RFR: JDK-8298448: UndefinedBehaviorSanitizer
Allow building OpenJDK with UBSan. Currently the build fails when optimizing the image due to lots of undefined behavior (it invokes the built JVM). Follow up PRs will either replace the undefined behavior with well defined behavior or suppress errors which are intentional. The goal is to make OpenJDK more well defined and thus more portable across compilers and architectures. - Commit messages: - Remove leftover debugging logic - Initial implementation of UBSan Changes: https://git.openjdk.org/jdk/pull/11604/files Webrev: https://webrevs.openjdk.org/?repo=jdk=11604=00 Issue: https://bugs.openjdk.org/browse/JDK-8298448 Stats: 54 lines in 4 files changed: 54 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/11604.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11604/head:pull/11604 PR: https://git.openjdk.org/jdk/pull/11604
[jdk20] RFR: 8298324: Unable to run shell test with make
The parsing of the TestID in the TEST parameter currently only handles tests that are .java files. Jtreg tests can also be .html and .sh files. This patch extends the macro to also handle these kinds of files. Without the patch, trying to run a shell test directly would fail like this: $ make test TEST=open/test/jdk/sun/security/tools/keytool/ListKeychainStore.sh Building target 'test' in configuration 'linux-x64' Test selection 'open/test/jdk/sun/security/tools/keytool/ListKeychainStore.sh', will run: * jtreg:open/test/jdk/sun/security/tools/keytool/ListKeychainStore.sh.sh Running test 'jtreg:open/test/jdk/sun/security/tools/keytool/ListKeychainStore.sh.sh' Error: Cannot find file: open/test/jdk/sun/security/tools/keytool/ListKeychainStore.sh.sh - Commit messages: - JDK-8298324 Changes: https://git.openjdk.org/jdk20/pull/5/files Webrev: https://webrevs.openjdk.org/?repo=jdk20=5=00 Issue: https://bugs.openjdk.org/browse/JDK-8298324 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk20/pull/5.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/5/head:pull/5 PR: https://git.openjdk.org/jdk20/pull/5
Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v5]
On Fri, 18 Nov 2022 11:27:14 GMT, Magnus Ihse Bursie wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Uh oh > > Aaaahhh, **that** bug. I've run into that before. I did attempt to fix it but > after wasting too many hours I gave up. :-( It seems to be a limitation in m4 > that I cannot understand how to get around. At some point, the string > literal, even though quoted inside the `[...]`, is expanded and parsed as m4 > macro expansion arguments. In theory, I should have been able to add an > additional layer of quoting and then un-quote it once it was past the > problematic point, but that did not work. > > I solved the problem by not solving it, and instead rephrased the message to > not need the comma. (Imho, this limitation actually improved the quality of > the descriptions, so it was not bad per se). > > But I agree that it is annoying to have such a limitation in > `UTIL_DEFUN_NAMED`. If you want to have a go at trying to solve it, please > do! I'll fully admit my shortcomings and state that trying to solve this > passes my knowledge and ability to manipulate m4. > > Or, maybe, you could add some documentation to `UTIL_DEFUN_NAMED` and > `UTIL_ARG_WITH`, saying that comma is not allowed in the values. @magicus is there something up with the Windows tests? They seem to suddenly not be able to handle the `build-user` option, while all other platforms don't have much of an issue. Weirder still is that both WSL and MSYS2 on my Windows device are both perfectly fine with the option, and are able to complete the configure step with no hassle whatsoever Failing tests: checking for --with-build-user... , default configure: Invalid value for --with-build-user: "" configure: --with-build-user cannot be empty WSL and MSYS on my end: checking for --with-build-user... vertig0, default checking for --with-jdk-rc-name... OpenJDK Platform, default checking for --with-vendor-name... N/A, default checking for --with-vendor-url... https://openjdk.org/, default checking for --with-vendor-bug-url... https://bugreport.java.com/bugreport/, default checking for --with-vendor-vm-bug-url... https://bugreport.java.com/bugreport/crash.jsp, default checking for --with-version-string... , default checking for --with-version-feature... 20, default checking for --with-version-date... 2023-03-21, default checking for --with-vendor-version-string... , default checking for --with-macosx-bundle-name-base... OpenJDK, default checking for --with-macosx-bundle-id-base... net.java.openjdk-internal, default checking for --with-macosx-bundle-build-version... 0, default checking for version string... 20-internal-adhoc.vertig0.jdk - PR: https://git.openjdk.org/jdk/pull/11020
Re: RFR: 8298050: Add links to graph output for javadoc
On Thu, 8 Dec 2022 16:22:30 GMT, Jonathan Gibbons wrote:
>> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 207:
>>
>>> 205: private static String relativeLink(TypeElement rootNode,
>>> TypeElement node) {
>>> 206: var backNavigator =
>>> rootNode.getQualifiedName().toString().chars()
>>> 207: .filter(c -> '.' == c)
>>
>> "Yoda conditions" are usually frowned upon. Can `c` be `null`?
>
> `c` is a character
`c` is an `int`, but even that does not matter. I read off `==` but somehow
pictured `equals` in my head; so, null-ness does not matter here at all. That
said, unnecessary "Yoda conditions" should probably be avoided.
-
PR: https://git.openjdk.org/jdk/pull/11580
Re: RFR: 8298050: Add links to graph output for javadoc
On Thu, 8 Dec 2022 09:19:54 GMT, Per Minborg wrote:
> This PR proposes adding hyperlinks to the sealed graphic layout making
> navigation much simpler via the image.
Given that this feature is welcome, I would suggest changing the priority of
the respective JBS issue to P3, withdrawing this PR and creating a new PR that
targets openjdk/jdk20 after it has been created (which should be within hours
from now).
make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 207:
> 205: private static String relativeLink(TypeElement rootNode,
> TypeElement node) {
> 206: var backNavigator =
> rootNode.getQualifiedName().toString().chars()
> 207: .filter(c -> '.' == c)
"Yoda conditions" are usually frowned upon. Can `c` be `null`?
-
PR: https://git.openjdk.org/jdk/pull/11580
Re: RFR: 8298050: Add links to graph output for javadoc
On Thu, 8 Dec 2022 09:19:54 GMT, Per Minborg wrote: > This PR proposes adding hyperlinks to the sealed graphic layout making > navigation much simpler via the image. make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 209: > 207: .filter(c -> '.' == c) > 208: .mapToObj(c -> "../") > 209: .collect(joining()); What about nested classes? - PR: https://git.openjdk.org/jdk/pull/11580
Integrated: JDK-8296149: Start of release updates for JDK 21
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote: > Usual start-of-release updates. Symbol updates in initial version reflect JDK > 20 build 21. This pull request has now been integrated. Changeset: 175e3d3f Author:Joe Darcy Committer: Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/175e3d3ff332be25cca9822c58c46f1e012953c2 Stats: 3726 lines in 70 files changed: 3672 ins; 1 del; 53 mod 8296149: Start of release updates for JDK 21 8296150: Add SourceVersion.RELEASE_21 8296151: Add source 21 and target 21 to javac Reviewed-by: dholmes, iris, erikj, vromero, jlahoda - PR: https://git.openjdk.org/jdk/pull/10924
Integrated: 8298383: JFR: GenerateJfrFiles.java lacks copyright header
On Thu, 8 Dec 2022 13:19:18 GMT, Erik Gahlin wrote: > Could I have a review of a PR that adds missing copyright header to > GenerateJfrFiles.java > > Testing: tier1 > > Thanks > Erik This pull request has now been integrated. Changeset: e555d547 Author:Erik Gahlin URL: https://git.openjdk.org/jdk/commit/e555d5470536b8379179879ec7343e004be95e36 Stats: 25 lines in 1 file changed: 25 ins; 0 del; 0 mod 8298383: JFR: GenerateJfrFiles.java lacks copyright header Reviewed-by: mgronlun, erikj - PR: https://git.openjdk.org/jdk/pull/11591
Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v14]
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out of the scope of this commit, which aims only to rework the > previous integrated commits mentioned above. Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Nope - Changes: - all: https://git.openjdk.org/jdk/pull/11020/files - new: https://git.openjdk.org/jdk/pull/11020/files/7f0fcebf..df029252 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11020=13 - incr: https://webrevs.openjdk.org/?repo=jdk=11020=12-13 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/11020.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11020/head:pull/11020 PR: https://git.openjdk.org/jdk/pull/11020
Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v13]
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out of the scope of this commit, which aims only to rework the > previous integrated commits mentioned above. Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Weird Configure Failures - Changes: - all: https://git.openjdk.org/jdk/pull/11020/files - new: https://git.openjdk.org/jdk/pull/11020/files/d7e26991..7f0fcebf Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11020=12 - incr: https://webrevs.openjdk.org/?repo=jdk=11020=11-12 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/11020.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11020/head:pull/11020 PR: https://git.openjdk.org/jdk/pull/11020
Re: RFR: 8298383: JFR: GenerateJfrFiles.java lacks copyright header [v2]
On Thu, 8 Dec 2022 13:50:14 GMT, Erik Gahlin wrote: >> Could I have a review of a PR that adds missing copyright header to >> GenerateJfrFiles.java >> >> Testing: tier1 >> >> Thanks >> Erik > > Erik Gahlin has updated the pull request incrementally with one additional > commit since the last revision: > > Update year Marked as reviewed by mgronlun (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11591
Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v8]
On Tue, 6 Dec 2022 19:32:27 GMT, Magnus Ihse Bursie wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> CHECK_VALUE > > make/autoconf/jdk-version.m4 line 571: > >> 569: DESC: [Set the MacOSX Bundle CFBundleVersion field. This key is a >> machine-readable >> 570: string composed of one to three period-separated integers and >> should represent the >> 571: build version. Defaults to the build number.], > > Please remove the text about the default from DESC, and add: > > DEFAULT_DESC: [the build number], Done, thanks - PR: https://git.openjdk.org/jdk/pull/11020
Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v12]
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out of the scope of this commit, which aims only to rework the > previous integrated commits mentioned above. Julian Waters has updated the pull request incrementally with one additional commit since the last revision: DESC - Changes: - all: https://git.openjdk.org/jdk/pull/11020/files - new: https://git.openjdk.org/jdk/pull/11020/files/4055adf3..d7e26991 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11020=11 - incr: https://webrevs.openjdk.org/?repo=jdk=11020=10-11 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11020.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11020/head:pull/11020 PR: https://git.openjdk.org/jdk/pull/11020
Re: RFR: 8298383: JFR: GenerateJfrFiles.java lacks copyright header [v2]
> Could I have a review of PR that adds missing copyright header to > GenerateJfrFiles.java > > Testing: tier1 > > Thanks > Erik Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Update year - Changes: - all: https://git.openjdk.org/jdk/pull/11591/files - new: https://git.openjdk.org/jdk/pull/11591/files/9ec1fa4e..85498689 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11591=01 - incr: https://webrevs.openjdk.org/?repo=jdk=11591=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11591.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11591/head:pull/11591 PR: https://git.openjdk.org/jdk/pull/11591
RFR: 8298383: JFR: GenerateJfrFiles.java lacks copyright header
Could I have a review of PR that adds missing copyright header to GenerateJfrFiles.java Testing: tier1 Thanks Erik - Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/11591/files Webrev: https://webrevs.openjdk.org/?repo=jdk=11591=00 Issue: https://bugs.openjdk.org/browse/JDK-8298383 Stats: 25 lines in 1 file changed: 25 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/11591.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11591/head:pull/11591 PR: https://git.openjdk.org/jdk/pull/11591
Integrated: 8298175: JFR: Common timestamp for periodic events
On Tue, 6 Dec 2022 15:31:22 GMT, Erik Gahlin wrote: > Could I have review of infrastructure that makes it easier to write periodic > events with the same timestamp. > > Testing: jdk/jdk/jfr + tier1 + tier2 > > Thanks > Erik This pull request has now been integrated. Changeset: 9353899b Author:Erik Gahlin URL: https://git.openjdk.org/jdk/commit/9353899bc5564827826ed94c0530497ff828e01b Stats: 48 lines in 6 files changed: 25 ins; 3 del; 20 mod 8298175: JFR: Common timestamp for periodic events Reviewed-by: dholmes, mgronlun - PR: https://git.openjdk.org/jdk/pull/11541
Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v11]
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out of the scope of this commit, which aims only to rework the > previous integrated commits mentioned above. Julian Waters has updated the pull request incrementally with five additional commits since the last revision: - make/autoconf/jdk-version.m4 Co-authored-by: Magnus Ihse Bursie - make/autoconf/jdk-version.m4 Co-authored-by: Magnus Ihse Bursie - make/autoconf/jdk-version.m4 Co-authored-by: Magnus Ihse Bursie - make/autoconf/jdk-version.m4 Co-authored-by: Magnus Ihse Bursie - make/autoconf/jdk-version.m4 Co-authored-by: Magnus Ihse Bursie - Changes: - all: https://git.openjdk.org/jdk/pull/11020/files - new: https://git.openjdk.org/jdk/pull/11020/files/9405b70d..4055adf3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11020=10 - incr: https://webrevs.openjdk.org/?repo=jdk=11020=09-10 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/11020.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11020/head:pull/11020 PR: https://git.openjdk.org/jdk/pull/11020
Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v10]
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out of the scope of this commit, which aims only to rework the > previous integrated commits mentioned above. Julian Waters has updated the pull request incrementally with two additional commits since the last revision: - make/autoconf/jdk-version.m4 Co-authored-by: Magnus Ihse Bursie - make/autoconf/jdk-version.m4 Co-authored-by: Magnus Ihse Bursie - Changes: - all: https://git.openjdk.org/jdk/pull/11020/files - new: https://git.openjdk.org/jdk/pull/11020/files/1cf37372..9405b70d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11020=09 - incr: https://webrevs.openjdk.org/?repo=jdk=11020=08-09 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/11020.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11020/head:pull/11020 PR: https://git.openjdk.org/jdk/pull/11020
RFR: 8298050: Add links to graph output for javadoc
This PR proposes adding hyperlinks to the sealed graphic layout making navigation much simpler via the image. - Commit messages: - Remove unused import - Add relative hyperlinks to nodes Changes: https://git.openjdk.org/jdk/pull/11580/files Webrev: https://webrevs.openjdk.org/?repo=jdk=11580=00 Issue: https://bugs.openjdk.org/browse/JDK-8298050 Stats: 20 lines in 1 file changed: 19 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11580.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11580/head:pull/11580 PR: https://git.openjdk.org/jdk/pull/11580
