On Fri, 18 Nov 2022 11:27:14 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Uh oh > > Aaaahhh, **that** bug. I've run into that before. I did attempt to fix it but > after wasting too many hours I gave up. :-( It seems to be a limitation in m4 > that I cannot understand how to get around. At some point, the string > literal, even though quoted inside the `[...]`, is expanded and parsed as m4 > macro expansion arguments. In theory, I should have been able to add an > additional layer of quoting and then un-quote it once it was past the > problematic point, but that did not work. > > I solved the problem by not solving it, and instead rephrased the message to > not need the comma. (Imho, this limitation actually improved the quality of > the descriptions, so it was not bad per se). > > But I agree that it is annoying to have such a limitation in > `UTIL_DEFUN_NAMED`. If you want to have a go at trying to solve it, please > do! I'll fully admit my shortcomings and state that trying to solve this > passes my knowledge and ability to manipulate m4. > > Or, maybe, you could add some documentation to `UTIL_DEFUN_NAMED` and > `UTIL_ARG_WITH`, saying that comma is not allowed in the values. @magicus is there something up with the Windows tests? They seem to suddenly not be able to handle the `build-user` option, while all other platforms don't have much of an issue. Weirder still is that both WSL and MSYS2 on my Windows device are both perfectly fine with the option, and are able to complete the configure step with no hassle whatsoever Failing tests: checking for --with-build-user... <none>, default configure: Invalid value for --with-build-user: "" configure: --with-build-user cannot be empty WSL and MSYS on my end: checking for --with-build-user... vertig0, default checking for --with-jdk-rc-name... OpenJDK Platform, default checking for --with-vendor-name... N/A, default checking for --with-vendor-url... https://openjdk.org/, default checking for --with-vendor-bug-url... https://bugreport.java.com/bugreport/, default checking for --with-vendor-vm-bug-url... https://bugreport.java.com/bugreport/crash.jsp, default checking for --with-version-string... <none>, default checking for --with-version-feature... 20, default checking for --with-version-date... 2023-03-21, default checking for --with-vendor-version-string... <disabled>, default checking for --with-macosx-bundle-name-base... OpenJDK, default checking for --with-macosx-bundle-id-base... net.java.openjdk-internal, default checking for --with-macosx-bundle-build-version... 0, default checking for version string... 20-internal-adhoc.vertig0.jdk ------------- PR: https://git.openjdk.org/jdk/pull/11020
