[chromium-dev] Re: Mozilla design challenge
On Wed, Jul 22, 2009 at 6:08 PM, Brian Rakowskibr...@chromium.org wrote: The most promising things I found from the design challenge were the history view in Favitabs n' Drawers (see attached image). The cool thing about it is that it shows how long the tabs were open. I find other history views that only show the time at which the page was loaded very unintuitive. I also still like the idea of to read tabs. The challenge is finding a simple gesture that would allow users to identify tabs or links that should go in the to read queue. I feel like this would dramatically cut down on the number of open tabs and also remove my fear of losing interesting pages that I wanted to get back to. There's a plugin for FF called Taboo that kinda does this. But I haven't found it hugely compelling - the experience needs to be a bit smoother. One thing that occurred to me just now is to be able to tick tabs as well as cross (i.e. close) them. A ticked tab would go onto some kind of temporary bookmark list when closed, so I could easily get it back. Unticking it would remove it (or maybe just getting it back would untick it). On Wed, Jul 22, 2009 at 9:54 AM, Linus Upson li...@google.com wrote: With a good heuristic, I think it will be very unlikely that we'll kill a renderer that has useful state. What are the chances that a tab on a site that I don't go to often, and that I opened 30 tabs ago has js/dom state that is critical for me? Mobile browsers already euthanize unused tabs aggressively. Since so few users have 20+ tabs open at once perhaps we can just reset their expectations for what happens if they accumulate a large number of tabs. Perhaps the heuristic could be tied to the mythical great overflow UI. For all of these heavy users I suspect they would prefer chrome to remain zippy fast with large tab sets rather than paging a renderer that 99.9% of the time doesn't have any interesting state. Linus On Tue, Jul 21, 2009 at 2:03 PM, Scott Hess sh...@chromium.org wrote: I don't think it's reasonable to require the user to specify which tabs to suspend, except, perhaps, if we develop a metric for power-hungry tabs and expose that. I think there is some potential for UI geared towards particular use-cases which could be overloaded to also allow more aggressive suspend. For instance, WRT my earlier posting, I would expect my pinned tabs to be given stronger priority, and my on-deck-to-read tabs to be treated more like preloaded/rendered bookmarks. There could be other UI advantages in there, like the on-deck tabs for a particular project could group under a single tab with other UI widgets to select which document within the group. -scott On Tue, Jul 21, 2009 at 1:50 PM, Ryosuke Niwarn...@google.com wrote: Is it possible to provide an intuitive UI that allows users to choose which tabs to be suspended? For example, just like users can click buttons on taskbar to pop up a particular window, we could provide a small window that pop-in tabs / windows. And then we can suspend all windows / tab that are popped into. Ryosuke On Tue, Jul 21, 2009 at 9:32 AM, Erik Kay erik...@chromium.org wrote: You may be on to something, but I think it's more complex than this. For example bookmark systems don't work because people use them for a number of conflicting purposes (my list of things to read every day, a simple history system, a 'to read' list, a collection of links for research), which have different UI requirements. I think the same thing has happened with tabs (and there's a surprising amount of overlap). Here are the use cases I know I wind up using: - a few long running apps that need to keep running, potentially notifying me of new events (calendar, mail, chat, buildbot, etc.) - a few pages that I'm currently actively using (a screenshot from a bug I'm looking at, some reference documentation, a writely page I'm editing between compiles, etc.) - a to read list of pages that I started reading but didn't finish yet (sometimes this is a collection of related pages when researching something) - I'm sure there are others. In my use case, 80% of my tabs could easily be killed / suspended (or even hidden altogether) without any downside to me. The problem is that there isn't a way to automatically figure out which ones are which. Which ones have pending state that might be lost? (yes, some of this is bad app design, but there are many like this) Which ones do I expect to keep running all of the time because of notifications? What about that flash game that I left running in the background? Maybe we could come up with some heuristics that could detect some of this automatically, but I worry that there will be so many exceptions that it won't work. That means we'd need to come up with a better UI to express these concepts where the user chose to treat tabs
[chromium-dev] Re: gcl upload can't support proxy
Python's urllib looks at the HTTP_PROXY environment variable. Try setting it before using gcl. Official doc: http://docs.python.org/library/urllib.html http://docs.python.org/library/urllib.htmlM-A On Thu, Jul 30, 2009 at 1:11 PM, Evan Martin e...@chromium.org wrote: The proxy suggestion already provided is your best bet. But if you can't make that work, I believe you can create reviews on codereview.chromium.org by uploading a patch file using your browser. On Thu, Jul 30, 2009 at 4:34 AM, empriserxueyunl...@gmail.com wrote: HI, All, I access internet through a http proxy, and the other protocol like https, ftp also use this http proxy. I found that I can't gcl upload when I under the proxy. Could you please help me ? Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: gyp scons generator temporary glitch
On Thu, Jul 30, 2009 at 18:52, Evan Martin e...@chromium.org wrote: For now you can pass the mode flag to make it work: hammer --mode=Debug This worked for me. Thanks. Easier than manually rolling back DEPS. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Question about chromium sandbox on Mac OSX
If you're just doing this for debugging purposes, an easier route would be to pass in the --no-sandbox flag to temporarily disable the sandbox entirely, documented here: http://sites.google.com/a/chromium.org/dev/developers/debugging-on-os-x On Thu, Jul 30, 2009 at 8:00 PM, n179911 n179...@gmail.com wrote: Thank you all. I have a better understanding now. I just try to log some debug info of the renderer in /tmp that may help me understand things better. Regards, On Thu, Jul 30, 2009 at 7:36 PM, Jeremy Moskovichjer...@chromium.org wrote: The easiest way would be to add a rule to renderer.sb, the language it uses is undocumented but very easy to use, you can find the file in the source tree. May I ask why you want the renderer to be able to read/write files in /tmp? Best regards, Jeremy On Thu, Jul 30, 2009 at 7:32 PM, n179911 n179...@gmail.com wrote: I would like to change it so that the renderer can create/write file on /tmp. Like this 'kSBXProfileNoWriteExceptTemporary' profile. On Thu, Jul 30, 2009 at 9:43 AM, Jeremy Moskovichjer...@chromium.org wrote: Is this just out of curiosity? Is there something specific you're trying to achieve? On Thu, Jul 30, 2009 at 9:32 AM, n179911 n179...@gmail.com wrote: On Thu, Jul 30, 2009 at 9:08 AM, Jeremy Moskovich jer...@chromium.org wrote: Hi, It would really help if you could provide some details on what your trying to do. Best regards, Jeremy From the http://dev.chromium.org/developers/design-documents/sandbox/osx-sandboxing-design It said In the renderer, we would probably want to use a combination of kSBXProfileNoNetwork and kSBXProfileNoWrite. If possible, we would like to get by with kSBXProfilePureComputation, I am trying to see what it the current setting in chromium. I can't find that in renderer.sb or when sandbox_init() is called. And then I would want to see if I can switch it to 'kSBXProfilePureComputation' and see what may break. Regards, On Thu, Jul 30, 2009 at 9:06 AM, n179911 n179...@gmail.com wrote: Thank you. Can you please tell me how can I change the configure file (renderer.sb) to use other sandbox profile, like the one described in man page: * kSBXProfileNoInternet * kSBXProfileNoNetwork * kSBXProfileNoWrite * kSBXProfileNoWriteExceptTemporary * kSBXProfilePureComputation And I did try looking for the sandbox configuration format, but this is the only thing I found, but it does not contain sandbox config file format http://developer.apple.com/DOCUMENTATION/DARWIN/Reference/ManPages/man3/sandbox_init.3.html On Thu, Jul 30, 2009 at 5:21 AM, Thomas Van Lententhoma...@chromium.org wrote: Those constants are pre-configured settings. The NAMED_EXTERNAL flag lets us pass in our own config, which is the renderer.sb. Apple hasn't really documented the file format, but if you do some searching on the web, you'll find some documentation folks have figured out and I believe there was a talk given at one point by some of the Apple folks that work on it. TVL On Thu, Jul 30, 2009 at 2:32 AM, n179911 n179...@gmail.com wrote: Hi, I read this article: http://dev.chromium.org/developers/design-documents/sandbox/osx-sandboxing-design It said Mac OSX supports five constants for sandbox access restrictions: * kSBXProfileNoInternet * kSBXProfileNoNetwork * kSBXProfileNoWrite * kSBXProfileNoWriteExceptTemporary * kSBXProfilePureComputation In the renderer, we would probably want to use a combination of kSBXProfileNoNetwork and kSBXProfileNoWrite. If possible, we would like to get by with kSBXProfilePureComputation, Can you please which access restrictions the renderer of chromium is currently set to? I have looked at renderer_main_platform_delegate_mac.mm, which I believe is how/where chromium set the access restrictions to. But from the code, i can't tell which access restrictions it assigns to renderer. int error = sandbox_init(sandbox_profile, SANDBOX_NAMED_EXTERNAL, error_buff); And I have looked at the file 'renderer.sb', it does not contains any of the above 5 access restrictions string either. Thank you for your help. Regards, --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Copy URL as plain text instead of HTML
Hi This is my first post in this group, so if there is more appropriate place to post a requests like this, please let me know. I often copy and past the browser URL or link URL's in documents or emails. IE copies the URL as plain text, and when pasting the URL in a document, the pasted text has not formatting, and correctly inherits the formatting of the document. When doing the same with Chrome, it pastes the the URL as formatted HTML, messing up the font and formatting of the document. To work around this, every time I paste in Outlook or Word, I have to select the paste special menu, and select paste as text. I can think of no particular reason why the URL or a link needs to be formatted in anything other than plain text. Can the URL and link copy code please be changed to not format the text? Thank you P. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
On Fri, Jul 31, 2009 at 10:28 AM, ptr727 pieter.vilj...@gmail.com wrote: I can think of no particular reason why the URL or a link needs to be formatted in anything other than plain text. Most people tend to prefer links to be formatted as links, so they can click them. Can the URL and link copy code please be changed to not format the text? I don't think that would serve our userbase well. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
Though, at least on Windows, that is what they (and the external application) are expecting, I mean, they expect the formatting not to change. Word, Outlook and rest are automatically turning the URL into a link if it is not already a link, anyway. GMail does not, true. But any other browser (I think) is not formatting it with HTML. ☆PhistucK On Fri, Jul 31, 2009 at 20:30, Peter Kasting pkast...@google.com wrote: On Fri, Jul 31, 2009 at 10:28 AM, ptr727 pieter.vilj...@gmail.com wrote: I can think of no particular reason why the URL or a link needs to be formatted in anything other than plain text. Most people tend to prefer links to be formatted as links, so they can click them. Can the URL and link copy code please be changed to not format the text? I don't think that would serve our userbase well. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
On Fri, Jul 31, 2009 at 10:41 AM, PhistucK phist...@gmail.com wrote: Though, at least on Windows, that is what they (and the external application) are expecting, I mean, they expect the formatting not to change. Word, Outlook and rest are automatically turning the URL into a link if it is not already a link, anyway. GMail does not, true. Gmail does when you send the mail, though. But any other browser (I think) is not formatting it with HTML. ☆PhistucK On Fri, Jul 31, 2009 at 20:30, Peter Kasting pkast...@google.com wrote: On Fri, Jul 31, 2009 at 10:28 AM, ptr727 pieter.vilj...@gmail.comwrote: I can think of no particular reason why the URL or a link needs to be formatted in anything other than plain text. Most people tend to prefer links to be formatted as links, so they can click them. Can the URL and link copy code please be changed to not format the text? I don't think that would serve our userbase well. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
Can you elaborate on how you're copying a URL from Chrome? Are you using Ctrl+C, the page menu item, or the context menu? When I use the context menu, I only get the plain text of the URL. In the other two cases, doesn't every browser paste as HTML? On Fri, Jul 31, 2009 at 10:28 AM, ptr727pieter.vilj...@gmail.com wrote: Hi This is my first post in this group, so if there is more appropriate place to post a requests like this, please let me know. I often copy and past the browser URL or link URL's in documents or emails. IE copies the URL as plain text, and when pasting the URL in a document, the pasted text has not formatting, and correctly inherits the formatting of the document. When doing the same with Chrome, it pastes the the URL as formatted HTML, messing up the font and formatting of the document. To work around this, every time I paste in Outlook or Word, I have to select the paste special menu, and select paste as text. I can think of no particular reason why the URL or a link needs to be formatted in anything other than plain text. Can the URL and link copy code please be changed to not format the text? Thank you P. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] PSA: Consider upgrading to VS2008.
A few changes are coming soon that mean using VS2008 is desirable: - /MP will be enabled by default for VS2008 debug builds, which will make your builds faster on newer multicore machines without you having to patch any files in your local tree. - We will eventually update the required SDK to the Windows 7 SDK. For this to work in VS2005 an additional hotfix is required. VS2005 will remain our base supported system however these benefits make upgrading to VS2008 desirable (especially if you are getting new hardware that needs everything to be set up on it anyway). -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: PSA: Consider upgrading to VS2008.
Are we planning to remove ATL so we can make Express people happy. We can do a project plan and figure out a timeline on how to remove ATL. It will make many people happy. -- Mohamed Mansour On Fri, Jul 31, 2009 at 2:01 PM, Ben Goodger (Google) b...@chromium.orgwrote: A few changes are coming soon that mean using VS2008 is desirable: - /MP will be enabled by default for VS2008 debug builds, which will make your builds faster on newer multicore machines without you having to patch any files in your local tree. - We will eventually update the required SDK to the Windows 7 SDK. For this to work in VS2005 an additional hotfix is required. VS2005 will remain our base supported system however these benefits make upgrading to VS2008 desirable (especially if you are getting new hardware that needs everything to be set up on it anyway). -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Topcrash on OSX - crbug.com/17555 - Renderer dies on WTF::HastSetWebCore::Page* ...
This is the top crash on OSX by far as of 3.0.196.0. From Dimitri's comment on the bug: It appears that somehow a message from BrowserRenderProcessHost catches the RenderProcess with its pants down, where WebView hasn't been created and the WebCore::Page constructor hasn't been called yet. Does this ring a bell for anyone? Best regards, Jeremy --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Topcrash on OSX - crbug.com/17555 - Renderer dies on WTF::HastSetWebCore::Page* ...
On Fri, Jul 31, 2009 at 11:42 AM, Jeremy Moskovich jer...@chromium.orgwrote: This is the top crash on OSX by far as of 3.0.196.0. From Dimitri's comment on the bug: It appears that somehow a message from BrowserRenderProcessHost catches the RenderProcess with its pants down, where WebView hasn't been created and the WebCore::Page constructor hasn't been called yet. Does this ring a bell for anyone? What do you mean by ring a bell? Do you know what the IPC message is? Do you guys know how to reproduce it? I believe I've hit this crash many times. If I open a tab and navigate somewhere too quickly (especially under system load) I can reliably crash the renderer. The one time I did this with the first tab I opened, every subsequent tab I opened went straight to the sad tab page. Some form or another of this has been happening for a while. J --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
As I was writing this and testing steps to replicate, I found that the HTML formatting did not always happen. I found the answer using the Windows ClipBook Viewer (it is only available on XP as clipbrd.exe, but works on Vista). When placing contents in the clipbook, the application that saves the information makes various versions of that information available. Copy something, then click the view menu to see all the available formats. E.g. when copying from text from a Word doc you will see Text, Unicode Text, Enhanced Metafile, Picture, Locale, OEM Text, DataObject, etc. E.g. when you copy the URL in IE, you will see Unicode Text, Locale, Text, and OEM Text. E.g. when you right click copy shortcut in IE, you will see Unicode Text, Locale, Text, and OEM Text, DataObject, FileContents, FileGropupDescriptorW, etc. E.g. when you copy the URL in FireFox, you will see Unicode Text, Text, Locale, OEM Text, DataObject, Ole Private Data. E.g. when you right click copy link location in FireFox, you will see Unicode Text, Text, Locale, OEM Text, DataObject, Ole Private Data. E.g. when you copy the URL in Chrome, you will see Unicode Text, Locale, Text, Locale, OEM Text, UniformResourceLocatorW, HTML Format. E.g. when you right click copy link address in Chrome, you will see Unicode Text, Locale, Text, OEM Text. When you paste in Outlook or Word, it defaults to HTML when available. If I create a new Outlook email or a new Word doc, and I paste the Chrome URL, it pastes fine because, I assume, there are no other HTML tags. If I am writing an email with formatting, or replying to an email, and I then paste the contents, the URL has a Times New Roman font instead of the font in the doc. To summarize, in Chrome copying the URL from the UI is not the same as right click copy link. Right click copy link works fine because it does not contain HTML formatted text. Copy from URL does contain HTML formatted text, and results in documents with weird formatting. If the UI URL copy can work the same as the right click copy link address, the problem can be solved. P. On Jul 31, 10:56 am, Tony Chang t...@chromium.org wrote: Can you elaborate on how you're copying a URL from Chrome? Are you using Ctrl+C, the page menu item, or the context menu? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: PSA: Consider upgrading to VS2008.
I would like to. It's just a matter of time and effort... and it's not been a top priority for me to date. Please feel free to gather requirements and develop a plan however. -Ben On Fri, Jul 31, 2009 at 11:11 AM, Mohamed Mansourm0.interact...@gmail.com wrote: Are we planning to remove ATL so we can make Express people happy. We can do a project plan and figure out a timeline on how to remove ATL. It will make many people happy. -- Mohamed Mansour On Fri, Jul 31, 2009 at 2:01 PM, Ben Goodger (Google) b...@chromium.org wrote: A few changes are coming soon that mean using VS2008 is desirable: - /MP will be enabled by default for VS2008 debug builds, which will make your builds faster on newer multicore machines without you having to patch any files in your local tree. - We will eventually update the required SDK to the Windows 7 SDK. For this to work in VS2005 an additional hotfix is required. VS2005 will remain our base supported system however these benefits make upgrading to VS2008 desirable (especially if you are getting new hardware that needs everything to be set up on it anyway). -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
On Fri, Jul 31, 2009 at 12:00 PM, ptr727 pieter.vilj...@gmail.com wrote: To summarize, in Chrome copying the URL from the UI is not the same as right click copy link. By copying the URL from the UI do you mean copying the URL from the Omnibox? Or copying from the webpage contents, using ctrl-c? Right click copy link works fine because it does not contain HTML formatted text. Does highlighting the link and copying do the same thing? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Topcrash on OSX - crbug.com/17555 - Renderer dies on WTF::HastSetWebCore::Page* ...
No, we don't have a repro, but what you mentioned sounds promising. Thanks, Jeremy On Fri, Jul 31, 2009 at 11:48 AM, Jeremy Orlow jor...@chromium.org wrote: On Fri, Jul 31, 2009 at 11:42 AM, Jeremy Moskovich jer...@chromium.orgwrote: This is the top crash on OSX by far as of 3.0.196.0. From Dimitri's comment on the bug: It appears that somehow a message from BrowserRenderProcessHost catches the RenderProcess with its pants down, where WebView hasn't been created and the WebCore::Page constructor hasn't been called yet. Does this ring a bell for anyone? What do you mean by ring a bell? Do you know what the IPC message is? Do you guys know how to reproduce it? I believe I've hit this crash many times. If I open a tab and navigate somewhere too quickly (especially under system load) I can reliably crash the renderer. The one time I did this with the first tab I opened, every subsequent tab I opened went straight to the sad tab page. Some form or another of this has been happening for a while. J --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
I have a feeling you are talking about the render view, and you should be asking these questions 'round webkit way -- Evan Stade On Fri, Jul 31, 2009 at 12:34 PM, Peter Kastingpkast...@google.com wrote: On Fri, Jul 31, 2009 at 12:00 PM, ptr727 pieter.vilj...@gmail.com wrote: To summarize, in Chrome copying the URL from the UI is not the same as right click copy link. By copying the URL from the UI do you mean copying the URL from the Omnibox? Or copying from the webpage contents, using ctrl-c? Right click copy link works fine because it does not contain HTML formatted text. Does highlighting the link and copying do the same thing? PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] `git pull` timeout
Hi, `git pull` times out for me: thakis-macbookpro:~/src/chrome-git/src thakis$ git pull git.chromium.org[0: 74.125.54.202]: errno=Operation timed out fatal: unable to connect a socket (Operation timed out) thakis-macbookpro:~/src/chrome-git/src thakis$ ping 74.125.54.202 PING 74.125.54.202 (74.125.54.202): 56 data bytes 64 bytes from 74.125.54.202: icmp_seq=0 ttl=246 time=62.565 ms Does someone have to restart some server? Thanks, Nico --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
I just happen to be looking at clipboard code for page contents.
Here's the code for writing a URL:
void WebClipboardImpl::writeURL(const WebURL url, const WebString title) {
ScopedClipboardWriterGlue scw(ClipboardGetClipboard());
scw.WriteBookmark(title, url.spec());
scw.WriteHTML(UTF8ToUTF16(URLToMarkup(url, title)), );
scw.WriteText(UTF8ToUTF16(url.spec()));
}
Notice how we write it as HTML here.
I'm not sure under what conditions we end up in that method though.
Selecting a link on a page and pressing control-c ends up here:
void WebClipboardImpl::writeHTML(
const WebString html_text, const WebURL source_url,
const WebString plain_text, bool write_smart_paste) {
ScopedClipboardWriterGlue scw(ClipboardGetClipboard());
scw.WriteHTML(html_text, source_url.spec());
scw.WriteText(plain_text);
if (write_smart_paste)
scw.WriteWebSmartPaste();
}
-Scott
On Fri, Jul 31, 2009 at 1:36 PM, Evan Stadeest...@chromium.org wrote:
I have a feeling you are talking about the render view, and you should
be asking these questions 'round webkit way
-- Evan Stade
On Fri, Jul 31, 2009 at 12:34 PM, Peter Kastingpkast...@google.com wrote:
On Fri, Jul 31, 2009 at 12:00 PM, ptr727 pieter.vilj...@gmail.com wrote:
To summarize, in Chrome copying the URL from the UI is not the same as
right click copy link.
By copying the URL from the UI do you mean copying the URL from the
Omnibox? Or copying from the webpage contents, using ctrl-c?
Right click copy link works fine because it does not contain HTML
formatted text.
Does highlighting the link and copying do the same thing?
PK
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] browser/sync is moving in
Hi!
A bunch of us have been working on a feature to sync user data in Chromium
with a Google account. (Surprise! :)) The great news is that we'll be
starting to work directly in the Chromium project this week, and let me tell
you, are we excited to do that! This email discusses how we're planning to
get started, in detail (maybe too much detail... sorry).
We have built a library that implements the client side of our sync
protocolhttp://sites.google.com/a/chromium.org/dev/developers/design-documents/sync,
as well as the Google server-side infrastructure to serve Google Chrome
users and synchronize data to their Google Account. Of course, all the code
going into Chromium is open source, and the messages between the client and
server use the open protobuf http://code.google.com/p/protobuf/ format and
library. Check out the sync developer
pagehttp://sites.google.com/a/chromium.org/dev/developers/design-documents/sync
if
you're interested in low-level goals and technical details.
We will be landing this code in a few steps rather than one giant changelist
for a number of reasons. First, this makes reviewing a *lot* easier; it
isn't the most straightforward code by nature, so the more fine grained
scrutiny the code gets, the better. Second, we've been working in a
proprietary environment until now because of the dependency of having to
build the complementary Google production server environment for syncing.
As such, the code uses a small number of internal libraries that we need to
open-source or replace, as well as libraries that would be redundant to what
Chromium already includes. Removing these, and open sourcing the entire
sync engine, is our highest priority and we expect this to take about three
weeks.
So how will we commit the code in pieces and not totally hose the build in
the process? First, a little more background. You may have come across the
CHROME_PERSONALIZATION #define when digging through Chromium source code.
Right now, this is used in conjunction with a relatively small number of
private c++ source files to conditionally build Chromium with sync enabled.
These files are in fact a glue layer between Chromium and what is called
the syncapi, which is the bulk of the client library I was talking about
above. On windows, syncapi is built into a DLL, and when
CHROME_PERSONALIZATION is defined this DLL gets placed alongside chrome.dll
for use at runtime. Syncapi builds and runs on Linux, but not Mac (yet).
With the initial checkin, we will leave the CHROME_PERSONALIZATION #define
as-is, so the sync code will not be built by default. We'll be working hard
over the coming weeks to make sure the code passes all existing test suites
that are part of the regular buildbot cycle, and on removing the #define.
After that, our hope is that we will be free of the DLL altogether and have
all the code checked in to the repository, fully functional or not, in a few
weeks. We do *not* plan on ever checking in the windows-only syncapi dll to
the main chromium repository. So until the dll is no longer needed, the
public repository won't have all the bits to actually build Chromium with
sync enabled. That said, we want to keep the sync build running smoothly,
so we will use a combination of command-line flag (to enable sync) and
delay-loading syncapi.dll only when it is needed. This will allow the
glue code to compile as part of the normal Chromium build without
introducing a dependency on this dll, yet still make it possible to run with
the dll present.
On that note, we're planning to use the syncapi DLL to produce a
sync-enabled Google Chrome build for dev-channel users in a week or so, to
get the feature into experimentally inclined hands. We have a great deal of
infrastructure, both in the browser and in the form of production Google
services, that need to start seeing real user traffic and usage. It takes a
great deal of testing and confidence inspired by real usage statistics
before any complex system like this can be deemed adequate for use by a
large user base. So if we want to let all Google Chrome users use sync (and
we do! we do!), we've got to get started on this pronto.
Our developer
pagehttp://sites.google.com/a/chromium.org/dev/developers/design-documents/sync
also
covers the hierarchy of files we're landing that you can expect to start
syncing (in the gclient sense) down in the next couple of days. We can't
wait (*really*) to work on this with the rest of the Chromium community and
going even further in creating the best browzr ever!
Thanks for reading, and happy syncing!
- the cloudy bunch
{idana, nick, nickbaum, chee, munjal, brg, chron, zork, laforge, tejasshah,
tim} at chromium.org
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
This is kind of off topic, but should we consider adding a
copy/cut-as-plain-text keyboard shortcut (ctrl+shift+c/x). That would be
nicely symmetrical with ctrl+shift+v for paste-as-plain-text.
Ojan
On Fri, Jul 31, 2009 at 4:57 PM, Scott Violet s...@chromium.org wrote:
I just happen to be looking at clipboard code for page contents.
Here's the code for writing a URL:
void WebClipboardImpl::writeURL(const WebURL url, const WebString title)
{
ScopedClipboardWriterGlue scw(ClipboardGetClipboard());
scw.WriteBookmark(title, url.spec());
scw.WriteHTML(UTF8ToUTF16(URLToMarkup(url, title)), );
scw.WriteText(UTF8ToUTF16(url.spec()));
}
Notice how we write it as HTML here.
I'm not sure under what conditions we end up in that method though.
Selecting a link on a page and pressing control-c ends up here:
void WebClipboardImpl::writeHTML(
const WebString html_text, const WebURL source_url,
const WebString plain_text, bool write_smart_paste) {
ScopedClipboardWriterGlue scw(ClipboardGetClipboard());
scw.WriteHTML(html_text, source_url.spec());
scw.WriteText(plain_text);
if (write_smart_paste)
scw.WriteWebSmartPaste();
}
-Scott
On Fri, Jul 31, 2009 at 1:36 PM, Evan Stadeest...@chromium.org wrote:
I have a feeling you are talking about the render view, and you should
be asking these questions 'round webkit way
-- Evan Stade
On Fri, Jul 31, 2009 at 12:34 PM, Peter Kastingpkast...@google.com
wrote:
On Fri, Jul 31, 2009 at 12:00 PM, ptr727 pieter.vilj...@gmail.com
wrote:
To summarize, in Chrome copying the URL from the UI is not the same as
right click copy link.
By copying the URL from the UI do you mean copying the URL from the
Omnibox? Or copying from the webpage contents, using ctrl-c?
Right click copy link works fine because it does not contain HTML
formatted text.
Does highlighting the link and copying do the same thing?
PK
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: `git pull` timeout
See the note on the page about if you're within the Google corporate network. (I should probably amend that for the public: it's just a routing issue related to how git.chromium.org lives in a DMZ.) On Fri, Jul 31, 2009 at 1:49 PM, Nico Webertha...@chromium.org wrote: Hi, `git pull` times out for me: thakis-macbookpro:~/src/chrome-git/src thakis$ git pull git.chromium.org[0: 74.125.54.202]: errno=Operation timed out fatal: unable to connect a socket (Operation timed out) thakis-macbookpro:~/src/chrome-git/src thakis$ ping 74.125.54.202 PING 74.125.54.202 (74.125.54.202): 56 data bytes 64 bytes from 74.125.54.202: icmp_seq=0 ttl=246 time=62.565 ms Does someone have to restart some server? Thanks, Nico --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: `git pull` timeout
On Fri, Jul 31, 2009 at 2:14 PM, Evan Martine...@chromium.org wrote: See the note on the page about if you're within the Google corporate network. the page = http://code.google.com/p/chromium/wiki/UsingGit (I should probably amend that for the public: it's just a routing issue related to how git.chromium.org lives in a DMZ.) On Fri, Jul 31, 2009 at 1:49 PM, Nico Webertha...@chromium.org wrote: Hi, `git pull` times out for me: thakis-macbookpro:~/src/chrome-git/src thakis$ git pull git.chromium.org[0: 74.125.54.202]: errno=Operation timed out fatal: unable to connect a socket (Operation timed out) thakis-macbookpro:~/src/chrome-git/src thakis$ ping 74.125.54.202 PING 74.125.54.202 (74.125.54.202): 56 data bytes 64 bytes from 74.125.54.202: icmp_seq=0 ttl=246 time=62.565 ms Does someone have to restart some server? Thanks, Nico --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: browser/sync is moving in
On Fri, Jul 31, 2009 at 2:07 PM, Tim Steele t...@chromium.org wrote: Check out the sync developer pagehttp://sites.google.com/a/chromium.org/dev/developers/design-documents/sync if you're interested in low-level goals and technical details. Since I suspect it will be a FAQ: According to that webpage, this currently only syncs bookmarks. More data types may come some day. (Personally, I hope they do. I'm more interested in history/visited link/omnibox syncing than bookmarks.) PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: `git pull` timeout
That fixed it, thanks. On Fri, Jul 31, 2009 at 2:14 PM, Evan Martine...@chromium.org wrote: On Fri, Jul 31, 2009 at 2:14 PM, Evan Martine...@chromium.org wrote: See the note on the page about if you're within the Google corporate network. the page = http://code.google.com/p/chromium/wiki/UsingGit (I should probably amend that for the public: it's just a routing issue related to how git.chromium.org lives in a DMZ.) On Fri, Jul 31, 2009 at 1:49 PM, Nico Webertha...@chromium.org wrote: Hi, `git pull` times out for me: thakis-macbookpro:~/src/chrome-git/src thakis$ git pull git.chromium.org[0: 74.125.54.202]: errno=Operation timed out fatal: unable to connect a socket (Operation timed out) thakis-macbookpro:~/src/chrome-git/src thakis$ ping 74.125.54.202 PING 74.125.54.202 (74.125.54.202): 56 data bytes 64 bytes from 74.125.54.202: icmp_seq=0 ttl=246 time=62.565 ms Does someone have to restart some server? Thanks, Nico --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: browser/sync is moving in
So we are going to tie up Chromium sync to just Google Services? Why not make the protocol open so any service could use it. So if anyone wants to sync, they will install an extension to do so, instead of coupling it directly to Google services. -- Mohamed Mansour On Fri, Jul 31, 2009 at 5:14 PM, Peter Kasting pkast...@google.com wrote: On Fri, Jul 31, 2009 at 2:07 PM, Tim Steele t...@chromium.org wrote: Check out the sync developer pagehttp://sites.google.com/a/chromium.org/dev/developers/design-documents/sync if you're interested in low-level goals and technical details. Since I suspect it will be a FAQ: According to that webpage, this currently only syncs bookmarks. More data types may come some day. (Personally, I hope they do. I'm more interested in history/visited link/omnibox syncing than bookmarks.) PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: browser/sync is moving in
On Fri, Jul 31, 2009 at 3:04 PM, Mohamed Mansour m...@chromium.org wrote: So we are going to tie up Chromium sync to just Google Services? Why not make the protocol open so any service could use it. The protocol _is_ open. Protobufs are open source and the sync spec built on them is also open source. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: browser/sync is moving in
Awesome! Many people will like this. -- Mohamed Mansour On Fri, Jul 31, 2009 at 6:08 PM, Tim Steele t...@chromium.org wrote: Yep, what Peter said. In the coming weeks, we will check in the full protocol definition itself, which is what we used to build the Google service for Google Chrome users. On Fri, Jul 31, 2009 at 3:05 PM, Peter Kasting pkast...@google.comwrote: On Fri, Jul 31, 2009 at 3:04 PM, Mohamed Mansour m...@chromium.orgwrote: So we are going to tie up Chromium sync to just Google Services? Why not make the protocol open so any service could use it. The protocol _is_ open. Protobufs are open source and the sync spec built on them is also open source. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: browser/sync is moving in
On Fri, Jul 31, 2009 at 3:59 PM, Caleb Eggensperger caleb...@gmail.comwrote: The doc says: - Provide a web interface to access stored / synced bookmarks, likely via the docs.google.com doclist. What about google.com/bookmarks? Shouldn't be difficult -- toolbar syncs to there currently. It's more difficult than you'd think. Chrome's different data model, among other things, make it a lot like the square peg in a round hole problem. But it's something we're looking into. For the first release, we've just focused on getting sync to work between Chrome instances. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] How do I filter CC'd code reviews in Gmail?
I added myself to some watchlists and I get a bunch of email about a lot of reviews But this has confused my Gmail filters, which automatic ally label and archive code reviews not addressed directly to me, and all of my CCd code reviews show up in my inbox. Anybody know how to reliably detect the difference between I'm the reviewer and I'm CC'd on a review in a Gmail filter? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
By copying the URL from the UI do you mean copying the URL from the Omnibox? Or copying from the webpage contents, using ctrl-c? The edit box where you type the URL. Click in it with the mouse (give it focus), press Ctrl-A (select all), press Ctrl-C (copy). This results in the clipboard having HTML content instead of just text. P. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] my patch fails compile on try servers because png file isn't updated?
My patch http://codereview.chromium.org/159728 keeps failing to compilehttp://build.chromium.org/buildbot/try-server/builders/win/builds/12301/steps/compile/logs/stdio on the try servers because the updatehttp://build.chromium.org/buildbot/try-server/builders/win/builds/12301/steps/gclient/logs/stdio step refuses to patch-in some .png files from the patch. I looked around and saw similar things happening to other folks on earlier reviews with .png files... Is this expected? Is there a way around it? Am I doing something wrong? ThanksTim --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: my patch fails compile on try servers because png file isn't updated?
I believe the tryserver doesn't take binaries.-BradN On Fri, Jul 31, 2009 at 5:40 PM, Tim Steele t...@chromium.org wrote: My patch http://codereview.chromium.org/159728 keeps failing to compilehttp://build.chromium.org/buildbot/try-server/builders/win/builds/12301/steps/compile/logs/stdio on the try servers because the updatehttp://build.chromium.org/buildbot/try-server/builders/win/builds/12301/steps/gclient/logs/stdio step refuses to patch-in some .png files from the patch. I looked around and saw similar things happening to other folks on earlier reviews with .png files... Is this expected? Is there a way around it? Am I doing something wrong? ThanksTim --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?
I would be interested in knowing this too. I think I'm going to create a second email address (e.g. ben-cc) to handle CC'ed reviews. -Ben On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilsonbre...@chromium.org wrote: I added myself to some watchlists and I get a bunch of email about a lot of reviews But this has confused my Gmail filters, which automatic ally label and archive code reviews not addressed directly to me, and all of my CCd code reviews show up in my inbox. Anybody know how to reliably detect the difference between I'm the reviewer and I'm CC'd on a review in a Gmail filter? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?
I thought to:user and -cc:user would work in this case? Have you tried using that in Has the words on Filter edit screen? On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson bre...@chromium.org wrote: I added myself to some watchlists and I get a bunch of email about a lot of reviews But this has confused my Gmail filters, which automatic ally label and archive code reviews not addressed directly to me, and all of my CCd code reviews show up in my inbox. Anybody know how to reliably detect the difference between I'm the reviewer and I'm CC'd on a review in a Gmail filter? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: my patch fails compile on try servers because png file isn't updated?
The patch file doesn't include binary content. If it's just pngs, I normally just check in the new files in a separate change before doing the code change. On Fri, Jul 31, 2009 at 5:41 PM, Bradley Nelsonbradnel...@google.com wrote: I believe the tryserver doesn't take binaries. -BradN On Fri, Jul 31, 2009 at 5:40 PM, Tim Steele t...@chromium.org wrote: My patch keeps failing to compile on the try servers because the update step refuses to patch-in some .png files from the patch. I looked around and saw similar things happening to other folks on earlier reviews with .png files... Is this expected? Is there a way around it? Am I doing something wrong? Thanks Tim --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Temporarily disable tcmalloc in build
What are the results of this experiment? On Jul 30, 12:15 pm, Huan Ren hu...@chromium.org wrote: I just submitted a change (22080) that disables tcmalloc used on Windows platform. The plan is keeping it in trunk for 24 hours and then reverting it. The intentions are - Having another round of performance comparison between build with and w/o tcmalloc. - Having a full run of UI test under purify with tcmalloc disabled. - Getting a verified CL in case we'd like to build an alternative dev build w/o tcmalloc for A/B test. As a head up, the performance, stability, and purify test results could be different during the period. Huan --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
Ah, I am eating my words. So you don't like the targets/flavors/formats we write to when copying from the omnibox, correct? If you plan to create a patch to change this, here would be the place to discuss the technical details. If you are simply requesting a change, you might be better served filing a bug at crbug.com. Personally I agree that it seems wrong to write the data as html when copying out of the omnibox, but I don't know the various formats that Windows programs expect well enough to say for sure. On Linux I think the right targets would be plain text and maybe uri list. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Copy URL as plain text instead of HTML
I already filed a bug for this: http://code.google.com/p/chromium/issues/detail?id=18194 On Fri, Jul 31, 2009 at 7:06 PM, Evan Stadeest...@chromium.org wrote: Ah, I am eating my words. So you don't like the targets/flavors/formats we write to when copying from the omnibox, correct? If you plan to create a patch to change this, here would be the place to discuss the technical details. If you are simply requesting a change, you might be better served filing a bug at crbug.com. Personally I agree that it seems wrong to write the data as html when copying out of the omnibox, but I don't know the various formats that Windows programs expect well enough to say for sure. On Linux I think the right targets would be plain text and maybe uri list. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?
I thought all those cc's from code reviews, is about the last couple of people who edited that part of the code in the past. I have been getting a couple of code reviews cc's and the code I was cc'd is what I have touched within a month or so. I could imagine Ben receiving a ton of reviews, he touched almost all browser code base. -- Mohamed Mansour On Fri, Jul 31, 2009 at 8:44 PM, Rahul Kuchhal kuch...@chromium.org wrote: I thought to:user and -cc:user would work in this case? Have you tried using that in Has the words on Filter edit screen? On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson bre...@chromium.org wrote: I added myself to some watchlists and I get a bunch of email about a lot of reviews But this has confused my Gmail filters, which automatic ally label and archive code reviews not addressed directly to me, and all of my CCd code reviews show up in my inbox. Anybody know how to reliably detect the difference between I'm the reviewer and I'm CC'd on a review in a Gmail filter? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do I filter CC'd code reviews in Gmail?
I get a lot of mail since I set up a watchlist filter on browser/. -Ben On Fri, Jul 31, 2009 at 7:28 PM, Mohamed Mansourm0.interact...@gmail.com wrote: I thought all those cc's from code reviews, is about the last couple of people who edited that part of the code in the past. I have been getting a couple of code reviews cc's and the code I was cc'd is what I have touched within a month or so. I could imagine Ben receiving a ton of reviews, he touched almost all browser code base. -- Mohamed Mansour On Fri, Jul 31, 2009 at 8:44 PM, Rahul Kuchhal kuch...@chromium.org wrote: I thought to:user and -cc:user would work in this case? Have you tried using that in Has the words on Filter edit screen? On Fri, Jul 31, 2009 at 5:18 PM, Brett Wilson bre...@chromium.org wrote: I added myself to some watchlists and I get a bunch of email about a lot of reviews But this has confused my Gmail filters, which automatic ally label and archive code reviews not addressed directly to me, and all of my CCd code reviews show up in my inbox. Anybody know how to reliably detect the difference between I'm the reviewer and I'm CC'd on a review in a Gmail filter? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
