Re: [chromium-dev] layout-test outputs and spell-checker
Hi Jeremy, et al, Sorry for my super-slow update. To investigate this issue deeply, this problem may be caused by font-smoothing since I can get the correct output when I execute 'defaults -currentHost write -g AppleFontSmoothing -int 0' on my mac book and disable font-smoothing. (I usually set this value to 2 "medium - best for plat panel".) If I recall correctly, test_shell used to call SetDefaultsToLayoutTestValues() via DefTestShellPlatformDelegate::SelectUnifiedTheme() to disable the font-smoothing while layout tests as WebKit DumpRenderTree does. Nevertheless, the current test_shell doesn't seems to call the function any longer. So, I'm wondering whether or not this is an intentional change. (It may be a good idea to keep disabling such tests and send the review request for this change.) Best regards, Hironori Bono E-mail: hb...@chromium.org 2009/12/17 Hironori Bono (坊野 博典) : > Hi Jeremy, > > Thank you for your quick response. > To check the source of the expected image, I notice it comes from the > WebKit tree (i.e. > "third_party/WebKit/LayoutTests/platform/mac/editing/selection/unrendered-002-expected.png"). > So, I would like to run WebKit layout tests, see its output images, > and investigate the font used by WebKit layout test. > By the way, I'm using Leopard (10.5.8 Build 9L31a) but its locale is > Japanese. :) > > Regards, > > Hironori Bono > E-mail: hb...@chromium.org > > 2009/12/16 Jeremy Moskovich : >> Hi Horonori, >> Thanks for taking a look at this!! >> What kinds of differences are you seeing without the new spellchecker class? >> The only notable difference seems to be that the fonts are slightly >> different vs. the expected output. >> Where is the expected output coming from? What OS version are you running >> this on? >> btw. The scrollbar diffs are to expected as we draw scrollbars differently >> in Chrome than Safari does. >> Best regards, >> Jeremy >> 2009/12/16 Hironori Bono (坊野 博典) >>> >>> Greetings chromium-developers, >>> >>> Sorry for my beginner's question in advance. >>> To fix a long-lasting issues: Issue 11577 (*1) and Issue 23497 (*2), I >>> have implemented a MockSpellcheck class (*3), which is a mock >>> implementation of our spell-checker used for layout tests. Even though >>> this change can fix most layout-test failures listed in Issue 23497, >>> there are a layout test that fails on an unknown reason, >>> "editing/selection/unrendered-002.html". >>> To run such tests on my Mac, our test_shell outputs very similar >>> images as the expected one but actually different ones as shown in the >>> attached pictures. Would it be possible to give me your thoughts about >>> why our test_shell cannot create the expected image for this case? >>> >>> (*1) http://crbug.com/11577 >>> (*2) http://crbug.com/23497 >>> (*3) http://codereview.chromium.org/493003/show >>> >>> Best regards, >>> >>> Hironori Bono >>> E-mail: hb...@chromium.org >>> >>> -- >>> Chromium Developers mailing list: chromium-dev@googlegroups.com >>> View archives, change email options, or unsubscribe: >>>http://groups.google.com/group/chromium-dev >> > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] layout-test outputs and spell-checker
Hi Jeremy, Thank you for your quick response. To check the source of the expected image, I notice it comes from the WebKit tree (i.e. "third_party/WebKit/LayoutTests/platform/mac/editing/selection/unrendered-002-expected.png"). So, I would like to run WebKit layout tests, see its output images, and investigate the font used by WebKit layout test. By the way, I'm using Leopard (10.5.8 Build 9L31a) but its locale is Japanese. :) Regards, Hironori Bono E-mail: hb...@chromium.org 2009/12/16 Jeremy Moskovich : > Hi Horonori, > Thanks for taking a look at this!! > What kinds of differences are you seeing without the new spellchecker class? > The only notable difference seems to be that the fonts are slightly > different vs. the expected output. > Where is the expected output coming from? What OS version are you running > this on? > btw. The scrollbar diffs are to expected as we draw scrollbars differently > in Chrome than Safari does. > Best regards, > Jeremy > 2009/12/16 Hironori Bono (坊野 博典) >> >> Greetings chromium-developers, >> >> Sorry for my beginner's question in advance. >> To fix a long-lasting issues: Issue 11577 (*1) and Issue 23497 (*2), I >> have implemented a MockSpellcheck class (*3), which is a mock >> implementation of our spell-checker used for layout tests. Even though >> this change can fix most layout-test failures listed in Issue 23497, >> there are a layout test that fails on an unknown reason, >> "editing/selection/unrendered-002.html". >> To run such tests on my Mac, our test_shell outputs very similar >> images as the expected one but actually different ones as shown in the >> attached pictures. Would it be possible to give me your thoughts about >> why our test_shell cannot create the expected image for this case? >> >> (*1) http://crbug.com/11577 >> (*2) http://crbug.com/23497 >> (*3) http://codereview.chromium.org/493003/show >> >> Best regards, >> >> Hironori Bono >> E-mail: hb...@chromium.org >> >> -- >> Chromium Developers mailing list: chromium-dev@googlegroups.com >> View archives, change email options, or unsubscribe: >>http://groups.google.com/group/chromium-dev > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] layout-test outputs and spell-checker
On Wed, Dec 16, 2009 at 4:25 AM, Jeremy Moskovich wrote: > Hi Horonori, > > Thanks for taking a look at this!! > > What kinds of differences are you seeing without the new spellchecker > class? > > The only notable difference seems to be that the fonts are slightly > different vs. the expected output. > The fonts appear bolded in this case (to me). > > Where is the expected output coming from? What OS version are you running > this on? > > btw. The scrollbar diffs are to expected as we draw scrollbars differently > in Chrome than Safari does. > > Best regards, > Jeremy > > 2009/12/16 Hironori Bono (坊野 博典) > > Greetings chromium-developers, >> >> Sorry for my beginner's question in advance. >> To fix a long-lasting issues: Issue 11577 (*1) and Issue 23497 (*2), I >> have implemented a MockSpellcheck class (*3), which is a mock >> implementation of our spell-checker used for layout tests. Even though >> this change can fix most layout-test failures listed in Issue 23497, >> there are a layout test that fails on an unknown reason, >> "editing/selection/unrendered-002.html". >> To run such tests on my Mac, our test_shell outputs very similar >> images as the expected one but actually different ones as shown in the >> attached pictures. Would it be possible to give me your thoughts about >> why our test_shell cannot create the expected image for this case? >> >> (*1) http://crbug.com/11577 >> (*2) http://crbug.com/23497 >> (*3) http://codereview.chromium.org/493003/show >> >> Best regards, >> >> Hironori Bono >> E-mail: hb...@chromium.org >> >> -- >> Chromium Developers mailing list: chromium-dev@googlegroups.com >> View archives, change email options, or unsubscribe: >>http://groups.google.com/group/chromium-dev > > > -- > Chromium Developers mailing list: chromium-dev@googlegroups.com > View archives, change email options, or unsubscribe: > http://groups.google.com/group/chromium-dev > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] layout-test outputs and spell-checker
Hi Horonori, Thanks for taking a look at this!! What kinds of differences are you seeing without the new spellchecker class? The only notable difference seems to be that the fonts are slightly different vs. the expected output. Where is the expected output coming from? What OS version are you running this on? btw. The scrollbar diffs are to expected as we draw scrollbars differently in Chrome than Safari does. Best regards, Jeremy 2009/12/16 Hironori Bono (坊野 博典) > Greetings chromium-developers, > > Sorry for my beginner's question in advance. > To fix a long-lasting issues: Issue 11577 (*1) and Issue 23497 (*2), I > have implemented a MockSpellcheck class (*3), which is a mock > implementation of our spell-checker used for layout tests. Even though > this change can fix most layout-test failures listed in Issue 23497, > there are a layout test that fails on an unknown reason, > "editing/selection/unrendered-002.html". > To run such tests on my Mac, our test_shell outputs very similar > images as the expected one but actually different ones as shown in the > attached pictures. Would it be possible to give me your thoughts about > why our test_shell cannot create the expected image for this case? > > (*1) http://crbug.com/11577 > (*2) http://crbug.com/23497 > (*3) http://codereview.chromium.org/493003/show > > Best regards, > > Hironori Bono > E-mail: hb...@chromium.org > > -- > Chromium Developers mailing list: chromium-dev@googlegroups.com > View archives, change email options, or unsubscribe: >http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] layout-test outputs and spell-checker
Greetings chromium-developers, Sorry for my beginner's question in advance. To fix a long-lasting issues: Issue 11577 (*1) and Issue 23497 (*2), I have implemented a MockSpellcheck class (*3), which is a mock implementation of our spell-checker used for layout tests. Even though this change can fix most layout-test failures listed in Issue 23497, there are a layout test that fails on an unknown reason, "editing/selection/unrendered-002.html". To run such tests on my Mac, our test_shell outputs very similar images as the expected one but actually different ones as shown in the attached pictures. Would it be possible to give me your thoughts about why our test_shell cannot create the expected image for this case? (*1) http://crbug.com/11577 (*2) http://crbug.com/23497 (*3) http://codereview.chromium.org/493003/show Best regards, Hironori Bono E-mail: hb...@chromium.org -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev<><><>
