Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v4]
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > javadoc fix Marked as reviewed by aivanov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2136431285
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v4]
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > javadoc fix Marked as reviewed by prr (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2136363950
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v4]
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > javadoc fix Marked as reviewed by kcr (Author). - PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2136280195
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v4]
> The no-arg constructor BasicSliderUI() was added under > [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This > constructor should be deprecated for removal in future release Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: javadoc fix - Changes: - all: https://git.openjdk.org/jdk/pull/19819/files - new: https://git.openjdk.org/jdk/pull/19819/files/40312082..6844be05 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19819=03 - incr: https://webrevs.openjdk.org/?repo=jdk=19819=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/19819.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19819/head:pull/19819 PR: https://git.openjdk.org/jdk/pull/19819
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v3]
On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added why
Changes requested by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
154:
> 152: * Constructs a {@code BasicSliderUI}.
> 153: * @deprecated This constructor was exposed erroneously and will be
> removed in next version.
> 154: * Use {@link #BasicSliderUI(JSlider b)} instead.
Suggestion:
* @deprecated This constructor was exposed erroneously and will be removed
in a future release.
* Use {@link #BasicSliderUI(JSlider)} instead.
I agree, _“in a future release”_ or _“version”_ would be more accurate.
I verified that it builds with the parameter name, however, it's more common to
omit parameter names.
-
PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2135839371
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1651053840
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v3]
On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added why
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
154:
> 152: * Constructs a {@code BasicSliderUI}.
> 153: * @deprecated This constructor was exposed erroneously and will be
> removed in next version.
> 154: * Use {@link #BasicSliderUI(JSlider b)} instead.
Did you build the docs and check that the `@link` command works? I would have
expected it without the named parameter: `{@link #BasicSliderUI(JSlider)}`.
Also, you might want to change "next version" to "a future version" to allow
more flexibility as to the timing of the removal.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1650968421
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 18:49:08 GMT, Kevin Rushforth wrote:
>> Or:
>>
>>
>> * @deprecated This constructor will be removed in a future release.
>> * Use {@link #BasicSliderUI(JSlider b)} instead.
>>
>> This is in the gist of the deprecation message for
>> [`SecurityManager`](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/lang/SecurityManager.html).
>
> FWIW, we did something similar to this in JavaFX when we deprecated for
> removal an accidentally added constructor (an implicit no-arg constructor in
> our case).
>
> https://github.com/openjdk/jfx/commit/a5ecfb68
>
>
> * @deprecated This constructor was exposed erroneously and will be
> removed in the next version.
> * Use {@link #createSelector(String)} instead.
>
>
> If you decide it's worth doing, you might also include a pointer to the other
> constructor, although since there only is one more, it is pretty obvious for
> this class.
OK...Updated...
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1650381797
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v3]
> The no-arg constructor BasicSliderUI() was added under > [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This > constructor should be deprecated for removal in future release Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Added why - Changes: - all: https://git.openjdk.org/jdk/pull/19819/files - new: https://git.openjdk.org/jdk/pull/19819/files/9dd9697b..40312082 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19819=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19819=01-02 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19819.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19819/head:pull/19819 PR: https://git.openjdk.org/jdk/pull/19819
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 18:44:58 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 153:
>>
>>> 151: /**
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: * @deprecated This constructor will be removed in future release
>>
>> Sounds reasonable enough. It's what happened, isn't it? It's the reason why
>> we're deprecating it and planning to remove it.
>>
>> Suggestion:
>>
>> * @deprecated This constructor was added by accident. Do not use it.
>> * This constructor will be removed in a future release.
>>
>>
>> There are comments that say this method shouldn't have been public.
>>
>> On the other hand, there are quite a few methods and classes in the list of
>> terminally terminated elements which don't say anything at all.
>
> Or:
>
>
> * @deprecated This constructor will be removed in a future release.
> * Use {@link #BasicSliderUI(JSlider b)} instead.
>
> This is in the gist of the deprecation message for
> [`SecurityManager`](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/lang/SecurityManager.html).
FWIW, we did something similar to this in JavaFX when we deprecated for removal
an accidentally added constructor (an implicit no-arg constructor in our case).
https://github.com/openjdk/jfx/commit/a5ecfb68
* @deprecated This constructor was exposed erroneously and will be removed
in the next version.
* Use {@link #createSelector(String)} instead.
If you decide it's worth doing, you might also include a pointer to the other
constructor, although since there only is one more, it is pretty obvious for
this class.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1649322438
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 18:33:37 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add forRemoval
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
> 153:
>
>> 151: /**
>> 152: * Constructs a {@code BasicSliderUI}.
>> 153: * @deprecated This constructor will be removed in future release
>
> Sounds reasonable enough. It's what happened, isn't it? It's the reason why
> we're deprecating it and planning to remove it.
>
> Suggestion:
>
> * @deprecated This constructor was added by accident. Do not use it.
> * This constructor will be removed in a future release.
>
>
> There are comments that say this method shouldn't have been public.
>
> On the other hand, there are quite a few methods and classes in the list of
> terminally terminated elements which don't say anything at all.
Or:
* @deprecated This constructor will be removed in a future release.
* Use {@link #BasicSliderUI(JSlider b)} instead.
This is in the gist of the deprecation message for
[`SecurityManager`](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/lang/SecurityManager.html).
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1649319001
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add forRemoval
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
153:
> 151: /**
> 152: * Constructs a {@code BasicSliderUI}.
> 153: * @deprecated This constructor will be removed in future release
Sounds reasonable enough. It's what happened, isn't it? It's the reason why
we're deprecating it and planning to remove it.
Suggestion:
* @deprecated This constructor was added by accident. Do not use it.
* This constructor will be removed in a future release.
There are comments that say this method shouldn't have been public.
On the other hand, there are quite a few methods and classes in the list of
terminally terminated elements which don't say anything at all.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1649309588
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 18:08:45 GMT, Phil Race wrote: > But it means that if we deprecated the consructor with args we'd probably > want to look at those too. It seems like the ripple effect isn't worth it. It would clean up the code… Yes, we would need to modify all the subclasses too. > And what if there is later a need for the JSlider ? Unlikely I know .. The `JSlider` object is set in `installUI` method where a UI object gets associated with a particular component. Before `installUI` is called, the `slider` field is `null`. > but I'd prefer to correct the short-term mistake and leave everything else > alone. So, considering the ripple effect is not worth it, I guess. - PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2183230243
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 15:13:27 GMT, Iris Clark wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 153:
>>
>>> 151: /**
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: * @deprecated This constructor will be removed in future release
>>
>> This needs a full stop at the end. It's usually added in `@deprecated` tags.
>> Suggestion:
>>
>> * @deprecated This constructor will be removed in future release.
>>
>>
>> Should we explain *why* it's deprecated?
>
> Second the recommendation for "why". As a "forRemoval=true" deprecation, it
> will appear in the "Terminally Deprecated Elements" table on this page:
> https://download.java.net/java/early_access/jdk24/docs/api/deprecated-list.html.
What text would you add ?
"This constructor was added by accident in JDK 16." ?
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1649289562
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 15:59:26 GMT, Prasanta Sadhukhan wrote: > Now that I looked at the code more thoroughly, the no-arg constructor makes > more sense actually. > > https://github.com/openjdk/jdk/blob/c41293a70834a79c79e859ebcdb8869884ac87dc/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java#L202-L207 > > I was under impression that `BasicSliderUI(JSlider b)` did use its parameter > but it doesn't. > > Should we keep the new constructor and deprecate the _old_ one? > > Should we remove the new constructor and keep the things as they've always > been? I looked at all the sub-classes of BasicSliderUI - and Aqua, Motif, Metal, Synth, Windows all of course use the constructor with args, since they had to. But it means that if we deprecated the consructor with args we'd probably want to look at those too. It seems like the ripple effect isn't worth it. And what if there is later a need for the JSlider ? Unlikely I know .. but I'd prefer to correct the short-term mistake and leave everything else alone. - PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2183211635
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add forRemoval > > I was under impression that BasicSliderUI(JSlider b) did use its parameter > > but it doesn't. > > > > Should we keep the new constructor and deprecate the _old_ one? > > I guess if we remove the old one, it might mean incompatibility to > applications which might be using it/calling it.. Even `createUI `uses this > JSlider param constructor This is why we *cannot* remove the old constructor with the parameter but we can deprecate it. The `createUI` method can use new no-arg constructor, and nothing will change. - PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2183068827
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add forRemoval > Now that I looked at the code more thoroughly, the no-arg constructor makes > more sense actually. > > https://github.com/openjdk/jdk/blob/c41293a70834a79c79e859ebcdb8869884ac87dc/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java#L202-L207 > > I was under impression that `BasicSliderUI(JSlider b)` did use its parameter > but it doesn't. > > Should we keep the new constructor and deprecate the _old_ one? > > Should we remove the new constructor and keep the things as they've always > been? I guess if we remove the old one, it might mean incompatibility to applications which might be using it/calling it.. Even `createUI `uses this JSlider param constructor - PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2183023132
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add forRemoval Need a review of the CSR as well.. - PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2182960041
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 14:51:39 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add forRemoval
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
> 153:
>
>> 151: /**
>> 152: * Constructs a {@code BasicSliderUI}.
>> 153: * @deprecated This constructor will be removed in future release
>
> This needs a full stop at the end. It's usually added in `@deprecated` tags.
> Suggestion:
>
> * @deprecated This constructor will be removed in future release.
>
>
> Should we explain *why* it's deprecated?
Second the recommendation for "why". As a "forRemoval=true" deprecation, it
will appear in the "Terminally Deprecated Elements" table on this page:
https://download.java.net/java/early_access/jdk24/docs/api/deprecated-list.html.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1649099183
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add forRemoval Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2132882820
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add forRemoval Now that I looked at the code more thoroughly, the no-arg constructor makes more sense actually. https://github.com/openjdk/jdk/blob/c41293a70834a79c79e859ebcdb8869884ac87dc/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java#L202-L207 I was under impression that `BasicSliderUI(JSlider b)` did use its parameter but it doesn't. Should we keep the new constructor and deprecate the *old* one? Should we remove the new constructor and keep the things as they've always been? - PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2182916810
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add forRemoval
Marked as reviewed by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
153:
> 151: /**
> 152: * Constructs a {@code BasicSliderUI}.
> 153: * @deprecated This constructor will be removed in future release
This needs a full stop at the end. It's usually added in `@deprecated` tags.
Suggestion:
* @deprecated This constructor will be removed in future release.
Should we explain *why* it's deprecated?
-
PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2132839628
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1649072864
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:21:38 GMT, Prasanta Sadhukhan
wrote:
> Build works ok however I see in some places like
> [this](https://github.com/openjdk/jdk/blob/08ace27da1d9cd215c77471eabf41417ff6282d2/src/java.desktop/share/classes/java/awt/Graphics.java#L1169)
> @SuppressWarnings("removal") is used, not sure if we need to use this here
> too...
It isn't needed on the constructor itself; it would only be needed if some
other code uses it. In the case you cited (an override of the finalize method),
you need the `@SuppressWarnings` because you are overriding a method in the
base class (Object) that is deprecated for removal.
-
PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2182674063
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:12:22 GMT, Kevin Rushforth wrote:
> This looks good. I presume you've done a test build to ensure that there are
> no "removal" warnings elsewhere in the JDK? (I suspect there aren't, since I
> doubt any test program would be using this mistakenly added constructor)
Build works ok however I see in some places like
[this](https://github.com/openjdk/jdk/blob/08ace27da1d9cd215c77471eabf41417ff6282d2/src/java.desktop/share/classes/java/awt/Graphics.java#L1169)
@SuppressWarnings("removal") is used, not sure if we need to use this here
too...
-
PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2182648707
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 11:14:52 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 154:
>>
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: */
>>> 154: @Deprecated(since = "23")
>>
>> You need to add `forRemoval = true` to deprecate this for removal. Also, we
>> typically add a `@deprecated` javadoc tag in addition to the `@Deprecated`
>> annotation.
>
> Yes, you're right.
Added forRemoval and @deprecated
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1648880085
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan wrote: >> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add forRemoval This looks good. I presume you've done a test build to ensure that there are no "removal" warnings elsewhere in the JDK? (I suspect there aren't, since I doubt any test program would be using this mistakenly added constructor) - Marked as reviewed by kcr (Author). PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2132519171
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal [v2]
> The no-arg constructor BasicSliderUI() was added under > [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This > constructor should be deprecated for removal in future release Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Add forRemoval - Changes: - all: https://git.openjdk.org/jdk/pull/19819/files - new: https://git.openjdk.org/jdk/pull/19819/files/57cbacd6..9dd9697b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19819=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19819=00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19819.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19819/head:pull/19819 PR: https://git.openjdk.org/jdk/pull/19819
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
On Fri, 21 Jun 2024 11:10:56 GMT, Kevin Rushforth wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
> 154:
>
>> 152: * Constructs a {@code BasicSliderUI}.
>> 153: */
>> 154: @Deprecated(since = "23")
>
> You need to add `forRemoval = true` to deprecate this for removal. Also, we
> typically add a `@deprecated` javadoc tag in addition to the `@Deprecated`
> annotation.
Yes, you're right.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1648826971
Re: RFR: 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
On Fri, 21 Jun 2024 03:31:50 GMT, Prasanta Sadhukhan
wrote:
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
Changes requested by kcr (Author).
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
154:
> 152: * Constructs a {@code BasicSliderUI}.
> 153: */
> 154: @Deprecated(since = "23")
You need to add `forRemoval = true` to deprecate this for removal. Also, we
typically add a `@deprecated` javadoc tag in addition to the `@Deprecated`
annotation.
-
PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2132422657
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1648823338
