[jira] [Commented] (CASSANDRASC-44) Use vertx periodicTimer for health checks
[
https://issues.apache.org/jira/browse/CASSANDRASC-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616195#comment-17616195
]
Yifan Cai commented on CASSANDRASC-44:
--
+1 on the patch.
> Use vertx periodicTimer for health checks
> -
>
> Key: CASSANDRASC-44
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-44
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Align Sidecar to vertx best practices by using vertx's periodic timer instead
> of using the {{Executors.newSingleThreadScheduledExecutor}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (5dc2fb95 -> 4812f5ac)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 5dc2fb95 generate docs for 2af01b8f new 4812f5ac generate docs for 2af01b8f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (5dc2fb95) \ N -- N -- N refs/heads/asf-staging (4812f5ac) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (b887b0af -> 5dc2fb95)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard b887b0af generate docs for 2af01b8f new 5dc2fb95 generate docs for 2af01b8f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b887b0af) \ N -- N -- N refs/heads/asf-staging (5dc2fb95) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (0cdcc785 -> b887b0af)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 0cdcc785 generate docs for 2af01b8f new b887b0af generate docs for 2af01b8f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (0cdcc785) \ N -- N -- N refs/heads/asf-staging (b887b0af) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616102#comment-17616102
]
David Capwell commented on CASSANDRA-17939:
---
bq. An alternative would be doing the diff on the generate.sh script and assume
that that not-open source script will also be updated to add the soon-to-be
mandatory repeated tests. David Capwell wdyt?
If you have logic to detect what to run as a repeat, replicating in my script
wouldn't be hard...
bq. It would be great to have either that or those not-open source scripts,
although that seems out of the scope of this ticket.
I really should just post it... its not the "perfect" that I want which is why
I kept holding it off... Ideally I want to rewrite all our CircleCI and my
script is a tmp solution until we do that...
bq. I agree that the HIGHRES config is a waste of resources, that's why we
added the MIDRES config some time ago
The issue we face is 1) number of workers are randomly chosen and not based off
the work needed, 2) we really didn't put in a lot of effort to say we need
xlarge vs medium images. We are also not consistent due to the patching nature
of this work (filed a ticket to move away from patches but that had concerns
due to 4.1 being branched soon), so some times HIGHER uses mid resources and
some times MID uses xlarge...
bq. The fact that we have a good number of developers not using the generate.sh
but a parallel not-open source script seems to support the decision of running
the diffs on CircleCI instead of on that script
If you add a new job to the workflow my script will drop it... so if you are
changing what you plan to do based off my non-OSS script... don't bother =).
I personally feel the logical place for this work is generate.sh as that is the
only place that can "learn" what needs to happen and if we even need the new
job...
I have a few things on my plate so will be slow to review this work; don't
think you need to block on my review if others have more cycles.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (cfeccf1a -> 0cdcc785)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard cfeccf1a generate docs for 2af01b8f new 0cdcc785 generate docs for 2af01b8f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (cfeccf1a) \ N -- N -- N refs/heads/asf-staging (0cdcc785) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616081#comment-17616081
]
Andres de la Peña edited comment on CASSANDRA-17939 at 10/11/22 9:41 PM:
-
{quote}I personally think our CI is too hard right now so I tell people in my
world to add a script to their path and just type "higher" and forget about all
this... I kinda wonder if we should try to do the same in OSS... "ci/higher",
"ci/lower", "ci/mid"...
{quote}
The current {{generate.sh}} script only allows to define the resource
low/mid/high profile with the -l/-m/h flags. I wrote a patch in CASSANDRA-17113
adding flags to automatically start the builds and to select between the
pre-commit and separate workflows. That ticket hasn't had any feedback since
November last year. It would be great to have either that or those not-open
source scripts, although that seems out of the scope of this ticket.
I agree that the HIGHRES config is a waste of resources, that's why we added
the MIDRES config some time ago. Learning that there is a script out there
overriding the HIGHRES config might explain why that config has survived for so
long: there isn't anyone using it. Nevertheless, changing the resources or
automatically estimating them is out of the scope of this ticket.
The fact that we have a good number of developers not using the {{generate.sh}}
but a parallel not-open source script seems to support the decision of running
the diffs on CircleCI instead of on that script, since our goal is making sure
that every ticket gets repeated runs for all the new, modified and relevant
tests. An alternative would be doing the diff on the {{generate.sh}} script and
assume that that not-open source script will also be updated to add the
soon-to-be mandatory repeated tests. [~dcapwell] wdyt?
was (Author: adelapena):
{quote}I personally think our CI is too hard right now so I tell people in my
world to add a script to their path and just type "higher" and forget about all
this... I kinda wonder if we should try to do the same in OSS... "ci/higher",
"ci/lower", "ci/mid"...
{quote}
The current {{generate.sh}} script only allows to define the resource
low/mid/high profile with the -l/-m/h flags. I wrote a patch in CASSANDRA-17113
adding flags to automatically start the builds and to select between the
pre-commit and separate workflows. That ticket hasn't had any feedback since
November last year. It would be great to have either that or those not-open
source scripts, although that seems out of the scope of this ticket.
The agree that the HIGH config is a waste of resources, that's why we added the
MID config some time ago. Learning that there is a script out there overriding
the HIGHRES config might explain why that config has survived for so long:
there isn't anyone using it. Nevertheless, changing the resources or
automatically estimating them is out of the scope of this ticket.
The fact that we have a good number of developers not using the {{generate.sh}}
but a parallel not-open source script seems to support the decision of running
the diffs on CircleCI instead of on that script, since our goal is making sure
that every ticket gets repeated runs for all the new, modified and relevant
tests. An alternative would be doing the diff on the {{generate.sh}} script and
assume that that not-open source script will also be updated to add the
soon-to-be mandatory repeated tests. [~dcapwell] wdyt?
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616081#comment-17616081
]
Andres de la Peña commented on CASSANDRA-17939:
---
{quote}I personally think our CI is too hard right now so I tell people in my
world to add a script to their path and just type "higher" and forget about all
this... I kinda wonder if we should try to do the same in OSS... "ci/higher",
"ci/lower", "ci/mid"...
{quote}
The current {{generate.sh}} script only allows to define the resource
low/mid/high profile with the -l/-m/h flags. I wrote a patch in CASSANDRA-17113
adding flags to automatically start the builds and to select between the
pre-commit and separate workflows. That ticket hasn't had any feedback since
November last year. It would be great to have either that or those not-open
source scripts, although that seems out of the scope of this ticket.
The agree that the HIGH config is a waste of resources, that's why we added the
MID config some time ago. Learning that there is a script out there overriding
the HIGHRES config might explain why that config has survived for so long:
there isn't anyone using it. Nevertheless, changing the resources or
automatically estimating them is out of the scope of this ticket.
The fact that we have a good number of developers not using the {{generate.sh}}
but a parallel not-open source script seems to support the decision of running
the diffs on CircleCI instead of on that script, since our goal is making sure
that every ticket gets repeated runs for all the new, modified and relevant
tests. An alternative would be doing the diff on the {{generate.sh}} script and
assume that that not-open source script will also be updated to add the
soon-to-be mandatory repeated tests. [~dcapwell] wdyt?
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated (682060ab -> fde75a88)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git from 682060ab Wait for replacement to come up fully add fde75a88 align audit log tests with CASSANDRA-17933 No new revisions were added by this update. Summary of changes: auditlog_test.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17933) Zero length file in Audit log folder, prevents a node from starting
[
https://issues.apache.org/jira/browse/CASSANDRA-17933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-17933:
--
Fix Version/s: 4.0.7
4.1-rc
4.2
(was: 4.x)
(was: 4.0.x)
(was: 4.1.x)
Source Control Link:
https://github.com/apache/cassandra/commit/488c0c75a8f632f2db4e3db39f2ebcf8a489971e
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Zero length file in Audit log folder, prevents a node from starting
> ---
>
> Key: CASSANDRA-17933
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17933
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Andrew Hogg
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.7, 4.1-rc, 4.2
>
> Attachments: signature.asc
>
>
> We have encountered a 4.0.3 cluster where the audit log folder had a zero
> byte length file within it after the node had stopped. It is not clear how
> Cassandra got to the point of this file existing. On restarting the node, the
> node will not start and throws the following stack trace.
> {code:java}
> ERROR [main] 2022-09-26 14:01:27,892 CassandraDaemon.java:911 - Exception
> encountered during startup
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:468)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:765)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:889)
> Caused by: org.apache.cassandra.exceptions.ConfigurationException: Unable to
> create instance of IAuditLogger.
> at
> org.apache.cassandra.utils.FBUtilities.newAuditLogger(FBUtilities.java:686)
> at
> org.apache.cassandra.audit.AuditLogManager.getAuditLogger(AuditLogManager.java:95)
> at
> org.apache.cassandra.audit.AuditLogManager.(AuditLogManager.java:74)
> at
> org.apache.cassandra.audit.AuditLogManager.(AuditLogManager.java:60)
> ... 3 common frames omitted
> Caused by: java.lang.reflect.InvocationTargetException: null
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.cassandra.utils.FBUtilities.newAuditLogger(FBUtilities.java:682)
> ... 6 common frames omitted
> Caused by: java.nio.channels.OverlappingFileLockException: null
> at sun.nio.ch.SharedFileLockTable.checkList(FileLockTable.java:255)
> at sun.nio.ch.SharedFileLockTable.add(FileLockTable.java:152)
> at sun.nio.ch.FileChannelImpl.lock(FileChannelImpl.java:1068)
> at java.nio.channels.FileChannel.lock(FileChannel.java:1053)
> at
> net.openhft.chronicle.bytes.MappedFile.resizeRafIfTooSmall(MappedFile.java:369)
> at
> net.openhft.chronicle.bytes.MappedFile.acquireByteStore(MappedFile.java:307)
> at
> net.openhft.chronicle.bytes.MappedFile.acquireByteStore(MappedFile.java:269)
> at
> net.openhft.chronicle.bytes.MappedBytes.acquireNextByteStore0(MappedBytes.java:434)
> at
> net.openhft.chronicle.bytes.MappedBytes.readVolatileInt(MappedBytes.java:792)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue$StoreSupplier.headerRecovery(SingleChronicleQueue.java:1027)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue$StoreSupplier.acquire(SingleChronicleQueue.java:981)
> at
> net.openhft.chronicle.queue.impl.WireStorePool.acquire(WireStorePool.java:53)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue.cleanupStoreFilesWithNoData(SingleChronicleQueue.java:821)
> at
> net.openhft.chronicle.queue.impl.single.StoreAppender.(StoreAppender.java:75)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue.newAppender(SingleChronicleQueue.java:422)
> at
> net.openhft.chronicle.core.threads.CleaningThreadLocal.initialValue(CleaningThreadLocal.java:54)
> at java.lang.ThreadLocal.setInitialValue(ThreadLocal.java:180)
> at java.lang.ThreadLocal.get(ThreadLocal.java:170)
> at
> net.openhft.chronicle.core.threads.CleaningThreadLocal.get(CleaningThreadLocal.java:59)
> at
>
[cassandra] branch cassandra-4.0 updated (e13356d75d -> 488c0c75a8)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from e13356d75d Fix multiple BufferPool bugs add 488c0c75a8 Remove empty cq4 log files to prevent BinLog from failing to start No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/utils/binlog/BinLog.java | 81 +--- .../cassandra/audit/AuditLoggerCleanupTest.java| 145 + 3 files changed, 207 insertions(+), 20 deletions(-) create mode 100644 test/unit/org/apache/cassandra/audit/AuditLoggerCleanupTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (3fc9bc033a -> 15b54687a5)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 3fc9bc033a Merge branch 'cassandra-4.0' into cassandra-4.1 add 488c0c75a8 Remove empty cq4 log files to prevent BinLog from failing to start add 15b54687a5 Merge branch 'cassandra-4.0' into cassandra-4.1 No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/utils/binlog/BinLog.java | 78 --- .../cassandra/audit/AuditLoggerCleanupTest.java| 145 + 3 files changed, 205 insertions(+), 19 deletions(-) create mode 100644 test/unit/org/apache/cassandra/audit/AuditLoggerCleanupTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit c5f8e63f67d105f483c56dd4f09b5ee6e46a4241 Merge: 04cfb57dde 15b54687a5 Author: Stefan Miklosovic AuthorDate: Tue Oct 11 23:21:25 2022 +0200 Merge branch 'cassandra-4.1' into trunk CHANGES.txt| 1 + .../org/apache/cassandra/utils/binlog/BinLog.java | 78 --- .../cassandra/audit/AuditLoggerCleanupTest.java| 145 + 3 files changed, 205 insertions(+), 19 deletions(-) diff --cc CHANGES.txt index 5b101ab3de,185770bafe..c3f0bcf534 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -91,8 -39,6 +91,9 @@@ Merged from 4.1 * Revert removal of withBufferSizeInMB(int size) in CQLSSTableWriter.Builder class and deprecate it in favor of withBufferSizeInMiB(int size) (CASSANDRA-17675) * Remove expired snapshots of dropped tables after restart (CASSANDRA-17619) Merged from 4.0: ++ * Remove empty cq4 files in log directory to not fail the startup of BinLog (CASSANDRA-17933) + * Fix multiple BufferPool bugs (CASSANDRA-16681) + * Fix StorageService.getNativeaddress handling of IPv6 addresses (CASSANDRA-17945) * Mitigate direct buffer memory OOM on replacements (CASSANDRA-17895) * Fix repair failure on assertion if two peers have overlapping mismatching ranges (CASSANDRA-17900) * Better handle null state in Gossip schema migration to avoid NPE (CASSANDRA-17864) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (04cfb57dde -> c5f8e63f67)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 04cfb57dde Merge branch 'cassandra-4.1' into trunk add 488c0c75a8 Remove empty cq4 log files to prevent BinLog from failing to start add 15b54687a5 Merge branch 'cassandra-4.0' into cassandra-4.1 new c5f8e63f67 Merge branch 'cassandra-4.1' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../org/apache/cassandra/utils/binlog/BinLog.java | 78 --- .../cassandra/audit/AuditLoggerCleanupTest.java| 145 + 3 files changed, 205 insertions(+), 19 deletions(-) create mode 100644 test/unit/org/apache/cassandra/audit/AuditLoggerCleanupTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616077#comment-17616077
]
David Capwell commented on CASSANDRA-17939:
---
bq. I don't know if everyone uses the script, though
I don't, I replaced with my own that Josh keeps pointing out that I should
OSS...
Ill try to review the ticket (don't want to block), but the intent behind it
LGTM... I personally think our CI is too hard right now so I tell people in my
world to add a script to their path and just type "higher" and forget about all
this... I kinda wonder if we should try to do the same in OSS... "ci/higher",
"ci/lower", "ci/mid"...
The reason why I ask this is that higher/lower/mid are all bad and based off
random judgement from someone a long time ago and tend to be a bad fit... for
example my scripts figure out how many containers are needed based off how many
tests are being run... and I find that we use far less containers (HIGHER says
100 containers for unit, but we can't justify more than 35 atm on trunk...
there is like a 1m difference in performance). Given this statement it feels
in-line with the idea of finding what tests need to run and sizing properly...
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616074#comment-17616074
]
Andres de la Peña commented on CASSANDRA-17939:
---
That's what [the patch running the diff
locally|https://github.com/adelapena/cassandra/commit/edb452ce2ef718877ba24e42f2287b4fd0490ea2]
does, where the diff is automatically done with the l/m/h flags. We can try to
also add the skipping of the repeated tests there. I don't know if everyone
uses the script, though. In theory we provide the four {{config.yml}} files so
people don't have to necessarily use the script, although I'm not sure that's
useful anymore.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17922) Jolokia agent fails to connect though port is available
[
https://issues.apache.org/jira/browse/CASSANDRA-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616072#comment-17616072
]
Josh McKenzie commented on CASSANDRA-17922:
---
+1 if CI's clean
> Jolokia agent fails to connect though port is available
> ---
>
> Key: CASSANDRA-17922
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17922
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 4.x
>
>
> In CASSANDRA-17872 we added protection around failures similar to this,
> caused by the port being in use, which is no longer the case:
> {code}
> subprocess.CalledProcessError: Command
> '('/usr/lib/jvm/java-8-openjdk-amd64/bin/java', '{-}cp',
> '/usr/lib/jvm/java-8-openjdk-amd64/lib/tools.jar:/home/cassandra/cassandra/cassandra-dtest/tools/../lib/jolokia-jvm-1.7.1-agent.jar',
> 'org.jolokia.jvmagent.client.AgentLauncher', '{-}{-}host', '127.0.0.2',
> '{-}-port', '8778', 'start', '1123')' returned non-zero exit status 1.
> {code}
> [https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/junit/dtest-novnode.auth_test/TestNetworkAuth/test_revoked_dc_access/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616063#comment-17616063
]
Josh McKenzie commented on CASSANDRA-17939:
---
What if we bake it into any of the sizing flags (low / medium / high) on
generate.sh w/the assumption that people that run circle will use that + want
to run the diffed test?
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17933) Zero length file in Audit log folder, prevents a node from starting
[
https://issues.apache.org/jira/browse/CASSANDRA-17933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616042#comment-17616042
]
Andrew Hogg commented on CASSANDRA-17933:
-
> By the way, we do not know what has caused the creation of that empty file we
> try to delete. That bothers me too.
I've checked back on the logs provided to try get some more information on what
happened, but it's not a very helpful error. The node went down in a
non-graceful manner from a Java OOM - with the cause of that not being clear.
> Zero length file in Audit log folder, prevents a node from starting
> ---
>
> Key: CASSANDRA-17933
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17933
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Andrew Hogg
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Attachments: signature.asc
>
>
> We have encountered a 4.0.3 cluster where the audit log folder had a zero
> byte length file within it after the node had stopped. It is not clear how
> Cassandra got to the point of this file existing. On restarting the node, the
> node will not start and throws the following stack trace.
> {code:java}
> ERROR [main] 2022-09-26 14:01:27,892 CassandraDaemon.java:911 - Exception
> encountered during startup
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:468)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:765)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:889)
> Caused by: org.apache.cassandra.exceptions.ConfigurationException: Unable to
> create instance of IAuditLogger.
> at
> org.apache.cassandra.utils.FBUtilities.newAuditLogger(FBUtilities.java:686)
> at
> org.apache.cassandra.audit.AuditLogManager.getAuditLogger(AuditLogManager.java:95)
> at
> org.apache.cassandra.audit.AuditLogManager.(AuditLogManager.java:74)
> at
> org.apache.cassandra.audit.AuditLogManager.(AuditLogManager.java:60)
> ... 3 common frames omitted
> Caused by: java.lang.reflect.InvocationTargetException: null
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.cassandra.utils.FBUtilities.newAuditLogger(FBUtilities.java:682)
> ... 6 common frames omitted
> Caused by: java.nio.channels.OverlappingFileLockException: null
> at sun.nio.ch.SharedFileLockTable.checkList(FileLockTable.java:255)
> at sun.nio.ch.SharedFileLockTable.add(FileLockTable.java:152)
> at sun.nio.ch.FileChannelImpl.lock(FileChannelImpl.java:1068)
> at java.nio.channels.FileChannel.lock(FileChannel.java:1053)
> at
> net.openhft.chronicle.bytes.MappedFile.resizeRafIfTooSmall(MappedFile.java:369)
> at
> net.openhft.chronicle.bytes.MappedFile.acquireByteStore(MappedFile.java:307)
> at
> net.openhft.chronicle.bytes.MappedFile.acquireByteStore(MappedFile.java:269)
> at
> net.openhft.chronicle.bytes.MappedBytes.acquireNextByteStore0(MappedBytes.java:434)
> at
> net.openhft.chronicle.bytes.MappedBytes.readVolatileInt(MappedBytes.java:792)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue$StoreSupplier.headerRecovery(SingleChronicleQueue.java:1027)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue$StoreSupplier.acquire(SingleChronicleQueue.java:981)
> at
> net.openhft.chronicle.queue.impl.WireStorePool.acquire(WireStorePool.java:53)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue.cleanupStoreFilesWithNoData(SingleChronicleQueue.java:821)
> at
> net.openhft.chronicle.queue.impl.single.StoreAppender.(StoreAppender.java:75)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue.newAppender(SingleChronicleQueue.java:422)
> at
> net.openhft.chronicle.core.threads.CleaningThreadLocal.initialValue(CleaningThreadLocal.java:54)
> at java.lang.ThreadLocal.setInitialValue(ThreadLocal.java:180)
> at java.lang.ThreadLocal.get(ThreadLocal.java:170)
> at
> net.openhft.chronicle.core.threads.CleaningThreadLocal.get(CleaningThreadLocal.java:59)
> at
>
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616032#comment-17616032
]
Andres de la Peña commented on CASSANDRA-17939:
---
The only way I know to not start those jobs is manual approval steps, as we do
in the separate workflows. Alternatively, if we do the diff on the
{{generate.sh}} script we can try to modify the config to remove or disable
those jobs if there isn't anything to run. But that approach has the problem of
requiring the developers to always use the {{generate.sh}} script.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615972#comment-17615972
]
Andres de la Peña edited comment on CASSANDRA-17939 at 10/11/22 6:45 PM:
-
{quote}Looks like the -d flag requires running in the root and doesn't take
relative path into account when it iterates over test directories.
{quote}
Yep, I have considered that in the above patch for doing the diff on the
{{generate.sh}} script but I missed it on the main PR. I'll fix it.
{quote}I was incredibly lazy and just copy/pasted the syntax from the comment
above which led to the "local branch is stale" diff showing up.
{quote}
Doesn't help that I wrote the command on that comment with the wrong syntax :).
The command is:
{code}
git --no-pager diff --name-only --diff-filter=AMR /...HEAD
{code}
And then there are a couple of filters.
was (Author: adelapena):
{quote}Looks like the -d flag requires running in the root and doesn't take
relative path into account when it iterates over test directories.
{quote}
Yep, I have considered that in the above patch for doing the diff on the
{{generate.sh}} script but I missed it on the main PR. I'll fix it.
{quote}I was incredibly lazy and just copy/pasted the syntax from the comment
above which led to the "local branch is stale" diff showing up.
{quote}
Doesn't help that I wrote the command on that comment with the wrong syntax :)
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616022#comment-17616022
]
Josh McKenzie commented on CASSANDRA-17939:
---
It looks like this'll spin up a bunch of parallel containers just to say "nope,
no repeated tests found here!" - [see
example|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/313/workflows/96c850ba-0042-4d0f-b5fd-6c142d88a617/jobs/3708/parallel-runs/0?filterBy=ALL].
Is there any way we can get it to skip the _repeat jobs w/out entries entirely?
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17634) Fix test: dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test.TestDropCompactStorage.test_drop_compact_storage_mixed_cluster
[
https://issues.apache.org/jira/browse/CASSANDRA-17634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-17634:
Assignee: Brandon Williams
> Fix test:
> dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test.TestDropCompactStorage.test_drop_compact_storage_mixed_cluster
> --
>
> Key: CASSANDRA-17634
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17634
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
>
> From
> https://ci-cassandra.apache.org/job/Cassandra-4.1/24/testReport/dtest-upgrade.upgrade_tests.drop_compact_storage_upgrade_test/TestDropCompactStorage/test_drop_compact_storage_mixed_cluster/
> {noformat}
> Error Message
> test teardown failure
> Stacktrace
> Unexpected error found in node logs (see stdout for full details). Errors:
> [[node2] 'ERROR [NonPeriodicTasks:1] 2022-05-18 11:36:18,780
> LogTransaction.java:398 - SSTableTidier ran with no existing data file for an
> sstable that was not new', [node2] 'ERROR [NonPeriodicTasks:1] 2022-05-18
> 11:36:18,788 LogTransaction.java:250 - Unable to delete
> /home/cassandra/cassandra/cassandra-dtest/tmp/dtest-vk4cgziz/test/node2/data0/system_schema/columns-24101c25a2ae3af787c1b40ee1aca33f/nb_txn_upgradesstables_bbe470a4-d69e-11ec-8d33-579a578037c7.log
> as it does not exist, see debug log file for stack trace', [node2] 'ERROR
> [NonPeriodicTasks:1] 2022-05-18 11:36:18,821 LogTransaction.java:250 - Unable
> to delete
> /home/cassandra/cassandra/cassandra-dtest/tmp/dtest-vk4cgziz/test/node2/data0/system_schema/columns-24101c25a2ae3af787c1b40ee1aca33f/nb_txn_upgradesstables_bbe4709a-d69e-11ec-8d33-579a578037c7.log
> as it does not exist, see debug log file for stack trace', [node2] 'ERROR
> [CompactionExecutor:1] 2022-05-18 11:36:29,589 JVMStabilityInspector.java:68
> - Exception in thread
> Thread[CompactionExecutor:1,5,CompactionExecutor]\njava.lang.NullPointerException:
> null\n\tat
> org.apache.cassandra.db.lifecycle.LogFile.makeRecord(LogFile.java:346)\n\tat
> org.apache.cassandra.db.lifecycle.LogFile.contains(LogFile.java:381)\n\tat
> org.apache.cassandra.db.lifecycle.LogTransaction.obsoleted(LogTransaction.java:183)\n\tat
>
> org.apache.cassandra.db.lifecycle.Helpers.prepareForObsoletion(Helpers.java:136)\n\tat
>
> org.apache.cassandra.db.lifecycle.LifecycleTransaction.doPrepare(LifecycleTransaction.java:206)\n\tat
>
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:168)\n\tat
>
> org.apache.cassandra.io.sstable.SSTableRewriter.doPrepare(SSTableRewriter.java:386)\n\tat
>
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:168)\n\tat
>
> org.apache.cassandra.db.compaction.writers.CompactionAwareWriter.doPrepare(CompactionAwareWriter.java:106)\n\tat
>
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.prepareToCommit(Transactional.java:168)\n\tat
>
> org.apache.cassandra.utils.concurrent.Transactional$AbstractTransactional.finish(Transactional.java:179)\n\tat
>
> org.apache.cassandra.db.compaction.writers.CompactionAwareWriter.finish(CompactionAwareWriter.java:116)\n\tat
>
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:218)\n\tat
>
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)\n\tat
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:82)\n\tat
>
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:100)\n\tat
>
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:299)\n\tat
> org.apache.cassandra.concurrent.FutureTask$2.call(FutureTask.java:98)\n\tat
> org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:47)\n\tat
> org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:57)\n\tat
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)\n\tat
>
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.lang.Thread.run(Thread.java:748)']
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail:
[jira] [Updated] (CASSANDRA-17957) WEBSITE - social icons and image caption formatting
[ https://issues.apache.org/jira/browse/CASSANDRA-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diogenese Topper updated CASSANDRA-17957: - Attachment: Screen Shot 2022-10-11 at 9.26.56 AM.png Screen Shot 2022-10-11 at 9.27.07 AM.png Screen Shot 2022-10-11 at 9.27.16 AM.png > WEBSITE - social icons and image caption formatting > --- > > Key: CASSANDRA-17957 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17957 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Priority: Normal > Labels: pull-request-available > Attachments: Screen Shot 2022-10-11 at 9.26.56 AM.png, Screen Shot > 2022-10-11 at 9.27.07 AM.png, Screen Shot 2022-10-11 at 9.27.16 AM.png > > > This ticket is to capture the work associated with adding social icons and > caption formatting to the website. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17957) WEBSITE - social icons and image caption formatting
[ https://issues.apache.org/jira/browse/CASSANDRA-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615990#comment-17615990 ] Diogenese Topper commented on CASSANDRA-17957: -- !Screen Shot 2022-10-11 at 9.26.56 AM.png! !Screen Shot 2022-10-11 at 9.27.07 AM.png! !Screen Shot 2022-10-11 at 9.27.16 AM.png! > WEBSITE - social icons and image caption formatting > --- > > Key: CASSANDRA-17957 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17957 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Priority: Normal > Labels: pull-request-available > > This ticket is to capture the work associated with adding social icons and > caption formatting to the website. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-45) Delegate methods to the RateLimiter
[
https://issues.apache.org/jira/browse/CASSANDRASC-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRASC-45:
-
Reviewers: Yifan Cai
Status: Review In Progress (was: Patch Available)
+1 on the patch
> Delegate methods to the RateLimiter
> ---
>
> Key: CASSANDRASC-45
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-45
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Sidecar offers a {{SidecarRateLimiter}} class that internally uses the
> {{com.google.common.util.concurrent.RateLimiter}}. We need to expose public
> methods of the {{RateLimiter}} class using the delegate pattern. These
> methods will allow us to tweak the settings of the {{RateLimiter}} that are
> available to us
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17957) WEBSITE - social icons and image caption formatting
[ https://issues.apache.org/jira/browse/CASSANDRA-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diogenese Topper updated CASSANDRA-17957: - Status: Patch Available (was: Open) https://github.com/apache/cassandra-website/pull/178 > WEBSITE - social icons and image caption formatting > --- > > Key: CASSANDRA-17957 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17957 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Priority: Normal > Labels: pull-request-available > > This ticket is to capture the work associated with adding social icons and > caption formatting to the website. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17957) WEBSITE - social icons and image caption formatting
[ https://issues.apache.org/jira/browse/CASSANDRA-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diogenese Topper updated CASSANDRA-17957: - Status: Open (was: Triage Needed) > WEBSITE - social icons and image caption formatting > --- > > Key: CASSANDRA-17957 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17957 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Priority: Normal > Labels: pull-request-available > > This ticket is to capture the work associated with adding social icons and > caption formatting to the website. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615972#comment-17615972
]
Andres de la Peña commented on CASSANDRA-17939:
---
{quote}Looks like the -d flag requires running in the root and doesn't take
relative path into account when it iterates over test directories.
{quote}
Yep, I have considered that in the above patch for doing the diff on the
{{generate.sh}} script but I missed it on the main PR. I'll fix it.
{quote}I was incredibly lazy and just copy/pasted the syntax from the comment
above which led to the "local branch is stale" diff showing up.
{quote}
Doesn't help that I wrote the command on that comment with the wrong syntax :)
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615970#comment-17615970
]
Andres de la Peña commented on CASSANDRA-17939:
---
[This
commit|https://github.com/adelapena/cassandra/commit/edb452ce2ef718877ba24e42f2287b4fd0490ea2]
shows a draft of how doing the diff locally with the {{generate.sh}} script
would look like. The script would do the diff and simply add the detected tests
to the usual env vars. For example:
{code:java}
$ .circleci/generate.sh
-m \
-e
REPEATED_UTESTS=org.apache.cassandra.cql3.DurationTest#testAddTo,org.apache.cassandra.cql3.validation.entities.DateTypeTest
\
-e
REPEATED_JVM_DTESTS=org.apache.cassandra.distributed.test.AlterTest#getAndSetCompressionParametersTest
\
-e
REPEATED_UTESTS_LONG=org.apache.cassandra.io.sstable.CQLSSTableWriterLongTest#testWideRow
\
-e
REPEATED_DTESTS=cfid_test.py,pending_range_test.py::TestPendingRangeMovements::test_pending_range
Generating new config.yml file with middle resources from config-2_1.yml
patching file .circleci/config-2_1.yml
Detecting new or modified tests with git diff --diff-filter=AMR trunk...HEAD:
org.apache.cassandra.cql3.functions.NewTimeFctsTest
org.apache.cassandra.cql3.functions.RenamedCastFctsTest
org.apache.cassandra.cql3.functions.TimeFctsTest
org.apache.cassandra.db.commitlog.BatchCommitLogStressTest
org.apache.cassandra.db.commitlog.GroupCommitLogStressTest
org.apache.cassandra.db.commitlog.NewBatchCommitLogStressTest
org.apache.cassandra.db.commitlog.PeriodicCommitLogStressTest
org.apache.cassandra.db.commitlog.RenamedCommitLogStressTest
org.apache.cassandra.stress.generate.RenamedDistributionSequenceTest
org.apache.cassandra.stress.settings.NewOptionReplicationTest
org.apache.cassandra.stress.settings.OptionReplicationTest
org.apache.cassandra.fqltool.FQLReplayTest
org.apache.cassandra.fqltool.NewFQLReplayTest
org.apache.cassandra.fqltool.RenamedFQLCompareTest
org.apache.cassandra.simulator.test.NewShortPaxosSimulationTest
org.apache.cassandra.simulator.test.RenamedMonitorMethodTransformerTest
org.apache.cassandra.simulator.test.TrivialSimulationTest
org.apache.cassandra.distributed.test.NewBooleanTest
org.apache.cassandra.distributed.test.QueriesTableTest
org.apache.cassandra.distributed.test.RenamedGroupByTest
org.apache.cassandra.distributed.upgrade.MixedModeMessageForwardTest
org.apache.cassandra.distributed.upgrade.NewMixedModeAvailabilityV3XOneAllTest
org.apache.cassandra.distributed.upgrade.RenamedMixedModeWritetimeOrTTLTest
Setting environment variables:
REPEATED_UTESTS:
org.apache.cassandra.cql3.functions.TimeFctsTest,org.apache.cassandra.cql3.functions.RenamedCastFctsTest,org.apache.cassandra.cql3.functions.NewTimeFctsTest,org.apache.cassandra.cql3.DurationTest#testAddTo,org.apache.cassandra.cql3.validation.entities.DateTypeTest
REPEATED_JVM_DTESTS:
org.apache.cassandra.distributed.test.RenamedGroupByTest,org.apache.cassandra.distributed.test.QueriesTableTest,org.apache.cassandra.distributed.test.NewBooleanTest,org.apache.cassandra.distributed.test.AlterTest#getAndSetCompressionParametersTest
REPEATED_UTESTS_LONG:
org.apache.cassandra.db.commitlog.RenamedCommitLogStressTest,org.apache.cassandra.db.commitlog.PeriodicCommitLogStressTest,org.apache.cassandra.db.commitlog.NewBatchCommitLogStressTest,org.apache.cassandra.db.commitlog.GroupCommitLogStressTest,org.apache.cassandra.db.commitlog.BatchCommitLogStressTest,org.apache.cassandra.io.sstable.CQLSSTableWriterLongTest#testWideRow
REPEATED_DTESTS:
cfid_test.py,pending_range_test.py::TestPendingRangeMovements::test_pending_range
REPEATED_UTESTS_STRESS:
org.apache.cassandra.stress.settings.OptionReplicationTest,org.apache.cassandra.stress.settings.NewOptionReplicationTest,org.apache.cassandra.stress.generate.RenamedDistributionSequenceTest
REPEATED_UTESTS_FQLTOOL:
org.apache.cassandra.fqltool.RenamedFQLCompareTest,org.apache.cassandra.fqltool.NewFQLReplayTest,org.apache.cassandra.fqltool.FQLReplayTest
REPEATED_SIMULATOR_DTESTS:
org.apache.cassandra.simulator.test.TrivialSimulationTest,org.apache.cassandra.simulator.test.RenamedMonitorMethodTransformerTest,org.apache.cassandra.simulator.test.NewShortPaxosSimulationTest
REPEATED_JVM_UPGRADE_DTESTS:
org.apache.cassandra.distributed.upgrade.RenamedMixedModeWritetimeOrTTLTest,org.apache.cassandra.distributed.upgrade.NewMixedModeAvailabilityV3XOneAllTest,org.apache.cassandra.distributed.upgrade.MixedModeMessageForwardTest
{code}
Note how the detected tests are listed and added to the final CircleCI env
vars, together with the tests manually provided by the user.
As mentioned before, the downside of this approach is that the detection of
tests depends on developers using the {{generate.sh}} script.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
>
[jira] [Commented] (CASSANDRA-14346) Scheduled Repair in Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615967#comment-17615967 ] David Capwell commented on CASSANDRA-14346: --- Need to catch up on this thread, but would love to see this come back to life. I am more than happy to help push repair changes into this direction if people wish to lead this effort, and have a backlog of repair improvements to help flesh out the internal APIs. > Scheduled Repair in Cassandra > - > > Key: CASSANDRA-14346 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14346 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: Joey Lynch >Assignee: Joey Lynch >Priority: Normal > Labels: 4.0-feature-freeze-review-requested, > CommunityFeedbackRequested > Fix For: 4.x > > Attachments: ScheduledRepairV1_20180327.pdf > > > There have been many attempts to automate repair in Cassandra, which makes > sense given that it is necessary to give our users eventual consistency. Most > recently CASSANDRA-10070, CASSANDRA-8911 and CASSANDRA-13924 have all looked > for ways to solve this problem. > At Netflix we've built a scheduled repair service within Priam (our sidecar), > which we spoke about last year at NGCC. Given the positive feedback at NGCC > we focussed on getting it production ready and have now been using it in > production to repair hundreds of clusters, tens of thousands of nodes, and > petabytes of data for the past six months. Also based on feedback at NGCC we > have invested effort in figuring out how to integrate this natively into > Cassandra rather than open sourcing it as an external service (e.g. in Priam). > As such, [~vinaykumarcse] and I would like to re-work and merge our > implementation into Cassandra, and have created a [design > document|https://docs.google.com/document/d/1RV4rOrG1gwlD5IljmrIq_t45rz7H3xs9GbFSEyGzEtM/edit?usp=sharing] > showing how we plan to make it happen, including the the user interface. > As we work on the code migration from Priam to Cassandra, any feedback would > be greatly appreciated about the interface or v1 implementation features. I > have tried to call out in the document features which we explicitly consider > future work (as well as a path forward to implement them in the future) > because I would very much like to get this done before the 4.0 merge window > closes, and to do that I think aggressively pruning scope is going to be a > necessity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-45) Delegate methods to the RateLimiter
[
https://issues.apache.org/jira/browse/CASSANDRASC-45?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRASC-45:
--
Test and Documentation Plan: delegating new methods for the RateLimiter, no
new tests addd
Status: Patch Available (was: Open)
PR: https://github.com/apache/cassandra-sidecar/pull/39
CI:
https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar?branch=CASSANDRASC-45
> Delegate methods to the RateLimiter
> ---
>
> Key: CASSANDRASC-45
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-45
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Sidecar offers a {{SidecarRateLimiter}} class that internally uses the
> {{com.google.common.util.concurrent.RateLimiter}}. We need to expose public
> methods of the {{RateLimiter}} class using the delegate pattern. These
> methods will allow us to tweak the settings of the {{RateLimiter}} that are
> available to us
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16664) Log JVM Arguments at in-JVM Test Class Initialization
[
https://issues.apache.org/jira/browse/CASSANDRA-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Natnael Adere reassigned CASSANDRA-16664:
-
Assignee: Natnael Adere
> Log JVM Arguments at in-JVM Test Class Initialization
> -
>
> Key: CASSANDRA-16664
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16664
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
>Reporter: Caleb Rackliffe
>Assignee: Natnael Adere
>Priority: Normal
> Labels: ghc-lhf, lhf
> Fix For: 4.0.x, 4.x
>
>
> Normal C* startup flows through {{CassandraDaemon.setup()}}, which calls
> {{logSystemInfo()}}, logging JVM arguments and a number of other useful bits
> of information. The in-JVM dtest startup does not flow through
> {{CassandraDaemon.setup()}}, and therefore does not. It would be useful for
> troubleshooting purposes if {{TestBaseImpl}} logged the JVM arguments before
> moving into executing tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17957) WEBSITE - social icons and image caption formatting
[ https://issues.apache.org/jira/browse/CASSANDRA-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-17957: --- Labels: pull-request-available (was: ) > WEBSITE - social icons and image caption formatting > --- > > Key: CASSANDRA-17957 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17957 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Diogenese Topper >Priority: Normal > Labels: pull-request-available > > This ticket is to capture the work associated with adding social icons and > caption formatting to the website. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615957#comment-17615957
]
Natnael Adere commented on CASSANDRA-17915:
---
[~blerer] thanks for clarifying!
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615917#comment-17615917
]
Josh McKenzie commented on CASSANDRA-17939:
---
Looks like the -d flag requires running in the root and doesn't take relative
path into account when it iterates over test directories. Maybe adding a bit
more helpful of an error message / usage guidance there could help future users:
{code:java}
./generate.sh -d asf/trunk
New or modified tests compared to asf/trunk:
unit_tests_repeat:
fatal: ambiguous argument 'test/unit/': unknown revision or path not in the
working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'
{code}
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17922) Jolokia agent fails to connect though port is available
[
https://issues.apache.org/jira/browse/CASSANDRA-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615906#comment-17615906
]
Brandon Williams commented on CASSANDRA-17922:
--
Patch updated.
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1993/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1993/pipeline]
> Jolokia agent fails to connect though port is available
> ---
>
> Key: CASSANDRA-17922
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17922
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 4.x
>
>
> In CASSANDRA-17872 we added protection around failures similar to this,
> caused by the port being in use, which is no longer the case:
> {code}
> subprocess.CalledProcessError: Command
> '('/usr/lib/jvm/java-8-openjdk-amd64/bin/java', '{-}cp',
> '/usr/lib/jvm/java-8-openjdk-amd64/lib/tools.jar:/home/cassandra/cassandra/cassandra-dtest/tools/../lib/jolokia-jvm-1.7.1-agent.jar',
> 'org.jolokia.jvmagent.client.AgentLauncher', '{-}{-}host', '127.0.0.2',
> '{-}-port', '8778', 'start', '1123')' returned non-zero exit status 1.
> {code}
> [https://ci-cassandra.apache.org/job/Cassandra-4.1/169/testReport/junit/dtest-novnode.auth_test/TestNetworkAuth/test_revoked_dc_access/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615904#comment-17615904
]
Josh McKenzie commented on CASSANDRA-17939:
---
Got it. I was incredibly lazy and just copy/pasted the syntax from the comment
above which led to the "local branch is stale" diff showing up. :)
Will be taking a look at this today.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16681) org.apache.cassandra.utils.memory.LongBufferPoolTest - tests are flaky
[
https://issues.apache.org/jira/browse/CASSANDRA-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-16681:
--
Fix Version/s: 3.11.14
4.0.7
4.1-beta2
4.2
(was: 4.x)
(was: 3.11.x)
(was: 4.0.x)
Since Version: 4.0.0
Source Control Link:
https://github.com/apache/cassandra/commit/e13356d75d2d3c200f1636337cf15329bd1b829b
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed the test fix as dc2acba043c6978b32a9556e0d610251d5535ce6 to 3.11 and
merged up (to 4.0, 4.1, and trunk (4.2)).
Committed the {{BufferPool}} fixes and improvements -verbatim - as
e13356d75d2d3c200f1636337cf15329bd1b829b to 4.0 and merged up (to 4.1 and trunk
(4.2)).
Thank you [~pkolaczk] for the great work and the patience.
> org.apache.cassandra.utils.memory.LongBufferPoolTest - tests are flaky
> --
>
> Key: CASSANDRA-16681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16681
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Piotr Kolaczkowski
>Priority: Normal
> Fix For: 3.11.14, 4.0.7, 4.1-beta2, 4.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Jenkins history:
> [https://jenkins-cm4.apache.org/job/Cassandra-4.0/50/testReport/junit/org.apache.cassandra.utils.memory/LongBufferPoolTest/testPoolAllocateWithRecyclePartially/history/]
> Fails being run in a loop in CircleCI:
> https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/844/workflows/945011f4-00ac-4678-89f6-5c0db0a40169/jobs/5008
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (af9439bcd7 -> 04cfb57dde)
This is an automated email from the ASF dual-hosted git repository. aleksey pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from af9439bcd7 IllegalArgumentException in Gossiper#order due to concurrent mutations to elements being applied add e13356d75d Fix multiple BufferPool bugs add 3fc9bc033a Merge branch 'cassandra-4.0' into cassandra-4.1 new 04cfb57dde Merge branch 'cassandra-4.1' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../apache/cassandra/utils/memory/BufferPool.java | 200 +++-- .../cassandra/utils/memory/BufferPoolTest.java | 23 +++ 3 files changed, 165 insertions(+), 59 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. aleksey pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 04cfb57ddee573eaea00ce8c7e3d99a2f84ca78f Merge: af9439bcd7 3fc9bc033a Author: Aleksey Yeschenko AuthorDate: Tue Oct 11 15:47:43 2022 +0100 Merge branch 'cassandra-4.1' into trunk CHANGES.txt| 1 + .../apache/cassandra/utils/memory/BufferPool.java | 200 +++-- .../cassandra/utils/memory/BufferPoolTest.java | 23 +++ 3 files changed, 165 insertions(+), 59 deletions(-) diff --cc CHANGES.txt index 37ad298e45,c38feb9e16..5b101ab3de --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -91,7 -38,6 +91,8 @@@ Merged from 4.1 * Revert removal of withBufferSizeInMB(int size) in CQLSSTableWriter.Builder class and deprecate it in favor of withBufferSizeInMiB(int size) (CASSANDRA-17675) * Remove expired snapshots of dropped tables after restart (CASSANDRA-17619) Merged from 4.0: ++ * Fix multiple BufferPool bugs (CASSANDRA-16681) + * Fix StorageService.getNativeaddress handling of IPv6 addresses (CASSANDRA-17945) * Mitigate direct buffer memory OOM on replacements (CASSANDRA-17895) * Fix repair failure on assertion if two peers have overlapping mismatching ranges (CASSANDRA-17900) * Better handle null state in Gossip schema migration to avoid NPE (CASSANDRA-17864) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (9524c22990 -> 3fc9bc033a)
This is an automated email from the ASF dual-hosted git repository. aleksey pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 9524c22990 Merge branch 'cassandra-4.0' into cassandra-4.1 add e13356d75d Fix multiple BufferPool bugs add 3fc9bc033a Merge branch 'cassandra-4.0' into cassandra-4.1 No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../apache/cassandra/utils/memory/BufferPool.java | 200 +++-- .../cassandra/utils/memory/BufferPoolTest.java | 23 +++ 3 files changed, 165 insertions(+), 59 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (3bdd2caa22 -> e13356d75d)
This is an automated email from the ASF dual-hosted git repository. aleksey pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 3bdd2caa22 Fix StorageService.getNativeaddress handling of IPv6 addresses add e13356d75d Fix multiple BufferPool bugs No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + .../apache/cassandra/utils/memory/BufferPool.java | 200 +++-- .../cassandra/utils/memory/BufferPoolTest.java | 23 +++ 3 files changed, 165 insertions(+), 59 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17934) Add --resolve-ip option on 'nodetool gossipinfo'
[ https://issues.apache.org/jira/browse/CASSANDRA-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-17934: Change Category: Operability Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > Add --resolve-ip option on 'nodetool gossipinfo' > > > Key: CASSANDRA-17934 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17934 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Maxim Chanturiay >Priority: Normal > Labels: lhf > > Give nodetool gossipinfo the option of either displaying IPs or hostnames for > the nodes in a ring. > Note: this option is already present for "nodetool status" and "nodetool ring" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17934) Add --resolve-ip option on 'nodetool gossipinfo'
[
https://issues.apache.org/jira/browse/CASSANDRA-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615879#comment-17615879
]
Paulo Motta commented on CASSANDRA-17934:
-
{quote}Could you assign the issue to me? Or do I have to do it myself?
{quote}
I think you can do it yourself but I just did it. :)
{quote}I've looked into tools/nodetool/Ring.java and tools/nodetool/Status.java
as they already have the --resolve-ip option. I've also made sure that unit
tests are executed and seen how they fail in case of unexpected results.
{quote}
Nice progress! :)
{quote}So in terms of work time, it will take me a couple of extra days to get
back to Java and find my way around language that compiles.
{quote}
Sounds good, let me know if you run into any issues
> Add --resolve-ip option on 'nodetool gossipinfo'
>
>
> Key: CASSANDRA-17934
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17934
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Paulo Motta
>Assignee: Maxim Chanturiay
>Priority: Normal
> Labels: lhf
>
> Give nodetool gossipinfo the option of either displaying IPs or hostnames for
> the nodes in a ring.
> Note: this option is already present for "nodetool status" and "nodetool ring"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17934) Add --resolve-ip option on 'nodetool gossipinfo'
[ https://issues.apache.org/jira/browse/CASSANDRA-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta reassigned CASSANDRA-17934: --- Assignee: Maxim Chanturiay > Add --resolve-ip option on 'nodetool gossipinfo' > > > Key: CASSANDRA-17934 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17934 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Assignee: Maxim Chanturiay >Priority: Normal > Labels: lhf > > Give nodetool gossipinfo the option of either displaying IPs or hostnames for > the nodes in a ring. > Note: this option is already present for "nodetool status" and "nodetool ring" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17934) Add --resolve-ip option on 'nodetool gossipinfo'
[ https://issues.apache.org/jira/browse/CASSANDRA-17934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615855#comment-17615855 ] Maxim Chanturiay commented on CASSANDRA-17934: -- [~paulo], hello! I would like to join Cassandra project as a code maintainer and this issue seems like a great starting point for me. Could you assign the issue to me? Or do I have to do it myself? According to ASF guide to contributing I have to introduce myself first and ask for the first task. However, [https://cwiki.apache.org/confluence/display/CASSANDRA2/HowToContribute] says to simply assign. So I am asking just in case :) So far, I have prepared dev env, poked around the source code and followed the working process based on a couple of "Done" tickets. Specifically, I've looked into tools/nodetool/Ring.java and tools/nodetool/Status.java as they already have the --resolve-ip option. I've also made sure that unit tests are executed and seen how they fail in case of unexpected results. I am a junior backend developer in my day time and we work primarily with Lua, Ruby and Python. So in terms of work time, it will take me a couple of extra days to get back to Java and find my way around language that compiles. > Add --resolve-ip option on 'nodetool gossipinfo' > > > Key: CASSANDRA-17934 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17934 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Paulo Motta >Priority: Normal > Labels: lhf > > Give nodetool gossipinfo the option of either displaying IPs or hostnames for > the nodes in a ring. > Note: this option is already present for "nodetool status" and "nodetool ring" -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17915:
-
Status: Patch Available (was: Review In Progress)
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17915:
-
Reviewers: Benjamin Lerer, Brandon Williams (was: Benjamin Lerer)
Status: Review In Progress (was: Needs Committer)
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17915:
-
Status: Open (was: Patch Available)
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615842#comment-17615842
]
Benjamin Lerer commented on CASSANDRA-17915:
[~NateAdere] to summarize: what is needed is patches for 4.0, 4.1 and trunk
with the CI runs. :)
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615729#comment-17615729
]
Andres de la Peña edited comment on CASSANDRA-17939 at 10/11/22 12:10 PM:
--
As for running the actual diff on CircleCI instead of running it locally:
* It allows the detection of new and modified tests even if the user doesn't
use the {{generate.sh}} script when pushing.
* It prevents us from doing shallow clones ({{git clone --depth 1}}). This
means a slightly longer build and a bigger working directory to be copied to
every runner. Running the diff locally would require less resources.
* It ensures that we use the right remote and base branch when running the
diff, whereas a local diff would require the right config on the user's machine.
* The results of a local call to {{generate.sh -d}} could be different to what
is actually run on CircleCI. However that seems unlikely given that we use
three-dot diffs. Having more commits on top of the base branch when the tests
are run shouldn't make a difference.
was (Author: adelapena):
As for running the actual diff on CircleCI instead of running it locally:
* It allows the detection of new and modified tests even if the user doesn't
use the {{generate.sh}} script when pushing.
* It prevents us from doing shallow clones ({{git clone --depth 1}}). This
means slightly a slightly longer build and a bigger working directory to be
copied to every runner. Running the diff locally would require less resources.
* It ensures that we use the right remote and base branch when running the
diff, whereas a local diff would require the right config on the user's machine.
* The results of {{generate.sh -d}} could be different to what is actually run
on server. However that seems unlikely given that we use three-dot diffs, so
having more commits on top of the base branch when the tests are run shouldn't
make a difference.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615729#comment-17615729
]
Andres de la Peña commented on CASSANDRA-17939:
---
As for running the actual diff on CircleCI instead of running it locally:
* It allows the detection of new and modified tests even if the user doesn't
use the {{generate.sh}} script when pushing.
* It prevents us from doing shallow clones ({{git clone --depth 1}}). This
means slightly a slightly longer build and a bigger working directory to be
copied to every runner. Running the diff locally would require less resources.
* It ensures that we use the right remote and base branch when running the
diff, whereas a local diff would require the right config on the user's machine.
* The results of {{generate.sh -d}} could be different to what is actually run
on server. However that seems unlikely given that we use three-dot diffs, so
having more commits on top of the base branch when the tests are run shouldn't
make a difference.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615702#comment-17615702
]
Andres de la Peña commented on CASSANDRA-17939:
---
I have just added a {{generate.sh -d}} option to preview the new or modified
tests that will be selected and run on CircleCI. It needs the base branch as an
argument because we don't know what remotes the users will have in their local
machines, and we probably don't want to mess with their repos by adding nor
fetching remotes. Using [the same test
commit|https://github.com/adelapena/cassandra/commit/6639cc5d1c39080da271ef8a5c8d8366a5b713af]
that we have used in the examples above, the output looks like:
{code}
$ .circleci/generate.sh -d apache/trunk
New or modified tests compared to apache/trunk:
unit_tests_repeat:
org.apache.cassandra.cql3.functions.NewTimeFctsTest
org.apache.cassandra.cql3.functions.RenamedCastFctsTest
org.apache.cassandra.cql3.functions.TimeFctsTest
utests_compression_repeat:
org.apache.cassandra.cql3.functions.NewTimeFctsTest
org.apache.cassandra.cql3.functions.RenamedCastFctsTest
org.apache.cassandra.cql3.functions.TimeFctsTest
utests_system_keyspace_directory_repeat:
org.apache.cassandra.cql3.functions.NewTimeFctsTest
org.apache.cassandra.cql3.functions.RenamedCastFctsTest
org.apache.cassandra.cql3.functions.TimeFctsTest
utests_long_repeat:
org.apache.cassandra.db.commitlog.BatchCommitLogStressTest
org.apache.cassandra.db.commitlog.GroupCommitLogStressTest
org.apache.cassandra.db.commitlog.NewBatchCommitLogStressTest
org.apache.cassandra.db.commitlog.PeriodicCommitLogStressTest
org.apache.cassandra.db.commitlog.RenamedCommitLogStressTest
utests_stress_repeat:
org.apache.cassandra.stress.generate.RenamedDistributionSequenceTest
org.apache.cassandra.stress.settings.NewOptionReplicationTest
org.apache.cassandra.stress.settings.OptionReplicationTest
utests_fqltool_repeat:
org.apache.cassandra.fqltool.FQLReplayTest
org.apache.cassandra.fqltool.NewFQLReplayTest
org.apache.cassandra.fqltool.RenamedFQLCompareTest
simulator_dtests_repeat:
org.apache.cassandra.simulator.test.NewShortPaxosSimulationTest
org.apache.cassandra.simulator.test.RenamedMonitorMethodTransformerTest
org.apache.cassandra.simulator.test.TrivialSimulationTest
jvm_dtests_repeat:
org.apache.cassandra.distributed.test.NewBooleanTest
org.apache.cassandra.distributed.test.QueriesTableTest
org.apache.cassandra.distributed.test.RenamedGroupByTest
jvm_dtests_vnode_repeat:
org.apache.cassandra.distributed.test.NewBooleanTest
org.apache.cassandra.distributed.test.QueriesTableTest
org.apache.cassandra.distributed.test.RenamedGroupByTest
jvm_upgrade_dtests_repeat:
org.apache.cassandra.distributed.upgrade.MixedModeMessageForwardTest
org.apache.cassandra.distributed.upgrade.NewMixedModeAvailabilityV3XOneAllTest
org.apache.cassandra.distributed.upgrade.RenamedMixedModeWritetimeOrTTLTest
{code}
Note that the actual diff is done on CircleCI, and this is only a preview mode
for local use. The reason for doing the diff on Circle is that using the
{{generate.sh}} script is optional, and users can directly use the provided
{{config.yml}} files.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17939) CircleCI: Automatically detect and repeat new or modified JUnit tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615625#comment-17615625
]
Andres de la Peña commented on CASSANDRA-17939:
---
[~jmckenzie] thanks for looking into this.
{quote}+1 to junit only; we should be avoiding adding new python tests anyway
at this point. I see you've added repeat python tests as well which I wouldn't
say _no_ to. :)
{quote}
The automatic repetitions are only for JUnit tests. The changes in Python
dtests are just the renaming of the job and the ability to accept multiple
tests. This is done for consistency with the changes in the rest of the test
jobs.
{quote}Locally, you can run the same simple git command
Could we wrap this up in a flag to generate.sh in .circleci, {{generate.sh -d}}
or something to show auto-detected diff tests? Or at least doc how circle
derives it in readme.md so folks can run that themselves locally if they're
curious what tests get picked up and want to perhaps add some more.
First thing that pops for me - this command will (reasonably so) pop up all
tests that differ from upstream {_}including ones that are due to your branch
being stale and needing a rebase{_}, which further adds to the value of "double
check which tests will auto-populate from my branch" as a generate.sh command +
some output to say "hey, if you're seeing more than you expect you may need to
rebase".
{quote}
Yep, I'll do that in a bit. Note that the diff uses the three dot syntax, so it
should compare the current head of the patch branch to its fork point, not to
the head of the base branch. That is, it compares the head of the base branch
to the most recent commit that both the patch branch and the base branch have
in common. The diff should remain unchanged even if there are newer changes on
the base branch.
{quote}I wonder if we should remove the classic utest multiplexer from the
pre-commit workflows and leave it only on the separate workflows
+1 to moving to separate workflows only in favor of the new flow
{quote}
I have renamed the job to {{repeated_ant_test}} so it doesn't get confused with
the regular jobs. I have also removed it from the pre-commit workflows but left
it on the separate workflows. I think that moving it to a new pair of workflows
would add more noise/confussion that just leaving it on the separate workflows.
Those workflows are meant for debugging an/or fixing flakies, so I guess it
makes sense to have the special {{repeated_ant_test}} jobs there. Once we have
specific test jobs for all the available Ant targets we can just remove
{{{}repeated_ant_test{}}}.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> -
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17933) Zero length file in Audit log folder, prevents a node from starting
[
https://issues.apache.org/jira/browse/CASSANDRA-17933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615621#comment-17615621
]
Stefan Miklosovic commented on CASSANDRA-17933:
---
I have added 500x run on the added junit here (1)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1404/workflows/c28c0994-6bca-47f4-961d-8aab18c6dfef/jobs/6192
> Zero length file in Audit log folder, prevents a node from starting
> ---
>
> Key: CASSANDRA-17933
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17933
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Andrew Hogg
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Attachments: signature.asc
>
>
> We have encountered a 4.0.3 cluster where the audit log folder had a zero
> byte length file within it after the node had stopped. It is not clear how
> Cassandra got to the point of this file existing. On restarting the node, the
> node will not start and throws the following stack trace.
> {code:java}
> ERROR [main] 2022-09-26 14:01:27,892 CassandraDaemon.java:911 - Exception
> encountered during startup
> java.lang.ExceptionInInitializerError: null
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:468)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:765)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:889)
> Caused by: org.apache.cassandra.exceptions.ConfigurationException: Unable to
> create instance of IAuditLogger.
> at
> org.apache.cassandra.utils.FBUtilities.newAuditLogger(FBUtilities.java:686)
> at
> org.apache.cassandra.audit.AuditLogManager.getAuditLogger(AuditLogManager.java:95)
> at
> org.apache.cassandra.audit.AuditLogManager.(AuditLogManager.java:74)
> at
> org.apache.cassandra.audit.AuditLogManager.(AuditLogManager.java:60)
> ... 3 common frames omitted
> Caused by: java.lang.reflect.InvocationTargetException: null
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.cassandra.utils.FBUtilities.newAuditLogger(FBUtilities.java:682)
> ... 6 common frames omitted
> Caused by: java.nio.channels.OverlappingFileLockException: null
> at sun.nio.ch.SharedFileLockTable.checkList(FileLockTable.java:255)
> at sun.nio.ch.SharedFileLockTable.add(FileLockTable.java:152)
> at sun.nio.ch.FileChannelImpl.lock(FileChannelImpl.java:1068)
> at java.nio.channels.FileChannel.lock(FileChannel.java:1053)
> at
> net.openhft.chronicle.bytes.MappedFile.resizeRafIfTooSmall(MappedFile.java:369)
> at
> net.openhft.chronicle.bytes.MappedFile.acquireByteStore(MappedFile.java:307)
> at
> net.openhft.chronicle.bytes.MappedFile.acquireByteStore(MappedFile.java:269)
> at
> net.openhft.chronicle.bytes.MappedBytes.acquireNextByteStore0(MappedBytes.java:434)
> at
> net.openhft.chronicle.bytes.MappedBytes.readVolatileInt(MappedBytes.java:792)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue$StoreSupplier.headerRecovery(SingleChronicleQueue.java:1027)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue$StoreSupplier.acquire(SingleChronicleQueue.java:981)
> at
> net.openhft.chronicle.queue.impl.WireStorePool.acquire(WireStorePool.java:53)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue.cleanupStoreFilesWithNoData(SingleChronicleQueue.java:821)
> at
> net.openhft.chronicle.queue.impl.single.StoreAppender.(StoreAppender.java:75)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue.newAppender(SingleChronicleQueue.java:422)
> at
> net.openhft.chronicle.core.threads.CleaningThreadLocal.initialValue(CleaningThreadLocal.java:54)
> at java.lang.ThreadLocal.setInitialValue(ThreadLocal.java:180)
> at java.lang.ThreadLocal.get(ThreadLocal.java:170)
> at
> net.openhft.chronicle.core.threads.CleaningThreadLocal.get(CleaningThreadLocal.java:59)
> at
> net.openhft.chronicle.queue.impl.single.SingleChronicleQueue.acquireAppender(SingleChronicleQueue.java:441)
> at org.apache.cassandra.utils.binlog.BinLog.(BinLog.java:133)
> at
[jira] [Updated] (CASSANDRA-17948) Get warning and errors through virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-17948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17948: -- Change Category: Operability Complexity: Normal Component/s: Feature/Virtual Tables Fix Version/s: 4.x Status: Open (was: Triage Needed) > Get warning and errors through virtual tables > - > > Key: CASSANDRA-17948 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17948 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Michiel Saelen >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Attachments: signature.asc > > > The warnings and errors are currently only accessible through Cassandra logs. > Automating the monitoring of the nodes would be much easier/secure if we can > make use of virtual tables to get the logs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17948) Get warning and errors through virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-17948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic reassigned CASSANDRA-17948: - Assignee: Stefan Miklosovic > Get warning and errors through virtual tables > - > > Key: CASSANDRA-17948 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17948 > Project: Cassandra > Issue Type: New Feature >Reporter: Michiel Saelen >Assignee: Stefan Miklosovic >Priority: Normal > Attachments: signature.asc > > > The warnings and errors are currently only accessible through Cassandra logs. > Automating the monitoring of the nodes would be much easier/secure if we can > make use of virtual tables to get the logs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615589#comment-17615589
]
Benjamin Lerer commented on CASSANDRA-17915:
\{quote}if we know which branches we're targeting\{quote}
Good point [~brandon.williams]. Operator support was added in 4.0 so we need to
fix 4.0, 4.1 and trunk. Now the patch should merge cleanly between branches
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17915:
---
Fix Version/s: (was: 3.11.x)
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17915) Confusing error message when using ? with functions
[
https://issues.apache.org/jira/browse/CASSANDRA-17915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17915:
---
Fix Version/s: 3.11.x
4.0.x
4.1.x
> Confusing error message when using ? with functions
> ---
>
> Key: CASSANDRA-17915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17915
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: David Capwell
>Assignee: Natnael Adere
>Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> INSERT INTO %S (a, b, c) VALUES (? + 1, ?, ?)
> {code}
> Errors saying
> {code}
> Ambiguous '+' operation with args ? and 1: use type casts to disambiguate
> {code}
> Now, if you google “type casts CQL” you get
> https://docs.datastax.com/en/dse/5.1/cql/cql/cql_reference/refCqlFunction.html
> which says to do
> {code}
> CAST( selector AS to_type )
> {code}
> But this also fails!
> {code}
> InvalidRequestException: Ambiguous call to function system.castAsFloat (can
> be matched by following signatures: system."castAsFloat" : (bigint) -> float,
> system."castAsFloat" : (counter) -> float, system."castAsFloat" : (double) ->
> float, system."castAsFloat" : (int) -> float, system."castAsFloat" :
> (tinyint) -> float, system."castAsFloat" : (varint) -> float,
> system."castAsFloat" : (decimal) -> float, system."castAsFloat" : (smallint)
> -> float): use type casts to disambiguate
> {code}
> What we have to do is
> {code}
> INSERT INTO %S (a, b, c) VALUES ((int) ? + 1, ?, ?)
> {code}
> We should improve the error message to show the expected syntax (or fix CAST
> to work in this case).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17918) DESCRIBE output does not quote column names using reserved keywords
[
https://issues.apache.org/jira/browse/CASSANDRA-17918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615579#comment-17615579
]
Benjamin Lerer commented on CASSANDRA-17918:
[~bernardo.botella] Thanks a lot for the patches :). Unfortunately, the
approach you took for the patches is not the correct one (the C* code base
isconfusing). Internally C* does not keep the quotes. It eliminates them on
input and add them back when recreating the statements for the DESCRIBE.
I added some information in the *Description* section to help you find the
parts of the code that need to be modified.
We changed the way DESCRIBE was working in C* 4.0 and moved it on the server
side before that DESCRIBE was implemented at the CQLSH level using the python
driver. This bug only affect 4.0, 4.1 and trunk. No need to worry about 3.11 :)
> DESCRIBE output does not quote column names using reserved keywords
> ---
>
> Key: CASSANDRA-17918
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17918
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
>Reporter: Yifan Cai
>Assignee: Bernardo Botella Corbi
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
>
> The DESCRIBE output of the column names that using reserved keywords are not
> quoted for UDTs. The following test reproduces. Reading the code, it looks
> like that the such columns names are not quoted in materialized view, UDF and
> user defined aggregation.
> The impact of the bug is that schema described cannot be imported due to the
> usage of reserved keywords as column names.
>
> {code:java}
> @Test
> public void testUsingReservedInCreateType() throws Throwable
> {
> String type = createType(KEYSPACE_PER_TEST, "CREATE TYPE %s
> (\"token\" text, \"desc\" text);");
> assertRowsNet(executeDescribeNet(KEYSPACE_PER_TEST, "DESCRIBE TYPE " + type),
> row(KEYSPACE_PER_TEST, "type", type, "CREATE TYPE " +
> KEYSPACE_PER_TEST + "." + type + " (\n" +
> " \"token\" text,\n" +
> " \"desc\" text\n" +
> ");"));
> } {code}
> +Additional information for newcomers:+
> * Unit tests for DESCRIBE statements are in {{DescribeStatementTest}}
> * The statement implementation is in {{DescribeStatement and fetch the
> create statement from the different schema element using
> SchemaElement.toCqlString}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17918) DESCRIBE output does not quote column names using reserved keywords
[
https://issues.apache.org/jira/browse/CASSANDRA-17918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17918:
---
Reviewers: Benjamin Lerer
> DESCRIBE output does not quote column names using reserved keywords
> ---
>
> Key: CASSANDRA-17918
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17918
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
>Reporter: Yifan Cai
>Assignee: Bernardo Botella Corbi
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
>
> The DESCRIBE output of the column names that using reserved keywords are not
> quoted for UDTs. The following test reproduces. Reading the code, it looks
> like that the such columns names are not quoted in materialized view, UDF and
> user defined aggregation.
> The impact of the bug is that schema described cannot be imported due to the
> usage of reserved keywords as column names.
>
> {code:java}
> @Test
> public void testUsingReservedInCreateType() throws Throwable
> {
> String type = createType(KEYSPACE_PER_TEST, "CREATE TYPE %s
> (\"token\" text, \"desc\" text);");
> assertRowsNet(executeDescribeNet(KEYSPACE_PER_TEST, "DESCRIBE TYPE " + type),
> row(KEYSPACE_PER_TEST, "type", type, "CREATE TYPE " +
> KEYSPACE_PER_TEST + "." + type + " (\n" +
> " \"token\" text,\n" +
> " \"desc\" text\n" +
> ");"));
> } {code}
> +Additional information for newcomers:+
> * Unit tests for DESCRIBE statements are in {{DescribeStatementTest}}
> * The statement implementation is in {{DescribeStatement and fetch the
> create statement from the different schema element using
> SchemaElement.toCqlString}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17918) DESCRIBE output does not quote column names using reserved keywords
[
https://issues.apache.org/jira/browse/CASSANDRA-17918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17918:
---
Fix Version/s: 4.0.x
4.1.x
> DESCRIBE output does not quote column names using reserved keywords
> ---
>
> Key: CASSANDRA-17918
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17918
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
>Reporter: Yifan Cai
>Assignee: Bernardo Botella Corbi
>Priority: Normal
> Fix For: 4.0.x, 4.1.x
>
>
> The DESCRIBE output of the column names that using reserved keywords are not
> quoted for UDTs. The following test reproduces. Reading the code, it looks
> like that the such columns names are not quoted in materialized view, UDF and
> user defined aggregation.
> The impact of the bug is that schema described cannot be imported due to the
> usage of reserved keywords as column names.
>
> {code:java}
> @Test
> public void testUsingReservedInCreateType() throws Throwable
> {
> String type = createType(KEYSPACE_PER_TEST, "CREATE TYPE %s
> (\"token\" text, \"desc\" text);");
> assertRowsNet(executeDescribeNet(KEYSPACE_PER_TEST, "DESCRIBE TYPE " + type),
> row(KEYSPACE_PER_TEST, "type", type, "CREATE TYPE " +
> KEYSPACE_PER_TEST + "." + type + " (\n" +
> " \"token\" text,\n" +
> " \"desc\" text\n" +
> ");"));
> } {code}
> +Additional information for newcomers:+
> * Unit tests for DESCRIBE statements are in {{DescribeStatementTest}}
> * The statement implementation is in {{DescribeStatement and fetch the
> create statement from the different schema element using
> SchemaElement.toCqlString}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17918) DESCRIBE output does not quote column names using reserved keywords
[
https://issues.apache.org/jira/browse/CASSANDRA-17918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17918:
---
Status: Open (was: Patch Available)
> DESCRIBE output does not quote column names using reserved keywords
> ---
>
> Key: CASSANDRA-17918
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17918
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
>Reporter: Yifan Cai
>Assignee: Bernardo Botella Corbi
>Priority: Normal
>
> The DESCRIBE output of the column names that using reserved keywords are not
> quoted for UDTs. The following test reproduces. Reading the code, it looks
> like that the such columns names are not quoted in materialized view, UDF and
> user defined aggregation.
> The impact of the bug is that schema described cannot be imported due to the
> usage of reserved keywords as column names.
>
> {code:java}
> @Test
> public void testUsingReservedInCreateType() throws Throwable
> {
> String type = createType(KEYSPACE_PER_TEST, "CREATE TYPE %s
> (\"token\" text, \"desc\" text);");
> assertRowsNet(executeDescribeNet(KEYSPACE_PER_TEST, "DESCRIBE TYPE " + type),
> row(KEYSPACE_PER_TEST, "type", type, "CREATE TYPE " +
> KEYSPACE_PER_TEST + "." + type + " (\n" +
> " \"token\" text,\n" +
> " \"desc\" text\n" +
> ");"));
> } {code}
> +Additional information for newcomers:+
> * Unit tests for DESCRIBE statements are in {{DescribeStatementTest}}
> * The statement implementation is in {{DescribeStatement and fetch the
> create statement from the different schema element using
> SchemaElement.toCqlString}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17918) DESCRIBE output does not quote column names using reserved keywords
[
https://issues.apache.org/jira/browse/CASSANDRA-17918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17918:
---
Description:
The DESCRIBE output of the column names that using reserved keywords are not
quoted for UDTs. The following test reproduces. Reading the code, it looks like
that the such columns names are not quoted in materialized view, UDF and user
defined aggregation.
The impact of the bug is that schema described cannot be imported due to the
usage of reserved keywords as column names.
{code:java}
@Test
public void testUsingReservedInCreateType() throws Throwable
{
String type = createType(KEYSPACE_PER_TEST, "CREATE TYPE %s (\"token\"
text, \"desc\" text);");
assertRowsNet(executeDescribeNet(KEYSPACE_PER_TEST, "DESCRIBE TYPE " + type),
row(KEYSPACE_PER_TEST, "type", type, "CREATE TYPE " +
KEYSPACE_PER_TEST + "." + type + " (\n" +
" \"token\" text,\n" +
" \"desc\" text\n" +
");"));
} {code}
+Additional information for newcomers:+
* Unit tests for DESCRIBE statements are in {{DescribeStatementTest}}
* The statement implementation is in {{DescribeStatement and fetch the create
statement from the different schema element using SchemaElement.toCqlString}}
was:
The DESCRIBE output of the column names that using reserved keywords are not
quoted for UDTs. The following test reproduces. Reading the code, it looks like
that the such columns names are not quoted in materialized view, UDF and user
defined aggregation.
The impact of the bug is that schema described cannot be imported due to the
usage of reserved keywords as column names.
{code:java}
@Test
public void testUsingReservedInCreateType() throws Throwable
{
String type = createType(KEYSPACE_PER_TEST, "CREATE TYPE %s (\"token\"
text, \"desc\" text);");
assertRowsNet(executeDescribeNet(KEYSPACE_PER_TEST, "DESCRIBE TYPE " + type),
row(KEYSPACE_PER_TEST, "type", type, "CREATE TYPE " +
KEYSPACE_PER_TEST + "." + type + " (\n" +
" \"token\" text,\n" +
" \"desc\" text\n" +
");"));
} {code}
+Additional information for newcomers:+
* Unit tests for DESCRIBE statements are in {{DescribeStatementTest}}
* The statement implementation is in {{DescribeStatement }}and fetch the
create statement from the different schema element using{{
SchemaElement.toCqlString}}
> DESCRIBE output does not quote column names using reserved keywords
> ---
>
> Key: CASSANDRA-17918
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17918
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL
>Reporter: Yifan Cai
>Assignee: Bernardo Botella Corbi
>Priority: Normal
>
> The DESCRIBE output of the column names that using reserved keywords are not
> quoted for UDTs. The following test reproduces. Reading the code, it looks
> like that the such columns names are not quoted in materialized view, UDF and
> user defined aggregation.
> The impact of the bug is that schema described cannot be imported due to the
> usage of reserved keywords as column names.
>
> {code:java}
> @Test
> public void testUsingReservedInCreateType() throws Throwable
> {
> String type = createType(KEYSPACE_PER_TEST, "CREATE TYPE %s
> (\"token\" text, \"desc\" text);");
> assertRowsNet(executeDescribeNet(KEYSPACE_PER_TEST, "DESCRIBE TYPE " + type),
> row(KEYSPACE_PER_TEST, "type", type, "CREATE TYPE " +
> KEYSPACE_PER_TEST + "." + type + " (\n" +
> " \"token\" text,\n" +
> " \"desc\" text\n" +
> ");"));
> } {code}
> +Additional information for newcomers:+
> * Unit tests for DESCRIBE statements are in {{DescribeStatementTest}}
> * The statement implementation is in {{DescribeStatement and fetch the
> create statement from the different schema element using
> SchemaElement.toCqlString}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Deleted] (CASSANDRA-17960) fcxgrtwetre
[ https://issues.apache.org/jira/browse/CASSANDRA-17960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe deleted CASSANDRA-17960: > fcxgrtwetre > --- > > Key: CASSANDRA-17960 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17960 > Project: Cassandra > Issue Type: Bug >Reporter: akian uba >Priority: Normal > > [https://wiki.lfnetworking.org/plugins/viewsource/viewpagesrc.action?pageId=74648253] > [https://wiki.tungsten.io/plugins/viewsource/viewpagesrc.action?pageId=62718118] > [https://wiki.onap.org/plugins/viewsource/viewpagesrc.action?pageId=149030431] > [https://wiki.opendaylight.org/plugins/viewsource/viewpagesrc.action?pageId=27067658] > [https://dotnetfiddle.net/CEbmLb] > [https://paste2.org/fwWBH426] > [https://www.geany.org/p/f1vzo/] > [https://pastelink.net/2juoy2o8] > [https://dotnetfiddle.net/0nzWRc] > [https://pastelink.net/0ak0re5n] > [https://www.geany.org/p/8i15L/] > [https://paste2.org/86xUm43d] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Deleted] (CASSANDRA-17959) vbnrtytrty
[ https://issues.apache.org/jira/browse/CASSANDRA-17959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe deleted CASSANDRA-17959: > vbnrtytrty > -- > > Key: CASSANDRA-17959 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17959 > Project: Cassandra > Issue Type: Bug >Reporter: akian uba >Priority: Normal > > [https://wiki.opendaylight.org/plugins/viewsource/viewpagesrc.action?pageId=27067652] > [https://wiki.onap.org/plugins/viewsource/viewpagesrc.action?pageId=149030427] > [https://wiki.tungsten.io/plugins/viewsource/viewpagesrc.action?pageId=62718114] > [https://wiki.lfnetworking.org/plugins/viewsource/viewpagesrc.action?pageId=74648249] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Deleted] (CASSANDRA-17958) vcrretret
[ https://issues.apache.org/jira/browse/CASSANDRA-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe deleted CASSANDRA-17958: > vcrretret > - > > Key: CASSANDRA-17958 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17958 > Project: Cassandra > Issue Type: Bug >Reporter: akian uba >Priority: Normal > > [https://wiki.opendaylight.org/plugins/viewsource/viewpagesrc.action?pageId=27067656] > [https://wiki.onap.org/plugins/viewsource/viewpagesrc.action?pageId=149030429] > [https://wiki.tungsten.io/plugins/viewsource/viewpagesrc.action?pageId=62718116] > [https://wiki.lfnetworking.org/plugins/viewsource/viewpagesrc.action?pageId=74648251] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (e5100071 -> cfeccf1a)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard e5100071 generate docs for 2af01b8f new cfeccf1a generate docs for 2af01b8f This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (e5100071) \ N -- N -- N refs/heads/asf-staging (cfeccf1a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17960) fcxgrtwetre
akian uba created CASSANDRA-17960: - Summary: fcxgrtwetre Key: CASSANDRA-17960 URL: https://issues.apache.org/jira/browse/CASSANDRA-17960 Project: Cassandra Issue Type: Bug Reporter: akian uba [https://wiki.lfnetworking.org/plugins/viewsource/viewpagesrc.action?pageId=74648253] [https://wiki.tungsten.io/plugins/viewsource/viewpagesrc.action?pageId=62718118] [https://wiki.onap.org/plugins/viewsource/viewpagesrc.action?pageId=149030431] [https://wiki.opendaylight.org/plugins/viewsource/viewpagesrc.action?pageId=27067658] [https://dotnetfiddle.net/CEbmLb] [https://paste2.org/fwWBH426] [https://www.geany.org/p/f1vzo/] [https://pastelink.net/2juoy2o8] [https://dotnetfiddle.net/0nzWRc] [https://pastelink.net/0ak0re5n] [https://www.geany.org/p/8i15L/] [https://paste2.org/86xUm43d] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
