[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[ https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517795#comment-17517795 ] ASF GitHub Bot commented on WICKET-6969: solomax commented on code in PR #509: URL: https://github.com/apache/wicket/pull/509#discussion_r843423501 ## wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketPushBroadcaster.java: ## @@ -189,7 +189,20 @@ private void process(final Application application, final Collection 0) Review Comment: I would drop this `if` and call the function with `timeout` > allow to process web socket push messages in an asynchronous way. > - > > Key: WICKET-6969 > URL: https://issues.apache.org/jira/browse/WICKET-6969 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Major > > Currently web socket push messages are always processed in a synchronous > way. Allow to configure applications to use by default asynchronous messages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [wicket] solomax commented on a diff in pull request #509: {WICKET-6969} allow asynchronous pushing of messages.
solomax commented on code in PR #509: URL: https://github.com/apache/wicket/pull/509#discussion_r843423501 ## wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketPushBroadcaster.java: ## @@ -189,7 +189,20 @@ private void process(final Application application, final Collection 0) Review Comment: I would drop this `if` and call the function with `timeout` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517794#comment-17517794
]
ASF GitHub Bot commented on WICKET-6969:
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843422972
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketResponse.java:
##
@@ -87,13 +100,34 @@ public void close()
{
if (text != null)
{
- connection.sendMessage(text.toString());
+ if (asynchronous)
+ {
+ if (timeout > 0)
Review Comment:
I would drop this `if` in favor of
`connection.sendMessageAsync(text.toString(), timeout);`
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [wicket] solomax commented on a diff in pull request #509: {WICKET-6969} allow asynchronous pushing of messages.
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843422972
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketResponse.java:
##
@@ -87,13 +100,34 @@ public void close()
{
if (text != null)
{
- connection.sendMessage(text.toString());
+ if (asynchronous)
+ {
+ if (timeout > 0)
Review Comment:
I would drop this `if` in favor of
`connection.sendMessageAsync(text.toString(), timeout);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517792#comment-17517792
]
ASF GitHub Bot commented on WICKET-6969:
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843422352
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketResponse.java:
##
@@ -47,9 +47,22 @@
private boolean isRedirect = false;
+ private final boolean asynchronous;
+
+ private final long timeout;
+
public WebSocketResponse(final IWebSocketConnection conn)
{
this.connection = conn;
Review Comment:
this can be replaced with `this(conn, false, -1)`
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [wicket] solomax commented on a diff in pull request #509: {WICKET-6969} allow asynchronous pushing of messages.
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843422352
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketResponse.java:
##
@@ -47,9 +47,22 @@
private boolean isRedirect = false;
+ private final boolean asynchronous;
+
+ private final long timeout;
+
public WebSocketResponse(final IWebSocketConnection conn)
{
this.connection = conn;
Review Comment:
this can be replaced with `this(conn, false, -1)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[ https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517791#comment-17517791 ] ASF GitHub Bot commented on WICKET-6969: solomax commented on code in PR #509: URL: https://github.com/apache/wicket/pull/509#discussion_r843422043 ## wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketRequestHandler.java: ## @@ -97,6 +128,36 @@ public void push(byte[] message, int offset, int length) } } + @Override + public Future pushAsync(byte[] message, int offset, int length) Review Comment: I would replace this method with `return pushAsync(message, offset, length, -1)` > allow to process web socket push messages in an asynchronous way. > - > > Key: WICKET-6969 > URL: https://issues.apache.org/jira/browse/WICKET-6969 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Major > > Currently web socket push messages are always processed in a synchronous > way. Allow to configure applications to use by default asynchronous messages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [wicket] solomax commented on a diff in pull request #509: {WICKET-6969} allow asynchronous pushing of messages.
solomax commented on code in PR #509: URL: https://github.com/apache/wicket/pull/509#discussion_r843422043 ## wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketRequestHandler.java: ## @@ -97,6 +128,36 @@ public void push(byte[] message, int offset, int length) } } + @Override + public Future pushAsync(byte[] message, int offset, int length) Review Comment: I would replace this method with `return pushAsync(message, offset, length, -1)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517790#comment-17517790
]
ASF GitHub Bot commented on WICKET-6969:
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843421689
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketRequestHandler.java:
##
@@ -77,6 +78,36 @@ public void push(CharSequence message)
}
}
+ @Override
+ public Future pushAsync(CharSequence message, long timeout)
+ {
+ if (connection.isOpen())
+ {
+ Args.notNull(message, "message");
+ return connection.sendMessageAsync(message.toString(),
timeout);
+ }
+ else
+ {
+ LOG.warn("The websocket connection is already closed.
Cannot push the text message '{}'", message);
+ }
+ return null;
+ }
+
+ @Override
+ public Future pushAsync(CharSequence message)
Review Comment:
I would replace this method with `return pushAsync(message, -1)`
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [wicket] solomax commented on a diff in pull request #509: {WICKET-6969} allow asynchronous pushing of messages.
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843421689
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketRequestHandler.java:
##
@@ -77,6 +78,36 @@ public void push(CharSequence message)
}
}
+ @Override
+ public Future pushAsync(CharSequence message, long timeout)
+ {
+ if (connection.isOpen())
+ {
+ Args.notNull(message, "message");
+ return connection.sendMessageAsync(message.toString(),
timeout);
+ }
+ else
+ {
+ LOG.warn("The websocket connection is already closed.
Cannot push the text message '{}'", message);
+ }
+ return null;
+ }
+
+ @Override
+ public Future pushAsync(CharSequence message)
Review Comment:
I would replace this method with `return pushAsync(message, -1)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517789#comment-17517789
]
ASF GitHub Bot commented on WICKET-6969:
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843420871
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketPushBroadcaster.java:
##
@@ -189,7 +189,20 @@ private void process(final Application application, final
Collection 0)
+ {
+
wsConnection.sendMessageAsync(message,
webSocketSettings.getAsynchronousPushTimeout());
+ }
+ else {
Review Comment:
`else {` ->
```
else
{
```
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [wicket] solomax commented on a diff in pull request #509: {WICKET-6969} allow asynchronous pushing of messages.
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843420871
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketPushBroadcaster.java:
##
@@ -189,7 +189,20 @@ private void process(final Application application, final
Collection 0)
+ {
+
wsConnection.sendMessageAsync(message,
webSocketSettings.getAsynchronousPushTimeout());
+ }
+ else {
Review Comment:
`else {` ->
```
else
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517784#comment-17517784
]
ASF GitHub Bot commented on WICKET-6969:
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843419552
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java:
##
@@ -305,7 +320,20 @@ public IWebSocketConnectionFilter getConnectionFilter()
*/
public WebResponse newWebSocketResponse(IWebSocketConnection connection)
{
- return new WebSocketResponse(connection);
+ return new WebSocketResponse(connection, isAsynchronousPush(),
getAsynchronousPushTimeout());
+ }
+
+ /**
+* A factory method for the {@link
org.apache.wicket.request.http.WebResponse}
+* that should be used to write the response back to the client/browser
+*
+* @param connection
+* The active web socket connection
+* @return the response object that should be used to write the
response back to the client
+*/
+ public WebResponse newWebSocketResponse(IWebSocketConnection
connection, boolean asynchronousPush, long timeout)
Review Comment:
extra whitespace :)
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [wicket] solomax commented on a diff in pull request #509: {WICKET-6969} allow asynchronous pushing of messages.
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843419552
##
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java:
##
@@ -305,7 +320,20 @@ public IWebSocketConnectionFilter getConnectionFilter()
*/
public WebResponse newWebSocketResponse(IWebSocketConnection connection)
{
- return new WebSocketResponse(connection);
+ return new WebSocketResponse(connection, isAsynchronousPush(),
getAsynchronousPushTimeout());
+ }
+
+ /**
+* A factory method for the {@link
org.apache.wicket.request.http.WebResponse}
+* that should be used to write the response back to the client/browser
+*
+* @param connection
+* The active web socket connection
+* @return the response object that should be used to write the
response back to the client
+*/
+ public WebResponse newWebSocketResponse(IWebSocketConnection
connection, boolean asynchronousPush, long timeout)
Review Comment:
extra whitespace :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[ https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517692#comment-17517692 ] ASF GitHub Bot commented on WICKET-6969: reiern70 commented on PR #509: URL: https://github.com/apache/wicket/pull/509#issuecomment-1089318912 Fixed some API breaks. > allow to process web socket push messages in an asynchronous way. > - > > Key: WICKET-6969 > URL: https://issues.apache.org/jira/browse/WICKET-6969 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Major > > Currently web socket push messages are always processed in a synchronous > way. Allow to configure applications to use by default asynchronous messages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [wicket] reiern70 commented on pull request #509: {WICKET-6969} allow asynchronous pushing of messages.
reiern70 commented on PR #509: URL: https://github.com/apache/wicket/pull/509#issuecomment-1089318912 Fixed some API breaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517684#comment-17517684
]
ASF subversion and git services commented on WICKET-6969:
-
Commit 3ae2f76baf9773616c09236766a37d935b1bef78 in wicket's branch
refs/heads/feature/reiern70/WICKET-6969 from reiern70
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=3ae2f76baf ]
{WICKET-6969} allow asynchronous pushing of messages.
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[wicket] branch feature/reiern70/WICKET-6969 updated (e0bb247381 -> 3ae2f76baf)
This is an automated email from the ASF dual-hosted git repository.
reiern70 pushed a change to branch feature/reiern70/WICKET-6969
in repository https://gitbox.apache.org/repos/asf/wicket.git
from e0bb247381 {WICKET-6969} allow asynchronous pushing of messages.
add 3ae2f76baf {WICKET-6969} allow asynchronous pushing of messages.
No new revisions were added by this update.
Summary of changes:
.../org/apache/wicket/protocol/ws/api/WebSocketResponse.java | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517682#comment-17517682
]
ASF subversion and git services commented on WICKET-6969:
-
Commit e0bb2473811c5ee7cf2b71db183c8306827f7d02 in wicket's branch
refs/heads/feature/reiern70/WICKET-6969 from reiern70
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=e0bb247381 ]
{WICKET-6969} allow asynchronous pushing of messages.
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[wicket] branch feature/reiern70/WICKET-6969 updated (835ff5953f -> e0bb247381)
This is an automated email from the ASF dual-hosted git repository.
reiern70 pushed a change to branch feature/reiern70/WICKET-6969
in repository https://gitbox.apache.org/repos/asf/wicket.git
from 835ff5953f {WICKET-6969} allow asynchronous pushing of messages.
add e0bb247381 {WICKET-6969} allow asynchronous pushing of messages.
No new revisions were added by this update.
Summary of changes:
.../org/apache/wicket/protocol/ws/WebSocketSettings.java| 13 +
1 file changed, 13 insertions(+)
[jira] [Commented] (WICKET-6968) SubmitLink results in submission without charset resulting in string corruption
[ https://issues.apache.org/jira/browse/WICKET-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517676#comment-17517676 ] Robert Murphy commented on WICKET-6968: --- Thank you Sven > SubmitLink results in submission without charset resulting in string > corruption > --- > > Key: WICKET-6968 > URL: https://issues.apache.org/jira/browse/WICKET-6968 > Project: Wicket > Issue Type: Bug > Components: wicket-core >Affects Versions: 9.1.0 > Environment: Ran into this issue running Wicket in WildFly > 20.0.1.Final in Java 11 in CentOS Linux release 7.6.1810 (Core) and in > Windows 11 >Reporter: Robert Murphy >Assignee: Sven Meier >Priority: Major > > Castañeda becomes Castañeda when SubmitLink is used to submit form. Same > exact code except for using AjaxFallbackButton does not corrupt the string. > Difference noted between the form submission with SubmitLink and the form > submission with AjaxFallbackButton is that AjaxFallbackButton specifies the > charset in the content-type and SubmitLink does not. > content-type: application/x-www-form-urlencoded > vs > content-type: application/x-www-form-urlencoded; charset=UTF-8 > where the latter would appear to be correct to me -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (WICKET-6968) SubmitLink results in submission without charset resulting in string corruption
[ https://issues.apache.org/jira/browse/WICKET-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517675#comment-17517675 ] Sven Meier commented on WICKET-6968: The decoding of the url is done by your servlet container, not Wicket. You have to configure your server accordingly. > SubmitLink results in submission without charset resulting in string > corruption > --- > > Key: WICKET-6968 > URL: https://issues.apache.org/jira/browse/WICKET-6968 > Project: Wicket > Issue Type: Bug > Components: wicket-core >Affects Versions: 9.1.0 > Environment: Ran into this issue running Wicket in WildFly > 20.0.1.Final in Java 11 in CentOS Linux release 7.6.1810 (Core) and in > Windows 11 >Reporter: Robert Murphy >Assignee: Sven Meier >Priority: Major > > Castañeda becomes Castañeda when SubmitLink is used to submit form. Same > exact code except for using AjaxFallbackButton does not corrupt the string. > Difference noted between the form submission with SubmitLink and the form > submission with AjaxFallbackButton is that AjaxFallbackButton specifies the > charset in the content-type and SubmitLink does not. > content-type: application/x-www-form-urlencoded > vs > content-type: application/x-www-form-urlencoded; charset=UTF-8 > where the latter would appear to be correct to me -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517602#comment-17517602
]
ASF subversion and git services commented on WICKET-6969:
-
Commit 835ff5953f64ed60cfc0e8270b313c59bb864c97 in wicket's branch
refs/heads/feature/reiern70/WICKET-6969 from reiern70
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=835ff5953f ]
{WICKET-6969} allow asynchronous pushing of messages.
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[wicket] branch feature/reiern70/WICKET-6969 updated (e06de412c9 -> 835ff5953f)
This is an automated email from the ASF dual-hosted git repository.
reiern70 pushed a change to branch feature/reiern70/WICKET-6969
in repository https://gitbox.apache.org/repos/asf/wicket.git
discard e06de412c9 {WICKET-6969} allow asynchronous pushing of messages.
discard 021b63d875 {WICKET-6969} allow asynchronous pushing of messages.
add 835ff5953f {WICKET-6969} allow asynchronous pushing of messages.
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (e06de412c9)
\
N -- N -- N refs/heads/feature/reiern70/WICKET-6969 (835ff5953f)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517601#comment-17517601
]
ASF subversion and git services commented on WICKET-6969:
-
Commit e06de412c9a800a8ebe9f58a3c10f67a3002f3a2 in wicket's branch
refs/heads/feature/reiern70/WICKET-6969 from reiern70
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=e06de412c9 ]
{WICKET-6969} allow asynchronous pushing of messages.
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[wicket] branch feature/reiern70/WICKET-6969 updated (021b63d875 -> e06de412c9)
This is an automated email from the ASF dual-hosted git repository.
reiern70 pushed a change to branch feature/reiern70/WICKET-6969
in repository https://gitbox.apache.org/repos/asf/wicket.git
from 021b63d875 {WICKET-6969} allow asynchronous pushing of messages.
add e06de412c9 {WICKET-6969} allow asynchronous pushing of messages.
No new revisions were added by this update.
Summary of changes:
.../wicket/examples/websocket/JSR356Application.java | 5 +++--
.../examples/websocket/progress/ProgressUpdater.java | 5 -
.../apache/wicket/protocol/ws/WebSocketSettings.java | 20 ++--
.../protocol/ws/api/AbstractWebSocketConnection.java | 10 --
.../protocol/ws/api/AbstractWebSocketProcessor.java | 8
.../wicket/protocol/ws/api/IWebSocketConnection.java | 14 ++
.../protocol/ws/api/WebSocketPushBroadcaster.java| 8 +++-
.../wicket/protocol/ws/api/WebSocketResponse.java| 14 --
.../ws/util/tester/TestWebSocketProcessor.java | 6 ++
.../protocol/ws/javax/JavaxWebSocketProcessor.java | 2 --
10 files changed, 72 insertions(+), 20 deletions(-)
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[ https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517555#comment-17517555 ] ASF GitHub Bot commented on WICKET-6969: reiern70 opened a new pull request, #509: URL: https://github.com/apache/wicket/pull/509 WIP: do not review just yet. > allow to process web socket push messages in an asynchronous way. > - > > Key: WICKET-6969 > URL: https://issues.apache.org/jira/browse/WICKET-6969 > Project: Wicket > Issue Type: Improvement >Reporter: Ernesto Reinaldo Barreiro >Priority: Major > > Currently web socket push messages are always processed in a synchronous > way. Allow to configure applications to use by default asynchronous messages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [wicket] reiern70 opened a new pull request, #509: {WICKET-6969} allow asynchronous pushing of messages.
reiern70 opened a new pull request, #509: URL: https://github.com/apache/wicket/pull/509 WIP: do not review just yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517552#comment-17517552
]
ASF subversion and git services commented on WICKET-6969:
-
Commit 021b63d8752da8d679a2f5f0ee0f89b74f8b03af in wicket's branch
refs/heads/feature/reiern70/WICKET-6969 from reiern70
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=021b63d875 ]
{WICKET-6969} allow asynchronous pushing of messages.
> allow to process web socket push messages in an asynchronous way.
> -
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
>Reporter: Ernesto Reinaldo Barreiro
>Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[wicket] branch feature/reiern70/WICKET-6969 created (now 021b63d875)
This is an automated email from the ASF dual-hosted git repository.
reiern70 pushed a change to branch feature/reiern70/WICKET-6969
in repository https://gitbox.apache.org/repos/asf/wicket.git
at 021b63d875 {WICKET-6969} allow asynchronous pushing of messages.
This branch includes the following new commits:
new 021b63d875 {WICKET-6969} allow asynchronous pushing of messages.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[wicket] 01/01: {WICKET-6969} allow asynchronous pushing of messages.
This is an automated email from the ASF dual-hosted git repository.
reiern70 pushed a commit to branch feature/reiern70/WICKET-6969
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit 021b63d8752da8d679a2f5f0ee0f89b74f8b03af
Author: reiern70
AuthorDate: Tue Apr 5 10:06:11 2022 -0600
{WICKET-6969} allow asynchronous pushing of messages.
---
.../wicket/protocol/ws/WebSocketSettings.java | 31 ---
.../ws/api/AbstractWebSocketConnection.java| 10 +++-
.../ws/api/AbstractWebSocketProcessor.java | 8 +--
.../protocol/ws/api/IWebSocketConnection.java | 21 ++--
.../protocol/ws/api/IWebSocketRequestHandler.java | 54 +++
.../protocol/ws/api/WebSocketPushBroadcaster.java | 9 +++-
.../protocol/ws/api/WebSocketRequestHandler.java | 61 ++
.../wicket/protocol/ws/api/WebSocketResponse.java | 23 ++--
.../ws/util/tester/TestWebSocketConnection.java| 5 +-
.../ws/util/tester/TestWebSocketProcessor.java | 6 +++
10 files changed, 206 insertions(+), 22 deletions(-)
diff --git
a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
index df78a18bbf..e151b1f3d3 100644
---
a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
+++
b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
@@ -158,11 +158,18 @@ public class WebSocketSettings
*/
private Function notifyOnCloseEvent = (code) -> true;
- public boolean shouldNotifyOnCloseEvent(int closeCode) {
+ /**
+* Flag that allows to use asynchronous push. By default, it is set to
false.
+*/
+ private boolean asynchronousPush = false;
+
+ public boolean shouldNotifyOnCloseEvent(int closeCode)
+ {
return notifyOnCloseEvent == null ||
notifyOnCloseEvent.apply(closeCode);
}
- public void setNotifyOnCloseEvent(Function
notifyOnCloseEvent) {
+ public void setNotifyOnCloseEvent(Function
notifyOnCloseEvent)
+ {
this.notifyOnCloseEvent = notifyOnCloseEvent;
}
@@ -174,11 +181,13 @@ public class WebSocketSettings
*/
private Function notifyOnErrorEvent = (throwable)
-> true;
- public boolean shouldNotifyOnErrorEvent(Throwable throwable) {
+ public boolean shouldNotifyOnErrorEvent(Throwable throwable)
+ {
return notifyOnErrorEvent == null ||
notifyOnErrorEvent.apply(throwable);
}
- public void setNotifyOnErrorEvent(Function
notifyOnErrorEvent) {
+ public void setNotifyOnErrorEvent(Function
notifyOnErrorEvent)
+ {
this.notifyOnErrorEvent = notifyOnErrorEvent;
}
@@ -303,9 +312,9 @@ public class WebSocketSettings
* The active web socket connection
* @return the response object that should be used to write the
response back to the client
*/
- public WebResponse newWebSocketResponse(IWebSocketConnection connection)
+ public WebResponse newWebSocketResponse(IWebSocketConnection
connection, boolean asynchronousPush)
{
- return new WebSocketResponse(connection);
+ return new WebSocketResponse(connection, asynchronousPush);
}
/**
@@ -497,4 +506,14 @@ public class WebSocketSettings
return new Thread(r,
"Wicket-WebSocket-HttpRequest-Thread-" + counter.getAndIncrement());
}
}
+
+ public void setAsynchronousPush(boolean asynchronousPush)
+ {
+ this.asynchronousPush = asynchronousPush;
+ }
+
+ public boolean isAsynchronousPush()
+ {
+ return asynchronousPush;
+ }
}
diff --git
a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketConnection.java
b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketConnection.java
index 3cd0f627d4..c9b64029b7 100644
---
a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketConnection.java
+++
b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketConnection.java
@@ -21,6 +21,8 @@ import
org.apache.wicket.protocol.ws.api.message.IWebSocketPushMessage;
import org.apache.wicket.protocol.ws.api.registry.IKey;
import org.apache.wicket.util.lang.Args;
+import java.util.concurrent.Future;
+
/**
* Abstract class handling the Web Socket broadcast messages.
*/
@@ -50,7 +52,13 @@ public abstract class Abstrac
[jira] [Created] (WICKET-6969) allow to process web socket push messages in an asynchronous way.
Ernesto Reinaldo Barreiro created WICKET-6969: - Summary: allow to process web socket push messages in an asynchronous way. Key: WICKET-6969 URL: https://issues.apache.org/jira/browse/WICKET-6969 Project: Wicket Issue Type: Improvement Reporter: Ernesto Reinaldo Barreiro Currently web socket push messages are always processed in a synchronous way. Allow to configure applications to use by default asynchronous messages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [wicket] renoth opened a new pull request, #508: Add Resource key to be logged on Warning in Localizer.java
renoth opened a new pull request, #508: URL: https://github.com/apache/wicket/pull/508 Suggestion: It would be very helpful to log the Resource key as well to easier identify the problem. Is this be security-sensitive? Can this be exploited somehow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
