svn commit: r169778 - in /jakarta/commons/proper/discovery: branches/listener-model/ tags/sandbox/
Author: skitching Date: Wed May 11 23:15:18 2005 New Revision: 169778 URL: http://svn.apache.org/viewcvs?rev=169778view=rev Log: Oops. The sandbox directory under trunk was not the code from commons-sandbox but rather an experimental refactoring of the trunk code. I think it should still be moved out of trunk, but a better place would be the branches directory. The README within the directory describes the refactoring as a listener model, so that's what I've called the branch. Added: jakarta/commons/proper/discovery/branches/listener-model/ - copied from r169777, jakarta/commons/proper/discovery/tags/sandbox/ Removed: jakarta/commons/proper/discovery/tags/sandbox/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of JakartaCommonsEtiquette by SimonKitching
Dear Wiki user, You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki for change notification. The following page has been changed by SimonKitching: http://wiki.apache.org/jakarta-commons/JakartaCommonsEtiquette -- The sandbox is a space provided by Jakarta for the development of experimental code by existing committers. It is divided into components. - Any Jakarta committer has the right ask for karma and have it granted. The right place to ask is on the commons-dev mailing list. + Any Jakarta committer (not just commons committers) has the right ask for karma (commit access) and have it granted. The right place to ask is on the commons-dev mailing list. - Components cannot be released from the sandbox. + Components cannot be released from the sandbox. This means no binaries posted anywere on the apache site as 0.x releases, as this implies that Apache supports the released code. Users of sandbox code are expected to extract the latest source from the source code repository and build the code themselves. + + Commit access to the sandbox is unfortunately '''not''' available to people who are not existing Jakarta committers, no matter how good their idea. Such projects are generally encouraged to start somewhere like sourceforge.net. Once a solid community has been established and existing projects are using the component, it may be possible to integrate the project direct into commons if the project developers feel that is appropriate, and the commons community feels the component is a good fit with commons goals. = Sandbox Etiquette = @@ -48, +50 @@ There is one important point about the list on the STATUS file. It is used to work out whose VOTEs are binding. (Since there are a lot of commons committers, this is more useful than it might first seem.) If you're name isn't on the list, your vote won't count :) + For components that use '''Maven''' as their build tool (and that is most of them now), you should add your name to the developers list in the project.xml file rather than the STATUS file if you intend to work on a component. + = VOTEs = The commons-dev mailing list is a busy place. Very much a bazaar rather than a Cathedral. This means that VOTE threads have a habit of petering out. It a good idea to post a tt[VOTE][RESULT]/tt which counts the binding VOTEs and tells people the result. @@ -60, +64 @@ Promotion to the commons proper is not the only route out of the sandbox. The commons proper isn't always the best place for all components from the sandbox. There isn't any reason why a component couldn't move directly from the sandbox to become a project or a subproject. At least one component has moved from the sandbox to sourceforge and then finally back to the incubator. - Promotion is basically a beauty contest. If the component can win enough votes and few enough people vote against it, then the component is promoted. But there is one thing that is most definitly required: + Promotion is basically a beauty contest. If the component can win enough votes and few enough people vote against it, then the component is promoted. But there is one thing that is most definitely required: * Compliance with Apache Software Federation policies. This means a full license at the top of every file. It means auditing the dependencies. It means ensuring the copyright date is correct on the licenses. @@ -70, +74 @@ * A good PROPOSAL. A good PROPOSAL is clearly written and tightly scoped (ie. specific rather than general). Commons components are small, resuable components. The commons does not do frameworks and anything frameworkesque is likely to be viewed with scepticism. A PROPOSAL that duplicates an existing component will probably be viewed with suspicion. This is not because duplication is disallowed (overlapping components are specifically allowed by the charter) but because it indicates that the PROPOSAL fails to indicate the essential difference between the proposed component and the existing one. For example, a PROSPOSAL for a small, fast, compact xml-object mapper with minimal dependencies would be more likely to succeed than a PROPOSAL for 'a better version of commons-digester'. - * The health of the development community. Fellow committers need to be persuaded that users will be supported and the code pushed forward by the listed committers. This is a major issue since there's only a limited amount of energy amongst the commons committers and no one wants to have to support a component whose committers have gone AWAL. + * The health of the development community. Fellow committers need to be persuaded that users will be supported and the code pushed forward by the listed committers. This is a major issue since there's only a limited amount of energy amongst the commons committers and no
[Jakarta-commons Wiki] Update of JakartaCommonsEtiquette by SimonKitching
Dear Wiki user, You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki for change notification. The following page has been changed by SimonKitching: http://wiki.apache.org/jakarta-commons/JakartaCommonsEtiquette -- = Sandbox Oversight = - Oversight for the sandbox is provided by the Commons team. Oversight means responsibility for ensuring that everything in the sandbox complies with Apache Software Foundation policies. Though (it is to be hoped that) committers should be able to be trusted, in the last resort the Commons team reserves the right to remove offending material from CVS. + Oversight for the sandbox is provided by the Commons team. Oversight means responsibility for ensuring that everything in the sandbox complies with Apache Software Foundation policies. Though (it is to be hoped that) committers should be able to be trusted, in the last resort the Commons team reserves the right to remove offending material from the source code repository. If questionable material is found, the right way to proceed is to first raise the matter on the commons-dev mailing list. The community will form a judgement about the material and the committers will be able to respond. It's a good idea to inform the committers directly (in case they are not on the list). It's also a good idea to copy the Jakarta PMC. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
moving code from sandbox to proper - best practice?
Hi,
The moving from sandbox to proper wiki page needs updating, as it is
all CVS based.
http://wiki.apache.org/jakarta-commons/MovingFromSandboxToProper
The main question that needs resolving is:
* should the code be MOVED from sandbox to proper, or COPIED?
Moving the code means that links to the old location break. But copying
the code means that links to the old stuff don't give any indication
that the main development is now happening elsewhere.
What do people think the best practice is for sandbox-proper promotion?
I think my preference would be
* move the existing code to {proj}/tags/sandbox
* copy to {proj}/trunk
* create a new sandbox/{proj} directory, containing just a README
that points to the new project.
That way, all the sandbox code vanishes from its old location, avoiding
any confusion. But users of the sandbox stuff at least get a hint where
the new stuff is.
The main disadvantage is clutter left in the sandbox directory.
Thoughts?
Regards,
Simon
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[VFS][ALL] Help on promotion
Hello! Due to user request I would like to start a promotion to get commons-vfs out of the sandbox. Now I have read the etiquette to see what is needet http://wiki.apache.org/jakarta-commons/JakartaCommonsEtiquette The health of the development community. Fellow committers need to be persuaded that users will be supported and the code pushed forward by the listed committers. This is a major issue since there's only a limited amount of energy amongst the commons committers and no one wants to have to support a component whose committers have gone AWAL. This makes me wondering if any promotion started by me might succeed? Currently I am the only active committer and I cant see someone who might follow. Is this a no-go for the promotion? --- Mario - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34886] New: - make long converter more resistant to extra white-spaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34886. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34886 Summary: make long converter more resistant to extra white-spaces Product: Commons Version: unspecified Platform: All OS/Version: other Status: NEW Severity: enhancement Priority: P4 Component: Bean Utilities AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] a .trim() and removing interspersed white-spaces might make this more user-friendly as per Bug 33630. Another option might be to remove NLS-dependent delimiters such as the ' in 1'000'000'000'000'000 -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[discovery] 0.3 release
Hi Rory, As I said in an earlier email, I hope you don't mind me getting involved in preparing for the Discovery release. No-one gave a -1...but I can back out anything that you disagree with. * I've checked the website (maven site:generate) and it all looks good. * The release notes are complete, and there don't seem to be any controversial changes since 0.2; all the patches seem reasonably obvious. * The unit tests all pass. * project.properties has been updated so that no matter what JDK the code is built with, a 1.1-compatible jar should result. Note, however, that this doesn't check whether code uses libs not available in that JDK distribution. * there are quite a few errors reported when generating the javadoc, but I presume this is no worse than the 0.2 release, so personally I'm ok with releasing this as-is. As far as I can see, it's now just a matter of creating a RC1 tag, posting the jar and website somewhere, and calling a vote. Of course I've never done a release before, so take that with a few grains of salt :-) Cheers, Simon - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34886] - [beanutils] Make long converter more resistant to extra white-spaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34886. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34886 [EMAIL PROTECTED] changed: What|Removed |Added Summary|make long converter more|[beanutils] Make long |resistant to extra white- |converter more resistant to |spaces |extra white-spaces -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Jakarta-commons Wiki] Update of JakartaCommonsEtiquette by SimonKitching
SimonKitching wrote: + Any Jakarta committer (not just commons committers) has the right ask for karma (commit access) and have it granted. The right place to ask is on the commons-dev mailing list. + Commit access to the sandbox is unfortunately '''not''' available to people who are not existing Jakarta committers, no matter how good their idea. Such projects are generally encouraged to start somewhere like sourceforge.net. Once a solid community has been established and existing projects are using the component, it may be possible to integrate the project direct into commons if the project developers feel that is appropriate, and the commons community feels the component is a good fit with commons goals. And if I am not currently a Jakarta commiter, but would like sandbox commit access for existing sandbox projects? /Mattias Jiderhamn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34887] New: - [configuration] Disabling property interpolation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34887. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34887 Summary: [configuration] Disabling property interpolation Product: Commons Version: Nightly Builds Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Configuration AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] We need a mechanism to disable to interpolation. A simple interpolationEnabled flag in AbstractConfiguration would do it. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [discovery] 0.3 release
Hi Simon, Not at all, I appreciate your help. It all sounds good to me. I'm currently waiting for a final confirmation from Fernando as to whether 0.3 fulfills his needs, then we can tag and release. The vote has been done already. Cheers Rory [EMAIL PROTECTED] wrote: Hi Rory, As I said in an earlier email, I hope you don't mind me getting involved in preparing for the Discovery release. No-one gave a -1...but I can back out anything that you disagree with. * I've checked the website (maven site:generate) and it all looks good. * The release notes are complete, and there don't seem to be any controversial changes since 0.2; all the patches seem reasonably obvious. * The unit tests all pass. * project.properties has been updated so that no matter what JDK the code is built with, a 1.1-compatible jar should result. Note, however, that this doesn't check whether code uses libs not available in that JDK distribution. * there are quite a few errors reported when generating the javadoc, but I presume this is no worse than the 0.2 release, so personally I'm ok with releasing this as-is. As far as I can see, it's now just a matter of creating a RC1 tag, posting the jar and website somewhere, and calling a vote. Of course I've never done a release before, so take that with a few grains of salt :-) Cheers, Simon - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ Sign up for eircom broadband now and get a free two month trial.* Phone 1850 73 00 73 or visit http://home.eircom.net/broadbandoffer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [discovery] 0.3 release
Hi Simon, Not at all, I appreciate your help. It all sounds good to me. I'm currently waiting for a final confirmation from Fernando as to whether 0.3 fulfills his needs, then we can tag and release. The vote has been done already. Cheers Rory [EMAIL PROTECTED] wrote: Hi Rory, As I said in an earlier email, I hope you don't mind me getting involved in preparing for the Discovery release. No-one gave a -1...but I can back out anything that you disagree with. * I've checked the website (maven site:generate) and it all looks good. * The release notes are complete, and there don't seem to be any controversial changes since 0.2; all the patches seem reasonably obvious. * The unit tests all pass. * project.properties has been updated so that no matter what JDK the code is built with, a 1.1-compatible jar should result. Note, however, that this doesn't check whether code uses libs not available in that JDK distribution. * there are quite a few errors reported when generating the javadoc, but I presume this is no worse than the 0.2 release, so personally I'm ok with releasing this as-is. As far as I can see, it's now just a matter of creating a RC1 tag, posting the jar and website somewhere, and calling a vote. Of course I've never done a release before, so take that with a few grains of salt :-) Cheers, Simon - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ Sign up for eircom broadband now and get a free two month trial.* Phone 1850 73 00 73 or visit http://home.eircom.net/broadbandoffer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: moving code from sandbox to proper - best practice?
Good question. We did look at doing a sandbox cleanup when it was migrated from
CVS to SVN. I remember doing a list of dead projects that were still in
sandbox. However, I agree that having a sandbox/{project} dir with at the very
least a README pointing to the new location (for promoted components) would be
useful.
[EMAIL PROTECTED] wrote:
Hi,
The moving from sandbox to proper wiki page needs updating, as it is
all CVS based.
http://wiki.apache.org/jakarta-commons/MovingFromSandboxToProper
The main question that needs resolving is:
* should the code be MOVED from sandbox to proper, or COPIED?
Moving the code means that links to the old location break. But copying
the code means that links to the old stuff don't give any indication
that the main development is now happening elsewhere.
What do people think the best practice is for sandbox-proper promotion?
I think my preference would be
* move the existing code to {proj}/tags/sandbox
* copy to {proj}/trunk
* create a new sandbox/{proj} directory, containing just a README
that points to the new project.
That way, all the sandbox code vanishes from its old location, avoiding
any confusion. But users of the sandbox stuff at least get a hint where
the new stuff is.
The main disadvantage is clutter left in the sandbox directory.
Thoughts?
Regards,
Simon
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
_
Sign up for eircom broadband now and get a free two month trial.*
Phone 1850 73 00 73 or visit http://home.eircom.net/broadbandoffer
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: moving code from sandbox to proper - best practice?
Good question. We did look at doing a sandbox cleanup when it was migrated from
CVS to SVN. I remember doing a list of dead projects that were still in
sandbox. However, I agree that having a sandbox/{project} dir with at the very
least a README pointing to the new location (for promoted components) would be
useful.
[EMAIL PROTECTED] wrote:
Hi,
The moving from sandbox to proper wiki page needs updating, as it is
all CVS based.
http://wiki.apache.org/jakarta-commons/MovingFromSandboxToProper
The main question that needs resolving is:
* should the code be MOVED from sandbox to proper, or COPIED?
Moving the code means that links to the old location break. But copying
the code means that links to the old stuff don't give any indication
that the main development is now happening elsewhere.
What do people think the best practice is for sandbox-proper promotion?
I think my preference would be
* move the existing code to {proj}/tags/sandbox
* copy to {proj}/trunk
* create a new sandbox/{proj} directory, containing just a README
that points to the new project.
That way, all the sandbox code vanishes from its old location, avoiding
any confusion. But users of the sandbox stuff at least get a hint where
the new stuff is.
The main disadvantage is clutter left in the sandbox directory.
Thoughts?
Regards,
Simon
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
_
Sign up for eircom broadband now and get a free two month trial.*
Phone 1850 73 00 73 or visit http://home.eircom.net/broadbandoffer
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VFS][ALL] Help on promotion
Mario, I'm willing to help out. On 5/12/05, Mario Ivankovits [EMAIL PROTECTED] wrote: Hello! Due to user request I would like to start a promotion to get commons-vfs out of the sandbox. Now I have read the etiquette to see what is needet http://wiki.apache.org/jakarta-commons/JakartaCommonsEtiquette The health of the development community. Fellow committers need to be persuaded that users will be supported and the code pushed forward by the listed committers. This is a major issue since there's only a limited amount of energy amongst the commons committers and no one wants to have to support a component whose committers have gone AWAL. This makes me wondering if any promotion started by me might succeed? Currently I am the only active committer and I cant see someone who might follow. Is this a no-go for the promotion? --- Mario - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- http://www.multitask.com.au/people/dion/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [discovery] 0.3 release
Good news. From Guillaume: commons-discovery 0.3 is OK for me. I had used it for my nightly test, and all is OK Cheers, Fernando Rory Winston wrote: Hi Simon, Not at all, I appreciate your help. It all sounds good to me. I'm currently waiting for a final confirmation from Fernando as to whether 0.3 fulfills his needs, then we can tag and release. The vote has been done already. Cheers Rory [EMAIL PROTECTED] wrote: Hi Rory, As I said in an earlier email, I hope you don't mind me getting involved in preparing for the Discovery release. No-one gave a -1...but I can back out anything that you disagree with. * I've checked the website (maven site:generate) and it all looks good. * The release notes are complete, and there don't seem to be any controversial changes since 0.2; all the patches seem reasonably obvious. * The unit tests all pass. * project.properties has been updated so that no matter what JDK the code is built with, a 1.1-compatible jar should result. Note, however, that this doesn't check whether code uses libs not available in that JDK distribution. * there are quite a few errors reported when generating the javadoc, but I presume this is no worse than the 0.2 release, so personally I'm ok with releasing this as-is. As far as I can see, it's now just a matter of creating a RC1 tag, posting the jar and website somewhere, and calling a vote. Of course I've never done a release before, so take that with a few grains of salt :-) Cheers, Simon - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ Sign up for eircom broadband now and get a free two month trial.* Phone 1850 73 00 73 or visit http://home.eircom.net/broadbandoffer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Fernando Nasser Red Hat Canada Ltd. E-Mail: [EMAIL PROTECTED] 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29203] - [beanutils] Indexed properties with Array type cause IllegalArgumentException in setProperty/populate
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29203. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29203 --- Additional Comments From [EMAIL PROTECTED] 2005-05-12 17:57 --- Created an attachment (id=15011) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15011action=view) Proposed patch for BeanUtilsBean.java I'm convinced that it is correct to put arrays into indexed properties. So there is no reason to handle arrays differently. The attached patch enabled us to use indexed multiple selects in struts. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r169849 - in /jakarta/commons/proper/httpclient/trunk/src: java/org/apache/commons/httpclient/ test/org/apache/commons/httpclient/ test/org/apache/commons/httpclient/server/
Author: olegk
Date: Thu May 12 10:05:07 2005
New Revision: 169849
URL: http://svn.apache.org/viewcvs?rev=169849view=rev
Log:
PR #34780 (HttpClient should always override the host of HostConfiguration if
an absolute request URI is given)
Contributed by Oleg Kalnichevski
Reviewed by Ortwin Glck
Added:
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestHostConfiguration.java
(with props)
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/DefaultHttpMethodRetryHandler.java
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpClient.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestHttpMethodFundamentals.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestNoHost.java
jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/server/ProxyRequestHandler.java
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/DefaultHttpMethodRetryHandler.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/DefaultHttpMethodRetryHandler.java?rev=169849r1=169848r2=169849view=diff
==
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/DefaultHttpMethodRetryHandler.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/DefaultHttpMethodRetryHandler.java
Thu May 12 10:05:07 2005
@@ -31,6 +31,7 @@
import java.io.IOException;
import java.io.InterruptedIOException;
+import java.net.UnknownHostException;
/**
* The default [EMAIL PROTECTED] HttpMethodRetryHandler} used by [EMAIL
PROTECTED] HttpMethod}s.
@@ -96,6 +97,10 @@
}
if (exception instanceof InterruptedIOException) {
// Timeout
+return false;
+}
+if (exception instanceof UnknownHostException) {
+// Unknown host
return false;
}
if (SSL_HANDSHAKE_EXCEPTION != null
SSL_HANDSHAKE_EXCEPTION.isInstance(exception)) {
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpClient.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpClient.java?rev=169849r1=169848r2=169849view=diff
==
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpClient.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpClient.java
Thu May 12 10:05:07 2005
@@ -353,7 +353,7 @@
* [EMAIL PROTECTED] HostConfiguration host configuration} with the given
custom
* [EMAIL PROTECTED] HttpState HTTP state}.
*
- * @param hostConfiguration The [EMAIL PROTECTED] HostConfiguration host
configuration} to use.
+ * @param hostconfig The [EMAIL PROTECTED] HostConfiguration host
configuration} to use.
* @param method the [EMAIL PROTECTED] HttpMethod HTTP method} to execute.
* @param state the [EMAIL PROTECTED] HttpState HTTP state} to use when
executing the method.
* If codenull/code, the state returned by [EMAIL PROTECTED]
#getState} will be used instead.
@@ -366,7 +366,7 @@
*cannot be recovered from.
* @since 2.0
*/
-public int executeMethod(HostConfiguration hostConfiguration,
+public int executeMethod(HostConfiguration hostconfig,
final HttpMethod method, final HttpState state)
throws IOException, HttpException {
@@ -376,18 +376,21 @@
throw new IllegalArgumentException(HttpMethod parameter may not
be null);
}
HostConfiguration defaulthostconfig = getHostConfiguration();
-if (hostConfiguration == null || hostConfiguration ==
defaulthostconfig) {
+if (hostconfig == null) {
+hostconfig = defaulthostconfig;
+}
+URI uri = method.getURI();
+if (hostconfig == defaulthostconfig || uri.isAbsoluteURI()) {
// make a deep copy of the host defaults
-hostConfiguration = new HostConfiguration(defaulthostconfig);
-URI uri = method.getURI();
+hostconfig = new HostConfiguration(hostconfig);
if (uri.isAbsoluteURI()) {
-hostConfiguration.setHost(uri);
+hostconfig.setHost(uri);
}
}
HttpMethodDirector methodDirector = new HttpMethodDirector(
this.httpConnectionManager,
-hostConfiguration,
+hostconfig,
this.params,
(state == null ? getState() : state));
svn commit: r169851 - /jakarta/commons/proper/httpclient/trunk/release_notes.txt
Author: olegk Date: Thu May 12 10:06:35 2005 New Revision: 169851 URL: http://svn.apache.org/viewcvs?rev=169851view=rev Log: PR #34780 Modified: jakarta/commons/proper/httpclient/trunk/release_notes.txt Modified: jakarta/commons/proper/httpclient/trunk/release_notes.txt URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/httpclient/trunk/release_notes.txt?rev=169851r1=169850r2=169851view=diff == --- jakarta/commons/proper/httpclient/trunk/release_notes.txt (original) +++ jakarta/commons/proper/httpclient/trunk/release_notes.txt Thu May 12 10:06:35 2005 @@ -1,5 +1,8 @@ Changes since Release Candidate 2: + * 34780 - HttpClient now always overrides the host of HostConfiguration if an absolute + request URI is given + * 34740 - Connection with the proxy is not reopened if an proxy auth failure occurs while SSL tunnel is being established - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r169878 - in /jakarta/commons/sandbox/vfs/trunk: ./ src/java/org/apache/commons/vfs/provider/webdav/ src/test-data/ src/test-data/basedir/ src/test/org/apache/commons/vfs/provider/sftp/test/ xdocs/
Author: imario
Date: Thu May 12 13:09:06 2005
New Revision: 169878
URL: http://svn.apache.org/viewcvs?rev=169878view=rev
Log:
Documentation how to setup a VFS testserver.
On the way found some problems with the webdav provider.
Might be due to new apache?
Added:
jakarta/commons/sandbox/vfs/trunk/src/test-data/basedir/file%.txt (with
props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/nested.jar (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/nested.tar (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/nested.tbz2 (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/nested.tgz (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/nested.zip (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/test.jar (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/test.tar (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/test.tbz2 (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/test.tgz (with props)
jakarta/commons/sandbox/vfs/trunk/src/test-data/test.zip (with props)
jakarta/commons/sandbox/vfs/trunk/xdocs/testserver.xml (with props)
Modified:
jakarta/commons/sandbox/vfs/trunk/maven.xml
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
jakarta/commons/sandbox/vfs/trunk/src/test/org/apache/commons/vfs/provider/sftp/test/SftpProviderTestCase.java
Modified: jakarta/commons/sandbox/vfs/trunk/maven.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/maven.xml?rev=169878r1=169877r2=169878view=diff
==
--- jakarta/commons/sandbox/vfs/trunk/maven.xml (original)
+++ jakarta/commons/sandbox/vfs/trunk/maven.xml Thu May 12 13:09:06 2005
@@ -8,6 +8,10 @@
copy todir=${test.basedir}/read-tests
fileset dir=${test.data.src}/basedir/
/copy
+copy todir=${test.basedir}/
+fileset dir=${test.data.src} includes=nested.*,test.*/
+/copy
+
!-- Compile the code for the class loader test --
javac
@@ -24,7 +28,8 @@
mkdir dir=${test.basedir}/read-tests/emptydir/
-!-- Create a zip file --
+!-- Create a zip file - its not possible to create tgz, tar and tbz2
so we provide
+ the whole set for download now
zip zipfile=${test.basedir}/test.zip
zipfileset dir=${test.basedir}
include name=read-tests/**/
@@ -50,6 +55,7 @@
jarfile=${test.basedir}/nested.jar
basedir=${test.basedir}
includes=test.jar/
+--
/postGoal
/project
Modified:
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java?rev=169878r1=169877r2=169878view=diff
==
---
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
(original)
+++
jakarta/commons/sandbox/vfs/trunk/src/java/org/apache/commons/vfs/provider/webdav/WebdavFileObject.java
Thu May 12 13:09:06 2005
@@ -31,6 +31,7 @@
import org.apache.webdav.lib.methods.DepthSupport;
import org.apache.webdav.lib.methods.OptionsMethod;
import org.apache.webdav.lib.methods.XMLResponseMethodBase;
+import org.apache.webdav.lib.methods.DeleteMethod;
import org.apache.webdav.lib.properties.ResourceTypeProperty;
import java.io.ByteArrayOutputStream;
@@ -90,6 +91,12 @@
}
}
+/**
+ * set the davResource
+ * @param resource
+ * @param bCheckExists might be removed soon
+ * @throws Exception
+ */
private void setDavResource(WebdavResource resource, boolean bCheckExists)
throws Exception
{
redirectionResolved = false;
@@ -109,7 +116,7 @@
this.resource = resource;
-if (bCheckExists)
+// if (bCheckExists)
{
/* now fill the dav properties */
final OptionsMethod optionsMethod = new
OptionsMethod(getName().getPath());
@@ -213,7 +220,7 @@
if (status = 200 status = 299)
{
setAllowedMethods(optionsMethod.getAllowedMethods());
-resource.getHttpURL().setPath(optionsMethod.getPath());
+resource.getHttpURL().setEscapedPath(optionsMethod.getPath());
redirectionResolved = true;
}
}
@@ -327,7 +334,9 @@
*/
protected void doDelete() throws Exception
{
-final boolean ok = resource.deleteMethod(getName().getPathDecoded()
/*url.getPath()*/);
+resolveRedirection();
+// final boolean ok = resource.deleteMethod(getName().getPathDecoded()
/*url.getPath()*/);
+
svn commit: r169880 - in /jakarta/commons/sandbox/vfs/trunk: build.xml project.properties xdocs/navigation.xml xdocs/testserver.xml
Author: imario
Date: Thu May 12 13:34:55 2005
New Revision: 169880
URL: http://svn.apache.org/viewcvs?rev=169880view=rev
Log:
Documentation how to setup a VFS testserver.
On the way found some problems with the webdav provider.
Might be due to new apache?
Modified:
jakarta/commons/sandbox/vfs/trunk/build.xml
jakarta/commons/sandbox/vfs/trunk/project.properties
jakarta/commons/sandbox/vfs/trunk/xdocs/navigation.xml
jakarta/commons/sandbox/vfs/trunk/xdocs/testserver.xml
Modified: jakarta/commons/sandbox/vfs/trunk/build.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/build.xml?rev=169880r1=169879r2=169880view=diff
==
--- jakarta/commons/sandbox/vfs/trunk/build.xml (original)
+++ jakarta/commons/sandbox/vfs/trunk/build.xml Thu May 12 13:34:55 2005
@@ -132,6 +132,7 @@
/include
exclude name=**/test/Abstract*TestCase.java
/exclude
+!-- tests disabled --
exclude name=**/*.java
/exclude
/fileset
Modified: jakarta/commons/sandbox/vfs/trunk/project.properties
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/project.properties?rev=169880r1=169879r2=169880view=diff
==
--- jakarta/commons/sandbox/vfs/trunk/project.properties (original)
+++ jakarta/commons/sandbox/vfs/trunk/project.properties Thu May 12 13:34:55
2005
@@ -24,6 +24,10 @@
maven.test.failure.ignore=true
maven.ant.excludeTests=**/*.java
+test.user=vfsusr
+test.password=vfsusr
+test.path=/vfstest
+
test.data.src=${maven.src.dir}/test-data
test.basedir=${maven.build.dir}/test-data
test.policy=${maven.test.data.src}/test.policy
@@ -32,6 +36,6 @@
test.ftp.uri=ftp://${test.user}:[EMAIL PROTECTED]
test.http.uri=http://${test.hostname}${test.path}
test.webdav.uri=webdav://${test.user}:[EMAIL PROTECTED]
-test.sftp.uri=sftp://${test.user}:[EMAIL
PROTECTED]/home/${test.user}${test.path}
+test.sftp.uri=sftp://${test.user}:[EMAIL PROTECTED]
maven.checkstyle.properties = ${basedir}/checkstyle.properties
Modified: jakarta/commons/sandbox/vfs/trunk/xdocs/navigation.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/xdocs/navigation.xml?rev=169880r1=169879r2=169880view=diff
==
--- jakarta/commons/sandbox/vfs/trunk/xdocs/navigation.xml (original)
+++ jakarta/commons/sandbox/vfs/trunk/xdocs/navigation.xml Thu May 12 13:34:55
2005
@@ -26,6 +26,7 @@
item name=File Systemshref=/filesystems.html/
item name=Ant Tasks href=/anttasks.html/
item name=To Do List href=/todo.html/
+ item name=Development href=/testserver.html/
/menu
common-menus;
/body
Modified: jakarta/commons/sandbox/vfs/trunk/xdocs/testserver.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/xdocs/testserver.xml?rev=169880r1=169879r2=169880view=diff
==
--- jakarta/commons/sandbox/vfs/trunk/xdocs/testserver.xml (original)
+++ jakarta/commons/sandbox/vfs/trunk/xdocs/testserver.xml Thu May 12 13:34:55
2005
@@ -35,9 +35,9 @@
liYou need maven to build the local test-data structure.
This is done automatically during build of VFS./li
liCreate a user 'vfsusr' with password 'vfsusr' and home
directory '/home/vfsusr'
br/
-code![CDATA[
-useradd -p vfsusr -m vfsusr/code
-]]/code
+source![CDATA[
+useradd -p vfsusr -m vfsusr
+]]/source
/li
liCreate the directories
ol
@@ -45,9 +45,9 @@
li/vfstest/write-tests/li
/ol
and copy from your local 'target/test-data' the
directories
-codecode,read-tests/code into it.br /
+sourcecode,read-tests/source into it.br /
Now your structure looks like this:br /
-code![CDATA[
+source![CDATA[
/vfstest
/vfstest/write-tests
/vfstest/read-tests
@@ -75,29 +75,33 @@
/vfstest/code/sealed
/vfstest/code/sealed/AnotherClass.class
/vfstest/code/ClassToLoad.class
-]]/code
+]]/source
/li
liSetup a symbolic link to '/vfstest'br /
-code![CDATA[
+source![CDATA[
ln -s /vfstest /home/vfsusr/vfstest
-]]/code
+]]/source
/li
liSet
svn commit: r169881 - /jakarta/commons/sandbox/vfs/trunk/src/test/org/apache/commons/vfs/RunTest.java
Author: imario
Date: Thu May 12 13:35:11 2005
New Revision: 169881
URL: http://svn.apache.org/viewcvs?rev=169881view=rev
Log:
Documentation how to setup a VFS testserver.
On the way found some problems with the webdav provider.
Might be due to new apache?
Added:
jakarta/commons/sandbox/vfs/trunk/src/test/org/apache/commons/vfs/RunTest.java
(with props)
Added:
jakarta/commons/sandbox/vfs/trunk/src/test/org/apache/commons/vfs/RunTest.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/src/test/org/apache/commons/vfs/RunTest.java?rev=169881view=auto
==
---
jakarta/commons/sandbox/vfs/trunk/src/test/org/apache/commons/vfs/RunTest.java
(added)
+++
jakarta/commons/sandbox/vfs/trunk/src/test/org/apache/commons/vfs/RunTest.java
Thu May 12 13:35:11 2005
@@ -0,0 +1,103 @@
+package org.apache.commons.vfs;
+
+import junit.framework.AssertionFailedError;
+import junit.framework.Test;
+import junit.framework.TestResult;
+import org.apache.commons.vfs.provider.ftp.test.FtpProviderTestCase;
+import org.apache.commons.vfs.provider.http.test.HttpProviderTestCase;
+import org.apache.commons.vfs.provider.jar.test.JarProviderTestCase;
+import org.apache.commons.vfs.provider.jar.test.NestedJarTestCase;
+import org.apache.commons.vfs.provider.local.test.LocalProviderTestCase;
+import org.apache.commons.vfs.provider.res.test.ResourceProviderTestCase;
+import org.apache.commons.vfs.provider.sftp.test.SftpProviderTestCase;
+import org.apache.commons.vfs.provider.smb.test.SmbProviderTestCase;
+import org.apache.commons.vfs.provider.tar.test.NestedTarTestCase;
+import org.apache.commons.vfs.provider.tar.test.NestedTbz2TestCase;
+import org.apache.commons.vfs.provider.tar.test.NestedTgzTestCase;
+import org.apache.commons.vfs.provider.tar.test.TarProviderTestCase;
+import org.apache.commons.vfs.provider.tar.test.Tbz2ProviderTestCase;
+import org.apache.commons.vfs.provider.tar.test.TgzProviderTestCase;
+import org.apache.commons.vfs.provider.temp.test.TemporaryProviderTestCase;
+import org.apache.commons.vfs.provider.test.VirtualProviderTestCase;
+import org.apache.commons.vfs.provider.url.test.UrlProviderTestCase;
+import org.apache.commons.vfs.provider.webdav.test.WebdavProviderTestCase;
+import org.apache.commons.vfs.provider.zip.test.NestedZipTestCase;
+import org.apache.commons.vfs.provider.zip.test.ZipProviderTestCase;
+
+import java.util.Properties;
+
+public class RunTest
+{
+public static void main(String[] args) throws Exception
+{
+Properties props = System.getProperties();
+props.setProperty(test.data.src, src/test-data);
+props.setProperty(test.basedir, target/test-data);
+props.setProperty(test.policy, src/test-data/test.policy);
+props.setProperty(test.secure, false);
+props.setProperty(test.smb.uri, smb://vfsusr:[EMAIL
PROTECTED]/vfsusr/vfstest);
+props.setProperty(test.ftp.uri, ftp://vfsusr:[EMAIL
PROTECTED]/vfstest);
+props.setProperty(test.http.uri, http://10.0.1.54/vfstest;);
+props.setProperty(test.webdav.uri, webdav://vfsusr:[EMAIL
PROTECTED]/vfstest);
+props.setProperty(test.sftp.uri, sftp://vfsusr:[EMAIL
PROTECTED]/vfstest);
+
+Test tests[] = new Test[]
+{
+LocalProviderTestCase.suite(),
+VirtualProviderTestCase.suite(),
+TemporaryProviderTestCase.suite(),
+UrlProviderTestCase.suite(),
+ResourceProviderTestCase.suite(),
+
+FtpProviderTestCase.suite(),
+HttpProviderTestCase.suite(),
+WebdavProviderTestCase.suite(),
+SmbProviderTestCase.suite(),
+SftpProviderTestCase.suite(),
+
+JarProviderTestCase.suite(),
+NestedJarTestCase.suite(),
+ZipProviderTestCase.suite(),
+NestedZipTestCase.suite(),
+TarProviderTestCase.suite(),
+TgzProviderTestCase.suite(),
+Tbz2ProviderTestCase.suite(),
+NestedTarTestCase.suite(),
+NestedTgzTestCase.suite(),
+NestedTbz2TestCase.suite(),
+};
+
+TestResult result = new TestResult()
+{
+public void startTest(Test test)
+{
+System.out.println(start + test);
+System.out.flush();
+}
+
+public void endTest(Test test)
+{
+// System.err.println(end + test);
+}
+
+public synchronized void addError(Test test, Throwable throwable)
+{
+throwable.printStackTrace();
+}
+
+public synchronized void addFailure(Test test,
AssertionFailedError assertionFailedError)
+{
+assertionFailedError.printStackTrace();
+}
+};
+
+for (int i = 0; i tests.length; i++)
+{
+
[VFS] Testserver documentation
Hi! As soon as the site is mirrored we should have the documentation How to setup a testserver for VFS online - based on Linux (Distribution: SuSE 9.3) The link is on: http://jakarta.apache.org/commons/sandbox/vfs Navigation: Commons-VFS/Development If you are familiar with your linux distribution it should be no problem to project the setup to their directory layout. Comments are welcome. Corrections to my english grammar (if there is one ;-)) send to my private e-mail please, we dont want to become a classroom :-) Have fun! --- Mario - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34902] New: - [pool] StackObjectPool.releaseObject(...) has silly behavior when the pool is full
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34902. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34902 Summary: [pool] StackObjectPool.releaseObject(...) has silly behavior when the pool is full Product: Commons Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Pool AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] StackObjectPool which is a LIFO pool discards newer pool objects when you call releaseObject(Object) on a full pool. Presumablly if you are using a StackObjectPool it is because the most recently added object is the most likely to be useful when you need another instance. In the current behavior (1.2) the pool is checked to see if it is maxed out when you try to release another object back into the pool (line 160). If it is the recently released object is discarded. Odds are the older objects pushed on to the pool stack are the most stale and lest useful but those are kept. This creates a situation where older objects are kept around despite their inferiority. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r169883 - /jakarta/commons/sandbox/vfs/trunk/xdocs/index.xml
Author: imario Date: Thu May 12 13:49:21 2005 New Revision: 169883 URL: http://svn.apache.org/viewcvs?rev=169883view=rev Log: Documentation how to setup a VFS testserver. On the way found some problems with the webdav provider. Might be due to new apache? Modified: jakarta/commons/sandbox/vfs/trunk/xdocs/index.xml Modified: jakarta/commons/sandbox/vfs/trunk/xdocs/index.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/vfs/trunk/xdocs/index.xml?rev=169883r1=169882r2=169883view=diff == --- jakarta/commons/sandbox/vfs/trunk/xdocs/index.xml (original) +++ jakarta/commons/sandbox/vfs/trunk/xdocs/index.xml Thu May 12 13:49:21 2005 @@ -47,6 +47,8 @@ /section section name=News +p2005-05 - [EMAIL PROTECTED]: Find the How to setup a VFS Testserver documentation in the developer area./p + p2005-03 - [EMAIL PROTECTED]: easier configuration for plugins - see api section for details/p p2005-03 - [EMAIL PROTECTED]: The filename parsing and api has changed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] [EMAIL] Checkstyle errors cleaned up
Ok, it sounds like we need to get another patch, or manually separate out the checkstyle from the changes. Eric, would you mind creating another two patches and attaching them in a post to the list?? Thanks, On 5/11/05, Matt Benson [EMAIL PROTECTED] wrote: I just joined the list myself... (for sandbox commons-pgp) but I noticed that in the non-checkstyle changes from this patch, the signature of a public method is modified in at least one place. This will break already-compiled code running against the library. Over in Ant-land we consider that bad; I can only assume the same would be true in Jakarta commons. $0.02, Matt --- Corey Scott [EMAIL PROTECTED] wrote: Eric, Firstly, welcome... Secondly... thanks. There are two things that would like to suggest with your patch. First: Please try to break this patch down into discrete sections. i.e. one patch for formatting and one for each of the other changes. Second: Please submit your patch(es) to the bugzilla as files. This allows use to keep everything in one place. Again, welcome and thanks. Corey - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Discover Yahoo! Stay in touch with email, IM, photo sharing and more. Check it out! http://discover.yahoo.com/stayintouch.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- http://www.multitask.com.au/people/dion/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta-commons Wiki] Update of JakartaCommonsEtiquette by MartinCooper
Dear Wiki user, You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki for change notification. The following page has been changed by MartinCooper: http://wiki.apache.org/jakarta-commons/JakartaCommonsEtiquette The comment on the change is: The Commons Sandbox is open to any ASF committer, not just Jakarta committers. -- The sandbox is a space provided by Jakarta for the development of experimental code by existing committers. It is divided into components. - Any Jakarta committer (not just commons committers) has the right ask for karma (commit access) and have it granted. The right place to ask is on the commons-dev mailing list. + Any ASF committer (not just Jakarta Commons committers) has the right ask for karma (commit access) and have it granted. The right place to ask is on the commons-dev mailing list. Components cannot be released from the sandbox. This means no binaries posted anywere on the apache site as 0.x releases, as this implies that Apache supports the released code. Users of sandbox code are expected to extract the latest source from the source code repository and build the code themselves. - Commit access to the sandbox is unfortunately '''not''' available to people who are not existing Jakarta committers, no matter how good their idea. Such projects are generally encouraged to start somewhere like sourceforge.net. Once a solid community has been established and existing projects are using the component, it may be possible to integrate the project direct into commons if the project developers feel that is appropriate, and the commons community feels the component is a good fit with commons goals. + Commit access to the sandbox is unfortunately '''not''' available to people who are not existing ASF committers, no matter how good their idea. Such projects are generally encouraged to start somewhere like sourceforge.net. Once a solid community has been established and existing projects are using the component, it may be possible to integrate the project direct into commons if the project developers feel that is appropriate, and the commons community feels the component is a good fit with commons goals. = Sandbox Etiquette = - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] [EMAIL] Checkstyle errors cleaned up
I agree with you that breaking existing API's is a bad thing. However, the project is currently at 1.0-dev and the main page itself states: * The code is unreleased * Methods and classes can and will appear and disappear without warning While changing the API at this point is less than ideal, most people would accept that there exists a potential of change between 1.0-dev and 1.0. When it comes down to it, all we're talking about is changing a public method's return object from a Hashtable to a Map. This is likely the last opportunity to make this (trivial) change before the v1.0 release and it would then have to be postponed until 1.1 (or whatever). I think changing it now is in everyone's best interest. Although I disagree with you in this specific circumstance, you've got a great point in general. This weekend I plan to follow Corey's feedback and break the patch down into discrete parts, one for Checkstyle clean up and one for this code change. That way, the commiters have the freedom to decide if they want to break the API now or down the road. Thanks for the food for thought, Eric Eric Spiegelberg wrote: Matt Benson wrote: I just joined the list myself... (for sandbox commons-pgp) but I noticed that in the non-checkstyle changes from this patch, the signature of a public method is modified in at least one place. This will break already-compiled code running against the library. Over in Ant-land we consider that bad; I can only assume the same would be true in Jakarta commons. $0.02, Matt --- Corey Scott [EMAIL PROTECTED] wrote: Eric, Firstly, welcome... Secondly... thanks. There are two things that would like to suggest with your patch. First: Please try to break this patch down into discrete sections. i.e. one patch for formatting and one for each of the other changes. Second: Please submit your patch(es) to the bugzilla as files. This allows use to keep everything in one place. Again, welcome and thanks. Corey - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Discover Yahoo! Stay in touch with email, IM, photo sharing and more. Check it out! http://discover.yahoo.com/stayintouch.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r169943 - /jakarta/commons/proper/resources/trunk/project.xml
Author: jmitchell
Date: Thu May 12 22:14:04 2005
New Revision: 169943
URL: http://svn.apache.org/viewcvs?rev=169943view=rev
Log:
adding new tests, and reports for jcoverage, with any luck I'll have Commons
Resources at 100% test coverage by the end of next month
Modified:
jakarta/commons/proper/resources/trunk/project.xml
Modified: jakarta/commons/proper/resources/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/resources/trunk/project.xml?rev=169943r1=169942r2=169943view=diff
==
--- jakarta/commons/proper/resources/trunk/project.xml (original)
+++ jakarta/commons/proper/resources/trunk/project.xml Thu May 12 22:14:04 2005
@@ -190,6 +190,9 @@
includes
include**/*TestCase.java/include
/includes
+ excludes
+exclude**/*Base*.java/exclude
+ /excludes
resources
resource
directory${pom.build.unitTestSourceDirectory}/directory
@@ -204,13 +207,19 @@
/build
reports
reportmaven-changelog-plugin/report
+ reportmaven-changes-plugin/report
reportmaven-checkstyle-plugin/report
reportmaven-developer-activity-plugin/report
reportmaven-file-activity-plugin/report
reportmaven-javadoc-plugin/report
+ reportmaven-jdepend-plugin/report
reportmaven-junit-report-plugin/report
reportmaven-jxr-plugin/report
+ reportmaven-simian-plugin/report
+ reportmaven-tasklist-plugin/report
reportmaven-license-plugin/report
+ reportmaven-jcoverage-plugin/report
+
/reports
/project
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r169945 - /jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/MessagesTestCase.java
Author: jmitchell
Date: Thu May 12 22:15:05 2005
New Revision: 169945
URL: http://svn.apache.org/viewcvs?rev=169945view=rev
Log:
adding new tests, and reports for jcoverage, with any luck I'll have Commons
Resources at 100% test coverage by the end of next month
Modified:
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/MessagesTestCase.java
Modified:
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/MessagesTestCase.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/MessagesTestCase.java?rev=169945r1=169944r2=169945view=diff
==
---
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/MessagesTestCase.java
(original)
+++
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/MessagesTestCase.java
Thu May 12 22:15:05 2005
@@ -23,6 +23,8 @@
package org.apache.commons.resources;
+import java.util.Locale;
+
import junit.framework.Test;
import junit.framework.TestCase;
import junit.framework.TestSuite;
@@ -117,6 +119,69 @@
message = local.getMessage(local.missing);
assertEquals(Correct missing message, ???local.missing???,
message);
+
+
+ Messages messages2 = new MyMessages(null);
+ Messages messages3 = messages2.getMessages(null);
+ assertNull(Invalid Messages, messages3);
+
+ }
+
+
+
+/**
+ * Test the ability to retrieve messages with replacements.
+ */
+ public void testMessage() {
+ String message = null;
+
+ message = messages.getMessage(test.missing);
+ assertEquals(Correct missing message, ???test.missing???,
message);
+
+ message = messages.getMessage(Locale.ENGLISH, test.message);
+ assertEquals(
+ Correct individual message,
+ [Base] REPLACE {0} WITH {1},
+ message);
+
+ message =
+ messages.getMessage(test.message, new String[] {
abc, def });
+
+assertEquals(
+ Correct replaced message,
+ [Base] REPLACE abc WITH def,
+ message);
+
+ message =
+ messages.getMessage(Locale.ENGLISH, test.message, new
String[] { abc, def });
+
+assertEquals(
+ Correct replaced message,
+ [Base] REPLACE abc WITH def,
+ message);
+
+ message =
+ messages.getMessage(Locale.ENGLISH,
test.message.single, abc);
+
+assertEquals(
+ Correct replaced message,
+ [Base] REPLACE abc,
+ message);
+
+ message =
+ messages.getMessage(test.message.single, abc);
+
+assertEquals(
+ Correct replaced message,
+ [Base] REPLACE abc,
+ message);
+
+ Resources resources2 =
+ factory.getResources(NAME + -does-not-exist,
+ CONFIG + -does-not-exist);
+ resources2.setReturnNull(false);
+Messages messages2 = new Messages(resources2);
+ message = messages2.getMessage(test.message);
}
@@ -142,6 +207,8 @@
message = messages.getMessage(test.missing);
assertEquals(Correct missing message, ???test.missing???,
message);
+
+
}
@@ -156,4 +223,33 @@
}
+ class MyMessages extends Messages{
+
+ public MyMessages(Resources resources) {
+ super(resources);
+ MyMessages.factory = new ResourcesFactory(){
+ public Resources getResources(String name)
+ throws ResourcesException{
+throw new ResourcesException(Bad
Implementation);
+ }
+
+ public boolean isReturnNull() {
+ return false;
+ }
+
+ public void setReturnNull(boolean returnNull) {}
+
+ public Resources getResources(String name, String
config) throws ResourcesException {
+ // TODO Auto-generated method stub
+ return null;
+ }
+
+ public void release() throws ResourcesException {
+ // TODO Auto-generated method stub
+
svn commit: r169946 - /jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/JDBCResourcesTestCase.java
Author: jmitchell
Date: Thu May 12 22:15:41 2005
New Revision: 169946
URL: http://svn.apache.org/viewcvs?rev=169946view=rev
Log:
adding new tests, and reports for jcoverage, with any luck I'll have Commons
Resources at 100% test coverage by the end of next month
Modified:
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/JDBCResourcesTestCase.java
Modified:
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/JDBCResourcesTestCase.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/JDBCResourcesTestCase.java?rev=169946r1=169945r2=169946view=diff
==
---
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/JDBCResourcesTestCase.java
(original)
+++
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/JDBCResourcesTestCase.java
Thu May 12 22:15:41 2005
@@ -22,6 +22,9 @@
*/
package org.apache.commons.resources.impl;
+import java.io.File;
+import java.io.FileReader;
+import java.io.InputStream;
import java.net.URL;
import java.sql.Connection;
import java.sql.DriverManager;
@@ -77,7 +80,10 @@
public void setUp() throws Exception {
factory = new JDBCResourcesFactory();
resources = factory.getResources(NAME, getBase());
-
+
+// InputStream in =
this.getClass().getResourceAsStream(init.sql);
+//File file = new File(init.sql);
+
// change this to load from init.sql
String[] sql = {
+ create table resources (
@@ -92,6 +98,7 @@
, Insert into resources (locale, msgKey, val) Values ('',
'test.base', '[Base] ONLY');
, Insert into resources (locale, msgKey, val) Values ('',
'test.specific', '[Base] SPECIFIC');
, Insert into resources (locale, msgKey, val) Values ('',
'test.inherit', '[Base] INHERIT');
+, Insert into resources (locale, msgKey, val) Values ('',
'test.message.single', '[Base] REPLACE {0}');
, Insert into resources (locale, msgKey, val) Values ('',
'test.message', '[Base] REPLACE {0} WITH {1}');
, Insert into resources (locale, msgKey, val) Values ('en',
'test.specific', '[en] SPECIFIC');
, Insert into resources (locale, msgKey, val) Values ('en',
'test.inherit', '[en] INHERIT');
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r169947 - /jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java
Author: jmitchell Date: Thu May 12 22:15:54 2005 New Revision: 169947 URL: http://svn.apache.org/viewcvs?rev=169947view=rev Log: adding new tests, and reports for jcoverage, with any luck I'll have Commons Resources at 100% test coverage by the end of next month Modified: jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java Modified: jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java?rev=169947r1=169946r2=169947view=diff == --- jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java (original) +++ jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/ResourcesBaseTestCase.java Thu May 12 22:15:54 2005 @@ -118,7 +118,7 @@ } // Validate the keys that were actually returned -assertEquals(4, results.size()); +assertEquals(5, results.size()); assertTrue(results.contains(test.base)); assertTrue(results.contains(test.specific)); assertTrue(results.contains(test.inherit)); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r169949 - /jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.properties
Author: jmitchell
Date: Thu May 12 22:16:07 2005
New Revision: 169949
URL: http://svn.apache.org/viewcvs?rev=169949view=rev
Log:
adding new tests, and reports for jcoverage, with any luck I'll have Commons
Resources at 100% test coverage by the end of next month
Modified:
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.properties
Modified:
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.properties
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.properties?rev=169949r1=169948r2=169949view=diff
==
---
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.properties
(original)
+++
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.properties
Thu May 12 22:16:07 2005
@@ -1,4 +1,5 @@
test.base=[Base] ONLY
test.specific=[Base] SPECIFIC
test.inherit=[Base] INHERIT
+test.message.single=[Base] REPLACE {0}
test.message=[Base] REPLACE {0} WITH {1}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r169951 - /jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.xml
Author: jmitchell
Date: Thu May 12 22:32:41 2005
New Revision: 169951
URL: http://svn.apache.org/viewcvs?rev=169951view=rev
Log:
adding new tests, and reports for jcoverage, with any luck I'll have Commons
Resources at 100% test coverage by the end of next month
Modified:
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.xml
Modified:
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.xml?rev=169951r1=169950r2=169951view=diff
==
---
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.xml
(original)
+++
jakarta/commons/proper/resources/trunk/src/test/org/apache/commons/resources/impl/TestResources.xml
Thu May 12 22:32:41 2005
@@ -7,5 +7,6 @@
resource id=test.base[Base] ONLY/resource
resource id=test.specific[Base] SPECIFIC/resource
resource id=test.inherit[Base] INHERIT/resource
+ resource id=test.message.single[Base] REPLACE {0}/resource
resource id=test.message[Base] REPLACE {0} WITH {1}/resource
/resources
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
