Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2018-01-05 Thread Tom Pantelis 
On Fri, Jan 5, 2018 at 6:04 PM, Ryan Dietrich 
wrote:

> Ended up in the hospital over the holidays (I’m fine now), sorry I wasn’t
> able to follow up sooner.
>
> So, I checked out the controller repo from both GitHub and
> git.opendaylight.org, and your SHA for the commit (
> 02888d8e212ec0a79270c1e5824e0a491d7d2660) listed in your change isn’t
> “there”.  I assume some git rebase -i shenanigans are going on or something?
>

My patch https://git.opendaylight.org/gerrit/#/c/66545/ hasn't been merged
yet. Still needs review. If you need it now then you can clone the
controller project (master branch) and cherry-pick my patch. You can test
it out and then review and +1 the patch to facilitate merging (assuming you
don't find any issues of course).


>
>
>
>
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2018-01-05 Thread Ryan Dietrich 
Ended up in the hospital over the holidays (I’m fine now), sorry I wasn’t able 
to follow up sooner.

So, I checked out the controller repo from both GitHub and git.opendaylight.org 
, and your SHA for the commit 
(02888d8e212ec0a79270c1e5824e0a491d7d2660) listed in your change isn’t “there”. 
 I assume some git rebase -i shenanigans are going on or something?

Anyway, I noticed that there were other startup archetype jar’s on nexus.  
https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/org/opendaylight/controller/opendaylight-startup-archetype/
 

  They both have timestamps of December 31, so I assumed the patch would be in 
place by now?

When I tried 1.5.0-SNAPSHOT, the code would not compile.  The first error was 
due to check style was mad because the line length exceeded 120 chars.  
(ExampleCliTestCommand.java)

@Command(name = "test-command", scope = "add the scope of the command, usually 
project name", description = “there was words here but I removed them so it 
would compile")

Then on the second attempt, it was mad because the ordering of library imports 
broke another check style rule, in ExampleCliCommandsImpl.java

import org.opendaylight.example.cli.api.ExampleCliCommands;

It was “below” the slf4j imports, so I moved it above, and then it compiled.  
(phew).

I fired up Karaf, and got nothing when for “log:display |grep Example” as I did 
before.

….

Ok, let’s try 1.4.2-SNAPSHOT…  It compiled first try, looks like some 
regressions were added along the way when 1.5.0 was put together?

I’ll spare you the asciinema this time, and just show that the same result 
happens as before:

opendaylight-user@root>log:display |grep Example
opendaylight-user@root>

No dice.  I *really* want to get this example working, because I literally 
can’t get anything working with my southbound plugin that worked perfectly fine 
up until Nitrogen nuked me from orbit.

please advise?


> On Dec 18, 2017, at 2:11 PM, Tom Pantelis  wrote:
> 
> 
> 
> On Mon, Dec 18, 2017 at 2:03 PM, Ryan Dietrich  > wrote:
>> The archetype has issues - I pushed 
>> https://git.opendaylight.org/gerrit/#/c/66545/ 
>>  to address the ones you 
>> encountered and others I found. coretutorials is an abortion - it was 
>> started with good intentions but not followed thru.
>> 
>> AKAIK the toaster example in the controller project along with 
>> https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Toaster_Step-By-Step
>>  
>> 
>>  are up-to-date and not broken.
> 
> How do I re-test the change you just pushed (I assume a version bump of some 
> sort?)
> 
> That patch is on master - you can clone master and then cherry-pick that 
> patch. 
>  
> 
> -Ryan Dietrich
> 

___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2017-12-18 Thread Tom Pantelis 
On Mon, Dec 18, 2017 at 2:03 PM, Ryan Dietrich 
wrote:

> The archetype has issues - I pushed https://git.
> opendaylight.org/gerrit/#/c/66545/ to address the ones you encountered
> and others I found. coretutorials is an abortion - it was started with good
> intentions but not followed thru.
>
> AKAIK the toaster example in the controller project along with
> https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-
> SAL:Toaster_Step-By-Step are up-to-date and not broken.
>
>
> How do I re-test the change you just pushed (I assume a version bump of
> some sort?)
>

That patch is on master - you can clone master and then cherry-pick that
patch.


>
> -Ryan Dietrich
>
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2017-12-18 Thread Ryan Dietrich 
> The archetype has issues - I pushed 
> https://git.opendaylight.org/gerrit/#/c/66545/ 
>  to address the ones you 
> encountered and others I found. coretutorials is an abortion - it was started 
> with good intentions but not followed thru.
> 
> AKAIK the toaster example in the controller project along with 
> https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Toaster_Step-By-Step
>  
> 
>  are up-to-date and not broken.

How do I re-test the change you just pushed (I assume a version bump of some 
sort?)

-Ryan Dietrich___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2017-12-17 Thread Tom Pantelis 
On Sun, Dec 17, 2017 at 10:15 PM, Tom Pantelis 
wrote:

>
>
> On Sun, Dec 17, 2017 at 7:50 PM, Ryan Dietrich 
> wrote:
>
>> I made a screencast showing exactly what I am doing.  Please advise?
>>>
>>> https://asciinema.org/a/R5Oo9BYsPuQMBYfpjGI29D1fM
>>>
>>> I have never seen “ExampleProvider Session Initiated”, no matter what I
>>> do.  It feels like the most basic “hello world” program doesn’t even work
>>> with Nitrogen anymore :(
>>>
>>>
>> There's a couple reasons you don't see that message. First, none of the
>> example features are specified in the featuresBoot property
>> in etc/org.apache.karaf.features.cfg so none of the generated example
>> features are installed on startup - that's b/c this line is commented out
>> in karaf/pom.xml:
>>
>>
>> First, thanks for getting back to me on this.  I was pretty impressed
>> with asciinema, going to use it a lot more in the future (did you see you
>> can copy/paste from the video while it is playing!?  That is super cool!)
>>
>> I see the file: features.cfg.  In it I see this section that refers to
>> featuresBoot
>>
>> featuresBoot = \
>> standard, \
>> wrap
>>
>> Should it include something related to old-example?  How do I know what
>> to put there?
>>
>> 
>>
>> 
>>
>>
>> I’m guessing uncommenting this without fixing the features.cfg file isn’t
>> going to do anything?
>>
>>
So the karaf.localFeature property in the pom causes the
maven-deploy-plugin to include that feature in the featuresBoot line in the
generated distro. However it won't work due to the issue outlined below, ie
the odl-example-rest feature needs to be listed in the generated
features-example feature repo otherwise karaf wont know about it at
runtime. However it wont even get that far as the maven-deploy-plugin will
fail to generate the distro if it can't resolve the karaf.localFeature.


> That's not really an issue other than it no longer matches the wiki
>> content.
>>
>>
>> -Ryan Dietrich
>>
>
>
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2017-12-17 Thread Tom Pantelis 
On Sun, Dec 17, 2017 at 7:50 PM, Ryan Dietrich 
wrote:

> I made a screencast showing exactly what I am doing.  Please advise?
>>
>> https://asciinema.org/a/R5Oo9BYsPuQMBYfpjGI29D1fM
>>
>> I have never seen “ExampleProvider Session Initiated”, no matter what I
>> do.  It feels like the most basic “hello world” program doesn’t even work
>> with Nitrogen anymore :(
>>
>>
> There's a couple reasons you don't see that message. First, none of the
> example features are specified in the featuresBoot property
> in etc/org.apache.karaf.features.cfg so none of the generated example
> features are installed on startup - that's b/c this line is commented out
> in karaf/pom.xml:
>
>
> First, thanks for getting back to me on this.  I was pretty impressed with
> asciinema, going to use it a lot more in the future (did you see you can
> copy/paste from the video while it is playing!?  That is super cool!)
>
> I see the file: features.cfg.  In it I see this section that refers to
> featuresBoot
>
> featuresBoot = \
> standard, \
> wrap
>
> Should it include something related to old-example?  How do I know what to
> put there?
>
> 
>
> 
>
>
> I’m guessing uncommenting this without fixing the features.cfg file isn’t
> going to do anything?
>
> That's not really an issue other than it no longer matches the wiki
> content.
>
>
> I can follow a step-by-step checklist, I promise!  (missing steps makes it
> a bit harder though)
>
>  When you list the features, notice there's only odl-example-api -
> the odl-example feature which includes the example-impl bundle, which of
> course has the ExampleProvider class, is missing (and also the
> odl-example-cli and odl-example-rest features). This is b/c the
> features-example feature repo only includes odl-example-api - the
> features/features-example/pom.xml should list odl-example-rest, which
> pulls in all the example features, instead of odl-example-api as a
> dependency. Unfortunately, this was overlooked when the archetype
> was  migrated to karaf 4.
>
>
> Yeah, this encapsulation that is going on in the features-repo is
> confusing.  I still don’t get how OSGi connects the dots between
> “packaging” that announces itself as a “feature”, a “bundle” or a “pom”.
> The Karaf 4 manual might as well be written in sanskrit because I can’t
> make it through the first few paragraphs without stack-overflowing.
>
> So, is example totally broken? (similar to toaster and coretutorials)?  Is
> there a simple “hello world”-esque example anywhere in ODL that works with
> Nitrogen SR1?
>
>
The archetype has issues - I pushed
https://git.opendaylight.org/gerrit/#/c/66545/ to address the ones you
encountered and others I found. coretutorials is an abortion - it was
started with good intentions but not followed thru.

AKAIK the toaster example in the controller project along with
https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Toaster_Step-By-Step
are up-to-date and not broken.



> -Ryan Dietrich
>
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2017-12-17 Thread Ryan Dietrich 
> I made a screencast showing exactly what I am doing.  Please advise?
> 
> https://asciinema.org/a/R5Oo9BYsPuQMBYfpjGI29D1fM 
> 
> 
> I have never seen “ExampleProvider Session Initiated”, no matter what I do.  
> It feels like the most basic “hello world” program doesn’t even work with 
> Nitrogen anymore :(
> 
> 
> There's a couple reasons you don't see that message. First, none of the 
> example features are specified in the featuresBoot property in 
> etc/org.apache.karaf.features.cfg so none of the generated example features 
> are installed on startup - that's b/c this line is commented out in 
> karaf/pom.xml:

First, thanks for getting back to me on this.  I was pretty impressed with 
asciinema, going to use it a lot more in the future (did you see you can 
copy/paste from the video while it is playing!?  That is super cool!)

I see the file: features.cfg.  In it I see this section that refers to 
featuresBoot

featuresBoot = \
standard, \
wrap

Should it include something related to old-example?  How do I know what to put 
there?

> 
>
> 

I’m guessing uncommenting this without fixing the features.cfg file isn’t going 
to do anything?

> That's not really an issue other than it no longer matches the wiki content.

I can follow a step-by-step checklist, I promise!  (missing steps makes it a 
bit harder though)

>  When you list the features, notice there's only odl-example-api - the 
> odl-example feature which includes the example-impl bundle, which of course 
> has the ExampleProvider class, is missing (and also the odl-example-cli and 
> odl-example-rest features). This is b/c the features-example feature repo 
> only includes odl-example-api - the  features/features-example/pom.xml should 
> list odl-example-rest, which pulls in all the example features, instead of 
> odl-example-api as a dependency. Unfortunately, this was overlooked when the 
> archetype was  migrated to karaf 4.

Yeah, this encapsulation that is going on in the features-repo is confusing.  I 
still don’t get how OSGi connects the dots between “packaging” that announces 
itself as a “feature”, a “bundle” or a “pom”.  The Karaf 4 manual might as well 
be written in sanskrit because I can’t make it through the first few paragraphs 
without stack-overflowing.

So, is example totally broken? (similar to toaster and coretutorials)?  Is 
there a simple “hello world”-esque example anywhere in ODL that works with 
Nitrogen SR1?

-Ryan Dietrich___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2017-12-16 Thread Tom Pantelis 
On Fri, Dec 15, 2017 at 5:27 PM, Ryan Dietrich 
wrote:

> I made a screencast showing exactly what I am doing.  Please advise?
>
> https://asciinema.org/a/R5Oo9BYsPuQMBYfpjGI29D1fM
>
> I have never seen “ExampleProvider Session Initiated”, no matter what I
> do.  It feels like the most basic “hello world” program doesn’t even work
> with Nitrogen anymore :(
>
>
There's a couple reasons you don't see that message. First, none of the
example features are specified in the featuresBoot property
in etc/org.apache.karaf.features.cfg so none of the generated example
features are installed on startup - that's b/c this line is commented out
in karaf/pom.xml:


   


That's not really an issue other than it no longer matches the wiki content.

 When you list the features, notice there's only odl-example-api -
the odl-example feature which includes the example-impl bundle, which of
course has the ExampleProvider class, is missing (and also the
odl-example-cli and odl-example-rest features). This is b/c the
features-example feature repo only includes odl-example-api - the
features/features-example/pom.xml should list odl-example-rest, which pulls
in all the example features, instead of odl-example-api as a dependency.
Unfortunately, this was overlooked when the archetype was  migrated to
karaf 4.
___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev

Re: [controller-dev] [Opendaylight-users] More Nitrogen weirdness

2017-12-15 Thread Ryan Dietrich 
I made a screencast showing exactly what I am doing.  Please advise?

https://asciinema.org/a/R5Oo9BYsPuQMBYfpjGI29D1fM 


I have never seen “ExampleProvider Session Initiated”, no matter what I do.  It 
feels like the most basic “hello world” program doesn’t even work with Nitrogen 
anymore :(

-Ryan Dietrich


> On Dec 12, 2017, at 4:53 PM, Luis Gomez  wrote:
> 
> Adding controller devs for the archetype question.
> 
>> Begin forwarded message:
>> 
>> From: Ryan Dietrich mailto:r...@betterservers.com>>
>> Subject: [Opendaylight-users] More Nitrogen weirdness
>> Date: December 12, 2017 at 3:15:57 PM PST
>> To: opendaylight-us...@lists.opendaylight.org 
>> 
>> 
>> I ran into some issues with my southbound plugin after trying to follow 
>> these instructions:  https://wiki.opendaylight.org/view/Karaf_4_migration 
>>  … So, I decided to 
>> start over to see where I went wrong, and I can’t even past “part 1” of the 
>> basic example now.
>> 
>> I followed this:  
>> https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Startup_Project_Archetype
>>  
>> 
>> 
>> I found this to specify Nitrogen-SR1:  
>> https://stackoverflow.com/questions/47054929/using-opendaylight-starter-archetype-does-not-work
>>  
>> 
>> 
>> I built the example and started karaf (in karaf/target/assembly/bin)
>> 
>> The log line that is supposed to show up when you type: 
>> 
>> log:display | grep Example
>> 
>> never shows up, regardless of how long you wait.
>> 
>> Curiously, when I check if the Example package is even installed nothing 
>> shows up.
>> 
>> opendaylight-user@root>feature:list |grep example
>> odl-example-api| 0.1.0.SNAPSHOT   |  | Uninstalled | 
>> odl-example-api | OpenDaylight :: example :: API [Karaf Feature]
>> features-example   | 0.1.0.SNAPSHOT   |  | Uninstalled | 
>> features-example| ODL :: org.opendaylight.example :: features-examp
>> 
>> If I install both example features using “feature:install”, I do not see the 
>> log line in “init” ExampleProvider Session Initiated  ever show up in the 
>> logs.
>> 
>> Help?
>> ___
>> opendaylight-users mailing list
>> opendaylight-us...@lists.opendaylight.org 
>> 
>> https://lists.opendaylight.org/mailman/listinfo/opendaylight-users
> 

___
controller-dev mailing list
controller-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/controller-dev