hg: jdk7/tl/langtools: 6639645: Modeling type implementing missing interfaces

2011-03-02 Thread jonathan . gibbons
Changeset: 4baab658f357
Author:jjg
Date:  2011-03-02 21:13 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4baab658f357

6639645: Modeling type implementing missing interfaces
Reviewed-by: darcy, mcimadamore

! src/share/classes/com/sun/tools/javac/code/Flags.java
! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/code/Type.java
! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java
! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java
! test/tools/javac/api/6557752/T6557752.java
+ 
test/tools/javac/processing/model/element/TestMissingElement/InvalidSource.java
+ 
test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java
+ test/tools/javac/processing/model/element/TestMissingElement2/Generator.java
+ 
test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java
+ 
test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java
+ 
test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java
+ 
test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java
+ 
test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java
+ 
test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java



hg: jdk7/tl/langtools: 6986892: confusing warning given after errors in annotation processing

2011-03-02 Thread jonathan . gibbons
Changeset: 3085d0089546
Author:jjg
Date:  2011-03-02 21:06 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3085d0089546

6986892: confusing warning given after errors in annotation processing
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
+ test/tools/javac/processing/warnings/UseImplicit/C1.java
+ 
test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java
+ test/tools/javac/processing/warnings/UseImplicit/err.out
+ test/tools/javac/processing/warnings/UseImplicit/p/C2.java
+ test/tools/javac/processing/warnings/UseImplicit/warn.out



Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-03-02 Thread Dr Andrew John Hughes
On 2 March 2011 19:48, Alan Bateman  wrote:
> Kelly O'Hair wrote:
>>
>> Need reviewer for change in jaxp source drop bundle
>>
>> 7023289: jaxp 1.4.5 development jdk7 2nd integration
>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp-145dev1/webrev/
>>
>> Joe or someone from the JAXP team may want to comment on the specific
>> changes in this new
>> source bundle.
>>
>> -kto
>>
>>
>
> The update to jaxp.properties looks okay to me.
>
> -Alan
>

The problem with this drop tarball method is the jaxp.properties
update is all you can see.

How do we know what the actual changes are between these tarballs?  Is
there some JAXP repository somewhere these are derived from, with
appropriate tagging?

When we had the source code in the repository, we could at least see
what changes were being made.  Having to track down and patch some
JAXP issues recently has been a nightmare with this drop tarball
system.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37


Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-03-02 Thread Joe Wang

Kelly,

Thanks for the quick action!  So I may even have time to handle any 
regressions before my vacation :)


I double-checked both paths, and also the checksum. They are all good to me.

Thanks,
Joe

On 3/2/2011 11:38 AM, Kelly O'Hair wrote:

Need reviewer for change in jaxp source drop bundle

7023289: jaxp 1.4.5 development jdk7 2nd integration
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp-145dev1/webrev/

Joe or someone from the JAXP team may want to comment on the specific changes 
in this new
source bundle.

-kto

  


Problem running webrev on linux

2011-03-02 Thread Rama Pulavarthi
Hi,
I am having problems running webrev on Ubuntu 10.04.It is stuck while
generating the framed_sdiff. The function relative_dir seems to get
wrong input as d1, d2 does not have a common root as logged below and
even the check in the function to find it fails and is stuck in loop. I
updated gawk from 3.1.6 to 3.1.8 and still see the same problem. Do
others face this problem?

Input to function framed_sdiff
**  debug TNAME=java.security
**  debug TPATH=src/share/lib/security
**  debug lhsfile=/tmp/28650.file1.html
**  debug rhsfile=/tmp/28650.file2.html
**  debug comment=
**  debug
WDIR=/home2/ramkris/w/jdk/jdk7/7020513-new/tl/jdk/webrev

Input to function relative_dir
**  debug d1= src/share/lib/security
**  debug d2=/home2/ramkris/w/jdk/jdk7/7020513-new/tl/jdk/webrev

**  debug 1 src/share/lib/security
**  debug 2 src/share/lib/security
**  debug 2 src/share/lib/security ..
**  debug 3
**  debug 2 src/share/lib/security ../..
**  debug 3
**  debug 2 src/share/lib/security ../../..
**  debug 3
**  debug 2 src/share/lib/security ../../../..
**  debug 3
**  debug 2 src/share/lib/security ../../../../..
**  debug 3
**  debug 2 src/share/lib/security ../../../../../..
**  debug 3
**  debug 2 src/share/lib/security ../../../../../../..
**  debug 3
**  debug 2 src/share/lib/security ../../../../../../../..
**  debug 3
**  debug 2 src/share/lib/security ../../../../../../../../..
**  debug 3
.

thanks,
Rama Pulavarthi


hg: jdk7/tl/langtools: 6986895: compiler gives misleading message for no input files

2011-03-02 Thread jonathan . gibbons
Changeset: 2a5c919f20b8
Author:jjg
Date:  2011-03-02 14:03 -0800
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2a5c919f20b8

6986895: compiler gives misleading message for no input files
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/main/Main.java
! src/share/classes/com/sun/tools/javac/resources/javac.properties
+ test/tools/javac/options/T6986895.java



Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-03-02 Thread Alan Bateman

Kelly O'Hair wrote:

Need reviewer for change in jaxp source drop bundle

7023289: jaxp 1.4.5 development jdk7 2nd integration
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp-145dev1/webrev/

Joe or someone from the JAXP team may want to comment on the specific changes 
in this new
source bundle.

-kto

  

The update to jaxp.properties looks okay to me.

-Alan


Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-03-02 Thread Kelly O'Hair

Need reviewer for change in jaxp source drop bundle

7023289: jaxp 1.4.5 development jdk7 2nd integration
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp-145dev1/webrev/

Joe or someone from the JAXP team may want to comment on the specific changes 
in this new
source bundle.

-kto



hg: jdk7/tl/jdk: 7021987: native2ascii "file cannot be read" error message is broken

2011-03-02 Thread alan . bateman
Changeset: 895687e879ca
Author:alanb
Date:  2011-03-02 16:56 +
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/895687e879ca

7021987: native2ascii "file cannot be read" error message is broken
Reviewed-by: lancea, mchung

! src/share/classes/sun/tools/native2ascii/Main.java
! test/sun/tools/native2ascii/Native2AsciiTests.sh



Re: 7021987: native2ascii "file cannot be read" error message is broken

2011-03-02 Thread Mandy Chung

 Thumbs up.
Mandy

On 3/2/11 7:12 AM, Alan Bateman wrote:


I need a reviewer for a small regression in the native2ascii tool 
whereby its error messages aren't as expected. Early in the jdk7 this 
code appears to have been changed to address a "non-varargs call of 
varargs method" warning in a usage of MessgaeFormat.format. A cast was 
added to cast a String[] to an Object resulting in the compiler 
treating it as a varargs call. I've  used the opportunity to eliminate 
a raw type warning in this code and replace a usage of legacy 
j.u.Vector with List. This is old code with other "opportunities" to 
do cleanup but I don't have time to spent time on it. The webrev with 
the changes is here:

 http://cr.openjdk.java.net/~alanb/7021987/webrev/

Thanks,
Alan.





Re: 7021987: native2ascii "file cannot be read" error message is broken

2011-03-02 Thread Lance Andersen - Oracle
looks fine Alan
On Mar 2, 2011, at 10:12 AM, Alan Bateman wrote:

> 
> I need a reviewer for a small regression in the native2ascii tool whereby its 
> error messages aren't as expected. Early in the jdk7 this code appears to 
> have been changed to address a "non-varargs call of varargs method" warning 
> in a usage of MessgaeFormat.format. A cast was added to cast a String[] to an 
> Object resulting in the compiler treating it as a varargs call. I've  used 
> the opportunity to eliminate a raw type warning in this code and replace a 
> usage of legacy j.u.Vector with List. This is old code with other 
> "opportunities" to do cleanup but I don't have time to spent time on it. The 
> webrev with the changes is here:
> http://cr.openjdk.java.net/~alanb/7021987/webrev/
> 
> Thanks,
> Alan.
> 




Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

Oracle is committed to developing practices and products that help 
protect the environment




7021987: native2ascii "file cannot be read" error message is broken

2011-03-02 Thread Alan Bateman


I need a reviewer for a small regression in the native2ascii tool 
whereby its error messages aren't as expected. Early in the jdk7 this 
code appears to have been changed to address a "non-varargs call of 
varargs method" warning in a usage of MessgaeFormat.format. A cast was 
added to cast a String[] to an Object resulting in the compiler treating 
it as a varargs call. I've  used the opportunity to eliminate a raw type 
warning in this code and replace a usage of legacy j.u.Vector with List. 
This is old code with other "opportunities" to do cleanup but I don't 
have time to spent time on it. The webrev with the changes is here:

 http://cr.openjdk.java.net/~alanb/7021987/webrev/

Thanks,
Alan.



hg: jdk7/tl/langtools: 6541876: "Enclosing Instance" error new in 1.6

2011-03-02 Thread maurizio . cimadamore
Changeset: 02b699d97a55
Author:mcimadamore
Date:  2011-03-02 10:56 +
URL:   http://hg.openjdk.java.net/jdk7/tl/langtools/rev/02b699d97a55

6541876: "Enclosing Instance" error new in 1.6
Summary: unqualified 'this' should not be selected in a qualified super() call 
in a default constructor
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
+ test/tools/javac/implicitThis/6541876/T6541876a.java
+ test/tools/javac/implicitThis/6541876/T6541876b.java
! test/tools/javac/implicitThis/NewBeforeOuterConstructed3.java
! test/tools/javac/nested/4903103/T4903103.java



Re: How can I get all emails from this mailing list

2011-03-02 Thread David Holmes

Alan,

Alan Eliasen said the following on 03/02/11 19:02:

On 03/02/2011 01:46 AM, David Holmes wrote:

You can try something like this on google:

site:mail.openjdk.java.net core-libs-dev AsynchronousDatagramChannel

there are probably better ways.


   That won't work because the pages are marked



   so nobody will be able to do a web search for any content here.  I
reported this months ago.  It's a pretty big issue for all of these
forums because you can't search for existing solutions, discussions, etc.


I suggest you try again, I tested it before I posted it.

David


Re: How can I get all emails from this mailing list

2011-03-02 Thread Charles Lee

On 03/02/2011 05:03 PM, Alan Bateman wrote:

Charles Lee wrote:

Hi guys,

I have noticed AsynchronousDatagramChannel has been removed. I am 
curious about this. So It comes to me that I can not find such topic 
in the mailing list. I know the archive is 
http://mail.openjdk.java.net/pipermail/jdk7-dev/, but there is no 
search function there. Does anyone has some secret ways to solve this 
problem?

The nio-dev list is where this was discussed [1].

-Alan

[1] 
http://mail.openjdk.java.net/pipermail/nio-dev/2010-October/001122.html



Thanks Alan.


Re: How can I get all emails from this mailing list

2011-03-02 Thread Alan Bateman

Charles Lee wrote:

Hi guys,

I have noticed AsynchronousDatagramChannel has been removed. I am 
curious about this. So It comes to me that I can not find such topic 
in the mailing list. I know the archive is 
http://mail.openjdk.java.net/pipermail/jdk7-dev/, but there is no 
search function there. Does anyone has some secret ways to solve this 
problem?

The nio-dev list is where this was discussed [1].

-Alan

[1] http://mail.openjdk.java.net/pipermail/nio-dev/2010-October/001122.html



Re: How can I get all emails from this mailing list

2011-03-02 Thread Alan Eliasen
On 03/02/2011 01:46 AM, David Holmes wrote:
> You can try something like this on google:
> 
> site:mail.openjdk.java.net core-libs-dev AsynchronousDatagramChannel
> 
> there are probably better ways.

   That won't work because the pages are marked



   so nobody will be able to do a web search for any content here.  I
reported this months ago.  It's a pretty big issue for all of these
forums because you can't search for existing solutions, discussions, etc.

-- 
  Alan Eliasen
  elia...@mindspring.com
  http://futureboy.us/


Re: How can I get all emails from this mailing list

2011-03-02 Thread Charles Lee

On 03/02/2011 04:46 PM, David Holmes wrote:

Charles Lee said the following on 03/02/11 18:32:
I have noticed AsynchronousDatagramChannel has been removed. I am 
curious about this. So It comes to me that I can not find such topic 
in the mailing list. I know the archive is 
http://mail.openjdk.java.net/pipermail/jdk7-dev/, 


Try:

http://mail.openjdk.java.net/pipermail/core-libs-dev/

but there is no search function there. Does anyone has some secret 
ways to solve this problem?


You can try something like this on google:

site:mail.openjdk.java.net core-libs-dev AsynchronousDatagramChannel

there are probably better ways.

HTH

David Holmes

Thanks David.

Using site:mail.openjdk.java.net core-libs-dev 
AsynchronousDatagramChannel, it is still not easy for me to find the 
AsynchronousDatagramChannel discussions. Is there any place, which is 
like http://markmail.org/, holding all the mailing from openjdk mailing 
list?


Re: How can I get all emails from this mailing list

2011-03-02 Thread David Holmes

Charles Lee said the following on 03/02/11 18:32:
I have noticed AsynchronousDatagramChannel has been removed. I am 
curious about this. So It comes to me that I can not find such topic in 
the mailing list. I know the archive is 
http://mail.openjdk.java.net/pipermail/jdk7-dev/, 


Try:

http://mail.openjdk.java.net/pipermail/core-libs-dev/

but there is no search 
function there. Does anyone has some secret ways to solve this problem?


You can try something like this on google:

site:mail.openjdk.java.net core-libs-dev AsynchronousDatagramChannel

there are probably better ways.

HTH

David Holmes


How can I get all emails from this mailing list

2011-03-02 Thread Charles Lee

Hi guys,

I have noticed AsynchronousDatagramChannel has been removed. I am 
curious about this. So It comes to me that I can not find such topic in 
the mailing list. I know the archive is 
http://mail.openjdk.java.net/pipermail/jdk7-dev/, but there is no search 
function there. Does anyone has some secret ways to solve this problem?