Re: Debian package without VCS

[Muri Nicanor]

Hello Andrius,

On 08/30/2018 08:00 AM, Andrius Merkys wrote:
> Dear Mentors,
> 
> I have stumbled upon a source package 'pegtl', whose binary is in Debian, but 
> the packaging files aren't on salsa.d.org. Moreover, d/control contains no 
> VCS information. I would be happy to update the package to the newest 
> upstream release.

There is an open ITP (#905853) for tao-pegtl-dev from bisco, who offered
to package the new and upcoming releases (upstream renamed the package
and changed the path of the header files, see the ITP for details).

cheers,
muri


> 
> My questions:
> 
> 1) I want package's source on salsa.d.org. Should I create a new repo on 
> salsa.d.org and import 'pegtl' there with 'gbp import-dsc'?
> 
> 2) The package is not maintained by any team (cc'ing Muri Nicanor, the 
> maintainer of 'pegtl'). Am I allowed to even touch it?
> 
> Best wishes,
> Andrius
> 

Re: Debian package without VCS

[Muri Nicanor]

On 08/30/2018 08:23 AM, Muri Nicanor wrote:
> Hello Andrius,
> 
> On 08/30/2018 08:00 AM, Andrius Merkys wrote:
>> Dear Mentors,
>>
>> I have stumbled upon a source package 'pegtl', whose binary is in Debian, 
>> but the packaging files aren't on salsa.d.org. Moreover, d/control contains 
>> no VCS information. I would be happy to update the package to the newest 
>> upstream release.
> 
> There is an open ITP (#905853) for tao-pegtl-dev from bisco, who offered
> to package the new and upcoming releases (upstream renamed the package
> and changed the path of the header files, see the ITP for details).
sorry, forgot to mention: there is actually also a corresponding RFS #905946

cheers,
muri

Bug#905654: RFS: usbguard/0.7.2+ds-2

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name : usbguard
  Version  : 0.7.2+ds-2
  Upstream Author  : Daniel Kopeček 
* Url  : https://dkopecek.github.io/usbguard/
* Licenses : public-domain,CC-BY-SA-3.0,GPL-3+,GPL-2+,FSFULLR
  Programming Lang : C
  Section  : utils

 The USBGuard software framework helps to protect your computer against
rogue
 USB devices (a.k.a. BadUSB) by implementing basic whitelisting and
blacklisting
 capabilities based on device attributes.

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.2+ds-2.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://salsa.debian.org/muri-guest/usbguard.git

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/


Changes since last upload:

  * Add a postrm file to clean up on purge (Closes: #905524)

Cheers,
muri

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

hm, somehow i didn't receive that mail...

On 03/15/2018 10:54 AM, Gianfranco Costamagna wrote:
> control: owner -1 ! control: tags -1 moreinfo
> 1) please fix the qt bug in this upload
> 2) missing lots of copyrights, e.g. src/ThirdParty/Catch/* 
> src/ThirdParty/PEGTL/*
> do you need such external libraries? why aren't it packaged separately?
they are- i apparently forgot to readd the folder to files-excluded at
some point. i readded the folder now and repackaged and reimported the
archive.

> 3) std-version is 4.1.3
yes, should it not be?

> 4)  dh ${@} --parallel --with=autoreconf
> isn't this automatic with compat level 10?
both removed.

i've also fixed a bug in the usbguard.postinst script that errored out
if one of the chmoded files didn't exist.

i've uploaded new versions of the packages to mentors.d.o and pushed all
the commits to salsa.

cheers and thanks,
muri



signature.asc
Description: OpenPGP digital signature

Re: Bug with sev: grave while new package waiting

[Muri Nicanor]

Hi,

On 03/15/2018 01:05 PM, Gianfranco Costamagna wrote:
> Hello,
>> Thanks, i've added some commits and specified the qt version and pushed
>> everything to salsa.
> 
> 
> please also address the stuff on RFS bug
i already pushed those changes a few weeks ago ;)

> and...
> --with=autoreconf
> isn't this useless too?
ah, yes, you're right. pushed.

> "libqt5core5a (<<5.10)" this will make it uninstallable when 5.10 goes in 
> unstable...
> isn't it better to just make it compatible with new qt stack? I don't want to 
> make qt folks
> sad.
hm, maybe i'm misunderstanding the problem, but i thought the applet
only works with the qt version it was compiled with. is it even possible
to build a package for unstable with a library from experimental? or is
there a way to make it compatible with both versions?

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Re: Bug with sev: grave while new package waiting

[Muri Nicanor]

Hi,

On 03/15/2018 10:48 AM, Gianfranco Costamagna wrote:
> Hello,
> 
>> there is a bug with severity: grave in usbguard, because of a libqt5
>> version incompatibility (#892045) and there is already a new version of
>> usbguard waiting to be sponsored. Should i fix the bug in the new
>> version or should i fix it in the version thats already in the archive?
> 
> 
> I'm taking the new version, feel free to fix it on top of the new one.
> (the new version has some issues, so maybe we will do only one upload)

Thanks, i've added some commits and specified the qt version and pushed
everything to salsa.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug with sev: grave while new package waiting

[Muri Nicanor]

hi mentors,

there is a bug with severity: grave in usbguard, because of a libqt5
version incompatibility (#892045) and there is already a new version of
usbguard waiting to be sponsored. Should i fix the bug in the new
version or should i fix it in the version thats already in the archive?

cheers and thanks,
muri



signature.asc
Description: OpenPGP digital signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

Hi nicoo,

On 02/11/2018 08:32 PM, Nicolas Braud-Santoni wrote:
> On Wed, Jan 24, 2018 at 08:23:12PM +0100, Muri Nicanor wrote:
>> i've fixed the bugs and uploaded the new version of usbguard to mentors,
>> and i've also pushed all the commits to salsa.
> 
> Hi!
> 
> Thanks for the good work on usbguard.
> 
> 
> I started taking a look, but it seems you forgot to push tags to the
> repository on salsa.d.o, so it's a bit annoying to diff with the version
> currently in Debian (or even just run `gbp buildpackage`).
> 
> Could you do that?  It's just a `git push --tags`  :)

i've pushed the tags, thanks for pointing that out.

cheers,
muri

> 
> 
> Best,
> 
>   nicoo
> 



signature.asc
Description: OpenPGP digital signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

control: reopen -1
control: retitle -1 RFS: usbguard/0.7.2+ds-1

On 01/23/2018 08:36 AM, Tobias Frost wrote:
> Please do not close RFS in this cases, so that the context is maintained.
> A RFS should be only be closed when uploaded (or when there is no longer
> something to sponsor).
> 
> When you have a new version, please recycle the bug, and retitle it
> appropiatly.

oke! i'm reopening the bug and retitleing for the new version.
i've fixed the bugs and uploaded the new version of usbguard to mentors,
and i've also pushed all the commits to salsa.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#887665: RFS: usbguard/0.7.1+ds-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name : usbguard
  Version  : 0.7.1+ds-1
  Upstream Author  : Muri Nicanor <m...@immerda.ch>
* Url  : https://dkopecek.github.io/usbguard/
* Licenses : GPL-2+,GPL-3+,CC-BY-SA-3.0,FSFULLR,public-domain
  Programming Lang : C
  Section  : utils

 The USBGuard software framework helps to protect your computer against
 rogue USB devices (a.k.a. BadUSB) by implementing basic whitelisting
 and blacklisting capabilities based on device attributes.

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.1+ds-1.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://salsa.debian.org/muri-guest/usbguard

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/


Changes since last upload:

  * New upstream version 0.7.1 (Closes: #868160)
  * remove dh-systemd due to being part of debhelper (>= 9.20160709)
  * bump standards version
  * add correct section to libusbguard0
  * remove parsing of dpkg-genchangelog
  * updated the watch file for the new github url, modified the archive name
so the correct version will be used and removed the signature line, as
that version is not signed
  * remove patches that have been upstreamed
  * add asciidoctor to build depends

Regards,
  Muri Nicanor





signature.asc
Description: OpenPGP digital signature

Re: Change file permissions

[Muri Nicanor]

Hi,

On 01/18/2018 10:02 AM, Gianfranco Costamagna wrote:
> Hello,
>> they are not 600. should i set the file permissions on package upgrade
>> or should i leave this to the user?
> 
>> if i should set them, should i use postinst or is there a better way?
> 
> is a dh_fixperms override helpful?

not really, because if i read its manpage correctly it only lets me
exclude files from dh_fixperms' predefined directory+mode configurations.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Change file permissions

[Muri Nicanor]

hi mentors,

i'm finalizing the package for the new usbguard version. the daemon now
looks at the permissions of the config files and refuses to start if
they are not 600. should i set the file permissions on package upgrade
or should i leave this to the user?
if i should set them, should i use postinst or is there a better way?

cheer and thanks,
muri



signature.asc
Description: OpenPGP digital signature

Bug#878516: RFS: ansi/0.1.3-1 [ITP]

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "ansi". (i've already sent an
RFS to debian-python a month ago:
https://lists.debian.org/debian-python/2017/09/msg00038.html)

* Package name : ansi
  Version  : 0.1.3-1
  Upstream Author  : Wijnand Modderman-Lenstra 
* Url  : https://github.com/tehmaze/ansi/
* Licenses : Expat
  Programming Lang : Python
  Section  : python

 Various ANSI escape codes, used in moving the cursor in a text console or
 rendering coloured text.

It builds those binary packages:

  * python3-ansi

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/ansi

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/a/ansi/ansi_0.1.3-1.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://anonscm.debian.org/git/python-modules/packages/ansi.git

More information about ansi can be obtained from
https://github.com/tehmaze/ansi/


cheers,
  muri



signature.asc
Description: OpenPGP digital signature

Bug#876199: RFS: usbguard/0.7.0+ds1-2

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name : usbguard
  Version  : 0.7.0+ds1-2
  Upstream Author  : Daniel Kopeček <dkope...@redhat.com>
* Url  : https://dkopecek.github.io/usbguard/
* Licenses : GPL-2+,GPL-3+,CC-BY-SA-3.0,FSFULLR,public-domain
  Programming Lang : C
  Section  : utils

 The USBGuard software framework helps to protect your computer against
 rogue USB devices (a.k.a. BadUSB) by implementing basic whitelisting
 and blacklisting capabilities based on device attributes.
 .
 This package contains the shared library

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.0+ds1-2.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://0xacab.org/muri/debian-usbguard

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/


Changes since last upload:

  * Remove qt4 dependencies (Closes: #875220)
  * Backport patch for multiple applet instances
(Closes: #871997)
  * Backport patch to make UEventDeviceManager work
with kernel >= 4.13 (Closes: #875808)

Regards,
  Muri Nicanor



signature.asc
Description: OpenPGP digital signature

Re: Package rejected bc of missing .orig

[Muri Nicanor]

Hi,

On 09/19/2017 04:51 PM, Gianfranco Costamagna wrote:
> Hello,
> 
>> usbguard   | 0.7.0+ds1-1   | unstable   | source, amd64, arm64, armel, 
>> armhf, i386, mips, mips64el, mipsel, powerpc, ppc64el, s390x
> 
> so it seems a mentors.d.o bug then (e.g. DebOMatic is smart enough to find 
> the orig tarball automatically when already in the archive) :)
> 
> BTW: "changestool *.changes includeallsources" works to include the orig 
> tarballs.

Thanks, that was what i was looking for!
> Your upload of the package 'usbguard' to mentors.debian.net was
> successful.
;)

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Package rejected bc of missing .orig

[Muri Nicanor]

hi mentors,

please cc me on reply.

i'm trying to upload usbguard_0.7.0+ds1-2 to mentors, but it gets rejected:

> Rejecting incomplete upload. You did not upload
> usbguard_0.7.0+ds1.orig.tar.gz and we didn't find it on any of our
> alternative resources.
> If you tried to upload a package which only increased the Debian
> revision part, make sure you include the full source (pass -sa to
> dpkg-buildpackage)

i'm using git-buildpackage, i wasn't able to find a way to find out what
-sa would do to dpkg-buildpackge (the mangpage mentions -sa, but without
explanation). usbguard_0.7.0+ds1.orig.tar.gz is on [0].


any help is apprechiated,
cheers,
muri

[0]
http://http.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.0+ds1.orig.tar.gz



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Hi gustavo,

On 07/22/2017 08:43 AM, gustavo panizzo wrote:
> Hello
> 
> I did review the package, here are my comments
> 
> - i did compare usbguard-0.7.0 tag from upstream github with
>  upstream/0.7.0+ds1 from your repo
> 
> - Why did you remove NOTES.md, doc/usbguard-vs-udev.md,  and
> ROADMAP.md?, they look useful.
I did not- i'm not using the git repo from upstream as a source for
orig, but i'm using the tar.gz upstream provides. In this tar.gz (which
i imported using gbp import-orig --uscan), those files are not included

> - in your git repo there should be a tags with the debian releases, i only
>  see upstream/XXX tags. please push, and sign, tags to your repo.
Oke, i've created a signed tag for this release and pushed it

> - why m4/* files haven't been updated since release 0.5, upstream no
>  longer ship those files. Why keep shipping it? i can build
>  successfully against stretch, with or without them.
Hm, they are part of upstreams release, i'll ask if they can be removed
upstream

> - why src/GUI.qt/ is deleted?
Hm, what do you mean? i don't see that happening...

> - i'm glad you deleted the 3rd party code :)
> 
> - please import upstream tags on your git repo, that makes more easy for
>  others to review (and hopefully send patches)
I plan to switch to using upstreams git repo at some point, but at the
moment I feel more safe using the released .tar.gz files. Is it a big
advantage for reviewing the packaging stuff? In that case i'll try to
have a go at this before the next usbguard release...

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#868378: RFS: nlohmann-json/2.1.1-1

[Muri Nicanor]

Hello Christian,

thanks for pointing that out!

On 07/16/2017 08:47 AM, Christian Seiler wrote:
> This will likely break builds of reverse dependencies because they
> might not find the header anymore. Did you test all of the reverse
> dependencies of nlohmann-json in the archive that they'll find the
> header in the new location? If some of them don't, you should file
> bugs against those packages (ideally with patches) that the
> maintainers know about this change. [1]
There are two reverse dependencies atm, usbguard and mkvtoolnix. I've
removed the build-dependency from usbguard, because it was not needed
anymore and i've filed bug #868573 against mkvtoolnix and attached a patch.

Not sure if that qualifies as a library transition if its only one
package, especially as mkvtoolnix doesn't FTBFS with the new
nlohmann-json package (because it ships its own copy os the json.hpp
file which it falls back to if the system one is not found...)

cheers,
muri

> 
> Also, if the current packages can't auto-detect the new location
> (i.e. they start to FTBFS with your new package), then this is
> technically a library transition, so you should follow the
> guidelines for those:
> https://wiki.debian.org/Teams/ReleaseTeam/Transitions
> 
> Regards,
> Christian
> 
> [1] List of reverse depends (since this is a header-only library):
> grep-dctrl -s Package -F Build-Depends,Build-Depends-Indep \
> nlohmann-json-dev /var/lib/apt/lists/*Sources
> (You need sid in your sources.list and a recent apt-get update
> to ensure this is up to date.)
> 



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Hi,

On 07/16/2017 05:28 PM, gustavo panizzo wrote:
>> [...]
>> but i've removed those files from the archive for now, patched the
>> relevant testscripts and created a bug report to create the testdata
>> from source [0]
> cool, excelent
> please add a target gen-orig-xz (or gz, or bz2) to d/rules to generate
> the source from upstream source.
done in git

>>> d/control
>>>
>>> - You have a d/gbp.conf but not Vcs-* headers on d/control
>>>  would be cool if you publish your git packaging, and documented it on
>>>  d/control
>> fixed
> 
> please push tags to you repo so i can compare between your tags and
> upstream tags
done

> the package fails to build with sbuild
it works here *if* i stop the usbguard-daemon on the system i'm building
the package. one of the tests tries to start a usbguard daemon which
fails if there is already a daemon running

> please do the d/rules targe and/or the tag in the repo so i have a way
> to validate the source you are providing before upload. i don't see
> anything else
> missing in the package :)

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

i've uploaded another version that removes an unused build-dependency



signature.asc
Description: OpenPGP digital signature

Bug#868378: RFS: nlohmann-json/2.1.1-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name : nlohmann-json
  Version  : 2.1.1-1
  Upstream Author  : Niels Lohmann <m...@nlohmann.me>
* Url  : https://nlohmann.github.io/json/
* Licenses : MIT,BSL-1.0,Apache-2.0
  Programming Lang :
  Section  : libs

 JSON library with intuitive syntax, trivial integration and serious
 testing. Other aspects, as memory efficiency and speed were not so
 important. The library consists of a single source file json.hpp.

It builds those binary packages:

  * nlohmann-json-dev

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/nlohmann-json

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.1.1-1.dsc


More information about nlohmann-json can be obtained from
https://nlohmann.github.io/json/


Changes since last upload:

  * New upstream version 2.1.1
  * Switched build system to cmake, library is now installed in
/usr/include/nlohmann, which is upstream default (Closes: #868112)

Regards,
  Muri Nicanor



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

On 06/29/2017 05:35 PM, gustavo panizzo wrote:
> Hello, apologies for the late response

no worries, as you can see i'm not very fast myself

oke, so...

On 06/18/2017 11:23 AM, gustavo panizzo wrote:
> d/copyright
> 
> - please set the years to include 2016, 2017. there are some files owned
> by RH which are copyright 2016 but in d/copyright it only says 2015
fixed

> - src/Tests/Makefile.in, src/Tests/test-driver are copyright FSF
added in d/copyright

> - would be cool to run files-without-copyright.sh
you mean in d/rules?

>>> - src/Tests/USB/data/0001.bin src/Tests/UseCase/DummyDevices/root.tar.xz
>>>  what's the source of that file? please regenerate them at build time
>> i'm not sure how to deal with this- the 0001.bin is a copy of a binary
>> USB Descriptor of one of upstreams devices.
> which device? is it a physical device? is it a virtual device?

upstream says:
> This is a copy of a binary USB descriptor of one of my devices. I
don't think I know anymore which one

but i've removed those files from the archive for now, patched the
relevant testscripts and created a bug report to create the testdata
from source [0]

> - please clarify copyright for src/Tests/custom.supp
done so in [1] and upstream added a public domain header [2]. i've added
a paragraph about that file to d/copyright, although it does not yet
contain that public domain header in this release (the file containing
the public domain header is not part of a relaese)

> d/control
> 
> - You have a d/gbp.conf but not Vcs-* headers on d/control
>  would be cool if you publish your git packaging, and documented it on
>  d/control
fixed

>  if you do that, please use pristine-tar to publish the tarballs
oke, i've imported the tarballs using pristine-tar commit
../usbguard_0.7.0+ds1.orig.tar.gz and used --git-pristine-tar with gbp

> d/changelog
> 
> - please fix spelling in 'neede kernek'
fixed

> * New upstream version 0.7.0
>  This release contains a backwards incompatible
>  change because it changes how the device hash is
>  computed for Linux root hub devices
> 
> Please create a NEWS.Debian file, also please make a note to add a
> notice in the release manual for buster (i know, looong time)
> Users hate when things change without notice (i'm an usbguard user :)
i've added a d/NEWS file (dch --create --news) and added the information
there. did you mean i should make a note for myself or did you mean a
note in d/NEWS and if the latter, what is the syntax?

new version is on mentors ;)

cheers,
muri

[0] https://github.com/dkopecek/usbguard/issues/188
[1] https://github.com/dkopecek/usbguard/issues/175
[2]
https://github.com/dkopecek/usbguard/commit/faa84a648a575db7d8e382729ea7dcea079afe3a



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Hi,

On 06/18/2017 11:23 AM, gustavo panizzo wrote:
> - src/Tests/USB/data/0001.bin src/Tests/UseCase/DummyDevices/root.tar.xz
>  what's the source of that file? please regenerate them at build time

i'm not sure how to deal with this- the 0001.bin is a copy of a binary
USB Descriptor of one of upstreams devices. The root.tar.xz is an
archive containing the files from
src/Tests/UseCase/DummyDevices/{bus,devices}, which itself is a copy of
upstreams /sys/bus/usb and /sys/devices, containing also some binary
files. And the files are only there for the tests.

i would compare this with a JPG-file thats part of a graphics library
test-routine or something like that...

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Re: Exclude files after gpb import-orig

[Muri Nicanor]

Hi,

On 06/19/2017 06:13 PM, Mattia Rizzolo wrote:
> On Mon, Jun 19, 2017 at 06:43:43PM +0500, Andrey Rahmatullin wrote:
>> On Mon, Jun 19, 2017 at 03:38:24PM +0200, Muri Nicanor wrote:
>>> I've imported a source package into git using gbp import-orig --uscan,
>>> then updated the changelog with gbp dch and then made a lot of changes
>>> (and commited them). Now I added a file to Files-Excluded: in
>>> debian/copyright- but when I run gbp buildpackage, it still generates a
>>> source-package with the file included. I guess i have to somehow run
>>> uscan again, and redo the import-orig?
>> Yes, Files-Excluded: is only used by uscan when generating the orig.tar.
>> Don't forget to change the upstream version when regenerating the tarball.
> 
> Also, you don't really need to run uscan (which can be a very annoying
> task if you are on slow network and the tarball is big), you only need
> mk-origtargz(1), which is the tool uscan calls to repack the tarball,
> and you can use the tarball you already have.
> If you haven't pushed anything around, you might be able to roll back
> you changes to were you were before, but it can be difficult and
> "dangerous" (for you safety of the data in the git repo) if you are not
> keen to use git.  I recommend just rebuilding the tarball versioning it
> +dfsg1 (assuming the previous one was "+dgsg" only) and import it again.
> 
Thank you Andrey and Mattia, that worked. For the record, I've added the
files to Files-Excluded, ran mk-origtargz -S +ds1
../usbguard_0.7.0.orig.tar.gz and then ran gbp import-orig
../usbguard_0.7.0+ds1.orig.tar.gz and used 0.7.0+ds1 as upstream-version
(and then updated the d/changelog files accordingly).

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Exclude files after gpb import-orig

[Muri Nicanor]

hi list,

I've imported a source package into git using gbp import-orig --uscan,
then updated the changelog with gbp dch and then made a lot of changes
(and commited them). Now I added a file to Files-Excluded: in
debian/copyright- but when I run gbp buildpackage, it still generates a
source-package with the file included. I guess i have to somehow run
uscan again, and redo the import-orig?

cheers & thanks,
muri



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

control: tags -1 - moreinfo

hi,

On 06/01/2017 12:07 PM, gustavo panizzo wrote:
> the package builds fine with pbuilder but tests fails when i try to
> build using sbuild.
> 
> FAIL UseCase/001_cli_policy.sh (exit status: 1)
this fails if there is already a running usbguard instance- when i
stopped mine the test ran fine


> perhaps usbguard should build-depend on sudo?
> 
> UseCase/002_cli_devices.sh.log:  + sudo -n dd bs=4096 count=1
> if=/dev/zero of=/tmp/usbguard_disk
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 81:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe dummy_hcd
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 82:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n rmmod g_mass_storage
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 83:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe g_mass_storage
> file=/tmp/usbguard_disk iSerialNumber=555666111
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 84:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + '[' 127 -ne 0 ']'
> UseCase/002_cli_devices.sh.log:  + exit 77
> UseCase/002_cli_devices.sh.log:  SKIP UseCase/002_cli_devices.sh (exit
> status: 77)

this test is now disabled (skipped), as the neede kernel modules needed
are not part of debian default kernel

> this should be easy to fix
> 
> Packaging/spell-check.sh.log:  Skipping test because some dependecies
> are missing
> Packaging/spell-check.sh.log:  ASPELL: Packaging/spell-check.sh.log: 
> PANDOC: /usr/bin/pandoc
> Packaging/spell-check.sh.log:  SKIP Packaging/spell-check.sh (exit
> status: 77)
fixed.

i've uploaded a new version to mentors,

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Hi,

On 06/01/2017 11:54 AM, gustavo panizzo wrote:
> Hello
> 
> On Wed, May 24, 2017 at 07:43:35PM +0200, Muri Nicanor wrote:
> 
>>  * New upstream version 0.7.0
>>This release contains a backwards incompatible
>>change because it changes how the device hash is
>>computed for Linux root hub devices
> 
> How is it handled for users that already have a config file? do they
> need to create a new configuration file?
kind of. the hashes of the devices in the usbguard rules file will have
to be set to new values. in the old versions of usbguard, the Linux root
hub bcdDevice value was included in the hash value of the device- but
this value changes every new kernel release. so it is now excluded from
calculating the hash.

> Can the update to the config file by done automatically? (postinst)
i don't think so- postinst would have to calculate new hashes for every
device listed in the rules file but most devices won't be present at the
time of upgrading.

> does this version need a newer kernel than older versions?
no



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

hi,

On 06/01/2017 12:07 PM, gustavo panizzo wrote:
> control: owner -1 !
> control: tags -1 moreinfo
> 
> the package builds fine with pbuilder but tests fails when i try to
> build using sbuild.
thanks for the pointer, i totally missed that only using pbuilder. now i
also have a working sbuild schroot ;)

> FAIL UseCase/001_cli_policy.sh (exit status: 1)
hm, i'm not sure yet why this test is failing, looking into thath

> 
> some tests are skipped, i feel they should run
> 
> 
> perhaps usbguard should build-depend on sudo?
> 
> UseCase/002_cli_devices.sh.log:  + sudo -n dd bs=4096 count=1
> if=/dev/zero of=/tmp/usbguard_disk
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 81:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe dummy_hcd
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 82:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n rmmod g_mass_storage
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 83:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe g_mass_storage
> file=/tmp/usbguard_disk iSerialNumber=555666111
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 84:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + '[' 127 -ne 0 ']'
> UseCase/002_cli_devices.sh.log:  + exit 77
> UseCase/002_cli_devices.sh.log:  SKIP UseCase/002_cli_devices.sh (exit
> status: 77)

i tried with removing the sudo, but debian doesn't have dummy_hcd or
g_mass_storage included in the kernel, so these tests won't work at all :(

> 
> 
> this should be easy to fix
> 
> Packaging/spell-check.sh.log:  Skipping test because some dependecies
> are missing
> Packaging/spell-check.sh.log:  ASPELL: Packaging/spell-check.sh.log: 
> PANDOC: /usr/bin/pandoc
> Packaging/spell-check.sh.log:  SKIP Packaging/spell-check.sh (exit
> status: 77)

thanks! i've added aspell to the build-dependencies!

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name: usbguard
  Version : 0.7.0-1
  Upstream Author : Daniel Kopeček
* Url : https://dkopecek.github.io/usbguard/
* Licenses: CC-BY-SA-3.0,FSFULLR,GPL-3+,GPL-2+
  Section : utils

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.0-1.dsc

Or clone the package from https://0xacab.org/muri/debian-usbguard

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/

Changes since last upload:

  * New upstream version 0.7.0
This release contains a backwards incompatible
change because it changes how the device hash is
computed for Linux root hub devices
  * Add support for bash-completion
  * Delete add-unistd.patch, its not needed anymore
  * Compile the library static, to make `make check` work
  * Bump compat version to 10
  * Add d/usbguard.dirs

Regards,
  Muri Nicanor




signature.asc
Description: OpenPGP digital signature

Re: Additional files/folders in package

[Muri Nicanor]

hi,

On 05/24/2017 09:44 AM, Andrey Rahmatullin wrote:
> On Wed, May 24, 2017 at 08:56:12AM +0200, Muri Nicanor wrote:
>> i'm in the process of upgrading usbguard to 0.7. In the new upstream
>> usbguard-daemon.conf there are the folder
>> /etc/usbguard/IPCAccessControl.d/ and the file
>> /var/log/usbguard/usbguard-audit.log specified. I'm not sure what's the
>> best way to create those:
> Create the directory with debian/package.dirs.
okey

> Why do you need to create
> the log file though?
turns out i don't!

> 
>> is there maybe a debhelper for logfiles (which creates logrotate configs
>> for those files...)?
> A logrotate config is a text file. You should create it yourself if it's
> not shipped by the upstream. You can use dh_installlogrotate to install
> it.
oke, i'll do that

thanks,
muri



signature.asc
Description: OpenPGP digital signature

Additional files/folders in package

[Muri Nicanor]

Hello mentors,

i'm in the process of upgrading usbguard to 0.7. In the new upstream
usbguard-daemon.conf there are the folder
/etc/usbguard/IPCAccessControl.d/ and the file
/var/log/usbguard/usbguard-audit.log specified. I'm not sure what's the
best way to create those:

a) remove or comment those lines from the usbguard-daemon.conf file
b) create them in a usbguard.postinst script (mkdir -p and touch in the
configure part)
c) create them in the build directory using d/rules and let dh_install
handle the rest
d) use dh_installdirs (and something similar for the logfile)

is there maybe a debhelper for logfiles (which creates logrotate configs
for those files...)?

at the moment i'd use b), but maybe there are even better solutions?

thanks and cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#854230: RFS: usbguard/0.6.2+ds1-2 [RC]

[Muri Nicanor]

Package: sponsorship-requests
Severity: serious

Dear mentors,

I am looking for a sponsor for my package "usbguard". This revision
fixes a serious bug (#854192), which makes installing break on a minimal
stretch installation. I'm not sure, should i contact release team about
that or does the sponsor do that?

* Package name: usbguard
  Version : 0.6.2+ds1-2
  Upstream Author : Daniel Kopeček <dkope...@redhat.com>
* URL : https://github.com/dkopecek/usbguard
* License : GPL-2+
  Section : utils

It builds those binary packages:

 libusbguard0 - USB device authorization policy framework - shared library
 usbguard   - USB device authorization policy framework
 usbguard-applet-qt - USB device authorization policy framework - qt applet

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.6.2+ds1-2.dsc

Changes since the last upload:

  * Add dbus to Depends (Closes: #854192)


Regards,
   Muri Nicanor



signature.asc
Description: OpenPGP digital signature

Re: serious bug in usbguard installation

[Muri Nicanor]

Hi!

On 02/04/2017 11:25 PM, Christian Seiler wrote:
> On 02/04/2017 10:09 PM, Muri Nicanor wrote:
>> i just found a bug (#854192) in the installation procedure of usbguard:
>> when i install usbguard on a minimal stretch system, the installation
>> stalls and never ends successfully. apparently it has something to do
>> with dbus being a dependency of usbguard. if i install dbus *before*
>> installing usbugard, everything works fine. this is probably, why it
>> didn't come up before. if i don't, the installations procedure stalls at
>>> /var/lib/dpkg/info/usbguard.postinst configure
>>
>> and the journal says
>>> Feb 04 13:11:04 debian dbus-daemon[1200]: Unknown username
>>> "usbguard-dbus" in message bus configuration file
>>> Feb 04 13:11:04 debian dbus-daemon[1200]: Failed to start message
>>> bus: Could not get UID and GID for username "messagebus"
> 
> Problem is that DBus fails to start, and systemd requires DBus to be
> running (and configured properly) if Type=dbus is used.
> 
> The problem is that your package doesn't have Depends: dbus, so it
> doesn't depend on the DBus daemon being available, so APT configures
> dbus after usbguard (it's allowed to do that w/o an explicit Depends),
> which is bad, since dbus's postinst creates the 'messagebus' user,
> without which the DBus daemon doesn't start.
> 
> Fix is simple: add that dependency. :-) If you look at other DBus
> services, they all have that dependency explicitly.

Ah, thanks! Thats actually much easier than i thought ;) i'll upload a
new revision today!

cheers,
muri



signature.asc
Description: OpenPGP digital signature

serious bug in usbguard installation

[Muri Nicanor]

hi,

i just found a bug (#854192) in the installation procedure of usbguard:
when i install usbguard on a minimal stretch system, the installation
stalls and never ends successfully. apparently it has something to do
with dbus being a dependency of usbguard. if i install dbus *before*
installing usbugard, everything works fine. this is probably, why it
didn't come up before. if i don't, the installations procedure stalls at
> /var/lib/dpkg/info/usbguard.postinst configure

and the journal says
> Feb 04 13:11:04 debian dbus-daemon[1200]: Unknown username
> "usbguard-dbus" in message bus configuration file
> Feb 04 13:11:04 debian dbus-daemon[1200]: Failed to start message
> bus: Could not get UID and GID for username "messagebus"
> Feb 04 13:11:29 debian systemd[1]: Failed to subscribe to
> NameOwnerChanged signal for 'org.usbguard': Connection timed out
> Feb 04 13:11:29 debian systemd[1]: Failed to subscribe to
> NameOwnerChanged signal for 'org.freedesktop.login1': Connection
> timed out
> Feb 04 13:11:29 debian systemd[1]: Failed to subscribe to activation 
> signal: Connection timed out
> Feb 04 13:11:29 debian systemd[1]: Failed to register name:
> Connection timed out
> Feb 04 13:11:29 debian systemd[1]: Failed to set up API bus:
> Connection timed out
> Feb 04 13:11:29 debian systemd[1]: dbus.service: Main process exited,
> code=exited, status=1/FAILURE
> Feb 04 13:11:29 debian systemd[1]: dbus.service: Unit entered failed
> state.
> Feb 04 13:11:29 debian systemd[1]: dbus.service: Failed with result
> 'exit-code'.
> Feb 04 13:11:29 debian systemd[1]: Looping too fast. Throttling
> execution a little.

with the last line then repeating every minute.
the process tree of dpkg actually looks like this:

|   \_ sudo apt install usbguard
|   \_ apt install usbguard
|   \_ /usr/bin/dpkg --status-fd 13 --configure --pending
|   \_ /bin/sh /var/lib/dpkg/info/usbguard.postinst configure
|   \_ perl /usr/bin/deb-systemd-invoke start
usbguard-dbus.service usbguard.service
|   \_ /bin/systemctl start usbguard.service
|   \_ /bin/systemd-tty-ask-password-agent --watch

Because the installation failes in that case, i tagged the bug with
severity serious. i know its a rather bad timing and i should have tried
the installation on a minimal install before...

does anyone have an idea, what the problem could be in that case? i'm
rather clueless...

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#847792: RFS: usbguard/0.6.2+ds1-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name: usbguard
  Version : 0.6.2+ds1-1
  Upstream Author : Daniel Kopeček
* Url : https://dkopecek.github.io/usbguard/
* Licenses: CC-BY-SA-3.0,GPL-3+,FSFULLR,GPL-2+
  Section : utils

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.6.2+ds1-1.dsc


More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/

Changes since last upload:

  * New upstream version 0.6.2+ds1
  * Add xdg autostart file to usbguard-applet-qt (Closes: #838173)
  * fixed upstream version tag
  * set default compilder and linker flags
  * changed the location of libusbguard.so.0 to a private directory
and set the rpath accordingly
  * remove the fix-mips-build patch, it was included upstream
  * remove the development file package, because the library is not
stable for now

cheers,
-- 
muri





signature.asc
Description: OpenPGP digital signature

usbguard soname stability

[Muri Nicanor]

hi,

the usbguard source package ships a shared library libusbguard0. i asked
upstream about bumping the soname when the interface changes, but
upstream considers usbguard 0.x as not stable yet and will start
maintaining soname version beginninig with 1.x (which is understandable).

i tried a buch of approaches to set the soname in the d/rules file, but
i failed. now i was thinking, if the shared library is not stable, it
maybe makes more sense to not ship it- but the main program use it. is
there a way of including a 'shared' library without sharing it?

or how do i set the soname in the d/rules file (i tried with
-Wl,-soname,libusbguard-d0.6.2.so in DEB_CXXFLAGS_MAINT_APPEND and in a
lot of other places).

and related: because upstream does not consider the project stable yet,
i'd file an rc bug (in the full freeze time) to prevent the package from
transitioning to stable. or is there an better/alternative way?

thanks a lot,
cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#847403: RFS: nlohmann-json/2.0.6-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 2.0.6-1
  Upstream Author : Niels Lohmann
* Url : https://nlohmann.github.io/json/
* Licenses: Apache-2.0,BSL-1.0,MIT
  Section : libs

It builds those binary packages:

  * nlohmann-json-dev

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/nlohmann-json

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.6-1.dsc


More information about nlohmann-json can be obtained from
https://nlohmann.github.io/json/

Changes since last upload:

  * New upstream version 2.0.5
  * New upstream version 2.0.6

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#837704: RFS: usbguard/0.5.14+ds1-2

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

because there is still some stuff to sort out with the new usbguard 0.6
release, i fixed the bugs in the already uploaded release and made a new
debian revision. I hope that approach is oke.

I am looking for a sponsor for my package "usbguard"

 * Package name: usbguard
   Version : 0.5.14+ds1-2
   Upstream Author : Daniel Kopeček 
 * URL : https://github.com/dkopecek/usbguard
 * License : GPL-2+
   Section : utils

  It builds those binary packages:

 libusbguard-dev - USB device authorization policy framework -
development files
 libusbguard0 - USB device authorization policy framework - shared library
 usbguard   - USB device authorization policy framework
 usbguard-applet-qt - USB device authorization policy framework - qt applet

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.5.14+ds1-2.dsc

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/

  Changes since the last upload:

  * d/control:
   - Add systemd to build dependencies (Closes: #836713)
   - Change architectures to linux-any in d/control
  * d/rules
   - Add sysconfdir flag to autoconf (Closes: #837176)
  * d/patches/
   - Fix mips build (Closes: #836712)
   - Set correct IPCAllowedGroups (Closes: #837175)

cheers,
-- 
muri




signature.asc
Description: OpenPGP digital signature

Bug#837598: RFS: nlohmann-json/2.0.4-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 2.0.4-1
   Upstream Author : Niels Lohmann
 * URL : https://github.com/nlohmann/json
 * License : MIT
   Section : libs

It builds those binary packages:

nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.4-1.dsc

Changes since the last upload:

* New upstream version 2.0.4

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

atomic_LIBS (was: FTBFS: how to test fixes)

[Muri Nicanor]

hi,

On 09/06/2016 12:44 PM, Christian Seiler wrote:
[...]
> I didn't think about adding -latomic to the linker flag list
> directly via -Wl. I just tested your suggestion and it's really
> funny; libtool does mangle your line and separate it into:
> 
>  -Wl,--push-state -Wl,--as-needed -Wl,-latomic -Wl,--pop-state
> 
> but since there's no direct -l argument, it actually does work
> and the things are kept together and in order.
> 
> @Muri: use this line in the patch instead:
> AC_CHECK_LIB([atomic], [__atomic_add_fetch_8], 
> [atomic_LIBS="-Wl,--push-state,--as-needed,-latomic,--pop-state"], 
> [atomic_LIBS=""]) 
> 
> That way, the libatomic dependency will only be picked up on
> platforms where it's necessary.

i've created a pull request for that change upstream[0], but the ci
seems not to like the patch:
https://travis-ci.org/dkopecek/usbguard/builds/158517934 - i'm not sure
what to make of that, i don't really see a difference in the successfull
builds and the ones that failed.

[0] https://github.com/dkopecek/usbguard/pull/126

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#836959: RFS: usbguard/0.6.0+ds1-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "usbguard"

 * Package name: usbguard
   Version : 0.6.0+ds1-1
   Upstream Author : Daniel Kopeček 
 * URL : https://github.com/dkopecek/usbguard
 * License : GPL-2+
   Section : utils

  It builds those binary packages:

 libusbguard-dev - USB device authorization policy framework -
development files
 libusbguard0 - USB device authorization policy framework - shared library
 usbguard   - USB device authorization policy framework
 usbguard-applet-qt - USB device authorization policy framework - qt applet

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.6.0+ds1-1.dsc

More information about hello can be obtained from
https://dkopecek.github.io/usbguard/

Changes since the last upload:

  * New upstream release
  * d/control:
- Remove nlohman-json from build-dependencies
- Add protobuf build dependency
- Change the architecture to linux-any
- Add systemd to build dependencies (Closes: #836713)
  * d/rules
- Add configure flag to enable building of the qt-gui
- Add sysconfdir argument to configure
  * Add patch to link against libatomic if present (Closes: #836712)

PS: I tried to test the build process on a qemu-mips machine, but i only
could create a qemu-system-mips machine with 256MB ram, which was not
enough for the build process. But christian said that he build-tested
the patch and i trust his judgment.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Re: FTBFS: how to test fixes

[Muri Nicanor]

hi,

On 09/05/2016 09:11 PM, Christian Seiler wrote:
> On 09/05/2016 08:59 PM, Muri Nicanor wrote:
>> On 09/05/2016 08:33 PM, Christian Seiler wrote:
>>>Since you depend on systemd.pc, which is part of the
>>>systemd package, just Build-Depend on systemd to make
>>>systemd.pc available. You won't need porterbox access
>>>to fix that issue. (Btw. libsystemd.pc != systemd.pc)
>>
>> ah, that comment in paranthesis helped me to understand the problem ;) i
>> was looking at the wrong package and was wondering what to do, because
>> there is no official libsystemd-dev package for hppa. thanks for
>> pointing that out! ;)
> 
> Huh? There is libsystemd-dev on hppa, it's just out of date
> at the moment:

ah, yeah- in addition, i looked in the wrong place:
https://packages.debian.org/search?searchon=contents=systemd.pc=path=stable=any
;)

cheers and thanks for all the help!
-- 
muri



signature.asc
Description: OpenPGP digital signature

Re: FTBFS: how to test fixes

[Muri Nicanor]

Hi,

On 09/05/2016 08:33 PM, Christian Seiler wrote:
> On 09/05/2016 07:20 PM, Andrey Rahmatullin wrote:
>> On Mon, Sep 05, 2016 at 07:07:51PM +0200, Muri Nicanor wrote:
>>> so, i've got my first two FTBFS bugs (on mips and hppa)- what the
>>> recommended way of testing fixes for architectures i don't have
>>> testmachines of?
>> Porterboxes. See https://dsa.debian.org/doc/guest-account/ about getting
>> access for non-DDs.
> 
> Note that there are no official hppa porterboxes. You can ask on
> the debian-hppa mailing list for access to an unofficial one
> though.
> 
> But speaking of the bugs, they don't actually require porterbox
> access.
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836713
> 
>The hppa build chroots don't have systemd installed (for
>whatever reasaon), in contrast to chroots on most other
>architectures.
> 
>Since you depend on systemd.pc, which is part of the
>systemd package, just Build-Depend on systemd to make
>systemd.pc available. You won't need porterbox access
>to fix that issue. (Btw. libsystemd.pc != systemd.pc)

ah, that comment in paranthesis helped me to understand the problem ;) i
was looking at the wrong package and was wondering what to do, because
there is no official libsystemd-dev package for hppa. thanks for
pointing that out! ;)

>Also note that there are plans to make init non-Essential
>in the future, so more build chroots will not have
>systemd preinstalled in them, so the problem you're seeing
>on hppa now is going to be a problem on all archs sooner
>or later.

ok, thanks for the hint!

> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836712
> 
>MIPS (at least 32bit) doesn't support 64bit atomic
>operations intrinsically (_8 == 8 bytes) - and your software
>uses std::atomic (found that by grepping).
> 
>However, gcc provides an emulation library called libatomic.
>You should link against that emulation library if present
>in order to use those intrinsics.

aha, thanks for the explanation! that makes the situation a lot clearer.

>I've attached a patch against your package (add it as a quilt
>patch) that checks for the availability of libatomic and adds
>it to the linker flags. This might result in a spurious
>dependency on libatomic on other platforms, but unfortunately
>I don't know of any way to properly pass --as-needed for just
>this library without libtool reordering the entire list of
>linker flags. :-(
thanks a lot! i'll integrate that asap and relay it to upstream.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

FTBFS: how to test fixes

[Muri Nicanor]

hi,

so, i've got my first two FTBFS bugs (on mips and hppa)- what the
recommended way of testing fixes for architectures i don't have
testmachines of?

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Re: d/control: Depends on same version

[Muri Nicanor]

hi,

On 09/04/2016 11:03 PM, Christian Seiler wrote:
> On 09/04/2016 09:40 PM, Muri Nicanor wrote:
>> if i have source package foo-x.y that builds binary packages foo_x.y and
>> libfoo_x.y, how can i declare a dependency from foo on libfoo where
>> libfoo has to be the same version of foo?
> 
> If both are Arch: any (or linux-any or something similar):
> 
> Depends: libfoo (= ${binary:Version})

thanks a lot, thats exactly what i was looking for!

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#836701: RFS: nlohmann-json/2.0.3-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

 * Package name: nlohmann-json
   Version : 2.0.3-1
   Upstream Author : Niels Lohmann
 * URL : https://github.com/nlohmann/json
 * License : MIT
   Section : libs

It builds those binary packages:

nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


  Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.3-1.dsc

More information about hello can be obtained from
https://nlohmann.github.io/json/.

Changes since the last upload:

* New upstream release

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

d/control: Depends on same version

[Muri Nicanor]

hi mentors,

if i have source package foo-x.y that builds binary packages foo_x.y and
libfoo_x.y, how can i declare a dependency from foo on libfoo where
libfoo has to be the same version of foo?

thanks and cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825302: RFS: usbguard/0.4-2 [ITP]

[Muri Nicanor]

hi,

i've just uploaded a new version of usbguard to mentors. Its now version
0.5.11, which removes the build dependency on quex, and uses pegtl
(pegtl-dev) instead, which i already packaged and Gianfranco kindly
sponsored. The other unresolved build dependency, json
(nlohmann-json-dev) i've also packaged and is also sponsored by Gianfranco.
In addition, the built packages now also include the qt-applet
(usbguard-applet-qt).

so:
I am looking for a sponsor for my package "usbguard"

 * Package name: usbguard
   Version : 0.5.11-1
   Upstream Author : Daniel Kopeček 
 * URL : https://github.com/dkopecek/usbguard
 * License : GPL-2+
   Section : utils

It builds those binary packages:

 libusbguard-dev - USB device authorization policy framework -
development files
 libusbguard0 - USB device authorization policy framework - shared library
 usbguard   - USB device authorization policy framework
 usbguard-applet-qt - USB device authorization policy framework - qt applet

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.5.11-1.dsc

More information about hello can be obtained from
https://dkopecek.github.io/usbguard/

Changes since the last upload:
* build dependencies are now in testing
* qt-applet is part of the package
* this release contains backwards incompatible changes: the device hash
value computation was changed to include the USB descriptor data

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#833456: RFS: nlohmann-json/2.0.2-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 2.0.2-1
  Upstream Author : Niels Lohmann
* URL : https://github.com/nlohmann/json
* License : MIT
  Section : libs

It builds those binary packages:

nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.2-1.dsc

More information about nlohmann-json can be obtained from
https://nlohmann.github.io/json/.

Changes since the last upload:

* New upstream release

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#830599: RFS: nlohmann-json/2.0.1-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 2.0.1-1
  Upstream Author : Niels Lohmann
* URL : https://github.com/nlohmann/json
* License : MIT
  Section : libs

It builds those binary packages:

  nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.1-1.dsc

More information about nlohmann-json can be obtained from
https://nlohmann.github.io/json/

Changes since the last upload:

 * New upstream realease

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

[Muri Nicanor]

hi,

On 06/17/2016 03:03 PM, Andrey Rahmatullin wrote:
> "No embedded code copies" is not a blind rule, it has its reasons, and I
> think none of them applies here. It would be nice to use the Debian copy
> after it is updated but I don't think it's a blocker. 
oke, sounds like a good plan

> If nobody voices
> their objections I can sponsor the package.
great, thanks! if there's anything i have to/should do now, just tell me ;)

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

[Muri Nicanor]

thanks for the explanation, andrey and christian- i did indeed not know
that the repackaging has to be done by uscan before the build (i thought
that was done during pdebuild).

in the end the Files-Excluded field worked which lead to the unit tests
not being successful (the catch.hpp is only used for the unit tests).
i've tried to use the packaged catch library, but its outdated. so now
its back to the original release of nlohmann-json with the
test/catch.hpp included (although i've updated the copyright file
accordingly)

i'm not exactly sure how to proceed here. catch.hpp is 'only' used for
the unit tests, but nevertheless its an embedded code copy. i guess the
correct way would be to ask for (via bug report?) or create an update of
the catch package?

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

[Muri Nicanor]

Hi Andrey,

thank you for your review!

On 06/13/2016 02:35 PM, Andrey Rahmatullin wrote:
> debian/nlohmann-json-dev.doc-base:
> "Document: json" is too generic, remember it must be unique.
fixed, it matches the package name nonw

> debian/rules:
> There is too many commented out dh_make example lines, you should remove
> them if you don't need them.
fixed

> debian/README.source:
> It says "You WILL either need to modify or delete this file"
file deleted

> debian/patches:
> Patch names should end with .patch
fixed

> debian/copyright:
> It has Files-Excluded: test/catch.hpp but the tarball still contains this
> file.
i don't know what i'm doing wrong. i've tried multiple sytaxes, but the
file somehow resists of being excluded of the tarball

> Consider using the same license as the upstream for debian/.
whats would be the benefit of this?

> The format specification doesn't know about the License-Reference:
> pseudo-field or whatever it is. Instead you should do the same as for GPL
> licenses, provide a short license grant and add the path of the license
> text. You can look at /usr/share/doc/*/copyright on your system for
> examples.
fixed!

thanks again,
cheers
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#826387: RFS: pegtl/1.3.1-1 [ITP]

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "pegtl". This package will be
a build dependency in the next release of usbguard.

* Package name: pegtl
  Version : 1.3.1-1
  Upstream Author : Dr. Colin Hirsch and Daniel Frey
* URL : https://github.com/ColinH/PEGTL
* License : MIT
  Section : libs

It builds those binary packages:

  pegtl-dev  - Parsing Expression Grammar Template Library

To access further information about this package, please visit the
following URL:

 https://mentors.debian.net/package/pegtl

Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/p/pegtl/pegtl_1.3.1-1.dsc

More information about pegtl can be obtained from
https://github.com/ColinH/PEGTL.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 1.1.0-1
  Upstream Author : Niels Lohmann
* URL : https://github.com/nlohmann/json
* License : MIT
  Section : libs

It builds those binary packages:

   nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


Alternatively, one can download the package with dget using this command:

   dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_1.1.0-1.dsc

More information about nlohmann-json-dev can be obtained from
https://nlohmann.github.io/json/.

Regards,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825302: RFS: usbguard/0.4-2 [ITP]

[Muri Nicanor]

hello pabs, hello *,

On 05/27/2016 06:29 AM, Paul Wise wrote:
> Here is another review, I don't intend to sponsor this though.
thanks for the review! again, i've learned a lot ;)

i'v now pushed everythin also to
https://gitlab.com/muri/usbguard-debian/, but not yet updated the
package on mentors, because the build dependencies are now unresolvable

> These things block the upload of this package to Debian:
> 
> debian/copyright isn't complete, some files have different
> licenses/copyright holders to what is documented. I would recommend
> looking at the header of each file and ensuring that is documented.
oke, i've fixed that to my best knowlegde.
i've created a list with files that lack any license and will file a bug
upstream about that.

> debian/changelog should have unstable instead of UNRELEASED if you are
> requesting an upload to unstable.
fixed

> These things block the upload of this package to Debian in my opinion
> but maybe not for others:
> 
> src/ThirdParty and src/Library/RuleParser/quex contain embedded code
> copies. Please ask upstream to remove them from their VCS and tarballs
> and depend on them instead. You can then package them separately.
> Alternatively, package them separately and remove all of them at
> `debian/rules build` time before dh_auto_configure and at
> `debian/rules clean` time (or just have uscan auto-repack the upstream
> tarball using Files-Excluded).
oke, so:
i've filed #825620 (ITP: quex), #825623 (ITP: json), #825625 (ITP: usbmon)

i've tried to exclude the folders using Files-Exclude, but that didn't
seem to work. i'm now deleting them in override_dh_auto_configure and
override_dh_auto_clean.
as soon as all the dependencies are packaged, i'll file a bug report
about removing the bundled code.

> The parser/lexer are not build from source. The documentation is
> actually missing the source code (Markdown).
i don't get the meaning of that last sentence, could you elaborate?


> Please ask upstream to
> remove all the generated files from their VCS and tarballs and create
> them at build time. Obviously some autotools things like ./configure
> need to be in the tarball though. As long as they are regenerated at
> build time using autoreconf that is fine though.
oke


> These things would be nice to fix:
> 
> The debian/changlog excerpts in debian/patches/* aren't needed.
fixed

> I like to have this in my ~/.quiltrc to keep quilt-generated patches clean:
> 
> QUILT_REFRESH_ARGS="-pab --no-timestamps --no-index"
thanks for the tip!

> Please add some DEP-3 headers to the patches, especially Forwarded:
done

> The watch file doesn't work (see the uscan output below), I think you
> need to check the releases page instead.
fixed

> Could you ask upstream to sign their commits, tags and release files?
putting it on my TODO list

> You can glob the manual page paths in usbguard.install:
fixed

> Personally I dislike the "documentation and commented-out settings in
> /etc/..." pattern, how systemd does it is nicer.
what do you mean by 'how systemd does it'?

> For the symbols file you might want to use the c++ pattern type. See
> the dpkg-gensymbols manual page for more details.
oke

> I like to run this command to wrap-and-sort the debian/ directory to
> make diffs easier to read:
> 
> wrap-and-sort --short-indent --wrap-always --sort-binary-packages
> --trailing-comma --verbose
thanks for the tip, done!

> Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
done

> debhelper already passes --disable-silent-rules to ./configure so you
> don't need to.
removed.

> dist/usbguard.service doesn't pay attention to the --prefix, --bindir,
> --etcdir, etc options passed to configure, I would suggest getting
> ./configure to generate it from a .in file.
adding to my TODO list

> The upstream README.md would be useful to install in the binary
> package if it didn't contain build/install instructions. I would
> suggest using sed or similar to automatically strip out those parts
> and copy the result to a README file, which could then be installed.
> Everything between these two headings should be stripped:
adding to my TODO list


> Will you also package the usbguard-applet-qt thing mentioned in README.md?
yes, as far as i can see, the qt-applet will also be part of the source
package in the next release

thanks a lot for all the tips!
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825302: RFS: usbguard/0.4-2 [ITP]

[Muri Nicanor]

Hi,

On 05/25/2016 11:23 PM, James Cowgill wrote:
> On Wed, 2016-05-25 at 21:10 +0200, Muri Nicanor wrote:
>> I am looking for a sponsor for my package "usbguard"
> 
> This looks like quite an interesting package, so here's a review.
wow, thanks for the detailed review, i really appreciate it, i've
learned a lot!

> You do not own the wnpp bug for this package. You need to retitle the
> bug from an RFP to ITP and set yourself as the owner. Do this before
> trying to fix anything else.
done


> Since libusbguard.so is in a public libs directory, you must put it in
> a separate package (probably called libusbguard0). You should then put
> all the development files in libusbguard-dev. 
done, now there are usbguard, libusbguard0 and libusbguard-dev. usbguard
depends on libusbguard0.


> Please run wrap-and-sort so wrap the Build-Depends field in the control
> file.
done

> You don't need the -2 changelog entry since your -1 version was never
> uploaded.
oke, i deleted the old packages and reuploaded to mentors with -1

> You add a group "usbguard" in postinst but didn't remove it in postrm.
> You should probably do that during the purge step.
fixed

> The other things in postrm seem incorrect. Why do you need to remove
> the service file manually?
fixed. but, when uninstalling the package, a
/etc/systemd/system/usbguard.service link to /dev/null is created. so
when reinstalling the package one has to unmask that service. i didn't
find any other way than that part of usbguard.postrm

> "usbguard" must depend on adduser to use addgroup in your postinst.
fixed

> The *.install files should use a wildcard (*) instead of including the
> multiarch directory manually.
fixed

> In rules, --with-bundled-spdlog=no doesn't seem to work.
yes, i removed that now. i tried several times and it uses system spdlog
whatever the configure switch says. and i'm removing the bundled spdlog
before anything else, to be sure.

> Enable parallel building (dh --parallel) if it works.
done

> You build-depend on dh-autoreconf, but don't actually run it. Use
> something like "dh --with=autoreconf,systemd".
done

> copyright:
>  Upstream code is GPL-2+ (not GPL-2)
>  The license identifier for the Boost License is "BSL-1.0"
>  The license identifier for your "MIT-License" is "Expat"
>   https://spdx.org/licenses/
>  Authors isn't a valid field name. You can use Comment or
>   Upstream-Contact instead.
fixed

> The default config doesn't allow the root user to use usbguard. This
> doesn't offer ant additional security, but does add inconvenience.
i added the group wheel to the list of groups allowed to control usbguard.

> usbguard.service contains:
>  WantedBy=base.target
> but base.target doesn't exist on my system.
fixed to basic.target

> The usbguard-rules.conf manpage uses "usbguard-daemon.conf" in the NAME
> section (and other places) which is obviously a typo.
fixed

> Please submit the patch you added upstream when you get the chance.
done

> Finally, although you've fixed all the lintian warnings, please try and
> fix some of the info tags.
> 
> I: usbguard source: duplicate-short-description usbguard usbguard-dev
> I: usbguard source: debian-watch-file-is-missing
> I: usbguard: hardening-no-pie usr/bin/usbguard
> I: usbguard: hardening-no-bindnow usr/bin/usbguard
> I: usbguard: spelling-error-in-binary 
> usr/lib/x86_64-linux-gnu/libusbguard.so.0.0.0 Uknown Unknown
> I: usbguard: hardening-no-bindnow 
> usr/lib/x86_64-linux-gnu/libusbguard.so.0.0.0
> I: usbguard: hardening-no-pie usr/sbin/usbguard-daemon
> I: usbguard: hardening-no-bindnow usr/sbin/usbguard-daemon
> I: usbguard: spelling-error-in-manpage 
> usr/share/man/man5/usbguard-rules.conf.5.gz formated formatted
> I: usbguard: no-symbols-control-file 
> usr/lib/x86_64-linux-gnu/libusbguard.so.0.0.0
> I: usbguard: systemd-service-file-missing-documentation-key 
> lib/systemd/system/usbguard.service
all fixed ;)


> Hopefully I've covered everything!
thanks again, such thorough reviews really help to get an understanding
for the packaging process!

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825302: RFS: usbguard/0.4-2 [ITP]

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name: usbguard
  Version : 0.4-2
  Upstream Author : Daniel Kopeček 
* URL : https://github.com/dkopecek/usbguard
* License : GPL-2
  Section : utils

It builds those binary packages:

 usbguard   - Framework for implementing USB device authorization policies
 usbguard-dev - Framework for implementing USB device authorization policies

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.4-2.dsc

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/.

Changes since the last upload:

* fixing some shortcomings of the package regarding the lintian checks

Regards,
-- 
muri




signature.asc
Description: OpenPGP digital signature