Processed: Re: Bug#704047: unblock: kvpm/0.8.6-3
Processing control commands: tags -1 + moreinfo Bug #704047 [release.debian.org] unblock: kvpm/0.8.6-3 Added tag(s) moreinfo. -- 704047: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704047 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.b704047.136446603721249.transcr...@bugs.debian.org
Bug#704047: unblock: kvpm/0.8.6-3
Control: tags -1 + moreinfo On 27.03.2013 10:32, John Paul Adrian Glaubitz wrote: the upstream author of kvpm who also happens to be the Debian maintainer of the package recently found a critical bug when moving partitions [1]. I have reviewed his package and I'm attaching the Debdiff. I have to admit that I'm really not overly happy about the use of urgency=critical here; that implies that the package should immediately transition to testing with no time in unstable and there are _very_ few cases where it would be justified - as far as I can tell from the bug report, this is an issue that only affects an operation which I'd at least be very cautious about trying on a drive containing live data, and even the maintainer says only happens sometimes. In any case, this will either have to go via t-p-u or wait for a point release, as it's picked up a depedency on liblvm2app2.2 (= 2.02.98), which isn't satisfiable in wheezy. Regards, Adam -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/0eb3f2a817785d97fd0b9b0f55901...@mail.adsl.funky-badger.org
Bug#704047: unblock: kvpm/0.8.6-3
On 03/28/2013 11:20 AM, Adam D. Barratt wrote: I have to admit that I'm really not overly happy about the use of urgency=critical here; that implies that the package should immediately transition to testing with no time in unstable and there are _very_ few cases where it would be justified - as far as I can tell from the bug report, this is an issue that only affects an operation which I'd at least be very cautious about trying on a drive containing live data, and even the maintainer says only happens sometimes. Hmm, valid point. These changes and the urgency were made by the original maintainer of the package who also happens to be the upstream author, so I am putting him into CC of this mail. In any case, this will either have to go via t-p-u or wait for a point release, as it's picked up a depedency on liblvm2app2.2 (= 2.02.98), which isn't satisfiable in wheezy. That's too bad. But I would go ahead now, build 0.8.6-3+wheezy1 with urgency=high (or medium, low), if you agree. Cheers, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/51541c6f.7010...@physik.fu-berlin.de
Bug#704047: unblock: kvpm/0.8.6-3
Control: tags -1 +confirmed -moreinfo On 28.03.2013 10:33, John Paul Adrian Glaubitz wrote: On 03/28/2013 11:20 AM, Adam D. Barratt wrote: In any case, this will either have to go via t-p-u or wait for a point release, as it's picked up a depedency on liblvm2app2.2 (= 2.02.98), which isn't satisfiable in wheezy. That's too bad. But I would go ahead now, build 0.8.6-3+wheezy1 That would be higher than the version in unstable. :) Please use 0.8.6-2+deb7u1. with urgency=high (or medium, low), if you agree. From britney's point of view t-p-u uploads always transition asap (once they're approved, built, etc) so the urgency is largely only for users in this case; high would be fine. Please go ahead; thanks. Regards, Adam -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/fc8acbf5b39f27df42e9cdd2799e0...@mail.adsl.funky-badger.org
Processed: Re: Bug#704047: unblock: kvpm/0.8.6-3
Processing control commands: tags -1 +confirmed -moreinfo Bug #704047 [release.debian.org] unblock: kvpm/0.8.6-3 Added tag(s) confirmed. Bug #704047 [release.debian.org] unblock: kvpm/0.8.6-3 Removed tag(s) moreinfo. -- 704047: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704047 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.b704047.136446745829636.transcr...@bugs.debian.org
Bug#704047: unblock: kvpm/0.8.6-3
On 03/28/2013 11:44 AM, Adam D. Barratt wrote: Control: tags -1 +confirmed -moreinfo On 28.03.2013 10:33, John Paul Adrian Glaubitz wrote: On 03/28/2013 11:20 AM, Adam D. Barratt wrote: In any case, this will either have to go via t-p-u or wait for a point release, as it's picked up a depedency on liblvm2app2.2 (= 2.02.98), which isn't satisfiable in wheezy. That's too bad. But I would go ahead now, build 0.8.6-3+wheezy1 That would be higher than the version in unstable. :) Please use 0.8.6-2+deb7u1. True, the moment I sent the mail, I had a dejavu regarding this [1] :). with urgency=high (or medium, low), if you agree. From britney's point of view t-p-u uploads always transition asap (once they're approved, built, etc) so the urgency is largely only for users in this case; high would be fine. True, when you're already in testing, there's not point to transition from. Will upload the package now. Adrian [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=697957 -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/51541f99.3020...@physik.fu-berlin.de
Bug#704047: unblock: kvpm/0.8.6-3
Package: release.debian.org
Severity: normal
Tags: patch
User: release.debian@packages.debian.org
Usertags: unblock
Hi,
the upstream author of kvpm who also happens to be the Debian
maintainer of the package recently found a critical bug when
moving partitions [1]. I have reviewed his package and I'm
attaching the Debdiff.
Please unblock the package for Wheezy.
unblock kvpm/0.8.6-3
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703919
-- System Information:
Debian Release: 7.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.8-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru kvpm-0.8.6/debian/changelog kvpm-0.8.6/debian/changelog
--- kvpm-0.8.6/debian/changelog 2012-04-16 17:47:32.0 +0200
+++ kvpm-0.8.6/debian/changelog 2013-03-27 01:13:57.0 +0100
@@ -1,3 +1,11 @@
+kvpm (0.8.6-3) unstable; urgency=critical
+
+ [ Benjamin J. Scott ]
+ * Changed file kvpm/partchange.cpp to fix potential data corruption bug
+when moving a partition on a disk with mounted partitions (Closes: #703919).
+
+ -- Benjamin J. Scott bensc...@nwlink.com Sun, 24 Feb 2013 17:25:21 -0700
+
kvpm (0.8.6-2) unstable; urgency=low
[ Benjamin J. Scott ]
diff -Nru kvpm-0.8.6/debian/patches/partition-move-corruption.patch kvpm-0.8.6/debian/patches/partition-move-corruption.patch
--- kvpm-0.8.6/debian/patches/partition-move-corruption.patch 1970-01-01 01:00:00.0 +0100
+++ kvpm-0.8.6/debian/patches/partition-move-corruption.patch 2013-03-06 07:12:54.0 +0100
@@ -0,0 +1,20 @@
+This patch corrects a bug in which data is sometimes corrupted when moving a disk
+partition while the disk has other partitions mounted.
+--- a/kvpm/partchange.cpp
b/kvpm/partchange.cpp
+@@ -649,13 +649,8 @@
+ return false;
+ }
+ else {
+-if( !movefs(old_start, current_start, old_size) ){
+-return false;
+-}
+-else{
+-pedCommitAndWait(m_ped_disk);
+-return true;
+-}
++pedCommitAndWait(m_ped_disk);
++ return movefs(old_start, current_start, old_size);
+ }
+ }
+
diff -Nru kvpm-0.8.6/debian/patches/series kvpm-0.8.6/debian/patches/series
--- kvpm-0.8.6/debian/patches/series 2012-04-16 17:41:26.0 +0200
+++ kvpm-0.8.6/debian/patches/series 2013-03-06 08:16:15.0 +0100
@@ -1 +1,2 @@
+partition-move-corruption.patch
bug-667232.patch
