[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12359065 ] Andrew McIntyre commented on DERBY-587: --- David - it looks like you missed the derbydocs_exclusions.ant file in the javadoc fix patch. I've checked it in with revision 350292. It's unfortunate that it's now necessary to copy basically the entire source tree, almost 1700 files, to generate the javadoc. But, since javadoc itself doesn't have the ability to exclude a list of files, only packages, I don't know what else to do either. If anyone knows a way to get Ant to generate a list of files (like the find command) that we could then filter, let me know. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: bug587_javadoc.diff, jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
If anyone knows a way to get Ant to generate a list of files (like the find command) that we could then filter, let me know. I'm always up for puttering around with Ant scripts. Between fileset, patternset, and selector, there's a lot of power there. Maybe you could send me some more details about what you'd exactly like Ant to be able to do, and I could fiddle with it for a while? thanks, bryan
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
On Dec 1, 2005, at 11:08 AM, Bryan Pendleton wrote:
If anyone knows a way to get Ant to generate a list of files
(like the find command) that we could then filter, let me know.
I'm always up for puttering around with Ant scripts. Between
fileset, patternset, and selector, there's a lot of power
there. Maybe you could send me some more details about what you'd
exactly like Ant to be able to do, and I could fiddle with it for a
while?
Javadoc accepts an @{file} argument for a file which contains a list
of the files to be javadoc'd. Ant, unfortunately, doesn't include a
facility for generating such a list of files.
Good news, though. It appears that recent versions of Ant will now
generate the file list for you from fileset elements. It would be
interesting if you can get the derbydocs javadoc build going using
multiple nested filesets, excluding the classes listed in tools/
javadoc/derbydocs_excludes.ant, and avoid the need to copy the entire
source tree to a new directory before generating the javadoc. And if
you get that working, then it should be simple to get the
publishedapi target to work in a similar fashion.
Let me know if you're interested in working on that, otherwise I'll
take a look.
thanks,
andrew
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
It would be
interesting if you can get the derbydocs javadoc build going using
multiple nested filesets, excluding the classes listed in tools/
javadoc/derbydocs_excludes.ant, and avoid the need to copy the entire
source tree to a new directory before generating the javadoc.
I'm possibly looking at this too simplistically, but I just tried
this simple change (attached) and it seemed to generate the correct javadoc
for me. In addition to tweaking the build.xml to pass the java classes
as nested filesets, rather than by making a source tree copy, I also
had to add a few more patterns to derbydocs_excludes.ant, to tell javadoc
to keep its hands off of build.xml files, properties files, etc.
Of course, I don't have a lot of experience generating Derby javadoc
so please try it and tell me whether you think it actually *does*
generate the correct javadoc.
thanks,
bryan
Index: tools/javadoc/derbydocs_exclusions.ant
===
--- tools/javadoc/derbydocs_exclusions.ant (revision 351528)
+++ tools/javadoc/derbydocs_exclusions.ant (working copy)
@@ -21,3 +21,8 @@
org/apache/derby/client/*40.java
org/apache/derby/client/am/*40.java
org/apache/derby/client/am/RowId.java
+**/build.xml
+**/*.properties
+**/*.jj
+**/*.tmpl
+**/package.html
Index: build.xml
===
--- build.xml (revision 351528)
+++ build.xml (working copy)
@@ -603,36 +603,12 @@
delete dir=${out.javadoc.dir}/engine/
mkdir dir=${out.javadoc.dir}/engine/
-delete dir=${out.javadoc.dir}/sourcedir/
-mkdir dir=${out.javadoc.dir}/sourcedir/
-
-!-- engine files --
-copy todir=${out.javadoc.dir}/sourcedir
- fileset dir=${derby.engine.src.dir}
- excludesfile=${javadoctools.dir}/derbydocs_exclusions.ant/
-/copy
-!-- client files --
-copy todir=${out.javadoc.dir}/sourcedir
- fileset dir=${derby.client.src.dir}
- excludesfile=${javadoctools.dir}/derbydocs_exclusions.ant/
-/copy
-!-- drda files --
-copy todir=${out.javadoc.dir}/sourcedir
- fileset dir=${derby.drda.src.dir}
- excludesfile=${javadoctools.dir}/derbydocs_exclusions.ant/
-/copy
-!-- tools files --
-copy todir=${out.javadoc.dir}/sourcedir
- fileset dir=${derby.tools.src.dir}
- excludesfile=${javadoctools.dir}/derbydocs_exclusions.ant/
-/copy
-
javadoc
additionalparam=-J-mx320M
packagenames=org.*
access=private
breakiterator=yes
-sourcepath=${out.javadoc.dir}/sourcedir
+useexternalfile=yes
classpath=${basedir}/classes;${java14compile.classpath};${jars.extras};${osgi}
destdir=${out.javadoc.dir}/engine
windowtitle=Apache Derby V${major}.${minor} Engine Documentation
@@ -650,10 +626,17 @@
path=${basedir}/classes/
taglet name=org.apache.derbyBuild.javadoc.EndFormatTaglet
path=${basedir}/classes/
+ fileset dir=${derby.engine.src.dir}
+ excludesfile=${javadoctools.dir}/derbydocs_exclusions.ant/
+ fileset dir=${derby.client.src.dir}
+ excludesfile=${javadoctools.dir}/derbydocs_exclusions.ant/
+ fileset dir=${derby.drda.src.dir}
+ excludesfile=${javadoctools.dir}/derbydocs_exclusions.ant/
+ fileset dir=${derby.tools.src.dir}
+ excludesfile=${javadoctools.dir}/derbydocs_exclusions.ant/
+
/javadoc
-delete dir=${out.javadoc.dir}/sourcedir/
-
/target
target name=toolsdocs
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12358273 ] David Van Couvering commented on DERBY-587: --- Committed fix for javadoc $ svn commit Sendingbuild.xml Transmitting file data . Committed revision 348203. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: bug587_javadoc.diff, jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12357948 ] Jean T. Anderson commented on DERBY-587: Narayanan's icla now shows up as being recorded -- so go ahead and commit, Satheesh. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Narayanan's icla now shows up as being recorded Yay! So does mine! http://people.apache.org/~jim/committers.html#unlistedclas bryan
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12357950 ] Satheesh Bandaram commented on DERBY-587: - I have submitted this patch. Thanks everyone! Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Hi, Thanx for the help with the icla Jean. Thank you Satheesh and Rick for guiding me through the various details of the patch. Thanx to everyone for the reviews and the comments. Narayanan Satheesh Bandaram (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12357950 ] Satheesh Bandaram commented on DERBY-587: - I have submitted this patch. Thanks everyone! Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Hi Jean, Narayanan has faxed, mailed, and emailed his ICLA to Apache several times. He has emailed [EMAIL PROTECTED] for confirmation that his ICLA was received. But his posts have not been acknowledged. Is there a back-channel, perhaps only available to committers or PMC members, through which we could get Apache's attention? For the record, Narayanan's java files now contain copyright notices ceding ownership to Apache. Can that be good enough to commit this work while we wait for Apache's response? Thanks, -Rick Satheesh Bandaram (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12357651 ] Satheesh Bandaram commented on DERBY-587: - Thanks, Narayanan, for the follow up. I think only the ICLA is the pending issue now. Jean had mentioned last time that either your name show on the list or get some kind of acknowledgement that Apache received your fax. I will commit your changes just after that. Jean, let us know if there is any other way. I hate to be holding up good and important work, but don't know what else I could do. Thanks to Rick for the reviews and for running the tests. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Rick Hillegas wrote: For the record, Narayanan's java files now contain copyright notices ceding ownership to Apache. That's incorrect. The copyright is not assigned to the ASF, and there is no requirement for it to be. The contributor maintains their copyright. Dan.
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Oh dear, I'm befuddled. According to http://www.apache.org/dev/apply-license.html (Applying the License to New Software), a new java source should begin with a line granting the copyright to ASF. The exact verbiage is: Source files contributed to or developed as part of an ASF project should begin with a copyright notice like Copyright 2004 The Apache Software Foundation. or Copyright 1999-2004 The Apache Software Foundation. or Copyright 2002,2004 The Apache Software Foundation. Just above that pile of words is a link to the boilerplate copyright notice. Curiously, that boilerplate has a generic copyright line which doesn't specify who owns the copyright although it publishes the code under the Apache license. I'm getting mixed signals. -Rick Daniel John Debrunner wrote: Rick Hillegas wrote: For the record, Narayanan's java files now contain copyright notices ceding ownership to Apache. That's incorrect. The copyright is not assigned to the ASF, and there is no requirement for it to be. The contributor maintains their copyright. Dan.
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Rick Hillegas wrote: Oh dear, I'm befuddled. According to http://www.apache.org/dev/apply-license.html (Applying the License to New Software), a new java source should begin with a line granting the copyright to ASF. ASF owns copyright on the collected work for a project, but the contributor owns the copyright on their contribution. If you look at the Dertby files the copyright statement correctly reflects this reality. Copyright 2005 The Apache Software Foundation or its licensors, as applicable. Note the or its licensors. This format was agreed to by the ASF. There is a long discussion on the derby-dev list around Sept/Oct 2004 about this. The page you reference I guess has not been updated, the issue with its wording/format is that is does not correctly represent legal reality. Now there are ASF folks that would like the ASF to hold copyright on all the code it distributes, but that is not the case at the moment. Dan.
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Rick Hillegas wrote: Oh dear, I'm befuddled. According to http://www.apache.org/dev/apply-license.html (Applying the License to New Software), a new java source should begin with a line granting the copyright to ASF. The exact verbiage is: slides 18 and 20 of Cliff Schmidt's ApacheCon presentation Licensing: What Every Apache Contributor Should Know might help clarify things a little. There's a link to it from http://db.apache.org/derby/license.html Come to ApacheCon US in December. We can all gang up on Cliff :-) and maybe help get the info in http://www.apache.org/dev/apply-license.html clarified. -jean
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12357595 ] Rick Hillegas commented on DERBY-587: - I have successfully built this patch under jdk1.4 and jdk1.6. For me derbyall runs cleanly under jdk1.4. Under jdk1.6 the new jdbc4 tests run cleanly. Satheesh, when you have a moment, could you verify that this submission satisifies the copyright and formatting issues you raised? If so, and there are no new issues, then I think this is ready to be committed. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12357651 ] Satheesh Bandaram commented on DERBY-587: - Thanks, Narayanan, for the follow up. I think only the ICLA is the pending issue now. Jean had mentioned last time that either your name show on the list or get some kind of acknowledgement that Apache received your fax. I will commit your changes just after that. Jean, let us know if there is any other way. I hate to be holding up good and important work, but don't know what else I could do. Thanks to Rick for the reviews and for running the tests. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Daniel John Debrunner wrote: Craig Russell (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356473 ] Craig Russell commented on DERBY-587: - 4. In response to Dan's comments immediately above, I'd think that the Apache board might want to discuss why the JIRA has a check box for contributions. If it's really irrelevant, it's certainly a distraction. Not sure it is irrelevant, at that point (in Jira) it's a choice between I am contibuting this attachment to the ASF vs. I'm not. Since there is always the option of this is useful information but it's not a contribution, there has to be the alternative of it *is* a contribution. Thus how else would you label that, except this is a contribution under the ASL? Apache projects typically allow small contributions, such as a small patch, without an icla. That checkbox in Jira is a visible reminder to the contributor that the patch must be contributed under the ASL. However, I think we'd all agree that attaching a file containing debug output doesn't need such a grant. :-) A broader, less visible policy holds for posts to apache mail lists; see the paragraph that starts with 'Contribution shall mean any work of authorship,' at http://www.apache.org/licenses/LICENSE-2.0.html . That covers posts to mail lists, source code control systems, and issue tracking systems such as Jira. But I have seen discussion on some mail lists about how that policy should be made visible for the mail lists, like it is for Jira. --I'm looking for some of the most relevant posts and will followup. Visibility is good -- reduces misunderstanding. -jean
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356415 ] Rick Hillegas commented on DERBY-587: - Thanks for pointing out these issues, Satheesh. I didn't turn up on the published list until a couple months after I submitted my ICLA. I'm hoping that it will be sufficient for Narayanan to say that he has faxed in his ICLA. That is, I hope we don't have to wait another 2 months to contribute this patch. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Does Derby or Apache have a set of coding guidelines? Where would a new contributor find rules about copyright notices and @author tags? It would be helpful if we had a link to the rules in the 'Contribute Code or Documentation' section of the Community tab. Thanks, -Rick Satheesh Bandaram (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356249 ] Satheesh Bandaram commented on DERBY-587: - I noticed Narayanan doesn't have ICLA signed with Apache. Any reasonable size contribution would require the contributor to have an ICLA signed and be on file. List of ICLAs can be found at: http://people.apache.org/~jim/committers.html. The process of starting an ICLA submission: http://www.apache.org/licenses/#clas I think it is wise to hold off on checking this in, pending ICLA submission. I was so close... :( Several new JAVA files don't have the ASF copyright notices at the top ... Isn't this required for all new JAVA files? I also noticed an @author tag in the patch. While I am not sure what guidelines Apache or Derby follows, it may be best to remove @author tags. Geronimo has a policy against this tag: http://wiki.apache.org/geronimo/CodingStandards One last minor one... The copyright notice should have 2005 for the file jdk16.java Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff
Coding Guidelines: was [Fwd: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby]
Re-posting with a more germane subject line. Cheers-Rick ---BeginMessage--- [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356415 ] Rick Hillegas commented on DERBY-587: - Thanks for pointing out these issues, Satheesh. I didn't turn up on the published list until a couple months after I submitted my ICLA. I'm hoping that it will be sufficient for Narayanan to say that he has faxed in his ICLA. That is, I hope we don't have to wait another 2 months to contribute this patch. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---End Message---
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356422 ] Rick Hillegas commented on DERBY-587: - Hi Satheesh: Narayanan has faxed in his ICLA. He's on holiday (Diwali) right now. Would it be ok to clean up the copyright and tag issues later? If so, would you be kind enough to check in this patch today? Thanks! Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356434 ] Satheesh Bandaram commented on DERBY-587: - As Dan (PMC member) said, we have to wait for the copyright notices for the files... Also, it would be good if Narayanan himself can post whether or not he FAXed his ICLA. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Satheesh Bandaram (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356434 ] Satheesh Bandaram commented on DERBY-587: - As Dan (PMC member) said, we have to wait for the copyright notices for the files... Also, it would be good if Narayanan himself can post whether or not he FAXed his ICLA. I suggest that Narayanan re-fax to the number at http://www.apache.org/foundation/contact.html , then send followup email to [EMAIL PROTECTED] asking whom to contact to verify it was actually received, mentioning that the previous attempt to fax seems to have been lost. (Perhaps also mail hard copy.) If Narayanan can report verification that it was received, I personally would have no problem with Satheesh committing the patch, provided any remaining issues such as the copyright notices are addressed. I have had very little success with faxes. I faxed my speaker agreement for ApacheCon three times last week, and *one* of those made it through. So successful transmission from your end doesn't necessarily mean it was successful. -jean
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356470 ] V.Narayanan commented on DERBY-587: --- Hi, Thanx for pointing out the issues satheesh. Also thanx for the follow up email address jean. I faxed the agreement to apache yesterday. Also I will follow this up using the email address given by jean. Sorry for my late response. Narayanan Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356471 ] Craig Russell commented on DERBY-587: - I recognize that this is an internal project issue, but: Doesn't the grant Apache license check box on the patch upload mean anything? I always assumed that it allowed someone without an ICLA on file to contribute code. The patches uploaded for this bug have the grant Apache license checked...Of course, the copyright notices are required in the code for new files. Craig Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356472 ] Daniel John Debrunner commented on DERBY-587: - I think this is an Apache wide issue, or desire: http://www.apache.org/licenses/#clas The ASF desires that all contributors of ideas, code, or documentation to the Apache projects complete, sign, and submit (via snailmail or fax) a Individual Contributor License Agreement (CLA) Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[
http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356473 ]
Craig Russell commented on DERBY-587:
-
I have just a few comments.
1. The code does not appear to be consistent with regard to spaces, tabs,
indents, and which line the { appears on. Are there coding standards to which
we try to hold contributions? Other projects recognize that some files in the
same project use different coding styles (standards?) but try to maintain
standards for new files. The rule is that patches to existing files use the
conventions already used, but new files have a standard approach. Are there any
such standards for Derby?
2. The copyright notices definitely need to be there for this contribution.
3. I agree that for a contribution of this magnitude, a signed ICLA should be a
requirement.
4. In response to Dan's comments immediately above, I'd think that the Apache
board might want to discuss why the JIRA has a check box for contributions. If
it's really irrelevant, it's certainly a distraction.
Providing JDBC 4.0 support for derby
Key: DERBY-587
URL: http://issues.apache.org/jira/browse/DERBY-587
Project: Derby
Type: New Feature
Components: JDBC
Versions: 10.2.0.0
Reporter: V.Narayanan
Assignee: V.Narayanan
Priority: Minor
Fix For: 10.2.0.0
Attachments: jdbc4.0.sxw, jdbc4.diff
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Craig Russell (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356473 ] Craig Russell commented on DERBY-587: - 4. In response to Dan's comments immediately above, I'd think that the Apache board might want to discuss why the JIRA has a check box for contributions. If it's really irrelevant, it's certainly a distraction. Not sure it is irrelevant, at that point (in Jira) it's a choice between I am contibuting this attachment to the ASF vs. I'm not. Since there is always the option of this is useful information but it's not a contribution, there has to be the alternative of it *is* a contribution. Thus how else would you label that, except this is a contribution under the ASL? Dan.
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356249 ] Satheesh Bandaram commented on DERBY-587: - I noticed Narayanan doesn't have ICLA signed with Apache. Any reasonable size contribution would require the contributor to have an ICLA signed and be on file. List of ICLAs can be found at: http://people.apache.org/~jim/committers.html. The process of starting an ICLA submission: http://www.apache.org/licenses/#clas I think it is wise to hold off on checking this in, pending ICLA submission. I was so close... :( Several new JAVA files don't have the ASF copyright notices at the top ... Isn't this required for all new JAVA files? I also noticed an @author tag in the patch. While I am not sure what guidelines Apache or Derby follows, it may be best to remove @author tags. Geronimo has a policy against this tag: http://wiki.apache.org/geronimo/CodingStandards One last minor one... The copyright notice should have 2005 for the file jdk16.java Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356162 ] Rick Hillegas commented on DERBY-587: - The patch looks good. Derby builds cleanly. If you put a pointer to jdk16 into your ant.properties, Derby again builds cleanly, including the new jdbc4 stubbed out implementation. Derbyall runs cleanly on my machine under jdk14. Under jdk16, the new jdbc4 tests run cleanly. I recommend that a committer commit this patch. Note that the committer will need to svn_add the following five empty master files: svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/StartTestConnection.out svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/TestCallableStatementMethods.out svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/TestConnectionMethods.out svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/TestPreparedStatementMethods.out svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/TestResultSetMethods.out Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
I can commit this... Let me know if anyone else have any other comments. Satheesh Rick Hillegas (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12356162 ] Rick Hillegas commented on DERBY-587: - The patch looks good. Derby builds cleanly. If you put a pointer to jdk16 into your ant.properties, Derby again builds cleanly, including the new jdbc4 stubbed out implementation. Derbyall runs cleanly on my machine under jdk14. Under jdk16, the new jdbc4 tests run cleanly. I recommend that a committer commit this patch. Note that the committer will need to svn_add the following five empty master files: svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/StartTestConnection.out svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/TestCallableStatementMethods.out svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/TestConnectionMethods.out svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/TestPreparedStatementMethods.out svn_add trunk/java/testing/org/apache/derbyTesting/functionTests/master/TestResultSetMethods.out Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc4.diff
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Not knowing the fully story and all the implications, choice three sounds far and above like the better choice. david Rick Hillegas (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12331629 ] Rick Hillegas commented on DERBY-587: - Dan raises an uncomfortable issue which I hope we don't have to address for this submission but which we do have to address for the 10.2 release. EmbeddedDataSource is just one instance of the problem. But it surfaces across the org.apache.derby.jdbc package. The problem is that EmbeddedDataSource implements an interface (javax.sql.DataSource) which has changed between jdk1.4 and jdk1.6 in an irreconcilable way. In jdk1.6, DataSource contains a method with generics in its signature. If we ship an EmbeddedDataSource which implements this method, then I think it won't play well in a 1.4 vm. If, however, we ship an EmbeddedDataSource which does NOT implement this method, then on a 1.6 vm, EmbeddedDataSource will fail to satisfy the DataSource contract. Here are some ways we could solve this problem: 1) Ship both a 1.4 and a 1.6 version of EmbeddedDataSource and sort the problem out at run time using some kind of classloader jiggery pokery. I'm waving my hands because I don't understand what the jiggery pokery would be. 2) Release two different distributions of 10.2, one for 1.5 and earlier vms and another for 1.6 vms. 3) Deprecate EmbeddedDataSource as a class in 10.2. Instead, turn it into an interface and add a factory to org.apache.derby.jdbc which is smart enough to contruct a vm-specific class at runtime. This solution could be applied to the other classes in that package which have the same problem. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc40.diff, jdbc40.stat begin:vcard fn:David W Van Couvering n:Van Couvering;David W org:Sun Microsystems, Inc.;Database Technology Group email;internet:[EMAIL PROTECTED] title:Senior Staff Software Engineer tel;work:510-550-6819 tel;cell:510-684-7281 x-mozilla-html:TRUE version:2.1 end:vcard
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12331629 ] Rick Hillegas commented on DERBY-587: - Dan raises an uncomfortable issue which I hope we don't have to address for this submission but which we do have to address for the 10.2 release. EmbeddedDataSource is just one instance of the problem. But it surfaces across the org.apache.derby.jdbc package. The problem is that EmbeddedDataSource implements an interface (javax.sql.DataSource) which has changed between jdk1.4 and jdk1.6 in an irreconcilable way. In jdk1.6, DataSource contains a method with generics in its signature. If we ship an EmbeddedDataSource which implements this method, then I think it won't play well in a 1.4 vm. If, however, we ship an EmbeddedDataSource which does NOT implement this method, then on a 1.6 vm, EmbeddedDataSource will fail to satisfy the DataSource contract. Here are some ways we could solve this problem: 1) Ship both a 1.4 and a 1.6 version of EmbeddedDataSource and sort the problem out at run time using some kind of classloader jiggery pokery. I'm waving my hands because I don't understand what the jiggery pokery would be. 2) Release two different distributions of 10.2, one for 1.5 and earlier vms and another for 1.6 vms. 3) Deprecate EmbeddedDataSource as a class in 10.2. Instead, turn it into an interface and add a factory to org.apache.derby.jdbc which is smart enough to contruct a vm-specific class at runtime. This solution could be applied to the other classes in that package which have the same problem. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc40.diff, jdbc40.stat -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12331271 ] Rick Hillegas commented on DERBY-587: - This patch looks good to me. I recommend that a committer check it in. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc40.diff, jdbc40.stat -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12331272 ] Oyvind Bakksjo commented on DERBY-587: -- OK, I'll commit it. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc40.diff, jdbc40.stat -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Has somebody other than Narayanan pulled it, built it, and run the tests? David Oyvind Bakksjo (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12331272 ] Oyvind Bakksjo commented on DERBY-587: -- OK, I'll commit it. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc40.diff, jdbc40.stat begin:vcard fn:David W Van Couvering n:Van Couvering;David W org:Sun Microsystems, Inc.;Database Technology Group email;internet:[EMAIL PROTECTED] title:Senior Staff Software Engineer tel;work:510-550-6819 tel;cell:510-684-7281 x-mozilla-html:TRUE version:2.1 end:vcard
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12331279 ] Daniel John Debrunner commented on DERBY-587: - The document says that EmbeddedDataSource40 extends EmbeddedDataSource30, but there is no such class in Derby. In fact this EmbeddedDataSource40 looks like it has to become part of the public api, which means a shift in Derby from a single class for JDBC 2.0 and JDBC 3.0, to applications having to select a specific DataSource for JDBC 4.0. Not sure this is a problem for this check in, but it might be something that needs to be resolved before a Derby release is made that supports JDBC 4.0. E.g. if the DataSource doesn't change in JDBC 5.0 then do applications still need to load EmbeddedDataSource40, possibly leading to confusion? One minor issue with the patch, the new constant in JVMInfo for JDK 1.6 has the comment aka J2SE 5.0 which is the same as JDK 1.5. Is that true? Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc40.diff, jdbc40.stat -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
David W. Van Couvering wrote: Has somebody other than Narayanan pulled it, built it, and run the tests? David I always check that stuff builds before committing. As for running the tests, we usually consider it sufficient if the contributor has run tests without failure and a reviewer approves the patch, don't we? -- Oyvind Bakksjo Sun Microsystems, Database Technology Group Haakon VII gt. 7b, N-7485 Trondheim, Norway Tel: x43419 / +47 73842119, Fax: +47 73842101
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
Øyvind Bakksjø wrote: David W. Van Couvering wrote: Has somebody other than Narayanan pulled it, built it, and run the tests? David I always check that stuff builds before committing. As for running the tests, we usually consider it sufficient if the contributor has run tests without failure and a reviewer approves the patch, don't we? It's a judgement call by the committer. If it's a small patch from a regular contributor who has a good history of providing good patches then most likely the tests need not be run again. If it's a big patch, risky or from a new contributor then it may be worth running the tests. The patch can always be reverted (commit-then-review), you as a committer have the decide what is risk of causing a disruption by having tests fail. Dan.
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
I'll try this. Cheers, -Rick David W. Van Couvering wrote: Has somebody other than Narayanan pulled it, built it, and run the tests? David Oyvind Bakksjo (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12331272 ] Oyvind Bakksjo commented on DERBY-587: -- OK, I'll commit it. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc40.diff, jdbc40.stat
Re: [jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
I thought at some point we agreed that at least one independent party should run the tests; this happened after a patch failed to pass tests even though it built -- I think the patch didn't contain a new master file that had been added. It would be nice to add guidelines for checking in a patch to our Wiki site... David Øyvind Bakksjø wrote: David W. Van Couvering wrote: Has somebody other than Narayanan pulled it, built it, and run the tests? David I always check that stuff builds before committing. As for running the tests, we usually consider it sufficient if the contributor has run tests without failure and a reviewer approves the patch, don't we? begin:vcard fn:David W Van Couvering n:Van Couvering;David W org:Sun Microsystems, Inc.;Database Technology Group email;internet:[EMAIL PROTECTED] title:Senior Staff Software Engineer tel;work:510-550-6819 tel;cell:510-684-7281 x-mozilla-html:TRUE version:2.1 end:vcard
[jira] Commented: (DERBY-587) Providing JDBC 4.0 support for derby
[ http://issues.apache.org/jira/browse/DERBY-587?page=comments#action_12331339 ] Rick Hillegas commented on DERBY-587: - I retract my hasty judgment. I don't think this submission is ready to be committed. The good news is that the trunk compiles without jdk1.6 and derbyall runs cleanly--I think. I saw a diff in NSinSameJVM but I think I may have seen this intermittently on my machine before. However, compilation fails when I define jdk16 in my ant.properties. The compilation will not run under cygwin. I almost have a fix for this but I'm not quite there yet. So let's hold off committing this. Providing JDBC 4.0 support for derby Key: DERBY-587 URL: http://issues.apache.org/jira/browse/DERBY-587 Project: Derby Type: New Feature Components: JDBC Versions: 10.2.0.0 Reporter: V.Narayanan Assignee: V.Narayanan Priority: Minor Fix For: 10.2.0.0 Attachments: jdbc4.0.sxw, jdbc40.diff, jdbc40.stat -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
