Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-15 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated July 16, 2019, 12:12 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Reverted Hive model file to not include dynAttributes.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
  intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 4ff4206471bb8b2b4997c00dca3b4433626ae392 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
 bf7e182429d00ca668cbbd41277291ecc5d457e0 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 edb45687712c7bb8941bc894e73423a463739a42 


Diff: https://reviews.apache.org/r/70913/diff/14/

Changes: https://reviews.apache.org/r/70913/diff/13-14/


Testing
---

Added unit test


File Attachments (updated)


Hive Model with dynAttributes
  
https://reviews.apache.org/media/uploaded/files/2019/07/16/1f7bed33-0509-4aee-acbf-7ed1b0616c84__1030-hive_model.json


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-15 Thread Aadarsh Jajodia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216632
---


Ship it!




Thanks for uploading the model file. We can have that as a reference.

- Aadarsh Jajodia


On July 16, 2019, 12:12 a.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 16, 2019, 12:12 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
>   intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  4ff4206471bb8b2b4997c00dca3b4433626ae392 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
>  bf7e182429d00ca668cbbd41277291ecc5d457e0 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
>  edb45687712c7bb8941bc894e73423a463739a42 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/14/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> File Attachments
> 
> 
> Hive Model with dynAttributes
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/16/1f7bed33-0509-4aee-acbf-7ed1b0616c84__1030-hive_model.json
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-15 Thread Aadarsh Jajodia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216630
---


Ship it!




Ship It!

- Aadarsh Jajodia


On July 15, 2019, 11:09 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 15, 2019, 11:09 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
>   intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  4ff4206471bb8b2b4997c00dca3b4433626ae392 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
>  bf7e182429d00ca668cbbd41277291ecc5d457e0 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
>  edb45687712c7bb8941bc894e73423a463739a42 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/13/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-15 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216629
---


Ship it!




Ship It!

- Sarath Subramanian


On July 15, 2019, 4:09 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 15, 2019, 4:09 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
>   intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  4ff4206471bb8b2b4997c00dca3b4433626ae392 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
>  bf7e182429d00ca668cbbd41277291ecc5d457e0 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
>  edb45687712c7bb8941bc894e73423a463739a42 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/13/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-15 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated July 15, 2019, 11:09 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Forgot to change the variable at 1 place, fixed now.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
  intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 4ff4206471bb8b2b4997c00dca3b4433626ae392 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
 bf7e182429d00ca668cbbd41277291ecc5d457e0 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 edb45687712c7bb8941bc894e73423a463739a42 


Diff: https://reviews.apache.org/r/70913/diff/13/

Changes: https://reviews.apache.org/r/70913/diff/12-13/


Testing
---

Added unit test


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-15 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated July 15, 2019, 11:06 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Renamed splitPath variable in DependentToken.java to objectPath


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
  intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 4ff4206471bb8b2b4997c00dca3b4433626ae392 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
 bf7e182429d00ca668cbbd41277291ecc5d457e0 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 edb45687712c7bb8941bc894e73423a463739a42 


Diff: https://reviews.apache.org/r/70913/diff/12/

Changes: https://reviews.apache.org/r/70913/diff/11-12/


Testing
---

Added unit test


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-15 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216618
---


Ship it!




Ship It!

- Madhan Neethiraj


On July 15, 2019, 2:20 a.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 15, 2019, 2:20 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
>   intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  4ff4206471bb8b2b4997c00dca3b4433626ae392 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
>  bf7e182429d00ca668cbbd41277291ecc5d457e0 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
>  edb45687712c7bb8941bc894e73423a463739a42 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/11/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-14 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated July 15, 2019, 2:20 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

I fixed up some outdated tests that involved the hive_db only using the dbname 
as the qualifiedName. Also when the attribute required for the evaluation of a 
dynAttribute is not present, the attribute is not generated and it does not get 
set for that entity.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
  intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 4ff4206471bb8b2b4997c00dca3b4433626ae392 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java
 bf7e182429d00ca668cbbd41277291ecc5d457e0 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java
 edb45687712c7bb8941bc894e73423a463739a42 


Diff: https://reviews.apache.org/r/70913/diff/11/

Changes: https://reviews.apache.org/r/70913/diff/10-11/


Testing
---

Added unit test


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-14 Thread Madhan Neethiraj 


> On July 12, 2019, 3:06 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/AttributeToken.java
> > Lines 35 (patched)
> > 
> >
> > UNKNOWN_ATTRIBUTE doesn't seem right error here. The attribute value is 
> > not prsent in the entity. I suggest to return null from here and have the 
> > caller deal with the desired action.
> 
> Merryle Wang wrote:
> How should the caller deal with the null case. Should it just throw an 
> error just like here?

Few options:
 1. set token value to empty string or 'null'
 2. abort dynamic evaluation for this attribute, with a warn log, and set 
attribute value to null

I suggest we go with option #2.


> On July 12, 2019, 3:06 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/DependentToken.java
> > Lines 37 (patched)
> > 
> >
> > Is the last entry the attrName? For example, consider  token 
> > '{table.db.name}' for hive_column.qualifiedName. 'table' would be the 
> > attribute name, which is the first entry. Please review.
> 
> Merryle Wang wrote:
> Well the structure I'm using is that, the last entry is the actual 
> attribute--not for the hive_column--but for the db. While table is also an 
> attributename, it's part of the sequence of relationship attributes to get to 
> the final entity where we read its attribute.

ok. Given the context is 'hive_column' entity, I assumed attrName will be a 
relationship-attribute in 'hive_column' type - which will be used to find 
entity related via this attribute. Since that functionalty will be added only 
in a subsequent patch, it is probably not important in this patch.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216543
---


On July 9, 2019, 11:55 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 9, 2019, 11:55 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
>   intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  4ff4206471bb8b2b4997c00dca3b4433626ae392 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/10/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-11 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216543
---




intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 754 (patched)


Consider simplifying with the following alternate:

StringBuilder token= new StringBuilder();
bool  isInAttrName = false;

for (int i = 0; i < template.length(); i++) {
  char c = template.charAt(i);

  switch (c) {
case DYN_ATTRIBUTE_OPEN_DELIM: {
  isInAttrName = true;

  if (token.length() > 0) {
ret.add(new ConstantToken(token.toString());

token.setLength(0);
  }
}
break;

case DYN_ATTRIBUTE_CLOSE_DELIM:
  if (isInAttrName) {
isInAttrName = false;

if (token.length() > 0) {
String attrName = token.toString();

if (attrName.indexOf(DYN_ATTRIBUTE_NAME_SEPARATOR) != -1) {
  ret.add(new DependentToken(token.toString()));
} else {
  ret.add(new AttributeToken(token.toString());
}

token.setLength(0);
}
  } else {
token.append(c);
  }
break;

default:
  token.append(c);
break;
  }
}



intg/src/main/java/org/apache/atlas/type/AttributeToken.java
Lines 25 (patched)


Consider marking as 'final' as this member is not updated after 
initialization.

Same for members of ConstantToken and DependentToken.



intg/src/main/java/org/apache/atlas/type/AttributeToken.java
Lines 35 (patched)


UNKNOWN_ATTRIBUTE doesn't seem right error here. The attribute value is not 
prsent in the entity. I suggest to return null from here and have the caller 
deal with the desired action.



intg/src/main/java/org/apache/atlas/type/DependentToken.java
Lines 37 (patched)


Is the last entry the attrName? For example, consider  token 
'{table.db.name}' for hive_column.qualifiedName. 'table' would be the attribute 
name, which is the first entry. Please review.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
Lines 132 (patched)


- dynamicAttributeGenerator() => processDynanicAttributes()
- move 'private' method to end of the class, after all public methods.


- Madhan Neethiraj


On July 9, 2019, 11:55 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 9, 2019, 11:55 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
>   intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  4ff4206471bb8b2b4997c00dca3b4433626ae392 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/10/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-09 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated July 9, 2019, 11:55 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

The code now takes the hook generated dynAttribute if there isn't a template 
for a given Entity in the models file.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
  intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 4ff4206471bb8b2b4997c00dca3b4433626ae392 


Diff: https://reviews.apache.org/r/70913/diff/10/

Changes: https://reviews.apache.org/r/70913/diff/9-10/


Testing
---

Added unit test


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-08 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated July 9, 2019, 12:13 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Moved the tokens classes into the type directory and edited their functions as 
well. Added functionality to generate dynAttributes for entities whose 
templates only depend on themselves. Only Hive_db has a dynAttribute as of now.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
0fe47bdcbe84c06545c517fec3177ef7e6487a6c 
  intg/src/main/java/org/apache/atlas/type/AttributeToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/ConstantToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/DependentToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/TemplateToken.java PRE-CREATION 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 4ff4206471bb8b2b4997c00dca3b4433626ae392 


Diff: https://reviews.apache.org/r/70913/diff/9/

Changes: https://reviews.apache.org/r/70913/diff/8-9/


Testing
---

Added unit test


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-02 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated July 3, 2019, 12:13 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Added 1 interface and 3 subclasses to keep track of the type of each part of 
the template. The classes can either be constant, an attribute, or one that's 
dependent on it's relationship attributes. I changed also the logic in 
AtlasEntityType because saving the split parts of the template simplifies the 
code in AtlasEntityType.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/model/AttributeToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/ConstantToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/DependentToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/TemplateToken.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
254eee4c9d18ab87a8862ce479fc2274227c7c29 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 


Diff: https://reviews.apache.org/r/70913/diff/8/

Changes: https://reviews.apache.org/r/70913/diff/7-8/


Testing
---

Added unit test


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-02 Thread Ashutosh Mestry via Review Board 


> On July 2, 2019, 3:50 p.m., Ashutosh Mestry wrote:
> > This an edge case: When temporary tables are created, their qualifiedName 
> > gets suffixed with GUID, how will this scheme handle that?
> 
> Aadarsh Jajodia wrote:
> Hi Ashutosh, Thats a good point you mentioned. Right now we don't have a 
> way in the templates to refer to a system attribute(we might need this as you 
> mentioned for a temp table). We can take that up later.

See this: AtlasHiveHookContext

public String getQualifiedName(Table table) {
String tableName = table.getTableName();

if (table.isTemporary()) {
if (SessionState.get() != null && SessionState.get().getSessionId() 
!= null) {
tableName = tableName + TEMP_TABLE_PREFIX + 
SessionState.get().getSessionId();
} else {
tableName = tableName + TEMP_TABLE_PREFIX + 
RandomStringUtils.random(10);
}
}

return (table.getDbName() + QNAME_SEP_ENTITY_NAME + tableName + 
QNAME_SEP_CLUSTER_NAME).toLowerCase() + getClusterName();
}


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216308
---


On July 1, 2019, 6:10 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 1, 2019, 6:10 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/7/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-02 Thread Aadarsh Jajodia 


> On July 2, 2019, 3:50 p.m., Ashutosh Mestry wrote:
> > This an edge case: When temporary tables are created, their qualifiedName 
> > gets suffixed with GUID, how will this scheme handle that?

Hi Ashutosh, Thats a good point you mentioned. Right now we don't have a way in 
the templates to refer to a system attribute(we might need this as you 
mentioned for a temp table). We can take that up later.


- Aadarsh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216308
---


On July 1, 2019, 6:10 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 1, 2019, 6:10 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/7/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-02 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216308
---



This an edge case: When temporary tables are created, their qualifiedName gets 
suffixed with GUID, how will this scheme handle that?

- Ashutosh Mestry


On July 1, 2019, 6:10 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 1, 2019, 6:10 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/7/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-01 Thread Le Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216285
---




intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java
Lines 168 (patched)


Please make sure you've run pre-commit job before committing the code.


- Le Ma


On July 1, 2019, 6:10 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated July 1, 2019, 6:10 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/7/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-07-01 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated July 1, 2019, 6:10 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Checks for the dynamic attribute refered to in options not existing (null case)


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
254eee4c9d18ab87a8862ce479fc2274227c7c29 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 


Diff: https://reviews.apache.org/r/70913/diff/7/

Changes: https://reviews.apache.org/r/70913/diff/6-7/


Testing
---

Added unit test


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-28 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216238
---




intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 723 (patched)


getAttribute(attributeName) could be null - if non-existing attribute was 
specified in the template. Please handle this case (i.e. log a warning, ignore 
and continue), to avoid NPE.


- Madhan Neethiraj


On June 28, 2019, 10:37 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated June 28, 2019, 10:37 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/6/
> 
> 
> Testing
> ---
> 
> Added unit test
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-28 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated June 28, 2019, 10:37 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
254eee4c9d18ab87a8862ce479fc2274227c7c29 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 


Diff: https://reviews.apache.org/r/70913/diff/6/


Testing (updated)
---

Added unit test


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-28 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated June 28, 2019, 10:37 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Made the dynamicAttributes from options only allowed to be Atlas String type, 
because it's the only type that makes sense given the current model. Edited the 
unit test to reflect that.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
254eee4c9d18ab87a8862ce479fc2274227c7c29 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 


Diff: https://reviews.apache.org/r/70913/diff/6/

Changes: https://reviews.apache.org/r/70913/diff/5-6/


Testing
---

Planning to add unit tests


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-27 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216220
---




intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java
Lines 362 (patched)


DynAttribute is relevant only for primitive type attributes - perhaps only 
to string type. Here it is applied on an array-type attribute - which should be 
ignored, with a warning message while loading the model. Please review and 
update.

Rest of the changes look good!


- Madhan Neethiraj


On June 28, 2019, 12:05 a.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated June 28, 2019, 12:05 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/5/
> 
> 
> Testing
> ---
> 
> Planning to add unit tests
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-27 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated June 28, 2019, 12:05 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

Changed Lists dynAttributes and dynEvalTriggerAttributes, and the Map 
ParsedTemplates to be unmodifiable. I removed the qualifiedName template for 
hive_column_lineage for now, since I am unsure how we are going to deal with 
Collection type relationship attributes.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
254eee4c9d18ab87a8862ce479fc2274227c7c29 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 


Diff: https://reviews.apache.org/r/70913/diff/5/

Changes: https://reviews.apache.org/r/70913/diff/4-5/


Testing
---

Planning to add unit tests


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-26 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216168
---




addons/models/1000-Hadoop/1030-hive_model.json
Lines 451 (patched)


"outputs" is a collection, hence referencing attribute 'name' would be 
ambiguous. I suggest to not support collection type attributes in dynAttribute 
expressions.



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 171 (patched)


relationshipAttributes is finalized only in resolveReferencesPhase3(). 
Given populateDynFlagsInfo() might be referring to relationship attributes, 
lines #170 - #173 should be moved to resolveReferencesPhase3().



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 675 (patched)


clear contents of dynAttributes, dynEvalTriggerAttributes before populating 
them here.



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 683 (patched)


Please consider adding a comment here, if and else case here i.e. 
presence/absence of DYN_ATTRIBUTE_NAME_SEPARATOR in exp.



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 690 (patched)


Instead of checking for null here, update the block in #677 to avoid adding 
null entries in dynAttributes.



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 696 (patched)


Instead of checking for null here, update the block in #684 to avoid adding 
null entries in dynAttributes.



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 708 (patched)


1. consider folllwing renames for better readabilitry"
   attributeName => key
   key   => attributeName

2. Consider updating this method to return parsed-map and have it assigned 
to this.parsedTemplates:

   private Map> parseDynAttributeTemplates() {
 Map> ret = new HashMap<>();
 
 ... // parse and populate ret
 
 return Collections.unmodifiableMap(ret);
   }


- Madhan Neethiraj


On June 26, 2019, 8:14 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated June 26, 2019, 8:14 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/4/
> 
> 
> Testing
> ---
> 
> Planning to add unit tests
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-26 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated June 26, 2019, 8:14 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

The result of the split of the template is converted from an array to a List 
for readability. It won't be an expensive operation because this happens at 
most once per entity type, and the array is small.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
254eee4c9d18ab87a8862ce479fc2274227c7c29 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 


Diff: https://reviews.apache.org/r/70913/diff/4/

Changes: https://reviews.apache.org/r/70913/diff/3-4/


Testing
---

Planning to add unit tests


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-24 Thread Merryle Wang via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated June 25, 2019, 12:08 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

I moved the parsing of the template to a separate method called parseTemplates, 
and this creates a hashmap that stores the parsed templates with a key value 
pair of .


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
254eee4c9d18ab87a8862ce479fc2274227c7c29 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 


Diff: https://reviews.apache.org/r/70913/diff/3/

Changes: https://reviews.apache.org/r/70913/diff/2-3/


Testing
---

Planning to add unit tests


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-24 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216095
---




intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 679 (patched)


Create 'private static final' field.



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 680 (patched)


Abstract this in a separate method, say 
resolveDynamicAttribute(AtlasAttribute attr);


- Ashutosh Mestry


On June 22, 2019, 12:40 a.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated June 22, 2019, 12:40 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/2/
> 
> 
> Testing
> ---
> 
> Planning to add unit tests
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-23 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216083
---




addons/models/1000-Hadoop/1030-hive_model.json
Lines 550 (patched)


why add a new type - 'hive_ddl' ?



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 166 (patched)


both dynAttributes and dynEvalTriggerAttributes are class variables, why 
pass as arguments? - populateDynFlagsInfo()



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 680 (patched)


this delim ('|') is no longer valid, please review and remove.



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Line 771 (original), 774 (patched)


revert formatting change if unintended.


- Sarath Subramanian


On June 21, 2019, 5:40 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated June 21, 2019, 5:40 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
> 3c53c02b48747515217c9327c98209a48ee84237 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/2/
> 
> 
> Testing
> ---
> 
> Planning to add unit tests
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-21 Thread Merryle Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/
---

(Updated June 22, 2019, 12:40 a.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Sarath Subramanian.


Changes
---

I moved all of the handling of setting the flags in AtlasAttributes to the 
AtlasEntityType class.


Repository: atlas


Description
---

ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes


Diffs (updated)
-

  addons/models/1000-Hadoop/1030-hive_model.json 
8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
d9ae9e36773146fad652a1e28fc8822bae5c8557 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
254eee4c9d18ab87a8862ce479fc2274227c7c29 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 
3c53c02b48747515217c9327c98209a48ee84237 


Diff: https://reviews.apache.org/r/70913/diff/2/

Changes: https://reviews.apache.org/r/70913/diff/1-2/


Testing
---

Planning to add unit tests


Thanks,

Merryle Wang

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-21 Thread Merryle Wang 


> On June 21, 2019, 7:08 p.m., Le Ma wrote:
> > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
> > Lines 674 (patched)
> > 
> >
> > Just a thoungt, is it possible to change "options" from  > String> to , then you can avoid all these string 
> > manipulation things by organizing them under a sub-map:
> > options : {
> > "DynAttributes" : {
> > "QualifiedName" : ...
> > }
> > }

There is already code that reads in the options as a  that I 
don't want to mess with, so that's why I'm keep the dynamicAttributes as a 
.


- Merryle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216062
---


On June 20, 2019, 11:52 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated June 20, 2019, 11:52 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  7791fb4c656a354065ad8f28ae8618c6e07d8ed4 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  aedb1552be14bf92d3464f44a5d89e8106104aeb 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> 4171942026efbc021d707fdc047e4d647208d021 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> 98071b297efef8596206842923d85d20b267cc10 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  64f5503fe70ebd494cabecd04da78494b6b827ac 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  02638c3ba5c429380ec9f098c143b49314604159 
> 
> 
> Diff: https://reviews.apache.org/r/70913/diff/1/
> 
> 
> Testing
> ---
> 
> Planning to add unit tests
> 
> 
> Thanks,
> 
> Merryle Wang
> 
>

Re: Review Request 70913: ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes

2019-06-20 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70913/#review216027
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
Lines 139 (patched)


Is addition of 'createTime' attribute (in CreateHiveProcess and 
CreateTable) related to this enhancement (of dynamic-attribute)? If not, please 
consider a seperate patch for these changes.



addons/models/1000-Hadoop/1030-hive_model.json
Lines 89 (patched)


'outputs' is an array, hence 'qualifiedName' on this doesn't look correct. 
I suggest to only use non-array attributes in dynamic-expressions.



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 674 (patched)


- consider replacing literal string "dynAttribute" with a 'static final' - 
like: private static final DYN_ATTR_PREFIX = "dynAttribute:";

- consider replacing substring(..).equals() with: 
s.startsWith(DYN_ATTR_PREFIX)

- consider moving the logic in fillDynFlagsInfo() method to AtlasAttribute 
constuction, entityDef.getOptions() should be passed to AtlasAttribute 
constructor for this.



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Lines 713 (patched)


Please consider explicitly initializing these to 'false' - for better 
readability.



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Line 714 (original), 716 (patched)


Please retain existing constructor, and add a new one with the additional 
parameters - for backward compatibility. Same for line #744 as well.



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Lines 828 (patched)


Isn't possible to determine if this attribute is 'dyn' - by looking into 
entityDef.options passed to constructor (see other comment in AtlasEntityType)? 
Please consider initializing isDynAttribute in the constructor and mark it as 
final. setIsDynAttribute() shouldn't be needed any more.



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Lines 914 (patched)


1. rename: fillDynFlags -> updateDynFlags
2. parameter names are not intutive; are they attributes of current 
entity-def? if yes, a better place for this method would be AtlasEntityType - 
like:
   class AtlasEntityType {
 private void setDynEvalTriggerAttributes(List attrNames) { ... 
}
   }

if #2 above makes sense, changes in AtlasAttribute constructor may not be 
necessary.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Line 305 (original)


Consider avoiding removing line seperators, like #305, #317, #327.

Also, only changes in this files are white-space/comments related. Consider 
not including this file in review.


- Madhan Neethiraj


On June 20, 2019, 11:52 p.m., Merryle Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70913/
> ---
> 
> (Updated June 20, 2019, 11:52 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  7791fb4c656a354065ad8f28ae8618c6e07d8ed4 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  aedb1552be14bf92d3464f44a5d89e8106104aeb 
>   addons/models/1000-Hadoop/1030-hive_model.json 
> 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> 4171942026efbc021d707fdc047e4d647208d021 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 
> d9ae9e36773146fad652a1e28fc8822bae5c8557 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> 98071b297efef8596206842923d85d20b267cc10 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 
> 254eee4c9d18ab87a8862ce479fc2274227c7c29 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  64f5503fe70ebd494cabecd04da78494b6b827ac 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>