Re: [ANNOUNCE] New PMC member: Etienne Chauchot

[Ismaël Mejía]

Congratulations Etienne!

Le sam. 26 janv. 2019 à 06:42, Reuven Lax  a écrit :

> Welcome!
>
> On Fri, Jan 25, 2019 at 9:30 PM Pablo Estrada  wrote:
>
>> Congrats Etienne :)
>>
>> On Fri, Jan 25, 2019, 9:24 PM Trần Thành Đạt > wrote:
>>
>>> Congratulations Etienne!
>>>
>>> On Sat, Jan 26, 2019 at 12:08 PM Thomas Weise  wrote:
>>>
 Congrats, félicitations!


 On Fri, Jan 25, 2019 at 3:06 PM Scott Wegner  wrote:

> Congrats Etienne!
>
> On Fri, Jan 25, 2019 at 2:34 PM Tim  wrote:
>
>> Congratulations Etienne!
>>
>> Tim
>>
>> > On 25 Jan 2019, at 23:00, Kenneth Knowles  wrote:
>> >
>> > Hi all,
>> >
>> > Please join me and the rest of the Beam PMC in welcoming Etienne
>> Chauchot to join the PMC.
>> >
>> > Etienne introduced himself to dev@ in September of 2017 and over
>> the years has contributed to Beam in many ways - connectors, performance,
>> design discussion, talks, code reviews, and I'm sure I cannot list them
>> all. He already has a major impact on the direction of Beam.
>> >
>> > Thanks for being a part of Beam, Etienne!
>> >
>> > Kenn
>>
>
>
> --
>
>
>
>
> Got feedback? tinyurl.com/swegner-feedback
>

Re: [ANNOUNCE] New PMC member: Etienne Chauchot

[Reuven Lax]

Welcome!

On Fri, Jan 25, 2019 at 9:30 PM Pablo Estrada  wrote:

> Congrats Etienne :)
>
> On Fri, Jan 25, 2019, 9:24 PM Trần Thành Đạt  wrote:
>
>> Congratulations Etienne!
>>
>> On Sat, Jan 26, 2019 at 12:08 PM Thomas Weise  wrote:
>>
>>> Congrats, félicitations!
>>>
>>>
>>> On Fri, Jan 25, 2019 at 3:06 PM Scott Wegner  wrote:
>>>
 Congrats Etienne!

 On Fri, Jan 25, 2019 at 2:34 PM Tim  wrote:

> Congratulations Etienne!
>
> Tim
>
> > On 25 Jan 2019, at 23:00, Kenneth Knowles  wrote:
> >
> > Hi all,
> >
> > Please join me and the rest of the Beam PMC in welcoming Etienne
> Chauchot to join the PMC.
> >
> > Etienne introduced himself to dev@ in September of 2017 and over
> the years has contributed to Beam in many ways - connectors, performance,
> design discussion, talks, code reviews, and I'm sure I cannot list them
> all. He already has a major impact on the direction of Beam.
> >
> > Thanks for being a part of Beam, Etienne!
> >
> > Kenn
>


 --




 Got feedback? tinyurl.com/swegner-feedback

>>>

Re: [ANNOUNCE] New PMC member: Etienne Chauchot

[Pablo Estrada]

Congrats Etienne :)

On Fri, Jan 25, 2019, 9:24 PM Trần Thành Đạt  Congratulations Etienne!
>
> On Sat, Jan 26, 2019 at 12:08 PM Thomas Weise  wrote:
>
>> Congrats, félicitations!
>>
>>
>> On Fri, Jan 25, 2019 at 3:06 PM Scott Wegner  wrote:
>>
>>> Congrats Etienne!
>>>
>>> On Fri, Jan 25, 2019 at 2:34 PM Tim  wrote:
>>>
 Congratulations Etienne!

 Tim

 > On 25 Jan 2019, at 23:00, Kenneth Knowles  wrote:
 >
 > Hi all,
 >
 > Please join me and the rest of the Beam PMC in welcoming Etienne
 Chauchot to join the PMC.
 >
 > Etienne introduced himself to dev@ in September of 2017 and over the
 years has contributed to Beam in many ways - connectors, performance,
 design discussion, talks, code reviews, and I'm sure I cannot list them
 all. He already has a major impact on the direction of Beam.
 >
 > Thanks for being a part of Beam, Etienne!
 >
 > Kenn

>>>
>>>
>>> --
>>>
>>>
>>>
>>>
>>> Got feedback? tinyurl.com/swegner-feedback
>>>
>>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Trần Thành Đạt]

Congratulations Gleb!

On Sat, Jan 26, 2019 at 4:19 AM David Morávek 
wrote:

> Congratulations!
>
> Sent from my iPhone
>
> On 25 Jan 2019, at 20:41, Kai Jiang  wrote:
>
> Congratulations!
>
> On Fri, Jan 25, 2019 at 10:01 AM Rui Wang  wrote:
>
>> Congratulations!
>>
>> -Rui
>>
>> On Fri, Jan 25, 2019 at 9:58 AM Ruoyun Huang  wrote:
>>
>>> Congratulations Gleb!
>>>
>>> On Fri, Jan 25, 2019 at 9:18 AM Scott Wegner  wrote:
>>>
 Congrats, and welcome Gleb!

 On Fri, Jan 25, 2019 at 9:15 AM Suneel Marthi 
 wrote:

> Congratulations
>
> On Fri, Jan 25, 2019 at 12:04 PM Anton Kedin  wrote:
>
>> Congrats!
>>
>> On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía 
>> wrote:
>>
>>> Well deserved, congratulations Gleb!
>>>
>>> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot <
>>> echauc...@apache.org> wrote:
>>> >
>>> > Congrats Gleb and welcome onboard !
>>> >
>>> > Etienne
>>> >
>>> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a
>>> écrit :
>>> >
>>> > Congrats to Gleb and welcome on board!
>>> >
>>> > On 25 Jan 2019, at 09:22, Tim Robertson 
>>> wrote:
>>> >
>>> > Welcome Gleb and congratulations!
>>> >
>>> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles 
>>> wrote:
>>> >
>>> > Hi all,
>>> >
>>> > Please join me and the rest of the Beam PMC in welcoming a new
>>> committer: Gleb Kanterov
>>> >
>>> > Gleb started contributing to Beam and quickly dove deep, doing
>>> some sensitive fixes to schemas, also general build issues, Beam SQL, 
>>> Avro,
>>> and more. In consideration of Gleb's technical and community 
>>> contributions,
>>> the Beam PMC trusts Gleb with the responsibilities of a Beam committer 
>>> [1].
>>> >
>>> > Thank you, Gleb, for your contributions.
>>> >
>>> > Kenn
>>> >
>>> > [1]
>>> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>>> >
>>> >
>>>
>>

 --




 Got feedback? tinyurl.com/swegner-feedback

>>>
>>>
>>> --
>>> 
>>> Ruoyun  Huang
>>>
>>>

Re: [ANNOUNCE] New PMC member: Etienne Chauchot

[Trần Thành Đạt]

Congratulations Etienne!

On Sat, Jan 26, 2019 at 12:08 PM Thomas Weise  wrote:

> Congrats, félicitations!
>
>
> On Fri, Jan 25, 2019 at 3:06 PM Scott Wegner  wrote:
>
>> Congrats Etienne!
>>
>> On Fri, Jan 25, 2019 at 2:34 PM Tim  wrote:
>>
>>> Congratulations Etienne!
>>>
>>> Tim
>>>
>>> > On 25 Jan 2019, at 23:00, Kenneth Knowles  wrote:
>>> >
>>> > Hi all,
>>> >
>>> > Please join me and the rest of the Beam PMC in welcoming Etienne
>>> Chauchot to join the PMC.
>>> >
>>> > Etienne introduced himself to dev@ in September of 2017 and over the
>>> years has contributed to Beam in many ways - connectors, performance,
>>> design discussion, talks, code reviews, and I'm sure I cannot list them
>>> all. He already has a major impact on the direction of Beam.
>>> >
>>> > Thanks for being a part of Beam, Etienne!
>>> >
>>> > Kenn
>>>
>>
>>
>> --
>>
>>
>>
>>
>> Got feedback? tinyurl.com/swegner-feedback
>>
>

Re: [ANNOUNCE] New PMC member: Etienne Chauchot

[Thomas Weise]

Congrats, félicitations!


On Fri, Jan 25, 2019 at 3:06 PM Scott Wegner  wrote:

> Congrats Etienne!
>
> On Fri, Jan 25, 2019 at 2:34 PM Tim  wrote:
>
>> Congratulations Etienne!
>>
>> Tim
>>
>> > On 25 Jan 2019, at 23:00, Kenneth Knowles  wrote:
>> >
>> > Hi all,
>> >
>> > Please join me and the rest of the Beam PMC in welcoming Etienne
>> Chauchot to join the PMC.
>> >
>> > Etienne introduced himself to dev@ in September of 2017 and over the
>> years has contributed to Beam in many ways - connectors, performance,
>> design discussion, talks, code reviews, and I'm sure I cannot list them
>> all. He already has a major impact on the direction of Beam.
>> >
>> > Thanks for being a part of Beam, Etienne!
>> >
>> > Kenn
>>
>
>
> --
>
>
>
>
> Got feedback? tinyurl.com/swegner-feedback
>

Re: [PROPOSAL] Prepare Beam 2.10.0 release

[Kenneth Knowles]

Just a quick update - I'm working through the RC generating process still.
I've run into issues in the scripts / gradle release plugin and some flakes
but proceeding manually seems to be going OK.

Kenn

On Thu, Jan 24, 2019 at 12:21 PM Kenneth Knowles  wrote:

> My mistake - the problem was that the Dataflow container image was not yet
> built, but I did not dig deep enough into StackDriver to find that message.
>
> All issues are resolved and all PRs against the release branch are now
> merged. I am now in process of building those containers and RC1.
>
> Kenn
>
> On Wed, Jan 23, 2019 at 5:25 PM Ahmet Altay  wrote:
>
>> Python precommit cron job (
>> https://builds.apache.org/view/A-D/view/Beam/view/PostCommit/job/beam_PreCommit_Python_Cron/)
>> seems to be healthy. Could you share one of the PRs that you noticed the
>> flakiness, I would be interested in debugging.
>>
>> On Wed, Jan 23, 2019 at 12:25 PM Kenneth Knowles  wrote:
>>
>>> I've seen many PRs that I am reviewing with flakiness problems in the
>>> python precommit IT. Anyone have any insights?
>>>
>>> Kenn
>>>
>>> On Wed, Jan 23, 2019 at 12:23 PM Kenneth Knowles  wrote:
>>>
 Thanks for the reminder. I was reading from
 https://issues.apache.org/jira/projects/BEAM/versions/12344540. RC1
 also gated on clearing
 https://github.com/apache/beam/pulls?utf8=%E2%9C%93=is%3Apr+is%3Aopen+base%3Arelease-2.10.0
 .

 Kenn

 On Wed, Jan 23, 2019 at 9:44 AM Maximilian Michels 
 wrote:

> What about the revert of "Parse SDK-unknown pipeline options"?
> https://github.com/apache/beam/pull/7564
>
> Should we merge this for the release?
>
> On 23.01.19 11:56, Scott Wegner wrote:
> > Cherry-pick PR for the last-remaining issue:
> > https://github.com/apache/beam/pull/7603
> >
> > On Wed, Jan 23, 2019 at 7:15 AM Kenneth Knowles  > > wrote:
> >
> > The last remaining issue is split into a non-blocker and a
> revert that is
> > confirmed to fix the issue.
> >
> > Once https://github.com/apache/beam/pull/7600 is merged and
> cherry-picked, I
> > will cut RC1 today.
> >
> > Kenn
> >
> > On Tue, Jan 22, 2019 at 6:03 PM Kenneth Knowles  > > wrote:
> >
> > OK. There is just one release blocker remaining;
> > https://issues.apache.org/jira/browse/BEAM-6354
> >
> > I have no insights yet, but I am bisecting. It was healthy
> in 2.9.0.
> >
> > Kenn
> >
> > On Tue, Jan 22, 2019 at 9:38 AM Scott Wegner <
> sweg...@google.com
> > > wrote:
> >
> > The rollback for BEAM-6352 is now in and cherry-picked
> into the
> > release branch.
> >
> > On Fri, Jan 18, 2019 at 9:04 AM Scott Wegner <
> sc...@apache.org
> > > wrote:
> >
> > For BEAM-6352, I have a rollback ready for review:
> > https://github.com/apache/beam/pull/7540
> > Conversation about the decision to rollback vs.
> roll-forward for
> > this change is on the JIRA issue.
> >
> > On Fri, Jan 18, 2019 at 8:22 AM Maximilian Michels
> > mailto:m...@apache.org>> wrote:
> >
> > I've created the revert for the pipeline options
> parsing
> > which we agreed on:
> > https://github.com/apache/beam/pull/7564
> >
> > On 17.01.19 15:16, Maximilian Michels wrote:
> >  > An issue with the Flink Runner when
> restarting streaming
> > pipelines:
> >  > https://jira.apache.org/jira/browse/BEAM-6460
> >  >
> >  > Looks like it will be easy to fix by
> invalidating the
> > Jackson cache.
> >  >
> >  > -Max
> >  >
> >  > On 16.01.19 23:00, Kenneth Knowles wrote:
> >  >> Quick update on this. There are three
> remaining issues:
> >  >>
> >  >>   -
> https://issues.apache.org/jira/browse/BEAM-6407: A
> > DirectRunner self-check
> >  >> was broken from 2.8.0 to 2.9.0 - PR looks
> good modulo
> > our infra flakes
> >  >>   -
> https://issues.apache.org/jira/browse/BEAM-6354:
> > PAssert + DirectRunner +
> >  >> Unbounded data busted? Investigation not
> started
> >  >>   -

Re: [ANNOUNCE] New PMC member: Etienne Chauchot

[Scott Wegner]

Congrats Etienne!

On Fri, Jan 25, 2019 at 2:34 PM Tim  wrote:

> Congratulations Etienne!
>
> Tim
>
> > On 25 Jan 2019, at 23:00, Kenneth Knowles  wrote:
> >
> > Hi all,
> >
> > Please join me and the rest of the Beam PMC in welcoming Etienne
> Chauchot to join the PMC.
> >
> > Etienne introduced himself to dev@ in September of 2017 and over the
> years has contributed to Beam in many ways - connectors, performance,
> design discussion, talks, code reviews, and I'm sure I cannot list them
> all. He already has a major impact on the direction of Beam.
> >
> > Thanks for being a part of Beam, Etienne!
> >
> > Kenn
>


-- 




Got feedback? tinyurl.com/swegner-feedback

Re: [ANNOUNCE] New PMC member: Etienne Chauchot

[Tim]

Congratulations Etienne!

Tim

> On 25 Jan 2019, at 23:00, Kenneth Knowles  wrote:
> 
> Hi all,
> 
> Please join me and the rest of the Beam PMC in welcoming Etienne Chauchot to 
> join the PMC.
> 
> Etienne introduced himself to dev@ in September of 2017 and over the years 
> has contributed to Beam in many ways - connectors, performance, design 
> discussion, talks, code reviews, and I'm sure I cannot list them all. He 
> already has a major impact on the direction of Beam.
> 
> Thanks for being a part of Beam, Etienne!
> 
> Kenn

[ANNOUNCE] New PMC member: Etienne Chauchot

[Kenneth Knowles]

Hi all,

Please join me and the rest of the Beam PMC in welcoming Etienne Chauchot
to join the PMC.

Etienne introduced himself to dev@ in September of 2017 and over the years
has contributed to Beam in many ways - connectors, performance, design
discussion, talks, code reviews, and I'm sure I cannot list them all. He
already has a major impact on the direction of Beam.

Thanks for being a part of Beam, Etienne!

Kenn

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[David Morávek]

Congratulations!

Sent from my iPhone

> On 25 Jan 2019, at 20:41, Kai Jiang  wrote:
> 
> Congratulations!
> 
>> On Fri, Jan 25, 2019 at 10:01 AM Rui Wang  wrote:
>> Congratulations!
>> 
>> -Rui
>> 
>>> On Fri, Jan 25, 2019 at 9:58 AM Ruoyun Huang  wrote:
>>> Congratulations Gleb! 
>>> 
 On Fri, Jan 25, 2019 at 9:18 AM Scott Wegner  wrote:
 Congrats, and welcome Gleb!
 
> On Fri, Jan 25, 2019 at 9:15 AM Suneel Marthi  wrote:
> Congratulations
> 
>> On Fri, Jan 25, 2019 at 12:04 PM Anton Kedin  wrote:
>> Congrats!
>> 
>>> On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:
>>> Well deserved, congratulations Gleb!
>>> 
>>> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot 
>>>  wrote:
>>> >
>>> > Congrats Gleb and welcome onboard !
>>> >
>>> > Etienne
>>> >
>>> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
>>> >
>>> > Congrats to Gleb and welcome on board!
>>> >
>>> > On 25 Jan 2019, at 09:22, Tim Robertson  
>>> > wrote:
>>> >
>>> > Welcome Gleb and congratulations!
>>> >
>>> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  
>>> > wrote:
>>> >
>>> > Hi all,
>>> >
>>> > Please join me and the rest of the Beam PMC in welcoming a new 
>>> > committer: Gleb Kanterov
>>> >
>>> > Gleb started contributing to Beam and quickly dove deep, doing some 
>>> > sensitive fixes to schemas, also general build issues, Beam SQL, 
>>> > Avro, and more. In consideration of Gleb's technical and community 
>>> > contributions, the Beam PMC trusts Gleb with the responsibilities of 
>>> > a Beam committer [1].
>>> >
>>> > Thank you, Gleb, for your contributions.
>>> >
>>> > Kenn
>>> >
>>> > [1] 
>>> > https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>>> >
>>> >
 
 
 -- 
 
 
 
 
 Got feedback? tinyurl.com/swegner-feedback
>>> 
>>> 
>>> -- 
>>> 
>>> Ruoyun  Huang
>>> 

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Kai Jiang]

Congratulations!

On Fri, Jan 25, 2019 at 10:01 AM Rui Wang  wrote:

> Congratulations!
>
> -Rui
>
> On Fri, Jan 25, 2019 at 9:58 AM Ruoyun Huang  wrote:
>
>> Congratulations Gleb!
>>
>> On Fri, Jan 25, 2019 at 9:18 AM Scott Wegner  wrote:
>>
>>> Congrats, and welcome Gleb!
>>>
>>> On Fri, Jan 25, 2019 at 9:15 AM Suneel Marthi 
>>> wrote:
>>>
 Congratulations

 On Fri, Jan 25, 2019 at 12:04 PM Anton Kedin  wrote:

> Congrats!
>
> On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía 
> wrote:
>
>> Well deserved, congratulations Gleb!
>>
>> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot <
>> echauc...@apache.org> wrote:
>> >
>> > Congrats Gleb and welcome onboard !
>> >
>> > Etienne
>> >
>> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit
>> :
>> >
>> > Congrats to Gleb and welcome on board!
>> >
>> > On 25 Jan 2019, at 09:22, Tim Robertson 
>> wrote:
>> >
>> > Welcome Gleb and congratulations!
>> >
>> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles 
>> wrote:
>> >
>> > Hi all,
>> >
>> > Please join me and the rest of the Beam PMC in welcoming a new
>> committer: Gleb Kanterov
>> >
>> > Gleb started contributing to Beam and quickly dove deep, doing some
>> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, 
>> and
>> more. In consideration of Gleb's technical and community contributions, 
>> the
>> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
>> >
>> > Thank you, Gleb, for your contributions.
>> >
>> > Kenn
>> >
>> > [1]
>> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>> >
>> >
>>
>
>>>
>>> --
>>>
>>>
>>>
>>>
>>> Got feedback? tinyurl.com/swegner-feedback
>>>
>>
>>
>> --
>> 
>> Ruoyun  Huang
>>
>>

Re: BEAM-6324 / #7340: "I've pretty much given up on the PR being merged. I use my own fork for my projects"

[Kenneth Knowles]

Yea, that guide oscillates in size because of the tension between (1) being
short enough that someone actually reads it and can get a birds-eye view of
what they have to do and (2) providing all the info needed in case they
don't already know what to do. It is already pretty short, and most of the
technical details are off on the wiki.

Kenn

On Fri, Jan 25, 2019 at 10:21 AM Rui Wang  wrote:

> We have code contribution guidelines [1] and it says useful tips to make
> PR reviewed and merged. But I guess it hides in Beam website so new
> contributors are likely to ignore it. In order to make the guidance easy to
> find and read for new contributors, we probably can
>
> a. Move number 5 item from [1] to a separate section and name it "Tips to
> get your PR reviewed and merged"
> b. Put the link to the Github pull request template, so when a contributor
> creates the first PR, the contributor could see the link (or even paste
> text from contribution guide). It will be a good chance that new
> contributors read what's in pull request template.
>
>
> -Rui
>
> [1] https://beam.apache.org/contribute/#make-your-change
>
> On Fri, Jan 25, 2019 at 9:24 AM Alexey Romanenko 
> wrote:
>
>> For sure, it’s a pity that this PR has not been addressed for a long time
>> (I guess, we probably have other ones like this) but, as I can see from
>> this PR history, review has not been requested explicitly by author (and
>> this is one of the our recommendations for code contribution [1]).
>>
>> What are the options to improve this:
>>
>> 1) Make it more clearly for new contributors that they need to ask for a
>> review explicitly (with a help of recommendations that already provided in
>> top-right corner on PR page)
>> 2) Create a bot (like “stale” bot that we have) to check for
>> non-addressed PRs that are more than, say, 7 days, and send notification to
>> dev@ (or dedicated, see n.3) mailing list if they are starving for
>> review.
>> 3) (Optionally) Create new mailing list called pr@ for new coming and
>> non-addressed PRs
>>
>> [1] https://beam.apache.org/contribute/#make-your-change
>>
>>
>> On 25 Jan 2019, at 17:50, Ismaël Mejía  wrote:
>>
>> The fact that this happened is a real pity. However it is clearly an
>> exception and not the rule. Really few PRs have been long time without
>> review. Can we somehow automatically send a notification if a PR has
>> no assigned reviewers, or if it has not been reviewed after some time
>> as Tim suggested?
>>
>> On Fri, Jan 25, 2019 at 9:43 AM Tim Robertson 
>> wrote:
>>
>>
>> Thanks Kenn
>>
>> I tend to think that timing is the main contributing factor as you note
>> on the Jira - it slipped down with no reminders / bumps sent on any
>> channels that I can see.
>>
>> Would something that alerts the dev@ list of PRs that have not received
>> any attention after N days be helpful perhaps?
>> Even if that only prompts action by one of us to comment on the PR that
>> it's been acknowledged would likely be enough to engage the contributor -
>> they would hopefully then ping the individual if it then slips for a long
>> time.
>>
>> Next week will be my first I'll be able to work on Beam in 2019, but I'll
>> comment on that PR now too as it's missing tests.
>>
>>
>>
>>
>>
>> On Fri, Jan 25, 2019 at 7:27 AM Kenneth Knowles  wrote:
>>
>>
>> The subject line is a quote from BEAM-6324*
>>
>> This makes me sad. I hope/expect it is a failure to route a pull request
>> to the right reviewer. I am less sad about the functionality than the
>> sentiment and how a contributor is being discouraged.
>>
>> Does anyone have ideas that could help?
>>
>> Kenn
>>
>> *https://issues.apache.org/jira/browse/BEAM-6324
>>
>>
>>

Re: BEAM-6324 / #7340: "I've pretty much given up on the PR being merged. I use my own fork for my projects"

[Scott Wegner]

For first-time contributors, GitHub will display a link to a contributor
guide [1]. We have one for Beam [2], which simply directs contributors to
the website contribution guide [3].

I think what we have is pretty good already, although we could be more
clear that the contributor guide includes tips like how to find a reviewer.
Here's an attempt at improving it: https://github.com/apache/beam/pull/7628

[1]
https://help.github.com/articles/setting-guidelines-for-repository-contributors/
[2] https://github.com/apache/beam/blob/master/CONTRIBUTING.md
[3] https://beam.apache.org/contribute/contribution-guide/

On Fri, Jan 25, 2019 at 10:21 AM Rui Wang  wrote:

> We have code contribution guidelines [1] and it says useful tips to make
> PR reviewed and merged. But I guess it hides in Beam website so new
> contributors are likely to ignore it. In order to make the guidance easy to
> find and read for new contributors, we probably can
>
> a. Move number 5 item from [1] to a separate section and name it "Tips to
> get your PR reviewed and merged"
> b. Put the link to the Github pull request template, so when a contributor
> creates the first PR, the contributor could see the link (or even paste
> text from contribution guide). It will be a good chance that new
> contributors read what's in pull request template.
>
>
> -Rui
>
> [1] https://beam.apache.org/contribute/#make-your-change
>
> On Fri, Jan 25, 2019 at 9:24 AM Alexey Romanenko 
> wrote:
>
>> For sure, it’s a pity that this PR has not been addressed for a long time
>> (I guess, we probably have other ones like this) but, as I can see from
>> this PR history, review has not been requested explicitly by author (and
>> this is one of the our recommendations for code contribution [1]).
>>
>> What are the options to improve this:
>>
>> 1) Make it more clearly for new contributors that they need to ask for a
>> review explicitly (with a help of recommendations that already provided in
>> top-right corner on PR page)
>> 2) Create a bot (like “stale” bot that we have) to check for
>> non-addressed PRs that are more than, say, 7 days, and send notification to
>> dev@ (or dedicated, see n.3) mailing list if they are starving for
>> review.
>> 3) (Optionally) Create new mailing list called pr@ for new coming and
>> non-addressed PRs
>>
>> [1] https://beam.apache.org/contribute/#make-your-change
>>
>>
>> On 25 Jan 2019, at 17:50, Ismaël Mejía  wrote:
>>
>> The fact that this happened is a real pity. However it is clearly an
>> exception and not the rule. Really few PRs have been long time without
>> review. Can we somehow automatically send a notification if a PR has
>> no assigned reviewers, or if it has not been reviewed after some time
>> as Tim suggested?
>>
>> On Fri, Jan 25, 2019 at 9:43 AM Tim Robertson 
>> wrote:
>>
>>
>> Thanks Kenn
>>
>> I tend to think that timing is the main contributing factor as you note
>> on the Jira - it slipped down with no reminders / bumps sent on any
>> channels that I can see.
>>
>> Would something that alerts the dev@ list of PRs that have not received
>> any attention after N days be helpful perhaps?
>> Even if that only prompts action by one of us to comment on the PR that
>> it's been acknowledged would likely be enough to engage the contributor -
>> they would hopefully then ping the individual if it then slips for a long
>> time.
>>
>> Next week will be my first I'll be able to work on Beam in 2019, but I'll
>> comment on that PR now too as it's missing tests.
>>
>>
>>
>>
>>
>> On Fri, Jan 25, 2019 at 7:27 AM Kenneth Knowles  wrote:
>>
>>
>> The subject line is a quote from BEAM-6324*
>>
>> This makes me sad. I hope/expect it is a failure to route a pull request
>> to the right reviewer. I am less sad about the functionality than the
>> sentiment and how a contributor is being discouraged.
>>
>> Does anyone have ideas that could help?
>>
>> Kenn
>>
>> *https://issues.apache.org/jira/browse/BEAM-6324
>>
>>
>>

-- 




Got feedback? tinyurl.com/swegner-feedback

Re: BEAM-6324 / #7340: "I've pretty much given up on the PR being merged. I use my own fork for my projects"

[Rui Wang]

We have code contribution guidelines [1] and it says useful tips to make PR
reviewed and merged. But I guess it hides in Beam website so new
contributors are likely to ignore it. In order to make the guidance easy to
find and read for new contributors, we probably can

a. Move number 5 item from [1] to a separate section and name it "Tips to
get your PR reviewed and merged"
b. Put the link to the Github pull request template, so when a contributor
creates the first PR, the contributor could see the link (or even paste
text from contribution guide). It will be a good chance that new
contributors read what's in pull request template.


-Rui

[1] https://beam.apache.org/contribute/#make-your-change

On Fri, Jan 25, 2019 at 9:24 AM Alexey Romanenko 
wrote:

> For sure, it’s a pity that this PR has not been addressed for a long time
> (I guess, we probably have other ones like this) but, as I can see from
> this PR history, review has not been requested explicitly by author (and
> this is one of the our recommendations for code contribution [1]).
>
> What are the options to improve this:
>
> 1) Make it more clearly for new contributors that they need to ask for a
> review explicitly (with a help of recommendations that already provided in
> top-right corner on PR page)
> 2) Create a bot (like “stale” bot that we have) to check for non-addressed
> PRs that are more than, say, 7 days, and send notification to dev@ (or
> dedicated, see n.3) mailing list if they are starving for review.
> 3) (Optionally) Create new mailing list called pr@ for new coming and
> non-addressed PRs
>
> [1] https://beam.apache.org/contribute/#make-your-change
>
>
> On 25 Jan 2019, at 17:50, Ismaël Mejía  wrote:
>
> The fact that this happened is a real pity. However it is clearly an
> exception and not the rule. Really few PRs have been long time without
> review. Can we somehow automatically send a notification if a PR has
> no assigned reviewers, or if it has not been reviewed after some time
> as Tim suggested?
>
> On Fri, Jan 25, 2019 at 9:43 AM Tim Robertson 
> wrote:
>
>
> Thanks Kenn
>
> I tend to think that timing is the main contributing factor as you note on
> the Jira - it slipped down with no reminders / bumps sent on any channels
> that I can see.
>
> Would something that alerts the dev@ list of PRs that have not received
> any attention after N days be helpful perhaps?
> Even if that only prompts action by one of us to comment on the PR that
> it's been acknowledged would likely be enough to engage the contributor -
> they would hopefully then ping the individual if it then slips for a long
> time.
>
> Next week will be my first I'll be able to work on Beam in 2019, but I'll
> comment on that PR now too as it's missing tests.
>
>
>
>
>
> On Fri, Jan 25, 2019 at 7:27 AM Kenneth Knowles  wrote:
>
>
> The subject line is a quote from BEAM-6324*
>
> This makes me sad. I hope/expect it is a failure to route a pull request
> to the right reviewer. I am less sad about the functionality than the
> sentiment and how a contributor is being discouraged.
>
> Does anyone have ideas that could help?
>
> Kenn
>
> *https://issues.apache.org/jira/browse/BEAM-6324
>
>
>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Rui Wang]

Congratulations!

-Rui

On Fri, Jan 25, 2019 at 9:58 AM Ruoyun Huang  wrote:

> Congratulations Gleb!
>
> On Fri, Jan 25, 2019 at 9:18 AM Scott Wegner  wrote:
>
>> Congrats, and welcome Gleb!
>>
>> On Fri, Jan 25, 2019 at 9:15 AM Suneel Marthi  wrote:
>>
>>> Congratulations
>>>
>>> On Fri, Jan 25, 2019 at 12:04 PM Anton Kedin  wrote:
>>>
 Congrats!

 On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:

> Well deserved, congratulations Gleb!
>
> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot <
> echauc...@apache.org> wrote:
> >
> > Congrats Gleb and welcome onboard !
> >
> > Etienne
> >
> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
> >
> > Congrats to Gleb and welcome on board!
> >
> > On 25 Jan 2019, at 09:22, Tim Robertson 
> wrote:
> >
> > Welcome Gleb and congratulations!
> >
> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles 
> wrote:
> >
> > Hi all,
> >
> > Please join me and the rest of the Beam PMC in welcoming a new
> committer: Gleb Kanterov
> >
> > Gleb started contributing to Beam and quickly dove deep, doing some
> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
> more. In consideration of Gleb's technical and community contributions, 
> the
> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
> >
> > Thank you, Gleb, for your contributions.
> >
> > Kenn
> >
> > [1]
> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
> >
> >
>

>>
>> --
>>
>>
>>
>>
>> Got feedback? tinyurl.com/swegner-feedback
>>
>
>
> --
> 
> Ruoyun  Huang
>
>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Ruoyun Huang]

 Congratulations Gleb!

On Fri, Jan 25, 2019 at 9:18 AM Scott Wegner  wrote:

> Congrats, and welcome Gleb!
>
> On Fri, Jan 25, 2019 at 9:15 AM Suneel Marthi  wrote:
>
>> Congratulations
>>
>> On Fri, Jan 25, 2019 at 12:04 PM Anton Kedin  wrote:
>>
>>> Congrats!
>>>
>>> On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:
>>>
 Well deserved, congratulations Gleb!

 On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot 
 wrote:
 >
 > Congrats Gleb and welcome onboard !
 >
 > Etienne
 >
 > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
 >
 > Congrats to Gleb and welcome on board!
 >
 > On 25 Jan 2019, at 09:22, Tim Robertson 
 wrote:
 >
 > Welcome Gleb and congratulations!
 >
 > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles 
 wrote:
 >
 > Hi all,
 >
 > Please join me and the rest of the Beam PMC in welcoming a new
 committer: Gleb Kanterov
 >
 > Gleb started contributing to Beam and quickly dove deep, doing some
 sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
 more. In consideration of Gleb's technical and community contributions, the
 Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
 >
 > Thank you, Gleb, for your contributions.
 >
 > Kenn
 >
 > [1]
 https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
 >
 >

>>>
>
> --
>
>
>
>
> Got feedback? tinyurl.com/swegner-feedback
>


-- 

Ruoyun  Huang

Re: The full list of proposals / prototype documents

[Alexey Romanenko]

Hi Alex,

Indeed, some of them are not shared with everyone. I asked on Slack channel to 
fix this.
Thank you for the list!


> On 18 Jan 2019, at 19:57, Alex Van Boxel  wrote:
> 
> typically me... I just click on 2 of the 3 that were not shared. I went over 
> all of the proposals to see where I needed to get access, here is the list:
> SQL / Schema
> Pubsub to Beam SQL [doc 
> ]
> Calcite/Beam SQL Windowing [doc 
> ]
> Reject Unsupported Windowing Strategies in JOIN [doc 
> ]
> the ones that I had access to, from the past I don't know anymore of course.
> 
>  _/
> _/ Alex Van Boxel
> 
> 
> On Fri, Jan 18, 2019 at 6:13 PM Alexey Romanenko  > wrote:
> Hi Alex,
> 
> Hmm, afaik, this is mostly google docs file which shared with anyone who 
> knows the link. 
> Could you send here the names of proposals that required an access approval?
> Thanks. 
> 
>> On 18 Jan 2019, at 16:58, Alex Van Boxel > > wrote:
>> 
>> Hey Alexey,
>> 
>> I see that a lot (well, I tried 2) proposals require access approval. Should 
>> that be the case?
>> 
>>  _/
>> _/ Alex Van Boxel
>> 
>> 
>> On Fri, Jan 18, 2019 at 4:51 PM Alexey Romanenko > > wrote:
>> I’m sorry but I forgot to mention that the whole list could be found here:
>> https://beam.apache.org/contribute/design-documents/ 
>> 
>> 
>> 
>>> On 18 Jan 2019, at 16:49, Alexey Romanenko >> > wrote:
>>> 
>>> FYI: I updated the list of design documents to make it up-to-date.
>>> PR: https://github.com/apache/beam/pull/7560 
>>> 
>>> Please, feel free to add new ones if I missed something.
>>> 
>>> Also, I’d like to remind that it would be very helpful to add design 
>>> document to this page in the same time as it was created and finalised 
>>> after all discussions.
>>> It should help us to keep this list consistent and always up-to-date.
>>> Thank you in advance!
>>> 
>>> On 11 Jul 2018, at 17:03, Alexey Romanenko >> > wrote:
 
 Thank you for this link, Etienne. 
 I agree that it doesn’t fit well for design documents page. So, I think it 
 makes sense to add either on wiki or as a part of Nexmark documentation on 
 web site: https://beam.apache.org/documentation/sdks/java/nexmark/ 
 .
 
 
 On 11 Jul 2018, at 11:16, Etienne Chauchot >>> > wrote:
> 
> Alexey,
> 
> One doc that can be interesting that I forgot to point out is 
> https://docs.google.com/document/d/1VgnGiVu8vSfm7Et-xAtQYv0PlEpqeyfmhpQUNPmWRJs/edit?usp=sharing
>  
> 
> It is the doc I wrote when I submitted Nexmark PR to ease the reading of 
> the code.
> It is not a design doc, I don't know if it belongs to the website page or 
> to the wiki for beam devs.
> 
> Etienne
> 
> 
> Le mercredi 06 juin 2018 à 17:48 +0200, Alexey Romanenko a écrit :
>> FYI: Finally, it was merged and you can find this page here:
>> https://beam.apache.org/contribute/design-documents/ 
>> 
>> 
>> Thank you everybody who helped me to compile this list! 
>> I’ll try to do my best to update this with new coming docs. In the same 
>> time, please, feel free to add your new docs (or notify me if I missed 
>> this) once they are finished and ready to be published.
>> 
>> WBR,
>> Alexey
>> 
>>> On 31 May 2018, at 18:52, Eugene Kirpichov >> > wrote:
>>> 
>>> Thank you!
>>> 
>>> On Thu, May 31, 2018 at 8:30 AM Alexey Romanenko 
>>> mailto:aromanenko@gmail.com>> wrote:
 Thank you everybody for provided links. I collected all of them 
 (please, correct me if I missed something), categorized and created a 
 dedicated page for Beam website.
 
 Here is a PR for that (please, review):
 https://github.com/apache/beam-site/pull/456 
 
 
 WBR,
 Alexey
 
> On 30 May 2018, at 13:17, Łukasz Gajowy  > wrote:
> 
> Hi, 
> 
> I just wanted to add those two (sorry for being kinda late with 
> this): 
> 
> https://docs.google.com/document/d/1dA-5s6OHiP_cz-NRAbwapoKF5MEC1wKps4A5tFbIPKE/edit?usp=sharing

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Scott Wegner]

Congrats, and welcome Gleb!

On Fri, Jan 25, 2019 at 9:15 AM Suneel Marthi  wrote:

> Congratulations
>
> On Fri, Jan 25, 2019 at 12:04 PM Anton Kedin  wrote:
>
>> Congrats!
>>
>> On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:
>>
>>> Well deserved, congratulations Gleb!
>>>
>>> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot 
>>> wrote:
>>> >
>>> > Congrats Gleb and welcome onboard !
>>> >
>>> > Etienne
>>> >
>>> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
>>> >
>>> > Congrats to Gleb and welcome on board!
>>> >
>>> > On 25 Jan 2019, at 09:22, Tim Robertson 
>>> wrote:
>>> >
>>> > Welcome Gleb and congratulations!
>>> >
>>> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles 
>>> wrote:
>>> >
>>> > Hi all,
>>> >
>>> > Please join me and the rest of the Beam PMC in welcoming a new
>>> committer: Gleb Kanterov
>>> >
>>> > Gleb started contributing to Beam and quickly dove deep, doing some
>>> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
>>> more. In consideration of Gleb's technical and community contributions, the
>>> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
>>> >
>>> > Thank you, Gleb, for your contributions.
>>> >
>>> > Kenn
>>> >
>>> > [1]
>>> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>>> >
>>> >
>>>
>>

-- 




Got feedback? tinyurl.com/swegner-feedback

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Suneel Marthi]

Congratulations

On Fri, Jan 25, 2019 at 12:04 PM Anton Kedin  wrote:

> Congrats!
>
> On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:
>
>> Well deserved, congratulations Gleb!
>>
>> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot 
>> wrote:
>> >
>> > Congrats Gleb and welcome onboard !
>> >
>> > Etienne
>> >
>> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
>> >
>> > Congrats to Gleb and welcome on board!
>> >
>> > On 25 Jan 2019, at 09:22, Tim Robertson 
>> wrote:
>> >
>> > Welcome Gleb and congratulations!
>> >
>> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  wrote:
>> >
>> > Hi all,
>> >
>> > Please join me and the rest of the Beam PMC in welcoming a new
>> committer: Gleb Kanterov
>> >
>> > Gleb started contributing to Beam and quickly dove deep, doing some
>> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
>> more. In consideration of Gleb's technical and community contributions, the
>> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
>> >
>> > Thank you, Gleb, for your contributions.
>> >
>> > Kenn
>> >
>> > [1]
>> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>> >
>> >
>>
>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Reuven Lax]

Welcome Gleb!


On Fri, Jan 25, 2019 at 9:09 AM Ahmet Altay  wrote:

> Congratulations!
>
> On Fri, Jan 25, 2019 at 9:04 AM Andrew Pilloud 
> wrote:
>
>> Congratulations Gleb!
>>
>> On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:
>>
>>> Well deserved, congratulations Gleb!
>>>
>>> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot 
>>> wrote:
>>> >
>>> > Congrats Gleb and welcome onboard !
>>> >
>>> > Etienne
>>> >
>>> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
>>> >
>>> > Congrats to Gleb and welcome on board!
>>> >
>>> > On 25 Jan 2019, at 09:22, Tim Robertson 
>>> wrote:
>>> >
>>> > Welcome Gleb and congratulations!
>>> >
>>> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles 
>>> wrote:
>>> >
>>> > Hi all,
>>> >
>>> > Please join me and the rest of the Beam PMC in welcoming a new
>>> committer: Gleb Kanterov
>>> >
>>> > Gleb started contributing to Beam and quickly dove deep, doing some
>>> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
>>> more. In consideration of Gleb's technical and community contributions, the
>>> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
>>> >
>>> > Thank you, Gleb, for your contributions.
>>> >
>>> > Kenn
>>> >
>>> > [1]
>>> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>>> >
>>> >
>>>
>>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Ahmet Altay]

Congratulations!

On Fri, Jan 25, 2019 at 9:04 AM Andrew Pilloud  wrote:

> Congratulations Gleb!
>
> On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:
>
>> Well deserved, congratulations Gleb!
>>
>> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot 
>> wrote:
>> >
>> > Congrats Gleb and welcome onboard !
>> >
>> > Etienne
>> >
>> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
>> >
>> > Congrats to Gleb and welcome on board!
>> >
>> > On 25 Jan 2019, at 09:22, Tim Robertson 
>> wrote:
>> >
>> > Welcome Gleb and congratulations!
>> >
>> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  wrote:
>> >
>> > Hi all,
>> >
>> > Please join me and the rest of the Beam PMC in welcoming a new
>> committer: Gleb Kanterov
>> >
>> > Gleb started contributing to Beam and quickly dove deep, doing some
>> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
>> more. In consideration of Gleb's technical and community contributions, the
>> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
>> >
>> > Thank you, Gleb, for your contributions.
>> >
>> > Kenn
>> >
>> > [1]
>> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>> >
>> >
>>
>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Andrew Pilloud]

Congratulations Gleb!

On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:

> Well deserved, congratulations Gleb!
>
> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot 
> wrote:
> >
> > Congrats Gleb and welcome onboard !
> >
> > Etienne
> >
> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
> >
> > Congrats to Gleb and welcome on board!
> >
> > On 25 Jan 2019, at 09:22, Tim Robertson 
> wrote:
> >
> > Welcome Gleb and congratulations!
> >
> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  wrote:
> >
> > Hi all,
> >
> > Please join me and the rest of the Beam PMC in welcoming a new
> committer: Gleb Kanterov
> >
> > Gleb started contributing to Beam and quickly dove deep, doing some
> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
> more. In consideration of Gleb's technical and community contributions, the
> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
> >
> > Thank you, Gleb, for your contributions.
> >
> > Kenn
> >
> > [1]
> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
> >
> >
>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Anton Kedin]

Congrats!

On Fri, Jan 25, 2019 at 8:54 AM Ismaël Mejía  wrote:

> Well deserved, congratulations Gleb!
>
> On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot 
> wrote:
> >
> > Congrats Gleb and welcome onboard !
> >
> > Etienne
> >
> > Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
> >
> > Congrats to Gleb and welcome on board!
> >
> > On 25 Jan 2019, at 09:22, Tim Robertson 
> wrote:
> >
> > Welcome Gleb and congratulations!
> >
> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  wrote:
> >
> > Hi all,
> >
> > Please join me and the rest of the Beam PMC in welcoming a new
> committer: Gleb Kanterov
> >
> > Gleb started contributing to Beam and quickly dove deep, doing some
> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
> more. In consideration of Gleb's technical and community contributions, the
> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
> >
> > Thank you, Gleb, for your contributions.
> >
> > Kenn
> >
> > [1]
> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
> >
> >
>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Ismaël Mejía]

Well deserved, congratulations Gleb!

On Fri, Jan 25, 2019 at 10:47 AM Etienne Chauchot  wrote:
>
> Congrats Gleb and welcome onboard !
>
> Etienne
>
> Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
>
> Congrats to Gleb and welcome on board!
>
> On 25 Jan 2019, at 09:22, Tim Robertson  wrote:
>
> Welcome Gleb and congratulations!
>
> On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  wrote:
>
> Hi all,
>
> Please join me and the rest of the Beam PMC in welcoming a new committer: 
> Gleb Kanterov
>
> Gleb started contributing to Beam and quickly dove deep, doing some sensitive 
> fixes to schemas, also general build issues, Beam SQL, Avro, and more. In 
> consideration of Gleb's technical and community contributions, the Beam PMC 
> trusts Gleb with the responsibilities of a Beam committer [1].
>
> Thank you, Gleb, for your contributions.
>
> Kenn
>
> [1] 
> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>
>

Re: BEAM-6324 / #7340: "I've pretty much given up on the PR being merged. I use my own fork for my projects"

[Ismaël Mejía]

The fact that this happened is a real pity. However it is clearly an
exception and not the rule. Really few PRs have been long time without
review. Can we somehow automatically send a notification if a PR has
no assigned reviewers, or if it has not been reviewed after some time
as Tim suggested?

On Fri, Jan 25, 2019 at 9:43 AM Tim Robertson  wrote:
>
> Thanks Kenn
>
> I tend to think that timing is the main contributing factor as you note on 
> the Jira - it slipped down with no reminders / bumps sent on any channels 
> that I can see.
>
> Would something that alerts the dev@ list of PRs that have not received any 
> attention after N days be helpful perhaps?
> Even if that only prompts action by one of us to comment on the PR that it's 
> been acknowledged would likely be enough to engage the contributor - they 
> would hopefully then ping the individual if it then slips for a long time.
>
> Next week will be my first I'll be able to work on Beam in 2019, but I'll 
> comment on that PR now too as it's missing tests.
>
>
>
>
>
> On Fri, Jan 25, 2019 at 7:27 AM Kenneth Knowles  wrote:
>>
>> The subject line is a quote from BEAM-6324*
>>
>> This makes me sad. I hope/expect it is a failure to route a pull request to 
>> the right reviewer. I am less sad about the functionality than the sentiment 
>> and how a contributor is being discouraged.
>>
>> Does anyone have ideas that could help?
>>
>> Kenn
>>
>> *https://issues.apache.org/jira/browse/BEAM-6324

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Etienne Chauchot]

Congrats Gleb and welcome onboard !
Etienne
Le vendredi 25 janvier 2019 à 10:39 +0100, Alexey Romanenko a écrit :
> Congrats to Gleb and welcome on board!
> 
> > On 25 Jan 2019, at 09:22, Tim Robertson  wrote:
> > 
> > Welcome Gleb and congratulations!
> > 
> > On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  wrote:
> > > Hi all,
> > > Please join me and the rest of the Beam PMC in welcoming a new committer: 
> > > Gleb Kanterov
> > > 
> > > Gleb started contributing to Beam and quickly dove deep, doing some 
> > > sensitive fixes to schemas, also general build
> > > issues, Beam SQL, Avro, and more. In consideration of Gleb's technical 
> > > and community contributions, the Beam PMC
> > > trusts Gleb with the responsibilities of a Beam committer [1].
> > > 
> > > Thank you, Gleb, for your contributions.
> > > 
> > > Kenn
> > > 
> > > [1] 
> > > https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Alexey Romanenko]

Congrats to Gleb and welcome on board!

> On 25 Jan 2019, at 09:22, Tim Robertson  wrote:
> 
> Welcome Gleb and congratulations!
> 
> On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  > wrote:
> Hi all,
> 
> Please join me and the rest of the Beam PMC in welcoming a new committer: 
> Gleb Kanterov
> 
> Gleb started contributing to Beam and quickly dove deep, doing some sensitive 
> fixes to schemas, also general build issues, Beam SQL, Avro, and more. In 
> consideration of Gleb's technical and community contributions, the Beam PMC 
> trusts Gleb with the responsibilities of a Beam committer [1].
> 
> Thank you, Gleb, for your contributions.
> 
> Kenn
> 
> [1] 
> https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-committer
>  
> 

Re: BEAM-6324 / #7340: "I've pretty much given up on the PR being merged. I use my own fork for my projects"

[Tim Robertson]

Thanks Kenn

I tend to think that timing is the main contributing factor as you note on
the Jira - it slipped down with no reminders / bumps sent on any channels
that I can see.

Would something that alerts the dev@ list of PRs that have not received any
attention after N days be helpful perhaps?
Even if that only prompts action by one of us to comment on the PR that
it's been acknowledged would likely be enough to engage the contributor -
they would hopefully then ping the individual if it then slips for a long
time.

Next week will be my first I'll be able to work on Beam in 2019, but I'll
comment on that PR now too as it's missing tests.





On Fri, Jan 25, 2019 at 7:27 AM Kenneth Knowles  wrote:

> The subject line is a quote from BEAM-6324*
>
> This makes me sad. I hope/expect it is a failure to route a pull request
> to the right reviewer. I am less sad about the functionality than the
> sentiment and how a contributor is being discouraged.
>
> Does anyone have ideas that could help?
>
> Kenn
>
> *https://issues.apache.org/jira/browse/BEAM-6324
>

Re: [ANNOUNCE] New committer announcement: Gleb Kanterov

[Tim Robertson]

Welcome Gleb and congratulations!

On Fri, Jan 25, 2019 at 8:06 AM Kenneth Knowles  wrote:

> Hi all,
>
> Please join me and the rest of the Beam PMC in welcoming a new committer: Gleb
> Kanterov
>
> Gleb started contributing to Beam and quickly dove deep, doing some
> sensitive fixes to schemas, also general build issues, Beam SQL, Avro, and
> more. In consideration of Gleb's technical and community contributions, the
> Beam PMC trusts Gleb with the responsibilities of a Beam committer [1].
>
> Thank you, Gleb, for your contributions.
>
> Kenn
>
> [1] https://beam.apache.org/contribute/become-a-committer/#an-apache-beam-
> committer
>