Re: How to fix libvirt storage pool refresh issue?

2013-08-02 Thread Wei ZHOU
Alex,

Exactly.

We can also use Enable Maintenance - umount nfs point - restart
cloudstack-agent - Cancel Maintenance to solve this issue.

-Wei


2013/8/2 Alex Huang alex.hu...@citrix.com

 So I have very limited knowledge on KVM.  But, from my understanding from
 Edison, we should consider what has to be done to fix this problem once it
 occurs.

 - Shutdown all VMs on all hosts that are affected.
 - umount the nfs mount point
 - Reestablish the storage pool.
 - Restart the VMs.

 Given how severe these actions are to the end user, I would vote for the
 file lock to ensure it never happens, even if it's slower.

 --Alex

  -Original Message-
  From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
  Sent: Tuesday, July 16, 2013 3:35 AM
  To: dev@cloudstack.apache.org
  Subject: Re: How to fix libvirt storage pool refresh issue?
 
  I agree with Wido.
 
  Moreover, the file lock will cause performane degrade of VM deployment.
 
  -Wei
 
 
  2013/7/16 Wido den Hollander w...@widodh.nl
 
   On 07/16/2013 12:27 AM, Marcus Sorensen wrote:
  
   I'm ok with a symptom fix on our end, if the root cause is in
   Libvirt we can't do much about that. This is the sort of patch that
   tends to get pulled into the regular update cycle of the
   distributions, so unless there's more to it and it's not a good fix I
   imagine we will see it come through without having to wait for the
   next point releases. We still have to support existing users who
   might not be running the latest, though, so the symptom fix is
   probably ok as a temporary measure.
  
  
   I'm ok with not calling storagePoolRefresh every time we want a
   capacity update, since that's also kind of I/O intensive for larger
 storage
  arrays.
  
   However, we should make sure we have a GOOD comment in the code
  about
   this fix, since that's the reason I initially removed the old code
   which invoked df.
  
   I'll see if I can get this libvirt patch into Ubuntu when it hits
   libvirt upstream, since this bug is really annoying.
  
   Wido
  
  
  
   On Mon, Jul 15, 2013 at 3:42 PM, Edison Su edison...@citrix.com
 wrote:
  
   There is a serious issue on KVM(https://issues.apache.org/**
   jira/browse/CLOUDSTACK-
  2729https://issues.apache.org/jira/browse/CLOUDSTACK-2729):
   a libvirt storage pool can disappear on KVM host, it's easy to be
   reproduced in our internal QA environment.
   Wei found the root cause, is on the libvirt:
   
   This is a libvirt issue. I created a ticket for it.
   https://bugzilla.redhat.com/**show_bug.cgi?id=977706https://bugzill
   a.redhat.com/show_bug.cgi?id=977706
   The patch is very simple.
   https://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.h
   tmlhttps://www.redhat.com/archives/libvir-list/2013-July/msg00635.h
   tml
   
   But it's also introduced by CloudStack, as cloudstack will call
   libvirt storage pool refresh method each time when access the
   storage pool. The code is added by commit:
   2ffc9907f7b0d371737e39b7649f7a**f23026f5cf,
   about less than one year ago.
  
   As Wei suggested, we can call storage pool refresh only if needed,
   it will mitigate the issue(It's behavior I did on cloudstack
   pre-4.0), but it's only treat the symptom, not the cause.
   Or add a cluster wide lock, only one guy can access storage pool at
   one time, we can add a file lock on NFS primary storage.
   Any idea/feedback on how to fix this KVM issue?
  
  
  
  
  



RE: [Doc] Dedicated Resources: Public IPs and VLANs per Account is Ready

2013-08-02 Thread Likitha Shetty
I just have 2 comments,



1. Since this feature allows the admin to assign (and release) the IP addresses 
and VLANs only to an account, not both domain and account we need to modify the 
introduction accordingly.



2. And could you also add the following to section 15.8,



If an account has consumed all the VLANs and IPs dedicated to it, the account 
can acquire the 2 resources from the system. Cloudstack provides the ROOT admin 
with 2 configuration parameter to modify this default behavior - 
use.system.public.ips and use.system.guest.vlans.

The 2 global configs allow the ROOT admin to disallow an account from acquiring 
public IPs and guest VLANs from the system if the account has dedicated 
resources and these dedicated resources have all been consumed.

Both these configurations are configurable at the account level too. 
(https://issues.apache.org/jira/browse/CLOUDSTACK-3011)



Everything else looks good.



Thanks,

Likitha

From: Radhika Puthiyetath
Sent: Thursday, August 01, 2013 3:51 PM
To: us...@cloudstack.apache.org; dev@cloudstack.apache.org; Abhinav Roy; 
Likitha Shetty
Subject: [Doc] Dedicated Resources: Public IPs and VLANs per Account is Ready

Hi,

Dedicated Resources: Public IPs and VLANs per Account is Ready documentation is 
ready for review. The doc is attached at 
https://issues.apache.org/jira/browse/CLOUDSTACK-817

Please see section 15.8. Reserving Public IP Addresses and VLANs Per Account 
(132), and provide your feedback.

Regards
-Radhika




Re: Review Request 13072: Print agent host name in logging of agent commands

2013-08-02 Thread Chiradeep Vittal
This of course introduces an extra DB call during EVERY agent
communication. 
If there was a cache, not a big deal, but as it so happens, there isn't
one.

On 8/1/13 10:10 PM, Koushik Das koushik@citrix.com wrote:

I see your point Marcus.
I felt that accessing the database would be simpler but you are right
that everyone may not have access to it. Actually the CS logs do mention
the host names as well but in a different place and based on that you can
match the id to a name. For e.g. if you look for agent status logs that
mentions both id and name.

2013-07-29 10:09:47,124 DEBUG [c.c.h.Status] (AgentTaskPool-3:null)
Transition:[Resource state = Enabled, Agent event = Ping, Host id = 1,
name = xenserver-kd1]
2013-07-29 10:09:47,136 DEBUG [c.c.h.Status] (AgentTaskPool-3:null) Agent
status update: [id = 1; name = xenserver-kd1; old status = Up; event =
Ping; new status = Up; old update count = 78; new update count = 79]

2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null) Seq
1-1386348573: Sending  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1,
Flags: 100011, 
[{com.cloud.agent.api.StopCommand:{isProxy:false,executeInSequence:f
alse,vmName:i-2-45-VM,wait:0}}] }
2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null) Seq
1-1386348573: Executing:  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1,
Flags: 100011, 
[{com.cloud.agent.api.StopCommand:{isProxy:false,executeInSequence:f
alse,vmName:i-2-45-VM,wait:0}}] }


The changes you have made would definitely improve the readability.

-Koushik

From: Marcus Sorensen [mailto:shadow...@gmail.com]
Sent: Thursday, August 01, 2013 7:26 PM
To: Koushik Das
Cc: cloudstack
Subject: Re: Review Request 13072: Print agent host name in logging of
agent commands


I agree, that would be useful.

The issue im resolving here is that 1) not everyone who has access to
look at the logs and troubleshoot also has access to (or knows the schema
of) the database. There might be an issue with a KVM host, but the admin
will waste time manually hunting down which host the command went to
because he has no idea what via:1237 means and 2) even with db access,
its a major pain to go hunt down the unencrypted db password(because its
a long string that's hard to memorize), log into the database, run a
query, just to know where to continue your debugging.

A little background: Most of the people who surf these logs aren't devs.
For us they are usually devs, but not cloudstack devs. Maybe UI guys or
some other consumer. It has happened several times where someone comes
into my office, points out an agent command, and says any idea where
that went?. I pretty much have the numbers memorized by now, depending
on the zone, so I tell them which agent the command went to. Then they
ask me where I found that, and when I explain that this little via: 85
means to go log into the db and make an SQL query for vm_instance 85, I
almost always get some gee that's useful, how was I ever supposed to
know that response.

So I do agree that the correlations you mention would also be good, I
disagree with the idea that there is not much value in doing this.
On Aug 1, 2013 6:06 AM, Koushik Das
koushik@citrix.commailto:koushik@citrix.com wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/




The changes look fine but I don't see much value with this as the name
can be easily identified from the db. I feel the logs are used primarily
for debugging issues. And one key aspect that is missing currently is the
correlation of logs. Currently when a API call is made to MS, it
traverses through various layers in the MS and finally hitting the
resource layer and then returns back with response. Logs gets generated
from each layer but it is not very intuitive to relate them to API call.
If there is a unique id (some kind of uuid) that gets appended to the
logs for a specific API call then correlation becomes very easy.



I feel adding these kind of correlation would be much more useful.


- Koushik Das


On July 30th, 2013, 5:37 p.m. UTC, Marcus Sorensen wrote:
Review request for cloudstack.
By Marcus Sorensen.

Updated July 30, 2013, 5:37 p.m.
Bugs: CLOUDSTACK-3872
Repository: cloudstack-git
Description

Print agent name when logging Commands sent to VM hosts. See bug
description.  I'm not super familiar with this code, so I'd like someone
to look over it and verify it's the right thing.


Testing

Tested on KVM zone, need help testing others.


Diffs

  *   core/src/com/cloud/agent/transport/Request.java (b0fa4cc)
  *   server/src/com/cloud/agent/manager/AgentManagerImpl.java (b157838)

View Diffhttps://reviews.apache.org/r/13072/diff/





Can not launch instances on 4.2 today

2013-08-02 Thread Thomas O'Dowd
This was working yesterday but the launching of instances for me on 4.2
is currently not working. I have twice now tried a clean build along
with deploydb and deploysvr in the usual manner but no luck.

On the UI I get: 
Unable to create a deployment for VM[User|tom1]

On the management server output I get.

INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8 = [ 
16ba488a-acbc-4c38-9384-9503123
4b9c8 ]) Unable to contact resource.
com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is 
unreachable: Unable to apply u
serdata and password entry on router
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkAppl
ianceManagerImpl.java:3810)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkA
pplianceManagerImpl.java:2997)
at 
com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElemen
t.java:941)
at 
com.cloud.network.NetworkManagerImpl.prepareElement(NetworkManagerImpl.java:2035)
at 
com.cloud.network.NetworkManagerImpl.prepareNic(NetworkManagerImpl.java:2141)
at 
com.cloud.network.NetworkManagerImpl.prepare(NetworkManagerImpl.java:2082)
at 
com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:932)
at 
com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:624)
at 
org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VM
EntityManagerImpl.java:227)
at 
org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMach
ineEntityImpl.java:209)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3408)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2968)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2954)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:420)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
at 
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)
INFO  [xen.resource.CitrixResourceBase] (DirectAgent-22:) VM does not exist on 
XenServer9d4c9db8-32f7-25c3-0435-eab4bf3adcea
ERROR [network.element.SspElement] (Job-Executor-1:job-8 = [ 
16ba488a-acbc-4c38-9384-95031234b9c8 ]) ReservationContext was null for 
NicProfile[8-3-68dd1f54-5d10-4e4e-9637-59fdc238c8b0-192.168.56.102-vlan://untagged
 Ntwk[204|Guest|6]
WARN  [apache.cloudstack.alerts] (Job-Executor-1:job-8 = [ 
16ba488a-acbc-4c38-9384-95031234b9c8 ])  alertType:: 8 // dataCenterId:: 1 // 
podId:: 1 // clusterId:: null // message:: Failed to deploy Vm with Id: 3, on 
Host with Id: null
INFO  [user.vm.DeployVMCmd] (Job-Executor-1:job-8 = [ 
16ba488a-acbc-4c38-9384-95031234b9c8 ]) 
com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
deployment for VM[User|tom1]Scope=interface com.cloud.dc.DataCenter; id=1
INFO  [user.vm.DeployVMCmd] (Job-Executor-1:job-8 = [ 
16ba488a-acbc-4c38-9384-95031234b9c8 ]) Unable to create a deployment for 
VM[User|tom1]
com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
deployment for VM[User|tom1]Scope=interface com.cloud.dc.DataCenter; id=1
at 
com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:888)
at 
com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:624)
at 
org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VMEntityManagerImpl.java:237)
at 
org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMachineEntityImpl.java:209)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3408)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2968)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2954)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:420)
at 

How to clean deployed system vm on xen host

2013-08-02 Thread Fang Wang
Hi,
I started running MS , host is xen hypervisor. After 2 system vms are up, there 
were issues. So I made changes in source code, rebuild, did deploydb to clean 
DB. 
Now I am running ms again, but failed to bring up ssvm and cpvm, because of the 
existing old system vm from previous run. 

I know for VMware host, I need to clean the old entry thru vcenter.  But not 
familiar with xen host, how do I clean and remove the old system vm on xen 
host? The proper way to do it? Is there a document or link? 

Thanks,
-Fang

Sent from my iPhone

Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Wei Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13223/
---

Review request for cloudstack, edison su and Wido den Hollander.


Bugs: CLOUDSTACK-2729


Repository: cloudstack-git


Description
---

The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt 
(https://bugzilla.redhat.com/show_bug.cgi?id=977706)
We need to prevent deleting a volume when refreshing the pool.
This patch use a simple file lock to implement it.

PS: I have tested another file lock similar to Read/Write file lock, but it was 
very unstable.


Diffs
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
 dae25ae 

Diff: https://reviews.apache.org/r/13223/diff/


Testing
---

Applied on 4.0.2 and 4.0.1

Testing On 4.0.1 From 20,June
3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes 
later. expunge.inteval = 600 (10 minutes), expunge.worker = 2
 

Testing On 4.0.2 From 01,July
2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 minutes 
later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 


Thanks,

Wei Zhou



Re: Can not launch instances on 4.2 today

2013-08-02 Thread Prasanna Santhanam
On devcloud

$ cd /
$ find . -name vmdata.py

Do you see a file by that name anywhere in the XCP plugins? If not -
it failed to copy over into the devcloud plugins for some reason when
adding the host.

On Fri, Aug 02, 2013 at 03:22:20PM +0900, Thomas O'Dowd wrote:
 This was working yesterday but the launching of instances for me on 4.2
 is currently not working. I have twice now tried a clean build along
 with deploydb and deploysvr in the usual manner but no luck.
 
 On the UI I get: 
 Unable to create a deployment for VM[User|tom1]
 
 On the management server output I get.
 
 INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8 = [ 
 16ba488a-acbc-4c38-9384-9503123
 4b9c8 ]) Unable to contact resource.
 com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is 
 unreachable: Unable to apply u
 serdata and password entry on router
 at 
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkAppl
 ianceManagerImpl.java:3810)
 at 
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkA
 pplianceManagerImpl.java:2997)
 at 
 com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElemen
 t.java:941)
 at 
 com.cloud.network.NetworkManagerImpl.prepareElement(NetworkManagerImpl.java:2035)
 at 
 com.cloud.network.NetworkManagerImpl.prepareNic(NetworkManagerImpl.java:2141)
 at 
 com.cloud.network.NetworkManagerImpl.prepare(NetworkManagerImpl.java:2082)
 at 
 com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:932)
 at 
 com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:624)
 at 
 org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VM
 EntityManagerImpl.java:227)
 at 
 org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMach
 ineEntityImpl.java:209)
 at 
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3408)
 at 
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2968)
 at 
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2954)
 at 
 com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
 at 
 org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:420)
 at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
 at 
 com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
 at 
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
 at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
 at java.util.concurrent.FutureTask.run(FutureTask.java:166)
 at 
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:724)
 INFO  [xen.resource.CitrixResourceBase] (DirectAgent-22:) VM does not exist 
 on XenServer9d4c9db8-32f7-25c3-0435-eab4bf3adcea
 ERROR [network.element.SspElement] (Job-Executor-1:job-8 = [ 
 16ba488a-acbc-4c38-9384-95031234b9c8 ]) ReservationContext was null for 
 NicProfile[8-3-68dd1f54-5d10-4e4e-9637-59fdc238c8b0-192.168.56.102-vlan://untagged
  Ntwk[204|Guest|6]
 WARN  [apache.cloudstack.alerts] (Job-Executor-1:job-8 = [ 
 16ba488a-acbc-4c38-9384-95031234b9c8 ])  alertType:: 8 // dataCenterId:: 1 // 
 podId:: 1 // clusterId:: null // message:: Failed to deploy Vm with Id: 3, on 
 Host with Id: null
 INFO  [user.vm.DeployVMCmd] (Job-Executor-1:job-8 = [ 
 16ba488a-acbc-4c38-9384-95031234b9c8 ]) 
 com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
 deployment for VM[User|tom1]Scope=interface com.cloud.dc.DataCenter; id=1
 INFO  [user.vm.DeployVMCmd] (Job-Executor-1:job-8 = [ 
 16ba488a-acbc-4c38-9384-95031234b9c8 ]) Unable to create a deployment for 
 VM[User|tom1]
 com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
 deployment for VM[User|tom1]Scope=interface com.cloud.dc.DataCenter; id=1
 at 
 com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:888)
 at 
 com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:624)
 at 
 org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VMEntityManagerImpl.java:237)
 at 
 org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMachineEntityImpl.java:209)
 at 
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3408)
 at 
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2968)
 at 
 

Re: How to fix libvirt storage pool refresh issue?

2013-08-02 Thread Wei ZHOU
Edison,

Please review the patch: https://reviews.apache.org/r/13223/

-Wei


2013/8/2 Wei ZHOU ustcweiz...@gmail.com

 Alex,

 Exactly.

 We can also use Enable Maintenance - umount nfs point - restart
 cloudstack-agent - Cancel Maintenance to solve this issue.

 -Wei


 2013/8/2 Alex Huang alex.hu...@citrix.com

 So I have very limited knowledge on KVM.  But, from my understanding from
 Edison, we should consider what has to be done to fix this problem once it
 occurs.

 - Shutdown all VMs on all hosts that are affected.
 - umount the nfs mount point
 - Reestablish the storage pool.
 - Restart the VMs.

 Given how severe these actions are to the end user, I would vote for the
 file lock to ensure it never happens, even if it's slower.

 --Alex

  -Original Message-
  From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
  Sent: Tuesday, July 16, 2013 3:35 AM
  To: dev@cloudstack.apache.org
  Subject: Re: How to fix libvirt storage pool refresh issue?
 
  I agree with Wido.
 
  Moreover, the file lock will cause performane degrade of VM deployment.
 
  -Wei
 
 
  2013/7/16 Wido den Hollander w...@widodh.nl
 
   On 07/16/2013 12:27 AM, Marcus Sorensen wrote:
  
   I'm ok with a symptom fix on our end, if the root cause is in
   Libvirt we can't do much about that. This is the sort of patch that
   tends to get pulled into the regular update cycle of the
   distributions, so unless there's more to it and it's not a good fix I
   imagine we will see it come through without having to wait for the
   next point releases. We still have to support existing users who
   might not be running the latest, though, so the symptom fix is
   probably ok as a temporary measure.
  
  
   I'm ok with not calling storagePoolRefresh every time we want a
   capacity update, since that's also kind of I/O intensive for larger
 storage
  arrays.
  
   However, we should make sure we have a GOOD comment in the code
  about
   this fix, since that's the reason I initially removed the old code
   which invoked df.
  
   I'll see if I can get this libvirt patch into Ubuntu when it hits
   libvirt upstream, since this bug is really annoying.
  
   Wido
  
  
  
   On Mon, Jul 15, 2013 at 3:42 PM, Edison Su edison...@citrix.com
 wrote:
  
   There is a serious issue on KVM(https://issues.apache.org/**
   jira/browse/CLOUDSTACK-
  2729https://issues.apache.org/jira/browse/CLOUDSTACK-2729):
   a libvirt storage pool can disappear on KVM host, it's easy to be
   reproduced in our internal QA environment.
   Wei found the root cause, is on the libvirt:
   
   This is a libvirt issue. I created a ticket for it.
   https://bugzilla.redhat.com/**show_bug.cgi?id=977706
 https://bugzill
   a.redhat.com/show_bug.cgi?id=977706
   The patch is very simple.
  
 https://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.h
   tml
 https://www.redhat.com/archives/libvir-list/2013-July/msg00635.h
   tml
   
   But it's also introduced by CloudStack, as cloudstack will call
   libvirt storage pool refresh method each time when access the
   storage pool. The code is added by commit:
   2ffc9907f7b0d371737e39b7649f7a**f23026f5cf,
   about less than one year ago.
  
   As Wei suggested, we can call storage pool refresh only if needed,
   it will mitigate the issue(It's behavior I did on cloudstack
   pre-4.0), but it's only treat the symptom, not the cause.
   Or add a cluster wide lock, only one guy can access storage pool at
   one time, we can add a file lock on NFS primary storage.
   Any idea/feedback on how to fix this KVM issue?
  
  
  
  
  





Re: How to clean deployed system vm on xen host

2013-08-02 Thread Prasanna Santhanam
On your xen host
$ xe vm-uninstall --force --multiple

And reconnect the MS again, it should kick in HA for systemVMs and
restart them.

On Fri, Aug 02, 2013 at 06:36:09AM +, Fang Wang wrote:
 Hi,
 I started running MS , host is xen hypervisor. After 2 system vms are up, 
 there were issues. So I made changes in source code, rebuild, did deploydb to 
 clean DB. 
 Now I am running ms again, but failed to bring up ssvm and cpvm, because of 
 the existing old system vm from previous run. 
 
 I know for VMware host, I need to clean the old entry thru vcenter.  But not 
 familiar with xen host, how do I clean and remove the old system vm on xen 
 host? The proper way to do it? Is there a document or link? 
 
 Thanks,
 -Fang
 
 Sent from my iPhone

-- 
Prasanna.,


Powered by BigRock.com



Re: Can not launch instances on 4.2 today

2013-08-02 Thread Thomas O'Dowd
Hi Prasanna,

I've just finished re-initializing a brand new devcloud and am about to
start things up again.

root@devcloud:~# find / -name vmdata.py
root@devcloud:~# 

Maybe it was there before in my previous install. How would it be copied
to devcloud usually? For example for the s3xen plugin I need to manually
copy it over myself to the xcp plugins directory. Then again I can't
imagine why it went missing since yesterday from my previous devcloud.

Tom.

On Fri, 2013-08-02 at 12:17 +0530, Prasanna Santhanam wrote:
 On devcloud
 
 $ cd /
 $ find . -name vmdata.py
 
 Do you see a file by that name anywhere in the XCP plugins? If not -
 it failed to copy over into the devcloud plugins for some reason when
 adding the host.
 
 On Fri, Aug 02, 2013 at 03:22:20PM +0900, Thomas O'Dowd wrote:
  This was working yesterday but the launching of instances for me on 4.2
  is currently not working. I have twice now tried a clean build along
  with deploydb and deploysvr in the usual manner but no luck.
  
  On the UI I get: 
  Unable to create a deployment for VM[User|tom1]
  
  On the management server output I get.
  
  INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8 = [ 
  16ba488a-acbc-4c38-9384-9503123
  4b9c8 ]) Unable to contact resource.
  com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is 
  unreachable: Unable to apply u
  serdata and password entry on router
  at 
  com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkAppl
  ianceManagerImpl.java:3810)
  at 
  com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkA
  pplianceManagerImpl.java:2997)
  at 
  com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElemen
  t.java:941)
  at 
  com.cloud.network.NetworkManagerImpl.prepareElement(NetworkManagerImpl.java:2035)
  at 
  com.cloud.network.NetworkManagerImpl.prepareNic(NetworkManagerImpl.java:2141)
  at 
  com.cloud.network.NetworkManagerImpl.prepare(NetworkManagerImpl.java:2082)
  at 
  com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:932)
  at 
  com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:624)
  at 
  org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VM
  EntityManagerImpl.java:227)
  at 
  org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMach
  ineEntityImpl.java:209)
  at 
  com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3408)
  at 
  com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2968)
  at 
  com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2954)
  at 
  com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
  at 
  org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:420)
  at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
  at 
  com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
  at 
  java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
  at 
  java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
  at java.util.concurrent.FutureTask.run(FutureTask.java:166)
  at 
  java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
  at 
  java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
  at java.lang.Thread.run(Thread.java:724)
  INFO  [xen.resource.CitrixResourceBase] (DirectAgent-22:) VM does not exist 
  on XenServer9d4c9db8-32f7-25c3-0435-eab4bf3adcea
  ERROR [network.element.SspElement] (Job-Executor-1:job-8 = [ 
  16ba488a-acbc-4c38-9384-95031234b9c8 ]) ReservationContext was null for 
  NicProfile[8-3-68dd1f54-5d10-4e4e-9637-59fdc238c8b0-192.168.56.102-vlan://untagged
   Ntwk[204|Guest|6]
  WARN  [apache.cloudstack.alerts] (Job-Executor-1:job-8 = [ 
  16ba488a-acbc-4c38-9384-95031234b9c8 ])  alertType:: 8 // dataCenterId:: 1 
  // podId:: 1 // clusterId:: null // message:: Failed to deploy Vm with Id: 
  3, on Host with Id: null
  INFO  [user.vm.DeployVMCmd] (Job-Executor-1:job-8 = [ 
  16ba488a-acbc-4c38-9384-95031234b9c8 ]) 
  com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
  deployment for VM[User|tom1]Scope=interface com.cloud.dc.DataCenter; id=1
  INFO  [user.vm.DeployVMCmd] (Job-Executor-1:job-8 = [ 
  16ba488a-acbc-4c38-9384-95031234b9c8 ]) Unable to create a deployment for 
  VM[User|tom1]
  com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
  deployment for VM[User|tom1]Scope=interface com.cloud.dc.DataCenter; id=1
  at 
  

[Doc] Multiple IP Address per NIC for Review

2013-08-02 Thread Radhika Puthiyetath
Hi,

Multiple IP Address per NIC documentation is ready for review. The doc is 
attached at https://issues.apache.org/jira/browse/CLOUDSTACK-809.

Please see 15.9. Configuring Multiple IP Addresses on a Single NIC  (134), and 
provide your feedback.

Regards
-Radhika




Re: Can not launch instances on 4.2 today

2013-08-02 Thread Prasanna Santhanam
Yeah this was a recent change that Marcus made to optimize the vmdata
passed to guests. I'll verify why the change is not working shortly.
Running some other tests at the moment on my setup.

Meanwhile, Could you manually copy that to where you see the s3xen
plugin and retry?


On Fri, Aug 02, 2013 at 03:57:58PM +0900, Thomas O'Dowd wrote:
 Hi Prasanna,
 
 I've just finished re-initializing a brand new devcloud and am about to
 start things up again.
 
 root@devcloud:~# find / -name vmdata.py
 root@devcloud:~# 
 
 Maybe it was there before in my previous install. How would it be copied
 to devcloud usually? For example for the s3xen plugin I need to manually
 copy it over myself to the xcp plugins directory. Then again I can't
 imagine why it went missing since yesterday from my previous devcloud.
 
 Tom.
 
 On Fri, 2013-08-02 at 12:17 +0530, Prasanna Santhanam wrote:
  On devcloud
  
  $ cd /
  $ find . -name vmdata.py
  
  Do you see a file by that name anywhere in the XCP plugins? If not -
  it failed to copy over into the devcloud plugins for some reason when
  adding the host.
  
  On Fri, Aug 02, 2013 at 03:22:20PM +0900, Thomas O'Dowd wrote:
   This was working yesterday but the launching of instances for me on 4.2
   is currently not working. I have twice now tried a clean build along
   with deploydb and deploysvr in the usual manner but no luck.
   
   On the UI I get: 
   Unable to create a deployment for VM[User|tom1]
   
   On the management server output I get.
   
   INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8 = [ 
   16ba488a-acbc-4c38-9384-9503123
   4b9c8 ]) Unable to contact resource.
   com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is 
   unreachable: Unable to apply u
   serdata and password entry on router
   at 
   com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkAppl
   ianceManagerImpl.java:3810)
   at 
   com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkA
   pplianceManagerImpl.java:2997)
   at 
   com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElemen
   t.java:941)
   at 
   com.cloud.network.NetworkManagerImpl.prepareElement(NetworkManagerImpl.java:2035)
   at 
   com.cloud.network.NetworkManagerImpl.prepareNic(NetworkManagerImpl.java:2141)
   at 
   com.cloud.network.NetworkManagerImpl.prepare(NetworkManagerImpl.java:2082)
   at 
   com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:932)
   at 
   com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:624)
   at 
   org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VM
   EntityManagerImpl.java:227)
   at 
   org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMach
   ineEntityImpl.java:209)
   at 
   com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3408)
   at 
   com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2968)
   at 
   com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2954)
   at 
   com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
   at 
   org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:420)
   at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
   at 
   com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
   at 
   java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
   at 
   java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
   at java.util.concurrent.FutureTask.run(FutureTask.java:166)
   at 
   java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
   at 
   java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
   at java.lang.Thread.run(Thread.java:724)
   INFO  [xen.resource.CitrixResourceBase] (DirectAgent-22:) VM does not 
   exist on XenServer9d4c9db8-32f7-25c3-0435-eab4bf3adcea
   ERROR [network.element.SspElement] (Job-Executor-1:job-8 = [ 
   16ba488a-acbc-4c38-9384-95031234b9c8 ]) ReservationContext was null for 
   NicProfile[8-3-68dd1f54-5d10-4e4e-9637-59fdc238c8b0-192.168.56.102-vlan://untagged
Ntwk[204|Guest|6]
   WARN  [apache.cloudstack.alerts] (Job-Executor-1:job-8 = [ 
   16ba488a-acbc-4c38-9384-95031234b9c8 ])  alertType:: 8 // dataCenterId:: 
   1 // podId:: 1 // clusterId:: null // message:: Failed to deploy Vm with 
   Id: 3, on Host with Id: null
   INFO  [user.vm.DeployVMCmd] (Job-Executor-1:job-8 = [ 
   16ba488a-acbc-4c38-9384-95031234b9c8 ]) 
   com.cloud.exception.InsufficientServerCapacityException: Unable to create 

Re: Can not launch instances on 4.2 today

2013-08-02 Thread Thomas O'Dowd
Ok. I've just copied it over. Its the only one that ends with .py and
I've chmod'd it to 755 also.

Will check it shortly. I'm building.

Tom.

root@devcloud:~# ls -l /usr/lib/xcp/plugins/
total 164
-rwxrwxrwx 1 root root  8304 Nov  5  2012 coalesce-leaf
-rwxrwxrwx 1 root root   301 Nov 27  2012 echo
-rwxrwxrwx 1 root root  1660 Nov  5  2012 lvhd-thin
-rwxrwxrwx 1 root root  1873 Nov  5  2012 nfs-on-slave
-rwxrwxrwx 1 root root  2289 Nov  5  2012 on-slave
-rwxr-xr-x 1 root root 10327 Jan  7  2013 ovstunnel
-rwxr-xr-x 1 root root 10059 Aug  2 06:48 s3xen
-rwxrwxrwx 1 root root  5386 Nov  5  2012 tapdisk-pause
-rwxrwxrwx 1 root root   517 Nov  5  2012 testing-hooks
-rwxr-xr-x 1 root root  6200 Aug  2 07:29 vmdata.py
-rwxr-xr-x 1 root root 55574 Jan  7  2013 vmops
-rwxr-xr-x 1 root root  4434 Jan  7  2013 vmopspremium
-rwxr-xr-x 1 root root 20967 Jan  7  2013 vmopsSnapshot
-rwxrwxrwx 1 root root  2754 Nov  5  2012 vss_control


On Fri, 2013-08-02 at 12:34 +0530, Prasanna Santhanam wrote:
 Yeah this was a recent change that Marcus made to optimize the vmdata
 passed to guests. I'll verify why the change is not working shortly.
 Running some other tests at the moment on my setup.
 
 Meanwhile, Could you manually copy that to where you see the s3xen
 plugin and retry?
 
 
 On Fri, Aug 02, 2013 at 03:57:58PM +0900, Thomas O'Dowd wrote:
  Hi Prasanna,
  
  I've just finished re-initializing a brand new devcloud and am about to
  start things up again.
  
  root@devcloud:~# find / -name vmdata.py
  root@devcloud:~# 
  
  Maybe it was there before in my previous install. How would it be copied
  to devcloud usually? For example for the s3xen plugin I need to manually
  copy it over myself to the xcp plugins directory. Then again I can't
  imagine why it went missing since yesterday from my previous devcloud.
  
  Tom.
  
  On Fri, 2013-08-02 at 12:17 +0530, Prasanna Santhanam wrote:
   On devcloud
   
   $ cd /
   $ find . -name vmdata.py
   
   Do you see a file by that name anywhere in the XCP plugins? If not -
   it failed to copy over into the devcloud plugins for some reason when
   adding the host.
   
   On Fri, Aug 02, 2013 at 03:22:20PM +0900, Thomas O'Dowd wrote:
This was working yesterday but the launching of instances for me on 4.2
is currently not working. I have twice now tried a clean build along
with deploydb and deploysvr in the usual manner but no luck.

On the UI I get: 
Unable to create a deployment for VM[User|tom1]

On the management server output I get.

INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8 = [ 
16ba488a-acbc-4c38-9384-9503123
4b9c8 ]) Unable to contact resource.
com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is 
unreachable: Unable to apply u
serdata and password entry on router
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkAppl
ianceManagerImpl.java:3810)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkA
pplianceManagerImpl.java:2997)
at 
com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElemen
t.java:941)
at 
com.cloud.network.NetworkManagerImpl.prepareElement(NetworkManagerImpl.java:2035)
at 
com.cloud.network.NetworkManagerImpl.prepareNic(NetworkManagerImpl.java:2141)
at 
com.cloud.network.NetworkManagerImpl.prepare(NetworkManagerImpl.java:2082)
at 
com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:932)
at 
com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:624)
at 
org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VM
EntityManagerImpl.java:227)
at 
org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMach
ineEntityImpl.java:209)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3408)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2968)
at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2954)
at 
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at 
org.apache.cloudstack.api.command.user.vm.DeployVMCmd.execute(DeployVMCmd.java:420)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
at 
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at 
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at 

Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13223/#review24511
---


Review 13223 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #104 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/104/

- Jenkins Cloudstack.org


On Aug. 2, 2013, 6:39 a.m., Wei Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13223/
 ---
 
 (Updated Aug. 2, 2013, 6:39 a.m.)
 
 
 Review request for cloudstack, edison su and Wido den Hollander.
 
 
 Bugs: CLOUDSTACK-2729
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt 
 (https://bugzilla.redhat.com/show_bug.cgi?id=977706)
 We need to prevent deleting a volume when refreshing the pool.
 This patch use a simple file lock to implement it.
 
 PS: I have tested another file lock similar to Read/Write file lock, but it 
 was very unstable.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
  dae25ae 
 
 Diff: https://reviews.apache.org/r/13223/diff/
 
 
 Testing
 ---
 
 Applied on 4.0.2 and 4.0.1
 
 Testing On 4.0.1 From 20,June
 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes 
 later. expunge.inteval = 600 (10 minutes), expunge.worker = 2
  
 
 Testing On 4.0.2 From 01,July
 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 
 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 
 
 
 Thanks,
 
 Wei Zhou
 




Re: Unable to start domR(VR) in devcloud using laster 4.1/master.

2013-08-02 Thread Nguyen Anh Tu
Hi guys,

So how to fix this? I got the same error

Thanks,


2013/4/1 Rajesh Battala rajesh.batt...@citrix.com

 I had debugged and found that from devcloud unable to ssh to the router
 vm. When it tries to execute the GetDomRVersionCmd its getting failing and
 router vm is getting destroyed.

 I had tried manually  ssh to router vm am getting Permission denied
 (publickey)

 I had tried changing the permission of my ssh folder and keys, still the
 same issue.
 -rw--- 1 root root 1674 Apr  1 15:38 id_rsa.cloud
 -rw--- 1 root root  394 Apr  1 15:38 id_rsa.cloud.pub
 -rw--- 1 root root  884 Apr  1 15:51 known_hosts

 How to resolve this issue?

 Here is the output of ssh with verbose mode. Am using devCloud with
 xenserver

 ssh -i .ssh/id_rsa.cloud -p 3922 169.254.0.105
 Permission denied (publickey).
 root@devcloud:~# ssh -vvv -i .ssh/id_rsa.cloud -p 3922 169.254.0.105
 OpenSSH_6.0p1 Debian-4, OpenSSL 1.0.1c 10 May 2012
 debug1: Reading configuration data /etc/ssh/ssh_config
 debug1: /etc/ssh/ssh_config line 19: Applying options for *
 debug2: ssh_connect: needpriv 0
 debug1: Connecting to 169.254.0.105 [169.254.0.105] port 3922.
 debug1: Connection established.
 debug1: permanently_set_uid: 0/0
 debug3: Incorrect RSA1 identifier
 debug3: Could not load .ssh/id_rsa.cloud as a RSA1 public key
 debug1: identity file .ssh/id_rsa.cloud type 1
 debug1: Checking blacklist file /usr/share/ssh/blacklist.RSA-2048
 debug1: Checking blacklist file /etc/ssh/blacklist.RSA-2048
 debug1: identity file .ssh/id_rsa.cloud-cert type -1
 debug1: Remote protocol version 2.0, remote software version OpenSSH_5.5p1
 Debian-6+squeeze1
 debug1: match: OpenSSH_5.5p1 Debian-6+squeeze1 pat OpenSSH_5*
 debug1: Enabling compatibility mode for protocol 2.0
 debug1: Local version string SSH-2.0-OpenSSH_6.0p1 Debian-4
 debug2: fd 3 setting O_NONBLOCK
 debug3: put_host_port: [169.254.0.105]:3922
 debug3: load_hostkeys: loading entries for host [169.254.0.105]:3922
 from file /root/.ssh/known_hosts 
 debug3: load_hostkeys: found key type RSA in file /root/.ssh/known_hosts:1
 debug3: load_hostkeys: loaded 1 keys
 debug3: order_hostkeyalgs: prefer hostkeyalgs:
 ssh-rsa-cert-...@openssh.com,ssh-rsa-cert-...@openssh.com,ssh-rsa
 debug1: SSH2_MSG_KEXINIT sent
 debug1: SSH2_MSG_KEXINIT received
 debug2: kex_parse_kexinit:
 ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group-exchange-sha1,diffie-hellman-group14-sha1,diffie-hellman-group1-sh

  a1
 debug2: kex_parse_kexinit: ssh-rsa-cert-...@openssh.com,
 ssh-rsa-cert-...@openssh.com,ssh-rsa,
 ecdsa-sha2-nistp256-cert-...@openssh.com,
 ecdsa-sha2-nistp384-cert-...@openssh.com,ecdsa-sha2-nistp521-cert-v01@open
  ssh.com,ssh-dss-cert-...@openssh.com,ssh-dss-cert-...@openssh.com
 ,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,ssh-dss
 debug2: kex_parse_kexinit:
 aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cbc,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,
 rijndael-...@lysator.liu.se
 debug2: kex_parse_kexinit:
 aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cbc,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,
 rijndael-...@lysator.liu.se
 debug2: kex_parse_kexinit: hmac-md5,hmac-sha1,umac...@openssh.com
 ,hmac-sha2-256,hmac-sha2-256-96,hmac-sha2-512,hmac-sha2-512-96,hmac-ripemd160,
 hmac-ripemd...@openssh.com,hmac-sha1-96,hmac-md5-96
 debug2: kex_parse_kexinit: hmac-md5,hmac-sha1,umac...@openssh.com
 ,hmac-sha2-256,hmac-sha2-256-96,hmac-sha2-512,hmac-sha2-512-96,hmac-ripemd160,
 hmac-ripemd...@openssh.com,hmac-sha1-96,hmac-md5-96
 debug2: kex_parse_kexinit: none,z...@openssh.com,zlib
 debug2: kex_parse_kexinit: none,z...@openssh.com,zlib
 debug2: kex_parse_kexinit:
 debug2: kex_parse_kexinit:
 debug2: kex_parse_kexinit: first_kex_follows 0
 debug2: kex_parse_kexinit: reserved 0
 debug2: kex_parse_kexinit:
 diffie-hellman-group-exchange-sha256,diffie-hellman-group-exchange-sha1,diffie-hellman-group14-sha1,diffie-hellman-group1-sha1
 debug2: kex_parse_kexinit: ssh-rsa,ssh-dss
 debug2: kex_parse_kexinit:
 aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cbc,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,
 rijndael-...@lysator.liu.se
 debug2: kex_parse_kexinit:
 aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cbc,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,
 rijndael-...@lysator.liu.se
 debug2: kex_parse_kexinit: hmac-md5,hmac-sha1,umac...@openssh.com
 ,hmac-ripemd160,hmac-ripemd160@openssh. com,hmac-sha1-96,hmac-md5-96
 debug2: kex_parse_kexinit: hmac-md5,hmac-sha1,umac...@openssh.com
 ,hmac-ripemd160,hmac-ripemd160@openssh. com,hmac-sha1-96,hmac-md5-96
 debug2: kex_parse_kexinit: none,z...@openssh.com
 debug2: kex_parse_kexinit: none,z...@openssh.com
 debug2: kex_parse_kexinit:
 debug2: kex_parse_kexinit:
 debug2: kex_parse_kexinit: first_kex_follows 0
 debug2: 

Re: Can not launch instances on 4.2 today

2013-08-02 Thread Thomas O'Dowd
Prasanna,

when I first ran deploysvr after a new database install, I had quite a
lot of starting and crashing of the system vms (which seems new to me)
but I waited and it settled down.

I was then able to launch an instance again after the usual other steps.
The instance now tells me the password in a pop up box which is also
new.

Anyway, thanks again for your help!

Tom.

On Fri, 2013-08-02 at 16:31 +0900, Thomas O'Dowd wrote:
 Ok. I've just copied it over. Its the only one that ends with .py and
 I've chmod'd it to 755 also.
 
 Will check it shortly. I'm building.
 
 Tom.
 
 root@devcloud:~# ls -l /usr/lib/xcp/plugins/
 total 164
 -rwxrwxrwx 1 root root  8304 Nov  5  2012 coalesce-leaf
 -rwxrwxrwx 1 root root   301 Nov 27  2012 echo
 -rwxrwxrwx 1 root root  1660 Nov  5  2012 lvhd-thin
 -rwxrwxrwx 1 root root  1873 Nov  5  2012 nfs-on-slave
 -rwxrwxrwx 1 root root  2289 Nov  5  2012 on-slave
 -rwxr-xr-x 1 root root 10327 Jan  7  2013 ovstunnel
 -rwxr-xr-x 1 root root 10059 Aug  2 06:48 s3xen
 -rwxrwxrwx 1 root root  5386 Nov  5  2012 tapdisk-pause
 -rwxrwxrwx 1 root root   517 Nov  5  2012 testing-hooks
 -rwxr-xr-x 1 root root  6200 Aug  2 07:29 vmdata.py
 -rwxr-xr-x 1 root root 55574 Jan  7  2013 vmops
 -rwxr-xr-x 1 root root  4434 Jan  7  2013 vmopspremium
 -rwxr-xr-x 1 root root 20967 Jan  7  2013 vmopsSnapshot
 -rwxrwxrwx 1 root root  2754 Nov  5  2012 vss_control
 
 
 On Fri, 2013-08-02 at 12:34 +0530, Prasanna Santhanam wrote:
  Yeah this was a recent change that Marcus made to optimize the vmdata
  passed to guests. I'll verify why the change is not working shortly.
  Running some other tests at the moment on my setup.
  
  Meanwhile, Could you manually copy that to where you see the s3xen
  plugin and retry?
  
  
  On Fri, Aug 02, 2013 at 03:57:58PM +0900, Thomas O'Dowd wrote:
   Hi Prasanna,
   
   I've just finished re-initializing a brand new devcloud and am about to
   start things up again.
   
   root@devcloud:~# find / -name vmdata.py
   root@devcloud:~# 
   
   Maybe it was there before in my previous install. How would it be copied
   to devcloud usually? For example for the s3xen plugin I need to manually
   copy it over myself to the xcp plugins directory. Then again I can't
   imagine why it went missing since yesterday from my previous devcloud.
   
   Tom.
   
   On Fri, 2013-08-02 at 12:17 +0530, Prasanna Santhanam wrote:
On devcloud

$ cd /
$ find . -name vmdata.py

Do you see a file by that name anywhere in the XCP plugins? If not -
it failed to copy over into the devcloud plugins for some reason when
adding the host.

On Fri, Aug 02, 2013 at 03:22:20PM +0900, Thomas O'Dowd wrote:
 This was working yesterday but the launching of instances for me on 
 4.2
 is currently not working. I have twice now tried a clean build along
 with deploydb and deploysvr in the usual manner but no luck.
 
 On the UI I get: 
 Unable to create a deployment for VM[User|tom1]
 
 On the management server output I get.
 
 INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8 = [ 
 16ba488a-acbc-4c38-9384-9503123
 4b9c8 ]) Unable to contact resource.
 com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] is 
 unreachable: Unable to apply u
 serdata and password entry on router
 at 
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkAppl
 ianceManagerImpl.java:3810)
 at 
 com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkA
 pplianceManagerImpl.java:2997)
 at 
 com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElemen
 t.java:941)
 at 
 com.cloud.network.NetworkManagerImpl.prepareElement(NetworkManagerImpl.java:2035)
 at 
 com.cloud.network.NetworkManagerImpl.prepareNic(NetworkManagerImpl.java:2141)
 at 
 com.cloud.network.NetworkManagerImpl.prepare(NetworkManagerImpl.java:2082)
 at 
 com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:932)
 at 
 com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:624)
 at 
 org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.deployVirtualMachine(VM
 EntityManagerImpl.java:227)
 at 
 org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.deploy(VirtualMach
 ineEntityImpl.java:209)
 at 
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:3408)
 at 
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2968)
 at 
 com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:2954)
 at 
 

Re: Can not launch instances on 4.2 today

2013-08-02 Thread Prasanna Santhanam
I made a mistake - the vmdata goes into the router deployed by
cloudstack but is called by the router_proxy.sh script within the
/usr/lib/xcp directory of the host over ssh.

root@r-5-VM:/# find . -name vmdata.py
./opt/cloud/bin/vmdata.py

The tests are passing now and VM deploy works fine:

nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/smoke/test_vm_life_cycle.py --load -a tags=devcloud
Test Deploy Virtual Machine ... ok
Test Stop Virtual Machine ... ok
Test Start Virtual Machine ... ok
Test Reboot Virtual Machine ... ok
Test destroy Virtual Machine ... ok
Test recover Virtual Machine ... ok
Test destroy(expunge) Virtual Machine ... ok

--
Ran 7 tests in 287.641s

OK

On Fri, Aug 02, 2013 at 05:33:20PM +0900, Thomas O'Dowd wrote:
 Prasanna,
 
 when I first ran deploysvr after a new database install, I had quite a
 lot of starting and crashing of the system vms (which seems new to me)
 but I waited and it settled down.
 
 I was then able to launch an instance again after the usual other steps.
 The instance now tells me the password in a pop up box which is also
 new.
 
 Anyway, thanks again for your help!
 
 Tom.
 
 On Fri, 2013-08-02 at 16:31 +0900, Thomas O'Dowd wrote:
  Ok. I've just copied it over. Its the only one that ends with .py and
  I've chmod'd it to 755 also.
  
  Will check it shortly. I'm building.
  
  Tom.
  
  root@devcloud:~# ls -l /usr/lib/xcp/plugins/
  total 164
  -rwxrwxrwx 1 root root  8304 Nov  5  2012 coalesce-leaf
  -rwxrwxrwx 1 root root   301 Nov 27  2012 echo
  -rwxrwxrwx 1 root root  1660 Nov  5  2012 lvhd-thin
  -rwxrwxrwx 1 root root  1873 Nov  5  2012 nfs-on-slave
  -rwxrwxrwx 1 root root  2289 Nov  5  2012 on-slave
  -rwxr-xr-x 1 root root 10327 Jan  7  2013 ovstunnel
  -rwxr-xr-x 1 root root 10059 Aug  2 06:48 s3xen
  -rwxrwxrwx 1 root root  5386 Nov  5  2012 tapdisk-pause
  -rwxrwxrwx 1 root root   517 Nov  5  2012 testing-hooks
  -rwxr-xr-x 1 root root  6200 Aug  2 07:29 vmdata.py
  -rwxr-xr-x 1 root root 55574 Jan  7  2013 vmops
  -rwxr-xr-x 1 root root  4434 Jan  7  2013 vmopspremium
  -rwxr-xr-x 1 root root 20967 Jan  7  2013 vmopsSnapshot
  -rwxrwxrwx 1 root root  2754 Nov  5  2012 vss_control
  
  
  On Fri, 2013-08-02 at 12:34 +0530, Prasanna Santhanam wrote:
   Yeah this was a recent change that Marcus made to optimize the vmdata
   passed to guests. I'll verify why the change is not working shortly.
   Running some other tests at the moment on my setup.
   
   Meanwhile, Could you manually copy that to where you see the s3xen
   plugin and retry?
   
   
   On Fri, Aug 02, 2013 at 03:57:58PM +0900, Thomas O'Dowd wrote:
Hi Prasanna,

I've just finished re-initializing a brand new devcloud and am about to
start things up again.

root@devcloud:~# find / -name vmdata.py
root@devcloud:~# 

Maybe it was there before in my previous install. How would it be copied
to devcloud usually? For example for the s3xen plugin I need to manually
copy it over myself to the xcp plugins directory. Then again I can't
imagine why it went missing since yesterday from my previous devcloud.

Tom.

On Fri, 2013-08-02 at 12:17 +0530, Prasanna Santhanam wrote:
 On devcloud
 
 $ cd /
 $ find . -name vmdata.py
 
 Do you see a file by that name anywhere in the XCP plugins? If not -
 it failed to copy over into the devcloud plugins for some reason when
 adding the host.
 
 On Fri, Aug 02, 2013 at 03:22:20PM +0900, Thomas O'Dowd wrote:
  This was working yesterday but the launching of instances for me on 
  4.2
  is currently not working. I have twice now tried a clean build along
  with deploydb and deploysvr in the usual manner but no luck.
  
  On the UI I get: 
  Unable to create a deployment for VM[User|tom1]
  
  On the management server output I get.
  
  INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8 = 
  [ 16ba488a-acbc-4c38-9384-9503123
  4b9c8 ]) Unable to contact resource.
  com.cloud.exception.ResourceUnavailableException: Resource [Pod:1] 
  is unreachable: Unable to apply u
  serdata and password entry on router
  at 
  com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkAppl
  ianceManagerImpl.java:3810)
  at 
  com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkA
  pplianceManagerImpl.java:2997)
  at 
  com.cloud.network.element.VirtualRouterElement.addPasswordAndUserdata(VirtualRouterElemen
  t.java:941)
  at 
  com.cloud.network.NetworkManagerImpl.prepareElement(NetworkManagerImpl.java:2035)
  at 
  com.cloud.network.NetworkManagerImpl.prepareNic(NetworkManagerImpl.java:2141)
  at 
  

Re: Can not launch instances on 4.2 today

2013-08-02 Thread Thomas O'Dowd
Thanks Prasanna,

I've confirmed that the vmdata.py is on the router vm.

root@r-7-VM:~# find / -name vmdata.py
/opt/cloud/bin/vmdata.py

Maybe some other commit fixed the problem at the same time for me.

Tom.

On Fri, 2013-08-02 at 14:42 +0530, Prasanna Santhanam wrote:
 I made a mistake - the vmdata goes into the router deployed by
 cloudstack but is called by the router_proxy.sh script within the
 /usr/lib/xcp directory of the host over ssh.
 
 root@r-5-VM:/# find . -name vmdata.py
 ./opt/cloud/bin/vmdata.py
 
 The tests are passing now and VM deploy works fine:
 
 nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg 
 test/integration/smoke/test_vm_life_cycle.py --load -a tags=devcloud
 Test Deploy Virtual Machine ... ok
 Test Stop Virtual Machine ... ok
 Test Start Virtual Machine ... ok
 Test Reboot Virtual Machine ... ok
 Test destroy Virtual Machine ... ok
 Test recover Virtual Machine ... ok
 Test destroy(expunge) Virtual Machine ... ok
 
 --
 Ran 7 tests in 287.641s
 
 OK
 
 On Fri, Aug 02, 2013 at 05:33:20PM +0900, Thomas O'Dowd wrote:
  Prasanna,
  
  when I first ran deploysvr after a new database install, I had quite a
  lot of starting and crashing of the system vms (which seems new to me)
  but I waited and it settled down.
  
  I was then able to launch an instance again after the usual other steps.
  The instance now tells me the password in a pop up box which is also
  new.
  
  Anyway, thanks again for your help!
  
  Tom.
  
  On Fri, 2013-08-02 at 16:31 +0900, Thomas O'Dowd wrote:
   Ok. I've just copied it over. Its the only one that ends with .py and
   I've chmod'd it to 755 also.
   
   Will check it shortly. I'm building.
   
   Tom.
   
   root@devcloud:~# ls -l /usr/lib/xcp/plugins/
   total 164
   -rwxrwxrwx 1 root root  8304 Nov  5  2012 coalesce-leaf
   -rwxrwxrwx 1 root root   301 Nov 27  2012 echo
   -rwxrwxrwx 1 root root  1660 Nov  5  2012 lvhd-thin
   -rwxrwxrwx 1 root root  1873 Nov  5  2012 nfs-on-slave
   -rwxrwxrwx 1 root root  2289 Nov  5  2012 on-slave
   -rwxr-xr-x 1 root root 10327 Jan  7  2013 ovstunnel
   -rwxr-xr-x 1 root root 10059 Aug  2 06:48 s3xen
   -rwxrwxrwx 1 root root  5386 Nov  5  2012 tapdisk-pause
   -rwxrwxrwx 1 root root   517 Nov  5  2012 testing-hooks
   -rwxr-xr-x 1 root root  6200 Aug  2 07:29 vmdata.py
   -rwxr-xr-x 1 root root 55574 Jan  7  2013 vmops
   -rwxr-xr-x 1 root root  4434 Jan  7  2013 vmopspremium
   -rwxr-xr-x 1 root root 20967 Jan  7  2013 vmopsSnapshot
   -rwxrwxrwx 1 root root  2754 Nov  5  2012 vss_control
   
   
   On Fri, 2013-08-02 at 12:34 +0530, Prasanna Santhanam wrote:
Yeah this was a recent change that Marcus made to optimize the vmdata
passed to guests. I'll verify why the change is not working shortly.
Running some other tests at the moment on my setup.

Meanwhile, Could you manually copy that to where you see the s3xen
plugin and retry?


On Fri, Aug 02, 2013 at 03:57:58PM +0900, Thomas O'Dowd wrote:
 Hi Prasanna,
 
 I've just finished re-initializing a brand new devcloud and am about 
 to
 start things up again.
 
 root@devcloud:~# find / -name vmdata.py
 root@devcloud:~# 
 
 Maybe it was there before in my previous install. How would it be 
 copied
 to devcloud usually? For example for the s3xen plugin I need to 
 manually
 copy it over myself to the xcp plugins directory. Then again I can't
 imagine why it went missing since yesterday from my previous devcloud.
 
 Tom.
 
 On Fri, 2013-08-02 at 12:17 +0530, Prasanna Santhanam wrote:
  On devcloud
  
  $ cd /
  $ find . -name vmdata.py
  
  Do you see a file by that name anywhere in the XCP plugins? If not -
  it failed to copy over into the devcloud plugins for some reason 
  when
  adding the host.
  
  On Fri, Aug 02, 2013 at 03:22:20PM +0900, Thomas O'Dowd wrote:
   This was working yesterday but the launching of instances for me 
   on 4.2
   is currently not working. I have twice now tried a clean build 
   along
   with deploydb and deploysvr in the usual manner but no luck.
   
   On the UI I get: 
   Unable to create a deployment for VM[User|tom1]
   
   On the management server output I get.
   
   INFO  [cloud.vm.VirtualMachineManagerImpl] (Job-Executor-1:job-8 
   = [ 16ba488a-acbc-4c38-9384-9503123
   4b9c8 ]) Unable to contact resource.
   com.cloud.exception.ResourceUnavailableException: Resource 
   [Pod:1] is unreachable: Unable to apply u
   serdata and password entry on router
   at 
   com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkAppl
   ianceManagerImpl.java:3810)
   at 
   com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyUserData(VirtualNetworkA
  

Re: S3 Object Store testing

2013-08-02 Thread Thomas O'Dowd
Sanjeev,

Any further ideas on
https://issues.apache.org/jira/browse/CLOUDSTACK-3229

John worked and I worked on it quite a lot yesterday (he had a long day
or rather a short night). We're passed the S3 plugin issue but snapshots
are still failing on what looks like the last step.

Tom.

On Tue, 2013-07-30 at 09:04 +, Sanjeev Neelarapu wrote:
 Hi Tom,
 
 Thanks for testing this feature on XCP. I haven't covered XCP in my tests. So 
 far testing has been done on XenServer and KVM. 
 
 Thanks,
 Sanjeev
 
 -Original Message-
 From: Thomas O'Dowd [mailto:tpod...@cloudian.com] 
 Sent: Tuesday, July 30, 2013 2:25 PM
 To: Sanjeev Neelarapu
 Cc: Cloudstack DEV
 Subject: S3 Object Store testing
 
 Sanjeev,
 
 I was talking to Prasanna earlier regarding testing various parts of the
 S3 Object Store integration. I've been testing on and off myself using 
 devcloud but have yet to get a snapshot to work. It looks like devcloud 
 version of XCP at least doesn't have /opt/xensource/sm/ so its failing to 
 store the snapshot. See this issue here:
 https://issues.apache.org/jira/browse/CLOUDSTACK-3229
 
 I'm going to try to find some hardware to test with KVM but not sure how soon 
 I can do it. I'm interested to hear regarding how far you have tested 
 different hypervisors with S3 and which areas you have concern with or need 
 further testing.
 
 Tom.
 --
 Cloudian KK - http://cloudian.jp/
 S3 REST API Compliant Cloud Storage with Cloudian®
 

-- 
Cloudian KK - http://www.cloudian.com/get-started.html
Fancy 100TB of full featured S3 Storage?
Checkout the Cloudian® Community Edition!



Re: Review Request 13109: CLOUDSTACK-3594: Fixes related to affinity groups

2013-08-02 Thread Prasanna Santhanam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13109/#review24513
---

Ship it!


Ship It!

- Prasanna Santhanam


On July 31, 2013, 12:13 p.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13109/
 ---
 
 (Updated July 31, 2013, 12:13 p.m.)
 
 
 Review request for cloudstack and Prasanna Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Fixed test case issues mentioned in issue 
 https://issues.apache.org/jira/browse/CLOUDSTACK-3594
 
 Radom-ized affinity group name to avoid cascading test case failures stating 
 unable to create affinity group due to affinity group with the same name 
 exists.
 
 Included following 2 test suites which were not run in last build because 
 there was no decorator for the test cases.
 1. TestListAffinityGroups
 2. TestUpdateVMAffinityGroups
 
 One test case in TestUpdateVMAffinityGroups is skipped, it's failing right 
 now. Will be fixed shortly.
 
 
 Diffs
 -
 
   test/integration/component/test_affinity_groups.py 3ecab6f 
   tools/marvin/marvin/integration/lib/base.py b552aba 
 
 Diff: https://reviews.apache.org/r/13109/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Gaurav Aradhye
 




reviewer wanted

2013-08-02 Thread Daan Hoogland
Can https://reviews.apache.org/r/13192/ be reviewed please.

regards,
Daan


Review Request 13236: CLOUDSTACK: 3798: Fixed test_accounts.TestUserLogin.test_LoginApiUuidResponse

2013-08-02 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13236/
---

Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

Removed wrong assert. It was checking if response is None, while it should 
check the reverse.
Sessionkey in response is checked below.

Test case running ok now.


Diffs
-

  test/integration/component/test_accounts.py 9c3d231 

Diff: https://reviews.apache.org/r/13236/diff/


Testing
---


Thanks,

Gaurav Aradhye



RE: How to enforce data disk selection

2013-08-02 Thread Musayev, Ilya
Mike,

That is correct, we need to enforce data disk selection when user goes through 
deploying instance wizard in UI.

Is there a config to do this or should I hack some .js files?

Thanks
ilya

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Friday, August 02, 2013 1:36 AM
To: dev@cloudstack.apache.org
Subject: Re: How to enforce data disk selection

Could you provide a little more info about where in the GUI you'd like to 
enforce the selection of a data disk? When kicking off a VM instance perhaps?


On Thu, Aug 1, 2013 at 4:03 PM, Musayev, Ilya imusa...@webmd.net wrote:

 How would one enforce data disk selection?

 I don't want to leave data disk blank in UI.




--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*(tm)*



Re: Review Request 12360: custom cpu model for kvm guest.the default model 'QEMU Virtual CPU version xxx' affect the activation of Windows OS and low performance.

2013-08-02 Thread Wei Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12360/#review24514
---

Ship it!


Ship It!

- Wei Zhou


On July 14, 2013, 3:38 a.m., Jijun wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12360/
 ---
 
 (Updated July 14, 2013, 3:38 a.m.)
 
 
 Review request for cloudstack, edison su, soren, and Wei Zhou.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Add cpu model for kvm guest.Now all the kvm guest's cpu model is 'QEMU 
 Virtual CPU version xxx'. This will affect the activation of Windows OS and 
 low performance. I add three mode for user to indicate the guest cpu model. 
 some ideas come from openstack and libvirt.
 user can uncomment guest.cpu.mode and guest.cpu.model in agent.properties to 
 enable this feature.it is disabled by default.
 some details as follows:
 custom - user custom the CPU model which specified by guest.cpu.model.
 host-model - identify the named CPU model which most closely matches the 
 host, and then request additional CPU flags to complete the match. This 
 should give close to maximum functionality/performance, which maintaining 
 good reliability/compatibility if the guest is migrated to another host with 
 slightly different host CPUs.
 host-passthrough - tell KVM to passthrough the host CPU with no 
 modifications. The difference to host-model, instead of just matching feature 
 flags, every last detail of the host CPU is matched. This gives absolutely 
 best performance,and can be important to some apps which check low level CPU 
 details, but it comes at a cost wrt migration. The guest can only be migrated 
 to an exactly matching host CPU. 
 
 
 Diffs
 -
 
   agent/conf/agent.properties 60030ae 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
  24f9ee0 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
  5120870 
   
 plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
  2c0ff8d 
 
 Diff: https://reviews.apache.org/r/12360/diff/
 
 
 Testing
 ---
 
 1.set guest.cpu.mode=custom,guest.cpu.model=Nehalem in agent.properties,you 
 can get more guest.cpu.model by execute virsh capabilities .create a new vm 
 instance or reboot your vm instance,the guest's cpu model will change as 
 guest.cpu.model specified.
 2.set guest.cpu.mode=host-model,create a new vm instance or reboot your vm 
 instance the guest's cpu model will be a closely cpu model as your hypervisor.
 3.set guest.cpu.mode=host-passthrough,create a new vm instance or reboot your 
 vm instance,the guest's cpu model should be the cpu model as your hypervisor.
 
 
 Thanks,
 
 Jijun
 




Re: Review Request 13236: CLOUDSTACK: 3798: Fixed test_accounts.TestUserLogin.test_LoginApiUuidResponse

2013-08-02 Thread Prasanna Santhanam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13236/#review24515
---


The reason for failure of the login tests is that Marvin is not packaging the 
login/logout APIs as part of it. This needs to be fixed upstream in the marvin 
library generator.

- Prasanna Santhanam


On Aug. 2, 2013, 9:44 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13236/
 ---
 
 (Updated Aug. 2, 2013, 9:44 a.m.)
 
 
 Review request for cloudstack and Prasanna Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Removed wrong assert. It was checking if response is None, while it should 
 check the reverse.
 Sessionkey in response is checked below.
 
 Test case running ok now.
 
 
 Diffs
 -
 
   test/integration/component/test_accounts.py 9c3d231 
 
 Diff: https://reviews.apache.org/r/13236/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Gaurav Aradhye
 




Review Request 13237: Unable to resize disk with Zone wide storage

2013-08-02 Thread Rajesh Battala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/
---

Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.


Bugs: 3781


Repository: cloudstack-git


Description
---

Issue:
== 
for Volume operations we are finding the hypervisor type. Volume can be in 
ZONE/Cluster scope storage pool. 
when volume is in ZONE scope, there is issue with they way we fetch the 
hypervisor type. It was written to handle Cluster scope only.

fixed:
==
Fixed with sql queries to fetch the Hypervisor type.
1. Fetch the hypervisor type for volume from storage pool table if the voluem 
is in ZONE scope storage pool.
2. Fetch the hypervisor type for volume from cluster table if the voluem is in 
CLUSTER scope storage pool.


Diffs
-

  engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 

Diff: https://reviews.apache.org/r/13237/diff/


Testing
---

Setup:
KVM and Xenserver with Adv Zone.
Added pool Zone scope on KVM and Cluster Scope on Xenserver 
1. created instances on KVM and xenserver.
2. Create two volumes attached to instances on KVM and Xenserver. 
3. vol1 is in Zone scope and vol2 is in cluster scope. 
4. Successfully performed resize opertions on vol1 and vol2.
5. Succssfully attached/detaches volumes


Thanks,

Rajesh Battala



Re: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-02 Thread Dave Cahill
Now that we've bumped the version number, do we need to
create Upgrade420to430 and add it
to engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java ?

I ran mvn -P developer -pl developer,tools/devcloud -Ddeploydb (from [1])
on a fresh checkout of master and got:

[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on project
cloud-developer: An exception occured while executing the Java class. null:
InvocationTargetException: The end upgrade version is actually at 4.2.0 but
our management server code version is at 4.3.0-SNAPSHOT - [Help 1]

Thanks,
Dave.

[1] http://cloudstack.apache.org/develop/environment.html


On Fri, Aug 2, 2013 at 2:37 PM, Radhika Puthiyetath 
radhika.puthiyet...@citrix.com wrote:

 Hi,

 I shall give you the complete picture on my doc tasks by EOD today.

 You will get a quick update on my doc progress at
 https://issues.apache.org/jira/issues/?filter=-1jql=project%20%3D%20CLOUDSTACK%20AND%20fixVersion%20%3D%20%224.2.0%22%20AND%20assignee%20in%20(currentUser())%20ORDER%20BY%20updatedDate%20DESC

 You can start localizing the following:

 GSLB (CLOUDSTACK-653)
 Document Dedicated Resources: Public IP Addresses and VLANs per Tenant
 (CLOUDSTACK-704)
 Document limiting resources to domain/accounts (Dedicated Resources)
 (CLOUDSTACK-713)
 Document user provided hostname to be specified in vCenter instead of
 CloudStack generated name (CLOUDSTACK-778)
 Documentation for nTier Apps 2.0 : Internal LB (CLOUDSTACK-770)
 Document Multiple IP Address per NIC (CLOUDSTACK-24)
 Document new default password encoding mechanism, SHA256Salt
 (CLOUDSTACK-1734)
 Document isolation in advanced zones using PVLAN (CLOUDSTACK-1456)
 Document ability to delete events and alerts (CLOUDSTACK-874)
 Document the ability to use multiple IP ranges (CLOUDSTACK-702)
 Document ability to use only a portion of the network (CLOUDSTACK-705)
 Documentation for the add/remove networks (CLOUDSTACK-645)
 Doc- Support Multiple Subnets per VLAN (CLOUDSTACK-788)
 Document the ability to use multiple IP ranges (CLOUDSTACK-702)


 Regards
 -Radhika

 -Original Message-
 From: Go Chiba [mailto:go.ch...@gmail.com]
 Sent: Thursday, August 01, 2013 2:54 PM
 To: dev@cloudstack.apache.org
 Subject: Re: [ACS42] Release Status Update: After Code Freeze Next Steps

 Thanks Animesh, I'll be checking open tasks too.


 On Thu, Aug 1, 2013 at 2:49 AM, Animesh Chaturvedi 
 animesh.chaturv...@citrix.com wrote:

 
 
   -Original Message-
   From: Chip Childers [mailto:chip.child...@sungard.com]
   Sent: Wednesday, July 31, 2013 8:44 AM
   To: dev@cloudstack.apache.org
   Subject: Re: [ACS42] Release Status Update: After Code Freeze Next
   Steps
  
   On Thu, Aug 01, 2013 at 12:41:16AM +0900, Go Chiba wrote:
Does it already fixed all 4.2 docs?
If yes, I'd like to update it to transifex to go ahead doc
   globalization...
  
   I'm not sure.
  
   Animesh? Docs team?
  [Animesh] I am  following up with doc team I see a bunch of doc sub
  tasks still open.
  
   
   
On Wed, Jul 31, 2013 at 11:20 PM, Chip Childers
chip.child...@sungard.comwrote:
   
 On Wed, Jul 31, 2013 at 10:33:51AM +0530, Prasanna Santhanam wrote:
  On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi
   wrote:
  
  
-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com]
Sent: Tuesday, July 30, 2013 2:06 PM
To: dev@cloudstack.apache.org
Subject: RE: [ACS42] Release Status Update: After Code
Freeze Next
 Steps
   
 The best type of commit for keeping things clean is a
   cherry-pick.
 Merging into the release branch is messy to track as the
 RM.

   
That should be a rule for release branches after code freeze.
   
--Alex
   [Animesh] Thanks for clarifying, we will follow that for
   4.2
 
  Also can we do a git cherry-pick -x? It lists the original
  commit from which the cherry was picked. Without it git branch
  --contains on a commit id returns the wrong branch the commit
  was brought in
   from.

 Ah...  smart idea!

   
   
   
--
千葉 豪  Go Chiba
E-mail:go.ch...@gmail.com
 



 --
 千葉 豪  Go Chiba
 E-mail:go.ch...@gmail.com



RE: How to enforce data disk selection

2013-08-02 Thread Sanjay Tripathi
There is no any gc to enforce the datadisk selection; perhaps you can hack 
instanceWizard.js file in ui-custom folder to disable the No thanks option.

--Sanjay

 -Original Message-
 From: Musayev, Ilya [mailto:imusa...@webmd.net]
 Sent: Friday, August 02, 2013 3:17 PM
 To: dev@cloudstack.apache.org
 Subject: RE: How to enforce data disk selection
 
 Mike,
 
 That is correct, we need to enforce data disk selection when user goes
 through deploying instance wizard in UI.
 
 Is there a config to do this or should I hack some .js files?
 
 Thanks
 ilya
 
 -Original Message-
 From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
 Sent: Friday, August 02, 2013 1:36 AM
 To: dev@cloudstack.apache.org
 Subject: Re: How to enforce data disk selection
 
 Could you provide a little more info about where in the GUI you'd like to
 enforce the selection of a data disk? When kicking off a VM instance
 perhaps?
 
 
 On Thu, Aug 1, 2013 at 4:03 PM, Musayev, Ilya imusa...@webmd.net
 wrote:
 
  How would one enforce data disk selection?
 
  I don't want to leave data disk blank in UI.
 
 
 
 
 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*



Values within commands.properties.in

2013-08-02 Thread Ian Duffy
Hi,

This query is in relation to the permissions set for commands via
client/tomcatconf/commands.properties.in

Within the header of the file it states:
bitmap of permissions at the end of each classname, 1 = ADMIN, 2 =
RESOURCE_DOMAIN_ADMIN, 4 = DOMAIN_ADMIN, 8 = USER

However, throughout the file the undocumented numbers of 3, 7 and 15
can be found. Can somebody explain what they mean?

Looking within the RoleType enum only the following are defined:

Admin = 1
ResourceAdmin = 2
Domain Admin = 4
User = 8
Unknown = 0

Thanks!


Re: How to fix libvirt storage pool refresh issue?

2013-08-02 Thread Wido den Hollander



On 08/02/2013 01:55 AM, Edison Su wrote:

Hi Wei, regarding to the bug CLOUDSTACK-2729, I removed storage.refresh during 
getStoragePool in LibvirtStorageAdaptor, but the issue still happened in BVT.
I am thinking add file lock on primary storage, seems you already have the 
patch, could you share the patch with us?



Fyi, I fixed this by patching the libvirt on our production systems 
rather then fixing the CloudStack agent.


It's just one very small patch: 
https://bugzilla.redhat.com/show_bug.cgi?id=977706


https://www.redhat.com/archives/libvir-list/2013-July/msg00635.html

Wido


-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: Tuesday, July 16, 2013 3:35 AM
To: dev@cloudstack.apache.org
Subject: Re: How to fix libvirt storage pool refresh issue?

I agree with Wido.

Moreover, the file lock will cause performane degrade of VM deployment.

-Wei


2013/7/16 Wido den Hollander w...@widodh.nl


On 07/16/2013 12:27 AM, Marcus Sorensen wrote:


 I'm ok with a symptom fix on our end, if the root cause is in
Libvirt we can't do much about that. This is the sort of patch that
tends to get pulled into the regular update cycle of the
distributions, so unless there's more to it and it's not a good fix I
imagine we will see it come through without having to wait for the
next point releases. We still have to support existing users who
might not be running the latest, though, so the symptom fix is
probably ok as a temporary measure.



I'm ok with not calling storagePoolRefresh every time we want a
capacity update, since that's also kind of I/O intensive for larger storage

arrays.


However, we should make sure we have a GOOD comment in the code

about

this fix, since that's the reason I initially removed the old code
which invoked df.

I'll see if I can get this libvirt patch into Ubuntu when it hits
libvirt upstream, since this bug is really annoying.

Wido




On Mon, Jul 15, 2013 at 3:42 PM, Edison Su edison...@citrix.com wrote:


There is a serious issue on KVM(https://issues.apache.org/**
jira/browse/CLOUDSTACK-

2729https://issues.apache.org/jira/browse/CLOUDSTACK-2729):

a libvirt storage pool can disappear on KVM host, it's easy to be
reproduced in our internal QA environment.
Wei found the root cause, is on the libvirt:

This is a libvirt issue. I created a ticket for it.
https://bugzilla.redhat.com/**show_bug.cgi?id=977706https://bugzill
a.redhat.com/show_bug.cgi?id=977706
The patch is very simple.
https://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.h
tmlhttps://www.redhat.com/archives/libvir-list/2013-July/msg00635.h
tml

But it's also introduced by CloudStack, as cloudstack will call
libvirt storage pool refresh method each time when access the
storage pool. The code is added by commit:
2ffc9907f7b0d371737e39b7649f7a**f23026f5cf,
about less than one year ago.

As Wei suggested, we can call storage pool refresh only if needed,
it will mitigate the issue(It's behavior I did on cloudstack
pre-4.0), but it's only treat the symptom, not the cause.
Or add a cluster wide lock, only one guy can access storage pool at
one time, we can add a file lock on NFS primary storage.
Any idea/feedback on how to fix this KVM issue?








Re: Review Request 12934: Tests for egress firewall rules for advance zone

2013-08-02 Thread Jayapal Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review24517
---



test/integration/component/test_egress_fw_rules.py
https://reviews.apache.org/r/12934/#comment48526

I appreciate your effort in correcting the test cases.
There are few comments from my side. Please fix those.
Also the script is failed to run.Also look into this. The below exception 
is thrown


integration.component.test_egress_fw_rules.log_test_exceptions ... ERROR

==
ERROR: integration.component.test_egress_fw_rules.log_test_exceptions
--
Traceback (most recent call last):
  File /Library/Python/2.7/site-packages/nose/case.py, line 197, in 
runTest
self.test(*self.arg)
TypeError: log_test_exceptions() takes exactly 1 argument (0 given)




test/integration/component/test_egress_fw_rules.py
https://reviews.apache.org/r/12934/#comment48519

change the comment.
Egress policy is true



test/integration/component/test_egress_fw_rules.py
https://reviews.apache.org/r/12934/#comment48520

fix the comment.
access to public network for tcp port 80 is blocked.



test/integration/component/test_egress_fw_rules.py
https://reviews.apache.org/r/12934/#comment48521

Egress policy is not set to false, but comment says false. The above test 
case is already set to true



test/integration/component/test_egress_fw_rules.py
https://reviews.apache.org/r/12934/#comment48522

Fix the comment, invalid cidr is passed to create the rule



test/integration/component/test_egress_fw_rules.py
https://reviews.apache.org/r/12934/#comment48523

Invalid cidr is not passed to rule. fix the comment



test/integration/component/test_egress_fw_rules.py
https://reviews.apache.org/r/12934/#comment48524

Fix the comment



test/integration/component/test_egress_fw_rules.py
https://reviews.apache.org/r/12934/#comment48525

Fix the comment


- Jayapal Reddy


On Aug. 1, 2013, 6:19 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12934/
 ---
 
 (Updated Aug. 1, 2013, 6:19 a.m.)
 
 
 Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna 
 Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Tests for egress firewall rules for advance zone.
 
 
 Diffs
 -
 
   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/12934/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Re: [ACS42] Release Status Update: After Code Freeze Next Steps

2013-08-02 Thread Wido den Hollander



On 08/02/2013 11:22 AM, Dave Cahill wrote:

Now that we've bumped the version number, do we need to
create Upgrade420to430 and add it
to engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java ?



Yes, I forgot that. I created the SQL file, but I didn't create the Java 
files.


Wido


I ran mvn -P developer -pl developer,tools/devcloud -Ddeploydb (from [1])
on a fresh checkout of master and got:

[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on project
cloud-developer: An exception occured while executing the Java class. null:
InvocationTargetException: The end upgrade version is actually at 4.2.0 but
our management server code version is at 4.3.0-SNAPSHOT - [Help 1]

Thanks,
Dave.

[1] http://cloudstack.apache.org/develop/environment.html


On Fri, Aug 2, 2013 at 2:37 PM, Radhika Puthiyetath 
radhika.puthiyet...@citrix.com wrote:


Hi,

I shall give you the complete picture on my doc tasks by EOD today.

You will get a quick update on my doc progress at
https://issues.apache.org/jira/issues/?filter=-1jql=project%20%3D%20CLOUDSTACK%20AND%20fixVersion%20%3D%20%224.2.0%22%20AND%20assignee%20in%20(currentUser())%20ORDER%20BY%20updatedDate%20DESC

You can start localizing the following:

GSLB (CLOUDSTACK-653)
Document Dedicated Resources: Public IP Addresses and VLANs per Tenant
(CLOUDSTACK-704)
Document limiting resources to domain/accounts (Dedicated Resources)
(CLOUDSTACK-713)
Document user provided hostname to be specified in vCenter instead of
CloudStack generated name (CLOUDSTACK-778)
Documentation for nTier Apps 2.0 : Internal LB (CLOUDSTACK-770)
Document Multiple IP Address per NIC (CLOUDSTACK-24)
Document new default password encoding mechanism, SHA256Salt
(CLOUDSTACK-1734)
Document isolation in advanced zones using PVLAN (CLOUDSTACK-1456)
Document ability to delete events and alerts (CLOUDSTACK-874)
Document the ability to use multiple IP ranges (CLOUDSTACK-702)
Document ability to use only a portion of the network (CLOUDSTACK-705)
Documentation for the add/remove networks (CLOUDSTACK-645)
Doc- Support Multiple Subnets per VLAN (CLOUDSTACK-788)
Document the ability to use multiple IP ranges (CLOUDSTACK-702)


Regards
-Radhika

-Original Message-
From: Go Chiba [mailto:go.ch...@gmail.com]
Sent: Thursday, August 01, 2013 2:54 PM
To: dev@cloudstack.apache.org
Subject: Re: [ACS42] Release Status Update: After Code Freeze Next Steps

Thanks Animesh, I'll be checking open tasks too.


On Thu, Aug 1, 2013 at 2:49 AM, Animesh Chaturvedi 
animesh.chaturv...@citrix.com wrote:





-Original Message-
From: Chip Childers [mailto:chip.child...@sungard.com]
Sent: Wednesday, July 31, 2013 8:44 AM
To: dev@cloudstack.apache.org
Subject: Re: [ACS42] Release Status Update: After Code Freeze Next
Steps

On Thu, Aug 01, 2013 at 12:41:16AM +0900, Go Chiba wrote:

Does it already fixed all 4.2 docs?
If yes, I'd like to update it to transifex to go ahead doc

globalization...

I'm not sure.

Animesh? Docs team?

[Animesh] I am  following up with doc team I see a bunch of doc sub
tasks still open.





On Wed, Jul 31, 2013 at 11:20 PM, Chip Childers
chip.child...@sungard.comwrote:


On Wed, Jul 31, 2013 at 10:33:51AM +0530, Prasanna Santhanam wrote:

On Tue, Jul 30, 2013 at 10:03:08PM +, Animesh Chaturvedi

wrote:




-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com]
Sent: Tuesday, July 30, 2013 2:06 PM
To: dev@cloudstack.apache.org
Subject: RE: [ACS42] Release Status Update: After Code
Freeze Next

Steps



The best type of commit for keeping things clean is a

cherry-pick.

Merging into the release branch is messy to track as the

RM.




That should be a rule for release branches after code freeze.

--Alex

[Animesh] Thanks for clarifying, we will follow that for
4.2


Also can we do a git cherry-pick -x? It lists the original
commit from which the cherry was picked. Without it git branch
--contains on a commit id returns the wrong branch the commit
was brought in

from.


Ah...  smart idea!





--
千葉 豪  Go Chiba
E-mail:go.ch...@gmail.com






--
千葉 豪  Go Chiba
E-mail:go.ch...@gmail.com





RE: Values within commands.properties.in

2013-08-02 Thread Musayev, Ilya
Ian, 

You can combine numbers to get the specific permission, for example

15 is the sum of 1, 2, 4, and 8 - which also means everyone has access
3 is the sum of 1 and 2 and only admin and resource admin have access

Regards
ilya

-Original Message-
From: Ian Duffy [mailto:i...@ianduffy.ie] 
Sent: Friday, August 02, 2013 6:25 AM
To: CloudStack Dev
Subject: Values within commands.properties.in

Hi,

This query is in relation to the permissions set for commands via 
client/tomcatconf/commands.properties.in

Within the header of the file it states:
bitmap of permissions at the end of each classname, 1 = ADMIN, 2 = 
RESOURCE_DOMAIN_ADMIN, 4 = DOMAIN_ADMIN, 8 = USER

However, throughout the file the undocumented numbers of 3, 7 and 15 can be 
found. Can somebody explain what they mean?

Looking within the RoleType enum only the following are defined:

Admin = 1
ResourceAdmin = 2
Domain Admin = 4
User = 8
Unknown = 0

Thanks!



Re: Values within commands.properties.in

2013-08-02 Thread Ian Duffy
Cool, thanks Ilya. I should of spotted that!

On 2 August 2013 11:32, Musayev, Ilya imusa...@webmd.net wrote:
 Ian,

 You can combine numbers to get the specific permission, for example

 15 is the sum of 1, 2, 4, and 8 - which also means everyone has access
 3 is the sum of 1 and 2 and only admin and resource admin have access

 Regards
 ilya

 -Original Message-
 From: Ian Duffy [mailto:i...@ianduffy.ie]
 Sent: Friday, August 02, 2013 6:25 AM
 To: CloudStack Dev
 Subject: Values within commands.properties.in

 Hi,

 This query is in relation to the permissions set for commands via 
 client/tomcatconf/commands.properties.in

 Within the header of the file it states:
 bitmap of permissions at the end of each classname, 1 = ADMIN, 2 = 
 RESOURCE_DOMAIN_ADMIN, 4 = DOMAIN_ADMIN, 8 = USER

 However, throughout the file the undocumented numbers of 3, 7 and 15 can be 
 found. Can somebody explain what they mean?

 Looking within the RoleType enum only the following are defined:

 Admin = 1
 ResourceAdmin = 2
 Domain Admin = 4
 User = 8
 Unknown = 0

 Thanks!



Re: Review Request 13112: upgrade to ASF 4.2 cloud Database Schema Inconsistencies on the Upgraded Setup - Table volumes

2013-08-02 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/#review24518
---

Ship it!


Ship It!

- Abhinandan Prateek


On Aug. 1, 2013, 6:01 p.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13112/
 ---
 
 (Updated Aug. 1, 2013, 6:01 p.m.)
 
 
 Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
 
 
 Bugs: Cloudstack-3836
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 upgrade to ASF 4.2  cloud Database Schema Inconsistencies on the Upgraded 
 Setup - Table volumes
 https://issues.apache.org/jira/browse/CLOUDSTACK-3836
 
 This extra column is because of the fix 
 Parent id of template incorrectly recorded as last ISO attached to VM.
 
 when a template is created form the snapshot the sourcetemplateid is recorded 
 as the iso attached to the VM at thee time of creation. 
 
 we fix this by adding a iso_id column to the volume table. when a template is 
 created from the snapshot we fetch the iso_id form the parent volume and set 
 it as the sourcetemplated id of the newly created template.
 
 
 Diffs
 -
 
   engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
   server/src/com/cloud/storage/VolumeManager.java 13ddbab 
   server/src/com/cloud/storage/VolumeManagerImpl.java 3cce8b6 
   server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2 
   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5b7aa5b 
   setup/db/db/schema-307to410.sql be6c17d 
   setup/db/db/schema-410to420.sql 99a0208 
 
 Diff: https://reviews.apache.org/r/13112/diff/
 
 
 Testing
 ---
 
 Tested on 4.2.
 
 
 Thanks,
 
 bharat kumar
 




Re: [4.1] getVMPassword how to decrypt

2013-08-02 Thread Antonio Petrocelli

  
  
Thanks a lot.
  
  It work.
  
  I'm unable to retrive PRIVATEKEY with API call:
http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/listSSHKeyPairs.html
  
  the only way to retrieve is from:
http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/createSSHKeyPair.html
  
  but i don't want store this key...
  
  Do you now how i can retrieve it?
  
  Thanks.
  
  Regards.
  
  Il 01/08/2013 16:47, Harikrishna Patnala ha scritto:


  Yes the password is encrypted with public key of ssh key pair assigned to the guest VM during deployment.
We can decrypt it using the private key of that key pair.

-Harikrishna

On 01-Aug-2013, at 3:13 AM, Chiradeep Vittal chiradeep.vit...@citrix.commailto:chiradeep.vit...@citrix.com wrote:

Isn't this encrypted with the ssh keys of the user? (createSshKeyPair)

From: Antonio Petrocelli a.petroce...@netsons.commailto:a.petroce...@netsons.com
Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Date: Tuesday, July 30, 2013 2:46 AM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: [4.1] getVMPassword  how to decrypt

Hello,

http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/getVMPassword.html

after retrieved the password i'm unable to decrypt the encryptedpassword.

Suggestions?

Thanks.

Regards.
--

netsons-logo-email.png

Supernova s.r.l.
Via G. Misiticoni, 3
65126 - Pescara
ITALY

www.netsons.comhttp://www.netsons.com/
Antonio Petrocelli
Software Engineer


t. (+39) 085 45 100 52
e. a.petroce...@netsons.commailto:a.petroce...@netsons.com


btn_viewmy_160x25.pnghttp://it.linkedin.com/pub/antonio-petrocelli/18/611/619


Netsons  un marchio registrato dalla Supernova s.r.l.

Le informazioni trasmesse sono riservate alla persona o alla societ indicata come destinatario, e possono includere contenuti considerati confidenziali. Ogni elaborazione, comunicazione, trasmissione o altro utilizzo, anche azioni conseguenti alla conoscenza di queste informazioni da parte di chiunque non sia espressamente indicato come destinatario  proibita. Nel caso abbiate ricevuto per errore questa comunicazione, siete pregati di darne avviso a info [at] netsons.comhttp://netsons.com ed eliminare ogni stampa ed ogni traccia informatica. Il ricevente dovr inoltre accertarsi che gli eventuali allegati non contengano virus prima di aprirli. Qualunque opinione o affermazione presentata in questo messaggio  da ritenersi propria dell'autore e non rappresenta necessariamente la posizione della Societ.

The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact: info [at] netsons.comhttp://netsons.com and delete the material from any computer. If this email contains attachments you should ensure they are checked for viruses before opening them. Any views or opinions presented are solely those of the author and do not necessarily represent those of the company.






-- 
   
  

  

  
  
  Supernova
  s.r.l.
  Via G. Misiticoni, 3
  65126 - Pescara
  ITALY
  
  www.netsons.com


   Antonio
Petrocelli
Software Engineer 
   
  
  t. (+39)
085 45 100 52
  e. a.petroce...@netsons.com
  
  
   
   
  

  
  
  
  Netsons  un marchio registrato dalla Supernova s.r.l.
  
  
  
Le informazioni trasmesse sono riservate alla persona o alla
societ indicata come destinatario, e possono includere
contenuti considerati confidenziali. Ogni elaborazione,
comunicazione, trasmissione o altro utilizzo, anche azioni
conseguenti alla conoscenza di queste informazioni da parte di
chiunque non sia espressamente indicato come destinatario 
proibita. Nel caso abbiate ricevuto per errore questa
comunicazione, siete pregati di darne avviso a info [at]
netsons.com ed eliminare ogni stampa ed ogni traccia
informatica. Il ricevente dovr inoltre accertarsi che gli
eventuali allegati non contengano virus prima di aprirli.
Qualunque opinione o affermazione presentata in questo messaggio
 da ritenersi propria dell'autore e non rappresenta
necessariamente la posizione della Societ.


The information transmitted is intended only for the person or
entity to 

Re: [4.1] getVMPassword how to decrypt

2013-08-02 Thread Wei ZHOU
Antonio,

For almost all clients, they do not want the provider storing the private
key (on management server). It is a big security risk for clients.
You have to store the key by yourself.

-Wei


2013/8/2 Antonio Petrocelli a.petroce...@netsons.com

  Thanks a lot.

 It work.

 I'm unable to retrive PRIVATEKEY with API call:
 http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/listSSHKeyPairs.html

 the only way to retrieve is from:
 http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/createSSHKeyPair.html

 but i don't want store this key...

 Do you now how i can retrieve it?

 Thanks.

 Regards.

 Il 01/08/2013 16:47, Harikrishna Patnala ha scritto:

 Yes the password is encrypted with public key of ssh key pair assigned to the 
 guest VM during deployment.
 We can decrypt it using the private key of that key pair.

 -Harikrishna

 On 01-Aug-2013, at 3:13 AM, Chiradeep Vittal 
 chiradeep.vit...@citrix.commailto:chiradeep.vit...@citrix.com 
 chiradeep.vit...@citrix.com wrote:

 Isn't this encrypted with the ssh keys of the user? (createSshKeyPair)

 From: Antonio Petrocelli 
 a.petroce...@netsons.commailto:a.petroce...@netsons.com 
 a.petroce...@netsons.com
 Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.org
 Date: Tuesday, July 30, 2013 2:46 AM
 To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.org
 Subject: [4.1] getVMPassword  how to decrypt

 Hello,
 http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/getVMPassword.html

 after retrieved the password i'm unable to decrypt the encryptedpassword.

 Suggestions?

 Thanks.

 Regards.
 --

 netsons-logo-email.png

 Supernova s.r.l.
 Via G. Misiticoni, 3
 65126 - Pescara
 ITALY
 www.netsons.comhttp://www.netsons.com/ http://www.netsons.com/
 Antonio Petrocelli
 Software Engineer


 t. (+39) 085 45 100 52
 e. a.petroce...@netsons.commailto:a.petroce...@netsons.com 
 a.petroce...@netsons.com


 btn_viewmy_160x25.pnghttp://it.linkedin.com/pub/antonio-petrocelli/18/611/619
  http://it.linkedin.com/pub/antonio-petrocelli/18/611/619


 Netsons® è un marchio registrato dalla Supernova s.r.l.

 Le informazioni trasmesse sono riservate alla persona o alla società indicata 
 come destinatario, e possono includere contenuti considerati confidenziali. 
 Ogni elaborazione, comunicazione, trasmissione o altro utilizzo, anche azioni 
 conseguenti alla conoscenza di queste informazioni da parte di chiunque non 
 sia espressamente indicato come destinatario è proibita. Nel caso abbiate 
 ricevuto per errore questa comunicazione, siete pregati di darne avviso a 
 info [at] netsons.comhttp://netsons.com http://netsons.com ed eliminare 
 ogni stampa ed ogni traccia informatica. Il ricevente dovrà inoltre 
 accertarsi che gli eventuali allegati non contengano virus prima di aprirli. 
 Qualunque opinione o affermazione presentata in questo messaggio è da 
 ritenersi propria dell'autore e non rappresenta necessariamente la posizione 
 della Società.

 The information transmitted is intended only for the person or entity to 
 which it is addressed and may contain confidential material. Any review, 
 retransmission, dissemination or other use of, or taking of any action in 
 reliance upon this information by persons or entities other than the intended 
 recipient is prohibited. If you received this in error, please contact: info 
 [at] netsons.comhttp://netsons.com http://netsons.com and delete the 
 material from any computer. If this email contains attachments you should 
 ensure they are checked for viruses before opening them. Any views or 
 opinions presented are solely those of the author and do not necessarily 
 represent those of the company.





 --



 *Supernova s.r.l.*
 Via G. Misiticoni, 3
 65126 - Pescara
 ITALY

 *www.netsons.com* http://www.netsons.com
  *Antonio Petrocelli*
 Software Engineer
 **

 *t. *(+39) 085 45 100 52
 *e. *a.petroce...@netsons.com


  [image: View Antonio Petrocelli's profile on 
 LinkedIn]http://it.linkedin.com/pub/antonio-petrocelli/18/611/619


 *Netsons® è un marchio registrato dalla Supernova s.r.l.*

  Le informazioni trasmesse sono riservate alla persona o alla società
 indicata come destinatario, e possono includere contenuti considerati
 confidenziali. Ogni elaborazione, comunicazione, trasmissione o altro
 utilizzo, anche azioni conseguenti alla conoscenza di queste informazioni
 da parte di chiunque non sia espressamente indicato come destinatario è
 proibita. Nel caso abbiate ricevuto per errore questa comunicazione, siete
 pregati di darne avviso a info [at] netsons.com ed eliminare ogni stampa
 ed ogni traccia informatica. Il ricevente dovrà inoltre accertarsi che gli
 eventuali allegati non contengano virus prima di aprirli. Qualunque
 opinione o affermazione presentata in questo messaggio è da ritenersi
 propria dell'autore e non rappresenta necessariamente la posizione della
 Società.

 The information 

Re: [4.1] getVMPassword how to decrypt

2013-08-02 Thread Antonio Petrocelli

This key must alreay be on the system...

Only i need to retrieve it API wan't i need a different solution

Thanks

Il 02/08/2013 12:51, Wei ZHOU ha scritto:

Antonio,
For almost all clients, they do not want the provider storing the 
private key (on management server). It is a big security risk for clients.

You have to store the key by yourself.
-Wei


2013/8/2 Antonio Petrocelli a.petroce...@netsons.com 
mailto:a.petroce...@netsons.com


Thanks a lot.

It work.

I'm unable to retrive PRIVATEKEY with API call:

http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/listSSHKeyPairs.html

the only way to retrieve is from:

http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/createSSHKeyPair.html

but i don't want store this key...

Do you now how i can retrieve it?

Thanks.

Regards.

Il 01/08/2013 16:47, Harikrishna Patnala ha scritto:

Yes the password is encrypted with public key of ssh key pair assigned to 
the guest VM during deployment.
We can decrypt it using the private key of that key pair.

-Harikrishna

On 01-Aug-2013, at 3:13 AM, Chiradeep Vittal chiradeep.vit...@citrix.com  
mailto:chiradeep.vit...@citrix.commailto:chiradeep.vit...@citrix.com  
mailto:chiradeep.vit...@citrix.com wrote:

Isn't this encrypted with the ssh keys of the user? (createSshKeyPair)

From: Antonio Petrocelli a.petroce...@netsons.com  
mailto:a.petroce...@netsons.commailto:a.petroce...@netsons.com  
mailto:a.petroce...@netsons.com
Reply-To: dev@cloudstack.apache.org  
mailto:dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org  
mailto:dev@cloudstack.apache.org
Date: Tuesday, July 30, 2013 2:46 AM
To: dev@cloudstack.apache.org  
mailto:dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org  
mailto:dev@cloudstack.apache.org
Subject: [4.1] getVMPassword  how to decrypt

Hello,


http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/getVMPassword.html

after retrieved the password i'm unable to decrypt the encryptedpassword.

Suggestions?

Thanks.

Regards.
--

netsons-logo-email.png

Supernova s.r.l.
Via G. Misiticoni, 3
65126 - Pescara
ITALY

www.netsons.com  http://www.netsons.comhttp://www.netsons.com/  
http://www.netsons.com/
Antonio Petrocelli
Software Engineer


t.(+39) 085 45 100 52  tel:%28%2B39%29%20085%2045%20100%2052
e.a.petroce...@netsons.com  
mailto:a.petroce...@netsons.commailto:a.petroce...@netsons.com  
mailto:a.petroce...@netsons.com


btn_viewmy_160x25.pnghttp://it.linkedin.com/pub/antonio-petrocelli/18/611/619 
 http://it.linkedin.com/pub/antonio-petrocelli/18/611/619


Netsons® è un marchio registrato dalla Supernova s.r.l.

Le informazioni trasmesse sono riservate alla persona o alla società indicata come 
destinatario, e possono includere contenuti considerati confidenziali. Ogni elaborazione, 
comunicazione, trasmissione o altro utilizzo, anche azioni conseguenti alla conoscenza di queste 
informazioni da parte di chiunque non sia espressamente indicato come destinatario è proibita. 
Nel caso abbiate ricevuto per errore questa comunicazione, siete pregati di darne avviso a info 
[at]netsons.com  http://netsons.comhttp://netsons.com  http://netsons.com 
 ed eliminare ogni stampa ed ogni traccia informatica. Il ricevente dovrà inoltre accertarsi che 
gli eventuali allegati non contengano virus prima di aprirli. Qualunque opinione o affermazione 
presentata in questo messaggio è da ritenersi propria dell'autore e non rappresenta 
necessariamente la posizione della Società.

The information transmitted is intended only for the person or entity to which it is 
addressed and may contain confidential material. Any review, retransmission, dissemination or 
other use of, or taking of any action in reliance upon this information by persons or entities 
other than the intended recipient is prohibited. If you received this in error, please contact: 
info [at]netsons.com  http://netsons.comhttp://netsons.com  
http://netsons.com  and delete the material from any computer. If this email contains 
attachments you should ensure they are checked for viruses before opening them. Any views or 
opinions presented are solely those of the author and do not necessarily represent those of the 
company.





smime.p7s
Description: Firma crittografica S/MIME


Re: Review Request 13239: fixed the test test_non_contigiousvlan.py

2013-08-02 Thread Prasanna Santhanam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13239/#review24519
---

Ship it!


- Prasanna Santhanam


On Aug. 2, 2013, 10:54 a.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13239/
 ---
 
 (Updated Aug. 2, 2013, 10:54 a.m.)
 
 
 Review request for cloudstack and Prasanna Santhanam.
 
 
 Bugs: Cloudstack-3753
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 fixed the test test_non_contigiousvlan.py
 https://issues.apache.org/jira/browse/CLOUDSTACK-3753
 
 
 Diffs
 -
 
   test/integration/smoke/test_non_contigiousvlan.py 5fdc034 
 
 Diff: https://reviews.apache.org/r/13239/diff/
 
 
 Testing
 ---
 
 tested on 4.2
 
 
 Thanks,
 
 bharat kumar
 




[DISCUSS] [jira] make affectedVersion field mandatory.....

2013-08-02 Thread Ram Ganesh
Hi,

While triaging bugs I noticed that many bugs had affectedVersion field as 
empty.  This makes it difficult to guess the version/release the reporter was 
on while filing the bug. Can we make the affectedVersion field a mandatory 
field instead?

Thanks,
RamG



Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Wido den Hollander

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13223/#review24520
---


I haven't tested the patch, but I'm missing some comments.

Can we add clear comments as to WHY this is in the code? Otherwise I'm afraid 
this will become legacy and in 6 months new committer won't have the slightest 
idea of why this is in there.

- Wido den Hollander


On Aug. 2, 2013, 6:39 a.m., Wei Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13223/
 ---
 
 (Updated Aug. 2, 2013, 6:39 a.m.)
 
 
 Review request for cloudstack, edison su and Wido den Hollander.
 
 
 Bugs: CLOUDSTACK-2729
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt 
 (https://bugzilla.redhat.com/show_bug.cgi?id=977706)
 We need to prevent deleting a volume when refreshing the pool.
 This patch use a simple file lock to implement it.
 
 PS: I have tested another file lock similar to Read/Write file lock, but it 
 was very unstable.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
  dae25ae 
 
 Diff: https://reviews.apache.org/r/13223/diff/
 
 
 Testing
 ---
 
 Applied on 4.0.2 and 4.0.1
 
 Testing On 4.0.1 From 20,June
 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes 
 later. expunge.inteval = 600 (10 minutes), expunge.worker = 2
  
 
 Testing On 4.0.2 From 01,July
 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 
 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 
 
 
 Thanks,
 
 Wei Zhou
 




Re: Review Request 13239: fixed the test test_non_contigiousvlan.py

2013-08-02 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13239/#review24521
---


Review 13239 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #105 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/105/

- Jenkins Cloudstack.org


On Aug. 2, 2013, 10:54 a.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13239/
 ---
 
 (Updated Aug. 2, 2013, 10:54 a.m.)
 
 
 Review request for cloudstack and Prasanna Santhanam.
 
 
 Bugs: Cloudstack-3753
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 fixed the test test_non_contigiousvlan.py
 https://issues.apache.org/jira/browse/CLOUDSTACK-3753
 
 
 Diffs
 -
 
   test/integration/smoke/test_non_contigiousvlan.py 5fdc034 
 
 Diff: https://reviews.apache.org/r/13239/diff/
 
 
 Testing
 ---
 
 tested on 4.2
 
 
 Thanks,
 
 bharat kumar
 




Re: Review Request 13112: upgrade to ASF 4.2 cloud Database Schema Inconsistencies on the Upgraded Setup - Table volumes

2013-08-02 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13112/
---

(Updated Aug. 2, 2013, 11:16 a.m.)


Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Changes
---

rebased with master.


Bugs: Cloudstack-3836


Repository: cloudstack-git


Description
---

upgrade to ASF 4.2  cloud Database Schema Inconsistencies on the Upgraded 
Setup - Table volumes
https://issues.apache.org/jira/browse/CLOUDSTACK-3836

This extra column is because of the fix 
Parent id of template incorrectly recorded as last ISO attached to VM.

when a template is created form the snapshot the sourcetemplateid is recorded 
as the iso attached to the VM at thee time of creation. 

we fix this by adding a iso_id column to the volume table. when a template is 
created from the snapshot we fetch the iso_id form the parent volume and set it 
as the sourcetemplated id of the newly created template.


Diffs (updated)
-

  engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 
  server/src/com/cloud/storage/VolumeManager.java 13ddbab 
  server/src/com/cloud/storage/VolumeManagerImpl.java 393904e 
  server/src/com/cloud/template/TemplateManagerImpl.java d26ebe2 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 08bca43 
  setup/db/db/schema-307to410.sql be6c17d 
  setup/db/db/schema-410to420.sql 657d947 

Diff: https://reviews.apache.org/r/13112/diff/


Testing
---

Tested on 4.2.


Thanks,

bharat kumar



Re: How to fix libvirt storage pool refresh issue?

2013-08-02 Thread Wei ZHOU
Wido,

You applied the libvirt patch on your production system, and this issue
disappeared, right?
If so, that is good.
I expect the redhat community can accep the patch (or the v2
https://www.redhat.com/archives/libvir-list/2013-July/msg00639.html) ASAP.


-Wei


2013/8/2 Wido den Hollander w...@widodh.nl



 On 08/02/2013 01:55 AM, Edison Su wrote:

 Hi Wei, regarding to the bug CLOUDSTACK-2729, I removed storage.refresh
 during getStoragePool in LibvirtStorageAdaptor, but the issue still
 happened in BVT.
 I am thinking add file lock on primary storage, seems you already have
 the patch, could you share the patch with us?


 Fyi, I fixed this by patching the libvirt on our production systems rather
 then fixing the CloudStack agent.

 It's just one very small patch: https://bugzilla.redhat.com/**
 show_bug.cgi?id=977706https://bugzilla.redhat.com/show_bug.cgi?id=977706

 https://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.htmlhttps://www.redhat.com/archives/libvir-list/2013-July/msg00635.html

 Wido


  -Original Message-
 From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
 Sent: Tuesday, July 16, 2013 3:35 AM
 To: dev@cloudstack.apache.org
 Subject: Re: How to fix libvirt storage pool refresh issue?

 I agree with Wido.

 Moreover, the file lock will cause performane degrade of VM deployment.

 -Wei


 2013/7/16 Wido den Hollander w...@widodh.nl

  On 07/16/2013 12:27 AM, Marcus Sorensen wrote:

   I'm ok with a symptom fix on our end, if the root cause is in
 Libvirt we can't do much about that. This is the sort of patch that
 tends to get pulled into the regular update cycle of the
 distributions, so unless there's more to it and it's not a good fix I
 imagine we will see it come through without having to wait for the
 next point releases. We still have to support existing users who
 might not be running the latest, though, so the symptom fix is
 probably ok as a temporary measure.


 I'm ok with not calling storagePoolRefresh every time we want a
 capacity update, since that's also kind of I/O intensive for larger
 storage

 arrays.


 However, we should make sure we have a GOOD comment in the code

 about

 this fix, since that's the reason I initially removed the old code
 which invoked df.

 I'll see if I can get this libvirt patch into Ubuntu when it hits
 libvirt upstream, since this bug is really annoying.

 Wido



  On Mon, Jul 15, 2013 at 3:42 PM, Edison Su edison...@citrix.com
 wrote:

  There is a serious issue on 
 KVM(https://issues.apache.org/https://issues.apache.org/**
 jira/browse/CLOUDSTACK-

 2729https://issues.apache.**org/jira/browse/CLOUDSTACK-**2729https://issues.apache.org/jira/browse/CLOUDSTACK-2729
 ):

 a libvirt storage pool can disappear on KVM host, it's easy to be
 reproduced in our internal QA environment.
 Wei found the root cause, is on the libvirt:
 
 This is a libvirt issue. I created a ticket for it.
 https://bugzilla.redhat.com/show_bug.cgi?id=977706https://bugzilla.redhat.com/**show_bug.cgi?id=977706
 https:/**/bugzill https://bugzill
 a.redhat.com/show_bug.cgi?id=**977706http://a.redhat.com/show_bug.cgi?id=977706
 
 The patch is very simple.
 https://www.redhat.com/archives/libvir-list/2013-
 July/msg00635.hhttps://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.h
 tmlhttps://www.redhat.com/**archives/libvir-list/2013-**
 July/msg00635.hhttps://www.redhat.com/archives/libvir-list/2013-July/msg00635.h
 tml
 
 But it's also introduced by CloudStack, as cloudstack will call
 libvirt storage pool refresh method each time when access the
 storage pool. The code is added by commit:
 2ffc9907f7b0d371737e39b7649f7af23026f5cf,
 about less than one year ago.

 As Wei suggested, we can call storage pool refresh only if needed,
 it will mitigate the issue(It's behavior I did on cloudstack
 pre-4.0), but it's only treat the symptom, not the cause.
 Or add a cluster wide lock, only one guy can access storage pool at
 one time, we can add a file lock on NFS primary storage.
 Any idea/feedback on how to fix this KVM issue?








Re: Review Request 13236: CLOUDSTACK: 3798: Fixed test_accounts.TestUserLogin.test_LoginApiUuidResponse

2013-08-02 Thread Prasanna Santhanam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13236/#review24522
---

Ship it!


The problem will be seen only when using marvin.sync to update marvin. The 
tarballs generated by the marvin build have the loginCMd in them. So this works 
with the tarball that the test infra uses.

- Prasanna Santhanam


On Aug. 2, 2013, 9:44 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13236/
 ---
 
 (Updated Aug. 2, 2013, 9:44 a.m.)
 
 
 Review request for cloudstack and Prasanna Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Removed wrong assert. It was checking if response is None, while it should 
 check the reverse.
 Sessionkey in response is checked below.
 
 Test case running ok now.
 
 
 Diffs
 -
 
   test/integration/component/test_accounts.py 9c3d231 
 
 Diff: https://reviews.apache.org/r/13236/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Gaurav Aradhye
 




RE: [DISCUSS] [jira] make affectedVersion field mandatory.....

2013-08-02 Thread Koushik Das
+1

 -Original Message-
 From: Ram Ganesh [mailto:ram.gan...@citrix.com]
 Sent: Friday, August 02, 2013 4:38 PM
 To: dev@cloudstack.apache.org
 Subject: [DISCUSS] [jira] make affectedVersion field mandatory.
 
 Hi,
 
 While triaging bugs I noticed that many bugs had affectedVersion field as
 empty.  This makes it difficult to guess the version/release the reporter was
 on while filing the bug. Can we make the affectedVersion field a mandatory
 field instead?
 
 Thanks,
 RamG



Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Wei Zhou


 On Aug. 2, 2013, 11:09 a.m., Wido den Hollander wrote:
  I haven't tested the patch, but I'm missing some comments.
  
  Can we add clear comments as to WHY this is in the code? Otherwise I'm 
  afraid this will become legacy and in 6 months new committer won't have the 
  slightest idea of why this is in there.

Wido,

Make sense. I will add some comments later.


- Wei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13223/#review24520
---


On Aug. 2, 2013, 6:39 a.m., Wei Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13223/
 ---
 
 (Updated Aug. 2, 2013, 6:39 a.m.)
 
 
 Review request for cloudstack, edison su and Wido den Hollander.
 
 
 Bugs: CLOUDSTACK-2729
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt 
 (https://bugzilla.redhat.com/show_bug.cgi?id=977706)
 We need to prevent deleting a volume when refreshing the pool.
 This patch use a simple file lock to implement it.
 
 PS: I have tested another file lock similar to Read/Write file lock, but it 
 was very unstable.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
  dae25ae 
 
 Diff: https://reviews.apache.org/r/13223/diff/
 
 
 Testing
 ---
 
 Applied on 4.0.2 and 4.0.1
 
 Testing On 4.0.1 From 20,June
 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes 
 later. expunge.inteval = 600 (10 minutes), expunge.worker = 2
  
 
 Testing On 4.0.2 From 01,July
 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 
 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 
 
 
 Thanks,
 
 Wei Zhou
 




Re: Review Request 12360: custom cpu model for kvm guest.the default model 'QEMU Virtual CPU version xxx' affect the activation of Windows OS and low performance.

2013-08-02 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12360/#review24525
---


Review 12360 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #107 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/107/

- Jenkins Cloudstack.org


On July 14, 2013, 3:38 a.m., Jijun wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12360/
 ---
 
 (Updated July 14, 2013, 3:38 a.m.)
 
 
 Review request for cloudstack, edison su, soren, and Wei Zhou.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Add cpu model for kvm guest.Now all the kvm guest's cpu model is 'QEMU 
 Virtual CPU version xxx'. This will affect the activation of Windows OS and 
 low performance. I add three mode for user to indicate the guest cpu model. 
 some ideas come from openstack and libvirt.
 user can uncomment guest.cpu.mode and guest.cpu.model in agent.properties to 
 enable this feature.it is disabled by default.
 some details as follows:
 custom - user custom the CPU model which specified by guest.cpu.model.
 host-model - identify the named CPU model which most closely matches the 
 host, and then request additional CPU flags to complete the match. This 
 should give close to maximum functionality/performance, which maintaining 
 good reliability/compatibility if the guest is migrated to another host with 
 slightly different host CPUs.
 host-passthrough - tell KVM to passthrough the host CPU with no 
 modifications. The difference to host-model, instead of just matching feature 
 flags, every last detail of the host CPU is matched. This gives absolutely 
 best performance,and can be important to some apps which check low level CPU 
 details, but it comes at a cost wrt migration. The guest can only be migrated 
 to an exactly matching host CPU. 
 
 
 Diffs
 -
 
   agent/conf/agent.properties 60030ae 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
  24f9ee0 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
  5120870 
   
 plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
  2c0ff8d 
 
 Diff: https://reviews.apache.org/r/12360/diff/
 
 
 Testing
 ---
 
 1.set guest.cpu.mode=custom,guest.cpu.model=Nehalem in agent.properties,you 
 can get more guest.cpu.model by execute virsh capabilities .create a new vm 
 instance or reboot your vm instance,the guest's cpu model will change as 
 guest.cpu.model specified.
 2.set guest.cpu.mode=host-model,create a new vm instance or reboot your vm 
 instance the guest's cpu model will be a closely cpu model as your hypervisor.
 3.set guest.cpu.mode=host-passthrough,create a new vm instance or reboot your 
 vm instance,the guest's cpu model should be the cpu model as your hypervisor.
 
 
 Thanks,
 
 Jijun
 




Re: How to fix libvirt storage pool refresh issue?

2013-08-02 Thread Wido den Hollander



On 08/02/2013 01:22 PM, Wei ZHOU wrote:

Wido,

You applied the libvirt patch on your production system, and this issue
disappeared, right?


Yes, I applied that patch and rebuild libvirt. The issue never came back.


If so, that is good.
I expect the redhat community can accep the patch (or the v2
https://www.redhat.com/archives/libvir-list/2013-July/msg00639.html) ASAP.



I've been watching the thread, but it seems kind of dead.

Wido



-Wei


2013/8/2 Wido den Hollander w...@widodh.nl




On 08/02/2013 01:55 AM, Edison Su wrote:


Hi Wei, regarding to the bug CLOUDSTACK-2729, I removed storage.refresh
during getStoragePool in LibvirtStorageAdaptor, but the issue still
happened in BVT.
I am thinking add file lock on primary storage, seems you already have
the patch, could you share the patch with us?



Fyi, I fixed this by patching the libvirt on our production systems rather
then fixing the CloudStack agent.

It's just one very small patch: https://bugzilla.redhat.com/**
show_bug.cgi?id=977706https://bugzilla.redhat.com/show_bug.cgi?id=977706

https://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.htmlhttps://www.redhat.com/archives/libvir-list/2013-July/msg00635.html

Wido


  -Original Message-

From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: Tuesday, July 16, 2013 3:35 AM
To: dev@cloudstack.apache.org
Subject: Re: How to fix libvirt storage pool refresh issue?

I agree with Wido.

Moreover, the file lock will cause performane degrade of VM deployment.

-Wei


2013/7/16 Wido den Hollander w...@widodh.nl

  On 07/16/2013 12:27 AM, Marcus Sorensen wrote:


   I'm ok with a symptom fix on our end, if the root cause is in

Libvirt we can't do much about that. This is the sort of patch that
tends to get pulled into the regular update cycle of the
distributions, so unless there's more to it and it's not a good fix I
imagine we will see it come through without having to wait for the
next point releases. We still have to support existing users who
might not be running the latest, though, so the symptom fix is
probably ok as a temporary measure.



I'm ok with not calling storagePoolRefresh every time we want a
capacity update, since that's also kind of I/O intensive for larger
storage


arrays.



However, we should make sure we have a GOOD comment in the code


about


this fix, since that's the reason I initially removed the old code
which invoked df.

I'll see if I can get this libvirt patch into Ubuntu when it hits
libvirt upstream, since this bug is really annoying.

Wido



  On Mon, Jul 15, 2013 at 3:42 PM, Edison Su edison...@citrix.com

wrote:

  There is a serious issue on 
KVM(https://issues.apache.org/https://issues.apache.org/**

jira/browse/CLOUDSTACK-


2729https://issues.apache.**org/jira/browse/CLOUDSTACK-**2729https://issues.apache.org/jira/browse/CLOUDSTACK-2729

):



a libvirt storage pool can disappear on KVM host, it's easy to be

reproduced in our internal QA environment.
Wei found the root cause, is on the libvirt:

This is a libvirt issue. I created a ticket for it.
https://bugzilla.redhat.com/show_bug.cgi?id=977706https://bugzilla.redhat.com/**show_bug.cgi?id=977706
https:/**/bugzill https://bugzill
a.redhat.com/show_bug.cgi?id=**977706http://a.redhat.com/show_bug.cgi?id=977706



The patch is very simple.
https://www.redhat.com/archives/libvir-list/2013-
July/msg00635.hhttps://www.redhat.com/**archives/libvir-list/2013-**July/msg00635.h
tmlhttps://www.redhat.com/**archives/libvir-list/2013-**
July/msg00635.hhttps://www.redhat.com/archives/libvir-list/2013-July/msg00635.h
tml

But it's also introduced by CloudStack, as cloudstack will call
libvirt storage pool refresh method each time when access the
storage pool. The code is added by commit:
2ffc9907f7b0d371737e39b7649f7af23026f5cf,
about less than one year ago.

As Wei suggested, we can call storage pool refresh only if needed,
it will mitigate the issue(It's behavior I did on cloudstack
pre-4.0), but it's only treat the symptom, not the cause.
Or add a cluster wide lock, only one guy can access storage pool at
one time, we can add a file lock on NFS primary storage.
Any idea/feedback on how to fix this KVM issue?











Review Request 13238: JIRA-3701 : VM instantiation : Sending network information to a new VM instance

2013-08-02 Thread Nicolas FOATA

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13238/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Abstract/suggestion:
While a VM is instantiated, CloudStack could also send the following 
information if need be :
- the instance name (CS uuid)
- the display name
- VM tags
- network information (IPv4, IPv6, netmask, routing, gateway, mac address, etc.)
just if we activate some global settings such as :
- vm.instance.boot.network.required (true/false)
- vm.instance.boot.vmname (true/false)
- vm.instance.boot.uuid (true/false)
- vm.instance.boot.tags (true/false) 
 
Applications:
- A VM could discover its network and dialog with physical and virtual 
machines, etc.
- A VM do not need a virtual router
- According of this type of information (tags, names, …) , management servers 
could be able to configure and deploy correctly  VMs.


Diffs
-

  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
 7173f0b 
  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
 11a7b42 
  server/src/com/cloud/configuration/Config.java c815c77 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 

Diff: https://reviews.apache.org/r/13238/diff/


Testing
---

Set global settings : instanciantion of VMs : checking if extra parameters are 
corrected and well send (even in base64URLSafe + / = - _)


Thanks,

Nicolas FOATA



[Doc] Egress Firewall Rules for Review

2013-08-02 Thread Radhika Puthiyetath
Hi,

Egress Firewall Rules documentation is ready for review. The doc is attached at 
https://issues.apache.org/jira/browse/CLOUDSTACK-2685

Please see 15.22.2. Egress Firewall Rules in Advanced Zone(165), and provide 
your feedback.

Regards
-Radhika




[Doc] IP Address Reservation is Ready for Review

2013-08-02 Thread Radhika Puthiyetath
Hi,

IP Reservation documentation is ready for review. The doc is attached at 
https://issues.apache.org/jira/browse/CLOUDSTACK-850.

Please see 15.7. IP Reservation in Isolated Guest Networks, and provide your 
feedback.

Regards
-Radhika




Re: Review Request 13238: JIRA-3701 : VM instantiation : Sending network information to a new VM instance

2013-08-02 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13238/#review24526
---


Review 13238 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #108 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/108/

- Jenkins Cloudstack.org


On Aug. 2, 2013, 11:56 a.m., Nicolas FOATA wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13238/
 ---
 
 (Updated Aug. 2, 2013, 11:56 a.m.)
 
 
 Review request for cloudstack.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Abstract/suggestion:
 While a VM is instantiated, CloudStack could also send the following 
 information if need be :
 - the instance name (CS uuid)
 - the display name
 - VM tags
 - network information (IPv4, IPv6, netmask, routing, gateway, mac address, 
 etc.)
 just if we activate some global settings such as :
 - vm.instance.boot.network.required (true/false)
 - vm.instance.boot.vmname (true/false)
 - vm.instance.boot.uuid (true/false)
 - vm.instance.boot.tags (true/false) 
  
 Applications:
 - A VM could discover its network and dialog with physical and virtual 
 machines, etc.
 - A VM do not need a virtual router
 - According of this type of information (tags, names, …) , management servers 
 could be able to configure and deploy correctly  VMs.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
  7173f0b 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
  11a7b42 
   server/src/com/cloud/configuration/Config.java c815c77 
   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f 
 
 Diff: https://reviews.apache.org/r/13238/diff/
 
 
 Testing
 ---
 
 Set global settings : instanciantion of VMs : checking if extra parameters 
 are corrected and well send (even in base64URLSafe + / = - _)
 
 
 Thanks,
 
 Nicolas FOATA
 




[Doc] PVLAN Doc is Ready for Review

2013-08-02 Thread Radhika Puthiyetath
Hi,

PVLAN  documentation is ready for review. The doc is attached at 
https://issues.apache.org/jira/browse/CLOUDSTACK-850.

Please see 15.14. Isolation in Advanced Zone Using Private VLAN (141), and 
provide your feedback.

Regards
-Radhika




Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread Wei Zhou

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13223/
---

(Updated Aug. 2, 2013, 1:03 p.m.)


Review request for cloudstack, edison su and Wido den Hollander.


Changes
---

add some comments


Bugs: CLOUDSTACK-2729


Repository: cloudstack-git


Description
---

The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt 
(https://bugzilla.redhat.com/show_bug.cgi?id=977706)
We need to prevent deleting a volume when refreshing the pool.
This patch use a simple file lock to implement it.

PS: I have tested another file lock similar to Read/Write file lock, but it was 
very unstable.


Diffs (updated)
-

  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
 a9baa52 

Diff: https://reviews.apache.org/r/13223/diff/


Testing
---

Applied on 4.0.2 and 4.0.1

Testing On 4.0.1 From 20,June
3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes 
later. expunge.inteval = 600 (10 minutes), expunge.worker = 2
 

Testing On 4.0.2 From 01,July
2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 minutes 
later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 


Thanks,

Wei Zhou



Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-02 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

dealt with some warnings in NetworkServiceImpl


Diffs
-

  server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 

Diff: https://reviews.apache.org/r/13240/diff/


Testing
---


Thanks,

daan Hoogland



Re: Review Request 13127: UI Plugin Internationalization

2013-08-02 Thread Chris Suich

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13127/
---

(Updated Aug. 2, 2013, 1:36 p.m.)


Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.


Repository: cloudstack-git


Description
---

This allows UI Plugins to contribute their own internationalized strings to the 
global js dictionary. Each plugin would define a dictionary.js and several 
dictionary_locale.js files. As each plugin is loaded, the appropriate plugin 
dictionary is loaded into the global js dictionary (with the global dictionary 
taking precedence in the event of a conflict).


Diffs
-

  ui/scripts/plugins.js 96ed229 

Diff: https://reviews.apache.org/r/13127/diff/


Testing
---


Thanks,

Chris Suich



Re: Review Request 13128: Zone Chart Extension

2013-08-02 Thread Chris Suich

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13128/
---

(Updated Aug. 2, 2013, 1:37 p.m.)


Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.


Repository: cloudstack-git


Description
---

I have extended some functions in zoneChart.js to allow plugins to create 
charts by simply defining their own function which assembles the chart itself 
rather than having to define the chart in zoneChart.js


Diffs
-

  ui/scripts/ui-custom/zoneChart.js 1a5fb59 

Diff: https://reviews.apache.org/r/13128/diff/


Testing
---


Thanks,

Chris Suich



Review Request 13241: was not populating the overcommit details in uservm details when overcommit is decreased to one.

2013-08-02 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13241/
---

Review request for cloudstack and Abhinandan Prateek.


Bugs: Cloudstack-1695


Repository: cloudstack-git


Description
---

was not populating the overcommit details in uservm details when overcommit is 
decreased to one.


Diffs
-

  server/src/com/cloud/vm/VirtualMachineManagerImpl.java cf24502 

Diff: https://reviews.apache.org/r/13241/diff/


Testing
---

Tested on 4.2


Thanks,

bharat kumar



Re: Review Request 13132: Field default value functions

2013-08-02 Thread Chris Suich

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13132/
---

(Updated Aug. 2, 2013, 1:37 p.m.)


Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.


Repository: cloudstack-git


Description
---

Currently, the default value for a UI field must be a constant. I have extended 
the dialog forms to allow default value functions which are given the standard 
'args' allowing default values to be determined at run time.


Diffs
-

  ui/scripts/sharedFunctions.js 8ddaeaf 
  ui/scripts/ui/dialog.js 1ff5401 

Diff: https://reviews.apache.org/r/13132/diff/


Testing
---


Thanks,

Chris Suich



Re: Review Request 13131: Default field identifier

2013-08-02 Thread Chris Suich

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13131/
---

(Updated Aug. 2, 2013, 1:38 p.m.)


Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.


Repository: cloudstack-git


Description
---

Currently, the identifying value of json objects is assumed to be 'id' or 
'name' (if 'id' doesn't exist). I have added the option of allowing fields to 
specify which json property should be the identifying value of an object.

For some reason, it says that ui/scripts/ui/dialog.js can not be found in the 
repository, so I have added the patch file manually. Please let me know if 
there is some way to fix this.


Diffs
-


Diff: https://reviews.apache.org/r/13131/diff/


Testing
---


File Attachments



  
https://reviews.apache.org/media/uploaded/files/2013/07/31/field-identify-value.patch


Thanks,

Chris Suich



Re: Review Request 13241: was not populating the overcommit details in uservm details when overcommit is decreased to one.

2013-08-02 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13241/#review24528
---

Ship it!


Ship It!

- Abhinandan Prateek


On Aug. 2, 2013, 1:36 p.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13241/
 ---
 
 (Updated Aug. 2, 2013, 1:36 p.m.)
 
 
 Review request for cloudstack and Abhinandan Prateek.
 
 
 Bugs: Cloudstack-1695
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 was not populating the overcommit details in uservm details when overcommit 
 is decreased to one.
 
 
 Diffs
 -
 
   server/src/com/cloud/vm/VirtualMachineManagerImpl.java cf24502 
 
 Diff: https://reviews.apache.org/r/13241/diff/
 
 
 Testing
 ---
 
 Tested on 4.2
 
 
 Thanks,
 
 bharat kumar
 




Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-02 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/#review24529
---


Review 13240 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #109 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/109/

- Jenkins Cloudstack.org


On Aug. 2, 2013, 1:15 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13240/
 ---
 
 (Updated Aug. 2, 2013, 1:15 p.m.)
 
 
 Review request for cloudstack.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 dealt with some warnings in NetworkServiceImpl
 
 
 Diffs
 -
 
   server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 
 
 Diff: https://reviews.apache.org/r/13240/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




RE: Review Request 13072: Print agent host name in logging of agent commands

2013-08-02 Thread Alex Huang
Yes.  I like the idea but we should just load the hostname during the attache's 
creation rather than on every communication.

--Alex

 -Original Message-
 From: Chiradeep Vittal
 Sent: Thursday, August 1, 2013 11:20 PM
 To: dev@cloudstack.apache.org; Marcus Sorensen
 Cc: cloudstack; Alex Huang
 Subject: Re: Review Request 13072: Print agent host name in logging of agent
 commands
 
 This of course introduces an extra DB call during EVERY agent communication.
 If there was a cache, not a big deal, but as it so happens, there isn't one.
 
 On 8/1/13 10:10 PM, Koushik Das koushik@citrix.com wrote:
 
 I see your point Marcus.
 I felt that accessing the database would be simpler but you are right
 that everyone may not have access to it. Actually the CS logs do
 mention the host names as well but in a different place and based on
 that you can match the id to a name. For e.g. if you look for agent
 status logs that mentions both id and name.
 
 2013-07-29 10:09:47,124 DEBUG [c.c.h.Status] (AgentTaskPool-3:null)
 Transition:[Resource state = Enabled, Agent event = Ping, Host id = 1,
 name = xenserver-kd1]
 2013-07-29 10:09:47,136 DEBUG [c.c.h.Status] (AgentTaskPool-3:null)
 Agent status update: [id = 1; name = xenserver-kd1; old status = Up;
 event = Ping; new status = Up; old update count = 78; new update count
 = 79]
 
 2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null)
 Seq
 1-1386348573: Sending  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1,
 Flags: 100011,
 [{com.cloud.agent.api.StopCommand:{isProxy:false,executeInSequen
 ce
 :f alse,vmName:i-2-45-VM,wait:0}}] }
 2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null)
 Seq
 1-1386348573: Executing:  { Cmd , MgmtId: 2546680725505, via: 1, Ver:
 v1,
 Flags: 100011,
 [{com.cloud.agent.api.StopCommand:{isProxy:false,executeInSequen
 ce
 :f alse,vmName:i-2-45-VM,wait:0}}] }
 
 
 The changes you have made would definitely improve the readability.
 
 -Koushik
 
 From: Marcus Sorensen [mailto:shadow...@gmail.com]
 Sent: Thursday, August 01, 2013 7:26 PM
 To: Koushik Das
 Cc: cloudstack
 Subject: Re: Review Request 13072: Print agent host name in logging of
 agent commands
 
 
 I agree, that would be useful.
 
 The issue im resolving here is that 1) not everyone who has access to
 look at the logs and troubleshoot also has access to (or knows the
 schema
 of) the database. There might be an issue with a KVM host, but the
 admin will waste time manually hunting down which host the command
 went
 to because he has no idea what via:1237 means and 2) even with db
 access, its a major pain to go hunt down the unencrypted db
 password(because its a long string that's hard to memorize), log into
 the database, run a query, just to know where to continue your debugging.
 
 A little background: Most of the people who surf these logs aren't devs.
 For us they are usually devs, but not cloudstack devs. Maybe UI guys or
 some other consumer. It has happened several times where someone
 comes
 into my office, points out an agent command, and says any idea where
 that went?. I pretty much have the numbers memorized by now,
 depending
 on the zone, so I tell them which agent the command went to. Then they
 ask me where I found that, and when I explain that this little via: 85
 means to go log into the db and make an SQL query for vm_instance 85, I
 almost always get some gee that's useful, how was I ever supposed to
 know that response.
 
 So I do agree that the correlations you mention would also be good, I
 disagree with the idea that there is not much value in doing this.
 On Aug 1, 2013 6:06 AM, Koushik Das
 koushik@citrix.commailto:koushik@citrix.com wrote:
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13072/
 
 
 
 
 The changes look fine but I don't see much value with this as the name
 can be easily identified from the db. I feel the logs are used
 primarily for debugging issues. And one key aspect that is missing
 currently is the correlation of logs. Currently when a API call is made
 to MS, it traverses through various layers in the MS and finally
 hitting the resource layer and then returns back with response. Logs
 gets generated from each layer but it is not very intuitive to relate them to
 API call.
 If there is a unique id (some kind of uuid) that gets appended to the
 logs for a specific API call then correlation becomes very easy.
 
 
 
 I feel adding these kind of correlation would be much more useful.
 
 
 - Koushik Das
 
 
 On July 30th, 2013, 5:37 p.m. UTC, Marcus Sorensen wrote:
 Review request for cloudstack.
 By Marcus Sorensen.
 
 Updated July 30, 2013, 5:37 p.m.
 Bugs: CLOUDSTACK-3872
 Repository: cloudstack-git
 Description
 
 Print agent name when logging Commands sent to VM hosts. See bug
 description.  I'm not super familiar with this code, so I'd like
 someone to look over it and verify it's the right thing.
 
 
 Testing
 
 Tested on KVM zone, need 

Re: Review Request 13072: Print agent host name in logging of agent commands

2013-08-02 Thread Marcus Sorensen
Yes, I thought of that, which is one of the reasons I asked for feedback.
I'm not quite sure how to do it the was Alex suggests, but I'll look into
it. I'm guessing some sort of id to hostname map that populates as attaches
are created.
On Aug 2, 2013 12:19 AM, Chiradeep Vittal chiradeep.vit...@citrix.com
wrote:

 This of course introduces an extra DB call during EVERY agent
 communication.
 If there was a cache, not a big deal, but as it so happens, there isn't
 one.

 On 8/1/13 10:10 PM, Koushik Das koushik@citrix.com wrote:

 I see your point Marcus.
 I felt that accessing the database would be simpler but you are right
 that everyone may not have access to it. Actually the CS logs do mention
 the host names as well but in a different place and based on that you can
 match the id to a name. For e.g. if you look for agent status logs that
 mentions both id and name.
 
 2013-07-29 10:09:47,124 DEBUG [c.c.h.Status] (AgentTaskPool-3:null)
 Transition:[Resource state = Enabled, Agent event = Ping, Host id = 1,
 name = xenserver-kd1]
 2013-07-29 10:09:47,136 DEBUG [c.c.h.Status] (AgentTaskPool-3:null) Agent
 status update: [id = 1; name = xenserver-kd1; old status = Up; event =
 Ping; new status = Up; old update count = 78; new update count = 79]
 
 2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null) Seq
 1-1386348573: Sending  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1,
 Flags: 100011,
 [{com.cloud.agent.api.StopCommand:{isProxy:false,executeInSequence:f
 alse,vmName:i-2-45-VM,wait:0}}] }
 2013-07-29 10:09:47,736 DEBUG [c.c.a.t.Request] (DirectAgent-24:null) Seq
 1-1386348573: Executing:  { Cmd , MgmtId: 2546680725505, via: 1, Ver: v1,
 Flags: 100011,
 [{com.cloud.agent.api.StopCommand:{isProxy:false,executeInSequence:f
 alse,vmName:i-2-45-VM,wait:0}}] }
 
 
 The changes you have made would definitely improve the readability.
 
 -Koushik
 
 From: Marcus Sorensen [mailto:shadow...@gmail.com]
 Sent: Thursday, August 01, 2013 7:26 PM
 To: Koushik Das
 Cc: cloudstack
 Subject: Re: Review Request 13072: Print agent host name in logging of
 agent commands
 
 
 I agree, that would be useful.
 
 The issue im resolving here is that 1) not everyone who has access to
 look at the logs and troubleshoot also has access to (or knows the schema
 of) the database. There might be an issue with a KVM host, but the admin
 will waste time manually hunting down which host the command went to
 because he has no idea what via:1237 means and 2) even with db access,
 its a major pain to go hunt down the unencrypted db password(because its
 a long string that's hard to memorize), log into the database, run a
 query, just to know where to continue your debugging.
 
 A little background: Most of the people who surf these logs aren't devs.
 For us they are usually devs, but not cloudstack devs. Maybe UI guys or
 some other consumer. It has happened several times where someone comes
 into my office, points out an agent command, and says any idea where
 that went?. I pretty much have the numbers memorized by now, depending
 on the zone, so I tell them which agent the command went to. Then they
 ask me where I found that, and when I explain that this little via: 85
 means to go log into the db and make an SQL query for vm_instance 85, I
 almost always get some gee that's useful, how was I ever supposed to
 know that response.
 
 So I do agree that the correlations you mention would also be good, I
 disagree with the idea that there is not much value in doing this.
 On Aug 1, 2013 6:06 AM, Koushik Das
 koushik@citrix.commailto:koushik@citrix.com wrote:
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13072/
 
 
 
 
 The changes look fine but I don't see much value with this as the name
 can be easily identified from the db. I feel the logs are used primarily
 for debugging issues. And one key aspect that is missing currently is the
 correlation of logs. Currently when a API call is made to MS, it
 traverses through various layers in the MS and finally hitting the
 resource layer and then returns back with response. Logs gets generated
 from each layer but it is not very intuitive to relate them to API call.
 If there is a unique id (some kind of uuid) that gets appended to the
 logs for a specific API call then correlation becomes very easy.
 
 
 
 I feel adding these kind of correlation would be much more useful.
 
 
 - Koushik Das
 
 
 On July 30th, 2013, 5:37 p.m. UTC, Marcus Sorensen wrote:
 Review request for cloudstack.
 By Marcus Sorensen.
 
 Updated July 30, 2013, 5:37 p.m.
 Bugs: CLOUDSTACK-3872
 Repository: cloudstack-git
 Description
 
 Print agent name when logging Commands sent to VM hosts. See bug
 description.  I'm not super familiar with this code, so I'd like someone
 to look over it and verify it's the right thing.
 
 
 Testing
 
 Tested on KVM zone, need help testing others.
 
 
 Diffs
 
   *   core/src/com/cloud/agent/transport/Request.java 

Re: Review Request 13241: was not populating the overcommit details in uservm details when overcommit is decreased to one.

2013-08-02 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13241/#review24530
---


Review 13241 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #110 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/110/

- Jenkins Cloudstack.org


On Aug. 2, 2013, 1:36 p.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13241/
 ---
 
 (Updated Aug. 2, 2013, 1:36 p.m.)
 
 
 Review request for cloudstack and Abhinandan Prateek.
 
 
 Bugs: Cloudstack-1695
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 was not populating the overcommit details in uservm details when overcommit 
 is decreased to one.
 
 
 Diffs
 -
 
   server/src/com/cloud/vm/VirtualMachineManagerImpl.java cf24502 
 
 Diff: https://reviews.apache.org/r/13241/diff/
 
 
 Testing
 ---
 
 Tested on 4.2
 
 
 Thanks,
 
 bharat kumar
 




Re: [4.1] getVMPassword how to decrypt

2013-08-02 Thread David Nalley
No it doesn't. Keeping both destroys the benefit of public key
cryptography. The idea is that you can hand out the public key and never
need share the private.
On Aug 2, 2013 7:02 AM, Antonio Petrocelli a.petroce...@netsons.com
wrote:

  This key must alreay be on the system...

 Only i need to retrieve it API wan't i need a different solution

 Thanks

 Il 02/08/2013 12:51, Wei ZHOU ha scritto:

  Antonio,

 For almost all clients, they do not want the provider storing the private
 key (on management server). It is a big security risk for clients.
 You have to store the key by yourself.

 -Wei


 2013/8/2 Antonio Petrocelli a.petroce...@netsons.com

  Thanks a lot.

 It work.

 I'm unable to retrive PRIVATEKEY with API call:
 http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/listSSHKeyPairs.html

 the only way to retrieve is from:
 http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/createSSHKeyPair.html

 but i don't want store this key...

 Do you now how i can retrieve it?

 Thanks.

 Regards.

 Il 01/08/2013 16:47, Harikrishna Patnala ha scritto:

 Yes the password is encrypted with public key of ssh key pair assigned to 
 the guest VM during deployment.
 We can decrypt it using the private key of that key pair.

 -Harikrishna

 On 01-Aug-2013, at 3:13 AM, Chiradeep Vittal 
 chiradeep.vit...@citrix.commailto:chiradeep.vit...@citrix.com 
 chiradeep.vit...@citrix.com wrote:

 Isn't this encrypted with the ssh keys of the user? (createSshKeyPair)

 From: Antonio Petrocelli 
 a.petroce...@netsons.commailto:a.petroce...@netsons.com 
 a.petroce...@netsons.com
 Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.org
 Date: Tuesday, July 30, 2013 2:46 AM
 To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.org
 Subject: [4.1] getVMPassword  how to decrypt

 Hello,
 http://cloudstack.apache.org/docs/api/apidocs-4.1/domain_admin/getVMPassword.html

 after retrieved the password i'm unable to decrypt the encryptedpassword.

 Suggestions?

 Thanks.

 Regards.
 --

 netsons-logo-email.png

 Supernova s.r.l.
 Via G. Misiticoni, 3
 65126 - Pescara
 ITALY
 www.netsons.comhttp://www.netsons.com/ http://www.netsons.com/
 Antonio Petrocelli
 Software Engineer


 t. (+39) 085 45 100 52
 e. a.petroce...@netsons.commailto:a.petroce...@netsons.com 
 a.petroce...@netsons.com


 btn_viewmy_160x25.pnghttp://it.linkedin.com/pub/antonio-petrocelli/18/611/619
  http://it.linkedin.com/pub/antonio-petrocelli/18/611/619


 Netsons® è un marchio registrato dalla Supernova s.r.l.

 Le informazioni trasmesse sono riservate alla persona o alla società 
 indicata come destinatario, e possono includere contenuti considerati 
 confidenziali. Ogni elaborazione, comunicazione, trasmissione o altro 
 utilizzo, anche azioni conseguenti alla conoscenza di queste informazioni da 
 parte di chiunque non sia espressamente indicato come destinatario è 
 proibita. Nel caso abbiate ricevuto per errore questa comunicazione, siete 
 pregati di darne avviso a info [at] netsons.comhttp://netsons.com 
 http://netsons.com ed eliminare ogni stampa ed ogni traccia informatica. 
 Il ricevente dovrà inoltre accertarsi che gli eventuali allegati non 
 contengano virus prima di aprirli. Qualunque opinione o affermazione 
 presentata in questo messaggio è da ritenersi propria dell'autore e non 
 rappresenta necessariamente la posizione della Societagr
 ave;.

 The information transmitted is intended only for the person or entity to 
 which it is addressed and may contain confidential material. Any review, 
 retransmission, dissemination or other use of, or taking of any action in 
 reliance upon this information by persons or entities other than the 
 intended recipient is prohibited. If you received this in error, please 
 contact: info [at] netsons.comhttp://netsons.com http://netsons.com and 
 delete the material from any computer. If this email contains attachments 
 you should ensure they are checked for viruses before opening them. Any 
 views or opinions presented are solely those of the author and do not 
 necessarily represent those of the company.






Force delete domain through test case

2013-08-02 Thread Gaurav Aradhye
Hi all,

While forcefully deleting a domain through test case, it fails. The
resources in the domain and the domain itself gets cleaned up, but the code
fails with following error.
After cleaning up the resources, it says can't find the specific domain.

Has anybody seen this issue before?

Log:

2013-08-03 00:51:50,657 DEBUG [cloud.user.DomainManagerImpl]
(Job-Executor-3:job-34 = [ a1e2cf53-6768-4571-9e4b-5749b4667bb0 ]) Deleting
networks for domain id=
2
2013-08-03 00:51:50,669 ERROR [domain.dao.DomainDaoImpl]
(Job-Executor-3:job-34 = [ a1e2cf53-6768-4571-9e4b-5749b4667bb0 ]) Unable
to remove domain as domain 2
no longer exists
2013-08-03 00:51:50,685 ERROR [cloud.user.DomainManagerImpl]
(Job-Executor-3:job-34 = [ a1e2cf53-6768-4571-9e4b-5749b4667bb0 ])
Exception deleting domain with i
d 2
com.cloud.utils.exception.CloudRuntimeException: Failed to clean up domain
resources and sub domains, delete failed on domain Domain-JVH211 (id: 2).
at
com.cloud.user.DomainManagerImpl.deleteDomain(DomainManagerImpl.java:243)
at
com.cloud.user.DomainManagerImpl.deleteDomain(DomainManagerImpl.java:226)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
org.apache.cloudstack.region.RegionManagerImpl.deleteDomain(RegionManagerImpl.java:231)
at
org.apache.cloudstack.region.RegionServiceImpl.deleteDomain(RegionServiceImpl.java:166)
2013-08-03 00:51:50,685 ERROR [cloud.user.DomainManagerImpl]
(Job-Executor-3:job-34 = [ a1e2cf53-6768-4571-9e4b-5749b4667bb0 ])
Exception deleting domain with i
d 2
com.cloud.utils.exception.CloudRuntimeException: Failed to clean up domain
resources and sub domains, delete failed on domain Domain-JVH211 (id: 2).
at
com.cloud.user.DomainManagerImpl.deleteDomain(DomainManagerImpl.java:243)
at
com.cloud.user.DomainManagerImpl.deleteDomain(DomainManagerImpl.java:226)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
org.apache.cloudstack.region.RegionManagerImpl.deleteDomain(RegionManagerImpl.java:231)
at
org.apache.cloudstack.region.RegionServiceImpl.deleteDomain(RegionServiceImpl.java:166)
at
org.apache.cloudstack.api.command.admin.domain.DeleteDomainCmd.execute(DeleteDomainCmd.java:99)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
at
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:679)
2013-08-03 00:51:50,690 DEBUG [cloud.user.DomainManagerImpl]
(Job-Executor-3:job-34 = [ a1e2cf53-6768-4571-9e4b-5749b4667bb0 ]) Changing
domain id=2 state back
to Active because it can't be removed due to resources referencing to it
2013-08-03 00:51:50,731 ERROR [cloud.async.AsyncJobManagerImpl]
(Job-Executor-3:job-34 = [ a1e2cf53-6768-4571-9e4b-5749b4667bb0 ])
Unexpected exception while ex
ecuting org.apache.cloudstack.api.command.admin.domain.DeleteDomainCmd
com.cloud.utils.exception.CloudRuntimeException: Failed to clean up domain
resources and sub domains, delete failed on domain Domain-JVH211 (id: 2).
at
com.cloud.user.DomainManagerImpl.deleteDomain(DomainManagerImpl.java:243)
at
com.cloud.user.DomainManagerImpl.deleteDomain(DomainManagerImpl.java:226)
at
com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
at
org.apache.cloudstack.region.RegionManagerImpl.deleteDomain(RegionManagerImpl.java:231)
at
org.apache.cloudstack.region.RegionServiceImpl.deleteDomain(RegionServiceImpl.java:166)
at
org.apache.cloudstack.api.command.admin.domain.DeleteDomainCmd.execute(DeleteDomainCmd.java:99)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:158)
at
com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:531)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:679)
2013-08-03 00:51:50,741 DEBUG [cloud.async.AsyncJobManagerImpl]
(Job-Executor-3:job-34 = [ 

RE: [DISCUSS] [jira] make affectedVersion field mandatory.....

2013-08-02 Thread Toshiaki Hatano
+1

Thanks,
--
Toshiaki

-Original Message-
From: Koushik Das [mailto:koushik@citrix.com] 
Sent: Friday, August 02, 2013 05:25
To: dev@cloudstack.apache.org
Subject: RE: [DISCUSS] [jira] make affectedVersion field mandatory.

+1

 -Original Message-
 From: Ram Ganesh [mailto:ram.gan...@citrix.com]
 Sent: Friday, August 02, 2013 4:38 PM
 To: dev@cloudstack.apache.org
 Subject: [DISCUSS] [jira] make affectedVersion field mandatory.
 
 Hi,
 
 While triaging bugs I noticed that many bugs had affectedVersion field 
 as empty.  This makes it difficult to guess the version/release the 
 reporter was on while filing the bug. Can we make the affectedVersion 
 field a mandatory field instead?
 
 Thanks,
 RamG



This email message is intended for the use of the person to whom it has been 
sent, and may contain information that is confidential or legally protected. If 
you are not the intended recipient or have received this message in error, you 
are not authorized to copy, distribute, or otherwise use this message or its 
attachments. Please notify the sender immediately by return e-mail and 
permanently delete this message and any attachments. Verio Inc. makes no 
warranty that this email is error or virus free.  Thank you.


Re: Review Request 13190: CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate parameter rather than olderthan parameter in the archive/delete alerts/events API.

2013-08-02 Thread Brian Federle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13190/#review24538
---

Ship it!


Ship It!

- Brian Federle


On Aug. 1, 2013, 11:05 a.m., Sanjay Tripathi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13190/
 ---
 
 (Updated Aug. 1, 2013, 11:05 a.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Bugs: CLOUDSTACK-4010
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate
  parameter rather than olderthan parameter in the archive/delete 
 alerts/events API.
 
 
 Diffs
 -
 
   ui/scripts/events.js 873998e 
 
 Diff: https://reviews.apache.org/r/13190/diff/
 
 
 Testing
 ---
 
 Veirified the fix and functionality locally on cloudstack setup.
 
 
 Thanks,
 
 Sanjay Tripathi
 




Re: Review Request 13190: CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate parameter rather than olderthan parameter in the archive/delete alerts/events API.

2013-08-02 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13190/#review24541
---


Commit 977b0eca973b721fe158768f3f3c5515b9d2aab7 in branch refs/heads/master 
from Brian Federle
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=977b0ec ]

CLOUDSTACK-4010: Events/alerts: Pass start date / end date

Original submitter: Sanjay Tripathi sanjay.tripa...@citrix.com
Reviewed by: Brian Federle brian.fede...@citrix.com


- ASF Subversion and Git Services


On Aug. 1, 2013, 11:05 a.m., Sanjay Tripathi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13190/
 ---
 
 (Updated Aug. 1, 2013, 11:05 a.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Bugs: CLOUDSTACK-4010
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate
  parameter rather than olderthan parameter in the archive/delete 
 alerts/events API.
 
 
 Diffs
 -
 
   ui/scripts/events.js 873998e 
 
 Diff: https://reviews.apache.org/r/13190/diff/
 
 
 Testing
 ---
 
 Veirified the fix and functionality locally on cloudstack setup.
 
 
 Thanks,
 
 Sanjay Tripathi
 




Re: Review Request 13190: CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate parameter rather than olderthan parameter in the archive/delete alerts/events API.

2013-08-02 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13190/#review24540
---


Commit 80ae4830ae63ab73a06ab033bc3feb3dd701cbb2 in branch refs/heads/4.2 from 
Brian Federle
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=80ae483 ]

CLOUDSTACK-4010: Events/alerts: Pass start date / end date

Original submitter: Sanjay Tripathi sanjay.tripa...@citrix.com
Reviewed by: Brian Federle brian.fede...@citrix.com


- ASF Subversion and Git Services


On Aug. 1, 2013, 11:05 a.m., Sanjay Tripathi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13190/
 ---
 
 (Updated Aug. 1, 2013, 11:05 a.m.)
 
 
 Review request for cloudstack, Brian Federle and Jessica Wang.
 
 
 Bugs: CLOUDSTACK-4010
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
  CLOUDSTACK-4010: Change required in the UI to pass startdate/enddate
  parameter rather than olderthan parameter in the archive/delete 
 alerts/events API.
 
 
 Diffs
 -
 
   ui/scripts/events.js 873998e 
 
 Diff: https://reviews.apache.org/r/13190/diff/
 
 
 Testing
 ---
 
 Veirified the fix and functionality locally on cloudstack setup.
 
 
 Thanks,
 
 Sanjay Tripathi
 




RE: Reverting 17267794adb2bab923fb20515a7b943780d61921

2013-08-02 Thread Alex Huang
Ok...i spoke too soon.  Just talked with Prasanna.  He pointed out that it's a 
large change that's been in since May.  So I won't revert it.  But the rule is 
no one can change create-schema.sql until the community decided we want to 
based off of a new copy of the create-schema.

--Alex

 -Original Message-
 From: Alex Huang [mailto:alex.hu...@citrix.com]
 Sent: Friday, August 2, 2013 10:01 AM
 To: Saksham Srivastava
 Cc: dev@cloudstack.apache.org
 Subject: Reverting 17267794adb2bab923fb20515a7b943780d61921
 
 Saksham,
 
 I'm reverting commit id: 17267794adb2bab923fb20515a7b943780d61921 in
 master.
 
 It changed the create-schema.sql.  We've established since 4.1 that create-
 schema.sql should not be changed and everything done through upgrades.  I
 believe this commit causes a fresh deployment to fail.
 
 --Alex


Re: How to enforce data disk selection

2013-08-02 Thread Mike Tutkowski
Exactly...through the current CS GUI, this is hard coded to be optional -
although it probably wouldn't be hard to make required if you change
instanceWizard.js.


On Fri, Aug 2, 2013 at 4:21 AM, Sanjay Tripathi
sanjay.tripa...@citrix.comwrote:

 There is no any gc to enforce the datadisk selection; perhaps you can hack
 instanceWizard.js file in ui-custom folder to disable the No thanks
 option.

 --Sanjay

  -Original Message-
  From: Musayev, Ilya [mailto:imusa...@webmd.net]
  Sent: Friday, August 02, 2013 3:17 PM
  To: dev@cloudstack.apache.org
  Subject: RE: How to enforce data disk selection
 
  Mike,
 
  That is correct, we need to enforce data disk selection when user goes
  through deploying instance wizard in UI.
 
  Is there a config to do this or should I hack some .js files?
 
  Thanks
  ilya
 
  -Original Message-
  From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
  Sent: Friday, August 02, 2013 1:36 AM
  To: dev@cloudstack.apache.org
  Subject: Re: How to enforce data disk selection
 
  Could you provide a little more info about where in the GUI you'd like to
  enforce the selection of a data disk? When kicking off a VM instance
  perhaps?
 
 
  On Thu, Aug 1, 2013 at 4:03 PM, Musayev, Ilya imusa...@webmd.net
  wrote:
 
   How would one enforce data disk selection?
  
   I don't want to leave data disk blank in UI.
  
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the
  cloudhttp://solidfire.com/solution/overview/?video=play
  *(tm)*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


Re: Review Request 13192: create private network test

2013-08-02 Thread Chiradeep Vittal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/#review24547
---



server/test/com/cloud/network/CreatePrivateNetworkTest.java
https://reviews.apache.org/r/13192/#comment48572

Use logger.error instead of printStackTrace? This way the logfile will 
contain the error.


- Chiradeep Vittal


On Aug. 1, 2013, 2:52 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13192/
 ---
 
 (Updated Aug. 1, 2013, 2:52 p.m.)
 
 
 Review request for cloudstack, Koushik Das and Sheng Yang.
 
 
 Bugs: CLOUDSTACK-1532
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It 
 occurred to me it can be submitted separately.
 
 
 Diffs
 -
 
   server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/13192/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: Unable to start domR(VR) in devcloud using laster 4.1/master.

2013-08-02 Thread Chiradeep Vittal
On 4.1?

On 8/2/13 1:05 AM, Nguyen Anh Tu ng.t...@gmail.com wrote:

Hi guys,

So how to fix this? I got the same error

Thanks,


2013/4/1 Rajesh Battala rajesh.batt...@citrix.com

 I had debugged and found that from devcloud unable to ssh to the router
 vm. When it tries to execute the GetDomRVersionCmd its getting failing
and
 router vm is getting destroyed.

 I had tried manually  ssh to router vm am getting Permission denied
 (publickey)

 I had tried changing the permission of my ssh folder and keys, still the
 same issue.
 -rw--- 1 root root 1674 Apr  1 15:38 id_rsa.cloud
 -rw--- 1 root root  394 Apr  1 15:38 id_rsa.cloud.pub
 -rw--- 1 root root  884 Apr  1 15:51 known_hosts

 How to resolve this issue?

 Here is the output of ssh with verbose mode. Am using devCloud with
 xenserver

 ssh -i .ssh/id_rsa.cloud -p 3922 169.254.0.105
 Permission denied (publickey).
 root@devcloud:~# ssh -vvv -i .ssh/id_rsa.cloud -p 3922 169.254.0.105
 OpenSSH_6.0p1 Debian-4, OpenSSL 1.0.1c 10 May 2012
 debug1: Reading configuration data /etc/ssh/ssh_config
 debug1: /etc/ssh/ssh_config line 19: Applying options for *
 debug2: ssh_connect: needpriv 0
 debug1: Connecting to 169.254.0.105 [169.254.0.105] port 3922.
 debug1: Connection established.
 debug1: permanently_set_uid: 0/0
 debug3: Incorrect RSA1 identifier
 debug3: Could not load .ssh/id_rsa.cloud as a RSA1 public key
 debug1: identity file .ssh/id_rsa.cloud type 1
 debug1: Checking blacklist file /usr/share/ssh/blacklist.RSA-2048
 debug1: Checking blacklist file /etc/ssh/blacklist.RSA-2048
 debug1: identity file .ssh/id_rsa.cloud-cert type -1
 debug1: Remote protocol version 2.0, remote software version
OpenSSH_5.5p1
 Debian-6+squeeze1
 debug1: match: OpenSSH_5.5p1 Debian-6+squeeze1 pat OpenSSH_5*
 debug1: Enabling compatibility mode for protocol 2.0
 debug1: Local version string SSH-2.0-OpenSSH_6.0p1 Debian-4
 debug2: fd 3 setting O_NONBLOCK
 debug3: put_host_port: [169.254.0.105]:3922
 debug3: load_hostkeys: loading entries for host [169.254.0.105]:3922
 from file /root/.ssh/known_hosts 
 debug3: load_hostkeys: found key type RSA in file
/root/.ssh/known_hosts:1
 debug3: load_hostkeys: loaded 1 keys
 debug3: order_hostkeyalgs: prefer hostkeyalgs:
 ssh-rsa-cert-...@openssh.com,ssh-rsa-cert-...@openssh.com,ssh-rsa
 debug1: SSH2_MSG_KEXINIT sent
 debug1: SSH2_MSG_KEXINIT received
 debug2: kex_parse_kexinit:
 
ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-g
roup-exchange-sha256,diffie-hellman-group-exchange-sha1,diffie-hellman-gr
oup14-sha1,diffie-hellman-group1-sh

  a1
 debug2: kex_parse_kexinit: ssh-rsa-cert-...@openssh.com,
 ssh-rsa-cert-...@openssh.com,ssh-rsa,
 ecdsa-sha2-nistp256-cert-...@openssh.com,
 
ecdsa-sha2-nistp384-cert-...@openssh.com,ecdsa-sha2-nistp521-cert-v01@ope
n
  ssh.com,ssh-dss-cert-...@openssh.com,ssh-dss-cert-...@openssh.com
 ,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,ssh-dss
 debug2: kex_parse_kexinit:
 
aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cb
c,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,
 rijndael-...@lysator.liu.se
 debug2: kex_parse_kexinit:
 
aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cb
c,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,
 rijndael-...@lysator.liu.se
 debug2: kex_parse_kexinit: hmac-md5,hmac-sha1,umac...@openssh.com
 
,hmac-sha2-256,hmac-sha2-256-96,hmac-sha2-512,hmac-sha2-512-96,hmac-ripem
d160,
 hmac-ripemd...@openssh.com,hmac-sha1-96,hmac-md5-96
 debug2: kex_parse_kexinit: hmac-md5,hmac-sha1,umac...@openssh.com
 
,hmac-sha2-256,hmac-sha2-256-96,hmac-sha2-512,hmac-sha2-512-96,hmac-ripem
d160,
 hmac-ripemd...@openssh.com,hmac-sha1-96,hmac-md5-96
 debug2: kex_parse_kexinit: none,z...@openssh.com,zlib
 debug2: kex_parse_kexinit: none,z...@openssh.com,zlib
 debug2: kex_parse_kexinit:
 debug2: kex_parse_kexinit:
 debug2: kex_parse_kexinit: first_kex_follows 0
 debug2: kex_parse_kexinit: reserved 0
 debug2: kex_parse_kexinit:
 
diffie-hellman-group-exchange-sha256,diffie-hellman-group-exchange-sha1,d
iffie-hellman-group14-sha1,diffie-hellman-group1-sha1
 debug2: kex_parse_kexinit: ssh-rsa,ssh-dss
 debug2: kex_parse_kexinit:
 
aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cb
c,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,
 rijndael-...@lysator.liu.se
 debug2: kex_parse_kexinit:
 
aes128-ctr,aes192-ctr,aes256-ctr,arcfour256,arcfour128,aes128-cbc,3des-cb
c,blowfish-cbc,cast128-cbc,aes192-cbc,aes256-cbc,arcfour,
 rijndael-...@lysator.liu.se
 debug2: kex_parse_kexinit: hmac-md5,hmac-sha1,umac...@openssh.com
 ,hmac-ripemd160,hmac-ripemd160@openssh. com,hmac-sha1-96,hmac-md5-96
 debug2: kex_parse_kexinit: hmac-md5,hmac-sha1,umac...@openssh.com
 ,hmac-ripemd160,hmac-ripemd160@openssh. com,hmac-sha1-96,hmac-md5-96
 debug2: kex_parse_kexinit: none,z...@openssh.com
 debug2: kex_parse_kexinit: none,z...@openssh.com
 debug2: kex_parse_kexinit:
 debug2: 

Re: Review Request 13237: Unable to resize disk with Zone wide storage

2013-08-02 Thread Rajesh Battala


 On Aug. 2, 2013, 11:29 a.m., Jenkins Cloudstack.org wrote:
  Review 13237 failed the build test : FAILURE
  The url of build cloudstack-master-with-patch #106 is : 
  http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/106/

patch is not generated on master branch hence this failure


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24524
---


On Aug. 2, 2013, 10:07 a.m., Rajesh Battala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13237/
 ---
 
 (Updated Aug. 2, 2013, 10:07 a.m.)
 
 
 Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
 
 
 Bugs: 3781
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Issue:
 == 
 for Volume operations we are finding the hypervisor type. Volume can be in 
 ZONE/Cluster scope storage pool. 
 when volume is in ZONE scope, there is issue with they way we fetch the 
 hypervisor type. It was written to handle Cluster scope only.
 
 fixed:
 ==
 Fixed with sql queries to fetch the Hypervisor type.
 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
 is in ZONE scope storage pool.
 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
 in CLUSTER scope storage pool.
 
 
 Diffs
 -
 
   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
 
 Diff: https://reviews.apache.org/r/13237/diff/
 
 
 Testing
 ---
 
 Setup:
 KVM and Xenserver with Adv Zone.
 Added pool Zone scope on KVM and Cluster Scope on Xenserver 
 1. created instances on KVM and xenserver.
 2. Create two volumes attached to instances on KVM and Xenserver. 
 3. vol1 is in Zone scope and vol2 is in cluster scope. 
 4. Successfully performed resize opertions on vol1 and vol2.
 5. Succssfully attached/detaches volumes
 
 
 Thanks,
 
 Rajesh Battala
 




Re: [DISCUSS] [jira] make affectedVersion field mandatory.....

2013-08-02 Thread Chiradeep Vittal
+1

On 8/2/13 4:06 AM, Ram Ganesh ram.gan...@citrix.com wrote:

Hi,

While triaging bugs I noticed that many bugs had affectedVersion field as
empty.  This makes it difficult to guess the version/release the reporter
was on while filing the bug. Can we make the affectedVersion field a
mandatory field instead?

Thanks,
RamG




RE: [DISCUSS] [jira] make affectedVersion field mandatory.....

2013-08-02 Thread Alex Huang
+10  How can we reproduce and verify without an affected version.

--Alex

 -Original Message-
 From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
 Sent: Friday, August 2, 2013 10:56 AM
 To: dev@cloudstack.apache.org
 Subject: Re: [DISCUSS] [jira] make affectedVersion field mandatory.
 
 +1
 
 On 8/2/13 4:06 AM, Ram Ganesh ram.gan...@citrix.com wrote:
 
 Hi,
 
 While triaging bugs I noticed that many bugs had affectedVersion field
 as empty.  This makes it difficult to guess the version/release the
 reporter was on while filing the bug. Can we make the affectedVersion
 field a mandatory field instead?
 
 Thanks,
 RamG
 



CloudStack Bay Area Meetup on August 7th

2013-08-02 Thread Animesh Chaturvedi

I am happy to announce the CloudStack Bay area meetup is on August 7th. Here is 
the link for meetup details 
http://www.meetup.com/CloudStack-SF-Bay-Area-Users-Group/events/117379992/. If 
you wish to be the speaker for this meetup please reach out to Karen Vuong, 
John Kinsella or Animesh.

Thanks
Animesh








CloudStack WorkShop in NYC / Free Training

2013-08-02 Thread Musayev, Ilya
I'm brain-storming hosting a CloudStack workshop in NYC.

I'm under impression that meetups are too informational - and not enough hands 
on.

End user must bring a laptop with Virtual Box pre-installed and template 
downloaded prior to attending the workshop. I will also have few USB sticks 
with template on it - just incase.

While I have lots of exposure with vSphere and CloudStack, I'm lacking KVM 
experience.

Would anyone point me to any guide or a blog that has the details on getting 
ACS to work with KVM?

Thanks
Ilya

PS: we will probably do online streaming as well and record the session. Do you 
have any feedback on Google Hangout VS GotoMeeting?


Re: Review Request 13192: create private network test

2013-08-02 Thread daan Hoogland


 On Aug. 2, 2013, 5:26 p.m., Chiradeep Vittal wrote:
  server/test/com/cloud/network/CreatePrivateNetworkTest.java, line 163
  https://reviews.apache.org/r/13192/diff/1/?file=332329#file332329line163
 
  Use logger.error instead of printStackTrace? This way the logfile will 
  contain the error.

will do


- daan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/#review24547
---


On Aug. 1, 2013, 2:52 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13192/
 ---
 
 (Updated Aug. 1, 2013, 2:52 p.m.)
 
 
 Review request for cloudstack, Koushik Das and Sheng Yang.
 
 
 Bugs: CLOUDSTACK-1532
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It 
 occurred to me it can be submitted separately.
 
 
 Diffs
 -
 
   server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/13192/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: Review Request 13192: create private network test

2013-08-02 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/
---

(Updated Aug. 2, 2013, 8:23 p.m.)


Review request for cloudstack, Koushik Das and Sheng Yang.


Changes
---

output to log


Bugs: CLOUDSTACK-1532


Repository: cloudstack-git


Description
---

This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It 
occurred to me it can be submitted separately.


Diffs (updated)
-

  server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/13192/diff/


Testing
---


Thanks,

daan Hoogland



Re: Review Request 13192: create private network test

2013-08-02 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/
---

(Updated Aug. 2, 2013, 8:24 p.m.)


Review request for cloudstack, Chiradeep Vittal, Koushik Das, and Sheng Yang.


Bugs: CLOUDSTACK-1532


Repository: cloudstack-git


Description
---

This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It 
occurred to me it can be submitted separately.


Diffs
-

  server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/13192/diff/


Testing
---


Thanks,

daan Hoogland



Re: Review Request 12976: Remove duplicate row from guest_os table

2013-08-02 Thread Alena Prokharchyk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/#review24559
---


The fix is good, but the patch failed to apply:

alena@macbookpro: [4.2]~/cloudstack-oss$ git am 
~/Desktop/db_remove_206_row.patch.2 --whitespace=nowarn
Applying: Removing duplicate unreferenced row
error: patch failed: setup/db/db/schema-410to420.sql:276
error: setup/db/db/schema-410to420.sql: patch does not apply
Patch failed at 0001 Removing duplicate unreferenced row
The copy of the patch that failed is found in:
   /Users/alena/cloudstack-oss/.git/rebase-apply/patch
When you have resolved this problem, run git am --resolved.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

- Alena Prokharchyk


On July 27, 2013, 7:22 p.m., Amogh Vasekar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12976/
 ---
 
 (Updated July 27, 2013, 7:22 p.m.)
 
 
 Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra 
 Bhamidipati.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Remove duplicate row (id=206) from table guest_os.
 Decided to remove instead of checking for duplicates on insertion since :
 1. The new row is referenced by id=166 elsewhere in the DB
 2. Old row with id=206 is not referenced in DB 
 
 
 Diffs
 -
 
   setup/db/db/schema-410to420.sql 82ca403 
   setup/db/db/schema-410to420.sql 82ca403 
 
 Diff: https://reviews.apache.org/r/12976/diff/
 
 
 Testing
 ---
 
 Local environment
 
 
 Thanks,
 
 Amogh Vasekar
 




Re: Review Request 13192: create private network test

2013-08-02 Thread Chiradeep Vittal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13192/#review24571
---

Ship it!


Needs license headers. Fixed locally and committed. Please ensure forthcoming 
patches have license header.
Please close review

- Chiradeep Vittal


On Aug. 2, 2013, 8:24 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13192/
 ---
 
 (Updated Aug. 2, 2013, 8:24 p.m.)
 
 
 Review request for cloudstack, Chiradeep Vittal, Koushik Das, and Sheng Yang.
 
 
 Bugs: CLOUDSTACK-1532
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It 
 occurred to me it can be submitted separately.
 
 
 Diffs
 -
 
   server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/13192/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl

2013-08-02 Thread Sheng Yang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13240/#review24576
---



server/src/com/cloud/network/NetworkServiceImpl.java
https://reviews.apache.org/r/13240/#comment48591

Don't remove it... It's a bug here.

It should be 
if ((networkId == null  vpcId == null) || (networkId != null  vpcId != 
null)) {

|| rather than 


- Sheng Yang


On Aug. 2, 2013, 1:15 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13240/
 ---
 
 (Updated Aug. 2, 2013, 1:15 p.m.)
 
 
 Review request for cloudstack.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 dealt with some warnings in NetworkServiceImpl
 
 
 Diffs
 -
 
   server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 
 
 Diff: https://reviews.apache.org/r/13240/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: [Discuss] Making CloudMonkey simpler to use for admin tasks

2013-08-02 Thread Rohit Yadav
On Thu, Aug 1, 2013 at 10:43 PM, Donal Lafferty
donal.laffe...@citrix.comwrote:

 I needed a different configuration than DevCloud provided, so I turned to
 CloudMonkey to automate setup of my test environment.

 This led to a blog on automating with CloudMonkey at
 http://dlafferty.blogspot.co.uk/2013/07/using-cloudmonkey-to-automate.html


Nice.


 What I forgot to mention is that automation would be a lot simpler if we
 were to do the following:

 1.   Update Apache CloudStack logging to provide API calls in a tidy
 format that can be fed directly.  E.g. POST parameters are not logged,  GET
 parameters are URL encoded.

 2.   Update CloudMonkey to allow username / password authentication


+1, send patch :)



 3.   Update CloudMonkey to not be picky about the case of command
 parameters when 'api' command used.


+1, send patch :)



 4.   Update CloudMonkey to allow filter option to be used with 'api'
 command.


How do you propose using that, example?

Regards.


Re: Review Request 12976: Remove duplicate row from guest_os table

2013-08-02 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/
---

(Updated Aug. 2, 2013, 10:43 p.m.)


Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra 
Bhamidipati.


Changes
---

Hi,
Have created a new patch with the latest master.
Thanks!


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647


Repository: cloudstack-git


Description
---

Remove duplicate row (id=206) from table guest_os.
Decided to remove instead of checking for duplicates on insertion since :
1. The new row is referenced by id=166 elsewhere in the DB
2. Old row with id=206 is not referenced in DB 


Diffs (updated)
-

  setup/db/db/schema-410to420.sql b2fe2ed 

Diff: https://reviews.apache.org/r/12976/diff/


Testing
---

Local environment


Thanks,

Amogh Vasekar



Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-02 Thread edison su

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13223/#review24589
---



plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
https://reviews.apache.org/r/13223/#comment48610

How about use the atomic semantics provided by createNewFile to coordinate 
between processes? 
For example: lock(int wait) {
   File lockFile = new File(lock-file-path);
   while(wait) {
   boolean havelock = false;
   if (lockFile.createNewFile()) {
  haveLock = true;
  break;
   }
Time.sleep(1000);
wait--;
}
   return haveLock;
}

unlock() {
   File lockFile = new File(path-of-lock-file);
   lockFile.delete();
}

It's simpler version of lockfile: 
https://github.com/spearce/jgit/blob/master/org.eclipse.jgit/src/org/eclipse/jgit/storage/file/LockFile.java
 


- edison su


On Aug. 2, 2013, 1:03 p.m., Wei Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13223/
 ---
 
 (Updated Aug. 2, 2013, 1:03 p.m.)
 
 
 Review request for cloudstack, edison su and Wido den Hollander.
 
 
 Bugs: CLOUDSTACK-2729
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt 
 (https://bugzilla.redhat.com/show_bug.cgi?id=977706)
 We need to prevent deleting a volume when refreshing the pool.
 This patch use a simple file lock to implement it.
 
 PS: I have tested another file lock similar to Read/Write file lock, but it 
 was very unstable.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
  a9baa52 
 
 Diff: https://reviews.apache.org/r/13223/diff/
 
 
 Testing
 ---
 
 Applied on 4.0.2 and 4.0.1
 
 Testing On 4.0.1 From 20,June
 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes 
 later. expunge.inteval = 600 (10 minutes), expunge.worker = 2
  
 
 Testing On 4.0.2 From 01,July
 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 
 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 
 
 
 Thanks,
 
 Wei Zhou
 




Re: Review Request 12976: Remove duplicate row from guest_os table

2013-08-02 Thread Alena Prokharchyk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12976/#review24590
---

Ship it!


Ship It!

- Alena Prokharchyk


On Aug. 2, 2013, 10:43 p.m., Amogh Vasekar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12976/
 ---
 
 (Updated Aug. 2, 2013, 10:43 p.m.)
 
 
 Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra 
 Bhamidipati.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Remove duplicate row (id=206) from table guest_os.
 Decided to remove instead of checking for duplicates on insertion since :
 1. The new row is referenced by id=166 elsewhere in the DB
 2. Old row with id=206 is not referenced in DB 
 
 
 Diffs
 -
 
   setup/db/db/schema-410to420.sql b2fe2ed 
 
 Diff: https://reviews.apache.org/r/12976/diff/
 
 
 Testing
 ---
 
 Local environment
 
 
 Thanks,
 
 Amogh Vasekar
 




Re: Cannot deploy db on latest 4.1 branch

2013-08-02 Thread Alena Prokharchyk
Happens because the management server version was changed to 4.1.2 on the 4.1 
branch, but the db upgrade path to 4.1.2 is not present in the databaseupgrade 
checker. Adding 411-412 db upgrade path – empty if there were no db changes 
between the releases- should fix this problem.

-alena.

From: Vijayendra Bhamidipati 
vijayendra.bhamidip...@citrix.commailto:vijayendra.bhamidip...@citrix.com
Date: Friday, August 2, 2013 4:32 PM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Cc: Alena Prokharchyk 
alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com
Subject: Cannot deploy db on latest 4.1 branch

I'm trying to do a simple fresh install of the mgmt. server and db using the 
latest 4.1 branch, and the building of the code and the deploydb go through 
smoothly. However, when I attempt to startup the mgmt. server using  mvn -pl 
:cloud-client-ui jetty:run, I run into a problem with the upgrade of the db 
from 4.0.0 to 4.1.2:

.
.
INFO  [utils.component.ComponentContext] (Timer-2:) Running 
SystemIntegrityChecker encryptionSecretKeyChecker
INFO  [utils.component.ComponentContext] (Timer-2:) Running 
SystemIntegrityChecker databaseIntegrityChecker
INFO  [cloud.upgrade.DatabaseIntegrityChecker] (Timer-2:) Grabbing lock to 
check for database integrity.
INFO  [cloud.upgrade.DatabaseIntegrityChecker] (Timer-2:) Performing database 
integrity check
INFO  [utils.component.ComponentContext] (Timer-2:) Running 
SystemIntegrityChecker managementServerNode
INFO  [utils.component.ComponentContext] (Timer-2:) Running 
SystemIntegrityChecker databaseUpgradeChecker
INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) Grabbing lock to check 
for database upgrade.
INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) DB version = 4.0.0 Code 
Version = 4.1.2-SNAPSHOT
INFO  [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) Database upgrade must 
be performed from 4.0.0 to 4.1.2-SNAPSHOT
ERROR [cloud.upgrade.DatabaseUpgradeChecker] (Timer-2:) The end upgrade version 
is actually at 4.1.1 but our management server code version is at 4.1.2-SNAPSHOT
ERROR [utils.component.ComponentContext] (Timer-2:) System integrity check 
failed. Refuse to startup
2013-08-02 09:40:39.356:INFO::Shutdown hook executing
2013-08-02 09:40:39.357:INFO::Stopped 
SelectChannelConnector@0.0.0.0mailto:SelectChannelConnector@0.0.0.0:8080
2013-08-02 09:40:39.862:INFO:/client:Closing Spring root WebApplicationContext
.
.

It looks like there are three version numbers - db version, which is at 4.0.0 :

mysql select * from db_version;
ERROR 1146 (42S02): Table 'cloud.db_version' doesn't exist
mysql select * from version;
++-+-+--+
| id | version | updated | step |
++-+-+--+
|  1 | 4.0.0   | 2013-08-02 09:38:16 | Complete |
++-+-+--+
1 row in set (0.01 sec)

mysql

And then there is the current version which is 4.1.2, and then an end 
upgrade version, which is in a map called _upgradeMap in 
DatabaseUpgradeChecker.java. It looks like the last version in this map is 
4.1.1, and since that is less than 4.1.2, mgmt. server startup fails as shown 
above.

Can someone please look into this and fix it? Ccing Alena as well since she's 
the expert on upgrade paths for CS..


Cheers!
Regards,
Vijay



Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor

2013-08-02 Thread Kelven Yang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13008/#review24602
---

Ship it!


Ship It!

- Kelven Yang


On Aug. 2, 2013, 12:49 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13008/
 ---
 
 (Updated Aug. 2, 2013, 12:49 a.m.)
 
 
 Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, 
 Sateesh Chodapuneedi, and William Chan.
 
 
 Bugs: CLOUDSTACK-3886
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The vminstancename flag has been incorrectly used to simply append the 
 displayname to the internal VM name that shows up on vCenter in vmware 
 deployments. It was intended to show the actual name supplied as hostname, on 
 the hypervisor. This helps admins and deployers to quickly identify VMs and 
 resolve issues related to those VMs. Its usage is very limited as it stands 
 now. This fix corrects it to ensure that the name of the VM on the hypervisor 
 matches the hostname if it is supplied, and if the vm.instancename.flag is 
 set to true.
 
 
 Diffs
 -
 
   
 engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
  96fb1d9 
   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
 292f7e9 
   
 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
  8d6bdb8 
   
 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
  10b6de9 
   
 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
  1216e17 
   
 plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
  112a0cb 
   server/src/com/cloud/configuration/Config.java 0d72694 
   server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 
   server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8 
   server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4 
   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 6d35539 
   setup/db/db/schema-410to420.sql 3f25c3b 
   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 
   vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java 
 11bc157 
   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 
   vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
 dd0f889 
   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 
 e2dd789 
   vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java 
 ac14328 
 
 Diff: https://reviews.apache.org/r/13008/diff/
 
 
 Testing
 ---
 
 Post this change, all major VM operations, namely 
 creation/destruction/expunging/start/stop/reboot of the VM have been tested 
 and observed to work correctly. Part of this patch also puts in a fix for 
 VMSync operations where the CS mgmt server doesn't detect that a guest VM is 
 down, if the guest VM has been shut down/powered off in vCenter. Other 
 operations such as VM snapshot, volume snapshots of disks belonging to the 
 VM, volume migration across primaries, volume attach/detach have also been 
 tested and they are working as expected. This is a functional change, and 
 completely transparent to any of cloudstack's existing functionalities and 
 all the test cases that cover the above code paths and APIs - all existing 
 tests should and do pass - no new tests are necessary.
 
 
 Thanks,
 
 Venkata Siva Vijayendra Bhamidipati
 




Re: How to enforce data disk selection

2013-08-02 Thread Mike Tutkowski
As an example, you might want to look at the Wizard path related to kicking
off a VM that is based on an ISO (as opposed to a template).

In that path, the Disk Offering is required.


On Fri, Aug 2, 2013 at 11:17 AM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 Exactly...through the current CS GUI, this is hard coded to be optional -
 although it probably wouldn't be hard to make required if you change
 instanceWizard.js.


 On Fri, Aug 2, 2013 at 4:21 AM, Sanjay Tripathi 
 sanjay.tripa...@citrix.com wrote:

 There is no any gc to enforce the datadisk selection; perhaps you can
 hack instanceWizard.js file in ui-custom folder to disable the No
 thanks option.

 --Sanjay

  -Original Message-
  From: Musayev, Ilya [mailto:imusa...@webmd.net]
  Sent: Friday, August 02, 2013 3:17 PM
  To: dev@cloudstack.apache.org
  Subject: RE: How to enforce data disk selection
 
  Mike,
 
  That is correct, we need to enforce data disk selection when user goes
  through deploying instance wizard in UI.
 
  Is there a config to do this or should I hack some .js files?
 
  Thanks
  ilya
 
  -Original Message-
  From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
  Sent: Friday, August 02, 2013 1:36 AM
  To: dev@cloudstack.apache.org
  Subject: Re: How to enforce data disk selection
 
  Could you provide a little more info about where in the GUI you'd like
 to
  enforce the selection of a data disk? When kicking off a VM instance
  perhaps?
 
 
  On Thu, Aug 1, 2013 at 4:03 PM, Musayev, Ilya imusa...@webmd.net
  wrote:
 
   How would one enforce data disk selection?
  
   I don't want to leave data disk blank in UI.
  
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the
  cloudhttp://solidfire.com/solution/overview/?video=play
  *(tm)*




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the 
 cloudhttp://solidfire.com/solution/overview/?video=play
 *™*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*