Re: What are the new features in 4.2?

2013-08-06 Thread Wei ZHOU
Mike,

I closed it.


2013/8/6 Mike Tutkowski mike.tutkow...@solidfire.com

 Hi Animesh,

 Upon seeing your e-mail here, I tried to go in and mark mine as Resolved,
 but the control for this is disabled.

 https://issues.apache.org/jira/browse/CLOUDSTACK-2778


 On Tue, Aug 6, 2013 at 12:00 PM, Animesh Chaturvedi 
 animesh.chaturv...@citrix.com wrote:

  You can use this JIRA filter for 4.2 features and improvements
  https://issues.apache.org/jira/issues/#?filter=12323963
 
  Some of the items are in open state which I am following to get them
  closed.
 
 
  Thanks
  Animesh
 
 
 
 
   -Original Message-
   From: Nux! [mailto:n...@li.nux.ro]
   Sent: Tuesday, August 06, 2013 10:30 AM
   To: cloudstack-...@incubator.apache.org
   Subject: What are the new features in 4.2?
  
   Hello guys,
  
   I've been trying to find a definitive new features for 4.2, but
   failed. Can anyone point me to the right URL or make a summary of
   what's new?
  
   Thanks,
   Lucian
  
   --
   Sent from the Delta quadrant using Borg technology!
  
   Nux!
   www.nux.ro
 



 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *™*



Re: What are the new features in 4.2?

2013-08-06 Thread Mike Tutkowski
Thanks!


On Tue, Aug 6, 2013 at 12:42 PM, Wei ZHOU ustcweiz...@gmail.com wrote:

 Mike,

 I closed it.


 2013/8/6 Mike Tutkowski mike.tutkow...@solidfire.com

  Hi Animesh,
 
  Upon seeing your e-mail here, I tried to go in and mark mine as Resolved,
  but the control for this is disabled.
 
  https://issues.apache.org/jira/browse/CLOUDSTACK-2778
 
 
  On Tue, Aug 6, 2013 at 12:00 PM, Animesh Chaturvedi 
  animesh.chaturv...@citrix.com wrote:
 
   You can use this JIRA filter for 4.2 features and improvements
   https://issues.apache.org/jira/issues/#?filter=12323963
  
   Some of the items are in open state which I am following to get them
   closed.
  
  
   Thanks
   Animesh
  
  
  
  
-Original Message-
From: Nux! [mailto:n...@li.nux.ro]
Sent: Tuesday, August 06, 2013 10:30 AM
To: cloudstack-...@incubator.apache.org
Subject: What are the new features in 4.2?
   
Hello guys,
   
I've been trying to find a definitive new features for 4.2, but
failed. Can anyone point me to the right URL or make a summary of
what's new?
   
Thanks,
Lucian
   
--
Sent from the Delta quadrant using Borg technology!
   
Nux!
www.nux.ro
  
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the
  cloudhttp://solidfire.com/solution/overview/?video=play
  *™*
 




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


RE: IP Address Allocation

2013-08-06 Thread Musayev, Ilya
Can this be done on system VMs as well? I see that its targeted for the guests, 
if there is a way to abstract and apply ip address on any component - it would 
certainly make ACS much more flexible than it is now.

 -Original Message-
 From: Soheil Eizadi [mailto:seiz...@infoblox.com]
 Sent: Tuesday, August 06, 2013 2:29 PM
 To: dev@cloudstack.apache.org
 Subject: RE: IP Address Allocation
 
 We can define a third type of element for IP Address Allocation, let me look
 at the code and see is there is standard base class that it can extend or we
 have to come up with a new base class like we have for NetworkElements.
 -Soheil
 
 From: Chiradeep Vittal [chiradeep.vit...@citrix.com]
 Sent: Tuesday, August 06, 2013 11:14 AM
 To: dev@cloudstack.apache.org
 Cc: Alex Huang
 Subject: Re: IP Address Allocation
 
 The way the gurus are consulted for network design and reservation makes it
 difficult to put this inside a guru.
 However it does seem odd to put this inside an element. Perhaps we need a
 3rd type (IpAddressReserver?)
 
 
 On 8/6/13 10:42 AM, Soheil Eizadi seiz...@infoblox.com wrote:
 
 The NetworkGuru does a lot more than IP address allocation, e.g. handle
 the Layer2/3 networking unique to the particular vendor. There are a
 lot of NetworkElements providing their own NetworkGuru plugins (Nicira,
 MidoNet, ...) extending the standard CloudStack Gurus.
 
 The feature of providing IP Address Allocation, DHCP and DNS is common
 for all these networks, so rather than provide our own Guru the
 proposed design would allow the above functions to coexist with existing
 Gurus.
 
 -Soheil
 
 From: Murali Reddy [murali.re...@citrix.com]
 Sent: Tuesday, August 06, 2013 3:24 AM
 To: dev@cloudstack.apache.org
 Subject: Re: IP Address Allocation
 
 On 06/08/13 8:59 AM, Soheil Eizadi seiz...@infoblox.com wrote:
 
 One way to achieve this behavior is to have a call out in prepareNic()
 to the NetworkElements before the call to the NetworkGuru allowing the
 NetworkElement to update the Nic Profile. In this use case the Network
 Element would suggest an IP Address. In the use case below the IP
 Address would be updated by the NetworkElement. There is logic in
 getIp(), the current IP Allocation that handles the case where the Nic
 Profile already has an IP Address. This needs to be updated to handle this
 new use case.
 The current use case assume that the VM had already been prepared
 once
 and has an IP Address allocated that could be reused.
 
 Does anyone see a problem with this approach?
 
 Purpose of Guru (to design the network) and Element (implement the
 network) are different. Right way would be for your plug-in to
 implement both network Guru and element and let the guru do the IP
 address allocation.
 
 -Soheil
 
 From: Soheil Eizadi [seiz...@infoblox.com]
 Sent: Monday, August 05, 2013 2:35 PM
 To: dev@cloudstack.apache.org
 Subject: IP Address Allocation
 
 I am trying to figure out what would be the proper way for a Plugin to
 interact with the CloudStack VM deployment and provide an
 authoritative IP Address from its database versus the local CloudStack
 database. It looks like the NetworkElements are not presented an
 opportunity to provide an IP Address and you must develop a
 NetworkGuru to provide this function. There is some customization of
 the IP Address designed into the Secondary NICs (see allocateGuestIP()).
 -Soheil
 
 
 
 




RE: Is the simulator broken?

2013-08-06 Thread Ian Duffy
Eventually got it running.
Still hangs during marvin.setup though.
On 6 Aug 2013 18:55, Edison Su edison...@citrix.com wrote:

 Can you try: mvn -P developer,systemvm,simulator  -D nonoss,simulator
 clean install


  -Original Message-
  From: Ian Duffy [mailto:i...@ianduffy.ie]
  Sent: Tuesday, August 06, 2013 7:46 AM
  To: dev@cloudstack.apache.org
  Subject: Re: Is the simulator broken?
 
  Yeah complied with:
 
  mvn -P developer,systemvm  -D nonoss,simulator clean install
 
 
  Will retry...
 
  On 6 August 2013 14:43, Prasanna Santhanam t...@apache.org wrote:
   I haven't tried on master but it seems to be broken on 4.2:
  
   I see this in the management server log when starting systemVMs
   https://gist.github.com/vogxn/6164508
  
   But that error you showed just means the simulator jar was not found
   in the classpath. Did you build with the -Dsimulator switch?
  
   On Tue, Aug 06, 2013 at 12:51:41PM +0100, Ian Duffy wrote:
   Hi,
  
   Is the simulator broken?
  
   Trying to run
  
   nosetests -v --with-marvin --marvin-config=setup/dev/advanced.cfg -w
   /tmp
  
   and getting
  
   Traceback (most recent call last):
 File /opt/python/bin/nosetests, line 9, in module
   load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
 File /opt/python/lib/python2.7/site-packages/nose/core.py, line
   118, in __init__
   **extra_args)
 File /opt/python/lib/python2.7/unittest/main.py, line 94, in
 __init__
   self.parseArgs(argv)
 File /opt/python/lib/python2.7/site-packages/nose/core.py, line
   135, in parseArgs
   self.config.configure(argv, doc=self.usage())
 File /opt/python/lib/python2.7/site-packages/nose/config.py, line
   344, in configure
   self.plugins.configure(options, self)
 File
   /opt/python/lib/python2.7/site-packages/nose/plugins/manager.py,
   line 284, in configure
   cfg(options, config)
 File
   /opt/python/lib/python2.7/site-packages/nose/plugins/manager.py,
   line 99, in __call__
   return self.call(*arg, **kw)
 File
   /opt/python/lib/python2.7/site-packages/nose/plugins/manager.py,
   line 167, in simple
   result = meth(*arg, **kw)
 File
   /opt/python/lib/python2.7/site-packages/marvin/marvinPlugin.py,
   line 68, in configure
   deploy.loadCfg() if options.load else deploy.deploy()
 File
   /opt/python/lib/python2.7/site-packages/marvin/deployDataCenter.py,
   line 576, in deploy
   self.createZones(self.config.zones)
 File
   /opt/python/lib/python2.7/site-packages/marvin/deployDataCenter.py,
   line 408, in createZones
   self.createpods(zone.pods, zoneId)
 File
   /opt/python/lib/python2.7/site-packages/marvin/deployDataCenter.py,
   line 126, in createpods
   vmwareDc=pod.vmwaredc)
 File
   /opt/python/lib/python2.7/site-packages/marvin/deployDataCenter.py,
   line 84, in createClusters
   clusterresponse = self.apiClient.addCluster(clustercmd)
 File
   /opt/python/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudst
   ackAPIClient.py,
   line 1378, in addCluster
   response = self.connection.marvin_request(command,
   response_type=response, method=method)
 File
   /opt/python/lib/python2.7/site-packages/marvin/cloudstackConnection.
   py,
   line 222, in marvin_request
   response = jsonHelper.getResultObj(response.json(), response_type)
 File
   /opt/python/lib/python2.7/site-packages/marvin/jsonHelper.py,
   line 148, in getResultObj
   raise cloudstackException.cloudstackAPIException(respname,
   errMsg)
   marvin.cloudstackException.cloudstackAPIException: Execute cmd:
   addcluster failed, due to: errorCode: 431, errorText:Could not find
   corresponding resource manager for simulator
  
   --
   Prasanna.,
  
   
   Powered by BigRock.com
  



Documentation Question

2013-08-06 Thread Mike Tutkowski
Hi,

I am working on documenting the SolidFire (storage) plug-in I developed for
4.2.

I have plenty of documentation handy, but am not familiar with how I should
document this for CloudStack.

Would someone be able to point me to a template so I know how mine
documentation should look and where it should be placed?

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


RE: IP Address Allocation

2013-08-06 Thread Soheil Eizadi
Agree that the IP Address allocation is different than the DHCP and DNS service 
offered by the NetworkElements.

The third party NetworkGurus just reference the standard NetworkManager IP 
Address Allocation routines, either directly (e.g. 
_networkMgr.assignPublicIpAddress()) or by calling out to the GuestNetworkGuru. 
I would say in the current design the Network Manager manages the IP Addresses 
not the Network Gurus. I don't think this is a bad design, in that the 
NetworkGurus are sharing the same  ip address allocation and get new features 
(e.g. IP reservation or VM migration) without implementing new code to support 
them.
-Soheil


From: Alex Huang [alex.hu...@citrix.com]
Sent: Tuesday, August 06, 2013 11:27 AM
To: Chiradeep Vittal; dev@cloudstack.apache.org
Subject: RE: IP Address Allocation

We can either break NetworkManager down further and say NetworkGuru sets the 
actual parameters of the network and a new IpAddressReserver sets the ip 
address or we can let NetworkGurus identify the IpAddressReserver to use 
themselves.  I generally think NetworkManager shouldn't care where the ip 
address came from because it really shouldn't know anything about the actual 
network we're laying out for the end user.  That's always been left to the 
NetworkGurus.  If you think about it from that perspective, then it's natural 
that ip address is allocated by the NetworkGuru.  But I can see different 
NetworkGurus may want to share the same ip address allocation tables/schemes so 
an interface for them to share that code does make sense.

Note there's a difference between allocating ip address and the act of actually 
issuing the ip address and associating the ip address to a fqdn.  That act is 
performed by the network elements.  Here we're specifically saying who is 
responsible for figuring out the ip address that can be allocated to a 
particular vm and works within a network.

--Alex

 -Original Message-
 From: Chiradeep Vittal
 Sent: Tuesday, August 6, 2013 11:14 AM
 To: dev@cloudstack.apache.org
 Cc: Alex Huang
 Subject: Re: IP Address Allocation

 The way the gurus are consulted for network design and reservation makes it
 difficult to put this inside a guru.
 However it does seem odd to put this inside an element. Perhaps we need a
 3rd type (IpAddressReserver?)


 On 8/6/13 10:42 AM, Soheil Eizadi seiz...@infoblox.com wrote:

 The NetworkGuru does a lot more than IP address allocation, e.g. handle
 the Layer2/3 networking unique to the particular vendor. There are a
 lot of NetworkElements providing their own NetworkGuru plugins (Nicira,
 MidoNet, ...) extending the standard CloudStack Gurus.
 
 The feature of providing IP Address Allocation, DHCP and DNS is common
 for all these networks, so rather than provide our own Guru the
 proposed design would allow the above functions to coexist with existing
 Gurus.
 
 -Soheil
 
 From: Murali Reddy [murali.re...@citrix.com]
 Sent: Tuesday, August 06, 2013 3:24 AM
 To: dev@cloudstack.apache.org
 Subject: Re: IP Address Allocation
 
 On 06/08/13 8:59 AM, Soheil Eizadi seiz...@infoblox.com wrote:
 
 One way to achieve this behavior is to have a call out in prepareNic()
 to the NetworkElements before the call to the NetworkGuru allowing the
 NetworkElement to update the Nic Profile. In this use case the Network
 Element would suggest an IP Address. In the use case below the IP
 Address would be updated by the NetworkElement. There is logic in
 getIp(), the current IP Allocation that handles the case where the Nic
 Profile already has an IP Address. This needs to be updated to handle this
 new use case.
 The current use case assume that the VM had already been prepared
 once
 and has an IP Address allocated that could be reused.
 
 Does anyone see a problem with this approach?
 
 Purpose of Guru (to design the network) and Element (implement the
 network) are different. Right way would be for your plug-in to
 implement both network Guru and element and let the guru do the IP
 address allocation.
 
 -Soheil
 
 From: Soheil Eizadi [seiz...@infoblox.com]
 Sent: Monday, August 05, 2013 2:35 PM
 To: dev@cloudstack.apache.org
 Subject: IP Address Allocation
 
 I am trying to figure out what would be the proper way for a Plugin to
 interact with the CloudStack VM deployment and provide an
 authoritative IP Address from its database versus the local CloudStack
 database. It looks like the NetworkElements are not presented an
 opportunity to provide an IP Address and you must develop a
 NetworkGuru to provide this function. There is some customization of
 the IP Address designed into the Secondary NICs (see allocateGuestIP()).
 -Soheil
 
 
 



Re: What are the new features in 4.2?

2013-08-06 Thread Mike Tutkowski
Thanks again, Wei.

It's silly what happened (just noticed). I thought I was logged in to JIRA,
but it was another web system, so not being logged in is why that option
was disabled. :)


On Tue, Aug 6, 2013 at 12:44 PM, Mike Tutkowski 
mike.tutkow...@solidfire.com wrote:

 Thanks!


 On Tue, Aug 6, 2013 at 12:42 PM, Wei ZHOU ustcweiz...@gmail.com wrote:

 Mike,

 I closed it.


 2013/8/6 Mike Tutkowski mike.tutkow...@solidfire.com

  Hi Animesh,
 
  Upon seeing your e-mail here, I tried to go in and mark mine as
 Resolved,
  but the control for this is disabled.
 
  https://issues.apache.org/jira/browse/CLOUDSTACK-2778
 
 
  On Tue, Aug 6, 2013 at 12:00 PM, Animesh Chaturvedi 
  animesh.chaturv...@citrix.com wrote:
 
   You can use this JIRA filter for 4.2 features and improvements
   https://issues.apache.org/jira/issues/#?filter=12323963
  
   Some of the items are in open state which I am following to get them
   closed.
  
  
   Thanks
   Animesh
  
  
  
  
-Original Message-
From: Nux! [mailto:n...@li.nux.ro]
Sent: Tuesday, August 06, 2013 10:30 AM
To: cloudstack-...@incubator.apache.org
Subject: What are the new features in 4.2?
   
Hello guys,
   
I've been trying to find a definitive new features for 4.2, but
failed. Can anyone point me to the right URL or make a summary of
what's new?
   
Thanks,
Lucian
   
--
Sent from the Delta quadrant using Borg technology!
   
Nux!
www.nux.ro
  
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the
  cloudhttp://solidfire.com/solution/overview/?video=play
  *™*
 




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the 
 cloudhttp://solidfire.com/solution/overview/?video=play
 *™*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


Re: Review Request 13237: Unable to resize disk with Zone wide storage

2013-08-06 Thread Rajesh Battala


 On Aug. 5, 2013, 6:17 p.m., edison su wrote:
  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java, line 77
  https://reviews.apache.org/r/13237/diff/1/?file=334435#file334435line77
 
  why not just use select s.scope from storage_pool s, volumes v where 
  s.id = v.pool_id?
 
 Rajesh Battala wrote:
 if we use the above query then we get list of scope values.
 mysql select s.scope from storage_pool s, volumes v where s.id = 
 v.pool_id;
 +-+
 | scope   |
 +-+
 | CLUSTER |
 | CLUSTER |
 | CLUSTER |
 | CLUSTER |
 | ZONE|
 +-+
 5 rows in set (0.00 sec)
 
  So I had written the above query like SELECT_POOLSCOPE = SELECT s.scope 
 from storage_pool s, volumes v where s.id =(select pool_id from volumes where 
 id =?); 
 to fetch the scope of the storage pool where the volume is existing.
 
 edison su wrote:
 If this is the case, you can use select s.scope from storage_pool s, 
 volumes v where s.id = v.pool_id and v.id = your-volume-id?

edison, the query select s.scope from storage_pool s, volumes v where s.id = 
v.pool_id and v.id = your-volume-id will also get me the scope without any 
issue. 

the query you had mentioned is proper one.

I will incorporate the change and rebase with 4.2 and submit the patch.


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24653
---


On Aug. 2, 2013, 10:07 a.m., Rajesh Battala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13237/
 ---
 
 (Updated Aug. 2, 2013, 10:07 a.m.)
 
 
 Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
 
 
 Bugs: 3781
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Issue:
 == 
 for Volume operations we are finding the hypervisor type. Volume can be in 
 ZONE/Cluster scope storage pool. 
 when volume is in ZONE scope, there is issue with they way we fetch the 
 hypervisor type. It was written to handle Cluster scope only.
 
 fixed:
 ==
 Fixed with sql queries to fetch the Hypervisor type.
 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
 is in ZONE scope storage pool.
 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
 in CLUSTER scope storage pool.
 
 
 Diffs
 -
 
   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
 
 Diff: https://reviews.apache.org/r/13237/diff/
 
 
 Testing
 ---
 
 Setup:
 KVM and Xenserver with Adv Zone.
 Added pool Zone scope on KVM and Cluster Scope on Xenserver 
 1. created instances on KVM and xenserver.
 2. Create two volumes attached to instances on KVM and Xenserver. 
 3. vol1 is in Zone scope and vol2 is in cluster scope. 
 4. Successfully performed resize opertions on vol1 and vol2.
 5. Succssfully attached/detaches volumes
 
 
 Thanks,
 
 Rajesh Battala
 




Re: [DISCUSS] Selectable UI list view rows

2013-08-06 Thread SuichII, Christopher
It's good to hear there is a demand for this. However, this is something that 
we could really use in our integrations targeted for 4.3. I have some spare 
cycles planned for contributing to CloudStack while working on our integrations 
 if you're interested in talking more either online or off about your plans for 
implementation.

I know I'm not as knowledgeable about the UI codebase, but I think I've got an 
idea about how to put this into listview.js with minimal impact and make it 
generic/reusable from the start. If I began working on it, I could test it 
against the list views that we would want to see it on within our plugin and 
work more closely with you when you have the bandwidth.

-Chris

On Aug 6, 2013, at 2:24 PM, Brian Federle 
brian.fede...@citrix.commailto:brian.fede...@citrix.com wrote:

Hey Chris,

I’ve actually created a ticket for this, which I’m planning to implement in a 
future release (hopefully the next one if I have the bandwidth). See 
https://issues.apache.org/jira/browse/CLOUDSTACK-1579

This will require a good deal of refactoring of existing code to support 
though, so to start it will probably be implemented on 1-2 sections; most 
likely instances and events/alerts which is where it is requested the most.

-Brian

From: SuichII, Christopher [mailto:chris.su...@netapp.comhttp://netapp.com]
Sent: Tuesday, August 06, 2013 10:57 AM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: [DISCUSS] Selectable UI list view rows

One feature I'd like to look in to is allowing list views  to have 'selectable' 
rows. With this, users could check individual rows of a list view to perform 
some action on a subset of the list. When one or more row is selected, the list 
of actions at the top of the list view would be filtered to only those which 
can be performed on the selected rows. Additionally, there would be a checkbox 
in the header of the list view which would allow the user to quickly 
select/unselect all items in the list.

Maybe a quick mockup will help make this more clear:


Any thoughts, concerns, feedback or existing plans for something like this?

Thanks,
Chris



Re: What are the new features in 4.2?

2013-08-06 Thread Wei ZHOU
:)


2013/8/6 Mike Tutkowski mike.tutkow...@solidfire.com

 Thanks again, Wei.

 It's silly what happened (just noticed). I thought I was logged in to JIRA,
 but it was another web system, so not being logged in is why that option
 was disabled. :)


 On Tue, Aug 6, 2013 at 12:44 PM, Mike Tutkowski 
 mike.tutkow...@solidfire.com wrote:

  Thanks!
 
 
  On Tue, Aug 6, 2013 at 12:42 PM, Wei ZHOU ustcweiz...@gmail.com wrote:
 
  Mike,
 
  I closed it.
 
 
  2013/8/6 Mike Tutkowski mike.tutkow...@solidfire.com
 
   Hi Animesh,
  
   Upon seeing your e-mail here, I tried to go in and mark mine as
  Resolved,
   but the control for this is disabled.
  
   https://issues.apache.org/jira/browse/CLOUDSTACK-2778
  
  
   On Tue, Aug 6, 2013 at 12:00 PM, Animesh Chaturvedi 
   animesh.chaturv...@citrix.com wrote:
  
You can use this JIRA filter for 4.2 features and improvements
https://issues.apache.org/jira/issues/#?filter=12323963
   
Some of the items are in open state which I am following to get them
closed.
   
   
Thanks
Animesh
   
   
   
   
 -Original Message-
 From: Nux! [mailto:n...@li.nux.ro]
 Sent: Tuesday, August 06, 2013 10:30 AM
 To: cloudstack-...@incubator.apache.org
 Subject: What are the new features in 4.2?

 Hello guys,

 I've been trying to find a definitive new features for 4.2, but
 failed. Can anyone point me to the right URL or make a summary of
 what's new?

 Thanks,
 Lucian

 --
 Sent from the Delta quadrant using Borg technology!

 Nux!
 www.nux.ro
   
  
  
  
   --
   *Mike Tutkowski*
   *Senior CloudStack Developer, SolidFire Inc.*
   e: mike.tutkow...@solidfire.com
   o: 303.746.7302
   Advancing the way the world uses the
   cloudhttp://solidfire.com/solution/overview/?video=play
   *™*
  
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
 http://solidfire.com/solution/overview/?video=play
  *™*
 



 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *™*



RE: IP Address Allocation

2013-08-06 Thread Soheil Eizadi
It is more a function of the networks that are managed, so any VM including 
SystemVMs would be managed. It would apply to both Public and Guest Networks.
-Soheil

From: Musayev, Ilya [imusa...@webmd.net]
Sent: Tuesday, August 06, 2013 11:49 AM
To: dev@cloudstack.apache.org
Subject: RE: IP Address Allocation

Can this be done on system VMs as well? I see that its targeted for the guests, 
if there is a way to abstract and apply ip address on any component - it would 
certainly make ACS much more flexible than it is now.

 -Original Message-
 From: Soheil Eizadi [mailto:seiz...@infoblox.com]
 Sent: Tuesday, August 06, 2013 2:29 PM
 To: dev@cloudstack.apache.org
 Subject: RE: IP Address Allocation

 We can define a third type of element for IP Address Allocation, let me look
 at the code and see is there is standard base class that it can extend or we
 have to come up with a new base class like we have for NetworkElements.
 -Soheil
 
 From: Chiradeep Vittal [chiradeep.vit...@citrix.com]
 Sent: Tuesday, August 06, 2013 11:14 AM
 To: dev@cloudstack.apache.org
 Cc: Alex Huang
 Subject: Re: IP Address Allocation

 The way the gurus are consulted for network design and reservation makes it
 difficult to put this inside a guru.
 However it does seem odd to put this inside an element. Perhaps we need a
 3rd type (IpAddressReserver?)


 On 8/6/13 10:42 AM, Soheil Eizadi seiz...@infoblox.com wrote:

 The NetworkGuru does a lot more than IP address allocation, e.g. handle
 the Layer2/3 networking unique to the particular vendor. There are a
 lot of NetworkElements providing their own NetworkGuru plugins (Nicira,
 MidoNet, ...) extending the standard CloudStack Gurus.
 
 The feature of providing IP Address Allocation, DHCP and DNS is common
 for all these networks, so rather than provide our own Guru the
 proposed design would allow the above functions to coexist with existing
 Gurus.
 
 -Soheil
 
 From: Murali Reddy [murali.re...@citrix.com]
 Sent: Tuesday, August 06, 2013 3:24 AM
 To: dev@cloudstack.apache.org
 Subject: Re: IP Address Allocation
 
 On 06/08/13 8:59 AM, Soheil Eizadi seiz...@infoblox.com wrote:
 
 One way to achieve this behavior is to have a call out in prepareNic()
 to the NetworkElements before the call to the NetworkGuru allowing the
 NetworkElement to update the Nic Profile. In this use case the Network
 Element would suggest an IP Address. In the use case below the IP
 Address would be updated by the NetworkElement. There is logic in
 getIp(), the current IP Allocation that handles the case where the Nic
 Profile already has an IP Address. This needs to be updated to handle this
 new use case.
 The current use case assume that the VM had already been prepared
 once
 and has an IP Address allocated that could be reused.
 
 Does anyone see a problem with this approach?
 
 Purpose of Guru (to design the network) and Element (implement the
 network) are different. Right way would be for your plug-in to
 implement both network Guru and element and let the guru do the IP
 address allocation.
 
 -Soheil
 
 From: Soheil Eizadi [seiz...@infoblox.com]
 Sent: Monday, August 05, 2013 2:35 PM
 To: dev@cloudstack.apache.org
 Subject: IP Address Allocation
 
 I am trying to figure out what would be the proper way for a Plugin to
 interact with the CloudStack VM deployment and provide an
 authoritative IP Address from its database versus the local CloudStack
 database. It looks like the NetworkElements are not presented an
 opportunity to provide an IP Address and you must develop a
 NetworkGuru to provide this function. There is some customization of
 the IP Address designed into the Secondary NICs (see allocateGuestIP()).
 -Soheil
 
 
 





Re: [VOTE] Update by-laws: non-technical decisions and other minor changes

2013-08-06 Thread Chip Childers
+1

On Mon, Aug 05, 2013 at 10:43:22PM +0100, Noah Slater wrote:
 Hi dev,
 
 I have some more by-law changes to propose. This is essentially round 2 for
 these changes. I incorporated feedback from the last thread.
 
 Per the by-laws, we're using a lazy majority for this vote. Please cast
 your vote now. I will tally the results in 72 hours.
 
 Here's my changelog:
 
 * Removed some spurious nbsp; entities
 
 * Added A technical decision is any decision that involves changes to the
 source code
 that we distribute in our official releases. to § 3.4.1 (Technical
 Decisions).
 
 * Added discussion-lead before consensus gathering in this section.
 
 * With the improved definition, I have tightened up the wording so that
 technical decisions must be made on @dev.
 
 * Added § 3.4.2, Non-Technical Decisions. Non-technical decisions are
 defined as in the inverse of technical decisions. They can be made on
 whatever list is appropriate. Formal voting will use a lazy 2/3 majority.
 Votes cannot be vetoed.
 
 * Changed § 3.4.3. (Release Plan) to limit decisions to @dev.
 
 * Changed § 3.4.4. (Product Release) to limit decisions to @dev.
 
 * Changed § 3.4.5. (Adoption of New Codebase) to limit decisions to @dev.
 
 * Changed § 3.4.10. (Modifying Bylaws) to limit decisions to @dev.
 
 * Added an Oxford comma to the final paras of § 3.4.1. and § 3.4.2.
 
 * Section renumbering to accommodate § 3.4.2.
 
 And here's the patch:
 
 Index: bylaws.mdtext
 ===
 --- bylaws.mdtext (revision 1510739)
 +++ bylaws.mdtext (working copy)
 @@ -198,41 +198,64 @@
 
  3.4.1. Technical Decisions
 
 +A technical decision is any decision that involves changes to the source
 code
 +that we distribute in our official releases.
 +
  Technical decisions should normally be made by the entire community using
 -consensusnbsp;gathering, and not through formal voting.
 +discussion-lead consensus gathering, and not through formal voting.
 
 -Technical decisions must be made on a project development mailing list.
 +Technical decisions must be made on the project development mailing list.
 
  During the consensus gathering process, technical decisions may be vetoed
 by
  any Committer with a valid reason.
 
  If a formal vote is started for a technical decision, the vote will be
 held as
 -a lazynbsp;consensusnbsp;of active committers.
 +a lazy consensus of active committers.
 
 -Any user, contributor, committer or PMC member can initiate a technical
 +Any user, contributor, committer, or PMC member can initiate a technical
  decision making process.
 
 -3.4.2. Release Plan
 +3.4.2. Non-Technical Decisions
 
 +A non-technical decisions is any decision that does not involve changes to
 the
 +source code that we distribute in our official releases.
 +
 +Non-technical decisions should normally be made by the entire community
 using
 +discussion-lead consensus-building, and not through formal voting.
 +
 +Non-technical decisions can be made on whichever project mailing list is
 most
 +appropriate.
 +
 +Non-technical decisions cannot be vetoed, but if there is strong opposition
 +a formal vote can be used to resolve the dispute.
 +
 +If a formal vote is started for a non-technical decision, the vote will be
 held
 +as a lazy 2/3 majority of active committers.
 +
 +Any user, contributor, committer, or PMC member can initiate a
 non-technical
 +decision making process.
 +
 +3.4.3. Release Plan
 +
  Defines the timetable and work items for a release. The plan also
 nominates a
  Release Manager.
 
  A lazy majority of active committers is required for approval.
 
 -Any active committer or PMC member may call a vote. The vote must occur on
 a
 +Any active committer or PMC member may call a vote. The vote must occur on
 the
  project development mailing list.
 
 -3.4.3. Product Release
 +3.4.4. Product Release
 
  When a release of one of the project's products is ready, a vote is
 required to
  accept the release as an official release of the project.
 
  Lazy Majority of active PMC members is required for approval.
 
 -Any active committer or PMC member may call a vote. The vote must occur on
 a
 +Any active committer or PMC member may call a vote. The vote must occur on
 the
  project development mailing list.
 
 -3.4.4. Adoption of New Codebase
 +3.4.5. Adoption of New Codebase
 
  When the codebase for an existing, released product is to be replaced with
 an
  alternative codebase. If such a vote fails to gain approval, the existing
 code
 @@ -242,10 +265,10 @@
 
  Lazy 2/3 majority of active PMC members.
 
 -Any active committer or PMC member may call a vote. The vote must occur on
 a
 +Any active committer or PMC member may call a vote. The vote must occur on
 the
  project development mailing list.
 
 -3.4.5. New Committer
 +3.4.6. New Committer
 
  When a new committer is proposed for the project.
 
 @@ -254,7 +277,7 @@
  Any active PMC member may call a vote. The vote must occur on 

Re: [DISCUSS] Selectable UI list view rows

2013-08-06 Thread Chip Childers
On Tue, Aug 06, 2013 at 06:48:50PM +, SuichII, Christopher wrote:
 It's good to hear there is a demand for this. However, this is something that 
 we could really use in our integrations targeted for 4.3. I have some spare 
 cycles planned for contributing to CloudStack while working on our 
 integrations  if you're interested in talking more either online or off about 
 your plans for implementation.
 
 I know I'm not as knowledgeable about the UI codebase, but I think I've got 
 an idea about how to put this into listview.js with minimal impact and make 
 it generic/reusable from the start. If I began working on it, I could test it 
 against the list views that we would want to see it on within our plugin and 
 work more closely with you when you have the bandwidth.
 
 -Chris

Awesome Chris, thanks for stepping up and volunteering.  Brian,
anything you can do to give him a jumpstart would rock.

 
 On Aug 6, 2013, at 2:24 PM, Brian Federle 
 brian.fede...@citrix.commailto:brian.fede...@citrix.com wrote:
 
 Hey Chris,
 
 I’ve actually created a ticket for this, which I’m planning to implement in a 
 future release (hopefully the next one if I have the bandwidth). See 
 https://issues.apache.org/jira/browse/CLOUDSTACK-1579
 
 This will require a good deal of refactoring of existing code to support 
 though, so to start it will probably be implemented on 1-2 sections; most 
 likely instances and events/alerts which is where it is requested the most.
 
 -Brian
 
 From: SuichII, Christopher [mailto:chris.su...@netapp.comhttp://netapp.com]
 Sent: Tuesday, August 06, 2013 10:57 AM
 To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Subject: [DISCUSS] Selectable UI list view rows
 
 One feature I'd like to look in to is allowing list views  to have 
 'selectable' rows. With this, users could check individual rows of a list 
 view to perform some action on a subset of the list. When one or more row is 
 selected, the list of actions at the top of the list view would be filtered 
 to only those which can be performed on the selected rows. Additionally, 
 there would be a checkbox in the header of the list view which would allow 
 the user to quickly select/unselect all items in the list.
 
 Maybe a quick mockup will help make this more clear:
 
 
 Any thoughts, concerns, feedback or existing plans for something like this?
 
 Thanks,
 Chris
 


Re: Is the simulator broken?

2013-08-06 Thread Chip Childers
On Tue, Aug 06, 2013 at 05:55:09PM +, Edison Su wrote:
 Can you try: mvn -P developer,systemvm,simulator  -D nonoss,simulator clean 
 install

What changed that requires this now?


RE: [VOTE] Update by-laws: non-technical decisions and other minor changes

2013-08-06 Thread Musayev, Ilya
+1

 -Original Message-
 From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com]
 Sent: Tuesday, August 06, 2013 1:58 PM
 To: dev@cloudstack.apache.org
 Subject: Re: [VOTE] Update by-laws: non-technical decisions and other minor
 changes
 
 +1
 
 On 8/5/13 2:43 PM, Noah Slater nsla...@apache.org wrote:
 
 Hi dev,
 
 I have some more by-law changes to propose. This is essentially round 2
 for these changes. I incorporated feedback from the last thread.
 
 Per the by-laws, we're using a lazy majority for this vote. Please cast
 your vote now. I will tally the results in 72 hours.
 
 Here's my changelog:
 
 * Removed some spurious nbsp; entities
 
 * Added A technical decision is any decision that involves changes to
 the source code that we distribute in our official releases. to §
 3.4.1 (Technical Decisions).
 
 * Added discussion-lead before consensus gathering in this section.
 
 * With the improved definition, I have tightened up the wording so that
 technical decisions must be made on @dev.
 
 * Added § 3.4.2, Non-Technical Decisions. Non-technical decisions are
 defined as in the inverse of technical decisions. They can be made on
 whatever list is appropriate. Formal voting will use a lazy 2/3 majority.
 Votes cannot be vetoed.
 
 * Changed § 3.4.3. (Release Plan) to limit decisions to @dev.
 
 * Changed § 3.4.4. (Product Release) to limit decisions to @dev.
 
 * Changed § 3.4.5. (Adoption of New Codebase) to limit decisions to @dev.
 
 * Changed § 3.4.10. (Modifying Bylaws) to limit decisions to @dev.
 
 * Added an Oxford comma to the final paras of § 3.4.1. and § 3.4.2.
 
 * Section renumbering to accommodate § 3.4.2.
 
 And here's the patch:
 
 Index: bylaws.mdtext
 =
 ==
 --- bylaws.mdtext (revision 1510739)
 +++ bylaws.mdtext (working copy)
 @@ -198,41 +198,64 @@
 
  3.4.1. Technical Decisions
 
 +A technical decision is any decision that involves changes to the
 +source
 code
 +that we distribute in our official releases.
 +
  Technical decisions should normally be made by the entire community
 using -consensusnbsp;gathering, and not through formal voting.
 +discussion-lead consensus gathering, and not through formal voting.
 
 -Technical decisions must be made on a project development mailing list.
 +Technical decisions must be made on the project development mailing list.
 
  During the consensus gathering process, technical decisions may be
 vetoed by  any Committer with a valid reason.
 
  If a formal vote is started for a technical decision, the vote will be
 held as -a lazynbsp;consensusnbsp;of active committers.
 +a lazy consensus of active committers.
 
 -Any user, contributor, committer or PMC member can initiate a
 technical
 +Any user, contributor, committer, or PMC member can initiate a
 +technical
  decision making process.
 
 -3.4.2. Release Plan
 +3.4.2. Non-Technical Decisions
 
 +A non-technical decisions is any decision that does not involve
 +changes
 to
 the
 +source code that we distribute in our official releases.
 +
 +Non-technical decisions should normally be made by the entire
 +community
 using
 +discussion-lead consensus-building, and not through formal voting.
 +
 +Non-technical decisions can be made on whichever project mailing list
 +is
 most
 +appropriate.
 +
 +Non-technical decisions cannot be vetoed, but if there is strong
 opposition
 +a formal vote can be used to resolve the dispute.
 +
 +If a formal vote is started for a non-technical decision, the vote
 +will
 be
 held
 +as a lazy 2/3 majority of active committers.
 +
 +Any user, contributor, committer, or PMC member can initiate a
 non-technical
 +decision making process.
 +
 +3.4.3. Release Plan
 +
  Defines the timetable and work items for a release. The plan also
 nominates a  Release Manager.
 
  A lazy majority of active committers is required for approval.
 
 -Any active committer or PMC member may call a vote. The vote must
 occur on a
 +Any active committer or PMC member may call a vote. The vote must
 +occur
 on
 the
  project development mailing list.
 
 -3.4.3. Product Release
 +3.4.4. Product Release
 
  When a release of one of the project's products is ready, a vote is
 required to  accept the release as an official release of the project.
 
  Lazy Majority of active PMC members is required for approval.
 
 -Any active committer or PMC member may call a vote. The vote must
 occur on a
 +Any active committer or PMC member may call a vote. The vote must
 +occur
 on
 the
  project development mailing list.
 
 -3.4.4. Adoption of New Codebase
 +3.4.5. Adoption of New Codebase
 
  When the codebase for an existing, released product is to be replaced
 with an  alternative codebase. If such a vote fails to gain approval,
 the existing code @@ -242,10 +265,10 @@
 
  Lazy 2/3 majority of active PMC members.
 
 -Any active committer or PMC member may call a vote. The vote must
 occur on a
 +Any active committer or PMC member 

RE: Documentation Question

2013-08-06 Thread Musayev, Ilya
Hi Mike,

We use publican for documentation.

There is a section on wiki for docs, 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Doc+Writers

Perhaps it will be helpful.

Regards
ilya

 -Original Message-
 From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
 Sent: Tuesday, August 06, 2013 2:53 PM
 To: dev@cloudstack.apache.org
 Subject: Documentation Question
 
 Hi,
 
 I am working on documenting the SolidFire (storage) plug-in I developed for
 4.2.
 
 I have plenty of documentation handy, but am not familiar with how I should
 document this for CloudStack.
 
 Would someone be able to point me to a template so I know how mine
 documentation should look and where it should be placed?
 
 Thanks!
 
 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*



Re: Documentation Question

2013-08-06 Thread Mike Tutkowski
Great - thanks for the info!


On Tue, Aug 6, 2013 at 1:05 PM, Musayev, Ilya imusa...@webmd.net wrote:

 Hi Mike,

 We use publican for documentation.

 There is a section on wiki for docs,
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Doc+Writers

 Perhaps it will be helpful.

 Regards
 ilya

  -Original Message-
  From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
  Sent: Tuesday, August 06, 2013 2:53 PM
  To: dev@cloudstack.apache.org
  Subject: Documentation Question
 
  Hi,
 
  I am working on documenting the SolidFire (storage) plug-in I developed
 for
  4.2.
 
  I have plenty of documentation handy, but am not familiar with how I
 should
  document this for CloudStack.
 
  Would someone be able to point me to a template so I know how mine
  documentation should look and where it should be placed?
 
  Thanks!
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the
  cloudhttp://solidfire.com/solution/overview/?video=play
  *(tm)*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


Re: Review Request 13237: Unable to resize disk with Zone wide storage

2013-08-06 Thread Rajesh Battala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/
---

(Updated Aug. 6, 2013, 7:13 p.m.)


Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.


Changes
---

Incorporated comments 
rebased with latest 4.2 and tested the patch.


Bugs: 3781


Repository: cloudstack-git


Description
---

Issue:
== 
for Volume operations we are finding the hypervisor type. Volume can be in 
ZONE/Cluster scope storage pool. 
when volume is in ZONE scope, there is issue with they way we fetch the 
hypervisor type. It was written to handle Cluster scope only.

fixed:
==
Fixed with sql queries to fetch the Hypervisor type.
1. Fetch the hypervisor type for volume from storage pool table if the voluem 
is in ZONE scope storage pool.
2. Fetch the hypervisor type for volume from cluster table if the voluem is in 
CLUSTER scope storage pool.


Diffs (updated)
-

  engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 

Diff: https://reviews.apache.org/r/13237/diff/


Testing
---

Setup:
KVM and Xenserver with Adv Zone.
Added pool Zone scope on KVM and Cluster Scope on Xenserver 
1. created instances on KVM and xenserver.
2. Create two volumes attached to instances on KVM and Xenserver. 
3. vol1 is in Zone scope and vol2 is in cluster scope. 
4. Successfully performed resize opertions on vol1 and vol2.
5. Succssfully attached/detaches volumes


Thanks,

Rajesh Battala



RE: CONSOLE access via API

2013-08-06 Thread Musayev, Ilya
Antonio,

Would you explain what the end goal is?

Console access is token based and works directly with your browser and java 
plugin, I'm not certain what you would achieve by executing console access 
command in command line.

Regards
ilya


 -Original Message-
 From: Antonio Petrocelli [mailto:a.petroce...@netsons.com]
 Sent: Tuesday, August 06, 2013 3:32 AM
 To: dev@cloudstack.apache.org
 Subject: CONSOLE access via API
 
 Hello,
 
 Under CloudStack UI interface, the console link is:
 http://xx.xx.xx.xx:8080/client/console?cmd=accessvm=x
 
 I'm trying to use signiture under API, all other commands works, but I'm
 trying to get VM console, just not work:
 
 http://xx.xx.xx.xx:8080/client/console?cmd=accessvm=xsignatu
 re=XX
 
 or
 http://xx.xx.xx.xx:8080/client/api?cmd=accessvm=xsignature=X
 X
 
 Could any friend point me correct command for console access through API?
 
 Thanks!




Re: [ACS411] 4.1.1 status

2013-08-06 Thread Chip Childers
This was a mistake in our release process, however instead of
re-spinning a 4.1.2 release just for this issue, I've chosen to modify
debian/changelog in the source release copy that I built the debs from.
They are now correct in cloudstack.apt-get.eu.


On Tue, Aug 06, 2013 at 06:59:15PM +, Musayev, Ilya wrote:
 Wido,
 
 Just to confirm,
 
 Did you switch to the proper commit or tag?
 
 Thanks
 ilya
 
  -Original Message-
  From: Wido den Hollander [mailto:w...@widodh.nl]
  Sent: Tuesday, August 06, 2013 3:10 AM
  To: dev@cloudstack.apache.org
  Subject: Re: [ACS411] 4.1.1 status
  
  Hi Chip,
  
  On 08/05/2013 08:01 PM, Chip Childers wrote:
   Hi all,
  
   Here's where we are:
  
   DEBs (oss) are loaded into the cloustack.apt-get.eu repo.
  
  The DEBs contain snapshot in their version number. I don't think that is
  correct, is it?
  
  Wido
  
   RPMs (nonoss) are being built now and will be pushed as soon as
   complete (soon)
  
   David is building the docs now.
  
   I'll announce once the RPM's and docs are published.
  
   -chip
  
 
 
 


Re: Review Request 13237: Unable to resize disk with Zone wide storage

2013-08-06 Thread edison su

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24736
---

Ship it!


Ship It!

- edison su


On Aug. 6, 2013, 7:13 p.m., Rajesh Battala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13237/
 ---
 
 (Updated Aug. 6, 2013, 7:13 p.m.)
 
 
 Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
 
 
 Bugs: 3781
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Issue:
 == 
 for Volume operations we are finding the hypervisor type. Volume can be in 
 ZONE/Cluster scope storage pool. 
 when volume is in ZONE scope, there is issue with they way we fetch the 
 hypervisor type. It was written to handle Cluster scope only.
 
 fixed:
 ==
 Fixed with sql queries to fetch the Hypervisor type.
 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
 is in ZONE scope storage pool.
 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
 in CLUSTER scope storage pool.
 
 
 Diffs
 -
 
   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
 
 Diff: https://reviews.apache.org/r/13237/diff/
 
 
 Testing
 ---
 
 Setup:
 KVM and Xenserver with Adv Zone.
 Added pool Zone scope on KVM and Cluster Scope on Xenserver 
 1. created instances on KVM and xenserver.
 2. Create two volumes attached to instances on KVM and Xenserver. 
 3. vol1 is in Zone scope and vol2 is in cluster scope. 
 4. Successfully performed resize opertions on vol1 and vol2.
 5. Succssfully attached/detaches volumes
 
 
 Thanks,
 
 Rajesh Battala
 




RE: api calls in 4.1.1

2013-08-06 Thread Musayev, Ilya
Daan,

The commit CLOUDSTACK-3080 seems like the only change that was made - that 
would be related.

I'm about to try this out and find it - if that's what broke it.

Thanks
ilya

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Monday, August 05, 2013 2:26 PM
 To: dev
 Subject: Re: api calls in 4.1.1
 
 Ilya,
 
 listVirtualMachines (as user) for one, but I got a second report that wasn't
 very precise yet, so I will be working on reproducing next days and report
 back (wit test case or patch)
 
 regards,
 
 On Mon, Aug 5, 2013 at 6:56 PM, Chip Childers chip.child...@sungard.com
 wrote:
  On Mon, Aug 05, 2013 at 10:42:53AM +0200, Daan Hoogland wrote:
  H,
 
  What is the status of 4.1.1 at this moment. I am getting several
  reports of api calls not working as before. I saw the vote passing by
  but didn't give them much attention. In jira I don't see much mention
  of such issues. Is this noticed by anybosy else?
 
  regards,
  Daan
 
 
  4.1.1 status is that we are working on pushing the docs, and then the
  release will be announced.
 
  -chip




RE: IP Address Allocation

2013-08-06 Thread Alex Huang
I'll say it's a bad design.  He he I designed it.  :(  We had to make some 
compromises due to time constraints.

I always intended to move the ip allocation into NetworkGurus and actually 
attempted to several times but, at the end for various reasons, we just 
couldn't complete that task.  I generally believe that ip address allocation 
can actually be done even without CloudStack's database, for example, if it 
came from a master dhcp server or some IT central database.  So an interface 
like IpAddressReserver to abstract that functionality would be great.

I have to say the number of implementations for NetworkGuru grew faster than I 
expected.  In one sense, it's a good sign that everyone was able to use it but 
then it exposes the work that was incomplete to begin with.  

IIRC, there's basically two problems I left on NetworkGuru to be better 
designed.  One is this ip address allocation.  The other problem is how to 
identify which set of NetworkGurus should manage the network.  I believe that 
selection process should be much more transparent to the administrator who 
setup the CS deployment but because at the time only VLAN isolation was 
supported, I did not put that into CS.  As more and more SDN technologies come 
online, it's best we design that process.  I think Hugo made some changes there 
but I haven't had a chance to study how that all works now in 4.x yet.
 
There are some artifacts in the code to show I was thinking about this.  For 
example, Network and Nic carries the Isolation URI instead of just VLAN tag 
because it was intended to be cast by the NetworkGuru and then transported to 
the hypervisor.  We expected anyone who plugs into CloudStack have two places 
to plug into:  orchestration and actual provisioning.  So the NetworkGuru forms 
the URI for isolation and then it has code at the hypervisor side to resolve 
the URI to something that the hypervisor can understand. 

--Alex

 -Original Message-
 From: Soheil Eizadi [mailto:seiz...@infoblox.com]
 Sent: Tuesday, August 6, 2013 11:54 AM
 To: dev@cloudstack.apache.org
 Subject: RE: IP Address Allocation
 
 Agree that the IP Address allocation is different than the DHCP and DNS
 service offered by the NetworkElements.
 
 The third party NetworkGurus just reference the standard NetworkManager
 IP Address Allocation routines, either directly (e.g.
 _networkMgr.assignPublicIpAddress()) or by calling out to the
 GuestNetworkGuru. I would say in the current design the Network Manager
 manages the IP Addresses not the Network Gurus. I don't think this is a bad
 design, in that the NetworkGurus are sharing the same  ip address allocation
 and get new features (e.g. IP reservation or VM migration) without
 implementing new code to support them.
 -Soheil
 
 
 From: Alex Huang [alex.hu...@citrix.com]
 Sent: Tuesday, August 06, 2013 11:27 AM
 To: Chiradeep Vittal; dev@cloudstack.apache.org
 Subject: RE: IP Address Allocation
 
 We can either break NetworkManager down further and say NetworkGuru
 sets the actual parameters of the network and a new IpAddressReserver
 sets the ip address or we can let NetworkGurus identify the
 IpAddressReserver to use themselves.  I generally think NetworkManager
 shouldn't care where the ip address came from because it really shouldn't
 know anything about the actual network we're laying out for the end user.
 That's always been left to the NetworkGurus.  If you think about it from that
 perspective, then it's natural that ip address is allocated by the 
 NetworkGuru.
 But I can see different NetworkGurus may want to share the same ip address
 allocation tables/schemes so an interface for them to share that code does
 make sense.
 
 Note there's a difference between allocating ip address and the act of
 actually issuing the ip address and associating the ip address to a fqdn.  
 That
 act is performed by the network elements.  Here we're specifically saying
 who is responsible for figuring out the ip address that can be allocated to a
 particular vm and works within a network.
 
 --Alex
 
  -Original Message-
  From: Chiradeep Vittal
  Sent: Tuesday, August 6, 2013 11:14 AM
  To: dev@cloudstack.apache.org
  Cc: Alex Huang
  Subject: Re: IP Address Allocation
 
  The way the gurus are consulted for network design and reservation
  makes it difficult to put this inside a guru.
  However it does seem odd to put this inside an element. Perhaps we
  need a 3rd type (IpAddressReserver?)
 
 
  On 8/6/13 10:42 AM, Soheil Eizadi seiz...@infoblox.com wrote:
 
  The NetworkGuru does a lot more than IP address allocation, e.g.
  handle the Layer2/3 networking unique to the particular vendor. There
  are a lot of NetworkElements providing their own NetworkGuru plugins
  (Nicira, MidoNet, ...) extending the standard CloudStack Gurus.
  
  The feature of providing IP Address Allocation, DHCP and DNS is
  common for all these networks, so rather than provide our 

RE: Documentation Question

2013-08-06 Thread Jessica Tomechak
Mike,
Is this what you are looking for?

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Doc+Writers

Jessica T.

From: Mike Tutkowski [mike.tutkow...@solidfire.com]
Sent: Tuesday, August 06, 2013 11:52 AM
To: dev@cloudstack.apache.org
Subject: Documentation Question

Hi,

I am working on documenting the SolidFire (storage) plug-in I developed for
4.2.

I have plenty of documentation handy, but am not familiar with how I should
document this for CloudStack.

Would someone be able to point me to a template so I know how mine
documentation should look and where it should be placed?

Thanks!

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


Re: Documentation Question

2013-08-06 Thread Mike Tutkowski
Yeah - thanks! :)


On Tue, Aug 6, 2013 at 2:17 PM, Jessica Tomechak 
jessica.tomec...@citrix.com wrote:

 Mike,
 Is this what you are looking for?

 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Doc+Writers

 Jessica T.
 
 From: Mike Tutkowski [mike.tutkow...@solidfire.com]
 Sent: Tuesday, August 06, 2013 11:52 AM
 To: dev@cloudstack.apache.org
 Subject: Documentation Question

 Hi,

 I am working on documenting the SolidFire (storage) plug-in I developed for
 4.2.

 I have plenty of documentation handy, but am not familiar with how I should
 document this for CloudStack.

 Would someone be able to point me to a template so I know how mine
 documentation should look and where it should be placed?

 Thanks!

 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *™*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


Re: Documentation Question

2013-08-06 Thread Mike Tutkowski
It looks like I'll need to provide an XML file using certain tags and then
link to it from another doc.

I'm working on the content now.

Thanks again


On Tue, Aug 6, 2013 at 2:22 PM, Mike Tutkowski mike.tutkow...@solidfire.com
 wrote:

 Yeah - thanks! :)


 On Tue, Aug 6, 2013 at 2:17 PM, Jessica Tomechak 
 jessica.tomec...@citrix.com wrote:

 Mike,
 Is this what you are looking for?

 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Doc+Writers

 Jessica T.
 
 From: Mike Tutkowski [mike.tutkow...@solidfire.com]
 Sent: Tuesday, August 06, 2013 11:52 AM
 To: dev@cloudstack.apache.org
 Subject: Documentation Question

 Hi,

 I am working on documenting the SolidFire (storage) plug-in I developed
 for
 4.2.

 I have plenty of documentation handy, but am not familiar with how I
 should
 document this for CloudStack.

 Would someone be able to point me to a template so I know how mine
 documentation should look and where it should be placed?

 Thanks!

 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *™*




 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the 
 cloudhttp://solidfire.com/solution/overview/?video=play
 *™*




-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


Re: queryAsyncJobResult ISSUE on 4.1.0

2013-08-06 Thread Chiradeep Vittal
Is it possible that you actually called StartVm ?

From: Antonio Petrocelli 
a.petroce...@netsons.commailto:a.petroce...@netsons.com
Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Date: Tuesday, August 6, 2013 6:50 AM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: queryAsyncJobResult ISSUE on 4.1.0

It is normal that after a deployVirtualMachine request the 
queryAsyncJobResult response is:

'cmd' = 'org.apache.cloudstack.api.command.user.vm.StartVMCmd' ?

it should be:

'cmd' = 'org.apache.cloudstack.api.command.user.vm.DeployVMCmd'

Thanks



Re: queryAsyncJobResult ISSUE on 4.1.0

2013-08-06 Thread Alena Prokharchyk
Just tested for deployVm command, DeployVMCmd is returned in the response:

queryasyncjobresultresponse cloud-stack-version=4.2.0-SNAPSHOT
accountid26ffed14-feb8-11e2-aad9-664f5bd82b4f/accountid
userid27002e0a-feb8-11e2-aad9-664f5bd82b4f/userid
cmd
org.apache.cloudstack.api.command.user.vm.DeployVMCmd
/cmd
jobstatus1/jobstatus




From: Chiradeep Vittal 
chiradeep.vit...@citrix.commailto:chiradeep.vit...@citrix.com
Date: Tuesday, August 6, 2013 1:33 PM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Cc: Alena Prokharchyk 
alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com
Subject: Re: queryAsyncJobResult ISSUE on 4.1.0

Is it possible that you actually called StartVm ?

From: Antonio Petrocelli 
a.petroce...@netsons.commailto:a.petroce...@netsons.com
Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Date: Tuesday, August 6, 2013 6:50 AM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: queryAsyncJobResult ISSUE on 4.1.0

It is normal that after a deployVirtualMachine request the 
queryAsyncJobResult response is:

'cmd' = 'org.apache.cloudstack.api.command.user.vm.StartVMCmd' ?

it should be:

'cmd' = 'org.apache.cloudstack.api.command.user.vm.DeployVMCmd'

Thanks



Re: Help needed with Cloudstack Setup

2013-08-06 Thread Chiradeep Vittal
Why would your primary (local) storage have a different IP than 
host-corporate-ip?
There is also a flag system.vm.use.local.storage which tells CloudStack to use 
local storage for system vms.

From: Sarath Chandra 
sarath.cloudst...@gmail.commailto:sarath.cloudst...@gmail.com
Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Date: Tuesday, August 6, 2013 4:33 AM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
Subject: Help needed with Cloudstack Setup

Hi All,

I am doing a fresh cloudstack installation and am not able to instantiate any 
VMs (both system  guest vms). I am seeing the following errors:

ERROR [network.element.SspElement] (consoleproxy-1:ctx-6d22b00c) 
ReservationContext was null for NicProfile[2-1-null-null-null 
Ntwk[202|Control|3]
ERROR [network.element.SspElement] (secstorage-1:ctx-3f99cd9c) 
ReservationContext was null for NicProfile[84-22-null-10.20.30.11-null 
Ntwk[200|Public|1]
ERROR [network.element.SspElement] (consoleproxy-1:ctx-6d22b00c) 
ReservationContext was null for NicProfile[3-1-null-null-null 
Ntwk[201|Management|2]
WARN  [cloud.consoleproxy.ConsoleProxyManagerImpl] 
(consoleproxy-1:ctx-6d22b00c) Exception while trying to start console proxy
com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
deployment for VM[ConsoleProxy|v-1-VM]Scope=interface com.cloud.dc.DataCenter; 
id=1

at a later place
com.cloud.utils.exception.CloudRuntimeException: Failed to find template 
routing-3 in VMTemplateStoragePool


I suspect my configuration is wrong some where. Can anybody kindly check and 
confirm if my configuration is right. If its right, then please point me to the 
likely cause of this issue.


I have attached a picture to this mail which shows my lab setup. To give a 
brief, the following is my setup:

Server -- Switch 1 -- Switch 2  KVM 
Hypervisor

The switches allow all Vlan traffic to pass through them (basically trunk all 
and have added vlans 3100,3200,3300 to both the switches)


On my server I have done the following:


  *   Ubuntu 13.04 OS
  *   Started NFS and exported to /mnt/primary (not using this) and 
/mnt/secondary
  *   Installed the System template by executing the command  :  
cloud-install-sys-tmplt -m /mnt/secondary -u 
http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2 -h 
kvm -o localhost -r root -d
  *   $ mvn clean install -P developer,systemvm
  *   $ mvn -P developer -pl developer -Ddeploydb  (Deployed the db)
  *   $ mvn -pl :cloud-client-ui jetty:run  (Started the management server)

On my hypervisor I have the following:

  *   Ubuntu 13.04 OS
  *   KVM as hypervisor

Server Interface configuration:
eth0 : Corporate Lab network ip (lets call it as server-corporate-ip)
eth1.3200 : 172.16.10.1 (assigned during CS setup)   [eth1.3200 is a 
subinterface on eth1]

Global Settings:
system.vm.use.local.storage = true

Zone Setup details:
DNS 18.8.8.8
DNS 28.8.4.4
Internal DNS 1172.16.10.1
Guest CIDR10.1.1.0/24http://10.1.1.0/24
Local storage enabledYes


Pod Setup
Netmask255.255.255.0
Start IP172.16.20.10
End IP172.16.20.100
Gateway172.16.20.1
Allocation StateEnabled
DedicatedNo

Cluster Setup
ZoneZone-1
PodPod-1
HypervisorKVM
Cluster TypeCloudManaged

Host Setup
Resource stateEnabled
StateUp
TypeRouting  (?? why routing)
Host Tags
OS PreferenceNone
ZoneZone-1
PodPod-1
ClusterCluster-1
IP Address172.16.10.10
Version4.2.0-SNAPSHOT
DedicatedNo

Primary Storage (Auto Configured)
Name : Hypervisor name Local Storage
StateUp
PodPod-1
ClusterCluster-1
TypeFilesystem
IP Address172.16.10.10
Path/var/lib/libvirt/images
Disk Total221.23 GB

Secondary Storage
Name : SecondaryStorage-1
URLnfs://server-corporate-ip/mnt/secondary
ProviderNFS
ScopeZONE
ZoneZone-1


Hypervisor Interface configuration:
eth0 : Corporate Lab network ip (lets call it ashost-corporate-ip)
eth1.3100 : 172.16.10.10
eth1.3200 : assigned to cloudbr0
eth1.3300 : assigned to cloudbr1

I have created the sub-interfaces as per CS hypervisor install guide.

agent.properties (has got auto configured)
#Storage
#Tue Aug 06 15:20:15 IST 2013
guest.network.device=cloudbr0
workers=5
private.network.device=
cloudbr0
port=8250
resource=com.cloud.hypervisor.kvm.resource.LibvirtComputingResource
pod=1
zone=1
guid=acc23093-6630-3c1a-aeb0-39367415bf6b
cluster=1
public.network.device=cloudbr0
local.storage.uuid=7c7e70ab-7e5d-4766-8d5c-f51935b780c4
domr.scripts.dir=scripts/network/domr/kvm
host=server-corporate-ip
LibvirtComputingResource.id=1


thanks and regards,
Sarath
















Re: please provide access to cwiki for my account

2013-08-06 Thread Chiradeep Vittal
I don't have the karma to do this, but I do notice there are 2 of you in
Confluence.

On 8/6/13 3:41 AM, Rajesh Battala rajesh.batt...@citrix.com wrote:

After resetting the password also am still facing the issue.
Please do the needful.

Thanks
Rajesh Battala

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: Tuesday, August 6, 2013 3:14 PM
To: dev@cloudstack.apache.org
Subject: please provide access to cwiki for my account

Hi ,

Am not able to view any page in cwiki after login-in.
Am getting permission denied for any page view.
Here is my account email
rajesh.batt...@citrix.commailto:rajesh.batt...@citrix.com
Please provide access to my a/c.


Thanks
Rajesh Battala



[DISCUSS] CSS framework for CloudStack UI

2013-08-06 Thread Brian Federle
Hey all,

As part of the next release, I'm planning on doing a lot of cleanup of our 
massive heap of CSS code. As part of this, I want to start using SASS/SCSS 
(http://sass-lang.com/) to improve organization and maintainability.

Particularly, this would allow:

- Splitting CSS into multiple files (by feature), instead of one large 3000+ 
line CSS. This is then compiled into one CSS during the build, so the browser 
doesn't have to make multiple requests.
- Hierarchical organization, to reduce redundant selectors
- Can easily utilize great helper libraries (i.e., http://bourbon.io,) and a 
semantic grid system for cleaner + responsive layout (i.e., 
http://neat.bourbon.io/)

Since it supports all standard CSS syntax, our UI code can be gradually 
converted feature-by-feature, and we can still retain any legacy CSS for 
certain functionality, if necessary.

The only problem I cannot handle is integrating the SASS compiler (which 
converts .scss-.css) into the UI build phase. I've found a maven plugin at 
https://github.com/Jasig/sass-maven-plugin, so if anyone wants to tackle that 
it would be awesome.

Any other thoughts?

-Brian


Re: Help needed with Cloudstack Setup

2013-08-06 Thread Marcus Sorensen
Any reason why you aren't using the developer packages? I don't see
any info regarding the agent install.  Did you also set your KVM
traffic labels for the various networks (I'm assuming cloubr0 and
cloudbr1 are for management, public, guest bridges, but not sure which
is which, management is 3200, maybe?) whats the 3100 addr for?

On Tue, Aug 6, 2013 at 2:41 PM, Chiradeep Vittal
chiradeep.vit...@citrix.com wrote:
 Why would your primary (local) storage have a different IP than 
 host-corporate-ip?
 There is also a flag system.vm.use.local.storage which tells CloudStack to 
 use local storage for system vms.

 From: Sarath Chandra 
 sarath.cloudst...@gmail.commailto:sarath.cloudst...@gmail.com
 Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Date: Tuesday, August 6, 2013 4:33 AM
 To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Subject: Help needed with Cloudstack Setup

 Hi All,

 I am doing a fresh cloudstack installation and am not able to instantiate any 
 VMs (both system  guest vms). I am seeing the following errors:

 ERROR [network.element.SspElement] (consoleproxy-1:ctx-6d22b00c) 
 ReservationContext was null for NicProfile[2-1-null-null-null 
 Ntwk[202|Control|3]
 ERROR [network.element.SspElement] (secstorage-1:ctx-3f99cd9c) 
 ReservationContext was null for NicProfile[84-22-null-10.20.30.11-null 
 Ntwk[200|Public|1]
 ERROR [network.element.SspElement] (consoleproxy-1:ctx-6d22b00c) 
 ReservationContext was null for NicProfile[3-1-null-null-null 
 Ntwk[201|Management|2]
 WARN  [cloud.consoleproxy.ConsoleProxyManagerImpl] 
 (consoleproxy-1:ctx-6d22b00c) Exception while trying to start console proxy
 com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
 deployment for VM[ConsoleProxy|v-1-VM]Scope=interface 
 com.cloud.dc.DataCenter; id=1

 at a later place
 com.cloud.utils.exception.CloudRuntimeException: Failed to find template 
 routing-3 in VMTemplateStoragePool


 I suspect my configuration is wrong some where. Can anybody kindly check and 
 confirm if my configuration is right. If its right, then please point me to 
 the likely cause of this issue.


 I have attached a picture to this mail which shows my lab setup. To give a 
 brief, the following is my setup:

 Server -- Switch 1 -- Switch 2  KVM 
 Hypervisor

 The switches allow all Vlan traffic to pass through them (basically trunk all 
 and have added vlans 3100,3200,3300 to both the switches)


 On my server I have done the following:


   *   Ubuntu 13.04 OS
   *   Started NFS and exported to /mnt/primary (not using this) and 
 /mnt/secondary
   *   Installed the System template by executing the command  :  
 cloud-install-sys-tmplt -m /mnt/secondary -u 
 http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2 
 -h kvm -o localhost -r root -d
   *   $ mvn clean install -P developer,systemvm
   *   $ mvn -P developer -pl developer -Ddeploydb  (Deployed the db)
   *   $ mvn -pl :cloud-client-ui jetty:run  (Started the management server)

 On my hypervisor I have the following:

   *   Ubuntu 13.04 OS
   *   KVM as hypervisor

 Server Interface configuration:
 eth0 : Corporate Lab network ip (lets call it as server-corporate-ip)
 eth1.3200 : 172.16.10.1 (assigned during CS setup)   [eth1.3200 is a 
 subinterface on eth1]

 Global Settings:
 system.vm.use.local.storage = true

 Zone Setup details:
 DNS 18.8.8.8
 DNS 28.8.4.4
 Internal DNS 1172.16.10.1
 Guest CIDR10.1.1.0/24http://10.1.1.0/24
 Local storage enabledYes


 Pod Setup
 Netmask255.255.255.0
 Start IP172.16.20.10
 End IP172.16.20.100
 Gateway172.16.20.1
 Allocation StateEnabled
 DedicatedNo

 Cluster Setup
 ZoneZone-1
 PodPod-1
 HypervisorKVM
 Cluster TypeCloudManaged

 Host Setup
 Resource stateEnabled
 StateUp
 TypeRouting  (?? why routing)
 Host Tags
 OS PreferenceNone
 ZoneZone-1
 PodPod-1
 ClusterCluster-1
 IP Address172.16.10.10
 Version4.2.0-SNAPSHOT
 DedicatedNo

 Primary Storage (Auto Configured)
 Name : Hypervisor name Local Storage
 StateUp
 PodPod-1
 ClusterCluster-1
 TypeFilesystem
 IP Address172.16.10.10
 Path/var/lib/libvirt/images
 Disk Total221.23 GB

 Secondary Storage
 Name : SecondaryStorage-1
 URLnfs://server-corporate-ip/mnt/secondary
 ProviderNFS
 ScopeZONE
 ZoneZone-1


 Hypervisor Interface configuration:
 eth0 : Corporate Lab network ip (lets call it ashost-corporate-ip)
 eth1.3100 : 172.16.10.10
 eth1.3200 : assigned to cloudbr0
 eth1.3300 : assigned to cloudbr1

 I have created the sub-interfaces as per CS hypervisor install guide.

 agent.properties (has got auto configured)
 #Storage
 #Tue Aug 06 15:20:15 IST 2013
 guest.network.device=cloudbr0
 workers=5
 

Re: Help needed with Cloudstack Setup

2013-08-06 Thread Marcus Sorensen
Also, what version are you deploying? 4.1.1?

On Tue, Aug 6, 2013 at 2:48 PM, Marcus Sorensen shadow...@gmail.com wrote:
 Any reason why you aren't using the developer packages? I don't see
 any info regarding the agent install.  Did you also set your KVM
 traffic labels for the various networks (I'm assuming cloubr0 and
 cloudbr1 are for management, public, guest bridges, but not sure which
 is which, management is 3200, maybe?) whats the 3100 addr for?

 On Tue, Aug 6, 2013 at 2:41 PM, Chiradeep Vittal
 chiradeep.vit...@citrix.com wrote:
 Why would your primary (local) storage have a different IP than 
 host-corporate-ip?
 There is also a flag system.vm.use.local.storage which tells CloudStack to 
 use local storage for system vms.

 From: Sarath Chandra 
 sarath.cloudst...@gmail.commailto:sarath.cloudst...@gmail.com
 Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Date: Tuesday, August 6, 2013 4:33 AM
 To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Subject: Help needed with Cloudstack Setup

 Hi All,

 I am doing a fresh cloudstack installation and am not able to instantiate 
 any VMs (both system  guest vms). I am seeing the following errors:

 ERROR [network.element.SspElement] (consoleproxy-1:ctx-6d22b00c) 
 ReservationContext was null for NicProfile[2-1-null-null-null 
 Ntwk[202|Control|3]
 ERROR [network.element.SspElement] (secstorage-1:ctx-3f99cd9c) 
 ReservationContext was null for NicProfile[84-22-null-10.20.30.11-null 
 Ntwk[200|Public|1]
 ERROR [network.element.SspElement] (consoleproxy-1:ctx-6d22b00c) 
 ReservationContext was null for NicProfile[3-1-null-null-null 
 Ntwk[201|Management|2]
 WARN  [cloud.consoleproxy.ConsoleProxyManagerImpl] 
 (consoleproxy-1:ctx-6d22b00c) Exception while trying to start console proxy
 com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
 deployment for VM[ConsoleProxy|v-1-VM]Scope=interface 
 com.cloud.dc.DataCenter; id=1

 at a later place
 com.cloud.utils.exception.CloudRuntimeException: Failed to find template 
 routing-3 in VMTemplateStoragePool


 I suspect my configuration is wrong some where. Can anybody kindly check and 
 confirm if my configuration is right. If its right, then please point me to 
 the likely cause of this issue.


 I have attached a picture to this mail which shows my lab setup. To give a 
 brief, the following is my setup:

 Server -- Switch 1 -- Switch 2  
 KVM Hypervisor

 The switches allow all Vlan traffic to pass through them (basically trunk 
 all and have added vlans 3100,3200,3300 to both the switches)


 On my server I have done the following:


   *   Ubuntu 13.04 OS
   *   Started NFS and exported to /mnt/primary (not using this) and 
 /mnt/secondary
   *   Installed the System template by executing the command  :  
 cloud-install-sys-tmplt -m /mnt/secondary -u 
 http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2 
 -h kvm -o localhost -r root -d
   *   $ mvn clean install -P developer,systemvm
   *   $ mvn -P developer -pl developer -Ddeploydb  (Deployed the db)
   *   $ mvn -pl :cloud-client-ui jetty:run  (Started the management server)

 On my hypervisor I have the following:

   *   Ubuntu 13.04 OS
   *   KVM as hypervisor

 Server Interface configuration:
 eth0 : Corporate Lab network ip (lets call it as server-corporate-ip)
 eth1.3200 : 172.16.10.1 (assigned during CS setup)   [eth1.3200 is a 
 subinterface on eth1]

 Global Settings:
 system.vm.use.local.storage = true

 Zone Setup details:
 DNS 18.8.8.8
 DNS 28.8.4.4
 Internal DNS 1172.16.10.1
 Guest CIDR10.1.1.0/24http://10.1.1.0/24
 Local storage enabledYes


 Pod Setup
 Netmask255.255.255.0
 Start IP172.16.20.10
 End IP172.16.20.100
 Gateway172.16.20.1
 Allocation StateEnabled
 DedicatedNo

 Cluster Setup
 ZoneZone-1
 PodPod-1
 HypervisorKVM
 Cluster TypeCloudManaged

 Host Setup
 Resource stateEnabled
 StateUp
 TypeRouting  (?? why routing)
 Host Tags
 OS PreferenceNone
 ZoneZone-1
 PodPod-1
 ClusterCluster-1
 IP Address172.16.10.10
 Version4.2.0-SNAPSHOT
 DedicatedNo

 Primary Storage (Auto Configured)
 Name : Hypervisor name Local Storage
 StateUp
 PodPod-1
 ClusterCluster-1
 TypeFilesystem
 IP Address172.16.10.10
 Path/var/lib/libvirt/images
 Disk Total221.23 GB

 Secondary Storage
 Name : SecondaryStorage-1
 URLnfs://server-corporate-ip/mnt/secondary
 ProviderNFS
 ScopeZONE
 ZoneZone-1


 Hypervisor Interface configuration:
 eth0 : Corporate Lab network ip (lets call it ashost-corporate-ip)
 eth1.3100 : 172.16.10.10
 eth1.3200 : assigned to cloudbr0
 eth1.3300 : assigned to cloudbr1

 I have created the sub-interfaces as per CS hypervisor install guide.

 

RE: What are the new features in 4.2?

2013-08-06 Thread Animesh Chaturvedi


 -Original Message-
 From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
 Sent: Tuesday, August 06, 2013 11:55 AM
 To: dev@cloudstack.apache.org
 Subject: Re: What are the new features in 4.2?
 
 Thanks again, Wei.
 
 It's silly what happened (just noticed). I thought I was logged in to
 JIRA, but it was another web system, so not being logged in is why that
 option was disabled. :)
 
[Animesh] :)
 
 On Tue, Aug 6, 2013 at 12:44 PM, Mike Tutkowski 
 mike.tutkow...@solidfire.com wrote:
 
  Thanks!
 
 
  On Tue, Aug 6, 2013 at 12:42 PM, Wei ZHOU ustcweiz...@gmail.com
 wrote:
 
  Mike,
 
  I closed it.
 
 
  2013/8/6 Mike Tutkowski mike.tutkow...@solidfire.com
 
   Hi Animesh,
  
   Upon seeing your e-mail here, I tried to go in and mark mine as
  Resolved,
   but the control for this is disabled.
  
   https://issues.apache.org/jira/browse/CLOUDSTACK-2778
  
  
   On Tue, Aug 6, 2013 at 12:00 PM, Animesh Chaturvedi 
   animesh.chaturv...@citrix.com wrote:
  
You can use this JIRA filter for 4.2 features and improvements
https://issues.apache.org/jira/issues/#?filter=12323963
   
Some of the items are in open state which I am following to get
them closed.
   
   
Thanks
Animesh
   
   
   
   
 -Original Message-
 From: Nux! [mailto:n...@li.nux.ro]
 Sent: Tuesday, August 06, 2013 10:30 AM
 To: cloudstack-...@incubator.apache.org
 Subject: What are the new features in 4.2?

 Hello guys,

 I've been trying to find a definitive new features for 4.2,
 but failed. Can anyone point me to the right URL or make a
 summary of what's new?

 Thanks,
 Lucian

 --
 Sent from the Delta quadrant using Borg technology!

 Nux!
 www.nux.ro
   
  
  
  
   --
   *Mike Tutkowski*
   *Senior CloudStack Developer, SolidFire Inc.*
   e: mike.tutkow...@solidfire.com
   o: 303.746.7302
   Advancing the way the world uses the
   cloudhttp://solidfire.com/solution/overview/?video=play
   *(tm)*
  
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the
  cloudhttp://solidfire.com/solution/overview/?video=play
  *(tm)*
 
 
 
 
 --
 *Mike Tutkowski*
 *Senior CloudStack Developer, SolidFire Inc.*
 e: mike.tutkow...@solidfire.com
 o: 303.746.7302
 Advancing the way the world uses the
 cloudhttp://solidfire.com/solution/overview/?video=play
 *(tm)*


Re: Help needed with Cloudstack Setup

2013-08-06 Thread Marcus Sorensen
4.2.0-SNAPSHOT -- this will require a newer system vm than the one
you installed. see
http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/

On Tue, Aug 6, 2013 at 2:52 PM, Marcus Sorensen shadow...@gmail.com wrote:
 Also, what version are you deploying? 4.1.1?

 On Tue, Aug 6, 2013 at 2:48 PM, Marcus Sorensen shadow...@gmail.com wrote:
 Any reason why you aren't using the developer packages? I don't see
 any info regarding the agent install.  Did you also set your KVM
 traffic labels for the various networks (I'm assuming cloubr0 and
 cloudbr1 are for management, public, guest bridges, but not sure which
 is which, management is 3200, maybe?) whats the 3100 addr for?

 On Tue, Aug 6, 2013 at 2:41 PM, Chiradeep Vittal
 chiradeep.vit...@citrix.com wrote:
 Why would your primary (local) storage have a different IP than 
 host-corporate-ip?
 There is also a flag system.vm.use.local.storage which tells CloudStack to 
 use local storage for system vms.

 From: Sarath Chandra 
 sarath.cloudst...@gmail.commailto:sarath.cloudst...@gmail.com
 Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Date: Tuesday, August 6, 2013 4:33 AM
 To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org 
 dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
 Subject: Help needed with Cloudstack Setup

 Hi All,

 I am doing a fresh cloudstack installation and am not able to instantiate 
 any VMs (both system  guest vms). I am seeing the following errors:

 ERROR [network.element.SspElement] (consoleproxy-1:ctx-6d22b00c) 
 ReservationContext was null for NicProfile[2-1-null-null-null 
 Ntwk[202|Control|3]
 ERROR [network.element.SspElement] (secstorage-1:ctx-3f99cd9c) 
 ReservationContext was null for NicProfile[84-22-null-10.20.30.11-null 
 Ntwk[200|Public|1]
 ERROR [network.element.SspElement] (consoleproxy-1:ctx-6d22b00c) 
 ReservationContext was null for NicProfile[3-1-null-null-null 
 Ntwk[201|Management|2]
 WARN  [cloud.consoleproxy.ConsoleProxyManagerImpl] 
 (consoleproxy-1:ctx-6d22b00c) Exception while trying to start console proxy
 com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
 deployment for VM[ConsoleProxy|v-1-VM]Scope=interface 
 com.cloud.dc.DataCenter; id=1

 at a later place
 com.cloud.utils.exception.CloudRuntimeException: Failed to find template 
 routing-3 in VMTemplateStoragePool


 I suspect my configuration is wrong some where. Can anybody kindly check 
 and confirm if my configuration is right. If its right, then please point 
 me to the likely cause of this issue.


 I have attached a picture to this mail which shows my lab setup. To give a 
 brief, the following is my setup:

 Server -- Switch 1 -- Switch 2  
 KVM Hypervisor

 The switches allow all Vlan traffic to pass through them (basically trunk 
 all and have added vlans 3100,3200,3300 to both the switches)


 On my server I have done the following:


   *   Ubuntu 13.04 OS
   *   Started NFS and exported to /mnt/primary (not using this) and 
 /mnt/secondary
   *   Installed the System template by executing the command  :  
 cloud-install-sys-tmplt -m /mnt/secondary -u 
 http://download.cloud.com/templates/acton/acton-systemvm-02062012.qcow2.bz2 
 -h kvm -o localhost -r root -d
   *   $ mvn clean install -P developer,systemvm
   *   $ mvn -P developer -pl developer -Ddeploydb  (Deployed the db)
   *   $ mvn -pl :cloud-client-ui jetty:run  (Started the management server)

 On my hypervisor I have the following:

   *   Ubuntu 13.04 OS
   *   KVM as hypervisor

 Server Interface configuration:
 eth0 : Corporate Lab network ip (lets call it as server-corporate-ip)
 eth1.3200 : 172.16.10.1 (assigned during CS setup)   [eth1.3200 is a 
 subinterface on eth1]

 Global Settings:
 system.vm.use.local.storage = true

 Zone Setup details:
 DNS 18.8.8.8
 DNS 28.8.4.4
 Internal DNS 1172.16.10.1
 Guest CIDR10.1.1.0/24http://10.1.1.0/24
 Local storage enabledYes


 Pod Setup
 Netmask255.255.255.0
 Start IP172.16.20.10
 End IP172.16.20.100
 Gateway172.16.20.1
 Allocation StateEnabled
 DedicatedNo

 Cluster Setup
 ZoneZone-1
 PodPod-1
 HypervisorKVM
 Cluster TypeCloudManaged

 Host Setup
 Resource stateEnabled
 StateUp
 TypeRouting  (?? why routing)
 Host Tags
 OS PreferenceNone
 ZoneZone-1
 PodPod-1
 ClusterCluster-1
 IP Address172.16.10.10
 Version4.2.0-SNAPSHOT
 DedicatedNo

 Primary Storage (Auto Configured)
 Name : Hypervisor name Local Storage
 StateUp
 PodPod-1
 ClusterCluster-1
 TypeFilesystem
 IP Address172.16.10.10
 Path/var/lib/libvirt/images
 Disk Total221.23 GB

 Secondary Storage
 Name : SecondaryStorage-1
 URLnfs://server-corporate-ip/mnt/secondary
 ProviderNFS
 ScopeZONE
 ZoneZone-1


 Hypervisor Interface configuration:
 eth0 : 

Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Chiradeep Vittal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13252/#review24743
---



plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
https://reviews.apache.org/r/13252/#comment48851

What is the impact on upgrades? That is, I already have users with salt 
length 20. You might have to check with both?
Also, you could make it 'final static int' I guess.



plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
https://reviews.apache.org/r/13252/#comment48849

convention is to have the } else { on the same line



- Chiradeep Vittal


On Aug. 5, 2013, 7:06 p.m., Amogh Vasekar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13252/
 ---
 
 (Updated Aug. 5, 2013, 7:06 p.m.)
 
 
 Review request for cloudstack and John Burwell.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2312 and 
 https://issues.apache.org/jira/browse/CLOUDSTACK-2314
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 1. Fix timing attack by using a constant-time comparison function
 2. Increase salt size
 3. Make flow for invalid user go through full normal execution using a fake 
 password and salt
 
 
 Diffs
 -
 
   
 plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
  da939273ea10bff3b2687c9684edf8a5d0ab4b2e 
 
 Diff: https://reviews.apache.org/r/13252/diff/
 
 
 Testing
 ---
 
 Local environment
 
 
 Thanks,
 
 Amogh Vasekar
 




Re: please provide access to cwiki for my account

2013-08-06 Thread David Nalley
Rajesh:

I noticed you weren't listed in the confluence-users group.
I have added your account to that group. Let me know if you have any problems.

--David

On Tue, Aug 6, 2013 at 5:44 AM, Rajesh Battala
rajesh.batt...@citrix.com wrote:
 Hi ,

 Am not able to view any page in cwiki after login-in.
 Am getting permission denied for any page view.
 Here is my account email 
 rajesh.batt...@citrix.commailto:rajesh.batt...@citrix.com
 Please provide access to my a/c.


 Thanks
 Rajesh Battala


Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor

2013-08-06 Thread Venkata Siva Vijayendra Bhamidipati

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13008/
---

(Updated Aug. 6, 2013, 9:10 p.m.)


Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh 
Chodapuneedi, and William Chan.


Changes
---

Updating refactored patch that applies on top of latest 4.2 branch. All testing 
as described previously was redone with the new patch and all cases passed.


Bugs: CLOUDSTACK-3886


Repository: cloudstack-git


Description
---

The vminstancename flag has been incorrectly used to simply append the 
displayname to the internal VM name that shows up on vCenter in vmware 
deployments. It was intended to show the actual name supplied as hostname, on 
the hypervisor. This helps admins and deployers to quickly identify VMs and 
resolve issues related to those VMs. Its usage is very limited as it stands 
now. This fix corrects it to ensure that the name of the VM on the hypervisor 
matches the hostname if it is supplied, and if the vm.instancename.flag is set 
to true.


Diffs (updated)
-

  
engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
 96fb1d9 
  plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
292f7e9 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 8d6bdb8 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 6b721de 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 d395425 
  
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 fe127e3 
  server/src/com/cloud/configuration/Config.java ad8e3aa 
  server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 
  server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8 
  server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b33ee49 
  setup/db/db/schema-410to420.sql b3206af 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java 
11bc157 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 
d20eb6f 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java cb97b26 
  vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java 
ac14328 

Diff: https://reviews.apache.org/r/13008/diff/


Testing
---

Post this change, all major VM operations, namely 
creation/destruction/expunging/start/stop/reboot of the VM have been tested and 
observed to work correctly. Part of this patch also puts in a fix for VMSync 
operations where the CS mgmt server doesn't detect that a guest VM is down, if 
the guest VM has been shut down/powered off in vCenter. Other operations such 
as VM snapshot, volume snapshots of disks belonging to the VM, volume migration 
across primaries, volume attach/detach have also been tested and they are 
working as expected. This is a functional change, and completely transparent to 
any of cloudstack's existing functionalities and all the test cases that cover 
the above code paths and APIs - all existing tests should and do pass - no new 
tests are necessary.


UPDATE for 08/05/2013
=
4.2 code has diverged - need to refactor the patch on top of latest 4.2. Will 
test out refactored patch and resubmit.


Thanks,

Venkata Siva Vijayendra Bhamidipati



Re: api calls in 4.1.1

2013-08-06 Thread Daan Hoogland
H Ilya,

I am not at the bottom of this yet. It seems the api no longer returns
the full list hence a certain key can not be found in the result set.
We are looking at it (between other work). If this is the case a test
scenario would need a big set of VMs:(

regards,

On Tue, Aug 6, 2013 at 10:16 PM, Musayev, Ilya imusa...@webmd.net wrote:
 Daan,

 The commit CLOUDSTACK-3080 seems like the only change that was made - that 
 would be related.

 I'm about to try this out and find it - if that's what broke it.

 Thanks
 ilya

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Monday, August 05, 2013 2:26 PM
 To: dev
 Subject: Re: api calls in 4.1.1

 Ilya,

 listVirtualMachines (as user) for one, but I got a second report that wasn't
 very precise yet, so I will be working on reproducing next days and report
 back (wit test case or patch)

 regards,

 On Mon, Aug 5, 2013 at 6:56 PM, Chip Childers chip.child...@sungard.com
 wrote:
  On Mon, Aug 05, 2013 at 10:42:53AM +0200, Daan Hoogland wrote:
  H,
 
  What is the status of 4.1.1 at this moment. I am getting several
  reports of api calls not working as before. I saw the vote passing by
  but didn't give them much attention. In jira I don't see much mention
  of such issues. Is this noticed by anybosy else?
 
  regards,
  Daan
 
 
  4.1.1 status is that we are working on pushing the docs, and then the
  release will be announced.
 
  -chip




Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13252/
---

(Updated Aug. 6, 2013, 9:51 p.m.)


Review request for cloudstack and John Kinsella.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2312 and 
https://issues.apache.org/jira/browse/CLOUDSTACK-2314


Repository: cloudstack-git


Description
---

1. Fix timing attack by using a constant-time comparison function
2. Increase salt size
3. Make flow for invalid user go through full normal execution using a fake 
password and salt


Diffs
-

  
plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
 da939273ea10bff3b2687c9684edf8a5d0ab4b2e 

Diff: https://reviews.apache.org/r/13252/diff/


Testing
---

Local environment


Thanks,

Amogh Vasekar



Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Chiradeep Vittal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13252/#review24757
---


Can you add tests to AuthenticatorTest.java
1. authenticate('FooUser', 'FooPassword') takes as long as 
authenticate('ValidUser', 'ValidPassword') takes as long as 
authenticate('ValidUser', 'FooPassword')
2. authenticate('ValidUserWith20byteSalt', 'ValidPassword') succeeds

- Chiradeep Vittal


On Aug. 6, 2013, 9:59 p.m., Amogh Vasekar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13252/
 ---
 
 (Updated Aug. 6, 2013, 9:59 p.m.)
 
 
 Review request for cloudstack and John Kinsella.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2312 and 
 https://issues.apache.org/jira/browse/CLOUDSTACK-2314
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 1. Fix timing attack by using a constant-time comparison function
 2. Increase salt size
 3. Make flow for invalid user go through full normal execution using a fake 
 password and salt
 
 
 Diffs
 -
 
   
 plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
  da939273ea10bff3b2687c9684edf8a5d0ab4b2e 
 
 Diff: https://reviews.apache.org/r/13252/diff/
 
 
 Testing
 ---
 
 Local environment
 
 
 Thanks,
 
 Amogh Vasekar
 




Re: TEST or integration test?

2013-08-06 Thread Min Chen
For /engine/storage/integration-test, I know that those tests are TestNG
test cases, requiring DB existence.

Thanks
-min

On 8/6/13 2:59 PM, Alex Huang alex.hu...@citrix.com wrote:

I noticed that some of our unit tests are run in integration-test stage
of maven.  Shouldn't that be in the test phase?  Does anyone know why
it's set at integration-test?  I based this observation on the surefire
plugins are set for integration-test phase.  Note the following.

./engine/orchestration/pom.xml-phaseintegration-test/phase
./engine/storage/integration-test/pom.xml-
phaseintegration-test/phase
./engine/storage/volume/pom.xml-
phaseintegration-test/phase
./plugins/storage/image/default/pom.xml-
phaseintegration-test/phase
./plugins/storage/image/sample/pom.xml-
phaseintegration-test/phase
./plugins/storage/image/swift/pom.xml-
phaseintegration-test/phase
./plugins/storage/volume/default/pom.xml-
phaseintegration-test/phase
./plugins/storage/volume/sample/pom.xml-
phaseintegration-test/phase
./plugins/storage/volume/solidfire/pom.xml-
phaseintegration-test/phase

I think integration test is probably just the smoke test that Prasanna
has written.  We should enforce that in the maven build.  Does that make
sense?

--Alex



Re: Review Request 13252: SHA256 timing attack and brute force attack fix

2013-08-06 Thread Demetrius Tsitrelis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13252/#review24759
---

Ship it!


Ship It!

- Demetrius Tsitrelis


On Aug. 6, 2013, 9:59 p.m., Amogh Vasekar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13252/
 ---
 
 (Updated Aug. 6, 2013, 9:59 p.m.)
 
 
 Review request for cloudstack and John Kinsella.
 
 
 Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-2312 and 
 https://issues.apache.org/jira/browse/CLOUDSTACK-2314
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 1. Fix timing attack by using a constant-time comparison function
 2. Increase salt size
 3. Make flow for invalid user go through full normal execution using a fake 
 password and salt
 
 
 Diffs
 -
 
   
 plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
  da939273ea10bff3b2687c9684edf8a5d0ab4b2e 
 
 Diff: https://reviews.apache.org/r/13252/diff/
 
 
 Testing
 ---
 
 Local environment
 
 
 Thanks,
 
 Amogh Vasekar
 




RE: api calls in 4.1.1

2013-08-06 Thread Musayev, Ilya
Daan,

Take this back - the error was on my part it seems (I've used cloudmonkey with 
api/secret keys for another test user).

Once I fixed the secret and api keys to a proper user that had vms, I would see 
the vms entitled to that user.

If you do come around on specifics of this issue, please let me know.

Thanks
ilya

 -Original Message-
 From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
 Sent: Tuesday, August 06, 2013 5:31 PM
 To: dev
 Subject: Re: api calls in 4.1.1
 
 H Ilya,
 
 I am not at the bottom of this yet. It seems the api no longer returns the 
 full
 list hence a certain key can not be found in the result set.
 We are looking at it (between other work). If this is the case a test scenario
 would need a big set of VMs:(
 
 regards,
 
 On Tue, Aug 6, 2013 at 10:16 PM, Musayev, Ilya imusa...@webmd.net
 wrote:
  Daan,
 
  The commit CLOUDSTACK-3080 seems like the only change that was made -
 that would be related.
 
  I'm about to try this out and find it - if that's what broke it.
 
  Thanks
  ilya
 
  -Original Message-
  From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
  Sent: Monday, August 05, 2013 2:26 PM
  To: dev
  Subject: Re: api calls in 4.1.1
 
  Ilya,
 
  listVirtualMachines (as user) for one, but I got a second report that
  wasn't very precise yet, so I will be working on reproducing next
  days and report back (wit test case or patch)
 
  regards,
 
  On Mon, Aug 5, 2013 at 6:56 PM, Chip Childers
  chip.child...@sungard.com
  wrote:
   On Mon, Aug 05, 2013 at 10:42:53AM +0200, Daan Hoogland wrote:
   H,
  
   What is the status of 4.1.1 at this moment. I am getting several
   reports of api calls not working as before. I saw the vote passing
   by but didn't give them much attention. In jira I don't see much
   mention of such issues. Is this noticed by anybosy else?
  
   regards,
   Daan
  
  
   4.1.1 status is that we are working on pushing the docs, and then
   the release will be announced.
  
   -chip
 
 




Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Sheng Yang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24756
---



api/src/com/cloud/network/Networks.java
https://reviews.apache.org/r/12849/#comment48880

I don't quite understand this part. Why // is missing in this case? Who 
would require // and who wouldn't?



api/src/com/cloud/network/Networks.java
https://reviews.apache.org/r/12849/#comment48877

I think by following the previous case, it should be 
URI(scheme,value.toString()) rather than null, null. It possibly doesn't make 
difference, but it's better not to use different constructor.

The same with several URI constructor above.

And I doubt if it's really need to discard this check. At least they would 
working for other broadcast domain type.



api/src/com/cloud/network/Networks.java
https://reviews.apache.org/r/12849/#comment48879

No reference of getTypeOf(URI) in the code? 



api/src/com/cloud/network/Networks.java
https://reviews.apache.org/r/12849/#comment48878

Does this function need to be public? I think getSchemeValue() and 
getTypeOf(String str) should be enough?


- Sheng Yang


On Aug. 6, 2013, 2:25 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12849/
 ---
 
 (Updated Aug. 6, 2013, 2:25 p.m.)
 
 
 Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, 
 and Sheng Yang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Both BroadcastDomainType and IsolationType needed some extra code for 
 backwards compatibility
 
 
 Diffs
 -
 
   api/src/com/cloud/network/Networks.java c76c3d4 
   api/test/com/cloud/network/NetworksTest.java 31114e8 
 
 Diff: https://reviews.apache.org/r/12849/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: Review Request 13323: if a failure occurs while adding VM to another network (this should be the first vm in the subnet). The ip alias created as a part of this process is not removed.

2013-08-06 Thread Sheng Yang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13323/#review24762
---



server/src/com/cloud/network/NetworkManager.java
https://reviews.apache.org/r/13323/#comment48882

Seems not neceesary.



server/src/com/cloud/network/NetworkManagerImpl.java
https://reviews.apache.org/r/13323/#comment48887

It's better to show the semantic of if this is the last nic in the subnet 
in code. Say, if (vm.getType() == Type.User  it's the last nic)



server/src/com/cloud/network/NetworkManagerImpl.java
https://reviews.apache.org/r/13323/#comment48885

Uppercase Subnet.



server/src/com/cloud/vm/VirtualMachineManagerImpl.java
https://reviews.apache.org/r/13323/#comment48886

Why we still need this if networkid is null then we remove all? 
removeNic() for each network in network manager is not enough?


- Sheng Yang


On Aug. 6, 2013, 12:48 p.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13323/
 ---
 
 (Updated Aug. 6, 2013, 12:48 p.m.)
 
 
 Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
 
 
 Bugs: Cloudstack-4083
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 https://issues.apache.org/jira/browse/CLOUDSTACK-4083
 if a failure occurs while adding VM to another network (this should be the 
 first vm in the subnet). The ip alias created as a part of this process is 
 not removed. 
 
 This occurred because we were not cleaning the alias ips in the event of a 
 failure.
 
 As a part of the fix.
 1.) moved the function removeDhcpServiceInsubnet and listLastNicsInSubnet to 
 NetworkManager (These were in VirtualMachineManagerImpl earlier.)
 2.) add the call to clean ipAlias in the remove nic function of the 
 networkManager.
 3.) Modified the removeDhcpServiceInsubnet to take network ad an argument. 
 This will help in removing only the ipAlias which belong to a particular 
 network.
 
 
 Diffs
 -
 
   server/src/com/cloud/network/NetworkManager.java dab7a13 
   server/src/com/cloud/network/NetworkManagerImpl.java effee96 
   server/src/com/cloud/vm/VirtualMachineManagerImpl.java b33ee49 
   server/test/com/cloud/network/MockNetworkManagerImpl.java 7f34e55 
   server/test/com/cloud/vpc/MockNetworkManagerImpl.java 178ebba 
 
 Diff: https://reviews.apache.org/r/13323/diff/
 
 
 Testing
 ---
 
 Tested on 4.2.
 created two guest networks guest1 and guest2.
 created VMS in both the networks. 
 Added a VM(with no PV drivers) from guest1 to guest2.
 this failed and on failure ipAlias configured as part of nic creation was 
 removed.
 
 Deleting the vm causes all the removal of all ipAliases from all the subnets 
 in which this is the lastvm.
 
 
 Thanks,
 
 bharat kumar
 




Re: Review Request 12098: Add PCI Passthrough to CloudStack on KVM Hypervisor

2013-08-06 Thread Chiradeep Vittal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12098/#review24763
---


Can you rebase against latest master? How does this apply to Xenserver?

- Chiradeep Vittal


On July 2, 2013, 7:12 a.m., Pawit Pornkitprasan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12098/
 ---
 
 (Updated July 2, 2013, 7:12 a.m.)
 
 
 Review request for cloudstack.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 This patch adds PCI Passthrough support to CloudStack on the KVM Hypervisor 
 as previously mentioned on the mailing list
 
 PCI Passthrough may be useful for high-performance networking devices
 or other hardware accelerators. This patch does not care what kind of
 the device it is or attempt to configure it, leaving it to the guest.
 
 Because the devices available at each agent may be different, the
 available devices for passthrough are configured at the agent
 configuration file (/etc/cloudstack/agent/agent.properties).
 Configuration is a comma separated list of available PCI devices and
 its given name.
 
 pci.devices=28:00.1|10GE,28:00.2|10GE,28:00.3|10GE,28:00.4|10GE,28:00.5|10GE,28:00.6|10GE,28:00.7|10GE,28:01.0|10GE
 
 At agent startup, the list of PCI devices is parsed and sent together
 with StartupRoutingCommand (in a new field, not in details). The
 management server then stores it in a new table “op_host_pci_devices”.
 If a device is added, removed, or renamed, the table is updated
 accordingly. The agent also probes libvirt which devices are currently
 in-use and send it with the command in attempt to synchronize any
 potential difference between the database and the actual status.
 
 The “name” of the PCI device is what is used to assign a device. In a
 compute offering, the user can specify the name of one or more PCI
 devices (as a comma-separated list) and CloudStack will find a host
 with the PCI device of the specified name available and assign it.
 
 A new manager, PciDeviceManager, is created to handle the
 allocation of PCI device. The manager implements StateListener and
 assigns PCI devices on state change to “starting” and also release the
 devices VM stop. First fit allocator and first fit planner are also
 modified to check for PCI device availability accordingly.
 
 For migration, intrusive migration is implementated. The PCI device is
 detached before migration and attached it again at the target host.
 This will interrupt whatever is using the device on the VM. However,
 it may be desirable for networking devices where the VM can use a
 bonding device to channel network traffic through the normal
 virtualized network device while the PCI Passthrough device is down.
 
 
 Diffs
 -
 
   api/src/com/cloud/agent/api/to/PciDeviceTO.java PRE-CREATION 
   api/src/com/cloud/agent/api/to/VirtualMachineTO.java e6240ff 
   api/src/com/cloud/offering/ServiceOffering.java 45d5f38 
   api/src/com/cloud/pci/PciDevice.java PRE-CREATION 
   api/src/org/apache/cloudstack/api/ApiConstants.java 8ac7c3f 
   
 api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
  decac29 
   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
 288f76b 
   client/WEB-INF/classes/resources/messages.properties ad8d29d 
   client/tomcatconf/applicationContext.xml.in ac1f3e4 
   core/src/com/cloud/agent/api/AttachPciDevicesCommand.java PRE-CREATION 
   core/src/com/cloud/agent/api/StartupRoutingCommand.java 5961ab0 
   engine/schema/src/com/cloud/host/HostPciDeviceVO.java PRE-CREATION 
   engine/schema/src/com/cloud/host/HostVO.java c814b94 
   engine/schema/src/com/cloud/host/dao/HostDaoImpl.java 810b973 
   engine/schema/src/com/cloud/host/dao/HostPciDevicesDao.java PRE-CREATION 
   engine/schema/src/com/cloud/host/dao/HostPciDevicesDaoImpl.java 
 PRE-CREATION 
   engine/schema/src/com/cloud/migration/ServiceOffering21VO.java 7a49e63 
   engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
  60cde8c 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
  a283768 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
  5120870 
   server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 
 b6286aa 
   server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 
   server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 6f6e277 
   server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 05ff5f3 
   server/src/com/cloud/configuration/ConfigurationManager.java 98eae37 
   

[API][4.1.1] ALL VMs for ALL users, domains and projects

2013-08-06 Thread Musayev, Ilya
How do you go about seeing *all* vms for *all* users in *all* domains and 
projects?

The admin user UI does not do it in 4.1.1

Thanks
ilya


RE: [API][4.1.1] ALL VMs for ALL users, domains and projects

2013-08-06 Thread Musayev, Ilya
When I say it does not do it, I don't see all VMs under general instances tab, 
I have to drill down to specific project to see them.

 -Original Message-
 From: Musayev, Ilya [mailto:imusa...@webmd.net]
 Sent: Tuesday, August 06, 2013 8:15 PM
 To: dev@cloudstack.apache.org
 Subject: [API][4.1.1] ALL VMs for ALL users, domains and projects
 
 How do you go about seeing *all* vms for *all* users in *all* domains and
 projects?
 
 The admin user UI does not do it in 4.1.1
 
 Thanks
 ilya



Re: [DISCUSS] CSS framework for CloudStack UI

2013-08-06 Thread Ian Duffy
+1 to that definitely!


 The only problem I cannot handle is integrating the SASS compiler (which 
 converts .scss-.css) into the UI build phase. I've found a maven plugin at 
 https://github.com/Jasig/sass-maven-plugin, so if anyone wants to tackle that 
  it would be awesome.


Below is a meer suggestion, I've only read about it and never done it.
I believe you are able to chain grunt into the maven life cycle. This
would allow us to do various things with the front end code. This
includes but is not limited to:

- JSHint
- Unit tests via xyz(suggesting QUnit or Jasmine) framework
- Static analysis of the javascript with Plato
- Compiling SASS + LESS
- Uglifying/Minifying
- Optimise images(png crush etc.)
- Dependency management of 3rd party js libs

It would supply us with a bunch nicer build process for the UI
elements of Cloudstack. However it would add a dependency of nodejs to
the build process.


Question about GUI refresh logic

2013-08-06 Thread Mike Tutkowski
Hi,

I'm curious when I should expect the GUI to refresh and when I should be
expected to manually do so.

For example, after I destroy a VM, the GUI refreshes to tell me the VM's in
the destroyed state.

However, to see when the VM is actually expunged, I have to refresh
manually by clicking on the Instance tab.

Is that expected behavior?

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Dave Cahill

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24766
---


Replied to Sheng's comments.


api/src/com/cloud/network/Networks.java
https://reviews.apache.org/r/12849/#comment4

Sheng, not sure if you caught the conversation around breaking backwards 
compatibility, but it explains these changes.

the reason for using the 4-parameter URI constructor is that it creates 
scheme://value URIs, which is what this method used to do before it was 
changed on July 19. There is no 2-parameter URI constructor, so I guess you're 
proposing the 3-parameter constructor - however that creates a URI without // - 
see https://gist.github.com/davecahill/6170364 for an example.

As for the check, this was also added in the July 19 commit - it causes 
Exceptions on valid input (colons in the value param are valid), which is why 
I'm proposing we remove it.

Hope that explains it - feel free to grab me on IRC for more details if 
needed.


- Dave Cahill


On Aug. 6, 2013, 2:25 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12849/
 ---
 
 (Updated Aug. 6, 2013, 2:25 p.m.)
 
 
 Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, 
 and Sheng Yang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Both BroadcastDomainType and IsolationType needed some extra code for 
 backwards compatibility
 
 
 Diffs
 -
 
   api/src/com/cloud/network/Networks.java c76c3d4 
   api/test/com/cloud/network/NetworksTest.java 31114e8 
 
 Diff: https://reviews.apache.org/r/12849/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: [API][4.1.1] ALL VMs for ALL users, domains and projects

2013-08-06 Thread Simon Weller
Ilya, 


This has been the status quo since 4.0. It would definitely be nice to be able 
to list all running VMs, rather than have to drill down to projects. 


- Si 

- Original Message -

From: Ilya Musayev imusa...@webmd.net 
To: dev@cloudstack.apache.org 
Sent: Tuesday, August 6, 2013 7:16:43 PM 
Subject: RE: [API][4.1.1] ALL VMs for ALL users, domains and projects 

When I say it does not do it, I don't see all VMs under general instances tab, 
I have to drill down to specific project to see them. 

 -Original Message- 
 From: Musayev, Ilya [mailto:imusa...@webmd.net] 
 Sent: Tuesday, August 06, 2013 8:15 PM 
 To: dev@cloudstack.apache.org 
 Subject: [API][4.1.1] ALL VMs for ALL users, domains and projects 
 
 How do you go about seeing *all* vms for *all* users in *all* domains and 
 projects? 
 
 The admin user UI does not do it in 4.1.1 
 
 Thanks 
 ilya 




Comment about Data Disk Offering when creating a VM from an ISO

2013-08-06 Thread Mike Tutkowski
Hi,

I noticed while creating a VM from an ISO today that I am taken to a page
in the wizard that talks about a Data Disk Offering.

It seems a bit confusing to me because I don't actually get a data disk
once the wizard has spun up the VM. This Data Disk Offering page is
displayed to collect data regarding the size of the root disk the VM will
have.

Any thoughts on this? Is this a known issue or should I log a bug?

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloudhttp://solidfire.com/solution/overview/?video=play
*™*


RE: TEST or integration test?

2013-08-06 Thread Alex Huang
So is the difference between test and integration-test is that the code access 
db?  I've noticed a great deal of test code that's been disabled by hand as 
well.  A proper test should just mock the db layer.  

To me it would make sense if we use an in memory db like derby for the unit 
tests.

--Alex

 -Original Message-
 From: Min Chen [mailto:min.c...@citrix.com]
 Sent: Tuesday, August 6, 2013 3:58 PM
 To: dev@cloudstack.apache.org
 Subject: Re: TEST or integration test?
 
 For /engine/storage/integration-test, I know that those tests are TestNG
 test cases, requiring DB existence.
 
 Thanks
 -min
 
 On 8/6/13 2:59 PM, Alex Huang alex.hu...@citrix.com wrote:
 
 I noticed that some of our unit tests are run in integration-test stage
 of maven.  Shouldn't that be in the test phase?  Does anyone know why
 it's set at integration-test?  I based this observation on the surefire
 plugins are set for integration-test phase.  Note the following.
 
 ./engine/orchestration/pom.xml-phaseintegration-test/phase
 ./engine/storage/integration-test/pom.xml-
 phaseintegration-test/phase
 ./engine/storage/volume/pom.xml-
 phaseintegration-test/phase
 ./plugins/storage/image/default/pom.xml-
 phaseintegration-test/phase
 ./plugins/storage/image/sample/pom.xml-
 phaseintegration-test/phase
 ./plugins/storage/image/swift/pom.xml-
 phaseintegration-test/phase
 ./plugins/storage/volume/default/pom.xml-
 phaseintegration-test/phase
 ./plugins/storage/volume/sample/pom.xml-
 phaseintegration-test/phase
 ./plugins/storage/volume/solidfire/pom.xml-
 phaseintegration-test/phase
 
 I think integration test is probably just the smoke test that Prasanna
 has written.  We should enforce that in the maven build.  Does that
 make sense?
 
 --Alex



Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Sheng Yang


 On Aug. 7, 2013, 1:10 a.m., Dave Cahill wrote:
  api/src/com/cloud/network/Networks.java, line 135
  https://reviews.apache.org/r/12849/diff/5/?file=337785#file337785line135
 
  Sheng, not sure if you caught the conversation around breaking 
  backwards compatibility, but it explains these changes.
  
  the reason for using the 4-parameter URI constructor is that it creates 
  scheme://value URIs, which is what this method used to do before it was 
  changed on July 19. There is no 2-parameter URI constructor, so I guess 
  you're proposing the 3-parameter constructor - however that creates a URI 
  without // - see https://gist.github.com/davecahill/6170364 for an example.
  
  As for the check, this was also added in the July 19 commit - it causes 
  Exceptions on valid input (colons in the value param are valid), which is 
  why I'm proposing we remove it.
  
  Hope that explains it - feel free to grab me on IRC for more details if 
  needed.

Got it, thanks for explaining!


- Sheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24766
---


On Aug. 6, 2013, 2:25 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12849/
 ---
 
 (Updated Aug. 6, 2013, 2:25 p.m.)
 
 
 Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, 
 and Sheng Yang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Both BroadcastDomainType and IsolationType needed some extra code for 
 backwards compatibility
 
 
 Diffs
 -
 
   api/src/com/cloud/network/Networks.java c76c3d4 
   api/test/com/cloud/network/NetworksTest.java 31114e8 
 
 Diff: https://reviews.apache.org/r/12849/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Sheng Yang


 On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote:
  api/src/com/cloud/network/Networks.java, line 135
  https://reviews.apache.org/r/12849/diff/5/?file=337785#file337785line135
 
  I think by following the previous case, it should be 
  URI(scheme,value.toString()) rather than null, null. It possibly doesn't 
  make difference, but it's better not to use different constructor.
  
  The same with several URI constructor above.
  
  And I doubt if it's really need to discard this check. At least they 
  would working for other broadcast domain type.

Dave explained this. Please drop this issue.


- Sheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24756
---


On Aug. 6, 2013, 2:25 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12849/
 ---
 
 (Updated Aug. 6, 2013, 2:25 p.m.)
 
 
 Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, 
 and Sheng Yang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Both BroadcastDomainType and IsolationType needed some extra code for 
 backwards compatibility
 
 
 Diffs
 -
 
   api/src/com/cloud/network/Networks.java c76c3d4 
   api/test/com/cloud/network/NetworksTest.java 31114e8 
 
 Diff: https://reviews.apache.org/r/12849/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Dave Cahill


 On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote:
  api/src/com/cloud/network/Networks.java, line 135
  https://reviews.apache.org/r/12849/diff/5/?file=337785#file337785line135
 
  I think by following the previous case, it should be 
  URI(scheme,value.toString()) rather than null, null. It possibly doesn't 
  make difference, but it's better not to use different constructor.
  
  The same with several URI constructor above.
  
  And I doubt if it's really need to discard this check. At least they 
  would working for other broadcast domain type.
 
 Sheng Yang wrote:
 Dave explained this. Please drop this issue.

Thanks for the quick reply Sheng! 

Actually, I dug deeper and realized that if we use the 4-parameter URI 
constructor, the value parameter is interpreted as host, and colons wouldn't 
be allowed!

It looks like the only way to preserve the behavior as it was is to stick with 
the old string concatenation behavior of scheme + :// + value. In fact, this 
is what Daan and I agreed on in IRC yesterday, but it looks like he went with 
the 4 param constructor - I'll discuss with  him later to see what changed.


- Dave


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24756
---


On Aug. 6, 2013, 2:25 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12849/
 ---
 
 (Updated Aug. 6, 2013, 2:25 p.m.)
 
 
 Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, 
 and Sheng Yang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Both BroadcastDomainType and IsolationType needed some extra code for 
 backwards compatibility
 
 
 Diffs
 -
 
   api/src/com/cloud/network/Networks.java c76c3d4 
   api/test/com/cloud/network/NetworksTest.java 31114e8 
 
 Diff: https://reviews.apache.org/r/12849/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Sheng Yang


 On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote:
  api/src/com/cloud/network/Networks.java, line 135
  https://reviews.apache.org/r/12849/diff/5/?file=337785#file337785line135
 
  I think by following the previous case, it should be 
  URI(scheme,value.toString()) rather than null, null. It possibly doesn't 
  make difference, but it's better not to use different constructor.
  
  The same with several URI constructor above.
  
  And I doubt if it's really need to discard this check. At least they 
  would working for other broadcast domain type.
 
 Sheng Yang wrote:
 Dave explained this. Please drop this issue.
 
 Dave Cahill wrote:
 Thanks for the quick reply Sheng! 
 
 Actually, I dug deeper and realized that if we use the 4-parameter URI 
 constructor, the value parameter is interpreted as host, and colons 
 wouldn't be allowed!
 
 It looks like the only way to preserve the behavior as it was is to stick 
 with the old string concatenation behavior of scheme + :// + value. In 
 fact, this is what Daan and I agreed on in IRC yesterday, but it looks like 
 he went with the 4 param constructor - I'll discuss with  him later to see 
 what changed.

Thank you Dave!


- Sheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24756
---


On Aug. 6, 2013, 2:25 p.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12849/
 ---
 
 (Updated Aug. 6, 2013, 2:25 p.m.)
 
 
 Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, 
 and Sheng Yang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Both BroadcastDomainType and IsolationType needed some extra code for 
 backwards compatibility
 
 
 Diffs
 -
 
   api/src/com/cloud/network/Networks.java c76c3d4 
   api/test/com/cloud/network/NetworksTest.java 31114e8 
 
 Diff: https://reviews.apache.org/r/12849/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




Re: Review Request: Freshness Check for doc xml on section Storage Setup

2013-08-06 Thread Gavin Lee
Appreciate if someone can help to review this doc.
Otherwise, it will be deferred to future release.
Thanks.



On Fri, Jul 26, 2013 at 7:23 AM, Jessica Tomechak 
jessica.tomec...@gmail.com wrote:

 Can anyone please review the newly added doc? Otherwise we have to decide
 whether to revert the commit before 4.2. Do we want to publish a doc
 section that's almost certainly inaccurate?

 Here is a link straight to the file that needs a look.


 https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob;f=docs/en-US/storage-setup.xml;h=dee2f4ccbd721439bf17b4aacbca80d0128b6070;hb=78ffb7ae5ef9c4383f86fa97cd647316dde507be

 Any help would be much appreciated.

 Jessica T.


 On Thu, Jun 6, 2013 at 4:30 AM, Gavin Lee gavin@gmail.com wrote:

  For CLOUDSTACK-1597 
 https://issues.apache.org/jira/browse/CLOUDSTACK-1597
  ,
  I made the changes weeks ago.
  The commit id on master is: 78ffb7ae5ef9c4383f86fa97cd647316dde507be
 
  It'll be great if someone can help to review in case some materials
 missing
  or out of date since the storage part changed a lot.
 
  Thanks.
  --
  Gavin
 




-- 
Gavin


Re: Review Request 13365: fix local storage volume deployment

2013-08-06 Thread Rajesh Battala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13365/#review24773
---

Ship it!


Ship It!

- Rajesh Battala


On Aug. 6, 2013, 10:53 p.m., Marcus Sorensen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13365/
 ---
 
 (Updated Aug. 6, 2013, 10:53 p.m.)
 
 
 Review request for cloudstack and Rajesh Battala.
 
 
 Bugs: CLOUDSTACK-4121
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 See CLOUDSTACK-4121. This seems to allow the hypervisor type to be queried 
 for local volumes, by using the cluster level storage SQL query. I *think* 
 these three are the only storage-related scope types.
 
 You may want to tweak this a bit more to not bother with the sql statement if 
 sql=null, but I think it provides a pretty obvious heads-up as to what's 
 wrong, aside from my little error message.
 
 
 Diffs
 -
 
   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 273f7f9 
 
 Diff: https://reviews.apache.org/r/13365/diff/
 
 
 Testing
 ---
 
 tested in KVM fresh 4.2 zone, VMs now starting rather than throwing SQL 
 errors.
 
 
 Thanks,
 
 Marcus Sorensen
 




Re: Review Request 13237: Unable to resize disk with Zone wide storage

2013-08-06 Thread Rajesh Battala


 On Aug. 6, 2013, 7:57 p.m., edison su wrote:
  Ship It!

thanks for committing the patch


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24736
---


On Aug. 6, 2013, 7:13 p.m., Rajesh Battala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13237/
 ---
 
 (Updated Aug. 6, 2013, 7:13 p.m.)
 
 
 Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
 
 
 Bugs: 3781
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Issue:
 == 
 for Volume operations we are finding the hypervisor type. Volume can be in 
 ZONE/Cluster scope storage pool. 
 when volume is in ZONE scope, there is issue with they way we fetch the 
 hypervisor type. It was written to handle Cluster scope only.
 
 fixed:
 ==
 Fixed with sql queries to fetch the Hypervisor type.
 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
 is in ZONE scope storage pool.
 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
 in CLUSTER scope storage pool.
 
 
 Diffs
 -
 
   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
 
 Diff: https://reviews.apache.org/r/13237/diff/
 
 
 Testing
 ---
 
 Setup:
 KVM and Xenserver with Adv Zone.
 Added pool Zone scope on KVM and Cluster Scope on Xenserver 
 1. created instances on KVM and xenserver.
 2. Create two volumes attached to instances on KVM and Xenserver. 
 3. vol1 is in Zone scope and vol2 is in cluster scope. 
 4. Successfully performed resize opertions on vol1 and vol2.
 5. Succssfully attached/detaches volumes
 
 
 Thanks,
 
 Rajesh Battala
 




Re: Review Request 13320: In case when all the vnets are deleted we are not logging a error message if there are vnets allocated.

2013-08-06 Thread Jayapal Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13320/#review24775
---

Ship it!


Ship It!

- Jayapal Reddy


On Aug. 6, 2013, 11:18 a.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13320/
 ---
 
 (Updated Aug. 6, 2013, 11:18 a.m.)
 
 
 Review request for cloudstack and Jayapal Reddy.
 
 
 Bugs: Cloudstack-4105
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 https://issues.apache.org/jira/browse/CLOUDSTACK-4105
 In case when all the vnets are deleted we are not logging a error message if 
 there are vnets allocated.
 Also not updating the physicalnetwork table in this case.
 
 
 Diffs
 -
 
   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java de68e1e 
   engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 3ac2729 
   server/src/com/cloud/network/NetworkServiceImpl.java 304cefa 
 
 Diff: https://reviews.apache.org/r/13320/diff/
 
 
 Testing
 ---
 
 Tested on 4.2
 
 
 Thanks,
 
 bharat kumar
 




Re: Review Request 13323: if a failure occurs while adding VM to another network (this should be the first vm in the subnet). The ip alias created as a part of this process is not removed.

2013-08-06 Thread bharat kumar


 On Aug. 7, 2013, 12:03 a.m., Sheng Yang wrote:
  server/src/com/cloud/network/NetworkManagerImpl.java, line 2433
  https://reviews.apache.org/r/13323/diff/1/?file=337776#file337776line2433
 
  It's better to show the semantic of if this is the last nic in the 
  subnet in code. Say, if (vm.getType() == Type.User  it's the last nic)

Hi sheng,
  removeDhcpServiceInsubnet functon calls the function listLastNicsInSubnet to 
get the last nics in subnet and then it removes the DhcpService based on the 
networkId. 

So I mean we do not know if it is last nic in the subnet until we call the 
listLastNicsInsubnet so we cannot put this check before hand.


 On Aug. 7, 2013, 12:03 a.m., Sheng Yang wrote:
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 479
  https://reviews.apache.org/r/13323/diff/1/?file=33#file33line479
 
  Why we still need this if networkid is null then we remove all? 
  removeNic() for each network in network manager is not enough?

Hi sheng,

  In cases when a VM is getting expunged we need to remove the Dhcpservice in 
all the networks in which this vm has a last nic. so we pass a null as 
networkId to do this.


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13323/#review24762
---


On Aug. 6, 2013, 12:48 p.m., bharat kumar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13323/
 ---
 
 (Updated Aug. 6, 2013, 12:48 p.m.)
 
 
 Review request for cloudstack, Alena Prokharchyk and Sheng Yang.
 
 
 Bugs: Cloudstack-4083
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 https://issues.apache.org/jira/browse/CLOUDSTACK-4083
 if a failure occurs while adding VM to another network (this should be the 
 first vm in the subnet). The ip alias created as a part of this process is 
 not removed. 
 
 This occurred because we were not cleaning the alias ips in the event of a 
 failure.
 
 As a part of the fix.
 1.) moved the function removeDhcpServiceInsubnet and listLastNicsInSubnet to 
 NetworkManager (These were in VirtualMachineManagerImpl earlier.)
 2.) add the call to clean ipAlias in the remove nic function of the 
 networkManager.
 3.) Modified the removeDhcpServiceInsubnet to take network ad an argument. 
 This will help in removing only the ipAlias which belong to a particular 
 network.
 
 
 Diffs
 -
 
   server/src/com/cloud/network/NetworkManager.java dab7a13 
   server/src/com/cloud/network/NetworkManagerImpl.java effee96 
   server/src/com/cloud/vm/VirtualMachineManagerImpl.java b33ee49 
   server/test/com/cloud/network/MockNetworkManagerImpl.java 7f34e55 
   server/test/com/cloud/vpc/MockNetworkManagerImpl.java 178ebba 
 
 Diff: https://reviews.apache.org/r/13323/diff/
 
 
 Testing
 ---
 
 Tested on 4.2.
 created two guest networks guest1 and guest2.
 created VMS in both the networks. 
 Added a VM(with no PV drivers) from guest1 to guest2.
 this failed and on failure ipAlias configured as part of nic creation was 
 removed.
 
 Deleting the vm causes all the removal of all ipAliases from all the subnets 
 in which this is the lastvm.
 
 
 Thanks,
 
 bharat kumar
 




Re: TEST or integration test?

2013-08-06 Thread Prasanna Santhanam
The integration-test is a lifecycle in maven.[1] Surefire plugin
provides a goal to maven where you can hook-in integration tests. The
weird thing I find about maven calling it an 'integration test' is
that it comes before the install phase. We only put together all our
modules and generate the cloudstack war at the end of the install
phase.

I understand integration-test as anything that runs against a group of
environment/systems. Perhaps we're not doing it right as the maven
world would have it.

[1] 
http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference

On Wed, Aug 07, 2013 at 01:15:33AM +, Alex Huang wrote:
 So is the difference between test and integration-test is that the code 
 access db?  I've noticed a great deal of test code that's been disabled by 
 hand as well.  A proper test should just mock the db layer.  
 
 To me it would make sense if we use an in memory db like derby for the unit 
 tests.
 
 --Alex
 
  -Original Message-
  From: Min Chen [mailto:min.c...@citrix.com]
  Sent: Tuesday, August 6, 2013 3:58 PM
  To: dev@cloudstack.apache.org
  Subject: Re: TEST or integration test?
  
  For /engine/storage/integration-test, I know that those tests are TestNG
  test cases, requiring DB existence.
  
  Thanks
  -min
  
  On 8/6/13 2:59 PM, Alex Huang alex.hu...@citrix.com wrote:
  
  I noticed that some of our unit tests are run in integration-test stage
  of maven.  Shouldn't that be in the test phase?  Does anyone know why
  it's set at integration-test?  I based this observation on the surefire
  plugins are set for integration-test phase.  Note the following.
  
  ./engine/orchestration/pom.xml-phaseintegration-test/phase
  ./engine/storage/integration-test/pom.xml-
  phaseintegration-test/phase
  ./engine/storage/volume/pom.xml-
  phaseintegration-test/phase
  ./plugins/storage/image/default/pom.xml-
  phaseintegration-test/phase
  ./plugins/storage/image/sample/pom.xml-
  phaseintegration-test/phase
  ./plugins/storage/image/swift/pom.xml-
  phaseintegration-test/phase
  ./plugins/storage/volume/default/pom.xml-
  phaseintegration-test/phase
  ./plugins/storage/volume/sample/pom.xml-
  phaseintegration-test/phase
  ./plugins/storage/volume/solidfire/pom.xml-
  phaseintegration-test/phase
  
  I think integration test is probably just the smoke test that Prasanna
  has written.  We should enforce that in the maven build.  Does that
  make sense?
  
  --Alex

-- 
Prasanna.,


Powered by BigRock.com



Re: [DISCUSS] CSS framework for CloudStack UI

2013-08-06 Thread Amit Das
This is definitely a great idea.

Will it be feasible to decouple the front-end build from server-side build
as mentioned in the following link:
http://addyosmani.com/blog/making-maven-grunt/


Regards,
Amit Kumar Das
*CloudByte Inc.* http://www.cloudbyte.com/


On Wed, Aug 7, 2013 at 5:48 AM, Ian Duffy i...@ianduffy.ie wrote:

 +1 to that definitely!


  The only problem I cannot handle is integrating the SASS compiler (which
 converts .scss-.css) into the UI build phase. I've found a maven plugin at
 https://github.com/Jasig/sass-maven-plugin, so if anyone wants to tackle
 that  it would be awesome.


 Below is a meer suggestion, I've only read about it and never done it.
 I believe you are able to chain grunt into the maven life cycle. This
 would allow us to do various things with the front end code. This
 includes but is not limited to:

 - JSHint
 - Unit tests via xyz(suggesting QUnit or Jasmine) framework
 - Static analysis of the javascript with Plato
 - Compiling SASS + LESS
 - Uglifying/Minifying
 - Optimise images(png crush etc.)
 - Dependency management of 3rd party js libs

 It would supply us with a bunch nicer build process for the UI
 elements of Cloudstack. However it would add a dependency of nodejs to
 the build process.



Review Request 13312: Add help docs for S3 secondary storage configuration.

2013-08-06 Thread Thomas O'Dowd

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13312/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Add help docs to S3 secondary storage configuration.

When adding an S3 secondary storage, the administrator will now be shown help 
for each input field making it friendlier to use.


Diffs
-

  ui/scripts/docs.js 03318b8 
  ui/scripts/system.js 92fa867 

Diff: https://reviews.apache.org/r/13312/diff/


Testing
---

Clean compile of 4.2. Logged in as admin. Clicked Infrastrucure. Add Secondary 
Storage, select S3 as the provider and used the UI while viewing help.


Thanks,

Thomas O'Dowd



Re: Review Request 13237: Unable to resize disk with Zone wide storage

2013-08-06 Thread Rajesh Battala


 On Aug. 5, 2013, 6:17 p.m., edison su wrote:
  engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java, line 77
  https://reviews.apache.org/r/13237/diff/1/?file=334435#file334435line77
 
  why not just use select s.scope from storage_pool s, volumes v where 
  s.id = v.pool_id?

if we use the above query then we get list of scope values.
mysql select s.scope from storage_pool s, volumes v where s.id = v.pool_id;
+-+
| scope   |
+-+
| CLUSTER |
| CLUSTER |
| CLUSTER |
| CLUSTER |
| ZONE|
+-+
5 rows in set (0.00 sec)

 So I had written the above query like SELECT_POOLSCOPE = SELECT s.scope from 
storage_pool s, volumes v where s.id =(select pool_id from volumes where id 
=?); 
to fetch the scope of the storage pool where the volume is existing.


- Rajesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13237/#review24653
---


On Aug. 2, 2013, 10:07 a.m., Rajesh Battala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13237/
 ---
 
 (Updated Aug. 2, 2013, 10:07 a.m.)
 
 
 Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.
 
 
 Bugs: 3781
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Issue:
 == 
 for Volume operations we are finding the hypervisor type. Volume can be in 
 ZONE/Cluster scope storage pool. 
 when volume is in ZONE scope, there is issue with they way we fetch the 
 hypervisor type. It was written to handle Cluster scope only.
 
 fixed:
 ==
 Fixed with sql queries to fetch the Hypervisor type.
 1. Fetch the hypervisor type for volume from storage pool table if the voluem 
 is in ZONE scope storage pool.
 2. Fetch the hypervisor type for volume from cluster table if the voluem is 
 in CLUSTER scope storage pool.
 
 
 Diffs
 -
 
   engine/schema/src/com/cloud/storage/dao/VolumeDao.java 7b58e7d 
   engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java e6595b2 
 
 Diff: https://reviews.apache.org/r/13237/diff/
 
 
 Testing
 ---
 
 Setup:
 KVM and Xenserver with Adv Zone.
 Added pool Zone scope on KVM and Cluster Scope on Xenserver 
 1. created instances on KVM and xenserver.
 2. Create two volumes attached to instances on KVM and Xenserver. 
 3. vol1 is in Zone scope and vol2 is in cluster scope. 
 4. Successfully performed resize opertions on vol1 and vol2.
 5. Succssfully attached/detaches volumes
 
 
 Thanks,
 
 Rajesh Battala
 




Re: Review Request 12934: Tests for egress firewall rules for advance zone

2013-08-06 Thread Jayapal Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review24701
---

Ship it!


Ship It!

- Jayapal Reddy


On Aug. 6, 2013, 4:38 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12934/
 ---
 
 (Updated Aug. 6, 2013, 4:38 a.m.)
 
 
 Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna 
 Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Tests for egress firewall rules for advance zone.
 
 
 Diffs
 -
 
   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/12934/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Re: [Discuss] Using XenServer 6.2's Clone-on-Boot feature on CloudStack

2013-08-06 Thread Nguyen Anh Tu
Hi Chiradeep,

Exactly Intellicache. As I know, to use this, VDIs on XenServer/XCP must be
set two params:
+ on-boot = persist (or reset). If persist, VM's data (except OS) will be
keep when reboot. Otherwise, it will be destroy on local SR when setting to
reset.
+ allow-caching = true. It enables cache mode on local SR.

Maybe we'll add a service offering tag so AgentMgr can realize this option.
Whatever we change, Xapi must set two above params for VDIs to use this
feature. However, Intellicache seemly can't update changes to VMs which
were booted before changing of Master image.


2013/8/6 Chiradeep Vittal chiradeep.vit...@citrix.com

 Is this the Intellicache feature? What changes does it require from
 CloudStack.
 Would just using service offering tags work?

 On 8/5/13 12:23 AM, Nguyen Anh Tu ng.t...@gmail.com wrote:

 Hi guys,
 
 Is anyone concerned about using XenServer 6.2's clone-on-boot feature on
 CloudStack? With it, we can quickly deploy a huge of VMs from a single
 golden template. This is amazing for some scenarios. For example: we can
 allocate a special/dedicated cluster with only one golden template. And
 when an update or patch be applied to golden template, changes
 automatically apply to every VMs.
 
 Thought?
 
 Thanks,
 
 --
 
 N.g.U.y.e.N.A.n.H.t.U




-- 

N.g.U.y.e.N.A.n.H.t.U


Re: [ACS411] 4.1.1 status

2013-08-06 Thread Wido den Hollander

Hi Chip,

On 08/05/2013 08:01 PM, Chip Childers wrote:

Hi all,

Here's where we are:

DEBs (oss) are loaded into the cloustack.apt-get.eu repo.


The DEBs contain snapshot in their version number. I don't think that is 
correct, is it?


Wido


RPMs (nonoss) are being built now and will be pushed as soon as complete (soon)

David is building the docs now.

I'll announce once the RPM's and docs are published.

-chip



Re: Review Request 13312: CLOUDSTACK-3211 - Add help docs for S3 secondary storage configuration.

2013-08-06 Thread Thomas O'Dowd

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13312/
---

(Updated Aug. 6, 2013, 4:10 p.m.)


Review request for cloudstack.


Changes
---

This patch addresses CLOUDSTACK-3211. Added to bugs section and prefixed to 
summary.


Summary (updated)
-

CLOUDSTACK-3211 - Add help docs for S3 secondary storage configuration.


Bugs: CLOUDSTACK-3211


Repository: cloudstack-git


Description
---

Add help docs to S3 secondary storage configuration.

When adding an S3 secondary storage, the administrator will now be shown help 
for each input field making it friendlier to use.


Diffs
-

  ui/scripts/docs.js 03318b8 
  ui/scripts/system.js 92fa867 

Diff: https://reviews.apache.org/r/13312/diff/


Testing
---

Clean compile of 4.2. Logged in as admin. Clicked Infrastrucure. Add Secondary 
Storage, select S3 as the provider and used the UI while viewing help.


Thanks,

Thomas O'Dowd



CONSOLE access via API

2013-08-06 Thread Antonio Petrocelli

Hello,

Under CloudStack UI interface, the console link is:
http://xx.xx.xx.xx:8080/client/console?cmd=accessvm=x

I'm trying to use signiture under API, all other commands works, but I'm 
trying to get VM console, just not work:


http://xx.xx.xx.xx:8080/client/console?cmd=accessvm=xsignature=XX 


or
http://xx.xx.xx.xx:8080/client/api?cmd=accessvm=xsignature=XX

Could any friend point me correct command for console access through API?

Thanks!



smime.p7s
Description: Firma crittografica S/MIME


Re: unable to view content of cwiki

2013-08-06 Thread Daan Hoogland
Rajesh,

You must reside behind a proxy or firwall that prohibits you from
working. I can access the page you linked us to.

regards,
Daan

On Tue, Aug 6, 2013 at 5:24 AM, Rajesh Battala
rajesh.batt...@citrix.com wrote:
 Am still not able to access any pages.
 Ex : https://cwiki.apache.org/confluence/users/viewmyprofile.action
 even a publicly accessable page, when I login am getting error
 Not Permitted
 You are not permitted to perform this operation.

 Please do the needful.

 Thanks
 Rajesh Battala

 -Original Message-
 From: Go Chiba [mailto:go.ch...@gmail.com]
 Sent: Monday, August 5, 2013 7:37 PM
 To: dev@cloudstack.apache.org
 Subject: Re: unable to view content of cwiki

 Yes, I able to access them too.
 Rajesh, are you still can't access cwiki page? if yes, please share some 
 example link.


 On Mon, Aug 5, 2013 at 10:47 PM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 I've able to access the wiki all day so far.

 On Mon, Aug 5, 2013 at 12:43 PM, Rajesh Battala
 rajesh.batt...@citrix.com wrote:
  Hi All,
 
  Am not able to view any link of cwiki.
  Am getting permission denied to view any content.
  Please let me know how to resolve this issue.
 
  Thanks
  Rajesh Battala




 --
 千葉 豪  Go Chiba
 E-mail:go.ch...@gmail.com


Re: Review Request 13312: CLOUDSTACK-3211 - Add help docs for S3 secondary storage configuration.

2013-08-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13312/#review24705
---


Commit a764cb91b30cb998aa391a1dc897cbafec26f34a in branch refs/heads/master 
from Thomas O'Dowd
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a764cb9 ]

CLOUDSTACK-3211: Add help docs to S3 secondary storage configuration.

When adding an S3 secondary storage, the administrator will
now be shown help for each input field making it friendlier
to use.

Signed-off-by: Prasanna Santhanam t...@apache.org
(cherry picked from commit 74643c9561b1ea564f180c3780ef762e97e7c10b)


- ASF Subversion and Git Services


On Aug. 6, 2013, 7:10 a.m., Thomas O'Dowd wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13312/
 ---
 
 (Updated Aug. 6, 2013, 7:10 a.m.)
 
 
 Review request for cloudstack.
 
 
 Bugs: CLOUDSTACK-3211
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Add help docs to S3 secondary storage configuration.
 
 When adding an S3 secondary storage, the administrator will now be shown help 
 for each input field making it friendlier to use.
 
 
 Diffs
 -
 
   ui/scripts/docs.js 03318b8 
   ui/scripts/system.js 92fa867 
 
 Diff: https://reviews.apache.org/r/13312/diff/
 
 
 Testing
 ---
 
 Clean compile of 4.2. Logged in as admin. Clicked Infrastrucure. Add 
 Secondary Storage, select S3 as the provider and used the UI while viewing 
 help.
 
 
 Thanks,
 
 Thomas O'Dowd
 




Re: Review Request 13312: CLOUDSTACK-3211 - Add help docs for S3 secondary storage configuration.

2013-08-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13312/#review24706
---


Commit 7fd71d708a34556eb9ab168e52f4471a8c2acdc8 in branch refs/heads/4.2 from 
Thomas O'Dowd
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7fd71d7 ]

CLOUDSTACK-3211: Add help docs to S3 secondary storage configuration.

When adding an S3 secondary storage, the administrator will
now be shown help for each input field making it friendlier
to use.

Signed-off-by: Prasanna Santhanam t...@apache.org


- ASF Subversion and Git Services


On Aug. 6, 2013, 7:10 a.m., Thomas O'Dowd wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13312/
 ---
 
 (Updated Aug. 6, 2013, 7:10 a.m.)
 
 
 Review request for cloudstack.
 
 
 Bugs: CLOUDSTACK-3211
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Add help docs to S3 secondary storage configuration.
 
 When adding an S3 secondary storage, the administrator will now be shown help 
 for each input field making it friendlier to use.
 
 
 Diffs
 -
 
   ui/scripts/docs.js 03318b8 
   ui/scripts/system.js 92fa867 
 
 Diff: https://reviews.apache.org/r/13312/diff/
 
 
 Testing
 ---
 
 Clean compile of 4.2. Logged in as admin. Clicked Infrastrucure. Add 
 Secondary Storage, select S3 as the provider and used the UI while viewing 
 help.
 
 
 Thanks,
 
 Thomas O'Dowd
 




Re: Review Request 13312: CLOUDSTACK-3211 - Add help docs for S3 secondary storage configuration.

2013-08-06 Thread Prasanna Santhanam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13312/#review24707
---

Ship it!


Applied on 4.2 and master

- Prasanna Santhanam


On Aug. 6, 2013, 7:10 a.m., Thomas O'Dowd wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13312/
 ---
 
 (Updated Aug. 6, 2013, 7:10 a.m.)
 
 
 Review request for cloudstack.
 
 
 Bugs: CLOUDSTACK-3211
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Add help docs to S3 secondary storage configuration.
 
 When adding an S3 secondary storage, the administrator will now be shown help 
 for each input field making it friendlier to use.
 
 
 Diffs
 -
 
   ui/scripts/docs.js 03318b8 
   ui/scripts/system.js 92fa867 
 
 Diff: https://reviews.apache.org/r/13312/diff/
 
 
 Testing
 ---
 
 Clean compile of 4.2. Logged in as admin. Clicked Infrastrucure. Add 
 Secondary Storage, select S3 as the provider and used the UI while viewing 
 help.
 
 
 Thanks,
 
 Thomas O'Dowd
 




Re: Breaking docs out

2013-08-06 Thread Daan Hoogland
one litle spark here; why does every thing need to go in its own repo.
I would rather go for putting it all in one repo.

not much of a flame but here you go.

Daan

On Tue, Aug 6, 2013 at 6:25 AM, Radhika Puthiyetath
radhika.puthiyet...@citrix.com wrote:
 Make perfect sense.
 + 1

 -Radhika

 -Original Message-
 From: David Nalley [mailto:da...@gnsa.us]
 Sent: Tuesday, August 06, 2013 3:13 AM
 To: dev@cloudstack.apache.org
 Subject: Breaking docs out

 Hi folks:

 I'd like to propose breaking out a nuymber of our documents into their own 
 repos.

 My thinking is that specifically; the release notes, midonet, and niciranvp 
 documentation shares very little with the rest of the documentation, and 
 should be broken out akin to how the QIG is currently broken out.

 The particular problem I am trying to solve is to deal with publishing. For 
 instance, even though the release notes are contained in just a few xml 
 documents, it copies content from every single xml file in thd directory - 
 over 400 - and it also copies those up to the website.

 Splitting things up also allows us to prioritize l10n. Right now, we just 
 dump 400 xml files worth of content into transifex and people translate away 
 - they can't put a priority on release notes, or de-emphasize more esoteric 
 documentation like Nicira or Midonet.

 Eventually I'd like to break out each of the individual guides into their own 
 document - separate from the other. Right now they carry a ton of similar 
 content so that isn't very practical; but it's what I am thinking, perhaps 
 for 4.4 or 4.5.

 In the meantime, I'd like to make this change as soon as we think we have 
 documentation pretty close to done for 4.2 to minimize the disruptive effects.

 Thoughts, comments, flames?

 --David


RE: unable to view content of cwiki

2013-08-06 Thread Rajesh Battala
Sorry the issue is not with the site. 
Issue is with my account. Can someone please provide permission to my account 
to access the content. 
My email rajesh.batt...@citrix.com

Thanks
Rajesh Battala


-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Tuesday, August 6, 2013 1:21 PM
To: dev
Subject: Re: unable to view content of cwiki

Rajesh,

You must reside behind a proxy or firwall that prohibits you from working. I 
can access the page you linked us to.

regards,
Daan

On Tue, Aug 6, 2013 at 5:24 AM, Rajesh Battala rajesh.batt...@citrix.com 
wrote:
 Am still not able to access any pages.
 Ex : https://cwiki.apache.org/confluence/users/viewmyprofile.action
 even a publicly accessable page, when I login am getting error Not 
 Permitted You are not permitted to perform this operation.

 Please do the needful.

 Thanks
 Rajesh Battala

 -Original Message-
 From: Go Chiba [mailto:go.ch...@gmail.com]
 Sent: Monday, August 5, 2013 7:37 PM
 To: dev@cloudstack.apache.org
 Subject: Re: unable to view content of cwiki

 Yes, I able to access them too.
 Rajesh, are you still can't access cwiki page? if yes, please share some 
 example link.


 On Mon, Aug 5, 2013 at 10:47 PM, Daan Hoogland daan.hoogl...@gmail.comwrote:

 I've able to access the wiki all day so far.

 On Mon, Aug 5, 2013 at 12:43 PM, Rajesh Battala 
 rajesh.batt...@citrix.com wrote:
  Hi All,
 
  Am not able to view any link of cwiki.
  Am getting permission denied to view any content.
  Please let me know how to resolve this issue.
 
  Thanks
  Rajesh Battala




 --
 千葉 豪  Go Chiba
 E-mail:go.ch...@gmail.com


Re: upgrade path 4.1.1 - 4.2/master

2013-08-06 Thread Daan Hoogland
Thanks Harikrishna,

it worked just fine

On Thu, Aug 1, 2013 at 11:12 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:
 I did a 4.0 - 4.1.1 - master
 I can/will go back to 4.0 and report my findings tomorrow

 On Thu, Aug 1, 2013 at 8:02 PM, Harikrishna Patnala
 harikrishna.patn...@citrix.com wrote:
 Have you taken the DB dump before trying to upgrade.
 Then you can build CS in 4.1.1 and apply the dump.

 -Harikrishna

 On 01-Aug-2013, at 8:42 PM, Daan Hoogland daan.hoogl...@gmail.com wrote:

 I have allready run master against this dev env, and added the
 mentioned entry in the upgrade map. Now I cannot access the database
 using 4.1.1 anymore because of
 ERROR [agent.manager.AgentManagerImpl] (AgentTaskPool-1:) Monitor
 StoragePoolMonitor says there is an error in the connect process for 3
 due to DB Exception on:
 com.mysql.jdbc.JDBC4PreparedStatement@4171352e: SELECT
 storage_pool.id, storage_pool.name, storage_pool.uuid,
 storage_pool.pool_type, storage_pool.created, storage_pool.removed,
 storage_pool.update_time, storage_pool.data_center_id,
 storage_pool.pod_id, storage_pool.available_bytes,
 storage_pool.capacity_bytes, storage_pool.status, storage_pool.scope,
 storage_pool.storage_provider_id, storage_pool.host_address,
 storage_pool.path, storage_pool.port, storage_pool.user_info,
 storage_pool.cluster_id FROM storage_pool WHERE
 storage_pool.data_center_id = 1  AND  ( storage_pool.pod_id IS NULL
 OR storage_pool.pod_id = 1  )  AND  ( storage_pool.cluster_id IS NULL
 OR storage_pool.cluster_id = 1  )  AND storage_pool.removed IS NULL
 com.cloud.utils.exception.CloudRuntimeException: DB Exception on:
 com.mysql.jdbc.JDBC4PreparedStatement@4171352e: SELECT
 storage_pool.id, storage_pool.name, storage_pool.uuid,
 storage_pool.pool_type, storage_pool.created, storage_pool.removed,
 storage_pool.update_time, storage_pool.data_center_id,
 storage_pool.pod_id, storage_pool.available_bytes,
 storage_pool.capacity_bytes, storage_pool.status, storage_pool.scope,
 storage_pool.storage_provider_id, storage_pool.host_address,
 storage_pool.path, storage_pool.port, storage_pool.user_info,
 storage_pool.cluster_id FROM storage_pool WHERE
 storage_pool.data_center_id = 1  AND  ( storage_pool.pod_id IS NULL
 OR storage_pool.pod_id = 1  )  AND  ( storage_pool.cluster_id IS NULL
 OR storage_pool.cluster_id = 1  )  AND storage_pool.removed IS NULL
 at 
 com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:415)
 at 
 com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125)
 at 
 com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:350)
 ...
 Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
 Unknown column 'storage_pool.available_bytes' in 'field list'
 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

 any change I can salvage this installation to run with master? I.E.
 add the templates outside cloudstack somehow? (and promise I will
 never do it again)


 On Thu, Aug 1, 2013 at 4:43 PM, Harikrishna Patnala
 harikrishna.patn...@citrix.com wrote:
 My comments inline.

 Thanks
 Harikrishna
 On 01-Aug-2013, at 7:05 PM, Daan Hoogland daan.hoogl...@gmail.com
 wrote:

 Harikrishna,

 I suppose I have to register those templates before upgrading; i.e. in
 the 4.1.1 version management server.
 Yes. in 4.1.1 these templates are registered as USER templates. During 
 upgrade to 4.2 these are converted to SYSTEM templates

 Is this procedure described somewhere?
 Usually upgrade instructions are given in the release notes.
 For 4.1 upgrade you can look at Chapter 4 
 http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Release_Notes/upgrade-instructions.html#upgrade-from-4.0-to-4.1

 Do I bake the templates myself first or should I use publicly offered 
 templates?
 No need to prepare templates. I guess there is some discussion happening 
 for place to download system templates.
 You can download these templates from jenkins URL 
 http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/


 thanks,
 Daan

 On Thu, Aug 1, 2013 at 3:16 PM, Harikrishna Patnala
 harikrishna.patn...@citrix.com wrote:
 Hi Daan,
 Before upgrading to 4.2 we need to register the new system templates for 
 each hypervisor with specific names so that during upgrade these new 
 templates are set to the system vms.
 It is mandatory to upgrade the system vm template if we want upgrade to 
 4.2.

 Here seems like you have a Xen cluster. So you need to register xen 
 system template with name systemvm-xenserver-4.2.
 So for the existing clusters you need to register system vm template per 
 hypervisor.
 System template names are for each hypervisor are
 1) systemvm-xenserver-4.2
 2) systemvm-kvm-4.2
 3) systemvm-vmware-4.2
 4) systemvm-hyperv-4.2
 5) systemvm-lxc-4.2

 Thank you
 Harikrishna

 On 01-Aug-2013, at 5:29 PM, Daan Hoogland 

Re: Review Request 12934: Tests for egress firewall rules for advance zone

2013-08-06 Thread Prasanna Santhanam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12934/#review24709
---

Ship it!


Applied on master and 4.2 and some minor changes.
Please watch the runs for failures/errors from the next run onwards:
http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-regression-matrix/




- Prasanna Santhanam


On Aug. 6, 2013, 4:38 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12934/
 ---
 
 (Updated Aug. 6, 2013, 4:38 a.m.)
 
 
 Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna 
 Santhanam.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Tests for egress firewall rules for advance zone.
 
 
 Diffs
 -
 
   test/integration/component/test_egress_fw_rules.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/12934/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

2013-08-06 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/
---

Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.


Bugs: CLOUDSTACK-3723


Repository: cloudstack-git


Description
---

CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type 
Information on the Database.

Made the correction in the DB entry to point to Debian 7.0 template instead of 
Debain 6.0.


Diffs
-

  setup/db/db/schema-410to420.sql f98bb50 
  setup/db/templates.sql ba13841 

Diff: https://reviews.apache.org/r/13316/diff/


Testing
---

Verifed the fix locally on cloudstack environment:

1. Created CS environment successfully.
2. SystemVMs are coming up fine.
3. UserVMs are getting deployed successfully.


Thanks,

Sanjay Tripathi



Review Request 13317: db upgrade 4.1.1 to master

2013-08-06 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13317/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

not worth much review but have a look if you like


Diffs
-

  engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java eb987ea 

Diff: https://reviews.apache.org/r/13317/diff/


Testing
---


Thanks,

daan Hoogland



Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-08-06 Thread Dave Cahill
Hi Daan / Alex,

Sorry I missed this change at the time, but it looks problematic to me.

The code is trying to check for a scheme part in the incoming value, and
doesn't add
a scheme if value already has one. Therefore, if the scheme check has a
false positive
(it thinks the value has a scheme, but it doesn't), we are guaranteed to
produce an
invalid URI (no scheme part) and an exception.

I'm pretty sure the current scheme check is invalid given the URI spec, but
definitely
shout if I'm off base.

Here's the check:
if (value.toString().contains(:))
return new URI(value.toString());
else
return new URI(scheme, value.toString(), null);

value in this case is ssp, the Scheme Specific Part (see signature of the
URI
constructor we're using [1]). There are basically no restrictions on the
scheme
specific part of a URI, and certainly no restriction on the presence of
colons.
In fact, many URIs have an authority part in the SSP (e.g. user:password)
 which
*requires* a colon [2]. http is another example, where a colon is
used within the
SSP to specify the port.

In summary, it's perfectly valid to have a colon in the scheme specific
part of a URI,
so we shouldn't be creating invalid URIs in that case.

What are we trying to protect against in the first place with the check?
Should we
just remove the check?

Thanks,
Dave.

[1] 
http://docs.oracle.com/javase/6/docs/api/java/net/URI.html#URI(java.lang.String,
java.lang.String, java.lang.String)
[2] http://www.ietf.org/rfc/rfc2396.txt


Review Request 13318: Update documentation for LDAP authentication

2013-08-06 Thread Ian Duffy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13318/
---

Review request for cloudstack and Abhinandan Prateek.


Repository: cloudstack-git


Description
---

Update documentation


Diffs
-

  docs/en-US/LDAP-for-user-authentication.xml 61f204c 
  docs/en-US/example-activedirectory-configuration.xml 98ab5da 
  docs/en-US/example-openldap-configuration.xml 2b28032 
  docs/en-US/images/add-ldap-configuration-ad.png 
7d0aa0f44f994fe7a6539527ef42fc68b2d333f6 
  docs/en-US/images/add-ldap-configuration-openldap.png 
c801275dbc964f1d0a4637aaf59e9b7e860c6624 

Diff: https://reviews.apache.org/r/13318/diff/


Testing
---

Build with publican.


Thanks,

Ian Duffy



Re: Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

2013-08-06 Thread Sanjay Tripathi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/
---

(Updated Aug. 6, 2013, 9:14 a.m.)


Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.


Changes
---

Added the mapping in CitrixHelper file to support Debain 7 in older XS versions.


Bugs: CLOUDSTACK-3723


Repository: cloudstack-git


Description
---

CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type 
Information on the Database.

Made the correction in the DB entry to point to Debian 7.0 template instead of 
Debain 6.0.


Diffs (updated)
-

  
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 
9cdbd84 
  setup/db/db/schema-410to420.sql f98bb50 
  setup/db/templates.sql ba13841 

Diff: https://reviews.apache.org/r/13316/diff/


Testing
---

Verifed the fix locally on cloudstack environment:

1. Created CS environment successfully.
2. SystemVMs are coming up fine.
3. UserVMs are getting deployed successfully.


Thanks,

Sanjay Tripathi



Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/
---

(Updated Aug. 6, 2013, 9:16 a.m.)


Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, and 
Sheng Yang.


Changes
---

get Dave involved, because of his mido code


Repository: cloudstack-git


Description
---

Both BroadcastDomainType and IsolationType needed some extra code for backwards 
compatibility


Diffs
-

  api/src/com/cloud/network/Networks.java c76c3d4 
  api/test/com/cloud/network/NetworksTest.java 31114e8 

Diff: https://reviews.apache.org/r/12849/diff/


Testing
---


Thanks,

daan Hoogland



Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

2013-08-06 Thread Dave Cahill
Hi,

Adding Daan's reply - I sent to the wrong dev@ first time around, so the
reply went astray:

 On Tue, Aug 6, 2013 at 10:30 AM, Dave Cahill dcah...@midokura.com wrote:
  I'm pretty sure the current scheme check is invalid given the URI spec,
but
  definitely
  shout if I'm off base.

 You are not 'way' of but please review https://reviews.apache.org/r/12849/

 If the caller needs BroadcastDomainType the reason why should be known
 and the value-member can be called taking your foreseen problem into
 account. The code you are quoting would 'just' be a default behavior.

 regards,
 Daan

If you're around, maybe discussing on IRC would be faster?

I took a read of the code you posted, and the default behavior still causes
an exception if colons are
present in the value passed to toUri.

I might be interpreting wrong, but it sounds like you're saying anyone
using BroadcastDomainType
should actively work around the new (incorrect) default colon handling by
changing what value they're
passing. This seems like a strange choice, since the value they're passing
may be perfectly correct and
other parts of the system may depend on it. Why would we intentionally change
the existing behavior
to start handling colons incorrectly, and put the burden on the caller?

The rest of the code looks fine to me, but the colon part breaks existing
callers (the MidoNet plugin
for one), is confusing for anyone using BroadcastDomainType in future, and
I don't yet see what it
gains us.

I'll add comments on the review. Thanks for the quick reply; feel free to
grab me on IRC, we'll probably
figure this out faster than on a mail thread. :)

Thanks,
Dave.




On Tue, Aug 6, 2013 at 5:38 PM, Dave Cahill dcah...@midokura.com wrote:

 Hi Daan / Alex,

 Sorry I missed this change at the time, but it looks problematic to me.

 The code is trying to check for a scheme part in the incoming value, and
 doesn't add
 a scheme if value already has one. Therefore, if the scheme check has a
 false positive
 (it thinks the value has a scheme, but it doesn't), we are guaranteed to
 produce an
 invalid URI (no scheme part) and an exception.

 I'm pretty sure the current scheme check is invalid given the URI spec,
 but definitely
 shout if I'm off base.

 Here's the check:
 if (value.toString().contains(:))
 return new URI(value.toString());
 else
 return new URI(scheme, value.toString(), null);

 value in this case is ssp, the Scheme Specific Part (see signature of
 the URI
 constructor we're using [1]). There are basically no restrictions on the
 scheme
 specific part of a URI, and certainly no restriction on the presence of
 colons.
 In fact, many URIs have an authority part in the SSP (e.g. user:password)
  which
 *requires* a colon [2]. http is another example, where a colon is
 used within the
 SSP to specify the port.

 In summary, it's perfectly valid to have a colon in the scheme specific
 part of a URI,
 so we shouldn't be creating invalid URIs in that case.

 What are we trying to protect against in the first place with the check?
 Should we
 just remove the check?

 Thanks,
 Dave.

 [1] 
 http://docs.oracle.com/javase/6/docs/api/java/net/URI.html#URI(java.lang.String,
 java.lang.String, java.lang.String)
 [2] http://www.ietf.org/rfc/rfc2396.txt



please provide access to cwiki for my account

2013-08-06 Thread Rajesh Battala
Hi ,

Am not able to view any page in cwiki after login-in.
Am getting permission denied for any page view.
Here is my account email 
rajesh.batt...@citrix.commailto:rajesh.batt...@citrix.com
Please provide access to my a/c.


Thanks
Rajesh Battala


Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread Dave Cahill

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/#review24710
---



api/src/com/cloud/network/Networks.java
https://reviews.apache.org/r/12849/#comment48820

Commenting as discussed on list - I think we should remove the check for 
contains(:) at this line. We weren't doing it before July 20, it's invalid as 
per the URI spec, and it breaks existing callers.


- Dave Cahill


On Aug. 6, 2013, 9:16 a.m., daan Hoogland wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12849/
 ---
 
 (Updated Aug. 6, 2013, 9:16 a.m.)
 
 
 Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, 
 and Sheng Yang.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Both BroadcastDomainType and IsolationType needed some extra code for 
 backwards compatibility
 
 
 Diffs
 -
 
   api/src/com/cloud/network/Networks.java c76c3d4 
   api/test/com/cloud/network/NetworksTest.java 31114e8 
 
 Diff: https://reviews.apache.org/r/12849/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 daan Hoogland
 




RE: [Doc] Adding Multiple IP Ranges is Ready

2013-08-06 Thread Radhika Puthiyetath
Thanks for the comments, Bharat.

The comments have been incorporated.

You can view them in the PDF attached at  
https://issues.apache.org/jira/browse/CLOUDSTACK-847

-Radhika

From: Bharat Kumar
Sent: Friday, August 02, 2013 11:07 AM
To: Radhika Puthiyetath
Subject: Re: [Doc] Adding Multiple IP Ranges is Ready

Hi Radhika,

due to recent design changes there is a changes in the behavior. I will 
describe these below.

1.)Please remove these lines form the doc
This operation fails if an IP from the remove range is in use. If the remove 
range contains the IP address on which the DHCP server is running, CloudStack 
acquires a new IP from the same subnet. If no IP is available in the subnet, 
the remove operation fails.

2.) Change the Heading to adding multiple subnets to a shared network.

3.) Mention that this is supported when virtual router is the provider of DNS  
and DHCP.
the user data and ssh-key reset service runs on the primary ip of eth0 
interface.  The primary ip being the ip allocated to eth0 interface
of the virtual router from the first subnet.  In case if the virtual router is 
used for providing the dns, Cloudstack adds the entry eth0Ip data-server in 
the /etc/hosts
of the router vm and users form all the subnets can use this name data-server 
to access the user-data.




On Aug 1, 2013, at 4:39 PM, Radhika Puthiyetath 
radhika.puthiyet...@citrix.commailto:radhika.puthiyet...@citrix.com wrote:


Hi,

Adding Multiple IP Ranges documentation is ready for review. The doc is 
attached at https://issues.apache.org/jira/browse/CLOUDSTACK-847

Please see 15.13. Adding Multiple IP Ranges (139), and provide your feedback.

Regards
-Radhika





Re: IP Address Allocation

2013-08-06 Thread Murali Reddy
On 06/08/13 8:59 AM, Soheil Eizadi seiz...@infoblox.com wrote:

One way to achieve this behavior is to have a call out in prepareNic() to
the NetworkElements before the call to the NetworkGuru allowing the
NetworkElement to update the Nic Profile. In this use case the Network
Element would suggest an IP Address. In the use case below the IP Address
would be updated by the NetworkElement. There is logic in getIp(), the
current IP Allocation that handles the case where the Nic Profile already
has an IP Address. This needs to be updated to handle this new use case.
The current use case assume that the VM had already been prepared once
and has an IP Address allocated that could be reused.

Does anyone see a problem with this approach?

Purpose of Guru (to design the network) and Element (implement the
network) are different. Right way would be for your plug-in to implement
both network Guru and element and let the guru do the IP address
allocation.

-Soheil

From: Soheil Eizadi [seiz...@infoblox.com]
Sent: Monday, August 05, 2013 2:35 PM
To: dev@cloudstack.apache.org
Subject: IP Address Allocation

I am trying to figure out what would be the proper way for a Plugin to
interact with the CloudStack VM deployment and provide an authoritative
IP Address from its database versus the local CloudStack database. It
looks like the NetworkElements are not presented an opportunity to
provide an IP Address and you must develop a NetworkGuru to provide this
function. There is some customization of the IP Address designed into the
Secondary NICs (see allocateGuestIP()).
-Soheil





Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13223/#review24711
---


Commit 5cb090ed40816950d0c9dbb62135240a7c8b1e3d in branch refs/heads/master 
from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5cb090e ]

CLOUDSTACK-2729: move unlock to finally block to handle failed libvirt 
operations


- ASF Subversion and Git Services


On Aug. 5, 2013, 6:07 p.m., Wei Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13223/
 ---
 
 (Updated Aug. 5, 2013, 6:07 p.m.)
 
 
 Review request for cloudstack, edison su and Wido den Hollander.
 
 
 Bugs: CLOUDSTACK-2729
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt 
 (https://bugzilla.redhat.com/show_bug.cgi?id=977706)
 We need to prevent deleting a volume when refreshing the pool.
 This patch use a simple file lock to implement it.
 
 PS: I have tested another file lock similar to Read/Write file lock, but it 
 was very unstable.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
  b8a9f0f 
 
 Diff: https://reviews.apache.org/r/13223/diff/
 
 
 Testing
 ---
 
 Applied on 4.0.2 and 4.0.1
 
 Testing On 4.0.1 From 20,June
 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes 
 later. expunge.inteval = 600 (10 minutes), expunge.worker = 2
  
 
 Testing On 4.0.2 From 01,July
 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 
 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 
 
 
 Thanks,
 
 Wei Zhou
 




Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool

2013-08-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13223/#review24712
---


Commit c229244dabb5c5685fbb1aab84de9afdf199820b in branch refs/heads/4.2 from 
Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c229244 ]

CLOUDSTACK-2729: move unlock to finally block to handle failed libvirt 
operations
(cherry picked from commit 5cb090ed40816950d0c9dbb62135240a7c8b1e3d)


- ASF Subversion and Git Services


On Aug. 5, 2013, 6:07 p.m., Wei Zhou wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13223/
 ---
 
 (Updated Aug. 5, 2013, 6:07 p.m.)
 
 
 Review request for cloudstack, edison su and Wido den Hollander.
 
 
 Bugs: CLOUDSTACK-2729
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt 
 (https://bugzilla.redhat.com/show_bug.cgi?id=977706)
 We need to prevent deleting a volume when refreshing the pool.
 This patch use a simple file lock to implement it.
 
 PS: I have tested another file lock similar to Read/Write file lock, but it 
 was very unstable.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
  b8a9f0f 
 
 Diff: https://reviews.apache.org/r/13223/diff/
 
 
 Testing
 ---
 
 Applied on 4.0.2 and 4.0.1
 
 Testing On 4.0.1 From 20,June
 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes 
 later. expunge.inteval = 600 (10 minutes), expunge.worker = 2
  
 
 Testing On 4.0.2 From 01,July
 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 
 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 
 
 
 Thanks,
 
 Wei Zhou
 




Re: Review Request 12849: added backwards compatibility code to Networks enums

2013-08-06 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12849/
---

(Updated Aug. 6, 2013, 10:41 a.m.)


Review request for cloudstack, Chiradeep Vittal, Dave Cahill, Koushik Das, and 
Sheng Yang.


Changes
---

default behavior as decided after consult with Dave


Repository: cloudstack-git


Description
---

Both BroadcastDomainType and IsolationType needed some extra code for backwards 
compatibility


Diffs (updated)
-

  api/src/com/cloud/network/Networks.java c76c3d4 
  api/test/com/cloud/network/NetworksTest.java 31114e8 

Diff: https://reviews.apache.org/r/12849/diff/


Testing
---


Thanks,

daan Hoogland



RE: please provide access to cwiki for my account

2013-08-06 Thread Rajesh Battala
After resetting the password also am still facing the issue. 
Please do the needful.

Thanks
Rajesh Battala

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Tuesday, August 6, 2013 3:14 PM
To: dev@cloudstack.apache.org
Subject: please provide access to cwiki for my account

Hi ,

Am not able to view any page in cwiki after login-in.
Am getting permission denied for any page view.
Here is my account email 
rajesh.batt...@citrix.commailto:rajesh.batt...@citrix.com
Please provide access to my a/c.


Thanks
Rajesh Battala


Re: database upgrade

2013-08-06 Thread Daan Hoogland
I did a submission, https://reviews.apache.org/r/13317/

On Mon, Aug 5, 2013 at 8:27 PM, Chip Childers chip.child...@sungard.com wrote:
 On Mon, Aug 05, 2013 at 08:23:48PM +0200, Daan Hoogland wrote:
 :) meaning now, i suppose.

 On Mon, Aug 5, 2013 at 7:12 PM, Chip Childers chip.child...@sungard.com 
 wrote:
  On Mon, Aug 05, 2013 at 12:32:19PM +0200, Daan Hoogland wrote:
  H,
 
  What is the policy for adding upgrade paths?
 
  I am working on upgrade from 4.1.1 already.
  So when do we add
  _upgradeMap.put(4.1.1, new DbUpgrade[] { new
  Upgrade410to420(), new Upgrade420to430() });
  to DatabaseUpgradeChecker?
 
  thanks,
  Daan
 
 
  Yup, that should be right.


 Yeah, it should be added if it's not yet.


Re: Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.

2013-08-06 Thread Jenkins Cloudstack.org

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13316/#review24713
---


Review 13316 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #113 is : 
http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/113/

- Jenkins Cloudstack.org


On Aug. 6, 2013, 9:14 a.m., Sanjay Tripathi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/13316/
 ---
 
 (Updated Aug. 6, 2013, 9:14 a.m.)
 
 
 Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
 
 
 Bugs: CLOUDSTACK-3723
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type 
 Information on the Database.
 
 Made the correction in the DB entry to point to Debian 7.0 template instead 
 of Debain 6.0.
 
 
 Diffs
 -
 
   
 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java
  9cdbd84 
   setup/db/db/schema-410to420.sql f98bb50 
   setup/db/templates.sql ba13841 
 
 Diff: https://reviews.apache.org/r/13316/diff/
 
 
 Testing
 ---
 
 Verifed the fix locally on cloudstack environment:
 
 1. Created CS environment successfully.
 2. SystemVMs are coming up fine.
 3. UserVMs are getting deployed successfully.
 
 
 Thanks,
 
 Sanjay Tripathi
 




Review Request 13320: In case when all the vnets are deleted we are not logging a error message if there are vnets allocated.

2013-08-06 Thread bharat kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13320/
---

Review request for cloudstack and Jayapal Reddy.


Bugs: Cloudstack-4105


Repository: cloudstack-git


Description
---

https://issues.apache.org/jira/browse/CLOUDSTACK-4105
In case when all the vnets are deleted we are not logging a error message if 
there are vnets allocated.
Also not updating the physicalnetwork table in this case.


Diffs
-

  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java de68e1e 
  engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 3ac2729 
  server/src/com/cloud/network/NetworkServiceImpl.java 304cefa 

Diff: https://reviews.apache.org/r/13320/diff/


Testing
---

Tested on 4.2


Thanks,

bharat kumar



Review Request 13319: [KVM] [PrimaryStorage] deleteStoragePool is not removing the storage pool information from KVM agent/host.

2013-08-06 Thread Rajesh Battala

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13319/
---

Review request for cloudstack, Devdeep Singh, edison su, and Ram Ganesh.


Bugs: 3887


Repository: cloudstack-git


Description
---

Issue:
==
[KVM] [PrimaryStorage] deleteStoragePool is not removing the storage pool 
information from KVM agent/host.

root cause:
== 
   In the CloudstackPrimaryDatastorelifecycleImpl class, deletedataStore method 
 when storage is getting deleted which is attached to kvm hosts, from the list 
of hosts only for first host Agentcmd is sent to remove the storage.
In case of xenserver this will work as the xapi will take care of removing the 
storagepool from its slaves. 

   In case of KVM we need to send to all hosts to remove the storage. 

Fixed:
==
Fixed by sending the agent command to all the hosts if the storage pool is 
attached to KVM type hypervisor.


Diffs
-

  
plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
 2c8c871 

Diff: https://reviews.apache.org/r/13319/diff/


Testing
---

1. Created a zone with two kvm hosts and one xenserver host 
2. Created cluster scope primary storage for kvm cluster, storage got mounted 
on both kvm hosts.
3. Enabled maintenance on storage and removed the storage pool.
4. Storage got successfully umount from both the hosts. virsh-pool is not 
listing the removed storage pool.

5. Created ZONE scope PS, storage got mounted in both the KVM hosts. 
6  Storage got successfully umount from both the hosts. virsh-pool is not 
listing the removed storage pool.

7. created cluster scope for Xenserver Cluster. 
8. Enabled maintenance on storage and removed the storage pool.
9. Storage got successfully umount from both xenserver.


Thanks,

Rajesh Battala



  1   2   >