date:20131120


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15668/#review29219
---


Commit b43b4b28b6780454405062d0963dae4af80e497b in branch refs/heads/4.3 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b43b4b2 ]

CLOUDSTACK-5201: Correcting code related to schedule of
 recurring snapshot policy


- ASF Subversion and Git Services


On Nov. 19, 2013, 10:25 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15668/
> ---
> 
> (Updated Nov. 19, 2013, 10:25 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5201
> https://issues.apache.org/jira/browse/CLOUDSTACK-5201
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case was failing while getting snapshots' list because minutes were 
> passed in the schedule of snapshot policy when the intervalType is "Hourly". 
> Passes hours and changed wait time accordingly to get the snapshots list.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_base_image_updation.py b70bea5 
> 
> Diff: https://reviews.apache.org/r/15668/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on KVM advanced. No Xen advanced up right now.
> 
> Log:
> test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-11-18 20:25:06,863 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Creating recurring 
> snapshot policy fo
> r root disk on vm created with IsVolatile=True
> 2013-11-18 20:25:06,863 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Snapshot Policy - Type 
> : HOURLY Sched
> uled Hours : 1
> 2013-11-18 20:25:06,959 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Sleeping for 70 
> minutes till the volu
> me is snapshoted
> 2013-11-18 21:35:57,329 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Checking whether root 
> disk of VM with
>  isVolatile=True was destroyed
> 2013-11-18 21:35:57,398 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Checking whether 
> snapshot rule for VM
>  with isVolatile=True was destroyedHere we are passing 
> root disk id of vm before reboot which does not exist hence   
> listing
>  should fail
> 
> ==> result.log <==
> ok
> 
> --
> Ran 4 tests in 4507.963s
> 
> OK (skipped=3)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 15668: CLOUDSTACK-5201: Corrected code related to schedule of recurring snapshot policy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15668/#review29218
---


Commit 2f308cc988bb3c82c753d99daade5f6bfafd26e5 in branch refs/heads/4.2 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2f308cc ]

CLOUDSTACK-5201: Correcting code related to schedule of
 recurring snapshot policy


- ASF Subversion and Git Services


On Nov. 19, 2013, 10:25 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15668/
> ---
> 
> (Updated Nov. 19, 2013, 10:25 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5201
> https://issues.apache.org/jira/browse/CLOUDSTACK-5201
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case was failing while getting snapshots' list because minutes were 
> passed in the schedule of snapshot policy when the intervalType is "Hourly". 
> Passes hours and changed wait time accordingly to get the snapshots list.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_base_image_updation.py b70bea5 
> 
> Diff: https://reviews.apache.org/r/15668/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on KVM advanced. No Xen advanced up right now.
> 
> Log:
> test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-11-18 20:25:06,863 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Creating recurring 
> snapshot policy fo
> r root disk on vm created with IsVolatile=True
> 2013-11-18 20:25:06,863 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Snapshot Policy - Type 
> : HOURLY Sched
> uled Hours : 1
> 2013-11-18 20:25:06,959 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Sleeping for 70 
> minutes till the volu
> me is snapshoted
> 2013-11-18 21:35:57,329 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Checking whether root 
> disk of VM with
>  isVolatile=True was destroyed
> 2013-11-18 21:35:57,398 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Checking whether 
> snapshot rule for VM
>  with isVolatile=True was destroyedHere we are passing 
> root disk id of vm before reboot which does not exist hence   
> listing
>  should fail
> 
> ==> result.log <==
> ok
> 
> --
> Ran 4 tests in 4507.963s
> 
> OK (skipped=3)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 15668: CLOUDSTACK-5201: Corrected code related to schedule of recurring snapshot policy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15668/#review29217
---


Commit 138cee401ff6973a43302da2ba323b7e85321a19 in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=138cee4 ]

CLOUDSTACK-5201: Correcting code related to schedule of
 recurring snapshot policy


- ASF Subversion and Git Services


On Nov. 19, 2013, 10:25 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15668/
> ---
> 
> (Updated Nov. 19, 2013, 10:25 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5201
> https://issues.apache.org/jira/browse/CLOUDSTACK-5201
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The test case was failing while getting snapshots' list because minutes were 
> passed in the schedule of snapshot policy when the intervalType is "Hourly". 
> Passes hours and changed wait time accordingly to get the snapshots list.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_base_image_updation.py b70bea5 
> 
> Diff: https://reviews.apache.org/r/15668/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on KVM advanced. No Xen advanced up right now.
> 
> Log:
> test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) ...
> ==> client.log <==
> 2013-11-18 20:25:06,863 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Creating recurring 
> snapshot policy fo
> r root disk on vm created with IsVolatile=True
> 2013-11-18 20:25:06,863 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Snapshot Policy - Type 
> : HOURLY Sched
> uled Hours : 1
> 2013-11-18 20:25:06,959 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Sleeping for 70 
> minutes till the volu
> me is snapshoted
> 2013-11-18 21:35:57,329 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Checking whether root 
> disk of VM with
>  isVolatile=True was destroyed
> 2013-11-18 21:35:57,398 - DEBUG - test_04_reoccuring_snapshot_rules 
> (test_base_image_updation_fixed.TestBaseImageUpdate) - Checking whether 
> snapshot rule for VM
>  with isVolatile=True was destroyedHere we are passing 
> root disk id of vm before reboot which does not exist hence   
> listing
>  should fail
> 
> ==> result.log <==
> ok
> 
> --
> Ran 4 tests in 4507.963s
> 
> OK (skipped=3)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 15672: CLOUDSTACK-5204: test_routers - fixed ssh issue

2013-11-20 Thread Girish Shilamkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15672/#review29216
---

Ship it!


Committed to 4.2, 4.3 and master

- Girish Shilamkar


On Nov. 19, 2013, 1:24 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15672/
> ---
> 
> (Updated Nov. 19, 2013, 1:24 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5204
> https://issues.apache.org/jira/browse/CLOUDSTACK-5204
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> component.test_routers.TestRouterStopCreatePF.test_01_RouterStopCreatePF 
> failed due to SSH issue.
> 
> The port numbers used for opening the firewall,crating NAT rule and those 
> which are used while SSH were not matching earlier. Corrected the port 
> numbers and now the test cases are running successfully.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_routers.py b41cc6f 
> 
> Diff: https://reviews.apache.org/r/15672/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_RouterStopCreatePF (test_routers.TestRouterStopCreatePF)
> Test router stop create port forwarding ...
> ==> client.log <==
> 2013-11-19 01:15:23,606 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Stopping router ID: 
> c3a8fa3d-7eb4-4aa3-89f5-a32e539519d4
> 2013-11-19 01:15:33,760 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - [{networkid : 
> u'c46664ce-7e35-4cfe-84dd-9ba643287190', phys
> icalnetworkid : u'd3a6b714-dca9-4c70-85a8-9b7eb21173f3', account : 
> u'testuser-5FC9JN', domainid : u'ca366bcc-4ea2-11e3-a447-1a6f7bb0d0a8', 
> issourcenat : True, i
> sstaticnat : False, tags : [], associatednetworkname : 
> u'testuser-5FC9JN-network', domain : u'ROOT', vlanid : 
> u'dd334b97-108d-49fb-9dd4-d52aa8d0e063', zoneid :
> u'949dc33b-3e26-491e-b85d-3c4007dc376e', vlanname : u'1221', state : 
> u'Allocated', associatednetworkid : u'9bf9e9e9-cb7a-424c-ba98-3df0ca11bef8', 
> zonename : u'A
> dv-KVM-Zone1', forvirtualnetwork : True, allocated : 
> u'2013-11-19T05:01:50-0800', issystem : False, ipaddress : u'10.223.122.101', 
> id : u'f6302d3b-0ab3-427e-835
> 3-810ceeacf6ae', isportable : False}]
> 2013-11-19 01:15:38,871 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Creating NAT rule for VM ID: 
> baf9415f-c930-4391-9f3f-637bfb
> 02779d
> 2013-11-19 01:15:43,979 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Starting router ID: 
> c3a8fa3d-7eb4-4aa3-89f5-a32e539519d4
> 2013-11-19 01:16:19,204 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - SSH into VM with ID: 10.223.122.101
> 2013-11-19 01:16:19,204 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - 22
> 
> ==> result.log <==
> ok
> 
> --
> Ran 6 tests in 216.937s
> 
> OK (skipped=5)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 15672: CLOUDSTACK-5204: test_routers - fixed ssh issue


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15672/#review29215
---


Commit 70aaf6a1b40f3c816b7ffbe8e4d303f30ea82fe8 in branch refs/heads/4.3 from 
Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=70aaf6a ]

CLOUDSTACK-5204: test_routers - fixed ssh issue


- ASF Subversion and Git Services


On Nov. 19, 2013, 1:24 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15672/
> ---
> 
> (Updated Nov. 19, 2013, 1:24 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5204
> https://issues.apache.org/jira/browse/CLOUDSTACK-5204
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> component.test_routers.TestRouterStopCreatePF.test_01_RouterStopCreatePF 
> failed due to SSH issue.
> 
> The port numbers used for opening the firewall,crating NAT rule and those 
> which are used while SSH were not matching earlier. Corrected the port 
> numbers and now the test cases are running successfully.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_routers.py b41cc6f 
> 
> Diff: https://reviews.apache.org/r/15672/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_RouterStopCreatePF (test_routers.TestRouterStopCreatePF)
> Test router stop create port forwarding ...
> ==> client.log <==
> 2013-11-19 01:15:23,606 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Stopping router ID: 
> c3a8fa3d-7eb4-4aa3-89f5-a32e539519d4
> 2013-11-19 01:15:33,760 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - [{networkid : 
> u'c46664ce-7e35-4cfe-84dd-9ba643287190', phys
> icalnetworkid : u'd3a6b714-dca9-4c70-85a8-9b7eb21173f3', account : 
> u'testuser-5FC9JN', domainid : u'ca366bcc-4ea2-11e3-a447-1a6f7bb0d0a8', 
> issourcenat : True, i
> sstaticnat : False, tags : [], associatednetworkname : 
> u'testuser-5FC9JN-network', domain : u'ROOT', vlanid : 
> u'dd334b97-108d-49fb-9dd4-d52aa8d0e063', zoneid :
> u'949dc33b-3e26-491e-b85d-3c4007dc376e', vlanname : u'1221', state : 
> u'Allocated', associatednetworkid : u'9bf9e9e9-cb7a-424c-ba98-3df0ca11bef8', 
> zonename : u'A
> dv-KVM-Zone1', forvirtualnetwork : True, allocated : 
> u'2013-11-19T05:01:50-0800', issystem : False, ipaddress : u'10.223.122.101', 
> id : u'f6302d3b-0ab3-427e-835
> 3-810ceeacf6ae', isportable : False}]
> 2013-11-19 01:15:38,871 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Creating NAT rule for VM ID: 
> baf9415f-c930-4391-9f3f-637bfb
> 02779d
> 2013-11-19 01:15:43,979 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Starting router ID: 
> c3a8fa3d-7eb4-4aa3-89f5-a32e539519d4
> 2013-11-19 01:16:19,204 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - SSH into VM with ID: 10.223.122.101
> 2013-11-19 01:16:19,204 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - 22
> 
> ==> result.log <==
> ok
> 
> --
> Ran 6 tests in 216.937s
> 
> OK (skipped=5)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 15672: CLOUDSTACK-5204: test_routers - fixed ssh issue


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15672/#review29214
---


Commit fbe5293689065b76fffadc5072f85fb72ccf3e17 in branch refs/heads/4.2 from 
Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fbe5293 ]

CLOUDSTACK-5204: test_routers - fixed ssh issue


- ASF Subversion and Git Services


On Nov. 19, 2013, 1:24 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15672/
> ---
> 
> (Updated Nov. 19, 2013, 1:24 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5204
> https://issues.apache.org/jira/browse/CLOUDSTACK-5204
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> component.test_routers.TestRouterStopCreatePF.test_01_RouterStopCreatePF 
> failed due to SSH issue.
> 
> The port numbers used for opening the firewall,crating NAT rule and those 
> which are used while SSH were not matching earlier. Corrected the port 
> numbers and now the test cases are running successfully.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_routers.py b41cc6f 
> 
> Diff: https://reviews.apache.org/r/15672/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_RouterStopCreatePF (test_routers.TestRouterStopCreatePF)
> Test router stop create port forwarding ...
> ==> client.log <==
> 2013-11-19 01:15:23,606 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Stopping router ID: 
> c3a8fa3d-7eb4-4aa3-89f5-a32e539519d4
> 2013-11-19 01:15:33,760 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - [{networkid : 
> u'c46664ce-7e35-4cfe-84dd-9ba643287190', phys
> icalnetworkid : u'd3a6b714-dca9-4c70-85a8-9b7eb21173f3', account : 
> u'testuser-5FC9JN', domainid : u'ca366bcc-4ea2-11e3-a447-1a6f7bb0d0a8', 
> issourcenat : True, i
> sstaticnat : False, tags : [], associatednetworkname : 
> u'testuser-5FC9JN-network', domain : u'ROOT', vlanid : 
> u'dd334b97-108d-49fb-9dd4-d52aa8d0e063', zoneid :
> u'949dc33b-3e26-491e-b85d-3c4007dc376e', vlanname : u'1221', state : 
> u'Allocated', associatednetworkid : u'9bf9e9e9-cb7a-424c-ba98-3df0ca11bef8', 
> zonename : u'A
> dv-KVM-Zone1', forvirtualnetwork : True, allocated : 
> u'2013-11-19T05:01:50-0800', issystem : False, ipaddress : u'10.223.122.101', 
> id : u'f6302d3b-0ab3-427e-835
> 3-810ceeacf6ae', isportable : False}]
> 2013-11-19 01:15:38,871 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Creating NAT rule for VM ID: 
> baf9415f-c930-4391-9f3f-637bfb
> 02779d
> 2013-11-19 01:15:43,979 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Starting router ID: 
> c3a8fa3d-7eb4-4aa3-89f5-a32e539519d4
> 2013-11-19 01:16:19,204 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - SSH into VM with ID: 10.223.122.101
> 2013-11-19 01:16:19,204 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - 22
> 
> ==> result.log <==
> ok
> 
> --
> Ran 6 tests in 216.937s
> 
> OK (skipped=5)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 15672: CLOUDSTACK-5204: test_routers - fixed ssh issue


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15672/#review29213
---


Commit db2ea0a16a1eac0a76318250355f4575c0681a29 in branch refs/heads/master 
from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=db2ea0a ]

CLOUDSTACK-5204: test_routers - fixed ssh issue


- ASF Subversion and Git Services


On Nov. 19, 2013, 1:24 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15672/
> ---
> 
> (Updated Nov. 19, 2013, 1:24 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5204
> https://issues.apache.org/jira/browse/CLOUDSTACK-5204
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> component.test_routers.TestRouterStopCreatePF.test_01_RouterStopCreatePF 
> failed due to SSH issue.
> 
> The port numbers used for opening the firewall,crating NAT rule and those 
> which are used while SSH were not matching earlier. Corrected the port 
> numbers and now the test cases are running successfully.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_routers.py b41cc6f 
> 
> Diff: https://reviews.apache.org/r/15672/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_RouterStopCreatePF (test_routers.TestRouterStopCreatePF)
> Test router stop create port forwarding ...
> ==> client.log <==
> 2013-11-19 01:15:23,606 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Stopping router ID: 
> c3a8fa3d-7eb4-4aa3-89f5-a32e539519d4
> 2013-11-19 01:15:33,760 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - [{networkid : 
> u'c46664ce-7e35-4cfe-84dd-9ba643287190', phys
> icalnetworkid : u'd3a6b714-dca9-4c70-85a8-9b7eb21173f3', account : 
> u'testuser-5FC9JN', domainid : u'ca366bcc-4ea2-11e3-a447-1a6f7bb0d0a8', 
> issourcenat : True, i
> sstaticnat : False, tags : [], associatednetworkname : 
> u'testuser-5FC9JN-network', domain : u'ROOT', vlanid : 
> u'dd334b97-108d-49fb-9dd4-d52aa8d0e063', zoneid :
> u'949dc33b-3e26-491e-b85d-3c4007dc376e', vlanname : u'1221', state : 
> u'Allocated', associatednetworkid : u'9bf9e9e9-cb7a-424c-ba98-3df0ca11bef8', 
> zonename : u'A
> dv-KVM-Zone1', forvirtualnetwork : True, allocated : 
> u'2013-11-19T05:01:50-0800', issystem : False, ipaddress : u'10.223.122.101', 
> id : u'f6302d3b-0ab3-427e-835
> 3-810ceeacf6ae', isportable : False}]
> 2013-11-19 01:15:38,871 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Creating NAT rule for VM ID: 
> baf9415f-c930-4391-9f3f-637bfb
> 02779d
> 2013-11-19 01:15:43,979 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - Starting router ID: 
> c3a8fa3d-7eb4-4aa3-89f5-a32e539519d4
> 2013-11-19 01:16:19,204 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - SSH into VM with ID: 10.223.122.101
> 2013-11-19 01:16:19,204 - DEBUG - test_01_RouterStopCreatePF 
> (test_routers.TestRouterStopCreatePF) - 22
> 
> ==> result.log <==
> ok
> 
> --
> Ran 6 tests in 216.937s
> 
> OK (skipped=5)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 15715: CLOUDSTACK-5215: Correcting and refactoring code related to getting free vlan

2013-11-20 Thread Girish Shilamkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15715/#review29212
---

Ship it!


Committed to 4.2, 4.2 and master

- Girish Shilamkar


On Nov. 20, 2013, 10:53 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15715/
> ---
> 
> (Updated Nov. 20, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5215
> https://issues.apache.org/jira/browse/CLOUDSTACK-5215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The function getFreeVlan was used in 3 files separately and it was not 
> checking whether the vlan id is already in use by any other network.
> 
> Now checking if it is used by any network, else search for another vlan id, 
> also moved this function to common.py and made respective changes across 3 
> files.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_shared_networks.py 28468c9 
>   test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
>   test/integration/component/test_vpc_vms_deployment.py c4811ed 
>   tools/marvin/marvin/integration/lib/common.py 6c2bb2a 
> 
> Diff: https://reviews.apache.org/r/15715/diff/
> 
> 
> Testing
> ---
> 
> Tested is the function works correctly. Ran 2 test cases simultaneously which 
> create multiple shared networks.
> 
> Log:
> 
> Test 1:
> ==> result.log <==
> test_createSharedNetwork_projectSpecific 
> (test_shared_networks.TestSharedNetworks)
> Test Shared Network with scope project ... skipped 'skip'
> test_createSharedNetwork_usedVlan (test_shared_networks.TestSharedNetworks)
> Test Shared Network with used vlan 01 ... skipped 'skipped - This is a 
> redundant case and also this is causing issue for rest fo the cases '
> test_createSharedNetwork_usedVlan2 (test_shared_networks.TestSharedNetworks)
> Test Shared Network with used vlan 02 ... skipped 'skip'
> test_deployVM_isolatedAndShared (test_shared_networks.TestSharedNetworks)
> Test VM deployment in shared and isolated networks ... skipped 'skip'
> test_deployVM_multipleSharedNetwork (test_shared_networks.TestSharedNetworks)
> Test Vm deployment with multiple shared networks ...
> ==> client.log <==
> 2013-11-19 21:40:40,957 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Admin account created: 
> 7d379404-9bf3-47aa-a4bc
> -0fe77e7455eb
> 2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - 2360
> 2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Physical Network found: 
> 05ef4a90-f9ba-449f-b1b
> 6-a437e6c4d4dd
> 2013-11-19 21:40:41,071 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Shared Network offering created: 
> d6b52bcc-f7d4
> -401a-83d2-6c049854ab76
> 2013-11-19 21:40:41,266 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Shared Network created: 
> bc992430-00f8-42eb-9e2
> 2-fdfcf3b2e94a
> 2013-11-19 21:40:41,321 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - 2368
> 2013-11-19 21:40:41,420 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Network created: 
> e661393d-a1bb-4619-adcc-4d7d6
> 5172e29
> 2013-11-19 21:42:01,929 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
> 44d30c61-07cb-4986-ab
> 16-96b9506c6061
> 2013-11-19 21:43:47,519 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
> 2d0f4114-a763-43be-90
> 70-73e3bb74571f
> 
> ==> result.log <==
> ok
> test_networkWithsubdomainaccessFalse (test_shared_networks.TestSharedNetworks)
> Test shared Network with subdomainaccess=False ... skipped 'skip'
> test_networkWithsubdomainaccessTrue (test_shared_networks.TestSharedNetworks)
> Test Shared Network with subdomainaccess=True ... skipped 'skip'
> test_sharedNetworkOffering_01 (test_shared_networks.TestSharedNetworks)
> Test shared network Offering 01 ... skipped 'skip'
> test_sharedNetworkOffering_02 (test_shared_networks.TestSharedNetworks)
> Test Shared Network Offering 02 ... skipped 'skip'
> test_sharedNetworkOffering_03 (test_shared_networks.TestSharedNetworks)
> Test Shared Network Offering 03 ... skipped 'skip'
> 
> --
> Ran 13 tests in 472.706s
> 
> OK (skipped=12)
> 
> 
> Test 2:
> 
>  ==> result.log <==
> test_createSharedNetwork_All (test_shared_networks.TestSharedNe

Re: Review Request 15715: CLOUDSTACK-5215: Correcting and refactoring code related to getting free vlan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15715/#review29211
---


Commit 631743b44a3cd5e69ff5c1ef6844950bb1074c5c in branch refs/heads/4.2 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=631743b ]

CLOUDSTACK-5215: Correcting and refactoring code related to
 getting free vlan


- ASF Subversion and Git Services


On Nov. 20, 2013, 10:53 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15715/
> ---
> 
> (Updated Nov. 20, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5215
> https://issues.apache.org/jira/browse/CLOUDSTACK-5215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The function getFreeVlan was used in 3 files separately and it was not 
> checking whether the vlan id is already in use by any other network.
> 
> Now checking if it is used by any network, else search for another vlan id, 
> also moved this function to common.py and made respective changes across 3 
> files.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_shared_networks.py 28468c9 
>   test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
>   test/integration/component/test_vpc_vms_deployment.py c4811ed 
>   tools/marvin/marvin/integration/lib/common.py 6c2bb2a 
> 
> Diff: https://reviews.apache.org/r/15715/diff/
> 
> 
> Testing
> ---
> 
> Tested is the function works correctly. Ran 2 test cases simultaneously which 
> create multiple shared networks.
> 
> Log:
> 
> Test 1:
> ==> result.log <==
> test_createSharedNetwork_projectSpecific 
> (test_shared_networks.TestSharedNetworks)
> Test Shared Network with scope project ... skipped 'skip'
> test_createSharedNetwork_usedVlan (test_shared_networks.TestSharedNetworks)
> Test Shared Network with used vlan 01 ... skipped 'skipped - This is a 
> redundant case and also this is causing issue for rest fo the cases '
> test_createSharedNetwork_usedVlan2 (test_shared_networks.TestSharedNetworks)
> Test Shared Network with used vlan 02 ... skipped 'skip'
> test_deployVM_isolatedAndShared (test_shared_networks.TestSharedNetworks)
> Test VM deployment in shared and isolated networks ... skipped 'skip'
> test_deployVM_multipleSharedNetwork (test_shared_networks.TestSharedNetworks)
> Test Vm deployment with multiple shared networks ...
> ==> client.log <==
> 2013-11-19 21:40:40,957 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Admin account created: 
> 7d379404-9bf3-47aa-a4bc
> -0fe77e7455eb
> 2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - 2360
> 2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Physical Network found: 
> 05ef4a90-f9ba-449f-b1b
> 6-a437e6c4d4dd
> 2013-11-19 21:40:41,071 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Shared Network offering created: 
> d6b52bcc-f7d4
> -401a-83d2-6c049854ab76
> 2013-11-19 21:40:41,266 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Shared Network created: 
> bc992430-00f8-42eb-9e2
> 2-fdfcf3b2e94a
> 2013-11-19 21:40:41,321 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - 2368
> 2013-11-19 21:40:41,420 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Network created: 
> e661393d-a1bb-4619-adcc-4d7d6
> 5172e29
> 2013-11-19 21:42:01,929 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
> 44d30c61-07cb-4986-ab
> 16-96b9506c6061
> 2013-11-19 21:43:47,519 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
> 2d0f4114-a763-43be-90
> 70-73e3bb74571f
> 
> ==> result.log <==
> ok
> test_networkWithsubdomainaccessFalse (test_shared_networks.TestSharedNetworks)
> Test shared Network with subdomainaccess=False ... skipped 'skip'
> test_networkWithsubdomainaccessTrue (test_shared_networks.TestSharedNetworks)
> Test Shared Network with subdomainaccess=True ... skipped 'skip'
> test_sharedNetworkOffering_01 (test_shared_networks.TestSharedNetworks)
> Test shared network Offering 01 ... skipped 'skip'
> test_sharedNetworkOffering_02 (test_shared_networks.TestSharedNetworks)
> Test Shared Network Offering 02 ... skipped 'skip'
> test_sharedNetworkOffering_03 (test_shared_networks.TestSharedNetworks)
> Test Shared Network Offering 03 ... skipped 'skip'
> 
> ---

Re: Review Request 15715: CLOUDSTACK-5215: Correcting and refactoring code related to getting free vlan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15715/#review29210
---


Commit 0253fe5d3bcaebfd7d23da5404a071588235b8d4 in branch refs/heads/4.3 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0253fe5 ]

CLOUDSTACK-5215: Correcting and refactoring code related to
 getting free vlan


- ASF Subversion and Git Services


On Nov. 20, 2013, 10:53 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15715/
> ---
> 
> (Updated Nov. 20, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5215
> https://issues.apache.org/jira/browse/CLOUDSTACK-5215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The function getFreeVlan was used in 3 files separately and it was not 
> checking whether the vlan id is already in use by any other network.
> 
> Now checking if it is used by any network, else search for another vlan id, 
> also moved this function to common.py and made respective changes across 3 
> files.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_shared_networks.py 28468c9 
>   test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
>   test/integration/component/test_vpc_vms_deployment.py c4811ed 
>   tools/marvin/marvin/integration/lib/common.py 6c2bb2a 
> 
> Diff: https://reviews.apache.org/r/15715/diff/
> 
> 
> Testing
> ---
> 
> Tested is the function works correctly. Ran 2 test cases simultaneously which 
> create multiple shared networks.
> 
> Log:
> 
> Test 1:
> ==> result.log <==
> test_createSharedNetwork_projectSpecific 
> (test_shared_networks.TestSharedNetworks)
> Test Shared Network with scope project ... skipped 'skip'
> test_createSharedNetwork_usedVlan (test_shared_networks.TestSharedNetworks)
> Test Shared Network with used vlan 01 ... skipped 'skipped - This is a 
> redundant case and also this is causing issue for rest fo the cases '
> test_createSharedNetwork_usedVlan2 (test_shared_networks.TestSharedNetworks)
> Test Shared Network with used vlan 02 ... skipped 'skip'
> test_deployVM_isolatedAndShared (test_shared_networks.TestSharedNetworks)
> Test VM deployment in shared and isolated networks ... skipped 'skip'
> test_deployVM_multipleSharedNetwork (test_shared_networks.TestSharedNetworks)
> Test Vm deployment with multiple shared networks ...
> ==> client.log <==
> 2013-11-19 21:40:40,957 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Admin account created: 
> 7d379404-9bf3-47aa-a4bc
> -0fe77e7455eb
> 2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - 2360
> 2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Physical Network found: 
> 05ef4a90-f9ba-449f-b1b
> 6-a437e6c4d4dd
> 2013-11-19 21:40:41,071 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Shared Network offering created: 
> d6b52bcc-f7d4
> -401a-83d2-6c049854ab76
> 2013-11-19 21:40:41,266 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Shared Network created: 
> bc992430-00f8-42eb-9e2
> 2-fdfcf3b2e94a
> 2013-11-19 21:40:41,321 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - 2368
> 2013-11-19 21:40:41,420 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Network created: 
> e661393d-a1bb-4619-adcc-4d7d6
> 5172e29
> 2013-11-19 21:42:01,929 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
> 44d30c61-07cb-4986-ab
> 16-96b9506c6061
> 2013-11-19 21:43:47,519 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
> 2d0f4114-a763-43be-90
> 70-73e3bb74571f
> 
> ==> result.log <==
> ok
> test_networkWithsubdomainaccessFalse (test_shared_networks.TestSharedNetworks)
> Test shared Network with subdomainaccess=False ... skipped 'skip'
> test_networkWithsubdomainaccessTrue (test_shared_networks.TestSharedNetworks)
> Test Shared Network with subdomainaccess=True ... skipped 'skip'
> test_sharedNetworkOffering_01 (test_shared_networks.TestSharedNetworks)
> Test shared network Offering 01 ... skipped 'skip'
> test_sharedNetworkOffering_02 (test_shared_networks.TestSharedNetworks)
> Test Shared Network Offering 02 ... skipped 'skip'
> test_sharedNetworkOffering_03 (test_shared_networks.TestSharedNetworks)
> Test Shared Network Offering 03 ... skipped 'skip'
> 
> ---

Re: Review Request 15715: CLOUDSTACK-5215: Correcting and refactoring code related to getting free vlan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15715/#review29209
---


Commit 6aca7de291e01a3a4641331ad1fedd6f0e70bd96 in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6aca7de ]

CLOUDSTACK-5215: Correcting and refactoring code related to
 getting free vlan


- ASF Subversion and Git Services


On Nov. 20, 2013, 10:53 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15715/
> ---
> 
> (Updated Nov. 20, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5215
> https://issues.apache.org/jira/browse/CLOUDSTACK-5215
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The function getFreeVlan was used in 3 files separately and it was not 
> checking whether the vlan id is already in use by any other network.
> 
> Now checking if it is used by any network, else search for another vlan id, 
> also moved this function to common.py and made respective changes across 3 
> files.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_shared_networks.py 28468c9 
>   test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
>   test/integration/component/test_vpc_vms_deployment.py c4811ed 
>   tools/marvin/marvin/integration/lib/common.py 6c2bb2a 
> 
> Diff: https://reviews.apache.org/r/15715/diff/
> 
> 
> Testing
> ---
> 
> Tested is the function works correctly. Ran 2 test cases simultaneously which 
> create multiple shared networks.
> 
> Log:
> 
> Test 1:
> ==> result.log <==
> test_createSharedNetwork_projectSpecific 
> (test_shared_networks.TestSharedNetworks)
> Test Shared Network with scope project ... skipped 'skip'
> test_createSharedNetwork_usedVlan (test_shared_networks.TestSharedNetworks)
> Test Shared Network with used vlan 01 ... skipped 'skipped - This is a 
> redundant case and also this is causing issue for rest fo the cases '
> test_createSharedNetwork_usedVlan2 (test_shared_networks.TestSharedNetworks)
> Test Shared Network with used vlan 02 ... skipped 'skip'
> test_deployVM_isolatedAndShared (test_shared_networks.TestSharedNetworks)
> Test VM deployment in shared and isolated networks ... skipped 'skip'
> test_deployVM_multipleSharedNetwork (test_shared_networks.TestSharedNetworks)
> Test Vm deployment with multiple shared networks ...
> ==> client.log <==
> 2013-11-19 21:40:40,957 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Admin account created: 
> 7d379404-9bf3-47aa-a4bc
> -0fe77e7455eb
> 2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - 2360
> 2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Physical Network found: 
> 05ef4a90-f9ba-449f-b1b
> 6-a437e6c4d4dd
> 2013-11-19 21:40:41,071 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Shared Network offering created: 
> d6b52bcc-f7d4
> -401a-83d2-6c049854ab76
> 2013-11-19 21:40:41,266 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Shared Network created: 
> bc992430-00f8-42eb-9e2
> 2-fdfcf3b2e94a
> 2013-11-19 21:40:41,321 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - 2368
> 2013-11-19 21:40:41,420 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Network created: 
> e661393d-a1bb-4619-adcc-4d7d6
> 5172e29
> 2013-11-19 21:42:01,929 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
> 44d30c61-07cb-4986-ab
> 16-96b9506c6061
> 2013-11-19 21:43:47,519 - DEBUG - test_deployVM_multipleSharedNetwork 
> (test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
> 2d0f4114-a763-43be-90
> 70-73e3bb74571f
> 
> ==> result.log <==
> ok
> test_networkWithsubdomainaccessFalse (test_shared_networks.TestSharedNetworks)
> Test shared Network with subdomainaccess=False ... skipped 'skip'
> test_networkWithsubdomainaccessTrue (test_shared_networks.TestSharedNetworks)
> Test Shared Network with subdomainaccess=True ... skipped 'skip'
> test_sharedNetworkOffering_01 (test_shared_networks.TestSharedNetworks)
> Test shared network Offering 01 ... skipped 'skip'
> test_sharedNetworkOffering_02 (test_shared_networks.TestSharedNetworks)
> Test Shared Network Offering 02 ... skipped 'skip'
> test_sharedNetworkOffering_03 (test_shared_networks.TestSharedNetworks)
> Test Shared Network Offering 03 ... skipped 'skip'
> 
>

[PROPOSAL] User VM HA using native XS HA capabilities

2013-11-20 Thread Koushik Das

Cloudstack relies on custom HA logic for user VMs running on Xenserver. The 
reason for doing it like this may be due the fact that native HA capabilities 
in XS was not mature enough during the initial days. Also in the custom HA 
logic, Cloudstack has to correctly determine the state of a VM from the 
hypervisor before it can take any action. In case there are any issues in 
determining the state, HA mechanism can get impacted. Since the hypervisor best 
knows the state of the VM it is a better approach to rely on native HA 
capabilities.

The idea is to rely on native HA capabilities for user VMs from XS 6.2 onwards. 
HA for system VMs would still be based on application logic. For sake of 
backward compatibility the earlier option will be there as well and there will 
be a choice to use any one option.

The additional requirement for this is to pre-configure native HA on a 
Xenserver cluster before deploying any user VMs as documented here [1].

I have created a ticket in Jira [2]. I will post the FS for this shortly.

Thanks,
Koushik

[1] 
http://support.citrix.com/servlet/KbServlet/download/34969-102-704897/reference.pdf
 (refer section 3.8)
[2] https://issues.apache.org/jira/browse/CLOUDSTACK-5203

Jenkins build is back to normal : build-master » Apache CloudStack Client UI #17

See

Jenkins build is back to normal : build-master #17

See

Review Request 15748: vmware os type error for redhat 6.x

2013-11-20 Thread Jijun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15748/
---

Review request for cloudstack and daan Hoogland.


Bugs: CLOUDSTACK-5225
https://issues.apache.org/jira/browse/CLOUDSTACK-5225


Repository: cloudstack-git


Description
---

 upload a redhat 6.x iso or template , start a vm using it. check the os type 
in vsphere client, the vm os type is other 64 linux. the vmware-tools can not 
be installed due to the issue. 


Diffs
-

  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareGuestOsMapper.java 
b8c3e8d 

Diff: https://reviews.apache.org/r/15748/diff/


Testing
---


Thanks,

Jijun

RE: Unable to add NetScaler in 4.3 branch builds - Automation blocker

2013-11-20 Thread Rayees Namathponnan

Created below defect, EIP / ELB automation blocked due to this

https://issues.apache.org/jira/browse/CLOUDSTACK-5224


Regards,
Rayees 

-Original Message-
From: Rayees Namathponnan [mailto:rayees.namathpon...@citrix.com] 
Sent: Wednesday, November 20, 2013 2:29 PM
To: dev@cloudstack.apache.org
Cc: Darren Shepherd  (darren.s.sheph...@gmail.com)
Subject: Unable to add NetScaler in 4.3 branch builds

Hi,

I created noredist (non oss  build from 4.3 branch ;  and  created advanced 
zone in KVM.

I am trying to add NetScaler as service provider;  but its failed with below 
error


2013-11-20 00:13:57,532 DEBUG [c.c.a.ApiServlet] 
(catalina-exec-24:ctx-2de1fb83) ===START===  10.223.240.194 -- GET  
physicalnetworkid=05ef4a90-f9ba-449f-b1b6
-a437e6c4d4dd&apiKey=a8WrP3KUsp4G9e4xsseUEgqRJF0hoZ8uZwtIL5tM7fnSNgZ-uez5ht7x0GvH8fnVzI59gjnq93VRZzazazy8dQ&name=Netscaler&command=addNetworkServiceProvider&s
ignature=Kz%2FM3E60UlpWJg0VbjEs%2FdHpIUE%3D&response=json
2013-11-20 00:13:57,553 INFO  [c.c.a.ApiServer] (catalina-exec-24:ctx-2de1fb83 
ctx-0bbc33a1 ctx-e0da0b07) Unable to find the Network Element implementing the 
Service Provider 'Netscaler'
2013-11-20 00:13:57,554 DEBUG [c.c.a.ApiServlet] (catalina-exec-24:ctx-2de1fb83 
ctx-0bbc33a1 ctx-e0da0b07) ===END===  10.223.240.194 -- GET  
physicalnetworkid=05ef4a90-f9ba-449f-b1b6-a437e6c4d4dd&apiKey=a8WrP3KUsp4G9e4xsseUEgqRJF0hoZ8uZwtIL5tM7fnSNgZ-uez5ht7x0GvH8fnVzI59gjnq93VRZzazazy8dQ&name=Netscaler&command=addNetworkServiceProvider&signature=Kz%2FM3E60UlpWJg0VbjEs%2FdHpIUE%3D&response=json


Regards,
Rayees

Review Request 15746: Service Offering being created without host tags due to mismatch with base for test_vpc_vm_life_cycle.py.

2013-11-20 Thread Parth Jagirdar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15746/
---

Review request for cloudstack, edison su and Girish Shilamkar.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5223

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5223


Repository: cloudstack-git


Description
---

Service Offering being created without host tags due to mismatch with base.


Diffs
-

  test/integration/component/test_vpc_vm_life_cycle.py beb5b99 

Diff: https://reviews.apache.org/r/15746/diff/


Testing
---

Yes


Thanks,

Parth Jagirdar

Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen is in processing state forever with Delete Events/Alerts request having no filter

2013-11-20 Thread Amogh Vasekar



> On Sept. 27, 2013, 6:54 p.m., ASF Subversion and Git Services wrote:
> > Commit 38b94e934c38556ed3974ab16a35d5be33f4edc4 in branch refs/heads/master 
> > from brito wang
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=38b94e9 ]
> > 
> > CLOUDSTACK-3363 UI > fix list Events/Alerts screen is in processing state 
> > forever with Delete Events/Alerts request having no filter
> >

Since this has been submitted, Bo can you please close the request?


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13770/#review26442
---


On Aug. 28, 2013, 7:46 a.m., bo wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13770/
> ---
> 
> (Updated Aug. 28, 2013, 7:46 a.m.)
> 
> 
> Review request for cloudstack, Brian Federle and bharat kumar.
> 
> 
> Bugs: CLOUDSTACK-3363
> https://issues.apache.org/jira/browse/CLOUDSTACK-3363
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1.The loading screen won't disappear when delete the events or alerts with 
> incorrect parameters ,Because there is no handling for exception in the js 
> code.
> 2.Error messages are not completely correct, it should be "Either type or 
> enddate must be specified".
> 
> 
> Diffs
> -
> 
>   ui/scripts/events.js 46d45c0 
> 
> Diff: https://reviews.apache.org/r/13770/diff/
> 
> 
> Testing
> ---
> 
> 1.The loading screen will disappear when close the error message dialog.
> 2.The error message will be "Either type or enddate must be specified".
> 
> 
> Thanks,
> 
> bo wang
> 
>

Re: Review Request 14549: Rename net.juniper.contrail to org.apache.cloudstack.network.contrail

2013-11-20 Thread Amogh Vasekar



> On Nov. 1, 2013, 4:57 p.m., Hugo Trippaers wrote:
> > commit 6b5fab2f5cd939f64b5c9c1ee8d87ca8b6f6514d
> > Author: Pedro Marques 
> > Date:   Thu Oct 31 17:16:58 2013 -0700
> > 
> > OpenContrail network plugin
> > 
> > Signed-off-by: Hugo Trippaers 
> >

Reminder - 

Hi,
Can you please mark this as submmited? Thanks!


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review28016
---


On Nov. 1, 2013, 12:19 a.m., Pedro Marques wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> ---
> 
> (Updated Nov. 1, 2013, 12:19 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/Network.java 49f380b 
>   client/pom.xml 3e08a9a 
>   client/tomcatconf/commands.properties.in e92596c 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  3df28ed 
>   plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-co

Build failed in Jenkins: build-master #16

See 

Changes:

[sudison] Add logs in case ipassoccmd failed

--
[...truncated 3623 lines...]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-systemvm ---
[INFO] Deleting 
 (includes 
= [**/*], excludes = [])
[INFO] Deleting 
 (includes = 
[**/*], excludes = [])
[INFO] Deleting  
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (build-cloud-scripts) @ cloud-systemvm 
---
[INFO] Executing tasks

main:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

 [copy] Copying 103 files to 

 [copy] Copying 3 files to 

  [tar] Building tar: 

 [gzip] Building: 

   [delete] Deleting directory 

   [delete] Deleting: 

[INFO] Executed tasks
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-systemvm 
---
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Client UI 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-client-ui ---
[INFO] Deleting 
 (includes = 
[**/*], excludes = [])
[INFO] Deleting  
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-client-ui ---
Downloading: 
http://repo.maven.apache.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: 
http://cs-maven.midokura.com/releases/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: 
http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: 
http://repo.maven.apache.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: 
http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
[WARNING] Missing POM for org.libvirt:libvirt:jar:0.5.1
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack . SUCCESS [29.229s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.585s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [27.939s]
[INFO] Apache CloudStack Utils ... SUCCESS [37.363s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.446s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [25.152s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [18.674s]
[INFO] Apache CloudStack API . SUCCESS [35.447s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [9.913s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [20.286s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.510s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [22.745s]
[INFO] Apache CloudStack Core  SUCCESS [35.402s]
[INFO] Apache CloudStack Agents .. SUCCESS [21.624s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [13.069s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [14.577s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [31.520s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [7.328s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [13.785s]
[INFO] Apache CloudStack Server .. SUCCESS [2:26.627s]
[INFO] Apache CloudStack Usage Server  SUCCESS [28.749s]
[INFO] Apache XenSource XAPI ..

Build failed in Jenkins: build-master » Apache CloudStack Client UI #16

See 


--
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Client UI 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-client-ui ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-client-ui ---
Downloading: 
http://repo.maven.apache.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: 
http://cs-maven.midokura.com/releases/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: 
http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: 
http://repo.maven.apache.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: 
http://libvirt.org/maven2/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
Downloading: http://ceph.com/maven/org/libvirt/libvirt/0.5.1/libvirt-0.5.1.pom
[WARNING] Missing POM for org.libvirt:libvirt:jar:0.5.1

Re: [MERGE] Reformat of the source code....

2013-11-20 Thread Hugo Trippaers

+1!

Sent from my iPhone

> On 20 nov. 2013, at 16:15, Alex Huang  wrote:
> 
> Taking advantage of the CCC happening and 4.3 just being branched, I did a 
> reformat of the entire source base.  It converts all tabs to spaces and 
> rejoin lines that were split due to the 80 column limit.  I also added 
> checkstyle to maven build.  There may be things missing here and there but 
> overall should reduce the number of lines in our checkins.
> 
> It created a massive amount of change of course but it all compiles and 
> starts up.  Any concerns about met checking this in to master?  I'll wait 24 
> hours for this merge request since we've talked about this before.
> 
> --Alex

Unable to add NetScaler in 4.3 branch builds

2013-11-20 Thread Rayees Namathponnan

Hi,

I created noredist (non oss  build from 4.3 branch ;  and  created advanced 
zone in KVM.

I am trying to add NetScaler as service provider;  but its failed with below 
error


2013-11-20 00:13:57,532 DEBUG [c.c.a.ApiServlet] 
(catalina-exec-24:ctx-2de1fb83) ===START===  10.223.240.194 -- GET  
physicalnetworkid=05ef4a90-f9ba-449f-b1b6
-a437e6c4d4dd&apiKey=a8WrP3KUsp4G9e4xsseUEgqRJF0hoZ8uZwtIL5tM7fnSNgZ-uez5ht7x0GvH8fnVzI59gjnq93VRZzazazy8dQ&name=Netscaler&command=addNetworkServiceProvider&s
ignature=Kz%2FM3E60UlpWJg0VbjEs%2FdHpIUE%3D&response=json
2013-11-20 00:13:57,553 INFO  [c.c.a.ApiServer] (catalina-exec-24:ctx-2de1fb83 
ctx-0bbc33a1 ctx-e0da0b07) Unable to find the Network Element implementing the 
Service Provider 'Netscaler'
2013-11-20 00:13:57,554 DEBUG [c.c.a.ApiServlet] (catalina-exec-24:ctx-2de1fb83 
ctx-0bbc33a1 ctx-e0da0b07) ===END===  10.223.240.194 -- GET  
physicalnetworkid=05ef4a90-f9ba-449f-b1b6-a437e6c4d4dd&apiKey=a8WrP3KUsp4G9e4xsseUEgqRJF0hoZ8uZwtIL5tM7fnSNgZ-uez5ht7x0GvH8fnVzI59gjnq93VRZzazazy8dQ&name=Netscaler&command=addNetworkServiceProvider&signature=Kz%2FM3E60UlpWJg0VbjEs%2FdHpIUE%3D&response=json


Regards,
Rayees

Re: Router requires upgrade. Unable to send command to router Error

OK here is how far I got debugging this. I think I am missing a small 
thing. I hope you guys can help.


So my VM template has the correct version.

root@eng-ns-dev-cs1: /export/secondary/template/tmpl/1/1 # strings 
f3fc75d9-0240-4c71-a3bf-fb65652e4763.vhd  | grep Cloudstack

Cloudstack Release*  4.2.0*Tue Nov 19 23:22:37 UTC 2013


But in the database I see the following ( table domain_router )

*** 4. row ***
 id: 11
 element_id: 4
 public_mac_address: 06:48:a8:00:00:68
  public_ip_address: 172.30.91.102
 public_netmask: 255.255.255.0
  guest_netmask: NULL
   guest_ip_address: NULL
is_redundant_router: 0
   priority: 0
 is_priority_bumpup: 0
redundant_state: UNKNOWN
   stop_pending: 0
   role: VIRTUAL_ROUTER
   template_version:*Cloudstack Release 3.0 Mon Feb 6 15:10:04 PST 2012*
scripts_version: 725d5e5901a62c68aed0dd3463023518
 vpc_id: NULL
4 rows in set (0.00 sec)



I guess this is populated from the VM that gets created. On the xen the 
vm is r-11. I see the following version on that VM


root@r-11-VM:~# cat /etc/cloudstack-release
Cloudstack Release 3.0 Mon Feb  6 15:10:04 PST 2012


This means that Xen is not picking up the template present in the 
secondary storage. Does Xen cache the vhd files locally to avoid coming 
to the secondary storage? If so, how can I disable that?


Also, I was looking at UpgradeRouterTemplateCmd API which basically goes 
through all the VRs and reboots them. It expects that when the reboot is 
completed, the router should have picked up the 4.2.0 version of the 
template ( see line 4072 in VirtualNetworkApplianceManagerImpl.java ) I 
try to do the reboot manually but the template remains the same. Do you 
guys have any more suggestions?


Thanks,
-Syed





On Wed 20 Nov 2013 12:55:04 PM EST, Wei ZHOU wrote:


FYI.

I upgraded from 2.2.14 to 4.2.1. The CPVM, SSVM and VRs are working after
running *cloudstack-sysvmadm to recreate.*


2013/11/20 Syed Ahmed 



+1 Same error. The secondary storage VM and the Console proxy VM seem to
be coming up alright. I see this error only when starting the virtual
router which is preventing me from creating any instances.


On Wed 20 Nov 2013 11:14:47 AM EST, Will Stevens wrote:



I am having the same problem. I got the latest system VMs from:
http://jenkins.buildacloud.org/view/master/job/build-systemvm-master/
lastSuccessfulBuild/artifact/tools/appliance/dist/

Are these the wrong System VM Templates? If so, where should I get the
System VM Templates to make this work again?

Thanks,

Will


On Thu, Nov 7, 2013 at 7:42 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

Nitin, I had the same problem, but I fixed it by uploading 4.2 system


templates to my secondary storage. Make sure you have the latest too.

-alena.

From: Nitin Mehta 
mailto:nitin.me...@citrix.com>





Reply-To: "dev@cloudstack.apache.org"
<
dev@cloudstack.apache.org>
Date: Thursday, November 7, 2013 4:16 PM
To: "dev@cloudstack.apache.org" <
dev@cloudstack.apache.org>
Subject: Router requires upgrade. Unable to send command to router 
Error


Unable to deploy vms in the latest master because of the commit 
below. Is

anyone noticing this on the latest master.
I checked the code and there was a commit made recently 3f5b8f which is
where the exception points to.

WARN [o.a.c.alerts] (CapacityChecker:ctx-4f1ef01f) alertType:: 2 //
dataCenterId:: 3 // podId:: 3 // clusterId:: null // message:: System
Alert: Low Available Storage in cluster c3 pod p of availability 
zone z3

INFO [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-1:ctx-f118d6dc) Add
job-44 into job monitoring
WARN [c.c.h.x.r.CitrixResourceBase] (DirectAgent-26:ctx-3e786331)
Detecting a change in xstoolsversion for r-6-VM
ERROR [c.c.v.VirtualMachineManagerImpl] (Job-Executor-1:ctx-f118d6dc
ctx-d9a00f18) Failed to start instance
VM[User|VM-4d5d5db2-e5ba-4bbd-b1dc-e749ac42a74c]
com.cloud.utils.exception.CloudRuntimeException: Router requires
upgrade.
Unable to send command to router:6
at
com.cloud.network.router.VirtualNetworkApplianceManager
Impl.sendCommandsToRouter(VirtualNetworkApplianceManagerImpl.java:3567)
at
com.cloud.network.router.VirtualNetworkApplianceManagerImpl$7.execute(
VirtualNetworkApplianceManagerImpl.java:3003)
at
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(
VirtualNetworkApplianceManagerImpl.java:3848)
at
com.cloud.network.router.VirtualNetworkApplianceManager
Impl.applyDhcpEntry(VirtualNetworkApplianceManagerImpl.java:2995)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:25)

4.3 bvt blocker - KVM automation run

2013-11-20 Thread Rayees Namathponnan

Hi All,


Executed automation run on 4.3 branch HEAD 
7ed2a21c29ef351463099bed6810151fd32e8970; observed below failures

1)
integration.smoke.test_iso.TestISO.test_03_delete_iso
integration.smoke.test_templates.TestTemplates.test_03_delete_template

Defect https://issues.apache.org/jira/browse/CLOUDSTACK-5221 created.


2)  integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl 
(issue reported in master also; before cutting 4.3 branch)

Defect https://issues.apache.org/jira/browse/CLOUDSTACK-5047 created.


3) Failures observed in below test cases,  looking on this

integration.smoke.test_vm_life_cycle.TestVMLifeCycle.test_10_attachAndDetach_iso
integration.smoke.test_loadbalance.TestLoadBalance.test_assign_and_removal_lb


Regards,
Rayees

Re: [MERGE] Reformat of the source code....

2013-11-20 Thread Sheng Yang

Sorry for confusion, in fact it's just for "community" information.

Because in the original thread, I don't see the new column limitation, then
find it out in wiki.

Thanks for reformatting Alex!

--Sheng


On Wed, Nov 20, 2013 at 1:39 PM, Alex Huang  wrote:

> Sorry.  What do you mean.  Do you mean I did it wrong somehow and the
> files are now over 180 columns wide?
>
> --Alex
>
> > -Original Message-
> > From: Sheng Yang [mailto:sh...@yasker.org]
> > Sent: Wednesday, November 20, 2013 9:43 AM
> > To: 
> > Subject: Re: [MERGE] Reformat of the source code
> >
> > FYI:
> >
> > coding convention at:
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventi
> > ons
> >
> > The updated column limit is: "File content must be kept within 180
> columns"
> >
> > --Sheng
> >
> >
> > On Wed, Nov 20, 2013 at 7:46 AM, Alex Huang 
> > wrote:
> >
> > > The branch is called reformat if you like to check it.
> > >
> > > --Alex
> > >
> > > > -Original Message-
> > > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > > Sent: Wednesday, November 20, 2013 7:15 AM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: [MERGE] Reformat of the source code
> > > >
> > > > Taking advantage of the CCC happening and 4.3 just being branched, I
> did
> > > a
> > > > reformat of the entire source base.  It converts all tabs to spaces
> and
> > > rejoin
> > > > lines that were split due to the 80 column limit.  I also added
> > > checkstyle to
> > > > maven build.  There may be things missing here and there but overall
> > > should
> > > > reduce the number of lines in our checkins.
> > > >
> > > > It created a massive amount of change of course but it all compiles
> and
> > > starts
> > > > up.  Any concerns about met checking this in to master?  I'll wait 24
> > > hours for
> > > > this merge request since we've talked about this before.
> > > >
> > > > --Alex
> > >
>

RE: A question on vm migrations when hosts are set into a maintenance mode.

Wido,

Looks like you didn't update your schema file or forgot to add a schema upgrade 
file in master?  See the error described by Alex below.

@Alex

You can probably remove the cachemode field in the DiskOfferingVO for now.  Or 
revert  1edaa36 on your local repo to keep moving forward.

--Alex

From: Alex Ough [mailto:alex.o...@sungard.com]
Sent: Wednesday, November 20, 2013 9:56 AM
To: Alex Huang
Cc: dev@cloudstack.apache.org
Subject: Re: A question on vm migrations when hosts are set into a maintenance 
mode.

Hi Alex,

It looks like you moved the 'ExecuteInSequence' to the vm level from the 
management server, which seems to be ok, but at this time I cannot test it
because when I try to start up the management server, it fails because of 
database schema error, which is 'Unknown column 'disk_offering.cache_mode' in 
'field list' even if I re-built the database.

Is the schema change part of your changes or something other developer changed?

If that is from any other developer, can you fix this?

Thanks
Alex Ough

On Tue, Nov 19, 2013 at 7:25 PM, Alex Huang 
mailto:alex.hu...@citrix.com>> wrote:
Alex,

Can you do a pull from master and see if my fix fits your needs.  
Unfortunately, I'm on the road and couldn't do an actual test of it.

--Alex

From: Alex Huang
Sent: Tuesday, November 19, 2013 4:45 AM
To: 'Alex Ough'; dev@cloudstack.apache.org
Subject: RE: A question on vm migrations when hosts are set into a maintenance 
mode.

Alex,

Sorry for the late reply.  Been travelling the last couple of weeks.  I'll look 
into this today.

--Alex

From: Alex Ough [mailto:alex.o...@sungard.com]
Sent: Monday, November 18, 2013 6:17 AM
To: dev@cloudstack.apache.org
Cc: Alex Huang
Subject: Re: A question on vm migrations when hosts are set into a maintenance 
mode.

Thank Parasanna & Sebastien,
I also got his email and sent an email.
Waiting for his reply...

Thanks
Alex Ough

On Sat, Nov 16, 2013 at 3:05 PM, Sebastien Goasguen 
mailto:run...@gmail.com>> wrote:
cc Alex Huang to get his attention:

On Nov 15, 2013, at 10:17 PM, Prasanna Santhanam 
mailto:t...@apache.org>> wrote:

> Alex, Could you just do a git blame on the file and copy the emails of
> people who changed that bit of code? They may be able to help if Cc-ed
> directly.
>
> Thanks,
>
> On Fri, Nov 15, 2013 at 01:49:07PM -0600, Alex Ough wrote:
>> I hate to sending the same emails over and over again, but I really need to
>> finalize this feature to be included in the next code freeze because this
>> feature is very critical in our inside project.
>>
>> Anyone who can help, please?
>> Thanks
>> Alex Ough
>>
>>
>> On Thu, Nov 14, 2013 at 1:27 PM, Alex Ough 
>> mailto:alex.o...@sungard.com>> wrote:
>>
>>> Not sure if Alex Huang checked this, but can anyone help to resolve this?
>>>
>>> Thanks
>>> Alex Ough
>>>
>>>
>>> On Wed, Nov 13, 2013 at 11:39 AM, Alex Ough 
>>> mailto:alex.o...@sungard.com>> wrote:
>>>
 It sounds a little scary...

 I looked at the history and found these.

 8/9/ : file moved to engine by Alex Huang
 9/16 : '_mgmtServer.getExecuteInSequence()' changed to
 'getExecuteInSequence()' by Alex Huang

 Hi Alex Huang,
 I'm not sure if you're aware of this, but can you check this for me?

 Thanks
 Alex Ough

 On Wed, Nov 13, 2013 at 11:18 AM, Marcus Sorensen 
 mailto:shadow...@gmail.com>>wrote:

> I'm not sure. I know in the past when I've seen files change locations
> it has also clobbered updates to that file. Someone branched, did the
> reorganization work, and merged, while in-between the original file
> changed.
>
> On Wed, Nov 13, 2013 at 9:21 AM, Alex Ough 
> mailto:alex.o...@sungard.com>>
> wrote:
>> All,
>>
>> While merging my changes to 4.3 branch, I found that the option,
>> 'execute.in.sequence.hypervisor.commands' is NOT used in
> Start/Stop/Copy
>> commands in 'VirtualMachineManagerImpl.java' any more as below.
>>
>>
>> *StopCommand stop = new StopCommand(vm, getExecuteInSequence());*
>>
>> *protected boolean getExecuteInSequence() {*
>> * return false;*
>> *}*
>>
>> As you see in the above, the function, 'getExecuteInSequence', just
> returns
>> false instead of getting the value from the global variable.
>>
>> And one more change is that the file has been moved to
>> 'engine/orchestration/src/com/cloud/vm' from 'server/src/com/cloud/vm'.
>>
>> Am I missing something related with this or do we stop supporting this
>> option in 4.3?
>> I'm a little confused, so please help me resolve this.
>>
>> Thanks
>> Alex Ough
>>
>>
>>
>>
>> On Tue, Nov 12, 2013 at 4:20 PM, Alex Ough 
>> mailto:alex.o...@sungard.com>>
> wrote:
>>
>>> Thanks a lot for your confirmation, Marcus.
>>> I'll create a review r

RE: [MERGE] Reformat of the source code....

Sorry.  What do you mean.  Do you mean I did it wrong somehow and the files are 
now over 180 columns wide?

--Alex

> -Original Message-
> From: Sheng Yang [mailto:sh...@yasker.org]
> Sent: Wednesday, November 20, 2013 9:43 AM
> To: 
> Subject: Re: [MERGE] Reformat of the source code
> 
> FYI:
> 
> coding convention at:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventi
> ons
> 
> The updated column limit is: "File content must be kept within 180 columns"
> 
> --Sheng
> 
> 
> On Wed, Nov 20, 2013 at 7:46 AM, Alex Huang 
> wrote:
> 
> > The branch is called reformat if you like to check it.
> >
> > --Alex
> >
> > > -Original Message-
> > > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > > Sent: Wednesday, November 20, 2013 7:15 AM
> > > To: dev@cloudstack.apache.org
> > > Subject: [MERGE] Reformat of the source code
> > >
> > > Taking advantage of the CCC happening and 4.3 just being branched, I did
> > a
> > > reformat of the entire source base.  It converts all tabs to spaces and
> > rejoin
> > > lines that were split due to the 80 column limit.  I also added
> > checkstyle to
> > > maven build.  There may be things missing here and there but overall
> > should
> > > reduce the number of lines in our checkins.
> > >
> > > It created a massive amount of change of course but it all compiles and
> > starts
> > > up.  Any concerns about met checking this in to master?  I'll wait 24
> > hours for
> > > this merge request since we've talked about this before.
> > >
> > > --Alex
> >

Re: Request: Help designing a 'powered by' logo for CloudStack

Seemed like fun so gave it a go too:
https://people.apache.org/~duffy/attemp2.png


On 20 November 2013 16:17, Kirk Jantzer  wrote:

> I'm not a graphic designer, and I don't have vector software, but here is
> my very simple idea :-) http://i.imgur.com/WTNAIoG.png
>
>
> Regards,
>
> Kirk Jantzer
> http://about.me/kirkjantzer
>
>
> On Fri, Nov 15, 2013 at 3:06 PM, Robyn Bergeron 
> wrote:
>
> >
> >
> > - Original Message -
> > > From: "David Nalley" 
> > > To: market...@cloudstack.apache.org, dev@cloudstack.apache.org
> > > Sent: Friday, November 15, 2013 10:56:15 AM
> > > Subject: Request: Help designing a 'powered by' logo for CloudStack
> > >
> > > Hi folks:
> > >
> > > If you happen to have some graphical design talent (I have none) I
> > > have a great opportunity for you :)
> > >
> > > CloudStack needs a 'powered by' logo that is easy to consume, and is
> > > also attractive.
> > >
> > > A couple examples of powered by logos:
> > >
> > > http://tomcat.apache.org/images/tomcat-power.gif
> > >
> >
> https://cwiki.apache.org/confluence/download/attachments/80899/mahout-logo-poweredby-100.png?version=1&modificationDate=1312880703000
> > >
> >
> https://netbeans.org/images_www/screenshots/6.0/baseIDE_ant_powered_150px.png
> > >
> > > A couple of constraints:
> > > * Please don't use the Apache feather. (we could, but lets not; it
> > > will make life simpler)
> > > * Please try and produce a vector format as source (this allows us to
> > > scale/etc)
> > > * Because this will become a trademark (which is vastly different that
> > > copyright) - we will likely need some explicit email agreement around
> > > trademarks rights for the image. (I promise, it isn't as scary as that
> > > sentence makes it out to be.)
> >
> > I also lack design skills, but am always willing to throw out ideas :)
> >
> > Maybe incorporate the cloud monkey into something where he is turning a
> > gear of some sort on a machine that has little clouds coming out of it?
> I'm
> > not quite sure how to turn that into "powered by" exactly... but just a
> > thought. (The monkey is super cute.)
> >
> > -robyn
> >
> >
> > >
> > > Anyone interested?
> > >
> > > --David
> > >
> >
>

Re: Error while running master

2013-11-20 Thread Wido den Hollander

I think cache_mode is indeed the probleem, that's my bad.

I'm not able to fix it right now. I'll do that asap.

Wido



> Op 20 nov. 2013 om 21:00 heeft "Syed Ahmed"  het 
> volgende geschreven:
> 
> Hi All,
> 
> I am facing the following error when running the latest master. I have done a 
> clean compile and have dropped and created the db again.
> 
> [WARNING] Nested in org.springframework.context.ApplicationContextException: 
> Failed to start bean 'cloudStackLifeCycle'; nested exception is 
> com.cloud.utils.exception.CloudRuntimeException: DB Exception on: 
> com.mysql.jdbc.JDBC4PreparedStatement@538a1556: SELECT disk_offering.id, 
> disk_offering.domain_id, disk_offering.unique_name, disk_offering.name, 
> disk_offering.display_text, disk_offering.disk_size, disk_offering.tags, 
> disk_offering.type, disk_offering.removed, disk_offering.created, 
> disk_offering.recreatable, disk_offering.use_local_storage, 
> disk_offering.system_use, disk_offering.customized, disk_offering.uuid, 
> disk_offering.customized_iops, disk_offering.min_iops, 
> disk_offering.max_iops, disk_offering.sort_key, 
> disk_offering.bytes_read_rate, disk_offering.bytes_write_rate, 
> disk_offering.iops_read_rate, disk_offering.iops_write_rate, 
> disk_offering.cache_mode, disk_offering.display_offering, 
> disk_offering.state, disk_offering.hv_ss_reserve, service_offering.cpu, 
> service_offering.speed, service_offering.ram_size, service_offering.nw_rate, 
> service_offering.mc_rate, service_offering.ha_enabled, 
> service_offering.limit_cpu_use, service_offering.is_volatile, 
> service_offering.host_tag, service_offering.default_use, 
> service_offering.vm_type, service_offering.sort_key, 
> service_offering.deployment_planner FROM service_offering INNER JOIN 
> disk_offering ON service_offering.id=disk_offering.id  WHERE 
> disk_offering.type='Service' AND disk_offering.unique_name = 
> _binary'Cloud.Com-Small Instance'  AND disk_offering.system_use = 1 AND 
> disk_offering.removed IS NULL :
> com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Unknown column 
> 'disk_offering.cache_mode' in 'field list'
> 
> 
> This is the definition of disk_offering from create-schema.sql
> 
> CREATE TABLE `cloud`.`disk_offering` (
>  `id` bigint unsigned NOT NULL auto_increment,
>  `domain_id` bigint unsigned,
>  `name` varchar(255) NOT NULL,
>  `uuid` varchar(40),
>  `display_text` varchar(4096) NULL COMMENT 'Descrianaption text set by the 
> admin for display purpose only',
>  `disk_size` bigint unsigned NOT NULL COMMENT 'disk space in byte',
>  `type` varchar(32) COMMENT 'inheritted by who?',
>  `tags` varchar(4096) COMMENT 'comma separated tags about the disk_offering',
>  `recreatable` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'The root disk 
> is always recreatable',
>  `use_local_storage` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 
> 'Indicates whether local storage pools should be used',
>  `unique_name` varchar(32) UNIQUE COMMENT 'unique name',
>  `system_use` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'is this 
> offering for system used only',
>  `customized` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT '0 implies not 
> customized by default',
>  `removed` datetime COMMENT 'date removed',
>  `created` datetime COMMENT 'date the disk offering was created',
>  `sort_key` int(32) NOT NULL default 0 COMMENT 'sort key used for customising 
> sort method',
>  PRIMARY KEY  (`id`),
>  INDEX `i_disk_offering__removed`(`removed`),
>  CONSTRAINT `uc_disk_offering__uuid` UNIQUE (`uuid`)
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
> 
> 
> And this is in my DB
> 
> mysql> describe disk_offering;
> +---+-+--+-+-++
> | Field | Type| Null | Key | Default | Extra  
> |
> +---+-+--+-+-++
> | id| bigint(20) unsigned | NO   | PRI | NULL| 
> auto_increment |
> | domain_id | bigint(20) unsigned | YES  | | NULL|
> |
> | name  | varchar(255)| NO   | | NULL|
> |
> | uuid  | varchar(40) | YES  | UNI | NULL|
> |
> | display_text  | varchar(4096)   | YES  | | NULL|
> |
> | disk_size | bigint(20) unsigned | NO   | | NULL|
> |
> | type  | varchar(32) | YES  | | NULL|
> |
> | tags  | varchar(4096)   | YES  | | NULL|
> |
> | recreatable   | tinyint(1) unsigned | NO   | | 0   |
> |
> | use_local_storage | tinyint(1) unsigned | NO   | | 0   |
> |
> | unique_name   | varchar(32) | YES  | UNI | NULL|
> |
> | system_use| tinyint(1) unsigned | NO   | | 0   |
> |
> | customized|

Re: Error while running master

Is this change going in 4.3? Is so then the Alter table I guess should 
be in schema-421to430.sql. I don't see a schema-430to440.sql though. 
How deploydb read the files? Does it go through all the

schema files or does it pick the latest one?


Thanks,
-Syed


On Wed 20 Nov 2013 03:24:37 PM EST, Wei ZHOU wrote:

Wido committed 1edaa36cc68e845a42339d5f267d49c82343aefb today.
try after "ALTER TABLE  disk_offering ADD COLUMN cache_mode varchar(20)"
I do not know which schema file should be inserted into,
schema-421to430.sql or schema-430to440.sql ?

2013/11/20 Syed Ahmed 


Hi All,

I am facing the following error when running the latest master. I have
done a clean compile and have dropped and created the db again.

[WARNING] Nested in org.springframework.context.ApplicationContextException:
Failed to start bean 'cloudStackLifeCycle'; nested exception is
com.cloud.utils.exception.CloudRuntimeException: DB Exception on:
com.mysql.jdbc.JDBC4PreparedStatement@538a1556: SELECT disk_offering.id,
disk_offering.domain_id, disk_offering.unique_name, disk_offering.name,
disk_offering.display_text, disk_offering.disk_size, disk_offering.tags,
disk_offering.type, disk_offering.removed, disk_offering.created,
disk_offering.recreatable, disk_offering.use_local_storage,
disk_offering.system_use, disk_offering.customized, disk_offering.uuid,
disk_offering.customized_iops, disk_offering.min_iops,
disk_offering.max_iops, disk_offering.sort_key,
disk_offering.bytes_read_rate, disk_offering.bytes_write_rate,
disk_offering.iops_read_rate, disk_offering.iops_write_rate,
disk_offering.cache_mode, disk_offering.display_offering,
disk_offering.state, disk_offering.hv_ss_reserve, service_offering.cpu,
service_offering.speed, service_offering.ram_size,
service_offering.nw_rate, service_offering.mc_rate,
service_offering.ha_enabled, service_offering.limit_cpu_use,
service_offering.is_volatile, service_offering.host_tag,
service_offering.default_use, service_offering.vm_type,
service_offering.sort_key, service_offering.deployment_planner FROM
service_offering INNER JOIN disk_offering ON service_offering.id=disk_
offering.id  WHERE disk_offering.type='Service' AND
disk_offering.unique_name = _binary'Cloud.Com-Small Instance'  AND
disk_offering.system_use = 1 AND disk_offering.removed IS NULL :
com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Unknown column
'disk_offering.cache_mode' in 'field list'


This is the definition of disk_offering from create-schema.sql

CREATE TABLE `cloud`.`disk_offering` (
   `id` bigint unsigned NOT NULL auto_increment,
   `domain_id` bigint unsigned,
   `name` varchar(255) NOT NULL,
   `uuid` varchar(40),
   `display_text` varchar(4096) NULL COMMENT 'Descrianaption text set by
the admin for display purpose only',
   `disk_size` bigint unsigned NOT NULL COMMENT 'disk space in byte',
   `type` varchar(32) COMMENT 'inheritted by who?',
   `tags` varchar(4096) COMMENT 'comma separated tags about the
disk_offering',
   `recreatable` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'The root
disk is always recreatable',
   `use_local_storage` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT
'Indicates whether local storage pools should be used',
   `unique_name` varchar(32) UNIQUE COMMENT 'unique name',
   `system_use` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'is this
offering for system used only',
   `customized` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT '0 implies
not customized by default',
   `removed` datetime COMMENT 'date removed',
   `created` datetime COMMENT 'date the disk offering was created',
   `sort_key` int(32) NOT NULL default 0 COMMENT 'sort key used for
customising sort method',
   PRIMARY KEY  (`id`),
   INDEX `i_disk_offering__removed`(`removed`),
   CONSTRAINT `uc_disk_offering__uuid` UNIQUE (`uuid`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;


And this is in my DB

mysql> describe disk_offering;
+---+-+--+-+
-++
| Field | Type| Null | Key | Default | Extra
|
+---+-+--+-+
-++
| id| bigint(20) unsigned | NO   | PRI | NULL|
auto_increment |
| domain_id | bigint(20) unsigned | YES  | | NULL|
|
| name  | varchar(255)| NO   | | NULL|
|
| uuid  | varchar(40) | YES  | UNI | NULL|
|
| display_text  | varchar(4096)   | YES  | | NULL|
|
| disk_size | bigint(20) unsigned | NO   | | NULL|
|
| type  | varchar(32) | YES  | | NULL|
|
| tags  | varchar(4096)   | YES  | | NULL|
|
| recreatable   | tinyint(1) unsigned | NO   | | 0   |
|
| use_local_storage | tinyint(1) unsigned | NO   | | 0   |
|
| unique_name   | varchar(32) | YES  | UNI | NULL|

Re: Error while running master

2013-11-20 Thread Wei ZHOU

Wido committed 1edaa36cc68e845a42339d5f267d49c82343aefb today.
try after "ALTER TABLE  disk_offering ADD COLUMN cache_mode varchar(20)"
I do not know which schema file should be inserted into,
schema-421to430.sql or schema-430to440.sql ?

2013/11/20 Syed Ahmed 

> Hi All,
>
> I am facing the following error when running the latest master. I have
> done a clean compile and have dropped and created the db again.
>
> [WARNING] Nested in org.springframework.context.ApplicationContextException:
> Failed to start bean 'cloudStackLifeCycle'; nested exception is
> com.cloud.utils.exception.CloudRuntimeException: DB Exception on:
> com.mysql.jdbc.JDBC4PreparedStatement@538a1556: SELECT disk_offering.id,
> disk_offering.domain_id, disk_offering.unique_name, disk_offering.name,
> disk_offering.display_text, disk_offering.disk_size, disk_offering.tags,
> disk_offering.type, disk_offering.removed, disk_offering.created,
> disk_offering.recreatable, disk_offering.use_local_storage,
> disk_offering.system_use, disk_offering.customized, disk_offering.uuid,
> disk_offering.customized_iops, disk_offering.min_iops,
> disk_offering.max_iops, disk_offering.sort_key,
> disk_offering.bytes_read_rate, disk_offering.bytes_write_rate,
> disk_offering.iops_read_rate, disk_offering.iops_write_rate,
> disk_offering.cache_mode, disk_offering.display_offering,
> disk_offering.state, disk_offering.hv_ss_reserve, service_offering.cpu,
> service_offering.speed, service_offering.ram_size,
> service_offering.nw_rate, service_offering.mc_rate,
> service_offering.ha_enabled, service_offering.limit_cpu_use,
> service_offering.is_volatile, service_offering.host_tag,
> service_offering.default_use, service_offering.vm_type,
> service_offering.sort_key, service_offering.deployment_planner FROM
> service_offering INNER JOIN disk_offering ON service_offering.id=disk_
> offering.id  WHERE disk_offering.type='Service' AND
> disk_offering.unique_name = _binary'Cloud.Com-Small Instance'  AND
> disk_offering.system_use = 1 AND disk_offering.removed IS NULL :
> com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Unknown column
> 'disk_offering.cache_mode' in 'field list'
>
>
> This is the definition of disk_offering from create-schema.sql
>
> CREATE TABLE `cloud`.`disk_offering` (
>   `id` bigint unsigned NOT NULL auto_increment,
>   `domain_id` bigint unsigned,
>   `name` varchar(255) NOT NULL,
>   `uuid` varchar(40),
>   `display_text` varchar(4096) NULL COMMENT 'Descrianaption text set by
> the admin for display purpose only',
>   `disk_size` bigint unsigned NOT NULL COMMENT 'disk space in byte',
>   `type` varchar(32) COMMENT 'inheritted by who?',
>   `tags` varchar(4096) COMMENT 'comma separated tags about the
> disk_offering',
>   `recreatable` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'The root
> disk is always recreatable',
>   `use_local_storage` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT
> 'Indicates whether local storage pools should be used',
>   `unique_name` varchar(32) UNIQUE COMMENT 'unique name',
>   `system_use` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'is this
> offering for system used only',
>   `customized` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT '0 implies
> not customized by default',
>   `removed` datetime COMMENT 'date removed',
>   `created` datetime COMMENT 'date the disk offering was created',
>   `sort_key` int(32) NOT NULL default 0 COMMENT 'sort key used for
> customising sort method',
>   PRIMARY KEY  (`id`),
>   INDEX `i_disk_offering__removed`(`removed`),
>   CONSTRAINT `uc_disk_offering__uuid` UNIQUE (`uuid`)
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
>
>
> And this is in my DB
>
> mysql> describe disk_offering;
> +---+-+--+-+
> -++
> | Field | Type| Null | Key | Default | Extra
>|
> +---+-+--+-+
> -++
> | id| bigint(20) unsigned | NO   | PRI | NULL|
> auto_increment |
> | domain_id | bigint(20) unsigned | YES  | | NULL|
>|
> | name  | varchar(255)| NO   | | NULL|
>|
> | uuid  | varchar(40) | YES  | UNI | NULL|
>|
> | display_text  | varchar(4096)   | YES  | | NULL|
>|
> | disk_size | bigint(20) unsigned | NO   | | NULL|
>|
> | type  | varchar(32) | YES  | | NULL|
>|
> | tags  | varchar(4096)   | YES  | | NULL|
>|
> | recreatable   | tinyint(1) unsigned | NO   | | 0   |
>|
> | use_local_storage | tinyint(1) unsigned | NO   | | 0   |
>|
> | unique_name   | varchar(32) | YES  | UNI | NULL|
>|
> | system_use| tinyint(1) unsigned | NO   | | 0   |
>|
> | customized| tinyint(1) unsigned | NO   | | 0   |
>

Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15725/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-5220
https://issues.apache.org/jira/browse/CLOUDSTACK-5220


Repository: cloudstack-git


Description
---

CLOUDSTACK-5022: NullPointerException when invalid zone is passed into 
UsageEventUtils

Updated UsageEventUtils code to not blow up when an invalid zone ID is passed 
in. Now will still generate usage event but leaving out zone UUID.


Diffs
-

  engine/components-api/src/com/cloud/event/UsageEventUtils.java a4be4dd 

Diff: https://reviews.apache.org/r/15725/diff/


Testing
---

built on master


Thanks,

David Grizzanti

Error while running master


Hi All,

I am facing the following error when running the latest master. I have 
done a clean compile and have dropped and created the db again.


[WARNING] Nested in 
org.springframework.context.ApplicationContextException: Failed to start 
bean 'cloudStackLifeCycle'; nested exception is 
com.cloud.utils.exception.CloudRuntimeException: DB Exception on: 
com.mysql.jdbc.JDBC4PreparedStatement@538a1556: SELECT disk_offering.id, 
disk_offering.domain_id, disk_offering.unique_name, disk_offering.name, 
disk_offering.display_text, disk_offering.disk_size, disk_offering.tags, 
disk_offering.type, disk_offering.removed, disk_offering.created, 
disk_offering.recreatable, disk_offering.use_local_storage, 
disk_offering.system_use, disk_offering.customized, disk_offering.uuid, 
disk_offering.customized_iops, disk_offering.min_iops, 
disk_offering.max_iops, disk_offering.sort_key, 
disk_offering.bytes_read_rate, disk_offering.bytes_write_rate, 
disk_offering.iops_read_rate, disk_offering.iops_write_rate, 
disk_offering.cache_mode, disk_offering.display_offering, 
disk_offering.state, disk_offering.hv_ss_reserve, service_offering.cpu, 
service_offering.speed, service_offering.ram_size, 
service_offering.nw_rate, service_offering.mc_rate, 
service_offering.ha_enabled, service_offering.limit_cpu_use, 
service_offering.is_volatile, service_offering.host_tag, 
service_offering.default_use, service_offering.vm_type, 
service_offering.sort_key, service_offering.deployment_planner FROM 
service_offering INNER JOIN disk_offering ON 
service_offering.id=disk_offering.id  WHERE disk_offering.type='Service' 
AND disk_offering.unique_name = _binary'Cloud.Com-Small Instance'  AND 
disk_offering.system_use = 1 AND disk_offering.removed IS NULL :
com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Unknown 
column 'disk_offering.cache_mode' in 'field list'



This is the definition of disk_offering from create-schema.sql

CREATE TABLE `cloud`.`disk_offering` (
  `id` bigint unsigned NOT NULL auto_increment,
  `domain_id` bigint unsigned,
  `name` varchar(255) NOT NULL,
  `uuid` varchar(40),
  `display_text` varchar(4096) NULL COMMENT 'Descrianaption text set by the 
admin for display purpose only',
  `disk_size` bigint unsigned NOT NULL COMMENT 'disk space in byte',
  `type` varchar(32) COMMENT 'inheritted by who?',
  `tags` varchar(4096) COMMENT 'comma separated tags about the disk_offering',
  `recreatable` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'The root disk 
is always recreatable',
  `use_local_storage` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'Indicates 
whether local storage pools should be used',
  `unique_name` varchar(32) UNIQUE COMMENT 'unique name',
  `system_use` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT 'is this offering 
for system used only',
  `customized` tinyint(1) unsigned NOT NULL DEFAULT 0 COMMENT '0 implies not 
customized by default',
  `removed` datetime COMMENT 'date removed',
  `created` datetime COMMENT 'date the disk offering was created',
  `sort_key` int(32) NOT NULL default 0 COMMENT 'sort key used for customising 
sort method',
  PRIMARY KEY  (`id`),
  INDEX `i_disk_offering__removed`(`removed`),
  CONSTRAINT `uc_disk_offering__uuid` UNIQUE (`uuid`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;


And this is in my DB

mysql> describe disk_offering;
+---+-+--+-+-++
| Field | Type| Null | Key | Default | Extra
  |
+---+-+--+-+-++
| id| bigint(20) unsigned | NO   | PRI | NULL| 
auto_increment |
| domain_id | bigint(20) unsigned | YES  | | NULL|  
  |
| name  | varchar(255)| NO   | | NULL|  
  |
| uuid  | varchar(40) | YES  | UNI | NULL|  
  |
| display_text  | varchar(4096)   | YES  | | NULL|  
  |
| disk_size | bigint(20) unsigned | NO   | | NULL|  
  |
| type  | varchar(32) | YES  | | NULL|  
  |
| tags  | varchar(4096)   | YES  | | NULL|  
  |
| recreatable   | tinyint(1) unsigned | NO   | | 0   |  
  |
| use_local_storage | tinyint(1) unsigned | NO   | | 0   |  
  |
| unique_name   | varchar(32) | YES  | UNI | NULL|  
  |
| system_use| tinyint(1) unsigned | NO   | | 0   |  
  |
| customized| tinyint(1) unsigned | NO   | | 0   |  
  |
| removed   | datetime| YES  | MUL | NULL|  
  |
| created   | datetime| YES  | | NULL|  
  |
| sort_key  | int(32) | NO   | | 0   |  
  |
| display_offering  | tinyint(1)  | NO   |

Re: Review Request 15722: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (4.2.0)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15722/
---

(Updated Nov. 20, 2013, 7:54 p.m.)


Review request for cloudstack.


Summary (updated)
-

CLOUDSTACK-5022: NullPointerException when invalid zone is passed into 
UsageEventUtils (4.2.0)


Bugs: CLOUDSTACK-5022
https://issues.apache.org/jira/browse/CLOUDSTACK-5022


Repository: cloudstack-git


Description
---

CLOUDSTACK-5022: NullPointerException when invalid zone is passed into 
UsageEventUtils

Updated UsageEventUtils code to not blow up when an invalid zone ID is passed 
in. Now will still generate usage event but leaving out zone UUID.

UsageEventUtils has been moved on master, so a separate review will be 
submitted for that fix.


Diffs
-

  server/src/com/cloud/event/UsageEventUtils.java 2e42229 

Diff: https://reviews.apache.org/r/15722/diff/


Testing
---

Tested on 4.2.0


Thanks,

David Grizzanti

Review Request 15722: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15722/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-5022
https://issues.apache.org/jira/browse/CLOUDSTACK-5022


Repository: cloudstack-git


Description
---

CLOUDSTACK-5022: NullPointerException when invalid zone is passed into 
UsageEventUtils

Updated UsageEventUtils code to not blow up when an invalid zone ID is passed 
in. Now will still generate usage event but leaving out zone UUID.

UsageEventUtils has been moved on master, so a separate review will be 
submitted for that fix.


Diffs
-

  server/src/com/cloud/event/UsageEventUtils.java 2e42229 

Diff: https://reviews.apache.org/r/15722/diff/


Testing
---

Tested on 4.2.0


Thanks,

David Grizzanti

Re: Entity UUID and Type missing on ActionEvent event notifications

2013-11-20 Thread Nitin Mehta

David - CallContext gets created during the entry point of the API.
I haven't had the chance to completely investigate but I am hoping that
you can push the UUID then or on completion of the API (in case where you
are creating the actual resource).
See if that works else there is no other way out.

Another feedback on Rabbit MQ would be to push the list of all the first
class objects (UUIDs) that are affected  in the event description if
possible. Say user invokes attachVolume to a vm. It would be good to
always push vm uuid.
Just putting in the volume uuid necessitates another call to CS and also
that this was attach volume operation.

Thanks,
-Nitin  

On 20/11/13 8:23 AM, "David Grizzanti"  wrote:

>Thanks for the feedback and info on the existing bug filed for this.
>
>Nitin - I was originally thinking along the lines of what Murali has
>recently commented (i.e. adding Entity Details in the UserContext in all
>the places where an Action Event is generated).  The particular case I
>was using this for when I found the issue was for creating a network,
>which is not an async job.  The AsyncJobManager I believe it generating a
>different type of event that what I was originally looking at.
>
>Let me know your thoughts.
>
>Thanks
>
>-- 
>David Grizzanti
>Software Engineer
>Sungard Availability Services
>
>e: david.grizza...@sungard.com
>w: 215.446.1431
>c: 570.575.0315
>
>On November 20, 2013 at 2:45:50 AM, Murali Reddy
>(murali.re...@citrix.com) wrote:
>
>
>
>On 20/11/13 2:15 AM, "David Grizzanti" 
>wrote:  
>
>>Hi All,  
>>  
>>I noticed that the event messages going to rabbitmq of type
>>"ActionEvent"  
>>are missing any reference to the entity Id/UUID. Was this omission
>>intentional? Poking through the code, I was able to find that adding the
>> 
>>information on to the event is fairly straightforward (albeit a bit
>>tedious). Does anyone have any objections to updating these event types
>>with this information? I can file the appropriate Jira, but wanted to
>>check in with the list first to get opinions.
>
>David,  
>
>Omission is not intentional. Please see [1] for earlier discussion. There
> 
>is a bug opened as well[2].
>
>If you see ActionEventUtils, there is code that gets 'entity type' and
>'entity uuid' from the CallContext and fills the details on the message
>published. I added this as generic mechanism. Unfortunately, there is not
> 
>a single place where if you populate the entity type and uuid in the call
> 
>context then things would fall in place. So its tedious job of adding the
> 
>entity type and uuid details to the call context to all the methods
>annotated with 'ActionEvent', but other wise it is a much needed fix.
>
>[1]  
>http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201306.mbox/%3CCDF
>1  
>db6a.424d9%25murali.re...@citrix.com%3E
>[2] https://issues.apache.org/jira/browse/CLOUDSTACK-3190
>
>
>> Example event for network creation below.
>>  
>>Thanks  
>>  
>>--  
>>@source="management-server", @type="ActionEvent",
>>@action="NETWORK-CREATE", @resource_type="Network", @resource_id="*">
>>{  
>> "status": "Completed",
>> "event": "NETWORK.CREATE",
>> "account": "6d836cf8-47cd-11e3-a130-606d02c0c082",
>> "user": "6d838544-47cd-11e3-a130-606d02c0c082"
>>}  
>>  
>>--  
>>David Grizzanti  
>>Software Engineer
>>Sungard Availability Services
>>  
>>e: david.grizza...@sungard.com
>>w: 215.446.1431  
>>c: 570.575.0315  
>
>
>

Re: [MERGE] Reformat of the source code....

2013-11-20 Thread Sheng Yang

FYI:

coding convention at:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions

The updated column limit is: "File content must be kept within 180 columns"

--Sheng


On Wed, Nov 20, 2013 at 7:46 AM, Alex Huang  wrote:

> The branch is called reformat if you like to check it.
>
> --Alex
>
> > -Original Message-
> > From: Alex Huang [mailto:alex.hu...@citrix.com]
> > Sent: Wednesday, November 20, 2013 7:15 AM
> > To: dev@cloudstack.apache.org
> > Subject: [MERGE] Reformat of the source code
> >
> > Taking advantage of the CCC happening and 4.3 just being branched, I did
> a
> > reformat of the entire source base.  It converts all tabs to spaces and
> rejoin
> > lines that were split due to the 80 column limit.  I also added
> checkstyle to
> > maven build.  There may be things missing here and there but overall
> should
> > reduce the number of lines in our checkins.
> >
> > It created a massive amount of change of course but it all compiles and
> starts
> > up.  Any concerns about met checking this in to master?  I'll wait 24
> hours for
> > this merge request since we've talked about this before.
> >
> > --Alex
>

Re: A question on vm migrations when hosts are set into a maintenance mode.

2013-11-20 Thread Alex Ough

Hi Alex,

It looks like you moved the 'ExecuteInSequence' to the vm level from the
management server, which seems to be ok, but at this time I cannot test it
because when I try to start up the management server, it fails because of
database schema error, which is 'Unknown column 'disk_offering.cache_mode'
in 'field list' even if I re-built the database.

Is the schema change part of your changes or something other developer
changed?

If that is from any other developer, can you fix this?

Thanks
Alex Ough




On Tue, Nov 19, 2013 at 7:25 PM, Alex Huang  wrote:

>  Alex,
>
>
>
> Can you do a pull from master and see if my fix fits your needs.
> Unfortunately, I’m on the road and couldn’t do an actual test of it.
>
>
>
> --Alex
>
>
>
> *From:* Alex Huang
> *Sent:* Tuesday, November 19, 2013 4:45 AM
> *To:* 'Alex Ough'; dev@cloudstack.apache.org
> *Subject:* RE: A question on vm migrations when hosts are set into a
> maintenance mode.
>
>
>
> Alex,
>
>
>
> Sorry for the late reply.  Been travelling the last couple of weeks.  I’ll
> look into this today.
>
>
>
> --Alex
>
>
>
> *From:* Alex Ough [mailto:alex.o...@sungard.com ]
> *Sent:* Monday, November 18, 2013 6:17 AM
> *To:* dev@cloudstack.apache.org
> *Cc:* Alex Huang
> *Subject:* Re: A question on vm migrations when hosts are set into a
> maintenance mode.
>
>
>
> Thank Parasanna & Sebastien,
>
> I also got his email and sent an email.
>
> Waiting for his reply...
>
>
>
> Thanks
>
> Alex Ough
>
>
>
> On Sat, Nov 16, 2013 at 3:05 PM, Sebastien Goasguen 
> wrote:
>
> cc Alex Huang to get his attention:
>
>
>
> On Nov 15, 2013, at 10:17 PM, Prasanna Santhanam  wrote:
>
> > Alex, Could you just do a git blame on the file and copy the emails of
> > people who changed that bit of code? They may be able to help if Cc-ed
> > directly.
> >
> > Thanks,
> >
> > On Fri, Nov 15, 2013 at 01:49:07PM -0600, Alex Ough wrote:
> >> I hate to sending the same emails over and over again, but I really
> need to
> >> finalize this feature to be included in the next code freeze because
> this
> >> feature is very critical in our inside project.
> >>
> >> Anyone who can help, please?
> >> Thanks
> >> Alex Ough
> >>
> >>
> >> On Thu, Nov 14, 2013 at 1:27 PM, Alex Ough 
> wrote:
> >>
> >>> Not sure if Alex Huang checked this, but can anyone help to resolve
> this?
> >>>
> >>> Thanks
> >>> Alex Ough
> >>>
> >>>
> >>> On Wed, Nov 13, 2013 at 11:39 AM, Alex Ough 
> wrote:
> >>>
>  It sounds a little scary...
> 
>  I looked at the history and found these.
> 
>  8/9/ : file moved to engine by Alex Huang
>  9/16 : '_mgmtServer.getExecuteInSequence()' changed to
>  'getExecuteInSequence()' by Alex Huang
> 
> 
>  Hi Alex Huang,
>  I'm not sure if you're aware of this, but can you check this for me?
> 
>  Thanks
>  Alex Ough
> 
> 
> 
>  On Wed, Nov 13, 2013 at 11:18 AM, Marcus Sorensen <
> shadow...@gmail.com>wrote:
> 
> > I'm not sure. I know in the past when I've seen files change
> locations
> > it has also clobbered updates to that file. Someone branched, did the
> > reorganization work, and merged, while in-between the original file
> > changed.
> >
> > On Wed, Nov 13, 2013 at 9:21 AM, Alex Ough 
> > wrote:
> >> All,
> >>
> >> While merging my changes to 4.3 branch, I found that the option,
> >> 'execute.in.sequence.hypervisor.commands' is NOT used in
> > Start/Stop/Copy
> >> commands in 'VirtualMachineManagerImpl.java' any more as below.
> >>
> >>
> >> *StopCommand stop = new StopCommand(vm, getExecuteInSequence());*
> >>
> >> *protected boolean getExecuteInSequence() {*
> >> * return false;*
> >> *}*
> >>
> >> As you see in the above, the function, 'getExecuteInSequence', just
> > returns
> >> false instead of getting the value from the global variable.
> >>
> >> And one more change is that the file has been moved to
> >> 'engine/orchestration/src/com/cloud/vm' from
> 'server/src/com/cloud/vm'.
> >>
> >> Am I missing something related with this or do we stop supporting
> this
> >> option in 4.3?
> >> I'm a little confused, so please help me resolve this.
> >>
> >> Thanks
> >> Alex Ough
> >>
> >>
> >>
> >>
> >> On Tue, Nov 12, 2013 at 4:20 PM, Alex Ough 
> > wrote:
> >>
> >>> Thanks a lot for your confirmation, Marcus.
> >>> I'll create a review request unless anyone has an objection.
> >>>
> >>> Thanks
> >>> Alex Ough
> >>>
> >>>
> >>> On Tue, Nov 12, 2013 at 3:37 PM, Marcus Sorensen <
> shadow...@gmail.com
> >> wrote:
> >>>
>  I have done parallel KVM migrations without issue, it's "supposed
> to
>  work". Really I think it's in the same boat as parallel
> start/stop.
> > It
>  should work, but the config option is there just in case. I think
> we
>  should add it.
> >>

Re: Router requires upgrade. Unable to send command to router Error

2013-11-20 Thread Wei ZHOU

FYI.

I upgraded from 2.2.14 to 4.2.1. The CPVM, SSVM and VRs are working after
running *cloudstack-sysvmadm to recreate.*


2013/11/20 Syed Ahmed 

> +1 Same error. The secondary storage VM and the Console proxy VM seem to
> be coming up alright. I see this error only when starting the virtual
> router which is preventing me from creating any instances.
>
>
> On Wed 20 Nov 2013 11:14:47 AM EST, Will Stevens wrote:
>
>> I am having the same problem.  I got the latest system VMs from:
>> http://jenkins.buildacloud.org/view/master/job/build-systemvm-master/
>> lastSuccessfulBuild/artifact/tools/appliance/dist/
>>
>> Are these the wrong System VM Templates?  If so, where should I get the
>> System VM Templates to make this work again?
>>
>> Thanks,
>>
>> Will
>>
>>
>> On Thu, Nov 7, 2013 at 7:42 PM, Alena Prokharchyk <
>> alena.prokharc...@citrix.com> wrote:
>>
>>  Nitin, I had the same problem, but I fixed it by uploading 4.2 system
>>> templates to my secondary storage. Make sure you have the latest too.
>>>
>>> -alena.
>>>
>>> From: Nitin Mehta mailto:nitin.me...@citrix.com>
>>> >
>>> Reply-To: "dev@cloudstack.apache.org"
>>> <
>>> dev@cloudstack.apache.org>
>>> Date: Thursday, November 7, 2013 4:16 PM
>>> To: "dev@cloudstack.apache.org" <
>>> dev@cloudstack.apache.org>
>>> Subject: Router requires upgrade. Unable to send command to router Error
>>>
>>> Unable to deploy vms in the latest master because of the commit below. Is
>>> anyone noticing this on the latest master.
>>> I checked the code  and there was a commit made recently 3f5b8f which is
>>> where the exception points to.
>>>
>>> WARN  [o.a.c.alerts] (CapacityChecker:ctx-4f1ef01f)  alertType:: 2 //
>>> dataCenterId:: 3 // podId:: 3 // clusterId:: null // message:: System
>>> Alert: Low Available Storage in cluster c3 pod p of availability zone z3
>>> INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-1:ctx-f118d6dc) Add
>>> job-44 into job monitoring
>>> WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-26:ctx-3e786331)
>>> Detecting a change in xstoolsversion for r-6-VM
>>> ERROR [c.c.v.VirtualMachineManagerImpl] (Job-Executor-1:ctx-f118d6dc
>>> ctx-d9a00f18) Failed to start instance
>>> VM[User|VM-4d5d5db2-e5ba-4bbd-b1dc-e749ac42a74c]
>>> com.cloud.utils.exception.CloudRuntimeException: Router requires
>>> upgrade.
>>> Unable to send command to router:6
>>> at
>>> com.cloud.network.router.VirtualNetworkApplianceManager
>>> Impl.sendCommandsToRouter(VirtualNetworkApplianceManagerImpl.java:3567)
>>> at
>>> com.cloud.network.router.VirtualNetworkApplianceManagerImpl$7.execute(
>>> VirtualNetworkApplianceManagerImpl.java:3003)
>>> at
>>> com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(
>>> VirtualNetworkApplianceManagerImpl.java:3848)
>>> at
>>> com.cloud.network.router.VirtualNetworkApplianceManager
>>> Impl.applyDhcpEntry(VirtualNetworkApplianceManagerImpl.java:2995)
>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> at
>>> sun.reflect.NativeMethodAccessorImpl.invoke(
>>> NativeMethodAccessorImpl.java:39)
>>> at
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(
>>> DelegatingMethodAccessorImpl.java:25)
>>>
>>>
>>>
>>
>
>

Re: Entity UUID and Type missing on ActionEvent event notifications

Thanks for the feedback and info on the existing bug filed for this.

Nitin - I was originally thinking along the lines of what Murali has recently 
commented (i.e. adding Entity Details in the UserContext in all the places 
where an Action Event is generated).  The particular case I was using this for 
when I found the issue was for creating a network, which is not an async job.  
The AsyncJobManager I believe it generating a different type of event that what 
I was originally looking at.

Let me know your thoughts.

Thanks

-- 
David Grizzanti
Software Engineer
Sungard Availability Services

e: david.grizza...@sungard.com
w: 215.446.1431
c: 570.575.0315

On November 20, 2013 at 2:45:50 AM, Murali Reddy (murali.re...@citrix.com) 
wrote:

On 20/11/13 2:15 AM, "David Grizzanti"  wrote:  

>Hi All,  
>  
>I noticed that the event messages going to rabbitmq of type "ActionEvent"  
>are missing any reference to the entity Id/UUID. Was this omission  
>intentional? Poking through the code, I was able to find that adding the  
>information on to the event is fairly straightforward (albeit a bit  
>tedious). Does anyone have any objections to updating these event types  
>with this information? I can file the appropriate Jira, but wanted to  
>check in with the list first to get opinions.  

David,  

Omission is not intentional. Please see [1] for earlier discussion. There  
is a bug opened as well[2].  

If you see ActionEventUtils, there is code that gets 'entity type' and  
'entity uuid' from the CallContext and fills the details on the message  
published. I added this as generic mechanism. Unfortunately, there is not  
a single place where if you populate the entity type and uuid in the call  
context then things would fall in place. So its tedious job of adding the  
entity type and uuid details to the call context to all the methods  
annotated with 'ActionEvent', but other wise it is a much needed fix.  

[1]  
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201306.mbox/%3CCDF1  
db6a.424d9%25murali.re...@citrix.com%3E  
[2] https://issues.apache.org/jira/browse/CLOUDSTACK-3190  

> Example event for network creation below.  
>  
>Thanks  
>  
>--  
>@source="management-server", @type="ActionEvent",  
>@action="NETWORK-CREATE", @resource_type="Network", @resource_id="*">  
>{  
> "status": "Completed",  
> "event": "NETWORK.CREATE",  
> "account": "6d836cf8-47cd-11e3-a130-606d02c0c082",  
> "user": "6d838544-47cd-11e3-a130-606d02c0c082"  
>}  
>  
>--  
>David Grizzanti  
>Software Engineer  
>Sungard Availability Services  
>  
>e: david.grizza...@sungard.com  
>w: 215.446.1431  
>c: 570.575.0315

Re: Router requires upgrade. Unable to send command to router Error

+1 Same error. The secondary storage VM and the Console proxy VM seem 
to be coming up alright. I see this error only when starting the 
virtual router which is preventing me from creating any instances.


On Wed 20 Nov 2013 11:14:47 AM EST, Will Stevens wrote:

I am having the same problem.  I got the latest system VMs from:
http://jenkins.buildacloud.org/view/master/job/build-systemvm-master/lastSuccessfulBuild/artifact/tools/appliance/dist/

Are these the wrong System VM Templates?  If so, where should I get the
System VM Templates to make this work again?

Thanks,

Will


On Thu, Nov 7, 2013 at 7:42 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:


Nitin, I had the same problem, but I fixed it by uploading 4.2 system
templates to my secondary storage. Make sure you have the latest too.

-alena.

From: Nitin Mehta mailto:nitin.me...@citrix.com>>
Reply-To: "dev@cloudstack.apache.org" <
dev@cloudstack.apache.org>
Date: Thursday, November 7, 2013 4:16 PM
To: "dev@cloudstack.apache.org" <
dev@cloudstack.apache.org>
Subject: Router requires upgrade. Unable to send command to router Error

Unable to deploy vms in the latest master because of the commit below. Is
anyone noticing this on the latest master.
I checked the code  and there was a commit made recently 3f5b8f which is
where the exception points to.

WARN  [o.a.c.alerts] (CapacityChecker:ctx-4f1ef01f)  alertType:: 2 //
dataCenterId:: 3 // podId:: 3 // clusterId:: null // message:: System
Alert: Low Available Storage in cluster c3 pod p of availability zone z3
INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-1:ctx-f118d6dc) Add
job-44 into job monitoring
WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-26:ctx-3e786331)
Detecting a change in xstoolsversion for r-6-VM
ERROR [c.c.v.VirtualMachineManagerImpl] (Job-Executor-1:ctx-f118d6dc
ctx-d9a00f18) Failed to start instance
VM[User|VM-4d5d5db2-e5ba-4bbd-b1dc-e749ac42a74c]
com.cloud.utils.exception.CloudRuntimeException: Router requires upgrade.
Unable to send command to router:6
at
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.sendCommandsToRouter(VirtualNetworkApplianceManagerImpl.java:3567)
at
com.cloud.network.router.VirtualNetworkApplianceManagerImpl$7.execute(VirtualNetworkApplianceManagerImpl.java:3003)
at
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkApplianceManagerImpl.java:3848)
at
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyDhcpEntry(VirtualNetworkApplianceManagerImpl.java:2995)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

Re: Router requires upgrade. Unable to send command to router Error

2013-11-20 Thread Will Stevens

I am having the same problem.  I got the latest system VMs from:
http://jenkins.buildacloud.org/view/master/job/build-systemvm-master/lastSuccessfulBuild/artifact/tools/appliance/dist/

Are these the wrong System VM Templates?  If so, where should I get the
System VM Templates to make this work again?

Thanks,

Will


On Thu, Nov 7, 2013 at 7:42 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

> Nitin, I had the same problem, but I fixed it by uploading 4.2 system
> templates to my secondary storage. Make sure you have the latest too.
>
> -alena.
>
> From: Nitin Mehta mailto:nitin.me...@citrix.com>>
> Reply-To: "dev@cloudstack.apache.org" <
> dev@cloudstack.apache.org>
> Date: Thursday, November 7, 2013 4:16 PM
> To: "dev@cloudstack.apache.org" <
> dev@cloudstack.apache.org>
> Subject: Router requires upgrade. Unable to send command to router Error
>
> Unable to deploy vms in the latest master because of the commit below. Is
> anyone noticing this on the latest master.
> I checked the code  and there was a commit made recently 3f5b8f which is
> where the exception points to.
>
> WARN  [o.a.c.alerts] (CapacityChecker:ctx-4f1ef01f)  alertType:: 2 //
> dataCenterId:: 3 // podId:: 3 // clusterId:: null // message:: System
> Alert: Low Available Storage in cluster c3 pod p of availability zone z3
> INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-1:ctx-f118d6dc) Add
> job-44 into job monitoring
> WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-26:ctx-3e786331)
> Detecting a change in xstoolsversion for r-6-VM
> ERROR [c.c.v.VirtualMachineManagerImpl] (Job-Executor-1:ctx-f118d6dc
> ctx-d9a00f18) Failed to start instance
> VM[User|VM-4d5d5db2-e5ba-4bbd-b1dc-e749ac42a74c]
> com.cloud.utils.exception.CloudRuntimeException: Router requires upgrade.
> Unable to send command to router:6
> at
> com.cloud.network.router.VirtualNetworkApplianceManagerImpl.sendCommandsToRouter(VirtualNetworkApplianceManagerImpl.java:3567)
> at
> com.cloud.network.router.VirtualNetworkApplianceManagerImpl$7.execute(VirtualNetworkApplianceManagerImpl.java:3003)
> at
> com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkApplianceManagerImpl.java:3848)
> at
> com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyDhcpEntry(VirtualNetworkApplianceManagerImpl.java:2995)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>
>

RE: [MERGE] Reformat of the source code....

The branch is called reformat if you like to check it.

--Alex

> -Original Message-
> From: Alex Huang [mailto:alex.hu...@citrix.com]
> Sent: Wednesday, November 20, 2013 7:15 AM
> To: dev@cloudstack.apache.org
> Subject: [MERGE] Reformat of the source code
> 
> Taking advantage of the CCC happening and 4.3 just being branched, I did a
> reformat of the entire source base.  It converts all tabs to spaces and rejoin
> lines that were split due to the 80 column limit.  I also added checkstyle to
> maven build.  There may be things missing here and there but overall should
> reduce the number of lines in our checkins.
> 
> It created a massive amount of change of course but it all compiles and starts
> up.  Any concerns about met checking this in to master?  I'll wait 24 hours 
> for
> this merge request since we've talked about this before.
> 
> --Alex

Re: Request: Help designing a 'powered by' logo for CloudStack

2013-11-20 Thread Kirk Jantzer

I'm not a graphic designer, and I don't have vector software, but here is
my very simple idea :-) http://i.imgur.com/WTNAIoG.png


Regards,

Kirk Jantzer
http://about.me/kirkjantzer


On Fri, Nov 15, 2013 at 3:06 PM, Robyn Bergeron  wrote:

>
>
> - Original Message -
> > From: "David Nalley" 
> > To: market...@cloudstack.apache.org, dev@cloudstack.apache.org
> > Sent: Friday, November 15, 2013 10:56:15 AM
> > Subject: Request: Help designing a 'powered by' logo for CloudStack
> >
> > Hi folks:
> >
> > If you happen to have some graphical design talent (I have none) I
> > have a great opportunity for you :)
> >
> > CloudStack needs a 'powered by' logo that is easy to consume, and is
> > also attractive.
> >
> > A couple examples of powered by logos:
> >
> > http://tomcat.apache.org/images/tomcat-power.gif
> >
> https://cwiki.apache.org/confluence/download/attachments/80899/mahout-logo-poweredby-100.png?version=1&modificationDate=1312880703000
> >
> https://netbeans.org/images_www/screenshots/6.0/baseIDE_ant_powered_150px.png
> >
> > A couple of constraints:
> > * Please don't use the Apache feather. (we could, but lets not; it
> > will make life simpler)
> > * Please try and produce a vector format as source (this allows us to
> > scale/etc)
> > * Because this will become a trademark (which is vastly different that
> > copyright) - we will likely need some explicit email agreement around
> > trademarks rights for the image. (I promise, it isn't as scary as that
> > sentence makes it out to be.)
>
> I also lack design skills, but am always willing to throw out ideas :)
>
> Maybe incorporate the cloud monkey into something where he is turning a
> gear of some sort on a machine that has little clouds coming out of it? I'm
> not quite sure how to turn that into "powered by" exactly... but just a
> thought. (The monkey is super cute.)
>
> -robyn
>
>
> >
> > Anyone interested?
> >
> > --David
> >
>

[MERGE] Reformat of the source code....

Taking advantage of the CCC happening and 4.3 just being branched, I did a 
reformat of the entire source base.  It converts all tabs to spaces and rejoin 
lines that were split due to the 80 column limit.  I also added checkstyle to 
maven build.  There may be things missing here and there but overall should 
reduce the number of lines in our checkins.

It created a massive amount of change of course but it all compiles and starts 
up.  Any concerns about met checking this in to master?  I'll wait 24 hours for 
this merge request since we've talked about this before.

--Alex

Re: POST in deployvirtual machine

2013-11-20 Thread Sebastien Goasguen


On Nov 20, 2013, at 7:54 AM, Suresh Sadhu  wrote:

> Yes we can use POST request in deployvirtualmachine api, pass method=POST to 
> overcome the get limit
> 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+cases+for+DeployVirtualMachine+userdata+enhancements
> 
> regards
> sadhu
> 

thanks, found the answer, but it only works with 4.2

> 
> 
> 
> 
> 
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com] 
> Sent: 20 November 2013 16:54
> To: dev@cloudstack.apache.org
> Subject: POST in deployvirtual machine
> 
> Hi,
> 
> Can we use post for every case of deployVirtualMachine ?
> 
> it seems we can pass userdata via get but it limits us to 2KB. To get up to 
> 32KB we need to move to POST requests.
> 
> Just wondering if we can use POST in every case...
> 
> -sebastien

RE: Potential bug with CS 4.1.1 to 4.2.1 db upgrade

2013-11-20 Thread Musayev, Ilya

This statement if fairly safe IMHO. We just catch a corner case if table does 
not exists.

It warrants a fix.

> -Original Message-
> From: Milamber [mailto:milam...@apache.org]
> Sent: Wednesday, November 20, 2013 3:37 AM
> To: dev@cloudstack.apache.org
> Subject: Potential bug with CS 4.1.1 to 4.2.1 db upgrade
> 
> Hello,
> 
> Yesterday, I've upgraded a CloudStack 4.1.1 installation to CloudStack 4.2.1,
> I've received this error when I started the management service the first time
> after upgrade (below).
> 
> To fix it, I've changed this line in schema-410to420.sql CREATE TABLE
> `cloud`.`vm_snapshots` ( to CREATE TABLE IF NOT EXISTS
> `cloud`.`vm_snapshots` (
> 
> 
> And I've restored the cloud db backup from the mysql dump executed just
> before upgrade, and (re-)start the management service.
> All is good after.
> 
> I've open this ticket on Jira
> https://issues.apache.org/jira/browse/CLOUDSTACK-5214
> 
> Please confirm that is a bug (or not).
> 
> Milamber
> 
> 
> =
> 2013-11-20 00:12:31,057 INFO  [utils.component.ComponentContext]
> (Timer-1:null) Running SystemIntegrityChecker managementServerNode
> 2013-11-20 00:12:31,057 INFO  [utils.component.ComponentContext]
> (Timer-1:null) Running SystemIntegrityChecker databaseUpgradeChecker
> 2013-11-20 00:12:31,057 INFO  [cloud.upgrade.DatabaseUpgradeChecker]
> (Timer-1:null) Grabbing lock to check for database upgrade.
> 2013-11-20 00:12:31,059 DEBUG [upgrade.dao.VersionDaoImpl]
> (Timer-1:null) Checking to see if the database is at a version before it was 
> the
> version table is created
> 2013-11-20 00:12:31,063 INFO  [cloud.upgrade.DatabaseUpgradeChecker]
> (Timer-1:null) DB version = 4.1.1 Code Version = 4.2.1-SNAPSHOT
> 2013-11-20 00:12:31,063 INFO  [cloud.upgrade.DatabaseUpgradeChecker]
> (Timer-1:null) Database upgrade must be performed from 4.1.1 to 4.2.1-
> SNAPSHOT
> 2013-11-20 00:12:31,064 DEBUG [cloud.upgrade.DatabaseUpgradeChecker]
> (Timer-1:null) Running upgrade Upgrade410to420 to upgrade from
> 4.1.0-4.1.1 to 4.2.0
> 2013-11-20 00:12:31,069 DEBUG [utils.script.Script] (Timer-1:null) Looking for
> db/schema-410to420.sql in the classpath
> 2013-11-20 00:12:31,069 DEBUG [utils.script.Script] (Timer-1:null) System
> resource:
> file:/usr/share/cloudstack-management/setup/db/schema-410to420.sql
> 2013-11-20 00:12:31,069 DEBUG [utils.script.Script] (Timer-1:null) Absolute
> path = /usr/share/cloudstack-management/setup/db/schema-410to420.sql
> []
> 2013-11-20 00:12:32,546 ERROR [utils.db.ScriptRunner] (Timer-1:null)
> Error executing: CREATE TABLE `cloud`.`vm_snapshots` (   `id` bigint(20)
> unsigned NOT NULL auto_increment COMMENT 'Primary Key', `uuid`
> varchar(40) NOT NULL,   `name` varchar(255) NOT NULL, `display_name`
> varchar(255) default NULL,   `description` varchar(255) default NULL,
> `vm_id` bigint(20) unsigned NOT NULL, `account_id` bigint(20) unsigned
> NOT NULL,   `domain_id` bigint(20) unsigned NOT NULL,
> `vm_snapshot_type` varchar(32) default NULL, `state` varchar(32) NOT
> NULL,   `parent` bigint unsigned default NULL,   `current` int(1)
> unsigned default NULL,   `update_count` bigint unsigned NOT NULL DEFAULT
> 0,   `updated` datetime default NULL,   `created` datetime default
> NULL,   `removed` datetime default NULL,   PRIMARY KEY  (`id`),
> CONSTRAINT UNIQUE KEY `uc_vm_snapshots_uuid` (`uuid`),   INDEX
> `vm_snapshots_name` (`name`),   INDEX `vm_snapshots_vm_id` (`vm_id`),
> INDEX `vm_snapshots_account_id` (`account_id`),   INDEX
> `vm_snapshots_display_name` (`display_name`),   INDEX
> `vm_snapshots_removed` (`removed`),   INDEX `vm_snapshots_parent`
> (`parent`),   CONSTRAINT `fk_vm_snapshots_vm_id__vm_instance_id`
> FOREIGN
> KEY `fk_vm_snapshots_vm_id__vm_instance_id` (`vm_id`) REFERENCES
> `vm_instance` (`id`),   CONSTRAINT
> `fk_vm_snapshots_account_id__account_id` FOREIGN KEY
> `fk_vm_snapshots_account_id__account_id` (`account_id`) REFERENCES
> `account` (`id`),   CONSTRAINT `fk_vm_snapshots_domain_id__domain_id`
> FOREIGN KEY `fk_vm_snapshots_domain_id__domain_id` (`domain_id`)
> REFERENCES `domain` (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8
> 2013-11-20 00:12:32,546 ERROR [utils.db.ScriptRunner] (Timer-1:null)
> com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Table
> 'vm_snapshots' already exists
> 2013-11-20 00:12:32,549 ERROR [cloud.upgrade.DatabaseUpgradeChecker]
> (Timer-1:null) Unable to execute upgrade script:
> /usr/share/cloudstack-management/setup/db/schema-410to420.sql
> com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Table
> 'vm_snapshots' already exists
>  at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:193)
>  at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
>  at
> com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeC
> hecker.java:204)
>  at
> com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeCh
> ecker.java:265)
>  at
> com.cloud.upgrade.DatabaseUpgradeChecker.check(Da

Re: Review Request 15572: LDAP import users changes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15572/#review29165
---

Ship it!


Ship It!

- Ian Duffy


On Nov. 15, 2013, 11:50 a.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15572/
> ---
> 
> (Updated Nov. 15, 2013, 11:50 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
> https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added LDAP group name label in add account wizard
> 
> changed the parameter for domain in api importLdapUser from name to UUID
> 
> improved error handling
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 5885bd0 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
>  063db0e 
>   
> plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy
>  0455640 
>   ui/dictionary.jsp 0ccfc23 
>   ui/scripts/accountsWizard.js 70ef082 
>   ui/scripts/docs.js a3151b1 
>   ui/scripts/ui-custom/accountsWizard.js 358e29c 
> 
> Diff: https://reviews.apache.org/r/15572/diff/
> 
> 
> Testing
> ---
> 
> unit testing for all the java changes and manual testing for UI changes is 
> done.
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

RE: POST in deployvirtual machine

2013-11-20 Thread Suresh Sadhu

Yes we can use POST request in deployvirtualmachine api, pass method=POST to 
overcome the get limit

https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+cases+for+DeployVirtualMachine+userdata+enhancements

regards
sadhu






-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: 20 November 2013 16:54
To: dev@cloudstack.apache.org
Subject: POST in deployvirtual machine

Hi,

Can we use post for every case of deployVirtualMachine ?

it seems we can pass userdata via get but it limits us to 2KB. To get up to 
32KB we need to move to POST requests.

Just wondering if we can use POST in every case...

-sebastien

POST in deployvirtual machine

2013-11-20 Thread Sebastien Goasguen

Hi,

Can we use post for every case of deployVirtualMachine ?

it seems we can pass userdata via get but it limits us to 2KB. To get up to 
32KB we need to move to POST requests.

Just wondering if we can use POST in every case...

-sebastien

Review Request 15715: CLOUDSTACK-5215: Correcting and refactoring code related to getting free vlan

2013-11-20 Thread Gaurav Aradhye


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15715/
---

Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-5215
https://issues.apache.org/jira/browse/CLOUDSTACK-5215


Repository: cloudstack-git


Description
---

The function getFreeVlan was used in 3 files separately and it was not checking 
whether the vlan id is already in use by any other network.

Now checking if it is used by any network, else search for another vlan id, 
also moved this function to common.py and made respective changes across 3 
files.


Diffs
-

  test/integration/component/test_shared_networks.py 28468c9 
  test/integration/component/test_vpc_vm_life_cycle.py beb5b99 
  test/integration/component/test_vpc_vms_deployment.py c4811ed 
  tools/marvin/marvin/integration/lib/common.py 6c2bb2a 

Diff: https://reviews.apache.org/r/15715/diff/


Testing
---

Tested is the function works correctly. Ran 2 test cases simultaneously which 
create multiple shared networks.

Log:

Test 1:
==> result.log <==
test_createSharedNetwork_projectSpecific 
(test_shared_networks.TestSharedNetworks)
Test Shared Network with scope project ... skipped 'skip'
test_createSharedNetwork_usedVlan (test_shared_networks.TestSharedNetworks)
Test Shared Network with used vlan 01 ... skipped 'skipped - This is a 
redundant case and also this is causing issue for rest fo the cases '
test_createSharedNetwork_usedVlan2 (test_shared_networks.TestSharedNetworks)
Test Shared Network with used vlan 02 ... skipped 'skip'
test_deployVM_isolatedAndShared (test_shared_networks.TestSharedNetworks)
Test VM deployment in shared and isolated networks ... skipped 'skip'
test_deployVM_multipleSharedNetwork (test_shared_networks.TestSharedNetworks)
Test Vm deployment with multiple shared networks ...
==> client.log <==
2013-11-19 21:40:40,957 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - Admin account created: 
7d379404-9bf3-47aa-a4bc
-0fe77e7455eb
2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - 2360
2013-11-19 21:40:41,004 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - Physical Network found: 
05ef4a90-f9ba-449f-b1b
6-a437e6c4d4dd
2013-11-19 21:40:41,071 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - Shared Network offering created: 
d6b52bcc-f7d4
-401a-83d2-6c049854ab76
2013-11-19 21:40:41,266 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - Shared Network created: 
bc992430-00f8-42eb-9e2
2-fdfcf3b2e94a
2013-11-19 21:40:41,321 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - 2368
2013-11-19 21:40:41,420 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - Network created: 
e661393d-a1bb-4619-adcc-4d7d6
5172e29
2013-11-19 21:42:01,929 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
44d30c61-07cb-4986-ab
16-96b9506c6061
2013-11-19 21:43:47,519 - DEBUG - test_deployVM_multipleSharedNetwork 
(test_shared_networks.TestSharedNetworks) - Virtual Machine created: 
2d0f4114-a763-43be-90
70-73e3bb74571f

==> result.log <==
ok
test_networkWithsubdomainaccessFalse (test_shared_networks.TestSharedNetworks)
Test shared Network with subdomainaccess=False ... skipped 'skip'
test_networkWithsubdomainaccessTrue (test_shared_networks.TestSharedNetworks)
Test Shared Network with subdomainaccess=True ... skipped 'skip'
test_sharedNetworkOffering_01 (test_shared_networks.TestSharedNetworks)
Test shared network Offering 01 ... skipped 'skip'
test_sharedNetworkOffering_02 (test_shared_networks.TestSharedNetworks)
Test Shared Network Offering 02 ... skipped 'skip'
test_sharedNetworkOffering_03 (test_shared_networks.TestSharedNetworks)
Test Shared Network Offering 03 ... skipped 'skip'

--
Ran 13 tests in 472.706s

OK (skipped=12)


Test 2:

 ==> result.log <==
test_createSharedNetwork_All (test_shared_networks.TestSharedNetworks)
Test Shared Network ALL ...
==> client.log <==
2013-11-19 21:34:56,669 - DEBUG - test_createSharedNetwork_All 
(test_shared_networks.TestSharedNetworks) - Admin type account created: 
admin-XABU1-JAM9J0
2013-11-19 21:34:56,744 - DEBUG - test_createSharedNetwork_All 
(test_shared_networks.TestSharedNetworks) - User type account created: 
admin-XABU1-YIDA7H
2013-11-19 21:34:56,782 - DEBUG - test_createSharedNetwork_All 
(test_shared_networks.TestSharedNetworks) - Physical network found: 
05ef4a90-f9ba-449f-b1b6-a437e
6c4d4dd
2013-11-19 21:34:57,023 - DEBUG - test_createSharedNetwork_All 
(test_shared_networks.Tes

Re: CloudstackDev on Arch Linux

2013-11-20 Thread Sacheendra Talluri

But that breaks other programs which actually need python to point to
python3. I am looking for something like virtualenv. The method mentioned
in the wiki(sourcing the virtualenv directory) wont work as it is not just
the terminal session that needs to point to python2.
I have looked at the source code and it is hardcoded to call bin/python
when it executes a python script.
Is it possible to change it to call bin/python2.7 as that is going to
remain the same in all distros.

If this doesn't work, i was going to setup a dev environment on windows.
Are there any problems with setting up the dev environment in windows.

Regards, Sacheendra

On Wed, Nov 20, 2013 at 2:44 PM, Ian Duffy  wrote:

> Hi Sacheendra,
>
> Does placing python2.7 in your path before python3.3 help in any way?
>
> This process is described at:
> https://wiki.archlinux.org/index.php/python
>
> They create a symbolic link from /usr/bin/python2 to ~/bin/python and then
> place ~/bin into their path.
>
>
> On 20 November 2013 10:11, Sacheendra Talluri  >wrote:
>
> > Hi,
> > I am new to Cloudstack
> >
> > In arch linux bin/python points to python3.3, but cloudstack needs it to
> > point to python2.7
> > How do I get around this. For python programs i use virtualenv, but
> > obviously it wont work for this.
> >
> > Has anybody got it working on arch linux.
> >
> > Regards, Sacheendra
> >
>

[Review Request]ASF4.2 to4.2.1 upgarde steps using source builds

2013-11-20 Thread Manasa Veloori (3P)

Steps to upgrade ASF 4.2 to 4.2.1 using source builds:

1. Deploy ASF4.2.0 using the procedure given at
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+test+procedure
Use the following links to download the source

wget --no-check-certificate
https://dist.apache.org/repos/dist/release/cloudstack/KEYS
wget --no-check-certificate
http://www.apache.org/dyn/closer.cgi/cloudstack/releases/4.2.0/apache-cloudstack-4.2.0-src.tar.bz2
wget --no-check-certificate
http://www.apache.org/dyn/closer.cgi/cloudstack/releases/4.2.0/apache-cloudstack-4.2.0-src.tar.bz2.asc
wget --no-check-certificate
http://www.apache.org/dyn/closer.cgi/cloudstack/releases/4.2.0/apache-cloudstack-4.2.0-src.tar.bz2.md5
wget --no-check-certificate
http://www.apache.org/dyn/closer.cgi/cloudstack/releases/4.2.0/apache-cloudstack-4.2.0-src.tar.bz2.sha

2. Stop the Managament server and take the db dump.

3. Now download the source for 4.2.1 from below location:
wget --no-check-certificate
https://dist.apache.org/repos/dist/release/cloudstack/KEYS
wget --no-check-certificate
https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/apache-cloudstack-4.2.1-src.tar.bz2
wget --no-check-certificate
https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/apache-cloudstack-4.2.1-src.tar.bz2.asc
wget --no-check-certificate
https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/apache-cloudstack-4.2.1-src.tar.bz2.md5
wget --no-check-certificate
https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/apache-cloudstack-4.2.1-src.tar.bz2.sha

4. gpg --import KEYS

5. Verify signatures and hash files:
gpg --verify apache-cloudstack-4.2.1-src.tar.bz2.asc

This command should return "Good Signature".

6. gpg --print-md MD5 apache-cloudstack-4.2.1-src.tar.bz2 | diff -
apache-cloudstack-4.2.1-src.tar.bz2.md5
gpg --print-md SHA512 apache-cloudstack-4.2.1-src.tar.bz2 | diff -
apache-cloudstack-4.1.0-src.tar.bz2.sha

Each of these commands should return no output. If there
is any output from them, then there is a difference between the hash you
generated locally and the hash that has been pulled from the
server.

7. Extract the source code and verify the contents:
Get the commit hash from the VOTE email (ex:
4cd60f3d1683a3445c3248f48ae064fb573db2a1). The value will change between
releases.
Create two new temporary directories:
mkdir /tmp/cloudstack/tree

8. Checkout to the 4.2.1 git branch

git archive --format=tar --prefix=/tmp/cloudstack/tree/ | tar Pxf
-

9. Unpack the release artifact:
cd /tmp/cloudstack
tar xvfj apache-cloudstack-4.2.1-src.tar.bz2

10. Compare the contents of the release artifact with the contents pulled
from the repo:
diff -r /tmp/cloudstack/apache-cloudstack-4.2.1-src
/tmp/cloudstack/tree

Nothing should be different.

11. Verify the Code's License Headers
cd /tmp/cloudstack/apache-cloudstack-4.2.1-src
mvn --projects='org.apache.cloudstack:cloudstack'
org.apache.rat:apache-rat-plugin:0.8:check

The build should FAIL if there are any non-compliant files that are not
specifically excluded from the ASF license header requirement. You can
optionally review the target/rat.txt file after the run completes. If the build
passes, RAT is saying that we are compliant and this test passes.

12. Compile and upgrade Management Server
mvn -P developer,systemvm clean install (or) mvn -P
developer,systemvm clean install -Dnonoss
mvn -pl :cloud-client-ui jetty:run

13.Check the database whether the db is upgraded to 4.2.1

Thanks,
Manasa

Re: Review Request 15508: Make sure that if the file does not exist an Exception is thrown and that once it exists it is also closed after the properties are loaded.

2013-11-20 Thread Hugo Trippaers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15508/#review29161
---



plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java


I'm giving a demo, ignore this


- Hugo Trippaers


On Nov. 14, 2013, 8:03 a.m., Wilder Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15508/
> ---
> 
> (Updated Nov. 14, 2013, 8:03 a.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Make sure that if the file does not exist an Exception is thrown and that 
> once it exists it is also closed after the properties are loaded.
> 
> fix for Coverity bug cv_1125364 Resource leak
> The system resource will not be reclaimed and reused, reducing the future 
> availability of the resource.
> In 
> org.?apache.?cloudstack.?network.?contrail.?management.?ManagementNetworkGuru.?configure(java.?lang.?String,
>  java.?util.?Map): Leak of a system resource (CWE-404)
> 
> 
> Diffs
> -
> 
>   
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java
>  e457023 
> 
> Diff: https://reviews.apache.org/r/15508/diff/
> 
> 
> Testing
> ---
> 
> A test branch was created, the patch was applied against the branch and a 
> full build was executed. Everything is working fine. The class changed is 
> tested by MockLocalNfsSecondaryStorageResource.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>

Re: CloudstackDev on Arch Linux

Hi Sacheendra,

Does placing python2.7 in your path before python3.3 help in any way?

This process is described at:
https://wiki.archlinux.org/index.php/python

They create a symbolic link from /usr/bin/python2 to ~/bin/python and then
place ~/bin into their path.


On 20 November 2013 10:11, Sacheendra Talluri wrote:

> Hi,
> I am new to Cloudstack
>
> In arch linux bin/python points to python3.3, but cloudstack needs it to
> point to python2.7
> How do I get around this. For python programs i use virtualenv, but
> obviously it wont work for this.
>
> Has anybody got it working on arch linux.
>
> Regards, Sacheendra
>

CloudstackDev on Arch Linux

2013-11-20 Thread Sacheendra Talluri

Hi,
I am new to Cloudstack

In arch linux bin/python points to python3.3, but cloudstack needs it to
point to python2.7
How do I get around this. For python programs i use virtualenv, but
obviously it wont work for this.

Has anybody got it working on arch linux.

Regards, Sacheendra

Re: Review Request 15572: LDAP import users changes