Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/#review29649 --- core/src/com/cloud/agent/api/MigrateCommand.java https://reviews.apache.org/r/15763/#comment57065 I see that you have tested for XS. In the mail thread people have mentioned that it should work on Vmware and KVM. Will it be possible to do a quick verification? Otherwise (except for a few minor comments) the change looks good to me. setup/db/db/schema-410to420.sql https://reviews.apache.org/r/15763/#comment57063 Since the change is for master, this is not required. 430-440 upgrade should suffice. setup/db/db/schema-430to440.sql https://reviews.apache.org/r/15763/#comment57064 Also the description needs to be updated in VirtualMachineManager.java where ExecuteInSequence is defined. - Koushik Das On Nov. 21, 2013, 6:39 p.m., Alex Ough wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/ --- (Updated Nov. 21, 2013, 6:39 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- When a host is switched to the 'maintenance mode', the vms in that host are migrated to another available hosts. Currently, the vm migrations are executed sequentially, it can take a lot of time when there are quite number of vms. So I changed 'MigrateCommand' to get the value of 'executeInSequence' property from the global setting value of 'execute.in.sequence.hypervisor.commands' so that users can execute the migrations in parallel to save time. Diffs - core/src/com/cloud/agent/api/MigrateCommand.java 0d8f70c engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 setup/db/db/schema-410to420.sql 522ccc4 setup/db/db/schema-430to440.sql 9bb9602 Diff: https://reviews.apache.org/r/15763/diff/ Testing --- Tested in the simulator mode and Xen servers. Thanks, Alex Ough
Re: A question on vm migrations when hosts are set into a maintenance mode.
I have posted my review comments. Except for a few minor comments changes look good to me. -Koushik On 02-Dec-2013, at 9:15 PM, Alex Ough alex.o...@sungard.com wrote: All, It's been a while since this review was requested, so can anyone review this to move on? Thanks in advance. Alex Ough On Fri, Nov 22, 2013 at 11:51 AM, Alex Ough alex.o...@sungard.com wrote: Thanks to help from many developers, I sent my first review request in the cloudstack, https://reviews.apache.org/r/15763/, so please take a look at it and let me know if there is anything missing/incorrect. Thanks again. Alex Ough On Thu, Nov 21, 2013 at 10:09 AM, Alex Ough alex.o...@sungard.com wrote: Hi Wido, Related with the 'disk_offering.cache_mode', I found that there is a sql file to add that column, which is 'cloudstack/ developer/target/db/db/schema-430to440.sql'. But after running it manually, I have another error saying that the 'cache_mode' cannot be null, so I just changed the column to allow null to move on. So you may include the sql file and allow null in that column. Thanks Alex Ough On Wed, Nov 20, 2013 at 3:45 PM, Alex Huang alex.hu...@citrix.comwrote: Wido, Looks like you didn’t update your schema file or forgot to add a schema upgrade file in master? See the error described by Alex below. @Alex You can probably remove the cachemode field in the DiskOfferingVO for now. Or revert 1edaa36 on your local repo to keep moving forward. --Alex *From:* Alex Ough [mailto:alex.o...@sungard.com] *Sent:* Wednesday, November 20, 2013 9:56 AM *To:* Alex Huang *Cc:* dev@cloudstack.apache.org *Subject:* Re: A question on vm migrations when hosts are set into a maintenance mode. Hi Alex, It looks like you moved the 'ExecuteInSequence' to the vm level from the management server, which seems to be ok, but at this time I cannot test it because when I try to start up the management server, it fails because of database schema error, which is 'Unknown column 'disk_offering.cache_mode' in 'field list' even if I re-built the database. Is the schema change part of your changes or something other developer changed? If that is from any other developer, can you fix this? Thanks Alex Ough On Tue, Nov 19, 2013 at 7:25 PM, Alex Huang alex.hu...@citrix.com wrote: Alex, Can you do a pull from master and see if my fix fits your needs. Unfortunately, I’m on the road and couldn’t do an actual test of it. --Alex *From:* Alex Huang *Sent:* Tuesday, November 19, 2013 4:45 AM *To:* 'Alex Ough'; dev@cloudstack.apache.org *Subject:* RE: A question on vm migrations when hosts are set into a maintenance mode. Alex, Sorry for the late reply. Been travelling the last couple of weeks. I’ll look into this today. --Alex *From:* Alex Ough [mailto:alex.o...@sungard.com alex.o...@sungard.com] *Sent:* Monday, November 18, 2013 6:17 AM *To:* dev@cloudstack.apache.org *Cc:* Alex Huang *Subject:* Re: A question on vm migrations when hosts are set into a maintenance mode. Thank Parasanna Sebastien, I also got his email and sent an email. Waiting for his reply... Thanks Alex Ough On Sat, Nov 16, 2013 at 3:05 PM, Sebastien Goasguen run...@gmail.com wrote: cc Alex Huang to get his attention: On Nov 15, 2013, at 10:17 PM, Prasanna Santhanam t...@apache.org wrote: Alex, Could you just do a git blame on the file and copy the emails of people who changed that bit of code? They may be able to help if Cc-ed directly. Thanks, On Fri, Nov 15, 2013 at 01:49:07PM -0600, Alex Ough wrote: I hate to sending the same emails over and over again, but I really need to finalize this feature to be included in the next code freeze because this feature is very critical in our inside project. Anyone who can help, please? Thanks Alex Ough On Thu, Nov 14, 2013 at 1:27 PM, Alex Ough alex.o...@sungard.com wrote: Not sure if Alex Huang checked this, but can anyone help to resolve this? Thanks Alex Ough On Wed, Nov 13, 2013 at 11:39 AM, Alex Ough alex.o...@sungard.com wrote: It sounds a little scary... I looked at the history and found these. 8/9/ : file moved to engine by Alex Huang 9/16 : '_mgmtServer.getExecuteInSequence()' changed to 'getExecuteInSequence()' by Alex Huang Hi Alex Huang, I'm not sure if you're aware of this, but can you check this for me? Thanks Alex Ough On Wed, Nov 13, 2013 at 11:18 AM, Marcus Sorensen shadow...@gmail.comwrote: I'm not sure. I know in the past when I've seen files change locations it has also clobbered updates to that file. Someone branched, did the reorganization work, and merged, while in-between the original file changed. On Wed, Nov 13, 2013 at 9:21 AM, Alex Ough alex.o...@sungard.com wrote: All, While merging my changes
Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15875/ --- (Updated Dec. 3, 2013, 8:52 a.m.) Review request for cloudstack, Jayapal Reddy and Koushik Das. Bugs: CLOUDSTACK-5160 https://issues.apache.org/jira/browse/CLOUDSTACK-5160 Repository: cloudstack-git Description --- use a map to specify the custom parameters in the deployvm api Instead of one parameter for each. https://issues.apache.org/jira/browse/CLOUDSTACK-5160 Diffs (updated) - api/src/com/cloud/vm/UserVmService.java ac14da7 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java f075082 engine/schema/src/com/cloud/event/UsageEventVO.java 2278103 server/src/com/cloud/vm/UserVmManagerImpl.java d3dd356 Diff: https://reviews.apache.org/r/15875/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'
On Dec. 3, 2013, 8:44 a.m., Koushik Das wrote: core/src/com/cloud/agent/api/MigrateCommand.java, line 32 https://reviews.apache.org/r/15763/diff/1/?file=389559#file389559line32 I see that you have tested for XS. In the mail thread people have mentioned that it should work on Vmware and KVM. Will it be possible to do a quick verification? Otherwise (except for a few minor comments) the change looks good to me. Now that HyperV is also there can there be any issues with that? - Koushik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/#review29649 --- On Nov. 21, 2013, 6:39 p.m., Alex Ough wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/ --- (Updated Nov. 21, 2013, 6:39 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- When a host is switched to the 'maintenance mode', the vms in that host are migrated to another available hosts. Currently, the vm migrations are executed sequentially, it can take a lot of time when there are quite number of vms. So I changed 'MigrateCommand' to get the value of 'executeInSequence' property from the global setting value of 'execute.in.sequence.hypervisor.commands' so that users can execute the migrations in parallel to save time. Diffs - core/src/com/cloud/agent/api/MigrateCommand.java 0d8f70c engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 setup/db/db/schema-410to420.sql 522ccc4 setup/db/db/schema-430to440.sql 9bb9602 Diff: https://reviews.apache.org/r/15763/diff/ Testing --- Tested in the simulator mode and Xen servers. Thanks, Alex Ough
Re: [Discuss] AutoScaling.next in CloudStack
On Thu, Nov 28, 2013 at 6:16 PM, Daan Hoogland daan.hoogl...@gmail.comwrote: I don't think we should try to go beyond the hypervisor extensions on the vms (unless it's the systemvms) is this what you mean? on the systemvm it seems we could indeed. Is that what you mean? on the others we should try to collect through the hypevisor and not beyond that, would you agree? @Daan, Apologize for slow response. Yeah, actually we have two approach methods: - using SNMP: I'm going to use pre-installed SNMP agent into VMs. Also, SNMP manager will be external pluggable devices. Problem now is what parameters we decide to monitor? - trying to explore hypervisor's ability in collecting performance data from VMs resided in. Problem is the hypervisor's limited in monitoring VMs. I prefer method 1. @Chiradeep, Okie I'm done with SNMP agent installed into VMs. What I'm thinking is: We use external SNMP managers opensource software, implemented as an external device, same architecture with other plugins like NetScaler of Nicira NVP. The advantage is scalable and pluggable. CloudStack send AS configuration to SNMP devices using their own API (similar to NetScaler's NitroAPI). AutoScale engine periodically request performance information to SNMP device and make AS actions (scaleup/scaledown) to CloudStack orchestration based on response data. So, problem now is: + what SNMP software we use? I found Net-SNMP but not sure it's okie. Need to try and review it. + what metric we decide to monitor for AS action? @guys: Any idea? Cheers, --Tuna
RE: ANNOUNCE] New Committer: Giles Sirett
Congratulations Giles! Kind Regards, Tariq Iqbal Senior Consultant S: +44(0)20 3603 0540 | M: +44(0)790 9911600 tariq.iq...@shapeblue.com | www.shapeblue.com | Twitter:@shapeBlue ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS From: John Burwell jburw...@basho.com Sent: 02 December 2013 16:06 To: dev@cloudstack.apache.org Cc: Giles Sirett Subject: ANNOUNCE] New Committer: Giles Sirett The Project Management Committee (PMC) for Apache CloudStack has asked Giles Sirett to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Giles! — John Burwell, on behalf of the Apache CloudStack PMC This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
4.2.1
Do we have any outstanding issues preventing 4.2.1 to be released ?
Re: 4.2.1
Yes, the 4.2.1 is going to be re-spun as a critical issue has been found recently. The new RC candidate will be up for voting in some hours from now. -abhi On 03/12/13 2:57 pm, sebgoa run...@gmail.com wrote: Do we have any outstanding issues preventing 4.2.1 to be released ?
Re: Request: Help designing a 'powered by' logo for CloudStack
I like, 2. But I agree with Rbyn about the word apache. I should be in there. I think it must even. 1. It looks streched on my preview in finder as well On Mon, Dec 2, 2013 at 9:47 PM, Robyn Bergeron rberg...@redhat.com wrote: - Original Message - From: Laszlo Hornyak laszlo.horn...@gmail.com To: dev@cloudstack.apache.org Cc: market...@cloudstack.apache.org Sent: Sunday, December 1, 2013 10:31:11 AM Subject: Re: Request: Help designing a 'powered by' logo for CloudStack Hi, Here is my version: - SVG format as you requested - Only two colors, exactly the same as for the original logo. I prefer few colors for such pictures - Unfortunately the monkey could not make it, the whole thing needs to fit into a very small area and the monkey would be too little detail (the monkey is übercool anyway) - if no monkey, then cloud - only powered by cloudstack, no extra text because it make make difficult to read in such a small place - see attached file :) Hi, I like the cloud idea/placement. (And totally get that it's going to be hard to see the monkey in such a small space. Even though he's so cute.) Two things - 1) The lettering in the word cloudstack looks stretched as compared with the normal look of the font - I'm not sure if that's intentional, not intentional, something really weird in how it's rendering on my screen... :) 2) I realize the problem around no extra text but ... do we want to add in the word apache? (or conversely, is there any reason why it shouldn't be added in... legal, etc)? -robyn On Fri, Nov 15, 2013 at 6:56 PM, David Nalley da...@gnsa.us wrote: Hi folks: If you happen to have some graphical design talent (I have none) I have a great opportunity for you :) CloudStack needs a 'powered by' logo that is easy to consume, and is also attractive. A couple examples of powered by logos: http://tomcat.apache.org/images/tomcat-power.gif https://cwiki.apache.org/confluence/download/attachments/80899/mahout-logo-poweredby-100.png?version=1modificationDate=1312880703000 https://netbeans.org/images_www/screenshots/6.0/baseIDE_ant_powered_150px.png A couple of constraints: * Please don't use the Apache feather. (we could, but lets not; it will make life simpler) * Please try and produce a vector format as source (this allows us to scale/etc) * Because this will become a trademark (which is vastly different that copyright) - we will likely need some explicit email agreement around trademarks rights for the image. (I promise, it isn't as scary as that sentence makes it out to be.) Anyone interested? --David -- EOF
Build failed in Jenkins: build-master #92
See http://jenkins.buildacloud.org/job/build-master/92/changes Changes: [anthony.xu] put shell scripts to a seperate directory in XS -- [...truncated 3734 lines...] [INFO] Surefire report directory: http://jenkins.buildacloud.org/job/build-master/ws/services/console-proxy-rdp/rdpconsole/target/surefire-reports --- T E S T S --- Running rdpclient.MockServerTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.295 sec Results : Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 [JENKINS] Recording test results [INFO] [INFO] [INFO] Building Apache CloudStack Framework - QuickCloud 4.4.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-quickcloud --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master/ws/quickcloud/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master/ws/quickcloud (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-quickcloud --- [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-quickcloud --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 1 resource [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-quickcloud --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master/ws/quickcloud/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-quickcloud --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-quickcloud --- [INFO] Surefire report directory: http://jenkins.buildacloud.org/job/build-master/ws/quickcloud/target/surefire-reports --- T E S T S --- Results : Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 [JENKINS] Recording test results [INFO] [INFO] [INFO] Building Apache CloudStack AWS API Bridge 4.4.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-awsapi --- [INFO] Deleting http://jenkins.buildacloud.org/job/build-master/ws/awsapi/target (includes = [**/*], excludes = []) [INFO] Deleting http://jenkins.buildacloud.org/job/build-master/ws/awsapi (includes = [target, dist], excludes = []) [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-awsapi --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (generate-resource) @ cloud-awsapi --- [INFO] Executing tasks main: [copy] Copying 3 files to http://jenkins.buildacloud.org/job/build-master/ws/awsapi/target/generated-webapp/WEB-INF/classes [INFO] Executed tasks [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-awsapi --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-awsapi --- [INFO] Compiling 1295 source files to http://jenkins.buildacloud.org/job/build-master/ws/awsapi/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-awsapi --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory http://jenkins.buildacloud.org/job/build-master/ws/awsapi/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ cloud-awsapi --- [INFO] Compiling 5 source files to http://jenkins.buildacloud.org/job/build-master/ws/awsapi/target/test-classes [INFO] [INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-awsapi --- [INFO] Surefire report directory: http://jenkins.buildacloud.org/job/build-master/ws/awsapi/target/surefire-reports --- T E S T S
Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15875/ --- (Updated Dec. 3, 2013, 10:53 a.m.) Review request for cloudstack, Jayapal Reddy and Koushik Das. Changes --- patch for 4.3 Bugs: CLOUDSTACK-5160 https://issues.apache.org/jira/browse/CLOUDSTACK-5160 Repository: cloudstack-git Description --- use a map to specify the custom parameters in the deployvm api Instead of one parameter for each. https://issues.apache.org/jira/browse/CLOUDSTACK-5160 Diffs (updated) - api/src/com/cloud/vm/UserVmService.java 6fc8b54 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java ad957d5 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 8c58227 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 4e25493 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 5dd15ce engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 71e8b7d server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c Diff: https://reviews.apache.org/r/15875/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: [Discuss] AutoScaling.next in CloudStack
On Tue, Dec 3, 2013 at 10:03 AM, Nguyen Anh Tu t...@apache.org wrote: + what SNMP software we use? I found Net-SNMP but not sure it's okie. Need to try and review it. There are a lot of oopen source and commercial once out there. We need an open source one. Given that we are probably going to have to do some work on the library our selves, I think license compatability with apache deserves the greatest consideration. + what metric we decide to monitor for AS action? I think we should design a solution that reads from a configuration file what mibs/oids to query from what device. So we don't need to make this decision in this (design) phase
Engage cloudStack project
Hi, I am Malintha Adikari from Sri Lanka ,a fresh engineer who works in an open source software company and I want to engage cloudStack project. I am very interesting in cloud computing concepts but I have least hands-on experience. I am experience in Java and C development.I have checked out the source and go through the documentation ( some sections were difficult to understand for me). What should be my first steps ? Can I build and run the source code ? Could you please give me suggestions to get start Thank you, -- *Malintha Adikari* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 71 2312958
Re: Review Request 15897: Add certificate chain support for netscaler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15897/#review29653 --- patch does not compile on master. Fails with error: [ERROR] /Users/murali/projects/asf/incubator-cloudstack/plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[2388,36] cannot find symbol [ERROR] symbol : method get(com.citrix.netscaler.nitro.service.nitro_service,com.citrix.netscaler.nitro.resource.config.ns.nsip) [ERROR] location: class com.citrix.netscaler.nitro.resource.config.ns.nsip [ERROR] /Users/murali/projects/asf/incubator-cloudstack/plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:[2437,28] cannot find symbol [ERROR] symbol : method get(com.citrix.netscaler.nitro.service.nitro_service,com.citrix.netscaler.nitro.resource.config.ns.nsip) [ERROR] location: class com.citrix.netscaler.nitro.resource.config.ns.nsip - Murali Reddy On Nov. 28, 2013, 1:01 a.m., Syed Ahmed wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15897/ --- (Updated Nov. 28, 2013, 1:01 a.m.) Review request for cloudstack and Murali Reddy. Bugs: CLOUDSTACK-5296 https://issues.apache.org/jira/browse/CLOUDSTACK-5296 Repository: cloudstack-git Description --- This patch adds support for trust chains in the netscaler. I initially planned on using the 10.1 API's bundle feature but during my testing I found that was not working. So I am doing the chain linking myself. Also NS can have only one entity of a certificate ie lets say two different users try to add the same certificate on the netscaler only one of them will go through. The other one says resouce already exists even though they have different files. This can be a problem in trust chains where the chain can be shared between multiple accounts/certificates. So, I am using the figerprint as an identifier of a certificate and making sure that we delete it only when no one references it. Diffs - .gitignore dab1b3f api/src/com/cloud/network/lb/LoadBalancingRule.java 4b2f9c4 engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java 99354c5 plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 7dac9a0 server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a2eba07 server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 17f88bd utils/src/com/cloud/utils/security/CertificateHelper.java e8d20b0 Diff: https://reviews.apache.org/r/15897/diff/ Testing --- Testing was done a a 3-length chain with a root, intermediate and a client certificate. Two clients share the same intermediate certificate. Thanks, Syed Ahmed
Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/#review29654 --- Commit 03ba659ae7263ca4fdb7c1c0eaccbecdf45594e8 in branch refs/heads/4.2 from David Grizzanti [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=03ba659 ] CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils - ASF Subversion and Git Services On Nov. 20, 2013, 8:15 p.m., David Grizzanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/ --- (Updated Nov. 20, 2013, 8:15 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-5220 https://issues.apache.org/jira/browse/CLOUDSTACK-5220 Repository: cloudstack-git Description --- CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils Updated UsageEventUtils code to not blow up when an invalid zone ID is passed in. Now will still generate usage event but leaving out zone UUID. Diffs - engine/components-api/src/com/cloud/event/UsageEventUtils.java a4be4dd Diff: https://reviews.apache.org/r/15725/diff/ Testing --- built on master Thanks, David Grizzanti
Re: Review Request 15722: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (4.2.0)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15722/#review29655 --- Ship it! commit 03ba659ae7263ca4fdb7c1c0eaccbecdf45594e8 - Murali Reddy On Nov. 20, 2013, 7:54 p.m., David Grizzanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15722/ --- (Updated Nov. 20, 2013, 7:54 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-5022 https://issues.apache.org/jira/browse/CLOUDSTACK-5022 Repository: cloudstack-git Description --- CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils Updated UsageEventUtils code to not blow up when an invalid zone ID is passed in. Now will still generate usage event but leaving out zone UUID. UsageEventUtils has been moved on master, so a separate review will be submitted for that fix. Diffs - server/src/com/cloud/event/UsageEventUtils.java 2e42229 Diff: https://reviews.apache.org/r/15722/diff/ Testing --- Tested on 4.2.0 Thanks, David Grizzanti
Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/#review29656 --- patch does not apply on master. Please resubmit. Also do you want to push the changes to 4.3 as well? - Murali Reddy On Nov. 20, 2013, 8:15 p.m., David Grizzanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/ --- (Updated Nov. 20, 2013, 8:15 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-5220 https://issues.apache.org/jira/browse/CLOUDSTACK-5220 Repository: cloudstack-git Description --- CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils Updated UsageEventUtils code to not blow up when an invalid zone ID is passed in. Now will still generate usage event but leaving out zone UUID. Diffs - engine/components-api/src/com/cloud/event/UsageEventUtils.java a4be4dd Diff: https://reviews.apache.org/r/15725/diff/ Testing --- built on master Thanks, David Grizzanti
[VOTE] 2nd round of voting for ASF 4.2.1 RC
Hi All, There were some issues found in the 4.2.1 RC that was earlier approved by voters. As a result the RC has to be re-spun. There is not much of a difference between this and the one approved earlier apart from some additional fixes. The current vote is to approve the current RC build for 4.2.1 maintenance release. For this particular release various upgrade paths have been tested apart from regression tests and BVTs. Around 175 bugs have been fixed some new features added (see Release Notes). Following are the particulars for this release: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.2 commit: 6ba071b159f5da6f86ff1b48cd6c2d555d60124d List of changes are available in Release Notes, a summary can be accessed here: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.2 Source release revision 3816 (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/ PGP release keys (signed using RSA Key ID = 42443AA1): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours (until 12/05 End of day PST). For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why)
Re: Ldap APIs
Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provisioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
Re: Ldap APIs
So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provisioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
Re: [VOTE] 2nd round of voting for ASF 4.2.1 RC
On Dec 3, 2013, at 1:24 PM, Abhinandan Prateek abhinandan.prat...@citrix.com wrote: Hi All, There were some issues found in the 4.2.1 RC that was earlier approved by voters. As a result the RC has to be re-spun. There is not much of a difference between this and the one approved earlier apart from some additional fixes. Can you be more specific ? what fixes required a re-vote ? also looking at the changes file, it lists new features in 4.2.1, yet this is a bug fix release that should not have new features. The current vote is to approve the current RC build for 4.2.1 maintenance release. For this particular release various upgrade paths have been tested apart from regression tests and BVTs. Around 175 bugs have been fixed some new features added (see Release Notes). Following are the particulars for this release: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.2 commit: 6ba071b159f5da6f86ff1b48cd6c2d555d60124d List of changes are available in Release Notes, a summary can be accessed here: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.2 Source release revision 3816 (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/ PGP release keys (signed using RSA Key ID = 42443AA1): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours (until 12/05 End of day PST). For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why)
[HELP] Unable to create/register new templates
Dear all,
I am running CloudStack version 4.2.0 with KVM hypervisor, Ceph RBD primary
storage and NFS secondary storage.
Since yesterday, I am not able to create/register a new template. Normally
I would be converting a root-disk volume into a template. In this case, the
process of creating the template will take forever and will never complete.
On management-server log, there is not much information other than a line
stating that the template is being copied:
2013-12-03 17:43:33,340 DEBUG [agent.transport.Request]
(Job-Executor-33:job-5446 = [ f6f014b3-7301-4be0-98e9-e6a8caba5e51 ]) Seq
37-2044592856: Sending { Cmd , MgmtId: 161342671900, via: 37, Ver: v1,
Flags: 100111,
[{org.apache.cloudstack.storage.command.CopyCommand:{srcTO:{org.apache.cloudstack.storage.to.VolumeObjectTO:{uuid:10c780a0-d574-4332-bcf4-9988e7ed963d,volumeType:ROOT,dataStore:{org.apache.cloudstack.storage.to.PrimaryDataStoreTO:{uuid:d433809b-01ea-3947-ba0f-48077244e4d6,id:214,poolType:RBD,host:
xx.xx.com,path:xx-xx-01,port:6789}},name:ROOT-281,size:10737418240,path:d9d5f42f-0c57-4b17-a093-f1172ba24b81,volumeId:306,vmName:i-2-281-VM,accountId:2,format:RAW,id:306,hypervisorType:KVM}},destTO:{org.apache.cloudstack.storage.to.TemplateObjectTO:{path:template/tmpl/2/345,uuid:73732183-69f7-47de-b2e8-556326ca989b,id:345,format:RAW,accountId:2,hvm:true,displayText:CentOS
5.10 (64-bit)
20131203a,imageDataStore:{com.cloud.agent.api.to.NfsTO:{_url:nfs://x.x.x.x/mnt/vol1/sec-storage2,_role:Image}},name:2c8002031-3971-33af-b59f-6f7b52011437,hypervisorType:KVM}},executeInSequence:true,wait:10800}}]
}
Logs from SSVM /var/log/cloud/cloud.out:
2013-12-03 11:18:58,137 WARN [storage.template.DownloadManagerImpl]
(agentRequest-Handler-3:null) Post download installation was not completed
for /mnt/SecStorage/41cab17f-4dbc-37a5-b8d2-cdc153301319/template/tmpl/2/343
2013-12-03 11:18:58,159 WARN [storage.template.DownloadManagerImpl]
(agentRequest-Handler-3:null) Post download installation was not completed
for /mnt/SecStorage/41cab17f-4dbc-37a5-b8d2-cdc153301319/template/tmpl/2/276
2013-12-03 11:18:58,186 WARN [storage.template.DownloadManagerImpl]
(agentRequest-Handler-3:null) Post download installation was not completed
for /mnt/SecStorage/41cab17f-4dbc-37a5-b8d2-cdc153301319/template/tmpl/2/275
2013-12-03 11:18:58,220 WARN [storage.template.DownloadManagerImpl]
(agentRequest-Handler-3:null) Post download installation was not completed
for /mnt/SecStorage/41cab17f-4dbc-37a5-b8d2-cdc153301319/template/tmpl/2/277
2013-12-03 11:18:58,234 WARN [storage.template.DownloadManagerImpl]
(agentRequest-Handler-3:null) Post download installation was not completed
for /mnt/SecStorage/41cab17f-4dbc-37a5-b8d2-cdc153301319/template/tmpl/2/225
After a while, the process will block other processes, i.e. I will not be
able to create a new VM or start/stop any VMs, it seems that it's waiting
for the template creation process to complete (which never completes). So I
would need to restart the cloudstack-management service on the management
server for the day-to-day operation to continue.
Status of the created template would be:
Ready: No
Status: (empty)
Size: (empty)
I have done all the SSVM health checks as mentioned on this URL:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/SSVM,+templates,+Secondary+storage+troubleshooting
And I can confirm that the SSVM is running fine, health checks passed. I
have tried to restart the SSVM service (service cloud restart) and even
stop and start the SSVM but the problem still persists and the templates
will never get created.
Any advice on how I can further troubleshoot this problem?
Looking forward to your reply, thank you.
Cheers.
[Responsiveness report] users 2013w48
http://markmail.org/message/lf4unndbuig7pu6w sdX-devices became vdX-devices in CloudStack-4.2.0 by Vladimir Melnik http://markmail.org/message/iz5x2cbkakw3dun5 the question of upgrade from 4.0.x to 4.1.0 by Steven Liang http://markmail.org/message/twawkkfhwmuheihj 4.2.0 LoadBalancing Question with systemvm by Andrei Mikhailovsky http://markmail.org/message/hikfkyhen4hs6srv how can consoleproxy.url.domain take effect by 卢惠勇 http://markmail.org/message/57oez35q3uiei27h Unable to start VM by m2m isb http://markmail.org/message/ew56aecck5hzsezv Connection refused by Steven Liang http://markmail.org/message/liwdty22bnfscsmy Template Update properties issue. by Thomas Joseph http://markmail.org/message/aes3q6yggdaainmj host memory usage by Gerolamo Valcamonica http://markmail.org/message/3ha7urm4m7vvizcx Template delete/update issue in CS v4.1.1 from project view by Thomas Joseph http://markmail.org/message/pujcjso4yovfrtbe Adding vmware support to my cloudstack install by Vosbury, David http://markmail.org/message/3dcnob6z3glvnpuo OPENCONTRAIL Plans ?? by Outback Dingo for an explanation of this report see https://cwiki.apache.org/confluence/display/CLOUDSTACK/Responsiveness+report
Review Request 15962: CLOUDSTACK-5346: Fixed shared network cleanup issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/ --- Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5346 https://issues.apache.org/jira/browse/CLOUDSTACK-5346 Repository: cloudstack-git Description --- component.test_project_resources.TestNetwork.test_03_network_create failed due to Exception during cleanup: Failed to delete network The test case failed to delete the shared network because it has 1 VM in it. Resolution: Deleted the VM and waited for expunge interval before proceeding to network cleanup. Other changes: Code cleanup and changes related to imports, getting free vlan and setting the startip,endip,netmask of shared network using random subnet number to avoid conflict. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15962/diff/ Testing --- Tested locally on XenServer setup. Log: test_03_network_create (test_project_resources_fixed.TestNetwork) Test create network in project ... ok test_01_service_offerings (test_project_resources_fixed.TestOfferings) Test service offerings in a project ... skipped 'skip' test_02_project_disk_offerings (test_project_resources_fixed.TestOfferings) Test project disk offerings ... skipped 'skip' test_07_associate_public_ip (test_project_resources_fixed.TestPublicIpAddress) Test associate public IP within the project ... skipped 'skip' test_08_security_group (test_project_resources_fixed.TestSecurityGroup) Test security groups in project ... skipped 'skip' test_06_create_snapshots_in_project (test_project_resources_fixed.TestSnapshots) Test create snapshots in project ... skipped 'skip' test_04_public_template_use_in_project (test_project_resources_fixed.TestTemplates) Test Templates creation in projects ... skipped 'skip' test_05_use_private_template_in_project (test_project_resources_fixed.TestTemplates) Test use of private template in a project ... skipped 'skip' -- Ran 8 tests in 479.325s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Engage cloudStack project
Hi Malintha, Should be a good starting point for you I think: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Development+101 Keep in touch in mail list and enjoy IRC #cloudstack-dev. Cheers, --Tuna On Tue, Dec 3, 2013 at 6:06 PM, Malintha Adikari malin...@wso2.com wrote: Hi, I am Malintha Adikari from Sri Lanka ,a fresh engineer who works in an open source software company and I want to engage cloudStack project. I am very interesting in cloud computing concepts but I have least hands-on experience. I am experience in Java and C development.I have checked out the source and go through the documentation ( some sections were difficult to understand for me). What should be my first steps ? Can I build and run the source code ? Could you please give me suggestions to get start Thank you, -- *Malintha Adikari* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 71 2312958
Review Request 15963: CLOUDSTACK-5347: Resolved issue related to snapshot state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/ --- Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5347 https://issues.apache.org/jira/browse/CLOUDSTACK-5347 Repository: cloudstack-git Description --- The test case component.test_project_resources.TestSnapshots.test_06_create_snapshots_in_project failed due to Check Snapshot state is Running or not It was checking the snapshot state only in (CreatedOnPrimary, BackedUp). The snapshot could also be in Allocated state. Snapshot is always first in allocated state, then createdOnPrimary and finally BackedUp. included Allocated state in the list. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15963/diff/ Testing --- Tested locally in XenServer advanced setup. Thanks, Gaurav Aradhye
Regarding systemvm jenksin job
Hi All, I had triggered the (generate systemvm64 bit) Jenkins job as I had made some changes for the HyperV systemvm template. Job was successfully but from the log I didn't see any message where the archive got published. Can anyone please let me know how to download the newly generated image? Thanks Rajesh Battala
RE: Ldap APIs
Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
Re: Ldap APIs
Why are they even changing? Once we publish an API, we should stick with it... otherwise we have to bump to version 5.0.0 for our next feature release. On Tue, Dec 3, 2013 at 10:01 AM, Suresh Sadhu suresh.sa...@citrix.com wrote: Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
RE: Ldap APIs
They were removed before i got started on ACS. Ian/abhi should be able to answer. Thanks, - Rajani From: Chip Childers [chipchild...@apache.org] Sent: Tuesday, December 03, 2013 8:48 PM To: dev@cloudstack.apache.org Subject: Re: Ldap APIs Why are they even changing? Once we publish an API, we should stick with it... otherwise we have to bump to version 5.0.0 for our next feature release. On Tue, Dec 3, 2013 at 10:01 AM, Suresh Sadhu suresh.sa...@citrix.com wrote: Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
RE: persistence layer
Hello Darren, I'm reading your reply - I shall post comments when I've got through it completely. -Original Message- From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] Sent: 02 December 2013 17:33 To: dev@cloudstack.apache.org Subject: Re: persistence layer Alright, this is long . I have to say after the 10+ years of struggling with JDBC, Hibernate, JbdcTemplate, JPA, QueryDSL, and countless custom solutions, I've have never found a database access solution that has impressed me as much as jooq. If I was starting from scratch today I'd definitely choose jooq. Now all of that doesn't matter though. Evaluating database access solutions in isolation is about as productive as discussing if c++ or java is a better language. The answer being it depends. We really need to ground this discussion in the realities of what ACS is today, what are the issues and where do we want to go. Nobody is going to sign on to a complete gut and rewrite of the data acces layer (DAL), so any solution must allow a slow migration to it. Current solution ACS currently has a completely custom DAL. While the VOs are annotated with JPA annotations it is dangerous to compare the custom ACS framework to JPA as the differences are substantial. It is also important to note that ACS does not have a ORM today. There is no relational mapping. The ACS DAL can be broken down to five parts. 1) DAO framework (GenericDao) 2) object mapping 3) query api 4) crud w/ change tracking 5) transaction management DAO framework ACS has a strict 1-to-1 mapping of VO to DAO. The generic DAO provides the common methods like findById that you see in most java DAOs. The generic DAO uses reflection to query the VOs JPA annotations to build up the metadata for the crud operations and query building. Object mapping === The metadata obtained through the GenericDao is used to map sql to the VOs. If you use the GenericDaos findX or listByX methods or the query api it will map the result to a VO. Additionally if you update a VO and persist it the mapper will generate SQL from the VO. Query API ACS has a search builder api that allows you to build sql queries in a type safe manner. The functionality is mostly limited to basically conditions and joins. The api works for most of the use cases in ACS but still there a quite a lot of raw sql statements in ACS because the api is not functional enough. CRUD with changing tracking = When POJOs are created by the GenericDao they are enhanced with cglib. All changes to the pojos are tracked as updates. When persist is called the updated fields are used to construct an update. Transaction management === Transactions are managed programmatically through the transaction api. Nested transactions and transaction propagation are not supported. Isolation level is determined at the DB pool level, so all connections have the same level which is read committed. Problems The general problems of the dal in ACS is that it's 100% custom. The APIs, especially around transactions and querying, are often a stumbling block for people developing in ACS. Additionally, since this is all custom, the maintenance and enhancements of the DAL is solely the responsibility of the ACS community. Finally, very little documentation exists around all of this, and there is realistically about 3 people who understand the core implementation. You have to consider that ACS was started almost 5 years ago. I can understand the creators not wanting to use hibernate or spring and instead rolling their own solutions. The problem with rolling your own solution typically ends up being that your use cases start off simple and your custom framework does too. As the product matures and more complex use cases are tackled things are no longer simple. You are then forced to enhance your simple framework, but then the warts start to really show. Or, you start bypassing it because it is too limiting. DAO framework I don't have major fundamental complaints with the DAOs. The API exposed is fairly consistent with most DAOs you would see in any java application. The main complaint I have is the strict 1-to-1 mapping between VO and DAO. In general I don't like that design pattern and prefer to group DAOs according to function and not tables. That's an opinion and I think the larger java community tends to disagree with me. So I concede on that point. The bigger problem with the 1-to-1 model is extensibility. Today, if you are writing a new plugin and need to execute some query that doesn't exist today, you really don't have much choice but to change the existing DAO in the core. This leads to people instead of doing DB logic in a DAO, they end up doing it in the services classes which is just bad. Object mapping === The object mapping in ACS is quite simple. Since there is no relational mapping, it just basically does the equivalent of
RE: ANNOUNCE] New Committer: Giles Sirett
Yes, Well done! Alexander Hitchins -Original Message- From: Tariq Iqbal [mailto:tariq.iq...@shapeblue.com] Sent: 03 December 2013 09:22 To: dev@cloudstack.apache.org Cc: Giles Sirett Subject: RE: ANNOUNCE] New Committer: Giles Sirett Congratulations Giles! Kind Regards, Tariq Iqbal Senior Consultant S: +44(0)20 3603 0540 | M: +44(0)790 9911600 tariq.iq...@shapeblue.com | www.shapeblue.com | Twitter:@shapeBlue ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS From: John Burwell jburw...@basho.com Sent: 02 December 2013 16:06 To: dev@cloudstack.apache.org Cc: Giles Sirett Subject: ANNOUNCE] New Committer: Giles Sirett The Project Management Committee (PMC) for Apache CloudStack has asked Giles Sirett to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Giles! - John Burwell, on behalf of the Apache CloudStack PMC This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: Review Request 15725: CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils (master)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15725/ --- (Updated Dec. 3, 2013, 4:50 p.m.) Review request for cloudstack. Changes --- Updating patch so it will work on master Bugs: CLOUDSTACK-5220 https://issues.apache.org/jira/browse/CLOUDSTACK-5220 Repository: cloudstack-git Description --- CLOUDSTACK-5022: NullPointerException when invalid zone is passed into UsageEventUtils Updated UsageEventUtils code to not blow up when an invalid zone ID is passed in. Now will still generate usage event but leaving out zone UUID. Diffs (updated) - engine/components-api/src/com/cloud/event/UsageEventUtils.java e71afb0 Diff: https://reviews.apache.org/r/15725/diff/ Testing --- built on master Thanks, David Grizzanti
Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/ --- (Updated Dec. 3, 2013, 5:07 p.m.) Review request for cloudstack. Changes --- To fix what Koushik Das pointed out. Repository: cloudstack-git Description --- When a host is switched to the 'maintenance mode', the vms in that host are migrated to another available hosts. Currently, the vm migrations are executed sequentially, it can take a lot of time when there are quite number of vms. So I changed 'MigrateCommand' to get the value of 'executeInSequence' property from the global setting value of 'execute.in.sequence.hypervisor.commands' so that users can execute the migrations in parallel to save time. Diffs (updated) - core/src/com/cloud/agent/api/MigrateCommand.java 0d8f70c engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 setup/db/db/schema-410to420.sql 522ccc4 setup/db/db/schema-410to420.sql 522ccc4 setup/db/db/schema-430to440.sql 9bb9602 Diff: https://reviews.apache.org/r/15763/diff/ Testing --- Tested in the simulator mode and Xen servers. Thanks, Alex Ough
Re: A question on vm migrations when hosts are set into a maintenance mode.
Thank Koushik, and I modified what you pointed out (for 'MigrateCommand' text) and updated the diffs. Let me know if there is anything missing/incorrect. Thanks Alex Ough On Tue, Dec 3, 2013 at 2:46 AM, Koushik Das koushik@citrix.com wrote: I have posted my review comments. Except for a few minor comments changes look good to me. -Koushik On 02-Dec-2013, at 9:15 PM, Alex Ough alex.o...@sungard.com wrote: All, It's been a while since this review was requested, so can anyone review this to move on? Thanks in advance. Alex Ough On Fri, Nov 22, 2013 at 11:51 AM, Alex Ough alex.o...@sungard.com wrote: Thanks to help from many developers, I sent my first review request in the cloudstack, https://reviews.apache.org/r/15763/, so please take a look at it and let me know if there is anything missing/incorrect. Thanks again. Alex Ough On Thu, Nov 21, 2013 at 10:09 AM, Alex Ough alex.o...@sungard.com wrote: Hi Wido, Related with the 'disk_offering.cache_mode', I found that there is a sql file to add that column, which is 'cloudstack/ developer/target/db/db/schema-430to440.sql'. But after running it manually, I have another error saying that the 'cache_mode' cannot be null, so I just changed the column to allow null to move on. So you may include the sql file and allow null in that column. Thanks Alex Ough On Wed, Nov 20, 2013 at 3:45 PM, Alex Huang alex.hu...@citrix.com wrote: Wido, Looks like you didn’t update your schema file or forgot to add a schema upgrade file in master? See the error described by Alex below. @Alex You can probably remove the cachemode field in the DiskOfferingVO for now. Or revert 1edaa36 on your local repo to keep moving forward. --Alex *From:* Alex Ough [mailto:alex.o...@sungard.com] *Sent:* Wednesday, November 20, 2013 9:56 AM *To:* Alex Huang *Cc:* dev@cloudstack.apache.org *Subject:* Re: A question on vm migrations when hosts are set into a maintenance mode. Hi Alex, It looks like you moved the 'ExecuteInSequence' to the vm level from the management server, which seems to be ok, but at this time I cannot test it because when I try to start up the management server, it fails because of database schema error, which is 'Unknown column 'disk_offering.cache_mode' in 'field list' even if I re-built the database. Is the schema change part of your changes or something other developer changed? If that is from any other developer, can you fix this? Thanks Alex Ough On Tue, Nov 19, 2013 at 7:25 PM, Alex Huang alex.hu...@citrix.com wrote: Alex, Can you do a pull from master and see if my fix fits your needs. Unfortunately, I’m on the road and couldn’t do an actual test of it. --Alex *From:* Alex Huang *Sent:* Tuesday, November 19, 2013 4:45 AM *To:* 'Alex Ough'; dev@cloudstack.apache.org *Subject:* RE: A question on vm migrations when hosts are set into a maintenance mode. Alex, Sorry for the late reply. Been travelling the last couple of weeks. I’ll look into this today. --Alex *From:* Alex Ough [mailto:alex.o...@sungard.com alex.o...@sungard.com] *Sent:* Monday, November 18, 2013 6:17 AM *To:* dev@cloudstack.apache.org *Cc:* Alex Huang *Subject:* Re: A question on vm migrations when hosts are set into a maintenance mode. Thank Parasanna Sebastien, I also got his email and sent an email. Waiting for his reply... Thanks Alex Ough On Sat, Nov 16, 2013 at 3:05 PM, Sebastien Goasguen run...@gmail.com wrote: cc Alex Huang to get his attention: On Nov 15, 2013, at 10:17 PM, Prasanna Santhanam t...@apache.org wrote: Alex, Could you just do a git blame on the file and copy the emails of people who changed that bit of code? They may be able to help if Cc-ed directly. Thanks, On Fri, Nov 15, 2013 at 01:49:07PM -0600, Alex Ough wrote: I hate to sending the same emails over and over again, but I really need to finalize this feature to be included in the next code freeze because this feature is very critical in our inside project. Anyone who can help, please? Thanks Alex Ough On Thu, Nov 14, 2013 at 1:27 PM, Alex Ough alex.o...@sungard.com wrote: Not sure if Alex Huang checked this, but can anyone help to resolve this? Thanks Alex Ough On Wed, Nov 13, 2013 at 11:39 AM, Alex Ough alex.o...@sungard.com wrote: It sounds a little scary... I looked at the history and found these. 8/9/ : file moved to engine by Alex Huang 9/16 : '_mgmtServer.getExecuteInSequence()' changed to 'getExecuteInSequence()' by Alex Huang Hi Alex Huang, I'm not sure if you're aware of this, but can you check this for me? Thanks Alex Ough On Wed, Nov 13, 2013 at 11:18 AM,
Re: [VOTE] 2nd round of voting for ASF 4.2.1 RC
I'm going to vote -1 on this one. I think https://issues.apache.org/jira/browse/CLOUDSTACK-5145 should be addressed as cloudstack is leaking data from users to other users who don't own the data. The data isn't extremely sensitive, it only gives away vpc ids that you don't own and acl information (port, protocol, cidr), but nothing about who owns them and where they're applied. It does however break the behavior of the API for those consuming it and will impact performance since all ACLs in the system are dumped, so I think it warrants blocker status. I took a look at fixing it myself, but am thus far pretty confused at how data access is supposed to work. Most other examples I could find extended ControlledEntity, and thus had the account/domain info in the table. The network ACL items don't (Only extending InternalIdentity), which requires either a schema change or a double join to get to the account owner. Since I get the feeling that I don't know what I'm doing, I'm at the mercy of someone else to help fix it. On Tue, Dec 3, 2013 at 5:48 AM, sebgoa run...@gmail.com wrote: On Dec 3, 2013, at 1:24 PM, Abhinandan Prateek abhinandan.prat...@citrix.com wrote: Hi All, There were some issues found in the 4.2.1 RC that was earlier approved by voters. As a result the RC has to be re-spun. There is not much of a difference between this and the one approved earlier apart from some additional fixes. Can you be more specific ? what fixes required a re-vote ? also looking at the changes file, it lists new features in 4.2.1, yet this is a bug fix release that should not have new features. The current vote is to approve the current RC build for 4.2.1 maintenance release. For this particular release various upgrade paths have been tested apart from regression tests and BVTs. Around 175 bugs have been fixed some new features added (see Release Notes). Following are the particulars for this release: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.2 commit: 6ba071b159f5da6f86ff1b48cd6c2d555d60124d List of changes are available in Release Notes, a summary can be accessed here: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.2 Source release revision 3816 (checksums and signatures are available at the same location): https://dist.apache.org/repos/dist/dev/cloudstack/4.2.1/ PGP release keys (signed using RSA Key ID = 42443AA1): https://dist.apache.org/repos/dist/release/cloudstack/KEYS Vote will be open for 72 hours (until 12/05 End of day PST). For sanity in tallying the vote, can PMC members please be sure to indicate (binding) with their vote? [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why)
Re: [VOTE] 2nd round of voting for ASF 4.2.1 RC
On Tue, Dec 3, 2013 at 7:48 AM, sebgoa run...@gmail.com wrote: Can you be more specific ? what fixes required a re-vote ? There was a security vulnerability reported in the release of sufficient severity to cause the security team to request Abhi hold off on publishing the release and to re-spin.
Re: Request: Help designing a 'powered by' logo for CloudStack
I'm going to miss the monkey. Are you sure there's not any way to work it in?? Regards, Kirk Jantzer http://about.me/kirkjantzer On Tue, Dec 3, 2013 at 1:13 PM, Laszlo Hornyak laszlo.horn...@gmail.comwrote: Hi, Thank you all for the feedback! - stretching: yes, that is true and it does not look good - apache: If I have to put the apache there, then I will have to completely rearrange the design. Are you sure it is a must-have? Wikipedia displays a logo without the apache. http://en.wikipedia.org/wiki/Apache_CloudStack - etc: the powered by font type does not go well with the cloudstack I go back to my drawing board and see what I can do for v0.0.2 On Tue, Dec 3, 2013 at 11:31 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: I like, 2. But I agree with Rbyn about the word apache. I should be in there. I think it must even. 1. It looks streched on my preview in finder as well On Mon, Dec 2, 2013 at 9:47 PM, Robyn Bergeron rberg...@redhat.com wrote: - Original Message - From: Laszlo Hornyak laszlo.horn...@gmail.com To: dev@cloudstack.apache.org Cc: market...@cloudstack.apache.org Sent: Sunday, December 1, 2013 10:31:11 AM Subject: Re: Request: Help designing a 'powered by' logo for CloudStack Hi, Here is my version: - SVG format as you requested - Only two colors, exactly the same as for the original logo. I prefer few colors for such pictures - Unfortunately the monkey could not make it, the whole thing needs to fit into a very small area and the monkey would be too little detail (the monkey is übercool anyway) - if no monkey, then cloud - only powered by cloudstack, no extra text because it make make difficult to read in such a small place - see attached file :) Hi, I like the cloud idea/placement. (And totally get that it's going to be hard to see the monkey in such a small space. Even though he's so cute.) Two things - 1) The lettering in the word cloudstack looks stretched as compared with the normal look of the font - I'm not sure if that's intentional, not intentional, something really weird in how it's rendering on my screen... :) 2) I realize the problem around no extra text but ... do we want to add in the word apache? (or conversely, is there any reason why it shouldn't be added in... legal, etc)? -robyn On Fri, Nov 15, 2013 at 6:56 PM, David Nalley da...@gnsa.us wrote: Hi folks: If you happen to have some graphical design talent (I have none) I have a great opportunity for you :) CloudStack needs a 'powered by' logo that is easy to consume, and is also attractive. A couple examples of powered by logos: http://tomcat.apache.org/images/tomcat-power.gif https://cwiki.apache.org/confluence/download/attachments/80899/mahout-logo-poweredby-100.png?version=1modificationDate=1312880703000 https://netbeans.org/images_www/screenshots/6.0/baseIDE_ant_powered_150px.png A couple of constraints: * Please don't use the Apache feather. (we could, but lets not; it will make life simpler) * Please try and produce a vector format as source (this allows us to scale/etc) * Because this will become a trademark (which is vastly different that copyright) - we will likely need some explicit email agreement around trademarks rights for the image. (I promise, it isn't as scary as that sentence makes it out to be.) Anyone interested? --David -- EOF -- EOF
Re: Request: Help designing a 'powered by' logo for CloudStack
Hi, Thank you all for the feedback! - stretching: yes, that is true and it does not look good - apache: If I have to put the apache there, then I will have to completely rearrange the design. Are you sure it is a must-have? Wikipedia displays a logo without the apache. http://en.wikipedia.org/wiki/Apache_CloudStack - etc: the powered by font type does not go well with the cloudstack I go back to my drawing board and see what I can do for v0.0.2 On Tue, Dec 3, 2013 at 11:31 AM, Daan Hoogland daan.hoogl...@gmail.comwrote: I like, 2. But I agree with Rbyn about the word apache. I should be in there. I think it must even. 1. It looks streched on my preview in finder as well On Mon, Dec 2, 2013 at 9:47 PM, Robyn Bergeron rberg...@redhat.com wrote: - Original Message - From: Laszlo Hornyak laszlo.horn...@gmail.com To: dev@cloudstack.apache.org Cc: market...@cloudstack.apache.org Sent: Sunday, December 1, 2013 10:31:11 AM Subject: Re: Request: Help designing a 'powered by' logo for CloudStack Hi, Here is my version: - SVG format as you requested - Only two colors, exactly the same as for the original logo. I prefer few colors for such pictures - Unfortunately the monkey could not make it, the whole thing needs to fit into a very small area and the monkey would be too little detail (the monkey is übercool anyway) - if no monkey, then cloud - only powered by cloudstack, no extra text because it make make difficult to read in such a small place - see attached file :) Hi, I like the cloud idea/placement. (And totally get that it's going to be hard to see the monkey in such a small space. Even though he's so cute.) Two things - 1) The lettering in the word cloudstack looks stretched as compared with the normal look of the font - I'm not sure if that's intentional, not intentional, something really weird in how it's rendering on my screen... :) 2) I realize the problem around no extra text but ... do we want to add in the word apache? (or conversely, is there any reason why it shouldn't be added in... legal, etc)? -robyn On Fri, Nov 15, 2013 at 6:56 PM, David Nalley da...@gnsa.us wrote: Hi folks: If you happen to have some graphical design talent (I have none) I have a great opportunity for you :) CloudStack needs a 'powered by' logo that is easy to consume, and is also attractive. A couple examples of powered by logos: http://tomcat.apache.org/images/tomcat-power.gif https://cwiki.apache.org/confluence/download/attachments/80899/mahout-logo-poweredby-100.png?version=1modificationDate=1312880703000 https://netbeans.org/images_www/screenshots/6.0/baseIDE_ant_powered_150px.png A couple of constraints: * Please don't use the Apache feather. (we could, but lets not; it will make life simpler) * Please try and produce a vector format as source (this allows us to scale/etc) * Because this will become a trademark (which is vastly different that copyright) - we will likely need some explicit email agreement around trademarks rights for the image. (I promise, it isn't as scary as that sentence makes it out to be.) Anyone interested? --David -- EOF -- EOF
Re: [PROPOSAL] Alert publishing via API
Here is the link for the FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Alert+publishing+via+Web+ROOT+admin+API -Alena. From: Alena Prokharchyk alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com Date: Monday, November 25, 2013 12:55 PM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: [PROPOSAL] Alert publishing via API Third party systems integrating with CloudStack should be able to publish custom alerts to the CS. Existing alerts might not be enough for a particular application purposes, and adding new one while utilizing the existing CS Alert notification system, can be quite useful. Currently there is no way to publish an alert through the web API; it can be done only by direct calls to the AlertManager. So the proposal would be - add a new API (with ROOT admin permissions) allowing to publish the alerts to CS system. Jira ticket ref is created [1]. I'll send the update with FS link if nobody objects on the proposal. Thank you, Alena. [1] https://issues.apache.org/jira/browse/CLOUDSTACK-5261
Re: [Discuss] AutoScaling.next in CloudStack
Agree that we should have at least 1 implemented monitoring plugin. Before we jump into SNMP etc, I'd like to see the public interfaces of the monitoring and AS services. In the figure I had sketched out, I'd like to see the specifications of all the APIs. We can then enumerate the autoscaling workflows and see if the APIs are sufficient. Some of the flows are: 1. Create a launch configuration 2. Create AS group using the launch config in #1 3. Scheduled scaling 4. Dynamic (load-based) scale up and down On 12/3/13 2:54 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: On Tue, Dec 3, 2013 at 10:03 AM, Nguyen Anh Tu t...@apache.org wrote: + what SNMP software we use? I found Net-SNMP but not sure it's okie. Need to try and review it. There are a lot of oopen source and commercial once out there. We need an open source one. Given that we are probably going to have to do some work on the library our selves, I think license compatability with apache deserves the greatest consideration. + what metric we decide to monitor for AS action? I think we should design a solution that reads from a configuration file what mibs/oids to query from what device. So we don't need to make this decision in this (design) phase
Re: Regarding systemvm jenksin job
http://jenkins.buildacloud.org/view/master/job/build-systemvm-master/ ? On 12/3/13 6:47 AM, Rajesh Battala rajesh.batt...@citrix.com wrote: Hi All, I had triggered the (generate systemvm64 bit) Jenkins job as I had made some changes for the HyperV systemvm template. Job was successfully but from the log I didn't see any message where the archive got published. Can anyone please let me know how to download the newly generated image? Thanks Rajesh Battala
Re: ANNOUNCE] New Committer: Giles Sirett
Congrats Giles !!!. On 03/12/13 8:40 AM, Alex Hitchins cloudst...@alexhitchins.com wrote: Yes, Well done! Alexander Hitchins -Original Message- From: Tariq Iqbal [mailto:tariq.iq...@shapeblue.com] Sent: 03 December 2013 09:22 To: dev@cloudstack.apache.org Cc: Giles Sirett Subject: RE: ANNOUNCE] New Committer: Giles Sirett Congratulations Giles! Kind Regards, Tariq Iqbal Senior Consultant S: +44(0)20 3603 0540 | M: +44(0)790 9911600 tariq.iq...@shapeblue.com | www.shapeblue.com | Twitter:@shapeBlue ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS From: John Burwell jburw...@basho.com Sent: 02 December 2013 16:06 To: dev@cloudstack.apache.org Cc: Giles Sirett Subject: ANNOUNCE] New Committer: Giles Sirett The Project Management Committee (PMC) for Apache CloudStack has asked Giles Sirett to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Giles! - John Burwell, on behalf of the Apache CloudStack PMC This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: Request: Help designing a 'powered by' logo for CloudStack
I will give it a try, but we can not have all and everything in 120x80 pixels. I have a not quite complete, reverse-engineered svg monkey, feel free to reuse it. On Tue, Dec 3, 2013 at 7:19 PM, Kirk Jantzer kirk.jant...@gmail.com wrote: I'm going to miss the monkey. Are you sure there's not any way to work it in?? Regards, Kirk Jantzer http://about.me/kirkjantzer On Tue, Dec 3, 2013 at 1:13 PM, Laszlo Hornyak laszlo.horn...@gmail.com wrote: Hi, Thank you all for the feedback! - stretching: yes, that is true and it does not look good - apache: If I have to put the apache there, then I will have to completely rearrange the design. Are you sure it is a must-have? Wikipedia displays a logo without the apache. http://en.wikipedia.org/wiki/Apache_CloudStack - etc: the powered by font type does not go well with the cloudstack I go back to my drawing board and see what I can do for v0.0.2 On Tue, Dec 3, 2013 at 11:31 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: I like, 2. But I agree with Rbyn about the word apache. I should be in there. I think it must even. 1. It looks streched on my preview in finder as well On Mon, Dec 2, 2013 at 9:47 PM, Robyn Bergeron rberg...@redhat.com wrote: - Original Message - From: Laszlo Hornyak laszlo.horn...@gmail.com To: dev@cloudstack.apache.org Cc: market...@cloudstack.apache.org Sent: Sunday, December 1, 2013 10:31:11 AM Subject: Re: Request: Help designing a 'powered by' logo for CloudStack Hi, Here is my version: - SVG format as you requested - Only two colors, exactly the same as for the original logo. I prefer few colors for such pictures - Unfortunately the monkey could not make it, the whole thing needs to fit into a very small area and the monkey would be too little detail (the monkey is übercool anyway) - if no monkey, then cloud - only powered by cloudstack, no extra text because it make make difficult to read in such a small place - see attached file :) Hi, I like the cloud idea/placement. (And totally get that it's going to be hard to see the monkey in such a small space. Even though he's so cute.) Two things - 1) The lettering in the word cloudstack looks stretched as compared with the normal look of the font - I'm not sure if that's intentional, not intentional, something really weird in how it's rendering on my screen... :) 2) I realize the problem around no extra text but ... do we want to add in the word apache? (or conversely, is there any reason why it shouldn't be added in... legal, etc)? -robyn On Fri, Nov 15, 2013 at 6:56 PM, David Nalley da...@gnsa.us wrote: Hi folks: If you happen to have some graphical design talent (I have none) I have a great opportunity for you :) CloudStack needs a 'powered by' logo that is easy to consume, and is also attractive. A couple examples of powered by logos: http://tomcat.apache.org/images/tomcat-power.gif https://cwiki.apache.org/confluence/download/attachments/80899/mahout-logo-poweredby-100.png?version=1modificationDate=1312880703000 https://netbeans.org/images_www/screenshots/6.0/baseIDE_ant_powered_150px.png A couple of constraints: * Please don't use the Apache feather. (we could, but lets not; it will make life simpler) * Please try and produce a vector format as source (this allows us to scale/etc) * Because this will become a trademark (which is vastly different that copyright) - we will likely need some explicit email agreement around trademarks rights for the image. (I promise, it isn't as scary as that sentence makes it out to be.) Anyone interested? --David -- EOF -- EOF -- EOF attachment: monkey.svg
Re: Review Request 15521: Fixed issue with DataStoreDrivers not being able to throw meaningful errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15521/#review29679 --- Ship it! Ship It! - edison su On Dec. 3, 2013, 6:58 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15521/ --- (Updated Dec. 3, 2013, 6:58 p.m.) Review request for cloudstack, Alena Prokharchyk, edison su, and Mike Tutkowski. Repository: cloudstack-git Description --- Added the exception message to errors thrown by DataStoreDrivers in StorageManagerImpl to the rethrown exceptions. Diffs - api/src/org/apache/cloudstack/api/ServerApiException.java 1a740d5 server/src/com/cloud/storage/StorageManagerImpl.java e81e30e Diff: https://reviews.apache.org/r/15521/diff/ Testing --- Thanks, Chris Suich
Re: [VOTE] 2nd round of voting for ASF 4.2.1 RC
H Marcus, It breaks behavior of the API, you say. Is this in comparison to 4.2 or to prior versions? thanks, Daan On Tue, Dec 3, 2013 at 6:40 PM, Chip Childers chipchild...@apache.org wrote: On Tue, Dec 3, 2013 at 7:48 AM, sebgoa run...@gmail.com wrote: Can you be more specific ? what fixes required a re-vote ? There was a security vulnerability reported in the release of sufficient severity to cause the security team to request Abhi hold off on publishing the release and to re-spin.
Re: [VOTE] 2nd round of voting for ASF 4.2.1 RC
Running the same API call on versions lower than 4.2.0 yields correct results, since 4.2.0 the API call returns incorrect data. The API itself is compatible, but for example if an application or user consuming the API makes those calls it will get incorrect data. For example, you now may get a hundred entries for port 22 open to 0.0.0.0/0 in your response, when only one of them is owned by you. On Tue, Dec 3, 2013 at 2:48 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Marcus, It breaks behavior of the API, you say. Is this in comparison to 4.2 or to prior versions? thanks, Daan On Tue, Dec 3, 2013 at 6:40 PM, Chip Childers chipchild...@apache.org wrote: On Tue, Dec 3, 2013 at 7:48 AM, sebgoa run...@gmail.com wrote: Can you be more specific ? what fixes required a re-vote ? There was a security vulnerability reported in the release of sufficient severity to cause the security team to request Abhi hold off on publishing the release and to re-spin.
Re: persistence layer
On 12/2/13, 5:00 PM, Frank Zhang frank.zh...@citrix.com wrote: It's really long I don't know if it's impossible to move us to JPA but I do agree that whatever path we choose it's lot of work to do. Given you have tried JOOQ and Lukas's explanation, my only concern is if we can leverage Spring TX with JOOQ. Especially we just moved to Spring TX recently. I agree most of your statements except DAO pattern. IMO, we should get rid of this pattern at all. No matter how Java community prefers it, I always think DAO is an anti-pattern that should have never been existing. There is no standard for implementing a DAO. But all implementation has below problems: 1. unnecessary All DAO have different persistence methods for different domain objects. For example. CustomerDao.saveCustomer(...) CustomerDao.updateCustomer(...) OrderDao.saveOrder(...) OrderDao.updateOrder(...) Why do we need so many interfaces? Why not simply use EntityManager.persist(CustomerVO); EntityManager.persist(OrderVO); EntityManager.update(CustomerVO); EntityManager.update(OrderVO); If there any special interests(rare case), using an entity listener can solve it perfectly 2. plain wrong Lots of DAO(not all) create method for every query. You have stated it lacks of extensibility. I thought it's just plain wrong. Combinations of query parameter is infinite, that's why people use SQL which is a DSL to manipulate DB because you can not enumerate all possibilities by function. Someone may argue NoSql doesn't have a language like SQL. But if you look into NoSQL query functions, they are DSL in essence. DSL like SQL is called external DSL which needs a parser, DSL like NoSql query function is called internal DSL which uses facilities provided by host programming language. So when we create DAO like: CustomerDao.findCustomerByLastName(...) CustomerDao.findCustomerByFirstName(...) CustomerDao.findCustomerByFirstAndLastName(...) We are wrong. My suggestion is, once we switch to new ORM, we should never create DAO anymore. We can have a single interface to do CRUD, and directly use ORM like JOOQ to do the query. Someone may argue again this will duplicate query. That's true but doesn't matter. To get flexibility and extensibility, duplicate code is a necessary sacrifice. We can put the most common query that is queried by primary key in CRUD interface, for others, just create a query criteria or JOOQ fluent query on demand. +1. I know Alex has already added entity manager trying to get rid of unnecessary DAO methods, but due to the way on how we construct queries, we still have to rely on individual DAOs. A simple CRUD mechanism and SQL compatible query(agnostic to underlying DB) would be enough for most of persistence needs in CloudStack. -Original Message- From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com] Sent: Monday, December 02, 2013 9:33 AM To: dev@cloudstack.apache.org Subject: Re: persistence layer Alright, this is long.. I have to say after the 10+ years of struggling with JDBC, Hibernate, JbdcTemplate, JPA, QueryDSL, and countless custom solutions, I've have never found a database access solution that has impressed me as much as jooq. If I was starting from scratch today I'd definitely choose jooq. Now all of that doesn't matter though. Evaluating database access solutions in isolation is about as productive as discussing if c++ or java is a better language. The answer being it depends. We really need to ground this discussion in the realities of what ACS is today, what are the issues and where do we want to go. Nobody is going to sign on to a complete gut and rewrite of the data acces layer (DAL), so any solution must allow a slow migration to it. Current solution ACS currently has a completely custom DAL. While the VOs are annotated with JPA annotations it is dangerous to compare the custom ACS framework to JPA as the differences are substantial. It is also important to note that ACS does not have a ORM today. There is no relational mapping. The ACS DAL can be broken down to five parts. 1) DAO framework (GenericDao) 2) object mapping 3) query api 4) crud w/ change tracking 5) transaction management DAO framework ACS has a strict 1-to-1 mapping of VO to DAO. The generic DAO provides the common methods like findById that you see in most java DAOs. The generic DAO uses reflection to query the VOs' JPA annotations to build up the metadata for the crud operations and query building. Object mapping === The metadata obtained through the GenericDao is used to map sql to the VOs. If you use the GenericDaos findX or listByX methods or the query api it will map the result to a VO. Additionally if you update a VO and persist it the mapper will generate SQL from the VO. Query API ACS has a search builder api that allows you to build sql queries in a type safe manner. The functionality is mostly limited to
test failures
Does anybody experience this test failure on the latest master? Results : Tests in error: getColumnName(com.cloud.utils.DbUtilTest) getColumnName(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy isPersistable(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy isPersistable(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getTableName(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getTableName(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getGlobalLock(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getGlobalLock(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getGlobalLockTimeout(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getGlobalLockTimeout(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy closeNull(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy closeNull(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy
Re: test failures
I am encountering the same. Thanks -min On 12/3/13 4:41 PM, Alena Prokharchyk alena.prokharc...@citrix.com wrote: Does anybody experience this test failure on the latest master? Results : Tests in error: getColumnName(com.cloud.utils.DbUtilTest) getColumnName(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy isPersistable(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy isPersistable(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getTableName(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getTableName(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getGlobalLock(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getGlobalLock(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getGlobalLockTimeout(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy getGlobalLockTimeout(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy closeNull(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy closeNull(com.cloud.utils.DbUtilTest): Could not initialize class com.cloud.utils.db.TransactionLegacy
Jenkins build is back to normal : build-master » Apache CloudStack AWS API Bridge #101
See http://jenkins.buildacloud.org/job/build-master/org.apache.cloudstack$cloud-awsapi/101/
Re: Engage cloudStack project
Hi Tuna, Thank you very much for the reply. I will keep in touch and try to get in as soon as possible. Thanks, On Tue, Dec 3, 2013 at 7:46 PM, Nguyen Anh Tu t...@apache.org wrote: Hi Malintha, Should be a good starting point for you I think: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Development+101 Keep in touch in mail list and enjoy IRC #cloudstack-dev. Cheers, --Tuna On Tue, Dec 3, 2013 at 6:06 PM, Malintha Adikari malin...@wso2.com wrote: Hi, I am Malintha Adikari from Sri Lanka ,a fresh engineer who works in an open source software company and I want to engage cloudStack project. I am very interesting in cloud computing concepts but I have least hands-on experience. I am experience in Java and C development.I have checked out the source and go through the documentation ( some sections were difficult to understand for me). What should be my first steps ? Can I build and run the source code ? Could you please give me suggestions to get start Thank you, -- *Malintha Adikari* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 71 2312958 -- *Malintha Adikari* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 71 2312958
RE: Regarding systemvm jenksin job
Yes. Thanks I got it -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Wednesday, December 4, 2013 12:04 AM To: dev@cloudstack.apache.org Subject: Re: Regarding systemvm jenksin job http://jenkins.buildacloud.org/view/master/job/build-systemvm-master/ ? On 12/3/13 6:47 AM, Rajesh Battala rajesh.batt...@citrix.com wrote: Hi All, I had triggered the (generate systemvm64 bit) Jenkins job as I had made some changes for the HyperV systemvm template. Job was successfully but from the log I didn't see any message where the archive got published. Can anyone please let me know how to download the newly generated image? Thanks Rajesh Battala
Re: Ldap APIs
We need to have the pre-existing API¹s working. Also I am not sure if we can even mark these depreciated in 4.3. We can move to the new and more flexible APIs completely in 5.0 release and deprecate the current APIs. On 03/12/13 9:28 pm, Rajani Karuturi rajani.karut...@citrix.com wrote: They were removed before i got started on ACS. Ian/abhi should be able to answer. Thanks, - Rajani From: Chip Childers [chipchild...@apache.org] Sent: Tuesday, December 03, 2013 8:48 PM To: dev@cloudstack.apache.org Subject: Re: Ldap APIs Why are they even changing? Once we publish an API, we should stick with it... otherwise we have to bump to version 5.0.0 for our next feature release. On Tue, Dec 3, 2013 at 10:01 AM, Suresh Sadhu suresh.sa...@citrix.com wrote: Rajani, Is there any specific reason for removing existing API's.why don't we show them as deprecated api but still it should work right Regards Sadhu -Original Message- From: Chip Childers [mailto:chip.child...@gmail.com] Sent: 03 December 2013 18:17 To: dev@cloudstack.apache.org; Rajani Karuturi Subject: Re: Ldap APIs So we are breaking API compatibility? On Dec 3, 2013, at 7:42 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: Hi Gaurav, addLdapConfiguration and deleteLdapConfiguration are the new commands. more information is available @ https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+user+provi sioning -- Thanks, Rajani Original Message- Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:%22...@cloudstack.apache.org%22%20%3 c...@cloudstack.apache.org%3e Subject: Ldap APIs Date: Tue, 3 Dec 2013 17:54:16 +0530 Hi all, When ldapConfig and ldapRemove APIs are fired, it shows error as Unknown API command. These APIs are listed under 4.2 admin API guide and we test cases to test them. Are these APIs removed recently? I am testing against 4.3. Regards, Gaurav
Re: Review Request 15897: Add certificate chain support for netscaler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15897/ --- (Updated Dec. 4, 2013, 4:44 a.m.) Review request for cloudstack and Murali Reddy. Changes --- Updated the NetscalerResource. Fixed compilation issue. Can you please check now ... sorry for the trouble. Bugs: CLOUDSTACK-5296 https://issues.apache.org/jira/browse/CLOUDSTACK-5296 Repository: cloudstack-git Description --- This patch adds support for trust chains in the netscaler. I initially planned on using the 10.1 API's bundle feature but during my testing I found that was not working. So I am doing the chain linking myself. Also NS can have only one entity of a certificate ie lets say two different users try to add the same certificate on the netscaler only one of them will go through. The other one says resouce already exists even though they have different files. This can be a problem in trust chains where the chain can be shared between multiple accounts/certificates. So, I am using the figerprint as an identifier of a certificate and making sure that we delete it only when no one references it. Diffs (updated) - .gitignore dab1b3f api/src/com/cloud/network/lb/LoadBalancingRule.java 4b2f9c4 engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java 99354c5 plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 7dac9a0 server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a2eba07 server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java 17f88bd utils/src/com/cloud/utils/security/CertificateHelper.java e8d20b0 Diff: https://reviews.apache.org/r/15897/diff/ Testing --- Testing was done a a 3-length chain with a root, intermediate and a client certificate. Two clients share the same intermediate certificate. Thanks, Syed Ahmed
Re: Engage cloudStack project
hi , deplay the cloudstack in your own machine using devcloud2 and play around it at the start. https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud this link is very helpful, thanks. On Wed, Dec 4, 2013 at 10:26 AM, Malintha Adikari malin...@wso2.com wrote: Thanks Rajani On Wed, Dec 4, 2013 at 10:20 AM, Rajani Karuturi rajani.karut...@citrix.com wrote: I would encourage you to go through the architecture overview and videos available. http://shapeblue.com/citrix/cloudstack-architecture-overview/ http://www.youtube.com/watch?v=D1K_8rvDhic part 1 http://www.youtube.com/watch?v=uSwisRfJVdM part 2 http://www.slideshare.net/cloudstack/cloudstack-architecture slides These are around an year old. But should definitely help you get started. -- Thanks, Rajani -Original Message- From: Malintha Adikari malin...@wso2.commailto: malintha%20adikari%20%3cmalin...@wso2.com%3e Reply-to: dev@cloudstack.apache.org To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Engage cloudStack project Date: Tue, 3 Dec 2013 16:36:28 +0530 Hi, I am Malintha Adikari from Sri Lanka ,a fresh engineer who works in an open source software company and I want to engage cloudStack project. I am very interesting in cloud computing concepts but I have least hands-on experience. I am experience in Java and C development.I have checked out the source and go through the documentation ( some sections were difficult to understand for me). What should be my first steps ? Can I build and run the source code ? Could you please give me suggestions to get start Thank you, -- *Malintha Adikari* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 71 2312958 -- regards, punith s cloudbyte.com
Re: Review Request 15962: CLOUDSTACK-5346: Fixed shared network cleanup issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/#review29703 --- Commit f05063f377087d41d9df5bae8680ce5121b6ec94 in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f05063f ] CLOUDSTACK-5346: Fixed shared network cleanup issue - ASF Subversion and Git Services On Dec. 3, 2013, 2:15 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/ --- (Updated Dec. 3, 2013, 2:15 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5346 https://issues.apache.org/jira/browse/CLOUDSTACK-5346 Repository: cloudstack-git Description --- component.test_project_resources.TestNetwork.test_03_network_create failed due to Exception during cleanup: Failed to delete network The test case failed to delete the shared network because it has 1 VM in it. Resolution: Deleted the VM and waited for expunge interval before proceeding to network cleanup. Other changes: Code cleanup and changes related to imports, getting free vlan and setting the startip,endip,netmask of shared network using random subnet number to avoid conflict. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15962/diff/ Testing --- Tested locally on XenServer setup. Log: test_03_network_create (test_project_resources_fixed.TestNetwork) Test create network in project ... ok test_01_service_offerings (test_project_resources_fixed.TestOfferings) Test service offerings in a project ... skipped 'skip' test_02_project_disk_offerings (test_project_resources_fixed.TestOfferings) Test project disk offerings ... skipped 'skip' test_07_associate_public_ip (test_project_resources_fixed.TestPublicIpAddress) Test associate public IP within the project ... skipped 'skip' test_08_security_group (test_project_resources_fixed.TestSecurityGroup) Test security groups in project ... skipped 'skip' test_06_create_snapshots_in_project (test_project_resources_fixed.TestSnapshots) Test create snapshots in project ... skipped 'skip' test_04_public_template_use_in_project (test_project_resources_fixed.TestTemplates) Test Templates creation in projects ... skipped 'skip' test_05_use_private_template_in_project (test_project_resources_fixed.TestTemplates) Test use of private template in a project ... skipped 'skip' -- Ran 8 tests in 479.325s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Review Request 15962: CLOUDSTACK-5346: Fixed shared network cleanup issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/#review29706 --- Commit 27c2c125d8e11cba5c58f1fcda57926832f75ebe in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=27c2c12 ] CLOUDSTACK-5346: Fixed shared network cleanup issue - ASF Subversion and Git Services On Dec. 3, 2013, 2:15 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/ --- (Updated Dec. 3, 2013, 2:15 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5346 https://issues.apache.org/jira/browse/CLOUDSTACK-5346 Repository: cloudstack-git Description --- component.test_project_resources.TestNetwork.test_03_network_create failed due to Exception during cleanup: Failed to delete network The test case failed to delete the shared network because it has 1 VM in it. Resolution: Deleted the VM and waited for expunge interval before proceeding to network cleanup. Other changes: Code cleanup and changes related to imports, getting free vlan and setting the startip,endip,netmask of shared network using random subnet number to avoid conflict. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15962/diff/ Testing --- Tested locally on XenServer setup. Log: test_03_network_create (test_project_resources_fixed.TestNetwork) Test create network in project ... ok test_01_service_offerings (test_project_resources_fixed.TestOfferings) Test service offerings in a project ... skipped 'skip' test_02_project_disk_offerings (test_project_resources_fixed.TestOfferings) Test project disk offerings ... skipped 'skip' test_07_associate_public_ip (test_project_resources_fixed.TestPublicIpAddress) Test associate public IP within the project ... skipped 'skip' test_08_security_group (test_project_resources_fixed.TestSecurityGroup) Test security groups in project ... skipped 'skip' test_06_create_snapshots_in_project (test_project_resources_fixed.TestSnapshots) Test create snapshots in project ... skipped 'skip' test_04_public_template_use_in_project (test_project_resources_fixed.TestTemplates) Test Templates creation in projects ... skipped 'skip' test_05_use_private_template_in_project (test_project_resources_fixed.TestTemplates) Test use of private template in a project ... skipped 'skip' -- Ran 8 tests in 479.325s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Review Request 15962: CLOUDSTACK-5346: Fixed shared network cleanup issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/#review29704 --- Commit 171c7e950b22a4aa6cd6e8b9051436794bb41373 in branch refs/heads/4.3 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=171c7e9 ] CLOUDSTACK-5346: Fixed shared network cleanup issue - ASF Subversion and Git Services On Dec. 3, 2013, 2:15 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/ --- (Updated Dec. 3, 2013, 2:15 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5346 https://issues.apache.org/jira/browse/CLOUDSTACK-5346 Repository: cloudstack-git Description --- component.test_project_resources.TestNetwork.test_03_network_create failed due to Exception during cleanup: Failed to delete network The test case failed to delete the shared network because it has 1 VM in it. Resolution: Deleted the VM and waited for expunge interval before proceeding to network cleanup. Other changes: Code cleanup and changes related to imports, getting free vlan and setting the startip,endip,netmask of shared network using random subnet number to avoid conflict. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15962/diff/ Testing --- Tested locally on XenServer setup. Log: test_03_network_create (test_project_resources_fixed.TestNetwork) Test create network in project ... ok test_01_service_offerings (test_project_resources_fixed.TestOfferings) Test service offerings in a project ... skipped 'skip' test_02_project_disk_offerings (test_project_resources_fixed.TestOfferings) Test project disk offerings ... skipped 'skip' test_07_associate_public_ip (test_project_resources_fixed.TestPublicIpAddress) Test associate public IP within the project ... skipped 'skip' test_08_security_group (test_project_resources_fixed.TestSecurityGroup) Test security groups in project ... skipped 'skip' test_06_create_snapshots_in_project (test_project_resources_fixed.TestSnapshots) Test create snapshots in project ... skipped 'skip' test_04_public_template_use_in_project (test_project_resources_fixed.TestTemplates) Test Templates creation in projects ... skipped 'skip' test_05_use_private_template_in_project (test_project_resources_fixed.TestTemplates) Test use of private template in a project ... skipped 'skip' -- Ran 8 tests in 479.325s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Review Request 15962: CLOUDSTACK-5346: Fixed shared network cleanup issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/#review29705 --- Ship it! Committed to 4.2, 4.3 and master - Girish Shilamkar On Dec. 3, 2013, 2:15 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15962/ --- (Updated Dec. 3, 2013, 2:15 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5346 https://issues.apache.org/jira/browse/CLOUDSTACK-5346 Repository: cloudstack-git Description --- component.test_project_resources.TestNetwork.test_03_network_create failed due to Exception during cleanup: Failed to delete network The test case failed to delete the shared network because it has 1 VM in it. Resolution: Deleted the VM and waited for expunge interval before proceeding to network cleanup. Other changes: Code cleanup and changes related to imports, getting free vlan and setting the startip,endip,netmask of shared network using random subnet number to avoid conflict. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15962/diff/ Testing --- Tested locally on XenServer setup. Log: test_03_network_create (test_project_resources_fixed.TestNetwork) Test create network in project ... ok test_01_service_offerings (test_project_resources_fixed.TestOfferings) Test service offerings in a project ... skipped 'skip' test_02_project_disk_offerings (test_project_resources_fixed.TestOfferings) Test project disk offerings ... skipped 'skip' test_07_associate_public_ip (test_project_resources_fixed.TestPublicIpAddress) Test associate public IP within the project ... skipped 'skip' test_08_security_group (test_project_resources_fixed.TestSecurityGroup) Test security groups in project ... skipped 'skip' test_06_create_snapshots_in_project (test_project_resources_fixed.TestSnapshots) Test create snapshots in project ... skipped 'skip' test_04_public_template_use_in_project (test_project_resources_fixed.TestTemplates) Test Templates creation in projects ... skipped 'skip' test_05_use_private_template_in_project (test_project_resources_fixed.TestTemplates) Test use of private template in a project ... skipped 'skip' -- Ran 8 tests in 479.325s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15875/#review29707 --- Commit e5cfe948186b825d2b28c99ce2915a5ca8498aff in branch refs/heads/master from Bharat Kumar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e5cfe94 ] CLOUDSTACK-5160 add a map to specify the custom compute parameters in the deployvm api. Signed-off-by: Jayapal jaya...@apache.org - ASF Subversion and Git Services On Dec. 3, 2013, 10:53 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15875/ --- (Updated Dec. 3, 2013, 10:53 a.m.) Review request for cloudstack, Jayapal Reddy and Koushik Das. Bugs: CLOUDSTACK-5160 https://issues.apache.org/jira/browse/CLOUDSTACK-5160 Repository: cloudstack-git Description --- use a map to specify the custom parameters in the deployvm api Instead of one parameter for each. https://issues.apache.org/jira/browse/CLOUDSTACK-5160 Diffs - api/src/com/cloud/vm/UserVmService.java 6fc8b54 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java ad957d5 engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 8c58227 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 4e25493 engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 5dd15ce engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 71e8b7d server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c Diff: https://reviews.apache.org/r/15875/diff/ Testing --- Tested on master. Thanks, bharat kumar
Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29708 --- Commit 6b955958c6165f69de8dbaf6310868d8f5c2a3b1 in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6b95595 ] CLOUDSTACK-5333: Code changes related to snapshots listing Signed-off-by: Girish Shilamkar gir...@clogeny.com - ASF Subversion and Git Services On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/ --- (Updated Dec. 2, 2013, 2:57 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5333 https://issues.apache.org/jira/browse/CLOUDSTACK-5333 Repository: cloudstack-git Description --- test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project was failing with error Check Snapshot state is Running or not. The snapshot state does not really matter here, as we are checking the limits. Instead of checking the snapshot state from all the possible options, just list the snapshots under the project and check if exactly one snapshot exists. Diffs - test/integration/component/test_project_limits.py c497311 Diff: https://reviews.apache.org/r/15942/diff/ Testing --- Tested locally on XenServer advanced setup. Log: test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) Test Limit number of guest account specific networks ... skipped 'skip' test_01_project_limits (test_project_limits_fixed.TestProjectLimits) Test project limits for domain admin ... skipped 'skip' test_02_project_limits_normal_user (test_project_limits_fixed.TestProjectLimits) Test project limits for normal user ... skipped 'skip' test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test VM limit per project ... skipped 'Skip' test_04_publicip_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Public IP limit per project ... skipped 'Skip' test_05_snapshots_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Snapshot limit per project ... ok test_06_volumes_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Volumes limit per project ... skipped 'Skip' test_07_templates_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Templates limit per project ... skipped 'Skip' -- Ran 8 tests in 360.690s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29709 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/ --- (Updated Dec. 2, 2013, 2:57 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5333 https://issues.apache.org/jira/browse/CLOUDSTACK-5333 Repository: cloudstack-git Description --- test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project was failing with error Check Snapshot state is Running or not. The snapshot state does not really matter here, as we are checking the limits. Instead of checking the snapshot state from all the possible options, just list the snapshots under the project and check if exactly one snapshot exists. Diffs - test/integration/component/test_project_limits.py c497311 Diff: https://reviews.apache.org/r/15942/diff/ Testing --- Tested locally on XenServer advanced setup. Log: test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) Test Limit number of guest account specific networks ... skipped 'skip' test_01_project_limits (test_project_limits_fixed.TestProjectLimits) Test project limits for domain admin ... skipped 'skip' test_02_project_limits_normal_user (test_project_limits_fixed.TestProjectLimits) Test project limits for normal user ... skipped 'skip' test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test VM limit per project ... skipped 'Skip' test_04_publicip_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Public IP limit per project ... skipped 'Skip' test_05_snapshots_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Snapshot limit per project ... ok test_06_volumes_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Volumes limit per project ... skipped 'Skip' test_07_templates_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Templates limit per project ... skipped 'Skip' -- Ran 8 tests in 360.690s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29710 --- Commit e5047141a9fd305be186fc303f7cfdfc68a4bfd3 in branch refs/heads/4.3 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e504714 ] CLOUDSTACK-5333: Code changes related to snapshots listing Signed-off-by: Girish Shilamkar gir...@clogeny.com - ASF Subversion and Git Services On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/ --- (Updated Dec. 2, 2013, 2:57 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5333 https://issues.apache.org/jira/browse/CLOUDSTACK-5333 Repository: cloudstack-git Description --- test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project was failing with error Check Snapshot state is Running or not. The snapshot state does not really matter here, as we are checking the limits. Instead of checking the snapshot state from all the possible options, just list the snapshots under the project and check if exactly one snapshot exists. Diffs - test/integration/component/test_project_limits.py c497311 Diff: https://reviews.apache.org/r/15942/diff/ Testing --- Tested locally on XenServer advanced setup. Log: test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) Test Limit number of guest account specific networks ... skipped 'skip' test_01_project_limits (test_project_limits_fixed.TestProjectLimits) Test project limits for domain admin ... skipped 'skip' test_02_project_limits_normal_user (test_project_limits_fixed.TestProjectLimits) Test project limits for normal user ... skipped 'skip' test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test VM limit per project ... skipped 'Skip' test_04_publicip_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Public IP limit per project ... skipped 'Skip' test_05_snapshots_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Snapshot limit per project ... ok test_06_volumes_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Volumes limit per project ... skipped 'Skip' test_07_templates_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Templates limit per project ... skipped 'Skip' -- Ran 8 tests in 360.690s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Review Request 15942: CLOUDSTACK-5333: Code changes related to snapshots listing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/#review29711 --- Commit 11231d6b12770c98d32e533d94ec63183cc19eda in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=11231d6 ] CLOUDSTACK-5333: Code changes related to snapshots listing Signed-off-by: Girish Shilamkar gir...@clogeny.com - ASF Subversion and Git Services On Dec. 2, 2013, 2:57 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15942/ --- (Updated Dec. 2, 2013, 2:57 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5333 https://issues.apache.org/jira/browse/CLOUDSTACK-5333 Repository: cloudstack-git Description --- test_project_limits.TestResourceLimitsProject.test_05_snapshots_per_project was failing with error Check Snapshot state is Running or not. The snapshot state does not really matter here, as we are checking the limits. Instead of checking the snapshot state from all the possible options, just list the snapshots under the project and check if exactly one snapshot exists. Diffs - test/integration/component/test_project_limits.py c497311 Diff: https://reviews.apache.org/r/15942/diff/ Testing --- Tested locally on XenServer advanced setup. Log: test_maxAccountNetworks (test_project_limits_fixed.TestMaxProjectNetworks) Test Limit number of guest account specific networks ... skipped 'skip' test_01_project_limits (test_project_limits_fixed.TestProjectLimits) Test project limits for domain admin ... skipped 'skip' test_02_project_limits_normal_user (test_project_limits_fixed.TestProjectLimits) Test project limits for normal user ... skipped 'skip' test_03_vm_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test VM limit per project ... skipped 'Skip' test_04_publicip_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Public IP limit per project ... skipped 'Skip' test_05_snapshots_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Snapshot limit per project ... ok test_06_volumes_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Volumes limit per project ... skipped 'Skip' test_07_templates_per_project (test_project_limits_fixed.TestResourceLimitsProject) Test Templates limit per project ... skipped 'Skip' -- Ran 8 tests in 360.690s OK (skipped=7) Thanks, Gaurav Aradhye
Re: Review Request 15963: CLOUDSTACK-5347: Resolved issue related to snapshot state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/#review29712 --- Commit 291eafadaefc66ca030c26e0bbc78256ac8a8dbd in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=291eafa ] CLOUDSTACK-5347: Resolved issue related to snapshot state - ASF Subversion and Git Services On Dec. 3, 2013, 2:31 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/ --- (Updated Dec. 3, 2013, 2:31 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5347 https://issues.apache.org/jira/browse/CLOUDSTACK-5347 Repository: cloudstack-git Description --- The test case component.test_project_resources.TestSnapshots.test_06_create_snapshots_in_project failed due to Check Snapshot state is Running or not It was checking the snapshot state only in (CreatedOnPrimary, BackedUp). The snapshot could also be in Allocated state. Snapshot is always first in allocated state, then createdOnPrimary and finally BackedUp. included Allocated state in the list. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15963/diff/ Testing --- Tested locally in XenServer advanced setup. Thanks, Gaurav Aradhye
Re: Review Request 15963: CLOUDSTACK-5347: Resolved issue related to snapshot state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/#review29715 --- Commit 454912d7b2d36f4578d3355798c737f5adba827c in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=454912d ] CLOUDSTACK-5347: Resolved issue related to snapshot state - ASF Subversion and Git Services On Dec. 3, 2013, 2:31 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/ --- (Updated Dec. 3, 2013, 2:31 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5347 https://issues.apache.org/jira/browse/CLOUDSTACK-5347 Repository: cloudstack-git Description --- The test case component.test_project_resources.TestSnapshots.test_06_create_snapshots_in_project failed due to Check Snapshot state is Running or not It was checking the snapshot state only in (CreatedOnPrimary, BackedUp). The snapshot could also be in Allocated state. Snapshot is always first in allocated state, then createdOnPrimary and finally BackedUp. included Allocated state in the list. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15963/diff/ Testing --- Tested locally in XenServer advanced setup. Thanks, Gaurav Aradhye
Re: Review Request 15763: Changed 'MigrateCommand' to use the global setting value of 'execute.in.sequence.hypervisor.commands'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/#review29716 --- Looks like the latest patch has some issues, the diff is not showing up. Also there are 2 commits in the patch file. Can you resubmit the patch with only a single commit? - Koushik Das On Dec. 3, 2013, 5:07 p.m., Alex Ough wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15763/ --- (Updated Dec. 3, 2013, 5:07 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- When a host is switched to the 'maintenance mode', the vms in that host are migrated to another available hosts. Currently, the vm migrations are executed sequentially, it can take a lot of time when there are quite number of vms. So I changed 'MigrateCommand' to get the value of 'executeInSequence' property from the global setting value of 'execute.in.sequence.hypervisor.commands' so that users can execute the migrations in parallel to save time. Diffs - core/src/com/cloud/agent/api/MigrateCommand.java 0d8f70c engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 3a3de70 setup/db/db/schema-410to420.sql 522ccc4 setup/db/db/schema-410to420.sql 522ccc4 setup/db/db/schema-430to440.sql 9bb9602 Diff: https://reviews.apache.org/r/15763/diff/ Testing --- Tested in the simulator mode and Xen servers. Thanks, Alex Ough
Re: Review Request 15963: CLOUDSTACK-5347: Resolved issue related to snapshot state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/#review29714 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar On Dec. 3, 2013, 2:31 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/ --- (Updated Dec. 3, 2013, 2:31 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5347 https://issues.apache.org/jira/browse/CLOUDSTACK-5347 Repository: cloudstack-git Description --- The test case component.test_project_resources.TestSnapshots.test_06_create_snapshots_in_project failed due to Check Snapshot state is Running or not It was checking the snapshot state only in (CreatedOnPrimary, BackedUp). The snapshot could also be in Allocated state. Snapshot is always first in allocated state, then createdOnPrimary and finally BackedUp. included Allocated state in the list. Diffs - test/integration/component/test_project_resources.py 9b9b2e6 Diff: https://reviews.apache.org/r/15963/diff/ Testing --- Tested locally in XenServer advanced setup. Thanks, Gaurav Aradhye
Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/#review29718 --- Commit 0aa17c4213adb5ec513151478c578015c6690050 in branch refs/heads/4.3 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0aa17c4 ] CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures - ASF Subversion and Git Services On Nov. 21, 2013, 12:49 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/ --- (Updated Nov. 21, 2013, 12:49 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5230 https://issues.apache.org/jira/browse/CLOUDSTACK-5230 Repository: cloudstack-git Description --- Removing dependency between the test cases. Some test cases were trying to delete/recover the instances which are already deleted in other test cases. Diffs - test/integration/component/test_vpc_vm_life_cycle.py beb5b99 Diff: https://reviews.apache.org/r/15761/diff/ Testing --- Tested locally on VMware Advanced setup. Log: Ran the failing test cases with the dependent test case. test_05_destroy_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test destroy an instance in VPC networks ... ok test_06_recover_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test recover an instance in VPC networks ... ok test_10_expunge_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test expunge an instance in VPC networks ... ok Thanks, Ashutosh Kelkar
Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/#review29717 --- Commit 4b5a0ca4c27f511e48c6cc094ce4bec731c0d8fb in branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4b5a0ca ] CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures - ASF Subversion and Git Services On Nov. 21, 2013, 12:49 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/ --- (Updated Nov. 21, 2013, 12:49 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5230 https://issues.apache.org/jira/browse/CLOUDSTACK-5230 Repository: cloudstack-git Description --- Removing dependency between the test cases. Some test cases were trying to delete/recover the instances which are already deleted in other test cases. Diffs - test/integration/component/test_vpc_vm_life_cycle.py beb5b99 Diff: https://reviews.apache.org/r/15761/diff/ Testing --- Tested locally on VMware Advanced setup. Log: Ran the failing test cases with the dependent test case. test_05_destroy_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test destroy an instance in VPC networks ... ok test_06_recover_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test recover an instance in VPC networks ... ok test_10_expunge_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test expunge an instance in VPC networks ... ok Thanks, Ashutosh Kelkar
Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/#review29719 --- Commit 8525dfd9310df409a7ddcb925e6b85299f6e4436 in branch refs/heads/4.2 from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8525dfd ] CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures - ASF Subversion and Git Services On Nov. 21, 2013, 12:49 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/ --- (Updated Nov. 21, 2013, 12:49 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5230 https://issues.apache.org/jira/browse/CLOUDSTACK-5230 Repository: cloudstack-git Description --- Removing dependency between the test cases. Some test cases were trying to delete/recover the instances which are already deleted in other test cases. Diffs - test/integration/component/test_vpc_vm_life_cycle.py beb5b99 Diff: https://reviews.apache.org/r/15761/diff/ Testing --- Tested locally on VMware Advanced setup. Log: Ran the failing test cases with the dependent test case. test_05_destroy_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test destroy an instance in VPC networks ... ok test_06_recover_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test recover an instance in VPC networks ... ok test_10_expunge_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test expunge an instance in VPC networks ... ok Thanks, Ashutosh Kelkar
Re: Review Request 15761: CLOUDSTACK-5230: Removing test cases' dependency on each other leading to failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/#review29720 --- Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar On Nov. 21, 2013, 12:49 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15761/ --- (Updated Nov. 21, 2013, 12:49 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5230 https://issues.apache.org/jira/browse/CLOUDSTACK-5230 Repository: cloudstack-git Description --- Removing dependency between the test cases. Some test cases were trying to delete/recover the instances which are already deleted in other test cases. Diffs - test/integration/component/test_vpc_vm_life_cycle.py beb5b99 Diff: https://reviews.apache.org/r/15761/diff/ Testing --- Tested locally on VMware Advanced setup. Log: Ran the failing test cases with the dependent test case. test_05_destroy_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test destroy an instance in VPC networks ... ok test_06_recover_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test recover an instance in VPC networks ... ok test_10_expunge_instance_in_network (test_vpc_vm_life_cycle_fixed.TestVMLifeCycleSharedNwVPC) Test expunge an instance in VPC networks ... ok Thanks, Ashutosh Kelkar
