date:20140708

RE: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

2014-07-08 Thread Damoder Reddy

Hugo,

 As Rajani mentioned we are not packaging the sources with MSI installer, we 
are telling to installer from where to download the dependencies.

Anyhow my question is, the MSI build is already part of separate build profile 
("buildw") which is not build with default profile. So still we need to move it 
to under noredist profile?

Damoder/

-Original Message-
From: Rajani Karuturi [mailto:rajani.karut...@citrix.com] 
Sent: Wednesday, 9 July 2014 10:45 AM
To: dev@cloudstack.apache.org
Cc: David Nalley; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of 
the installation. Also installing mysql connector

Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a 
[spec] file. only difference being, it also mentions the download url as 
windows doesn’t have a package repository and doesn’t know where to download 
from.
It will not be part of the installer. The msi only tells where to download the 
mysql connector jar from. It doesn’t include the jar itself.

When the user is installing cloudstack using the msi, the jar will be 
downloaded from the location mentioned.


[spec] https://reviews.apache.org/r/23192/diff/#5

~Rajani



On 08-Jul-2014, at 7:25 pm, Hugo Trippaers 
mailto:h...@trippaers.nl>> wrote:

Rajani,

That is why we renamed nonoss to noredist. It has to do with the policy of the 
Apache Software Foundation regarding compatible licenses [1]. The problem in 
this case is subtle, but there is a difference. The main point in the 
discussion is so-called system dependencies. We know we need java, mysql and 
the mysql-connector-java to be installed before we can install our packages. 
This is what the dependency on mysql-connector-java in the spec file indicates. 
Creating a package containing those source is actually including the items we 
consider is going just a bit further and to a point where we concluded that it 
is not inline with the apache policies. So it is perfectly alright to include a 
popup in the installer that tells the users that he needs to install mysql, 
java etc, but we can’t have an installed in the source that will do that for 
the user as part of the installer.

What David proposes is a the middle ground where we can keep the installer in 
the configured like this in the pom, but it can’t be in that standard build, 
but only in the build that know we can’t redistribute (the noredist build). We 
will never make the artifacts resulting from that build available, but other 
entities can make them available. By specifying noredist on the build command 
we can be reasonably sure that the builder has been informed that distribution 
restrictions might apply on whatever it is he is doing.

Cheers,

Hugo

[1] http://www.apache.org/legal/resolved.html#category-x


On 8 jul. 2014, at 12:57, Rajani Karuturi 
mailto:rajani.karut...@citrix.com>> wrote:

I believe this has nothing to do with nonoss. If I understand it right, nonoss 
modules are required for cloudstack to work with certain 3rd party stuff.

This one is just a helper to create a windows installer. It chose to use a mvn 
command to create the installer instead of shell/bat script. It should work 
with either nonoss or oss modules.
This is very similar to cloud.spec[1] we have which is used to create the rpm 
and which already has mysql-connector-java already listed as required package.

I think the right way would be to create independent git repos for 
deb/rpm/windows installers/packages.

In its current state, I don’t see it any different from other helper installer 
scripts we already have.

[1] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=packaging/centos63/cloud.spec;hb=HEAD

~Rajani



On 08-Jul-2014, at 9:56 am, Damoder Reddy 
mailto:damoder.re...@citrix.com>>
 wrote:

Ok,

To clarify the windows MSI will not build in the default profile. I have 
enabled a new profile "buildw" to build windows MSI installer which explicitly 
we need to pass similar to nonoss?

Is that sufficient to make it nonoss or still we need to move it under nonoss 
profile explicitly?

Thanks
Damoder/

-Original Message-
From: David Nalley [mailto:da...@gnsa.us]
Sent: Thursday, 3 July 2014 9:58 PM
To: 
dev@cloudstack.apache.org
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of 
the installation. Also installing mysql connector

On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers 
mailto:chipchild...@apache.org>>
 wrote:
On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and installs a 
variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldnąt really happen. The principle is one of łleast 
surprise˛: As a user or developer who does not RTFM, f

Re: [DISCUSS][PROPOSAL] git workflow

2014-07-08 Thread Rajani Karuturi

In my first email, I mentioned a youtube url[1] which is a google tech talk by  
Laura Wingerd [2] of Perforce Software
I recommend watching it as well. (its a 55 min video).

[1] https://www.youtube.com/watch?v=AJ-CpGsCpM0
[2] http://www.perforce.com/blog/author/lwingerd

~Rajani



On 09-Jul-2014, at 3:52 am, Sebastien Goasguen 
mailto:run...@gmail.com>> wrote:

This is also a good read, against cherry-picking (back to Rajani's original 
point):

http://www.draconianoverlord.com/2013/09/07/no-cherry-picking.html

(even wondering if Rohit did not send this to the list already…)

-sebastien

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

2014-07-08 Thread Rajani Karuturi

Hi Hugo,
Even in case of windows installer, mysql-connector-java is mentioned in a 
[spec] file. only difference being, it also mentions the download url as 
windows doesn’t have a package repository and doesn’t know where to download 
from.
It will not be part of the installer. The msi only tells where to download the 
mysql connector jar from. It doesn’t include the jar itself.

When the user is installing cloudstack using the msi, the jar will be 
downloaded from the location mentioned.


[spec] https://reviews.apache.org/r/23192/diff/#5

~Rajani



On 08-Jul-2014, at 7:25 pm, Hugo Trippaers 
mailto:h...@trippaers.nl>> wrote:

Rajani,

That is why we renamed nonoss to noredist. It has to do with the policy of the 
Apache Software Foundation regarding compatible licenses [1]. The problem in 
this case is subtle, but there is a difference. The main point in the 
discussion is so-called system dependencies. We know we need java, mysql and 
the mysql-connector-java to be installed before we can install our packages. 
This is what the dependency on mysql-connector-java in the spec file indicates. 
Creating a package containing those source is actually including the items we 
consider is going just a bit further and to a point where we concluded that it 
is not inline with the apache policies. So it is perfectly alright to include a 
popup in the installer that tells the users that he needs to install mysql, 
java etc, but we can’t have an installed in the source that will do that for 
the user as part of the installer.

What David proposes is a the middle ground where we can keep the installer in 
the configured like this in the pom, but it can’t be in that standard build, 
but only in the build that know we can’t redistribute (the noredist build). We 
will never make the artifacts resulting from that build available, but other 
entities can make them available. By specifying noredist on the build command 
we can be reasonably sure that the builder has been informed that distribution 
restrictions might apply on whatever it is he is doing.

Cheers,

Hugo

[1] http://www.apache.org/legal/resolved.html#category-x


On 8 jul. 2014, at 12:57, Rajani Karuturi 
mailto:rajani.karut...@citrix.com>> wrote:

I believe this has nothing to do with nonoss. If I understand it right, nonoss 
modules are required for cloudstack to work with certain 3rd party stuff.

This one is just a helper to create a windows installer. It chose to use a mvn 
command to create the installer instead of shell/bat script. It should work 
with either nonoss or oss modules.
This is very similar to cloud.spec[1] we have which is used to create the rpm 
and which already has mysql-connector-java already listed as required package.

I think the right way would be to create independent git repos for 
deb/rpm/windows installers/packages.

In its current state, I don’t see it any different from other helper installer 
scripts we already have.

[1] 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=packaging/centos63/cloud.spec;hb=HEAD

~Rajani



On 08-Jul-2014, at 9:56 am, Damoder Reddy 
mailto:damoder.re...@citrix.com>>
 wrote:

Ok,

To clarify the windows MSI will not build in the default profile. I have 
enabled a new profile "buildw" to build windows MSI installer which explicitly 
we need to pass similar to nonoss?

Is that sufficient to make it nonoss or still we need to move it under nonoss 
profile explicitly?

Thanks
Damoder/

-Original Message-
From: David Nalley [mailto:da...@gnsa.us]
Sent: Thursday, 3 July 2014 9:58 PM
To: 
dev@cloudstack.apache.org
Cc: Damoder Reddy; Koushik Das
Subject: Re: Review Request 23192: Adding Readme and run checkbox at the end of 
the installation. Also installing mysql connector

On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers 
mailto:chipchild...@apache.org>>
 wrote:
On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote:
It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldnąt really happen. The principle is one
of łleast surprise˛: As a user or developer who does not RTFM,
following the default commands/tools/etc, you should end up with a
more-or-less apache-licensed build result (*) that you can
redistribute the result under.

+1


But apache policy is that it is acceptable to provide scripts/build
tools/assistance to help those same users/developers do things that
they want to do. As long as they understand the legal situation they end up in.

I would recommend adding a "nonoss" maven profile that the
developer/user has to explicitly select in order to do those
downloads. As long as that option is described clearly, thatąs then
ok. See

http://svn.apache.org/repos/asf/apr/apr/trunk/README

for an example of how to point out the

Re: Review Request 23314: Plugin specific code for the Brocade Network Plugin

2014-07-08 Thread Ritu Sabharwal



> On July 8, 2014, 9:29 a.m., Hugo Trippaers wrote:
> > Thanks for make this a separate review, much easier to read.
> > 
> > The licenses are not added to all files and in some files they appear not 
> > to be complete. A good trick to solve this is to include the 
> > license-maven-plugin in the build section. See 
> > plugins/network-elements/nicira-nvp/pom.xml for an example.
> > 
> > Also the plugin doesn't contain any tests. We need unit tests or functional 
> > tests (and preferably both) to validate that this plugin works and keeps on 
> > working in future versions of CloudStack. It would be great if you could 
> > supply unit tests to validate this inner workings of this module and marvin 
> > based integration tests that we can run to see if this work with the 
> > intended hardware.
> > 
> > The last general point is that we would also need documentation on this 
> > plugin so administrators will know how to use this.
> 
> Ritu  Sabharwal wrote:
> Thanks for reviewing the code.
> 
> I have fixed the license in all the files.
> 
> I am working on writing the unit tests for the plugin.
> 
> I am working on providing the documentation on using the plugin.
> 
> I have tested the plugin with the simulator and see the configurations on 
> Brocade switches happening. Currently, I am setting up a real hardware setup 
> with Vmware hypervisor and Brocade switches so test the connectivity between 
> spawned VMs.
> 
> Can I continue writing the unit tests and marvin integration tests and 
> documentation after the July 19 date so that this plugin makes to 4.5 feature 
> freeze date.
> 
> I have updated the diffs with the changes for the license and other 
> comments.

I am planning to include the following in the documentation:
 - Brocade switch setup
 - Connections to the Hypervisor hosts
 - the flow to use the plugin from UI


- Ritu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23314/#review47435
---


On July 8, 2014, 6:49 p.m., Ritu  Sabharwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23314/
> ---
> 
> (Updated July 8, 2014, 6:49 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6823
> https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Plugin specific code.
> 
> 
> Diffs
> -
> 
>   plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd 
> PRE-CREATION 
>   plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkHostMappingVO.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Cache.java 
> PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/CacheManager.java
>  PRE-CREATION 
>   
> plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java
>  PRE-CREATI

[Help] Help for setting up Vmware Cluster in CloudStack...

2014-07-08 Thread Ritu Sabharwal

Hi Ilya,

I am trying to add VMWare DC for the first time in CloudStack management server
and need help in doing so. I am trying to test the Brocade Network Plugin
functionality. The Jira id is :
https://issues.apache.org/jira/browse/CLOUDSTACK-6823

I am following the Tutorial:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Advanced+Network+Tutorial+-+Step+by+Step

My Network setup:

1. 2 ESXi hosts 4.1.0 hosts.

2. vCenter 5.0

Network layout:

vSwitch0: For Management Network
vSwitch0: for Guest Network

vSwitch0 is assigned 1 Physical Nic. This Nic is connected to Brocade VDX
switch.

My test includes:

* Create an isolated network; verify that the port-profile is created on the
Brocade switch.
* Attach a VM to the network; verify that the VMs MAC address is associated
with the port profile of the network on the Brocade switch.
* Add VMs to the same guest network but on different hosts and verify
connectivity.
* Check the availability of the switch by using the CloudStack API:
http://:8096/client/api?command=listHosts&type=L2Networking.
This should list the switch with its availability status.
* Delete VMs for an isolated network; verify that the VMs MAC address is
disassociated with the port profile of the network on the Brocade switch.
* Delete the isolated network; verify that the port-profile is deleted from
the Brocade switch.

I have few questions:

1. Where do I download the system vm template for vmware. I am using
master CS codebase, I don't have the script
/usr/lib64/cloud/common/scripts/storage/secondary/cloud-install-sys-tmplt

2. Since I am testing L2 connectivity b/w VMs using Brocade switches by
configuring the VLANs( by creating port-profiles) for the network on the
switches, do I need to assign a IP range for Public network and storage network?

54 matches

Mail list logo