Re: [VOTE] Apache CloudStack 4.6.0

[Remi Bergsma]

Kicked off some Jenkins builds:

CentOS 6 packages:
http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64/
 

CentOS 7 packages:
http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter-centos7/lastSuccessfulBuild/artifact/dist/rpmbuild/RPMS/x86_64/
 

Ubuntu Trusty packages:
http://cloudstack.apt-get.eu/ubuntu/dists/trusty/4.6/pool/

SystemVM template:
http://jenkins.buildacloud.org/view/parameterized/job/parameterized-sytemvm/lastSuccessfulBuild/artifact/tools/appliance/dist/


You can always build packages from the source:
cd packaging
./package.sh -h

Happy testing!

Regards,
Remi





On 04/11/15 18:12, "Remi Bergsma"  wrote:

>The jobs failed due to the git clone failing (time out). I also experience it 
>is quite slow at the moment.
>
>It is mirrored here (same commit id):
>https://github.com/apache/cloudstack/tree/4.6.0-RC20151104T1522
>
>Regards,
>Remi
>
>
>
>
>On 04/11/15 17:17, "Rajani Karuturi"  wrote:
>
>>I started jenkins builds for cloudstack RPM packages and systemvm templates 
>>for this branch here
>>
>>http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/19/console
>>http://jenkins.buildacloud.org/view/parameterized/job/parameterized-sytemvm/3/console
>>
>>We can use them once the build is complete.
>>
>>~Rajani
>>
>>On 04-Nov-2015, at 8:58 PM, Nux! > 
>>wrote:
>>
>>Hi,
>>
>>Has jenkins built rpms for this somewhere?
>>
>>--
>>Sent from the Delta quadrant using Borg technology!
>>
>>Nux!
>>www.nux.ro
>>
>>- Original Message -
>>From: "Remi Bergsma" 
>>To: dev@cloudstack.apache.org
>>Sent: Wednesday, 4 November, 2015 14:55:11
>>Subject: [VOTE] Apache CloudStack 4.6.0
>>
>>Hi all,
>>
>>I've created a 4.6.0 release candidate, with the following artifacts up for a
>>vote:
>>
>>Git Branch and Commit SH:
>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522
>>
>>Commit: b0ebe68e375432b28eef031ab62ccd5831234c77
>>
>>Source release (checksums and signatures are available at the same
>>location):
>>https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
>>
>>PGP release keys (signed using A47DDC4F):
>>https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>
>>Vote will be open for at least 72 hours.
>>
>>For sanity in tallying the vote, can PMC members please be sure to indicate
>>"(binding)" with their vote?
>>
>>[ ] +1  approve
>>[ ] +0  no opinion
>>[ ] -1  disapprove (and reason why)
>>

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[mlsorensen]

Github user mlsorensen commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153863283
  
John,
I probably shouldn't respond in this thread, but from your response I
feel like much of my point was missed. In fact I had pointed out the very
thing you mention, that there's no requirement for third parties to submit
their code to the community, they could ship their plugin standalone and
have their users install it. If a user has a problem, it won't matter if
the plugin was shipped with CloudStack or installed standalone, the result
will be the same.
I think we are in agreement that the code should have the same
standards, but I think we (and I mean all of us) differ to varying degrees
in what those standards should be. One may block an important commit
because it uses String.length() == 0 instead of String.isEmpty(), or
doesn't print enough debug info, and end up postponing the benefit of the
fixes to the next release, while another committer might not care about
that level of review and standard. There should probably be a basic list of
items to look for so that the reviews themselves can be standardized. I
think that would also address the concern I have for the community culture,
because contributors will fear the review process less if they can see up
front what the criteria are for merge. There's little I can think of that
is more detrimental to growing our community of committers than making
people feel like they're submitted to an arbitrary level of scrutiny
whenever they contribute. When contributing becomes painful then we're held
at arms length, rather than encouraging ownership of the code and
participation.

On Wed, Nov 4, 2015 at 10:35 AM, John Burwell 
wrote:

> I agree with @runseb  that we need to move
> this discussion to dev@, and re-assess accepting the maintenance
> responsibly for code that cannot be tested and verified by the community.
> This plugin has already been accepted into 4.5, and as such, would be
> "grandfathered" into any decision we would make. Therefore, we should 
carry
> our current precedent forward and not prevent acceptance of this PR for
> this reason. We are at a point in the 4.6 release cycle that only blockers
> should be accepted. Otherwise, we will never ship 4.6.
>
> @KrisSterckx  I realize my comments may
> come across as unappreciative which is not my intention. I greatly
> appreciate the work @nlivens  and you have
> done to contribute this capability to the community. This plugin 
highlights
> a larger issue which is that, as a community, we are delivering releases
> containing code that cannot be verified. By contributing this plugin to 
our
> community, we become responsible for its support and maintenance. In 6-12
> months, how do answer answer a user who asks does this plugin work in the
> latest release if you are unavailable?
>
> @runseb  while there is a fairness issue for
> the contributor, I think it is incredibly unfair to our users that we ship
> code without on-going validation. When a user sees the availability of
> PluginX supporting Device1 in a release, they assume that we have verified
> the proper operation of PluginX since we shipped it in that release. In
> fact, we haven't, and they may be attempting to use something that is
> completely broken.
>
> @mlsorensen  yes, plugins provide a
> mechanism for vendors to extend CloudStack. However, there is no
> requirement for those plugins to be part of the community, OSS codebase.
> Therefore, we should not conflate the ability of third-parties to extend
> CloudStack using plugins with the code that is accepted as part of the
> community's repositories. All code in our repositories, regardless of 
being
> in the core or a plugin, should be held to the same standards. When a user
> has a problem, they aren't any less frustrated with the project because
> their problem happens to be in a plugin.
>
> @mike-tutkowski  I don't believe that
> code inspection by itself is adequate to determine the quality of code
> integrating an external device. For example, I reviewed the code for this
> plugin, and while I feel confident that it will behave well within the
> management server, I have absolutely no idea if the various network
> functions are being properly automated using the Nuage client APIs. The
> only way for those aspects of the plugin's operation to be verified would
> be to run in a test environment with a Nuage device and realize a set of
> network 

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

[terbolous]

Github user terbolous commented on a diff in the pull request:

https://github.com/apache/cloudstack-www/pull/17#discussion_r43938320
  
--- Diff: source/users.markdown ---
@@ -229,5 +245,4 @@ If you noticed something wrong  with your entry here 
(or if you’d like us to r
 * Xtendsys
 * Zajil Telecom
 * Zenoss
-* Zynga 
-
+* Zynga
--- End diff --

I have no idea why git thinks there is a change here, but the end result 
remain the same


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

[terbolous]

GitHub user terbolous opened a pull request:

https://github.com/apache/cloudstack-www/pull/17

Update the list of known CloudStack users

Based on formwize as of 2015/11/04

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/terbolous/cloudstack-www master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-www/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit a8b677dd6e5a3c330bb4ba077e94fb9c4c1e23c7
Author: Erik Weber 
Date:   2015-11-04T20:54:54Z

Update the list of known CloudStack users

Based on formwize as of 2015/11/04




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[Mike Tutkowski]

I agree, John, that visual code inspection is not sufficient to "prove" the
code behaves as expected (too many variables to take into consideration
that just examining the code can easily miss problems).

I believe the idea, though, was just to protect the state of the DB since
the plug-ins don't run in sandboxes. If a customer wants to use CloudStack
with SolidFire and should happen to encounter an issue or question, I would
expect the customer would contact SolidFire about the issue/question. I
think for some plug-ins that this is the case and for others it is not. I
think for the ones where this is not the case (i.e. issues/questions come
to the CS community and not to a particular vendor), we should try to
enforce more strict community requirements for testing.

On Wed, Nov 4, 2015 at 11:35 AM, jburwell  wrote:

> Github user jburwell commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/801#issuecomment-153822915
>
> I agree with @runseb that we need to move this discussion to dev@,
> and re-assess accepting the maintenance responsibly for code that cannot be
> tested and verified by the community.  This plugin has already been
> accepted into 4.5, and as such, would be "grandfathered" into any decision
> we would make.  Therefore, we should carry our current precedent forward
> and not prevent acceptance of this PR for this reason.  We are at a point
> in the 4.6 release cycle that only blockers should be accepted.  Otherwise,
> we will never ship 4.6.
>
> @KrisSterckx I realize my comments may come across as unappreciative
> which is not my intention.  I greatly appreciate the work @nlivens and you
> have done to contribute this capability to the community.  This plugin
> highlights a larger issue which is that, as a community, we are delivering
> releases containing code that cannot be verified.  By contributing this
> plugin to our community, we become responsible for its support and
> maintenance.  In 6-12 months, how do answer answer a user who asks does
> this plugin work in the latest release if you are unavailable?
>
> @runseb while there is a fairness issue for the contributor, I think
> it is incredibly unfair to our users that we ship code without on-going
> validation.  When a user sees the availability of PluginX supporting
> Device1 in a release, they assume that we have verified the proper
> operation of PluginX since we shipped it in that release.  In fact, we
> haven't, and they may be attempting to use something that is completely
> broken.
>
> @mlsorensen yes, plugins provide a mechanism for vendors to extend
> CloudStack.  However, there is no requirement for those plugins to be part
> of the community, OSS codebase.  Therefore, we should not conflate the
> ability of third-parties to extend CloudStack using plugins with the code
> that is accepted as part of the community's repositories.  All code in our
> repositories, regardless of being in the core or a plugin, should be held
> to the same standards.  When a user has a problem, they aren't any less
> frustrated with the project because their problem happens to be in a plugin.
>
> @mike-tutkowski I don't believe that code inspection by itself is
> adequate to determine the quality of code integrating an external device.
> For example, I reviewed the code for this plugin, and while I feel
> confident that it will behave well within the management server, I have
> absolutely no idea if the various network functions are being properly
> automated using the Nuage client APIs.  The only way for those aspects of
> the plugin's operation to be verified would be to run in a test environment
> with a Nuage device and realize a set of network topologies.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

[GitHub] cloudstack-docs-admin pull request: JIRA CLOUDSTACK-9034

[karuturi]

Github user karuturi commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/32#issuecomment-153963381
  
@ronatartifact next time, in addition to jira id, please add more 
information to the subject line. 
something like "CLOUDSTACK-9034: Fixed bad bullet ending at xyz"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: JIRA CLOUDSTACK-9034

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-admin/pull/32


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: JIRA CLOUDSTACK-9034

[karuturi]

Github user karuturi commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/32#issuecomment-153963135
  
Thanks for the PR. looks good. verified in github preview. merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Seeking comments about JIRA issues on Admin Guide

[Ron Wheeler]

I have created issues 9031-9033 that identify some apparent deficiencies 
in the structure of the documentation files - not the content.
I would be grateful if anyone who knows anything about the docs could 
add some comments that provide some background.


Thanks
Ron

--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

User vm password gets update only the master VR.

[Bharat Kumar]

Hi,

In my local setup i found this issue, The user VM password is not getting saved 
in the backup router.

we send the save password command to both the VRs in a rvr enabled network, But 
the password gets saved only in the master VR. This happens because the 
password server is not running in the backup.
Because of this if someone resets the password of a VM and starts it when the 
backup becomes master. Then the password of the user VM will not change, 
because the save password command was not successful.

This breaks the password reset functionality, I have a raised a Blocker issue 
CLOUDSTACK-9035 to track 
this.


Thanks,
Bharat.

[GitHub] cloudstack-docs-admin pull request: JIRA CLOUDSTACK-9034

[ronatartifact]

GitHub user ronatartifact opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/32

JIRA CLOUDSTACK-9034

Fixed bad bullet ending

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ronatartifact/cloudstack-docs-admin master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit 50f72014329b5665844bf9504ebfa59b277e7dd9
Author: Ron Wheeler 
Date:   2015-11-05T02:46:10Z

JIRA CLOUDSTACK-9034




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: User vm password gets update only the master VR.

[Erik Weber]

On Thu, Nov 5, 2015 at 7:15 AM, Bharat Kumar 
wrote:

> Hi,
>
> In my local setup i found this issue, The user VM password is not getting
> saved in the backup router.
>
> we send the save password command to both the VRs in a rvr enabled
> network, But the password gets saved only in the master VR. This happens
> because the password server is not running in the backup.
> Because of this if someone resets the password of a VM and starts it when
> the backup becomes master. Then the password of the user VM will not
> change, because the save password command was not successful.
>
> This breaks the password reset functionality, I have a raised a Blocker
> issue CLOUDSTACK-9035<
> https://issues.apache.org/jira/browse/CLOUDSTACK-9035> to track this.
>
>

Does it work if you re-issue the password reset call after the slave vr has
been promoted to master?
If it does, then atleast you have a workaround for the issue.

-- 
Erik

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1021#discussion_r43892103
  
--- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java 
---
@@ -38,6 +40,7 @@
 
 @SerializedName(ApiConstants.CERTIFICATE)
 @Param(description = "certificate")
+@LogLevel(Log4jLevel.Off)
--- End diff --

certificates are not sensitive data. They are meant to be public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Apache CloudStack 4.6.0

[Remi Bergsma]

Hi all,

I've created a 4.6.0 release candidate, with the following artifacts up for a 
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522

Commit: b0ebe68e375432b28eef031ab62ccd5831234c77

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/

PGP release keys (signed using A47DDC4F):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for at least 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153755733
  
@koushik-das On second thought LogLevel can not be used I think: It is used 
for json serialization and one might have to serialize a password to be send to 
an agent while it may not be logged at the same time. We do need a separate 
annotation. this is not going to fly and hide sensitive data at the same time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request:

[dsclose]

Github user dsclose commented on the pull request:


https://github.com/apache/cloudstack/commit/59a9db39b1d17056753385c0e091bfe26d2df522#commitcomment-14184110
  
Issue CLOUDSTACK-9024 refers to this commit.
https://issues.apache.org/jira/browse/CLOUDSTACK-9024


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153749695
  
```
2015-11-04 14:23:51,076 DEBUG [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-34:ctx-0d2ee513 job-104/job-105 ctx-0d5c6252) Done executing 
VM work job: com.cloud.vm.VmWorkStart{"dcId

":1,"podId":1,"clusterId":1,"hostId":2,"rawParams":{"VmPassword":""},"userId":2,"accountId":2,"vmId":13,"handlerName":"VirtualMachineManagerImpl"}
```
And some other examples in there. I am looking further. @koushik-das this 
is going to take a lot of work to get right, right? Like this it is not done I 
think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1021#discussion_r43891649
  
--- Diff: 
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java ---
@@ -40,6 +42,7 @@
 
 @SerializedName("fingerprint")
 @Param(description = "Fingerprint of the public key")
+@LogLevel(Log4jLevel.Off)
--- End diff --

why is fingerprint sensitive?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

[Rajani Karuturi]

Its merged.

~Rajani
Sent from my Windows Phone

From: Raja Pullela
Sent: ‎04-‎11-‎15 15:55
To: dev@cloudstack.apache.org
Subject: RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Remi, Rajani, can you push this PR in ?

Best,
Raja

-Original Message-
From: Raja Pullela [mailto:raja.pull...@citrix.com]
Sent: Tuesday, November 3, 2015 7:02 PM
To: dev@cloudstack.apache.org
Subject: Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Cool, thanks Remi!  a job is scheduled to run tomorrow morning and looking 
forward to see 100% passrates!

Best
Raja

> On Nov 3, 2015, at 6:05 PM, Remi Bergsma  wrote:
>
> Hi Raja,
>
> Please see this PR: https://github.com/apache/cloudstack/pull/1028
>
> Regards,
> Remi
>
>
>
>
>> On 30/10/15 17:44, "Raja Pullela"  wrote:
>>
>> Hi Michael
>>
>> Can you please add a wait for the template  to download before the VM 
>> creation?
>>
>> Raja
>> Begin forwarded message:
>> From: Raja Pullela
>> >
>> Date: October 29, 2015 at 11:49:59 AM GMT+5:30
>> To: "CloudStack Dev
>> (dev@cloudstack.apache.org)"
>> >
>> Subject: Few BVTs failing
>> Reply-To:
>> >
>>
>> Hi,
>>
>> In the latest BVTs, following tests are failing consistently -
>>
>> * 2015-10-29 00:27:43,987 - CRITICAL - FAILED: 
>> test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
>> testMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, in 
>> test_vpc_remote_access_vpn\nself.fail(e)\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise 
>> self.failureException(msg)\n', 'AssertionError: Execute cmd: 
>> deployvirtualmachine failed, due to: errorCode: 530, errorText:Template 202 
>> has not been completely downloaded to zone 1\n']
>>
>> * 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION: 
>> test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
>> testMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, in 
>> test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to 
>> deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before 
>> assignment\n"]
>>
>> * 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION: 
>> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most recent 
>> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>> run\ntestMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 576, in 
>> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm = 
>> self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 382, in 
>> deployvm_in_network\nraise Exception("Deployment failed of VM: %s" % 
>> e)\n', "Exception: Deployment failed of VM: Job failed: {jobprocstatus : 0, 
>> created : u'2015-10-29T02:02:09+', jobresult : {errorcode : 533, 
>> errortext : u'Unable to create a deployment for VM[User|i-36-69-VM]'}, cmd : 
>> u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : 
>> u'afe432e8-7dd7-11e5-9ca5-b230fb1ebb83', jobstatus : 2, jobid : 
>> u'de5a239a-c70c-4039-9e8e-2ea9b80ed28b', jobresultcode : 530, jobinstanceid 
>> : u'47770620-0c37-4e7c-91e0-666bf7fe5eaa', jobresulttype : u'object', 
>> jobinstancetype : u'VirtualMachine', accountid : 
>> u'afe422b2-7dd7-11e5-9ca5-b230fb1ebb83'}\n"]
>>
>> * 2015-10-29 02:00:33,135 - CRITICAL - EXCEPTION: 
>> test02_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most recent 
>> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>> run\ntestMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 686, in 
>> test02_internallb_haproxy_stats_on_all_interfaces\nsettings = 
>> self.get_lb_stats_settings()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 646, in 
>> get_lb_stats_settings\nself.fail("Failed to retrieve stats settings " % 
>> e)\n', 'TypeError: not all arguments converted during string formatting\n']
>>
>> Looks like these were added by Michael.
>>
>> Michael,
>> Can you optimize the tests with the following
>>
>> 1)  Before the VM Deployment or right after Template Register, can you 
>> put a loop to check if the Template is in a ready state before continuing 
>> with the test ? The reason is Template download is not 

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1032#issuecomment-153709054
  


![untitled](https://cloud.githubusercontent.com/assets/2486961/10938358/b6905d48-82f9-11e5-9fd7-2a93934c7d8d.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153693746
  
Ping @remibergsma @karuturi @borisroman @DaanHoogland @miguelaferreira 

Test is finally done and bug-free!

Test Environment:

* Hardware required: true
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common RPMs built from source

```
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok

--
Ran 4 tests in 2085.023s

OK
/tmp//MarvinLogs/test_routers_network_ops_N14PY8/results.txt (END)
```

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153701619
  
Jenkins error is not related. It says "no failures" but still shows a red 
button on Cloud Server. By the way, I pushed a python file.


![image](https://cloud.githubusercontent.com/assets/5129209/10937755/6352e3c0-82f5-11e5-96a1-16264c4d959e.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153707458
  
A ticket is out for this at infra: INFRA-10703


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153699912
  
@wilderrodrigues @remibergsma Still had the tests setup running. Here are 
the results: 

```
=== TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | 
Status : SUCCESS ===
ok
=== TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | 
Status : SUCCESS ===
ok
=== TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | 
Status : SUCCESS ===
ok
=== TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | 
Status : SUCCESS ===
ok
```

LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1032#issuecomment-153708419
  
Just did LGTM (logging in as a sturmbahn)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1032#issuecomment-153708491
  
@DaanHoogland A picture or it didn't happen! ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1032


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153717404
  
Ping @borisroman @remibergsma @DaanHoogland @miguelaferreira @karuturi 

Test results:

```
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok

--
Ran 4 tests in 2005.385s

OK
/tmp//MarvinLogs/test_routers_network_ops_KVHJOX/results.txt (END)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1023


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153690595
  
@DaanHoogland if you look at the changes or the code that takes in Object 
(Response object) and serializes it; we create the json or xml response string 
by manually adding the delimiters ({, }, <, >, : characters etc). I was 
wondering if there is a way to avoid that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153694220
  
@wilderrodrigues Running now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

[Raja Pullela]

Thank you Rajani!

-Original Message-
From: Rajani Karuturi [mailto:rajani.karut...@citrix.com] 
Sent: Wednesday, November 4, 2015 5:18 PM
To: dev@cloudstack.apache.org
Subject: RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Its merged.

~Rajani
Sent from my Windows Phone

From: Raja Pullela
Sent: ‎04-‎11-‎15 15:55
To: dev@cloudstack.apache.org
Subject: RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Remi, Rajani, can you push this PR in ?

Best,
Raja

-Original Message-
From: Raja Pullela [mailto:raja.pull...@citrix.com]
Sent: Tuesday, November 3, 2015 7:02 PM
To: dev@cloudstack.apache.org
Subject: Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Cool, thanks Remi!  a job is scheduled to run tomorrow morning and looking 
forward to see 100% passrates!

Best
Raja

> On Nov 3, 2015, at 6:05 PM, Remi Bergsma  wrote:
>
> Hi Raja,
>
> Please see this PR: https://github.com/apache/cloudstack/pull/1028
>
> Regards,
> Remi
>
>
>
>
>> On 30/10/15 17:44, "Raja Pullela"  wrote:
>>
>> Hi Michael
>>
>> Can you please add a wait for the template  to download before the VM 
>> creation?
>>
>> Raja
>> Begin forwarded message:
>> From: Raja Pullela
>> >
>> Date: October 29, 2015 at 11:49:59 AM GMT+5:30
>> To: "CloudStack Dev
>> (dev@cloudstack.apache.org)"
>> >
>> Subject: Few BVTs failing
>> Reply-To:
>> >
>>
>> Hi,
>>
>> In the latest BVTs, following tests are failing consistently -
>>
>> * 2015-10-29 00:27:43,987 - CRITICAL - FAILED: 
>> test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
>> testMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, in 
>> test_vpc_remote_access_vpn\nself.fail(e)\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise 
>> self.failureException(msg)\n', 'AssertionError: Execute cmd: 
>> deployvirtualmachine failed, due to: errorCode: 530, errorText:Template 202 
>> has not been completely downloaded to zone 1\n']
>>
>> * 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION: 
>> test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
>> testMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, in 
>> test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to 
>> deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before 
>> assignment\n"]
>>
>> * 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION: 
>> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most recent 
>> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>> run\ntestMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 576, in 
>> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm = 
>> self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 382, in 
>> deployvm_in_network\nraise Exception("Deployment failed of VM: %s" % 
>> e)\n', "Exception: Deployment failed of VM: Job failed: {jobprocstatus : 0, 
>> created : u'2015-10-29T02:02:09+', jobresult : {errorcode : 533, 
>> errortext : u'Unable to create a deployment for VM[User|i-36-69-VM]'}, cmd : 
>> u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : 
>> u'afe432e8-7dd7-11e5-9ca5-b230fb1ebb83', jobstatus : 2, jobid : 
>> u'de5a239a-c70c-4039-9e8e-2ea9b80ed28b', jobresultcode : 530, jobinstanceid 
>> : u'47770620-0c37-4e7c-91e0-666bf7fe5eaa', jobresulttype : u'object', 
>> jobinstancetype : u'VirtualMachine', accountid : 
>> u'afe422b2-7dd7-11e5-9ca5-b230fb1ebb83'}\n"]
>>
>> * 2015-10-29 02:00:33,135 - CRITICAL - EXCEPTION: 
>> test02_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most recent 
>> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>> run\ntestMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 686, in 
>> test02_internallb_haproxy_stats_on_all_interfaces\nsettings = 
>> self.get_lb_stats_settings()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 646, in 
>> get_lb_stats_settings\nself.fail("Failed to retrieve stats settings " % 
>> e)\n', 'TypeError: not all arguments converted during string formatting\n']
>>
>> Looks like these were added by Michael.
>>
>> Michael,
>> Can you optimize 

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1032#issuecomment-153702504
  
ok, travis green does not mean it actually does anything, does it? In this 
case I think it did compile but none of the tests were run. Maybe that's enough 
for this one @remibergsma ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1032#issuecomment-153708234
  
Shouldn't we at least try a compile and see if the UI shows up?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153726658
  
LGTM, the test from this branch now succeed:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_routers_network_ops.py
```

Result:
```
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok

--
Ran 4 tests in 1812.275s

OK

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153695015
  
@bhaisaab Agree that the existing JSON and XML serialization can be 
improved but it is better to do it as a separate PR. For JSON, the standard 
Gson library is used. For XML we may have to check for a ASF compatible library 
that solves the purpose. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/902


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153704575
  
@koushik-das makes sense so we have a policy that for any sensitive field 
LogLevel(LogLevel.OFF) be used. We should add that as a comment to the enum to 
document it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153701940
  
JVM died: 
https://builds.apache.org/job/cloudstack-pull-analysis/1150/org.apache.cloudstack$cloud-server/console


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153713989
  
@borisroman , could you please retest? It worked for me and for you, but 
not for @remibergsma due to a resolving thing on RVR test. I then ran it again 
and it did not work. Seems to be some intermittent thing. The new push add a 
egress rule to open UDP/53, which makes it work.

It happens with RVR default egress DENY

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

[runseb]

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/997#issuecomment-153775777
  
nope, I'd like to figure out why tests are not running. Just have not found 
the time to do so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache CloudStack 4.6.0

[Nux!]

That's great, thanks a lot! Saves on time and confusion. If we could do this 
with every (rc) release, that'd be great.

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Rajani Karuturi" 
> To: dev@cloudstack.apache.org
> Sent: Wednesday, 4 November, 2015 16:17:10
> Subject: Re: [VOTE] Apache CloudStack 4.6.0

> I started jenkins builds for cloudstack RPM packages and systemvm templates 
> for
> this branch here
> 
> http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/19/console
> http://jenkins.buildacloud.org/view/parameterized/job/parameterized-sytemvm/3/console
> 
> We can use them once the build is complete.
> 
> ~Rajani
> 
> On 04-Nov-2015, at 8:58 PM, Nux! > 
> wrote:
> 
> Hi,
> 
> Has jenkins built rpms for this somewhere?
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
> 
> - Original Message -
> From: "Remi Bergsma" 
> To: dev@cloudstack.apache.org
> Sent: Wednesday, 4 November, 2015 14:55:11
> Subject: [VOTE] Apache CloudStack 4.6.0
> 
> Hi all,
> 
> I've created a 4.6.0 release candidate, with the following artifacts up for a
> vote:
> 
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522
> 
> Commit: b0ebe68e375432b28eef031ab62ccd5831234c77
> 
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
> 
> PGP release keys (signed using A47DDC4F):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
> Vote will be open for at least 72 hours.
> 
> For sanity in tallying the vote, can PMC members please be sure to indicate
> "(binding)" with their vote?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)

Re: [VOTE] Apache CloudStack 4.6.0

[Nux!]

Hi,

Has jenkins built rpms for this somewhere?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Remi Bergsma" 
> To: dev@cloudstack.apache.org
> Sent: Wednesday, 4 November, 2015 14:55:11
> Subject: [VOTE] Apache CloudStack 4.6.0

> Hi all,
> 
> I've created a 4.6.0 release candidate, with the following artifacts up for a
> vote:
> 
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522
> 
> Commit: b0ebe68e375432b28eef031ab62ccd5831234c77
> 
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
> 
> PGP release keys (signed using A47DDC4F):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
> Vote will be open for at least 72 hours.
> 
> For sanity in tallying the vote, can PMC members please be sure to indicate
> "(binding)" with their vote?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153783852
  
I think we should add isSensitive() to @Parameter and use that.

Also we should base this on gson 2+ and not on the version we are presently 
using.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1021#discussion_r43897789
  
--- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java 
---
@@ -62,10 +65,12 @@
 
 @SerializedName(ApiConstants.CERTIFICATE_CHAIN)
 @Param(description = "certificate chain")
+@LogLevel(Log4jLevel.Off)
 private String certchain;
 
 @SerializedName(ApiConstants.CERTIFICATE_FINGERPRINT)
 @Param(description = "certificate fingerprint")
+@LogLevel(Log4jLevel.Off)
--- End diff --

fingerprint is not sensitive (though it doesn't need to logged either)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1021#discussion_r43898594
  
--- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java ---
@@ -27,30 +29,40 @@
 import com.google.gson.GsonBuilder;
 
 /**
- * The ApiResonseGsonHelper is different from ApiGsonHelper - it 
registeres one more adapter for String type required for api response encoding
+ * The ApiResonseGsonHelper is different from ApiGsonHelper - it registers 
one more adapter for String type required for api response encoding
--- End diff --

We should upgrade gson before further expanding on this feature of it. 
Exlusion strategies have somewhat changed in version 2 in the sense that 
exclusion is cahced inside gson and a change in loglevel is not endorsed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache CloudStack 4.6.0

[Rajani Karuturi]

I started jenkins builds for cloudstack RPM packages and systemvm templates for 
this branch here

http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/19/console
http://jenkins.buildacloud.org/view/parameterized/job/parameterized-sytemvm/3/console

We can use them once the build is complete.

~Rajani

On 04-Nov-2015, at 8:58 PM, Nux! > wrote:

Hi,

Has jenkins built rpms for this somewhere?

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
From: "Remi Bergsma" 
To: dev@cloudstack.apache.org
Sent: Wednesday, 4 November, 2015 14:55:11
Subject: [VOTE] Apache CloudStack 4.6.0

Hi all,

I've created a 4.6.0 release candidate, with the following artifacts up for a
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522

Commit: b0ebe68e375432b28eef031ab62ccd5831234c77

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/

PGP release keys (signed using A47DDC4F):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for at least 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1021#discussion_r43897730
  
--- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java 
---
@@ -62,10 +65,12 @@
 
 @SerializedName(ApiConstants.CERTIFICATE_CHAIN)
 @Param(description = "certificate chain")
+@LogLevel(Log4jLevel.Off)
--- End diff --

cert chain is not sensitive data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1021#discussion_r43898186
  
--- Diff: api/src/org/apache/cloudstack/api/response/UserVmResponse.java ---
@@ -256,6 +259,7 @@
 
 @SerializedName(ApiConstants.SSH_KEYPAIR)
 @Param(description = "ssh key-pair")
+@LogLevel(Log4jLevel.Off)
--- End diff --

why is the keypair name sensitive?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1021#discussion_r43899212
  
--- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java ---
@@ -71,4 +83,19 @@ public boolean shouldSkipField(FieldAttributes f) {
 return false;
 }
 }
+
+private static class LogExclusionStrategy extends 
ApiResponseExclusionStrategy implements ExclusionStrategy {
--- End diff --

LoggingExclusionStrategy allready exists. It shouldn't be needed to 
implement again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9029: Proper support to identi...

[Carles-Figuerola]

GitHub user Carles-Figuerola opened a pull request:

https://github.com/apache/cloudstack/pull/1033

CLOUDSTACK-9029: Proper support to identify CentOS 7 version number

https://issues.apache.org/jira/browse/CLOUDSTACK-9029

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Carles-Figuerola/cloudstack 
centos-7-redhat-release

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1033


commit 3ce420c367363202cac4e4f5f59aac23d32defc7
Author: Carles Figuerola 
Date:   2015-11-04T17:21:47Z

CLOUDSTACK-9029: Proper support to identify CentOS 7 version number




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache CloudStack 4.6.0

[Remi Bergsma]

The jobs failed due to the git clone failing (time out). I also experience it 
is quite slow at the moment.

It is mirrored here (same commit id):
https://github.com/apache/cloudstack/tree/4.6.0-RC20151104T1522

Regards,
Remi




On 04/11/15 17:17, "Rajani Karuturi"  wrote:

>I started jenkins builds for cloudstack RPM packages and systemvm templates 
>for this branch here
>
>http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/19/console
>http://jenkins.buildacloud.org/view/parameterized/job/parameterized-sytemvm/3/console
>
>We can use them once the build is complete.
>
>~Rajani
>
>On 04-Nov-2015, at 8:58 PM, Nux! > wrote:
>
>Hi,
>
>Has jenkins built rpms for this somewhere?
>
>--
>Sent from the Delta quadrant using Borg technology!
>
>Nux!
>www.nux.ro
>
>- Original Message -
>From: "Remi Bergsma" 
>To: dev@cloudstack.apache.org
>Sent: Wednesday, 4 November, 2015 14:55:11
>Subject: [VOTE] Apache CloudStack 4.6.0
>
>Hi all,
>
>I've created a 4.6.0 release candidate, with the following artifacts up for a
>vote:
>
>Git Branch and Commit SH:
>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522
>
>Commit: b0ebe68e375432b28eef031ab62ccd5831234c77
>
>Source release (checksums and signatures are available at the same
>location):
>https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
>
>PGP release keys (signed using A47DDC4F):
>https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
>Vote will be open for at least 72 hours.
>
>For sanity in tallying the vote, can PMC members please be sure to indicate
>"(binding)" with their vote?
>
>[ ] +1  approve
>[ ] +0  no opinion
>[ ] -1  disapprove (and reason why)
>

Re: [VOTE] Apache CloudStack 4.6.0

[Wilder Rodrigues]

I have CentOS 7.1 RPMs. In case anyone needs them now, I can make available.

Testing the 4.6.0 RC as I type.

Cheers,
Wilder

> On 04 Nov 2015, at 18:12, Remi Bergsma  wrote:
> 
> The jobs failed due to the git clone failing (time out). I also experience it 
> is quite slow at the moment.
> 
> It is mirrored here (same commit id):
> https://github.com/apache/cloudstack/tree/4.6.0-RC20151104T1522
> 
> Regards,
> Remi
> 
> 
> 
> 
> On 04/11/15 17:17, "Rajani Karuturi"  wrote:
> 
>> I started jenkins builds for cloudstack RPM packages and systemvm templates 
>> for this branch here
>> 
>> http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter/19/console
>> http://jenkins.buildacloud.org/view/parameterized/job/parameterized-sytemvm/3/console
>> 
>> We can use them once the build is complete.
>> 
>> ~Rajani
>> 
>> On 04-Nov-2015, at 8:58 PM, Nux! > 
>> wrote:
>> 
>> Hi,
>> 
>> Has jenkins built rpms for this somewhere?
>> 
>> --
>> Sent from the Delta quadrant using Borg technology!
>> 
>> Nux!
>> www.nux.ro
>> 
>> - Original Message -
>> From: "Remi Bergsma" 
>> To: dev@cloudstack.apache.org
>> Sent: Wednesday, 4 November, 2015 14:55:11
>> Subject: [VOTE] Apache CloudStack 4.6.0
>> 
>> Hi all,
>> 
>> I've created a 4.6.0 release candidate, with the following artifacts up for a
>> vote:
>> 
>> Git Branch and Commit SH:
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151104T1522
>> 
>> Commit: b0ebe68e375432b28eef031ab62ccd5831234c77
>> 
>> Source release (checksums and signatures are available at the same
>> location):
>> https://dist.apache.org/repos/dist/dev/cloudstack/4.6.0/
>> 
>> PGP release keys (signed using A47DDC4F):
>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>> 
>> Vote will be open for at least 72 hours.
>> 
>> For sanity in tallying the vote, can PMC members please be sure to indicate
>> "(binding)" with their vote?
>> 
>> [ ] +1  approve
>> [ ] +0  no opinion
>> [ ] -1  disapprove (and reason why)
>> 

[GitHub] cloudstack pull request:

[resmo]

Github user resmo commented on the pull request:


https://github.com/apache/cloudstack/commit/34fee547cd10025f91e47e5efa6a97a96dd96313#commitcomment-14176906
  
German is now fully translated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/1031

CLOUDSTACK-9026: Modifying testpath for adding missing parameter

Addning service_offering creation in testpath_storage_migration.py testpath 
which is missing right now 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-9026-Modifying-testpath-for-adding-missing-parameter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1031


commit c2376334592835c30b865c2b08f8c179eed8d328
Author: Priti Sarap 
Date:   2015-11-04T09:18:38Z

CLOUDSTACK-9026: Modifying testpath for adding missing parameter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-153650536
  
@wido code are updated.
I have a node running with Ubuntu 12.04/qemu 1.2.1/libvirt 0.9.13 (not 
stock QEMU 1.0 and libvirt 0.9.8). It works fine in the vm snapshot testing.
I did not test libvirt 0.9.8, but I think it will work. I will test it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[NuxRo]

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-153643254
  
@koushik-das You are right, I did not realise the display name was missing 
from there.
Can't we make that table a bit wider so we can add another column or two?
It seems kind of silly to run with such a narrow design when we all have 
wide screens.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153656222
  
Talked with @karuturi and agreed that we make the tests in this PR work, 
then merge it. The other issue should be tracked and fixed separately as it is 
not a blocker (and this PR fixes a blocker).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153631129
  
@runseb I am with you but for 4.7 instead of 4.6. The Nuage people have 
shown great effort of elegantly using our crappy plugin system and are now 
maintaining it. We should use extreme prejudice in merging it for all kinds of 
reasons.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[runseb]

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153629584
  
@jburwell I hear what you are saying, but I think it would be totally 
unfair to ask this plugin provider to provide independent testing capability to 
the community. No other vendor plugin has been asked to do this and deciding to 
do this should not be done on a PR.

1- This PR has been submitted for sometime, and has had quite thorough 
review
2- The contributors are showing great respect, understanding and will to 
work with the community
3- As you mention other plugins are not tested independently, e.g Solidfire 
is maintained by Mike T and he did not even contribute his Marvin 
tests...Vmware NSX ?...

I'd rather work on a policy for removing dead code and abandoned plugins on 
the mailing list, than stop this great feature from being merged because we 
suddenly want to raise the bar and impose new way of testing third-party 
plugins.

The request to have a way for the community to test this independently of 
Nuage is valid but I would like to work with them in the coming month(s) to 
make this happen, rather than put a burden that has never existed on them now.

+1 for merge in 4.6



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[runseb]

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153631839
  
@DaanHoogland yep, so we can release this right on the heel of 4.6 release, 
with just one commit to get 4.7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1029#issuecomment-153634024
  
@koushik-das Thanks for your comments. I pushed a new commit . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153822915
  
I agree with @runseb that we need to move this discussion to dev@, and 
re-assess accepting the maintenance responsibly for code that cannot be tested 
and verified by the community.  This plugin has already been accepted into 4.5, 
and as such, would be "grandfathered" into any decision we would make.  
Therefore, we should carry our current precedent forward and not prevent 
acceptance of this PR for this reason.  We are at a point in the 4.6 release 
cycle that only blockers should be accepted.  Otherwise, we will never ship 4.6.

@KrisSterckx I realize my comments may come across as unappreciative which 
is not my intention.  I greatly appreciate the work @nlivens and you have done 
to contribute this capability to the community.  This plugin highlights a 
larger issue which is that, as a community, we are delivering releases 
containing code that cannot be verified.  By contributing this plugin to our 
community, we become responsible for its support and maintenance.  In 6-12 
months, how do answer answer a user who asks does this plugin work in the 
latest release if you are unavailable?

@runseb while there is a fairness issue for the contributor, I think it is 
incredibly unfair to our users that we ship code without on-going validation.  
When a user sees the availability of PluginX supporting Device1 in a release, 
they assume that we have verified the proper operation of PluginX since we 
shipped it in that release.  In fact, we haven't, and they may be attempting to 
use something that is completely broken.

@mlsorensen yes, plugins provide a mechanism for vendors to extend 
CloudStack.  However, there is no requirement for those plugins to be part of 
the community, OSS codebase.  Therefore, we should not conflate the ability of 
third-parties to extend CloudStack using plugins with the code that is accepted 
as part of the community's repositories.  All code in our repositories, 
regardless of being in the core or a plugin, should be held to the same 
standards.  When a user has a problem, they aren't any less frustrated with the 
project because their problem happens to be in a plugin.  

@mike-tutkowski I don't believe that code inspection by itself is adequate 
to determine the quality of code integrating an external device.  For example, 
I reviewed the code for this plugin, and while I feel confident that it will 
behave well within the management server, I have absolutely no idea if the 
various network functions are being properly automated using the Nuage client 
APIs.  The only way for those aspects of the plugin's operation to be verified 
would be to run in a test environment with a Nuage device and realize a set of 
network topologies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153830070
  
This PR will be merged once 4.6.0 is out and together with some other cool 
features (I counted at least 5 of them that have pull requests that are almost 
ready to be merged) it will become 4.7.0.

After 4.6.0 is out we'll start to see the benefit of all te hard work to 
make master stable: we will deliver another stable release (4.7.0) in say a 
month with new cool features. Velocity! Yay!

+1 for removing dead code. Let's make a list and discuss.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[runseb]

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/1032#issuecomment-153665922
  
+1 LGTM just looking at the translated strings. did not build it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[sspans]

Github user sspans commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153667126
  
Consistent Snapshots are not possible without freeze/thaw via the 
guest-agent.
I think most people want good snapshots of their virtual machines.

That said it's quite possible to disable the agent on particularly 
sensitive VM's if one feels the need,
the channel will still be open but nobody will be listening


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153668149
  
Also, it is possible to avoid serializing the objects by hand (like 
adding/appending {, >, <, } etc by hand?). Probably use any available library, 
and if that's not possible write unit tests to do some crud like comparisons?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153668057
  
So I wrote #985 which adds a channel by default to all guests. The question 
is, how do we proceed. Which one goes in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/801#issuecomment-153669186
  
@runseb, yes in principle but we have a list of 4.7 candidates allready, so 
It would cantain a little more. Let's try to contain it though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153671338
  
I created https://issues.apache.org/jira/browse/CLOUDSTACK-9027 to track 
the new issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

[Raja Pullela]

Remi, Rajani, can you push this PR in ?  

Best,
Raja

-Original Message-
From: Raja Pullela [mailto:raja.pull...@citrix.com] 
Sent: Tuesday, November 3, 2015 7:02 PM
To: dev@cloudstack.apache.org
Subject: Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

Cool, thanks Remi!  a job is scheduled to run tomorrow morning and looking 
forward to see 100% passrates! 

Best
Raja 

> On Nov 3, 2015, at 6:05 PM, Remi Bergsma  wrote:
> 
> Hi Raja,
> 
> Please see this PR: https://github.com/apache/cloudstack/pull/1028
> 
> Regards,
> Remi
> 
> 
> 
> 
>> On 30/10/15 17:44, "Raja Pullela"  wrote:
>> 
>> Hi Michael
>> 
>> Can you please add a wait for the template  to download before the VM 
>> creation?
>> 
>> Raja
>> Begin forwarded message:
>> From: Raja Pullela 
>> >
>> Date: October 29, 2015 at 11:49:59 AM GMT+5:30
>> To: "CloudStack Dev 
>> (dev@cloudstack.apache.org)" 
>> >
>> Subject: Few BVTs failing
>> Reply-To: 
>> >
>> 
>> Hi,
>> 
>> In the latest BVTs, following tests are failing consistently -
>> 
>> * 2015-10-29 00:27:43,987 - CRITICAL - FAILED: 
>> test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
>> testMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, in 
>> test_vpc_remote_access_vpn\nself.fail(e)\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise 
>> self.failureException(msg)\n', 'AssertionError: Execute cmd: 
>> deployvirtualmachine failed, due to: errorCode: 530, errorText:Template 202 
>> has not been completely downloaded to zone 1\n']
>> 
>> * 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION: 
>> test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File 
>> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
>> testMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, in 
>> test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to 
>> deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before 
>> assignment\n"]
>> 
>> * 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION: 
>> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most recent 
>> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>> run\ntestMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 576, in 
>> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm = 
>> self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 382, in 
>> deployvm_in_network\nraise Exception("Deployment failed of VM: %s" % 
>> e)\n', "Exception: Deployment failed of VM: Job failed: {jobprocstatus : 0, 
>> created : u'2015-10-29T02:02:09+', jobresult : {errorcode : 533, 
>> errortext : u'Unable to create a deployment for VM[User|i-36-69-VM]'}, cmd : 
>> u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : 
>> u'afe432e8-7dd7-11e5-9ca5-b230fb1ebb83', jobstatus : 2, jobid : 
>> u'de5a239a-c70c-4039-9e8e-2ea9b80ed28b', jobresultcode : 530, jobinstanceid 
>> : u'47770620-0c37-4e7c-91e0-666bf7fe5eaa', jobresulttype : u'object', 
>> jobinstancetype : u'VirtualMachine', accountid : 
>> u'afe422b2-7dd7-11e5-9ca5-b230fb1ebb83'}\n"]
>> 
>> * 2015-10-29 02:00:33,135 - CRITICAL - EXCEPTION: 
>> test02_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most recent 
>> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
>> run\ntestMethod()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 686, in 
>> test02_internallb_haproxy_stats_on_all_interfaces\nsettings = 
>> self.get_lb_stats_settings()\n', '  File 
>> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 646, in 
>> get_lb_stats_settings\nself.fail("Failed to retrieve stats settings " % 
>> e)\n', 'TypeError: not all arguments converted during string formatting\n']
>> 
>> Looks like these were added by Michael.
>> 
>> Michael,
>> Can you optimize the tests with the following
>> 
>> 1)  Before the VM Deployment or right after Template Register, can you 
>> put a loop to check if the Template is in a ready state before continuing 
>> with the test ? The reason is Template download is not getting completed and 
>> as a result the test cases are failing.
>> 
>> 2)  Any reason for not using test_data.py to have all the 
>> configuration/settings you have defined the test file ?
>> 
>> Please let me know if you have any questions, Raja
>> 

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153674330
  
@ustcweizhou Ah, I see indeed.

So the discussion is:
- Do we enable the port by default? I would say yes. (Less code!)
- Do we enable the port for SSVMs? I would say yes (Easier control over 
SSVMs)
- Do we need Python? I would say no, this can be done from Java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1028


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153677208
  
@bhaisaab can you explain ? I like your comment about the annotation not 
being descriptive on the sensitivity of the field. So for the best solution we 
would have to write another annotation for that. It would be tchnical similar 
to the @LogLevel and the paramter of the @APICommand. thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8902 Restart Network fails in ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/898


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153664020
  
ran the regression set with some f

```nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
component/test_password_server.py \
component/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py```
results:
```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
=== TestName: test_assign_and_removal_lb | Status : EXCEPTION ===
ERROR
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
FAILED ===
FAIL
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

==
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[bhaisaab]

Github user bhaisaab closed the pull request at:

https://github.com/apache/cloudstack/pull/1003


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[milamberspace]

GitHub user milamberspace opened a pull request:

https://github.com/apache/cloudstack/pull/1032

Update de_DE Localization. Now Web UI 4.6 is fully translated in German

Last update to have 100% on German in Web UI

Please 2 LGTM before the RC1!

Thanks @resmo 

cc @remibergsma @DaanHoogland @karuturi 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/milamberspace/cloudstack 
L10N-update-updateMaster-20151104

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1032.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1032


commit 54e77df5bb66f9c4f882994c1f007bc31b2e086a
Author: Milamber <milam...@apache.org>
Date:   2015-11-04T09:52:06Z

Update de_DE Localization. Now Web UI 4.6 is fully translated in German




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1003#issuecomment-153664686
  
@koushik-das I understand removal of the column may not be accepted, but 
then the UI would look misaligned if I add another column due to strict width 
issues.

One way could be to make the state column compact by just showing the icons 
and its values (such as Running, stopped etc) as title/tooltip.  I'll close 
this now, probably open another one in future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

[bhaisaab]

Github user bhaisaab closed the pull request at:

https://github.com/apache/cloudstack/pull/1004


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153664875
  
@ustcweizhou I don't see the difference personally, as a admin you already 
have full access to the Instance if you want to.

But this PR conflicts with mine, they can't be merged both :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [blocker/critical] CLOUDSTACK-9025 : [Xen...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1030#issuecomment-153668049
  
I am not sure why this PR is marked blocker/critical. The implemented code 
is a nested. It should have been a factored out check-method with unit test, 
not withstanding the integration test instructions in it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153667726
  
@koushik-das I think it's inappropriate as we're not marking those fields 
to note that they have hold sensitive information; but anyway that works


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153667850
  
@sspans Indeed. Users can stop/disable the agent or even block specific 
commands if they wish to. As CloudStack we don't control what's in the 
Instance, so it's the user who decides if he/she wants the Agent or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1029#issuecomment-153669733
  
Seems good! Great to see this :) Some tests are failing though, could you 
look into that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153672795
  
@wido this PR already includes your commits in #985 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: smoke/test_vpc_vpn: Add template wait & r...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1028#issuecomment-153673706
  
LGTM, test runs fine:

```
[root@cs1 MarvinLogs]# less test_vpc_vpn_WK8870/results.txt 
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok

--
Ran 2 tests in 1137.908s

OK
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153673995
  
Thanks, @karuturi !

I already found the error in the test, running it now and will push the 
code. The problem was:

* For RVR networks, an extra pub IP is being acquired, but when I do the 
SSH it first does a list IPs and uses the first one. In the RVR_default_allow 
it was not like that.

I know: stupid error. Probably due to writing tests after midnight... not 
healthy and not productive.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1032#issuecomment-153678077
  
+1 LGTM (ignore jenkins, one of the modules crashed due to jvm issue not 
code issues)
@remibergsma include this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update de_DE Localization. Now Web UI 4.6...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1032#issuecomment-153680282
  
@bhaisaab I agree that this run on jenkins can be ignored but let's see a 
successful compile anyhow. I have it in my queue but I will forgive anybody 
that beats me to it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9022: keep Destroyed volumes f...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1029#issuecomment-153680788
  
LGTM +1 (just code review, no testing was performed)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8925 - Default allow for Egres...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1023#issuecomment-153681147
  
Glad you found it @wilderrodrigues and thanks for the fix! Will retest soon!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8715: qemu-guest-agent s...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1027#issuecomment-153681436
  
@wido @sspans 
To be honest, this code was written by me about two years ago , which is 
not used for now. I created the PR because you guys can judge this code are 
useful or not. I have no comments if we revert some of the commits (or even 
all).
1. for the default port, if most of you agree, I will revert the related 
commits.
2. I agree. I did not remove it in the commits. However, I change the 
'vmName'.vport as the first virtio port, because cloud-early-config get the 
publickey and boot args from /dev/vport0p1.
3. rom my point of view, python is easy for testing, the data send/receive 
are already implemented. If you want to replace it with Java, that's very good. 
for now, python works fine in my testing, I even use it for guest agent command 
testing. btw, do you want replace patachviasocket.pl with java ?  I replace it 
with the python script in the PR.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1009#issuecomment-153681458
  
code LGTM, @rags22489664 can you put the integration test in the simulator 
on your backlog? would love to see it :) If tests pass merge, @remibergsma . 
Thought the only commit since your tests is the unit test which is validated by 
jenkins so merge at your will actually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CID 1338016: multi catch instead of pokem...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1018#issuecomment-153681786
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1019#issuecomment-153681753
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8485: listAPIs are taking too ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1021#issuecomment-153681687
  
@DaanHoogland we can simply use @LogLevel I simply shared that there is a 
slight chance on confusion in future, and do we then remove the 
requestHasSensitiveInfo/responseHasSensitiveInfo from Param/Apis throughout the 
codebase?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9006 - ListTemplates API retur...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1009


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9012 :automation of cores feat...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1011#issuecomment-153681911
  
LGTM (not tested, just reviewed code)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1010#issuecomment-153682260
  
@pritisarap12 I don't see any changes on the "Files changed" tab is the 
file plaintext with 0644 file mod, or is it already merged on master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---