date:20160128

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1261#issuecomment-176045236
  
@remibergsma build/smoke tests passed, constructor definition was changed 
with unused variables removed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1288#issuecomment-176045486
  
@runseb this was sent for master as the author intended, non-issue actually 
but would satisfy SonarQube from showing up redflags


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CID-1338387: Deletion of method endPointS...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1124#issuecomment-176045950
  
@rafaelweingartner thanks; @remibergsma should we let this be merged 
considering your integration test result, or you want to re-run them?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1342#issuecomment-176046154
  
cc @remibergsma requires merging on 4.6 and consequent fwd merges


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Freeze everything until we get CI

[ShapeBlue]
Rohit Yadav
Software Architect  ,   ShapeBlue

d:   | s: +44 203 603 0540  |  
m:  +91 8826230892

e:  rohit.ya...@shapeblue.com | t: 
   |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK

[cid:image62697c.png@c62a8c20.4d8db108]

Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.

On 27-Jan-2016, at 9:29 PM, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>> wrote:

>From the last 12 PRs that were merged, only 2 had integration tests executed 
>against.

Feel free to revert them, if you must

I went through a list of pending PRs searching by lgtms, all of them has either 
text changes and/or integration tests passed/attached, and/or changes validated 
by travis/jenkins. According to me, they were validated that’s why they were 
merged.

These were PRs that had some discussions, at least one LGTM; master is not 
broken.

There is no rush, I had some time (which I don’t difficult these days) so 
helped review and merge them.

Regards.

Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design & Build | 
CSForge – rapid IaaS deployment framework
CloudStack Consulting | 
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support | CloudStack 
Bootcamp Training Courses

RE: [PROPOSAL] Freeze everything until we get CI

Hi,

I mentioned last week I am working with a few of my colleagues to develop a 
repo of the Ansible plays to be able deploy both Marvin and virtualised 
environments - (relatively) simply and then run Marvin against that environment.

As I said, we have a load of work to do to get to the bottom of issues, as 
currently a large proportion of the 250 Marvin tests fail in my 'early' builds.

Once we triage issues into Marvin build/Marvin Tests/CloudStack Env/CloudStack 
Code, we'll be in better shape to see where we are.

Our intention is to not only share our approach and code, but also (with 
everyone's blessing) to work to integrate it into the infra that Citrix donated 
to Apache and allow anyone to ask this 'communal marvin' to generate a 
specified environment and run any of the integration tests against master or 
any given PR

We are actively working on this, but it is going to take a little time




[ShapeBlue]
Paul Angus
VP Technology   ,   ShapeBlue


d:  +44 203 617 0528 | s: +44 203 603 
0540 |  
m:  +44 7711 418784

e:  paul.an...@shapeblue.com | t: 
@cloudyangus  |
  w:  www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:imagec996fc.png@836cfe96.47bdedb6]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




-Original Message-
From: Bharat Kumar [mailto:bharat.ku...@citrix.com]
Sent: 28 January 2016 14:45
To:  
Subject: Re: [PROPOSAL] Freeze everything until we get CI

Hi,

I agree with Remi on the hurdles he mentioned. It is difficult to integrate 3rd 
party CI, If someone wants to implement their own CI, the link below gives one 
way to do it.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration

Thanks,
Bharat.

On 28-Jan-2016, at 2:52 AM, Wido den Hollander 
mailto:w...@widodh.nl>> wrote:



On 01/27/2016 10:02 PM, Remi Bergsma wrote:
Hi all,

We should keep the simple approach that was used until now: one LGTM based on 
code review and one LGTM based on integration tests (that’s not the same as 
2xLGTM).

If we care about master stability, every change has to be tested for 
regression. Period. Things may look OK, but still break something else in an 
unexpected way. IMHO, giving up on it would be a shame.

In a perfect world, CI would automate this for us and run it against every PR. 
Current impediments I see for proper CI on every PR:
- there is no community hardware to run integration tests on (there was 
supposed to be something)
- no support from Apache Infra: need Github write access (also to hook 3rd 
party CI). It’s nowhere close.
- the community has very few people that are able to run the integration tests 
on their own laptop/hardware and post the results on PRs


We tried to address points 1 and 2 and I propose to give up on them.

If all devs would stop developing for a couple of days and make sure they have 
a box that can run KVM, then clone the code we use [1] it should be pretty 
straight forward to run the integration tests. We choose to make it all virtual 
and used nested-virtualisation, but that is optional. A simple Intel Nuc or 
similar will do.


Yes, that's great code. I still have to master it, but the README should get us 
there.

I still need to create one which also spins up a Ceph cluster. Probably a good 
thing to do now ;)

Wido

People can then test the PRs that they find interesting and post results, after 
which it can be merged. Distribute it. Share the load.

This is what Wilder, Miguel, Boris, Daan an I have been doing for months. 
Simply running the tests. Hundreds of times. That’s why we can run a 100% 
Mission Critical Cloud close to master branch at Schuberg Philis.

Regards,
Remi

[1] https://github.com/schubergphilis/MCT-shared/






On 27/01/16 21:33, "Sebastien Goasguen" 
mailto:run...@gmail.com>> wrote:


On Jan 27, 2016, at 9:25 PM, Wido den Hollander 
mailto:w...@widodh.

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1274#issuecomment-176055926
  
@runseb checked the diff, travis/jenkins passed, diff looked good to me.
I've merged this and few others without integration tests as they *don't* 
explictly need them; see the diff -- do you think an explicit integration test 
is necessary for this simple NPE check?

IMO, some changes cannot be tested by integration tests - if they are text 
related, in non-Java files such as READMEs, reset scripts (not even used by 
systemvm/systemvm.iso). Then, there are some changes such as this where we can 
cheat and avoid running integration tests given you know the code, and 
build/travis passes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Freeze everything until we get CI



[ShapeBlue]
Rohit Yadav
Software Architect  ,   ShapeBlue


d:   | s: +44 203 603 0540  |  
m:  +91 8826230892

e:  rohit.ya...@shapeblue.com | t: 
   |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:image24a672.png@c43ecb78.4d9cef18]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




On 27-Jan-2016, at 10:02 PM, Remi Bergsma 
mailto:rberg...@schubergphilis.com>> wrote:

We should keep the simple approach that was used until now: one LGTM based on 
code review and one LGTM based on integration tests (that’s not the same as 
2xLGTM).

In general, a good idea though integration tests won’t apply everywhere to help 
us maintain quality.

We can cheat by avoiding integration tests but do other kinds of tests 
(manually for now) based on that Travis/Jenkins strictly pass and diffs are 
entirely:

- Text based in API doc/params for example, README files, comments, etc.

- Non-java code, not even systemvm related scripts where they may require 
alternative tests; such as changes in systemvm-template building scripts, 
marvin, docker etc.

- Javascript file changes, as that would require some manual testing and 
screenshots and won’t be caught by integration tests

Regards.

Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design & Build | 
CSForge – rapid IaaS deployment framework
CloudStack Consulting | 
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support | CloudStack 
Bootcamp Training Courses

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Remi Bergsma

Hi Paul,

Indeed not all Marvin tests are generic enough and can be run on all 
environments. If you use this [1] collection of ~85 tests it should work well 
as we tested the PRs with these. Sure we should add more, but it’s probably way 
faster if you’d use these and work from there, instead of trying to get them 
all to work.

Regards,
Remi

[1] 
https://github.com/schubergphilis/MCT-shared/blob/master/helper_scripts/cloudstack/run_marvin_router_tests.sh
 (the name of the file by now is a bit mis-leading)



From: Paul Angus mailto:paul.an...@shapeblue.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Thursday 28 January 2016 09:29
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: RE: [PROPOSAL] Freeze everything until we get CI

Hi,

I mentioned last week I am working with a few of my colleagues to develop a 
repo of the Ansible plays to be able deploy both Marvin and virtualised 
environments - (relatively) simply and then run Marvin against that environment.

As I said, we have a load of work to do to get to the bottom of issues, as 
currently a large proportion of the 250 Marvin tests fail in my 'early' builds.

Once we triage issues into Marvin build/Marvin Tests/CloudStack Env/CloudStack 
Code, we'll be in better shape to see where we are.

Our intention is to not only share our approach and code, but also (with 
everyone's blessing) to work to integrate it into the infra that Citrix donated 
to Apache and allow anyone to ask this 'communal marvin' to generate a 
specified environment and run any of the integration tests against master or 
any given PR

We are actively working on this, but it is going to take a little time




[ShapeBlue]
Paul Angus
VP Technology   ,   ShapeBlue


d:  +44 203 617 0528 | s: +44 203 603 
0540 |  
m:  +44 7711 418784

e:  paul.an...@shapeblue.com | t: 
@cloudyangus  |
  w:  www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:imagec996fc.png@836cfe96.47bdedb6]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




-Original Message-
From: Bharat Kumar [mailto:bharat.ku...@citrix.com]
Sent: 28 January 2016 14:45
To: mailto:dev@cloudstack.apache.org>> 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [PROPOSAL] Freeze everything until we get CI

Hi,

I agree with Remi on the hurdles he mentioned. It is difficult to integrate 3rd 
party CI, If someone wants to implement their own CI, the link below gives one 
way to do it.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration

Thanks,
Bharat.

On 28-Jan-2016, at 2:52 AM, Wido den Hollander 
mailto:w...@widodh.nl>> wrote:



On 01/27/2016 10:02 PM, Remi Bergsma wrote:
Hi all,

We should keep the simple approach that was used until now: one LGTM based on 
code review and one LGTM based on integration tests (that’s not the same as 
2xLGTM).

If we care about master stability, every change has to be tested for 
regression. Period. Things may look OK, but still break something else in an 
unexpected way. IMHO, giving up on it would be a shame.

In a perfect world, CI would automate this for us and run it against every PR. 
Current impediments I see for proper CI on every PR:
- there is no community hardware to run integration tests on (there was 
supposed to be something)
- no support from Apache Infra: need Github write access (also to hook 3rd 
party CI). It’s nowhere close.
- the community has very few people that are able to run the integration tests 
on their own laptop/hardware and post the results on PRs


We tried to address points 1 and 2 and I propose to give up on them.

If all devs would stop developing for a couple of days and make sure they have 
a box that can run KVM, then clone the code we use

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Remi Bergsma

Sure Rohit, sometimes it makes no sense to run integration tests. That’s why 
for example I build an environment and check the UI when someone changes a 
javascript file.

Just saying it “looks” good is valuable from a code review point of view, but 
not from a verification point of view. I say we always need both.

As a general rule, every PR should be “tested” so one way or the other you need 
to show it works. Can be integration tests, can be UI screenshot, can be 
successful package build result or whatever. Currently, there is not much real 
“testing” going on and people expect this to magically happen somehow by 
someone else. Currently I feel quite alone in performing that "magic". I can’t 
and won’t keep that up.

Regards,
Remi


From: Rohit Yadav mailto:rohit.ya...@shapeblue.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Thursday 28 January 2016 09:50
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [PROPOSAL] Freeze everything until we get CI



[ShapeBlue]
Rohit Yadav
Software Architect  ,   ShapeBlue


d:   | s: +44 203 603 0540  |  
m:  +91 8826230892

e:  rohit.ya...@shapeblue.com | t: 
   |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:image24a672.png@c43ecb78.4d9cef18]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




On 27-Jan-2016, at 10:02 PM, Remi Bergsma 
mailto:rberg...@schubergphilis.com>> wrote:

We should keep the simple approach that was used until now: one LGTM based on 
code review and one LGTM based on integration tests (that’s not the same as 
2xLGTM).

In general, a good idea though integration tests won’t apply everywhere to help 
us maintain quality.

We can cheat by avoiding integration tests but do other kinds of tests 
(manually for now) based on that Travis/Jenkins strictly pass and diffs are 
entirely:

- Text based in API doc/params for example, README files, comments, etc.

- Non-java code, not even systemvm related scripts where they may require 
alternative tests; such as changes in systemvm-template building scripts, 
marvin, docker etc.

- Javascript file changes, as that would require some manual testing and 
screenshots and won’t be caught by integration tests

Regards.

Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design & Build | 
CSForge – rapid IaaS deployment framework
CloudStack Consulting | 
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support | CloudStack 
Bootcamp Training Courses

RE: [PROPOSAL] Freeze everything until we get CI

Thanks Remi,

That would give us a working 'good' baseline to start from - I've found tests 
that have hardcoded local IPs in template URLs and allsorts in the Marvin test 
scripts.

We'll look to add a little move configurability (such as template locations)

I also want to get working on expanding marvin to include new features and 
continue 'encouraging' people fixing bugs to write tests to ensure fixes 'work' 
and to avoid regressions later on.




Paul Angus
VP Technology   ,   ShapeBlue


t:  @cloudyangus

e:  paul.an...@shapeblue.com|  
w:  www.shapeblue.com





-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
Sent: 28 January 2016 17:57
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] Freeze everything until we get CI

Hi Paul,

Indeed not all Marvin tests are generic enough and can be run on all 
environments. If you use this [1] collection of ~85 tests it should work well 
as we tested the PRs with these. Sure we should add more, but it’s probably way 
faster if you’d use these and work from there, instead of trying to get them 
all to work.

Regards,
Remi

[1] 
https://github.com/schubergphilis/MCT-shared/blob/master/helper_scripts/cloudstack/run_marvin_router_tests.sh
 (the name of the file by now is a bit mis-leading)



From: Paul Angus mailto:paul.an...@shapeblue.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Thursday 28 January 2016 09:29
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: RE: [PROPOSAL] Freeze everything until we get CI

Hi,

I mentioned last week I am working with a few of my colleagues to develop a 
repo of the Ansible plays to be able deploy both Marvin and virtualised 
environments - (relatively) simply and then run Marvin against that environment.

As I said, we have a load of work to do to get to the bottom of issues, as 
currently a large proportion of the 250 Marvin tests fail in my 'early' builds.

Once we triage issues into Marvin build/Marvin Tests/CloudStack Env/CloudStack 
Code, we'll be in better shape to see where we are.

Our intention is to not only share our approach and code, but also (with 
everyone's blessing) to work to integrate it into the infra that Citrix donated 
to Apache and allow anyone to ask this 'communal marvin' to generate a 
specified environment and run any of the integration tests against master or 
any given PR

We are actively working on this, but it is going to take a little time




[ShapeBlue]
Paul Angus
VP Technology , ShapeBlue


d: +44 203 617 0528 | s: +44 203 603 
0540 | m: +44 
7711 418784

e: paul.an...@shapeblue.com | t: 
@cloudyangus | w: 
www.shapeblue.com

a: 53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:imagec996fc.png@836cfe96.47bdedb6]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




-Original Message-
From: Bharat Kumar [mailto:bharat.ku...@citrix.com]
Sent: 28 January 2016 14:45
To: mailto:dev@cloudstack.apache.org>> 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [PROPOSAL] Freeze everything until we get CI

Hi,

I agree with Remi on the hurdles he mentioned. It is difficult to integrate 3rd 
party CI, If someone wants to implement their own CI, the link below gives one 
way to do it.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration

Thanks,
Bharat.

On 28-Jan-2016, at 2:52 AM, Wido den Hollander 
mailto:w...@widodh.nl>> wrote:



On 01/27/2016 10:02 PM, Remi Bergsma wrote:
Hi all,

We should keep the simple approach that was used until now: one LGTM based on 
code review and one LGTM based on integration tests (that’s not the same as 
2xLGTM).

If we care about master stability, every change has to be tested for 
re

Build failed in Jenkins: build-master-slowbuild #3094

See 

--
[...truncated 28675 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.742s]
[INFO] Apache CloudStack . SUCCESS [2.101s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.775s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [20.814s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.245s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.112s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.767s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.476s]
[INFO] Apache CloudStack API . SUCCESS [1:48.507s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [15.999s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.405s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.091s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.346s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.103s]
[INFO] Apache CloudStack Core  SUCCESS [1:20.803s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.179s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [37.103s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.198s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.498s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.895s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.717s]
[INFO] Apache CloudStack Server .. SUCCESS [4:12.403s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.291s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.233s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.989s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.068s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.446s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [55.175s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.994s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.535s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [27.203s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.618s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.064s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.554s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.431s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.081s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.964s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.822s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.809s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.685s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.176s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.190s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.962s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.996s]
[INFO] Apache Cloud

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1350#issuecomment-176080946
  
@agneya2001 Sounds like you want to set the style guide. you and 
@rafaelweingartner should take this discussion to a higher level and take it to 
a discuss thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

2016-01-28 Thread agneya2001

Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/1350#issuecomment-176082402
  
@DaanHoogland I agree there should be some guideline on code style. If 
these are there I think most of us will be willing to follow these. I guess it 
will not be difficult to adapt something that is already out there. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Daan Hoogland

On Wed, Jan 27, 2016 at 9:18 PM, Sebastien Goasguen 
wrote:

> Now Travis is not running, Jenkins fails all the time and nobody cares…
>

Sebastien, Jenkins succeeds more then 50% of the time and I do care.
Please report problems with jenkins.



-- 
Daan

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

2016-01-28 Thread sarathkouk

GitHub user sarathkouk opened a pull request:

https://github.com/apache/cloudstack/pull/1377

 Escalation Automation of bug CS-43976 :VM snapshot fails for 12 min â¦

â¦after instance creation

ISSUE

VM snapshot fails for 12 min after instance creation

EXPECTED BEHAVIOR
==
VMSnapshot should be successful from the moment the VM is ready

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarathkouk/cloudstack escalation2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1377


commit 8db4806cfa142adf66e7e6ed79b7929f4ceefe12
Author: sharath 
Date:   2016-01-28T09:49:27Z

 Escalation Automation of bug CS-43976 :VM snapshot fails for 12 min after 
instance creation

ISSUE

VM snapshot fails for 12 min after instance creation

EXPECTED BEHAVIOR
==
VMSnapshot should be successful from the moment the VM is ready




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1377#issuecomment-176095546
  
@sarathkouk please remove the internal bug reference and replace it by an 
apache equivalent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Escalation Automation of bug CS-43976 :VM...

2016-01-28 Thread sarathkouk

Github user sarathkouk commented on the pull request:

https://github.com/apache/cloudstack/pull/1377#issuecomment-176095486
  
TEST RESULT :  
@summary: Test  if SS creation is successful in the first ... === TestName: 
test_05_check_vm_snapshot_creation_after_Instance_creation | Status : SUCCESS 
===
ok

--
Ran 1 test in 305.719s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Freeze everything until we get CI

So, since some have directly (over IM etc) or indirectly have thrown 
allegations on me since I merged most of the PRs.
Here is a list of those 12 PRs and answers on why they were merged on 
case-by-case basis.
Please keep any further replies technical and to the specific PR, please point 
out and revert if needed:

1. https://github.com/apache/cloudstack/pull/1288

Enough LGTMs, JS related change and fix tested with UI screenshot from Remi. I 
personally looked at the diff and therefore then merged.

2. https://github.com/apache/cloudstack/pull/1274/files

Enough LGTMs, a simple NPE fix one-liner. I personally thought we can cheat 
here and given Travis/Jenkins passed I merged it.

3. https://github.com/apache/cloudstack/pull/1261/files

Enough LGTMs, the diff only removed unused variable leading to change in the 
constructor definition. Explicit integration tests are not necessary as it’d 
simply dead-code removal and as the simulator smoke tests passed with 
Travis/Jenkins passed so I merged it.

4. https://github.com/apache/cloudstack/pull/1048

Enough LGTMs. This change is related to a marvin test itself where it adds 2 
new test methods — so no need to run regression integration test. The 
integration test result of the marvin test was shared in the comment. PR merged 
on this basis.

5. https://github.com/apache/cloudstack/pull/1044

Enough LGTMs and regression tests results (shared as attachments by Daan, in 
case someone missed), so merged.

6. https://github.com/apache/cloudstack/pull/969

Enough LGTMs and regression tests results (shared as attachments by Daan, in 
case someone missed), so merged.

7. https://github.com/apache/cloudstack/pull/855

Enough LGTMs and regression tests results by Remi, so merged.

8. https://github.com/apache/cloudstack/pull/831

Enough LGTMs and only text changes in API doc-string so merged given 
Travis/Jenkins passed.

9. https://github.com/apache/cloudstack/pull/830/files

Enough LGTMs and NPE fixes, so no explicit integration tests required given 
Travis/Jenkins passed.

10. https://github.com/apache/cloudstack/pull/1256/files

Enough LGTMs and simple Java OOP fix with Travis/Jenkins passed so merged this. 
I’m aware of this codebase.

11. https://github.com/apache/cloudstack/pull/1240

Enough LGTMs, the changes would require manual tests wrt usage server etc as 
well as confirmed in comments. I had seen the regression test result (of the 
new/modified marvin test wrt of the feature) so merged. The regression test 
suite does not include this among other tests.

12. https://github.com/apache/cloudstack/pull/1289

Enough LGTMs, this was a findbugs related fix. Travis/Jenkins passed on it and 
the findbugs mvn job result was shared to confirm that the fix works now. This 
was not merged by me.

Regards.


[ShapeBlue]
Rohit Yadav
Software Architect  ,   ShapeBlue


d:   | s: +44 203 603 0540  |  
m:  +91 8826230892

e:  rohit.ya...@shapeblue.com | t: 
   |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:imagec3b5d1.png@4f59c4e1.4a840a5d]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design & Build | 
CSForge – rapid IaaS deployment framework
CloudStack Consulting | 
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support | CloudStack 
Bootcamp Training Courses

[GitHub] cloudstack pull request: [4.9+] WIP: Support Java 8, Maven 3.3, Up...

Github user bhaisaab closed the pull request at:

https://github.com/apache/cloudstack/pull/1370


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Config Drive

2016-01-28 Thread Eric Waegeman

Hi all,

we would like to port "Config drive" on KVM feature to a previous version
of Cloudstack for one of our customers. We got most of it working but have
a problem in udev not putting the config drive ISO in /dev/disk/by-label
path because it considers it to be a removable drive.

And we would like to have a look at the userdata/password scripts mentioned
in the design document
 but
don't know where to find them.

Any help is appreciated,
Eric.

[GitHub] cloudstack pull request: trailing commas in javascripts removed

2016-01-28 Thread runseb

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/1288#issuecomment-176107957
  
Hi @bhaisaab I am genuinely asking because of the new release principles:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up

where we agreed to apply to release branches and merge forward.

Now this is not a bug per se, so could go directly to master, but I think 
it could be applied as a "fix" and merged forward


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

2016-01-28 Thread runseb

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/1274#issuecomment-176108973
  
@bhaisaab actually I am not even seeing the travis runs here anymore.

Reason I am asking is genuine (again), because in the last few months 
Travis has shown to be flaky and was Green when actually tests did not run ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: trailing commas in javascripts removed

2016-01-28 Thread remibergsma

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1288#issuecomment-176114078
  
@runseb We could see it as a bug, but I agree with @bhaisaab that it is a 
non-issue that was "fixed" to make SonarQube happy. Fine to do that straight on 
master IMHO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1288#issuecomment-176114524
  
@runseb @bhaisaab I think this is worth a small but intensive discussion, 
preferably over a beer. What we are talking about is neither a bug nor a 
feature. We never mentioned this kind of improvement in are procedures. My 
instict goes with the way @bhaisaab handled this but that is worth less then 
â¬0,02.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Sebastien Goasguen

Hi Folks,

My proposal to freeze until we get CI was indeed due to seeing Rohit’s commit 
but was by no means a personal attack or judgment.

We have lots of PR pending (as mentioned before by Remi) and we need people to 
help review and test.
So thanks to Rohit.

My only concerns were two fold:

1- We need  to keep to adhere to our release principles:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up

Hence I replied to some PR asking if they needed to be merged directly in 
master or not and wondered about the release branches.

With so many releases in flight it is not yet clear to me where we start to 
apply a PR ?

2- We need to keep testing and post results of tests.

Currently it is manual and but there has been a strong guarantee in the last 
releases that the PR where not going to break things.
While I agree that some PR are small and *should* not break things, history has 
shown that even small unrelated things *somehow* can affect the behavior of 
cloudstack.

So I proposed a freeze because:

- Remi stepped down as RM and we don’t have an official RM yet.
- The code has reached a solid state and we don’t want to do anything that 
changes that
- We have a proposal for LTS on the floor
- We still don’t have CI.

So my standpoint is that we focused in the last 6 months on getting our release 
principles right (pending LTS principles), code has stabilized and we can 
release. Awesome.

Now is probably a good time to concentrate our limited resources on figuring 
out automated CI.

- For instance as far as I know Travis is bonkers…(reports green but does not 
do anything)
- And with citrix stepping out, we need to take control of the jenkins slaves 
(some of which are on AWS and still paid by Citrix…)

My email while triggered by seeing Rohit’s commits, was not a judgement or 
critic of his actions, so let’s not get into a personal argument here.

-Sebastien

> On Jan 28, 2016, at 11:00 AM, Rohit Yadav  wrote:
> 
> So, since some have directly (over IM etc) or indirectly have thrown 
> allegations on me since I merged most of the PRs.
> Here is a list of those 12 PRs and answers on why they were merged on 
> case-by-case basis.
> Please keep any further replies technical and to the specific PR, please 
> point out and revert if needed:
> 
> 1. https://github.com/apache/cloudstack/pull/1288
> 
> Enough LGTMs, JS related change and fix tested with UI screenshot from Remi. 
> I personally looked at the diff and therefore then merged.
> 
> 2. https://github.com/apache/cloudstack/pull/1274/files
> 
> Enough LGTMs, a simple NPE fix one-liner. I personally thought we can cheat 
> here and given Travis/Jenkins passed I merged it.
> 
> 3. https://github.com/apache/cloudstack/pull/1261/files
> 
> Enough LGTMs, the diff only removed unused variable leading to change in the 
> constructor definition. Explicit integration tests are not necessary as it’d 
> simply dead-code removal and as the simulator smoke tests passed with 
> Travis/Jenkins passed so I merged it.
> 
> 4. https://github.com/apache/cloudstack/pull/1048
> 
> Enough LGTMs. This change is related to a marvin test itself where it adds 2 
> new test methods — so no need to run regression integration test. The 
> integration test result of the marvin test was shared in the comment. PR 
> merged on this basis.
> 
> 5. https://github.com/apache/cloudstack/pull/1044
> 
> Enough LGTMs and regression tests results (shared as attachments by Daan, in 
> case someone missed), so merged.
> 
> 6. https://github.com/apache/cloudstack/pull/969
> 
> Enough LGTMs and regression tests results (shared as attachments by Daan, in 
> case someone missed), so merged.
> 
> 7. https://github.com/apache/cloudstack/pull/855
> 
> Enough LGTMs and regression tests results by Remi, so merged.
> 
> 8. https://github.com/apache/cloudstack/pull/831
> 
> Enough LGTMs and only text changes in API doc-string so merged given 
> Travis/Jenkins passed.
> 
> 9. https://github.com/apache/cloudstack/pull/830/files
> 
> Enough LGTMs and NPE fixes, so no explicit integration tests required given 
> Travis/Jenkins passed.
> 
> 10. https://github.com/apache/cloudstack/pull/1256/files
> 
> Enough LGTMs and simple Java OOP fix with Travis/Jenkins passed so merged 
> this. I’m aware of this codebase.
> 
> 11. https://github.com/apache/cloudstack/pull/1240
> 
> Enough LGTMs, the changes would require manual tests wrt usage server etc as 
> well as confirmed in comments. I had seen the regression test result (of the 
> new/modified marvin test wrt of the feature) so merged. The regression test 
> suite does not include this among other tests.
> 
> 12. https://github.com/apache/cloudstack/pull/1289
> 
> Enough LGTMs, this was a findbugs related fix. Travis/Jenkins passed on it 
> and the findbugs mvn job result was shared to confirm that the fix works now. 
> This was not merged by me.
> 
> Regards.
> 
> 
>   
> Rohit Yadav
> Software Archi

[GitHub] cloudstack pull request: trailing commas in javascripts removed

2016-01-28 Thread runseb

Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/1288#issuecomment-176115753
  
@bhaisaab @remibergsma @DaanHoogland ok then, just checking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: disable github notifications ?

2016-01-28 Thread Sebastien Goasguen

The interesting thing is to look at our archive:

http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201601.mbox/thread

And try to get in the shoes of a new comer or someone browsing for info.

January starts with 50 jenkins failed build emails...

I agree that GH discussion need to be recorded…but JIRA discussions for 
instance go to issues@

maybe we create a pr@ and direct GH there ?

> On Jan 27, 2016, at 11:23 PM, Wei ZHOU  wrote:
> 
> Agree.
> 
> Can we move to issues mailing list or create a new mailing list ?
> I am interested in the github PRs and comments.
> 
> 
> -Wei
> 
> 
> 
> 2016-01-27 15:59 GMT+01:00 sebgoa :
> 
>> Hi folks,
>> 
>> Shall we disable github notifications to dev@ ?
>> 
>> It has become quite noisy.
>> 
>> On the other end you see all the comments fly by...
>> 
>> -sebastien
>>

Re: disable github notifications ?

2016-01-28 Thread Daan Hoogland

On Thu, Jan 28, 2016 at 11:42 AM, Sebastien Goasguen 
wrote:

> January starts with 50 jenkins failed build emails...
>
>
Ah, don't forget we have our own jenkins and the builds.pache.org ones.
The ones going to github are the builds builds named
cloudstack-pr-analysis. The master-slow-build is indeed failing since a
long time due to findbugs errors. there were 5 and 2 of them are still out
there. BTW those got in in spite of our strict policy so maybe we need to
further tighten the belt.


personally I would want everybody to be reminded of introduced weaknesses
untill they are fixed. Open to discussion though.

-- 
Daan

Re: [PROPOSAL] Freeze everything until we get CI

All,

I’m sorry to get to have the PRs merged without adhering to the strict testing 
requirements. While I think PRs were alright and it did not break anything, the 
way it was merged made people uncomfortable that there is some sort of haste in 
doing this fast which there is none.

I’ll not repeat this and hope you understand that I never had any hidden agenda 
but to simply help people with some PRs.

Regards.

> On 28-Jan-2016, at 11:36 AM, Sebastien Goasguen  wrote:
>
> Hi Folks,
>
> My proposal to freeze until we get CI was indeed due to seeing Rohit’s commit 
> but was by no means a personal attack or judgment.
>
> We have lots of PR pending (as mentioned before by Remi) and we need people 
> to help review and test.
> So thanks to Rohit.
>
> My only concerns were two fold:
>
> 1- We need  to keep to adhere to our release principles:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up
>
> Hence I replied to some PR asking if they needed to be merged directly in 
> master or not and wondered about the release branches.
>
> With so many releases in flight it is not yet clear to me where we start to 
> apply a PR ?
>
> 2- We need to keep testing and post results of tests.
>
> Currently it is manual and but there has been a strong guarantee in the last 
> releases that the PR where not going to break things.
> While I agree that some PR are small and *should* not break things, history 
> has shown that even small unrelated things *somehow* can affect the behavior 
> of cloudstack.
>
> So I proposed a freeze because:
>
> - Remi stepped down as RM and we don’t have an official RM yet.
> - The code has reached a solid state and we don’t want to do anything that 
> changes that
> - We have a proposal for LTS on the floor
> - We still don’t have CI.
>
> So my standpoint is that we focused in the last 6 months on getting our 
> release principles right (pending LTS principles), code has stabilized and we 
> can release. Awesome.
>
> Now is probably a good time to concentrate our limited resources on figuring 
> out automated CI.
>
> - For instance as far as I know Travis is bonkers…(reports green but does not 
> do anything)
> - And with citrix stepping out, we need to take control of the jenkins slaves 
> (some of which are on AWS and still paid by Citrix…)
>
> My email while triggered by seeing Rohit’s commits, was not a judgement or 
> critic of his actions, so let’s not get into a personal argument here.
>
> -Sebastien
>
>> On Jan 28, 2016, at 11:00 AM, Rohit Yadav  wrote:
>>
>> So, since some have directly (over IM etc) or indirectly have thrown 
>> allegations on me since I merged most of the PRs.
>> Here is a list of those 12 PRs and answers on why they were merged on 
>> case-by-case basis.
>> Please keep any further replies technical and to the specific PR, please 
>> point out and revert if needed:
>>
>> 1. https://github.com/apache/cloudstack/pull/1288
>>
>> Enough LGTMs, JS related change and fix tested with UI screenshot from Remi. 
>> I personally looked at the diff and therefore then merged.
>>
>> 2. https://github.com/apache/cloudstack/pull/1274/files
>>
>> Enough LGTMs, a simple NPE fix one-liner. I personally thought we can cheat 
>> here and given Travis/Jenkins passed I merged it.
>>
>> 3. https://github.com/apache/cloudstack/pull/1261/files
>>
>> Enough LGTMs, the diff only removed unused variable leading to change in the 
>> constructor definition. Explicit integration tests are not necessary as it’d 
>> simply dead-code removal and as the simulator smoke tests passed with 
>> Travis/Jenkins passed so I merged it.
>>
>> 4. https://github.com/apache/cloudstack/pull/1048
>>
>> Enough LGTMs. This change is related to a marvin test itself where it adds 2 
>> new test methods — so no need to run regression integration test. The 
>> integration test result of the marvin test was shared in the comment. PR 
>> merged on this basis.
>>
>> 5. https://github.com/apache/cloudstack/pull/1044
>>
>> Enough LGTMs and regression tests results (shared as attachments by Daan, in 
>> case someone missed), so merged.
>>
>> 6. https://github.com/apache/cloudstack/pull/969
>>
>> Enough LGTMs and regression tests results (shared as attachments by Daan, in 
>> case someone missed), so merged.
>>
>> 7. https://github.com/apache/cloudstack/pull/855
>>
>> Enough LGTMs and regression tests results by Remi, so merged.
>>
>> 8. https://github.com/apache/cloudstack/pull/831
>>
>> Enough LGTMs and only text changes in API doc-string so merged given 
>> Travis/Jenkins passed.
>>
>> 9. https://github.com/apache/cloudstack/pull/830/files
>>
>> Enough LGTMs and NPE fixes, so no explicit integration tests required given 
>> Travis/Jenkins passed.
>>
>> 10. https://github.com/apache/cloudstack/pull/1256/files
>>
>> Enough LGTMs and simple Java OOP fix with Travis/Jenkins passed so merged 
>> this. I’m aware of this codebase.
>>
>> 11. https://github.com/apache/cloudsta

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

GitHub user ProjectMoon opened a pull request:

https://github.com/apache/cloudstack/pull/1378

Emit event UUIDs on template deletion

When a template is deleted, it emits a usage event over the event bus. 
However, it does not emit the UUID or class name of the template over the event 
bus. This is leads to null pointers when expecting a template UUID on a delete 
event. The UUID and class name of the template are present on template 
creation, and on other usage events for different resources. 

We have based this on 4.6 because we consider this a bug fix and it should 
be forward-merged.

Testing: No unit tests provided, but we have tested it in a fully deployed 
staging environment. Without this fix, delete a template and check the messages 
on the event bus. No template UUID or class name (VirtualMachineTemplate). With 
this fix, the template UUID and class name are emitted on the event bus.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack 
pr-emit-template-uuid-on-delete

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1378


commit e405d9075ab6dedcb061e6edcea77136303d3430
Author: jeff 
Date:   2016-01-28T10:19:00Z

Emit template UUID and class name over event bus when deleting templates.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8324: config drive data set/ge...

2016-01-28 Thread jayapalu

GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1379

CLOUDSTACK-8324: config drive data set/get scripts for the guest vm

Added the guest vm scripts for set/get the vm data, password and ssh keys

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jayapalu/cloudstack configdriveScripts

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1379


commit 6c8b7c03aaf7091a7de50c20846b2aef8789ebcb
Author: Jayapal 
Date:   2016-01-28T11:21:13Z

CLOUDSTACK-8324: config drive data set/get scripts for the guest vm




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Config Drive

2016-01-28 Thread Jayapal Reddy Uradi

Hi Eric,

Please find the scripts in the below pull request.
https://github.com/apache/cloudstack/pull/1379

Thanks,
Jayapal

On 28-Jan-2016, at 3:38 pm, Eric Waegeman 
mailto:eric.waege...@nuagenetworks.net>> wrote:

Hi all,

we would like to port "Config drive" on KVM feature to a previous version
of Cloudstack for one of our customers. We got most of it working but have
a problem in udev not putting the config drive ISO in /dev/disk/by-label
path because it considers it to be a removable drive.

And we would like to have a look at the userdata/password scripts mentioned
in the design document
 but
don't know where to find them.

Any help is appreciated,
Eric.

Re: Config Drive

2016-01-28 Thread Nux!

Hi Eric,

That's great news!
If udev is misbehaving, you could use blkid to get the device name instead, 
e.g.:
blkid -t LABEL="config" -o device

What OS are you seeing these problems on?

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Eric Waegeman" 
> To: dev@cloudstack.apache.org
> Sent: Thursday, 28 January, 2016 10:08:41
> Subject: Config Drive

> Hi all,
> 
> we would like to port "Config drive" on KVM feature to a previous version
> of Cloudstack for one of our customers. We got most of it working but have
> a problem in udev not putting the config drive ISO in /dev/disk/by-label
> path because it considers it to be a removable drive.
> 
> And we would like to have a look at the userdata/password scripts mentioned
> in the design document
>  
> but
> don't know where to find them.
> 
> Any help is appreciated,
> Eric.

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1378#issuecomment-176144240
  
Says a license is missing, but this only touches one existing file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

Github user DaanHoogland closed the pull request at:

https://github.com/apache/cloudstack/pull/1351


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

GitHub user DaanHoogland reopened a pull request:

https://github.com/apache/cloudstack/pull/1351

Vmdk findbugs

these are two of the findbugs errors coming out of our jenkins all the 
time. The author seems to be unavailable so I kicked and screamed at it.
notice that this is noredist code. I did the compile without it. there is 
one with running.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1351


commit 18ba5bbf6d95e9056b981c05f88d1b914bf49cb5
Author: Daan Hoogland 
Date:   2016-01-19T15:55:05Z

findbugs: pre-fix reformat

commit b106f574a4828c7f45cc5711e13909fe1e6d3340
Author: Daan Hoogland 
Date:   2016-01-19T15:56:20Z

findbugs: use explicit encoding




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1378#issuecomment-176147131
  
Yes, nothing to do with your code but it is genuine. You can add the 
license to ActionEventUtilsTest to make the build pass. The license is there in 
higher branches.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: user-authenticators/saml2: Remove unused ...

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1380

user-authenticators/saml2: Remove unused dependency

Removes Spring security saml extension as it is not needed or used by the
SAML plugin.

cc @DaanHoogland

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.7-saml-removedep

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1380


commit 94607be4e433d393ab16baf350368791780e
Author: Rohit Yadav 
Date:   2016-01-28T12:06:08Z

user-authenticators/saml2: Remove unused dependency

Removes Spring security saml extension as it is not needed or used by the
SAML plugin.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3095

See 

--
[...truncated 28675 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.900s]
[INFO] Apache CloudStack . SUCCESS [2.330s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.823s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.556s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:31.644s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.137s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.824s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.994s]
[INFO] Apache CloudStack API . SUCCESS [1:50.177s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.034s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.857s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.137s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.548s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.913s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.043s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.842s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.651s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.331s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.339s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.800s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [26.364s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.404s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [38.140s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.479s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:24.380s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.101s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.583s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.980s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.804s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.582s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.945s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.929s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.231s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.314s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.504s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.831s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.122s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.860s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.870s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.573s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.402s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.308s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.686s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.289s]
[INFO] Apache Cloud

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

2016-01-28 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1342


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7+] user-authenticators/saml2: Remove ...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1380#issuecomment-176157606
  
looks good but needs testing, right? might be a runtime issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1378#issuecomment-176159834
  
I added the license header.

Out of curiosity, I ran the `org.apache.rat:apache-rat-plugin:0.10:check` 
locally on my PR branch and it reported 59 failures rather than the 1 failure 
here. Any ideas?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8324: config drive data set/ge...

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1379#discussion_r51116786
  
--- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in ---
@@ -0,0 +1,107 @@
+#!/bin/bash
+#
+# Init file for SSH Public Keys Download Client
+#
+# chkconfig: 345 98 02
+# description: SSH Public Keys Download Client
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# Modify this line to specify the user (default is root)
+user=root
+
+mountdir=/mnt/configdrive
+
--- End diff --

Why a static directory? The danger exists that it is already there.

Why not use mktemp?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8324: config drive data set/ge...

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1379#discussion_r51116750
  
--- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in ---
@@ -0,0 +1,107 @@
+#!/bin/bash
+#
+# Init file for SSH Public Keys Download Client
+#
+# chkconfig: 345 98 02
+# description: SSH Public Keys Download Client
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+# Modify this line to specify the user (default is root)
+user=root
+
+mountdir=/mnt/configdrive
+
+# If lable name is other than config, please change the below line as 
required
+DefaultDisk=/dev/disk/by-label/config
+
+SSHKey_File=$mountdir/cloudstack/metadata/public_keys.txt
+keys_received=0
+
+function prepare_mount
+{
+if [ ! -e $mountdir ]; then
+mkdir $mountdir
+chmod 700 $mountdir
+fi
+
+if [ -e $DefaultDisk ]; then
+Disk=$DefaultDisk
+else
+BLOCK_DEVICE=$(blkid -t LABEL='config' /dev/hd? /dev/sd? /dev/xvd? 
-o device)
--- End diff --

Shouldn't this also look at /dev/vdX devices? VirtIO devices under KVM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Bharat Kumar

Hi All,

I agree that we need to have a CI to deal with the large volume of PRs. The
current travis CI is not good enough as it runs only simulator tests.
We identified this issue and came up with a effective CI for automating test
runs for a each PR. This is already functional, with few github integration
aspects pending. We are internally stabilizing it before sharing it.

We have been in touch with David Nalley ( CC’ed ) in making this operational
for entire community using ACS infra.

For your reference, here is the FS I have shared with the community earlier and
also in this thread before, your feedback is welcome.
(https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration).

Thanks,
Bharat.

On 28-Jan-2016, at 4:26 PM, Rohit Yadav
mailto:rohit.ya...@shapeblue.com>> wrote:

All,

I’m sorry to get to have the PRs merged without adhering to the strict testing
requirements. While I think PRs were alright and it did not break anything, the
way it was merged made people uncomfortable that there is some sort of haste in
doing this fast which there is none.

I’ll not repeat this and hope you understand that I never had any hidden agenda
but to simply help people with some PRs.

Regards.

On 28-Jan-2016, at 11:36 AM, Sebastien Goasguen
mailto:run...@gmail.com>> wrote:

Hi Folks,

My proposal to freeze until we get CI was indeed due to seeing Rohit’s commit
but was by no means a personal attack or judgment.

We have lots of PR pending (as mentioned before by Remi) and we need people to
help review and test.
So thanks to Rohit.

My only concerns were two fold:

1- We need to keep to adhere to our release principles:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up

Hence I replied to some PR asking if they needed to be merged directly in
master or not and wondered about the release branches.

With so many releases in flight it is not yet clear to me where we start to
apply a PR ?

2- We need to keep testing and post results of tests.

Currently it is manual and but there has been a strong guarantee in the last
releases that the PR where not going to break things.
While I agree that some PR are small and *should* not break things, history has
shown that even small unrelated things *somehow* can affect the behavior of
cloudstack.

So I proposed a freeze because:

- Remi stepped down as RM and we don’t have an official RM yet.
- The code has reached a solid state and we don’t want to do anything that
changes that
- We have a proposal for LTS on the floor
- We still don’t have CI.

So my standpoint is that we focused in the last 6 months on getting our release
principles right (pending LTS principles), code has stabilized and we can
release. Awesome.

Now is probably a good time to concentrate our limited resources on figuring
out automated CI.

- For instance as far as I know Travis is bonkers…(reports green but does not
do anything)
- And with citrix stepping out, we need to take control of the jenkins slaves
(some of which are on AWS and still paid by Citrix…)

My email while triggered by seeing Rohit’s commits, was not a judgement or
critic of his actions, so let’s not get into a personal argument here.

-Sebastien

On Jan 28, 2016, at 11:00 AM, Rohit Yadav wrote:

So, since some have directly (over IM etc) or indirectly have thrown
allegations on me since I merged most of the PRs.
Here is a list of those 12 PRs and answers on why they were merged on
case-by-case basis.
Please keep any further replies technical and to the specific PR, please point
out and revert if needed:

1. https://github.com/apache/cloudstack/pull/1288

Enough LGTMs, JS related change and fix tested with UI screenshot from Remi. I
personally looked at the diff and therefore then merged.

2. https://github.com/apache/cloudstack/pull/1274/files

Enough LGTMs, a simple NPE fix one-liner. I personally thought we can cheat
here and given Travis/Jenkins passed I merged it.

3. https://github.com/apache/cloudstack/pull/1261/files

Enough LGTMs, the diff only removed unused variable leading to change in the
constructor definition. Explicit integration tests are not necessary as it’d
simply dead-code removal and as the simulator smoke tests passed with
Travis/Jenkins passed so I merged it.

4. https://github.com/apache/cloudstack/pull/1048

Enough LGTMs. This change is related to a marvin test itself where it adds 2
new test methods — so no need to run regression integration test. The
integration test result of the marvin test was shared in the comment. PR merged
on this basis.

5. https://github.com/apache/cloudstack/pull/1044

Enough LGTMs and regression tests results (shared as attachments by Daan, in
case someone missed), so merged.

6. https://github.com/apache/cloudstack/pull/969

Enough LGTMs and regression tests results (shared as attachments by Daan, in
case someone missed)

[GitHub] cloudstack pull request: [4.7+] user-authenticators/saml2: Remove ...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1380#issuecomment-176170704
  
@DaanHoogland sure. There are no imports (git grep 
org.springframework.security to check) from any part of the codebase and since 
I had put it in I know for sure it's not at least used by the SAML plugin 
(which only uses OpenSAML lib). I can help run manual runtime tests since that 
requires a IdP server next week or later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

silence findbugs

2016-01-28 Thread Daan Hoogland

https://github.com/apache/cloudstack/pull/1351 is still open for the last
two issues  to silence findbugs. please all have a look.

-- 
Daan

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1378#issuecomment-176181871
  
have a look in target/rat.txt and see what those are. maybe some remanence 
of your prior work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1351#issuecomment-176191880
  
Seems good to me looking at it. Don't know how to test it properly, but 
code-wise the changes look sane to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1378#issuecomment-176194553
  
I added the license check to ActionEventUtilsTest and of course now the 
checks pass. But may it is a better idea to put the license in as a separate 
PR? Not exactly related to this commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Vmdk findbugs

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1351#issuecomment-176195149
  
LGTM, did not test it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1378#issuecomment-176197509
  
It looks like it was some old Debian package build causing a bunch of 
extraneous files to be placed into the rat report. Cleaned up those and the 
report is now much more in line with what the Jenkins job is reporting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [PROPOSAL] Freeze everything until we get CI

Hi Kumar,

That’s great. I've been working along similar lines, I'd love to collaborate 
with you on this.

Are you able to share an estimated timescale with us? And are you thinking of 
sharing the code and construction details of how to build the environment(s) 
for the community and users to build or are you looking to deploy the CI 
capability on ASF infra for the community to consume?



Paul Angus
VP Technology   ,   ShapeBlue


t:  @cloudyangus

e:  paul.an...@shapeblue.com|  
w:  www.shapeblue.com





-Original Message-
From: Bharat Kumar [mailto:bharat.ku...@citrix.com]
Sent: 28 January 2016 21:50
To:  
Cc: David Nalley 
Subject: Re: [PROPOSAL] Freeze everything until we get CI

Hi All,

I agree that we need to have a CI to deal with the large volume of PRs. The 
current travis CI is not good enough as it runs only simulator tests.
We identified this issue and came up with a effective CI for automating test 
runs for a each PR. This is already functional, with few github integration 
aspects pending. We are internally stabilizing it before sharing it.

We have been in touch with David Nalley ( CC’ed ) in making this operational 
for entire community using ACS infra.


For your reference, here is the FS I have shared with the community earlier and 
also in this thread before, your feedback is welcome.
(https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration).

Thanks,
Bharat.




On 28-Jan-2016, at 4:26 PM, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>> wrote:

All,

I’m sorry to get to have the PRs merged without adhering to the strict testing 
requirements. While I think PRs were alright and it did not break anything, the 
way it was merged made people uncomfortable that there is some sort of haste in 
doing this fast which there is none.

I’ll not repeat this and hope you understand that I never had any hidden agenda 
but to simply help people with some PRs.

Regards.

On 28-Jan-2016, at 11:36 AM, Sebastien Goasguen 
mailto:run...@gmail.com>> wrote:

Hi Folks,

My proposal to freeze until we get CI was indeed due to seeing Rohit’s commit 
but was by no means a personal attack or judgment.

We have lots of PR pending (as mentioned before by Remi) and we need people to 
help review and test.
So thanks to Rohit.

My only concerns were two fold:

1- We need to keep to adhere to our release principles:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up

Hence I replied to some PR asking if they needed to be merged directly in 
master or not and wondered about the release branches.

With so many releases in flight it is not yet clear to me where we start to 
apply a PR ?

2- We need to keep testing and post results of tests.

Currently it is manual and but there has been a strong guarantee in the last 
releases that the PR where not going to break things.
While I agree that some PR are small and *should* not break things, history has 
shown that even small unrelated things *somehow* can affect the behavior of 
cloudstack.

So I proposed a freeze because:

- Remi stepped down as RM and we don’t have an official RM yet.
- The code has reached a solid state and we don’t want to do anything that 
changes that
- We have a proposal for LTS on the floor
- We still don’t have CI.

So my standpoint is that we focused in the last 6 months on getting our release 
principles right (pending LTS principles), code has stabilized and we can 
release. Awesome.

Now is probably a good time to concentrate our limited resources on figuring 
out automated CI.

- For instance as far as I know Travis is bonkers…(reports green but does not 
do anything)
- And with citrix stepping out, we need to take control of the jenkins slaves 
(some of which are on AWS and still paid by Citrix…)

My email while triggered by seeing Rohit’s commits, was not a judgement or 
critic of his actions, so let’s not get into a personal argument here.

-Sebastien

On Jan 28, 2016, at 11:00 AM, Rohit Yadav  wrote:

So, since some have directly (over IM etc) or indirectly have thrown 
allegations on me since I merged most of the PRs.
Here is a list of those 12 PRs and answers on why they were merged on 
case-by-case basis.
Please keep any further replies technical and to the specific PR, please point 
out and revert if needed:

1. https://github.com/apache/cloudstack/pull/1288

Enough LGTMs, JS related change and fix tested with UI screenshot from Remi. I 
personally looked at the diff and therefore then merged.

2. https://github.com/apache/cloudstack/pull/1274/files

Enough LGTMs, a simple NPE fix one-liner. I personally thought we can cheat 
here and given Travis/Jenkins passed I merged it.

3. https://github.com/apache/cloudstack/pull/1261/files

Enough LGTMs, the diff only removed unused variable leading to change in the 
const

Re: [PROPOSAL] Freeze everything until we get CI

Why not share it as is, then the community could help improving this,
rather than this being a single company effort?

-- 
Erik

On Thu, Jan 28, 2016 at 1:49 PM, Bharat Kumar 
wrote:

> Hi All,
>
> I agree that we need to have a CI to deal with the large volume of PRs.
> The current travis CI is not good enough as it runs only simulator tests.
> We identified this issue and came up with a effective CI for automating
> test runs for a each PR. This is already functional, with few github
> integration aspects pending. We are internally stabilizing it before
> sharing it.
>
> We have been in touch with David Nalley ( CC’ed )  in making this
> operational for entire community using ACS infra.
>
>
> For your reference, here is the FS I have shared with the community
> earlier and also in this thread before, your feedback is welcome.
> (
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration
> ).
>
> Thanks,
> Bharat.
>
>
>
>
> On 28-Jan-2016, at 4:26 PM, Rohit Yadav  rohit.ya...@shapeblue.com>> wrote:
>
> All,
>
> I’m sorry to get to have the PRs merged without adhering to the strict
> testing requirements. While I think PRs were alright and it did not break
> anything, the way it was merged made people uncomfortable that there is
> some sort of haste in doing this fast which there is none.
>
> I’ll not repeat this and hope you understand that I never had any hidden
> agenda but to simply help people with some PRs.
>
> Regards.
>
> On 28-Jan-2016, at 11:36 AM, Sebastien Goasguen  run...@gmail.com>> wrote:
>
> Hi Folks,
>
> My proposal to freeze until we get CI was indeed due to seeing Rohit’s
> commit but was by no means a personal attack or judgment.
>
> We have lots of PR pending (as mentioned before by Remi) and we need
> people to help review and test.
> So thanks to Rohit.
>
> My only concerns were two fold:
>
> 1- We need  to keep to adhere to our release principles:
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up
>
> Hence I replied to some PR asking if they needed to be merged directly in
> master or not and wondered about the release branches.
>
> With so many releases in flight it is not yet clear to me where we start
> to apply a PR ?
>
> 2- We need to keep testing and post results of tests.
>
> Currently it is manual and but there has been a strong guarantee in the
> last releases that the PR where not going to break things.
> While I agree that some PR are small and *should* not break things,
> history has shown that even small unrelated things *somehow* can affect the
> behavior of cloudstack.
>
> So I proposed a freeze because:
>
> - Remi stepped down as RM and we don’t have an official RM yet.
> - The code has reached a solid state and we don’t want to do anything that
> changes that
> - We have a proposal for LTS on the floor
> - We still don’t have CI.
>
> So my standpoint is that we focused in the last 6 months on getting our
> release principles right (pending LTS principles), code has stabilized and
> we can release. Awesome.
>
> Now is probably a good time to concentrate our limited resources on
> figuring out automated CI.
>
> - For instance as far as I know Travis is bonkers…(reports green but does
> not do anything)
> - And with citrix stepping out, we need to take control of the jenkins
> slaves (some of which are on AWS and still paid by Citrix…)
>
> My email while triggered by seeing Rohit’s commits, was not a judgement or
> critic of his actions, so let’s not get into a personal argument here.
>
> -Sebastien
>
> On Jan 28, 2016, at 11:00 AM, Rohit Yadav 
> wrote:
>
> So, since some have directly (over IM etc) or indirectly have thrown
> allegations on me since I merged most of the PRs.
> Here is a list of those 12 PRs and answers on why they were merged on
> case-by-case basis.
> Please keep any further replies technical and to the specific PR, please
> point out and revert if needed:
>
> 1. https://github.com/apache/cloudstack/pull/1288
>
> Enough LGTMs, JS related change and fix tested with UI screenshot from
> Remi. I personally looked at the diff and therefore then merged.
>
> 2. https://github.com/apache/cloudstack/pull/1274/files
>
> Enough LGTMs, a simple NPE fix one-liner. I personally thought we can
> cheat here and given Travis/Jenkins passed I merged it.
>
> 3. https://github.com/apache/cloudstack/pull/1261/files
>
> Enough LGTMs, the diff only removed unused variable leading to change in
> the constructor definition. Explicit integration tests are not necessary as
> it’d simply dead-code removal and as the simulator smoke tests passed with
> Travis/Jenkins passed so I merged it.
>
> 4. https://github.com/apache/cloudstack/pull/1048
>
> Enough LGTMs. This change is related to a marvin test itself where it adds
> 2 new test methods — so no need to run regression integration test. The
> integration test result of the marvin test was shared i

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1373#issuecomment-176200921
  
Added the license header to the MockUsageEventDao class to fix rat report 
error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Emit event UUIDs on template deletion

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1378#issuecomment-176204562
  
After some discussion on IRC, going to remove the addition of the license 
header here and fix it in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1373#issuecomment-176205293
  
Hi @ProjectMoon ,
Out of curiosity, why did you create the 
"server/test/com/cloud/user/MockUsageEventDao.java" class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

GitHub user ProjectMoon opened a pull request:

https://github.com/apache/cloudstack/pull/1381

Add missing license header to ActionEventUtilsTest.

The test class was merged without the license header. This commit fixes 
that problem.

Also note that the license header exists on the master branch only as a 
result of commit 8a5fc16f. The commit seems to be on the master branch and the 
4.7 branch only. So there may be some conflicts when forward merging.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack pr-fix-license-header

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1381


commit 5de8cb179218be97842993d38365c3902a160328
Author: jeff 
Date:   2016-01-28T14:23:10Z

Add missing license header to ActionEventUtilsTest.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1381#issuecomment-176207310
  
My god I swear GitHub's PR interface can die in a fire. Wrong base branch 
again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

Github user ProjectMoon closed the pull request at:

https://github.com/apache/cloudstack/pull/1381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

GitHub user ProjectMoon opened a pull request:

https://github.com/apache/cloudstack/pull/1382

Add missing license header to ActionEventUtilsTest.

The test class was merged without the license header. This commit fixes 
that problem.

Also note that the license header exists on the master branch only as a 
result of commit 8a5fc16. The commit seems to be on the master branch and the 
4.7 branch only. So there may be some conflicts when forward merging.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack pr-fix-license-header

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1382


commit 5de8cb179218be97842993d38365c3902a160328
Author: jeff 
Date:   2016-01-28T14:23:10Z

Add missing license header to ActionEventUtilsTest.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1373#issuecomment-176208728
  
I'm not the original author of this work, but I think it was just because a 
class for testing was needed. Looking at it now I'm not really sure why it 
can't just be the regular `UsageEventDao` with `@Mock`. I will try to find out 
the intention behind it, and then remove the class if it's not needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3096

See 

Changes:

[w.zhou] CLOUDSTACK-6181: Add 'root disk size' field in instance wizard for KVM

--
[...truncated 28675 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.892s]
[INFO] Apache CloudStack . SUCCESS [2.220s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.997s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.846s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.992s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.102s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.253s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.544s]
[INFO] Apache CloudStack API . SUCCESS [1:51.285s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.819s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.873s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.096s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.458s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.651s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.279s]
[INFO] Apache CloudStack Agents .. SUCCESS [37.272s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.380s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.063s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.421s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.987s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.081s]
[INFO] Apache CloudStack Server .. SUCCESS [4:13.550s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.403s]
[INFO] Apache CloudStack Usage Server  SUCCESS [45.003s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.152s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.069s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.510s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.364s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.822s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.165s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.251s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [32.519s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.199s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.361s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.539s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.286s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.943s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.577s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.728s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.609s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [18.173s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.932s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [17.197s]
[INF

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1373#issuecomment-176263770
  
@rafaelweingartner I have removed the MockUsageEventDao and replaced it 
with a normal Mockito mock of the UsageEventDao interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1373#discussion_r51146580
  
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -205,6 +223,11 @@
 @Mock
 private UserAuthenticator userAuthenticator;
 
+//Maintain a list of old fields in the usage utils class... This
--- End diff --

If this comment is important, would you mind using a java doc style?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1373#discussion_r51146522
  
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -192,6 +205,11 @@
 @Mock
 VMSnapshotDao _vmSnapshotDao;
 
+//Mocked in the setupUsageUtils method.
--- End diff --

I do not think you need this kind of comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixes regarding VOLUME_DELETE events resu...

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1373#issuecomment-176270996
  
@ProjectMoon  that is great, 
Your code is ok,
I would just suggest you extracting the code from "AccountManagerImpl" 
lines 769-778 to a method. Then you would be able to add proper java 
documentation and test cases.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1332#issuecomment-176289614
  
Added unit tests 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1332#discussion_r51153892
  
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, 
String path) {
 command.execute(parser);
 return true;
 }
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
+
+Map tempKeyMap = new HashMap<>();
+tempKeyMap.put("Temp-URL-Key", tempKey);
+return postMeta(cfg, "", "", tempKeyMap);
+
+}
+
+public static URL generateTempUrl(SwiftClientCfg cfg, String 
container, String object, String tempKey, int urlExpirationInterval) {
+
+int currentTime = (int) (System.currentTimeMillis() / 1000L);
+int expirationSeconds = currentTime + urlExpirationInterval;
+
+try {
+
+URL endpoint = new URL(cfg.getEndPoint());
+String method = "GET";
+String path = String.format("/v1/AUTH_%s/%s/%s", 
cfg.getAccount(), container, object);
+
+//sign the request
+String hmacBody = String.format("%s\n%d\n%s", method, 
expirationSeconds, path);
+String signature = calculateRFC2104HMAC(hmacBody, tempKey);
+path += String.format("?temp_url_sig=%s&temp_url_expires=%d", 
signature, expirationSeconds);
+
+//generate the temp url
+URL tempUrl = new URL(endpoint.getProtocol(), 
endpoint.getHost(), endpoint.getPort(), path);
+
+return tempUrl;
+
+} catch (Exception e) {
+logger.error(e.getMessage());
+throw new CloudRuntimeException(e.getMessage());
+}
+
+}
+
+
+private static String calculateRFC2104HMAC(String data, String key)
+throws SignatureException, NoSuchAlgorithmException, 
InvalidKeyException {
+
+SecretKeySpec signingKey = new SecretKeySpec(key.getBytes(), 
HMAC_SHA1_ALGORITHM);
+Mac mac = Mac.getInstance(HMAC_SHA1_ALGORITHM);
+mac.init(signingKey);
+return toHexString(mac.doFinal(data.getBytes()));
+
+}
+
+private static String toHexString(byte[] bytes) {
--- End diff --

done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1332#discussion_r51153916
  
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, 
String path) {
 command.execute(parser);
 return true;
 }
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
+
+Map tempKeyMap = new HashMap<>();
+tempKeyMap.put("Temp-URL-Key", tempKey);
+return postMeta(cfg, "", "", tempKeyMap);
+
+}
+
+public static URL generateTempUrl(SwiftClientCfg cfg, String 
container, String object, String tempKey, int urlExpirationInterval) {
--- End diff --

done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1332#discussion_r51153907
  
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, 
String path) {
 command.execute(parser);
 return true;
 }
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
+
+Map tempKeyMap = new HashMap<>();
+tempKeyMap.put("Temp-URL-Key", tempKey);
+return postMeta(cfg, "", "", tempKeyMap);
+
+}
+
+public static URL generateTempUrl(SwiftClientCfg cfg, String 
container, String object, String tempKey, int urlExpirationInterval) {
+
+int currentTime = (int) (System.currentTimeMillis() / 1000L);
+int expirationSeconds = currentTime + urlExpirationInterval;
+
+try {
+
+URL endpoint = new URL(cfg.getEndPoint());
+String method = "GET";
+String path = String.format("/v1/AUTH_%s/%s/%s", 
cfg.getAccount(), container, object);
+
+//sign the request
+String hmacBody = String.format("%s\n%d\n%s", method, 
expirationSeconds, path);
+String signature = calculateRFC2104HMAC(hmacBody, tempKey);
+path += String.format("?temp_url_sig=%s&temp_url_expires=%d", 
signature, expirationSeconds);
+
+//generate the temp url
+URL tempUrl = new URL(endpoint.getProtocol(), 
endpoint.getHost(), endpoint.getPort(), path);
+
+return tempUrl;
+
+} catch (Exception e) {
+logger.error(e.getMessage());
+throw new CloudRuntimeException(e.getMessage());
+}
+
+}
+
+
+private static String calculateRFC2104HMAC(String data, String key)
--- End diff --

done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1332#discussion_r51154027
  
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, 
String path) {
 command.execute(parser);
 return true;
 }
+
+public static boolean setTempKey(SwiftClientCfg cfg, String tempKey){
--- End diff --

I don't think I can write a unit test for this as it relies on an external 
script to work to give the correct output. I could mock the output but that 
would defeat the purpose of the unit test. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7+] user-authenticators/saml2: Remove ...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1380#issuecomment-176291448
  
@DaanHoogland upgraded my local 4.7.0 cloudstack to 4.7.1 without the 
spring-saml ext dependency and logged in as a SAML user. Log:

2016-01-28 18:16:32,085 DEBUG [o.a.c.s.SAML2AuthManagerImpl] (Timer-5:null) 
(logid:) Starting SAML IDP Metadata Refresh Task
2016-01-28 18:16:32,085 DEBUG [o.a.c.s.SAML2AuthManagerImpl] (Timer-5:null) 
(logid:) Adding IdP to the list of discovered IdPs: 
https://idp.scaleninja.com/idp/shibboleth
2016-01-28 18:16:32,088 DEBUG [o.a.c.s.SAML2AuthManagerImpl] (Timer-5:null) 
(logid:) Finished refreshing SAML Metadata and expiring old auth tokens
2016-01-28 18:22:41,287 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Module Hierarchy: saml2
2016-01-28 18:22:56,876 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Loading module context [saml2] from URL 
[jar:file:/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-plugin-user-authenticator-saml2-4.7.1.jar!/META-INF/cloudstack/saml2/spring-saml2-context.xml]
2016-01-28 18:22:56,876 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Loading module context [saml2] from URL 
[jar:file:/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-core-4.7.1.jar!/META-INF/cloudstack/api/spring-core-lifecycle-api-context-inheritable.xml]
2016-01-28 18:22:56,876 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Loading module context [saml2] from URL 
[jar:file:/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-core-4.7.1.jar!/META-INF/cloudstack/core/spring-core-lifecycle-core-context-inheritable.xml]
2016-01-28 18:22:56,876 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Loading module context [saml2] from URL 
[jar:file:/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-core-4.7.1.jar!/META-INF/cloudstack/system/spring-core-system-context-inheritable.xml]
2016-01-28 18:22:56,877 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Loading module context [saml2] from URL 
[jar:file:/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-framework-config-4.7.1.jar!/META-INF/cloudstack/system/spring-framework-config-system-context-inheritable.xml]
2016-01-28 18:22:56,877 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Loading module context [saml2] from URL 
[jar:file:/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-plugin-network-contrail-4.7.1.jar!/META-INF/cloudstack/system/spring-contrail-system-context-inheritable.xml]
2016-01-28 18:22:56,877 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Loading module context [saml2] from URL 
[jar:file:/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-core-4.7.1.jar!/META-INF/cloudstack/bootstrap/spring-bootstrap-context-inheritable.xml]
2016-01-28 18:22:56,991 DEBUG [o.a.c.f.c.i.ConfigDepotImpl] (main:null) 
(logid:) Retrieving keys from SAML2AuthManagerImpl
2016-01-28 18:22:57,012 DEBUG [o.a.c.s.l.r.ExtensionRegistry] (main:null) 
(logid:) Registering extension [SAML2] in [User Authenticators Registry]
2016-01-28 18:22:57,012 DEBUG [o.a.c.s.l.r.RegistryLifecycle] (main:null) 
(logid:) Registered org.apache.cloudstack.saml.SAML2UserAuthenticator@573410b6
2016-01-28 18:22:57,014 DEBUG [o.a.c.s.l.r.ExtensionRegistry] (main:null) 
(logid:) Registering extension [SAML2Auth] in [Pluggable A P I Authenticators 
Registry]
2016-01-28 18:22:57,014 DEBUG [o.a.c.s.l.r.RegistryLifecycle] (main:null) 
(logid:) Registered org.apache.cloudstack.saml.SAML2AuthManagerImpl@3a678371
2016-01-28 18:22:57,014 DEBUG [o.a.c.s.l.r.ExtensionRegistry] (main:null) 
(logid:) Registering extension [SAML2] in [User Password Encoders Registry]
2016-01-28 18:22:57,014 DEBUG [o.a.c.s.l.r.RegistryLifecycle] (main:null) 
(logid:) Registered org.apache.cloudstack.saml.SAML2UserAuthenticator@573410b6
2016-01-28 18:22:57,014 DEBUG [o.a.c.s.l.r.ExtensionRegistry] (main:null) 
(logid:) Registering extension [SAML2Auth] in [Api Commands Registry]
2016-01-28 18:22:57,014 DEBUG [o.a.c.s.l.r.RegistryLifecycle] (main:null) 
(logid:) Registered org.apache.cloudstack.saml.SAML2AuthManagerImpl@3a678371
2016-01-28 18:22:57,017 INFO  [o.a.c.s.m.m.i.DefaultModuleDefinitionSet] 
(main:null) (logid:) Loaded module context [saml2] in 141 ms
2016-01-28 18:23:02,673 DEBUG [c.c.a.ApiServer] (main:null) (logid:) 
Discovered plugin SAML2AuthManagerImpl
2016-01-28 18:23:02,712 INFO  [o.a.c.s.l.r.DumpRegistry] (main:null) 
(logid:) Registry [User Authenticators Registry] contains [PBKDF2, SHA256SALT, 
MD5, LDAP, SAML2]
2016-01-28 18:23:02,713 INFO  [o.a.c.s.l.r.DumpRegistry] (main:null) 
(logid:) Registry [Pluggable A P I Authenticators Registry] contains [SA

Build failed in Jenkins: build-master-slowbuild #3097

See 

--
[...truncated 28675 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.725s]
[INFO] Apache CloudStack . SUCCESS [2.114s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.780s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.972s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:31.732s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.107s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [55.114s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.470s]
[INFO] Apache CloudStack API . SUCCESS [1:48.408s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.771s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.519s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.115s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.225s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.627s]
[INFO] Apache CloudStack Core  SUCCESS [1:20.768s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.519s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.912s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.394s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:06.598s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.742s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [26.406s]
[INFO] Apache CloudStack Server .. SUCCESS [4:16.662s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.768s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.691s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:23.294s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.086s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.519s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.921s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.171s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.658s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.320s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [26.150s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.307s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.461s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.518s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.526s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.959s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.258s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.602s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.717s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.327s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.860s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.887s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.904s]
[INFO] Apache Cloud

[GitHub] cloudstack pull request: Add missing license header to ActionEvent...

2016-01-28 Thread GabrielBrascher

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1382#issuecomment-176321558
  
LGTM based on the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

2016-01-28 Thread nvazquez

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1310#issuecomment-176351414
  
Hi @bhaisaab ,

Which test files would you like me to run? Is this ok with this command on 
each file?
nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/...file.py
Or is it a command to run multiple files?

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3098

See 

--
[...truncated 28675 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.723s]
[INFO] Apache CloudStack . SUCCESS [2.112s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.794s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.408s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.904s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.108s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.882s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.296s]
[INFO] Apache CloudStack API . SUCCESS [1:51.702s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.641s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.440s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.083s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.685s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.491s]
[INFO] Apache CloudStack Core  SUCCESS [1:20.833s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.360s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [37.644s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.146s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.579s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.383s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.529s]
[INFO] Apache CloudStack Server .. SUCCESS [4:10.816s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.918s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.679s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.289s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.068s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.471s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.800s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.592s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.892s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.043s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.672s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.983s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [34.760s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.257s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.023s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.011s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.632s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.504s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.309s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.568s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.422s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.149s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.629s]
[INFO] Apache Cloud

Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Pinnock Jr., Clifford R

Hi.
Here are logs
dstk-svc&domain=na.domain.com","_role":"Image"}},"name":"routing-9","hypervisorType":"Hyperv"}},"destTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"origUrl":"https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
 Template 
(HyperV)","imageDataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"b40338b6-f5c8-351a-8d28-2a0e7b9433b8","id":4,"poolType":"SMB","host":"pa-winfilesvr","path":"/HVPrimary1","port":445,"url":"SMB://pa-winfilesvr/HVPrimary1/?ROLE=Primary&STOREUUID=b40338b6-f5c8-351a-8d28-2a0e7b9433b8"}},"name":"routing-9","hypervisorType":"Hyperv"}},"executeInSequence":false,"options":{},"wait":10800}}]
 }
2016-01-28 14:28:36,009 DEBUG [c.c.a.m.DirectAgentAttache] 
(DirectAgent-13:ctx-ad8f51b8) (logid:774b885f) Seq 5-2841208414917361734: 
Executing request
2016-01-28 14:28:36,017 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-13:ctx-ad8f51b8) (logid:d1d35783) POST request to 
https://10.102.0.91:8250/api/HypervResource/org.apache.cloudstack.storage.command.CopyCommand
 with contents 
{"srcTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"path":"template/tmpl/1/9/","origUrl":"https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
 Template 
(HyperV)","imageDataStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"cifs://pa-winfilesvr.na.domain.com/HVSecondary1","_role":"Image"}},"name":"routing-9","hypervisorType":"Hyperv"}},"destTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"origUrl":"https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
 Template 
(HyperV)","imageDataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"b40338b6-f5c8-351a-8d28-2a0e7b9433b8","id":4,"poolType":"SMB","host":"pa-winfilesvr","path":"/HVPrimary1","port":445,"url":"SMB://pa-winfilesvr/HVPrimary1/?ROLE=Primary&STOREUUID=b40338b6-f5c8-351a-8d28-2a0e7b9433b8"}},"name":"routing-9","hypervisorType":"Hyperv"}},"executeInSequence":false,"options":{},"contextMap":{"job":"job-22/job-5552","logid":"d1d35783"},"wait":10800}
2016-01-28 14:28:36,022 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-13:ctx-ad8f51b8) (logid:d1d35783) Sending cmd to 
https://10.102.0.91:8250/api/HypervResource/org.apache.cloudstack.storage.command.CopyCommand
 cmd 
data:{"srcTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"path":"template/tmpl/1/9/","origUrl":"https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
 Template 
(HyperV)","imageDataStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"cifs://pa-winfilesvr.na.domain.com/HVSecondary1","_role":"Image"}},"name":"routing-9","hypervisorType":"Hyperv"}},"destTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"origUrl":"https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
 Template 
(HyperV)","imageDataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"b40338b6-f5c8-351a-8d28-2a0e7b9433b8","id":4,"poolType":"SMB","host":"pa-winfilesvr","path":"/HVPrimary1","port":445,"url":"SMB://pa-winfilesvr/HVPrimary1/?ROLE=Primary&STOREUUID=b40338b6-f5c8-351a-8d28-2a0e7b9433b8"}},"name":"routing-9","hypervisorType":"Hyperv"}},"executeInSequence":false,"options":{},"contextMap":{"job":"job-22/job-5552","logid":"d1d35783"},"wait":10800}
2016-01-28 14:28:36,110 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-13:ctx-ad8f51b8) (logid:d1d35783) POST response is 
[{"org.apache.cloudstack.storage.command.CopyCmdAnswer":{"result":false,"details":"org.apache.cloudstack.storage.command.CopyCommand
 failed on exception, Could not find a part of the path 
'\\pa-winfilesvr.na.domain.com\HVSecondary1\template\tmpl\1\9'.","newData":null,"contextMap":{}}}]
2016-01-28 14:28:36,112 DEBUG [c.c.h.h.r.HypervDirectConnectResource] 
(DirectAgent-13:ctx-ad8f51b8) (logid:d1d35783) executeRequest received response 
[{"org.apache.cloudstack.s

Re: Citrix CloudPltform Question-Hyper-V

On Thu, Jan 28, 2016 at 11:41 PM, Pinnock Jr., Clifford R <
clifford.pinnoc...@ca.com> wrote:

> Hi.
>
> Here are logs
>
> dstk-svc&domain=na.domain.com 
> ","_role":"Image"}},"name":"routing-9","hypervisorType":"Hyperv"}},"destTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"origUrl":"
> https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
> Template
> (HyperV)","imageDataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"b40338b6-f5c8-351a-8d28-2a0e7b9433b8","id":4,"poolType":"SMB","host":"pa-winfilesvr","path":"/HVPrimary1","port":445,"url":"SMB://pa-winfilesvr/HVPrimary1/?ROLE=Primary&STOREUUID=b40338b6-f5c8-351a-8d28-2a0e7b9433b8"}},"name":"routing-9","hypervisorType":"Hyperv"}},"executeInSequence":false,"options":{},"wait":10800}}]
> }
>
> 2016-01-28 14:28:36,009 DEBUG [c.c.a.m.DirectAgentAttache]
> (DirectAgent-13:ctx-ad8f51b8) (logid:774b885f) Seq 5-2841208414917361734:
> Executing request
>
> 2016-01-28 14:28:36,017 DEBUG [c.c.h.h.r.HypervDirectConnectResource]
> (DirectAgent-13:ctx-ad8f51b8) (logid:d1d35783) POST request to
> https://10.102.0.91:8250/api/HypervResource/org.apache.cloudstack.storage.command.CopyCommand
> with contents
> {"srcTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"path":"template/tmpl/1/9/","origUrl":"
> https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
> Template
> (HyperV)","imageDataStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"cifs://
> pa-winfilesvr.na.domain.com/HVSecondary1
> 
> ","_role":"Image"}},"name":"routing-9","hypervisorType":"Hyperv"}},"destTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"origUrl":"
> https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
> Template
> (HyperV)","imageDataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"b40338b6-f5c8-351a-8d28-2a0e7b9433b8","id":4,"poolType":"SMB","host":"pa-winfilesvr","path":"/HVPrimary1","port":445,"url":"SMB://pa-winfilesvr/HVPrimary1/?ROLE=Primary&STOREUUID=b40338b6-f5c8-351a-8d28-2a0e7b9433b8"}},"name":"routing-9","hypervisorType":"Hyperv"}},"executeInSequence":false,"options":{},"contextMap":{"job":"job-22/job-5552","logid":"d1d35783"},"wait":10800}
>
> 2016-01-28 14:28:36,022 DEBUG [c.c.h.h.r.HypervDirectConnectResource]
> (DirectAgent-13:ctx-ad8f51b8) (logid:d1d35783) Sending cmd to
> https://10.102.0.91:8250/api/HypervResource/org.apache.cloudstack.storage.command.CopyCommand
> cmd
> data:{"srcTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"path":"template/tmpl/1/9/","origUrl":"
> https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
> Template
> (HyperV)","imageDataStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"cifs://
> pa-winfilesvr.na.domain.com/HVSecondary1
> 
> ","_role":"Image"}},"name":"routing-9","hypervisorType":"Hyperv"}},"destTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"origUrl":"
> https://download.cloud.com/templates/4.5.1/systemvm64template-2015-05-14-4.5.1-hyperv.vhd.bz2","uuid":"8a54a66a-bafa-11e5-8210-005056aa1ca9","id":9,"format":"VHD","accountId":1,"checksum":"70ab1d60c578156561aa143443003f81","hvm":false,"displayText":"SystemVM
> Template
> (HyperV)","imageDataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"b40338b6-f5c8-351a-8d28-2a0e7b9433b8","id":4,"poolType":"SMB","host":"pa-winfilesvr","path":"/HVPrimary1","port":445,"url":"SMB://pa-winfilesvr/HVPrimary1/?ROLE=Primary&STOREUUID=b40338b6-f5c8-351a-8d28-2a0e7b9433b8"}},"name":"routing-9","hypervisorType":"Hyperv"}},"executeInSequence":false,"options":{},"contextMap":{"job":"job-22/job-5552","logid":"d1d35783"},"wait":10800}
>
> 2016-01-28 14:28:36,110 DEBUG [c.c.h.h.r.HypervDirectConnectResource]
> (DirectAgent-13:ctx-ad8f51b8) (logid:d1d35783) POST response is
> [{"org.apache.cloudstack.storage.command.CopyCmdAnswer":{"result":false,"details":"org.apache.cloudstack.storage.command.CopyCommand
> failed on exception, Could not find a part of the path '\\
> pa-winfilesvr.na.domain.com 
> \HVSecondary1\template\tmpl\1\9'.","newData":null,"contextM

Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Pinnock Jr., Clifford R

Hi.
I am with a Citrix partner and we are trying to deploy CloudPlatform integrated 
with Hyper-V, all is well except we get exceptionCould not find a part of the 
path /"secondary"tmpl/1/9 when creating the system vm's. The thing is how are 
we supposed to get the system vm template onto the secondary if it is SMB and 
we can't mount it onto management? Any thoughts on this issue would be 
appreciated.

Clifford Pinnock Jr.
Principal, Platform Engineer

CA Technologies | 160 Bridge St Hartfield Executive Pk | East Windsor, CT 
06088-9548
Mobile: +1 860 861 6744 | clifford.pinnoc...@ca.com

[CA][Twitter][Slideshare][Facebook][YouTube][LinkedIn][Google+][Google+]

Re: Citrix CloudPltform Question-Hyper-V

Is your management server running on linux or windows?

If it is on linux I guess you could CIFS mount it and use the regular
system vm install method from [1], but use the appropriate version.
If it is on windows I have no idea, never used cloudstack in combination
with windows/hyper-v before, someone else might have though.

-- 
Erik

On Thu, Jan 28, 2016 at 11:26 PM, Pinnock Jr., Clifford R <
clifford.pinnoc...@ca.com> wrote:

> Hi.
>
> I am with a Citrix partner and we are trying to deploy CloudPlatform
> integrated with Hyper-V, all is well except we get exceptionCould not find
> a part of the path /”secondary”tmpl/1/9 when creating the system vm’s. The
> thing is how are we supposed to get the system vm template onto the
> secondary if it is SMB and we can’t mount it onto management? Any thoughts
> on this issue would be appreciated.
>
>
>
> *Clifford Pinnock Jr.*
> Principal, Platform Engineer
>
> CA Technologies | 160 Bridge St Hartfield Executive Pk | East Windsor, CT
> 06088-9548
> Mobile: +1 860 861 6744 | clifford.pinnoc...@ca.com
>
> [image: CA] [image: Twitter]
> [image: Slideshare]
> [image: Facebook]
> [image: YouTube]
> [image: LinkedIn]
> [image:
> Google+] [image: Google+]
> 
>
>
>

Re: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Todd Pigram

Clifford,

I assume your running CCP 4.5.1, in the install guide did you follow section 
5.4.10 Prepare the SystemVM Template?

I am a Citrix partner as well, but I run CCP on XenServer. I will try and 
assist any way I can.





Todd Pigram
about.me/ToddPigram
 


www.linkedin.com/in/toddpigram/ 
@pigram86 on twitter
https://plus.google.com/+ToddPigram86 
Mobile - 216-224-5769

PGP Public Key 
> On Jan 28, 2016, at 5:26 PM, Pinnock Jr., Clifford R 
>  wrote:
> 
> Hi.
> I am with a Citrix partner and we are trying to deploy CloudPlatform 
> integrated with Hyper-V, all is well except we get exceptionCould not find a 
> part of the path /”secondary”tmpl/1/9 when creating the system vm’s. The 
> thing is how are we supposed to get the system vm template onto the secondary 
> if it is SMB and we can’t mount it onto management? Any thoughts on this 
> issue would be appreciated.
> 
> Clifford Pinnock Jr.
> Principal, Platform Engineer
> 
> CA Technologies | 160 Bridge St Hartfield Executive Pk | East Windsor, CT 
> 06088-9548
> Mobile: +1 860 861 6744 | clifford.pinnoc...@ca.com
> 
>    
>   
>  
>  
>  
>  
> 


signature.asc
Description: Message signed with OpenPGP using GPGMail

RE: Citrix CloudPltform Question-Hyper-V

Hi Clifford,

You need to install samba-client, samba-common and cifs-utils on your mgmt 
server to have CIFS support.

then you can mount your CIFS share with something like:

mount -t cifs /// -o 
uid=cloud,gid=cloud,username=,password='',domain= 

As a side note, these CloudStack mailing lists are really for Apache CloudStack 
users. You should really be speaking to your vendor if you're using a 
commercial distribution.

[ShapeBlue]
Paul Angus
VP Technology   ,   ShapeBlue

d:  +44 203 617 0528 | s: +44 203 603 
0540 |  
m:  +44 7711 418784

e:  paul.an...@shapeblue.com | t: 
@cloudyangus  |
  w:  www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK

[cid:image0bc1f7.png@48615786.488e91f4]

Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.

-Original Message-
From: Erik Weber [mailto:terbol...@gmail.com]
Sent: 29 January 2016 08:14
To: dev 
Subject: Re: Citrix CloudPltform Question-Hyper-V

Is your management server running on linux or windows?

If it is on linux I guess you could CIFS mount it and use the regular system vm 
install method from [1], but use the appropriate version.
If it is on windows I have no idea, never used cloudstack in combination with 
windows/hyper-v before, someone else might have though.

--
Erik

On Thu, Jan 28, 2016 at 11:26 PM, Pinnock Jr., Clifford R < 
clifford.pinnoc...@ca.com> wrote:

> Hi.
>
> I am with a Citrix partner and we are trying to deploy CloudPlatform
> integrated with Hyper-V, all is well except we get exceptionCould not
> find a part of the path /”secondary”tmpl/1/9 when creating the system
> vm’s. The thing is how are we supposed to get the system vm template
> onto the secondary if it is SMB and we can’t mount it onto management?
> Any thoughts on this issue would be appreciated.
>
>
>
> *Clifford Pinnock Jr.*
> Principal, Platform Engineer
>
> CA Technologies | 160 Bridge St Hartfield Executive Pk | East Windsor,
> CT
> 06088-9548
> Mobile: +1 860 861 6744 | clifford.pinnoc...@ca.com
>
> [image: CA] [image: Twitter]
> [image: Slideshare]
> [image: Facebook]
> [image: YouTube]
> [image: LinkedIn]
> [image:
> Google+] [image: Google+]
> 
>
>
>
Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design & Build | 
CSForge – rapid IaaS deployment framework
CloudStack Consulting | 
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support | CloudStack 
Bootcamp Training Courses

Re: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread ilya

I think most would agree -  we welcome anyone in this mailing list -
regardless of their affiliation :)

There is not anything special about CCP vs ACS.

Regards
ilya



On 1/28/16 3:22 PM, Paul Angus wrote:
> Hi Clifford,
> 
> You need to install samba-client, samba-common and cifs-utils on your
> mgmt server to have CIFS support.
> 
> then you can mount your CIFS share with something like:
> 
> mount -t cifs /// -o
> uid=cloud,gid=cloud,username=,password='',domain=
> 
> 
> 
> As a side note, these CloudStack mailing lists are really for Apache
> CloudStack users. You should really be speaking to your vendor if you're
> using a commercial distribution.
> 
> 
> 
> ShapeBlue   
> Paul Angus
> VP Technology ,   ShapeBlue
> 
> d:*+44 203 617 0528 | s: +44 203 603 0540*
>  | 
> m:*+44 7711 418784* 
> 
> e:*paul.an...@shapeblue.com | t: @cloudyangus*
>   |  w: 
> *www.shapeblue.com* 
> 
> a:53 Chandos Place, Covent Garden London WC2N 4HS UK
> 
> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
> Services India LLP is a company incorporated in India and is operated
> under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is
> a company incorporated in Brasil and is operated under license from
> Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The
> Republic of South Africa and is traded under license from Shape Blue
> Ltd. ShapeBlue is a registered trademark.
> This email and any attachments to it may be confidential and are
> intended solely for the use of the individual to whom it is addressed.
> Any views or opinions expressed are solely those of the author and do
> not necessarily represent those of Shape Blue Ltd or related companies.
> If you are not the intended recipient of this email, you must neither
> take any action based upon its contents, nor copy or show it to anyone.
> Please contact the sender if you believe you have received this email in
> error.
> 
> 
> -Original Message-
> From: Erik Weber [mailto:terbol...@gmail.com]
> Sent: 29 January 2016 08:14
> To: dev 
> Subject: Re: Citrix CloudPltform Question-Hyper-V
> 
> Is your management server running on linux or windows?
> 
> If it is on linux I guess you could CIFS mount it and use the regular
> system vm install method from [1], but use the appropriate version.
> If it is on windows I have no idea, never used cloudstack in combination
> with windows/hyper-v before, someone else might have though.
> 
> --
> Erik
> 
> On Thu, Jan 28, 2016 at 11:26 PM, Pinnock Jr., Clifford R <
> clifford.pinnoc...@ca.com> wrote:
> 
>> Hi.
>>
>> I am with a Citrix partner and we are trying to deploy CloudPlatform
>> integrated with Hyper-V, all is well except we get exceptionCould not
>> find a part of the path /”secondary”tmpl/1/9 when creating the system
>> vm’s. The thing is how are we supposed to get the system vm template
>> onto the secondary if it is SMB and we can’t mount it onto management?
>> Any thoughts on this issue would be appreciated.
>>
>>
>>
>> *Clifford Pinnock Jr.*
>> Principal, Platform Engineer
>>
>> CA Technologies | 160 Bridge St Hartfield Executive Pk | East Windsor,
>> CT
>> 06088-9548
>> Mobile: +1 860 861 6744 | clifford.pinnoc...@ca.com
>>
>> [image: CA] [image: Twitter]
>> [image: Slideshare]
>> [image: Facebook]
>> [image: YouTube]
>> [image: LinkedIn]
>> [image:
>> Google+] [image: Google+]
>> 
>>
>>
>>
> Find out more about ShapeBlue and our range of CloudStack related services:
> IaaS Cloud Design & Build
>  | CSForge – rapid
> IaaS deployment framework 
> CloudStack Consulting  |
> CloudStack Software Engineering
> 
> CloudStack Infrastructure Support
>  | CloudStack
> Bootcamp Training Courses

Build failed in Jenkins: build-master-slowbuild #3099

See 

--
[...truncated 28685 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.808s]
[INFO] Apache CloudStack . SUCCESS [2.197s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.799s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.685s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.076s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.115s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.495s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.830s]
[INFO] Apache CloudStack API . SUCCESS [1:56.317s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.284s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [31.258s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.085s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.436s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.834s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.407s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.327s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.707s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [15.502s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.038s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.673s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.702s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.783s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.084s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.785s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.263s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.068s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.429s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.203s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.044s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.082s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.091s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.796s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.572s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.105s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.139s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.310s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.020s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.385s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.237s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.862s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.571s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.687s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.711s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.621s]
[INFO] Apache Cloud

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disk co...

2016-01-28 Thread GabrielBrascher

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-176495485
  
@bhaisaab Could you please do the following changes?

At **VirtualMachineVolumeChainInfo** class:
**1 -** create Javadoc blocks (would be nice to document all the class, but 
I think that at least the class and the "getControllerFromDeviceBusName" method 
deserves a documentation);
**2 -** simplify the **if** conditional at line **43**. Test with "( 
(StringUtils.isEmpty) || (!this.diskDeviceBusName.contains(":")) )" condition. 
The StringUtils.isEmpty method already checks if the String is empty("") or 
null 
(https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html).
**3 -** create test for the getControllerFromDeviceBusName method.

At **UserVmManagerImpl** class:
**1 -** document the "persistDeviceBusInfo(UserVmVO vm, String 
rootDiskController)" method (lines **5458-5466**).
**2 -** use the "StringUtils.isEmpty()" with the condition at line 
**5460**, instead of "(existingVmRootDiskController==null) || 
(existingVmRootDiskController.isEmpty())".
**3 -** create test for "persistDeviceBusInfo(UserVmVO vm, String 
rootDiskController)" method.

**VolumeApiServiceImpl**:
**1 -** Remove â**_**â from variables names (lines **200**, **252**, 
**267**): private variables with â**_**â at the beginning is common in C++ 
but not in Java.

Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3100

See 

--
[...truncated 28675 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.872s]
[INFO] Apache CloudStack . SUCCESS [2.108s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.814s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.116s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:26.399s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.117s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.811s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.693s]
[INFO] Apache CloudStack API . SUCCESS [1:49.854s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.455s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.250s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.100s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.605s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.251s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.084s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.426s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.826s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [13.987s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.905s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.229s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.762s]
[INFO] Apache CloudStack Server .. SUCCESS [4:15.246s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.990s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.891s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.534s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.084s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.480s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.261s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.993s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.083s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.897s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.542s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [22.669s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.193s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.246s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [9.357s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.955s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.606s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.009s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[39.158s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.040s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.441s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.038s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.440s]
[INFO] Apache Cloud

Re: Citrix CloudPltform Question-Hyper-V

2016-01-28 Thread Anshul Gangwar

Hi Clifford,

Is this resolved or are you still waiting for response?

Regards,
Anshul

On 29-Jan-2016, at 3:56 AM, Pinnock Jr., Clifford R 
mailto:clifford.pinnoc...@ca.com>> wrote:

Hi.
I am with a Citrix partner and we are trying to deploy CloudPlatform integrated 
with Hyper-V, all is well except we get exceptionCould not find a part of the 
path /”secondary”tmpl/1/9 when creating the system vm’s. The thing is how are 
we supposed to get the system vm template onto the secondary if it is SMB and 
we can’t mount it onto management? Any thoughts on this issue would be 
appreciated.

Clifford Pinnock Jr.
Principal, Platform Engineer

CA Technologies | 160 Bridge St Hartfield Executive Pk | East Windsor, CT 
06088-9548
Mobile: +1 860 861 6744 | clifford.pinnoc...@ca.com

Build failed in Jenkins: build-master-slowbuild #3101

See 

--
[...truncated 28675 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.684s]
[INFO] Apache CloudStack . SUCCESS [2.664s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.884s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.376s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.729s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.105s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.612s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [28.507s]
[INFO] Apache CloudStack API . SUCCESS [1:50.317s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.469s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.303s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.090s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.993s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.659s]
[INFO] Apache CloudStack Core  SUCCESS [1:20.119s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.499s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.390s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.170s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:09.213s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.639s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.313s]
[INFO] Apache CloudStack Server .. SUCCESS [4:21.671s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.022s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.495s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.799s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.068s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.432s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.819s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.874s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.167s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.660s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [30.651s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.465s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.170s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.338s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.629s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.990s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.469s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.738s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.725s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.360s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.054s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.826s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.697s]
[INFO] Apache Cloud

Re: [PROPOSAL] Freeze everything until we get CI

2016-01-28 Thread Bharat Kumar

yes, we would be sharing it with the community and get this running in the ACS
infra.
Currently it can create a cloudstack test bed, runs tests and email the results.

Here are some details on how this works and what is needed to set this up.

* we use jenkins, cobbler, puppet and marvin to create cloudstack setup.
* jenkins triggers the test runs, collects the test results and mails them.
* cobbler is use to image the hosts and create Management server.
* The management server is a VM and each time a test run is triggered we
pull the latest code, build (dev setup) the MS and run it.
* Need IPMI enabled servers to uses and Hosts in cloudstack setup. Cobbler
installs the required OS on these hosts.
* We use a XenServer to create management server VMs.

The resources required to set this up.

* We need two servers to host the VMs used in CI, one XenServer to host the
Cloustack management servers and at least 3 IPMI enabled servers per cloudstack
setup to run the BVTs.
* some set of IPs (public and private IPs) and vlans.

Once we have the resources in ACS infra we can start setting this up. But some
work needs to
be done to integrate this with the github to test and post the results in the
PRs instead of mailing them.

I think the best way to share it will be by implementing this in the ACS infra.
Once we do this every one can pitch in, replicate and further contribute to
this.

Meanwhile i will commit the scripts to set this up and keep this going.

Thanks,
Bharat.

On 28-Jan-2016, at 7:37 PM, Erik Weber
mailto:terbol...@gmail.com>> wrote:

Why not share it as is, then the community could help improving this,
rather than this being a single company effort?

--
Erik

On Thu, Jan 28, 2016 at 1:49 PM, Bharat Kumar
mailto:bharat.ku...@citrix.com>>
wrote:

Hi All,

I agree that we need to have a CI to deal with the large volume of PRs.
The current travis CI is not good enough as it runs only simulator tests.
We identified this issue and came up with a effective CI for automating
test runs for a each PR. This is already functional, with few github
integration aspects pending. We are internally stabilizing it before
sharing it.

We have been in touch with David Nalley ( CC’ed ) in making this
operational for entire community using ACS infra.

For your reference, here is the FS I have shared with the community
earlier and also in this thread before, your feedback is welcome.
(
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration
).

Thanks,
Bharat.

On 28-Jan-2016, at 4:26 PM, Rohit Yadav > wrote:

All,

I’m sorry to get to have the PRs merged without adhering to the strict
testing requirements. While I think PRs were alright and it did not break
anything, the way it was merged made people uncomfortable that there is
some sort of haste in doing this fast which there is none.

I’ll not repeat this and hope you understand that I never had any hidden
agenda but to simply help people with some PRs.

Regards.

On 28-Jan-2016, at 11:36 AM, Sebastien Goasguen > wrote:

Hi Folks,

My proposal to freeze until we get CI was indeed due to seeing Rohit’s
commit but was by no means a personal attack or judgment.

We have lots of PR pending (as mentioned before by Remi) and we need
people to help review and test.
So thanks to Rohit.

My only concerns were two fold:

1- We need to keep to adhere to our release principles:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up

Hence I replied to some PR asking if they needed to be merged directly in
master or not and wondered about the release branches.

With so many releases in flight it is not yet clear to me where we start
to apply a PR ?

2- We need to keep testing and post results of tests.

Currently it is manual and but there has been a strong guarantee in the
last releases that the PR where not going to break things.
While I agree that some PR are small and *should* not break things,
history has shown that even small unrelated things *somehow* can affect the
behavior of cloudstack.

So I proposed a freeze because:

So my standpoint is that we focused in the last 6 months on getting our
release principles right (pending LTS principles), code has stabilized and
we can release. Awesome.

Now is probably a good time to concentrate our limited resources on
figuring out automated CI.

- For instance as far as I know Travis is bonkers…(reports green but does
not do anything)
- And with citrix stepping out, we need to take control of the jenkins
slaves (some of which are on AWS and still paid by Citrix…)

My email while triggered by seeing Rohit’s commits, was not a judgement or
critic of hi

Re: [PROPOSAL] Freeze everything until we get CI

I'd love to see this in the cloudstack repository.
Others might have an easier time getting access to hardware, and could use
it to help test releases/PR


Erik

Den fredag 29. januar 2016 skrev Bharat Kumar 
følgende:

> yes, we would be sharing it with the community and get this running in the
> ACS infra.
> Currently it can create a cloudstack test bed, runs tests and email the
> results.
>
> Here are some details on how this works and what is needed to set this up.
>
>   *   we use jenkins, cobbler, puppet and marvin to create cloudstack
> setup.
>   *   jenkins triggers the test runs, collects the test results and mails
> them.
>   *   cobbler is use to image the hosts and create Management server.
>   *   The management server is a VM and each time a test run is triggered
> we pull the latest code, build (dev setup) the MS and run it.
>   *   Need IPMI enabled servers to uses and Hosts in cloudstack setup.
> Cobbler installs the required OS on these hosts.
>   *   We use a XenServer to create management server VMs.
>
> The resources required to set this up.
>
>   *   We need two servers to host the VMs used in CI, one XenServer to
> host the Cloustack management servers and at least 3 IPMI enabled servers
> per cloudstack setup to run the BVTs.
>   *   some set of IPs (public and private IPs) and vlans.
>
> Once we have the resources in ACS infra we can start setting this up. But
> some work needs to
> be done to integrate this with the github to test and post the results in
> the PRs instead of mailing them.
>
> I think the best way to share it will be by implementing this in the ACS
> infra. Once we do this every one can pitch in, replicate and further
> contribute to this.
>
> Meanwhile i will commit the scripts to set this up and keep this going.
>
> Thanks,
> Bharat.
>
>
> On 28-Jan-2016, at 7:37 PM, Erik Weber 
> > wrote:
>
> Why not share it as is, then the community could help improving this,
> rather than this being a single company effort?
>
> --
> Erik
>
> On Thu, Jan 28, 2016 at 1:49 PM, Bharat Kumar  >
> wrote:
>
> Hi All,
>
> I agree that we need to have a CI to deal with the large volume of PRs.
> The current travis CI is not good enough as it runs only simulator tests.
> We identified this issue and came up with a effective CI for automating
> test runs for a each PR. This is already functional, with few github
> integration aspects pending. We are internally stabilizing it before
> sharing it.
>
> We have been in touch with David Nalley ( CC’ed )  in making this
> operational for entire community using ACS infra.
>
>
> For your reference, here is the FS I have shared with the community
> earlier and also in this thread before, your feedback is welcome.
> (
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration
> ).
>
> Thanks,
> Bharat.
>
>
>
>
> On 28-Jan-2016, at 4:26 PM, Rohit Yadav   rohit.ya...@shapeblue.com >> wrote:
>
> All,
>
> I’m sorry to get to have the PRs merged without adhering to the strict
> testing requirements. While I think PRs were alright and it did not break
> anything, the way it was merged made people uncomfortable that there is
> some sort of haste in doing this fast which there is none.
>
> I’ll not repeat this and hope you understand that I never had any hidden
> agenda but to simply help people with some PRs.
>
> Regards.
>
> On 28-Jan-2016, at 11:36 AM, Sebastien Goasguen   run...@gmail.com >> wrote:
>
> Hi Folks,
>
> My proposal to freeze until we get CI was indeed due to seeing Rohit’s
> commit but was by no means a personal attack or judgment.
>
> We have lots of PR pending (as mentioned before by Remi) and we need
> people to help review and test.
> So thanks to Rohit.
>
> My only concerns were two fold:
>
> 1- We need  to keep to adhere to our release principles:
>
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up
>
> Hence I replied to some PR asking if they needed to be merged directly in
> master or not and wondered about the release branches.
>
> With so many releases in flight it is not yet clear to me where we start
> to apply a PR ?
>
> 2- We need to keep testing and post results of tests.
>
> Currently it is manual and but there has been a strong guarantee in the
> last releases that the PR where not going to break things.
> While I agree that some PR are small and *should* not break things,
> history has shown that even small unrelated things *somehow* can affect the
> behavior of cloudstack.
>
> So I proposed a freeze because:
>
> - Remi stepped down as RM and we don’t have an official RM yet.
> - The code has reached a solid state and we don’t want to do anything that
> changes that
> - We have a proposal for LTS on the floor
> - We still don’t have CI.
>
> So my standpoint is that we focused in the last 6 months on getting our
> release principl

[GitHub] cloudstack pull request: Add ability to download templates in Swif...