Re: Introducing Vishwas

2017-02-28 Thread Sanjeev N
Welcome Vishwas !!

On Tue, Feb 28, 2017 at 4:57 AM, Tutkowski, Mike <mike.tutkow...@netapp.com>
wrote:

> Welcome to the CloudStack Community! :)
>
> > On Feb 24, 2017, at 9:30 AM, Nathan Johnson <njohn...@ena.com> wrote:
> >
> > Vishwas Pathak <vishwas_pat...@accelerite.com> wrote:
> >
> >> Hello CloudStack team,
> >>
> >> My name is Vishwas Pathak and I am working with Accelerite CloudPlatform
> >> testing team. Earlier I have worked in storage systems, cloud computing,
> >> virtualization and telecom messaging domains. Excited to be part of this
> >> community and happy to contribute.
> >
> > Welcome Vishwas!
> >
> >
> > Nathan Johnson
> > R Engineer
> > Education Networks of America
>



-- 
Best Regards,
Sanjeev N
Chief Product Engineer@Accelerite


Re: Important Pending Items

2016-03-01 Thread Sanjeev N
Hi Steve,

Currently travis runs all simulator tests(marvin tests which does not
require any hardware, tagged with requierd_hardware=false) on every PR. If
any test fails it updates the PR and marks it red. IMO apart from 2 LGTMs
travis test pass is also mandatory for PR merge.

Thanks,
Sanjeev N
Chief Product Engineer@Accelerite

On Wed, Mar 2, 2016 at 3:13 AM, Will Stevens <wstev...@cloudops.com> wrote:

> Awesome, thanks Remi.  I will review this.
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Tue, Mar 1, 2016 at 4:29 PM, Remi Bergsma <rberg...@schubergphilis.com>
> wrote:
>
> > Hi Will,
> >
> > We used this to test hundreds of PRs:
> > https://github.com/schubergphilis/MCT-shared/. I can talk you through it
> > sometime next week or so if you want.
> >
> > Regards,
> > Remi
> >
> >
> > On 01/03/16 21:50, "williamstev...@gmail.com on behalf of Will Stevens"
> <
> > williamstev...@gmail.com on behalf of wstev...@cloudops.com> wrote:
> >
> > >Thanks Paul.  Great to hear you are planning to make everything
> available
> > >and you are willing to take contributions from the community.
> > >
> > >I am currently trying to get up to speed on everything that has been
> done
> > >and all the different pieces in play.  I would like to have a CI in
> place
> > >(even if it is only locally on my hardware) for testing PRs for 4.9.  My
> > >focus right now is solving the CI problem, so I am interested in any
> > >developments on this front.
> > >
> > >We have Travis doing smoke tests on every PR right now.  Travis is free
> > for
> > >open source projects.  Is there a reason we are not doing more extensive
> > >tests with Travis since it is already integrated into github?  Like
> maybe
> > >running the simulator on every PR?  I think this could be a good first
> > step
> > >to weed out some of the PRs that are likely to fail a full CI run.
> > >
> > >Cheers,
> > >
> > >*Will STEVENS*
> > >Lead Developer
> > >
> > >*CloudOps* *| *Cloud Solutions Experts
> > >420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > >w cloudops.com *|* tw @CloudOps_
> > >
> > >On Tue, Mar 1, 2016 at 3:40 PM, Paul Angus <paul.an...@shapeblue.com>
> > wrote:
> > >
> > >> Hi Will,
> > >>
> > >> It will be 100% open source. The $dayjob has blocked the team from
> > working
> > >> on it recently. I'd like to get some of our ideas into the CloudStack
> > wiki
> > >> this week before I go on leave for a week.
> > >> Rohit has created a repo for us:
> https://github.com/shapeblue/Trillian
> > >> (which looks a bit sad at the moment - I hope to push our Ansible
> roles
> > >> for building mgmt. servers and Marvin boxes into it this week also)
> > >>
> > >> Internally we're planning a two week sprint on it starting 14th March.
> > >> Having to dip in and out of this effort is making it very difficult to
> > get
> > >> anywhere
> > >>
> > >> I think the biggest part of the work will be to get Marvin up to
> > scratch,
> > >> the log output from the tests is pretty bad.
> > >>
> > >> We very much want this to be a community 'thing', and we're happy to
> > work
> > >> with everyone/anyone to get there.
> > >>
> > >> Any ideas on the most effective way to have a number of people on
> this -
> > >> I'm all ears.
> > >> In the meantime I'll try to make good on my promises to get our ideas
> > >> visible to everyone...
> > >>
> > >>
> > >>
> > >>
> > >> Paul Angus
> > >> VP Technology   ,   ShapeBlue
> > >>
> > >>
> > >> t:  @cloudyangus<tel:@cloudyangus>
> > >>
> > >> e:  paul.an...@shapeblue.com<mailto:paul.an...@shapeblue.com>
> > >> |  w:  www.shapeblue.com<http://www.shapeblue.com>
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> -Original Message-
> > >> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > >> Behalf Of Will Stevens
> > >> Sent: Monday, February 29, 2016 9:52 PM
> > >> To: dev@clou

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9066: Update testpath to delet...

2016-02-25 Thread Sanjeev N
Test Results:
snapshot hardning ... === TestName: test_01_snapshot_hardning_kvm | Status
: : SUCCESS ===
ok

--
Ran 1 test in 1477.688s

OK

LGTM!!

On Wed, Feb 17, 2016 at 3:02 PM, pritisarap12  wrote:

> Github user pritisarap12 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1078#issuecomment-185115973
>
> Testcase result:
>
> snapshot hardning ... === TestName: test_01_snapshot_hardning_kvm |
> Status : SUCCESS ===
> ok
> snapshot hardning ... === SKIP: Skip test for server other than
> XenServer
>
> --
> Ran 2 tests in 1259.500s
>
> OK (SKIP=1)
>
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: CLOUDSTACK-9140: Testcase to verify if De...

2016-02-23 Thread Sanjeev N
LGTM !!

On Wed, Feb 17, 2016 at 12:46 PM, pritisarap12  wrote:

> Github user pritisarap12 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1218#issuecomment-185067571
>
> Testcase result after modifications:
>
> Dedicated cluster and router allocation ... === TestName:
> test_01_dedicated_cluster_allocation | Status : SUCCESS ===
> ok
>
> --
> Ran 1 test in 278.037s
>
> OK
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: VM state = Expunging

2016-02-22 Thread Sanjeev N
Expunging is the final state of the vm. We don't have expunged state.

On Mon, Feb 22, 2016 at 12:51 PM, Daan Hoogland 
wrote:

> I ran into that as well, a while ago. IMNSHO the VM record should be
> deleted after the state expunging, so a state of expunged would never make
> sense. Deabatable of course.
>
> On Mon, Feb 22, 2016 at 7:03 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
> > Hi,
> >
> > Is anyone able to confirm that when you delete and expunge a VM in 4.9
> that
> > the state finishes with "Expunging" instead of "Expunged".
> >
> > I don't think it really "harms" much as the removed column is populated
> > (so, for example, the GUI doesn't show these VMs), but it does seem a bit
> > odd (and front-ends that are waiting for the "Expunged" state to show up
> > won't see it).
> >
> > Thanks,
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
> >
>
>
>
> --
> Daan
>


Re: template available on http://dl.openvm.eu/cloudstack/macchinina/x86_64/

2016-02-18 Thread Sanjeev N
Hi Nux,

Can you please convert this template to .ova format , so that tests can run
on vmware.

http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-vmware.vmdk.bz2

Thanks,
Sanjeev

On Mon, Jan 4, 2016 at 5:42 PM, Raja Pullela 
wrote:

> Nux, I will provide you the files and if you can upload them that will be
> great.  Hope that is possible,
>
> Raja
>
> -Original Message-
> From: Nux! [mailto:n...@li.nux.ro]
> Sent: Saturday, January 2, 2016 4:08 PM
> To: dev@cloudstack.apache.org
> Subject: Re: template available on
> http://dl.openvm.eu/cloudstack/macchinina/x86_64/
>
> Raja,
>
> Do you have access to the sysvm tmpl generation? What commands are used to
> create OVA format?
> If you use the uncompressed RAW file, does that help you? It's already
> there http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina.img
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
> - Original Message -
> > From: "Raja Pullela" 
> > To: dev@cloudstack.apache.org
> > Sent: Saturday, 2 January, 2016 05:33:41
> > Subject: RE: template available on
> > http://dl.openvm.eu/cloudstack/macchinina/x86_64/
>
> > Nux, you are right... it is working for the system but not for the test
> suite.
> > I am going to create a bug to track it.
> > However, it will be great if you could post a BZ2 templates for HyperV
> > and for VMWare a OVA format - that will help!
> >
> > Thanks,
> > Raja
> >
> > -Original Message-
> > From: Nux! [mailto:n...@li.nux.ro]
> > Sent: Friday, January 1, 2016 5:36 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: template available on
> > http://dl.openvm.eu/cloudstack/macchinina/x86_64/
> >
> > Raja,
> >
> > This is confusing me. I am looking here and the VHD is ZIP:
> > http://jenkins.buildacloud.org/view/master/job/build-systemvm64-master
> > /
> >
> > I don't mind bz2-ing the VHD, but it's not clear what ACS/HyperV expects.
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
> >
> > - Original Message -
> >> From: "Raja Pullela" 
> >> To: dev@cloudstack.apache.org
> >> Sent: Friday, 1 January, 2016 11:12:12
> >> Subject: RE: template available on
> >> http://dl.openvm.eu/cloudstack/macchinina/x86_64/
> >
> >> Hi Nux,
> >>
> >> these templates available are not working...
> >> I see the following System Templates available for -
> >> - VMWare is in OVA format
> >> - HyperV is in VZD with BZ2 format
> >> - Xen is in VHD with BZ2 compression
> >> - KVM is in qCow2 with BZ2 compression
> >>
> >> If you can give me access to this VM/webserver, I can upload the files.
> >> Having the correct files will help pass few additional tests on my
> setups.
> >> Can you please let me know,
> >>
> >> Raja
> >>
> >> -Original Message-
> >> From: Nux! [mailto:n...@li.nux.ro]
> >> Sent: Tuesday, December 22, 2015 2:19 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: Re: template available on
> >> http://dl.openvm.eu/cloudstack/macchinina/x86_64/
> >>
> >> BTW, Cloudstack ships systemvm templates for HyperV also in ZIP,
> >> that's the reason I also pack it like that.
> >> AFAIK Windows can't deal with any other compression.
> >>
> >> --
> >> Sent from the Delta quadrant using Borg technology!
> >>
> >> Nux!
> >> www.nux.ro
> >>
> >> - Original Message -
> >>> From: "Nux!" 
> >>> To: dev@cloudstack.apache.org
> >>> Sent: Tuesday, 22 December, 2015 08:44:50
> >>> Subject: Re: template available on
> >>> http://dl.openvm.eu/cloudstack/macchinina/x86_64/
> >>
> >>> Hi,
> >>>
> >>> I do not know what you are running there, but:
> >>>
> >>> unzip macchinina-hyperv.vhd.zip
> >>> Archive:  macchinina-hyperv.vhd.zip
> >>>  inflating: macchinina-hyperv.vhd
> >>>
> >>>
> >>> qemu-img info macchinina-hyperv.vhd
> >>> image: macchinina-hyperv.vhd
> >>> file format: vpc
> >>> virtual size: 50M (52432896 bytes)
> >>> disk size: 50M
> >>> cluster_size: 2097152
> >>>
> >>>
> >>> Also, VHD is completely untested, let me know if it boots for you.
> >>> :)
> >>>
> >>> --
> >>> Sent from the Delta quadrant using Borg technology!
> >>>
> >>> Nux!
> >>> www.nux.ro
> >>>
> >>> - Original Message -
>  From: "Raja Pullela" 
>  To: dev@cloudstack.apache.org
>  Sent: Tuesday, 22 December, 2015 04:45:29
>  Subject: RE: template available on
>  http://dl.openvm.eu/cloudstack/macchinina/x86_64/
> >>>
>  Hello Nux,
> 
>  Three test scripts are failing with the error messages as below -
>  File "/root/cloudstack/test/integration/smoke/test_internal_lb.py",
>  line 285, in  setUpClass
> cls.template.download(cls.apiclient)
>   File "/usr/local/lib/python2.7/dist-packages/marvin/lib/base.py",
>  line 1261, in  download
> template.status)
>  'Error in downloading template: status - Failed post download script:
>  Unable to 

Re: [GitHub] cloudstack pull request: Squashing two commits in to single commit

2016-02-15 Thread Sanjeev N
LGTM based on PR#667

On Mon, Feb 15, 2016 at 5:37 PM, DaanHoogland  wrote:

> Github user DaanHoogland commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1411#issuecomment-184182132
>
> @sanjeevneelarapu If you LGTM this there are 2 LGTM here so please go
> ahead and merge.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: CLOUDSTACK-9012 :automation of cores feat...

2016-02-09 Thread Sanjeev N
LGTM !!

test1_coreos_VM_creation
(integration.component.test_coreos.TestDeployVmWithCoreosTemplate) ... ===
TestName: test1_coreos_VM_creation | Status : SUCCESS ===
ok

--
Ran 1 test in 754.205s

OK

On Thu, Feb 4, 2016 at 4:29 PM, shwetaag  wrote:

> Github user shwetaag commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/1011#discussion_r51857877
>
> --- Diff: test/integration/component/test_coreos.py ---
> @@ -0,0 +1,291 @@
> +# Licensed to the Apache Software Foundation (ASF) under one
> +# or more contributor license agreements.  See the NOTICE file
> +# distributed with this work for additional information
> +# regarding copyright ownership.  The ASF licenses this file
> +# to you under the Apache License, Version 2.0 (the
> +# "License"); you may not use this file except in compliance
> +# with the License.  You may obtain a copy of the License at
> +#
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing,
> +# software distributed under the License is distributed on an
> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +# KIND, either express or implied.  See the License for the
> +# specific language governing permissions and limitations
> +# under the License.
> +
> +""" P1 tests for coreos template and vm
> +"""
> +
> +from marvin.lib.base import (
> +VirtualMachine,
> +ServiceOffering,
> +Account,
> +SSHKeyPair,
> +Host, Template)
> +from marvin.lib.common import (
> +get_zone,
> +get_template,
> +list_routers)
> +from marvin.lib.utils import (
> +cleanup_resources,
> +get_hypervisor_type,
> +get_process_status)
> +from marvin.cloudstackTestCase import cloudstackTestCase
> +# Import System modules
> +import tempfile
> +import time
> +import os
> +import base64
> +from nose.plugins.attrib import attr
> +from marvin.sshClient import SshClient
> +
> +
> +class TestDeployVmWithCoreosTemplate(cloudstackTestCase):
> +"""Tests for deploying VM  using coreos template
> +"""
> +
> +@classmethod
> +def setUpClass(cls):
> +cls._cleanup = []
> +cls.testClient = super(
> +TestDeployVmWithCoreosTemplate,
> +cls).getClsTestClient()
> +cls.api_client = cls.testClient.getApiClient()
> +cls.services = cls.testClient.getParsedTestDataConfig()
> +cls.zone = get_zone(cls.api_client,
> cls.testClient.getZoneForTests())
> +cls.service_offering = ServiceOffering.create(
> +cls.api_client,
> services=cls.services["service_offerings"]["medium"])
> +cls.account = Account.create(
> +cls.api_client, services=cls.services["account"])
> +cls.cleanup = [cls.account]
> +cls.template = get_template(
> +cls.api_client,
> +cls.zone.id,
> +cls.services["ostype"]
> +)
> +cls.services["coreos"][
> +"hypervisor"] = cls.testClient.getHypervisorInfo()
> +cls.userdata = '#cloud-config\n\ncoreos:\n  units:\n-
> name: docker.service\n  command: start\n' \
> +   '- name: web.service\n  command: start\n
> content: |\n[Unit]\n' \
> +   'After=docker.service\n
> Requires=docker.service\nDescription=Starts web server ' \
> +   'container\n[Service]\n
> TimeoutStartSec=0\n' \
> +   'ExecStartPre=/usr/bin/docker pull
> httpd:2.4\n' \
> +   'ExecStart=/usr/bin/docker run -d -p 8000:80
> httpd:2.4'
> +cls.services["virtual_machine"]["userdata"] = cls.userdata
> +
> +cls.keypair = SSHKeyPair.create(
> +cls.api_client,
> +name="coreos",
> +account=cls.account.name,
> +domainid=cls.account.domainid
> +)
> +cls.debug("Created a new keypair with name: %s" %
> cls.keypair.name)
> +
> +cls.debug("Writing the private key to local file")
> +cls.keyPairFilePath = tempfile.gettempdir() + os.sep +
> cls.keypair.name
> +# Clenaup at end of execution
> +cls.cleanup.append(cls.keyPairFilePath)
> +
> +cls.debug("File path: %s" % cls.keyPairFilePath)
> +
> +f = open(cls.keyPairFilePath, "w+")
> +f.write(cls.keypair.privatekey)
> +f.close()
> +os.system("chmod 400 " + cls.keyPairFilePath)
> +

Re: Advice needed - switching IP for SS

2016-02-03 Thread Sanjeev N
Hi Daniel,

It is possible to have the MAC-IP pair in the switch arp cache. You can use
arping from your new NFS server to send gratious arp request, so that the
switch can update the MAC address in its arp cache.

Thanks,
Sanjeev

On Thu, Feb 4, 2016 at 1:47 PM, Daniel Mezentsev  wrote:

>  Igor,
>
> I have question. Doing such IP migration is it possible that arp cache on
> the switch (assuming that we have layer 3 switch) can have old server pair
> MAC<--->IP.
>
>
> Andrija, as for me the best solution:
>>
>> 1. shutdown data interfaces (or bond) on switch for new server after
>>
> rsync
>
>> 2. Configure same IP as for old server
>> 3. via switch CLI shutdown data ports for old server
>> 4. via switch CLI startup ports for new server
>> 4. Reconfigure IP for data bond old server via mgm interface to new IP
>> 5. via switch CLI startup data ports for old server on switch
>>
>> All this can be done via ansible. Downtime will be only between steps 3
>> and
>> 4. And it's will be around 0,1-0,5 seconds.
>>
>> From cloudstack mgmt sever it's will be transparent. Possible 1-2 TCP
>> retransit will happen.
>>
>> 2016-02-03 22:49 GMT+02:00 Andrija Panic :
>>
>> Hi guys,
>>>
>>> I need to do manitance of 1 Seconary Storage NFS server fro few days,
>>> so I
>>> though to temporarily rsync data to another NFS box, and switch IP
>>> addresses, so the new NFS box has the original IP for few days...(need
>>>
>> to
>
>> test if KVm nodes will gracefullt remount the NFS server during the IP
>>> switchover...)
>>>
>>> Is this the prefered way, or should I hack the DB to point existing NFS
>>> server (that is defined in ACS) to the new IP of the second NFS box, and
>>> perhaps restart mgmt and agents across all nodes.
>>>
>>> Any recomendations ?
>>>
>>> Best,
>>>
>>> Andrija Panić
>>>
>>
>>
>>
>  Daniel Mezentsev, founder
> (+1) 604 313 8592.
> Soleks Data Group.
> Shaping the clouds.
>


Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

2016-01-19 Thread Sanjeev N
Congrats Boris !!

On Wed, Jan 20, 2016 at 12:10 AM, ilya  wrote:

> Warm welcome Boris..
>
> On 1/19/16 4:15 AM, Wilder Rodrigues wrote:
> > The Project Management Committee (PMC) for Apache CloudStack is pleased
> to
> > announce that Boris Roman Schrijver has accepted our invitation to join
> the PMC.
> >
> > Please join me in congratulating him.
> >
> > On behalf of the Apache CloudStack PMC
> > Wilder Rodrigues
> >
>


Re: [GitHub] cloudstack pull request: [CLOUDSTACK-9215]Test to verify vm deploy...

2016-01-08 Thread Sanjeev N
Will add some validations

On Fri, Jan 8, 2016 at 7:51 PM, DaanHoogland  wrote:

> Github user DaanHoogland commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1316#issuecomment-170016433
>
> test succeeds as is :
> ```
> [root@daans-dev-machinina ~]# ssh cs1 nosetests --with-marvin
> --marvin-config=/data/shared/marvin/mct-zone1-kvm1-kvm2.cfg  -s -a
> tags=advanced,required_hardware=true
> /data/git/cs1/cloudstack/test/integration/component/maint/test_vpc.py
> root@cs1's password:
>
>  Marvin Init Started 
>
> === Marvin Parse Config Successful ===
>
> === Marvin Setting TestData Successful===
>
>  Log Folder Path: /tmp//MarvinLogs//Jan_08_2016_14_17_12_EBMCRT.
> All logs will be available here 
>
> === Marvin Init Logging Successful===
>
>  Marvin Init Successful 
> ===final results are now copied to: /tmp//MarvinLogs/test_vpc_1F4ULR===
> ```
>
> LGTM but seems less useful due to my remark on line 354
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

2016-01-05 Thread Sanjeev N
This PR is related to changes in base.py So ran one test which invokes the
changes to make sure the changes works fine.

Check Snapshots size in database ... === TestName:
test_02_snapshot_size_check | Status : SUCCESS ===
ok

--
Ran 1 tests in 385.302s

OK

On Mon, Dec 28, 2015 at 6:08 PM, sanju1010  wrote:

> Github user sanju1010 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1041#issuecomment-167562620
>
> I will post test results. LGTM !!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: Test to create vpn customer gateway with ...

2016-01-05 Thread Sanjeev N
Makes sense. I will add code to list vpn customer gateways and will check
if the response contains the customer gateway or not.

On Tue, Jan 5, 2016 at 3:55 PM, DaanHoogland  wrote:

> Github user DaanHoogland commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/1308#discussion_r48831039
>
> --- Diff: test/integration/component/test_vpc.py ---
> @@ -2490,3 +2498,23 @@ def test_21_deploy_vm_with_gateway_ip(self):
>  "Failed to create VM with first ip address in the CIDR as
> the vm ip"
>  )
>  return
> +
> +@attr(tags=["advanced", "intervlan"], required_hardware="false")
> +def test_22_vpn_customer_gw_with_hostname(self):
> +"""
> +Test to create vpn customer gateway with hostname
> +instead of gateway ip address
> +"""
> +try:
> +vpnGw = VpnCustomerGateway.create(
> +self.apiclient,
> +self.services["vpn_customer_gw"],
> +name="test_vpn_customer_gw",
> +gateway="GwWithHostName",
> +cidrlist="10.1.0.0/16"
> +)
> +self.cleanup.append(vpnGw)
> +except Exception as e:
> +self.fail("Creating vpn customer gateway with hostname\
> +  Failed with error :%s" % e)
> +return
> --- End diff --
>
> @sanju1010 shouldn't some assertion that the adding succeeded be added
> here? If some programmer decides to silently ignore an error somewhere this
> test becomes useless.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

2015-12-30 Thread Sanjeev N
LGTM!!

Test revert snapshot on XenServer ... === TestName:
test_01_check_revert_snapshot | Status : SUCCESS ===

ok



--

Ran 1 test in 132.503s



OK

On Wed, Dec 23, 2015 at 5:44 PM, pvr9711  wrote:

> Github user pvr9711 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1190#issuecomment-166878697
>
> @remibergsma can you please check this commit and merge it in?
> Thanks, Raja
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread Sanjeev N
@wilder, I am ok with it. You can take it over.
One comment, is ostype "Other PV (64-bit)" valid for other hypervisors
otherthan Xenserver? And vmware template format should be in .ova
The one you have mentioned in the Services class won't work.

On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues  wrote:

> Github user wilderrodrigues commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177
>
> @sanju1010
>
> Are you still working on this? It's currently holding us a bit because
> we need to do some work on this test as well. For instance, I want to make
> it rVPC compliant.
>
> The point is: I'm trying to avoid conflicts when merging your changes
> with my changes.
>
> If that would be fine, I would like to suggest I take it over. I
> already applied some fixes to the test_internal_lb.py, which was suffering
> from the same problem. See PR #1204
>
> Is that okay if I take it ove?
>
> Cheers,
> Wilder
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread Sanjeev N
@Wilder, forgot to mention, either we should also add template for LXC or
skip the test for LXC.

On Thu, Dec 10, 2015 at 2:40 PM, Sanjeev N <sanj...@apache.org> wrote:

> @wilder, I am ok with it. You can take it over.
> One comment, is ostype "Other PV (64-bit)" valid for other hypervisors
> otherthan Xenserver? And vmware template format should be in .ova
> The one you have mentioned in the Services class won't work.
>
> On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues <g...@git.apache.org>
> wrote:
>
>> Github user wilderrodrigues commented on the pull request:
>>
>> https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177
>>
>> @sanju1010
>>
>> Are you still working on this? It's currently holding us a bit
>> because we need to do some work on this test as well. For instance, I want
>> to make it rVPC compliant.
>>
>> The point is: I'm trying to avoid conflicts when merging your changes
>> with my changes.
>>
>> If that would be fine, I would like to suggest I take it over. I
>> already applied some fixes to the test_internal_lb.py, which was suffering
>> from the same problem. See PR #1204
>>
>> Is that okay if I take it ove?
>>
>> Cheers,
>> Wilder
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>


Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread Sanjeev N
@terbolour, as per the previous logic in the test, it will register
xenserver template for any hypervisor other than kvm and vm deployment
fails for other hypervisors like vmware,hyper-v and lxc.
So I was asking how we should handle this.

On Tue, Dec 8, 2015 at 12:44 PM, terbolous  wrote:

> Github user terbolous commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-162797528
>
> @sanju1010 it works for XenServer as well atleast, haven't tried
> VMware. But you'll have to change your script to adjust to the different
> output
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread Sanjeev N
Thanks @michaelandersen, I will take those templates and make the test
generic.

On Tue, Dec 8, 2015 at 3:35 PM, michaelandersen  wrote:

> Github user michaelandersen commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936
>
> Gotcha. We could add templates for the other hypervisors (vmware and
> hyperv) from http://dl.openvm.eu/cloudstack/macchinina/x86_64/
>
> And remove the default_hypervisor variable and replace it for a
> dynamic template selection based on the nosetests hypervisor parameter.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread Sanjeev N
@michaelandersen, if we want to use that template it only works for kvm. So
either we have to skip the tests for other hypervisors or make the similar
templates for all other hypervisors as well.

On Tue, Dec 8, 2015 at 2:00 AM, michaelandersen  wrote:

> Github user michaelandersen commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-162651522
>
> So removed my last comment about field 7 to 6.  We need to choose 1
> type of template os for both kvm and xen and base the test on that.
>  @sanju1010: the machininna was already in there and working for kvm at
> least.  would you mind making that template work?
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

2015-12-02 Thread Sanjeev N
@daanhoogland I have updated the validation steps.

On Wed, Dec 2, 2015 at 2:46 PM, DaanHoogland  wrote:

> Github user DaanHoogland commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/1122#discussion_r46391214
>
> --- Diff: test/integration/component/test_tags.py ---
> @@ -2401,3 +2403,143 @@ def
> test_23_list_untagged_host_for_vm_migration(self):
>  if not id in host_ids_for_migration:
>  self.fail("Not all hosts are available for vm
> migration")
>  return
> +
> +@attr(tags=["advanced"], required_hardware="false")
> +def test_24_public_IP_tag(self):
> +""" Testcreation, adding and removing tag on public IP address
> +"""
> +# Validate the following
> +# 1. Create a domain and admin account under the new domain
> +# 2. Create  a tag on acquired public IP address using
> createTags API
> +# 3. Delete above created tag using deleteTags API
> +# 4. Perform steps 3&4 using domain-admin
> --- End diff --
>
> :) will you update it?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: marvin updates

2015-12-01 Thread Sanjeev N
Please let me know if there are any issues with Marvin? I can look into it.

On Tue, Dec 1, 2015 at 5:58 PM, Daan Hoogland 
wrote:

> thanks Abhi,
>
> On Tue, Dec 1, 2015 at 1:14 PM, Abhinandan Prateek <
> abhinandan.prat...@shapeblue.com> wrote:
>
> > AFAIK, Santhosh and Gaurav were the last few looking at Marvin framework.
> > Though I do not see them active as in real active, but once in a while I
> > see them responding to some issue.
> > If you know there are some issues to be looked into, just cc that to
> their
> > email ids, hopefully they will respond or other community folks may try
> > picking it up.
> >
> > Regards,
> > Abhinandan Prateek
> > S: +44 20 3603 0540  | M: +91 97011 99011
> > 
> > abhinandan.prat...@shapeblue.com
> >
> >
> >
> >
> >
> >
> > On 01/12/15, 3:45 PM, "Daan Hoogland"  wrote:
> >
> > >​Is anybody in the community still maintaining Marvin? (I mean the
> > >framework not the tests)​
> > >
> > >--
> > >Daan
> > Find out more about ShapeBlue and our range of CloudStack related
> services
> >
> > IaaS Cloud Design & Build<
> > http://shapeblue.com/iaas-cloud-design-and-build//>
> > CSForge – rapid IaaS deployment framework
> > CloudStack Consulting
> > CloudStack Software Engineering<
> > http://shapeblue.com/cloudstack-software-engineering/>
> > CloudStack Infrastructure Support<
> > http://shapeblue.com/cloudstack-infrastructure-support/>
> > CloudStack Bootcamp Training Courses<
> > http://shapeblue.com/cloudstack-training/>
> >
> > This email and any attachments to it may be confidential and are intended
> > solely for the use of the individual to whom it is addressed. Any views
> or
> > opinions expressed are solely those of the author and do not necessarily
> > represent those of Shape Blue Ltd or related companies. If you are not
> the
> > intended recipient of this email, you must neither take any action based
> > upon its contents, nor copy or show it to anyone. Please contact the
> sender
> > if you believe you have received this email in error. Shape Blue Ltd is a
> > company incorporated in England & Wales. ShapeBlue Services India LLP is
> a
> > company incorporated in India and is operated under license from Shape
> Blue
> > Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
> Brasil
> > and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd
> is
> > a company registered by The Republic of South Africa and is traded under
> > license from Shape Blue Ltd. ShapeBlue is a registered trademark.
> >
>
>
>
> --
> Daan
>


Re: [4.6] VPN works?

2015-11-08 Thread Sanjeev N
Nux,

When you say SNAT is it SourceNAT IP address or you have acquired IP
address and trying VPN on it? If later is the case then it won't work.

-Sanjeev

On Fri, Nov 6, 2015 at 10:41 AM, Jayapal Reddy Uradi <
jayapalreddy.ur...@citrix.com> wrote:

> When I test last time remote access vpn and s2s vpn are working.
> I think there are no changes done on vpn after that.
>
> @Nux
> If you still see problem observe /var/log/auth.log in the VR.
>
>
> Thanks,
> Jayapal
> > On 06-Nov-2015, at 5:22 am, Nux!  wrote:
> >
> > Remi,
> >
> > This was a normal server-client VPN, not site2site. The client is Win7,
> but the network was a bit dodgy there, hence my doubts the VPN was actually
> broken. :)
> >
> > Lucian
> >
> > PS: script welcome for possible future uses, thanks!
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
> >
> > - Original Message -
> >> From: "Remi Bergsma" 
> >> To: dev@cloudstack.apache.org
> >> Sent: Thursday, 5 November, 2015 20:01:01
> >> Subject: Re: [4.6] VPN works?
> >
> >> Hi Lucian,
> >>
> >> As far as I know it works. The Marvin tests also passes.
> >>
> >> When I test manual and connect two VPCs together, I can ping the hosts
> on each
> >> side. I can send you a small script that sets it up, if you want.
> >>
> >> Regards,
> >> Remi
> >>
> >>
> >>
> >>
> >> On 05/11/15 19:47, "Nux!"  wrote:
> >>
> >>> Hi guys,
> >>>
> >>> I am testing 4.6 briefly and basic operations work. I am also trying
> now VPN
> >>> functionality on a SNAT public IP, however I don't seem to get it
> working.
> >>> Can someone confirm it works for them so I know it's me (as always)? I
> am not
> >>> usually using this feature, but thought to try it anyway.
> >>>
> >>> Lucian
> >>>
> >>> --
> >>> Sent from the Delta quadrant using Borg technology!
> >>>
> >>> Nux!
> >>> www.nux.ro
>
>


Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8 tests in test_ssvm.py

2015-11-03 Thread Sanjeev N
In case of VMWare and Hyper-v , linc local is on eth1. So the command in
all the failed tests to verify link local IP should be modified.
"cat /var/cache/cloud/cmdline | xargs | sed \"s/ /\\n/g\" | grep eth0ip= |
sed \"s/\=/ /g\" | awk '{print $2}'",.
It is using eth0ip. However, it should be eth1ip.

On Tue, Nov 3, 2015 at 12:25 PM, Wilder Rodrigues <
wrodrig...@schubergphilis.com> wrote:

> Thanks , Raja!
>
> Will fix it today!
>
> Cheers,
> Wilder
>
> Sent from my iPhone
>
> On 02 Nov 2015, at 14:11, Raja Pullela > wrote:
>
> Hi wilder, missed your earlier email.. sorry,  here are the details.  Let
> me know if you need any further details.  I believe for Hyperv/Vmware the
> ips come from the pod cidr and the validation should be skipped.
>
> Raja
> Error Message
>
> The cached Link Local should be the same as the current Link Local IP, but
> they are different! Current ==> 10.71.153.33; Cached ==> 169.254.1.130
> Logs available at 
>
> Stacktrace
>
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/root/cloudstack/test/integration/smoke/test_ssvm.py", line 518,
> in test_03_ssvm_internals
> "The cached Link Local should be the same as the current Link Local
> IP, but they are different! Current ==> %s; Cached ==> %s " %
> (linklocal_ip, res)
>   File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 924, in
> assertMultiLineEqual
> self.fail(self._formatMessage(msg, standardMsg))
>   File "/usr/lib/python2.7/unittest/case.py", line 410, in fail
> raise self.failureException(msg)
> 'The cached Link Local should be the same as the current Link Local IP,
> but they are different! Current ==> 10.71.153.33; Cached ==> 169.254.1.130
> \n
>
> 
>
> From: Wilder Rodrigues >
> Date: November 2, 2015 at 4:04:31 PM GMT+5:30
> To: Rajani Karuturi >, Remi
> Bergsma >,
> Raja Pullela >,
> dev@cloudstack.apache.org <
> dev@cloudstack.apache.org>
> Subject: Re: CloudStack-8933 changes regressed HyperV and VMware BVTs - 8
> tests in test_ssvm.py
>
> Hi Raja,
>
> We don't have vmware/hyperv test environment. Could you please print the
> whole error message? I'm missing the bit that says:
>
> Current ==> %s; Cached ==> %s
>
> Without the full message I cannot look further into it.
>
> Cheers,
> Wilder
>
>
>
> > On 30 Oct 2015, at 17:03, Raja Pullela > wrote:
> >
> > Hi Wilder
> >
> > The changes from this commit are failing the HyperV and VMware BVTs.
> >
> > Can you please let me know if these tests were passing in your
> environment- VMware, Hyperv?
> >
> > Raja
> >
> > Error - "the cached link local should be same current local ip, but they
> are different!"
> >
>
>


Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

2015-11-03 Thread Sanjeev N
I am taking back my previous comment. I created VMWare environment and vpc
creation was successful. Please ignore it.


On Tue, Nov 3, 2015 at 12:15 PM, Remi Bergsma <rberg...@schubergphilis.com>
wrote:

> Hi Sanjeev,
>
> That same tests passes fine here (see all the reviews I posted). Can you
> provide more details, so we can find the difference?
>
> What hypervisor, management server, other environmental properties. Please
> also share the full logs (you may also send them to me private, if you
> don’t want to publish them). Then we can investigate.
>
> Regards,
> Remi
>
>
>
>
>
> On 02/11/15 13:29, "Sanjeev N" <sanj...@apache.org> wrote:
>
> >The reason for these two failures is VPC creation itself is failing.
> Reason
> >being "SSH access to VR on 3922 port using its management ip address" is
> >failing. Hence failure in VR start. This looks like product bug to me.
> >
> >-Sanjeev
> >
> >On Fri, Oct 30, 2015 at 10:36 PM, Raja Pullela <raja.pull...@citrix.com>
> >wrote:
> >
> >> Super, thanks Remi!
> >>
> >> > On Oct 30, 2015, at 10:35 PM, Remi Bergsma <
> rberg...@schubergphilis.com>
> >> wrote:
> >> >
> >> > Hi Raja,
> >> >
> >> > Talked to Michael and he will improve the test soon.
> >> >
> >> > Regards,
> >> > Remi
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >> On 30/10/15 17:44, "Raja Pullela" <raja.pull...@citrix.com> wrote:
> >> >>
> >> >> Hi Michael
> >> >>
> >> >> Can you please add a wait for the template  to download before the VM
> >> creation?
> >> >>
> >> >> Raja
> >> >> Begin forwarded message:
> >> >> From: Raja Pullela <raja.pull...@citrix.com >> raja.pull...@citrix.com>>
> >> >> Date: October 29, 2015 at 11:49:59 AM GMT+5:30
> >> >> To: "CloudStack Dev (dev@cloudstack.apache.org >> dev@cloudstack.apache.org>)" <dev@cloudstack.apache.org >> dev@cloudstack.apache.org>>
> >> >> Subject: Few BVTs failing
> >> >> Reply-To: <dev@cloudstack.apache.org dev@cloudstack.apache.org>>
> >> >>
> >> >> Hi,
> >> >>
> >> >> In the latest BVTs, following tests are failing consistently -
> >> >>
> >> >> * 2015-10-29 00:27:43,987 - CRITICAL - FAILED:
> >> test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '
> >> File "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
> >> testMethod()\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, in
> >> test_vpc_remote_access_vpn\nself.fail(e)\n', '  File
> >> "/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise
> >> self.failureException(msg)\n', 'AssertionError: Execute cmd:
> >> deployvirtualmachine failed, due to: errorCode: 530, errorText:Template
> 202
> >> has not been completely downloaded to zone 1\n']
> >> >>
> >> >> * 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION:
> >> test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File
> >> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
> >> testMethod()\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, in
> >> test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to
> >> deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before
> >> assignment\n"]
> >> >>
> >> >> * 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION:
> >> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most
> >> recent call last):\n', '  File "/usr/lib/python2.7/unittest/case.py",
> line
> >> 329, in run\ntestMethod()\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line
> 576, in
> >> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm =
> >> self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File
> >> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line
> 382, in
> >> deployvm_in_network\nraise Exception("Deployment failed of VM: %s" %
> >> e)\n', "Exception: Deployment

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

2015-11-02 Thread Sanjeev N
This is very small change related to list validation and it looks good.

LGTM!!

On Wed, Oct 28, 2015 at 11:28 AM, bhaisaab  wrote:

> Github user bhaisaab commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/994#issuecomment-151733973
>
> Officially we're over 9000 :)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

2015-11-02 Thread Sanjeev N
I looked at the changes Priti has done in this PR. It looks good to me.
LGTM!!

On Thu, Oct 29, 2015 at 11:00 AM, pritisarap12  wrote:

> GitHub user pritisarap12 opened a pull request:
>
> https://github.com/apache/cloudstack/pull/1000
>
> CLOUDSTACK-9005: Modifying tearDown function
>
> Modifying tearDown function to check if data volume is in detached
> state before deleting the volume
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pritisarap12/cloudstack
> CLOUDSTACK-9005-Modifying-tearDown-function
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/1000.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #1000
>
> 
> commit d793c7f50ff56a3ecdd6c8862df1ee67ebcc9ac4
> Author: Priti Sarap 
> Date:   2015-10-29T05:28:15Z
>
> CLOUDSTACK-9005: Modifying tearDown function
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: test_vpc_vpn.py failing 2 BVTs on all Advnetworking config

2015-11-02 Thread Sanjeev N
The reason for these two failures is VPC creation itself is failing. Reason
being "SSH access to VR on 3922 port using its management ip address" is
failing. Hence failure in VR start. This looks like product bug to me.

-Sanjeev

On Fri, Oct 30, 2015 at 10:36 PM, Raja Pullela 
wrote:

> Super, thanks Remi!
>
> > On Oct 30, 2015, at 10:35 PM, Remi Bergsma 
> wrote:
> >
> > Hi Raja,
> >
> > Talked to Michael and he will improve the test soon.
> >
> > Regards,
> > Remi
> >
> >
> >
> >
> >
> >> On 30/10/15 17:44, "Raja Pullela"  wrote:
> >>
> >> Hi Michael
> >>
> >> Can you please add a wait for the template  to download before the VM
> creation?
> >>
> >> Raja
> >> Begin forwarded message:
> >> From: Raja Pullela >
> >> Date: October 29, 2015 at 11:49:59 AM GMT+5:30
> >> To: "CloudStack Dev (dev@cloudstack.apache.org dev@cloudstack.apache.org>)" >
> >> Subject: Few BVTs failing
> >> Reply-To: >
> >>
> >> Hi,
> >>
> >> In the latest BVTs, following tests are failing consistently -
> >>
> >> * 2015-10-29 00:27:43,987 - CRITICAL - FAILED:
> test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '
> File "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
> testMethod()\n', '  File
> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, in
> test_vpc_remote_access_vpn\nself.fail(e)\n', '  File
> "/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise
> self.failureException(msg)\n', 'AssertionError: Execute cmd:
> deployvirtualmachine failed, due to: errorCode: 530, errorText:Template 202
> has not been completely downloaded to zone 1\n']
> >>
> >> * 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION:
> test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File
> "/usr/lib/python2.7/unittest/case.py", line 329, in run\n
> testMethod()\n', '  File
> "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, in
> test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to
> deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before
> assignment\n"]
> >>
> >> * 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION:
> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most
> recent call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line
> 329, in run\ntestMethod()\n', '  File
> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 576, in
> test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm =
> self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File
> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 382, in
> deployvm_in_network\nraise Exception("Deployment failed of VM: %s" %
> e)\n', "Exception: Deployment failed of VM: Job failed: {jobprocstatus : 0,
> created : u'2015-10-29T02:02:09+', jobresult : {errorcode : 533,
> errortext : u'Unable to create a deployment for VM[User|i-36-69-VM]'}, cmd
> : u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid
> : u'afe432e8-7dd7-11e5-9ca5-b230fb1ebb83', jobstatus : 2, jobid :
> u'de5a239a-c70c-4039-9e8e-2ea9b80ed28b', jobresultcode : 530, jobinstanceid
> : u'47770620-0c37-4e7c-91e0-666bf7fe5eaa', jobresulttype : u'object',
> jobinstancetype : u'VirtualMachine', accountid :
> u'afe422b2-7dd7-11e5-9ca5-b230fb1ebb83'}\n"]
> >>
> >> * 2015-10-29 02:00:33,135 - CRITICAL - EXCEPTION:
> test02_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most recent
> call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in
> run\ntestMethod()\n', '  File
> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 686, in
> test02_internallb_haproxy_stats_on_all_interfaces\nsettings =
> self.get_lb_stats_settings()\n', '  File
> "/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 646, in
> get_lb_stats_settings\nself.fail("Failed to retrieve stats settings " %
> e)\n', 'TypeError: not all arguments converted during string formatting\n']
> >>
> >> Looks like these were added by Michael.
> >>
> >> Michael,
> >> Can you optimize the tests with the following
> >>
> >> 1)  Before the VM Deployment or right after Template Register, can
> you put a loop to check if the Template is in a ready state before
> continuing with the test ? The reason is Template download is not getting
> completed and as a result the test cases are failing.
> >>
> >> 2)  Any reason for not using test_data.py to have all the
> configuration/settings you have defined the test file ?
> >>
> >> Please let me know if you have any questions,
> >> Raja
> >>
>


Re: [GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-25 Thread Sanjeev N
I will update the PR with required changes suggested by @pvr9711.

On Sat, Oct 24, 2015 at 11:36 PM, remibergsma  wrote:

> Github user remibergsma commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/902#issuecomment-150838537
>
> @sanju1010 Any update on this?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-14 Thread Sanjeev N
@kishankavala,
Big no , because simulator regression suite takes almost 6 hours to
complete.

On Wed, Oct 14, 2015 at 11:24 AM, kishankavala  wrote:

> Github user kishankavala commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/920#issuecomment-147944007
>
> @runseb @pvr9711 @sanjeevneelarapu
> Can we include all regression simulator tests also?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-13 Thread Sanjeev N
Hi,

travis/script.sh uses following nose command to pick the tests.
nosetests --with-xunit --xunit-file=integration-test-results/$suite.xml
--with-marvin --marvin-config=setup/dev/advanced.cfg
test/integration/$suite.py -s -a tags=advanced,required_hardware=false
--zone=Sandbox-simulator --hypervisor=simulator || true ;

CI is running on advanced zone and it is picking the tests that are tagged
for running on simulator.  That is the reason we don't see all tests
running since some of them require hardware to run.

PR looks good. LTGM !!

@pvr9711, we don't need to add .py at the end.

Thanks,
Sanjeev

On Tue, Oct 13, 2015 at 11:01 AM, pvr9711  wrote:

> Github user pvr9711 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/920#issuecomment-147607738
>
> Following are the tests that run on Simulator basic and adv -
> separately, please add ".py" to the end.
> Simulator Basic -
> integration.smoke.test_affinity_groups
> integration.smoke.test_deploy_vms_with_varied_deploymentplanners
> integration.smoke.test_disk_offerings
> integration.smoke.test_global_settings
> integration.smoke.test_iso
> integration.smoke.test_multipleips_per_nic
> integration.smoke.test_over_provisioning
> integration.smoke.test_portable_publicip
> integration.smoke.test_primary_storage
> integration.smoke.test_reset_vm_on_reboot
> integration.smoke.test_scale_vm
> integration.smoke.test_secondary_storage
> integration.smoke.test_service_offerings
> integration.smoke.test_ssvm
> integration.smoke.test_templates
> integration.smoke.test_vm_life_cycle
> integration.smoke.test_volumes
>
> Simulator Adv -
> integration.smoke.test_affinity_groups
> integration.smoke.test_deploy_vms_with_varied_deploymentplanners
> integration.smoke.test_disk_offerings
> integration.smoke.test_global_settings
> integration.smoke.test_guest_vlan_range
> integration.smoke.test_iso
> integration.smoke.test_multipleips_per_nic
> integration.smoke.test_network
> integration.smoke.test_nic_adapter_type
> integration.smoke.test_non_contigiousvlan
> integration.smoke.test_over_provisioning
> integration.smoke.test_portable_publicip
> integration.smoke.test_primary_storage
> integration.smoke.test_privategw_acl
> integration.smoke.test_public_ip_range
> integration.smoke.test_pvlan
> integration.smoke.test_reset_vm_on_reboot
> integration.smoke.test_resource_detail
> integration.smoke.test_routers
> integration.smoke.test_scale_vm
> integration.smoke.test_secondary_storage
> integration.smoke.test_service_offerings
> integration.smoke.test_ssvm
> integration.smoke.test_templates
> integration.smoke.test_vm_life_cycle
> integration.smoke.test_volumes
> ntegration.smoke.test_vpc_vpn
>
>
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: Blameless post mortem

2015-09-27 Thread Sanjeev N
I have a concern here. Some of us are actively involved in reviewing the
PRs related to marvin tests(Enhancing existing tests/Adding new tests). If
we have to test a PR it requires an environment to be created with actual
resources and this is going to take lot of time. Some of the tests can run
on simulator but most of the tests require real hardware to test. PR
submitter is already testing and submitting the test results along with the
PR. So is it require to test these PRs by reviewers?

On Sat, Sep 26, 2015 at 1:49 PM, sebgoa  wrote:

> Remi, thanks for the detailed post-mortem, it's a good read and great
> learning.
> I hope everyone reads it.
>
> The one thing to emphasize is that we now have a very visible way to get
> code into master, we have folks investing time to provide review (great),
> we need the submitters to make due diligence and answer all comments in the
> reviews.
>
> In another project i work on, nothing can be added to the code without
> unit tests. I think we could go down the route of asking for new
> integration tests and unit tests for anything. If not, the PR does not get
> merged. But let's digest your post-mortem and we can discuss after 4.6.0.
>
> I see that you reverted one commit that was not made by you, that's great.
>
> Let's focus on the blockers now, everything else can wait.
>
> The big bonus of doing what we are doing is that once 4.6.0 is out, we can
> merge PRs again (assuming they are properly rebased and tested) and we can
> release 4.6.1 really quickly after.
>
> -sebastien
>
> On Sep 25, 2015, at 9:51 PM, Remi Bergsma 
> wrote:
>
> > Hi all,
> >
> > This mail is intended to be blameless. We need to learn something from
> it. That's why I left out who exactly did what because it’s not relevant.
> There are multiple examples but it's about the why. Let's learn from this
> without blaming anyone.
> >
> > We know we need automated testing. We have integration tests, but we are
> unable to run all of them on any Pull Request we receive. If we would have
> that in place, it'd be much easier to spot errors, regression and so on.
> It'd also be more rewarding to write more tests.
> >
> > Unfortunately we're not there yet. So, we need to do something else
> instead until we get there. If we do nothing, we know we have many issues
> because a master that breaks on a regular basis is the most frustrating
> things. We said we'd use Pull Requests with at least two humans to review
> and give their OK for a Pull Request. In the form of LGTM: Looks Good To
> Me. Ok, so the LGTMs are there because we have no automated testing. Keep
> that in mind. You are supposed to replace automated testing until it's
> there.
> >
> > Since we do this, master got a lot more stable. But every now and then
> we still have issues. Let's look at how we do manual reviews. Again, this
> is not to blame anyone. It's to open our eyes and make us realise what
> we're doing and what results we get out of that.
> >
> >
> > Example Pull Request #784:
> > Title: CLOUDSTACK-8799 fixed the default routes
> >
> > That's nice, it has a Jira id and a short description (as it should be).
> >
> > The first person comes along and makes a comment:
> > "There was also an issue with VPC VRs" ... "Have you seen this issue?
> Does your change affects the VPC VR (single/redundant)?"
> >
> > Actually a good question. Unfortunaly there comes no answer. After a
> reminder, it was promised to do tests against VPC networks. Great!
> >
> > The Jenkins builds both succeed and also Travis is green. But how much
> value does this have? They have the impression to do automated testing, and
> although you could argue they do, it's far from complete. If it breaks, you
> know you have an issue. But it doesn’t work the other way around.
> >
> > Back to our example PR. In the mean time, another commit gets pushed to
> it: "CLOUDSTACK-8799 fixed for vpc networks." But if you look at the Jira
> issue, you see it is about redundant virtual routers. The non-VPC ones. So
> this is vague at best. But a reviewer gives a LGTM because the person could
> create a VPC. That doesn't have anything to do with the problem being fixed
> in this PR nor with the comments made earlier. But, at least the person
> said what he did and we should all do that. What nobody knew back then, was
> that this broke the default route on VPCs.
> >
> > Then something strange happens: the two commits from the PR end up on
> master as direct commits. With just one LGTM and no verification from the
> person commenting about the linked issue. This happened on Friday September
> 11th.
> >
> > That day 21 commits came in, from 7 Pull Request and unfortunately also
> from some direct commits. We noticed the direct commits and notified the
> list (http://cloudstack.markmail.org/message/srmszloyipkxml36). As a lot
> came in at the same time, it was decided not to revert them. Looking back,
> we should have done it.
> >
> > 

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8893: Fixing script as per the...

2015-09-23 Thread Sanjeev N
@pavanb018 good catch !! It is not part of the code but will change.

On Wed, Sep 23, 2015 at 10:52 AM, pavanb018  wrote:

> Github user pavanb018 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/871#issuecomment-142497091
>
> @Desc: Test that Volume snapshot for root volume not allowed ... ===
> TestName: test_01_test_vm_volume_snapshot | Status : SUCCESS ===
> ok
>
> Sanju1010 , is the above description part of script ? The description
> looks misleading with the current functionality. If it is not part of the
> code then LGTM !! , else please modify the description so that it wont be
> confusing.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: [GitHub] cloudstack pull request: CLOUDSTACK-8726 : Automation for Quickly ...

2015-09-23 Thread Sanjeev N
LGTM!!

On Wed, Sep 23, 2015 at 2:15 PM, pavanb018  wrote:

> Github user pavanb018 commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/683#issuecomment-142531937
>
> The result of operation is captured in the list volume validation
> following the call to query_async_job method. Hence didn't capture the
> return value of call to function as it will be captured in the end
> validation. Please let me know your suggestions.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: Proposal to get to 100% passrate on BVTs

2015-09-21 Thread Sanjeev N
I would be happy to lend my hand in generalizing the BVT Infra.

-Sanjeev

On Mon, Sep 21, 2015 at 4:34 PM, Raja Pullela 
wrote:

> Rohit, not sure about the efforts required to do this.  Can certainly work
> with you or someone to do this.  Please let me know,
>
> best,
> Raja
> From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
> Sent: Monday, September 21, 2015 2:53 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Proposal to get to 100% passrate on BVTs
>
> Great initiative Raja!
>
> Any effort in generalizing the BVT infra so the infra can be reproduced
> using Puppet/Ansible?
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
>
>
> [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]
>
>
> M. +91 88 262 30892 | rohit.ya...@shapeblue.com rohit.ya...@shapeblue.com>
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build<
> http://shapeblue.com/iaas-cloud-design-and-build/>
> CSForge - rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Software Engineering<
> http://shapeblue.com/cloudstack-software-engineering/>
> CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses<
> http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>


Re: [GitHub] cloudstack pull request: verify that when createTemplate is ued to...

2015-08-26 Thread Sanjeev N
LGTM!!

On Wed, Aug 26, 2015 at 3:01 PM, bhaisaab g...@git.apache.org wrote:

 Github user bhaisaab commented on the pull request:

 https://github.com/apache/cloudstack/pull/688#issuecomment-134918074

 LGTM


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8723: Verify API call listUsa...

2015-08-13 Thread Sanjeev N
LGTM!!

On Tue, Aug 11, 2015 at 4:56 PM, pritisarap12 g...@git.apache.org wrote:

 Github user pritisarap12 commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/675#discussion_r36734678

 --- Diff: test/integration/testpaths/testpath_usage.py ---
 @@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self):
  # aggregation period and current period will give the network
 usage
  return

 +@attr(tags=[advanced, basic], required_hardware=false)
 +def test_08_checkNewVolumein_listUsageRecords(self):
 + Test case to check if new volume crated after
 +restore VM is listed in listUsageRecords
 +# 1. Launch a VM
 +# 2. Restore the VM
 +# 3. Check if the new volume created is listed in
 listUsageRecords API
 +
 +
 +# Step 1
 +vm_cluster = VirtualMachine.create(
 +self.userapiclient,
 +self.testdata[small],
 +templateid=self.template.id,
 +accountid=self.account.name,
 +domainid=self.account.domainid,
 +serviceofferingid=self.service_offering.id,
 +zoneid=self.zone.id,
 +)
 +
 +volumes_root_list = list_volumes(
 +self.apiclient,
 +virtualmachineid=vm_cluster.id,
 +type='ROOT',
 +listall=True
 +)
 +
 +root_volume = volumes_root_list[0]
 +
 +# Step 2
 +vm_cluster.restore(self.apiclient)
 +
 +qresultset = self.dbclient.execute(
 +select id from volumes where name='%s' and
 state='Ready'; %
 +root_volume.name)
 +
 +self.assertNotEqual(
 +len(qresultset),
 +0,
 +Check DB Query result set
 +)
 +
 +volumeCheck = Volume Id:  + str(qresultset[0][0]) +  usage
 time
 +
 +response = self.listUsageRecords(usagetype=6)
 +self.assertEqual(response[0], PASS, response[1])
 +UsageRecords = [record for record in response[1]
 +if volumeCheck in record.description]
 +# Step 3
 +self.assertNotEqual(
 --- End diff --

 No, In step 3 we are verifying that UsageRecords should not be None.
 or I have updated test case to fail it if UsageRecords  is empty.


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

2015-08-10 Thread Sanjeev N
LGTM!!


On Mon, Aug 10, 2015 at 11:34 AM, pritisarap12 g...@git.apache.org wrote:

 GitHub user pritisarap12 opened a pull request:

 https://github.com/apache/cloudstack/pull/668


 CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath

 -Adding cls.hypervisor = cls.testClient.getHypervisorInfo()
 -Fixed pep8 issues

 You can merge this pull request into a Git repository by running:

 $ git pull https://github.com/pritisarap12/cloudstack
 CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha

 Alternatively you can review and apply these changes as the patch at:

 https://github.com/apache/cloudstack/pull/668.patch

 To close this pull request, make a commit to your master/trunk branch
 with (at least) the following in the commit message:

 This closes #668

 
 commit 23ac5588fb354b9ba36c9e0096287c700a85775f
 Author: Priti Sarap priti.sa...@clogeny.com
 Date:   2015-08-10T06:00:55Z


 CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha
 -Adding cls.hypervisor = cls.testClient.getHypervisorInfo()

 


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [Blocker] Default ip table rules on VR

2015-08-03 Thread Sanjeev N
I think we need to allow tcp port 3922 in INPUT chain for the host to ssh
to VR.

On Mon, Aug 3, 2015 at 3:00 PM, Wilder Rodrigues 
wrodrig...@schubergphilis.com wrote:

 Hi Sanjeev,

 I added some comments to the issue on Jira, but will share it here as well
 since not many people are watching the issue:

 I updated the CsAddress.py file and deployed a KVM datacenter, with new
 agent/common RPM packages. The router has now INPUT/FORWARD with DROP
 instead of ACCEPT.

 However, it seems to block communication with the host, since the router
 stays stuck on starting state on ACS management server.

 I managed to access the router via libvirt console command. See details
 below:

 [root@kvm2 ~]# virsh console 4
 Connected to domain r-4-VM
 Escape character is ^]

 root@r-4-VM:~# iptables --list
 Chain INPUT (policy DROP)
 target prot opt source   destination
 ACCEPT tcp  --  anywhere anywhere tcp dpt:10086
 NETWORK_STATS  all  --  anywhere anywhere
 ACCEPT all  --  anywhere vrrp.mcast.net
 ACCEPT all  --  anywhere 225.0.0.50
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT icmp --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere
 ACCEPT all  --  anywhere vrrp.mcast.net
 ACCEPT all  --  anywhere 225.0.0.50
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT icmp --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere
 ACCEPT udp  --  anywhere anywhere udp
 dpt:bootps
 ACCEPT udp  --  anywhere anywhere udp
 dpt:domain
 ACCEPT tcp  --  anywhere anywhere tcp
 dpt:domain
 ACCEPT tcp  --  anywhere anywhere tcp dpt:http
 state NEW
 ACCEPT tcp  --  anywhere anywhere tcp
 dpt:http-alt state NEW

 Chain FORWARD (policy DROP)
 target prot opt source   destination
 NETWORK_STATS  all  --  anywhere anywhere
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT all  --  anywhere anywhere state NEW
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED
 ACCEPT all  --  anywhere anywhere state
 RELATED,ESTABLISHED

 Chain OUTPUT (policy ACCEPT)
 target prot opt source   destination
 NETWORK_STATS  all  --  anywhere anywhere

 Chain NETWORK_STATS (3 references)
 target prot opt source   destination
all  --  anywhere anywhere
all  --  anywhere anywhere
tcp  --  anywhere anywhere
tcp  --  anywhere anywhere
 root@r-4-VM:~#

 I will compare the new iptables configuration with the old
 iptables-vpcrouter/iptables-router files.

 Cheers,
 Wilder


  On 31 Jul 2015, at 06:03, Sanjeev N sanj...@apache.org wrote:
 
  Thanks for working on it Wilder !!
 
  On Thu, Jul 30, 2015 at 6:05 PM, Wilder Rodrigues 
  wrodrig...@schubergphilis.com wrote:
 
  Hi,
 
  We discussed that one yesterday and I already assigned the issue to
 myself
  on Jira. I will fix it.
 
  Cheers,
  WIlder
 
 
 
  On 30 Jul 2015, at 14:09, Sanjeev N sanj...@apache.org wrote:
 
  Agree with Kishan Kavala and Jayapal.
 
  On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala 
 kishan.kav...@citrix.com
 
  wrote:
 
  This is a security issue with high impact.
  We should treat it as a blocker.
 
  -Original Message-
  From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
  Sent: 30 July 2015 02:07 PM
  To: dev@cloudstack.apache.org dev@cloudstack.apache.org
  Subject: Re: [Blocker] Default ip table rules on VR
 
  I see VR ingress traffic is blocked by default from iptables mangle
  table.
  But on the guest interface all the traffic is accepted.
  Also egress firewall rule will break because of FORWARD policy.
 
  Thanks,
  Jayapal
 
  On 30-Jul-2015, at 12:53 PM, Jayapal Reddy Uradi 
  jayapalreddy.ur...@citrix.com wrote:
 
 
  It is security concern on the VR. All the ingress traffic onto the VR
  is
  accepted.
  Let it be blocker.
 
  Thanks,
  Jayapal
 
  On 30-Jul-2015, at 12:28 PM, Daan Hoogland daan.hoogl...@gmail.com
  wrote:
 
  I changed it to critical. It is only a blocker if we agree on this
  list that it is.
 
  On Thu, Jul 30, 2015 at 6:44 AM, Sanjeev N sanj...@apache.org
  wrote:
  Hi,
 
  In latest ACS builds, the ip table rules in VR have ACCEPT as the
  default policy in INPUT and FORWARD chains, instead of DROP.
 
  Created a blocker bug for this issue
  https://issues.apache.org/jira/browse/CLOUDSTACK-8688
 
  Can somebody please fix it?
 
  Thanks,
  Sanjeev
 
 
 
  --
  Daan
 
 
 
 
 




Re: [GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...

2015-08-03 Thread Sanjeev N
LGTM!!


On Mon, Aug 3, 2015 at 11:46 AM, pritisarap12 g...@git.apache.org wrote:

 Github user pritisarap12 commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/631#discussion_r36058447

 --- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
 @@ -0,0 +1,209 @@
 +# Licensed to the Apache Software Foundation (ASF) under one
 +# or more contributor license agreements.  See the NOTICE file
 +# distributed with this work for additional information
 +# regarding copyright ownership.  The ASF licenses this file
 +# to you under the Apache License, Version 2.0 (the
 +# License); you may not use this file except in compliance
 +# with the License.  You may obtain a copy of the License at
 +#
 +#   http://www.apache.org/licenses/LICENSE-2.0
 +#
 +# Unless required by applicable law or agreed to in writing,
 +# software distributed under the License is distributed on an
 +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 +# KIND, either express or implied.  See the License for the
 +# specific language governing permissions and limitations
 +# under the License.
 + Test case for Data Disk Attach to VM on ZWPS Test Path
 +
 +
 +from nose.plugins.attrib import attr
 +from marvin.cloudstackTestCase import cloudstackTestCase
 +from marvin.lib.utils import (cleanup_resources,
 +  validateList)
 +from marvin.lib.base import (Account,
 + ServiceOffering,
 + DiskOffering,
 + Volume,
 + VirtualMachine,
 + StoragePool
 + )
 +from marvin.lib.common import (get_domain,
 +   get_zone,
 +   get_template
 +   )
 +
 +from marvin.codes import (PASS,
 +  ZONETAG1)
 +
 +
 +class TestAttachDataDisk(cloudstackTestCase):
 +
 +@classmethod
 +def setUpClass(cls):
 +testClient = super(TestAttachDataDisk, cls).getClsTestClient()
 +cls.apiclient = testClient.getApiClient()
 +cls.testdata = testClient.getParsedTestDataConfig()
 +cls.hypervisor = cls.testClient.getHypervisorInfo()
 +
 +# Get Zone, Domain and templates
 +cls.domain = get_domain(cls.apiclient)
 +cls.zone = get_zone(cls.apiclient,
 testClient.getZoneForTests())
 +cls._cleanup = []
 +cls.template = get_template(
 +cls.apiclient,
 +cls.zone.id,
 +cls.testdata[ostype])
 +cls.skiptest = False
 +
 +try:
 +cls.pools = StoragePool.list(cls.apiclient, zoneid=
 cls.zone.id)
 +except Exception as e:
 +cls.skiptest = True
 +return
 +try:
 +
 +# Create an account
 +cls.account = Account.create(
 +cls.apiclient,
 +cls.testdata[account],
 +domainid=cls.domain.id
 +)
 +cls._cleanup.append(cls.account)
 +
 +# Create user api client of the account
 +cls.userapiclient = testClient.getUserApiClient(
 +UserName=cls.account.name,
 +DomainName=cls.account.domain
 +)
 +# Create Service offering
 +cls.service_offering_zone1 = ServiceOffering.create(
 +cls.apiclient,
 +cls.testdata[service_offering],
 +tags=ZONETAG1
 +)
 +cls._cleanup.append(cls.service_offering_zone1)
 +
 +# Create Disk offering
 +cls.disk_offering = DiskOffering.create(
 +cls.apiclient,
 +cls.testdata[disk_offering]
 +)
 +
 +cls._cleanup.append(cls.disk_offering)
 +
 +except Exception as e:
 +cls.tearDownClass()
 +raise e
 +return
 +
 +@classmethod
 +def tearDownClass(cls):
 +try:
 +cleanup_resources(cls.apiclient, cls._cleanup)
 +except Exception as e:
 +raise Exception(Warning: Exception during cleanup : %s
 % e)
 +
 +def setUp(self):
 +self.apiclient = self.testClient.getApiClient()
 +self.dbclient = self.testClient.getDbConnection()
 +self.cleanup = []
 +
 +def tearDown(self):
 +try:
 +for storagePool in self.pools:
 +

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

2015-07-31 Thread Sanjeev N
LGTM

On Fri, Jul 31, 2015 at 4:42 PM, nitt10prashant g...@git.apache.org wrote:

 Github user nitt10prashant commented on the pull request:

 https://github.com/apache/cloudstack/pull/638#issuecomment-126656909

 LGTM



 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8689: Verify effect of changin...

2015-07-31 Thread Sanjeev N
How your logic works if there are no system vms on a host (ssvm, cpvm and
VR)? I mean if the cluster has more than one host and system vms were
deployed on another host in the cluster?

On Fri, Jul 31, 2015 at 2:01 PM, pritisarap12 g...@git.apache.org wrote:

 Github user pritisarap12 commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/638#discussion_r35955311

 --- Diff: test/integration/testpaths/testpath_hypervisor_limit.py ---
 @@ -0,0 +1,198 @@
 +# Licensed to the Apache Software Foundation (ASF) under one
 +# or more contributor license agreements.  See the NOTICE file
 +# distributed with this work for additional information
 +# regarding copyright ownership.  The ASF licenses this file
 +# to you under the Apache License, Version 2.0 (the
 +# License); you may not use this file except in compliance
 +# with the License.  You may obtain a copy of the License at
 +#
 +#   http://www.apache.org/licenses/LICENSE-2.0
 +#
 +# Unless required by applicable law or agreed to in writing,
 +# software distributed under the License is distributed on an
 +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 +# KIND, either express or implied.  See the License for the
 +# specific language governing permissions and limitations
 +# under the License.
 + Test cases for Testing Max Hypervisor Limit
 +
 +from nose.plugins.attrib import attr
 +from marvin.cloudstackTestCase import cloudstackTestCase
 +from marvin.lib.utils import (cleanup_resources,
 +  validateList)
 +from marvin.lib.base import (Account,
 + ServiceOffering,
 + VirtualMachine,
 + Host
 + )
 +from marvin.lib.common import (get_domain,
 +   get_zone,
 +   get_template,
 +   list_virtual_machines
 +   )
 +
 +
 +from marvin.cloudstackAPI import (updateHypervisorCapabilities,
 +  listHypervisorCapabilities)
 +
 +from marvin.codes import PASS
 +
 +
 +class TestMaxHyperviosrLimit(cloudstackTestCase):
 +
 +@classmethod
 +def setUpClass(cls):
 +testClient = super(TestMaxHyperviosrLimit,
 cls).getClsTestClient()
 +cls.apiclient = testClient.getApiClient()
 +cls.testdata = testClient.getParsedTestDataConfig()
 +
 +cls.hypervisor = cls.testClient.getHypervisorInfo()
 +# Get Zone, Domain and templates
 +
 +cls.domain = get_domain(cls.apiclient)
 +cls.zone = get_zone(cls.apiclient,
 testClient.getZoneForTests())
 +
 +cls.template = get_template(
 +cls.apiclient,
 +cls.zone.id,
 +cls.testdata[ostype])
 +
 +cls._cleanup = []
 +hostList = Host.list(cls.apiclient, zoneid=cls.zone.id,
 type=Routing)
 +cls.host = Host(hostList[0].__dict__)
 +Host.update(cls.apiclient, id=cls.host.id, hosttags=host1)
 +try:
 +cls.skiptest = False
 +if cls.hypervisor.lower() not in ['xenserver']:
 +cls.skiptest = True
 +return
 +
 +# Create an account
 +cls.account = Account.create(
 +cls.apiclient,
 +cls.testdata[account],
 +domainid=cls.domain.id
 +)
 +
 +# Create user api client of the account
 +cls.userapiclient = testClient.getUserApiClient(
 +UserName=cls.account.name,
 +DomainName=cls.account.domain
 +)
 +# Create Service offering
 +cls.service_offering = ServiceOffering.create(
 +cls.apiclient,
 +cls.testdata[service_offering],
 +hosttags=host1
 +)
 +
 +cls._cleanup = [
 +cls.account,
 +cls.service_offering,
 +]
 +except Exception as e:
 +cls.tearDownClass()
 +raise e
 +return
 +
 +@classmethod
 +def tearDownClass(cls):
 +try:
 +cleanup_resources(cls.apiclient, cls._cleanup)
 +except Exception as e:
 +raise Exception(Warning: Exception during cleanup : %s
 % e)
 +
 +def setUp(self):
 +self.cleanup = []
 +if self.skiptest:
 +self.skipTest(This test is to be checked on xenserver \
 +only  Hence, skip for 

Re: [Blocker] Default ip table rules on VR

2015-07-30 Thread Sanjeev N
Agree with Kishan Kavala and Jayapal.

On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala kishan.kav...@citrix.com
wrote:

 This is a security issue with high impact.
 We should treat it as a blocker.

 -Original Message-
 From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
 Sent: 30 July 2015 02:07 PM
 To: dev@cloudstack.apache.org dev@cloudstack.apache.org
 Subject: Re: [Blocker] Default ip table rules on VR

 I see VR ingress traffic is blocked by default from iptables mangle table.
 But on the guest interface all the traffic is accepted.
 Also egress firewall rule will break because of FORWARD policy.

 Thanks,
 Jayapal

 On 30-Jul-2015, at 12:53 PM, Jayapal Reddy Uradi 
 jayapalreddy.ur...@citrix.com wrote:

 
  It is security concern on the VR. All the ingress traffic onto the VR is
 accepted.
  Let it be blocker.
 
  Thanks,
  Jayapal
 
  On 30-Jul-2015, at 12:28 PM, Daan Hoogland daan.hoogl...@gmail.com
  wrote:
 
  I changed it to critical. It is only a blocker if we agree on this
  list that it is.
 
  On Thu, Jul 30, 2015 at 6:44 AM, Sanjeev N sanj...@apache.org wrote:
  Hi,
 
  In latest ACS builds, the ip table rules in VR have ACCEPT as the
  default policy in INPUT and FORWARD chains, instead of DROP.
 
  Created a blocker bug for this issue
  https://issues.apache.org/jira/browse/CLOUDSTACK-8688
 
  Can somebody please fix it?
 
  Thanks,
  Sanjeev
 
 
 
  --
  Daan
 




Re: [Blocker] Default ip table rules on VR

2015-07-30 Thread Sanjeev N
Thanks for working on it Wilder !!

On Thu, Jul 30, 2015 at 6:05 PM, Wilder Rodrigues 
wrodrig...@schubergphilis.com wrote:

 Hi,

 We discussed that one yesterday and I already assigned the issue to myself
 on Jira. I will fix it.

 Cheers,
 WIlder



  On 30 Jul 2015, at 14:09, Sanjeev N sanj...@apache.org wrote:
 
  Agree with Kishan Kavala and Jayapal.
 
  On Thu, Jul 30, 2015 at 2:13 PM, Kishan Kavala kishan.kav...@citrix.com
 
  wrote:
 
  This is a security issue with high impact.
  We should treat it as a blocker.
 
  -Original Message-
  From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
  Sent: 30 July 2015 02:07 PM
  To: dev@cloudstack.apache.org dev@cloudstack.apache.org
  Subject: Re: [Blocker] Default ip table rules on VR
 
  I see VR ingress traffic is blocked by default from iptables mangle
 table.
  But on the guest interface all the traffic is accepted.
  Also egress firewall rule will break because of FORWARD policy.
 
  Thanks,
  Jayapal
 
  On 30-Jul-2015, at 12:53 PM, Jayapal Reddy Uradi 
  jayapalreddy.ur...@citrix.com wrote:
 
 
  It is security concern on the VR. All the ingress traffic onto the VR
 is
  accepted.
  Let it be blocker.
 
  Thanks,
  Jayapal
 
  On 30-Jul-2015, at 12:28 PM, Daan Hoogland daan.hoogl...@gmail.com
  wrote:
 
  I changed it to critical. It is only a blocker if we agree on this
  list that it is.
 
  On Thu, Jul 30, 2015 at 6:44 AM, Sanjeev N sanj...@apache.org
 wrote:
  Hi,
 
  In latest ACS builds, the ip table rules in VR have ACCEPT as the
  default policy in INPUT and FORWARD chains, instead of DROP.
 
  Created a blocker bug for this issue
  https://issues.apache.org/jira/browse/CLOUDSTACK-8688
 
  Can somebody please fix it?
 
  Thanks,
  Sanjeev
 
 
 
  --
  Daan
 
 
 




[Blocker] Default ip table rules on VR

2015-07-29 Thread Sanjeev N
Hi,

In latest ACS builds, the ip table rules in VR have ACCEPT as the default
policy in INPUT and FORWARD chains, instead of DROP.

Created a blocker bug for this issue
https://issues.apache.org/jira/browse/CLOUDSTACK-8688

Can somebody please fix it?

Thanks,
Sanjeev


Re: [GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...

2015-07-27 Thread Sanjeev N
LGTM!!

On Mon, Jul 27, 2015 at 12:11 PM, pritisarap12 g...@git.apache.org wrote:

 Github user pritisarap12 commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/619#discussion_r35508814

 --- Diff: test/integration/testpaths/testpath_queryAsyncJobResult.py
 ---
 @@ -0,0 +1,133 @@
 +# Licensed to the Apache Software Foundation (ASF) under one
 +# or more contributor license agreements.  See the NOTICE file
 +# distributed with this work for additional information
 +# regarding copyright ownership.  The ASF licenses this file
 +# to you under the Apache License, Version 2.0 (the
 +# License); you may not use this file except in compliance
 +# with the License.  You may obtain a copy of the License at
 +#
 +#   http://www.apache.org/licenses/LICENSE-2.0
 +#
 +# Unless required by applicable law or agreed to in writing,
 +# software distributed under the License is distributed on an
 +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 +# KIND, either express or implied.  See the License for the
 +# specific language governing permissions and limitations
 +# under the License.
 + Test case to check if queryAsyncJobResult returns jobinstanceid
 +
 +from nose.plugins.attrib import attr
 +from marvin.cloudstackTestCase import cloudstackTestCase
 +from marvin.lib.utils import (cleanup_resources)
 +from marvin.lib.base import (Account,
 + ServiceOffering,
 + VirtualMachine,
 + )
 +from marvin.lib.common import (get_domain,
 +   get_zone,
 +   get_template,
 +  )
 +
 +from marvin.cloudstackAPI import queryAsyncJobResult
 +
 +class TestJobinstanceid(cloudstackTestCase):
 +
 +@classmethod
 +def setUpClass(cls):
 +testClient = super(TestJobinstanceid, cls).getClsTestClient()
 +cls.apiclient = testClient.getApiClient()
 +cls.testdata = testClient.getParsedTestDataConfig()
 +
 +cls.hypervisor = cls.testClient.getHypervisorInfo()
 +# Get Zone, Domain and templates
 +cls.domain = get_domain(cls.apiclient)
 +cls.zone = get_zone(cls.apiclient,
 testClient.getZoneForTests())
 +
 +cls.template = get_template(
 +cls.apiclient,
 +cls.zone.id,
 +cls.testdata[ostype])
 +
 +cls._cleanup = []
 +
 +try:
 +
 +# Create an account
 +cls.account = Account.create(
 +cls.apiclient,
 +cls.testdata[account],
 +domainid=cls.domain.id
 +)
 +# Create user api client of the account
 +cls.userapiclient = testClient.getUserApiClient(
 +UserName=cls.account.name,
 +DomainName=cls.account.domain
 +)
 +
 +   # Create Service offering
 +cls.service_offering = ServiceOffering.create(
 +cls.apiclient,
 +cls.testdata[service_offering],
 +)
 +
 +cls._cleanup = [
 +cls.account,
 +cls.service_offering,
 +]
 +except Exception as e:
 +cls.tearDownClass()
 +raise e
 +return
 +
 +
 +@classmethod
 +def tearDownClass(cls):
 +try:
 +cleanup_resources(cls.apiclient, cls._cleanup)
 +except Exception as e:
 +raise Exception(Warning: Exception during cleanup : %s
 % e)
 +
 +def setUp(self):
 +self.apiclient = self.testClient.getApiClient()
 +self.dbclient = self.testClient.getDbConnection()
 +self.cleanup = []
 +
 +def tearDown(self):
 +try:
 +cleanup_resources(self.apiclient, self.cleanup)
 +except Exception as e:
 +raise Exception(Warning: Exception during cleanup : %s
 % e)
 +return
 +
 +@attr(tags=[advanced, basic], required_hardware=false)
 +def test_queryAsyncJobResult_jobinstanceid(self):
 + Test queryAsyncJobResult api return jobinstanceid
 +
 +# 1. Deploy a VM
 +# 2. Call queryAsyncJobResult API with jobid of previous step
 +# 3. Verify that queryAsyncJobResult returns jobinstanceid
 +
 +
 +# Step 1
 +
 --- End diff --

 Fixed pep8 issues.


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this 

[BlockerBug] VR creation fails in basic zone

2015-07-24 Thread Sanjeev N
Hi,

In latest build with ACS master, VR creation fails in basic zone.
Created a blocker bug for this. More details @
https://issues.apache.org/jira/browse/CLOUDSTACK-8668

Thanks,
Sanjeev


Re: [GitHub] cloudstack pull request: CLOUDSTACK-8634: Made changes to test_sec...

2015-07-22 Thread Sanjeev N
Can somebody please review this PR?

On Tue, Jul 14, 2015 at 5:58 PM, sanju1010 g...@git.apache.org wrote:

 GitHub user sanju1010 opened a pull request:

 https://github.com/apache/cloudstack/pull/586

 CLOUDSTACK-8634: Made changes to test_security_group.py test suite to
 support EIP


 Made changes to test_security_group.py test suite to support EIP

 1. In case of a basic zone with EIP/ELB capability vm will have two ip
 addresses one from public ip range and another one from guest ip range.
 vm creation method in base.py returns vm ip address which is part of
 guest ip range as the vm.ssh.ipaddress if we don't pass mode to it. So
 access to vms with that ip address would not be successful. Made changes to
 handle this
 2.vm public address is associated with Netscaler. So even if we don't
 allow ping traffic in security groups applied to vm, ping will be
 successful. Skipping ping test in case the zone is enabled with EIP/ELB
 3.Removing default rules from security groups except what is needed
 for that test.


 Test Results:
 ==
 Test ingress rules for specific IP set ... === TestName:
 test_ingress_rules_specific_IP_set | Status : SUCCESS ===
 ok
 Test revoke ingress rule ... === TestName: test_01_revokeIngressRule |
 Status : SUCCESS ===
 ok
 Test ingress rules for specific IP set and non default security group
 ... === TestName: test_ingress_rules_specific_IP_set_non_def_sec_group |
 Status : SUCCESS ===
 ok

 You can merge this pull request into a Git repository by running:

 $ git pull https://github.com/sanju1010/cloudstack eip

 Alternatively you can review and apply these changes as the patch at:

 https://github.com/apache/cloudstack/pull/586.patch

 To close this pull request, make a commit to your master/trunk branch
 with (at least) the following in the commit message:

 This closes #586

 
 commit 3ecf3dc172cc5f60f55d9b389d3e53a6a1e67f05
 Author: sanjeev sanj...@apache.org
 Date:   2015-07-14T11:54:58Z

 CLOUDSTACK-8634: Made changes to test_security_group.py test suite to
 support EIP

 


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...

2015-07-19 Thread Sanjeev N
LGTM

On Thu, Jul 16, 2015 at 11:34 AM, wilderrodrigues g...@git.apache.org
wrote:

 Github user wilderrodrigues commented on the pull request:

 https://github.com/apache/cloudstack/pull/590#issuecomment-121843137

 LGTM


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...

2015-07-15 Thread Sanjeev N
LGTM

On Wed, Jul 15, 2015 at 2:04 PM, pritisarap12 g...@git.apache.org wrote:

 Github user pritisarap12 commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/592#discussion_r34656988

 --- Diff: test/integration/testpaths/testpath_custom_disk_offering.py
 ---
 @@ -0,0 +1,84 @@
 +# Licensed to the Apache Software Foundation (ASF) under one
 +# or more contributor license agreements.  See the NOTICE file
 +# distributed with this work for additional information
 +# regarding copyright ownership.  The ASF licenses this file
 +# to you under the Apache License, Version 2.0 (the
 +# License); you may not use this file except in compliance
 +# with the License.  You may obtain a copy of the License at
 +#
 +#   http://www.apache.org/licenses/LICENSE-2.0
 +#
 +# Unless required by applicable law or agreed to in writing,
 +# software distributed under the License is distributed on an
 +# AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 +# KIND, either express or implied.  See the License for the
 +# specific language governing permissions and limitations
 +# under the License.
 + Test case for Create Custom DiskOffering with size Test Path
 +
 +
 +from nose.plugins.attrib import attr
 +from marvin.cloudstackTestCase import cloudstackTestCase
 +from marvin.cloudstackAPI import (createDiskOffering)
 +from marvin.lib.utils import (cleanup_resources)
 +from marvin.lib.common import (get_domain,
 +   get_zone
 +   )
 +
 +
 +class TestCustomDiskOfferingWithSize(cloudstackTestCase):
 +
 +@classmethod
 +def setUpClass(cls):
 +testClient = super(
 +TestCustomDiskOfferingWithSize,
 +cls).getClsTestClient()
 +cls.apiclient = testClient.getApiClient()
 +cls.testdata = testClient.getParsedTestDataConfig()
 +cls.hypervisor = cls.testClient.getHypervisorInfo()
 +
 +# Get Zone, Domain and templates
 +cls.domain = get_domain(cls.apiclient)
 +cls.zone = get_zone(cls.apiclient,
 testClient.getZoneForTests())
 +cls._cleanup = []
 +
 +cls.tearDownClass()
 +
 +return
 +
 +@classmethod
 +def tearDownClass(cls):
 +try:
 +cleanup_resources(cls.apiclient, cls._cleanup)
 +except Exception as e:
 +raise Exception(Warning: Exception during cleanup : %s
 % e)
 +
 +def setUp(self):
 +self.apiclient = self.testClient.getApiClient()
 +self.dbclient = self.testClient.getDbConnection()
 +self.cleanup = []
 +
 +def tearDown(self):
 +try:
 +cleanup_resources(self.apiclient, self.cleanup)
 +except Exception as e:
 +raise Exception(Warning: Exception during cleanup : %s
 % e)
 +return
 +
 +@attr(tags=[basic, advanced], required_hardware=false)
 +def test_create_custom_disk_offering_with_size(self):
 + Create custom disk offerign with size
 +1.   Create custom disk offering with size.
 +2.   Should not allow to create custom disk offering
 + with size mentioned.(Exception should be raised)
 +
 +
 +with self.assertRaises(Exception):
 --- End diff --

 Updated the testcase as per review changes.


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8637: Verify that VM with same...

2015-07-15 Thread Sanjeev N
LGTM

On Wed, Jul 15, 2015 at 3:29 PM, pritisarap12 g...@git.apache.org wrote:

 GitHub user pritisarap12 opened a pull request:

 https://github.com/apache/cloudstack/pull/594

 CLOUDSTACK-8637: Verify that VM with same Display name creation fails
 if vm.instancename.flag=true

 When vm.instancename.flag=true it will only set the instancename
 without any additional prefix so name of the instance on host will also be
 same hence verify that when tried to create another instance with same name
 on same host should fail on VMWare as it should have every instance with
 unique name.

 You can merge this pull request into a Git repository by running:

 $ git pull https://github.com/pritisarap12/cloudstack
 CLOUDSTACK-8637-Verify-that-cloudstack-gives-error-on-creation-of-VMs-with-the-same-Display-name-when-vm.instancename.flag=true

 Alternatively you can review and apply these changes as the patch at:

 https://github.com/apache/cloudstack/pull/594.patch

 To close this pull request, make a commit to your master/trunk branch
 with (at least) the following in the commit message:

 This closes #594

 
 commit a2df28d2f7f2596a121a53ee064250b62bb3b6c2
 Author: Priti Sarap priti.sa...@clogeny.com
 Date:   2015-07-15T09:46:24Z

 CLOUDSTACK-8637: Verify that VM with same Display name creation fails
 if vm.instancename.flag=true

 


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8633: Changing file permission...

2015-07-15 Thread Sanjeev N
I was trying to bring up MS with xencluster.

On Wed, Jul 15, 2015 at 4:10 PM, pvr9712 g...@git.apache.org wrote:

 Github user pvr9712 commented on the pull request:

 https://github.com/apache/cloudstack/pull/591#issuecomment-121571026

 BTW, here is my email on the Dev list with the details for this issues
 - including the earlier commit - Using Master builds, MS logs shows
 following error -

 management-server.log:org.springframework.context.ApplicationContextException:
 Failed to start bean 'cloudStackLifeCycle'; nested exception is
 com.cloud.utils.exception.CloudRuntimeException: Failed to inject generated
 public key into systemvm iso sudo: /etc/sudoers.d/cloudstack-management is
 mode 0755, should be 0440sudo: sorry, you must have a tty to run sudo

 After modifying the permissions - MS works fine.

 Apparently, this is related to a checkin ...
 commit 870e1898eb28039fafaaeb8e50a7039f626f912c

 https://github.com/apache/cloudstack/commit/870e1898eb28039fafaaeb8e50a7039f626f912c

 I have created a defect, CLOUDSTACK-8633
 https://issues.apache.org/jira/browse/CLOUDSTACK-8633, to track this




 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8556: Unable to delete attache...

2015-07-14 Thread Sanjeev N
You are right Wido. It is only a test case change to handle volume cleanup.

On Tue, Jul 14, 2015 at 11:43 AM, wido g...@git.apache.org wrote:

 Github user wido commented on the pull request:

 https://github.com/apache/cloudstack/pull/481#issuecomment-121140868

 The description of the pull request isn't really specific. Looking at
 the files changed it is only a test case which changed, right? No CS code
 itself.


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: Newb

2015-07-14 Thread Sanjeev N
LGTM!!

On Tue, Jul 14, 2015 at 11:47 AM, pavanb018 g...@git.apache.org wrote:

 GitHub user pavanb018 opened a pull request:

 https://github.com/apache/cloudstack/pull/581

 Newb

 Test Create/Delete a LB rule and verify correct usage is recorded ...
 === TestName: test_01_lb_usage | Status : SUCCESS ===
 ok

 --
 Ran 1 test in 50.564s

 OK


 You can merge this pull request into a Git repository by running:

 $ git pull https://github.com/pavanb018/cloudstack newb

 Alternatively you can review and apply these changes as the patch at:

 https://github.com/apache/cloudstack/pull/581.patch

 To close this pull request, make a commit to your master/trunk branch
 with (at least) the following in the commit message:

 This closes #581

 
 commit 6f91392e9c037d542d0150cbf1d12501e9d9ba45
 Author: pavan018 pavanbandarupa...@gmail.com
 Date:   2015-07-13T12:41:24Z

 Passing firewal service parameter for LB rule creation

 commit df7646af01828cb9ea471e8efcfff9e5d4156437
 Author: pavan018 pavanbandarupa...@gmail.com
 Date:   2015-07-14T06:14:04Z

 Firewall service parameter addition typos

 


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

2015-07-14 Thread Sanjeev N
LGTM!!

On Tue, Jul 14, 2015 at 5:08 PM, DaanHoogland g...@git.apache.org wrote:

 Github user DaanHoogland commented on the pull request:

 https://github.com/apache/cloudstack/pull/585#issuecomment-121211124

 I agree with Sanju. please ammend to something like
 CLOUDSTACK-8631: changing if condition to update to zero when needed


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8626 :[Automation]fixing test/...

2015-07-13 Thread Sanjeev N
LGTM

On Mon, Jul 13, 2015 at 11:02 AM, nitt10prashant g...@git.apache.org wrote:

 GitHub user nitt10prashant opened a pull request:

 https://github.com/apache/cloudstack/pull/579

 CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_p…

 …s_max_limits.py for lxc hypervisor

 test results
 
 Test Try to deploy VM with admin account where account has used ...
 === TestName: test_02_deploy_vm_account_limit_reached | Status : SUCCESS ===
 ok
 Test TTry to deploy VM with admin account where account has not used
 ... === TestName: test_03_deploy_vm_project_limit_reached | Status :
 SUCCESS ===
 ok

 --
 Ran 2 tests in 579.271s

 OK


 You can merge this pull request into a Git repository by running:

 $ git pull https://github.com/nitt10prashant/cloudstack ps_mx_limits

 Alternatively you can review and apply these changes as the patch at:

 https://github.com/apache/cloudstack/pull/579.patch

 To close this pull request, make a commit to your master/trunk branch
 with (at least) the following in the commit message:

 This closes #579

 
 commit 85235d89dfa66c675b964ceebbb49a61c1205f8b
 Author: nitt10prashant nitt10.prash...@gmail.com
 Date:   2015-07-13T05:31:11Z

 CLOUDSTACK-8626 :[Automation]fixing
 test/integration/component/test_ps_max_limits.py for lxc hypervisor

 


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...

2015-07-09 Thread Sanjeev N
LGTM!! I am taking this patch.

On Thu, Jul 9, 2015 at 3:25 PM, pavanb018 g...@git.apache.org wrote:

 Github user pavanb018 commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/569#discussion_r34239937

 --- Diff: test/integration/component/test_blocker_bugs.py ---
 @@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self):
  #all it's services should resume

  # Find router associated with user account
 -list_router_response = list_routers(
 --- End diff --

 We already have the list_routers as wrapper function on top of the api
 building. This function serves basic and advanced zone depending upon the
 passed arguments. Hence the same is called depending on the network type
 check. Adding another function with network type as a parameter might just
 be another wrapper that internally calls list_routers again.


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)

2015-07-08 Thread Sanjeev N
I thought there is a limitation on LGTMs for integration tests?

On Wed, Jul 8, 2015 at 5:11 PM, Daan Hoogland daan.hoogl...@gmail.com
wrote:

 guys and dolss,

 this was closed with only 1 LGTM! we agreed not to submit with less
 then two ok reviews on master. So next steps? revert? some extra
 justification or else revert? .

 On Wed, Jul 8, 2015 at 12:39 PM, asfgit g...@git.apache.org wrote:
  Github user asfgit closed the pull request at:
 
  https://github.com/apache/cloudstack/pull/567
 
 
  ---
  If your project is set up for it, you can reply to this email and have
 your
  reply appear on GitHub as well. If your project does not have this
 feature
  enabled and wishes so, or if the feature is enabled but not working,
 please
  contact infrastructure at infrastruct...@apache.org or file a JIRA
 ticket
  with INFRA.
  ---



 --
 Daan



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8582: Skipping unsuitable test...

2015-07-02 Thread Sanjeev N
if required_hardware=false means these tests can run on Simulator.

On Thu, Jul 2, 2015 at 3:06 PM, runseb g...@git.apache.org wrote:

 Github user runseb commented on the pull request:

 https://github.com/apache/cloudstack/pull/532#issuecomment-117977659

 @gauravaradhye if you answer my questions I can give a LGTM :)


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8577: fixing script testpath_d...

2015-06-23 Thread Sanjeev N
LGTM. I am taking this patch.

On Mon, Jun 22, 2015 at 6:26 PM, nitt10prashant g...@git.apache.org wrote:

 GitHub user nitt10prashant opened a pull request:

 https://github.com/apache/cloudstack/pull/507

 CLOUDSTACK-8577: fixing script  testpath_disable_enable_zone

 disable enable cluster ... === TestName:
 test_01_disable_enable_cluster | Status : SUCCESS ===
 ok
 disable enable host ... === TestName: test_01_disable_enable_host |
 Status : SUCCESS ===
 ok
 disable enable Pod ... === TestName: test_01_disable_enable_pod |
 Status : SUCCESS ===
 ok
 disable enable zone ... === TestName: test_01_disable_enable_zone |
 Status : SUCCESS ===
 ok

 --
 Ran 4 tests in 2818.119s

 OK

 You can merge this pull request into a Git repository by running:

 $ git pull https://github.com/nitt10prashant/cloudstack enable_zone

 Alternatively you can review and apply these changes as the patch at:

 https://github.com/apache/cloudstack/pull/507.patch

 To close this pull request, make a commit to your master/trunk branch
 with (at least) the following in the commit message:

 This closes #507

 
 commit 4554ae7eb793ad1a519e5b96d938f380218a18fa
 Author: nitt10prashant nitt10.prash...@gmail.com
 Date:   2015-06-22T12:55:39Z

 CLOUDSTACK-8577: fixing script  testpath_disable_enable_zone

 


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8576: Skip tests for LXC

2015-06-22 Thread Sanjeev N
Please ignore my comment. I confirmed with Kishan and he said template
creation from volume is not supported in LXC.

On Mon, Jun 22, 2015 at 5:45 PM, sanju1010 g...@git.apache.org wrote:

 Github user sanju1010 commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/506#discussion_r32927724

 --- Diff: test/integration/component/test_resource_limits.py ---
 @@ -748,6 +748,8 @@ def test_05_templates_per_account(self):
  #should be denied to create more than 1 template.
  # 3. Try to create 2 templates in account 2. Verify account 2
 should be
  #able to create template without any error
 +if self.hypervisor.lower() in ['lxc']:
 --- End diff --

 I think template creation from volume is supported in lxc.


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: [GitHub] cloudstack pull request: CLOUDSTACK-8572:Unable to deploy VM as no...

2015-06-19 Thread Sanjeev N
Agree with Gaurav,
We should look at the tests which are changing the storage pool status. We
should make sure that those tests turn the status back to UP.

-Sanjeev

On Fri, Jun 19, 2015 at 1:05 PM, gauravaradhye g...@git.apache.org wrote:

 Github user gauravaradhye commented on a diff in the pull request:

 https://github.com/apache/cloudstack/pull/480#discussion_r32807101

 --- Diff: test/integration/testpaths/testpath_vmlc.py ---
 @@ -176,6 +176,19 @@ def setUpClass(cls):
  cls.zone = get_zone(cls.apiclient)
  cls._cleanup = []

 +cls.skiptest = False
 --- End diff --

 There is no need for these checks. Instead the tests which leave the
 storage pool in disabled state should be looked at. Hold it for now.


 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---



Re: Swift storage

2015-05-29 Thread Sanjeev N
No issues with S3 provider.

On Fri, May 29, 2015 at 12:48 PM, Andrija Panic andrija.pa...@gmail.com
wrote:

 auth v1, old libraries, lot's of limitations (cant extract/download
 ISO/template from ACS, dont see if register/download of ISO/template from
 URL has started at all - no progress percentage, etc). Problems deleting
 any ISO/template from GUI (at the moment, zoneid is or is not sent, in
 contrast what it should be - also try for S3 - any region wide SS, afaik)

 MGMT server mounts Secondary Storage on itself, and downloads systemVM
 template from database records (so systemVM from download.cloud.com) - so
 there is no preseed of systemVM template manually.

 S3 interface (Swift can provide S3 support) seems to be working much better
 - but we are still to test it all later...

 :)





 On 29 May 2015 at 08:09, prapul cool prapul_cool2...@yahoo.com.invalid
 wrote:

  Hi,
  Has  any one added swift as secondary storage in cloudstack, if yes
  please share the instructions for it.
 How do we seed systemvm template in this case?
  Thanks,Prapul sriram,PSI cloud solutions.




 --

 Andrija Panić



Re: Swift storage

2015-05-29 Thread Sanjeev N
yes all the existing nfs storages will be converted to staging storage
after migrating from nfs to s3.

On Fri, May 29, 2015 at 2:50 PM, Andrija Panic andrija.pa...@gmail.com
wrote:

 Nice to hear that :)

 Sanjeev, is migration api supported if we use 2 nfs boxes now for secondary
 storage or if it must be only 1 nfs box(that will ve converted to staging
 store)?
 Thx
 On May 29, 2015 11:02 AM, Sanjeev N sanj...@apache.org wrote:

  No issues with S3 provider.
 
  On Fri, May 29, 2015 at 12:48 PM, Andrija Panic andrija.pa...@gmail.com
 
  wrote:
 
   auth v1, old libraries, lot's of limitations (cant extract/download
   ISO/template from ACS, dont see if register/download of ISO/template
 from
   URL has started at all - no progress percentage, etc). Problems
 deleting
   any ISO/template from GUI (at the moment, zoneid is or is not sent, in
   contrast what it should be - also try for S3 - any region wide SS,
 afaik)
  
   MGMT server mounts Secondary Storage on itself, and downloads systemVM
   template from database records (so systemVM from download.cloud.com) -
  so
   there is no preseed of systemVM template manually.
  
   S3 interface (Swift can provide S3 support) seems to be working much
  better
   - but we are still to test it all later...
  
   :)
  
  
  
  
  
   On 29 May 2015 at 08:09, prapul cool prapul_cool2...@yahoo.com.invalid
 
   wrote:
  
Hi,
Has  any one added swift as secondary storage in cloudstack, if
 yes
please share the instructions for it.
   How do we seed systemvm template in this case?
Thanks,Prapul sriram,PSI cloud solutions.
  
  
  
  
   --
  
   Andrija Panić
  
 



Re: support for /31 Networks

2015-05-22 Thread Sanjeev N
Not sure when this check was added excatly :(

On Fri, May 22, 2015 at 1:12 AM, Remi Bergsma rberg...@schubergphilis.com
wrote:

 Exactly!
 Left my mail in outbox and missed your reply ;-)

 @Sanjeev, since you answered the original mail.. Do you know when/where
 this check was added? Or else I’ll search for it. Let’s open an issue and
 resolve it.

 Thanks,
 Remi

  On 21 May 2015, at 19:28, Simon Weller swel...@ena.com wrote:
 
  You can assigned the network address as a valid ip address from a /31,
 and this is defined in RFC 3021 (http://www.ietf.org/rfc/rfc3021.txt).
 
  This is widely supported on network gear, and in modern operating
 systems.
 
  - Si
 
  
  From: Remi Bergsma r...@remi.nl
  Sent: Thursday, May 21, 2015 10:31 AM
  To: dev@cloudstack.apache.org
  Subject: Re: support for /31 Networks
 
  Hi,
 
  This question was answered here as well:
  http://markmail.org/message/m7vi342uwm4zr5iv
 
  Support was removed as /31 has no available ip addresses.
 
  Regards,
  Remi
 
  2015-05-21 16:42 GMT+02:00 Ian Southam isout...@schubergphilis.com:
 
  Hi Devender,
 
  You have started quite a discussion in our office about using the .0 and
  putting a host on the cast address …...
 
  Just as a matter of interest, why do you do this - we are presuming it
  does actually work ;)
 
  —
  Grts!
  Ian
 
  On 21 May 2015, at 10:29, Singh, Devender dsi...@virtela.net wrote:
 
  Hi Cloudstack Team,
 
 
  We had no problems building and using /31 networks on 4.2.0, but after
  our upgrade to 4.4.2  we are no longer able to add new ones.
  We have a lot of them already in place.  As an example I pasted some
  output from cloudmonkey on a link that is already established and
 working.
  Does anyone have a workaround, or can point me in the right direction
  for a patch?
  (local)  list networks id=e044c442-48f7-4bae-8c5d-530423a249f7
  count = 1
  network:
  id = e044c442-48f7-4bae-8c5d-530423a249f7
  name = VLAN180
  acltype = Domain
  broadcastdomaintype = Vlan
  broadcasturi = vlan://180
  canusefordeploy = False
  cidr = 202.90.43.0/31
  displaynetwork = True
  displaytext = VM-UTILITY-2
  dns1 = 4.2.2.1
  domain = ROOT
  domainid = 8acf0368-e5b1-11e2-b5cf-2ef4cf18a6ae
  gateway = 202.90.43.0
  ispersistent = False
  issystem = False
  netmask = 255.255.255.254
  networkofferingavailability = Optional
  networkofferingconservemode = False
  networkofferingdisplaytext = private-guest1_switch
  networkofferingid = 0b63d457-5f5e-426f-a81e-8797e522eb8c
  networkofferingname = private-guest1_switch
  physicalnetworkid = cf4c2846-2418-4ba4-b307-6a6405860799
  related = e044c442-48f7-4bae-8c5d-530423a249f7
  restartrequired = False
  service:
  specifyipranges = True
  state = Setup
  strechedl2subnet = False
  subdomainaccess = True
  tags:
  traffictype = Guest
  type = Shared
  vlan = 180
  zoneid = 88066cb4-64ab-4c54-83a9-3279a1e030cb
  zonename = UTILITY-ZONE-1
 
  (local)  list nics nicid=e062922f-c0ea-4f8a-beca-b86146dee622
  virtualmachineid=842054e6-c379-49fe-92f9-e2fdefa6779f
  count = 1
  nic:
  id = e062922f-c0ea-4f8a-beca-b86146dee622
  deviceid = 0
  gateway = 202.90.43.0
  ipaddress = 202.90.43.1
  isdefault = True
  macaddress = 06:ca:b4:00:00:20
  netmask = 255.255.255.254
  networkid = e044c442-48f7-4bae-8c5d-530423a249f7
  virtualmachineid = 842054e6-c379-49fe-92f9-e2fdefa6779f
  (local) 
 
  Devender Kumar Singh
 
 




Re: FW: Support for /31 Networks on cloudstack 4.4.2

2015-05-14 Thread Sanjeev N
Hi Devender,

IIRC some changes have been made in this area in recent releases. So first
ip address in the cidr would not be treated as valid ip address for
assignment since it is a network id. So /31 would not have sufficient ips
to deploy vm.

Thanks,
Sanjeev

On Thu, May 14, 2015 at 10:15 PM, Singh, Devender dsi...@virtela.net
wrote:

 Hello,

 We had no problems building and using /31 networks on 4.2.0, but after our
 upgrade to 4.4.2 we are no longer able to add new ones.
 We have a lot of them already in place.  As an example I pasted some
 output from cloudmonkey on a link that is already established and working.
 Does anyone have a workaround, or can point me in the right direction for
 a patch?
 (local)  list networks id=e044c442-48f7-4bae-8c5d-530423a249f7
 count = 1
 network:
 id = e044c442-48f7-4bae-8c5d-530423a249f7
 name = VLAN180
 acltype = Domain
 broadcastdomaintype = Vlan
 broadcasturi = vlan://180
 canusefordeploy = False
 cidr = 202.90.43.0/31
 displaynetwork = True
 displaytext = VM-UTILITY-2
 dns1 = 4.2.2.1
 domain = ROOT
 domainid = 8acf0368-e5b1-11e2-b5cf-2ef4cf18a6ae
 gateway = 202.90.43.0
 ispersistent = False
 issystem = False
 netmask = 255.255.255.254
 networkofferingavailability = Optional
 networkofferingconservemode = False
 networkofferingdisplaytext = private-guest1_switch
 networkofferingid = 0b63d457-5f5e-426f-a81e-8797e522eb8c
 networkofferingname = private-guest1_switch
 physicalnetworkid = cf4c2846-2418-4ba4-b307-6a6405860799
 related = e044c442-48f7-4bae-8c5d-530423a249f7
 restartrequired = False
 service:
 specifyipranges = True
 state = Setup
 strechedl2subnet = False
 subdomainaccess = True
 tags:
 traffictype = Guest
 type = Shared
 vlan = 180
 zoneid = 88066cb4-64ab-4c54-83a9-3279a1e030cb
 zonename = UTILITY-ZONE-1

 (local)  list nics nicid=e062922f-c0ea-4f8a-beca-b86146dee622
 virtualmachineid=842054e6-c379-49fe-92f9-e2fdefa6779f
 count = 1
 nic:
 id = e062922f-c0ea-4f8a-beca-b86146dee622
 deviceid = 0
 gateway = 202.90.43.0
 ipaddress = 202.90.43.1
 isdefault = True
 macaddress = 06:ca:b4:00:00:20
 netmask = 255.255.255.254
 networkid = e044c442-48f7-4bae-8c5d-530423a249f7
 virtualmachineid = 842054e6-c379-49fe-92f9-e2fdefa6779f
 (local) 

 Thanks and Regards,
 Devender Kumar Singh




Re: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye

2015-04-13 Thread Sanjeev N
Congrats Gaurav!!

On Tue, Apr 14, 2015 at 9:34 AM, Jayapal Reddy Uradi 
jayapalreddy.ur...@citrix.com wrote:

 Congrats Gaurav!

 -Jayapal

 On 14-Apr-2015, at 9:10 AM, Rajani Karuturi raj...@apache.org
  wrote:

  congratulations Gaurav..
 
  ~Rajani
 
  On Tue, Apr 14, 2015 at 1:35 AM, Erik Weber terbol...@gmail.com wrote:
 
  On Mon, Apr 13, 2015 at 9:43 PM, Daan Hoogland daan.hoogl...@gmail.com
 
  wrote:
 
  The Project Management Committee (PMC) for Apache CloudStack
  has asked Gaurav Aradhya to become a committer and we are pleased to
  announce that they have accepted.
 
  Being a committer allows many contributors to contribute more
  autonomously. For developers, it makes it easier to submit changes and
  eliminates the need to have contributions reviewed via the patch
  submission process. Whether contributions are development-related or
  otherwise, it is a recognition of a contributor's participation in the
  project and commitment to the project and the Apache Way.
 
  Please join me in congratulating Gaurav
 
 
  Well deserved, welcome!
  Congratulations :-)
 
  --
  Erik
 




Re: Migrating to VPC/Site-to-Site VPN

2015-04-02 Thread Sanjeev N
It is not possible to add existing network/VR to a VPC.

On Wed, Apr 1, 2015 at 8:03 PM, Logan Barfield lbarfi...@tqhosting.com
wrote:

 That's what I figured.  We were hoping to be able to set up
 site-to-site VPN on the existing network.  If a VPC is just a supernet
 to multiple virtual routers it seems like it would be feasible to
 seamlessly add an existing network/VR to a VPC.

 Since this isn't possible now I guess opening a feature request for it
 would be good, in case we run into a similar issue next year.  Before
 I do, does anyone know if this is technically possible, just not yet
 coded?  In other words, could I theoretically add an existing isolated
 network/VR to a VPC seamlessly via updating the database or manually
 changing something on the VR?  If so I would think adding the code to
 handle that task would be relatively easy.

 Thank You,

 Logan Barfield
 Tranquil Hosting


 On Wed, Apr 1, 2015 at 3:20 AM, Sanjeev N sanj...@apache.org wrote:
  As Erik mentioned, we can add nic from VPC network to existing vms so the
  vms will be in both isolated(non-vpc) and vpc networks.
 
  On Wed, Apr 1, 2015 at 11:56 AM, Erik Weber terbol...@gmail.com wrote:
 
  Haven't tried it myself, but i think you should be able to create the
 vpc
  and change nic on VMs.
 
  If you want to keep the ip addresses you might have to use the api
 
  Erik
 
  Den onsdag 1. april 2015 skrev Logan Barfield lbarfi...@tqhosting.com
  følgende:
 
   We have a customer that is currently set up in an isolated network in
   an advanced zone.  They recently mentioned that they have a need for
   site-to-site VPN connectivity for their application.
  
   Is it possible to move an existing isolated network into a VPC for
   site-to-site VPN functionality?  Or is there another way to set up a
   site-to-site VPN using the existing network?
  
  
   Thank You,
  
   Logan Barfield
   Tranquil Hosting
  
 



Re: Migrating to VPC/Site-to-Site VPN

2015-04-01 Thread Sanjeev N
As Erik mentioned, we can add nic from VPC network to existing vms so the
vms will be in both isolated(non-vpc) and vpc networks.

On Wed, Apr 1, 2015 at 11:56 AM, Erik Weber terbol...@gmail.com wrote:

 Haven't tried it myself, but i think you should be able to create the vpc
 and change nic on VMs.

 If you want to keep the ip addresses you might have to use the api

 Erik

 Den onsdag 1. april 2015 skrev Logan Barfield lbarfi...@tqhosting.com
 følgende:

  We have a customer that is currently set up in an isolated network in
  an advanced zone.  They recently mentioned that they have a need for
  site-to-site VPN connectivity for their application.
 
  Is it possible to move an existing isolated network into a VPC for
  site-to-site VPN functionality?  Or is there another way to set up a
  site-to-site VPN using the existing network?
 
 
  Thank You,
 
  Logan Barfield
  Tranquil Hosting
 



Re: [DISCUSS] Stop using Review Board

2015-03-30 Thread Sanjeev N
+1

On Mon, Mar 30, 2015 at 3:58 PM, Raja Pullela raja.pull...@citrix.com
wrote:

 +1 for GitHub...

 Some of us are already using GH and any new review requests on RB,
 reviewers should ask for the owners to post them to GH.
 Otherwise, there is no easy way to stop people from using RB ?

 -Original Message-
 From: Sebastien Goasguen [mailto:run...@gmail.com]
 Sent: Monday, March 30, 2015 12:52 PM
 To: dev@cloudstack.apache.org
 Subject: Re: [DISCUSS] Stop using Review Board


  On Mar 30, 2015, at 7:39 AM, Kishan Kavala kishan.kav...@citrix.com
 wrote:
 
  +1 for GitHub
 
  Can we do a one-time migration of all open RB requests to GH and make RB
 read-only?
 

 I don’t think we can do an automatic migration. We should all check RB in
 the coming days, try to close the one we can and contact the authors we
 know.

 I would like to keep this DISCUSS open till next friday, since it’s a
 relatively big change. At that time, I will check with infra if we can make
 RB read only.


  -Original Message-
  From: Rajani Karuturi [mailto:raj...@apache.org]
  Sent: Monday, March 30, 2015 10:33 AM
  To: dev@cloudstack.apache.org
  Subject: Re: [DISCUSS] Stop using Review Board
 
  +1
 
  ~Rajani
 
  On Fri, Mar 27, 2015 at 9:00 PM, Mike Tutkowski 
 mike.tutkow...@solidfire.com wrote:
 
  +1
 
  On Fri, Mar 27, 2015 at 2:52 AM, Sebastien Goasguen
  run...@gmail.com
  wrote:
 
  Hi everyone,
 
  Since GitHub pull requests have been enabled for cloudstack, we have
  closed 127 commits.
 
  I believe this is a nicer interface, one that folks are used to when
  contributing to other open source projects.
 
  In the meantime, we still have 73 open reviews on Review Board
 
  https://reviews.apache.org/
 
  * I propose that we stop using RB all together, and remove any links
  to
  it
  from our website and README.
 
  A few of us have tried to close some of the reviews by pinging the
  authors
  already.
 
  * My second proposition is that we write a comment in all reviews:
 
  “Thanks for the patch, the cloudstack community has decided to stop
  using Review Board in favor of github pull request.
  You can see link to learn how to submit a pull request to cloudstack.
  Could you move your patch to a PR ?
  Without response from you we will close this review within 7 days.
  
 
  There is good contribution guidelines in our docs README:
  https://github.com/apache/cloudstack-docs
 
  -Sebastien
 
 
 
 
  --
  *Mike Tutkowski*
  *Senior CloudStack Developer, SolidFire Inc.*
  e: mike.tutkow...@solidfire.com
  o: 303.746.7302
  Advancing the way the world uses the cloud
  http://solidfire.com/solution/overview/?video=play*™*
 




Re: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack

2015-03-27 Thread Sanjeev N
Congrats Rohit!!

On Fri, Mar 27, 2015 at 2:06 PM, Jayapal Reddy Uradi 
jayapalreddy.ur...@citrix.com wrote:

 Congrats Bhaisaab :)

 On 27-Mar-2015, at 2:01 PM, Funs Kessen f...@barred.org wrote:

  Congrats Rohit, awesome!
 
  On 27 Mar 2015, at 09:20, Remi Bergsma rberg...@schubergphilis.com
 wrote:
 
  Congratz Rohit, well deserved! :-)
 
  Sent from my iPhone
 
  On 27 Mar 2015, at 09:08, Sebastien Goasguen run...@gmail.com wrote:
 
  The Project Management Committee (PMC) for Apache CloudStack are
 pleased to
  announce that Rohit Yadav has accepted our invitation to join the PMC.
 
  Please join me in congratulating him.
 
  On behalf of the Apache CloudStack PMC
 
 
  —
=Funs
 




Review Request 31476: If password is defined in vm response then skip password assignement

2015-02-25 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31476/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

If password is defined in vm response then skip password assignement


Diffs
-

  tools/marvin/marvin/lib/base.py 7443373 

Diff: https://reviews.apache.org/r/31476/diff/


Testing
---

Yes


Thanks,

sanjeev n



Review Request 31189: skip password assignment from services

2015-02-19 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31189/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

If self.password is available skip password assignement from test data


Diffs
-

  tools/marvin/marvin/lib/base.py 7443373 

Diff: https://reviews.apache.org/r/31189/diff/


Testing
---

yes


Thanks,

sanjeev n



Re: Review Request 30611: Before throwing exception for iso download try one more time

2015-02-15 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30611/
---

(Updated Feb. 16, 2015, 6:47 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Before throwing exception for iso download try one more time


Diffs
-

  tools/marvin/marvin/lib/base.py e38c394 

Diff: https://reviews.apache.org/r/30611/diff/


Testing
---

Yes


Thanks,

sanjeev n



Review Request 30611: Before throwing exception for iso download try one more time

2015-02-04 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30611/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Before throwing exception for iso download try one more time


Diffs
-

  tools/marvin/marvin/lib/base.py e38c394 

Diff: https://reviews.apache.org/r/30611/diff/


Testing
---

Yes


Thanks,

sanjeev n



Re: Review Request 30067: CLOUDSTACK-8170: Skipping tests on HyperV which try to scale VM in running state because feature not supported

2015-01-22 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30067/#review69162
---

Ship it!


Ship It!

- sanjeev n


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30067/
 ---
 
 (Updated Jan. 22, 2015, 5:29 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8170
 https://issues.apache.org/jira/browse/CLOUDSTACK-8170
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Skipping tests on HyperV because scaling VM in running state is not supported.
 
 
 Diffs
 -
 
   test/integration/component/test_dynamic_compute_offering.py 5215f84 
 
 Diff: https://reviews.apache.org/r/30067/diff/
 
 
 Testing
 ---
 
 Yes.
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 30067: CLOUDSTACK-8170: Skipping tests on HyperV which try to scale VM in running state because feature not supported

2015-01-22 Thread sanjeev n


 On Jan. 22, 2015, 11:09 a.m., sanjeev n wrote:
  Ship It!

commit d37c1589bea8a02c9dd8c17254b96d9fb01d70b3
Author: Gaurav Aradhye gaurav.arad...@clogeny.com
Date:   Tue Jan 20 16:18:08 2015 +0530

CLOUDSTACK-8170: Skipping tests on HyperV which try to scale VM in running 
state because feature not supported


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30067/#review69162
---


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30067/
 ---
 
 (Updated Jan. 22, 2015, 5:29 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8170
 https://issues.apache.org/jira/browse/CLOUDSTACK-8170
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Skipping tests on HyperV because scaling VM in running state is not supported.
 
 
 Diffs
 -
 
   test/integration/component/test_dynamic_compute_offering.py 5215f84 
 
 Diff: https://reviews.apache.org/r/30067/diff/
 
 
 Testing
 ---
 
 Yes.
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

2015-01-22 Thread sanjeev n


 On Jan. 22, 2015, 11:22 a.m., sanjeev n wrote:
  Ship It!

commit 2db5ee3c0a5d40cdc4d5de60b2f8f3afca32e57f
Author: Gaurav Aradhye gaurav.arad...@clogeny.com
Date:   Tue Jan 13 13:56:41 2015 +0530

CLOUDSTACK-8152: Adding delay before creating snapshot/template from root 
disk after writing data to disk - test_vm_passwordenabled.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/#review69164
---


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29845/
 ---
 
 (Updated Jan. 22, 2015, 5:29 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8152
 https://issues.apache.org/jira/browse/CLOUDSTACK-8152
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Due to timing issue, sometimes data gets lost if snapshot/template is created 
 from root volume immediately after writing data to disk. Add delay to bypass 
 this issue.
 
 
 Diffs
 -
 
   test/integration/component/test_vm_passwdenabled.py d998ed5 
 
 Diff: https://reviews.apache.org/r/29845/diff/
 
 
 Testing
 ---
 
 Test get VM password for password enabled template ... === TestName: 
 test_11_get_vm_password | Status : SUCCESS ===
 ok
 
 --
 Ran 1 test in 751.495s
 
 OK
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 29845: CLOUDSTACK-8152: Adding delay before creating snapshot/template from root disk after writing data to disk - test_vm_passwordenabled.py

2015-01-22 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29845/#review69164
---

Ship it!


Ship It!

- sanjeev n


On Jan. 22, 2015, 5:29 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29845/
 ---
 
 (Updated Jan. 22, 2015, 5:29 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8152
 https://issues.apache.org/jira/browse/CLOUDSTACK-8152
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Due to timing issue, sometimes data gets lost if snapshot/template is created 
 from root volume immediately after writing data to disk. Add delay to bypass 
 this issue.
 
 
 Diffs
 -
 
   test/integration/component/test_vm_passwdenabled.py d998ed5 
 
 Diff: https://reviews.apache.org/r/29845/diff/
 
 
 Testing
 ---
 
 Test get VM password for password enabled template ... === TestName: 
 test_11_get_vm_password | Status : SUCCESS ===
 ok
 
 --
 Ran 1 test in 751.495s
 
 OK
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 30157: CLOUDSTACK-8174: Fixed network delete issue in test_add_remove_network.py

2015-01-22 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30157/#review69147
---

Ship it!


Ship It!

- sanjeev n


On Jan. 22, 2015, 7:03 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30157/
 ---
 
 (Updated Jan. 22, 2015, 7:03 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8174
 https://issues.apache.org/jira/browse/CLOUDSTACK-8174
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The test case failed while cleaning up the network.
 The network will be cleaned up as part of account cleanup, no need to add it 
 separately to the cleanup list.
 
 
 Diffs
 -
 
   test/integration/component/test_add_remove_network.py 2f685b5 
 
 Diff: https://reviews.apache.org/r/30157/diff/
 
 
 Testing
 ---
 
 Yes.
 
 LOg:
 Add network to vm with wrong vm id ... === TestName: 
 test_15_add_nic_wrong_vm_id | Status : SUCCESS ===
 ok
 Add network to vm with wrong network id ... === TestName: 
 test_16_add_nic_wrong_network_id | Status : SUCCESS ===
 ok
 Add network to vm where both belong to different zones ... === TestName: 
 test_17_add_nic_different_zone | Status : SUCCESS ===
 ok
 Add network to vm in basic zone ... SKIP: This test requires at least one 
 basic zone to be present in the setup
 Try to add network to vm with insufficient permission ... === TestName: 
 test_26_add_nic_insufficient_permission | Status : SUCCESS ===
 ok
 
 --
 Ran 5 tests in 285.485s
 
 OK (SKIP=1)
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 30157: CLOUDSTACK-8174: Fixed network delete issue in test_add_remove_network.py

2015-01-22 Thread sanjeev n


 On Jan. 22, 2015, 8:49 a.m., sanjeev n wrote:
  Ship It!

commit 8894fc897b9e6d20efda6f18f7e9178fa63e87a6
Author: Gaurav Aradhye gaurav.arad...@clogeny.com
Date:   Wed Jan 21 22:31:24 2015 -0800

CLOUDSTACK-8174: Fixed cleanup issue in test_add_remove_network.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30157/#review69147
---


On Jan. 22, 2015, 7:03 a.m., Gaurav Aradhye wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30157/
 ---
 
 (Updated Jan. 22, 2015, 7:03 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8174
 https://issues.apache.org/jira/browse/CLOUDSTACK-8174
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The test case failed while cleaning up the network.
 The network will be cleaned up as part of account cleanup, no need to add it 
 separately to the cleanup list.
 
 
 Diffs
 -
 
   test/integration/component/test_add_remove_network.py 2f685b5 
 
 Diff: https://reviews.apache.org/r/30157/diff/
 
 
 Testing
 ---
 
 Yes.
 
 LOg:
 Add network to vm with wrong vm id ... === TestName: 
 test_15_add_nic_wrong_vm_id | Status : SUCCESS ===
 ok
 Add network to vm with wrong network id ... === TestName: 
 test_16_add_nic_wrong_network_id | Status : SUCCESS ===
 ok
 Add network to vm where both belong to different zones ... === TestName: 
 test_17_add_nic_different_zone | Status : SUCCESS ===
 ok
 Add network to vm in basic zone ... SKIP: This test requires at least one 
 basic zone to be present in the setup
 Try to add network to vm with insufficient permission ... === TestName: 
 test_26_add_nic_insufficient_permission | Status : SUCCESS ===
 ok
 
 --
 Ran 5 tests in 285.485s
 
 OK (SKIP=1)
 
 
 Thanks,
 
 Gaurav Aradhye
 




Re: Review Request 29620: CLOUDSTACK-8143: Corrected a test in BVT test_routers.py

2015-01-13 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29620/#review67838
---

Ship it!


Ship It!

- sanjeev n


On Jan. 6, 2015, 7:37 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29620/
 ---
 
 (Updated Jan. 6, 2015, 7:37 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8143
 https://issues.apache.org/jira/browse/CLOUDSTACK-8143
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The test case test_03_restart_network_cleanup is restarting the network with 
 cleanup=True and verifying that the linklocalip of the new router should be 
 different than the linklocalip of the old router.
 
 However this may not be true as the linklocalip is assigned randomly and 
 hence can be same for the new router.
 
 The test case should instead check that the publicip of the new router should 
 be the same as publicip of the old router.
 
 
 Diffs
 -
 
   test/integration/smoke/test_routers.py 7d5f267 
 
 Diff: https://reviews.apache.org/r/29620/diff/
 
 
 Testing
 ---
 
 Test router internal basic zone ... SKIP: Skip
 Test router internal advanced zone ... SKIP: Skip
 Test restart network ... === TestName: test_03_restart_network_cleanup | 
 Status : SUCCESS ===
 ok
 Test restart network without cleanup ... SKIP: Skip
 Test router basic setup ... SKIP: Skip
 Test router advanced setup ... SKIP: Skip
 Test stop router ... SKIP: Skip
 Test start router ... SKIP: Skip
 Test reboot router ... SKIP: Skip
 
 --
 Ran 9 tests in 231.829s
 
 OK (SKIP=8)
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Re: Review Request 29620: CLOUDSTACK-8143: Corrected a test in BVT test_routers.py

2015-01-13 Thread sanjeev n


 On Jan. 13, 2015, 11:10 a.m., sanjeev n wrote:
  Ship It!

commit 9f55411295c9abc843a49f226691a6b720fb0c07
Author: Ashutosh K ashut...@clogeny.com
Date:   Tue Jan 6 12:54:49 2015 +0530

CLOUDSTACK-8143: Corrected a test in BVT test_routers.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29620/#review67838
---


On Jan. 6, 2015, 7:37 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29620/
 ---
 
 (Updated Jan. 6, 2015, 7:37 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8143
 https://issues.apache.org/jira/browse/CLOUDSTACK-8143
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The test case test_03_restart_network_cleanup is restarting the network with 
 cleanup=True and verifying that the linklocalip of the new router should be 
 different than the linklocalip of the old router.
 
 However this may not be true as the linklocalip is assigned randomly and 
 hence can be same for the new router.
 
 The test case should instead check that the publicip of the new router should 
 be the same as publicip of the old router.
 
 
 Diffs
 -
 
   test/integration/smoke/test_routers.py 7d5f267 
 
 Diff: https://reviews.apache.org/r/29620/diff/
 
 
 Testing
 ---
 
 Test router internal basic zone ... SKIP: Skip
 Test router internal advanced zone ... SKIP: Skip
 Test restart network ... === TestName: test_03_restart_network_cleanup | 
 Status : SUCCESS ===
 ok
 Test restart network without cleanup ... SKIP: Skip
 Test router basic setup ... SKIP: Skip
 Test router advanced setup ... SKIP: Skip
 Test stop router ... SKIP: Skip
 Test start router ... SKIP: Skip
 Test reboot router ... SKIP: Skip
 
 --
 Ran 9 tests in 231.829s
 
 OK (SKIP=8)
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Re: Review Request 29620: CLOUDSTACK-8143: Corrected a test in BVT test_routers.py

2015-01-13 Thread sanjeev n


 On Jan. 13, 2015, 11:10 a.m., sanjeev n wrote:
  Ship It!
 
 sanjeev n wrote:
 commit 9f55411295c9abc843a49f226691a6b720fb0c07
 Author: Ashutosh K ashut...@clogeny.com
 Date:   Tue Jan 6 12:54:49 2015 +0530
 
 CLOUDSTACK-8143: Corrected a test in BVT test_routers.py

Commit on ACS 4.5:
commit 2ed76b2a55f843053e51d243a1545e92307a0012
Author: Ashutosh K ashut...@clogeny.com
Date:   Tue Jan 6 12:54:49 2015 +0530

CLOUDSTACK-8143: Corrected a test in BVT test_routers.py


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29620/#review67838
---


On Jan. 6, 2015, 7:37 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29620/
 ---
 
 (Updated Jan. 6, 2015, 7:37 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8143
 https://issues.apache.org/jira/browse/CLOUDSTACK-8143
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The test case test_03_restart_network_cleanup is restarting the network with 
 cleanup=True and verifying that the linklocalip of the new router should be 
 different than the linklocalip of the old router.
 
 However this may not be true as the linklocalip is assigned randomly and 
 hence can be same for the new router.
 
 The test case should instead check that the publicip of the new router should 
 be the same as publicip of the old router.
 
 
 Diffs
 -
 
   test/integration/smoke/test_routers.py 7d5f267 
 
 Diff: https://reviews.apache.org/r/29620/diff/
 
 
 Testing
 ---
 
 Test router internal basic zone ... SKIP: Skip
 Test router internal advanced zone ... SKIP: Skip
 Test restart network ... === TestName: test_03_restart_network_cleanup | 
 Status : SUCCESS ===
 ok
 Test restart network without cleanup ... SKIP: Skip
 Test router basic setup ... SKIP: Skip
 Test router advanced setup ... SKIP: Skip
 Test stop router ... SKIP: Skip
 Test start router ... SKIP: Skip
 Test reboot router ... SKIP: Skip
 
 --
 Ran 9 tests in 231.829s
 
 OK (SKIP=8)
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Re: Review Request 29843: CLOUDSTACK-8149: Code-refactor - test_VirtualRouter_alerts.py

2015-01-13 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29843/#review67827
---



test/integration/component/test_VirtualRouter_alerts.py
https://reviews.apache.org/r/29843/#comment111915

Why are we just checking for dnsmasq process status? Why don't we stop it 
for the monitor service to start?



test/integration/component/test_VirtualRouter_alerts.py
https://reviews.apache.org/r/29843/#comment111916

Read the router.alerts.check.interval value from Global settings and add 
10mins instead of hard coding the value in time.sleep()


- sanjeev n


On Jan. 13, 2015, 7:04 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29843/
 ---
 
 (Updated Jan. 13, 2015, 7:04 a.m.)
 
 
 Review request for cloudstack and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-8149
 https://issues.apache.org/jira/browse/CLOUDSTACK-8149
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 The test case needed a major code-refactor. Also it had import issues and 
 pep8 issues. Fixed those too.
 
 
 Diffs
 -
 
   test/integration/component/test_VirtualRouter_alerts.py bff12f9 
 
 Diff: https://reviews.apache.org/r/29843/diff/
 
 
 Testing
 ---
 
 Yes.
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Review Request 26488: New Test to verify the fix for issue The ISO / Template is automatically deleted after download URL expires.

2014-10-09 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26488/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Reproduce:
Template created from volume
Template is downloaded (should succeed the first time)
4 hours later the template vanishes.
Now you cannot deploy from this template.


Diffs
-

  test/integration/smoke/misc/test_escalations_templates.py PRE-CREATION 

Diff: https://reviews.apache.org/r/26488/diff/


Testing
---

test01_template_download_URL_expire 
(integration.smoke.misc.test_escalations_templates.TestTemplates) ... === 
TestName: test01_template_download_URL_expire | Status : SUCCESS ===
ok

--
Ran 1 test in 651.143s

OK


Thanks,

sanjeev n



Re: Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

2014-09-26 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/
---

(Updated Sept. 26, 2014, 10:15 a.m.)


Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Changes
---

Incorporated review comments


Repository: cloudstack-git


Description
---

Test script to verify vm deployment with two networks in SG enabled advanced 
zone.
Involves following steps:
1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range 
using simulator
2.Deploy one guest vm in the default shared guest network so that all the IP 
addresses will be consumed
3.Add another guest network in the zone created at step1
4.Deploy vm without passing the network id. It should pick the network with 
sufficient resources


Diffs (updated)
-

  test/integration/component/test_advancedsg_networks.py 85ab697 
  tools/marvin/marvin/config/test_data.py b658b01 

Diff: https://reviews.apache.org/r/25293/diff/


Testing
---

@Desc: VM Cannot deploy to second network in advanced SG network ... === 
TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
ok

--
Ran 1 test in 343.198s

OK


Thanks,

sanjeev n



Re: Review Request 26080: Automation for volume life cycle testPath

2014-09-26 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26080/#review54670
---



test/integration/testpaths/testpath_volumelifecycle.py
https://reviews.apache.org/r/26080/#comment94907

Replace with validateList



test/integration/testpaths/testpath_volumelifecycle.py
https://reviews.apache.org/r/26080/#comment94906

Add new line(\n)



test/integration/testpaths/testpath_volumelifecycle.py
https://reviews.apache.org/r/26080/#comment94904

Replace this with validateList



test/integration/testpaths/testpath_volumelifecycle.py
https://reviews.apache.org/r/26080/#comment94905

Replace with assertEqual



test/integration/testpaths/testpath_volumelifecycle.py
https://reviews.apache.org/r/26080/#comment94902

Please remove this line



test/integration/testpaths/testpath_volumelifecycle.py
https://reviews.apache.org/r/26080/#comment94903

Remove the blank lines



test/integration/testpaths/testpath_volumelifecycle.py
https://reviews.apache.org/r/26080/#comment94908

move this line after assertion


- sanjeev n


On Sept. 26, 2014, 10:58 a.m., prashant mishra wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/26080/
 ---
 
 (Updated Sept. 26, 2014, 10:58 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-7632
 https://issues.apache.org/jira/browse/CLOUDSTACK-7632
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Automation for volume life cycle testPath
 
 
 Diffs
 -
 
   test/integration/testpaths/testpath_volumelifecycle.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/26080/diff/
 
 
 Testing
 ---
 
 tested on following setup 
 
 1-only shared storage
 2-local storage + zone wide storage +shared storage
 
 
 Thanks,
 
 prashant mishra
 




Re: Review Request 25771: Adding new test case to verify the fix provided in bug CLOUDSTACK-6172

2014-09-23 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25771/
---

(Updated Sept. 23, 2014, 6:29 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Changes
---

Fixed Review Comments


Bugs: CS-6172
https://issues.apache.org/jira/browse/CS-6172


Repository: cloudstack-git


Description
---

@Desc:Volume is not retaining same uuid when migrating from one storage to 
another.
Step1:Create a volume/data disk
Step2:Verify UUID of the volume
Step3:Migrate the volume to another primary storage within the cluster
Step4:Migrating volume to new primary storage should succeed
Step5:volume UUID should not change even after migration


Diffs (updated)
-

  test/integration/component/test_volumes.py 122f2d1 

Diff: https://reviews.apache.org/r/25771/diff/


Testing
---

Yes
@Desc:Volume is not retaining same uuid when migrating from one storage to 
another. ... === TestName: test_01_migrateVolume | Status : SUCCESS ===
ok

--
Ran 1 test in 343.250s

OK


Thanks,

sanjeev n



Re: Review Request 25580: Adding test case to verify fix for issue Create volume from custom disk offering does not work as expected

2014-09-23 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25580/#review54259
---

Ship it!


commit 0d5a435f7669eddd44a6b62317fe26bb1d96e96c
Author: sanjeev sanj...@apache.org
Date:   Tue Sep 23 14:15:39 2014 +0530

Creating custom disk does not work as expected

- sanjeev n


On Sept. 12, 2014, 1:32 p.m., sanjeev n wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25580/
 ---
 
 (Updated Sept. 12, 2014, 1:32 p.m.)
 
 
 Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 @Desc:Create volume from custom disk offering does not work as expected
 Step1:Create custom disk offering
 Step2:Create Volume with size x
 Step3:Attach that volume to a vm
 Step4:Create another volume with size y
 Step5:Verify that the new volume is created with size Y but not with size X
   
 
 
 Diffs
 -
 
   test/integration/component/test_escalations_volumes.py db4c3d8 
   tools/marvin/marvin/lib/base.py 04217b2 
 
 Diff: https://reviews.apache.org/r/25580/diff/
 
 
 Testing
 ---
 
 Yes
 
 @Desc:Create volume from custom disk offering does not work as expected ... 
 === TestName: test_13_volume_custom_disk_size | Status : SUCCESS ===
 ok
 
 --
 Ran 1 test in 303.508s
 
 OK
 
 
 Thanks,
 
 sanjeev n
 




Re: Review Request 25536: Adding new test case to verify the fix for issue Exception when attaching data disk to Rhel vm on vSphere

2014-09-23 Thread sanjeev n


 On Sept. 19, 2014, 6:03 a.m., SrikanteswaraRao Talluri wrote:
  test/integration/component/test_escalations_vmware.py, line 19
  https://reviews.apache.org/r/25536/diff/1/?file=685097#file685097line19
 
  can you please avoid import * ?

commit 5fb2b3a0d24c2bcda0745a6b8ff59fae5651e054
Author: sanjeev sanj...@apache.org
Date:   Wed Sep 10 11:55:26 2014 +0530

Test to verify fix for issue Exception when attaching data disk to RHEL vm 
on vSphere

Added Rhel6 template details to test_data.py

Signed-off-by: sanjeev sanj...@apache.org

Fixed review comments provided in RR 25536


- sanjeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25536/#review53939
---


On Sept. 11, 2014, 10:31 a.m., sanjeev n wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25536/
 ---
 
 (Updated Sept. 11, 2014, 10:31 a.m.)
 
 
 Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 @desc: Exception when attaching data disk to RHEL VM on vSphere
 Step1: Confirm that vmware.root.disk.controller = ide in Global Settings.
 Step2: Register RHEl 6.0 template and deploy a VM.
 Step3: Note that the root disk is attached to IDE.
 Step4: Create new DATA disk and attempt to attach it to the VM.
 Verify that step4 succeeds without any exception
 
 
 Diffs
 -
 
   test/integration/component/test_escalations_vmware.py PRE-CREATION 
   tools/marvin/marvin/config/test_data.py 4133aba 
 
 Diff: https://reviews.apache.org/r/25536/diff/
 
 
 Testing
 ---
 
 Yes
 
 
 Thanks,
 
 sanjeev n
 




Review Request 25889: Add more wait time for ssh execute command in case of Hyper-v

2014-09-22 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25889/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

In case of Hyper-v ssvm/cpvm reboot takes more time than other hypervisors. So 
made changes to get_process_status accordingly.


Diffs
-

  tools/marvin/marvin/lib/utils.py c52e277 

Diff: https://reviews.apache.org/r/25889/diff/


Testing
---

Yes


Thanks,

sanjeev n



Review Request 25771: Adding new test case to verify the fix provided in bug CLOUDSTACK-6172

2014-09-18 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25771/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CS-6172
https://issues.apache.org/jira/browse/CS-6172


Repository: cloudstack-git


Description
---

@Desc:Volume is not retaining same uuid when migrating from one storage to 
another.
Step1:Create a volume/data disk
Step2:Verify UUID of the volume
Step3:Migrate the volume to another primary storage within the cluster
Step4:Migrating volume to new primary storage should succeed
Step5:volume UUID should not change even after migration


Diffs
-

  test/integration/component/test_volumes.py 122f2d1 

Diff: https://reviews.apache.org/r/25771/diff/


Testing
---

Yes
@Desc:Volume is not retaining same uuid when migrating from one storage to 
another. ... === TestName: test_01_migrateVolume | Status : SUCCESS ===
ok

--
Ran 1 test in 343.250s

OK


Thanks,

sanjeev n



Re: Review Request 25681: Fixed the test_templates.py script bug CLOUDSTACK-7554

2014-09-16 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25681/#review53487
---

Ship it!


commit 50990c40423062ed0b724472c95a1d3120b8b66d
Author: Chandan Purushothama chandan.purushoth...@citrix.com
Date:   Mon Sep 15 21:12:26 2014 -0700

CLOUDSTACK-7554 : Fixed the script - /component/test_templates.py - User 
Account now has permissions to the Template created by Admin

- sanjeev n


On Sept. 16, 2014, 4:21 a.m., Chandan Purushothama wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25681/
 ---
 
 (Updated Sept. 16, 2014, 4:21 a.m.)
 
 
 Review request for cloudstack, sangeetha hariharan, sanjeev n, and Santhosh 
 Edukulla.
 
 
 Bugs: CLOUDSTACK-7554
 https://issues.apache.org/jira/browse/CLOUDSTACK-7554
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Two testcases failed due to template permissions issue:
 
 test_01_create_template_volume
 test_04_template_from_snapshot
 
 Template created by Admin should have public permissions so that the Regular 
 Account can use it to deploy VMs in the test cases.
 
 
 Diffs
 -
 
   test/integration/component/test_templates.py 01f331e 
 
 Diff: https://reviews.apache.org/r/25681/diff/
 
 
 Testing
 ---
 
 Testing was not done.
 
 
 Thanks,
 
 Chandan Purushothama
 




Review Request 25580: Adding test case to verify fix for issue Create volume from custom disk offering does not work as expected

2014-09-12 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25580/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

@Desc:Create volume from custom disk offering does not work as expected
Step1:Create custom disk offering
Step2:Create Volume with size x
Step3:Attach that volume to a vm
Step4:Create another volume with size y
Step5:Verify that the new volume is created with size Y but not with size X
  


Diffs
-

  test/integration/component/test_escalations_volumes.py db4c3d8 
  tools/marvin/marvin/lib/base.py 04217b2 

Diff: https://reviews.apache.org/r/25580/diff/


Testing
---

Yes

@Desc:Create volume from custom disk offering does not work as expected ... === 
TestName: test_13_volume_custom_disk_size | Status : SUCCESS ===
ok

--
Ran 1 test in 303.508s

OK


Thanks,

sanjeev n



Review Request 25536: Adding new test case to verify the fix for issue Exception when attaching data disk to Rhel vm on vSphere

2014-09-11 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25536/
---

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

@desc: Exception when attaching data disk to RHEL VM on vSphere
Step1: Confirm that vmware.root.disk.controller = ide in Global Settings.
Step2: Register RHEl 6.0 template and deploy a VM.
Step3: Note that the root disk is attached to IDE.
Step4: Create new DATA disk and attempt to attach it to the VM.
Verify that step4 succeeds without any exception


Diffs
-

  test/integration/component/test_escalations_vmware.py PRE-CREATION 
  tools/marvin/marvin/config/test_data.py 4133aba 

Diff: https://reviews.apache.org/r/25536/diff/


Testing
---

Yes


Thanks,

sanjeev n



Review Request 25293: Test script to verify vm deployment with two networks in SG enabled advanced zone

2014-09-03 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25293/
---

Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Test script to verify vm deployment with two networks in SG enabled advanced 
zone.
Involves following steps:
1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range 
using simulator
2.Deploy one guest vm in the default shared guest network so that all the IP 
addresses will be consumed
3.Add another guest network in the zone created at step1
4.Deploy vm without passing the network id. It should pick the network with 
sufficient resources


Diffs
-

  test/integration/component/test_advancedsg_networks.py 85ab697 
  tools/marvin/marvin/config/test_data.py b658b01 

Diff: https://reviews.apache.org/r/25293/diff/


Testing
---

@Desc: VM Cannot deploy to second network in advanced SG network ... === 
TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
ok

--
Ran 1 test in 343.198s

OK


Thanks,

sanjeev n



Re: Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant

2014-08-28 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24055/#review51756
---

Ship it!


Ship It!

- sanjeev n


On Aug. 22, 2014, 10:14 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/24055/
 ---
 
 (Updated Aug. 22, 2014, 10:14 a.m.)
 
 
 Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and 
 Sowmya Krishnan.
 
 
 Bugs: CLOUDSTACK-2251
 https://issues.apache.org/jira/browse/CLOUDSTACK-2251
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Automation test cases for feature - Dedicated guest VLAN ranges per tenant
 
 
 Diffs
 -
 
   test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION 
   tools/marvin/marvin/lib/base.py f0d53a6 
   tools/marvin/marvin/lib/common.py 3706456 
 
 Diff: https://reviews.apache.org/r/24055/diff/
 
 
 Testing
 ---
 
 Yes.
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits

2014-08-28 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22805/#review51758
---

Ship it!


Ship It!

- sanjeev n


On Aug. 27, 2014, 8:31 a.m., Ashutosh Kelkar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22805/
 ---
 
 (Updated Aug. 27, 2014, 8:31 a.m.)
 
 
 Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
 
 
 Bugs: CLOUDSTACK-1466
 https://issues.apache.org/jira/browse/CLOUDSTACK-1466
 
 
 Repository: cloudstack-git
 
 
 Description
 ---
 
 Automation tests for Secondary Storage Limits. This patch contains 2 test 
 suites. 2 more test suites to follow.
 
 
 Diffs
 -
 
   test/integration/component/test_ss_domain_limits.py PRE-CREATION 
   test/integration/component/test_ss_limits.py PRE-CREATION 
   test/integration/component/test_ss_max_limits.py PRE-CREATION 
   test/integration/component/test_ss_project_limits.py PRE-CREATION 
   tools/marvin/marvin/config/test_data.py ade8657 
   tools/marvin/marvin/lib/base.py 99a541a 
 
 Diff: https://reviews.apache.org/r/22805/diff/
 
 
 Testing
 ---
 
 Yes.
 
 
 Thanks,
 
 Ashutosh Kelkar
 




Review Request 25097: Test script to verify vm deployment with two networks in SG enabled advanced zone

2014-08-27 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25097/
---

Review request for cloudstack, suresh sadhu, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

Test script to verify vm deployment with two networks in SG enabled advanced 
zone. 
Involves following steps:
1.Deploy SG enabled advanced zone with only 4 ip addresses in guest ip range 
using simulator
2.Deploy one guest vm in the default shared guest network so that all the IP 
addresses will be consumed
3.Add another guest network in the zone created at step1
4.Deploy vm without passing the network id. It should pick the network with 
sufficient resources


Diffs
-

  test/integration/component/test_advancedsg_networks.py 85ab697 
  tools/marvin/marvin/config/test_data.cfg 5a3d8aa 

Diff: https://reviews.apache.org/r/25097/diff/


Testing
---

@Desc: VM Cannot deploy to second network in advanced SG network ... === 
TestName: test_34_DeployVM_in_SecondSGNetwork | Status : SUCCESS ===
ok

--
Ran 1 test in 357.750s

OK


Thanks,

sanjeev n



Re: Review Request 25017: Disabling VPC tests on Hyper-v

2014-08-26 Thread sanjeev n

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25017/
---

(Updated Aug. 26, 2014, 10 a.m.)


Review request for cloudstack, John Dilley, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

skipping VPC tests on Hyper-v. Made changes to following test scripts to skip 
VPC tests on Hyper-v :
/test/integration/smoke/test_network_acl.py 
b/test/integration/smoke/test_network_acl.py
/test/integration/smoke/test_privategw_acl.py 
b/test/integration/smoke/test_privategw_acl.py
test/integration/smoke/test_vpc_vpn.py b/test/integration/smoke/test_vpc_vpn.py


Diffs
-

  test/integration/smoke/test_network_acl.py 015ebab 
  test/integration/smoke/test_privategw_acl.py cf0f8e3 
  test/integration/smoke/test_vpc_vpn.py 9e8f97f 

Diff: https://reviews.apache.org/r/25017/diff/


Testing
---

Yes


Thanks,

sanjeev n



  1   2   >