CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Remi Bergsma
Hi all,

In our employee cloud most of our employees have their own Domain to spin up 
machines. Since we have 150+ domains and the lists are unsorted, it is very 
hard to find the one you need. The order returned by the API is the order they 
were added.

Without any knowledge of the CloudStack UI, I decided to spend some spare time 
on this, to figure out a way of fixing this issue. I succeeded, as in my dev 
environment it now shows alphabetically ordered lists. Although, I discovered 
that the javascript code that does the select for the domains is on many places 
in the code base (25+ occurrences, with 3 or so variations). Am I supposed to 
fix this “ordering” on all these occurrences or am I missing something?

First, I fixed it on the most obvious parts that bother us most:
https://github.com/remibergsma/cloudstack/commit/af3a7755a26e13d36a3600f16acac61085a1fa50
This I have verified works well.

Then did a search and altered the others as well:
https://github.com/remibergsma/cloudstack/commit/f0a2e09df4b9887d771250dc8682739b8728952b
This I still need to test/verify.

Before I proceed, could you let me know if this is the way to fix it (without 
refactoring the whole thing into a single shared function).

Thanks,
Remi



RE: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Gabor Apati-Nagy
Hi,

I think sorting would be good to have, but I would not change the display 
format because that would remove hierarchy (as a sorting criteria). 

Wouldn't it be good to sort just by path? (To me sorting looks like an 
improvement, changing the format is more like a change that may cause problem 
for some.)

Cheers,
Gabor


-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com] 
Sent: 18 December 2014 08:40
To: dev@cloudstack.apache.org
Subject: CLOUDSTACK-6543 Sorting the domain list in UI

Hi all,

In our employee cloud most of our employees have their own Domain to spin up 
machines. Since we have 150+ domains and the lists are unsorted, it is very 
hard to find the one you need. The order returned by the API is the order they 
were added.

Without any knowledge of the CloudStack UI, I decided to spend some spare time 
on this, to figure out a way of fixing this issue. I succeeded, as in my dev 
environment it now shows alphabetically ordered lists. Although, I discovered 
that the javascript code that does the select for the domains is on many places 
in the code base (25+ occurrences, with 3 or so variations). Am I supposed to 
fix this "ordering" on all these occurrences or am I missing something?

First, I fixed it on the most obvious parts that bother us most:
https://github.com/remibergsma/cloudstack/commit/af3a7755a26e13d36a3600f16acac61085a1fa50
This I have verified works well.

Then did a search and altered the others as well:
https://github.com/remibergsma/cloudstack/commit/f0a2e09df4b9887d771250dc8682739b8728952b
This I still need to test/verify.

Before I proceed, could you let me know if this is the way to fix it (without 
refactoring the whole thing into a single shared function).

Thanks,
Remi



Re: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Andrija Panic
+1 for sorting - somwhat painfull to find domains in current situation...

On 18 December 2014 at 11:35, Gabor Apati-Nagy 
wrote:
>
> Hi,
>
> I think sorting would be good to have, but I would not change the display
> format because that would remove hierarchy (as a sorting criteria).
>
> Wouldn't it be good to sort just by path? (To me sorting looks like an
> improvement, changing the format is more like a change that may cause
> problem for some.)
>
> Cheers,
> Gabor
>
>
> -Original Message-
> From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
> Sent: 18 December 2014 08:40
> To: dev@cloudstack.apache.org
> Subject: CLOUDSTACK-6543 Sorting the domain list in UI
>
> Hi all,
>
> In our employee cloud most of our employees have their own Domain to spin
> up machines. Since we have 150+ domains and the lists are unsorted, it is
> very hard to find the one you need. The order returned by the API is the
> order they were added.
>
> Without any knowledge of the CloudStack UI, I decided to spend some spare
> time on this, to figure out a way of fixing this issue. I succeeded, as in
> my dev environment it now shows alphabetically ordered lists. Although, I
> discovered that the javascript code that does the select for the domains is
> on many places in the code base (25+ occurrences, with 3 or so variations).
> Am I supposed to fix this "ordering" on all these occurrences or am I
> missing something?
>
> First, I fixed it on the most obvious parts that bother us most:
>
> https://github.com/remibergsma/cloudstack/commit/af3a7755a26e13d36a3600f16acac61085a1fa50
> This I have verified works well.
>
> Then did a search and altered the others as well:
>
> https://github.com/remibergsma/cloudstack/commit/f0a2e09df4b9887d771250dc8682739b8728952b
> This I still need to test/verify.
>
> Before I proceed, could you let me know if this is the way to fix it
> (without refactoring the whole thing into a single shared function).
>
> Thanks,
> Remi
>
>

-- 

Andrija Panić


Re: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Remi Bergsma
Hi,

The reason I’ve put the name upfront is because it allows for easy navigation 
using a keyboard. But I see your point.

About the format, it is not consistent now, as most lists display the path 
whereas others display just the name (which is really not what you want). For 
example when dedicating a zone to an account. I'd suggest changing then all to 
the same format.

As an alternative, would sorting it at the API level be better? Then we 
wouldn’t have to do it client side and we’d only have to change it at one place 
only.

Regards,
Remi


On Dec 18, 2014, at 12:46 PM, Andrija Panic  wrote:

> +1 for sorting - somwhat painfull to find domains in current situation...
> 
> On 18 December 2014 at 11:35, Gabor Apati-Nagy 
> wrote:
>> 
>> Hi,
>> 
>> I think sorting would be good to have, but I would not change the display
>> format because that would remove hierarchy (as a sorting criteria).
>> 
>> Wouldn't it be good to sort just by path? (To me sorting looks like an
>> improvement, changing the format is more like a change that may cause
>> problem for some.)
>> 
>> Cheers,
>> Gabor
>> 
>> 
>> -Original Message-
>> From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
>> Sent: 18 December 2014 08:40
>> To: dev@cloudstack.apache.org
>> Subject: CLOUDSTACK-6543 Sorting the domain list in UI
>> 
>> Hi all,
>> 
>> In our employee cloud most of our employees have their own Domain to spin
>> up machines. Since we have 150+ domains and the lists are unsorted, it is
>> very hard to find the one you need. The order returned by the API is the
>> order they were added.
>> 
>> Without any knowledge of the CloudStack UI, I decided to spend some spare
>> time on this, to figure out a way of fixing this issue. I succeeded, as in
>> my dev environment it now shows alphabetically ordered lists. Although, I
>> discovered that the javascript code that does the select for the domains is
>> on many places in the code base (25+ occurrences, with 3 or so variations).
>> Am I supposed to fix this "ordering" on all these occurrences or am I
>> missing something?
>> 
>> First, I fixed it on the most obvious parts that bother us most:
>> 
>> https://github.com/remibergsma/cloudstack/commit/af3a7755a26e13d36a3600f16acac61085a1fa50
>> This I have verified works well.
>> 
>> Then did a search and altered the others as well:
>> 
>> https://github.com/remibergsma/cloudstack/commit/f0a2e09df4b9887d771250dc8682739b8728952b
>> This I still need to test/verify.
>> 
>> Before I proceed, could you let me know if this is the way to fix it
>> (without refactoring the whole thing into a single shared function).
>> 
>> Thanks,
>> Remi
>> 
>> 
> 
> -- 
> 
> Andrija Panić



RE: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Gabor Apati-Nagy
My point here is: unless the API supported sorting as a parameter, we should 
not rely on any expected sorting done by the API. It is really the presentation 
layer's job to show the results in an order it wants to. So instead of changing 
the API, I would suggest let's just sort it at UI side. 

I see why sorting by name would be good in some cases, but if the same names 
exist in different domains it could easily become confusing. Or it can be even 
more confusing if someone tries to find something by hierarchy - not knowing 
it's exact name, but knowing where it should be.

As a future feature, there could be a "browse domains" or similar selector 
where a popup could show them in a searchable grid or similar where users could 
search by name for instance.

So I am +1 for sorting at UI side and -1 for changing to "Name (Path)" format. 
And +1 for having the same format everywhere.

Thanks,
Gabor


-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com] 
Sent: 18 December 2014 12:16
To: dev@cloudstack.apache.org
Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI

Hi,

The reason I’ve put the name upfront is because it allows for easy navigation 
using a keyboard. But I see your point.

About the format, it is not consistent now, as most lists display the path 
whereas others display just the name (which is really not what you want). For 
example when dedicating a zone to an account. I'd suggest changing then all to 
the same format.

As an alternative, would sorting it at the API level be better? Then we 
wouldn’t have to do it client side and we’d only have to change it at one place 
only.

Regards,
Remi


On Dec 18, 2014, at 12:46 PM, Andrija Panic  wrote:

> +1 for sorting - somwhat painfull to find domains in current situation...
> 
> On 18 December 2014 at 11:35, Gabor Apati-Nagy 
> 
> wrote:
>> 
>> Hi,
>> 
>> I think sorting would be good to have, but I would not change the 
>> display format because that would remove hierarchy (as a sorting criteria).
>> 
>> Wouldn't it be good to sort just by path? (To me sorting looks like 
>> an improvement, changing the format is more like a change that may 
>> cause problem for some.)
>> 
>> Cheers,
>> Gabor
>> 
>> 
>> -Original Message-----
>> From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
>> Sent: 18 December 2014 08:40
>> To: dev@cloudstack.apache.org
>> Subject: CLOUDSTACK-6543 Sorting the domain list in UI
>> 
>> Hi all,
>> 
>> In our employee cloud most of our employees have their own Domain to 
>> spin up machines. Since we have 150+ domains and the lists are 
>> unsorted, it is very hard to find the one you need. The order 
>> returned by the API is the order they were added.
>> 
>> Without any knowledge of the CloudStack UI, I decided to spend some 
>> spare time on this, to figure out a way of fixing this issue. I 
>> succeeded, as in my dev environment it now shows alphabetically 
>> ordered lists. Although, I discovered that the javascript code that 
>> does the select for the domains is on many places in the code base (25+ 
>> occurrences, with 3 or so variations).
>> Am I supposed to fix this "ordering" on all these occurrences or am I 
>> missing something?
>> 
>> First, I fixed it on the most obvious parts that bother us most:
>> 
>> https://github.com/remibergsma/cloudstack/commit/af3a7755a26e13d36a36
>> 00f16acac61085a1fa50
>> This I have verified works well.
>> 
>> Then did a search and altered the others as well:
>> 
>> https://github.com/remibergsma/cloudstack/commit/f0a2e09df4b9887d7712
>> 50dc8682739b8728952b
>> This I still need to test/verify.
>> 
>> Before I proceed, could you let me know if this is the way to fix it 
>> (without refactoring the whole thing into a single shared function).
>> 
>> Thanks,
>> Remi
>> 
>> 
> 
> --
> 
> Andrija Panić



Re: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Mike Tutkowski
+1 on GUI-side sorting (ideally it would be nice if we could sort by
clicking a column header in a table...maybe some reasonable column header
would be selected by default for each table)

On Thursday, December 18, 2014, Gabor Apati-Nagy <
gabor.apati-n...@citrix.com> wrote:

> My point here is: unless the API supported sorting as a parameter, we
> should not rely on any expected sorting done by the API. It is really the
> presentation layer's job to show the results in an order it wants to. So
> instead of changing the API, I would suggest let's just sort it at UI side.
>
> I see why sorting by name would be good in some cases, but if the same
> names exist in different domains it could easily become confusing. Or it
> can be even more confusing if someone tries to find something by hierarchy
> - not knowing it's exact name, but knowing where it should be.
>
> As a future feature, there could be a "browse domains" or similar selector
> where a popup could show them in a searchable grid or similar where users
> could search by name for instance.
>
> So I am +1 for sorting at UI side and -1 for changing to "Name (Path)"
> format. And +1 for having the same format everywhere.
>
> Thanks,
> Gabor
>
>
> -Original Message-
> From: Remi Bergsma [mailto:rberg...@schubergphilis.com ]
> Sent: 18 December 2014 12:16
> To: dev@cloudstack.apache.org 
> Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI
>
> Hi,
>
> The reason I’ve put the name upfront is because it allows for easy
> navigation using a keyboard. But I see your point.
>
> About the format, it is not consistent now, as most lists display the path
> whereas others display just the name (which is really not what you want).
> For example when dedicating a zone to an account. I'd suggest changing then
> all to the same format.
>
> As an alternative, would sorting it at the API level be better? Then we
> wouldn’t have to do it client side and we’d only have to change it at one
> place only.
>
> Regards,
> Remi
>
>
> On Dec 18, 2014, at 12:46 PM, Andrija Panic  > wrote:
>
> > +1 for sorting - somwhat painfull to find domains in current situation...
> >
> > On 18 December 2014 at 11:35, Gabor Apati-Nagy
> > >
> > wrote:
> >>
> >> Hi,
> >>
> >> I think sorting would be good to have, but I would not change the
> >> display format because that would remove hierarchy (as a sorting
> criteria).
> >>
> >> Wouldn't it be good to sort just by path? (To me sorting looks like
> >> an improvement, changing the format is more like a change that may
> >> cause problem for some.)
> >>
> >> Cheers,
> >> Gabor
> >>
> >>
> >> -Original Message-
> >> From: Remi Bergsma [mailto:rberg...@schubergphilis.com ]
> >> Sent: 18 December 2014 08:40
> >> To: dev@cloudstack.apache.org 
> >> Subject: CLOUDSTACK-6543 Sorting the domain list in UI
> >>
> >> Hi all,
> >>
> >> In our employee cloud most of our employees have their own Domain to
> >> spin up machines. Since we have 150+ domains and the lists are
> >> unsorted, it is very hard to find the one you need. The order
> >> returned by the API is the order they were added.
> >>
> >> Without any knowledge of the CloudStack UI, I decided to spend some
> >> spare time on this, to figure out a way of fixing this issue. I
> >> succeeded, as in my dev environment it now shows alphabetically
> >> ordered lists. Although, I discovered that the javascript code that
> >> does the select for the domains is on many places in the code base (25+
> occurrences, with 3 or so variations).
> >> Am I supposed to fix this "ordering" on all these occurrences or am I
> >> missing something?
> >>
> >> First, I fixed it on the most obvious parts that bother us most:
> >>
> >> https://github.com/remibergsma/cloudstack/commit/af3a7755a26e13d36a36
> >> 00f16acac61085a1fa50
> >> This I have verified works well.
> >>
> >> Then did a search and altered the others as well:
> >>
> >> https://github.com/remibergsma/cloudstack/commit/f0a2e09df4b9887d7712
> >> 50dc8682739b8728952b
> >> This I still need to test/verify.
> >>
> >> Before I proceed, could you let me know if this is the way to fix it
> >> (without refactoring the whole thing into a single shared function).
> >>
> >> Thanks,
> >> Remi
> >>
> >>
> >
> > --
> >
> > Andrija Panić
>
>

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*


Re: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-18 Thread Abhinandan Prateek
We should give it some more thought as UI side sorting is limited in its 
capability in case the data is huge and there is pagination.
There could be some default ordering that API’s implement. On top of it we 
could further have UI/javascript level sorting and searching.

> On 18-Dec-2014, at 10:47 pm, Mike Tutkowski  
> wrote:
>
> +1 on GUI-side sorting (ideally it would be nice if we could sort by
> clicking a column header in a table...maybe some reasonable column header
> would be selected by default for each table)
>
> On Thursday, December 18, 2014, Gabor Apati-Nagy <
> gabor.apati-n...@citrix.com> wrote:
>
>> My point here is: unless the API supported sorting as a parameter, we
>> should not rely on any expected sorting done by the API. It is really the
>> presentation layer's job to show the results in an order it wants to. So
>> instead of changing the API, I would suggest let's just sort it at UI side.
>>
>> I see why sorting by name would be good in some cases, but if the same
>> names exist in different domains it could easily become confusing. Or it
>> can be even more confusing if someone tries to find something by hierarchy
>> - not knowing it's exact name, but knowing where it should be.
>>
>> As a future feature, there could be a "browse domains" or similar selector
>> where a popup could show them in a searchable grid or similar where users
>> could search by name for instance.
>>
>> So I am +1 for sorting at UI side and -1 for changing to "Name (Path)"
>> format. And +1 for having the same format everywhere.
>>
>> Thanks,
>> Gabor
>>
>>
>> -Original Message-
>> From: Remi Bergsma [mailto:rberg...@schubergphilis.com ]
>> Sent: 18 December 2014 12:16
>> To: dev@cloudstack.apache.org 
>> Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI
>>
>> Hi,
>>
>> The reason I’ve put the name upfront is because it allows for easy
>> navigation using a keyboard. But I see your point.
>>
>> About the format, it is not consistent now, as most lists display the path
>> whereas others display just the name (which is really not what you want).
>> For example when dedicating a zone to an account. I'd suggest changing then
>> all to the same format.
>>
>> As an alternative, would sorting it at the API level be better? Then we
>> wouldn’t have to do it client side and we’d only have to change it at one
>> place only.
>>
>> Regards,
>> Remi
>>
>>
>> On Dec 18, 2014, at 12:46 PM, Andrija Panic > > wrote:
>>
>>> +1 for sorting - somwhat painfull to find domains in current situation...
>>>
>>> On 18 December 2014 at 11:35, Gabor Apati-Nagy
>>> >
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I think sorting would be good to have, but I would not change the
>>>> display format because that would remove hierarchy (as a sorting
>> criteria).
>>>>
>>>> Wouldn't it be good to sort just by path? (To me sorting looks like
>>>> an improvement, changing the format is more like a change that may
>>>> cause problem for some.)
>>>>
>>>> Cheers,
>>>> Gabor
>>>>
>>>>
>>>> -Original Message-
>>>> From: Remi Bergsma [mailto:rberg...@schubergphilis.com ]
>>>> Sent: 18 December 2014 08:40
>>>> To: dev@cloudstack.apache.org 
>>>> Subject: CLOUDSTACK-6543 Sorting the domain list in UI
>>>>
>>>> Hi all,
>>>>
>>>> In our employee cloud most of our employees have their own Domain to
>>>> spin up machines. Since we have 150+ domains and the lists are
>>>> unsorted, it is very hard to find the one you need. The order
>>>> returned by the API is the order they were added.
>>>>
>>>> Without any knowledge of the CloudStack UI, I decided to spend some
>>>> spare time on this, to figure out a way of fixing this issue. I
>>>> succeeded, as in my dev environment it now shows alphabetically
>>>> ordered lists. Although, I discovered that the javascript code that
>>>> does the select for the domains is on many places in the code base (25+
>> occurrences, with 3 or so variations).
>>>> Am I supposed to fix this "ordering" on all these occurrences or am I
>>>> missing something?
>>>>
>>>> First, I fixed it on the most obvious parts that bother us most:
>>>>
>>

RE: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-19 Thread Gabor Apati-Nagy
Well, thanks Abhinandan, I have just noticed I did not emphasize that I was not 
talking about the GUI in general or any other screens. What I talked about is 
only that one specific dropdown where users can select a domain on the Advanced 
Search panel. 

Definitely, for the UI in general this is not right approach. For many screens, 
api calls, we already use pagination, server side sorting - what is good 
practice. 
For this dropdown though, I wouldn't say we should change the API, because 
sorting at GUI side is easy and would work fine.

Sorry for the confusion.

Cheers,
Gabor

-Original Message-
From: Abhinandan Prateek [mailto:abhinandan.prat...@shapeblue.com] 
Sent: 19 December 2014 01:23
To: dev@cloudstack.apache.org
Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI

We should give it some more thought as UI side sorting is limited in its 
capability in case the data is huge and there is pagination.
There could be some default ordering that API’s implement. On top of it we 
could further have UI/javascript level sorting and searching.

> On 18-Dec-2014, at 10:47 pm, Mike Tutkowski  
> wrote:
>
> +1 on GUI-side sorting (ideally it would be nice if we could sort by
> clicking a column header in a table...maybe some reasonable column 
> header would be selected by default for each table)
>
> On Thursday, December 18, 2014, Gabor Apati-Nagy < 
> gabor.apati-n...@citrix.com> wrote:
>
>> My point here is: unless the API supported sorting as a parameter, we 
>> should not rely on any expected sorting done by the API. It is really 
>> the presentation layer's job to show the results in an order it wants 
>> to. So instead of changing the API, I would suggest let's just sort it at UI 
>> side.
>>
>> I see why sorting by name would be good in some cases, but if the 
>> same names exist in different domains it could easily become 
>> confusing. Or it can be even more confusing if someone tries to find 
>> something by hierarchy
>> - not knowing it's exact name, but knowing where it should be.
>>
>> As a future feature, there could be a "browse domains" or similar 
>> selector where a popup could show them in a searchable grid or 
>> similar where users could search by name for instance.
>>
>> So I am +1 for sorting at UI side and -1 for changing to "Name (Path)"
>> format. And +1 for having the same format everywhere.
>>
>> Thanks,
>> Gabor
>>
>>
>> -Original Message-
>> From: Remi Bergsma [mailto:rberg...@schubergphilis.com 
>> ]
>> Sent: 18 December 2014 12:16
>> To: dev@cloudstack.apache.org 
>> Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI
>>
>> Hi,
>>
>> The reason I’ve put the name upfront is because it allows for easy 
>> navigation using a keyboard. But I see your point.
>>
>> About the format, it is not consistent now, as most lists display the 
>> path whereas others display just the name (which is really not what you 
>> want).
>> For example when dedicating a zone to an account. I'd suggest 
>> changing then all to the same format.
>>
>> As an alternative, would sorting it at the API level be better? Then 
>> we wouldn’t have to do it client side and we’d only have to change it 
>> at one place only.
>>
>> Regards,
>> Remi
>>
>>
>> On Dec 18, 2014, at 12:46 PM, Andrija Panic > > wrote:
>>
>>> +1 for sorting - somwhat painfull to find domains in current situation...
>>>
>>> On 18 December 2014 at 11:35, Gabor Apati-Nagy 
>>> >
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I think sorting would be good to have, but I would not change the 
>>>> display format because that would remove hierarchy (as a sorting
>> criteria).
>>>>
>>>> Wouldn't it be good to sort just by path? (To me sorting looks like 
>>>> an improvement, changing the format is more like a change that may 
>>>> cause problem for some.)
>>>>
>>>> Cheers,
>>>> Gabor
>>>>
>>>>
>>>> -Original Message-
>>>> From: Remi Bergsma [mailto:rberg...@schubergphilis.com 
>>>> ]
>>>> Sent: 18 December 2014 08:40
>>>> To: dev@cloudstack.apache.org 
>>>> Subject: CLOUDSTACK-6543 Sorting the domain list in UI
>>>>
>>>> Hi all,
>>>>
>>>> In our employee cloud most of our employees have their own Domain 
>>>> to spin up machines. Since we have 150+ domains and the lists are 
>

Re: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-19 Thread Abhinandan Prateek
Thanks Gabor, Probably I should have read the full thread before responding.

-abhi


> On 19-Dec-2014, at 4:48 pm, Gabor Apati-Nagy  
> wrote:
>
> Well, thanks Abhinandan, I have just noticed I did not emphasize that I was 
> not talking about the GUI in general or any other screens. What I talked 
> about is only that one specific dropdown where users can select a domain on 
> the Advanced Search panel.
>
> Definitely, for the UI in general this is not right approach. For many 
> screens, api calls, we already use pagination, server side sorting - what is 
> good practice.
> For this dropdown though, I wouldn't say we should change the API, because 
> sorting at GUI side is easy and would work fine.
>
> Sorry for the confusion.
>
> Cheers,
> Gabor
>
> -Original Message-
> From: Abhinandan Prateek [mailto:abhinandan.prat...@shapeblue.com]
> Sent: 19 December 2014 01:23
> To: dev@cloudstack.apache.org
> Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI
>
> We should give it some more thought as UI side sorting is limited in its 
> capability in case the data is huge and there is pagination.
> There could be some default ordering that API’s implement. On top of it we 
> could further have UI/javascript level sorting and searching.
>
>> On 18-Dec-2014, at 10:47 pm, Mike Tutkowski  
>> wrote:
>>
>> +1 on GUI-side sorting (ideally it would be nice if we could sort by
>> clicking a column header in a table...maybe some reasonable column
>> header would be selected by default for each table)
>>
>> On Thursday, December 18, 2014, Gabor Apati-Nagy <
>> gabor.apati-n...@citrix.com> wrote:
>>
>>> My point here is: unless the API supported sorting as a parameter, we
>>> should not rely on any expected sorting done by the API. It is really
>>> the presentation layer's job to show the results in an order it wants
>>> to. So instead of changing the API, I would suggest let's just sort it at 
>>> UI side.
>>>
>>> I see why sorting by name would be good in some cases, but if the
>>> same names exist in different domains it could easily become
>>> confusing. Or it can be even more confusing if someone tries to find
>>> something by hierarchy
>>> - not knowing it's exact name, but knowing where it should be.
>>>
>>> As a future feature, there could be a "browse domains" or similar
>>> selector where a popup could show them in a searchable grid or
>>> similar where users could search by name for instance.
>>>
>>> So I am +1 for sorting at UI side and -1 for changing to "Name (Path)"
>>> format. And +1 for having the same format everywhere.
>>>
>>> Thanks,
>>> Gabor
>>>
>>>
>>> -Original Message-
>>> From: Remi Bergsma [mailto:rberg...@schubergphilis.com
>>> ]
>>> Sent: 18 December 2014 12:16
>>> To: dev@cloudstack.apache.org 
>>> Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI
>>>
>>> Hi,
>>>
>>> The reason I’ve put the name upfront is because it allows for easy
>>> navigation using a keyboard. But I see your point.
>>>
>>> About the format, it is not consistent now, as most lists display the
>>> path whereas others display just the name (which is really not what you 
>>> want).
>>> For example when dedicating a zone to an account. I'd suggest
>>> changing then all to the same format.
>>>
>>> As an alternative, would sorting it at the API level be better? Then
>>> we wouldn’t have to do it client side and we’d only have to change it
>>> at one place only.
>>>
>>> Regards,
>>> Remi
>>>
>>>
>>> On Dec 18, 2014, at 12:46 PM, Andrija Panic >> > wrote:
>>>
>>>> +1 for sorting - somwhat painfull to find domains in current situation...
>>>>
>>>> On 18 December 2014 at 11:35, Gabor Apati-Nagy
>>>> >
>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I think sorting would be good to have, but I would not change the
>>>>> display format because that would remove hierarchy (as a sorting
>>> criteria).
>>>>>
>>>>> Wouldn't it be good to sort just by path? (To me sorting looks like
>>>>> an improvement, changing the format is more like a change that may
>>>>> cause problem for some.)
>>>>>
>>>>> Cheers,
>>

Re: CLOUDSTACK-6543 Sorting the domain list in UI

2014-12-19 Thread Mike Tutkowski
Still...it can be difficult to find items in GUI tables when you have a
bunch of rows.

It would be nice if we solved that problem at some point with some sorting
capability.

I suppose right now people just use our filtering capability to find what
they need.

On Friday, December 19, 2014, Abhinandan Prateek <
abhinandan.prat...@shapeblue.com> wrote:

> Thanks Gabor, Probably I should have read the full thread before
> responding.
>
> -abhi
>
>
> > On 19-Dec-2014, at 4:48 pm, Gabor Apati-Nagy <
> gabor.apati-n...@citrix.com > wrote:
> >
> > Well, thanks Abhinandan, I have just noticed I did not emphasize that I
> was not talking about the GUI in general or any other screens. What I
> talked about is only that one specific dropdown where users can select a
> domain on the Advanced Search panel.
> >
> > Definitely, for the UI in general this is not right approach. For many
> screens, api calls, we already use pagination, server side sorting - what
> is good practice.
> > For this dropdown though, I wouldn't say we should change the API,
> because sorting at GUI side is easy and would work fine.
> >
> > Sorry for the confusion.
> >
> > Cheers,
> > Gabor
> >
> > -Original Message-
> > From: Abhinandan Prateek [mailto:abhinandan.prat...@shapeblue.com
> ]
> > Sent: 19 December 2014 01:23
> > To: dev@cloudstack.apache.org 
> > Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI
> >
> > We should give it some more thought as UI side sorting is limited in its
> capability in case the data is huge and there is pagination.
> > There could be some default ordering that API’s implement. On top of it
> we could further have UI/javascript level sorting and searching.
> >
> >> On 18-Dec-2014, at 10:47 pm, Mike Tutkowski <
> mike.tutkow...@solidfire.com > wrote:
> >>
> >> +1 on GUI-side sorting (ideally it would be nice if we could sort by
> >> clicking a column header in a table...maybe some reasonable column
> >> header would be selected by default for each table)
> >>
> >> On Thursday, December 18, 2014, Gabor Apati-Nagy <
> >> gabor.apati-n...@citrix.com > wrote:
> >>
> >>> My point here is: unless the API supported sorting as a parameter, we
> >>> should not rely on any expected sorting done by the API. It is really
> >>> the presentation layer's job to show the results in an order it wants
> >>> to. So instead of changing the API, I would suggest let's just sort it
> at UI side.
> >>>
> >>> I see why sorting by name would be good in some cases, but if the
> >>> same names exist in different domains it could easily become
> >>> confusing. Or it can be even more confusing if someone tries to find
> >>> something by hierarchy
> >>> - not knowing it's exact name, but knowing where it should be.
> >>>
> >>> As a future feature, there could be a "browse domains" or similar
> >>> selector where a popup could show them in a searchable grid or
> >>> similar where users could search by name for instance.
> >>>
> >>> So I am +1 for sorting at UI side and -1 for changing to "Name (Path)"
> >>> format. And +1 for having the same format everywhere.
> >>>
> >>> Thanks,
> >>> Gabor
> >>>
> >>>
> >>> -Original Message-
> >>> From: Remi Bergsma [mailto:rberg...@schubergphilis.com 
> >>> ]
> >>> Sent: 18 December 2014 12:16
> >>> To: dev@cloudstack.apache.org  
> >>> Subject: Re: CLOUDSTACK-6543 Sorting the domain list in UI
> >>>
> >>> Hi,
> >>>
> >>> The reason I’ve put the name upfront is because it allows for easy
> >>> navigation using a keyboard. But I see your point.
> >>>
> >>> About the format, it is not consistent now, as most lists display the
> >>> path whereas others display just the name (which is really not what
> you want).
> >>> For example when dedicating a zone to an account. I'd suggest
> >>> changing then all to the same format.
> >>>
> >>> As an alternative, would sorting it at the API level be better? Then
> >>> we wouldn’t have to do it client side and we’d only have to change it
> >>> at one place only.
> >>>
> >>> Regards,
> >>> Remi
> >>>
> >>>
> >>> On Dec 18, 2014, at 12:46 PM, Andrija