[GitHub] cordova-plugin-camera pull request: Change private CameraLauncher....
Github user jpalermo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/23#issuecomment-46143691 Rebased the commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: CB-6945 Make Camera plugin ind...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/33 CB-6945 Make Camera plugin independent from File plugin on windows 8 After resolving [CB-6920](https://issues.apache.org/jira/browse/CB-6920) and [CB-6613](https://issues.apache.org/jira/browse/CB-6613) Camera plugin uses native Windows 8 functions to manage files instead of File plugin. So file plugin dependency is excess and we can remove it. Fix for [CB-6945](https://issues.apache.org/jira/browse/CB-6945) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-6945 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 06ecc91fd1430bf3261990315e7e6361a6bc5cad Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2014-06-16T06:51:45Z Removes File plugin dependency from windows8 code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-2606 add icon support
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-46151067 Pls take a look [here](https://github.com/apache/cordova-plugin-splashscreen/blob/master/doc/index.md#android-quirks_) and [here](http://docs.phonegap.com/en/3.0.0/cordova_splashscreen_splashscreen.md.html). We are working on new proposal for splash screen support which will make our live easier. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-2606 add icon support
Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-46151794 Yes I have used these methods but these all suggest to replace the image into platforms folder that means to add manually but I want to add splashscreen without making changes to platforms folder as we can add app icon in 3.5 version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cordova-cli pull request: CB-2606 add icon support
I want to make clear that splash icons have nothing to do with CB-2606. Splash icons are handled in this issue: https://issues.apache.org/jira/browse/CB-3571 I have a PR for this https://github.com/apache/cordova-lib/pull/30 that implements this for Android. -Axel 2014-06-16 10:46 GMT+02:00 Axel Nennker ignisvul...@gmail.com: Launcher icons are not part of the app. Please do not put them into www. Put them into project_dir. One above www. Use platform name=android in config.xml and put icon src=ABC.PNG wi Am 05.06.2014 12:12 schrieb rohitagg28 g...@git.apache.org: Github user rohitagg28 commented on the pull request: https://github.com/apache/cordova-cli/pull/126#issuecomment-45202523 Hi I am building the cordova application and I want change the default icon of the app . I am using android platform and I have put all my icons sizes into res folder in www of cordova project. So can you suggest the way how my platform will map those images from www folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: File transfer and HTTP caching
I've created a test case for the caching problem that works fine with my patched plugin. The problem is that with the unpatched plugin versoin, the test doesn't works because the getMetadata method (nor getFile) it's working if the file was corrupted by the bug. The method is not executed at all, success nor error callbacks. In the issue comments there's a deep explanation and the complete test attached. Does anyone experienced this issue before? the method is supposed to work and indeed it's working with the patched file-transfer plugin. A new bug? 2014-06-12 11:08 GMT+02:00 Javier Puerto jpue...@gmail.com: Hi all cordova developers, I'm working on a project based on the Apache Cordova framework. Using the file-transfer plugin I've noticed that the behaviour for HTTP cached resources is not correct. I've opened an issue explaining the problem https://issues.apache.org/jira/browse/CB-6928 I've also created a patch for the issue in the fork I've done from github for Android only https://github.com/jpuerto/cordova-plugin-file-transfer I don't know if others implementations has the same problem as I didn't tested for other platform. I've read that for contributing, the patch must pass the tests. Could someone guide me to run the tests? there's no tests in the file transfer repository, is there another project for testing? Thanks and salu2. PD: I've also moved the OutputStream initialization just before it's used there's no need to close the output stream twice.
[GitHub] cordova-lib pull request: CB-3571: support for splash element in...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46158371 The usage LGTM. But does current implementation remove all default cordova splash screen images if there is no splash element defined? Also, on Android icons and splash images definitions are very similar, but we use two different code blocks for icons and splashIcons. There is probably a way to move common logic to special function and then call it for icons and splash screens. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
File-transfer: delete target file on process error
Hi Cordova developers, I'm creating a system to download/update several resources from a server to the device and I've observe a behaviour that breaks my use case. After fix the issue CB-6928, I'm able to download/update all the resources without problems. My next test was to try to download the resources but with no server response (stopped). I've found that the plugin is deleting my target file silently because there's was an error. I think that the developer should be the responsible to delete or leave the corrupted file because the file-transfer plugin already communicates the error, I don't think that the hardcoded behaviour is a good solution. What do you think? I can open a new issue and provide the patch and test case (Android only) Best regards.
[GitHub] cordova-lib pull request: CB-3571: support for splash element in...
Github user AxelNennker commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46165459 The current code does not remove the default cordova splash screens if there are any but there is no splash in config.xml I think the default splash screens should not be there in the first place if config.xml does not indicate splash screen usage. So if there are splash elements then screen.png is deleted. If splash is not there then nothing happens to res/drawable-*/* files. From: Sergey Grebnov [mailto:notificati...@github.com] Sent: Monday, June 16, 2014 11:35 AM To: apache/cordova-lib Cc: Axel Nennker Subject: Re: [cordova-lib] CB-3571: support for splash element in config.xml on Android (#30) The usage LGTM. But does current implementation remove all default cordova splash screen images if there is no splash element defined? Also, on Android icons and splash images definitions are very similar, but we use two different code blocks for icons and splashIcons. There is probably a way to move common logic to special function and then call it for icons and splash screens. â Reply to this email directly or view it on GitHubhttps://github.com/apache/cordova-lib/pull/30#issuecomment-46158371. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-3571: support for splash element in...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46166927 @AxelNennker, thx for the clarification! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-3571: support for splash element in...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46170707 Here is proposal for standartized splashscreen support across platforms: https://gist.github.com/vladimir-kotikov/875a5f61a88a508d6ca9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-3571: support for splash element in...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46172077 @AxelNennker ok, i started with WP8, Windows8 and iOS implementations, based on your work here: https://github.com/MSOpenTech/cordova-lib/tree/CB-3571. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-docs pull request: 3.0.x
GitHub user guglie opened a pull request: https://github.com/apache/cordova-docs/pull/213 3.0.x offline and online event descriptions were *swapped* You can merge this pull request into a Git repository by running: $ git pull https://github.com/guglie/cordova-docs 3.0.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #213 commit 815d086feccc22a31c18afb63e047e109270e129 Author: guglie gdgug...@gmail.com Date: 2014-06-16T13:12:45Z fixed connection type in offline event offline and online events description were swapped commit 06029f30b76f32c86b6bfcc95daa339e291f8114 Author: guglie gdgug...@gmail.com Date: 2014-06-16T13:14:29Z fixed connection type in online event offline and online event descriptions were swapped --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[CANCELLED][VOTE] Tools release
I'm fine with delaying until then, and through further testing. The vote is hereby CANCELLED. Ian On Fri, Jun 13, 2014 at 1:32 PM, Joe Bowser bows...@gmail.com wrote: I agree. I haven't tested it yet. I'm fine with delaying it. On Fri, Jun 13, 2014 at 10:29 AM, Andrew Grieve agri...@chromium.org wrote: I think the main motivation for this release is the android library project support. But... looks like it wasn't baked enough ( https://github.com/apache/cordova-lib/pull/29). I think we should wait for this PR to land before launching the feature. On Thu, Jun 12, 2014 at 2:19 PM, Ian Clelland iclell...@google.com wrote: Please review and vote on this Tools Release. Release issue: https://issues.apache.org/jira/browse/CB-6390 Both tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-6390/ The packages were published from their corresponding git tags: cordova-plugman: 0.22.3-rc1 (537b8b153c) cordova-cli: 3.5.0-0.2.5-rc1 (a73337d064) cordova-lib: 0.21.5-rc1 (2906b72269) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Used `license-checker` to ensure all dependencies have Apache-compatible licenses * Ensured all unit tests passing * Built and ran mobile spec with tools
[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...
GitHub user drkemp opened a pull request: https://github.com/apache/cordova-app-harness/pull/1 [CB6947] move app directory by default. for file-by-file use parameter m... Change default zip push behavior to move the base directory instead of file-by-file This reduces the number of bridge calls and vastly improves performance. To force file-by-file (for incremental updates) use parameter merge=xx You can merge this pull request into a Git repository by running: $ git pull https://github.com/drkemp/cordova-app-harness master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-harness/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 commit ab2415cf84ae8e83cc9cae931fb9cef0f831507f Author: David Kemp drk...@chromium.org Date: 2014-06-16T13:46:34Z [CB6947] move app directory by default. for file-by-file use parameter merge= --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...
Github user clelland commented on the pull request: https://github.com/apache/cordova-app-harness/pull/1#issuecomment-46182293 Is that literally '`xx`', or is that a placeholder for some other value? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Cordova hooks always verbose.
I agree with this balance that Tommy proposed. Having a simple one liner by default it shows intention, and progress (i.e. not halted). --Carlos On Fri, Jun 13, 2014 at 9:15 PM, tommy-carlos williams to...@devgeeks.org wrote: My personal preference would be (but this is overall, not just for hooks): cordova (no flags): gives minimal stage info – preparing blah, compiling foo, running after_prepare hook, etc. I would only have the “running after_prepare hook” if there actually *is* an after_prepare hook to run. cordova (—verbose or -d): full output of all scripts as well as stage info above. cordova (—silent or -s): completely silent unless there is an error. This would be best for CI or build slave environments where you only want to be notified if something goes wrong On 14 June 2014 at 7:06:05, Michal Mocny (mmo...@chromium.org) wrote: Landed the change to make this verbose only since the current behaviour is certainly not a great default. We can add subsequent improvements to how we report on hooks firing as need arises (though honestly no one complained about this so far, perhaps hooks are not all that commonly used). On Fri, Jun 13, 2014 at 5:00 PM, Michal Mocny mmo...@chromium.org wrote: running X hooks is not trivial to implement given how it works today. You would have to pre-calculate how many scripts will run in response to any action, and some actions are compound. I.e. cordova run you have to count before/after from all of {prepare, build, run} (and more?), and we just don't do that sort of accounting right now. Its not that difficult to add and we should file a feature request to better manage how hooks run, but I'm pretty sure there are better uses of effort short-term. -Michal On Fri, Jun 13, 2014 at 4:08 PM, Lorin Beer lorin.b...@gmail.com wrote: as someone who uses hooks, I think that's a good idea 1. non verbose mode should simply output something like running X hooks 2. verbose mode can output more details of the scripts being run On Fri, Jun 13, 2014 at 1:05 PM, Michal Mocny mmo...@google.com wrote: https://issues.apache.org/jira/browse/CB-6942 On Fri, Jun 13, 2014 at 3:51 PM, Michal Mocny mmo...@google.com wrote: Hey all, I'd like to change cordova-cli to not always print multiple messages like Running command: ... when it runs hooks. I'd like this to happen only if you have verbose logging on (with -d or --verbose). I think this was a regression added in February, but since its been in a few releases with no complaints (likely because most projects don't use hooks), I wonder if others feel this is a useful default (I don't think it is)? Tommy: you guys use hooks in your projects a lot, what do you think? If it is a useful default, I'll instead add a way to opt-out without disabling absolutely all logging with --silent. -Michal -- Carlos Santana csantan...@gmail.com
Re: Browserify JS is in
Awesome Anis. Will gladly take a look at this later today. Just wanted to send a quick thanks for landing this this way, and for the useful report. -Michal On Fri, Jun 13, 2014 at 7:55 PM, Anis KADRI anis.ka...@gmail.com wrote: Yo, Just wanted to let everyone know that I added browserify support to plugman (behind a flag for now). CLI is not hooked to this yet. Here is how it works: plugman install --browserify --plugin [PLUGIN] --platform [PLATFORM] --project [PROJECT_PATH] will generate a browserify version of cordova.js. Plugins and everything is bundled in. This version passes mobile-spec on iOS and Android. I am not yet setup to test other platforms. plugman install --plugin [PLUGIN] --platform [PLATFORM] --project [PROJECT_PATH] Will continue to generate cordova.js the way it used to. Because some of you really care about benchmarks here is some comparison for dependencies-plugin install: No browserify: real 0m9.546s user 0m4.673s sys 0m0.692s Browserify: real 0m9.861s user 0m4.759s sys 0m0.648s All cordova-lib tests are passing so I am assuming this has minimal impact but LET ME KNOW otherwise. Anis
documentation for adding a new platform to cordova
Hey, Just wished to ask where is the detail documentation of adding a platform ? As I explore for sugar, and go through the repositories, there are soo many things to do but there isn't a word about them anywhere.I wonder how the other platforms made it. Are there some dedicated persons , a few helpful ones , who collaborate and help to add the platform to cordova ? please reply. Thanks, Puneet
opened a ticket to add sugar as a platform to cordova
Hey all, I have opened a ticket to add sugar as a platform to cordova : https://issues.apache.org/jira/browse/CB-6948 Your views are welcome :-) Regards, Puneet
Re: WKWebView for iOS8
Awesome. Shaz (or anyone else), curious if you've tested yet to see if the whitelist still works with WKWebView? (e.g. does it go through NSURLProtocol?) On Sat, Jun 14, 2014 at 8:16 PM, tommy-carlos williams to...@devgeeks.org wrote: This looks promising. Thanks for the update, Shazron. - tommy On Sun, Jun 15, 2014 at 7:48 AM, Shazron shaz...@gmail.com wrote: Rev log: http://trac.webkit.org/log/trunk/Source/WebKit2/ UIProcess/API/Cocoa/WKWebView.mm for potential WKWebView updates in beta 2. On Sat, Jun 14, 2014 at 2:46 PM, Shazron shaz...@gmail.com wrote: Some potential good news. Updated 4 days ago, hopefully its in beta 2: http://trac.webkit.org/changeset/169765 Add -[WKWebView evaluateJavaScript:completionHandler:] Updated: https://issues.apache.org/jira/browse/CB-6884 On Sat, Jun 7, 2014 at 10:06 PM, Carlos Santana csantan...@gmail.com wrote: ok, was a bit confuse with api doc, I assumed that there was a way to specify a time other than documentstart, documentend, and no passing something will do it immediately. Will open a radar too, we need wkwebview to officialy support for objc-js, postMessage seems kind of half working if only can do js-objc On Sat, Jun 7, 2014 at 10:48 PM, Shazron shaz...@gmail.com wrote: No it's not. That is precisely what we discussed, it's the limitation in WKUserScript. On Saturday, June 7, 2014, Carlos Santana csantan...@gmail.com wrote: Shaz I think the closest replacement is [1] - (void)addUserScript:( WKUserScript *)*userScript * I have not tried my self, but looking forward on helping out. [1]: https://developer.apple.com/library/prerelease/ios/ documentation/WebKit/Reference/WKUserContentController_Ref/ index.html#//apple_ref/occ/instm/WKUserContentController/addUserScript : On Fri, Jun 6, 2014 at 12:47 AM, Shazron shaz...@gmail.com wrote: No use in polling if we can't write anything back to JS from Obj-C. There's a private API to do so: https://github.com/WebKit/webkit/commit/ adb4c60064b38b5ab3d6e78422325f35f0b7fe2b only landed a few months ago, we'll have to do some advocacy through whatever channels we have to get it in the public API (radars, connections), since it is a deficiency in their API losing something like stringByEvaluatingJavaScriptFromString On Thu, Jun 5, 2014 at 6:09 PM, Michal Mocny mmo...@chromium.org wrote: Oh wow. I totally assumed that you can postMessage in either direction at any time. Wouldn't the alternative be polling from JS? -Michal On Thu, Jun 5, 2014 at 6:46 PM, Shazron shaz...@gmail.com wrote: Well seems like the answer in iOS 8 beta 1 is -- no arbitrary sending of JS, so no Obj-C - JS communication, which leaves Cordova handcuffed. Please everyone file radars for this. https://devforums.apple.com/message/975230#975230 On Thu, Jun 5, 2014 at 3:40 PM, Shazron shaz...@gmail.com wrote: Thanks Tommy - I sure will. I think injecting JavaScript at arbitrary times -- you would just use WKUserScriptInjectionTimeAtDocumentEnd for WKUserScript -- although I haven't tested it. If setting JS at arbitrary times is taken away - yikes. Anyways, on the bridge front, I've posted my approach for the new bridge: https://issues.apache.org/jira/browse/CB-6884 On Thu, Jun 5, 2014 at 2:06 PM, Tommy Williams to...@devgeeks.org wrote: I am sure you won't need it, but if I can help, let me know. I think the biggest hurdle will be firing user scripts at arbitrary times instead of only on page load.. There seems to be an API that hasn't been exposed :/ On 6 Jun 2014 04:59, Shazron shaz...@gmail.com wrote: My intent is to work on this today, in a branch for cordova-ios: https://issues.apache.org/jira/browse/CB-6863 On Wed, Jun 4, 2014 at 10:15 AM, Shazron shaz...@gmail.com wrote: Use Safari to watch Introducing the Modern WebKit API (no login required): https://developer.apple.com/videos/wwdc/2014/ On Wed, Jun 4, 2014 at 8:25 AM, Michal Mocny mmo...@chromium.org wrote: You can probably bet on it. But this is really fresh news, we're as excited as you are, trying to figure out the details. On Wed, J-- Carlos Santana csantan...@gmail.com javascript:; -- Carlos Santana csantan...@gmail.com
Re: File-transfer: delete target file on process error
I think this behaviour has been around for a while, and makes sense in the majority of cases. Best practice is to download to a temporary location, and then upon success move the file to its final spot. That said, I think it'd be fine to add an option for not delete on error. On Mon, Jun 16, 2014 at 5:39 AM, Javier Puerto jav...@apache.org wrote: Hi Cordova developers, I'm creating a system to download/update several resources from a server to the device and I've observe a behaviour that breaks my use case. After fix the issue CB-6928, I'm able to download/update all the resources without problems. My next test was to try to download the resources but with no server response (stopped). I've found that the plugin is deleting my target file silently because there's was an error. I think that the developer should be the responsible to delete or leave the corrupted file because the file-transfer plugin already communicates the error, I don't think that the hardcoded behaviour is a good solution. What do you think? I can open a new issue and provide the patch and test case (Android only) Best regards.
Re: WKWebView for iOS8
Haven't yet - but from what I read - no. Something about requests being out of process On Monday, June 16, 2014, Andrew Grieve agri...@chromium.org wrote: Awesome. Shaz (or anyone else), curious if you've tested yet to see if the whitelist still works with WKWebView? (e.g. does it go through NSURLProtocol?) On Sat, Jun 14, 2014 at 8:16 PM, tommy-carlos williams to...@devgeeks.org javascript:; wrote: This looks promising. Thanks for the update, Shazron. - tommy On Sun, Jun 15, 2014 at 7:48 AM, Shazron shaz...@gmail.com wrote: Rev log: http://trac.webkit.org/log/trunk/Source/WebKit2/ UIProcess/API/Cocoa/WKWebView.mm for potential WKWebView updates in beta 2. On Sat, Jun 14, 2014 at 2:46 PM, Shazron shaz...@gmail.com wrote: Some potential good news. Updated 4 days ago, hopefully its in beta 2: http://trac.webkit.org/changeset/169765 Add -[WKWebView evaluateJavaScript:completionHandler:] Updated: https://issues.apache.org/jira/browse/CB-6884 On Sat, Jun 7, 2014 at 10:06 PM, Carlos Santana csantan...@gmail.com wrote: ok, was a bit confuse with api doc, I assumed that there was a way to specify a time other than documentstart, documentend, and no passing something will do it immediately. Will open a radar too, we need wkwebview to officialy support for objc-js, postMessage seems kind of half working if only can do js-objc On Sat, Jun 7, 2014 at 10:48 PM, Shazron shaz...@gmail.com wrote: No it's not. That is precisely what we discussed, it's the limitation in WKUserScript. On Saturday, June 7, 2014, Carlos Santana csantan...@gmail.com wrote: Shaz I think the closest replacement is [1] - (void)addUserScript:( WKUserScript *)*userScript * I have not tried my self, but looking forward on helping out. [1]: https://developer.apple.com/library/prerelease/ios/ documentation/WebKit/Reference/WKUserContentController_Ref/ index.html#//apple_ref/occ/instm/WKUserContentController/addUserScript : On Fri, Jun 6, 2014 at 12:47 AM, Shazron shaz...@gmail.com wrote: No use in polling if we can't write anything back to JS from Obj-C. There's a private API to do so: https://github.com/WebKit/webkit/commit/ adb4c60064b38b5ab3d6e78422325f35f0b7fe2b only landed a few months ago, we'll have to do some advocacy through whatever channels we have to get it in the public API (radars, connections), since it is a deficiency in their API losing something like stringByEvaluatingJavaScriptFromString
cordova 3.5 ios app stuck on splashscreen after long idle on after force close
hi list sorry to post here but i still have this damn problem only on ios (iphone 3gs, ios 6.1) since months everything is in the title but, the first time i launch my app i see the splashscreen then few seconds later i see the spinner then my app launch normally, right ... now, if i force close the app from multitask or let it turn for few hours the reopen it from multitask i have the splashcreen showing again but no spinner and the phone is completely frozen ... it reboot alone few minutes later or i have to reboot it myself i don t have any problems with the same code on android and the app works fine the first time i launch it so what could be the problem ? can i remove the splashcreen on ios ? if you want some infos let me know and how do we (officially) test an ios app on the iphone with cordova without signing it ? (for the moment i send it thru xcode and i edited a file to be able to not code sign the package) *thanks* !
[GitHub] cordova-plugin-globalization pull request: The ISO 639-2 code is r...
Github user svkirans closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...
Github user drkemp commented on the pull request: https://github.com/apache/cordova-app-harness/pull/1#issuecomment-46198612 That was an oops. Meant to change the parameter - change submitted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: cordova 3.5 ios app stuck on splashscreen after long idle on after force close
This is a mailing list for the development of Cordova itself, not a user list. Please file an issue at: http://issues.apache.org/jira/browse/CB ... so it can be tracked and evaluated by the devs, and you can be notified. Sign up here: https://issues.apache.org/jira/secure/Signup!default.jspa Thanks! On Mon, Jun 16, 2014 at 8:26 AM, smo s.la...@gmail.com wrote: hi list sorry to post here but i still have this damn problem only on ios (iphone 3gs, ios 6.1) since months everything is in the title but, the first time i launch my app i see the splashscreen then few seconds later i see the spinner then my app launch normally, right ... now, if i force close the app from multitask or let it turn for few hours the reopen it from multitask i have the splashcreen showing again but no spinner and the phone is completely frozen ... it reboot alone few minutes later or i have to reboot it myself i don t have any problems with the same code on android and the app works fine the first time i launch it so what could be the problem ? can i remove the splashcreen on ios ? if you want some infos let me know and how do we (officially) test an ios app on the iphone with cordova without signing it ? (for the moment i send it thru xcode and i edited a file to be able to not code sign the package) *thanks* !
Re: Plugman support for Android libraries
PR looks good (and updates tests). Don't think we need a new test. Will try and sanity check (probably tomorrow). On Fri, Jun 13, 2014 at 12:48 PM, Martin Bektchiev martin.bektch...@telerik.com wrote: Hi, I created a PR for this but didn't have time to add any new unit tests. Can you please write some? :) Martin Bektchiev AppBuilder Core Team -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Friday, June 13, 2014 5:40 PM To: dev Subject: Re: Plugman support for Android libraries Ah, okay. Yeah, when I tried it out I was seeing the not found errors because I didn't have a src to copy it in. Let's make the copying of the files automatic (can't think of why you might not want this). Want to take this on or I can do it? On Fri, Jun 13, 2014 at 8:47 AM, Martin Bektchiev martin.bektch...@telerik.com wrote: Hi Andrew, Sorry for the late reply. I just tested the change you committed and it doesn't work as expected. Why do you think that it's better to refer the custom library from within the plugin? IMO it should be copied to the project and referenced from there, because on install the project files get modified and on build all temporary files are output there. I think it is better to not pollute the plugin directory with these changes. We could either make the copying of the library automatic or leave it to be specified in the plugin.xml as a src element (as was my initial intention). Looking forward to your thoughts on this! ~Martin Bektchiev -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Friday, June 6, 2014 11:26 PM To: dev Subject: Re: Plugman support for Android libraries Just tested this out today! Everything worked great except it tried to find my custom library within the project dir instead of within the plugin. Fixed it with: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/04588a42 But wanted to check that you think this is correct. On Thu, May 15, 2014 at 4:28 AM, Martin Bektchiev martin.bektch...@telerik.com wrote: Thank you all for the comments. I think that Andrew is right and the best approach would be to implement it inside plugman. I have created a new JIRA issue and intend to start working on it: https://issues.apache.org/jira/browse/CB-6698 I suggest the syntax in plugin.xml to be framework src=path/to/library /. Do you think that it will be good to require specification of the custom=true attribute or not? -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Monday, May 12, 2014 5:35 PM To: dev Subject: Re: Plugman support for Android libraries Adding library support would be a definite win. android update project is what we use in our create / update script right now, and it has the side-effect of creating duplicate library entries each time you update your project. Writing logic to manually edit the project.properties file would be better I think. On Mon, May 12, 2014 at 2:55 AM, Martin Bektchiev martin.bektch...@telerik.com wrote: Hi guys, I want to ask you for ideas about how would it be best to solve an issue that I'm facing. Sometimes a plugin's implementation depends on a native library, but there's no easy way to embed it as a .jar file in Android if the library has resources. Let's take https://github.com/phonegap/phonegap-facebook-plugin and https://github.com/wildabeast/BarcodeScanner for example. The former one can't be automatically installed and requires manually adding the FacebookSDK library. While the latter one relies on a gross hack which copies the resource files to the Cordova application project and then dynamically finds their IDs instead of using the R.* class. This is far from optimal because it makes updating the underlying library a lot more difficult, adds a lot of overhead in the plugin.xml file, adds performance overhead at runtime for retrieving the IDs and most importantly doesn't always work (e.g. the plugin installation will fail if the app itself contains a res/values/colors.xml file). Instead of these approaches it would be much better if plugman was capable of adding library references itself. How do you think that this should be implemented? Is it a good idea to use the framework tag? Should the implementation depend on calling android update project or would it be better to directly edit the project.properties file? Any ideas and suggestions will be more than welcome! Looking forward to your thoughts! Best regards, Martin Bektchiev
Re: Browserify JS is in
Cool, yes! Thanks for the update! Is there a JIRA for this? Was asked in https://issues.apache.org/jira/browse/CB-5671. On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny mmo...@chromium.org wrote: Awesome Anis. Will gladly take a look at this later today. Just wanted to send a quick thanks for landing this this way, and for the useful report. -Michal On Fri, Jun 13, 2014 at 7:55 PM, Anis KADRI anis.ka...@gmail.com wrote: Yo, Just wanted to let everyone know that I added browserify support to plugman (behind a flag for now). CLI is not hooked to this yet. Here is how it works: plugman install --browserify --plugin [PLUGIN] --platform [PLATFORM] --project [PROJECT_PATH] will generate a browserify version of cordova.js. Plugins and everything is bundled in. This version passes mobile-spec on iOS and Android. I am not yet setup to test other platforms. plugman install --plugin [PLUGIN] --platform [PLATFORM] --project [PROJECT_PATH] Will continue to generate cordova.js the way it used to. Because some of you really care about benchmarks here is some comparison for dependencies-plugin install: No browserify: real 0m9.546s user 0m4.673s sys 0m0.692s Browserify: real 0m9.861s user 0m4.759s sys 0m0.648s All cordova-lib tests are passing so I am assuming this has minimal impact but LET ME KNOW otherwise. Anis
Re: cordova plugin splashscreen
Thanks Axel. It looks like the Icon and Splash Screen guide mentions doing it this way but I will update the Android Quirks section. Good catch. On Sat, Jun 14, 2014 at 3:42 PM, Axel Nennker ignisvul...@gmail.com wrote: Hi, I think that the section about Android quirks is outdated: https://github.com/apache/cordova-plugin-splashscreen/blob/master/doc/index.md Because the time to show the splash screen is now handled here, right? https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaActivity.java#L392 I think that these line should be removed: For Android, you also have to edit your projects main java file. You must add a second parameter representing a time delay to your super.loadUrl. super.loadUrl(Config.getStartUrl(), 1); -Axel
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
GitHub user dzeims opened a pull request: https://github.com/apache/cordova-plugin-file/pull/52 CB-6940: Android: context.getExternal* methods return null if sdcard isn't in mou... ...nted state, causing exceptions that prevent startup from reaching readystate You can merge this pull request into a Git repository by running: $ git pull https://github.com/dzeims/cordova-plugin-file master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit dabbd00804d8f68d2929bd96da82f184d84aaffe Author: dzeims dze...@users.noreply.github.com Date: 2014-06-16T18:24:23Z CB-6940: context.getExternal* methods return null if sdcard isn't in mounted state, causing exceptions that prevent startup from reaching readystate --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Proposal] Cordova guidelines part of ContributorWorkflow
I don't think we need to vote for anything but releases. Unless we cannot agree and decide a vote is all that can settle (unlikely). FWIW, I also like semicolons, but I wasn't aware when/why this jshint setting was made. -Michal On Fri, Jun 13, 2014 at 5:46 PM, Jesse purplecabb...@gmail.com wrote: Rebooting this thread. I just noticed a ton of missing semicolons in the cordova-cli/src/cli.js, so I ran jshint and discovered that we explicitly set asi:true I don't think we agreed on semicolon use, I for one want to see semicolons because of the fact that they clearly demonstrate the intent of the developer. Let me know if we need a vote thread. @purplecabbage risingj.com On Fri, Apr 25, 2014 at 10:05 AM, Mark Koudritsky kam...@google.com wrote: Jshint seems to have pretty good defaults, so a short config line like this might be enough for most node js files we have. /* jshint node:true, unused:true, indent:4 */ One very simple option it is to start adding this config line in every file, and then just run jshint without any extra config. This also allows for slight variations between the files, e.g. sub:true is useful for files that deal with XML parsing to prevent jshint from complaining about doc['key'] where doc.key looks like better JS but is not really appropriate because it's an XML doc. Jasmine files will need pretty long whitelist of globals since (afaik) there is no Jasmine preset for jshint. The other config method that allows for different configs for parts of the project are several .jshintrc files, e.g. one in src/ and another one in spec/. On Thu, Apr 24, 2014 at 6:15 PM, Shazron shaz...@gmail.com wrote: jshint doesn't focus on formatting: jscs does, and is like uncrustify that I mentioned. As for a jshint-like thing for non-JS platforms, for iOS - there is OCLint http://oclint.org/ On Thu, Apr 24, 2014 at 2:22 PM, Jesse purplecabb...@gmail.com wrote: I agree that jshint is awesome and powerful, I use it all the time, and so should you. That seems like a great end to this discussion ... Otherwise, how do we address the 50% of our code that is not JS? @purplecabbage risingj.com On Thu, Apr 24, 2014 at 2:15 PM, Martin Gonzalez Glez martin.c.glez.g...@gmail.com wrote: jshint is really cool. Agree, +1 for jshint. A couple of questions about this, which are gonna be the validation rules? I mean, we have to be in the same page about which are gonna be those rules. Besides, how the users are going to use it? First they need to have the node module installed, and then, use a set of validation rules that we are going to provide? How it's gonna be? use a .jshintrc file with all the rules, general rules provided by the community, or each cordova component would contain a jshintConfig/package.json with specific validation rules. CLI+rules, platforms + rules, plugins + rules It's gonna be optional(recommended)or as requirement to deliver code, the usage of jshint before commit files? the contributors would need send any evidence, that proves that their code has passed the validation? Any thoughts? Jshint, it's awesome and a really good solution, I really like it. -Martin. 2014-04-24 10:55 GMT-05:00 Marcel Kinard cmarc...@gmail.com: Big +1 for jshint. On Apr 23, 2014, at 5:53 PM, Brian LeRoux b...@brian.io wrote: This may get rotten eggs thrown at me but I think it would be good to add jshint to the project.
[GitHub] cordova-coho pull request: CB-6941 gnode: Tell people to run npm i...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Github user dzeims commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46218127 I've updated the try/catch blocks and wrapped them with an Environment.getExternalStorageState() check I noticed was being used in FileUtils. From what I could tell, the documentation only seemed to narrow down the exception type to IOException. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Github user dzeims commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46221077 My mistake, it should be NullPointerException. Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
plugin test framework
Hi, after some discussions here with IBM management, we’re going to bring in a couple extra interns for a week to jumpstart the migration of the tests out of mobile-spec into the new plugin test framework. Staci Cooper will be leading this effort, and Martin Gonzalez will be a part of it. So if you see a bunch of pull requests, this is what it is for. We’ll get the interns to submit an ICLA asap.
staff change
Wanted to let the community know about a staff change here at IBM. James Jong, who has been working in the iOS area, is transferring to a different department internally to work on a new product. He will be using Cordova and writing some new native code for the product, so he’s a natural fit, though we are sad to see him step away from the Cordova team. We should expect to see James from time to time, since he’s now wearing a consumer hat. His cube is still next to mine, so I can throw things at him if needed. We just gained a new person to help backfill James. Eric Weiterman just graduated from college and is joining us. Eric is new to iOS, but is training and coming up to speed. Friday he deployed mobile-spec to an iPhone and ran through the tests ;-) We should see pull requests coming from him soon, and he is exercising our README.md’s. Thanks!
Re: plugin test framework
Fantastic! I'll try to keep an eye out on the PR's, and please ping me if you would like any help. -Michal On Mon, Jun 16, 2014 at 3:25 PM, Marcel Kinard cmarc...@gmail.com wrote: Hi, after some discussions here with IBM management, we’re going to bring in a couple extra interns for a week to jumpstart the migration of the tests out of mobile-spec into the new plugin test framework. Staci Cooper will be leading this effort, and Martin Gonzalez will be a part of it. So if you see a bunch of pull requests, this is what it is for. We’ll get the interns to submit an ICLA asap.
Re: staff change
Thanks for the update. See you around James, and hello Eric! On Mon, Jun 16, 2014 at 3:40 PM, Marcel Kinard cmarc...@gmail.com wrote: Wanted to let the community know about a staff change here at IBM. James Jong, who has been working in the iOS area, is transferring to a different department internally to work on a new product. He will be using Cordova and writing some new native code for the product, so he’s a natural fit, though we are sad to see him step away from the Cordova team. We should expect to see James from time to time, since he’s now wearing a consumer hat. His cube is still next to mine, so I can throw things at him if needed. We just gained a new person to help backfill James. Eric Weiterman just graduated from college and is joining us. Eric is new to iOS, but is training and coming up to speed. Friday he deployed mobile-spec to an iPhone and ran through the tests ;-) We should see pull requests coming from him soon, and he is exercising our README.md’s. Thanks!
Re: [Proposal] Cordova guidelines part of ContributorWorkflow
I may be old school, but I like semicolons and agree. On Jun 13, 2014, at 5:46 PM, Jesse purplecabb...@gmail.com wrote: Rebooting this thread. I just noticed a ton of missing semicolons in the cordova-cli/src/cli.js, so I ran jshint and discovered that we explicitly set asi:true I don't think we agreed on semicolon use, I for one want to see semicolons because of the fact that they clearly demonstrate the intent of the developer.
Re: [Proposal] Cordova guidelines part of ContributorWorkflow
That was me who added asi:true and a bunch of code without semicolons in cli.js. The short wiki doc we have for a style guide https://wiki.apache.org/cordova/StyleGuide#line-19 says that semicolons are unnecessary visual entropy This is consistent with the comma-first style it describes in general, as most comma-first style evangelists also advocate for using no semicolons except where necessary. I somewhat took the comma-first style to its extreme in this refactoring of cli.js. That's the benefit of having no real style guide - there is nothing to violate - good for innovation in coding style :P (big sarcasm sign here). Simple votes on separate style related questions can result in an overall very strange style and are likely to leave many of us unhappy. Some other mechanism is needed for coming up with a good coherent style guide. Last time the issue of style guide was brought up on this list (iirc) people were reluctant to continue in fear of holy wars and we stayed with the current status-quo. Do we feel brave enough this time? Do we want to spend the time on this? If yes, I'll be glad to start a separate thread with some rules to keep it from deteriorating into a flame war.
Re: [Proposal] Cordova guidelines part of ContributorWorkflow
I'm agree with the use of semicolons. I think we should keep it consistent with the rest of the code, we should be on the same page about the code style. Regards. 2014-06-16 15:09 GMT-05:00 Mark Koudritsky kam...@google.com: That was me who added asi:true and a bunch of code without semicolons in cli.js. The short wiki doc we have for a style guide https://wiki.apache.org/cordova/StyleGuide#line-19 says that semicolons are unnecessary visual entropy This is consistent with the comma-first style it describes in general, as most comma-first style evangelists also advocate for using no semicolons except where necessary. I somewhat took the comma-first style to its extreme in this refactoring of cli.js. That's the benefit of having no real style guide - there is nothing to violate - good for innovation in coding style :P (big sarcasm sign here). Simple votes on separate style related questions can result in an overall very strange style and are likely to leave many of us unhappy. Some other mechanism is needed for coming up with a good coherent style guide. Last time the issue of style guide was brought up on this list (iirc) people were reluctant to continue in fear of holy wars and we stayed with the current status-quo. Do we feel brave enough this time? Do we want to spend the time on this? If yes, I'll be glad to start a separate thread with some rules to keep it from deteriorating into a flame war. -- Regards, Martin Gonzalez
[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-46233044 ICLA all signed now. Cheers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Proposal] Cordova guidelines part of ContributorWorkflow
To make it clear, I don't really care whether to use semicolons or not, but I do want cordova to have a style guide which I can follow without surprising people too much. Which is obviously not the case with our current style guide :)
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/52#issuecomment-46241179 I've accepted the first two and did the last fix at the same time. Can you close this pull request, since I don't remember how Apache wants us to do this. (I'm not kidding, I don't have the ability right in front of me) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: cordova 3.5 ios app stuck on splashscreen after long idle on after force close
problem reported here: https://issues.apache.org/jira/browse/CB-6952 ps: even if the PID is not listed anymore the app won t restart … thanks Le 16 juin 2014 à 22:39, smo s.la...@gmail.com a écrit : hi thanks just found the problem (i think) i downloaded the devicestats app from the App Store i killed my app but the process PID is still there…. don t know why thanks Le 16 juin 2014 à 18:22, Shazron shaz...@gmail.com a écrit : This is a mailing list for the development of Cordova itself, not a user list. Please file an issue at: http://issues.apache.org/jira/browse/CB ... so it can be tracked and evaluated by the devs, and you can be notified. Sign up here: https://issues.apache.org/jira/secure/Signup!default.jspa Thanks! On Mon, Jun 16, 2014 at 8:26 AM, smo s.la...@gmail.com wrote: hi list sorry to post here but i still have this damn problem only on ios (iphone 3gs, ios 6.1) since months everything is in the title but, the first time i launch my app i see the splashscreen then few seconds later i see the spinner then my app launch normally, right ... now, if i force close the app from multitask or let it turn for few hours the reopen it from multitask i have the splashcreen showing again but no spinner and the phone is completely frozen ... it reboot alone few minutes later or i have to reboot it myself i don t have any problems with the same code on android and the app works fine the first time i launch it so what could be the problem ? can i remove the splashcreen on ios ? if you want some infos let me know and how do we (officially) test an ios app on the iphone with cordova without signing it ? (for the moment i send it thru xcode and i edited a file to be able to not code sign the package) *thanks* !
[GitHub] cordova-plugin-device pull request: Use Windows system calls to ge...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/14#issuecomment-46241419 And there you are ... https://people.apache.org/committer-index.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file-transfer pull request: properly uses the fileK...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6940: Android: context.getExt...
Github user dzeims closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: Update FileProxy.js
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/34#issuecomment-46251489 for some reason that did not close it ... Please close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-46251564 This code is fully merged. Please close this pull request. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: Update FileProxy.js
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: Add win8 support for readAsBinar...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Support for Windows Universal apps (Windows 8.1 and Windows Phone 8.1)
I have discussed this at length already with Parashuram and completely support the proposal as documented, which might not be evident from just looking at the docs and links. Since there has not been much action on this item, I think we are okay to just move ahead Parashuram. Let's consider this last call. Cheers, Jesse @purplecabbage risingj.com On Thu, Jun 12, 2014 at 12:21 PM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: Hi, With Windows 8.1 and Windows Phone 8.1 platforms released, it would be great to get Cordova support building apps for those platforms too. A lot of people on this list have also been talking about how to adapt existing apps to the new 8.1 platforms. Here is an initial proposal and prototype of how it may look. TL;DR; - Rename windows8 platform to be called windows. This platform can build apps for Windows 8, Windows 8.1 and Windows Phone 8.1. Window Phone 8 (wp8) stays as a platform. Link to the document - https://onedrive.live.com/redir?resid=DEA20E6DC28C96DD!2781authkey=!APz1za6lnJhsaaQithint=file%2c.docx Prototype Code - https://github.com/msopentech/cordova-cli/tree/win81 - https://github.com/msopentech/cordova-windows/tree/win81 - https://github.com/msopentech/cordova-lib/tree/win81 As discussed in the Cordova hangouts yesterday, we could have a mini-hangout for discussing this in a more focused manner. Please reply to this thread if you are interested in this and I could set up the hangouts.
RE: Cordova strategy for Hosted Apps
The origin of the question... I'm trying to figure out where an investment makes the most sense. -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, June 10, 2014 11:31 AM To: dev@cordova.apache.org Subject: Re: Cordova strategy for Hosted Apps Well, here's what we know. Most developers use Chrome Devtools, Webkit Inspector, IE Developer Tools, and, increasingly, Firefox Devtools to build their apps. They treat Cordova less as an authoring env and more as a publishing step to test/qa. This is an important distinction to acknowledge. Anything we can do as a project to reduce friction in the authoring experience is good for our developer community and Cordova. The team I'm with is on board with this mission and we are working towards it. So why aren't we working on it? Well, we are. But not directly. We ran into architectural issues with the generated cordova.js code that needed attention first. (Its too big and not really friendly to good web publishing practices.) We're close to addressing that but it will require a great deal of testing. With cordova.js cleaned up we'll be revisiting our tooling to abstract out common functionality. Creating a project, for example, requires the entire cordova-lib so we need to refactor that stuff out, so we can ultimately create the smallest, most isolated, discreet, and intelligent builds for the browser possible. The project that started Cordova had a stated goal to enable web development. I view the 'browser as a platform' as work towards that original goal. I can't speak to Cordova project strategy overall, no one can, but I can advocate a direction where we make publishing to the web a seamless and supported part of the Cordova workflow. If you want an idea to succeed in open source ultimately you'll have to sponsor some sort of development so hopefully Microsoft agrees. =) On Tue, Jun 10, 2014 at 8:38 AM, Jeff Burtoft jeffb...@microsoft.com wrote: My hesitation with integrating with Cordova for the pure hosted app solution is that it seems like there are a lot of work-arounds (and not supported on some platforms like windows 8) to make it happen. My fear is that as Cordova continues to mature, the hosted app solution may get even less support. That's why I'm wondering if it is officially part of the strategy. What are your thoughts on this? -Original Message- From: Marcel Kinard [mailto:cmarc...@gmail.com] Sent: Monday, June 9, 2014 3:05 PM To: dev@cordova.apache.org Subject: Re: Cordova strategy for Hosted Apps To elaborate a bit more on #1, I've seen issues where the cordova.js in the hosted content gets out-of-sync with the native Cordova runtime installed on the device. Weird behavior can ensue when there are changes across Cordova versions in the js-native interactions. One brute-force way to deal with this would be to locally inspect the version of the native Cordova runtime, and ask the remote server to serve up the matching version of cordova.js. The folks writing hosted apps like this don't see this design wrinkle until they are debugging weird behavior. On Jun 6, 2014, at 4:24 PM, Jesse purplecabb...@gmail.com wrote: Hi Jeff, 1. Currently (out of the box) you can load the start page from the network or the device file system. However, you need to be aware of both CORS issues as well as App store policies which may make this approach un-submittable [1] . You can achieve this either by setting the content src=''/ in your config.xml file, or by redirecting from the index.html that is packaged with your app. The latter approach allows you to respond to no-network issues, which you must do in mobile anyway. cordova.js will need to live with your server pages, and any plugins, and cordova_plugins.js and all plugin files must match the versions of the native implementation that is compiled in the app. 2. Yes, it is a great way of testing, as you can skip the whole build, and just reload. If the app should function with/without the feature, then yes, it should detect it. 3. Similar to what you describe in #2, for targeting browsers generically. [1] 2.12 Apps that are not very useful, unique, are simply web sites bundled as Apps, or do not provide any lasting entertainment value may be rejected. https://developer.apple.com/appstore/resources/approval/guidelines.h tm l Cheers, Jesse @purplecabbage risingj.com On Fri, Jun 6, 2014 at 1:02 PM, Jeff Burtoft jeffb...@microsoft.com wrote: I have a tool that allows developers to take their web apps and build them into hosted store apps on Windows 8.1 and Windows Phone (8 and 8.1) called the Web App Templatehttps://wat.codeplex.com/. Some of the developers who are using the tool would like to see it go cross platform to Android and iOS, so that the
Re: plugin test framework
Yeah, really exciting. Thanks for taking this on. On Mon, Jun 16, 2014 at 3:42 PM, Michal Mocny mmo...@chromium.org wrote: Fantastic! I'll try to keep an eye out on the PR's, and please ping me if you would like any help. -Michal On Mon, Jun 16, 2014 at 3:25 PM, Marcel Kinard cmarc...@gmail.com wrote: Hi, after some discussions here with IBM management, we’re going to bring in a couple extra interns for a week to jumpstart the migration of the tests out of mobile-spec into the new plugin test framework. Staci Cooper will be leading this effort, and Martin Gonzalez will be a part of it. So if you see a bunch of pull requests, this is what it is for. We’ll get the interns to submit an ICLA asap.
Re: [Proposal] Cordova guidelines part of ContributorWorkflow
I haven't seen our style guide followed, and generally don't think style is a thing that can really be enforced without tools or code review. How about deleting the wiki page and doubling down on jshint? Can we tell jshint to force ;s while allowing comma-first? On Mon, Jun 16, 2014 at 5:00 PM, Mark Koudritsky kam...@google.com wrote: To make it clear, I don't really care whether to use semicolons or not, but I do want cordova to have a style guide which I can follow without surprising people too much. Which is obviously not the case with our current style guide :)
[GitHub] cordova-app-harness pull request: [CB6947] move app directory by d...
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-app-harness/pull/1#discussion_r13839802 --- Diff: www/cdvah/js/HarnessServer.js --- @@ -272,15 +278,30 @@ app.updatingStatus = unzipPercentage; }) .then(function(zipAssetManifest) { -var keys = Object.keys(zipAssetManifest); -return $q.when() -.then(function next() { -var k = keys.shift(); -if (k) { -return importFile(tmpDirUrl + k, zipAssetManifest[k]['path'], app, zipAssetManifest[k]['etag']) -.then(next); -} -}); +if (movetype == 'bulk') { +console.log('Moving files in bulk'); +return $q.when() +.then(function(){ +// get the source base path from the first file +// all files need to be in the same place +var firstfile = Object.keys(zipAssetManifest)[0]; +var fpath = tmpDirUrl + firstfile; +var pathendposition = fpath.lastIndexOf(zipAssetManifest[firstfile]['path']); +var fromurl = fpath.substr(0,pathendposition-1); +return app.directoryManager.bulkAddFile(zipAssetManifest, fromurl, tmpDirUrl); --- End diff -- bulkAddFile takes only 2 parameters. I think fromurl == tmpDirUrl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Proposal] Cordova guidelines part of ContributorWorkflow
/* jshint laxcomma: true */ at the top of a JS file should do it. Ref: http://www.jshint.com/docs/options/#laxcomma On Mon, Jun 16, 2014 at 9:34 PM, Andrew Grieve agri...@chromium.org wrote: I haven't seen our style guide followed, and generally don't think style is a thing that can really be enforced without tools or code review. How about deleting the wiki page and doubling down on jshint? Can we tell jshint to force ;s while allowing comma-first? On Mon, Jun 16, 2014 at 5:00 PM, Mark Koudritsky kam...@google.com wrote: To make it clear, I don't really care whether to use semicolons or not, but I do want cordova to have a style guide which I can follow without surprising people too much. Which is obviously not the case with our current style guide :)
[GitHub] cordova-lib pull request: CB-6698 Automatically copy sub-libraries...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---