[DISCUSS] Tools Release June 4th
Sorry, don¹t see a DISCUSS thread and don¹t want to clutter the VOTE thread. Please let me know if starting a DISCUSS thread to ask a question is the wrong way to go. Shouldn¹t the pinned Android in Tools Release June 4th be bumped to ~4.0.2? Currently it is ~4.0.1: https://github.com/apache/cordova-lib/blob/5.1.x/cordova-lib/src/platforms/ platformsConfig.json - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Android plugin crash on resume when activity destroyed
I'm off for a week after tomorrow, so 2 weeks?
I'll try to get a discuss thread up tomorrow.
@purplecabbage
risingj.com
On Thu, Jun 4, 2015 at 3:00 PM, Serge Huijben s.huij...@gmail.com wrote:
Sounds great Jesse, it would be awesome to have some context awareness in a
startup event.
any idea when you could have this ready?
- Serge
Op do 4 jun. 2015 om 22:52 schreef Jesse purplecabb...@gmail.com:
Yes, I am working on a unified solution, which is to include a
pre-deviceready event which contains launch context data. This
would/could
include being launched from an intent, or a url:protocol that you have
registered, a local notification, a push notification, launch from a
secondary tile,
Typically an app that needs to maintain state should do it whenever state
changes. pause/resume events can be used as well, but there is no
specific
event for going from paused-destroyed other than possibly being able to
use window.onunload | addEventListener('unload'..
@purplecabbage
risingj.com
On Thu, Jun 4, 2015 at 1:04 PM, Dan Polivy d...@cellartracker.com
wrote:
Is there any notification to the app via JS that the activity is being
destroyed, e.g. to allow the app to save state?
FWIW, I think any plugin that invokes another intent that returns data
is
potentially vulnerable to this issue -- e.g. barcode scanner being
another
one (I have a few real world crashes on this, too -- but not as many as
for
Camera). So a more general purpose solution might be appropriate if
possible.
Dan
-Original Message-
From: Serge Huijben [mailto:s.huij...@gmail.com]
Sent: Wednesday, June 03, 2015 11:39 PM
To: dev@cordova.apache.org
Subject: Re: Android plugin crash on resume when activity destroyed
Joe, it failing on Travis was not caused by the code in the
pullrequest.
I just changed one word in the readme.md and committed that to have
Travis
build it again and now it's all good.
- Serge
Op do 4 jun. 2015 om 07:54 schreef Serge Huijben s.huij...@gmail.com
:
I must say that restoring state in the webview has not been a problem
for
me. admittedly our app is only for Android 4.1 (sdk 16) and higher.
In our app we save state all the time using localstorage, and I do
know
exaxtly where the user was at -- he was taking a picture or
selecting
one
from the gallery
that leaves me with only one possible view to deliver to the user.
I just call checkForSavedResult on the camera plugin in onDeviceReady
using a promise and if it returns a value I take the user to that
view.
localstorage is still intact so the user is non the wiser, maybe
only a
bit
confused as to why he just saw the splashscreen. if the returnvalue
is
an
empty string I take the user to the welcome view
This method could be generalised but as Joe pointed out, there's
little
chance of this occurring in plugins other than the camera plugin.
- Serge
Op wo 3 jun. 2015 om 23:31 schreef Dan Polivy d...@cellartracker.com
:
Interesting, thanks for the history, Joe and Serge.
I do probably agree with you, Joe, that this won't work well as
it'll
be
hard to restore the DOM to the correct state. I can say that for my
app,
it's pretty unlikely to get exactly back to where you started. In
prior
versions of Cordova (pre-4.0), I think that instead of a crash, the
user
experience was the app just appeared to restart itself.
At the very least, is there any possibility of better handling this
scenario at a general level so it doesn't lead to a crash? I guess a
targeted fix for the Camera plugin, to perhaps detect this and throw
an
error dialog, might be a start. I've also seen this with the barcode
scanner plugin (which uses the camera). I don't know the policy on
introducing localized strings in the core platform components, but
if
there's a way to handle that, it seems like showing the user a
(native)
notification that it failed would be appropriate.
It may also be prudent to update the plugin development guide to
discuss
this issue and how to prevent crashes from referencing uninitialized
instance variables in the intent callback.
I may also play with Serge's solution and see if it is viable, and
will
report back what I find.
Dan
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Wednesday, June 03, 2015 11:44 AM
To: dev@cordova.apache.org
Subject: Re: Android plugin crash on resume when activity destroyed
This has been a problem since we started, and there's no solution to
it
because there's no reliable way to restore state on a WebView. We
have
tried in the past, and failed miserably. I'm extremely skeptical
that
this
would even work, since this apparently
Re: [CI] Builds failing due to cordova lib version bump
Problem with that is that npm install would fail when it runs `pushd cordova-cli; npm install; popd` because cordova-lib@5.1.1 doesn't exist on npm. I believe a way around this is to do something like pushd cordova-js; npm install; npm link; popd; pushd cordova-lib/cordova-lib; npm link cordova-js; npm install; npm link; popd; pushd cordova-cli; npm link cordova-lib; npm install; npm link popd; pushd cordova-plugman; npm link cordova-lib; npm install; npm link popd; Is this possible and a easy fix? On Thu, Jun 4, 2015 at 1:03 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Sorry, the mail client lost the formatting. Here it is again: pushd cordova-lib/cordova-lib; npm install; popd; pushd cordova-cli; npm install; popd; pushd cordova-plugman; npm install; popd; pushd cordova-js; npm install; popd; coho npm-link; -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Thursday, June 4, 2015 1:02 PM To: dev@cordova.apache.org Subject: RE: [CI] Builds failing due to cordova lib version bump Hmm, I think the CI is doing it wrong then. It should be using the master version of the code, not what's on NPM. The installation steps are: pushd cordova-lib/cordova-lib; npm install; popd pushd cordova-cli; npm install; popd pushd cordova-plugman; npm install; popd pushd cordova-js; npm install; popd coho npm-link Should there be some npm links in there to use the cloned code instead of NPM? Kindly, Dmitry -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 12:57 PM To: dev@cordova.apache.org Subject: Re: [CI] Builds failing due to cordova lib version bump Sorry, I didn't publish 5.1.1 for cordova-lib and cli to npm under RC tag yet. (or plugman 0.23.3). If we needed to change something before we vote, I would have to bump all of the versions again to republish (just had to do that and remove 5.1.0 from npm). I can go ahead and publish them under RC, or we can wait until the vote is done to publish under latest. On Thu, Jun 4, 2015 at 12:43 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hey folks, The recent cordova lib version bump broke our dependencies: http://ci.apache.org/builders/cordova-windows-store8.0/builds/109/step s/npm-installing-cordova-cli/logs/stdio Kindly, Dmitry
RE: [VOTE] Partial Tools Release June 1, 2015
If we need a blog post for this one, I have one here for review: https://github.com/cordova/apache-blog-posts/blob/c1d53b7a3731a15c40101fe4b2f39041724252c3/2015-06-04-tools-release.md Thanks, Tim -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Thursday, June 4, 2015 10:36 AM To: dev@cordova.apache.org Subject: RE: [VOTE] Partial Tools Release June 1, 2015 The vote has now closed. The results are: Positive binding votes: - Murat Sutunc - Nikhil Khandelwal - Tim Barham No negative votes. The vote has passed. Thanks, Tim -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Thursday, June 4, 2015 10:16 AM To: dev@cordova.apache.org Subject: RE: [VOTE] Partial Tools Release June 1, 2015 +1 I've verified the following: * coho verify-archive * versions displayed correctly * installed android correctly -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Wednesday, June 3, 2015 5:03 PM To: dev@cordova.apache.org Subject: RE: [VOTE] Partial Tools Release June 1, 2015 +1. I verified the following: * Confirmed signature with `coho verify-archive` * Manually verified tags * Verified it picks up the 3.7.2 version of Android. Thanks, Nikhil -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, June 2, 2015 9:41 AM To: 'dev@cordova.apache.org' Subject: [VOTE] Partial Tools Release June 1, 2015 Please review and vote on this partial Tools Release (lib and cli only) by replying to this email (and keep discussion on the DISCUSS thread) This release is to provide a 4.3.1 patch that pins Android 3.7.2 (a security release). Release issue: https://issues.apache.org/jira/browse/CB-9103 The packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9103/ The packages were published from their corresponding git tags: cordova-lib: 4.3.1 (0f244f6dca) cordova-cli: 4.3.1 (327357a560) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Verified install from npm * Added and built for android and windows platforms (verified patched version of android platform was installed) Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Android plugin crash on resume when activity destroyed
Yes, I am working on a unified solution, which is to include a
pre-deviceready event which contains launch context data. This would/could
include being launched from an intent, or a url:protocol that you have
registered, a local notification, a push notification, launch from a
secondary tile,
Typically an app that needs to maintain state should do it whenever state
changes. pause/resume events can be used as well, but there is no specific
event for going from paused-destroyed other than possibly being able to
use window.onunload | addEventListener('unload'..
@purplecabbage
risingj.com
On Thu, Jun 4, 2015 at 1:04 PM, Dan Polivy d...@cellartracker.com wrote:
Is there any notification to the app via JS that the activity is being
destroyed, e.g. to allow the app to save state?
FWIW, I think any plugin that invokes another intent that returns data is
potentially vulnerable to this issue -- e.g. barcode scanner being another
one (I have a few real world crashes on this, too -- but not as many as for
Camera). So a more general purpose solution might be appropriate if
possible.
Dan
-Original Message-
From: Serge Huijben [mailto:s.huij...@gmail.com]
Sent: Wednesday, June 03, 2015 11:39 PM
To: dev@cordova.apache.org
Subject: Re: Android plugin crash on resume when activity destroyed
Joe, it failing on Travis was not caused by the code in the pullrequest.
I just changed one word in the readme.md and committed that to have Travis
build it again and now it's all good.
- Serge
Op do 4 jun. 2015 om 07:54 schreef Serge Huijben s.huij...@gmail.com:
I must say that restoring state in the webview has not been a problem for
me. admittedly our app is only for Android 4.1 (sdk 16) and higher.
In our app we save state all the time using localstorage, and I do know
exaxtly where the user was at -- he was taking a picture or selecting
one
from the gallery
that leaves me with only one possible view to deliver to the user.
I just call checkForSavedResult on the camera plugin in onDeviceReady
using a promise and if it returns a value I take the user to that view.
localstorage is still intact so the user is non the wiser, maybe only a
bit
confused as to why he just saw the splashscreen. if the returnvalue is an
empty string I take the user to the welcome view
This method could be generalised but as Joe pointed out, there's little
chance of this occurring in plugins other than the camera plugin.
- Serge
Op wo 3 jun. 2015 om 23:31 schreef Dan Polivy d...@cellartracker.com:
Interesting, thanks for the history, Joe and Serge.
I do probably agree with you, Joe, that this won't work well as it'll be
hard to restore the DOM to the correct state. I can say that for my app,
it's pretty unlikely to get exactly back to where you started. In prior
versions of Cordova (pre-4.0), I think that instead of a crash, the user
experience was the app just appeared to restart itself.
At the very least, is there any possibility of better handling this
scenario at a general level so it doesn't lead to a crash? I guess a
targeted fix for the Camera plugin, to perhaps detect this and throw an
error dialog, might be a start. I've also seen this with the barcode
scanner plugin (which uses the camera). I don't know the policy on
introducing localized strings in the core platform components, but if
there's a way to handle that, it seems like showing the user a (native)
notification that it failed would be appropriate.
It may also be prudent to update the plugin development guide to discuss
this issue and how to prevent crashes from referencing uninitialized
instance variables in the intent callback.
I may also play with Serge's solution and see if it is viable, and will
report back what I find.
Dan
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Wednesday, June 03, 2015 11:44 AM
To: dev@cordova.apache.org
Subject: Re: Android plugin crash on resume when activity destroyed
This has been a problem since we started, and there's no solution to it
because there's no reliable way to restore state on a WebView. We have
tried in the past, and failed miserably. I'm extremely skeptical that
this
would even work, since this apparently failed Travis. That said, if it
does, every intent would have to manage their own state, and even when
the
plugin is loaded, we still don't know where in the app the user would be
at, so returning a photo to a part of the DOM that doesn't even exist
would
have JS errors.
Of course, this only happens when you're using a LOT of memory, like
what
Cameras tend to do, and other Intents, like for example, requesting
permission to use a Tango Service on a Project Tango plugin, (
https://github.com/infil00p/PhoneGapTango) or other third party plugins
wouldn't run into the same problems.
This is a problem with the Android
RE: [DISCUSS] Tools Release June 4th
Let us know when you have done that. We can verify the archive for voting. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 2:49 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Tools Release June 4th Good catch. That should have been updated earlier. It shouldn't make a difference though. I believe with our new ranges, it will always grab 4.0.2 when doing a cordova platform add android. I would need to add the commit to both master and 5.1.x branch for cordova-lib. Then retag and upload to dist/dev. On Thu, Jun 4, 2015 at 2:32 PM, Homer, Tony tony.ho...@intel.com wrote: Sorry, don¹t see a DISCUSS thread and don¹t want to clutter the VOTE thread. Please let me know if starting a DISCUSS thread to ask a question is the wrong way to go. Shouldn¹t the pinned Android in Tools Release June 4th be bumped to ~4.0.2? Currently it is ~4.0.1: https://github.com/apache/cordova-lib/blob/5.1.x/cordova-lib/src/platf orms/ platformsConfig.json - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [CI] Builds failing due to cordova lib version bump
On it. Kindly, Dmitry -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 1:42 PM To: dev@cordova.apache.org Subject: Re: [CI] Builds failing due to cordova lib version bump Problem with that is that npm install would fail when it runs `pushd cordova-cli; npm install; popd` because cordova-lib@5.1.1 doesn't exist on npm. I believe a way around this is to do something like pushd cordova-js; npm install; npm link; popd; pushd cordova-lib/cordova-lib; npm link cordova-js; npm install; npm link; popd; pushd cordova-cli; npm link cordova-lib; npm install; npm link popd; pushd cordova-plugman; npm link cordova-lib; npm install; npm link popd; Is this possible and a easy fix? On Thu, Jun 4, 2015 at 1:03 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Sorry, the mail client lost the formatting. Here it is again: pushd cordova-lib/cordova-lib; npm install; popd; pushd cordova-cli; npm install; popd; pushd cordova-plugman; npm install; popd; pushd cordova-js; npm install; popd; coho npm-link; -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Thursday, June 4, 2015 1:02 PM To: dev@cordova.apache.org Subject: RE: [CI] Builds failing due to cordova lib version bump Hmm, I think the CI is doing it wrong then. It should be using the master version of the code, not what's on NPM. The installation steps are: pushd cordova-lib/cordova-lib; npm install; popd pushd cordova-cli; npm install; popd pushd cordova-plugman; npm install; popd pushd cordova-js; npm install; popd coho npm-link Should there be some npm links in there to use the cloned code instead of NPM? Kindly, Dmitry -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 12:57 PM To: dev@cordova.apache.org Subject: Re: [CI] Builds failing due to cordova lib version bump Sorry, I didn't publish 5.1.1 for cordova-lib and cli to npm under RC tag yet. (or plugman 0.23.3). If we needed to change something before we vote, I would have to bump all of the versions again to republish (just had to do that and remove 5.1.0 from npm). I can go ahead and publish them under RC, or we can wait until the vote is done to publish under latest. On Thu, Jun 4, 2015 at 12:43 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hey folks, The recent cordova lib version bump broke our dependencies: http://ci.apache.org/builders/cordova-windows-store8.0/builds/109/st ep s/npm-installing-cordova-cli/logs/stdio Kindly, Dmitry
Re: Android plugin crash on resume when activity destroyed
Sounds great Jesse, it would be awesome to have some context awareness in a
startup event.
any idea when you could have this ready?
- Serge
Op do 4 jun. 2015 om 22:52 schreef Jesse purplecabb...@gmail.com:
Yes, I am working on a unified solution, which is to include a
pre-deviceready event which contains launch context data. This would/could
include being launched from an intent, or a url:protocol that you have
registered, a local notification, a push notification, launch from a
secondary tile,
Typically an app that needs to maintain state should do it whenever state
changes. pause/resume events can be used as well, but there is no specific
event for going from paused-destroyed other than possibly being able to
use window.onunload | addEventListener('unload'..
@purplecabbage
risingj.com
On Thu, Jun 4, 2015 at 1:04 PM, Dan Polivy d...@cellartracker.com wrote:
Is there any notification to the app via JS that the activity is being
destroyed, e.g. to allow the app to save state?
FWIW, I think any plugin that invokes another intent that returns data is
potentially vulnerable to this issue -- e.g. barcode scanner being
another
one (I have a few real world crashes on this, too -- but not as many as
for
Camera). So a more general purpose solution might be appropriate if
possible.
Dan
-Original Message-
From: Serge Huijben [mailto:s.huij...@gmail.com]
Sent: Wednesday, June 03, 2015 11:39 PM
To: dev@cordova.apache.org
Subject: Re: Android plugin crash on resume when activity destroyed
Joe, it failing on Travis was not caused by the code in the pullrequest.
I just changed one word in the readme.md and committed that to have
Travis
build it again and now it's all good.
- Serge
Op do 4 jun. 2015 om 07:54 schreef Serge Huijben s.huij...@gmail.com:
I must say that restoring state in the webview has not been a problem
for
me. admittedly our app is only for Android 4.1 (sdk 16) and higher.
In our app we save state all the time using localstorage, and I do know
exaxtly where the user was at -- he was taking a picture or selecting
one
from the gallery
that leaves me with only one possible view to deliver to the user.
I just call checkForSavedResult on the camera plugin in onDeviceReady
using a promise and if it returns a value I take the user to that view.
localstorage is still intact so the user is non the wiser, maybe only a
bit
confused as to why he just saw the splashscreen. if the returnvalue is
an
empty string I take the user to the welcome view
This method could be generalised but as Joe pointed out, there's little
chance of this occurring in plugins other than the camera plugin.
- Serge
Op wo 3 jun. 2015 om 23:31 schreef Dan Polivy d...@cellartracker.com:
Interesting, thanks for the history, Joe and Serge.
I do probably agree with you, Joe, that this won't work well as it'll
be
hard to restore the DOM to the correct state. I can say that for my
app,
it's pretty unlikely to get exactly back to where you started. In
prior
versions of Cordova (pre-4.0), I think that instead of a crash, the
user
experience was the app just appeared to restart itself.
At the very least, is there any possibility of better handling this
scenario at a general level so it doesn't lead to a crash? I guess a
targeted fix for the Camera plugin, to perhaps detect this and throw
an
error dialog, might be a start. I've also seen this with the barcode
scanner plugin (which uses the camera). I don't know the policy on
introducing localized strings in the core platform components, but if
there's a way to handle that, it seems like showing the user a
(native)
notification that it failed would be appropriate.
It may also be prudent to update the plugin development guide to
discuss
this issue and how to prevent crashes from referencing uninitialized
instance variables in the intent callback.
I may also play with Serge's solution and see if it is viable, and
will
report back what I find.
Dan
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Wednesday, June 03, 2015 11:44 AM
To: dev@cordova.apache.org
Subject: Re: Android plugin crash on resume when activity destroyed
This has been a problem since we started, and there's no solution to
it
because there's no reliable way to restore state on a WebView. We
have
tried in the past, and failed miserably. I'm extremely skeptical that
this
would even work, since this apparently failed Travis. That said, if
it
does, every intent would have to manage their own state, and even when
the
plugin is loaded, we still don't know where in the app the user would
be
at, so returning a photo to a part of the DOM that doesn't even exist
would
have JS errors.
Of course, this only happens when you're
[GitHub] cordova-plugin-inappbrowser pull request: Updating fork with lates...
Github user ElliottElectric closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Cordova-windows 4.0.0 release
I have a blog post up here for review: https://github.com/cordova/apache-blog-posts/pull/40 Thanks, Nikhil -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Friday, May 22, 2015 10:55 AM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-windows 4.0.0 release Does anyone have reason to delay this release? This is the first release with Windows 10 support and has a breaking change that requires an accompanying tools release. Hence, I propose we version it 4.0.0 Here are the next steps: - Prepare blog for the release include details of support of Windows 10. - Do an accompany DOCS TOOLS release. I have created a JIRA issue for this: https://issues.apache.org/jira/browse/CB-9064 I have made updates to the RELEASENOTES.md: [4.0.0-dev] * Updating appx manifest to a large extent now happens in the `prepare` step as opposed to the `build` step. This change implies that cordova-windows 4.0.0 can only work with with cordova CLI 5.0 * CB-8486 Support for creating signed package and build.json for Windows * Add preview support for Windows 10 Universal Apps. To target Windows 10, add `preference name=windows-target-version value=10.0 /` to config.xml. * The default windows target version is now 8.1. * Support for `--appx` command line argument to override the windows target version * CB-8946: Added the `WindowsToastCapable` preference to indicate that the app can support toasts. This is to support the Local Notifications plugin. * CB-8856 Fix 'Id' attribute is invalid when creating Windows Store submission build * CB-8307: Adding a 25-year expiration temporary certificate. * CB-8760 platform list doesn't show version for windows platform. **Known Issues with 4.0.0-dev and Windows 10** * Windows 10 Technical Preview 2 does not have a command-line compatible emulator deployment scenario. To deploy to an emulator, open your solution file in Visual Studio. * The Windows SDK included with Visual Studio 2015 RC does not include a tool to deploy to a Windows 10 Phone. To deploy to a phone, open your solution file in Visual Studio. * WinJS is included inline in the package. In the future, it will be migrated to an NPM dependency, and the dependency will not include any UI-related files. You should not take a dependency on WinJS UI functionality unless you include it yourself (see [WinJS on Github](http://github.com/winjs/winjs)). Thanks, Nikhil - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Tools Release June 4th
Updated: cordova-lib: 5.1.1 (83cc078229) On Thu, Jun 4, 2015 at 11:20 AM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9087 Both tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9087/ The packages were published from their corresponding git tags: cordova-js: 4.0.0 (706c4a8936) cordova-lib: 5.1.1 (ffb02197e9) cordova-plugman: 0.23.3 (45dd80134a) cordova-cli: 5.1.1 (f15612cb8c) RELEASENOTES: cordova-js: https://github.com/apache/cordova-js/blob/4.0.x/RELEASENOTES.md cordova-lib: https://github.com/apache/cordova-lib/blob/5.1.x/cordova-lib/RELEASENOTES.md cordova-plugman: https://github.com/apache/cordova-plugman/blob/0.23.x/RELEASENOTES.md cordova-cli: https://github.com/apache/cordova-cli/blob/5.1.x/RELEASENOTES.md Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran unit tests and saw that they were all building * Build a cordova project for ios and android and added a plugin.
Re: [DISCUSS] Tools Release June 4th
Done! Vote away! On Thu, Jun 4, 2015 at 3:42 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Let us know when you have done that. We can verify the archive for voting. Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 2:49 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Tools Release June 4th Good catch. That should have been updated earlier. It shouldn't make a difference though. I believe with our new ranges, it will always grab 4.0.2 when doing a cordova platform add android. I would need to add the commit to both master and 5.1.x branch for cordova-lib. Then retag and upload to dist/dev. On Thu, Jun 4, 2015 at 2:32 PM, Homer, Tony tony.ho...@intel.com wrote: Sorry, don¹t see a DISCUSS thread and don¹t want to clutter the VOTE thread. Please let me know if starting a DISCUSS thread to ask a question is the wrong way to go. Shouldn¹t the pinned Android in Tools Release June 4th be bumped to ~4.0.2? Currently it is ~4.0.1: https://github.com/apache/cordova-lib/blob/5.1.x/cordova-lib/src/platf orms/ platformsConfig.json - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Tools Release June 4th
Good catch. That should have been updated earlier. It shouldn't make a difference though. I believe with our new ranges, it will always grab 4.0.2 when doing a cordova platform add android. I would need to add the commit to both master and 5.1.x branch for cordova-lib. Then retag and upload to dist/dev. On Thu, Jun 4, 2015 at 2:32 PM, Homer, Tony tony.ho...@intel.com wrote: Sorry, don¹t see a DISCUSS thread and don¹t want to clutter the VOTE thread. Please let me know if starting a DISCUSS thread to ask a question is the wrong way to go. Shouldn¹t the pinned Android in Tools Release June 4th be bumped to ~4.0.2? Currently it is ~4.0.1: https://github.com/apache/cordova-lib/blob/5.1.x/cordova-lib/src/platforms/ platformsConfig.json - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-webos pull request: CB-6715 [webOS] Upgrade webOS Cordova ...
Github user JayCanuck closed the pull request at: https://github.com/apache/cordova-webos/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[CI] It's Beautiful
Hey all, This is what our builds are looking like right now: https://paste.apache.org/59w6. Congrats to us all! Now we just need more tests, so the builds once again stop being so annoyingly neon green. Kindly, Dmitry P.S. I hope I didn't jinx it!
Re: [CI] It's Beautiful
Woohoo! On Thu, Jun 4, 2015 at 10:29 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Awesome, congrats! -Sergey -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Thursday, June 4, 2015 8:27 PM To: dev@cordova.apache.org Subject: [CI] It's Beautiful Hey all, This is what our builds are looking like right now: https://paste.apache.org/59w6. Congrats to us all! Now we just need more tests, so the builds once again stop being so annoyingly neon green. Kindly, Dmitry P.S. I hope I didn't jinx it! - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova edge docs update needed
Steven - does this mean the update to the CLI mentioned in the Tools release won't be documented when released? On Thu, Jun 4, 2015 at 1:28 PM, Jesse purplecabb...@gmail.com wrote: Or, every 13.5 days ... @purplecabbage risingj.com On Thu, Jun 4, 2015 at 11:21 AM, Steven Gill stevengil...@gmail.com wrote: I will update the docs after the tools release. We don't have a set schedule. Right now we do it as needed. Updating docs doesn't require a vote On Wed, Jun 3, 2015 at 5:54 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I was looking to make a blog post for the Windows release, but I could not find the docs for Windows 10 on the edge version of the published docs website. How often are the docs published to the edge website? This commit introduced the change to the cordova-docs repo: 50f1d88 - Merge branch 'master' of https://github.com/apache/cordova-docs into win10 (13 days ago) Thanks, Nikhil -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8051 [webOS] Fixes webOS SmartTV detec...
Github user JayCanuck closed the pull request at: https://github.com/apache/cordova-js/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8052 [webOS] Update cordova-lib for w...
Github user JayCanuck closed the pull request at: https://github.com/apache/cordova-lib/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [CI] It's Beautiful
Awesome, congrats! -Sergey -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Thursday, June 4, 2015 8:27 PM To: dev@cordova.apache.org Subject: [CI] It's Beautiful Hey all, This is what our builds are looking like right now: https://paste.apache.org/59w6. Congrats to us all! Now we just need more tests, so the builds once again stop being so annoyingly neon green. Kindly, Dmitry P.S. I hope I didn't jinx it! - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/144#discussion_r31741687
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -87,6 +87,13 @@ module.exports.run = function (argv) {
}
return Q.nfcall(fs.writeFile, path.join(__dirname, '..',
'build-extras.xcconfig'), extraConfig, 'utf-8');
}).then(function () {
+// Ensure platform scripts are executable as the platform could be
added on non-OSX environment
+shell.find(projectPath).filter(function (file) {
--- End diff --
sounds good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] Partial Tools Release June 1, 2015
The vote has now closed. The results are: Positive binding votes: - Murat Sutunc - Nikhil Khandelwal - Tim Barham No negative votes. The vote has passed. Thanks, Tim -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Thursday, June 4, 2015 10:16 AM To: dev@cordova.apache.org Subject: RE: [VOTE] Partial Tools Release June 1, 2015 +1 I've verified the following: * coho verify-archive * versions displayed correctly * installed android correctly -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Wednesday, June 3, 2015 5:03 PM To: dev@cordova.apache.org Subject: RE: [VOTE] Partial Tools Release June 1, 2015 +1. I verified the following: * Confirmed signature with `coho verify-archive` * Manually verified tags * Verified it picks up the 3.7.2 version of Android. Thanks, Nikhil -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, June 2, 2015 9:41 AM To: 'dev@cordova.apache.org' Subject: [VOTE] Partial Tools Release June 1, 2015 Please review and vote on this partial Tools Release (lib and cli only) by replying to this email (and keep discussion on the DISCUSS thread) This release is to provide a 4.3.1 patch that pins Android 3.7.2 (a security release). Release issue: https://issues.apache.org/jira/browse/CB-9103 The packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9103/ The packages were published from their corresponding git tags: cordova-lib: 4.3.1 (0f244f6dca) cordova-cli: 4.3.1 (327357a560) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Verified install from npm * Added and built for android and windows platforms (verified patched version of android platform was installed) Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] Partial Tools Release June 1, 2015
+1 I've verified the following: * coho verify-archive * versions displayed correctly * installed android correctly -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Wednesday, June 3, 2015 5:03 PM To: dev@cordova.apache.org Subject: RE: [VOTE] Partial Tools Release June 1, 2015 +1. I verified the following: * Confirmed signature with `coho verify-archive` * Manually verified tags * Verified it picks up the 3.7.2 version of Android. Thanks, Nikhil -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, June 2, 2015 9:41 AM To: 'dev@cordova.apache.org' Subject: [VOTE] Partial Tools Release June 1, 2015 Please review and vote on this partial Tools Release (lib and cli only) by replying to this email (and keep discussion on the DISCUSS thread) This release is to provide a 4.3.1 patch that pins Android 3.7.2 (a security release). Release issue: https://issues.apache.org/jira/browse/CB-9103 The packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9103/ The packages were published from their corresponding git tags: cordova-lib: 4.3.1 (0f244f6dca) cordova-cli: 4.3.1 (327357a560) Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Verified install from npm * Added and built for android and windows platforms (verified patched version of android platform was installed) Thanks! Tim - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova edge docs update needed
I will update the docs after the tools release. We don't have a set schedule. Right now we do it as needed. Updating docs doesn't require a vote On Wed, Jun 3, 2015 at 5:54 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I was looking to make a blog post for the Windows release, but I could not find the docs for Windows 10 on the edge version of the published docs website. How often are the docs published to the edge website? This commit introduced the change to the cordova-docs repo: 50f1d88 - Merge branch 'master' of https://github.com/apache/cordova-docs into win10 (13 days ago) Thanks, Nikhil
[VOTE] Tools Release June 4th
Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9087 Both tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9087/ The packages were published from their corresponding git tags: cordova-js: 4.0.0 (706c4a8936) cordova-lib: 5.1.1 (ffb02197e9) cordova-plugman: 0.23.3 (45dd80134a) cordova-cli: 5.1.1 (f15612cb8c) RELEASENOTES: cordova-js: https://github.com/apache/cordova-js/blob/4.0.x/RELEASENOTES.md cordova-lib: https://github.com/apache/cordova-lib/blob/5.1.x/cordova-lib/RELEASENOTES.md cordova-plugman: https://github.com/apache/cordova-plugman/blob/0.23.x/RELEASENOTES.md cordova-cli: https://github.com/apache/cordova-cli/blob/5.1.x/RELEASENOTES.md Upon a successful vote I will upload the archives to dist/, publish them to NPM, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran unit tests and saw that they were all building * Build a cordova project for ios and android and added a plugin.
Re: Cordova edge docs update needed
Or, every 13.5 days ... @purplecabbage risingj.com On Thu, Jun 4, 2015 at 11:21 AM, Steven Gill stevengil...@gmail.com wrote: I will update the docs after the tools release. We don't have a set schedule. Right now we do it as needed. Updating docs doesn't require a vote On Wed, Jun 3, 2015 at 5:54 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I was looking to make a blog post for the Windows release, but I could not find the docs for Windows 10 on the edge version of the published docs website. How often are the docs published to the edge website? This commit introduced the change to the cordova-docs repo: 50f1d88 - Merge branch 'master' of https://github.com/apache/cordova-docs into win10 (13 days ago) Thanks, Nikhil
[CI] Builds failing due to cordova lib version bump
Hey folks, The recent cordova lib version bump broke our dependencies: http://ci.apache.org/builders/cordova-windows-store8.0/builds/109/steps/npm-installing-cordova-cli/logs/stdio Kindly, Dmitry
Re: [CI] Builds failing due to cordova lib version bump
Sorry, I didn't publish 5.1.1 for cordova-lib and cli to npm under RC tag yet. (or plugman 0.23.3). If we needed to change something before we vote, I would have to bump all of the versions again to republish (just had to do that and remove 5.1.0 from npm). I can go ahead and publish them under RC, or we can wait until the vote is done to publish under latest. On Thu, Jun 4, 2015 at 12:43 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hey folks, The recent cordova lib version bump broke our dependencies: http://ci.apache.org/builders/cordova-windows-store8.0/builds/109/steps/npm-installing-cordova-cli/logs/stdio Kindly, Dmitry
RE: [CI] Builds failing due to cordova lib version bump
Sorry, the mail client lost the formatting. Here it is again: pushd cordova-lib/cordova-lib; npm install; popd; pushd cordova-cli; npm install; popd; pushd cordova-plugman; npm install; popd; pushd cordova-js; npm install; popd; coho npm-link; -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Thursday, June 4, 2015 1:02 PM To: dev@cordova.apache.org Subject: RE: [CI] Builds failing due to cordova lib version bump Hmm, I think the CI is doing it wrong then. It should be using the master version of the code, not what's on NPM. The installation steps are: pushd cordova-lib/cordova-lib; npm install; popd pushd cordova-cli; npm install; popd pushd cordova-plugman; npm install; popd pushd cordova-js; npm install; popd coho npm-link Should there be some npm links in there to use the cloned code instead of NPM? Kindly, Dmitry -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 12:57 PM To: dev@cordova.apache.org Subject: Re: [CI] Builds failing due to cordova lib version bump Sorry, I didn't publish 5.1.1 for cordova-lib and cli to npm under RC tag yet. (or plugman 0.23.3). If we needed to change something before we vote, I would have to bump all of the versions again to republish (just had to do that and remove 5.1.0 from npm). I can go ahead and publish them under RC, or we can wait until the vote is done to publish under latest. On Thu, Jun 4, 2015 at 12:43 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hey folks, The recent cordova lib version bump broke our dependencies: http://ci.apache.org/builders/cordova-windows-store8.0/builds/109/step s/npm-installing-cordova-cli/logs/stdio Kindly, Dmitry
[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108975191 @omefire I don't have Android environment on Mac now, but as far as I can see there are no shell scripts in Android platform. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108966698 @daserge , does this behavior show up if for example, I add android from windows, then check it into git ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-9000 Failing properly if no test re...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/55#issuecomment-108967609 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108911479 LGTM ! - what causes file permissions to change when the platform is added on a non-OSX system ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108915724 @omefire I think that it is because git does not include exec permission for these files. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-9000 Failing properly if no test re...
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/55 CB-9000 Failing properly if no test results were found https://issues.apache.org/jira/browse/CB-9000 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic CB-9000 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-medic/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit a89b32cbedc3cab97be7f571ee6603255c9527b9 Author: alsorokin alexander.soro...@akvelon.com Date: 2015-06-04T15:03:35Z CB-9000 Failing properly if no test results were found --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Android plugin crash on resume when activity destroyed
Joe, it failing on Travis was not caused by the code in the pullrequest.
I just changed one word in the readme.md and committed that to have Travis
build it again and now it's all good.
- Serge
Op do 4 jun. 2015 om 07:54 schreef Serge Huijben s.huij...@gmail.com:
I must say that restoring state in the webview has not been a problem for
me. admittedly our app is only for Android 4.1 (sdk 16) and higher.
In our app we save state all the time using localstorage, and I do know
exaxtly where the user was at -- he was taking a picture or selecting one
from the gallery
that leaves me with only one possible view to deliver to the user.
I just call checkForSavedResult on the camera plugin in onDeviceReady
using a promise and if it returns a value I take the user to that view.
localstorage is still intact so the user is non the wiser, maybe only a bit
confused as to why he just saw the splashscreen. if the returnvalue is an
empty string I take the user to the welcome view
This method could be generalised but as Joe pointed out, there's little
chance of this occurring in plugins other than the camera plugin.
- Serge
Op wo 3 jun. 2015 om 23:31 schreef Dan Polivy d...@cellartracker.com:
Interesting, thanks for the history, Joe and Serge.
I do probably agree with you, Joe, that this won't work well as it'll be
hard to restore the DOM to the correct state. I can say that for my app,
it's pretty unlikely to get exactly back to where you started. In prior
versions of Cordova (pre-4.0), I think that instead of a crash, the user
experience was the app just appeared to restart itself.
At the very least, is there any possibility of better handling this
scenario at a general level so it doesn't lead to a crash? I guess a
targeted fix for the Camera plugin, to perhaps detect this and throw an
error dialog, might be a start. I've also seen this with the barcode
scanner plugin (which uses the camera). I don't know the policy on
introducing localized strings in the core platform components, but if
there's a way to handle that, it seems like showing the user a (native)
notification that it failed would be appropriate.
It may also be prudent to update the plugin development guide to discuss
this issue and how to prevent crashes from referencing uninitialized
instance variables in the intent callback.
I may also play with Serge's solution and see if it is viable, and will
report back what I find.
Dan
-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com]
Sent: Wednesday, June 03, 2015 11:44 AM
To: dev@cordova.apache.org
Subject: Re: Android plugin crash on resume when activity destroyed
This has been a problem since we started, and there's no solution to it
because there's no reliable way to restore state on a WebView. We have
tried in the past, and failed miserably. I'm extremely skeptical that
this
would even work, since this apparently failed Travis. That said, if it
does, every intent would have to manage their own state, and even when the
plugin is loaded, we still don't know where in the app the user would be
at, so returning a photo to a part of the DOM that doesn't even exist
would
have JS errors.
Of course, this only happens when you're using a LOT of memory, like what
Cameras tend to do, and other Intents, like for example, requesting
permission to use a Tango Service on a Project Tango plugin, (
https://github.com/infil00p/PhoneGapTango) or other third party plugins
wouldn't run into the same problems.
This is a problem with the Android architecture, and many native apps have
run into similar problems. I don't think there's a solution for this in
Cordova, and we have definitely tried.
On Wed, Jun 3, 2015 at 9:46 AM Mefire O. ommen...@microsoft.com wrote:
Interesting fix, Serge. A question comes to mind:
- Since it seems like this issue affects all android plugins that call
other intents, won't we have to do this for all of them? Is there a way
we
can leverage your PR and maybe come up with a general solution ? Maybe
fit
the boilerplate code (state saving/restoring) somewhere all android
plugins
can inherit ?
On Jun 3, 2015 3:54 AM, Serge Huijben s.huij...@gmail.com wrote:
what I did to solve this is add a check for callbackcontext, If that is
null save the incoming parameters.
if (this.callbackContext == null) {
this.savedRequestCode = requestCode;
this.savedResultCode = resultCode;
this.savedIntent = intent;
} else {
// procede as planned
This is what happens after the activity has been killed by the system
while
you are in the camera Intent.
Once you take or select your picture the mainactivity is restarted and
with
it all the plugins, after which onActivityResult is fired.
the code above saves the incoming parameters so they can be used later.
To do this I also added a new method, checkForSavedResults,
[GitHub] cordova-plugin-media-capture pull request: Various Fixes to crashe...
GitHub user aroberson opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/38 Various Fixes to crashes in Windows Phone 8 This pull request contains the following fixes. 1. The app crashes in wp8 when trying to take a picture or video and use the back arrow key. This is fixed by checking for defined file object before processing it. 2. The app crashes in wp8 when using gestures on the capture picture or capture video screens. The solution is to not use the click event and move to the MSGestures events for gestures. This change replaces the onclick event with listening for MSGestureTap event. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ABB-Austin/cordova-plugin-media-capture master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media-capture/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 600afcab6c82819d5b065311054eea9c95dd4adf Author: aroberson adam.rober...@ventyx.abb.com Date: 2015-05-19T16:14:15Z Fixed cancel of image capture to return no media commit acf815e6faa9c460c0b89fc05731b33811139f42 Author: aroberson adam.rober...@ventyx.abb.com Date: 2015-05-19T16:16:13Z remove dependency commit 18b3a8cfba95e9f2e533898d3fc116ddd5c7f3a8 Author: aroberson adam.rober...@ventyx.abb.com Date: 2015-05-19T16:19:38Z Remove file dependency commit 7af759049eaf34958f852d9ed20d9dda1c7a61ca Author: aroberson adam.rober...@ventyx.abb.com Date: 2015-05-19T16:35:57Z Added back dependency commit 13a60dd6cd48b1e477023268b5351434282357c1 Author: aroberson adam.rober...@ventyx.abb.com Date: 2015-05-20T19:57:16Z Added catch error function for unsupported actions. commit cb19f02d048f9bff131e51671314fdc9b3dac06c Author: aroberson adam.rober...@ventyx.abb.com Date: 2015-06-01T18:12:41Z Catch exceptions caused by zoom events commit 3d0af79944df315ff6d3318e773f44319b9ae3c1 Author: aroberson adam.rober...@ventyx.abb.com Date: 2015-06-04T16:28:56Z Removed the on click for camera preview and replaced with gesture tracking. commit 77b01c564989862f127b6f93411cba59add9ae29 Author: aroberson adam.rober...@ventyx.abb.com Date: 2015-06-04T18:41:26Z Fixed Tap Gesture processing for ui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Experimenting with API for cordova tooling
Hello again :) I wanted to bring your attention to this thread again. I've opened a new PR updated according to Mark's feedback and will be very grateful if someone can review this again before merging. There is also the implementation for Android platform which uses this new API provides own implementation for all PlatformAPI methods. Links to PRs: https://github.com/apache/cordova-lib/pull/235 https://github.com/apache/cordova-android/pull/179 --- Best regards, Vladimir -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Monday, May 25, 2015 7:31 PM To: dev@cordova.apache.org Subject: RE: Experimenting with API for cordova tooling Hey, guys. I would like to raise this thread again. I've done implementing a draft for Platform API interface, integrated directly into cordova-lib, that allows to use platform functionality as a node modules. The PRs for this is: Cordova-lib: https://github.com/apache/cordova-lib/pull/226 Cordova-windows (sample platform's implementation): https://github.com/apache/cordova-windows/pull/84 Here is brief details of implementation: There is PlatformApi (former PlatformProject) class -- acts as entry point for platform-related functionality. It exposes: a) methods that represent platform's actions, like 'build', 'run', etc. Base implementations of these methods acts as a wrappers around platform executable scripts, but each platform can provide its own implementation by defining Api.js module with same prototype methods, which will override methods of base implementation. Current draft contains wrappers for `build` and `requirements` commands. b) PlatformHandler instance, accessible via both `getPlatformHandler()` method and `parser` property (left for backward compatibility). The PlatformHandler class is intended to be a container for platform-specific implementations for `prepare` logic. The approach here is the same as with PlatformApi class - the platform can override default implementation (currently it's being taken from cordova\metadata\platform_parser.js file) with custom one through providing own PlatformApi.PlatformHandler class. c) PluginHandler instance - for plugin manipulation related functionality. Approach is the same as for PlatformHandler. Since this implementation provides a fallback alternatives for all new functionality, it will allow to us to seamlessly move all platform-related functionality to platforms. IMO this could be done in three steps: 1. Copy platform actions (build, run, etc. ) to platforms. (See windows PR for sample - https://github.com/MSOpenTech/cordova-windows/blob/unified_platform_api/template/cordova/Api.js ) 2. Copy `prepare`- and plugin-related logic to platforms, leave existing code for compatibility with old platforms. 3. Completely remove platform-related functionality from lib. This will break compatibility with old platforms, so we'll need to wait for some time before doing this. Would love to hear any feedback and thoughts on this. --- Best regards, Vladimir -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Saturday, 25 April, 2015 6:14 To: dev@cordova.apache.org Subject: Re: Experimenting with API for cordova tooling I like the idea of cordova-discuss, lets give it a try ) To read the md file formatted: https://github.com/kamrik/cordova-discuss/blob/master/proposals/PlatformProject.md To comment, look at the pull request https://github.com/cordova/cordova-discuss/pull/4 On Fri, Apr 24, 2015 at 10:16 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Should we move this docs to cordova-discuss instead -https://github.com/cordova/cordova-discuss ? On 4/24/15, 4:02 PM, Mark Koudritsky kam...@google.com wrote: I'm back from ApacheCon and vacation. Very glad to see some enthusiasm about this! My thoughts about the next steps turned out to be rather lengthy so here is a doc: https://docs.google.com/document/d/1jxQvygBtTeCYhxMtHLD9jgKTKZofMJdux1 UIzs dd5b0 The most important next steps are: - Take one platform and try combine the logic from cordova/metadata and plugman/platforms for it. This will help figure out some details. - Improve plugin (un)install logic in PlatformProject so that the CLI can be eventually implemented in terms of PlatformProject. Comments and discussion will be greatly appreciated! On Wed, Apr 15, 2015 at 1:52 PM, Michal Mocny mmo...@chromium.org wrote: Great enthusiasm! Mark is currently at ApacheCon and then taking a few vacation days, so I'm not sure if he will answer this quickly. Figured I'd chime in for now. I think that exactly as you say, the PlatformProject work was started by Mark as a way to separate the divide between platforms and lib. This experiment I think came out of discussions on how best to move out the platform parsers (search ML for Move
[GitHub] cordova-lib pull request: Implementation for Unified platform API
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/235 Implementation for Unified platform API An mplementation of Unified Platform API for cordova, that inspired by [this thread](http://markmail.org/thread/3dw4mis4qo5d4ecz) in cordova-dev mailing list and [this proposal](https://github.com/kamrik/cordova-discuss/blob/master/proposals/PlatformProject.md) This PR is the updated version of https://github.com/apache/cordova-lib/pull/226 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib unified_platform_api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/235.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #235 commit 5a916c978c84b36f92e39f17dac8d48db7ef927d Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2015-06-04T09:57:18Z Adds BasePlatformApi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Implementation for Unified platform ...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/179 Implementation for Unified platform API for Android platform. Draft implementation of Unified Platform API for Windows platform, that inspired by [this thread](http://markmail.org/thread/3dw4mis4qo5d4ecz) in cordova-dev mailing list and [this proposal](https://github.com/kamrik/cordova-discuss/blob/master/proposals/PlatformProject.md) Requires https://github.com/apache/cordova-lib/pull/235 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-android unified_platform_api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/179.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #179 commit 291682ea30e4000943c0def34dfc060a8ddfe219 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2015-06-04T12:31:33Z Adds PlatformApi implementation commit 5b7b52df2a20b15b9ca0f5b6b4df382785f84a53 Author: Vladimir Kotikov v-vlk...@microsoft.com Date: 2015-06-04T12:31:48Z Adds dependencies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Cancel of Image Capture...
Github user aroberson closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova edge docs update needed
I went ahead and just updated the edge documentation. We can still cut a 5.1 series of docs if we need to -Steve On Thu, Jun 4, 2015 at 11:49 AM, Raymond Camden raymondcam...@gmail.com wrote: Steven - does this mean the update to the CLI mentioned in the Tools release won't be documented when released? On Thu, Jun 4, 2015 at 1:28 PM, Jesse purplecabb...@gmail.com wrote: Or, every 13.5 days ... @purplecabbage risingj.com On Thu, Jun 4, 2015 at 11:21 AM, Steven Gill stevengil...@gmail.com wrote: I will update the docs after the tools release. We don't have a set schedule. Right now we do it as needed. Updating docs doesn't require a vote On Wed, Jun 3, 2015 at 5:54 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I was looking to make a blog post for the Windows release, but I could not find the docs for Windows 10 on the edge version of the published docs website. How often are the docs published to the edge website? This commit introduced the change to the cordova-docs repo: 50f1d88 - Merge branch 'master' of https://github.com/apache/cordova-docs into win10 (13 days ago) Thanks, Nikhil -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/144 CB-9116 Ensure platform scripts are executable as the platform could be added on non-OSX environment Corresponding [Jira issue](https://issues.apache.org/jira/browse/CB-9116) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-9116 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/144.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #144 commit 53c8b3ad2d64466b72c24e44b33d7dc648723520 Author: daserge dase...@yandex.ru Date: 2015-06-04T08:48:59Z CB-9116 Ensure platform scripts are executable as the platform could be added on non-OSX environment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Draft implementation for Unified pla...
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-windows/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/144#discussion_r31713805
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -87,6 +87,13 @@ module.exports.run = function (argv) {
}
return Q.nfcall(fs.writeFile, path.join(__dirname, '..',
'build-extras.xcconfig'), extraConfig, 'utf-8');
}).then(function () {
+// Ensure platform scripts are executable as the platform could be
added on non-OSX environment
+shell.find(projectPath).filter(function (file) {
--- End diff --
Should we check `cordova` folder only? (projectPath/cordova). My concern is
that there could be too many files in other folders like `www` so this could be
slow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Draft implementation for Unified platfor...
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [CI] Builds failing due to cordova lib version bump
Hmm, I think the CI is doing it wrong then. It should be using the master version of the code, not what's on NPM. The installation steps are: pushd cordova-lib/cordova-lib; npm install; popd pushd cordova-cli; npm install; popd pushd cordova-plugman; npm install; popd pushd cordova-js; npm install; popd coho npm-link Should there be some npm links in there to use the cloned code instead of NPM? Kindly, Dmitry -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, June 4, 2015 12:57 PM To: dev@cordova.apache.org Subject: Re: [CI] Builds failing due to cordova lib version bump Sorry, I didn't publish 5.1.1 for cordova-lib and cli to npm under RC tag yet. (or plugman 0.23.3). If we needed to change something before we vote, I would have to bump all of the versions again to republish (just had to do that and remove 5.1.0 from npm). I can go ahead and publish them under RC, or we can wait until the vote is done to publish under latest. On Thu, Jun 4, 2015 at 12:43 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hey folks, The recent cordova lib version bump broke our dependencies: http://ci.apache.org/builders/cordova-windows-store8.0/builds/109/step s/npm-installing-cordova-cli/logs/stdio Kindly, Dmitry
RE: Android plugin crash on resume when activity destroyed
Is there any notification to the app via JS that the activity is being destroyed, e.g. to allow the app to save state? FWIW, I think any plugin that invokes another intent that returns data is potentially vulnerable to this issue -- e.g. barcode scanner being another one (I have a few real world crashes on this, too -- but not as many as for Camera). So a more general purpose solution might be appropriate if possible. Dan -Original Message- From: Serge Huijben [mailto:s.huij...@gmail.com] Sent: Wednesday, June 03, 2015 11:39 PM To: dev@cordova.apache.org Subject: Re: Android plugin crash on resume when activity destroyed Joe, it failing on Travis was not caused by the code in the pullrequest. I just changed one word in the readme.md and committed that to have Travis build it again and now it's all good. - Serge Op do 4 jun. 2015 om 07:54 schreef Serge Huijben s.huij...@gmail.com: I must say that restoring state in the webview has not been a problem for me. admittedly our app is only for Android 4.1 (sdk 16) and higher. In our app we save state all the time using localstorage, and I do know exaxtly where the user was at -- he was taking a picture or selecting one from the gallery that leaves me with only one possible view to deliver to the user. I just call checkForSavedResult on the camera plugin in onDeviceReady using a promise and if it returns a value I take the user to that view. localstorage is still intact so the user is non the wiser, maybe only a bit confused as to why he just saw the splashscreen. if the returnvalue is an empty string I take the user to the welcome view This method could be generalised but as Joe pointed out, there's little chance of this occurring in plugins other than the camera plugin. - Serge Op wo 3 jun. 2015 om 23:31 schreef Dan Polivy d...@cellartracker.com: Interesting, thanks for the history, Joe and Serge. I do probably agree with you, Joe, that this won't work well as it'll be hard to restore the DOM to the correct state. I can say that for my app, it's pretty unlikely to get exactly back to where you started. In prior versions of Cordova (pre-4.0), I think that instead of a crash, the user experience was the app just appeared to restart itself. At the very least, is there any possibility of better handling this scenario at a general level so it doesn't lead to a crash? I guess a targeted fix for the Camera plugin, to perhaps detect this and throw an error dialog, might be a start. I've also seen this with the barcode scanner plugin (which uses the camera). I don't know the policy on introducing localized strings in the core platform components, but if there's a way to handle that, it seems like showing the user a (native) notification that it failed would be appropriate. It may also be prudent to update the plugin development guide to discuss this issue and how to prevent crashes from referencing uninitialized instance variables in the intent callback. I may also play with Serge's solution and see if it is viable, and will report back what I find. Dan -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Wednesday, June 03, 2015 11:44 AM To: dev@cordova.apache.org Subject: Re: Android plugin crash on resume when activity destroyed This has been a problem since we started, and there's no solution to it because there's no reliable way to restore state on a WebView. We have tried in the past, and failed miserably. I'm extremely skeptical that this would even work, since this apparently failed Travis. That said, if it does, every intent would have to manage their own state, and even when the plugin is loaded, we still don't know where in the app the user would be at, so returning a photo to a part of the DOM that doesn't even exist would have JS errors. Of course, this only happens when you're using a LOT of memory, like what Cameras tend to do, and other Intents, like for example, requesting permission to use a Tango Service on a Project Tango plugin, ( https://github.com/infil00p/PhoneGapTango) or other third party plugins wouldn't run into the same problems. This is a problem with the Android architecture, and many native apps have run into similar problems. I don't think there's a solution for this in Cordova, and we have definitely tried. On Wed, Jun 3, 2015 at 9:46 AM Mefire O. ommen...@microsoft.com wrote: Interesting fix, Serge. A question comes to mind: - Since it seems like this issue affects all android plugins that call other intents, won't we have to do this for all of them? Is there a way we can leverage your PR and maybe come up with a general solution ? Maybe fit the boilerplate code (state saving/restoring) somewhere all android plugins can inherit ? On Jun 3, 2015 3:54 AM, Serge Huijben s.huij...@gmail.com wrote: what I did to solve this is add a check for callbackcontext, If that is null save the incoming
[GitHub] cordova-plugin-inappbrowser pull request: Updating fork with lates...
GitHub user ElliottElectric opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/103 Updating fork with latest. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ElliottElectric/cordova-plugin-inappbrowser master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 commit 54ca5182e973a23aac62127e7b3a860638a4ebab Author: ctap32 cta...@hotmail.com Date: 2014-07-23T15:58:25Z allow way to close browser without setting view controller to nil iOS only commit 5035704f70725bb14db975d291912f94b19c37c0 Author: ctap32 cta...@hotmail.com Date: 2014-07-31T22:40:58Z fix presentation is in progress error Prevent attempt to present view controller while a presentation is in progress --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/144#discussion_r31719008
--- Diff: bin/templates/scripts/cordova/lib/build.js ---
@@ -87,6 +87,13 @@ module.exports.run = function (argv) {
}
return Q.nfcall(fs.writeFile, path.join(__dirname, '..',
'build-extras.xcconfig'), extraConfig, 'utf-8');
}).then(function () {
+// Ensure platform scripts are executable as the platform could be
added on non-OSX environment
+shell.find(projectPath).filter(function (file) {
--- End diff --
Makes sense; although there is another script there:
`ios/build/HelloCordova.build/Debug-iphonesimulator/HelloCordova.build/Script-304B58A110DAC018002A0835.sh`
So we can probably check all folders except `www` - what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
