[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116949803
  
I've tested on iOS and it seems to work fine. @marcuspridham, did you make 
any custom changes, or is it just an update of the files that belong to Jasmine?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[CI] iOS bugs found

[Dmitry Blotsky]

Hey folks,

We’ve seen two issues pop up in iOS in the past two days:
https://issues.apache.org/jira/browse/CB-9265 (mobilespec crash on iOS 
simulator)
https://issues.apache.org/jira/browse/CB-9266 (“cordova run” not finding 
iOS simulators)

Please take a look and investigate. Many thanks to you from your friendly local 
CI watcher.

Kindly,
Dmitry
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/214


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9114: Deprecating the --usegit flag

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/214#issuecomment-116874574
  
@nikhilkh 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [cordova-lib] nom version too old, cannot use cnpm @scoped syntax

[Nikhil Khandelwal]

I think our cordova plugin registry (plugins.cordova.io) requires us to use old 
version of npm - 1.3.4. When we make the cordova plugin registry read-only 
(very soon) - we will be able to move to a newer version of npm.

-Nikhil

-Original Message-
From: huz's gmail [mailto:huiqingzhou1...@gmail.com] 
Sent: Friday, June 26, 2015 2:56 PM
To: dev@cordova.apache.org
Subject: [cordova-lib] nom version too old, cannot use cnpm @scoped syntax

Hi, Dear Cordova Team,

I’m in a dilemma where i’d like to publish company private cordova 
plugins using cnpm: https://github.com/cnpm/cnpmjs.org 
 while its syntax is rejected by 
cordova-cli’s (5.1.1) npm max version: 1.3.4
I understand that there’re other issues open trying to upgrade the 
outdated npm version for other support, just like to put this to the table as 
well.

cordova plugin add @company/pluginid 

After some debugging, i’ve located the issue as the npm 1.3.4 doesn’t 
support @scoped syntax till: https://github.com/npm/npm/issues/5239 


Much Thanks,
Roy

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116850705
  
On it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...

[darkyen]

Github user darkyen commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116853635
  
Personally I feel that returning a blob url is probably going to be a 
better bet cross device, then a single format for images and other media can be 
followed, same as what browsers do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[CI] Apache buildbot down

[Dmitry Blotsky]

Hey folks,

Our CI is down because Apache’s buildbot is down. Will let you all know once 
it’s up again. In the meantime, will look into setting up something like a 
failover on cordova-vm.apache.org.

Kindly,
Dmitry

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/57#discussion_r33498946
  
--- Diff: src/windows/MediaProxy.js ---
@@ -35,6 +46,8 @@ module.exports = {
 var src = args[1];
 var thisM = Media.get(id);
 
+src = cdvfileToNative(src);
--- End diff --

Yes, thanks!
Although I think of moving this commit to [CB-9238 Media plugin cannot 
record audio on 
windows](https://github.com/apache/cordova-plugin-media/pull/58) PR as it 
requires paths handling introduced there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...

[cfjedimaster]

Github user cfjedimaster commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116787903
  
Ah ok - so I misread it then.

On Mon, Jun 29, 2015 at 1:27 PM, Abhishek Hingnikar <
notificati...@github.com> wrote:

> @cfjedimaster  The platform you tested
> seems to be android, on windows phone you cannot directly use absolute
> paths (for obvious reasons).
>
> Windows returns a file, get the absolute url out of the file, read it
> again(also messing up with path is quite hectic on wp) using windows api
> (which already gave u the file), whereas if we use blob urls they are the
> de-facto way to read media on filesystem, now the runtime itself manages
> the reading of the file, the user can store the file if they want.
>
> Also a blob url is actually just a uuid, (its not data-url). Its actually
> smaller than the absolute file path on windows phone. ;-)
>
> —
> Reply to this email directly or view it on GitHub
> 

> .
>



-- 
===
Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : raymondcam...@gmail.com
Blog : www.raymondcamden.com
Twitter: raymondcamden



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...

[darkyen]

Github user darkyen commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116785859
  
@cfjedimaster The platform you tested seems to be android, on windows phone 
you cannot directly use absolute paths (for obvious reasons).

Windows returns a file, get the absolute url out of the file, read it 
again(also messing up with path is quite hectic on wp) using windows api (which 
already gave u the file), whereas if we use blob urls they are the de-facto way 
to read media on filesystem, now the runtime itself manages the reading of the 
file, the user can store the file if they want.

Also a blob url is actually just a uuid, (its not data-url). Its actually 
smaller than the absolute file path on windows phone. ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-test-framework pull request: CB-9071 Update test fr...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116774679
  
@dblotsky Can you take a look at this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...

[robpaveza]

Github user robpaveza commented on the pull request:

https://github.com/apache/cordova-windows/pull/91#issuecomment-116763083
  
In general LGTM.  

I would prefer that we examine the pipeline here.  We had been talking 
about making the build process be module-based for Windows (for example, the 
Windows build step provides a set of require()-able modules that then executes 
from cordova-lib).  In such a world, we could just parse the CLI arguments once 
up-front, instead of making each individual step parse them, which seems to 
have increased the complexity as we talk about build vs run vs prepare.  I'd 
like to see us go that direction in the long-term, but in the short-term, I 
think this will be adequate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/91#discussion_r33486397
  
--- Diff: template/cordova/lib/run.js ---
@@ -169,20 +135,10 @@ module.exports.help = function () {
 process.exit(0);
 };
 
-
-function getWindowsTargetVersion() {
--- End diff --

I'm confused about why this function is being removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-9159 Fix Windows Phone 8.1 deploy...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/91#issuecomment-116753933
  
@robpaveza Ping..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482157
  
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
 var id = args[0];
 var thisM = Media.get(id);
 
-var normalizedSrc = thisM.src.replace(/\//g, '\\');
+var success = function () {
+Media.onStatus(id, Media.MEDIA_STATE, Media.MEDIA_STOPPED);
+win();
+};
+
+var error = function (reason) {
+Media.onStatus(id, Media.MEDIA_ERROR, reason);
+lose(reason);
+};
+
+var fsTypes = {
+PERSISTENT: 'PERSISTENT',
+TEMPORARY: 'TEMPORARY'
+};
+var fsType;
+
+var normalizedSrc = thisM.src;
+normalizedSrc = setTemporaryFsByDefault(normalizedSrc);
+
+if (normalizedSrc.indexOf('ms-appdata:///local/') === 0) {
+fsType = fsTypes.PERSISTENT;
+} else if (normalizedSrc.indexOf('ms-appdata:///temp/') === 0) {
+fsType = fsTypes.TEMPORARY;
+} else {
+lose({ code: MediaError.MEDIA_ERR_NONE_SUPPORTED });
+return;
+}
+
+// Removing schemes (both variants are supported)
+normalizedSrc = normalizedSrc.replace('ms-appdata:///local//', 
'').replace('ms-appdata:///temp//', '')
--- End diff --

Seems like as per line 192 you don't need these top two variations.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482725
  
--- Diff: src/windows/MediaProxy.js ---
@@ -226,6 +301,10 @@ module.exports = {
 try {
 if (thisM.node) {
 thisM.node.onloadedmetadata = null;
+// Unsubscribing as the media object is being released
+thisM.node.onerror = null;
+// Needed to avoid "0x80070005 - JavaScript runtime error: 
Access is denied." on copyAsync
--- End diff --

This occurs when there is an Audio object with `src` set to a file being 
rewritten on recording.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482618
  
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
 var id = args[0];
 var thisM = Media.get(id);
 
-var normalizedSrc = thisM.src.replace(/\//g, '\\');
+var success = function () {
+Media.onStatus(id, Media.MEDIA_STATE, Media.MEDIA_STOPPED);
+win();
+};
+
+var error = function (reason) {
+Media.onStatus(id, Media.MEDIA_ERROR, reason);
+lose(reason);
+};
+
+var fsTypes = {
+PERSISTENT: 'PERSISTENT',
+TEMPORARY: 'TEMPORARY'
+};
+var fsType;
+
+var normalizedSrc = thisM.src;
+normalizedSrc = setTemporaryFsByDefault(normalizedSrc);
+
+if (normalizedSrc.indexOf('ms-appdata:///local/') === 0) {
--- End diff --

Do you mean cdvfile://localhost/persistent paths?
There is another [PR for 
this](https://github.com/apache/cordova-plugin-media/pull/57).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482303
  
--- Diff: src/windows/MediaProxy.js ---
@@ -91,6 +106,8 @@ module.exports = {
 var thisM = Media.get(id);
 // if Media was released, then node will be null and we need to 
create it again
 if (!thisM.node) {
+// createAudioNode = true;
--- End diff --

No it's a comment for the following line:
```javascript
args[2] = true;
```
It will add it as a side-comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482258
  
--- Diff: src/windows/MediaProxy.js ---
@@ -226,6 +301,10 @@ module.exports = {
 try {
 if (thisM.node) {
 thisM.node.onloadedmetadata = null;
+// Unsubscribing as the media object is being released
+thisM.node.onerror = null;
+// Needed to avoid "0x80070005 - JavaScript runtime error: 
Access is denied." on copyAsync
--- End diff --

Can you clarify here why this error is occurring?  Is it because there is a 
sharing violation (i.e., the file is already open when trying to overwrite it)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[daserge]

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482032
  
--- Diff: src/windows/MediaProxy.js ---
@@ -26,6 +26,15 @@ var MediaError = 
require('cordova-plugin-media.MediaError');
 
 var recordedFile;
 
+function setTemporaryFsByDefault(src) {
+if (!/.+:/.test(src)) {
--- End diff --

Great idea, thank you!
Will rework this via Windows.Foundation.Uri


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482012
  
--- Diff: src/windows/MediaProxy.js ---
@@ -203,20 +234,64 @@ module.exports = {
 var id = args[0];
 var thisM = Media.get(id);
 
-var normalizedSrc = thisM.src.replace(/\//g, '\\');
+var success = function () {
+Media.onStatus(id, Media.MEDIA_STATE, Media.MEDIA_STOPPED);
+win();
+};
+
+var error = function (reason) {
+Media.onStatus(id, Media.MEDIA_ERROR, reason);
+lose(reason);
+};
+
+var fsTypes = {
+PERSISTENT: 'PERSISTENT',
+TEMPORARY: 'TEMPORARY'
+};
+var fsType;
+
+var normalizedSrc = thisM.src;
+normalizedSrc = setTemporaryFsByDefault(normalizedSrc);
+
+if (normalizedSrc.indexOf('ms-appdata:///local/') === 0) {
--- End diff --

Is this component going to allow for interoperable code among platforms?  I 
just want to ensure that the developer isn't expected to utter 
"ms-appdata:///local/" - instead they're getting that from some service (or 
we're converting into that from some other argument) so that the developer can 
just write "persistent" or "temporary" and it saves.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481751
  
--- Diff: src/windows/MediaProxy.js ---
@@ -159,7 +176,21 @@ module.exports = {
 var id = args[0];
 var src = args[1];
 
-var normalizedSrc = src.replace(/\//g, '\\');
+src = setTemporaryFsByDefault(src);
+
+var success = function () {
+Media.onStatus(id, Media.MEDIA_STATE, Media.MEDIA_RUNNING);
+win();
+};
+
+var error = function (reason) {
+Media.onStatus(id, Media.MEDIA_ERROR, reason);
+lose(reason);
+};
+
+// Fixing paths like: ms-appdata:///temp//recs/memos/media.m4a => 
ms-appdata:///temp/recs/memos/media.m4a
+var normalizedSrc = src.replace(/([^\/])(\/\/)([^\/])/g, '$1/$3');
--- End diff --

This is another instance in which using Windows.Foundation.Uri may be 
preferable.  You can canonicalize the Uri using it, instead of worrying about 
doing accurate regular expression matching.  See for example 
https://msdn.microsoft.com/en-us/library/windows/apps/windows.foundation.uri.absolutecanonicaluri.aspx


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/57#discussion_r33481593
  
--- Diff: src/windows/MediaProxy.js ---
@@ -35,6 +46,8 @@ module.exports = {
 var src = args[1];
 var thisM = Media.get(id);
 
+src = cdvfileToNative(src);
--- End diff --

Should `src` for `startRecordingAudio` also be updated?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481357
  
--- Diff: src/windows/MediaProxy.js ---
@@ -91,6 +106,8 @@ module.exports = {
 var thisM = Media.get(id);
 // if Media was released, then node will be null and we need to 
create it again
 if (!thisM.node) {
+// createAudioNode = true;
--- End diff --

Dead code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33481074
  
--- Diff: src/windows/MediaProxy.js ---
@@ -33,8 +42,11 @@ module.exports = {
 create:function(win, lose, args) {
 var id = args[0];
 var src = args[1];
+var createAudioNode = args[2];
--- End diff --

This is later compared to true using ===.  Suggest coercing it to true or 
false here, "var createAudioNode = !!args[2];".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33480928
  
--- Diff: src/windows/MediaProxy.js ---
@@ -33,8 +42,11 @@ module.exports = {
 create:function(win, lose, args) {
 var id = args[0];
 var src = args[1];
+var createAudioNode = args[2];
 var thisM = Media.get(id);
 
+src = setTemporaryFsByDefault(src);
--- End diff --

Would prefer this line immediately follow "var src = args[1]" because it is 
easy to miss this mutation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[robpaveza]

Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33480844
  
--- Diff: src/windows/MediaProxy.js ---
@@ -26,6 +26,15 @@ var MediaError = 
require('cordova-plugin-media.MediaError');
 
 var recordedFile;
 
+function setTemporaryFsByDefault(src) {
+if (!/.+:/.test(src)) {
--- End diff --

This test seems like it could collide with absolute file paths (e.g., 
"c:\foo.bar") or UNC paths (e.g., "\\?\C:\foo.bar").  Are you sure this is 
adequate?  I'm curious about whether creating a new Windows.Foundation.Uri 
would be more likely to detect such sources.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...

[cfjedimaster]

Github user cfjedimaster commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-116725065
  
Are you sure this is needed? I think you are wrong about needing to use the 
FileSystem API to convert the URLs. I had no issue using the URLs returned 
here: 

http://www.raymondcamden.com/2014/12/23/cordova-demo-viewing-all-contacts

Also, a Blob URL would make the data returned by the API quite a bit larger 
and could have performance impacts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-plugin-file pull request: Added cdvfile protocol purpose d...

[Raymond Camden]

Wow, *very* nice addition to the docs here - thank you @daserge.

On Mon, Jun 29, 2015 at 7:31 AM, daserge  wrote:
> GitHub user daserge opened a pull request:
>
> https://github.com/apache/cordova-plugin-file/pull/120
>
> Added cdvfile protocol purpose description and examples
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/MSOpenTech/cordova-plugin-file cdvfile-docs
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cordova-plugin-file/pull/120.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #120
>
> 
> commit 9069da075bf7bbf4a652e3355c26b27edc5d613c
> Author: daserge 
> Date:   2015-06-29T12:27:09Z
>
> Added cdvfile protocol purpose description and examples
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>



-- 
===
Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : raymondcam...@gmail.com
Blog : www.raymondcamden.com
Twitter: raymondcamden

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

[mnill]

Github user mnill closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/84


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: Implementation of read only acce...

[mnill]

Github user mnill commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-116716134
  
Pull request is outdated from master. But the problem is still there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/58

CB-9238 Media plugin cannot record audio on windows

Reworked Windows proxy to support ms-appdata file paths (temporaryFolder 
and localFolder) instead of app package' folders (ms-appx) as ms-appx is 
readonly
Fixed release method to avoid Access is denied exception on Windows
Added MEDIA_RUNNING and MEDIA_ERROR states firing to record-related methods 
on Windows
Reworked Windows proxy to not to create Audio object in case of record mode
Adds releaseAudio to record manual test to avoid Access denied errors on 
Windows
Updates Windows test to use ms-appdata file path (via toURL)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-media CB-9238

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #58


commit 79e466ffa2dad270eab3ab4c841b1b1d72d0073a
Author: daserge 
Date:   2015-06-29T08:49:00Z

CB-9238 Media plugin cannot record audio on windows

Reworked Windows proxy to support ms-appdata file paths (temporaryFolder 
and localFolder) instead of app package' folders (ms-appx) as ms-appx is 
readonly
Fixed release method to avoid Access is denied exception on Windows
Added MEDIA_RUNNING and MEDIA_ERROR states firing to record-related methods 
on Windows
Reworked Windows proxy to not to create Audio object in case of record mode
Adds releaseAudio to record manual test to avoid Access denied errors on 
Windows
Updates Windows test to use ms-appdata file path (via toURL)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/57

CB-9237 Add cdvfile:// support to media plugin on windows platform

Mentioned cdvfile support in the documentation

[JIRA issue](https://issues.apache.org/jira/browse/CB-9237)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-media CB-9237

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit fa1ab0a29c13cc64efb47c6d57cbd4bb6cb58e64
Author: daserge 
Date:   2015-06-24T13:55:28Z

CB-9237 Add cdvfile:// support to media plugin on windows platform

Mentioned cdvfile support in the documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: Added cdvfile protocol purpose d...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/120

Added cdvfile protocol purpose description and examples



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file cdvfile-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #120


commit 9069da075bf7bbf4a652e3355c26b27edc5d613c
Author: daserge 
Date:   2015-06-29T12:27:09Z

Added cdvfile protocol purpose description and examples




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Need help on accessing Cordova code

[Thiyagarajan]

Dear All,

 

I need to add a new functionality on android hybrid application which
expects to store the geolocation (latitude and longitude) on 'Exif' while
taking the picture from camera.
The existing code was 4 years old which does many services(Web Service,
Camera, Storage etc.,) and used "Cordova 1.0".

 

When I googled, I got the something which starts from "Cordova 3+", but what
I'm using is Cordova 1.0. 
And I tried to change in java side code itself, instead of JavaScript, but
it leads to failure. 
What would be a better solution to include this Geolocation functionality in
my code.?

 

And I need to do the same functionality for Iphone app too.

 

Any help would be needful.

 

 

Thanks,

N.M.Thiyagarajan