Build failed in Jenkins: cordova-nightly #25

2016-05-31 Thread Apache Jenkins Server
See 

--
[...truncated 448 lines...]
├── js-yaml@3.6.1 (esprima@2.7.2, argparse@1.0.7)
└── handlebars@4.0.5 (source-map@0.4.4, optimist@0.6.1, uglify-js@2.6.2)
/home/jenkins/.npm-global/lib/node_modules/cordova-common -> 


 


 -> /home/jenkins/.npm-global/lib/node_modules/cordova-common -> 


 


 -> /home/jenkins/.npm-global/lib/node_modules/cordova-common -> 


 


 

npm WARN engine shelljs@0.7.0: wanted: {"node":">=0.11.0","iojs":"*"} (current: 
{"node":"0.10.25","npm":"2.15.6"})
is-url@1.2.1 node_modules/is-url

dependency-ls@1.0.0 node_modules/dependency-ls

q@1.4.1 node_modules/q

jasmine@2.4.1 node_modules/jasmine
├── exit@0.1.2
├── jasmine-core@2.4.1
└── glob@3.2.11 (inherits@2.0.1, minimatch@0.3.0)

shelljs@0.7.0 node_modules/shelljs
├── interpret@1.0.1
├── rechoir@0.6.2 (resolve@1.1.7)
└── glob@7.0.3 (path-is-absolute@1.0.0, inherits@2.0.1, once@1.3.3, 
inflight@1.0.5, minimatch@3.0.0)

jshint@2.9.2 node_modules/jshint
├── strip-json-comments@1.0.4
├── exit@0.1.2
├── shelljs@0.3.0
├── console-browserify@1.1.0 (date-now@0.1.4)
├── cli@0.6.6 (glob@3.2.11)
├── minimatch@2.0.10 (brace-expansion@1.1.4)
├── lodash@3.7.0
└── htmlparser2@3.8.3 (domelementtype@1.3.0, entities@1.0.0, 
domhandler@2.3.0, readable-stream@1.1.14, domutils@1.5.1)
/home/jenkins/.npm-global/lib/node_modules/cordova-fetch -> 


 


 -> /home/jenkins/.npm-global/lib/node_modules/cordova-fetch -> 


 

npm WARN engine cordova-serve@1.0.0: wanted: {"node":">= 0.12.0","npm":">= 
2.5.1"} (current: {"node":"0.10.25","npm":"2.15.6"})
npm WARN engine escodegen@1.7.1: wanted: {"node":">=0.12.0"} (current: 
{"node":"0.10.25","npm":"2.15.6"})
npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail 
on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as 
possible. Use 'npm ls graceful-fs' to find it in the tree.

> execSync@1.0.2 install 
> 
> node install.js

[execsync v1.0.2] Attempting to compile native extensions.
[execSync v1.0.2] Native extension compilation successful!
npm WARN deprecated lodash-node@2.4.1: This package has been discontinued in 
favor of lodash@^4.0.0.
npm WARN engine is-buffer@1.1.3: wanted: {"node":">=0.12"} (current: 
{"node":"0.10.25","npm":"2.15.6"})
npm WARN engine is-buffer@1.1.3: wanted: {"node":">=0.12"} (current: 
{"node":"0.10.25","npm":"2.15.6"})
npm WARN engineStrict Per-package engineStrict (found in this package's 
package.json) 
npm WARN engineStrict won't be used in npm 3+. Use the config setting 
`engine-strict` instead.
valid-identifier@0.0.1 node_modules/valid-identifier

opener@1.4.1 node_modules/opener

cordova-registry-mapper@1.1.15 node_modules/cordova-registry-mapper

properties-parser@0.2.3 node_modules/properties-parser

underscore@1.7.0 node_modules/underscore

q@1.0.1 node_modules/q

unorm@1.3.3 node_modules/unorm

rewire@2.1.3 node_modules/rewire

shelljs@0.3.0 node_modules/shelljs

semver@4.3.6 node_modules/semver

nopt@3.0.6 

Re: [DISCUSS] CLI Templates

2016-05-31 Thread Tommy Williams
Yeah, I don’t really mean any more than what templates + create already do with 
config.xml.

Use case:

`cordova create mycoolapp —template=some-react-template`
cd mycoolapp
npm install
npm start

etc

The `some-react-template` by necessity will have a package.json with stuff in 
it (deps, npm scripts, etc) that the resulting created app will need in _its_ 
package.json.

However, with the new move to fetch and having all Cordova apps have a 
package.json (with cordoba-specific stuff in it), the resulting app will need 
the stuff that a newly created app gets + whatever the template needs to 
work/build/etc.

Does that make sense?


Stuff is a great word, just saying.



> On 1 Jun 2016, at 11:38 AM, Steven Gill  wrote:
> 
> By merge the package.json, do you mean update the package.name to the name
> of the app?
> On May 31, 2016 6:01 PM, "Tommy Williams"  wrote:
> 
>> Yeah, a subduer is fine as long as we can merge the package.json from the
>> template somehow…
>> 
>> Dibs not writing that :/
>> 
>> 
>>> On 1 Jun 2016, at 10:47 AM, Steven Gill  wrote:
>>> 
>>> I definitely see the usecase tommy describes.
>>> 
>>> I think subdir makes the most sense. package.json has a `dirname` field
>>> which would fetch everything in that subdirectory. This functionality
>>> already exists for `--template`.
>>> 
>>> TLDR We should be a bit more picky for top level files we copy over but
>>> blindly copy over sub directory files
>>> 
>>> On Tue, May 31, 2016 at 4:46 PM, Carlos Santana 
>>> wrote:
>>> 
 Using a subdir makes a clear separation between final template files vs.
 files associated with tooling, tests, packaging
 
 - Carlos Santana
 @csantanapr
 
> On May 31, 2016, at 7:37 PM, Jesse  wrote:
> 
> `cordova create` is destructive by nature.
> Anything and everything required by the templated app should be part of
> what is copied.  Our current blind folder copy needs to be more
 intelligent.
> I would prefer that template files be in a sub-dir, much like they are
>> in
> each platform.
> 
> Simon and I faced a similar situation with making a plugin template[1]
> While only half baked at this point, the file structure is relevant I
 think.
> 
> [1] https://github.com/phonegap/phonegap-plugin-template
> 
> 
> 
> @purplecabbage
> risingj.com
> 
>> On Tue, May 31, 2016 at 4:18 PM, Tommy Williams 
 wrote:
>> 
>> .npmignore can help with some of those unwanted files, but not all…
>> 
>> However, what happens in the circumstance when the template _does_
>> need
 a
>> package.json file, such as the react-hot-loader template Jed and I
 made? It
>> has npm dips and npm scripts that are vital to how it works in its
>> package,json. We can’t just omit files, Similarly, a template might
 include
>> hooks and merges as well.
>> 
>> - tommy
>> 
>> 
>>> On 1 Jun 2016, at 8:22 AM, Carlos Santana 
 wrote:
>>> 
>>> I opened a JIRA for ignoring .git
>>> Don't have it handy on mobile now
>>> 
>>> Best practice:
>>> 1.  To use subdir feature to specify dir to use via main module
>>> 2.  To follow npm best practices when publishing to npm (i.e. do not
>> include everything, only the minimum required)
>>> 
>>> 
>>> - Carlos Santana
>>> @csantanapr
>>> 
 On May 31, 2016, at 6:10 PM, Steven Gill 
>> wrote:
 
 Sorry to bring up a old thread instead of starting a new one but I
>> thought
 the context might be relevant.
 
 Currently, template pretty much copies over all of the files. I see
>> this as
 a problem.
 
 Example [1]. When you add a template, its package.json gets copied
 into
 your app. I don't think we want that to happen right?
 
 Other files that are getting copied but shouldn't:
 - RELEASENOTES.md
 - README.md
 - .git (if you do it locally or f
 - NOTICE
 - LICENSE
 - COPYWRIGHT
 
 Files we want:
 - config.xml
 - .gitignore
 - .npmignore ?
 - node_modules?
 - platforms/plugins (if present)
 - hooks
 - merges
 
 templates can provide additional info by setting a subdirectory in
 their
 package.json for where the template files live.
 
 [1] https://issues.apache.org/jira/browse/CB-11344.
 
 Thoughts?
 
 
 
 On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana <
>> csantan...@gmail.com
> 
 wrote:
 
> Oh I'm late on this thread.
> 
> Latest code is in master 

Re: [DISCUSS] CLI Templates

2016-05-31 Thread Steven Gill
By merge the package.json, do you mean update the package.name to the name
of the app?
On May 31, 2016 6:01 PM, "Tommy Williams"  wrote:

> Yeah, a subduer is fine as long as we can merge the package.json from the
> template somehow…
>
> Dibs not writing that :/
>
>
> > On 1 Jun 2016, at 10:47 AM, Steven Gill  wrote:
> >
> > I definitely see the usecase tommy describes.
> >
> > I think subdir makes the most sense. package.json has a `dirname` field
> > which would fetch everything in that subdirectory. This functionality
> > already exists for `--template`.
> >
> > TLDR We should be a bit more picky for top level files we copy over but
> > blindly copy over sub directory files
> >
> > On Tue, May 31, 2016 at 4:46 PM, Carlos Santana 
> > wrote:
> >
> >> Using a subdir makes a clear separation between final template files vs.
> >> files associated with tooling, tests, packaging
> >>
> >> - Carlos Santana
> >> @csantanapr
> >>
> >>> On May 31, 2016, at 7:37 PM, Jesse  wrote:
> >>>
> >>> `cordova create` is destructive by nature.
> >>> Anything and everything required by the templated app should be part of
> >>> what is copied.  Our current blind folder copy needs to be more
> >> intelligent.
> >>> I would prefer that template files be in a sub-dir, much like they are
> in
> >>> each platform.
> >>>
> >>> Simon and I faced a similar situation with making a plugin template[1]
> >>> While only half baked at this point, the file structure is relevant I
> >> think.
> >>>
> >>> [1] https://github.com/phonegap/phonegap-plugin-template
> >>>
> >>>
> >>>
> >>> @purplecabbage
> >>> risingj.com
> >>>
>  On Tue, May 31, 2016 at 4:18 PM, Tommy Williams 
> >> wrote:
> 
>  .npmignore can help with some of those unwanted files, but not all…
> 
>  However, what happens in the circumstance when the template _does_
> need
> >> a
>  package.json file, such as the react-hot-loader template Jed and I
> >> made? It
>  has npm dips and npm scripts that are vital to how it works in its
>  package,json. We can’t just omit files, Similarly, a template might
> >> include
>  hooks and merges as well.
> 
>  - tommy
> 
> 
> > On 1 Jun 2016, at 8:22 AM, Carlos Santana 
> >> wrote:
> >
> > I opened a JIRA for ignoring .git
> > Don't have it handy on mobile now
> >
> > Best practice:
> > 1.  To use subdir feature to specify dir to use via main module
> > 2.  To follow npm best practices when publishing to npm (i.e. do not
>  include everything, only the minimum required)
> >
> >
> > - Carlos Santana
> > @csantanapr
> >
> >> On May 31, 2016, at 6:10 PM, Steven Gill 
>  wrote:
> >>
> >> Sorry to bring up a old thread instead of starting a new one but I
>  thought
> >> the context might be relevant.
> >>
> >> Currently, template pretty much copies over all of the files. I see
>  this as
> >> a problem.
> >>
> >> Example [1]. When you add a template, its package.json gets copied
> >> into
> >> your app. I don't think we want that to happen right?
> >>
> >> Other files that are getting copied but shouldn't:
> >> - RELEASENOTES.md
> >> - README.md
> >> - .git (if you do it locally or f
> >> - NOTICE
> >> - LICENSE
> >> - COPYWRIGHT
> >>
> >> Files we want:
> >> - config.xml
> >> - .gitignore
> >> - .npmignore ?
> >> - node_modules?
> >> - platforms/plugins (if present)
> >> - hooks
> >> - merges
> >>
> >> templates can provide additional info by setting a subdirectory in
> >> their
> >> package.json for where the template files live.
> >>
> >> [1] https://issues.apache.org/jira/browse/CB-11344.
> >>
> >> Thoughts?
> >>
> >>
> >>
> >> On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana <
> csantan...@gmail.com
> >>>
> >> wrote:
> >>
> >>> Oh I'm late on this thread.
> >>>
> >>> Latest code is in master cordova-cli and cordova-lib
> >>> you have to link lib to cli to get it to show up.
> >>>
> >>> if you are lazy like me you can do "npm install -g
> >>> csantanapr/cordova-cli-dev"
> >>> To see the help "cordova help create"
> >>> --template= ... use a custom template
> >> located
> >>> locally, in NPM, or GitHub.
> >>> Options:
> >>> --template= ... use a custom template
> >>> located locally, in NPM, or GitHub.
> >>> --copy-from|src= .. deprecated, use
> >>> --template instead.
> >>> --link-to=  symlink to custom www
> >>> assets without creating a copy.
> >>>
> >>> The goal is to help people getting started by using a package from
> >> npm
>  

Re: [DISCUSS] CLI Templates

2016-05-31 Thread Tommy Williams
Yeah, a subduer is fine as long as we can merge the package.json from the 
template somehow…

Dibs not writing that :/


> On 1 Jun 2016, at 10:47 AM, Steven Gill  wrote:
> 
> I definitely see the usecase tommy describes.
> 
> I think subdir makes the most sense. package.json has a `dirname` field
> which would fetch everything in that subdirectory. This functionality
> already exists for `--template`.
> 
> TLDR We should be a bit more picky for top level files we copy over but
> blindly copy over sub directory files
> 
> On Tue, May 31, 2016 at 4:46 PM, Carlos Santana 
> wrote:
> 
>> Using a subdir makes a clear separation between final template files vs.
>> files associated with tooling, tests, packaging
>> 
>> - Carlos Santana
>> @csantanapr
>> 
>>> On May 31, 2016, at 7:37 PM, Jesse  wrote:
>>> 
>>> `cordova create` is destructive by nature.
>>> Anything and everything required by the templated app should be part of
>>> what is copied.  Our current blind folder copy needs to be more
>> intelligent.
>>> I would prefer that template files be in a sub-dir, much like they are in
>>> each platform.
>>> 
>>> Simon and I faced a similar situation with making a plugin template[1]
>>> While only half baked at this point, the file structure is relevant I
>> think.
>>> 
>>> [1] https://github.com/phonegap/phonegap-plugin-template
>>> 
>>> 
>>> 
>>> @purplecabbage
>>> risingj.com
>>> 
 On Tue, May 31, 2016 at 4:18 PM, Tommy Williams 
>> wrote:
 
 .npmignore can help with some of those unwanted files, but not all…
 
 However, what happens in the circumstance when the template _does_ need
>> a
 package.json file, such as the react-hot-loader template Jed and I
>> made? It
 has npm dips and npm scripts that are vital to how it works in its
 package,json. We can’t just omit files, Similarly, a template might
>> include
 hooks and merges as well.
 
 - tommy
 
 
> On 1 Jun 2016, at 8:22 AM, Carlos Santana 
>> wrote:
> 
> I opened a JIRA for ignoring .git
> Don't have it handy on mobile now
> 
> Best practice:
> 1.  To use subdir feature to specify dir to use via main module
> 2.  To follow npm best practices when publishing to npm (i.e. do not
 include everything, only the minimum required)
> 
> 
> - Carlos Santana
> @csantanapr
> 
>> On May 31, 2016, at 6:10 PM, Steven Gill 
 wrote:
>> 
>> Sorry to bring up a old thread instead of starting a new one but I
 thought
>> the context might be relevant.
>> 
>> Currently, template pretty much copies over all of the files. I see
 this as
>> a problem.
>> 
>> Example [1]. When you add a template, its package.json gets copied
>> into
>> your app. I don't think we want that to happen right?
>> 
>> Other files that are getting copied but shouldn't:
>> - RELEASENOTES.md
>> - README.md
>> - .git (if you do it locally or f
>> - NOTICE
>> - LICENSE
>> - COPYWRIGHT
>> 
>> Files we want:
>> - config.xml
>> - .gitignore
>> - .npmignore ?
>> - node_modules?
>> - platforms/plugins (if present)
>> - hooks
>> - merges
>> 
>> templates can provide additional info by setting a subdirectory in
>> their
>> package.json for where the template files live.
>> 
>> [1] https://issues.apache.org/jira/browse/CB-11344.
>> 
>> Thoughts?
>> 
>> 
>> 
>> On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana >> 
>> wrote:
>> 
>>> Oh I'm late on this thread.
>>> 
>>> Latest code is in master cordova-cli and cordova-lib
>>> you have to link lib to cli to get it to show up.
>>> 
>>> if you are lazy like me you can do "npm install -g
>>> csantanapr/cordova-cli-dev"
>>> To see the help "cordova help create"
>>> --template= ... use a custom template
>> located
>>> locally, in NPM, or GitHub.
>>> Options:
>>> --template= ... use a custom template
>>> located locally, in NPM, or GitHub.
>>> --copy-from|src= .. deprecated, use
>>> --template instead.
>>> --link-to=  symlink to custom www
>>> assets without creating a copy.
>>> 
>>> The goal is to help people getting started by using a package from
>> npm
 as
>>> starting point, I see the samples that Raymond produces being used
 with the
>>> --template flag for novice users to get a sample running faster. also
>>> opening the door for web frameworks to have their cordova template in
 npm,
>>> or plugin creators to share templates that uses their plugin, and
 declare
>>> the plugin in config.xml
>>> 
>>> 1. Omar
>>> 

Re: [DISCUSS] CLI Templates

2016-05-31 Thread Steven Gill
I definitely see the usecase tommy describes.

I think subdir makes the most sense. package.json has a `dirname` field
which would fetch everything in that subdirectory. This functionality
already exists for `--template`.

TLDR We should be a bit more picky for top level files we copy over but
blindly copy over sub directory files

On Tue, May 31, 2016 at 4:46 PM, Carlos Santana 
wrote:

> Using a subdir makes a clear separation between final template files vs.
> files associated with tooling, tests, packaging
>
> - Carlos Santana
> @csantanapr
>
> > On May 31, 2016, at 7:37 PM, Jesse  wrote:
> >
> > `cordova create` is destructive by nature.
> > Anything and everything required by the templated app should be part of
> > what is copied.  Our current blind folder copy needs to be more
> intelligent.
> > I would prefer that template files be in a sub-dir, much like they are in
> > each platform.
> >
> > Simon and I faced a similar situation with making a plugin template[1]
> > While only half baked at this point, the file structure is relevant I
> think.
> >
> > [1] https://github.com/phonegap/phonegap-plugin-template
> >
> >
> >
> > @purplecabbage
> > risingj.com
> >
> >> On Tue, May 31, 2016 at 4:18 PM, Tommy Williams 
> wrote:
> >>
> >> .npmignore can help with some of those unwanted files, but not all…
> >>
> >> However, what happens in the circumstance when the template _does_ need
> a
> >> package.json file, such as the react-hot-loader template Jed and I
> made? It
> >> has npm dips and npm scripts that are vital to how it works in its
> >> package,json. We can’t just omit files, Similarly, a template might
> include
> >> hooks and merges as well.
> >>
> >> - tommy
> >>
> >>
> >>> On 1 Jun 2016, at 8:22 AM, Carlos Santana 
> wrote:
> >>>
> >>> I opened a JIRA for ignoring .git
> >>> Don't have it handy on mobile now
> >>>
> >>> Best practice:
> >>> 1.  To use subdir feature to specify dir to use via main module
> >>> 2.  To follow npm best practices when publishing to npm (i.e. do not
> >> include everything, only the minimum required)
> >>>
> >>>
> >>> - Carlos Santana
> >>> @csantanapr
> >>>
>  On May 31, 2016, at 6:10 PM, Steven Gill 
> >> wrote:
> 
>  Sorry to bring up a old thread instead of starting a new one but I
> >> thought
>  the context might be relevant.
> 
>  Currently, template pretty much copies over all of the files. I see
> >> this as
>  a problem.
> 
>  Example [1]. When you add a template, its package.json gets copied
> into
>  your app. I don't think we want that to happen right?
> 
>  Other files that are getting copied but shouldn't:
>  - RELEASENOTES.md
>  - README.md
>  - .git (if you do it locally or f
>  - NOTICE
>  - LICENSE
>  - COPYWRIGHT
> 
>  Files we want:
>  - config.xml
>  - .gitignore
>  - .npmignore ?
>  - node_modules?
>  - platforms/plugins (if present)
>  - hooks
>  - merges
> 
>  templates can provide additional info by setting a subdirectory in
> their
>  package.json for where the template files live.
> 
>  [1] https://issues.apache.org/jira/browse/CB-11344.
> 
>  Thoughts?
> 
> 
> 
>  On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana  >
>  wrote:
> 
> > Oh I'm late on this thread.
> >
> > Latest code is in master cordova-cli and cordova-lib
> > you have to link lib to cli to get it to show up.
> >
> > if you are lazy like me you can do "npm install -g
> > csantanapr/cordova-cli-dev"
> > To see the help "cordova help create"
> > --template= ... use a custom template
> located
> > locally, in NPM, or GitHub.
> > Options:
> >  --template= ... use a custom template
> > located locally, in NPM, or GitHub.
> >  --copy-from|src= .. deprecated, use
> > --template instead.
> >  --link-to=  symlink to custom www
> > assets without creating a copy.
> >
> > The goal is to help people getting started by using a package from
> npm
> >> as
> > starting point, I see the samples that Raymond produces being used
> >> with the
> > --template flag for novice users to get a sample running faster. also
> > opening the door for web frameworks to have their cordova template in
> >> npm,
> > or plugin creators to share templates that uses their plugin, and
> >> declare
> > the plugin in config.xml
> >
> > 1. Omar
> > what you describe in your list what was implemented
> > The only thing, that was not implemented because was not in the
> >> proposal
> > and not discuss was ~/.cordova/config.json
> >
> > I didn't added because I think there should be a better architecture

Re: [DISCUSS] CLI Templates

2016-05-31 Thread Carlos Santana
Using a subdir makes a clear separation between final template files vs. files 
associated with tooling, tests, packaging 

- Carlos Santana
@csantanapr

> On May 31, 2016, at 7:37 PM, Jesse  wrote:
> 
> `cordova create` is destructive by nature.
> Anything and everything required by the templated app should be part of
> what is copied.  Our current blind folder copy needs to be more intelligent.
> I would prefer that template files be in a sub-dir, much like they are in
> each platform.
> 
> Simon and I faced a similar situation with making a plugin template[1]
> While only half baked at this point, the file structure is relevant I think.
> 
> [1] https://github.com/phonegap/phonegap-plugin-template
> 
> 
> 
> @purplecabbage
> risingj.com
> 
>> On Tue, May 31, 2016 at 4:18 PM, Tommy Williams  wrote:
>> 
>> .npmignore can help with some of those unwanted files, but not all…
>> 
>> However, what happens in the circumstance when the template _does_ need a
>> package.json file, such as the react-hot-loader template Jed and I made? It
>> has npm dips and npm scripts that are vital to how it works in its
>> package,json. We can’t just omit files, Similarly, a template might include
>> hooks and merges as well.
>> 
>> - tommy
>> 
>> 
>>> On 1 Jun 2016, at 8:22 AM, Carlos Santana  wrote:
>>> 
>>> I opened a JIRA for ignoring .git
>>> Don't have it handy on mobile now
>>> 
>>> Best practice:
>>> 1.  To use subdir feature to specify dir to use via main module
>>> 2.  To follow npm best practices when publishing to npm (i.e. do not
>> include everything, only the minimum required)
>>> 
>>> 
>>> - Carlos Santana
>>> @csantanapr
>>> 
 On May 31, 2016, at 6:10 PM, Steven Gill 
>> wrote:
 
 Sorry to bring up a old thread instead of starting a new one but I
>> thought
 the context might be relevant.
 
 Currently, template pretty much copies over all of the files. I see
>> this as
 a problem.
 
 Example [1]. When you add a template, its package.json gets copied into
 your app. I don't think we want that to happen right?
 
 Other files that are getting copied but shouldn't:
 - RELEASENOTES.md
 - README.md
 - .git (if you do it locally or f
 - NOTICE
 - LICENSE
 - COPYWRIGHT
 
 Files we want:
 - config.xml
 - .gitignore
 - .npmignore ?
 - node_modules?
 - platforms/plugins (if present)
 - hooks
 - merges
 
 templates can provide additional info by setting a subdirectory in their
 package.json for where the template files live.
 
 [1] https://issues.apache.org/jira/browse/CB-11344.
 
 Thoughts?
 
 
 
 On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana 
 wrote:
 
> Oh I'm late on this thread.
> 
> Latest code is in master cordova-cli and cordova-lib
> you have to link lib to cli to get it to show up.
> 
> if you are lazy like me you can do "npm install -g
> csantanapr/cordova-cli-dev"
> To see the help "cordova help create"
> --template= ... use a custom template located
> locally, in NPM, or GitHub.
> Options:
>  --template= ... use a custom template
> located locally, in NPM, or GitHub.
>  --copy-from|src= .. deprecated, use
> --template instead.
>  --link-to=  symlink to custom www
> assets without creating a copy.
> 
> The goal is to help people getting started by using a package from npm
>> as
> starting point, I see the samples that Raymond produces being used
>> with the
> --template flag for novice users to get a sample running faster. also
> opening the door for web frameworks to have their cordova template in
>> npm,
> or plugin creators to share templates that uses their plugin, and
>> declare
> the plugin in config.xml
> 
> 1. Omar
> what you describe in your list what was implemented
> The only thing, that was not implemented because was not in the
>> proposal
> and not discuss was ~/.cordova/config.json
> 
> I didn't added because I think there should be a better architecture
>> for
> config. That's another proposal I'm thinking on doing but it looks
>> like how
> npm does config
> For example  have "cordova config" cli
> cordova config set template=my-app-hello
> cordova config ls
> and so...
> so default configs can be override using the CLI
> 
> 2. Dmitry
> Let's have a hangout and let's, talk because I don't understand what
>> is the
> problem that --template is causing,
> I don't understand if you don't want the flag present, or the
> implementation, or you want to keep --copy-from as it is today.
> Email is not helping to communicate what is what you think that 

Re: [DISCUSS] CLI Templates

2016-05-31 Thread Jesse
`cordova create` is destructive by nature.
Anything and everything required by the templated app should be part of
what is copied.  Our current blind folder copy needs to be more intelligent.
I would prefer that template files be in a sub-dir, much like they are in
each platform.

Simon and I faced a similar situation with making a plugin template[1]
While only half baked at this point, the file structure is relevant I think.

[1] https://github.com/phonegap/phonegap-plugin-template



@purplecabbage
risingj.com

On Tue, May 31, 2016 at 4:18 PM, Tommy Williams  wrote:

> .npmignore can help with some of those unwanted files, but not all…
>
> However, what happens in the circumstance when the template _does_ need a
> package.json file, such as the react-hot-loader template Jed and I made? It
> has npm dips and npm scripts that are vital to how it works in its
> package,json. We can’t just omit files, Similarly, a template might include
> hooks and merges as well.
>
> - tommy
>
>
> > On 1 Jun 2016, at 8:22 AM, Carlos Santana  wrote:
> >
> > I opened a JIRA for ignoring .git
> > Don't have it handy on mobile now
> >
> > Best practice:
> > 1.  To use subdir feature to specify dir to use via main module
> > 2.  To follow npm best practices when publishing to npm (i.e. do not
> include everything, only the minimum required)
> >
> >
> > - Carlos Santana
> > @csantanapr
> >
> >> On May 31, 2016, at 6:10 PM, Steven Gill 
> wrote:
> >>
> >> Sorry to bring up a old thread instead of starting a new one but I
> thought
> >> the context might be relevant.
> >>
> >> Currently, template pretty much copies over all of the files. I see
> this as
> >> a problem.
> >>
> >> Example [1]. When you add a template, its package.json gets copied into
> >> your app. I don't think we want that to happen right?
> >>
> >> Other files that are getting copied but shouldn't:
> >> - RELEASENOTES.md
> >> - README.md
> >> - .git (if you do it locally or f
> >> - NOTICE
> >> - LICENSE
> >> - COPYWRIGHT
> >>
> >> Files we want:
> >> - config.xml
> >> - .gitignore
> >> - .npmignore ?
> >> - node_modules?
> >> - platforms/plugins (if present)
> >> - hooks
> >> - merges
> >>
> >> templates can provide additional info by setting a subdirectory in their
> >> package.json for where the template files live.
> >>
> >> [1] https://issues.apache.org/jira/browse/CB-11344.
> >>
> >> Thoughts?
> >>
> >>
> >>
> >> On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana 
> >> wrote:
> >>
> >>> Oh I'm late on this thread.
> >>>
> >>> Latest code is in master cordova-cli and cordova-lib
> >>> you have to link lib to cli to get it to show up.
> >>>
> >>> if you are lazy like me you can do "npm install -g
> >>> csantanapr/cordova-cli-dev"
> >>> To see the help "cordova help create"
> >>> --template= ... use a custom template located
> >>> locally, in NPM, or GitHub.
> >>> Options:
> >>>   --template= ... use a custom template
> >>> located locally, in NPM, or GitHub.
> >>>   --copy-from|src= .. deprecated, use
> >>> --template instead.
> >>>   --link-to=  symlink to custom www
> >>> assets without creating a copy.
> >>>
> >>> The goal is to help people getting started by using a package from npm
> as
> >>> starting point, I see the samples that Raymond produces being used
> with the
> >>> --template flag for novice users to get a sample running faster. also
> >>> opening the door for web frameworks to have their cordova template in
> npm,
> >>> or plugin creators to share templates that uses their plugin, and
> declare
> >>> the plugin in config.xml
> >>>
> >>> 1. Omar
> >>> what you describe in your list what was implemented
> >>> The only thing, that was not implemented because was not in the
> proposal
> >>> and not discuss was ~/.cordova/config.json
> >>>
> >>> I didn't added because I think there should be a better architecture
> for
> >>> config. That's another proposal I'm thinking on doing but it looks
> like how
> >>> npm does config
> >>> For example  have "cordova config" cli
> >>> cordova config set template=my-app-hello
> >>> cordova config ls
> >>> and so...
> >>> so default configs can be override using the CLI
> >>>
> >>> 2. Dmitry
> >>> Let's have a hangout and let's, talk because I don't understand what
> is the
> >>> problem that --template is causing,
> >>> I don't understand if you don't want the flag present, or the
> >>> implementation, or you want to keep --copy-from as it is today.
> >>> Email is not helping to communicate what is what you think that is
> broken
> >>>
> >>> 3. Simon
> >>> There is no much documentation other than the help, and mentioned in
> the
> >>> docs.
> >>> Will love some help feedback and help on docs for this .
> >>>
> >>>
> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/guide/cli/index.md
> >>> 

Re: [DISCUSS] CLI Templates

2016-05-31 Thread Carlos Santana
package.json should be ignore also is fetching template via npm

If you want to include a package.json then use the subdir feature and
include the package.json inside the subdir

On Tue, May 31, 2016 at 7:18 PM Tommy Williams  wrote:

> .npmignore can help with some of those unwanted files, but not all…
>
> However, what happens in the circumstance when the template _does_ need a
> package.json file, such as the react-hot-loader template Jed and I made? It
> has npm dips and npm scripts that are vital to how it works in its
> package,json. We can’t just omit files, Similarly, a template might include
> hooks and merges as well.
>
> - tommy
>
>
> > On 1 Jun 2016, at 8:22 AM, Carlos Santana  wrote:
> >
> > I opened a JIRA for ignoring .git
> > Don't have it handy on mobile now
> >
> > Best practice:
> > 1.  To use subdir feature to specify dir to use via main module
> > 2.  To follow npm best practices when publishing to npm (i.e. do not
> include everything, only the minimum required)
> >
> >
> > - Carlos Santana
> > @csantanapr
> >
> >> On May 31, 2016, at 6:10 PM, Steven Gill 
> wrote:
> >>
> >> Sorry to bring up a old thread instead of starting a new one but I
> thought
> >> the context might be relevant.
> >>
> >> Currently, template pretty much copies over all of the files. I see
> this as
> >> a problem.
> >>
> >> Example [1]. When you add a template, its package.json gets copied into
> >> your app. I don't think we want that to happen right?
> >>
> >> Other files that are getting copied but shouldn't:
> >> - RELEASENOTES.md
> >> - README.md
> >> - .git (if you do it locally or f
> >> - NOTICE
> >> - LICENSE
> >> - COPYWRIGHT
> >>
> >> Files we want:
> >> - config.xml
> >> - .gitignore
> >> - .npmignore ?
> >> - node_modules?
> >> - platforms/plugins (if present)
> >> - hooks
> >> - merges
> >>
> >> templates can provide additional info by setting a subdirectory in their
> >> package.json for where the template files live.
> >>
> >> [1] https://issues.apache.org/jira/browse/CB-11344.
> >>
> >> Thoughts?
> >>
> >>
> >>
> >> On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana 
> >> wrote:
> >>
> >>> Oh I'm late on this thread.
> >>>
> >>> Latest code is in master cordova-cli and cordova-lib
> >>> you have to link lib to cli to get it to show up.
> >>>
> >>> if you are lazy like me you can do "npm install -g
> >>> csantanapr/cordova-cli-dev"
> >>> To see the help "cordova help create"
> >>> --template= ... use a custom template located
> >>> locally, in NPM, or GitHub.
> >>> Options:
> >>>   --template= ... use a custom template
> >>> located locally, in NPM, or GitHub.
> >>>   --copy-from|src= .. deprecated, use
> >>> --template instead.
> >>>   --link-to=  symlink to custom www
> >>> assets without creating a copy.
> >>>
> >>> The goal is to help people getting started by using a package from npm
> as
> >>> starting point, I see the samples that Raymond produces being used
> with the
> >>> --template flag for novice users to get a sample running faster. also
> >>> opening the door for web frameworks to have their cordova template in
> npm,
> >>> or plugin creators to share templates that uses their plugin, and
> declare
> >>> the plugin in config.xml
> >>>
> >>> 1. Omar
> >>> what you describe in your list what was implemented
> >>> The only thing, that was not implemented because was not in the
> proposal
> >>> and not discuss was ~/.cordova/config.json
> >>>
> >>> I didn't added because I think there should be a better architecture
> for
> >>> config. That's another proposal I'm thinking on doing but it looks
> like how
> >>> npm does config
> >>> For example  have "cordova config" cli
> >>> cordova config set template=my-app-hello
> >>> cordova config ls
> >>> and so...
> >>> so default configs can be override using the CLI
> >>>
> >>> 2. Dmitry
> >>> Let's have a hangout and let's, talk because I don't understand what
> is the
> >>> problem that --template is causing,
> >>> I don't understand if you don't want the flag present, or the
> >>> implementation, or you want to keep --copy-from as it is today.
> >>> Email is not helping to communicate what is what you think that is
> broken
> >>>
> >>> 3. Simon
> >>> There is no much documentation other than the help, and mentioned in
> the
> >>> docs.
> >>> Will love some help feedback and help on docs for this .
> >>>
> >>>
> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/guide/cli/index.md
> >>> https://github.com/apache/cordova-cli/blob/master/doc/create.txt#L14
> >>>
> >>> Finally nothing is writing in stone, we can change, remove, add to
> this as
> >>> we iterate.
> >>>
> >>> I thought I follow the our community practices as best I understood.
> >>> Wrote a proposal, communicated in the mailing list, got feedback to
> change
> >>> the original 

Re: [DISCUSS] CLI Templates

2016-05-31 Thread Tommy Williams
.npmignore can help with some of those unwanted files, but not all…

However, what happens in the circumstance when the template _does_ need a 
package.json file, such as the react-hot-loader template Jed and I made? It has 
npm dips and npm scripts that are vital to how it works in its package,json. We 
can’t just omit files, Similarly, a template might include hooks and merges as 
well.

- tommy


> On 1 Jun 2016, at 8:22 AM, Carlos Santana  wrote:
> 
> I opened a JIRA for ignoring .git
> Don't have it handy on mobile now
> 
> Best practice:
> 1.  To use subdir feature to specify dir to use via main module
> 2.  To follow npm best practices when publishing to npm (i.e. do not include 
> everything, only the minimum required)
> 
> 
> - Carlos Santana
> @csantanapr
> 
>> On May 31, 2016, at 6:10 PM, Steven Gill  wrote:
>> 
>> Sorry to bring up a old thread instead of starting a new one but I thought
>> the context might be relevant.
>> 
>> Currently, template pretty much copies over all of the files. I see this as
>> a problem.
>> 
>> Example [1]. When you add a template, its package.json gets copied into
>> your app. I don't think we want that to happen right?
>> 
>> Other files that are getting copied but shouldn't:
>> - RELEASENOTES.md
>> - README.md
>> - .git (if you do it locally or f
>> - NOTICE
>> - LICENSE
>> - COPYWRIGHT
>> 
>> Files we want:
>> - config.xml
>> - .gitignore
>> - .npmignore ?
>> - node_modules?
>> - platforms/plugins (if present)
>> - hooks
>> - merges
>> 
>> templates can provide additional info by setting a subdirectory in their
>> package.json for where the template files live.
>> 
>> [1] https://issues.apache.org/jira/browse/CB-11344.
>> 
>> Thoughts?
>> 
>> 
>> 
>> On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana 
>> wrote:
>> 
>>> Oh I'm late on this thread.
>>> 
>>> Latest code is in master cordova-cli and cordova-lib
>>> you have to link lib to cli to get it to show up.
>>> 
>>> if you are lazy like me you can do "npm install -g
>>> csantanapr/cordova-cli-dev"
>>> To see the help "cordova help create"
>>> --template= ... use a custom template located
>>> locally, in NPM, or GitHub.
>>> Options:
>>>   --template= ... use a custom template
>>> located locally, in NPM, or GitHub.
>>>   --copy-from|src= .. deprecated, use
>>> --template instead.
>>>   --link-to=  symlink to custom www
>>> assets without creating a copy.
>>> 
>>> The goal is to help people getting started by using a package from npm as
>>> starting point, I see the samples that Raymond produces being used with the
>>> --template flag for novice users to get a sample running faster. also
>>> opening the door for web frameworks to have their cordova template in npm,
>>> or plugin creators to share templates that uses their plugin, and declare
>>> the plugin in config.xml
>>> 
>>> 1. Omar
>>> what you describe in your list what was implemented
>>> The only thing, that was not implemented because was not in the proposal
>>> and not discuss was ~/.cordova/config.json
>>> 
>>> I didn't added because I think there should be a better architecture for
>>> config. That's another proposal I'm thinking on doing but it looks like how
>>> npm does config
>>> For example  have "cordova config" cli
>>> cordova config set template=my-app-hello
>>> cordova config ls
>>> and so...
>>> so default configs can be override using the CLI
>>> 
>>> 2. Dmitry
>>> Let's have a hangout and let's, talk because I don't understand what is the
>>> problem that --template is causing,
>>> I don't understand if you don't want the flag present, or the
>>> implementation, or you want to keep --copy-from as it is today.
>>> Email is not helping to communicate what is what you think that is broken
>>> 
>>> 3. Simon
>>> There is no much documentation other than the help, and mentioned in the
>>> docs.
>>> Will love some help feedback and help on docs for this .
>>> 
>>> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/guide/cli/index.md
>>> https://github.com/apache/cordova-cli/blob/master/doc/create.txt#L14
>>> 
>>> Finally nothing is writing in stone, we can change, remove, add to this as
>>> we iterate.
>>> 
>>> I thought I follow the our community practices as best I understood.
>>> Wrote a proposal, communicated in the mailing list, got feedback to change
>>> the original proposal to not exclude platforms/plugins and other changes.
>>> had pointers to PR, JIRA, proposal, discussion, waited for feedback on PR,
>>> gave a heads up on that there was no more feedback and everything that was
>>> discuss was implemented.
>>> 
>>> I saw Dmitry'ss comments just after we merge, but I try to give enough
>>> heads up. And will like to understand better what are his concerns.
>>> 
>>> 
>>> On Thu, Dec 10, 2015 at 6:53 PM Simon MacDonald >> 

Re: Cordova Monthly Hangouts

2016-05-31 Thread Kerri Shotts
Quick update on my part — I might be able to make it at that time. A lot
depends upon a couple things going on tomorrow, so I won’t know for sure
just yet, but I’m going to cross my fingers and think a lot of happy
thoughts. :-)




From: Jesse  
Reply: dev@cordova.apache.org 

Date: May 31, 2016 at 5:15:00 PM
To: dev@cordova.apache.org  
Subject:  Re: Cordova Monthly Hangouts

I have deleted all available dates in the past, because if time travel were
ever going to be possible it would already have happened. I have also
deleted the imposter Tommy, and let the good one stay.

At this point, it is looking like Thursday June 2, at 12:00 PM SF Time.

This gives us: Steve, Me, Edna, Joe, Michael, Simon, Dmitry, Vladimir and
Tommy.
But it unfortunately doesn't work for Parshu, or Kerri

Anyone else want to respond?
http://doodle.com/poll/xvifrwwnqci2fti3

Cheers,
Jesse


@purplecabbage
risingj.com

On Tue, May 31, 2016 at 1:03 PM, Jesse  wrote:

> Okay, my apologies, I totally dropped the ball on this.
> Since we are not having the hangout literally 1 hour ago, which was the
> best available time, please everyone have another look and let's see what
> we can salvage from this.
>
> If you haven't put your name in, please do so soon so we can agree on a
> time.
>
> Cheers,
> Jesse
>
>
>
> @purplecabbage
> risingj.com
>
> On Fri, May 13, 2016 at 10:52 AM, Kerri Shotts 
> wrote:
>
>> Thanks for posting the doodle! I've put in my availability.
>>
>> *Kerri Shotts*, photoKandy Studios LLC • (312) 380–1035 • (618) 435–0823
>> *(mobile)*
>>
>> http://www.photokandy.com/ • @photokandy 
>> •
>> Github  • CoderWall
>> 
>>
>> Apps on the Apple  Store →
>> 
>> 
>>
>> → *CONFIDENTIAL* ←
>>
>> This email and any attachments may be confidential. If you are not the
>> intended recipient, please let us know by replying to this message, and
>> then remove the message and its attachments from your system. You should
>> not disseminate, distribute, or otherwise copy or release the
information
>> contained herein, nor can we accept any liability for any loss or
damages
>> resulting from the use, abuse, or mis-use of the information contained
>> herein.
>>
>> → *SECURITY* ←
>>
>> Computer viruses can be distributed via email. It is the recipient’s
>> responsibility to check this email and any attachments for viruses.
Email
>> transmission cannot be guaranteed to be secure or error-free as the
email
>> could have been intercepted, corrupted, delayed, and/or re-transmitted.
>> The
>> sender does not accept any liability for errors or omissions within this
>> message or its attachments, nor for any viruses which may be present.
>>
>> *Note:* We do our very best to ensure that nothing we send contains
>> viruses. However, because of the nature of email and the way it is sent,
>> we
>> can’t promise that some other party hasn’t intercepted our email and
added
>> malicious content. Due to the nature of email, we can’t accept any
>> liability for any damage or loss arising from the use, abuse, or mis-use
>> of
>> this email and any of its attachments.
>>
>> → *PRIVACY* ←
>>
>> Email is not a secure communications medium. When replying to this or
any
>> message, you should not include any information that you do not want the
>> entire world to be capable of seeing. In other words, don’t send
financial
>> accounts (CC#s, Bank Account #s, etc.), passwords, social security
>> numbers,
>> or the like, even when asked directly. photoKandy Studios LLC will
>> *never* ask
>> you for this information.
>>
>> Information transmitted via email may be intercepted and retransmitted
by
>> any number of other entities. This is the nature of email, and as such,
we
>> can’t be held liable for any loss or damage incurred by replying to this
>> message with compromising information. Review your message prior to
>> sending
>> it, and ensure that there is no information you wouldn’t be comfortable
>> with the entire world knowing.
>>
>> On Fri, May 13, 2016 at 12:43 PM, Jesse  wrote:
>>
>> > Here's a doodle for a hangout. Let me know if I should extend the
hours
>> > past 8:00 AM - 7:00 PM Pacific.
>> > http://doodle.com/poll/xvifrwwnqci2fti3
>> >
>> >
>> > @purplecabbage
>> > risingj.com
>> >
>> > On Fri, May 13, 2016 at 4:09 AM, julio cesar sanchez <
>> > jcesarmob...@gmail.com
>> > > wrote:
>> >
>> > > +1
>> > >
>> > > I'll be traveling the next two weeks (not pg day ), so I prefer
>> after
>> > the
>> > > 29th.
>> > >
>> > > Steve, can you send the doodle?
>> > >
>> > >
>> > > El jueves, 12 de mayo de 

[GitHub] cordova-lib pull request: CB-11345 Added '/package.json' to path of template...

2016-05-31 Thread carynbear
GitHub user carynbear opened a pull request:

https://github.com/apache/cordova-lib/pull/446

CB-11345 Added '/package.json' to path of templatePkg



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carynbear/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #446


commit 4501e0b83397479a5eafd33d573acc213a174819
Author: carynbear 
Date:   2016-05-31T22:30:37Z

CB-11345 Added '/package.json' to path of templatePkg

commit f8436b0a210f4cc58e0edb2a4511711f729c3cfe
Author: carynbear 
Date:   2016-05-31T22:31:55Z

Merge branch 'master' of github.com:carynbear/cordova-lib

commit 58234c9ac29f146db47675243b0fa563fbe9fd34
Author: carynbear 
Date:   2016-05-31T22:35:52Z

CB-11345 Added '/package.json' to path of templatePkg




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] CLI Templates

2016-05-31 Thread Carlos Santana
I opened a JIRA for ignoring .git
Don't have it handy on mobile now

Best practice:
1.  To use subdir feature to specify dir to use via main module
2.  To follow npm best practices when publishing to npm (i.e. do not include 
everything, only the minimum required)


- Carlos Santana
@csantanapr

> On May 31, 2016, at 6:10 PM, Steven Gill  wrote:
> 
> Sorry to bring up a old thread instead of starting a new one but I thought
> the context might be relevant.
> 
> Currently, template pretty much copies over all of the files. I see this as
> a problem.
> 
> Example [1]. When you add a template, its package.json gets copied into
> your app. I don't think we want that to happen right?
> 
> Other files that are getting copied but shouldn't:
> - RELEASENOTES.md
> - README.md
> - .git (if you do it locally or f
> - NOTICE
> - LICENSE
> - COPYWRIGHT
> 
> Files we want:
> - config.xml
> - .gitignore
> - .npmignore ?
> - node_modules?
> - platforms/plugins (if present)
> - hooks
> - merges
> 
> templates can provide additional info by setting a subdirectory in their
> package.json for where the template files live.
> 
> [1] https://issues.apache.org/jira/browse/CB-11344.
> 
> Thoughts?
> 
> 
> 
> On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana 
> wrote:
> 
>> Oh I'm late on this thread.
>> 
>> Latest code is in master cordova-cli and cordova-lib
>> you have to link lib to cli to get it to show up.
>> 
>> if you are lazy like me you can do "npm install -g
>> csantanapr/cordova-cli-dev"
>> To see the help "cordova help create"
>> --template= ... use a custom template located
>> locally, in NPM, or GitHub.
>>  Options:
>>--template= ... use a custom template
>> located locally, in NPM, or GitHub.
>>--copy-from|src= .. deprecated, use
>> --template instead.
>>--link-to=  symlink to custom www
>> assets without creating a copy.
>> 
>> The goal is to help people getting started by using a package from npm as
>> starting point, I see the samples that Raymond produces being used with the
>> --template flag for novice users to get a sample running faster. also
>> opening the door for web frameworks to have their cordova template in npm,
>> or plugin creators to share templates that uses their plugin, and declare
>> the plugin in config.xml
>> 
>> 1. Omar
>> what you describe in your list what was implemented
>> The only thing, that was not implemented because was not in the proposal
>> and not discuss was ~/.cordova/config.json
>> 
>> I didn't added because I think there should be a better architecture for
>> config. That's another proposal I'm thinking on doing but it looks like how
>> npm does config
>> For example  have "cordova config" cli
>> cordova config set template=my-app-hello
>> cordova config ls
>> and so...
>> so default configs can be override using the CLI
>> 
>> 2. Dmitry
>> Let's have a hangout and let's, talk because I don't understand what is the
>> problem that --template is causing,
>> I don't understand if you don't want the flag present, or the
>> implementation, or you want to keep --copy-from as it is today.
>> Email is not helping to communicate what is what you think that is broken
>> 
>> 3. Simon
>> There is no much documentation other than the help, and mentioned in the
>> docs.
>> Will love some help feedback and help on docs for this .
>> 
>> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/guide/cli/index.md
>> https://github.com/apache/cordova-cli/blob/master/doc/create.txt#L14
>> 
>> Finally nothing is writing in stone, we can change, remove, add to this as
>> we iterate.
>> 
>> I thought I follow the our community practices as best I understood.
>> Wrote a proposal, communicated in the mailing list, got feedback to change
>> the original proposal to not exclude platforms/plugins and other changes.
>> had pointers to PR, JIRA, proposal, discussion, waited for feedback on PR,
>> gave a heads up on that there was no more feedback and everything that was
>> discuss was implemented.
>> 
>> I saw Dmitry'ss comments just after we merge, but I try to give enough
>> heads up. And will like to understand better what are his concerns.
>> 
>> 
>> On Thu, Dec 10, 2015 at 6:53 PM Simon MacDonald >> 
>> wrote:
>> 
>>> Are there docs checked in anywhere that describe how to use the
>> --template
>>> flag?
>>> 
>>> 
>>> Simon Mac Donald
>>> http://hi.im/simonmacdonald
>>> 
>>> On Thu, Dec 10, 2015 at 4:55 PM, Raymond Camden >> 
>>> wrote:
>>> 
 Looks like --template wasn't added to the CLI help. Will file a bug.
 
 On Wed, Dec 9, 2015 at 12:06 AM, Steven Gill 
 wrote:
> The thread was proposed Nov 10th and PR was merged Dec 3rd. I think
>>> that
 is
> ample time to give feedback. If people don't give feedback, apache
>> way
>>> 

Re: Cordova Monthly Hangouts

2016-05-31 Thread Jesse
I have deleted all available dates in the past, because if time travel were
ever going to be possible it would already have happened. I have also
deleted the imposter Tommy, and let the good one stay.

At this point, it is looking like Thursday June 2, at 12:00 PM SF Time.

This gives us: Steve, Me, Edna, Joe, Michael, Simon, Dmitry, Vladimir and
Tommy.
But it unfortunately doesn't work for Parshu, or Kerri

Anyone else want to respond?
http://doodle.com/poll/xvifrwwnqci2fti3

Cheers,
  Jesse


@purplecabbage
risingj.com

On Tue, May 31, 2016 at 1:03 PM, Jesse  wrote:

> Okay, my apologies, I totally dropped the ball on this.
> Since we are not having the hangout literally 1 hour ago, which was the
> best available time, please everyone have another look and let's see what
> we can salvage from this.
>
> If you haven't put your name in, please do so soon so we can agree on a
> time.
>
> Cheers,
>   Jesse
>
>
>
> @purplecabbage
> risingj.com
>
> On Fri, May 13, 2016 at 10:52 AM, Kerri Shotts 
> wrote:
>
>> Thanks for posting the doodle! I've put in my availability.
>>
>> *Kerri Shotts*, photoKandy Studios LLC • (312) 380–1035 • (618) 435–0823
>> *(mobile)*
>>
>> http://www.photokandy.com/ • @photokandy 
>> •
>> Github  • CoderWall
>> 
>>
>> Apps on the Apple  Store →
>> 
>> 
>>
>> → *CONFIDENTIAL* ←
>>
>> This email and any attachments may be confidential. If you are not the
>> intended recipient, please let us know by replying to this message, and
>> then remove the message and its attachments from your system. You should
>> not disseminate, distribute, or otherwise copy or release the information
>> contained herein, nor can we accept any liability for any loss or damages
>> resulting from the use, abuse, or mis-use of the information contained
>> herein.
>>
>> → *SECURITY* ←
>>
>> Computer viruses can be distributed via email. It is the recipient’s
>> responsibility to check this email and any attachments for viruses. Email
>> transmission cannot be guaranteed to be secure or error-free as the email
>> could have been intercepted, corrupted, delayed, and/or re-transmitted.
>> The
>> sender does not accept any liability for errors or omissions within this
>> message or its attachments, nor for any viruses which may be present.
>>
>> *Note:* We do our very best to ensure that nothing we send contains
>> viruses. However, because of the nature of email and the way it is sent,
>> we
>> can’t promise that some other party hasn’t intercepted our email and added
>> malicious content. Due to the nature of email, we can’t accept any
>> liability for any damage or loss arising from the use, abuse, or mis-use
>> of
>> this email and any of its attachments.
>>
>> → *PRIVACY* ←
>>
>> Email is not a secure communications medium. When replying to this or any
>> message, you should not include any information that you do not want the
>> entire world to be capable of seeing. In other words, don’t send financial
>> accounts (CC#s, Bank Account #s, etc.), passwords, social security
>> numbers,
>> or the like, even when asked directly. photoKandy Studios LLC will
>> *never*  ask
>> you for this information.
>>
>> Information transmitted via email may be intercepted and retransmitted by
>> any number of other entities. This is the nature of email, and as such, we
>> can’t be held liable for any loss or damage incurred by replying to this
>> message with compromising information. Review your message prior to
>> sending
>> it, and ensure that there is no information you wouldn’t be comfortable
>> with the entire world knowing.
>>
>> On Fri, May 13, 2016 at 12:43 PM, Jesse  wrote:
>>
>> > Here's a doodle for a hangout. Let me know if I should extend the hours
>> > past 8:00 AM - 7:00 PM Pacific.
>> > http://doodle.com/poll/xvifrwwnqci2fti3
>> >
>> >
>> > @purplecabbage
>> > risingj.com
>> >
>> > On Fri, May 13, 2016 at 4:09 AM, julio cesar sanchez <
>> > jcesarmob...@gmail.com
>> > > wrote:
>> >
>> > > +1
>> > >
>> > > I'll be traveling the next two weeks (not pg day ), so I prefer
>> after
>> > the
>> > > 29th.
>> > >
>> > > Steve, can you send the doodle?
>> > >
>> > >
>> > > El jueves, 12 de mayo de 2016, Shazron  escribió:
>> > >
>> > > > +1
>> > > >
>> > > > On Wed, May 11, 2016 at 12:50 PM, Steven Gill <
>> stevengil...@gmail.com
>> > > > >
>> > > > wrote:
>> > > >
>> > > > > A hangout sounds good. We need to pick a date and time. Should I
>> send
>> > > > out a
>> > > > > doodle?
>> > > > >
>> > > > > For me personally, I won't be able to attend until the first week
>> of
>> > > June
>> > > > > due to PGDAY EU travels.
>> > > > >
>> > > > > On Tue, May 10, 2016 at 11:55 AM, 

[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redirects when d...

2016-05-31 Thread Pazkov
Github user Pazkov commented on the pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/126
  
Please merge...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] CLI Templates

2016-05-31 Thread Steven Gill
Sorry to bring up a old thread instead of starting a new one but I thought
the context might be relevant.

Currently, template pretty much copies over all of the files. I see this as
a problem.

Example [1]. When you add a template, its package.json gets copied into
your app. I don't think we want that to happen right?

Other files that are getting copied but shouldn't:
- RELEASENOTES.md
- README.md
- .git (if you do it locally or f
- NOTICE
- LICENSE
- COPYWRIGHT

Files we want:
- config.xml
- .gitignore
- .npmignore ?
- node_modules?
- platforms/plugins (if present)
- hooks
- merges

templates can provide additional info by setting a subdirectory in their
package.json for where the template files live.

[1] https://issues.apache.org/jira/browse/CB-11344.

Thoughts?



On Fri, Dec 11, 2015 at 7:09 AM, Carlos Santana 
wrote:

> Oh I'm late on this thread.
>
> Latest code is in master cordova-cli and cordova-lib
> you have to link lib to cli to get it to show up.
>
> if you are lazy like me you can do "npm install -g
> csantanapr/cordova-cli-dev"
> To see the help "cordova help create"
> --template= ... use a custom template located
> locally, in NPM, or GitHub.
>   Options:
> --template= ... use a custom template
> located locally, in NPM, or GitHub.
> --copy-from|src= .. deprecated, use
> --template instead.
> --link-to=  symlink to custom www
> assets without creating a copy.
>
> The goal is to help people getting started by using a package from npm as
> starting point, I see the samples that Raymond produces being used with the
> --template flag for novice users to get a sample running faster. also
> opening the door for web frameworks to have their cordova template in npm,
> or plugin creators to share templates that uses their plugin, and declare
> the plugin in config.xml
>
> 1. Omar
> what you describe in your list what was implemented
> The only thing, that was not implemented because was not in the proposal
> and not discuss was ~/.cordova/config.json
>
> I didn't added because I think there should be a better architecture for
> config. That's another proposal I'm thinking on doing but it looks like how
> npm does config
> For example  have "cordova config" cli
> cordova config set template=my-app-hello
> cordova config ls
> and so...
> so default configs can be override using the CLI
>
> 2. Dmitry
> Let's have a hangout and let's, talk because I don't understand what is the
> problem that --template is causing,
> I don't understand if you don't want the flag present, or the
> implementation, or you want to keep --copy-from as it is today.
> Email is not helping to communicate what is what you think that is broken
>
> 3. Simon
> There is no much documentation other than the help, and mentioned in the
> docs.
> Will love some help feedback and help on docs for this .
>
> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/guide/cli/index.md
> https://github.com/apache/cordova-cli/blob/master/doc/create.txt#L14
>
> Finally nothing is writing in stone, we can change, remove, add to this as
> we iterate.
>
> I thought I follow the our community practices as best I understood.
> Wrote a proposal, communicated in the mailing list, got feedback to change
> the original proposal to not exclude platforms/plugins and other changes.
> had pointers to PR, JIRA, proposal, discussion, waited for feedback on PR,
> gave a heads up on that there was no more feedback and everything that was
> discuss was implemented.
>
> I saw Dmitry'ss comments just after we merge, but I try to give enough
> heads up. And will like to understand better what are his concerns.
>
>
> On Thu, Dec 10, 2015 at 6:53 PM Simon MacDonald  >
> wrote:
>
> > Are there docs checked in anywhere that describe how to use the
> --template
> > flag?
> >
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> > On Thu, Dec 10, 2015 at 4:55 PM, Raymond Camden  >
> > wrote:
> >
> > > Looks like --template wasn't added to the CLI help. Will file a bug.
> > >
> > > On Wed, Dec 9, 2015 at 12:06 AM, Steven Gill 
> > > wrote:
> > > > The thread was proposed Nov 10th and PR was merged Dec 3rd. I think
> > that
> > > is
> > > > ample time to give feedback. If people don't give feedback, apache
> way
> > is
> > > > consider it as lazy consensus.
> > > >
> > > > We do not vote on feature requests and I hope we never do as it is a
> > > > terrible practice. Good luck trying to get anything done.
> > > > The `--template` flag currently there is the one that was added as
> per
> > > this
> > > > discussion. I think in the future we should refrain from adding code
> > > before
> > > > a discussion completes, especially if there is contention. At the
> very
> > > > least, we should probably hold a vote.
> > > >
> > > > I’m 

Re: Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-31 Thread Frederico Galvão
I know it's only a detail, but https://github.com/phonegap-build/PushPlugin,
the example used as a plugin that would "break", is a deprecated and old
plugin.

2016-05-31 13:46 GMT-03:00 Nikhil Khandelwal :

> It sounds like you are working on a plan to remap the older directory
> structure to a new one. Will look forward to updates on the design and code
> for that. In that case our expectation is that most plugins will not break
> - is that correct? It will be great to do some compat testing with say the
> top plugins.
>
> I understand it's hard to guarantee complete compat and we need to move
> forward but breaking the entire plugin ecosystem will cause a lot of issues
> for existing Cordova developers.
>
> -Nikhil
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Tuesday, May 31, 2016 8:22 AM
> To: dev 
> Subject: Re: Proposal: Change Android Project Directory Structure to
> Android Studio style
>
> On Fri, May 27, 2016 at 12:22 PM, Nikhil Khandelwal <
> nikhi...@microsoft.com>
> wrote:
>
> > As I see it, a change to the directory structure will break almost
> > every Android plugin currently out there.
> >
> >
> I know.  However, I don't think that's a good enough reason to not do this.
>
>
> > There are atleast 20K references [1] on github where people use depend
> > on the current directory structure for android: "res/xml/config.xml".
> >
> > Taking the example of a config.xml manipulation that will now stop
> working:
> > https://github.com/phonegap-build/PushPlugin/blob/master/plugin.xml#L3
> > 4
> >
> > Can you explain how source-file and other tags that reference path
> > will continue to work? Looking at your current branch [2] there are
> > not changes to path old path references in plugin.xml to new path.
> >
>
> Actually, here's the thing.  They won't.  We're going to have to fix our
> tooling so that they remap.  After working on the exploratory branch, all
> our plugin installation code is stuck in plugman and really should be
> handled by the platforms so that we can actually handle changes to Android
> Studio and Xcode.
>
> What I'm now proposing is that by default when we specify a source file,
> or a config file without specifying a target, it by default goes to a
> location specified by the project.  That means that when you are using an
> Android Studio project, it knows that we keep the config.xml in a different
> location than the old project.  That way, if Google decides that they don't
> like the current Android Studio project structure and they decide to change
> things again, we're not stuck holding the bag for years and being stuck
> having to do all this work so that we can actually allow native developers
> to be able to use Cordova, since it's almost completely unusable to these
> developers currently.
>
>
> >
> > If the path of the file changes it will break lots of plugins and if
> > the plugins change to work with the new directory structure they will
> > not work with older versions of Cordova. Let me know if I missed some
> > part of this change which ensures most plugins for Android do not stop
> working.
> >
> > [1]
> > https://github.com/search?q=%22res%2Fxml%2Fconfig.xml%22+filename%3Apl
> > ugin.xml=searchresults=Code=%E2%9C%93
> > [2]
> > https://github.com/apache/cordova-android/compare/master...infil00p:st
> > udio_project_structure
> >
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Tuesday, May 17, 2016 8:14 PM
> > To: dev 
> > Subject: Re: Proposal: Change Android Project Directory Structure to
> > Android Studio style
> >
> > On Tue, May 17, 2016 at 5:35 PM, Richard Knoll 
> > wrote:
> >
> > > Does that mean the plan is to provide a mapping from old file
> > > locations to new ones? For example, if I have this in my plugin.xml:
> > >
> > > 
> > >
> > > Will the new cordova-android automatically convert the target value
> > > to the new location of "app/src/main/res/values/strings.xml"?
> > >
> >
> >
> > I'm pretty sure that config-file targets like that won't work
> > properly, but I think that source, resource and assets should.  I
> > would have added that as a resource file, since it's strings.xml.
> >
> >
> > >
> > > Thanks,
> > > Richard
> > >
> > > -Original Message-
> > > From: Joe Bowser [mailto:bows...@gmail.com]
> > > Sent: Tuesday, May 17, 2016 3:51 PM
> > > To: dev 
> > > Subject: Re: Proposal: Change Android Project Directory Structure to
> > > Android Studio style
> > >
> > > @Richard: The changes to the Android files in cordova-common should
> > > allow for config-file, source-file and resource-file to work fine.
> > > I already did something similar in February, but I should have
> > > checked it in on an Cordova-Android branch instead of the other repo.
> > >
> > > https://github.com/infil00p/cordova-android-studio
> > >
> > > 

[GitHub] cordova-plugin-device-orientation pull request: add Android support for true...

2016-05-31 Thread sinzianag
Github user sinzianag commented on the pull request:

https://github.com/apache/cordova-plugin-device-orientation/pull/19
  
Most calls to Location Manager require permissions that in android 5.0+ 
need to be handled at runtime (ACCESS_COARSE_LOCATION,ACCESS_FINE_LOCATION) and 
I don't see any code in this PR that handles that.
Other plugins seem to be using the [Permission Helper from compat 
plugin](https://github.com/apache/cordova-plugin-compat/blob/master/src/android/PermissionHelper.java).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: Master

2016-05-31 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/147
  
Please change the title of the pull request to something more meaningful. 
Rebase and squash all the commits and file a JIRA issue here talking about the 
feature and its purpose: https://issues.apache.org/jira/browse/CB/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file-transfer pull request: Master

2016-05-31 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/147
  
There are some test failures as `options` might be undefined: 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15/label=mac-slave,platformName=android/testReport/junit/cordova-plugin-file-transfer-tests.tests%20%3E%3E.FileTransfer.methods/download/filetransfer_spec_4_should_download_a_file/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: [DISCUSS] Cordova-Android 5.2.0 Release

2016-05-31 Thread Nikhil Khandelwal
Support for incremental prepare (PR #295) has been merged. We should be ready 
for a release.

-Nikhil

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Thursday, May 26, 2016 2:52 PM
To: dev 
Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release

Do we have an N PR yet? I've seen the proposal, but not the PR.

On Thu, May 26, 2016 at 2:47 PM, Steven Gill  wrote:

> Can we merge the android N PR too?
>
> On Wed, May 25, 2016 at 2:50 PM, Joe Bowser  wrote:
>
> > On Wed, May 25, 2016 at 1:47 PM, Homer, Tony 
> wrote:
> >
> > > +1
> > >
> > > Would like #307 to be merged in first
> > >
> > >
> > Done! Yay for tests!
> >
> > BTW, We need to re-write those to migrate to the new Android JUnit 
> > test framework (It's more deleting code than adding).
> >
> >
> >
> >
> > > On 5/25/16, 3:31 PM, "Carlos Santana"  wrote:
> > >
> > > >+1
> > > >
> > > >- Carlos
> > > >@csantanapr
> > > >
> > > >> On May 25, 2016, at 3:08 PM, Shazron  wrote:
> > > >>
> > > >> +1
> > > >>
> > > >> Release often
> > > >>
> > > >>> On Wed, May 25, 2016 at 10:33 AM, Joe Bowser 
> > > >>> 
> > > wrote:
> > > >>>
> > > >>> Hey
> > > >>>
> > > >>> I know that we haven't done a minor release for a few months 
> > > >>> for
> > > Android,
> > > >>> and I think that we have enough worthwhile changes in Android 
> > > >>> that
> we
> > > >>> should probably do a release soon.  If possible, I would like 
> > > >>> for
> us
> > > to do
> > > >>> a 5.2.0 release with the versioning fix, and the other build 
> > > >>> script
> > > fixes
> > > >>> that have been done recently.  There's not a lot of commits, 
> > > >>> but I
> do
> > > think
> > > >>> what we do have is worthy of being released.
> > > >>>
> > > >>> What do people think?
> > > >>>
> > > >>> Joe
> > > >>>
> > > >
> > > >-
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > >For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > >
> > >
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


Re: Cordova Monthly Hangouts

2016-05-31 Thread Jesse
Okay, my apologies, I totally dropped the ball on this.
Since we are not having the hangout literally 1 hour ago, which was the
best available time, please everyone have another look and let's see what
we can salvage from this.

If you haven't put your name in, please do so soon so we can agree on a
time.

Cheers,
  Jesse



@purplecabbage
risingj.com

On Fri, May 13, 2016 at 10:52 AM, Kerri Shotts  wrote:

> Thanks for posting the doodle! I've put in my availability.
>
> *Kerri Shotts*, photoKandy Studios LLC • (312) 380–1035 • (618) 435–0823
> *(mobile)*
>
> http://www.photokandy.com/ • @photokandy  •
> Github  • CoderWall
> 
>
> Apps on the Apple  Store →
> 
> 
>
> → *CONFIDENTIAL* ←
>
> This email and any attachments may be confidential. If you are not the
> intended recipient, please let us know by replying to this message, and
> then remove the message and its attachments from your system. You should
> not disseminate, distribute, or otherwise copy or release the information
> contained herein, nor can we accept any liability for any loss or damages
> resulting from the use, abuse, or mis-use of the information contained
> herein.
>
> → *SECURITY* ←
>
> Computer viruses can be distributed via email. It is the recipient’s
> responsibility to check this email and any attachments for viruses. Email
> transmission cannot be guaranteed to be secure or error-free as the email
> could have been intercepted, corrupted, delayed, and/or re-transmitted. The
> sender does not accept any liability for errors or omissions within this
> message or its attachments, nor for any viruses which may be present.
>
> *Note:* We do our very best to ensure that nothing we send contains
> viruses. However, because of the nature of email and the way it is sent, we
> can’t promise that some other party hasn’t intercepted our email and added
> malicious content. Due to the nature of email, we can’t accept any
> liability for any damage or loss arising from the use, abuse, or mis-use of
> this email and any of its attachments.
>
> → *PRIVACY* ←
>
> Email is not a secure communications medium. When replying to this or any
> message, you should not include any information that you do not want the
> entire world to be capable of seeing. In other words, don’t send financial
> accounts (CC#s, Bank Account #s, etc.), passwords, social security numbers,
> or the like, even when asked directly. photoKandy Studios LLC will
> *never*  ask
> you for this information.
>
> Information transmitted via email may be intercepted and retransmitted by
> any number of other entities. This is the nature of email, and as such, we
> can’t be held liable for any loss or damage incurred by replying to this
> message with compromising information. Review your message prior to sending
> it, and ensure that there is no information you wouldn’t be comfortable
> with the entire world knowing.
>
> On Fri, May 13, 2016 at 12:43 PM, Jesse  wrote:
>
> > Here's a doodle for a hangout. Let me know if I should extend the hours
> > past 8:00 AM - 7:00 PM Pacific.
> > http://doodle.com/poll/xvifrwwnqci2fti3
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Fri, May 13, 2016 at 4:09 AM, julio cesar sanchez <
> > jcesarmob...@gmail.com
> > > wrote:
> >
> > > +1
> > >
> > > I'll be traveling the next two weeks (not pg day ), so I prefer after
> > the
> > > 29th.
> > >
> > > Steve, can you send the doodle?
> > >
> > >
> > > El jueves, 12 de mayo de 2016, Shazron  escribió:
> > >
> > > > +1
> > > >
> > > > On Wed, May 11, 2016 at 12:50 PM, Steven Gill <
> stevengil...@gmail.com
> > > > >
> > > > wrote:
> > > >
> > > > > A hangout sounds good. We need to pick a date and time. Should I
> send
> > > > out a
> > > > > doodle?
> > > > >
> > > > > For me personally, I won't be able to attend until the first week
> of
> > > June
> > > > > due to PGDAY EU travels.
> > > > >
> > > > > On Tue, May 10, 2016 at 11:55 AM, Parashuram N <
> > panar...@microsoft.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > It has been a while since all of us met, so I was wondering if it
> > > would
> > > > > > help to do a Cordova Monthly hangout ? I also understand that we
> > have
> > > > > > Phonegap day EU this month, and maybe we could use that timeframe
> > to
> > > > get
> > > > > > more folks involved in the hangout ? For the rest of us who could
> > not
> > > > > > attend Phonegap day EU, we could do the hangount. It may also
> help
> > > > other
> > > > > > community members see how we do hangouts, and may be a way to
> > > encourage
> > > > > > them to participate even more ?
> > > > > >
> > > > > > I was thinking that we could discuss some of the 

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimize prepare ...

2016-05-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/295


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: NPM v3 packaging issues

2016-05-31 Thread Jason Ginchereau
Could npm shrinkwrap be a solution? The cordova-coho docs mention shrinkwrap 
was avoided previously because it was "not mature", but it has apparently 
improved a lot in v3. According to a comment [1] in another related issue it 
has solved this problem in v3. I'm not totally familiar with the platform 
versioning and packaging strategy though so I may be missing something.

[1] https://github.com/npm/npm/issues/11287#issuecomment-175262681


Jason


-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Tuesday, May 31, 2016 12:11 AM
To: dev@cordova.apache.org
Subject: NPM v3 packaging issues

Hey, guys

We've just ran into issue, caused by NPM v3 flat directory structure. The issue 
is that NPM does not pack sub-dependencies of bundled dependencies into 
resultant archive. This only affects flatten dependency trees, but we already 
switched to that in platform repos.

As an example, we have 'elementtree' dependency in cordova-windows, which 
depends on 'sax'. After running 'npm install' these dependencies installed as a 
siblings into 'node_modules', but after running 'npm pack' (in particular - 
'coho create-archive') the resultant .tgz contains ONLY 'elementtree' but not 
'sax'.

Related NPM issue is https://github.com/npm/npm/issues/8474

AFAIK, the only solution for now is to revert 'node_modules' structure back to 
tree form.

-
Best regards, Vladimir

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



RE: Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-31 Thread Nikhil Khandelwal
It sounds like you are working on a plan to remap the older directory structure 
to a new one. Will look forward to updates on the design and code for that. In 
that case our expectation is that most plugins will not break - is that 
correct? It will be great to do some compat testing with say the top plugins. 

I understand it's hard to guarantee complete compat and we need to move forward 
but breaking the entire plugin ecosystem will cause a lot of issues for 
existing Cordova developers. 

-Nikhil

-Original Message-
From: Joe Bowser [mailto:bows...@gmail.com] 
Sent: Tuesday, May 31, 2016 8:22 AM
To: dev 
Subject: Re: Proposal: Change Android Project Directory Structure to Android 
Studio style

On Fri, May 27, 2016 at 12:22 PM, Nikhil Khandelwal 
wrote:

> As I see it, a change to the directory structure will break almost 
> every Android plugin currently out there.
>
>
I know.  However, I don't think that's a good enough reason to not do this.


> There are atleast 20K references [1] on github where people use depend 
> on the current directory structure for android: "res/xml/config.xml".
>
> Taking the example of a config.xml manipulation that will now stop working:
> https://github.com/phonegap-build/PushPlugin/blob/master/plugin.xml#L3
> 4
>
> Can you explain how source-file and other tags that reference path 
> will continue to work? Looking at your current branch [2] there are 
> not changes to path old path references in plugin.xml to new path.
>

Actually, here's the thing.  They won't.  We're going to have to fix our 
tooling so that they remap.  After working on the exploratory branch, all our 
plugin installation code is stuck in plugman and really should be handled by 
the platforms so that we can actually handle changes to Android Studio and 
Xcode.

What I'm now proposing is that by default when we specify a source file, or a 
config file without specifying a target, it by default goes to a location 
specified by the project.  That means that when you are using an Android Studio 
project, it knows that we keep the config.xml in a different location than the 
old project.  That way, if Google decides that they don't like the current 
Android Studio project structure and they decide to change things again, we're 
not stuck holding the bag for years and being stuck having to do all this work 
so that we can actually allow native developers to be able to use Cordova, 
since it's almost completely unusable to these developers currently.


>
> If the path of the file changes it will break lots of plugins and if 
> the plugins change to work with the new directory structure they will 
> not work with older versions of Cordova. Let me know if I missed some 
> part of this change which ensures most plugins for Android do not stop 
> working.
>
> [1]
> https://github.com/search?q=%22res%2Fxml%2Fconfig.xml%22+filename%3Apl
> ugin.xml=searchresults=Code=%E2%9C%93
> [2]
> https://github.com/apache/cordova-android/compare/master...infil00p:st
> udio_project_structure
>
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Tuesday, May 17, 2016 8:14 PM
> To: dev 
> Subject: Re: Proposal: Change Android Project Directory Structure to 
> Android Studio style
>
> On Tue, May 17, 2016 at 5:35 PM, Richard Knoll 
> wrote:
>
> > Does that mean the plan is to provide a mapping from old file 
> > locations to new ones? For example, if I have this in my plugin.xml:
> >
> > 
> >
> > Will the new cordova-android automatically convert the target value 
> > to the new location of "app/src/main/res/values/strings.xml"?
> >
>
>
> I'm pretty sure that config-file targets like that won't work 
> properly, but I think that source, resource and assets should.  I 
> would have added that as a resource file, since it's strings.xml.
>
>
> >
> > Thanks,
> > Richard
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Tuesday, May 17, 2016 3:51 PM
> > To: dev 
> > Subject: Re: Proposal: Change Android Project Directory Structure to 
> > Android Studio style
> >
> > @Richard: The changes to the Android files in cordova-common should 
> > allow for config-file, source-file and resource-file to work fine.  
> > I already did something similar in February, but I should have 
> > checked it in on an Cordova-Android branch instead of the other repo.
> >
> > https://github.com/infil00p/cordova-android-studio
> >
> > @Parashuram: Does this drop the JAR is libs?  I couldn't quite tell 
> > from looking at the JS code doing the installation.  If it does, 
> > that won't change at all.
> >
> > On Tue, May 17, 2016 at 3:03 PM, Parashuram N 
> > 
> > wrote:
> >
> > > This is an example -
> > > https://github.com/ConnectSDK/Connect-SDK-Cordova-Plugin. This 
> > > actually has a hook that downloads and places the 

[GitHub] cordova-android pull request: CB-11343: Handle Java versions after JEP-223

2016-05-31 Thread codecov-io
Github user codecov-io commented on the pull request:

https://github.com/apache/cordova-android/pull/308
  
## [Current coverage][cc-pull] is **34.21%**
> Merging [#308][cc-pull] into [master][cc-base-branch] will not change 
coverage

```diff
@@ master   #308   diff @@
==
  Files11 11  
  Lines   947947  
  Methods 194194  
  Messages  0  0  
  Branches153153  
==
  Hits324324  
  Misses  623623  
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 
[d125ece...8573555][cc-compare]
[cc-base-branch]: 
https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-compare]: 
https://codecov.io/gh/apache/cordova-android/compare/d125ece9e9598f6b4f52e2148e8005f0fbabc5c8...857355503635857d7bbe017a23566fa8db7eb42f
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/308?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: Cb 11343

2016-05-31 Thread ankon
GitHub user ankon opened a pull request:

https://github.com/apache/cordova-android/pull/308

Cb 11343



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ankon/cordova-android CB-11343

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #308


commit 765804226dd608a3e272b6f1010d0df24d535a82
Author: Andreas Kohn 
Date:   2016-05-31T15:21:17Z

Fix a typo

commit 70ac31b4686a957311680e0230cdc51a356e
Author: Andreas Kohn 
Date:   2016-05-31T15:30:17Z

Remove the check for javacPath

At this point this will always be false-y.

commit 8d2d21fd40018714436e961b7714df460837e6a2
Author: Andreas Kohn 
Date:   2016-05-31T15:43:36Z

CB-11343: Handle Java versions after JEP-223




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: Proposal: Change Android Project Directory Structure to Android Studio style

2016-05-31 Thread Joe Bowser
On Fri, May 27, 2016 at 12:22 PM, Nikhil Khandelwal 
wrote:

> As I see it, a change to the directory structure will break almost every
> Android plugin currently out there.
>
>
I know.  However, I don't think that's a good enough reason to not do this.


> There are atleast 20K references [1] on github where people use depend on
> the current directory structure for android: "res/xml/config.xml".
>
> Taking the example of a config.xml manipulation that will now stop working:
> https://github.com/phonegap-build/PushPlugin/blob/master/plugin.xml#L34
>
> Can you explain how source-file and other tags that reference path will
> continue to work? Looking at your current branch [2] there are not changes
> to path old path references in plugin.xml to new path.
>

Actually, here's the thing.  They won't.  We're going to have to fix our
tooling so that they remap.  After working on the exploratory branch, all
our plugin installation code is stuck in plugman and really should be
handled by the platforms so that we can actually handle changes to Android
Studio and Xcode.

What I'm now proposing is that by default when we specify a source file, or
a config file without specifying a target, it by default goes to a location
specified by the project.  That means that when you are using an Android
Studio project, it knows that we keep the config.xml in a different
location than the old project.  That way, if Google decides that they don't
like the current Android Studio project structure and they decide to change
things again, we're not stuck holding the bag for years and being stuck
having to do all this work so that we can actually allow native developers
to be able to use Cordova, since it's almost completely unusable to these
developers currently.


>
> If the path of the file changes it will break lots of plugins and if the
> plugins change to work with the new directory structure they will not work
> with older versions of Cordova. Let me know if I missed some part of this
> change which ensures most plugins for Android do not stop working.
>
> [1]
> https://github.com/search?q=%22res%2Fxml%2Fconfig.xml%22+filename%3Aplugin.xml=searchresults=Code=%E2%9C%93
> [2]
> https://github.com/apache/cordova-android/compare/master...infil00p:studio_project_structure
>
>
> -Original Message-
> From: Joe Bowser [mailto:bows...@gmail.com]
> Sent: Tuesday, May 17, 2016 8:14 PM
> To: dev 
> Subject: Re: Proposal: Change Android Project Directory Structure to
> Android Studio style
>
> On Tue, May 17, 2016 at 5:35 PM, Richard Knoll 
> wrote:
>
> > Does that mean the plan is to provide a mapping from old file
> > locations to new ones? For example, if I have this in my plugin.xml:
> >
> > 
> >
> > Will the new cordova-android automatically convert the target value to
> > the new location of "app/src/main/res/values/strings.xml"?
> >
>
>
> I'm pretty sure that config-file targets like that won't work properly,
> but I think that source, resource and assets should.  I would have added
> that as a resource file, since it's strings.xml.
>
>
> >
> > Thanks,
> > Richard
> >
> > -Original Message-
> > From: Joe Bowser [mailto:bows...@gmail.com]
> > Sent: Tuesday, May 17, 2016 3:51 PM
> > To: dev 
> > Subject: Re: Proposal: Change Android Project Directory Structure to
> > Android Studio style
> >
> > @Richard: The changes to the Android files in cordova-common should
> > allow for config-file, source-file and resource-file to work fine.  I
> > already did something similar in February, but I should have checked
> > it in on an Cordova-Android branch instead of the other repo.
> >
> > https://github.com/infil00p/cordova-android-studio
> >
> > @Parashuram: Does this drop the JAR is libs?  I couldn't quite tell
> > from looking at the JS code doing the installation.  If it does, that
> > won't change at all.
> >
> > On Tue, May 17, 2016 at 3:03 PM, Parashuram N 
> > wrote:
> >
> > > This is an example -
> > > https://github.com/ConnectSDK/Connect-SDK-Cordova-Plugin. This
> > > actually has a hook that downloads and places the source code based
> > > on the current directory structure.
> > >
> > > On 5/17/16, 2:53 PM, "Richard Knoll"  wrote:
> > >
> > > >We have a lot of plugin.xml elements that depend on the old file
> > > structure. Tags like config-file, source-file, resource-file, etc.
> > > all have target elements that take arbitrary paths to project files.
> > > Looking at the new project structure, it seems like most of the
> > > relevant folders have moved around. Does your proposal handle that
> > > or do plugins need to update to reflect the new structure? I figure
> > > there isn't much we can do for plugins that use hooks.
> > > >
> > > >Richard
> > > >
> > > >-Original Message-
> > > >From: Joe Bowser [mailto:bows...@gmail.com]
> > > >Sent: Tuesday, May 17, 2016 

[Vote] Cordova-windows 4.4.0 release

2016-05-31 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this 5.0.0 Android Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-11334

The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-11334

The package was published from its corresponding git tag:
cordova-windows: 4.4.0 (4c0c81a121)

Note that you can test it out via:
cordova platform add https://github.com/apache/cordova-windows#4.4.0

Upon a successful vote I will upload the archive to dist/, publish it to npm, 
and post the blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the repo
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* Ran unit and e2e tests
* Created and ran mobilespec app

-
Best regards, Vladimir


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

2016-05-31 Thread daserge
Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/276#issuecomment-222627964
  
The tags a commit is released under are below the commit description, for 
example:


https://github.com/apache/cordova-android/commit/bc9e895e2537f212756eb8e18559fac2cb02c536
`master (#276)`


https://github.com/apache/cordova-android/commit/ce2525d4d8b2b7c2af0b467f99490529c14beb1d
`master (#260)  rel/5.1.1 5.1.1`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

2016-05-31 Thread pke
Github user pke commented on the pull request:

https://github.com/apache/cordova-android/pull/276#issuecomment-222626969
  
ah ok, thanks. For the future: Are fixed + released PR marked here with a 
special label?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

2016-05-31 Thread daserge
Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/276#issuecomment-222618225
  
@pke, the fix is not released yet.
You can use master version for now: `cordova platform add 
https://github.com/apache/cordova-android`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



NPM v3 packaging issues

2016-05-31 Thread Vladimir Kotikov (Akvelon)
Hey, guys

We've just ran into issue, caused by NPM v3 flat directory structure. The issue 
is that NPM does not pack sub-dependencies of bundled dependencies into 
resultant archive. This only affects flatten dependency trees, but we already 
switched to that in platform repos.

As an example, we have 'elementtree' dependency in cordova-windows, which 
depends on 'sax'. After running 'npm install' these dependencies installed as a 
siblings into 'node_modules', but after running 'npm pack' (in particular - 
'coho create-archive') the resultant .tgz contains ONLY 'elementtree' but not 
'sax'.

Related NPM issue is https://github.com/npm/npm/issues/8474

AFAIK, the only solution for now is to revert 'node_modules' structure back to 
tree form.

-
Best regards, Vladimir