[GitHub] [cordova] totalpave deleted a comment on the discussion: Problem on running apk downloading from whatsapp or google drive, says app not installed, adb and cordova run works, its just an hello
GitHub user totalpave deleted a comment on the discussion: Problem on running apk downloading from whatsapp or google drive, says app not installed, adb and cordova run works, its just an helloworld This is standard Android OS behaviour. By default, only a select few apps can install apps on the device, which is usually Google Play Store and generally the phone manufacturer's app store (e.g. Samsung Galaxy Store). Apps can also be installed to developer devices (phones with USB debugging enabled) via ADB, which is the channel that Cordova uses to install apps onto the device. This is something that needs to be explicitly enabled by the user. If you manually transfer the APK to your device, you must allow the source app that accepted the APK to install APKs on the device. This can be done by going to `Settings -> Security -> Install unknown apps`. On older android versions, install unknown apps is a simple target that was disabled by default, and enabling it will allow you to install APks from untrusted sources. Newer android versions will go into a subscreen where you enable access for specific apps to allow APKs to be installed from specific sources. E.g. if you download an APK from Google Drive, then you must enable `Allow from this source` on the Google Drive app to install APKs obtained from the Drive app. None of these methods is a recommended way of publishing your app if you can help it. Your end users must jump through a lot of security hoops to install your app this fashion. The play stores often have a certain standard that your app must uphere too, which indirectly gives users some sense of trust when they install your app through official play stores. GitHub link: https://github.com/apache/cordova/discussions/419#discussioncomment-6317711 This is an automatically sent email for dev@cordova.apache.org. To unsubscribe, please send an email to: dev-unsubscr...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Just saying hello and introducing myself
Welcome Mahendra, If you have any questions, let us know. Looking forward in seeing a PR! Cheers, Norman On 2023-01-23 9:55 a.m., Mahendra Liya wrote: Hello everyone, I thought of working on this <https://github.com/apache/cordova-android/issues/1450> issue and the Contribution Guideline suggested to join the Dev Mailing List and to introduce myself to the community, and so this email. I carry a cumulative experience of 12 years mostly in the mobile domain (both native & hybrid), but have fullstack skills as well. I've been working with PhoneGap (now Cordova) since its early beta (0.9x) but haven't ever contributed to it. In fact, this would be my first contribution to any major open source project! So, I'm excited as well :) Would start a new thread on adding the support for Themed Icons for Android, so that I can get inputs from the community. Cheers, Mahendra Liya - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Just saying hello and introducing myself
Hello everyone, I thought of working on this <https://github.com/apache/cordova-android/issues/1450> issue and the Contribution Guideline suggested to join the Dev Mailing List and to introduce myself to the community, and so this email. I carry a cumulative experience of 12 years mostly in the mobile domain (both native & hybrid), but have fullstack skills as well. I've been working with PhoneGap (now Cordova) since its early beta (0.9x) but haven't ever contributed to it. In fact, this would be my first contribution to any major open source project! So, I'm excited as well :) Would start a new thread on adding the support for Themed Icons for Android, so that I can get inputs from the community. Cheers, Mahendra Liya
[ANNOUNCEMENT] cordova-eslint@4.0.0 & cordova-app-hello-world@6.0.0 Release
We have just released an update to our eslint config & default template! - cordova-eslint@4.0.0 - cordova-app-hello-world@6.0.0 You can view the release blog post at https://cordova.apache.org/news/2021/10/31/template-release.html <https://cordova.apache.org/news/2021/10/31/template-release.html>
Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release
The vote has now closed. The results are: Positive Binding Votes: 3 * Bryan Ellis * Jesse MacFadyen * Niklas Merz Negative Binding Votes: 0 The vote has passed. Thanks everyone! > On Oct 29, 2021, at 3:33 PM, Niklas Merz wrote: > > I vote +1 > > I checked: > > - hash and signature > - tags > - no audit issues > - releasenotes > - local tests pass > - no license header issues > > On October 29, 2021, Jesse wrote: >> +1 >> >> - ran coho verify-archive >> - review of commits >> - CI green >> >> >> On Wed, Oct 27, 2021 at 4:55 AM Bryan Ellis wrote: >> >>> Please review and vote on the following packages for release by >> replying >>> to this email (and keep discussion on the DISCUSS thread): >>> >>> - cordova-eslint v4.0.0 >>> - cordova-app-hello-world v6.0.0 >>> >>> The archives has been published to the dist/dev: >>> >>> - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ < >>> https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> >>> - https://dist.apache.org/repos/dist/dev/cordova/app-hello-world- >> 6.0.0/ < >>> https://dist.apache.org/repos/dist/dev/cordova/app-hello-world- >> 6.0.0/> >>> >>> The packages was published from its corresponding git tag: >>> >>> cordova-eslint: 4.0.0 (d0f055c8f8) >>> cordova-app-hello-world: 6.0.0 (8430b5cfe9) >>> >>> Upon a successful vote I will upload the archive to dist/, publish >> it to >>> npm, and post the blog post. >>> >>> Voting guidelines: >>> https://github.com/apache/cordova-coho/blob/master/docs/release- >> voting.md >>> >>> Voting will go on for a minimum of 48 hours. >>> >>> I vote +1: >>> >>> * Ran coho audit-license-headers over the relevant repos >>> * Ran coho check-license to ensure all dependencies and sub- >> dependencies >>> have Apache-compatible licenses >>> * Ensured the continuous build was green when repo was tagged >>> * Ran `npm test` >>> * Ran `npm audit` >>> * Ran `cordova create` - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release
I vote +1 I checked: - hash and signature - tags - no audit issues - releasenotes - local tests pass - no license header issues On October 29, 2021, Jesse wrote: > +1 > > - ran coho verify-archive > - review of commits > - CI green > > > On Wed, Oct 27, 2021 at 4:55 AM Bryan Ellis wrote: > > > Please review and vote on the following packages for release by > replying > > to this email (and keep discussion on the DISCUSS thread): > > > > - cordova-eslint v4.0.0 > > - cordova-app-hello-world v6.0.0 > > > > The archives has been published to the dist/dev: > > > > - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ < > > https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> > > - https://dist.apache.org/repos/dist/dev/cordova/app-hello-world- > 6.0.0/ < > > https://dist.apache.org/repos/dist/dev/cordova/app-hello-world- > 6.0.0/> > > > > The packages was published from its corresponding git tag: > > > > cordova-eslint: 4.0.0 (d0f055c8f8) > > cordova-app-hello-world: 6.0.0 (8430b5cfe9) > > > > Upon a successful vote I will upload the archive to dist/, publish > it to > > npm, and post the blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release- > voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and sub- > dependencies > > have Apache-compatible licenses > > * Ensured the continuous build was green when repo was tagged > > * Ran `npm test` > > * Ran `npm audit` > > * Ran `cordova create`
Re: [VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release
+1 - ran coho verify-archive - review of commits - CI green On Wed, Oct 27, 2021 at 4:55 AM Bryan Ellis wrote: > Please review and vote on the following packages for release by replying > to this email (and keep discussion on the DISCUSS thread): > > - cordova-eslint v4.0.0 > - cordova-app-hello-world v6.0.0 > > The archives has been published to the dist/dev: > > - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ < > https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> > - https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-6.0.0/ < > https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-6.0.0/> > > The packages was published from its corresponding git tag: > > cordova-eslint: 4.0.0 (d0f055c8f8) > cordova-app-hello-world: 6.0.0 (8430b5cfe9) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and sub-dependencies > have Apache-compatible licenses > * Ensured the continuous build was green when repo was tagged > * Ran `npm test` > * Ran `npm audit` > * Ran `cordova create`
[VOTE] cordova-eslint 4.0.0 & cordova-app-hello-world 6.0.0 Major Release
Please review and vote on the following packages for release by replying to this email (and keep discussion on the DISCUSS thread): - cordova-eslint v4.0.0 - cordova-app-hello-world v6.0.0 The archives has been published to the dist/dev: - https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/ <https://dist.apache.org/repos/dist/dev/cordova/eslint-v4.0.0/> - https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-6.0.0/ <https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-6.0.0/> The packages was published from its corresponding git tag: cordova-eslint: 4.0.0 (d0f055c8f8) cordova-app-hello-world: 6.0.0 (8430b5cfe9) Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and sub-dependencies have Apache-compatible licenses * Ensured the continuous build was green when repo was tagged * Ran `npm test` * Ran `npm audit` * Ran `cordova create`
[DISCUSS] cordova-eslint 4.0.0 major & cordova-app-hello-world 6.0.0 major Release
Does anyone have any reason to delay a major release for the following packages? - cordova-eslint@4.0.0 - cordova-app-hello-world@6.0.0 Any additional outstanding changes to land? If not, I will proceed with the release by tomorrow. == Changes == - https://github.com/apache/cordova-eslint/compare/rel/3.0.0...master <https://github.com/apache/cordova-eslint/compare/rel/3.0.0...master> - https://github.com/apache/cordova-app-hello-world/compare/rel/5.0.0...master <https://github.com/apache/cordova-app-hello-world/compare/rel/5.0.0...master>
RE: Hello Cordova team
Hi everyone, @Brian: Thanks for the info, I'll upgrade it then. @Chris: I'll create the PR on cordova-plugin-wkwebview-engine today since it's the one I originally modified and tested, then I'll try to do the same with cordova-ios@6 once our project will be upgraded to use this version. Thank you Julien -Original Message- From: Bryan Ellis Sent: December 22, 2020 11:09 PM To: dev@cordova.apache.org Subject: Re: Hello Cordova team CAUTION: This email came from outside NexJ. Do not click links or open attachments unless you recognize the sender and know the contents are safe. Hi Julian, I read that your using Monaca and building with cordova-ios@5.1.1 and also said that it is "the most recent version they give us access to for the moment." Monaca has reported that Cordova CLI 10.x and Cordova-iOS 6.x support was implemented & released on November 19th. If you do not see Cordova-iOS 6.x as a platform option, then the project's Cordova CLI version is not up-to-date. First, upgrade the project's CLI version before you can select the new iOS version. > On Dec 23, 2020, at 2:13, Chris Brody wrote: > > Hi Julian I would recommend you consider announcing and sharing > whatever you have, in case it may help others or receive any contributions. > Thanks! > > > On Tue, Dec 22, 2020 at 11:28 AM Julien Lamure > > wrote: > >> Hi Mathias, >> >> With this feature, we don't need to do anything on the device to be >> able to access web resources hosted on a server that uses self-signed >> certificates. >> As I said in a previous message, making the device accept or not >> untrusted certificates is controlled by a preference in the >> config.xml file. Then, the corresponding Objective-C code controlled >> by the preference intercepts the HTTPS request right when iOS >> evaluates the certificate and dynamically adds an exception so that all >> certificates get accepted. >> We configure this preference at build time so that our development >> versions can accept the self-signed certificates used by our >> developers local VMs, and it's disabled for our production builds. >> It's basically working the same way as this Oracle plugin: >> https://github.com/oracle/cordova-plugin-wkwebview-file-xhr#configura >> tion However, when I tried to use the Oracle plugin for our app, I >> never managed to make it work properly, so I ended up adding the same >> mechanics to cordova-plugin-wkwebview-engine so that it could accept >> all certificates as well. >> >> Cheers, >> Julien >> >> -Original Message- >> From: Scheffe, Mathias >> Sent: December 22, 2020 1:47 AM >> To: dev@cordova.apache.org >> Subject: Re: Hello Cordova team >> >> CAUTION: This email came from outside NexJ. Do not click links or >> open attachments unless you recognize the sender and know the contents are >> safe. >> >> Hi, >> >> @Julien: Can you detail your feature a bit more? >> We are also using self-signed certificates for testing. We are >> working with the Cordova standard and install our self-signed >> certificate on the testing iOS devices as trusted root certificate. >> Then everything works out of the box. Which additional features does your >> extension bring? >> >> Kind regards, >> Mathias >> >> From: Julien Lamure >> Date: Saturday, 19. December 2020 at 00:21 >> To: dev@cordova.apache.org >> Subject: [External] RE: Hello Cordova team This message is from an >> EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments. >> >> Hi Norman, >> >> You're right, it would totally make sense to have this directly built >> in cordova-ios@6. >> I had to add this feature to cordova-plugin-wkwebview-engine because >> we're using Monaca to build our app and cordova-ios@5.1.1 is the most >> recent version they give us access to for the moment. >> And I totally agree that allowing self-signed certificates is a big >> no-go for release builds, our automated build processes make sure >> it's only available for developer builds (accepting or refusing >> self-signed certificates is controlled by a preference in the config.xml >> file). >> I'm going to see if I can figure out how to incorporate it into >> cordova-ios@6 then, but maybe I can still also create the pull >> request for cordova-plugin-wkwebview-engine so that other Monaca >> customers like us can use it while waiting for getting access to >> cordova-ios@6. >> >> Cheers, >> Julien >> >>
Re: Hello Cordova team
Hi Julian, I read that your using Monaca and building with cordova-ios@5.1.1 and also said that it is "the most recent version they give us access to for the moment." Monaca has reported that Cordova CLI 10.x and Cordova-iOS 6.x support was implemented & released on November 19th. If you do not see Cordova-iOS 6.x as a platform option, then the project's Cordova CLI version is not up-to-date. First, upgrade the project's CLI version before you can select the new iOS version. > On Dec 23, 2020, at 2:13, Chris Brody wrote: > > Hi Julian I would recommend you consider announcing and sharing > whatever you have, in case it may help others or receive any contributions. > Thanks! > > > On Tue, Dec 22, 2020 at 11:28 AM Julien Lamure > wrote: > >> Hi Mathias, >> >> With this feature, we don't need to do anything on the device to be able >> to access web resources hosted on a server that uses self-signed >> certificates. >> As I said in a previous message, making the device accept or not untrusted >> certificates is controlled by a preference in the config.xml file. Then, >> the corresponding Objective-C code controlled by the preference intercepts >> the HTTPS request right when iOS evaluates the certificate and dynamically >> adds an exception so that all certificates get accepted. >> We configure this preference at build time so that our development >> versions can accept the self-signed certificates used by our developers >> local VMs, and it's disabled for our production builds. >> It's basically working the same way as this Oracle plugin: >> https://github.com/oracle/cordova-plugin-wkwebview-file-xhr#configuration >> However, when I tried to use the Oracle plugin for our app, I never >> managed to make it work properly, so I ended up adding the same mechanics >> to cordova-plugin-wkwebview-engine so that it could accept all certificates >> as well. >> >> Cheers, >> Julien >> >> -Original Message- >> From: Scheffe, Mathias >> Sent: December 22, 2020 1:47 AM >> To: dev@cordova.apache.org >> Subject: Re: Hello Cordova team >> >> CAUTION: This email came from outside NexJ. Do not click links or open >> attachments unless you recognize the sender and know the contents are safe. >> >> Hi, >> >> @Julien: Can you detail your feature a bit more? >> We are also using self-signed certificates for testing. We are working >> with the Cordova standard and install our self-signed certificate on the >> testing iOS devices as trusted root certificate. Then everything works out >> of the box. Which additional features does your extension bring? >> >> Kind regards, >> Mathias >> >> From: Julien Lamure >> Date: Saturday, 19. December 2020 at 00:21 >> To: dev@cordova.apache.org >> Subject: [External] RE: Hello Cordova team This message is from an >> EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments. >> >> Hi Norman, >> >> You're right, it would totally make sense to have this directly built in >> cordova-ios@6. >> I had to add this feature to cordova-plugin-wkwebview-engine because we're >> using Monaca to build our app and cordova-ios@5.1.1 is the most recent >> version they give us access to for the moment. >> And I totally agree that allowing self-signed certificates is a big no-go >> for release builds, our automated build processes make sure it's only >> available for developer builds (accepting or refusing self-signed >> certificates is controlled by a preference in the config.xml file). >> I'm going to see if I can figure out how to incorporate it into >> cordova-ios@6 then, but maybe I can still also create the pull request >> for cordova-plugin-wkwebview-engine so that other Monaca customers like us >> can use it while waiting for getting access to cordova-ios@6. >> >> Cheers, >> Julien >> >> -Original Message- >> From: Norman Breau >> Sent: December 18, 2020 5:49 PM >> To: dev@cordova.apache.org >> Cc: dev@cordova.apache.org >> Subject: Re: Hello Cordova team >> >> CAUTION: This email came from outside NexJ. Do not click links or open >> attachments unless you recognize the sender and know the contents are safe. >> >> Hi Julien, >> >> Ability to accept self-signed certificates for development builds sounds >> like a neat enhancement and I personally would give my thumbs up for this >> kind of feature. I would be hesitant to allow self-signed certificates for >> r
Re: Hello Cordova team
Hi Julian I would recommend you consider announcing and sharing whatever you have, in case it may help others or receive any contributions. Thanks! On Tue, Dec 22, 2020 at 11:28 AM Julien Lamure wrote: > Hi Mathias, > > With this feature, we don't need to do anything on the device to be able > to access web resources hosted on a server that uses self-signed > certificates. > As I said in a previous message, making the device accept or not untrusted > certificates is controlled by a preference in the config.xml file. Then, > the corresponding Objective-C code controlled by the preference intercepts > the HTTPS request right when iOS evaluates the certificate and dynamically > adds an exception so that all certificates get accepted. > We configure this preference at build time so that our development > versions can accept the self-signed certificates used by our developers > local VMs, and it's disabled for our production builds. > It's basically working the same way as this Oracle plugin: > https://github.com/oracle/cordova-plugin-wkwebview-file-xhr#configuration > However, when I tried to use the Oracle plugin for our app, I never > managed to make it work properly, so I ended up adding the same mechanics > to cordova-plugin-wkwebview-engine so that it could accept all certificates > as well. > > Cheers, > Julien > > -Original Message- > From: Scheffe, Mathias > Sent: December 22, 2020 1:47 AM > To: dev@cordova.apache.org > Subject: Re: Hello Cordova team > > CAUTION: This email came from outside NexJ. Do not click links or open > attachments unless you recognize the sender and know the contents are safe. > > Hi, > > @Julien: Can you detail your feature a bit more? > We are also using self-signed certificates for testing. We are working > with the Cordova standard and install our self-signed certificate on the > testing iOS devices as trusted root certificate. Then everything works out > of the box. Which additional features does your extension bring? > > Kind regards, > Mathias > > From: Julien Lamure > Date: Saturday, 19. December 2020 at 00:21 > To: dev@cordova.apache.org > Subject: [External] RE: Hello Cordova team This message is from an > EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments. > > Hi Norman, > > You're right, it would totally make sense to have this directly built in > cordova-ios@6. > I had to add this feature to cordova-plugin-wkwebview-engine because we're > using Monaca to build our app and cordova-ios@5.1.1 is the most recent > version they give us access to for the moment. > And I totally agree that allowing self-signed certificates is a big no-go > for release builds, our automated build processes make sure it's only > available for developer builds (accepting or refusing self-signed > certificates is controlled by a preference in the config.xml file). > I'm going to see if I can figure out how to incorporate it into > cordova-ios@6 then, but maybe I can still also create the pull request > for cordova-plugin-wkwebview-engine so that other Monaca customers like us > can use it while waiting for getting access to cordova-ios@6. > > Cheers, > Julien > > -Original Message- > From: Norman Breau > Sent: December 18, 2020 5:49 PM > To: dev@cordova.apache.org > Cc: dev@cordova.apache.org > Subject: Re: Hello Cordova team > > CAUTION: This email came from outside NexJ. Do not click links or open > attachments unless you recognize the sender and know the contents are safe. > > Hi Julien, > > Ability to accept self-signed certificates for development builds sounds > like a neat enhancement and I personally would give my thumbs up for this > kind of feature. I would be hesitant to allow self-signed certificates for > release builds. I'm wondering if this could be adapted to either an > independent plugin or be incorporated into cordova-ios package. The > cordova-plugin-wkwebview-engine package while not officially declared > deprecated... will become obsolete soon given that it's only supported for > cordova-ios <= 5.x. It's pending a formal vote and I think one last release > for official deprecation. As of > cordova-ios@6 WKWebView is built into the core platform and UIWebView is > physically removed from the codebase. > > So if this could be adapted to support cordova-ios@6, I think that would > be better in the long term. > Kind regards, > Norman > On Dec 18 2020, at 6:21 pm, Julien Lamure > wrote: > > Hello everyone, > > > > I'm senior DevOps engineer and team lead at NexJ Health, greetings from > Toronto, Canada. > > We're a provider of cloud-based population he
RE: Hello Cordova team
Hi Mathias, With this feature, we don't need to do anything on the device to be able to access web resources hosted on a server that uses self-signed certificates. As I said in a previous message, making the device accept or not untrusted certificates is controlled by a preference in the config.xml file. Then, the corresponding Objective-C code controlled by the preference intercepts the HTTPS request right when iOS evaluates the certificate and dynamically adds an exception so that all certificates get accepted. We configure this preference at build time so that our development versions can accept the self-signed certificates used by our developers local VMs, and it's disabled for our production builds. It's basically working the same way as this Oracle plugin: https://github.com/oracle/cordova-plugin-wkwebview-file-xhr#configuration However, when I tried to use the Oracle plugin for our app, I never managed to make it work properly, so I ended up adding the same mechanics to cordova-plugin-wkwebview-engine so that it could accept all certificates as well. Cheers, Julien -Original Message- From: Scheffe, Mathias Sent: December 22, 2020 1:47 AM To: dev@cordova.apache.org Subject: Re: Hello Cordova team CAUTION: This email came from outside NexJ. Do not click links or open attachments unless you recognize the sender and know the contents are safe. Hi, @Julien: Can you detail your feature a bit more? We are also using self-signed certificates for testing. We are working with the Cordova standard and install our self-signed certificate on the testing iOS devices as trusted root certificate. Then everything works out of the box. Which additional features does your extension bring? Kind regards, Mathias From: Julien Lamure Date: Saturday, 19. December 2020 at 00:21 To: dev@cordova.apache.org Subject: [External] RE: Hello Cordova team This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments. Hi Norman, You're right, it would totally make sense to have this directly built in cordova-ios@6. I had to add this feature to cordova-plugin-wkwebview-engine because we're using Monaca to build our app and cordova-ios@5.1.1 is the most recent version they give us access to for the moment. And I totally agree that allowing self-signed certificates is a big no-go for release builds, our automated build processes make sure it's only available for developer builds (accepting or refusing self-signed certificates is controlled by a preference in the config.xml file). I'm going to see if I can figure out how to incorporate it into cordova-ios@6 then, but maybe I can still also create the pull request for cordova-plugin-wkwebview-engine so that other Monaca customers like us can use it while waiting for getting access to cordova-ios@6. Cheers, Julien -Original Message- From: Norman Breau Sent: December 18, 2020 5:49 PM To: dev@cordova.apache.org Cc: dev@cordova.apache.org Subject: Re: Hello Cordova team CAUTION: This email came from outside NexJ. Do not click links or open attachments unless you recognize the sender and know the contents are safe. Hi Julien, Ability to accept self-signed certificates for development builds sounds like a neat enhancement and I personally would give my thumbs up for this kind of feature. I would be hesitant to allow self-signed certificates for release builds. I'm wondering if this could be adapted to either an independent plugin or be incorporated into cordova-ios package. The cordova-plugin-wkwebview-engine package while not officially declared deprecated... will become obsolete soon given that it's only supported for cordova-ios <= 5.x. It's pending a formal vote and I think one last release for official deprecation. As of cordova-ios@6 WKWebView is built into the core platform and UIWebView is physically removed from the codebase. So if this could be adapted to support cordova-ios@6, I think that would be better in the long term. Kind regards, Norman On Dec 18 2020, at 6:21 pm, Julien Lamure wrote: > Hello everyone, > > I'm senior DevOps engineer and team lead at NexJ Health, greetings from > Toronto, Canada. > We're a provider of cloud-based population health management solutions and > our platform can also be accessed from a Cordova-based mobile app available > for Android and iOS. > I've been recently working on the migration to the WKWebView engine for iOS, > and I made a fork of cordova-plugin-wkwebview-engine that adds the ability to > accept self-signed certificates. > I'm not an iOS developer, it was the first time I was touching some > Objective-C code, but my patch is vastly inspired from what was done in > Oracle's cordova-plugin-wkwebview-file-xhr. > We needed this feature because our developers test our mobile app along with > a server insta
Re: Hello Cordova team
Hi, @Julien: Can you detail your feature a bit more? We are also using self-signed certificates for testing. We are working with the Cordova standard and install our self-signed certificate on the testing iOS devices as trusted root certificate. Then everything works out of the box. Which additional features does your extension bring? Kind regards, Mathias From: Julien Lamure Date: Saturday, 19. December 2020 at 00:21 To: dev@cordova.apache.org Subject: [External] RE: Hello Cordova team This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments. Hi Norman, You're right, it would totally make sense to have this directly built in cordova-ios@6. I had to add this feature to cordova-plugin-wkwebview-engine because we're using Monaca to build our app and cordova-ios@5.1.1 is the most recent version they give us access to for the moment. And I totally agree that allowing self-signed certificates is a big no-go for release builds, our automated build processes make sure it's only available for developer builds (accepting or refusing self-signed certificates is controlled by a preference in the config.xml file). I'm going to see if I can figure out how to incorporate it into cordova-ios@6 then, but maybe I can still also create the pull request for cordova-plugin-wkwebview-engine so that other Monaca customers like us can use it while waiting for getting access to cordova-ios@6. Cheers, Julien -Original Message- From: Norman Breau Sent: December 18, 2020 5:49 PM To: dev@cordova.apache.org Cc: dev@cordova.apache.org Subject: Re: Hello Cordova team CAUTION: This email came from outside NexJ. Do not click links or open attachments unless you recognize the sender and know the contents are safe. Hi Julien, Ability to accept self-signed certificates for development builds sounds like a neat enhancement and I personally would give my thumbs up for this kind of feature. I would be hesitant to allow self-signed certificates for release builds. I'm wondering if this could be adapted to either an independent plugin or be incorporated into cordova-ios package. The cordova-plugin-wkwebview-engine package while not officially declared deprecated... will become obsolete soon given that it's only supported for cordova-ios <= 5.x. It's pending a formal vote and I think one last release for official deprecation. As of cordova-ios@6 WKWebView is built into the core platform and UIWebView is physically removed from the codebase. So if this could be adapted to support cordova-ios@6, I think that would be better in the long term. Kind regards, Norman On Dec 18 2020, at 6:21 pm, Julien Lamure wrote: > Hello everyone, > > I'm senior DevOps engineer and team lead at NexJ Health, greetings from > Toronto, Canada. > We're a provider of cloud-based population health management solutions and > our platform can also be accessed from a Cordova-based mobile app available > for Android and iOS. > I've been recently working on the migration to the WKWebView engine for iOS, > and I made a fork of cordova-plugin-wkwebview-engine that adds the ability to > accept self-signed certificates. > I'm not an iOS developer, it was the first time I was touching some > Objective-C code, but my patch is vastly inspired from what was done in > Oracle's cordova-plugin-wkwebview-file-xhr. > We needed this feature because our developers test our mobile app along with > a server instance hosted on there workstation, and this local instance uses > self-signed certificates. > > I was thinking of creating a pull request on the official > cordova-plugin-wkwebview-engine to share this feature with the community > since I could see a lot of people asking how to do it, please let me know if > it's something that you would like me to do so. > Our fork is currently in one of our private repositories. > > Cheers > Julien > This message is for the designated recipient only and may contain privileged, proprietary, or otherwise confidential information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the e-mail by you is prohibited. Where allowed by local law, electronic communications with Accenture and its affiliates, including e-mail and instant messaging (including content), may be scanned by our systems for the purposes of information security and assessment of internal compliance with Accenture policy. Your privacy is important to us. Accenture uses your personal data only in compliance with data protection laws. For further information on how Accenture processes your personal data, please see our privacy statement at https://www.accenture.com/us-en/privacy-policy. __ www.accenture.com
RE: Hello Cordova team
Hi Norman, You're right, it would totally make sense to have this directly built in cordova-ios@6. I had to add this feature to cordova-plugin-wkwebview-engine because we're using Monaca to build our app and cordova-ios@5.1.1 is the most recent version they give us access to for the moment. And I totally agree that allowing self-signed certificates is a big no-go for release builds, our automated build processes make sure it's only available for developer builds (accepting or refusing self-signed certificates is controlled by a preference in the config.xml file). I'm going to see if I can figure out how to incorporate it into cordova-ios@6 then, but maybe I can still also create the pull request for cordova-plugin-wkwebview-engine so that other Monaca customers like us can use it while waiting for getting access to cordova-ios@6. Cheers, Julien -Original Message- From: Norman Breau Sent: December 18, 2020 5:49 PM To: dev@cordova.apache.org Cc: dev@cordova.apache.org Subject: Re: Hello Cordova team CAUTION: This email came from outside NexJ. Do not click links or open attachments unless you recognize the sender and know the contents are safe. Hi Julien, Ability to accept self-signed certificates for development builds sounds like a neat enhancement and I personally would give my thumbs up for this kind of feature. I would be hesitant to allow self-signed certificates for release builds. I'm wondering if this could be adapted to either an independent plugin or be incorporated into cordova-ios package. The cordova-plugin-wkwebview-engine package while not officially declared deprecated... will become obsolete soon given that it's only supported for cordova-ios <= 5.x. It's pending a formal vote and I think one last release for official deprecation. As of cordova-ios@6 WKWebView is built into the core platform and UIWebView is physically removed from the codebase. So if this could be adapted to support cordova-ios@6, I think that would be better in the long term. Kind regards, Norman On Dec 18 2020, at 6:21 pm, Julien Lamure wrote: > Hello everyone, > > I'm senior DevOps engineer and team lead at NexJ Health, greetings from > Toronto, Canada. > We're a provider of cloud-based population health management solutions and > our platform can also be accessed from a Cordova-based mobile app available > for Android and iOS. > I've been recently working on the migration to the WKWebView engine for iOS, > and I made a fork of cordova-plugin-wkwebview-engine that adds the ability to > accept self-signed certificates. > I'm not an iOS developer, it was the first time I was touching some > Objective-C code, but my patch is vastly inspired from what was done in > Oracle's cordova-plugin-wkwebview-file-xhr. > We needed this feature because our developers test our mobile app along with > a server instance hosted on there workstation, and this local instance uses > self-signed certificates. > > I was thinking of creating a pull request on the official > cordova-plugin-wkwebview-engine to share this feature with the community > since I could see a lot of people asking how to do it, please let me know if > it's something that you would like me to do so. > Our fork is currently in one of our private repositories. > > Cheers > Julien >
Re: Hello Cordova team
Hi Julien, Ability to accept self-signed certificates for development builds sounds like a neat enhancement and I personally would give my thumbs up for this kind of feature. I would be hesitant to allow self-signed certificates for release builds. I'm wondering if this could be adapted to either an independent plugin or be incorporated into cordova-ios package. The cordova-plugin-wkwebview-engine package while not officially declared deprecated... will become obsolete soon given that it's only supported for cordova-ios <= 5.x. It's pending a formal vote and I think one last release for official deprecation. As of cordova-ios@6 WKWebView is built into the core platform and UIWebView is physically removed from the codebase. So if this could be adapted to support cordova-ios@6, I think that would be better in the long term. Kind regards, Norman On Dec 18 2020, at 6:21 pm, Julien Lamure wrote: > Hello everyone, > > I'm senior DevOps engineer and team lead at NexJ Health, greetings from > Toronto, Canada. > We're a provider of cloud-based population health management solutions and > our platform can also be accessed from a Cordova-based mobile app available > for Android and iOS. > I've been recently working on the migration to the WKWebView engine for iOS, > and I made a fork of cordova-plugin-wkwebview-engine that adds the ability to > accept self-signed certificates. > I'm not an iOS developer, it was the first time I was touching some > Objective-C code, but my patch is vastly inspired from what was done in > Oracle's cordova-plugin-wkwebview-file-xhr. > We needed this feature because our developers test our mobile app along with > a server instance hosted on there workstation, and this local instance uses > self-signed certificates. > > I was thinking of creating a pull request on the official > cordova-plugin-wkwebview-engine to share this feature with the community > since I could see a lot of people asking how to do it, please let me know if > it's something that you would like me to do so. > Our fork is currently in one of our private repositories. > > Cheers > Julien >
Hello Cordova team
Hello everyone, I'm senior DevOps engineer and team lead at NexJ Health, greetings from Toronto, Canada. We're a provider of cloud-based population health management solutions and our platform can also be accessed from a Cordova-based mobile app available for Android and iOS. I've been recently working on the migration to the WKWebView engine for iOS, and I made a fork of cordova-plugin-wkwebview-engine that adds the ability to accept self-signed certificates. I'm not an iOS developer, it was the first time I was touching some Objective-C code, but my patch is vastly inspired from what was done in Oracle's cordova-plugin-wkwebview-file-xhr. We needed this feature because our developers test our mobile app along with a server instance hosted on there workstation, and this local instance uses self-signed certificates. I was thinking of creating a pull request on the official cordova-plugin-wkwebview-engine to share this feature with the community since I could see a lot of people asking how to do it, please let me know if it's something that you would like me to do so. Our fork is currently in one of our private repositories. Cheers Julien
Re: [VOTE] cordova-app-hello-world 5.0.0 Release
The vote has now closed. The results are: Positive Binding Votes: 3 * Bryan Ellis * Jesse MacFadyen * Tim Brust Negative Binding Votes: 0 The vote has passed. Thanks everyone! On Thu, Apr 9, 2020 at 5:53 PM Tim Brust wrote: > I vote +1: > ✅ coho verify-archive > ✅ Changes make sense > ✅ NOTICE and LICENSE file are present > > On Wed, Apr 8, 2020 at 2:29 AM Bryan Ellis wrote: > > > Please review and vote on this cordova-app-hello-world Major Release > v5.0.0 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-5.0.0 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 5.0.0 (70084d1bab) > > > > Upon a successful vote I will upload the archive to dist/, publish it to > > npm, and post the blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos (gitignore is > > excluded) > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses (No Dependencies) > > * NPM Audit (No Package) > > * NPM Test (No Tests) > > * Built locally a CLI which has cordova-create tied with > > cordova-app-hello-world@5.0.0. > > * Created a new cordova project > > * Tested a platform add, build, and run with Android > > > > > -- > Tim Brust, Product Engineer > > tim.br...@sinnerschrader.com > T +49 40 398855 315 > > SinnerSchrader Deutschland GmbH | SinnerSchrader Group > Völckersstraße 38, 22765 Hamburg, Germany > > Amtsgericht Hamburg HRB-Nr. 63663 > Geschäftsführer: Matthias Schrader (Sprecher), > Jürgen Alker, Dr. Axel Averdung, Holger Blank, > Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson > > Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag > > https://www.sinnerschrader.com | NEXT AGENCY >
Re: [VOTE] cordova-app-hello-world 5.0.0 Release
I vote +1: ✅ coho verify-archive ✅ Changes make sense ✅ NOTICE and LICENSE file are present On Wed, Apr 8, 2020 at 2:29 AM Bryan Ellis wrote: > Please review and vote on this cordova-app-hello-world Major Release v5.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-5.0.0 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 5.0.0 (70084d1bab) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos (gitignore is > excluded) > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses (No Dependencies) > * NPM Audit (No Package) > * NPM Test (No Tests) > * Built locally a CLI which has cordova-create tied with > cordova-app-hello-world@5.0.0. > * Created a new cordova project > * Tested a platform add, build, and run with Android > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] cordova-app-hello-world 5.0.0 Release
+1 - coho verify-archive - reviewed code On Tue, Apr 7, 2020 at 7:28 PM Bryan Ellis wrote: > Please review and vote on this cordova-app-hello-world Major Release v5.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-5.0.0 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 5.0.0 (70084d1bab) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos (gitignore is > excluded) > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses (No Dependencies) > * NPM Audit (No Package) > * NPM Test (No Tests) > * Built locally a CLI which has cordova-create tied with > cordova-app-hello-world@5.0.0. > * Created a new cordova project > * Tested a platform add, build, and run with Android >
[VOTE] cordova-app-hello-world 5.0.0 Release
Please review and vote on this cordova-app-hello-world Major Release v5.0.0 by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/app-hello-world-5.0.0 The package was published from its corresponding git tag: cordova-app-hello-world: 5.0.0 (70084d1bab) Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos (gitignore is excluded) * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses (No Dependencies) * NPM Audit (No Package) * NPM Test (No Tests) * Built locally a CLI which has cordova-create tied with cordova-app-hello-world@5.0.0. * Created a new cordova project * Tested a platform add, build, and run with Android
[DISCUSS] cordova-app-hello-world 5.0.0 Major Release
Does anyone have any reason to delay a cordova-app-hello-world major release (5.0.0)? Any additional outstanding changes to land? If not, I will start the release process tomorrow.
Re: Hello
Nice to meet you too Fil and thank you for the information :) . Look forward to help :). On 20 June 2017 at 17:33, Filip Maj wrote: > Welcome Georgios! > > Nice to e-meet you, I'm Fil. > > Thanks for reaching out about where and how to contribute - we really > appreciate it. > > The easyfix stuff Julio pointed to is a great place to start and get > your bearings on how the issue tracker works, and hopefully you can > start there to figure out how to send good pull requests and get > reviews on any changes you want to make. > > Recently, the chair of Cordova' Project Management Committee (PMC), > Shazron, sent a report about the health of this project to the Apache > Board [1]. If you're curious what issues are top-of-mind for > committers to this project, that's a quick read to get up to speed. > > Longer-term, the area where Cordova committers have the most trouble > keeping up is with the mountain of pull requests issued to all the > cordova-plugin-* repositories, as well as the most popular platform > repositories (cordova-ios, cordova-android, cordova-windows and > cordova-browser). If I had a personal choice in a direction to steer > your contributions, it would be reviewing and testing these pull > requests. However, I understand that's a tall task and is a lot to ask > for :) > > Anyways, if you have any questions at all, feel free to reply back > here. We also hang out on Slack for informal chats [2], if that's your > cup of tea - I'm filmaj on there. > > Once again, welcome, and hope to see your contributions soon :) > > Best, > Fil Maj > > [1] https://github.com/cordova/apache-board-reports/blob/ > master/2017/2017-06.md > [2] slack.cordova.io > > On Tue, Jun 20, 2017 at 6:47 AM, Georgios Galatoulas > wrote: > > Thank you Julio, > > > > Will do ! > > > > On 20 June 2017 at 12:46, julio cesar sanchez > > wrote: > > > >> Welcome Georgios, > >> > >> If you want to contribute with bug fixing, here you have the list of > >> "easyfix" issues http://easyfix.cordova.io. or all the issues > >> http://issues.cordova.io. > >> If you find issues you can also report them there, reporting issues is > also > >> contributing. > >> > >> Feel free to join the Cordova Slack http://slack.cordova.io/ > >> > >> > >> 2017-06-20 13:30 GMT+02:00 Georgios Galatoulas < > >> georgiosgalatou...@gmail.com > >> >: > >> > >> > Hello guys, > >> > > >> > I am Georgios, and I work as Mobile Developer at Masabi. I am Mobile > Dev > >> > for a while but I am totally new in open source projects. > >> > I am currently working on our hybrid app which uses Cordova. > >> > > >> > I hope I can contribute whenever possible and looking forward to speak > >> with > >> > you guys. > >> > > >> > I hope this is enough for my intro. Please let me know if I miss > >> anything I > >> > need to mention. > >> > > >> > -- > >> > Georgios J. Galatoulas > >> > > >> > > > > > > > > -- > > Georgios J. Galatoulas > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Georgios J. Galatoulas
Re: Hello
Welcome Georgios! Nice to e-meet you, I'm Fil. Thanks for reaching out about where and how to contribute - we really appreciate it. The easyfix stuff Julio pointed to is a great place to start and get your bearings on how the issue tracker works, and hopefully you can start there to figure out how to send good pull requests and get reviews on any changes you want to make. Recently, the chair of Cordova' Project Management Committee (PMC), Shazron, sent a report about the health of this project to the Apache Board [1]. If you're curious what issues are top-of-mind for committers to this project, that's a quick read to get up to speed. Longer-term, the area where Cordova committers have the most trouble keeping up is with the mountain of pull requests issued to all the cordova-plugin-* repositories, as well as the most popular platform repositories (cordova-ios, cordova-android, cordova-windows and cordova-browser). If I had a personal choice in a direction to steer your contributions, it would be reviewing and testing these pull requests. However, I understand that's a tall task and is a lot to ask for :) Anyways, if you have any questions at all, feel free to reply back here. We also hang out on Slack for informal chats [2], if that's your cup of tea - I'm filmaj on there. Once again, welcome, and hope to see your contributions soon :) Best, Fil Maj [1] https://github.com/cordova/apache-board-reports/blob/master/2017/2017-06.md [2] slack.cordova.io On Tue, Jun 20, 2017 at 6:47 AM, Georgios Galatoulas wrote: > Thank you Julio, > > Will do ! > > On 20 June 2017 at 12:46, julio cesar sanchez > wrote: > >> Welcome Georgios, >> >> If you want to contribute with bug fixing, here you have the list of >> "easyfix" issues http://easyfix.cordova.io. or all the issues >> http://issues.cordova.io. >> If you find issues you can also report them there, reporting issues is also >> contributing. >> >> Feel free to join the Cordova Slack http://slack.cordova.io/ >> >> >> 2017-06-20 13:30 GMT+02:00 Georgios Galatoulas < >> georgiosgalatou...@gmail.com >> >: >> >> > Hello guys, >> > >> > I am Georgios, and I work as Mobile Developer at Masabi. I am Mobile Dev >> > for a while but I am totally new in open source projects. >> > I am currently working on our hybrid app which uses Cordova. >> > >> > I hope I can contribute whenever possible and looking forward to speak >> with >> > you guys. >> > >> > I hope this is enough for my intro. Please let me know if I miss >> anything I >> > need to mention. >> > >> > -- >> > Georgios J. Galatoulas >> > >> > > > > -- > Georgios J. Galatoulas - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hello
Thank you Julio, Will do ! On 20 June 2017 at 12:46, julio cesar sanchez wrote: > Welcome Georgios, > > If you want to contribute with bug fixing, here you have the list of > "easyfix" issues http://easyfix.cordova.io. or all the issues > http://issues.cordova.io. > If you find issues you can also report them there, reporting issues is also > contributing. > > Feel free to join the Cordova Slack http://slack.cordova.io/ > > > 2017-06-20 13:30 GMT+02:00 Georgios Galatoulas < > georgiosgalatou...@gmail.com > >: > > > Hello guys, > > > > I am Georgios, and I work as Mobile Developer at Masabi. I am Mobile Dev > > for a while but I am totally new in open source projects. > > I am currently working on our hybrid app which uses Cordova. > > > > I hope I can contribute whenever possible and looking forward to speak > with > > you guys. > > > > I hope this is enough for my intro. Please let me know if I miss > anything I > > need to mention. > > > > -- > > Georgios J. Galatoulas > > > -- Georgios J. Galatoulas
Re: Hello
Welcome Georgios, If you want to contribute with bug fixing, here you have the list of "easyfix" issues http://easyfix.cordova.io. or all the issues http://issues.cordova.io. If you find issues you can also report them there, reporting issues is also contributing. Feel free to join the Cordova Slack http://slack.cordova.io/ 2017-06-20 13:30 GMT+02:00 Georgios Galatoulas : > Hello guys, > > I am Georgios, and I work as Mobile Developer at Masabi. I am Mobile Dev > for a while but I am totally new in open source projects. > I am currently working on our hybrid app which uses Cordova. > > I hope I can contribute whenever possible and looking forward to speak with > you guys. > > I hope this is enough for my intro. Please let me know if I miss anything I > need to mention. > > -- > Georgios J. Galatoulas >
Hello
Hello guys, I am Georgios, and I work as Mobile Developer at Masabi. I am Mobile Dev for a while but I am totally new in open source projects. I am currently working on our hybrid app which uses Cordova. I hope I can contribute whenever possible and looking forward to speak with you guys. I hope this is enough for my intro. Please let me know if I miss anything I need to mention. -- Georgios J. Galatoulas
[GitHub] cordova-app-hello-world pull request #19: CB-12397 fix .gitignore for plugin...
GitHub user brodybits opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/19
CB-12397 fix .gitignore for plugins & platforms
### Platforms affected
All
### What does this PR do?
Add `plugins` and `platforms` to `.gitignore` to resolve [Apache Cordova
CB-12397](https://issues.apache.org/jira/browse/CB-12397), now working if
properly integrated with apache/cordova-create#8 (workaround solution to
[Apache Cordova CB-12397](https://issues.apache.org/jira/browse/CB-12397) in
`cordova-create`).
### What testing has been done on this change?
As described in <https://github.com/apache/cordova-create/pull/8>: tested
using local installation of
<https://github.com/brodybits/cordova-cli/tree/cb-12397-devtest1>.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
**NOT RELEVANT in this PR:**
- ~~Added automated test coverage as appropriate for this change.~~
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brodybits/cordova-app-hello-world cb-12397
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-app-hello-world/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
commit f7c85137256e050856e8fe9341ed3b2ba0c319f1
Author: Christopher J. Brody
Date: 2017-05-09T13:11:49Z
CB-12397 fix .gitignore for plugins & platforms
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-app-hello-world/pull/18#discussion_r113055741
--- Diff: template_src/package.json ---
@@ -0,0 +1,11 @@
+{
+ "name": "hellocordova",
--- End diff --
actually, can we change the name to `io.cordova.hellocordova` and add a new
field called `displayName` that equals `HelloCordova`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #18: CB-12684 : added package.json to d...
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/18 CB-12684 : added package.json to default hello world app ### Platforms affected ### What does this PR do? Added package.json to default hello world app. ### What testing has been done on this change? ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [X] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-app-hello-world CB-12684 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit c61f6a54efe754d5e4177131aa388d4027b5d419 Author: Audrey So Date: 2017-04-21T23:20:51Z CB-12684 : added package.json to default hello world app --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hello again!
Thanks for the clarification Alexander! I think I got confused between the PR and periodic builds. I see in the periodic builds, indeed the job is cloning down the relevant platform and using the latest HEAD from master. In the PR builds, the logs are sparser and don't explicitly log out versions of dependent libraries consumed, so I will assume you are right! I have one more question: how does everyone feel about cordova-qa's GitHub comments with test results (passing example: [1], failing example: [2])? What about integrating these kinds of checks into the GitHub UI for per-commit checks (this is the green checkmark you'll see in GH UI)? I'm probably missing a reason why it is integrated in this way, so forgive me if it's a naive question :) It looks like Travis test runs are integrated using the GitHub pass/fail integrations / UI. I'm wondering why not the Jenkins tests? I believe we can set up the integration such that each discrete check (i.e. a specific plugin/platform combination) can set up as a separate check, posting a separate result. Might be less confusing / less "made in house" than a custom QA bot? Just a thought. Currently, the 'fail' comment from cordova-qa requires contributors to click through all the various links to figure out which particular platform errored out. By splitting the checks out, it would make that more apparent more immediately. I think the UI as viewed from GitHub would be cleaner: from the pull req list it would be instantly visible which PRs are passing and which are failing, and the merge instructions could be simplified to "if the green check mark shows up, merge away", instead of right now needing to wait for both the green checkmark representing Travis + cordova-qa bot comment. It's a UI nitpick but I think it might improve the contribution experience. Feel free to shoot me down or direct me to more pressing issues :D [1] https://github.com/apache/cordova-plugin-device/pull/58#issuecomment-263793786 [2] https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-263013516 On Tue, Nov 29, 2016 at 12:28 AM, wrote: > Hi again Filip, you are most welcome! > >>> - cordova-paramedic configs are pulled from cordova-medic repo. >>> (?) requires an extra pull in CI. > Yeah. This is kind of rudimentary thing, I think we can safely transfer them > to cordova-paramedic repo. This will require some Jenkins jobs changes, I can > assist with that. > >> > - paramedic setup for individual plugins install latest HEAD of >> > master of platform code (at least, cordova-android + device plugin) > What makes you think so? I double-checked, our current CI setup for per-PR > jobs is using the released versions of all the platforms. Master versions are > used only for periodic build. > >> > - there are plugins tests that run via a jenkins instance on >> > cloudapp.net, and there are travis tests too. travis is pull-req >> > triggered, cloud app runs nightly. why? > Regarding cloudapp (Jenkins) builds: > The goal of nightly tests is to verify the master versions of plugins against > the master versions of platforms and CLI. We also run per-PR jobs against the > released versions of platform and CLI, you can find them here: > http://cordova-ci.cloudapp.net:8080/view/Pull%20requests/ > > Feel free to contact me via email or Slack if you have any questions > regarding our current CI setup or need an assistance. > > Thanks, > Alexander Sorokin > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Monday, November 28, 2016 11:00 PM > To: dev@cordova.apache.org > Subject: Re: Hello again! > > Welcome back! > > > @purplecabbage > risingj.com > > On Mon, Nov 28, 2016 at 11:50 AM, Simon MacDonald > wrote: > >> Never heard of this guy. >> Simon Mac Donald >> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsimonm >> acdonald.com&data=02%7C01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff >> 9353408d417c92e87%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6361596 >> 00215033744&sdata=zPpzT0F5p5rlW71wFWe0DtB2cG8rednMPQyiqtUw%2BZg%3D&res >> erved=0 >> >> >> On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj wrote: >> > Hi everyone! >> > >> > Just wanted to (re)introduce myself after a 3 year or so hiatus :) >> > >> > I used to be an active member of the group between 2011 and 2013 >> > when I was on the Adobe PhoneGap team. I took a 3 year detour >> > focusing on mobile testing infrastructure at Sauce Labs, but >> > recently rejoined the Adobe PhoneGap team. I have been lurking more >> > intently on this list for the past month or so and aim to be mor
Re: Hello again!
Welcome back Fil! On Tue, Nov 29, 2016 at 12:28 AM wrote: > Hi again Filip, you are most welcome! > > >> - cordova-paramedic configs are pulled from cordova-medic repo. > >> (?) requires an extra pull in CI. > Yeah. This is kind of rudimentary thing, I think we can safely transfer > them to cordova-paramedic repo. This will require some Jenkins jobs > changes, I can assist with that. > > > > - paramedic setup for individual plugins install latest HEAD of > > > master of platform code (at least, cordova-android + device plugin) > What makes you think so? I double-checked, our current CI setup for per-PR > jobs is using the released versions of all the platforms. Master versions > are used only for periodic build. > > > > - there are plugins tests that run via a jenkins instance on > > > cloudapp.net, and there are travis tests too. travis is pull-req > > > triggered, cloud app runs nightly. why? > Regarding cloudapp (Jenkins) builds: > The goal of nightly tests is to verify the master versions of plugins > against the master versions of platforms and CLI. We also run per-PR jobs > against the released versions of platform and CLI, you can find them here: > http://cordova-ci.cloudapp.net:8080/view/Pull%20requests/ > > Feel free to contact me via email or Slack if you have any questions > regarding our current CI setup or need an assistance. > > Thanks, > Alexander Sorokin > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Monday, November 28, 2016 11:00 PM > To: dev@cordova.apache.org > Subject: Re: Hello again! > > Welcome back! > > > @purplecabbage > risingj.com > > On Mon, Nov 28, 2016 at 11:50 AM, Simon MacDonald < > simon.macdon...@gmail.com > > wrote: > > > Never heard of this guy. > > Simon Mac Donald > > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsimonm > > acdonald.com&data=02%7C01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff > > 9353408d417c92e87%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6361596 > > 00215033744&sdata=zPpzT0F5p5rlW71wFWe0DtB2cG8rednMPQyiqtUw%2BZg%3D&res > > erved=0 > > > > > > On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj wrote: > > > Hi everyone! > > > > > > Just wanted to (re)introduce myself after a 3 year or so hiatus :) > > > > > > I used to be an active member of the group between 2011 and 2013 > > > when I was on the Adobe PhoneGap team. I took a 3 year detour > > > focusing on mobile testing infrastructure at Sauce Labs, but > > > recently rejoined the Adobe PhoneGap team. I have been lurking more > > > intently on this list for the past month or so and aim to be more > involved these days. > > > > > > I've been poking around and getting my bearings around the testing > > > suites, infrastructure and CI in Cordova the past week or so. I > > > think I will try to contribute in that area initially. In > > > particular, I am interested in enabling functional end-to-end > > > testing for all repos in cordova that could benefit from that sort > > > of testing, and seamlessly integrating running the tests and > > > reporting their results back into the standard Cordova dev workflow > > > (I assume that is focussed around GitHub?). I see there are > > > different kinds of test coverage and CI systems at play (cloudapp, > > > travis, appveyor, plus unit and functional tests), so initially just > wrapping my head around all that. > > > > > > If anyone here has suggestions on areas that need work, have > > > grievances around how they are frustrated by manually needing to > > > test something, or having any other helpful tips on what needs work > > > or what could be improved, feel free to reply to this thread! > > > > > > My generic notes on this topic so far, in case that is helpful: > > > > > > cordova testing overview > > > ——— > > > notes / weird things: > > > - cordova-paramedic configs are pulled from cordova-medic repo. (?) > > > requires an extra pull in CI. > > > - paramedic setup for individual plugins install latest HEAD of > > > master of platform code (at least, cordova-android + device plugin) > > > - there are plugins tests that run via a jenkins instance on > > > cloudapp.net, and there are travis tests too. travis is pull-req > > > triggered, cloud app runs nightly. why? > > > > > > road to testing utopia: > > > - how do platforms get tested? integration tests with
RE: Hello again!
Hi again Filip, you are most welcome! >> - cordova-paramedic configs are pulled from cordova-medic repo. >> (?) requires an extra pull in CI. Yeah. This is kind of rudimentary thing, I think we can safely transfer them to cordova-paramedic repo. This will require some Jenkins jobs changes, I can assist with that. > > - paramedic setup for individual plugins install latest HEAD of > > master of platform code (at least, cordova-android + device plugin) What makes you think so? I double-checked, our current CI setup for per-PR jobs is using the released versions of all the platforms. Master versions are used only for periodic build. > > - there are plugins tests that run via a jenkins instance on > > cloudapp.net, and there are travis tests too. travis is pull-req > > triggered, cloud app runs nightly. why? Regarding cloudapp (Jenkins) builds: The goal of nightly tests is to verify the master versions of plugins against the master versions of platforms and CLI. We also run per-PR jobs against the released versions of platform and CLI, you can find them here: http://cordova-ci.cloudapp.net:8080/view/Pull%20requests/ Feel free to contact me via email or Slack if you have any questions regarding our current CI setup or need an assistance. Thanks, Alexander Sorokin -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Monday, November 28, 2016 11:00 PM To: dev@cordova.apache.org Subject: Re: Hello again! Welcome back! @purplecabbage risingj.com On Mon, Nov 28, 2016 at 11:50 AM, Simon MacDonald wrote: > Never heard of this guy. > Simon Mac Donald > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fsimonm > acdonald.com&data=02%7C01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff > 9353408d417c92e87%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6361596 > 00215033744&sdata=zPpzT0F5p5rlW71wFWe0DtB2cG8rednMPQyiqtUw%2BZg%3D&res > erved=0 > > > On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj wrote: > > Hi everyone! > > > > Just wanted to (re)introduce myself after a 3 year or so hiatus :) > > > > I used to be an active member of the group between 2011 and 2013 > > when I was on the Adobe PhoneGap team. I took a 3 year detour > > focusing on mobile testing infrastructure at Sauce Labs, but > > recently rejoined the Adobe PhoneGap team. I have been lurking more > > intently on this list for the past month or so and aim to be more involved > > these days. > > > > I've been poking around and getting my bearings around the testing > > suites, infrastructure and CI in Cordova the past week or so. I > > think I will try to contribute in that area initially. In > > particular, I am interested in enabling functional end-to-end > > testing for all repos in cordova that could benefit from that sort > > of testing, and seamlessly integrating running the tests and > > reporting their results back into the standard Cordova dev workflow > > (I assume that is focussed around GitHub?). I see there are > > different kinds of test coverage and CI systems at play (cloudapp, > > travis, appveyor, plus unit and functional tests), so initially just > > wrapping my head around all that. > > > > If anyone here has suggestions on areas that need work, have > > grievances around how they are frustrated by manually needing to > > test something, or having any other helpful tips on what needs work > > or what could be improved, feel free to reply to this thread! > > > > My generic notes on this topic so far, in case that is helpful: > > > > cordova testing overview > > ——— > > notes / weird things: > > - cordova-paramedic configs are pulled from cordova-medic repo. (?) > > requires an extra pull in CI. > > - paramedic setup for individual plugins install latest HEAD of > > master of platform code (at least, cordova-android + device plugin) > > - there are plugins tests that run via a jenkins instance on > > cloudapp.net, and there are travis tests too. travis is pull-req > > triggered, cloud app runs nightly. why? > > > > road to testing utopia: > > - how do platforms get tested? integration tests with what: tooling? > plugins? > >- unit tests run on travis/appveyor? > >- understand what needs to be tested for a release. work > > backwards to automate that from there. Steve sent some helpful links my way: > > - platform: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit > > hub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2F&data=02%7C > > 01%7Cv-alsoro%40microsoft.com%7Cdcdee276682a4ff9353408d417c92e87%7C7 > > 2f988bf
Re: Hello again!
Welcome back! @purplecabbage risingj.com On Mon, Nov 28, 2016 at 11:50 AM, Simon MacDonald wrote: > Never heard of this guy. > Simon Mac Donald > http://simonmacdonald.com > > > On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj wrote: > > Hi everyone! > > > > Just wanted to (re)introduce myself after a 3 year or so hiatus :) > > > > I used to be an active member of the group between 2011 and 2013 when > > I was on the Adobe PhoneGap team. I took a 3 year detour focusing on > > mobile testing infrastructure at Sauce Labs, but recently rejoined the > > Adobe PhoneGap team. I have been lurking more intently on this list > > for the past month or so and aim to be more involved these days. > > > > I've been poking around and getting my bearings around the testing > > suites, infrastructure and CI in Cordova the past week or so. I think > > I will try to contribute in that area initially. In particular, I am > > interested in enabling functional end-to-end testing for all repos in > > cordova that could benefit from that sort of testing, and seamlessly > > integrating running the tests and reporting their results back into > > the standard Cordova dev workflow (I assume that is focussed around > > GitHub?). I see there are different kinds of test coverage and CI > > systems at play (cloudapp, travis, appveyor, plus unit and functional > > tests), so initially just wrapping my head around all that. > > > > If anyone here has suggestions on areas that need work, have > > grievances around how they are frustrated by manually needing to test > > something, or having any other helpful tips on what needs work or what > > could be improved, feel free to reply to this thread! > > > > My generic notes on this topic so far, in case that is helpful: > > > > cordova testing overview > > ——— > > notes / weird things: > > - cordova-paramedic configs are pulled from cordova-medic repo. (?) > > requires an extra pull in CI. > > - paramedic setup for individual plugins install latest HEAD of > > master of platform code (at least, cordova-android + device plugin) > > - there are plugins tests that run via a jenkins instance on > > cloudapp.net, and there are travis tests too. travis is pull-req > > triggered, cloud app runs nightly. why? > > > > road to testing utopia: > > - how do platforms get tested? integration tests with what: tooling? > plugins? > >- unit tests run on travis/appveyor? > >- understand what needs to be tested for a release. work backwards > > to automate that from there. Steve sent some helpful links my way: > > - platform: > > https://github.com/apache/cordova-coho/blob/master/docs/ > platforms-release-process.md#testing > > - plugins: > > https://github.com/apache/cordova-coho/blob/master/docs/ > plugins-release-process.md#test > > - tools: https://github.com/apache/cordova-coho/blob/master/docs/ > tools-release-process.md#test > > - how do plugins get tested? > >- make sure dependencies / artifact versions are locked down. > >- what is the difference between "local" vs appium tests > > > > Looking forward to collaborating with y'all in here once more :) > > > > Cheers, > > Fil > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: Hello again!
Never heard of this guy. Simon Mac Donald http://simonmacdonald.com On Mon, Nov 28, 2016 at 2:48 PM, Filip Maj wrote: > Hi everyone! > > Just wanted to (re)introduce myself after a 3 year or so hiatus :) > > I used to be an active member of the group between 2011 and 2013 when > I was on the Adobe PhoneGap team. I took a 3 year detour focusing on > mobile testing infrastructure at Sauce Labs, but recently rejoined the > Adobe PhoneGap team. I have been lurking more intently on this list > for the past month or so and aim to be more involved these days. > > I've been poking around and getting my bearings around the testing > suites, infrastructure and CI in Cordova the past week or so. I think > I will try to contribute in that area initially. In particular, I am > interested in enabling functional end-to-end testing for all repos in > cordova that could benefit from that sort of testing, and seamlessly > integrating running the tests and reporting their results back into > the standard Cordova dev workflow (I assume that is focussed around > GitHub?). I see there are different kinds of test coverage and CI > systems at play (cloudapp, travis, appveyor, plus unit and functional > tests), so initially just wrapping my head around all that. > > If anyone here has suggestions on areas that need work, have > grievances around how they are frustrated by manually needing to test > something, or having any other helpful tips on what needs work or what > could be improved, feel free to reply to this thread! > > My generic notes on this topic so far, in case that is helpful: > > cordova testing overview > ——— > notes / weird things: > - cordova-paramedic configs are pulled from cordova-medic repo. (?) > requires an extra pull in CI. > - paramedic setup for individual plugins install latest HEAD of > master of platform code (at least, cordova-android + device plugin) > - there are plugins tests that run via a jenkins instance on > cloudapp.net, and there are travis tests too. travis is pull-req > triggered, cloud app runs nightly. why? > > road to testing utopia: > - how do platforms get tested? integration tests with what: tooling? plugins? >- unit tests run on travis/appveyor? >- understand what needs to be tested for a release. work backwards > to automate that from there. Steve sent some helpful links my way: > - platform: > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#testing > - plugins: > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#test > - tools: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test > - how do plugins get tested? >- make sure dependencies / artifact versions are locked down. >- what is the difference between "local" vs appium tests > > Looking forward to collaborating with y'all in here once more :) > > Cheers, > Fil > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Hello again!
Hi everyone! Just wanted to (re)introduce myself after a 3 year or so hiatus :) I used to be an active member of the group between 2011 and 2013 when I was on the Adobe PhoneGap team. I took a 3 year detour focusing on mobile testing infrastructure at Sauce Labs, but recently rejoined the Adobe PhoneGap team. I have been lurking more intently on this list for the past month or so and aim to be more involved these days. I've been poking around and getting my bearings around the testing suites, infrastructure and CI in Cordova the past week or so. I think I will try to contribute in that area initially. In particular, I am interested in enabling functional end-to-end testing for all repos in cordova that could benefit from that sort of testing, and seamlessly integrating running the tests and reporting their results back into the standard Cordova dev workflow (I assume that is focussed around GitHub?). I see there are different kinds of test coverage and CI systems at play (cloudapp, travis, appveyor, plus unit and functional tests), so initially just wrapping my head around all that. If anyone here has suggestions on areas that need work, have grievances around how they are frustrated by manually needing to test something, or having any other helpful tips on what needs work or what could be improved, feel free to reply to this thread! My generic notes on this topic so far, in case that is helpful: cordova testing overview ——— notes / weird things: - cordova-paramedic configs are pulled from cordova-medic repo. (?) requires an extra pull in CI. - paramedic setup for individual plugins install latest HEAD of master of platform code (at least, cordova-android + device plugin) - there are plugins tests that run via a jenkins instance on cloudapp.net, and there are travis tests too. travis is pull-req triggered, cloud app runs nightly. why? road to testing utopia: - how do platforms get tested? integration tests with what: tooling? plugins? - unit tests run on travis/appveyor? - understand what needs to be tested for a release. work backwards to automate that from there. Steve sent some helpful links my way: - platform: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#testing - plugins: https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#test - tools: https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test - how do plugins get tested? - make sure dependencies / artifact versions are locked down. - what is the difference between "local" vs appium tests Looking forward to collaborating with y'all in here once more :) Cheers, Fil - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[ANNOUNCE] cordova-plugin-geolocation, cordova-create, cordova-app-hello-world released!
Tweet: https://twitter.com/apachecordova/status/783739548962390016 Blog: http://cordova.apache.org/news/2016/10/04/small-releases.html
[DRAFT] release blog post for create, app-hello-world and geolocation plugin.
https://github.com/apache/cordova-docs/pull/647
Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Shazron Abdullah Vladimir Kotikov The vote has passed. On Tue, Oct 4, 2016 at 12:43 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ran npm test for cordova create > > - > Best regards, Vladimir > > -Original Message- > From: Shazron [mailto:shaz...@gmail.com] > Sent: Monday, October 3, 2016 9:22 PM > To: dev@cordova.apache.org > Subject: Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release! > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ran npm test for cordova create (with new cordova-app-hello-world linked) > * Built hello world app and ran on iOS successfully > > > On Thu, Sep 29, 2016 at 6:49 PM, Steven Gill > wrote: > > > Please review and vote on this release by replying to this email (and > > keep discussion on the DISCUSS thread) > > > > Release issue: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue > > s.apache.org%2Fjira%2Fbrowse%2FCB-11904&data=01%7C01%7Cv-vlkoti%40micr > > osoft.com%7Cfcedb8a692e247851f4408d3ebba467a%7C72f988bf86f141af91ab2d7 > > cd011db47%7C1&sdata=yoQj5RxphF%2BUfmASqifQya1QBtM4weun06TXM%2FxUynE%3D > > &reserved=0 > > > > Both packages have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11904/ > > > > The packages were published from their corresponding git tags: > > > > cordova-app-hello-world: 3.11.0 (eb20135263) > > cordova-create: 1.0.1 (a1c3ecda8b) > > > > Upon a successful vote I will upload the archives to dist/, publish > > them to npm, and post the corresponding blog post. > > > > Voting guidelines: > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > > b.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting. > > md&data=01%7C01%7Cv-vlkoti%40microsoft.com%7Cfcedb8a692e247851f4408d3e > > bba467a%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=%2FwO9C2JO0rmsLdG > > fV062NQMlG%2BSuDauJcfTfHkzGaHw%3D&reserved=0 > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ran npm test for cordova create > > * Built hello world app > > >
RE: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!
I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test for cordova create - Best regards, Vladimir -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Monday, October 3, 2016 9:22 PM To: dev@cordova.apache.org Subject: Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release! I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test for cordova create (with new cordova-app-hello-world linked) * Built hello world app and ran on iOS successfully On Thu, Sep 29, 2016 at 6:49 PM, Steven Gill wrote: > Please review and vote on this release by replying to this email (and > keep discussion on the DISCUSS thread) > > Release issue: > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissue > s.apache.org%2Fjira%2Fbrowse%2FCB-11904&data=01%7C01%7Cv-vlkoti%40micr > osoft.com%7Cfcedb8a692e247851f4408d3ebba467a%7C72f988bf86f141af91ab2d7 > cd011db47%7C1&sdata=yoQj5RxphF%2BUfmASqifQya1QBtM4weun06TXM%2FxUynE%3D > &reserved=0 > > Both packages have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11904/ > > The packages were published from their corresponding git tags: > > cordova-app-hello-world: 3.11.0 (eb20135263) > cordova-create: 1.0.1 (a1c3ecda8b) > > Upon a successful vote I will upload the archives to dist/, publish > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu > b.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting. > md&data=01%7C01%7Cv-vlkoti%40microsoft.com%7Cfcedb8a692e247851f4408d3e > bba467a%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=%2FwO9C2JO0rmsLdG > fV062NQMlG%2BSuDauJcfTfHkzGaHw%3D&reserved=0 > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran npm test for cordova create > * Built hello world app >
Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!
I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test for cordova create (with new cordova-app-hello-world linked) * Built hello world app and ran on iOS successfully On Thu, Sep 29, 2016 at 6:49 PM, Steven Gill wrote: > Please review and vote on this release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-11904 > > Both packages have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11904/ > > The packages were published from their corresponding git tags: > > cordova-app-hello-world: 3.11.0 (eb20135263) > cordova-create: 1.0.1 (a1c3ecda8b) > > Upon a successful vote I will upload the archives to dist/, publish > them to npm, and post the corresponding blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran npm test for cordova create > * Built hello world app >
[VOTE] create@1.0.1 & app-hello-world@3.11.0 release!
Please review and vote on this release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11904 Both packages have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11904/ The packages were published from their corresponding git tags: cordova-app-hello-world: 3.11.0 (eb20135263) cordova-create: 1.0.1 (a1c3ecda8b) Upon a successful vote I will upload the archives to dist/, publish them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test for cordova create * Built hello world app
[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/17 CB-11938 updated csp to include content: for img-src You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-app-hello-world master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] cordova-app-hello-world@3.11.0
+1 On Tue, Sep 27, 2016 at 3:27 PM, Steven Gill wrote: > Wanted to do a quick release for this. Just updated it to follow the > template docs a bit closer. > http://cordova.apache.org/docs/en/latest/guide/cli/template.html#create-a- > template >
[DISCUSS] cordova-app-hello-world@3.11.0
Wanted to do a quick release for this. Just updated it to follow the template docs a bit closer. http://cordova.apache.org/docs/en/latest/guide/cli/template.html#create-a-template
[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...
Github user brianleroux closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...
Github user brianleroux closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #5: updated with feedback from cordova ...
GitHub user brianleroux reopened a pull request: https://github.com/apache/cordova-app-hello-world/pull/5 updated with feedback from cordova crew You can merge this pull request into a Git repository by running: $ git pull https://github.com/brianleroux/cordova-app-hello-world simplified Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit 15a22e7745e6719293ebc03182ac0d05b14eefb7 Author: brianleroux Date: 2013-12-09T02:19:04Z distilling to essence of hello world commit 8a069d2e3a7f55775e8f0bf6331ca03ba092a20c Author: brianleroux Date: 2013-12-09T23:51:21Z tweaks from feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #16: CB-11412 Update templates to desig...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...
Github user carynbear commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 @stevengill removed package.json from template_src, changed config.xml version to 1.0.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 LGTM otherwise :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets not add a `package.json` to template_src for now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world issue #16: CB-11412 Update templates to designate te...
Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets update version in the default config.xml to be 1.0.0 instead of 0.0.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request #16: CB-11412 Update templates to desig...
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/16 CB-11412 Update templates to designate template source dir You can merge this pull request into a Git repository by running: $ git pull https://github.com/carynbear/cordova-app-hello-world master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 513d01060ebc31d660cbae5ac21642a9e90386a1 Author: carynbear Date: 2016-06-15T20:15:14Z CB-11412 Update templates to designate template source dir --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hello!
Welcome Michel ! Hope you'll have great journey ahead. On Tue, Mar 1, 2016 at 8:45 AM, Carlos Santana wrote: > Michael > Glad that you took the step forward to contribute to open source, we > appreciate any help you can provide. > > > On Mon, Feb 29, 2016 at 4:48 PM Steven Gill > wrote: > > > Welcome Michael! > > > > Join us on slack too! slack.cordova.io > > > > On Mon, Feb 29, 2016 at 1:45 PM, julio cesar sanchez < > > jcesarmob...@gmail.com > > > wrote: > > > > > Welcome Michael. > > > > > > Make sure you read the contributor guidelines > > > https://cordova.apache.org/contribute/contribute_guidelines.html > > > > > > Easyfix issues are a good starting point. > > > > > > > > > > > > 2016-02-29 21:49 GMT+01:00 Michael Baldwin : > > > > > > > Hey everyone, I'm Michael Baldwin and I'm a Computer Science student > at > > > > Arizona State University. I'm currently finishing up my Junior year > > and > > > > looking to get some real world experience in development. So I'm > here > > to > > > > get some bugs fixed, receive criticism, and hopefully learn a ton! > > > Cordova > > > > is the first open source project that really jumped out at me, I love > > the > > > > idea and it's definitely something that I will use myself. > > > > > > > > Right now my plan of attack is to keep reading information on the > site > > > and > > > > to start by tackling some easyfix issues. I'm open to any other > > > > suggestions if anyone has any! > > > > > > > > Thanks and have a good one. > > > > > > > > > >
Re: Hello!
Michael Glad that you took the step forward to contribute to open source, we appreciate any help you can provide. On Mon, Feb 29, 2016 at 4:48 PM Steven Gill wrote: > Welcome Michael! > > Join us on slack too! slack.cordova.io > > On Mon, Feb 29, 2016 at 1:45 PM, julio cesar sanchez < > jcesarmob...@gmail.com > > wrote: > > > Welcome Michael. > > > > Make sure you read the contributor guidelines > > https://cordova.apache.org/contribute/contribute_guidelines.html > > > > Easyfix issues are a good starting point. > > > > > > > > 2016-02-29 21:49 GMT+01:00 Michael Baldwin : > > > > > Hey everyone, I'm Michael Baldwin and I'm a Computer Science student at > > > Arizona State University. I'm currently finishing up my Junior year > and > > > looking to get some real world experience in development. So I'm here > to > > > get some bugs fixed, receive criticism, and hopefully learn a ton! > > Cordova > > > is the first open source project that really jumped out at me, I love > the > > > idea and it's definitely something that I will use myself. > > > > > > Right now my plan of attack is to keep reading information on the site > > and > > > to start by tackling some easyfix issues. I'm open to any other > > > suggestions if anyone has any! > > > > > > Thanks and have a good one. > > > > > >
Re: Hello!
Welcome Michael! Join us on slack too! slack.cordova.io On Mon, Feb 29, 2016 at 1:45 PM, julio cesar sanchez wrote: > Welcome Michael. > > Make sure you read the contributor guidelines > https://cordova.apache.org/contribute/contribute_guidelines.html > > Easyfix issues are a good starting point. > > > > 2016-02-29 21:49 GMT+01:00 Michael Baldwin : > > > Hey everyone, I'm Michael Baldwin and I'm a Computer Science student at > > Arizona State University. I'm currently finishing up my Junior year and > > looking to get some real world experience in development. So I'm here to > > get some bugs fixed, receive criticism, and hopefully learn a ton! > Cordova > > is the first open source project that really jumped out at me, I love the > > idea and it's definitely something that I will use myself. > > > > Right now my plan of attack is to keep reading information on the site > and > > to start by tackling some easyfix issues. I'm open to any other > > suggestions if anyone has any! > > > > Thanks and have a good one. > > >
Re: Hello!
Welcome Michael. Make sure you read the contributor guidelines https://cordova.apache.org/contribute/contribute_guidelines.html Easyfix issues are a good starting point. 2016-02-29 21:49 GMT+01:00 Michael Baldwin : > Hey everyone, I'm Michael Baldwin and I'm a Computer Science student at > Arizona State University. I'm currently finishing up my Junior year and > looking to get some real world experience in development. So I'm here to > get some bugs fixed, receive criticism, and hopefully learn a ton! Cordova > is the first open source project that really jumped out at me, I love the > idea and it's definitely something that I will use myself. > > Right now my plan of attack is to keep reading information on the site and > to start by tackling some easyfix issues. I'm open to any other > suggestions if anyone has any! > > Thanks and have a good one. >
Hello!
Hey everyone, I'm Michael Baldwin and I'm a Computer Science student at Arizona State University. I'm currently finishing up my Junior year and looking to get some real world experience in development. So I'm here to get some bugs fixed, receive criticism, and hopefully learn a ton! Cordova is the first open source project that really jumped out at me, I love the idea and it's definitely something that I will use myself. Right now my plan of attack is to keep reading information on the site and to start by tackling some easyfix issues. I'm open to any other suggestions if anyone has any! Thanks and have a good one.
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184885794 Cool, seems like we've reached a consensus. Merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-184856505 LGTM. That third layer of binding always seemed confusing. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-183448308 @axemclion Can you check now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52271030
--- Diff: www/js/index.js ---
@@ -19,22 +19,20 @@
var app = {
// Application Constructor
initialize: function() {
-this.bindEvents();
-},
-// Bind Event Listeners
-//
-// Bind any events that are required on startup. Common events are:
-// 'load', 'deviceready', 'offline', and 'online'.
-bindEvents: function() {
document.addEventListener('deviceready', this.onDeviceReady,
false);
--- End diff --
Any variables in `app`'s scope are already in `onDeviceReady`'s scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user axemclion commented on a diff in the pull request:
https://github.com/apache/cordova-app-hello-world/pull/15#discussion_r52264119
--- Diff: www/js/index.js ---
@@ -19,22 +19,20 @@
var app = {
// Application Constructor
initialize: function() {
-this.bindEvents();
-},
-// Bind Event Listeners
-//
-// Bind any events that are required on startup. Common events are:
-// 'load', 'deviceready', 'offline', and 'online'.
-bindEvents: function() {
document.addEventListener('deviceready', this.onDeviceReady,
false);
--- End diff --
Do we wanna do a this.onDeviceReady.bind(this) here ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181674386 @dblotsky yes. Definitely needs dev list approval. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181673845 Will this also be going out as an email to the dev@ list? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181659458 @axemclion Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/15#issuecomment-181630866 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-10522: Event binding in H...
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/15 CB-10522: Event binding in Hello World is misleading The current event binding in the Hello World example is slightly misleading. So, fixing it. @nikhilkh @dblotsky @riknoll @rkatyal Can you please review and merge this PR? You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarangan12/cordova-app-hello-world CB-10522 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit a17a3d289a6e1428a34068040563d998faf63fc0 Author: Sarangan Rajamanickam Date: 2016-02-05T19:25:34Z CB-10522: Event binding in Hello World is misleading Fixing the Hello World example --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Raphael from Switzerland say hello
Hi all My Name is Raphael Bircher. I have a Long history in Open Source and at Apache. I'm a Committer and was a PMC Member of Apache OpenOffice and I also did some work for the Incobator. My speciality is Quality Assurance and tracking down Bugs. I have some interests in developping webapps. My Apache Name is rbircher and I have a blog at http://raphaelbircher.wordpress.com (moastly in German). Regards Raphael
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-2528 Add window.onerror
Github user BBosman closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[ANNOUNCEMENT] Cordova-app-hello-world@3.10.0 has been released!
:D Also updated Android, iOS and Windows templates with this released version (for non cli usecases).
[GitHub] cordova-coho pull request: Update app-hello-world-release-process....
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: Update app-hello-world-release-process....
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/99 Update app-hello-world-release-process.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-38 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/99.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #99 commit 443c2f8460c86ed59d23a1854ca11df4fc0ba27f Author: Steve Gill Date: 2015-10-29T22:52:44Z Update app-hello-world-release-process.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] 3.10.0 Cordova App Hello World Release
The vote has now closed. The results are: Positive Binding Votes: (# of PMC members that +1'ed) Steve Gill Carlos Santana Vladimir Kotikov The vote has passed. I will now publish to dist & npm. On Thu, Oct 29, 2015 at 11:16 AM, Carlos Santana wrote: > choo choo !! > > On Thu, Oct 29, 2015 at 10:08 AM Vladimir Kotikov (Akvelon) < > v-vlk...@microsoft.com> wrote: > > > I vote +1 > > > > * Ran coho verify-archive successfully > > * Created blank application using cordova-app-hello-world@3.10.0, build > > and ran successfully > > > > - > > Best regards, Vladimir > > > > -Original Message- > > From: Carlos Santana [mailto:csantan...@gmail.com] > > Sent: Thursday, October 29, 2015 5:20 AM > > To: dev@cordova.apache.org > > Subject: Re: [Vote] 3.10.0 Cordova App Hello World Release > > > > +1 > > Review the new commits for release > > Ran coho verify-archive vote-hello/cordova-app-hello-world-3.10.0.tgz > > Ran coho verify-tags with cordova-app-hello-world: 3.10.0 (64d5c71f05) > > Recreated archive Ran coho create-archive -r app-hello-world --tag 3.10.0 > > --dest test-hello/ and compare with dist Created test app with new > > app-hello-world > > > > minor comments, nothing to stop the vote: > > - CB-9712 I think it is npm 3, instead of node 3.3.3 > > - CB-8896 using spec attribute instead of version attribute for whitelist > > plugin in config.xml, I was not able to find were do we document the > > element for config.xml [1] > > > > [1]: > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-docs%2fblob%2fmaster%2fwww%2fdocs%2fen%2fedge%2fconfig_ref%2findex.md&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c8ffe2b9439664c53312d08d2e0077611%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=oPPRggL3%2bg3RSHgIUhcCdJb02FNg1CA4LPSh8ZTekQ4%3d > > > > On Mon, Oct 26, 2015 at 8:24 PM Steven Gill > > wrote: > > > > > Please review and vote on this 3.10.0 Cordova App Hello World Release > > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > > > Release issue: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue > > > s.apache.org%2fjira%2fbrowse%2fCB-9870&data=01%7c01%7cv-vlkoti%40064d. > > > mgd.microsoft.com%7c8ffe2b9439664c53312d08d2e0077611%7c72f988bf86f141a > > > f91ab2d7cd011db47%7c1&sdata=ENB0p90lCZ1zbkOoCyTMZNAPDjT752qlJCRA9fcNtD > > > g%3d > > > > > > Repos ready to be released have been published to > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9870 > > > > > > The package was published from its corresponding git tag: > > > cordova-app-hello-world: 3.10.0 (64d5c71f05) > > > > > > Upon a successful vote I will upload the archive to dist/ and publish > > > it to NPM. > > > > > > Voting guidelines: > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > > b.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting. > > > md&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c8ffe2b9439664c53 > > > 312d08d2e0077611%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=EUgWsABn > > > hfoIb5nxx6uQLp%2faefXOXrcIFfhknXjuCwE%3d > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Built a hello world app using the CLI > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > >
Re: [Vote] 3.10.0 Cordova App Hello World Release
choo choo !! On Thu, Oct 29, 2015 at 10:08 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > I vote +1 > > * Ran coho verify-archive successfully > * Created blank application using cordova-app-hello-world@3.10.0, build > and ran successfully > > - > Best regards, Vladimir > > -Original Message- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Thursday, October 29, 2015 5:20 AM > To: dev@cordova.apache.org > Subject: Re: [Vote] 3.10.0 Cordova App Hello World Release > > +1 > Review the new commits for release > Ran coho verify-archive vote-hello/cordova-app-hello-world-3.10.0.tgz > Ran coho verify-tags with cordova-app-hello-world: 3.10.0 (64d5c71f05) > Recreated archive Ran coho create-archive -r app-hello-world --tag 3.10.0 > --dest test-hello/ and compare with dist Created test app with new > app-hello-world > > minor comments, nothing to stop the vote: > - CB-9712 I think it is npm 3, instead of node 3.3.3 > - CB-8896 using spec attribute instead of version attribute for whitelist > plugin in config.xml, I was not able to find were do we document the > element for config.xml [1] > > [1]: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-docs%2fblob%2fmaster%2fwww%2fdocs%2fen%2fedge%2fconfig_ref%2findex.md&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c8ffe2b9439664c53312d08d2e0077611%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=oPPRggL3%2bg3RSHgIUhcCdJb02FNg1CA4LPSh8ZTekQ4%3d > > On Mon, Oct 26, 2015 at 8:24 PM Steven Gill > wrote: > > > Please review and vote on this 3.10.0 Cordova App Hello World Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue > > s.apache.org%2fjira%2fbrowse%2fCB-9870&data=01%7c01%7cv-vlkoti%40064d. > > mgd.microsoft.com%7c8ffe2b9439664c53312d08d2e0077611%7c72f988bf86f141a > > f91ab2d7cd011db47%7c1&sdata=ENB0p90lCZ1zbkOoCyTMZNAPDjT752qlJCRA9fcNtD > > g%3d > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9870 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 3.10.0 (64d5c71f05) > > > > Upon a successful vote I will upload the archive to dist/ and publish > > it to NPM. > > > > Voting guidelines: > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > > b.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting. > > md&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c8ffe2b9439664c53 > > 312d08d2e0077611%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=EUgWsABn > > hfoIb5nxx6uQLp%2faefXOXrcIFfhknXjuCwE%3d > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Built a hello world app using the CLI > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org >
RE: [Vote] 3.10.0 Cordova App Hello World Release
I vote +1 * Ran coho verify-archive successfully * Created blank application using cordova-app-hello-world@3.10.0, build and ran successfully - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Thursday, October 29, 2015 5:20 AM To: dev@cordova.apache.org Subject: Re: [Vote] 3.10.0 Cordova App Hello World Release +1 Review the new commits for release Ran coho verify-archive vote-hello/cordova-app-hello-world-3.10.0.tgz Ran coho verify-tags with cordova-app-hello-world: 3.10.0 (64d5c71f05) Recreated archive Ran coho create-archive -r app-hello-world --tag 3.10.0 --dest test-hello/ and compare with dist Created test app with new app-hello-world minor comments, nothing to stop the vote: - CB-9712 I think it is npm 3, instead of node 3.3.3 - CB-8896 using spec attribute instead of version attribute for whitelist plugin in config.xml, I was not able to find were do we document the element for config.xml [1] [1]: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-docs%2fblob%2fmaster%2fwww%2fdocs%2fen%2fedge%2fconfig_ref%2findex.md&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c8ffe2b9439664c53312d08d2e0077611%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=oPPRggL3%2bg3RSHgIUhcCdJb02FNg1CA4LPSh8ZTekQ4%3d On Mon, Oct 26, 2015 at 8:24 PM Steven Gill wrote: > Please review and vote on this 3.10.0 Cordova App Hello World Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue > s.apache.org%2fjira%2fbrowse%2fCB-9870&data=01%7c01%7cv-vlkoti%40064d. > mgd.microsoft.com%7c8ffe2b9439664c53312d08d2e0077611%7c72f988bf86f141a > f91ab2d7cd011db47%7c1&sdata=ENB0p90lCZ1zbkOoCyTMZNAPDjT752qlJCRA9fcNtD > g%3d > > Repos ready to be released have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9870 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 3.10.0 (64d5c71f05) > > Upon a successful vote I will upload the archive to dist/ and publish > it to NPM. > > Voting guidelines: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu > b.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting. > md&data=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c8ffe2b9439664c53 > 312d08d2e0077611%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=EUgWsABn > hfoIb5nxx6uQLp%2faefXOXrcIFfhknXjuCwE%3d > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Built a hello world app using the CLI > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] 3.10.0 Cordova App Hello World Release
+1 Review the new commits for release Ran coho verify-archive vote-hello/cordova-app-hello-world-3.10.0.tgz Ran coho verify-tags with cordova-app-hello-world: 3.10.0 (64d5c71f05) Recreated archive Ran coho create-archive -r app-hello-world --tag 3.10.0 --dest test-hello/ and compare with dist Created test app with new app-hello-world minor comments, nothing to stop the vote: - CB-9712 I think it is npm 3, instead of node 3.3.3 - CB-8896 using spec attribute instead of version attribute for whitelist plugin in config.xml, I was not able to find were do we document the element for config.xml [1] [1]: https://github.com/apache/cordova-docs/blob/master/www/docs/en/edge/config_ref/index.md On Mon, Oct 26, 2015 at 8:24 PM Steven Gill wrote: > Please review and vote on this 3.10.0 Cordova App Hello World Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-9870 > > Repos ready to be released have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9870 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 3.10.0 (64d5c71f05) > > Upon a successful vote I will upload the archive to dist/ and publish it > to NPM. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Built a hello world app using the CLI >
[Vote] 3.10.0 Cordova App Hello World Release
Please review and vote on this 3.10.0 Cordova App Hello World Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9870 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9870 The package was published from its corresponding git tag: cordova-app-hello-world: 3.10.0 (64d5c71f05) Upon a successful vote I will upload the archive to dist/ and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built a hello world app using the CLI
Re: [DISCUSS] Cordova App Hello World Release
RELEASE NOTES: https://github.com/apache/cordova-app-hello-world/blob/master/RELEASENOTES.md On Mon, Oct 26, 2015 at 4:36 PM, Steven Gill wrote: > Issue: https://issues.apache.org/jira/browse/CB-9870 > > On Mon, Oct 26, 2015 at 4:34 PM, Steven Gill > wrote: > >> Does anyone have any reason to delay a cordova-app-hello-world release? >> Any outstanding patches to land? >> >> >> >
Re: [DISCUSS] Cordova App Hello World Release
Issue: https://issues.apache.org/jira/browse/CB-9870 On Mon, Oct 26, 2015 at 4:34 PM, Steven Gill wrote: > Does anyone have any reason to delay a cordova-app-hello-world release? > Any outstanding patches to land? > > >
[DISCUSS] Cordova App Hello World Release
Does anyone have any reason to delay a cordova-app-hello-world release? Any outstanding patches to land?
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user omefire commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146967713 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146869382 LGTM :shipit: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user daserge commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146835675 @omefire, thank you for review, I've addressed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
Github user omefire commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146660710 I think we should also update package.json to explicitly mention the entry point (index.js) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9712 CLI 5.3 breaks with ...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/14 CB-9712 CLI 5.3 breaks with node 3.3.3 Added `index.js` so that the module can be required and resolved. [Jira issue](https://issues.apache.org/jira/browse/CB-9712) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-app-hello-world CB-9712 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit bca1753d09b4d23fc59d1ed35ad4a76028d56fa8 Author: daserge Date: 2015-10-06T10:33:52Z CB-9712 CLI 5.3 breaks with node 3.3.3 Added blank index.js so that module can be required and resolved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-130459377 Thanks everyone - I've got a potential solution that we're testing here. We can close this request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128885973 Adding this to index.html should be a blackberry build step, I would expect this to only exist in the platform's www folder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128835312 @jengee you don't have to get tired of update the template every time, you can implement a user land cordova hook after_prepare [1] [2] you can have a simple nodejs script or any other type of script, and parse the index.html after being copy to the platform/**/www/ and and check if csp is missing the value that you want "http://localhost:8247"; and added there. having an arbitrary localhost port open in csp, present for a common template will raise an eye brow of concerns for people using it in other platforms than blackberry. [1] http://cordova.apache.org/docs/en/edge/guide_appdev_hooks_index.md.html#Hooks%20Guide [2] http://photokandy.tumblr.com/post/47426024187/cordova-cli-simple-hooks-and-merges --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128833712 -1 hum this looks very ugly in the template. I don't like to have this in the default template. people might think that is a security whole. In another platform like android, not picking android then that port will be expose, it will not get intercepted because is not blackberry some options: 1. bb plugin to implement plugin hook, this is a new type of hook that plugins can implement If this is only required for BlackBerry, then the plugin for blackberry can implement a plugin hook to edit the index.html during after_prepare. it can parse the index.html look for the tag and if http://locahost:8472 doesn't exist then added. 2. the cordova.js for blackberry dynamically edits the csp tag in the dom when cordova.js runs before setting up the plugin update the csp meta, I don't know if this is too late to change since index.html is already parsed, if this is not an option then take a look at option 1 above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/12#issuecomment-108547543 It's unclear what the intent of this PR is. Can you please close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/13#issuecomment-108547570 It's unclear what the intent of this PR is. Can you please close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
