Re: Hello
Welcome Vish! On Fri, May 29, 2015 at 11:08 AM, Murat Sutunc wrote: > Welcome Vishal !! Happy to have another contributor :) > > -Original Message- > From: Vishal Mishra [mailto:vismi...@adobe.com] > Sent: Thursday, May 28, 2015 11:30 AM > To: dev@cordova.apache.org > Subject: Hello > > Hi, > > I am Vishal and have joined the Adobe team that works on Cordova. I will > be working on making Cordova work better with the new devices and platforms. > > Regards, > Vishal > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
RE: Hello
Welcome Vishal !! Happy to have another contributor :) -Original Message- From: Vishal Mishra [mailto:vismi...@adobe.com] Sent: Thursday, May 28, 2015 11:30 AM To: dev@cordova.apache.org Subject: Hello Hi, I am Vishal and have joined the Adobe team that works on Cordova. I will be working on making Cordova work better with the new devices and platforms. Regards, Vishal - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Hello
Hi, I am Vishal and have joined the Adobe team that works on Cordova. I will be working on making Cordova work better with the new devices and platforms. Regards, Vishal - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
GitHub user Yamini-Sontakke opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/13 Useless change Added by Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world copy-from-app-hello-world Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 3760adf47a6bde16377d5844368992c6614d0aaa Author: Yamini-Sontakke Date: 2015-05-28T11:22:13Z Useless change Added by Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
GitHub user Yamini-Sontakke opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/12 Useless change Added by Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world copy-from-app-hello-world Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 3760adf47a6bde16377d5844368992c6614d0aaa Author: Yamini-Sontakke Date: 2015-05-28T11:22:13Z Useless change Added by Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
GitHub user Yamini-Sontakke reopened a pull request: https://github.com/apache/cordova-app-hello-world/pull/12 Useless change Added by Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world copy-from-app-hello-world Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 3760adf47a6bde16377d5844368992c6614d0aaa Author: Yamini-Sontakke Date: 2015-05-28T11:22:13Z Useless change Added by Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
Github user Yamini-Sontakke closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
Github user Yamini-Sontakke commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/12#issuecomment-106285245 hell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
Github user Yamini-Sontakke commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/11#issuecomment-106284959 hello demo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
Github user Yamini-Sontakke closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: Useless change
GitHub user Yamini-Sontakke opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/11 Useless change Added by Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/Yamini-Sontakke/cordova-app-hello-world copy-from-app-hello-world Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit 3760adf47a6bde16377d5844368992c6614d0aaa Author: Yamini-Sontakke Date: 2015-05-28T11:22:13Z Useless change Added by Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101817138 It's required for runtime if an app (running on BlackBerry 10) has any plugins. The app doesn't actually talk to port 8472, it's just magically intercepted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101816514 Is this required for development time experience or every app needs access to localhost port 8472 to run on the phone? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Can we use a plugin hook to modify the csp in the bb10 start html page? localhost is not defined on most platforms afaik, so it may be less of an issue. @purplecabbage risingj.com On Wed, May 13, 2015 at 1:00 PM, Josh Soref wrote: > > https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 > 9782 > > Problem: > As is, today, Cordova projects created w/ the default cordova hello-world > template which have any plugins won't work on BlackBerry 10 at-all > > My fix is to add a CSP whitelist for the BlackBerry 10 magic port... > > Steve Gill commented on the pull request: > > As long as this doesn't negatively impact other platforms, merge > away. > > The only downside is that if someone manages to have another application > running on that port on a non blackberry platform, > and if someone writes a buggy application which can be taken over, > then that buggy application could talk to the other application w/ that > port > on that non blackberry platform > > it's pretty obscure, but... > > Are people OK with this? > > The section we're changing has a bunch of platform specific notes, it seems > like it's really asking for a pre-processor of some sort to magically > stitch > up this field... > > > Does anyone have an alternative proposal? If not, I'm planning to merge my > PR on Monday. >
RE: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 9782 Problem: As is, today, Cordova projects created w/ the default cordova hello-world template which have any plugins won't work on BlackBerry 10 at-all My fix is to add a CSP whitelist for the BlackBerry 10 magic port... Steve Gill commented on the pull request: > As long as this doesn't negatively impact other platforms, merge away. The only downside is that if someone manages to have another application running on that port on a non blackberry platform, and if someone writes a buggy application which can be taken over, then that buggy application could talk to the other application w/ that port on that non blackberry platform it's pretty obscure, but... Are people OK with this? The section we're changing has a bunch of platform specific notes, it seems like it's really asking for a pre-processor of some sort to magically stitch up this field... Does anyone have an alternative proposal? If not, I'm planning to merge my PR on Monday. smime.p7s Description: S/MIME cryptographic signature
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101429782 As long as this doesn't negatively impact other platforms, merge away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101032363 Works for me - required for use of any plugins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/10 CB-9009 default CSP needs to include 8472 for blackberry You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-app-hello-world cb_9009 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-app-hello-world/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit fac9f1c19744e25fdc45b993ff1b53ea4f54cc1c Author: Josh Soref Date: 2015-05-11T19:30:15Z CB-9009 default CSP needs to include 8472 for blackberry --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101026209 @timwindsor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] 3.9.0 Cordova App Hello World Release
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Ian Clelland Andrew Grieve The vote has passed. I will now publish it to npm and dist. I will also update the dependency in cordova-lib. On Wed, Mar 25, 2015 at 12:55 PM, Andrew Grieve wrote: > +1 > > On Tue, Mar 24, 2015 at 9:29 AM, Ian Clelland > wrote: > > > +1 > > > > * Checked signatures and checksums > > * Verified contents against Git repo at 3.9.0 tag > > * Successfully built and ran hello world with Cordova-Android 3.7.1 and > > 4.0.0-dev (master) > > > > On Mon, Mar 23, 2015 at 8:13 PM, Steven Gill > > wrote: > > > > > Please review and vote on this 3.9.0 Cordova App Hello World Release. > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-8731 > > > > > > Repos ready to be released have been published to > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8731 > > > > > > The package was published from its corresponding git tag: > > > cordova-app-hello-world: 3.9.0 (fb3150bf76) > > > > > > Upon a successful vote I will upload the archive to dist/ and publish > it > > > to NPM. > > > > > > Voting guidelines: > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Built a hello world app using the CLI > > > > > >
Re: [Vote] 3.9.0 Cordova App Hello World Release
+1 On Tue, Mar 24, 2015 at 9:29 AM, Ian Clelland wrote: > +1 > > * Checked signatures and checksums > * Verified contents against Git repo at 3.9.0 tag > * Successfully built and ran hello world with Cordova-Android 3.7.1 and > 4.0.0-dev (master) > > On Mon, Mar 23, 2015 at 8:13 PM, Steven Gill > wrote: > > > Please review and vote on this 3.9.0 Cordova App Hello World Release. > > > > Release issue: https://issues.apache.org/jira/browse/CB-8731 > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8731 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 3.9.0 (fb3150bf76) > > > > Upon a successful vote I will upload the archive to dist/ and publish it > > to NPM. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Built a hello world app using the CLI > > >
[Vote] 3.9.0 Cordova App Hello World Release
Please review and vote on this 3.9.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8731 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8731 The package was published from its corresponding git tag: cordova-app-hello-world: 3.9.0 (fb3150bf76) Upon a successful vote I will upload the archive to dist/ and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built a hello world app using the CLI
Re: [DISCUSS] Cordova App Hello World Release 3.9.0
yes! On Mon, Mar 23, 2015 at 1:16 PM, Mark Koudritsky wrote: > +1 > > The code that uses NPM version of cordova-app-hello-world in cordova-lib is > currently on a branch > < > https://github.com/apache/cordova-lib/blob/copy-from-app-hello-world/cordova-lib/package.json > >. > Should we merge it now to start using the npm version of hello world? > > On Mon, Mar 23, 2015 at 3:20 PM, Steven Gill > wrote: > > > Yup > > On Mar 23, 2015 11:50 AM, "Ian Clelland" wrote: > > > > > This includes > > > > > > > > > https://github.com/apache/cordova-app-hello-world/commit/2e856b845a0134e7056bdc74f89cafcf483a379f > > > , > > > right? > > > > > > If so, +1 for releasing! > > > > > > On Mon, Mar 23, 2015 at 1:54 PM, Steven Gill > > > wrote: > > > > > > > Does anyone have any reason to delay a cordova-app-hello-world > release? > > > > Any outstanding patches to land? > > > > > > > > If not, I will start the release this afternoon. > > > > > > > > > >
Re: [DISCUSS] Cordova App Hello World Release 3.9.0
+1 The code that uses NPM version of cordova-app-hello-world in cordova-lib is currently on a branch <https://github.com/apache/cordova-lib/blob/copy-from-app-hello-world/cordova-lib/package.json>. Should we merge it now to start using the npm version of hello world? On Mon, Mar 23, 2015 at 3:20 PM, Steven Gill wrote: > Yup > On Mar 23, 2015 11:50 AM, "Ian Clelland" wrote: > > > This includes > > > > > https://github.com/apache/cordova-app-hello-world/commit/2e856b845a0134e7056bdc74f89cafcf483a379f > > , > > right? > > > > If so, +1 for releasing! > > > > On Mon, Mar 23, 2015 at 1:54 PM, Steven Gill > > wrote: > > > > > Does anyone have any reason to delay a cordova-app-hello-world release? > > > Any outstanding patches to land? > > > > > > If not, I will start the release this afternoon. > > > > > >
Re: [DISCUSS] Cordova App Hello World Release 3.9.0
Yup On Mar 23, 2015 11:50 AM, "Ian Clelland" wrote: > This includes > > https://github.com/apache/cordova-app-hello-world/commit/2e856b845a0134e7056bdc74f89cafcf483a379f > , > right? > > If so, +1 for releasing! > > On Mon, Mar 23, 2015 at 1:54 PM, Steven Gill > wrote: > > > Does anyone have any reason to delay a cordova-app-hello-world release? > > Any outstanding patches to land? > > > > If not, I will start the release this afternoon. > > >
Re: [DISCUSS] Cordova App Hello World Release 3.9.0
This includes https://github.com/apache/cordova-app-hello-world/commit/2e856b845a0134e7056bdc74f89cafcf483a379f, right? If so, +1 for releasing! On Mon, Mar 23, 2015 at 1:54 PM, Steven Gill wrote: > Does anyone have any reason to delay a cordova-app-hello-world release? > Any outstanding patches to land? > > If not, I will start the release this afternoon. >
[DISCUSS] Cordova App Hello World Release 3.9.0
Does anyone have any reason to delay a cordova-app-hello-world release? Any outstanding patches to land? If not, I will start the release this afternoon.
Re: App Hello World with default plugin (plus status update)
On 20 Mar 2015, at 14:46, Andrew Grieve wrote: First: just committed a change to add the whitelist plugin to the default app template: https://git1-us-west.apache.org/repos/asf?p=cordova-app-hello-world.git;a=commit;h=2e856b845a0134e7056bdc74f89cafcf483a379f Perhaps a bit strange if projects don't use iOS / Android, but I'm not sure there's a good alternative. Second: Seems there were some started tasks that have fallen silent: - Publishing app-hello-world to NPM (Steve - vote passed?) - CLI (so that it obeys within config.xml, and so that it can get plugins from npm) This is just waiting for a release. The master of cordova-lib now works with on config.xml. It still retains the ability to use tags but prints a warning about them. All new information is added as tags. Would like both of these things to happen (plus another app-hello-world release to pick up change), so that: - We can publish cordova-plugin-whitelist to NPM - We can ship android@4.0 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: App Hello World with default plugin (plus status update)
I closed app hello world vote and published. Agree will need another release. On Mar 20, 2015 11:48 AM, "Andrew Grieve" wrote: > First: just committed a change to add the whitelist plugin to the default > app template: > > > https://git1-us-west.apache.org/repos/asf?p=cordova-app-hello-world.git;a=commit;h=2e856b845a0134e7056bdc74f89cafcf483a379f > > Perhaps a bit strange if projects don't use iOS / Android, but I'm not sure > there's a good alternative. > > > Second: Seems there were some started tasks that have fallen silent: > > - Publishing app-hello-world to NPM (Steve - vote passed?) > - CLI (so that it obeys within config.xml, and so that it can get > plugins from npm) > > Would like both of these things to happen (plus another app-hello-world > release to pick up change), so that: > - We can publish cordova-plugin-whitelist to NPM > - We can ship android@4.0 >
App Hello World with default plugin (plus status update)
First: just committed a change to add the whitelist plugin to the default app template: https://git1-us-west.apache.org/repos/asf?p=cordova-app-hello-world.git;a=commit;h=2e856b845a0134e7056bdc74f89cafcf483a379f Perhaps a bit strange if projects don't use iOS / Android, but I'm not sure there's a good alternative. Second: Seems there were some started tasks that have fallen silent: - Publishing app-hello-world to NPM (Steve - vote passed?) - CLI (so that it obeys within config.xml, and so that it can get plugins from npm) Would like both of these things to happen (plus another app-hello-world release to pick up change), so that: - We can publish cordova-plugin-whitelist to NPM - We can ship android@4.0
Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 3)
The vote has now closed. The results are: Positive Binding Votes: (# of PMC members that +1'ed) Steve Gill Mark Koudritsky Andrew Grieve The vote has passed. I will now publish to dist & npm On Mon, Mar 16, 2015 at 9:01 AM, Andrew Grieve wrote: > +1 > > On Fri, Mar 13, 2015 at 3:01 PM, Mark Koudritsky > wrote: > > > +1 > > Built and ran on > > - Android 5.0.2 on Nexus 7 > > - iOS simulator > > > > On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill > > wrote: > > > > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > > > > > Repos ready to be released have been published to > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > > > > > The package was published from its corresponding git tag: > > > cordova-app-hello-world: 3.8.0 (5e572b6bd2) > > > > > > Upon a successful vote I will upload the archive to dist/ and publish > it > > > to NPM. > > > > > > Voting guidelines: > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Built a hello world app using the CLI > > > > > >
Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 3)
+1 On Fri, Mar 13, 2015 at 3:01 PM, Mark Koudritsky wrote: > +1 > Built and ran on > - Android 5.0.2 on Nexus 7 > - iOS simulator > > On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill > wrote: > > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 3.8.0 (5e572b6bd2) > > > > Upon a successful vote I will upload the archive to dist/ and publish it > > to NPM. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Built a hello world app using the CLI > > >
Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 3)
+1 Built and ran on - Android 5.0.2 on Nexus 7 - iOS simulator On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill wrote: > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > Repos ready to be released have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 3.8.0 (5e572b6bd2) > > Upon a successful vote I will upload the archive to dist/ and publish it > to NPM. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Built a hello world app using the CLI >
[Vote] 3.8.0 Cordova App Hello World Release (attempt 3)
Please review and vote on this 3.8.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8645 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 The package was published from its corresponding git tag: cordova-app-hello-world: 3.8.0 (5e572b6bd2) Upon a successful vote I will upload the archive to dist/ and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built a hello world app using the CLI
Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)
Going to redo this vote one more time due to unsafe-eval being added by default to the csp. This vote has failed. On Fri, Mar 13, 2015 at 8:47 AM, Andrew Grieve wrote: > +1 > > On Fri, Mar 13, 2015 at 11:40 AM, Mark Koudritsky > wrote: > > > +1 > > > > Built and ran the app on iOS simulator and Android on Nexus 7. > > > > On Fri, Mar 13, 2015 at 10:41 AM, Sergey Grebnov (Akvelon) < > > v-seg...@microsoft.com> wrote: > > > > > I vote +1 > > > > > > * Verified that app can be built and ran (android, windows, wp8) > > > > > > Thx! > > > Sergey > > > -Original Message- > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > Sent: Friday, March 13, 2015 2:22 AM > > > To: dev@cordova.apache.org > > > Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2) > > > > > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > > > > > Repos ready to be released have been published to > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > > > > > The package was published from its corresponding git tag: > > > cordova-app-hello-world: 3.8.0 (79448fd995) > > > > > > Upon a successful vote I will upload the archive to dist/ and publish > it > > > to NPM. > > > > > > Voting guidelines: > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and subdependencies > > > have Apache-compatible licenses > > > * Built a hello world app using the CLI > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > >
Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)
+1 On Fri, Mar 13, 2015 at 11:40 AM, Mark Koudritsky wrote: > +1 > > Built and ran the app on iOS simulator and Android on Nexus 7. > > On Fri, Mar 13, 2015 at 10:41 AM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > I vote +1 > > > > * Verified that app can be built and ran (android, windows, wp8) > > > > Thx! > > Sergey > > -Original Message- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Friday, March 13, 2015 2:22 AM > > To: dev@cordova.apache.org > > Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2) > > > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 3.8.0 (79448fd995) > > > > Upon a successful vote I will upload the archive to dist/ and publish it > > to NPM. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Built a hello world app using the CLI > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)
+1 Built and ran the app on iOS simulator and Android on Nexus 7. On Fri, Mar 13, 2015 at 10:41 AM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > I vote +1 > > * Verified that app can be built and ran (android, windows, wp8) > > Thx! > Sergey > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Friday, March 13, 2015 2:22 AM > To: dev@cordova.apache.org > Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2) > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > Repos ready to be released have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 3.8.0 (79448fd995) > > Upon a successful vote I will upload the archive to dist/ and publish it > to NPM. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Built a hello world app using the CLI > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
RE: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)
I vote +1 * Verified that app can be built and ran (android, windows, wp8) Thx! Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Friday, March 13, 2015 2:22 AM To: dev@cordova.apache.org Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2) Please review and vote on this 3.8.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8645 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 The package was published from its corresponding git tag: cordova-app-hello-world: 3.8.0 (79448fd995) Upon a successful vote I will upload the archive to dist/ and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built a hello world app using the CLI - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[Vote] 3.8.0 Cordova App Hello World Release (attempt 2)
Please review and vote on this 3.8.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8645 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 The package was published from its corresponding git tag: cordova-app-hello-world: 3.8.0 (79448fd995) Upon a successful vote I will upload the archive to dist/ and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built a hello world app using the CLI
RE: [Vote] 3.8.0 Cordova App Hello World Release
This vote has failed. I'll start a new vote thread. On Mar 11, 2015 6:26 PM, "Parashuram N (MS OPEN TECH)" < panar...@microsoft.com> wrote: > I think if we change the tag, we will have to vote again. However, we > don't have to necessarily wait for 72 hours, for a fix that is small. > > -Original Message- > From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew > Grieve > Sent: Wednesday, March 11, 2015 6:18 PM > To: dev > Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release > > -1 Verified it works on the latest release iOS and Android, but I had a > typo in the CSP string: > > https://github.com/apache/cordova-app-hello-world/commit/18fc9b4eaecd90bf35795c31a7801bc5260b5c6c > > Perhaps we could re-spin with this one fix and leave the vote end period > the same (assuming everyone can still verify based on this one-character > change)? > > On Wed, Mar 11, 2015 at 2:13 PM, Parashuram N (MS OPEN TECH) < > panar...@microsoft.com> wrote: > > > Voting +1 for this. Also did initial tests on Windows, seems to work > > > > * Verified signatures and hashes > > * Verified tags > > * Verified that app can be built and ran under windows, wp8 and android > > platforms > > * Verified release notes: > > + added license header to config.xml > > + added releasenotes.md > > + removed version file, package.json can keep track of version > > + Adding hooks to default app > > + [CB-8597] First attempt at importing cordova-app-hello-world > > via npm dependency > > + Remove jasmine ref > > + Tweak CSP string > > + CB-8295 Add content-security-policy to template > > + Remove target-density and height=device-height from > > + Remove self-closing slashes from since this isn't xhtml > > > > > > -Original Message- > > From: agri...@google.com [mailto:agri...@google.com] On Behalf Of > > Andrew Grieve > > Sent: Wednesday, March 11, 2015 7:16 AM > > To: dev > > Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release > > > > Note that this pulls in the addition of a content-security-policy > > tag. > > Please ensure that this doesn't break your platform when voting. > > > > On Tue, Mar 10, 2015 at 7:30 PM, Steven Gill > > wrote: > > > > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > > > > > Repos ready to be released have been published to > > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > > > > > The package was published from its corresponding git tag: > > > cordova-app-hello-world: 3.8.0 (0b55140d09) > > > > > > Upon a successful vote I will upload the archive to dist/ and > > > publish it to NPM. > > > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voti > > > ng > > > .md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Built a hello world app using the CLI > > > > > >
RE: [Vote] 3.8.0 Cordova App Hello World Release
Voting +1 for this. Also did initial tests on Windows, seems to work • Verified signatures and hashes • Verified tags • Verified that app can be built and ran under windows, wp8 and android platforms • Verified release notes: + added license header to config.xml + added releasenotes.md + removed version file, package.json can keep track of version + Adding hooks to default app + [CB-8597] First attempt at importing cordova-app-hello-world via npm dependency + Remove jasmine ref + Tweak CSP string + CB-8295 Add content-security-policy to template + Remove target-density and height=device-height from + Remove self-closing slashes from since this isn't xhtml -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, March 11, 2015 7:16 AM To: dev Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release Note that this pulls in the addition of a content-security-policy tag. Please ensure that this doesn't break your platform when voting. On Tue, Mar 10, 2015 at 7:30 PM, Steven Gill wrote: > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > Repos ready to be released have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 3.8.0 (0b55140d09) > > Upon a successful vote I will upload the archive to dist/ and publish > it to NPM. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > .md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Built a hello world app using the CLI >
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Perfect. Thanks Steve. On Mon, Mar 9, 2015 at 7:46 PM, Steven Gill wrote: > Release steps: > > https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md > > I will have to run through a release to see if I got it all right. > > Okay, I'm going to merge the copy-from-app-hello-world branch into master > and start a vote thread! Lets hold off on merging the cordova-lib changes > into master until cordova-app-hello-world gets released. This way we won't > have failures on master according to travis. > > Sound good? > > On Fri, Mar 6, 2015 at 4:30 PM, Nikhil Khandelwal > wrote: > > > Thanks for making the change to make it compatible. I took a brief look > at > > your changes and they look good. > > > > Thanks, > > Nikhil > > > > > > -Original Message- > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > Mocny > > Sent: Friday, March 6, 2015 1:12 PM > > To: Steven Gill > > Cc: Michal Mocny; Andrew Grieve; dev > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > adding as dependency of cordova-lib > > > > Agreed. > > > > Everything is upstream on the branch. The package.json wasn't fully > > thought out, so please peak at it. Ping me if you need anything, I'll > > rebase cordova-lib and move to master when you are done. > > > > Thanks Steve. > > > > On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill > > wrote: > > > > > Sure. I can make the changes to release process + coho for it. > > > > > > I imagine it won't be released often, so it might be best give > > > app-hello-world its own release process instead of tying it into > > > tools, platforms or plugins release. > > > On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > > > > > >> (Sorry for all the messages) > > >> > > >> Fixed all the remaining breaks, and now all tests pass without > > >> modification and cordova-cli doesn't need changes. > > >> > > >> However, there is a new npm dependency on cordova-app-hello-word from > > >> cordova-lib. We will need to release that to npm before publishing > > >> the next tools release. > > >> > > >> Steve/Andrew, I will attempt to update coho etc, but I'm not sure of > > >> all the places to update release instructions for this new thing, nor > > >> am I sure of all the licensing requirements. Care to advise / help? > > >> > > >> Thanks! > > >> -Michal > > >> > > >> On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny > > >> wrote: > > >> > > >>> Updated as described. > > >>> > > >>> Now you no longer need to use the branch of cordova-cli, so I'm > > >>> pretty sure this is 100% compat. Huzzah. > > >>> > > >>> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny > > >>> wrote: > > >>> > > >>>> I wanted to originally, but you can --copy-from a www/ only (no > > >>>> config.xml), and then we need a template. If I change cordova-lib > > >>>> to depend on app-hello-world then we can remove it. Another reason > > to do so. > > >>>> > > >>>> -Michal > > >>>> > > >>>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve > > >>>> > > >>>> wrote: > > >>>> > > >>>>> Can we move the config.xml template out of cordova-lib/templates > > >>>>> and into app-hello-world as a part of this? > > >>>>> > > >>>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny > > >>>>> wrote: > > >>>>> > > >>>>> > The current breaking change is that you cannot create a new > > >>>>> > project > > >>>>> using > > >>>>> > cordova-lib directly, without providing a project template to > > >>>>> > import > > >>>>> from. > > >>>>> > cordova-cli works as it always has, and will provide the > > >>>>> app-hello-world > > >>>>> > as a default if you do not use --copy-from / --link-to. > > >>>>> > > > >>>>> > However, writing that explanation out now, I realize I could
RE: [Vote] 3.8.0 Cordova App Hello World Release
I think if we change the tag, we will have to vote again. However, we don’t have to necessarily wait for 72 hours, for a fix that is small. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, March 11, 2015 6:18 PM To: dev Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release -1 Verified it works on the latest release iOS and Android, but I had a typo in the CSP string: https://github.com/apache/cordova-app-hello-world/commit/18fc9b4eaecd90bf35795c31a7801bc5260b5c6c Perhaps we could re-spin with this one fix and leave the vote end period the same (assuming everyone can still verify based on this one-character change)? On Wed, Mar 11, 2015 at 2:13 PM, Parashuram N (MS OPEN TECH) < panar...@microsoft.com> wrote: > Voting +1 for this. Also did initial tests on Windows, seems to work > > • Verified signatures and hashes > • Verified tags > • Verified that app can be built and ran under windows, wp8 and android > platforms > • Verified release notes: > + added license header to config.xml > + added releasenotes.md > + removed version file, package.json can keep track of version > + Adding hooks to default app > + [CB-8597] First attempt at importing cordova-app-hello-world > via npm dependency > + Remove jasmine ref > + Tweak CSP string > + CB-8295 Add content-security-policy to template > + Remove target-density and height=device-height from > + Remove self-closing slashes from since this isn't xhtml > > > -Original Message- > From: agri...@google.com [mailto:agri...@google.com] On Behalf Of > Andrew Grieve > Sent: Wednesday, March 11, 2015 7:16 AM > To: dev > Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release > > Note that this pulls in the addition of a content-security-policy > tag. > Please ensure that this doesn't break your platform when voting. > > On Tue, Mar 10, 2015 at 7:30 PM, Steven Gill > wrote: > > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 3.8.0 (0b55140d09) > > > > Upon a successful vote I will upload the archive to dist/ and > > publish it to NPM. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release-voti > > ng > > .md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Built a hello world app using the CLI > > >
Re: [Vote] 3.8.0 Cordova App Hello World Release
-1 Verified it works on the latest release iOS and Android, but I had a typo in the CSP string: https://github.com/apache/cordova-app-hello-world/commit/18fc9b4eaecd90bf35795c31a7801bc5260b5c6c Perhaps we could re-spin with this one fix and leave the vote end period the same (assuming everyone can still verify based on this one-character change)? On Wed, Mar 11, 2015 at 2:13 PM, Parashuram N (MS OPEN TECH) < panar...@microsoft.com> wrote: > Voting +1 for this. Also did initial tests on Windows, seems to work > > • Verified signatures and hashes > • Verified tags > • Verified that app can be built and ran under windows, wp8 and android > platforms > • Verified release notes: > + added license header to config.xml > + added releasenotes.md > + removed version file, package.json can keep track of version > + Adding hooks to default app > + [CB-8597] First attempt at importing cordova-app-hello-world via > npm dependency > + Remove jasmine ref > + Tweak CSP string > + CB-8295 Add content-security-policy to template > + Remove target-density and height=device-height from > + Remove self-closing slashes from since this isn't xhtml > > > -Original Message- > From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew > Grieve > Sent: Wednesday, March 11, 2015 7:16 AM > To: dev > Subject: Re: [Vote] 3.8.0 Cordova App Hello World Release > > Note that this pulls in the addition of a content-security-policy > tag. > Please ensure that this doesn't break your platform when voting. > > On Tue, Mar 10, 2015 at 7:30 PM, Steven Gill > wrote: > > > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > > > Repos ready to be released have been published to > > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > > > The package was published from its corresponding git tag: > > cordova-app-hello-world: 3.8.0 (0b55140d09) > > > > Upon a successful vote I will upload the archive to dist/ and publish > > it to NPM. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > > .md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Built a hello world app using the CLI > > >
Re: [Vote] 3.8.0 Cordova App Hello World Release
Note that this pulls in the addition of a content-security-policy tag. Please ensure that this doesn't break your platform when voting. On Tue, Mar 10, 2015 at 7:30 PM, Steven Gill wrote: > Please review and vote on this 3.8.0 Cordova App Hello World Release. > > Release issue: https://issues.apache.org/jira/browse/CB-8645 > > Repos ready to be released have been published to > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 > > The package was published from its corresponding git tag: > cordova-app-hello-world: 3.8.0 (0b55140d09) > > Upon a successful vote I will upload the archive to dist/ and publish it > to NPM. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Built a hello world app using the CLI >
[Vote] 3.8.0 Cordova App Hello World Release
Please review and vote on this 3.8.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8645 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 The package was published from its corresponding git tag: cordova-app-hello-world: 3.8.0 (0b55140d09) Upon a successful vote I will upload the archive to dist/ and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built a hello world app using the CLI
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Release steps: https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md I will have to run through a release to see if I got it all right. Okay, I'm going to merge the copy-from-app-hello-world branch into master and start a vote thread! Lets hold off on merging the cordova-lib changes into master until cordova-app-hello-world gets released. This way we won't have failures on master according to travis. Sound good? On Fri, Mar 6, 2015 at 4:30 PM, Nikhil Khandelwal wrote: > Thanks for making the change to make it compatible. I took a brief look at > your changes and they look good. > > Thanks, > Nikhil > > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Friday, March 6, 2015 1:12 PM > To: Steven Gill > Cc: Michal Mocny; Andrew Grieve; dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Agreed. > > Everything is upstream on the branch. The package.json wasn't fully > thought out, so please peak at it. Ping me if you need anything, I'll > rebase cordova-lib and move to master when you are done. > > Thanks Steve. > > On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill > wrote: > > > Sure. I can make the changes to release process + coho for it. > > > > I imagine it won't be released often, so it might be best give > > app-hello-world its own release process instead of tying it into > > tools, platforms or plugins release. > > On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > > > >> (Sorry for all the messages) > >> > >> Fixed all the remaining breaks, and now all tests pass without > >> modification and cordova-cli doesn't need changes. > >> > >> However, there is a new npm dependency on cordova-app-hello-word from > >> cordova-lib. We will need to release that to npm before publishing > >> the next tools release. > >> > >> Steve/Andrew, I will attempt to update coho etc, but I'm not sure of > >> all the places to update release instructions for this new thing, nor > >> am I sure of all the licensing requirements. Care to advise / help? > >> > >> Thanks! > >> -Michal > >> > >> On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny > >> wrote: > >> > >>> Updated as described. > >>> > >>> Now you no longer need to use the branch of cordova-cli, so I'm > >>> pretty sure this is 100% compat. Huzzah. > >>> > >>> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny > >>> wrote: > >>> > >>>> I wanted to originally, but you can --copy-from a www/ only (no > >>>> config.xml), and then we need a template. If I change cordova-lib > >>>> to depend on app-hello-world then we can remove it. Another reason > to do so. > >>>> > >>>> -Michal > >>>> > >>>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve > >>>> > >>>> wrote: > >>>> > >>>>> Can we move the config.xml template out of cordova-lib/templates > >>>>> and into app-hello-world as a part of this? > >>>>> > >>>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny > >>>>> wrote: > >>>>> > >>>>> > The current breaking change is that you cannot create a new > >>>>> > project > >>>>> using > >>>>> > cordova-lib directly, without providing a project template to > >>>>> > import > >>>>> from. > >>>>> > cordova-cli works as it always has, and will provide the > >>>>> app-hello-world > >>>>> > as a default if you do not use --copy-from / --link-to. > >>>>> > > >>>>> > However, writing that explanation out now, I realize I could > >>>>> > just > >>>>> change > >>>>> > cordova-lib to be the one to depend on cordova-app-hello-world > >>>>> > and > >>>>> do the > >>>>> > defaulting there, and not break compatibility. I think I > >>>>> > originally envisioned the cordova-lib script to be more > >>>>> > "primitive", but its > >>>>> already > >>>>> > doing a tremendous amount of input handling and backwards comp
RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Thanks for making the change to make it compatible. I took a brief look at your changes and they look good. Thanks, Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Friday, March 6, 2015 1:12 PM To: Steven Gill Cc: Michal Mocny; Andrew Grieve; dev Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib Agreed. Everything is upstream on the branch. The package.json wasn't fully thought out, so please peak at it. Ping me if you need anything, I'll rebase cordova-lib and move to master when you are done. Thanks Steve. On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill wrote: > Sure. I can make the changes to release process + coho for it. > > I imagine it won't be released often, so it might be best give > app-hello-world its own release process instead of tying it into > tools, platforms or plugins release. > On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > >> (Sorry for all the messages) >> >> Fixed all the remaining breaks, and now all tests pass without >> modification and cordova-cli doesn't need changes. >> >> However, there is a new npm dependency on cordova-app-hello-word from >> cordova-lib. We will need to release that to npm before publishing >> the next tools release. >> >> Steve/Andrew, I will attempt to update coho etc, but I'm not sure of >> all the places to update release instructions for this new thing, nor >> am I sure of all the licensing requirements. Care to advise / help? >> >> Thanks! >> -Michal >> >> On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny >> wrote: >> >>> Updated as described. >>> >>> Now you no longer need to use the branch of cordova-cli, so I'm >>> pretty sure this is 100% compat. Huzzah. >>> >>> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny >>> wrote: >>> >>>> I wanted to originally, but you can --copy-from a www/ only (no >>>> config.xml), and then we need a template. If I change cordova-lib >>>> to depend on app-hello-world then we can remove it. Another reason to do >>>> so. >>>> >>>> -Michal >>>> >>>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve >>>> >>>> wrote: >>>> >>>>> Can we move the config.xml template out of cordova-lib/templates >>>>> and into app-hello-world as a part of this? >>>>> >>>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny >>>>> wrote: >>>>> >>>>> > The current breaking change is that you cannot create a new >>>>> > project >>>>> using >>>>> > cordova-lib directly, without providing a project template to >>>>> > import >>>>> from. >>>>> > cordova-cli works as it always has, and will provide the >>>>> app-hello-world >>>>> > as a default if you do not use --copy-from / --link-to. >>>>> > >>>>> > However, writing that explanation out now, I realize I could >>>>> > just >>>>> change >>>>> > cordova-lib to be the one to depend on cordova-app-hello-world >>>>> > and >>>>> do the >>>>> > defaulting there, and not break compatibility. I think I >>>>> > originally envisioned the cordova-lib script to be more >>>>> > "primitive", but its >>>>> already >>>>> > doing a tremendous amount of input handling and backwards compat >>>>> > workarounds. Probably I can just make this adjustment. >>>>> > >>>>> > -Michal >>>>> > >>>>> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >>>>> nikhi...@microsoft.com> >>>>> > wrote: >>>>> > >>>>> > > Michal: I'm new to this area - can you please elaborate why >>>>> > > this >>>>> change >>>>> > > could potentially break downstream distributions? IS there an >>>>> > > API >>>>> change? >>>>> > > >>>>> > > -Nikhil >>>>> > > >>>>> > > -Original Message- >>>>> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf >>>>> > > Of >>>>
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Agreed. Everything is upstream on the branch. The package.json wasn't fully thought out, so please peak at it. Ping me if you need anything, I'll rebase cordova-lib and move to master when you are done. Thanks Steve. On Fri, Mar 6, 2015 at 4:08 PM, Steven Gill wrote: > Sure. I can make the changes to release process + coho for it. > > I imagine it won't be released often, so it might be best give > app-hello-world its own release process instead of tying it into tools, > platforms or plugins release. > On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > >> (Sorry for all the messages) >> >> Fixed all the remaining breaks, and now all tests pass without >> modification and cordova-cli doesn't need changes. >> >> However, there is a new npm dependency on cordova-app-hello-word from >> cordova-lib. We will need to release that to npm before publishing the >> next tools release. >> >> Steve/Andrew, I will attempt to update coho etc, but I'm not sure of all >> the places to update release instructions for this new thing, nor am I sure >> of all the licensing requirements. Care to advise / help? >> >> Thanks! >> -Michal >> >> On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny >> wrote: >> >>> Updated as described. >>> >>> Now you no longer need to use the branch of cordova-cli, so I'm pretty >>> sure this is 100% compat. Huzzah. >>> >>> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny >>> wrote: >>> >>>> I wanted to originally, but you can --copy-from a www/ only (no >>>> config.xml), and then we need a template. If I change cordova-lib to >>>> depend on app-hello-world then we can remove it. Another reason to do so. >>>> >>>> -Michal >>>> >>>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve >>>> wrote: >>>> >>>>> Can we move the config.xml template out of cordova-lib/templates and >>>>> into >>>>> app-hello-world as a part of this? >>>>> >>>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny >>>>> wrote: >>>>> >>>>> > The current breaking change is that you cannot create a new project >>>>> using >>>>> > cordova-lib directly, without providing a project template to import >>>>> from. >>>>> > cordova-cli works as it always has, and will provide the >>>>> app-hello-world >>>>> > as a default if you do not use --copy-from / --link-to. >>>>> > >>>>> > However, writing that explanation out now, I realize I could just >>>>> change >>>>> > cordova-lib to be the one to depend on cordova-app-hello-world and >>>>> do the >>>>> > defaulting there, and not break compatibility. I think I originally >>>>> > envisioned the cordova-lib script to be more "primitive", but its >>>>> already >>>>> > doing a tremendous amount of input handling and backwards compat >>>>> > workarounds. Probably I can just make this adjustment. >>>>> > >>>>> > -Michal >>>>> > >>>>> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >>>>> nikhi...@microsoft.com> >>>>> > wrote: >>>>> > >>>>> > > Michal: I'm new to this area - can you please elaborate why this >>>>> change >>>>> > > could potentially break downstream distributions? IS there an API >>>>> change? >>>>> > > >>>>> > > -Nikhil >>>>> > > >>>>> > > -Original Message- >>>>> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >>>>> Michal >>>>> > > Mocny >>>>> > > Sent: Thursday, March 5, 2015 1:12 PM >>>>> > > To: dev >>>>> > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm >>>>> and >>>>> > > adding as dependency of cordova-lib >>>>> > > >>>>> > > Alight, remote branches (named copy-from-app-hello-world) are >>>>> created for >>>>> > > cordova-lib, cordova-cli, and cordova-app-hello-world. >>>>> > > >>>>> > > There are still 2 failing cordov
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Sure. I can make the changes to release process + coho for it. I imagine it won't be released often, so it might be best give app-hello-world its own release process instead of tying it into tools, platforms or plugins release. On Mar 6, 2015 1:04 PM, "Michal Mocny" wrote: > (Sorry for all the messages) > > Fixed all the remaining breaks, and now all tests pass without > modification and cordova-cli doesn't need changes. > > However, there is a new npm dependency on cordova-app-hello-word from > cordova-lib. We will need to release that to npm before publishing the > next tools release. > > Steve/Andrew, I will attempt to update coho etc, but I'm not sure of all > the places to update release instructions for this new thing, nor am I sure > of all the licensing requirements. Care to advise / help? > > Thanks! > -Michal > > On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny wrote: > >> Updated as described. >> >> Now you no longer need to use the branch of cordova-cli, so I'm pretty >> sure this is 100% compat. Huzzah. >> >> On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny >> wrote: >> >>> I wanted to originally, but you can --copy-from a www/ only (no >>> config.xml), and then we need a template. If I change cordova-lib to >>> depend on app-hello-world then we can remove it. Another reason to do so. >>> >>> -Michal >>> >>> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve >>> wrote: >>> >>>> Can we move the config.xml template out of cordova-lib/templates and >>>> into >>>> app-hello-world as a part of this? >>>> >>>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny >>>> wrote: >>>> >>>> > The current breaking change is that you cannot create a new project >>>> using >>>> > cordova-lib directly, without providing a project template to import >>>> from. >>>> > cordova-cli works as it always has, and will provide the >>>> app-hello-world >>>> > as a default if you do not use --copy-from / --link-to. >>>> > >>>> > However, writing that explanation out now, I realize I could just >>>> change >>>> > cordova-lib to be the one to depend on cordova-app-hello-world and do >>>> the >>>> > defaulting there, and not break compatibility. I think I originally >>>> > envisioned the cordova-lib script to be more "primitive", but its >>>> already >>>> > doing a tremendous amount of input handling and backwards compat >>>> > workarounds. Probably I can just make this adjustment. >>>> > >>>> > -Michal >>>> > >>>> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >>>> nikhi...@microsoft.com> >>>> > wrote: >>>> > >>>> > > Michal: I'm new to this area - can you please elaborate why this >>>> change >>>> > > could potentially break downstream distributions? IS there an API >>>> change? >>>> > > >>>> > > -Nikhil >>>> > > >>>> > > -Original Message- >>>> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >>>> Michal >>>> > > Mocny >>>> > > Sent: Thursday, March 5, 2015 1:12 PM >>>> > > To: dev >>>> > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and >>>> > > adding as dependency of cordova-lib >>>> > > >>>> > > Alight, remote branches (named copy-from-app-hello-world) are >>>> created for >>>> > > cordova-lib, cordova-cli, and cordova-app-hello-world. >>>> > > >>>> > > There are still 2 failing cordova-lib tests, but I'm working to >>>> resolve >>>> > > that. My actual end-to-end tests appear to be working with all use >>>> > cases. >>>> > > >>>> > > Please, please: if you develop a downstream distribution that uses >>>> > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try >>>> this >>>> > > out and see if it works for you. I will do so for cca. Please >>>> forward >>>> > > this to anyone on your team responsible for this work! >>>> > > >>>> > > -Michal >>>>
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
(Sorry for all the messages) Fixed all the remaining breaks, and now all tests pass without modification and cordova-cli doesn't need changes. However, there is a new npm dependency on cordova-app-hello-word from cordova-lib. We will need to release that to npm before publishing the next tools release. Steve/Andrew, I will attempt to update coho etc, but I'm not sure of all the places to update release instructions for this new thing, nor am I sure of all the licensing requirements. Care to advise / help? Thanks! -Michal On Fri, Mar 6, 2015 at 11:30 AM, Michal Mocny wrote: > Updated as described. > > Now you no longer need to use the branch of cordova-cli, so I'm pretty > sure this is 100% compat. Huzzah. > > On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny wrote: > >> I wanted to originally, but you can --copy-from a www/ only (no >> config.xml), and then we need a template. If I change cordova-lib to >> depend on app-hello-world then we can remove it. Another reason to do so. >> >> -Michal >> >> On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve >> wrote: >> >>> Can we move the config.xml template out of cordova-lib/templates and into >>> app-hello-world as a part of this? >>> >>> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny >>> wrote: >>> >>> > The current breaking change is that you cannot create a new project >>> using >>> > cordova-lib directly, without providing a project template to import >>> from. >>> > cordova-cli works as it always has, and will provide the >>> app-hello-world >>> > as a default if you do not use --copy-from / --link-to. >>> > >>> > However, writing that explanation out now, I realize I could just >>> change >>> > cordova-lib to be the one to depend on cordova-app-hello-world and do >>> the >>> > defaulting there, and not break compatibility. I think I originally >>> > envisioned the cordova-lib script to be more "primitive", but its >>> already >>> > doing a tremendous amount of input handling and backwards compat >>> > workarounds. Probably I can just make this adjustment. >>> > >>> > -Michal >>> > >>> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >>> nikhi...@microsoft.com> >>> > wrote: >>> > >>> > > Michal: I'm new to this area - can you please elaborate why this >>> change >>> > > could potentially break downstream distributions? IS there an API >>> change? >>> > > >>> > > -Nikhil >>> > > >>> > > -Original Message- >>> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >>> Michal >>> > > Mocny >>> > > Sent: Thursday, March 5, 2015 1:12 PM >>> > > To: dev >>> > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and >>> > > adding as dependency of cordova-lib >>> > > >>> > > Alight, remote branches (named copy-from-app-hello-world) are >>> created for >>> > > cordova-lib, cordova-cli, and cordova-app-hello-world. >>> > > >>> > > There are still 2 failing cordova-lib tests, but I'm working to >>> resolve >>> > > that. My actual end-to-end tests appear to be working with all use >>> > cases. >>> > > >>> > > Please, please: if you develop a downstream distribution that uses >>> > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try >>> this >>> > > out and see if it works for you. I will do so for cca. Please >>> forward >>> > > this to anyone on your team responsible for this work! >>> > > >>> > > -Michal >>> > > >>> > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal < >>> > nikhi...@microsoft.com> >>> > > wrote: >>> > > >>> > > > I like moving this to npm because Apache Git as a distribution >>> > > > mechanism for the hello world app has been less reliable than >>> desirable >>> > > in the past. >>> > > > >>> > > > Thanks, >>> > > > Nikhil >>> > > > >>> > > > >>> > > > -Original Message- >>> > > > From: mmo...@google.com [mailto:mmo...@google.com] On Beh
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Updated as described. Now you no longer need to use the branch of cordova-cli, so I'm pretty sure this is 100% compat. Huzzah. On Fri, Mar 6, 2015 at 11:06 AM, Michal Mocny wrote: > I wanted to originally, but you can --copy-from a www/ only (no > config.xml), and then we need a template. If I change cordova-lib to > depend on app-hello-world then we can remove it. Another reason to do so. > > -Michal > > On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve > wrote: > >> Can we move the config.xml template out of cordova-lib/templates and into >> app-hello-world as a part of this? >> >> On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny wrote: >> >> > The current breaking change is that you cannot create a new project >> using >> > cordova-lib directly, without providing a project template to import >> from. >> > cordova-cli works as it always has, and will provide the >> app-hello-world >> > as a default if you do not use --copy-from / --link-to. >> > >> > However, writing that explanation out now, I realize I could just change >> > cordova-lib to be the one to depend on cordova-app-hello-world and do >> the >> > defaulting there, and not break compatibility. I think I originally >> > envisioned the cordova-lib script to be more "primitive", but its >> already >> > doing a tremendous amount of input handling and backwards compat >> > workarounds. Probably I can just make this adjustment. >> > >> > -Michal >> > >> > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < >> nikhi...@microsoft.com> >> > wrote: >> > >> > > Michal: I'm new to this area - can you please elaborate why this >> change >> > > could potentially break downstream distributions? IS there an API >> change? >> > > >> > > -Nikhil >> > > >> > > -----Original Message- >> > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >> Michal >> > > Mocny >> > > Sent: Thursday, March 5, 2015 1:12 PM >> > > To: dev >> > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and >> > > adding as dependency of cordova-lib >> > > >> > > Alight, remote branches (named copy-from-app-hello-world) are created >> for >> > > cordova-lib, cordova-cli, and cordova-app-hello-world. >> > > >> > > There are still 2 failing cordova-lib tests, but I'm working to >> resolve >> > > that. My actual end-to-end tests appear to be working with all use >> > cases. >> > > >> > > Please, please: if you develop a downstream distribution that uses >> > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try >> this >> > > out and see if it works for you. I will do so for cca. Please >> forward >> > > this to anyone on your team responsible for this work! >> > > >> > > -Michal >> > > >> > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal < >> > nikhi...@microsoft.com> >> > > wrote: >> > > >> > > > I like moving this to npm because Apache Git as a distribution >> > > > mechanism for the hello world app has been less reliable than >> desirable >> > > in the past. >> > > > >> > > > Thanks, >> > > > Nikhil >> > > > >> > > > >> > > > -Original Message- >> > > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of >> Michal >> > > > Mocny >> > > > Sent: Tuesday, March 3, 2015 12:08 PM >> > > > To: Michal Mocny >> > > > Cc: dev >> > > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and >> > > > adding as dependency of cordova-lib >> > > > >> > > > Pushed first attempt to remote branches: >> > > > - >> https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world >> > > > - >> > > > >> > > > >> https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h >> > > > ello-world >> > > > >> > > > Cleaning up cordova-lib is strictly required, though I think we >> should >> > > > still take the opportunity to do so. >> > > > >> > > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mo
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
I wanted to originally, but you can --copy-from a www/ only (no config.xml), and then we need a template. If I change cordova-lib to depend on app-hello-world then we can remove it. Another reason to do so. -Michal On Thu, Mar 5, 2015 at 10:17 PM, Andrew Grieve wrote: > Can we move the config.xml template out of cordova-lib/templates and into > app-hello-world as a part of this? > > On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny wrote: > > > The current breaking change is that you cannot create a new project using > > cordova-lib directly, without providing a project template to import > from. > > cordova-cli works as it always has, and will provide the app-hello-world > > as a default if you do not use --copy-from / --link-to. > > > > However, writing that explanation out now, I realize I could just change > > cordova-lib to be the one to depend on cordova-app-hello-world and do the > > defaulting there, and not break compatibility. I think I originally > > envisioned the cordova-lib script to be more "primitive", but its already > > doing a tremendous amount of input handling and backwards compat > > workarounds. Probably I can just make this adjustment. > > > > -Michal > > > > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal < > nikhi...@microsoft.com> > > wrote: > > > > > Michal: I'm new to this area - can you please elaborate why this > change > > > could potentially break downstream distributions? IS there an API > change? > > > > > > -Nikhil > > > > > > -Original Message- > > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > > Mocny > > > Sent: Thursday, March 5, 2015 1:12 PM > > > To: dev > > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > > adding as dependency of cordova-lib > > > > > > Alight, remote branches (named copy-from-app-hello-world) are created > for > > > cordova-lib, cordova-cli, and cordova-app-hello-world. > > > > > > There are still 2 failing cordova-lib tests, but I'm working to resolve > > > that. My actual end-to-end tests appear to be working with all use > > cases. > > > > > > Please, please: if you develop a downstream distribution that uses > > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try > this > > > out and see if it works for you. I will do so for cca. Please forward > > > this to anyone on your team responsible for this work! > > > > > > -Michal > > > > > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal < > > nikhi...@microsoft.com> > > > wrote: > > > > > > > I like moving this to npm because Apache Git as a distribution > > > > mechanism for the hello world app has been less reliable than > desirable > > > in the past. > > > > > > > > Thanks, > > > > Nikhil > > > > > > > > > > > > -Original Message- > > > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of > Michal > > > > Mocny > > > > Sent: Tuesday, March 3, 2015 12:08 PM > > > > To: Michal Mocny > > > > Cc: dev > > > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > > > adding as dependency of cordova-lib > > > > > > > > Pushed first attempt to remote branches: > > > > - > https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > > > > - > > > > > > > > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > > > > ello-world > > > > > > > > Cleaning up cordova-lib is strictly required, though I think we > should > > > > still take the opportunity to do so. > > > > > > > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny > > > wrote: > > > > > > > > > Jesse, I think not. The platform scripts just copy the bundled > www/ > > > > > (its already included with the platform). > > > > > > > > > > This is only for the top-level project www/ of a cordova-cli > project. > > > > > > > > > > I guess, though, that we could consider changing the platform > create > > > > > scripts to import config.xml's, since they currently do not. This > > > > > may be difficult given that the format is different even though the
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Can we move the config.xml template out of cordova-lib/templates and into app-hello-world as a part of this? On Thu, Mar 5, 2015 at 5:13 PM, Michal Mocny wrote: > The current breaking change is that you cannot create a new project using > cordova-lib directly, without providing a project template to import from. > cordova-cli works as it always has, and will provide the app-hello-world > as a default if you do not use --copy-from / --link-to. > > However, writing that explanation out now, I realize I could just change > cordova-lib to be the one to depend on cordova-app-hello-world and do the > defaulting there, and not break compatibility. I think I originally > envisioned the cordova-lib script to be more "primitive", but its already > doing a tremendous amount of input handling and backwards compat > workarounds. Probably I can just make this adjustment. > > -Michal > > On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal > wrote: > > > Michal: I'm new to this area - can you please elaborate why this change > > could potentially break downstream distributions? IS there an API change? > > > > -Nikhil > > > > -Original Message- > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > Mocny > > Sent: Thursday, March 5, 2015 1:12 PM > > To: dev > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > adding as dependency of cordova-lib > > > > Alight, remote branches (named copy-from-app-hello-world) are created for > > cordova-lib, cordova-cli, and cordova-app-hello-world. > > > > There are still 2 failing cordova-lib tests, but I'm working to resolve > > that. My actual end-to-end tests appear to be working with all use > cases. > > > > Please, please: if you develop a downstream distribution that uses > > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this > > out and see if it works for you. I will do so for cca. Please forward > > this to anyone on your team responsible for this work! > > > > -Michal > > > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal < > nikhi...@microsoft.com> > > wrote: > > > > > I like moving this to npm because Apache Git as a distribution > > > mechanism for the hello world app has been less reliable than desirable > > in the past. > > > > > > Thanks, > > > Nikhil > > > > > > > > > -Original Message- > > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > > Mocny > > > Sent: Tuesday, March 3, 2015 12:08 PM > > > To: Michal Mocny > > > Cc: dev > > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > > adding as dependency of cordova-lib > > > > > > Pushed first attempt to remote branches: > > > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > > > - > > > > > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > > > ello-world > > > > > > Cleaning up cordova-lib is strictly required, though I think we should > > > still take the opportunity to do so. > > > > > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny > > wrote: > > > > > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > > > (its already included with the platform). > > > > > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > > > > > I guess, though, that we could consider changing the platform create > > > > scripts to import config.xml's, since they currently do not. This > > > > may be difficult given that the format is different even though the > > > > name is the same (platform vs project config). > > > > > > > > -Michal > > > > > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse > wrote: > > > > > > > >> +1 > > > >> Does this affect the ability to use an individual platform? > > > >> ie. cordova-ios/bin/create ... > > > >> Will platform create scripts need to change? > > > >> > > > >> > > > >> > > > >> @purplecabbage > > > >> risingj.com > > > >> > > > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny > > > wrote: > > > >> > > > >> > This came up in the context of whitelist discussion, but wanted
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
The current breaking change is that you cannot create a new project using cordova-lib directly, without providing a project template to import from. cordova-cli works as it always has, and will provide the app-hello-world as a default if you do not use --copy-from / --link-to. However, writing that explanation out now, I realize I could just change cordova-lib to be the one to depend on cordova-app-hello-world and do the defaulting there, and not break compatibility. I think I originally envisioned the cordova-lib script to be more "primitive", but its already doing a tremendous amount of input handling and backwards compat workarounds. Probably I can just make this adjustment. -Michal On Thu, Mar 5, 2015 at 4:57 PM, Nikhil Khandelwal wrote: > Michal: I'm new to this area - can you please elaborate why this change > could potentially break downstream distributions? IS there an API change? > > -Nikhil > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Thursday, March 5, 2015 1:12 PM > To: dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Alight, remote branches (named copy-from-app-hello-world) are created for > cordova-lib, cordova-cli, and cordova-app-hello-world. > > There are still 2 failing cordova-lib tests, but I'm working to resolve > that. My actual end-to-end tests appear to be working with all use cases. > > Please, please: if you develop a downstream distribution that uses > cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this > out and see if it works for you. I will do so for cca. Please forward > this to anyone on your team responsible for this work! > > -Michal > > On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal > wrote: > > > I like moving this to npm because Apache Git as a distribution > > mechanism for the hello world app has been less reliable than desirable > in the past. > > > > Thanks, > > Nikhil > > > > > > -Original Message- > > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > > Mocny > > Sent: Tuesday, March 3, 2015 12:08 PM > > To: Michal Mocny > > Cc: dev > > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > > adding as dependency of cordova-lib > > > > Pushed first attempt to remote branches: > > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > > - > > > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > > ello-world > > > > Cleaning up cordova-lib is strictly required, though I think we should > > still take the opportunity to do so. > > > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny > wrote: > > > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > > (its already included with the platform). > > > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > > > I guess, though, that we could consider changing the platform create > > > scripts to import config.xml's, since they currently do not. This > > > may be difficult given that the format is different even though the > > > name is the same (platform vs project config). > > > > > > -Michal > > > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > > > > > >> +1 > > >> Does this affect the ability to use an individual platform? > > >> ie. cordova-ios/bin/create ... > > >> Will platform create scripts need to change? > > >> > > >> > > >> > > >> @purplecabbage > > >> risingj.com > > >> > > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny > > wrote: > > >> > > >> > This came up in the context of whitelist discussion, but wanted > > >> > to > > >> bring it > > >> > to everyones attention. > > >> > > > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 > > >> > > > >> > We would like the default app to support installing the whitelist > > >> > plugin automatically using the new plugin auto-restore feature > > >> > (If you > > >> disagree, > > >> > discuss on the whitelist thread, that is not the topic of this > post). > > >> > > > >> > However, the cordova-lib create script cannot support this > > >> > feature right
RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Michal: I'm new to this area - can you please elaborate why this change could potentially break downstream distributions? IS there an API change? -Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Thursday, March 5, 2015 1:12 PM To: dev Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib Alight, remote branches (named copy-from-app-hello-world) are created for cordova-lib, cordova-cli, and cordova-app-hello-world. There are still 2 failing cordova-lib tests, but I'm working to resolve that. My actual end-to-end tests appear to be working with all use cases. Please, please: if you develop a downstream distribution that uses cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this out and see if it works for you. I will do so for cca. Please forward this to anyone on your team responsible for this work! -Michal On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal wrote: > I like moving this to npm because Apache Git as a distribution > mechanism for the hello world app has been less reliable than desirable in > the past. > > Thanks, > Nikhil > > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Tuesday, March 3, 2015 12:08 PM > To: Michal Mocny > Cc: dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Pushed first attempt to remote branches: > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > - > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-h > ello-world > > Cleaning up cordova-lib is strictly required, though I think we should > still take the opportunity to do so. > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny wrote: > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > (its already included with the platform). > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > I guess, though, that we could consider changing the platform create > > scripts to import config.xml's, since they currently do not. This > > may be difficult given that the format is different even though the > > name is the same (platform vs project config). > > > > -Michal > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > > > >> +1 > >> Does this affect the ability to use an individual platform? > >> ie. cordova-ios/bin/create ... > >> Will platform create scripts need to change? > >> > >> > >> > >> @purplecabbage > >> risingj.com > >> > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny > wrote: > >> > >> > This came up in the context of whitelist discussion, but wanted > >> > to > >> bring it > >> > to everyones attention. > >> > > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 > >> > > >> > We would like the default app to support installing the whitelist > >> > plugin automatically using the new plugin auto-restore feature > >> > (If you > >> disagree, > >> > discuss on the whitelist thread, that is not the topic of this post). > >> > > >> > However, the cordova-lib create script cannot support this > >> > feature right now anyway (that is the topic of this post). I've > >> > outlined in the JIRA > >> how > >> > we could fix that (open to feedback). > >> > > >> > TLDR; --copy-from already supports this, so lets just vastly > >> > simplify cordova-lib create.js to just always do a --copy-from > >> > (or --link-to), > >> and > >> > change cordova-cli to provide the default > >> > --copy-from=./node_modules/cordova-app-hello-world. > >> > > >> > This also implies we can remove our last use of lazy_load from > >> cordova-lib > >> > (minus explicit git clones or platforms/plugins), and npm all the > >> things! > >> > > >> > It also means a semver MAJOR change to cordova-lib that > >> > downstreams directly using cordova-lib's create will need to adjust to. > >> > > >> > Thoughts? > >> > > >> > -Michal > >> > > >> > > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Alight, remote branches (named copy-from-app-hello-world) are created for cordova-lib, cordova-cli, and cordova-app-hello-world. There are still 2 failing cordova-lib tests, but I'm working to resolve that. My actual end-to-end tests appear to be working with all use cases. Please, please: if you develop a downstream distribution that uses cordova-lib directly (PhoneGap, BlackBerry, Ionic, etc), please try this out and see if it works for you. I will do so for cca. Please forward this to anyone on your team responsible for this work! -Michal On Wed, Mar 4, 2015 at 2:21 PM, Nikhil Khandelwal wrote: > I like moving this to npm because Apache Git as a distribution mechanism > for the hello world app has been less reliable than desirable in the past. > > Thanks, > Nikhil > > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Tuesday, March 3, 2015 12:08 PM > To: Michal Mocny > Cc: dev > Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and > adding as dependency of cordova-lib > > Pushed first attempt to remote branches: > - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world > - > > https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world > > Cleaning up cordova-lib is strictly required, though I think we should > still take the opportunity to do so. > > On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny wrote: > > > Jesse, I think not. The platform scripts just copy the bundled www/ > > (its already included with the platform). > > > > This is only for the top-level project www/ of a cordova-cli project. > > > > I guess, though, that we could consider changing the platform create > > scripts to import config.xml's, since they currently do not. This may > > be difficult given that the format is different even though the name > > is the same (platform vs project config). > > > > -Michal > > > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > > > >> +1 > >> Does this affect the ability to use an individual platform? > >> ie. cordova-ios/bin/create ... > >> Will platform create scripts need to change? > >> > >> > >> > >> @purplecabbage > >> risingj.com > >> > >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny > wrote: > >> > >> > This came up in the context of whitelist discussion, but wanted to > >> bring it > >> > to everyones attention. > >> > > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 > >> > > >> > We would like the default app to support installing the whitelist > >> > plugin automatically using the new plugin auto-restore feature (If > >> > you > >> disagree, > >> > discuss on the whitelist thread, that is not the topic of this post). > >> > > >> > However, the cordova-lib create script cannot support this feature > >> > right now anyway (that is the topic of this post). I've outlined > >> > in the JIRA > >> how > >> > we could fix that (open to feedback). > >> > > >> > TLDR; --copy-from already supports this, so lets just vastly > >> > simplify cordova-lib create.js to just always do a --copy-from (or > >> > --link-to), > >> and > >> > change cordova-cli to provide the default > >> > --copy-from=./node_modules/cordova-app-hello-world. > >> > > >> > This also implies we can remove our last use of lazy_load from > >> cordova-lib > >> > (minus explicit git clones or platforms/plugins), and npm all the > >> things! > >> > > >> > It also means a semver MAJOR change to cordova-lib that downstreams > >> > directly using cordova-lib's create will need to adjust to. > >> > > >> > Thoughts? > >> > > >> > -Michal > >> > > >> > > > > >
RE: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
I like moving this to npm because Apache Git as a distribution mechanism for the hello world app has been less reliable than desirable in the past. Thanks, Nikhil -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Tuesday, March 3, 2015 12:08 PM To: Michal Mocny Cc: dev Subject: Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib Pushed first attempt to remote branches: - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world - https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world Cleaning up cordova-lib is strictly required, though I think we should still take the opportunity to do so. On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny wrote: > Jesse, I think not. The platform scripts just copy the bundled www/ > (its already included with the platform). > > This is only for the top-level project www/ of a cordova-cli project. > > I guess, though, that we could consider changing the platform create > scripts to import config.xml's, since they currently do not. This may > be difficult given that the format is different even though the name > is the same (platform vs project config). > > -Michal > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > >> +1 >> Does this affect the ability to use an individual platform? >> ie. cordova-ios/bin/create ... >> Will platform create scripts need to change? >> >> >> >> @purplecabbage >> risingj.com >> >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: >> >> > This came up in the context of whitelist discussion, but wanted to >> bring it >> > to everyones attention. >> > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 >> > >> > We would like the default app to support installing the whitelist >> > plugin automatically using the new plugin auto-restore feature (If >> > you >> disagree, >> > discuss on the whitelist thread, that is not the topic of this post). >> > >> > However, the cordova-lib create script cannot support this feature >> > right now anyway (that is the topic of this post). I've outlined >> > in the JIRA >> how >> > we could fix that (open to feedback). >> > >> > TLDR; --copy-from already supports this, so lets just vastly >> > simplify cordova-lib create.js to just always do a --copy-from (or >> > --link-to), >> and >> > change cordova-cli to provide the default >> > --copy-from=./node_modules/cordova-app-hello-world. >> > >> > This also implies we can remove our last use of lazy_load from >> cordova-lib >> > (minus explicit git clones or platforms/plugins), and npm all the >> things! >> > >> > It also means a semver MAJOR change to cordova-lib that downstreams >> > directly using cordova-lib's create will need to adjust to. >> > >> > Thoughts? >> > >> > -Michal >> > >> > >
Re: Hello!
Hi Rob! Nice to see all the new faces. -Michal On Wed, Mar 4, 2015 at 9:51 AM, Andrew Grieve wrote: > Welcome Rob! > > On Tue, Mar 3, 2015 at 8:30 PM, Shazron wrote: > > > Welcome Rob! > > > > On Tue, Mar 3, 2015 at 4:33 PM, Rob Paveza > > wrote: > > > Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the > > Visual Studio team. I've been working on the Cordova tools for a short > > while, particularly getting a cordova-windows prototype ready to roll out > > with Windows 10 support. I wanted to start getting into the mix and > > getting involved in stuff that IS currently out in the open, so I thought > > I'd say hello! > > > > > > -Rob > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
Re: Hello!
Welcome Rob! On Tue, Mar 3, 2015 at 8:30 PM, Shazron wrote: > Welcome Rob! > > On Tue, Mar 3, 2015 at 4:33 PM, Rob Paveza > wrote: > > Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the > Visual Studio team. I've been working on the Cordova tools for a short > while, particularly getting a cordova-windows prototype ready to roll out > with Windows 10 support. I wanted to start getting into the mix and > getting involved in stuff that IS currently out in the open, so I thought > I'd say hello! > > > > -Rob > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: Hello!
Welcome Rob! On Tue, Mar 3, 2015 at 4:33 PM, Rob Paveza wrote: > Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the Visual > Studio team. I've been working on the Cordova tools for a short while, > particularly getting a cordova-windows prototype ready to roll out with > Windows 10 support. I wanted to start getting into the mix and getting > involved in stuff that IS currently out in the open, so I thought I'd say > hello! > > -Rob > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hello!
Hello, and welcome! @purplecabbage risingj.com On Tue, Mar 3, 2015 at 4:33 PM, Rob Paveza wrote: > Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the > Visual Studio team. I've been working on the Cordova tools for a short > while, particularly getting a cordova-windows prototype ready to roll out > with Windows 10 support. I wanted to start getting into the mix and > getting involved in stuff that IS currently out in the open, so I thought > I'd say hello! > > -Rob > >
Hello!
Hello! I'm Rob Paveza. I'm a software engineer at Microsoft, on the Visual Studio team. I've been working on the Cordova tools for a short while, particularly getting a cordova-windows prototype ready to roll out with Windows 10 support. I wanted to start getting into the mix and getting involved in stuff that IS currently out in the open, so I thought I'd say hello! -Rob
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Pushed first attempt to remote branches: - https://github.com/Apache/cordova-cli/tree/copy-from-app-hello-world - https://github.com/Apache/cordova-app-hello-world/tree/copy-from-app-hello-world Cleaning up cordova-lib is strictly required, though I think we should still take the opportunity to do so. On Tue, Mar 3, 2015 at 2:46 PM, Michal Mocny wrote: > Jesse, I think not. The platform scripts just copy the bundled www/ (its > already included with the platform). > > This is only for the top-level project www/ of a cordova-cli project. > > I guess, though, that we could consider changing the platform create > scripts to import config.xml's, since they currently do not. This may be > difficult given that the format is different even though the name is the > same (platform vs project config). > > -Michal > > On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > >> +1 >> Does this affect the ability to use an individual platform? >> ie. cordova-ios/bin/create ... >> Will platform create scripts need to change? >> >> >> >> @purplecabbage >> risingj.com >> >> On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: >> >> > This came up in the context of whitelist discussion, but wanted to >> bring it >> > to everyones attention. >> > >> > JIRA: https://issues.apache.org/jira/browse/CB-8597 >> > >> > We would like the default app to support installing the whitelist plugin >> > automatically using the new plugin auto-restore feature (If you >> disagree, >> > discuss on the whitelist thread, that is not the topic of this post). >> > >> > However, the cordova-lib create script cannot support this feature right >> > now anyway (that is the topic of this post). I've outlined in the JIRA >> how >> > we could fix that (open to feedback). >> > >> > TLDR; --copy-from already supports this, so lets just vastly simplify >> > cordova-lib create.js to just always do a --copy-from (or --link-to), >> and >> > change cordova-cli to provide the default >> > --copy-from=./node_modules/cordova-app-hello-world. >> > >> > This also implies we can remove our last use of lazy_load from >> cordova-lib >> > (minus explicit git clones or platforms/plugins), and npm all the >> things! >> > >> > It also means a semver MAJOR change to cordova-lib that downstreams >> > directly using cordova-lib's create will need to adjust to. >> > >> > Thoughts? >> > >> > -Michal >> > >> > >
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
Jesse, I think not. The platform scripts just copy the bundled www/ (its already included with the platform). This is only for the top-level project www/ of a cordova-cli project. I guess, though, that we could consider changing the platform create scripts to import config.xml's, since they currently do not. This may be difficult given that the format is different even though the name is the same (platform vs project config). -Michal On Tue, Mar 3, 2015 at 2:40 PM, Jesse wrote: > +1 > Does this affect the ability to use an individual platform? > ie. cordova-ios/bin/create ... > Will platform create scripts need to change? > > > > @purplecabbage > risingj.com > > On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: > > > This came up in the context of whitelist discussion, but wanted to bring > it > > to everyones attention. > > > > JIRA: https://issues.apache.org/jira/browse/CB-8597 > > > > We would like the default app to support installing the whitelist plugin > > automatically using the new plugin auto-restore feature (If you disagree, > > discuss on the whitelist thread, that is not the topic of this post). > > > > However, the cordova-lib create script cannot support this feature right > > now anyway (that is the topic of this post). I've outlined in the JIRA > how > > we could fix that (open to feedback). > > > > TLDR; --copy-from already supports this, so lets just vastly simplify > > cordova-lib create.js to just always do a --copy-from (or --link-to), and > > change cordova-cli to provide the default > > --copy-from=./node_modules/cordova-app-hello-world. > > > > This also implies we can remove our last use of lazy_load from > cordova-lib > > (minus explicit git clones or platforms/plugins), and npm all the things! > > > > It also means a semver MAJOR change to cordova-lib that downstreams > > directly using cordova-lib's create will need to adjust to. > > > > Thoughts? > > > > -Michal > > >
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
+1 Does this affect the ability to use an individual platform? ie. cordova-ios/bin/create ... Will platform create scripts need to change? @purplecabbage risingj.com On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: > This came up in the context of whitelist discussion, but wanted to bring it > to everyones attention. > > JIRA: https://issues.apache.org/jira/browse/CB-8597 > > We would like the default app to support installing the whitelist plugin > automatically using the new plugin auto-restore feature (If you disagree, > discuss on the whitelist thread, that is not the topic of this post). > > However, the cordova-lib create script cannot support this feature right > now anyway (that is the topic of this post). I've outlined in the JIRA how > we could fix that (open to feedback). > > TLDR; --copy-from already supports this, so lets just vastly simplify > cordova-lib create.js to just always do a --copy-from (or --link-to), and > change cordova-cli to provide the default > --copy-from=./node_modules/cordova-app-hello-world. > > This also implies we can remove our last use of lazy_load from cordova-lib > (minus explicit git clones or platforms/plugins), and npm all the things! > > It also means a semver MAJOR change to cordova-lib that downstreams > directly using cordova-lib's create will need to adjust to. > > Thoughts? > > -Michal >
Re: [DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
+1. So on board with this. I'll take a look at your Jira issue later on today. On Tue, Mar 3, 2015 at 11:32 AM, Michal Mocny wrote: > This came up in the context of whitelist discussion, but wanted to bring it > to everyones attention. > > JIRA: https://issues.apache.org/jira/browse/CB-8597 > > We would like the default app to support installing the whitelist plugin > automatically using the new plugin auto-restore feature (If you disagree, > discuss on the whitelist thread, that is not the topic of this post). > > However, the cordova-lib create script cannot support this feature right > now anyway (that is the topic of this post). I've outlined in the JIRA how > we could fix that (open to feedback). > > TLDR; --copy-from already supports this, so lets just vastly simplify > cordova-lib create.js to just always do a --copy-from (or --link-to), and > change cordova-cli to provide the default > --copy-from=./node_modules/cordova-app-hello-world. > > This also implies we can remove our last use of lazy_load from cordova-lib > (minus explicit git clones or platforms/plugins), and npm all the things! > > It also means a semver MAJOR change to cordova-lib that downstreams > directly using cordova-lib's create will need to adjust to. > > Thoughts? > > -Michal >
[DISCUSS] publishing cordova-app-hello-world to npm and adding as dependency of cordova-lib
This came up in the context of whitelist discussion, but wanted to bring it to everyones attention. JIRA: https://issues.apache.org/jira/browse/CB-8597 We would like the default app to support installing the whitelist plugin automatically using the new plugin auto-restore feature (If you disagree, discuss on the whitelist thread, that is not the topic of this post). However, the cordova-lib create script cannot support this feature right now anyway (that is the topic of this post). I've outlined in the JIRA how we could fix that (open to feedback). TLDR; --copy-from already supports this, so lets just vastly simplify cordova-lib create.js to just always do a --copy-from (or --link-to), and change cordova-cli to provide the default --copy-from=./node_modules/cordova-app-hello-world. This also implies we can remove our last use of lazy_load from cordova-lib (minus explicit git clones or platforms/plugins), and npm all the things! It also means a semver MAJOR change to cordova-lib that downstreams directly using cordova-lib's create will need to adjust to. Thoughts? -Michal
Re: Hello
*Moving Eric from the 'lurker' file to the 'participant' file, wrings hands* Welcome Eric! Be sure to check out http://wiki.apache.org/cordova/ContributorWorkflow Also, each repo should have a CONTRIBUTING.md file that shows how to contribute. On Sat, Feb 28, 2015 at 5:28 PM, Harmon, Eric wrote: > Hi, > > I wanted to introduce myself. My name is Eric Harmon and I’m a software > engineer at Intel. I work on the Intel XDK team.I’ve been working with > the Cordova CLI and the android, iOS, windows, and wp8 platforms for the > build component of the XDK. I’ve also been lurking on the mailing list for a > long time. > > Since I’ve been taking advantage of Cordova for a while, I would like to > start contributing. > > Eric > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hello
Thanks for the intro! Looking forward to the help :) On Sun, Mar 1, 2015 at 5:40 PM, Mefire O. wrote: > Welcome, Eric ! > Nice to have you contributing. > > Thanks, > Mefire > > -Original Message- > From: Jesse [mailto:purplecabb...@gmail.com] > Sent: Saturday, February 28, 2015 10:37 PM > To: dev@cordova.apache.org > Subject: Re: Hello > > Welcome Eric! No more lurking. Glad to hear you're involved in many > platforms. > > > > > On Feb 28, 2015, at 5:28 PM, Harmon, Eric wrote: > > > > Hi, > > > > I wanted to introduce myself. My name is Eric Harmon and I’m a software > engineer at Intel. I work on the Intel XDK team.I’ve been working > with the Cordova CLI and the android, iOS, windows, and wp8 platforms for > the build component of the XDK. I’ve also been lurking on the mailing list > for a long time. > > > > Since I’ve been taking advantage of Cordova for a while, I would like to > start contributing. > > > > Eric > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org >
RE: Hello
Welcome, Eric ! Nice to have you contributing. Thanks, Mefire -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Saturday, February 28, 2015 10:37 PM To: dev@cordova.apache.org Subject: Re: Hello Welcome Eric! No more lurking. Glad to hear you're involved in many platforms. > On Feb 28, 2015, at 5:28 PM, Harmon, Eric wrote: > > Hi, > > I wanted to introduce myself. My name is Eric Harmon and I’m a software > engineer at Intel. I work on the Intel XDK team.I’ve been working with > the Cordova CLI and the android, iOS, windows, and wp8 platforms for the > build component of the XDK. I’ve also been lurking on the mailing list for a > long time. > > Since I’ve been taking advantage of Cordova for a while, I would like to > start contributing. > > Eric > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hello
Welcome Eric! No more lurking. Glad to hear you're involved in many platforms. > On Feb 28, 2015, at 5:28 PM, Harmon, Eric wrote: > > Hi, > > I wanted to introduce myself. My name is Eric Harmon and I’m a software > engineer at Intel. I work on the Intel XDK team.I’ve been working with > the Cordova CLI and the android, iOS, windows, and wp8 platforms for the > build component of the XDK. I’ve also been lurking on the mailing list for a > long time. > > Since I’ve been taking advantage of Cordova for a while, I would like to > start contributing. > > Eric > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Hello
Hi, I wanted to introduce myself. My name is Eric Harmon and I’m a software engineer at Intel. I work on the Intel XDK team.I’ve been working with the Cordova CLI and the android, iOS, windows, and wp8 platforms for the build component of the XDK. I’ve also been lurking on the mailing list for a long time. Since I’ve been taking advantage of Cordova for a while, I would like to start contributing. Eric - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hello Cordova world!
Welcome Les!
On Mon, Jan 5, 2015 at 11:58 AM, Les Orchard wrote:
> Hey folks! Just realized that my attempt last year at an intro email
> bounced, so here goes again...
>
> My name's Les Orchard, and I'm a webdev at the Mozilla Corp. I'm just
> starting to dig into contributing work on Firefox OS support, alongside
> Piotr Zalewa. I think my sweet spot will be looking at server-side stuff
> and developer tools, especially in node.js.
>
> I'm very much a newb and playing catch-up with the project. I've got a
> couple of PRs submitted, but still have a lot to learn.
>
> https://github.com/phonegap/connect-phonegap/pull/102
> https://github.com/phonegap-build/confetti/pull/3
>
> --
> lorch...@mozilla.com
> http://lmorchard.com
> {web,mad,computer} scientist; {tech,scifi} writer; home{brew,roast}er;
> Mozillian
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Hello Cordova world!
Hey folks! Just realized that my attempt last year at an intro email
bounced, so here goes again...
My name's Les Orchard, and I'm a webdev at the Mozilla Corp. I'm just
starting to dig into contributing work on Firefox OS support, alongside
Piotr Zalewa. I think my sweet spot will be looking at server-side stuff
and developer tools, especially in node.js.
I'm very much a newb and playing catch-up with the project. I've got a
couple of PRs submitted, but still have a lot to learn.
https://github.com/phonegap/connect-phonegap/pull/102
https://github.com/phonegap-build/confetti/pull/3
--
lorch...@mozilla.com
http://lmorchard.com
{web,mad,computer} scientist; {tech,scifi} writer; home{brew,roast}er;
Mozillian
[GitHub] cordova-app-hello-world pull request: more helpful stupid-friendly...
Github user kingIZZZY commented on a diff in the pull request:
https://github.com/apache/cordova-app-hello-world/pull/9#discussion_r19973706
--- Diff: www/js/index.js ---
@@ -16,27 +16,15 @@
* specific language governing permissions and limitations
* under the License.
*/
-var app = {
-// Application Constructor
-initialize: function() {
-this.bindEvents();
-},
-// Bind Event Listeners
-//
-// Bind any events that are required on startup. Common events are:
-// 'load', 'deviceready', 'offline', and 'online'.
-bindEvents: function() {
-document.addEventListener('deviceready', this.onDeviceReady,
false);
-},
-// deviceready Event Handler
-//
-// The scope of 'this' is the event. In order to call the
'receivedEvent'
-// function, we must explicitly call 'app.receivedEvent(...);'
-onDeviceReady: function() {
-app.receivedEvent('deviceready');
-},
-// Update DOM on a Received Event
-receivedEvent: function(id) {
+
+// before any cordova functionality can be used, you must hook into this
event
--- End diff --
perhaps compare to jQuery $(document).ready()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: more helpful stupid-friendly...
GitHub user kingIZZZY opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/9
more helpful stupid-friendly index.js
3:07:37 PM regedit: i did actually look at index.js at first, but it
seemed a little daunting so i put it aside and started coding my own stuff
3:08:25 PM regedit: i saw this 'app' object and calling .initialize() on
it, and for some reason I thought it must be some internal cordova stuff i must
read about elsewhere
3:08:43 PM regedit: didnt realize this 'app' object was all defined right
then & there
3:09:01 PM regedit: thought it might be set up from inside cordova.js or
whatnot...
3:09:11 PM regedit: gave up on it, wrote my own js
3:09:23 PM timeless: so, if you can think about a way for that block of
code that you did look at
3:09:24 PM regedit: maybe index.js can be more stupid friendly?
3:09:26 PM timeless: and did quickly discard
3:09:39 PM timeless: could have been more friendly to prevent you from
doing what you did
3:09:43 PM timeless: i'm open to changes
3:11:20 PM timeless: hrm
3:11:31 PM timeless: yeah. js/index.js really isn't stupid-friendly
3:11:34 PM timeless: please file a bug
3:11:57 PM regedit: here http://hastebin.com/rugelupena.js
3:12:33 PM regedit: my amateur newly proposed index.js :D
3:13:19 PM timeless nods
3:13:31 PM timeless: the problem is that their code was designed to be
pluggable and object oriented
3:13:50 PM timeless: which is well... nice and all, but... makes it hard
to figure out what's important
3:14:38 PM regedit: at least from a newcomer point of view, yeah. many
(most?) newcomers dont even care much about OO
3:14:53 PM regedit: if you want to appeal to them, it must be stupider
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kingIZZZY/cordova-app-hello-world master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-app-hello-world/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
commit 4c1b7a04260f833d32052c3d276c9c5c77b6245f
Author: Yisroel Goldstein
Date: 2014-11-06T20:23:25Z
more helpful stupid-friendly index.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hello Cordova!
Welcome Nikolai! On Sun, Aug 17, 2014 at 5:02 PM, tommy-carlos williams wrote: > Welcome! > > On 18 August 2014 at 8:59:55, Nikolai Kotchetkov (moto...@gmail.com) > wrote: > > Hello Cordova! > > My name is Nikolai, and I've been taking part in several Cordova projects > already mostly by writing plugins for Android. > > At this time I'd like to contribute a small feature to make a plugin > handling a bit easier :) > https://github.com/apache/cordova-lib/pull/63 > > My ICLA is on it's way to secretary :) > > Best regards, > Nikolai > >
Re: Hello Cordova!
Welcome! On 18 August 2014 at 8:59:55, Nikolai Kotchetkov (moto...@gmail.com) wrote: Hello Cordova! My name is Nikolai, and I've been taking part in several Cordova projects already mostly by writing plugins for Android. At this time I'd like to contribute a small feature to make a plugin handling a bit easier :) https://github.com/apache/cordova-lib/pull/63 My ICLA is on it's way to secretary :) Best regards, Nikolai
Hello Cordova!
Hello Cordova! My name is Nikolai, and I've been taking part in several Cordova projects already mostly by writing plugins for Android. At this time I'd like to contribute a small feature to make a plugin handling a bit easier :) https://github.com/apache/cordova-lib/pull/63 My ICLA is on it's way to secretary :) Best regards, Nikolai
Re: Hello
Welcome Jason! Lots to do and see here. Please document your journey of getting up to speed. Lots of rough edges that we can smooth out with a fresh perspective. I'm sure your colleagues have already given you a boat load of stuff to look at but our wiki [1] * is a great place to start. [1] http://wiki.cordova.io/ * Usually the wiki is available but not right now apparently =/ On Thu, Aug 7, 2014 at 7:19 AM, Jason Chase wrote: > Hi all, > > I'm Jason Chase, and I just joined the Google team working on Cordova. > > I've spent the last while working on enterprise SaaS solution, so I'm > looking forward to the challenge of getting up to speed on Cordova. Looks > like there's a lot going on with Cordova, so I can't wait to contribute! > > Thanks, > Jason >
Re: Hello
Welcome Jason! On Thu, Aug 7, 2014 at 9:55 AM, Sebastian Mil wrote: > Hi Jason! > > > On Thu, Aug 7, 2014 at 9:50 AM, Carlos Santana > wrote: > > > Welcome Jason ! > > > > > > On Thu, Aug 7, 2014 at 10:19 AM, Jason Chase > wrote: > > > > > Hi all, > > > > > > I'm Jason Chase, and I just joined the Google team working on Cordova. > > > > > > I've spent the last while working on enterprise SaaS solution, so I'm > > > looking forward to the challenge of getting up to speed on Cordova. > > Looks > > > like there's a lot going on with Cordova, so I can't wait to > contribute! > > > > > > Thanks, > > > Jason > > > > > > > > > > > -- > > Carlos Santana > > > > >
Re: Hello
Hi Jason! On Thu, Aug 7, 2014 at 9:50 AM, Carlos Santana wrote: > Welcome Jason ! > > > On Thu, Aug 7, 2014 at 10:19 AM, Jason Chase wrote: > > > Hi all, > > > > I'm Jason Chase, and I just joined the Google team working on Cordova. > > > > I've spent the last while working on enterprise SaaS solution, so I'm > > looking forward to the challenge of getting up to speed on Cordova. > Looks > > like there's a lot going on with Cordova, so I can't wait to contribute! > > > > Thanks, > > Jason > > > > > > -- > Carlos Santana > >
Re: Hello
Welcome Jason ! On Thu, Aug 7, 2014 at 10:19 AM, Jason Chase wrote: > Hi all, > > I'm Jason Chase, and I just joined the Google team working on Cordova. > > I've spent the last while working on enterprise SaaS solution, so I'm > looking forward to the challenge of getting up to speed on Cordova. Looks > like there's a lot going on with Cordova, so I can't wait to contribute! > > Thanks, > Jason > -- Carlos Santana
Hello
Hi all, I'm Jason Chase, and I just joined the Google team working on Cordova. I've spent the last while working on enterprise SaaS solution, so I'm looking forward to the challenge of getting up to speed on Cordova. Looks like there's a lot going on with Cordova, so I can't wait to contribute! Thanks, Jason
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user JohnMcLear commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-48886202 Thanks guys :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user zalun commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-48788987 I'll wait for any possible "-1" and if none, I'm pushing it to master on Monday --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Saying Hello and Problem with Jira
Ok, I was able to assign it to myself. Thanks Andrew. Eric. On Thu, Jul 3, 2014 at 3:03 PM, Andrew Grieve wrote: > I've added you to the JIRA project. Try it again and let me know if you > still can't assign it to yourself. > > > On Thu, Jul 3, 2014 at 1:33 PM, Eric Weiterman > wrote: > > > Hi everyone, Marcel K introduced me on here a couple weeks ago. I just > > started with IBM out of college and I'm glad I'm going to be getting a > > chance to work on Cordova with all of you. Hope you all have a good > > weekend coming up. > > > > I am having problems having Jiras assigned to me. In particular I was > > trying to have this one assigned to me, > > https://issues.apache.org/jira/browse/CB-7064 . Can anyone with Jira > > credentials help me out. > > > > Thanks, > > Eric W. > > >
Re: Saying Hello and Problem with Jira
I've added you to the JIRA project. Try it again and let me know if you still can't assign it to yourself. On Thu, Jul 3, 2014 at 1:33 PM, Eric Weiterman wrote: > Hi everyone, Marcel K introduced me on here a couple weeks ago. I just > started with IBM out of college and I'm glad I'm going to be getting a > chance to work on Cordova with all of you. Hope you all have a good > weekend coming up. > > I am having problems having Jiras assigned to me. In particular I was > trying to have this one assigned to me, > https://issues.apache.org/jira/browse/CB-7064 . Can anyone with Jira > credentials help me out. > > Thanks, > Eric W. >
Saying Hello and Problem with Jira
Hi everyone, Marcel K introduced me on here a couple weeks ago. I just started with IBM out of college and I'm glad I'm going to be getting a chance to work on Cordova with all of you. Hope you all have a good weekend coming up. I am having problems having Jiras assigned to me. In particular I was trying to have this one assigned to me, https://issues.apache.org/jira/browse/CB-7064 . Can anyone with Jira credentials help me out. Thanks, Eric W.
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user zalun commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574935 Looks good to me - I haven't tested it though. Moving JS to separate file is a good practice. I'd suggest doing that even if it wouldn't be about CSP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574133 > The pull request looks fine to me. My only suggestion would be to leave a comment explaining that initialization must happen after cordova.js: > > // initialize the app after the cordova.js script so that deviceready is registered. > app.initialize(); I'm not sure this comment will be clear at this point. Maybe add something to `index.html`, right before loading `js/index.js`? Although I don't think this change really complicates this bit and the comment seems overkill. > It would be nice to have an addition Mozillian verify that the change solves CB-6949, before we merge the pull request. I tested it and @zalun will take a look too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user mwbrooks commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47569377 Generally, our philosophy for the Hello World app is to avoid over complicating the code. This is why we use the `app` object instead of a self executing anonymous function, which would require a certain level of JavaScript knowledge. The pull request looks fine to me. My only suggestion would be to leave a comment explaining that initialization must happen after `cordova.js`: // initialize the app after the cordova.js script so that deviceready is registered. app.initialize(); It would be nice to have an addition Mozillian verify that the change solves [CB-6949](https://issues.apache.org/jira/browse/CB-6949), before we merge the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47561643 Code looks good to me too. @zalun, can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47559877 @JohnMcLear ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user JohnMcLear commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47555716 @marti1125 wut? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47554060 why I removed this line? because it has a warning about CSP when I validated in marketplace https://developer.mozilla.org/en-US/Apps/CSP @JohnMcLear, maybe I have to create main.js where it will have app.initialize() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user JohnMcLear commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47515954 PR looks fine to me, this i how I would have made this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47493059 Hi! @rodms10, when I try to validated this app at marketplace, this value: "pkgName": "io.cordova.hellocordova", doesn't valid for manifest.webapp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
