[jira] [Commented] (DL-155) TestAsyncReaderLock#testReaderLockMultiReadersScenario is flaky
[ https://issues.apache.org/jira/browse/DL-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769519#comment-15769519 ] ASF GitHub Bot commented on DL-155: --- GitHub user xieliang opened a pull request: https://github.com/apache/incubator-distributedlog/pull/88 DL-155 : fix flaky TestAsyncReaderLock#testReaderLockMultiReadersScenario Ran the case with changed patch 30 times, all are passed; and it'll fail w/o patch You can merge this pull request into a Git repository by running: $ git pull https://github.com/xieliang/incubator-distributedlog DL-155 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit 44d273afde6d04aa35464170bec770b578c92e4b Author: xieliang Date: 2016-12-22T08:46:25Z fix flaky TestAsyncReaderLock#testReaderLockMultiReadersScenario > TestAsyncReaderLock#testReaderLockMultiReadersScenario is flaky > --- > > Key: DL-155 > URL: https://issues.apache.org/jira/browse/DL-155 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > See > https://builds.apache.org/job/distributedlog-nightly-build/com.twitter$distributedlog-core/162/testReport/junit/com.twitter.distributedlog/TestAsyncReaderLock/testReaderLockMultiReadersScenario/ > The error came from write path, due to extra control records be transmitted > sometimes, the entryId probably more than 99 which was expected in original > case. > DL-151 had a similar issue and gave a solution already. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-131) Enable check style for distributedlog-client module
[ https://issues.apache.org/jira/browse/DL-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769373#comment-15769373 ] ASF GitHub Bot commented on DL-131: --- GitHub user xiliuant opened a pull request: https://github.com/apache/incubator-distributedlog/pull/87 DL-131: Enable checkstyle for distributedlog-client module You can merge this pull request into a Git repository by running: $ git pull https://github.com/xiliuant/incubator-distributedlog xi/checkstyle_client Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/87.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #87 commit e6bc01a0fe084fe4b473546089238f886d7ac6f6 Author: Xi Liu Date: 2016-12-22T07:35:04Z Enable checkstyle for distributedlog-client module > Enable check style for distributedlog-client module > --- > > Key: DL-131 > URL: https://issues.apache.org/jira/browse/DL-131 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-client >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-17) Ledger allocator pool should be able to use hostname to distinguish write proxies
[ https://issues.apache.org/jira/browse/DL-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769130#comment-15769130 ] ASF GitHub Bot commented on DL-17: -- GitHub user jayk-juma opened a pull request: https://github.com/apache/incubator-distributedlog/pull/86 DL-17: Ledger allocator pool should be able to use hostname to distinguish write proxies …guish write proxies You can merge this pull request into a Git repository by running: $ git pull https://github.com/jayk-juma/incubator-distributedlog jay/use_hostname_for_ledger_allocation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/86.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #86 commit 9b86ee41c94e9a9965843fb66205cf7edeaa6643 Author: Jay Juma Date: 2016-12-22T05:39:52Z DL-17: Ledger allocator pool should be able to use hostname to distinguish write proxies > Ledger allocator pool should be able to use hostname to distinguish write > proxies > - > > Key: DL-17 > URL: https://issues.apache.org/jira/browse/DL-17 > Project: DistributedLog > Issue Type: Task > Components: distributedlog-service >Reporter: Sijie Guo >Assignee: Jay Juma > Labels: help-wanted > Fix For: 0.4.0 > > > Currently write proxy uses shard id to distinguish ledger allocators in the > pool. Using shard id is very convenient if deploying using a scheduler like > aurora, as scheduler usually be able to assign a unique shard id. > However, for deployments not using aurora, it might make sense to use just > hostname to identify the allocator used by a specific write proxy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-153) typo in distributedlog-benchmark/bin/dbench
[
https://issues.apache.org/jira/browse/DL-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769068#comment-15769068
]
ASF GitHub Bot commented on DL-153:
---
GitHub user jayk-juma opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/85
DL-153: typo in distributedlog-benchmark/bin/dbench
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jayk-juma/incubator-distributedlog
jay/fix_typo_in_benchmark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
commit 057cbdeb4cce93ae0ac274c9ccc3f8e7b7127850
Author: Jay Juma
Date: 2016-12-22T05:00:34Z
DL-153: typo in distributedlog-benchmark/bin/dbench
> typo in distributedlog-benchmark/bin/dbench
> ---
>
> Key: DL-153
> URL: https://issues.apache.org/jira/browse/DL-153
> Project: DistributedLog
> Issue Type: Bug
> Components: distributedlog-benchmark
>Reporter: Jay Juma
>Assignee: Jay Juma
>Priority: Minor
> Fix For: 0.4.0
>
>
> {code}
> *)
> set -x
> echo java $OPTS $COMMAND $@
> ;;
> {code}
> It should be 'exec' not 'echo'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-151) TestBKLogReadHandler#testGetFirstDLSNWithOpenLedger is flaky
[
https://issues.apache.org/jira/browse/DL-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768147#comment-15768147
]
ASF GitHub Bot commented on DL-151:
---
GitHub user sijie opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/84
DL-151: TestBKLogReadHandler#testGetFirstDLSNWithOpenLedger is flaky
- Flush/Commit records only after the data are written
- Disable immediate flush
- Reduce num writes from 100 to 10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/incubator-distributedlog
sijie/FixTestGetFirstDLSNWithOpenLedger
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
commit 4aa78c2cbbfc1a89c25463a3aa0401595471445a
Author: Sijie Guo
Date: 2016-12-21T20:55:32Z
DL-151: TestBKLogReadHandler#testGetFirstDLSNWithOpenLedger is flaky
- Flush/Commit records only after the data are written
- Disable immediate flush
- Reduce num writes from 100 to 10
> TestBKLogReadHandler#testGetFirstDLSNWithOpenLedger is flaky
>
>
> Key: DL-151
> URL: https://issues.apache.org/jira/browse/DL-151
> Project: DistributedLog
> Issue Type: Task
> Components: distributedlog-core, tests
>Reporter: Sijie Guo
>Assignee: Sijie Guo
>
> {code}
> Failed tests:
> testGetFirstDLSNWithOpenLedger(com.twitter.distributedlog.TestBKLogReadHandler):
> expected: but
> was:
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-99) Enable thrift mux on DL smoketest reader
[
https://issues.apache.org/jira/browse/DL-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767616#comment-15767616
]
ASF GitHub Bot commented on DL-99:
--
GitHub user sijie opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/82
DL-99 - DL-111
This is a umbrella merge for DL-99 to DL-111. Individual commit in this
pull request is associated with one DL jira.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/incubator-distributedlog
squashed_merge/DL-111
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
commit 9ff22f4239754d25fb3c7238cf25cf453f0ebbd6
Author: Dave Rusek
Date: 2016-07-18T19:23:49Z
DL-99: Enable thriftmux for distributedlog smoketest reader
commit 785ff1cdfb515882f934d4bd79fe34bb39cd95a9
Author: Sijie Guo
Date: 2016-07-29T04:10:33Z
DL-101: Improve session expire handling on fetching log segments for readers
This change focuses on improving the session expire handling on fetching
log segments for readers.
The log segment management in DL is now done by 3 parts.
- a LogSegmentMetadataStore (one per namespace instance): it is used for
fetching the log segments from log segment metadata store (ZooKeeper). it
doesn't do any caching.
- a LogSegmentMetadataCache (one per namespace instance): it is a guava
cache based metadata cache. it maintains a mapping between log segment metadata
path and the log segment metadata. it manages the cache for the log segments
that will be accessed in this namespace instance. it doesn't manage the
sequence of the log segments for streams.
- a PerStreamLogSegmentCache for each BKLogHandler. the log segment cache
is per stream. it maintains the sequence of the log segments.
BKLogWriteHandler doesn't watch the log segment changes. It fetches minimal
number of log segments when it is created and fetches the full list of log
segments for truncations. New log segments will be added to the per stream log
segment cache with log segment rolling.
BKLogReadHandler watch the log segments changes and only notify when the
list of log segments is changed. the session handling which is specific to the
metadata store is hidden to the implementations of LogSegmentMetadataStore.
The change tries to cleanup bunch of unused methods in
BKLog{Read,Write}Handler too.
commit 10ff44510437d4087df5dc4775d968e174df83b0
Author: Leigh Stewart
Date: 2016-07-29T04:36:49Z
DL-102: Add routing service to write proxy server side
this change is to add getOwner rpc in write proxy. so we can change the
client side to get owner from write proxy first for routing service. in this
way, we can start experiementing any resource placement algorithms.
commit 9f80812ab4293de2f7073642f7ef452b6a88f8f6
Author: Sijie Guo
Date: 2016-07-29T05:02:09Z
DL-103: DL client can use server-side routing service to retrieve
ownerships for streams
If the dl client configures a routing service finagle name, the client will
use this to retrieve ownerships for streams.
commit 75774256dbaa5fcccb2e0d319e5d7d272a976901
Author: Jordan Bull
Date: 2016-08-09T18:36:53Z
DL-104: BKClientReadTimeout can be equal to getReadLACLongPollTimeout so
current config validates
commit afe64639b871b4dbc564f904fc4f522c0de334d3
Author: Yiming Zang
Date: 2016-08-10T23:18:53Z
DL-105: Make compression stats available per stream
commit 36a07f6b1d5d3fde395687f97ee10fb9376b5d7b
Author: Yiming Zang
Date: 2016-08-12T17:30:39Z
DL-106: Use namespace after it is closed will throw AlreadyClosedException
commit d156c1d6223034fceba90750febc42d25e389d5c
Author: Phillip Su
Date: 2016-08-23T00:47:28Z
DL-107: Added unregistering gauges for distributedlog-core and
distributedlog-benchmark
commit e18cd48c2f9a9d03dfc7f46e96e74ebaa1471659
Author: Yiming Zang
Date: 2016-09-17T00:35:51Z
DL-108: Log rate limiting more clearly
commit a743b44f4614154c67cc4d6a98a9003d80062d70
Author: Sijie Guo
Date: 2016-10-27T17:18:52Z
DL-109: Add a tool to find the stream containing the given ledger
commit 5f50a41b3883e2107befa95f774687deae9d62fe
Author: Sijie Guo
Date: 2016-11-22T00:17:51Z
DL-110: Write control record if necessary when roll a log segment
commit 0d2e20c7c9189dec7909ae67f4a62443a9aa40bc
Author: Sijie Guo
Date: 2016-11-22T01:30:13Z
DL-111: ReadAhead Cache should cache entries rather than records
Current readahead cache cache records. So it will be a lot of callbacks
(function calls) when polling a record off the readahead cache. Most of the cpu
c
[jira] [Commented] (DL-95) Assign host ip client id if the client id is undefined
[ https://issues.apache.org/jira/browse/DL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766428#comment-15766428 ] ASF GitHub Bot commented on DL-95: -- Github user sijie closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/68 > Assign host ip client id if the client id is undefined > -- > > Key: DL-95 > URL: https://issues.apache.org/jira/browse/DL-95 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Leigh Stewart > Fix For: 0.4.0 > > > Assign host ip client id if the client id is undefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-93) LogSegmentMetadataStore should only notify when the list of log segments is updated
[ https://issues.apache.org/jira/browse/DL-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766423#comment-15766423 ] ASF GitHub Bot commented on DL-93: -- Github user sijie closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/66 > LogSegmentMetadataStore should only notify when the list of log segments is > updated > --- > > Key: DL-93 > URL: https://issues.apache.org/jira/browse/DL-93 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > Currently it notifies the listeners not only when there is a change but also > when session expires. it would break the reada > head loop and cause readers have to wait until it is able to connect to > zookeeper again. > With this change, it would only notify when the list of log segments is > updated. If it disconnects to zookeeper, the listen > er won't be notified and it would keep reading from the log segments it knows. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-92) Simplify the state transition on stream
[ https://issues.apache.org/jira/browse/DL-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766422#comment-15766422 ] ASF GitHub Bot commented on DL-92: -- Github user sijie closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/65 > Simplify the state transition on stream > --- > > Key: DL-92 > URL: https://issues.apache.org/jira/browse/DL-92 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-service >Affects Versions: 0.4.0 >Reporter: Sijie Guo >Assignee: Leigh Stewart > > Simplify the state transition on stream > * the stream is created on INITIALIZING > * when the stream is started, it would start transition from INITIALIZING > to INITIALIZED > * it would serve stream operations when the stream is INITIALIZED > * it would be turned to ERROR when encountered exceptions. > * the stream would be closed when service operation timeout or > encountered any exceptions. it would first be removed from acquired mapping > * the stream would be removed from cached mapping depends on probation > time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-94) Make the zookeeper client used by bookkeeper client retry on session expires
[ https://issues.apache.org/jira/browse/DL-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766427#comment-15766427 ] ASF GitHub Bot commented on DL-94: -- Github user sijie closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/67 > Make the zookeeper client used by bookkeeper client retry on session expires > > > Key: DL-94 > URL: https://issues.apache.org/jira/browse/DL-94 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > * the zookeeper client used by bookkeeper client is purely for metadata > accesses, so we should retry on session expires. > * remove the unnessary zookeeper session handling in bk log handler. as > we don't necessary to fail bookkeeper client or log > handler when session expires as it would be handled and retried by the > zookeeper client. > * Make the retry infinitely if the retry settings for bkc zookeeper > client is set to 0 or negative. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-97) Remove unused methods in BKLogHandler
[ https://issues.apache.org/jira/browse/DL-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766420#comment-15766420 ] ASF GitHub Bot commented on DL-97: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/69 > Remove unused methods in BKLogHandler > - > > Key: DL-97 > URL: https://issues.apache.org/jira/browse/DL-97 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Leigh Stewart > Fix For: 0.4.0 > > > Remove unused methods in BKLogHandler -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-146) Fix Stream typo : initiaize
[ https://issues.apache.org/jira/browse/DL-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766414#comment-15766414 ] ASF GitHub Bot commented on DL-146: --- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/79 +1 LGTM. > Fix Stream typo : initiaize > --- > > Key: DL-146 > URL: https://issues.apache.org/jira/browse/DL-146 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-service >Reporter: Liang Xie >Assignee: Liang Xie >Priority: Minor > > "moved to initiaize()" -> "moved to initialize()" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-146) Fix Stream typo : initiaize
[ https://issues.apache.org/jira/browse/DL-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766417#comment-15766417 ] ASF GitHub Bot commented on DL-146: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/79 > Fix Stream typo : initiaize > --- > > Key: DL-146 > URL: https://issues.apache.org/jira/browse/DL-146 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-service >Reporter: Liang Xie >Assignee: Liang Xie >Priority: Minor > > "moved to initiaize()" -> "moved to initialize()" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765730#comment-15765730 ] ASF GitHub Bot commented on DL-129: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/54 > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763642#comment-15763642 ] ASF GitHub Bot commented on DL-129: --- Github user xiliuant commented on the issue: https://github.com/apache/incubator-distributedlog/pull/54 @sijie I addressed most of your comments. please let me know if you have any other comments. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763641#comment-15763641 ] ASF GitHub Bot commented on DL-129: --- Github user xiliuant commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190694 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- fixed. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763639#comment-15763639 ] ASF GitHub Bot commented on DL-129: --- Github user xiliuant commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r93190638 --- Diff: distributedlog-build-tools/pom.xml --- @@ -0,0 +1,30 @@ + --- End diff -- I moved the eclipse setting to the build-tools module. I will create a jira for findbugs settings. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-145) Fix the flaky testServiceTimeout
[ https://issues.apache.org/jira/browse/DL-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763630#comment-15763630 ] ASF GitHub Bot commented on DL-145: --- Github user xieliang commented on the issue: https://github.com/apache/incubator-distributedlog/pull/78 The failure cases are not related with current change, please see https://issues.apache.org/jira/browse/DL-147 for further working on it. > Fix the flaky testServiceTimeout > > > Key: DL-145 > URL: https://issues.apache.org/jira/browse/DL-145 > Project: DistributedLog > Issue Type: Test > Components: distributedlog-service >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > The TestDistributedLogService#testServiceTimeout case is not stable, e.g. > https://builds.apache.org/job/distributedlog-precommit-pullrequest/22/com.twitter$distributedlog-service/testReport/com.twitter.distributedlog.service/TestDistributedLogService/testServiceTimeout/ > It could be reproduced on my box occasionally, and the failures were stable > if i tuned the ServiceTimeoutMs from 200 to 150, and always passed if tuned > to a larger value, e.g. 1000(btw, my disk is SSD type) > After digging into it, shows it related with starting a new log segment > corner case. > For a good case, once service time out occurs, steam status : ERROR -> > CLOSING -> CLOSED, calling Abortables.asyncAbort will trigger the cached > logsegment be aborted, then writeOp will be injected an exception, e.g. write > cancel exception. > For a bad case, since no log records be written before, so there'll be an > async start new log segment, once the timeout occurs, the segment starting > still not be done, so no cache, then asyncAbort has no change to abort that > segment. > I think change the test timeout value to a larger one should be fine for this > special test corner case. > will attach a minor patch later. Any suggestions are welcome. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-91) Be able to close writer within a timeout duration
[ https://issues.apache.org/jira/browse/DL-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763578#comment-15763578 ] ASF GitHub Bot commented on DL-91: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/64 > Be able to close writer within a timeout duration > - > > Key: DL-91 > URL: https://issues.apache.org/jira/browse/DL-91 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-client >Reporter: Sijie Guo >Assignee: Leigh Stewart > > If a stream is hanging on closing the writer on write proxy, it will cause > STEAM_UNAVAILABLE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-146) Fix Stream typo : initiaize
[ https://issues.apache.org/jira/browse/DL-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763540#comment-15763540 ] ASF GitHub Bot commented on DL-146: --- GitHub user xieliang opened a pull request: https://github.com/apache/incubator-distributedlog/pull/79 DL-146 : fix Stream typo : initiaize -> initialize You can merge this pull request into a Git repository by running: $ git pull https://github.com/xieliang/incubator-distributedlog DL-146 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 commit 7f7e86af064d81a338a5db4215eeb24afb0ada34 Author: xieliang Date: 2016-12-20T07:41:01Z fix Stream typo : initiaize -> initialize > Fix Stream typo : initiaize > --- > > Key: DL-146 > URL: https://issues.apache.org/jira/browse/DL-146 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-service >Reporter: Liang Xie >Assignee: Liang Xie >Priority: Minor > > "moved to initiaize()" -> "moved to initialize()" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-126) Fix the url of distributedlog blog post
[ https://issues.apache.org/jira/browse/DL-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763536#comment-15763536 ] ASF GitHub Bot commented on DL-126: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/52 > Fix the url of distributedlog blog post > --- > > Key: DL-126 > URL: https://issues.apache.org/jira/browse/DL-126 > Project: DistributedLog > Issue Type: Bug > Components: website >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > The URL states 2015. It should be 2016. > http://distributedlog.incubator.apache.org/technical-review/2015/09/19/kafka-vs-distributedlog -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-145) Fix the flaky testServiceTimeout
[ https://issues.apache.org/jira/browse/DL-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763511#comment-15763511 ] ASF GitHub Bot commented on DL-145: --- GitHub user xieliang opened a pull request: https://github.com/apache/incubator-distributedlog/pull/78 DL-145 : the write requests should be error out immediately even if the rolling writer still be creating Passed all test cases locally, now TestDistributedLogService#testServiceTimeout case is stable on my box You can merge this pull request into a Git repository by running: $ git pull https://github.com/xieliang/incubator-distributedlog DL-145 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/78.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #78 commit 6be8ca4d01c4c40947d4b901f0299c8dcc97c509 Author: xieliang Date: 2016-12-20T07:19:38Z the write requests should be error out immediately even if the rolling writer still be creating > Fix the flaky testServiceTimeout > > > Key: DL-145 > URL: https://issues.apache.org/jira/browse/DL-145 > Project: DistributedLog > Issue Type: Test > Components: distributedlog-service >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > The TestDistributedLogService#testServiceTimeout case is not stable, e.g. > https://builds.apache.org/job/distributedlog-precommit-pullrequest/22/com.twitter$distributedlog-service/testReport/com.twitter.distributedlog.service/TestDistributedLogService/testServiceTimeout/ > It could be reproduced on my box occasionally, and the failures were stable > if i tuned the ServiceTimeoutMs from 200 to 150, and always passed if tuned > to a larger value, e.g. 1000(btw, my disk is SSD type) > After digging into it, shows it related with starting a new log segment > corner case. > For a good case, once service time out occurs, steam status : ERROR -> > CLOSING -> CLOSED, calling Abortables.asyncAbort will trigger the cached > logsegment be aborted, then writeOp will be injected an exception, e.g. write > cancel exception. > For a bad case, since no log records be written before, so there'll be an > async start new log segment, once the timeout occurs, the segment starting > still not be done, so no cache, then asyncAbort has no change to abort that > segment. > I think change the test timeout value to a larger one should be fine for this > special test corner case. > will attach a minor patch later. Any suggestions are welcome. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-28) generate java code failed using scrooge
[ https://issues.apache.org/jira/browse/DL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763408#comment-15763408 ] ASF GitHub Bot commented on DL-28: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/73 > generate java code failed using scrooge > --- > > Key: DL-28 > URL: https://issues.apache.org/jira/browse/DL-28 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-protocol >Affects Versions: 0.4.0 > Environment: Apache Maven 3.2.5 > Maven home: C:\apache-maven-3.2.5 > Java version: 1.8.0_60, vendor: Oracle Corporation > Java home: C:\Java\jdk1.8.0_60\jre > Default locale: zh_CN, platform encoding: UTF-8 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" >Reporter: weiwei >Priority: Blocker > Labels: build > Fix For: 0.4.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > [INFO] Reactor Summary: > [INFO] > [INFO] distributedlog . SUCCESS [ 0.002 > s] > [INFO] DistributedLog Protocol FAILURE [ 1.081 > s] > [INFO] DistributedLog Core Library SKIPPED > [INFO] DistributedLog Client .. SKIPPED > [INFO] DistributedLog Service . SKIPPED > [INFO] DistributedLog Benchmark ... SKIPPED > [INFO] DistributedLog Example . SKIPPED > [INFO] DistributedLog Basics .. SKIPPED > [INFO] DistributedLog Messaging Tutorial .. SKIPPED > [INFO] DistributedLog Kafka Tutorial .. SKIPPED > [INFO] DistributedLog MapReduce ... SKIPPED > [INFO] DistributedLog Tutorials ... SKIPPED > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 1.321 s > [INFO] Finished at: 2016-08-02T13:26:31+08:00 > [INFO] Final Memory: 12M/150M > [INFO] > > [ERROR] Exception parsing: > E:\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift: > [3.1] failure: string matching regex `\z' expected but `/' found > [ERROR] > [ERROR] // Response stats codes > [ERROR] > [ERROR] ^ > [ERROR] -> [Help 1] > com.twitter.scrooge.frontend.FileParseException: Exception parsing: > E:\isoftstone\workspacedeis\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift > at > com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427) > at > com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427) > at scala.Option.map(Option.scala:145) > at > com.twitter.scrooge.frontend.ThriftParser.parse(ThriftParser.scala:420) > at > com.twitter.scrooge.frontend.ThriftParser.parseFile(ThriftParser.scala:448) > at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:66) > at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:64) > at scala.collection.immutable.List.foreach(List.scala:318) > at > scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:32) > at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:45) > at com.twitter.scrooge.Compiler.run(Compiler.scala:64) > at com.twitter.ScroogeRunner.compile(ScroogeRunner.scala:45) > at > com.twitter.AbstractMavenScroogeMojo.execute(AbstractMavenScroogeMojo.java:239) > at > com.twitter.MavenScroogeCompileMojo.execute(MavenScroogeCompileMojo.java:22) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355) > at org.apach
[jira] [Commented] (DL-122) Use assertions from Junit rather than assert() for tests
[ https://issues.apache.org/jira/browse/DL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763399#comment-15763399 ] ASF GitHub Bot commented on DL-122: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/77 > Use assertions from Junit rather than assert() for tests > > > Key: DL-122 > URL: https://issues.apache.org/jira/browse/DL-122 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Reporter: Gerrit Sundaram >Assignee: Brennon York > > there are too many places in test using 'assert()' rather than using > assertions from junit. it would be good that we can change that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-123) Every tests should have timeout
[ https://issues.apache.org/jira/browse/DL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763394#comment-15763394 ] ASF GitHub Bot commented on DL-123: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/75 > Every tests should have timeout > --- > > Key: DL-123 > URL: https://issues.apache.org/jira/browse/DL-123 > Project: DistributedLog > Issue Type: Bug >Reporter: Gerrit Sundaram >Assignee: Brennon York > Labels: help-wanted > > Currently not every test has timeout value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-136) Avoid empty catch blocks
[
https://issues.apache.org/jira/browse/DL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763391#comment-15763391
]
ASF GitHub Bot commented on DL-136:
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-distributedlog/pull/74
> Avoid empty catch blocks
>
>
> Key: DL-136
> URL: https://issues.apache.org/jira/browse/DL-136
> Project: DistributedLog
> Issue Type: Task
>Reporter: Sijie Guo
>Assignee: Brennon York
> Labels: help-wanted
>
> Based on the code analysis here :
> https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/, there are 22
> Times: Catching exceptions with empty bodies.
> {quote}
> There are exceptions of different types: InterruptedException,
> KeeperException, Exception, etc.. Even though we think that these exceptions
> should never occur, if they are captured it means that they are technically
> possible. In case that they do happen, it will be very difficult to know what
> is happening and to diagnose the problem. It is very recommendable, at least
> to add a log trace, in case these exceptions are triggered.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-136) Avoid empty catch blocks
[
https://issues.apache.org/jira/browse/DL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763387#comment-15763387
]
ASF GitHub Bot commented on DL-136:
---
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/74
The change looks good to me +1
@brennonyork thank you for your contribution.
> Avoid empty catch blocks
>
>
> Key: DL-136
> URL: https://issues.apache.org/jira/browse/DL-136
> Project: DistributedLog
> Issue Type: Task
>Reporter: Sijie Guo
>Assignee: Brennon York
> Labels: help-wanted
>
> Based on the code analysis here :
> https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/, there are 22
> Times: Catching exceptions with empty bodies.
> {quote}
> There are exceptions of different types: InterruptedException,
> KeeperException, Exception, etc.. Even though we think that these exceptions
> should never occur, if they are captured it means that they are technically
> possible. In case that they do happen, it will be very difficult to know what
> is happening and to diagnose the problem. It is very recommendable, at least
> to add a log trace, in case these exceptions are triggered.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-122) Use assertions from Junit rather than assert() for tests
[ https://issues.apache.org/jira/browse/DL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759066#comment-15759066 ] ASF GitHub Bot commented on DL-122: --- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/77 @brennonyork I think it is a common issue for a few tests that are kind of time dependent. so travis ci will run two jobs and the apache jenkins will run another one. they run same mvn command. if any of one passed the verification, it typically means that this change is safe. so in your pull request, one of travis CI passed and the jenkins also passed, so your change seems to be safe. > Use assertions from Junit rather than assert() for tests > > > Key: DL-122 > URL: https://issues.apache.org/jira/browse/DL-122 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Reporter: Gerrit Sundaram >Assignee: Brennon York > > there are too many places in test using 'assert()' rather than using > assertions from junit. it would be good that we can change that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-90) Don't use stack and codec together for configuring thriftmux
[ https://issues.apache.org/jira/browse/DL-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756593#comment-15756593 ] ASF GitHub Bot commented on DL-90: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/62 > Don't use stack and codec together for configuring thriftmux > > > Key: DL-90 > URL: https://issues.apache.org/jira/browse/DL-90 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-client, distributedlog-service >Affects Versions: 0.4.0 >Reporter: Sijie Guo >Assignee: David Rusek > > - Don't use stack and codec together for configuring thriftmux > - Remove codec if the thriftmux is disabled -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-89) add flag to enable thrift mux on DL monitor service
[ https://issues.apache.org/jira/browse/DL-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756507#comment-15756507 ] ASF GitHub Bot commented on DL-89: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/61 > add flag to enable thrift mux on DL monitor service > --- > > Key: DL-89 > URL: https://issues.apache.org/jira/browse/DL-89 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-service >Reporter: Sijie Guo >Assignee: David Rusek > Fix For: 0.4.0 > > > provide the ability to enable thriftmux on monitor service -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-88) remove watches when unregister children watches
[ https://issues.apache.org/jira/browse/DL-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756500#comment-15756500 ] ASF GitHub Bot commented on DL-88: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/60 > remove watches when unregister children watches > --- > > Key: DL-88 > URL: https://issues.apache.org/jira/browse/DL-88 > Project: DistributedLog > Issue Type: New Feature > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > use the new zk removeWatches api to remove watchers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-87) Introduce periodic keepalive control record in writer
[ https://issues.apache.org/jira/browse/DL-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756486#comment-15756486 ] ASF GitHub Bot commented on DL-87: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/59 > Introduce periodic keepalive control record in writer > - > > Key: DL-87 > URL: https://issues.apache.org/jira/browse/DL-87 > Project: DistributedLog > Issue Type: New Feature >Reporter: Sijie Guo >Assignee: Leigh Stewart > Fix For: 0.4.0 > > > the writer will periodically write 'keepalive' control record to make sure > the stream is alive. so if the write proxy is disconnected from bookies, the > control record will fail to write hence write proxy gets a chance to drop the > ownership. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-86) Improve handling of lock conflicts in zk session lock
[ https://issues.apache.org/jira/browse/DL-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756412#comment-15756412 ] ASF GitHub Bot commented on DL-86: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/58 > Improve handling of lock conflicts in zk session lock > - > > Key: DL-86 > URL: https://issues.apache.org/jira/browse/DL-86 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > - lock reacquire could happen in foreground and background thread. so use a > semaphore to make sure there is only on e outstanding acquire > operation. and check if already hold lock before reacquire. > - fix handling zk sibling znode logic. as the znode is sequential znode, > the name would be different each time. so onlycomparing the client id and > session id of the znodes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-122) Use assertions from Junit rather than assert() for tests
[ https://issues.apache.org/jira/browse/DL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755862#comment-15755862 ] ASF GitHub Bot commented on DL-122: --- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/77 LGTM +1 > Use assertions from Junit rather than assert() for tests > > > Key: DL-122 > URL: https://issues.apache.org/jira/browse/DL-122 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Reporter: Gerrit Sundaram >Assignee: Brennon York > > there are too many places in test using 'assert()' rather than using > assertions from junit. it would be good that we can change that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-122) Use assertions from Junit rather than assert() for tests
[
https://issues.apache.org/jira/browse/DL-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755344#comment-15755344
]
ASF GitHub Bot commented on DL-122:
---
GitHub user brennonyork opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/77
DL-122: Use assertions from Junit rather than assert() for tests
* changed all instances of `assert()` to junit versions in `src/test`
Here is the script I used to find all instances of `assert()` inside the
`src/test` folder:
```
grep -r "assert(" * 2>/dev/null | grep -v "main"
```
The `grep -v "main"` removes all instances of the usage within the main
source tree (which there are quite a few). I did this as I assumed the JIRA
ticket spirit was not to remove those instances from the main tree and thus
would require including `junit` in core compilation rather than scoped for
`test` as is.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brennonyork/incubator-distributedlog DL-122
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
commit d95c57afe627f73b0e98a0a6b11db59f07eccfd5
Author: Brennon York
Date: 2016-12-16T19:38:20Z
changed all instances of assert() to junit versions in src/test
> Use assertions from Junit rather than assert() for tests
>
>
> Key: DL-122
> URL: https://issues.apache.org/jira/browse/DL-122
> Project: DistributedLog
> Issue Type: Bug
> Components: distributedlog-core
>Reporter: Gerrit Sundaram
>Assignee: Brennon York
>
> there are too many places in test using 'assert()' rather than using
> assertions from junit. it would be good that we can change that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-123) Every tests should have timeout
[ https://issues.apache.org/jira/browse/DL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755285#comment-15755285 ] ASF GitHub Bot commented on DL-123: --- Github user leighst commented on the issue: https://github.com/apache/incubator-distributedlog/pull/75 Makes sense, doesnt sound obviously better. Shipit! > Every tests should have timeout > --- > > Key: DL-123 > URL: https://issues.apache.org/jira/browse/DL-123 > Project: DistributedLog > Issue Type: Bug >Reporter: Gerrit Sundaram >Assignee: Brennon York > Labels: help-wanted > > Currently not every test has timeout value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-141) DLog scripts are broken
[
https://issues.apache.org/jira/browse/DL-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755276#comment-15755276
]
ASF GitHub Bot commented on DL-141:
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-distributedlog/pull/76
> DLog scripts are broken
> ---
>
> Key: DL-141
> URL: https://issues.apache.org/jira/browse/DL-141
> Project: DistributedLog
> Issue Type: Bug
> Components: distributedlog-core, distributedlog-service
>Reporter: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> The scripts in distributedlog-service are broken.
> {quote}
> $ ./distributedlog-service/bin/dlog local
> JMX enabled by default
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
> Error: Could not find or load main class
> com.twitter.distributedlog.LocalDLMEmulator
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-123) Every tests should have timeout
[ https://issues.apache.org/jira/browse/DL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755019#comment-15755019 ] ASF GitHub Bot commented on DL-123: --- Github user brennonyork commented on the issue: https://github.com/apache/incubator-distributedlog/pull/75 Totally valid question. I went through and Google'd for a bit and found a few links. In short the best we can do that is _currently_ supported by JUnit is to create a class rule within a test suite (eg timeout) although we'd then need to create all the test suites (which it doesn't look like DL is setup for currently). * [history of global params for junit](https://github.com/junit-team/junit4/issues/1219) * [creating class rules for test suites](http://stackoverflow.com/questions/16608934/can-i-apply-a-time-limit-for-all-the-tests-in-the-suite) > Every tests should have timeout > --- > > Key: DL-123 > URL: https://issues.apache.org/jira/browse/DL-123 > Project: DistributedLog > Issue Type: Bug >Reporter: Gerrit Sundaram >Assignee: Brennon York > Labels: help-wanted > > Currently not every test has timeout value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-141) DLog scripts are broken
[
https://issues.apache.org/jira/browse/DL-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754005#comment-15754005
]
ASF GitHub Bot commented on DL-141:
---
GitHub user sijie opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/76
DL-141: Fix broken scripts in tutorials and add integration test to travis
ci
- fix the broken scripts used in tutorials
- fix the write_proxy configuration (a change was merged to validate
configuration which it brokes the configuration too)
- add integration test to validate the basic end-to-end functionalities
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/incubator-distributedlog
sijie/script_for_ci
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
commit 534617e06e5ca360eab8c0ebb0273e589f7698ef
Author: Sijie Guo
Date: 2016-12-16T10:03:33Z
Fix broken scripts in tutorials and add integration test to travis ci
- fix the broken scripts used in tutorials
- fix the write_proxy configuration (a change was merged to validate
configuration which it brokes the configuration too)
- add integration test to validate the basic end-to-end functionalities
> DLog scripts are broken
> ---
>
> Key: DL-141
> URL: https://issues.apache.org/jira/browse/DL-141
> Project: DistributedLog
> Issue Type: Bug
> Components: distributedlog-core, distributedlog-service
>Reporter: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> The scripts in distributedlog-service are broken.
> {quote}
> $ ./distributedlog-service/bin/dlog local
> JMX enabled by default
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
> Error: Could not find or load main class
> com.twitter.distributedlog.LocalDLMEmulator
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-123) Every tests should have timeout
[
https://issues.apache.org/jira/browse/DL-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753481#comment-15753481
]
ASF GitHub Bot commented on DL-123:
---
GitHub user brennonyork opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/75
DL-123: Every tests should have timeout
* used a simple bash script to find any tests without a timeout
Here is the below bash executed from the root directory. This could be
expanded to take in more than one line above the initial `grep` although, for
more, it only reduces the false positive rate. After this patch there are only
4 false positives (tests where the text immediately above is not `@Test(timeout
= ...)`).
```
grep -r "public void test" -B 1 * | awk '($NR+1) % 3 !=0 {printf $0; printf
" "} NR % 3 == 0 {print " "}' | grep -v "timeout"
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brennonyork/incubator-distributedlog DL-123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
commit ece7cde25fd44e913d0b5b15a807fd1d0f28fd89
Author: Brennon York
Date: 2016-12-16T05:06:29Z
added timeout of 6 to all tests
> Every tests should have timeout
> ---
>
> Key: DL-123
> URL: https://issues.apache.org/jira/browse/DL-123
> Project: DistributedLog
> Issue Type: Bug
>Reporter: Gerrit Sundaram
>Assignee: Brennon York
> Labels: help-wanted
>
> Currently not every test has timeout value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-136) Avoid empty catch blocks
[
https://issues.apache.org/jira/browse/DL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753423#comment-15753423
]
ASF GitHub Bot commented on DL-136:
---
GitHub user brennonyork opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/74
DL-136: Avoid empty catch blocks
* resolves the 9 empty catch blocks in `src/main`
* leaves 49 errors within `src/test` unchanged
* if we want to resolve those as well let me know, wasn't sure how we
wanted to handle that
Used an independent checkstyle that looked for [empty catch
blocks](http://checkstyle.sourceforge.net/config_blocks.html#EmptyBlock). Did a
quick manual analysis and cannot find any other empty catch blocks in
`src/main` so cannot rectify the original 22 as stated in the [Kiuwan
blog](https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brennonyork/incubator-distributedlog DL-136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
commit 83fc9880135d5e32dd81a68b32be423732cf4837
Author: Brennon York
Date: 2016-12-16T04:16:18Z
updated catch blocks for async reader benchmark
commit 7decca2d173d10a6bfefc13a64a5fe40b1f0ebe2
Author: Brennon York
Date: 2016-12-16T04:28:13Z
updated warn text for async reader, added catch blocks for ledger read
benchmark
commit 3a2b5533f683f5d51cc865fbe8d6a25cc850ff1b
Author: Brennon York
Date: 2016-12-16T04:34:40Z
updated logging verbage, added catch blocks for sync reader and zkmetadata
resolver
> Avoid empty catch blocks
>
>
> Key: DL-136
> URL: https://issues.apache.org/jira/browse/DL-136
> Project: DistributedLog
> Issue Type: Task
>Reporter: Sijie Guo
>Assignee: Brennon York
> Labels: help-wanted
>
> Based on the code analysis here :
> https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/, there are 22
> Times: Catching exceptions with empty bodies.
> {quote}
> There are exceptions of different types: InterruptedException,
> KeeperException, Exception, etc.. Even though we think that these exceptions
> should never occur, if they are captured it means that they are technically
> possible. In case that they do happen, it will be very difficult to know what
> is happening and to diagnose the problem. It is very recommendable, at least
> to add a log trace, in case these exceptions are triggered.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752705#comment-15752705 ] ASF GitHub Bot commented on DL-140: --- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/71 @xieliang gotcha. it might be worth having a jira to make the findbugs threshold 'LOW'. and in this jira, we need to fix those findbug warnings. for this pr, I think it is good to fix synchronization issue. > Fix several FindBug "Inconsistent synchronization" warnings > --- > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-28) generate java code failed using scrooge
[ https://issues.apache.org/jira/browse/DL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752700#comment-15752700 ] ASF GitHub Bot commented on DL-28: -- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/73 LGTM. +1 > generate java code failed using scrooge > --- > > Key: DL-28 > URL: https://issues.apache.org/jira/browse/DL-28 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-protocol >Affects Versions: 0.4.0 > Environment: Apache Maven 3.2.5 > Maven home: C:\apache-maven-3.2.5 > Java version: 1.8.0_60, vendor: Oracle Corporation > Java home: C:\Java\jdk1.8.0_60\jre > Default locale: zh_CN, platform encoding: UTF-8 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" >Reporter: weiwei >Priority: Blocker > Labels: build > Fix For: 0.4.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > [INFO] Reactor Summary: > [INFO] > [INFO] distributedlog . SUCCESS [ 0.002 > s] > [INFO] DistributedLog Protocol FAILURE [ 1.081 > s] > [INFO] DistributedLog Core Library SKIPPED > [INFO] DistributedLog Client .. SKIPPED > [INFO] DistributedLog Service . SKIPPED > [INFO] DistributedLog Benchmark ... SKIPPED > [INFO] DistributedLog Example . SKIPPED > [INFO] DistributedLog Basics .. SKIPPED > [INFO] DistributedLog Messaging Tutorial .. SKIPPED > [INFO] DistributedLog Kafka Tutorial .. SKIPPED > [INFO] DistributedLog MapReduce ... SKIPPED > [INFO] DistributedLog Tutorials ... SKIPPED > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 1.321 s > [INFO] Finished at: 2016-08-02T13:26:31+08:00 > [INFO] Final Memory: 12M/150M > [INFO] > > [ERROR] Exception parsing: > E:\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift: > [3.1] failure: string matching regex `\z' expected but `/' found > [ERROR] > [ERROR] // Response stats codes > [ERROR] > [ERROR] ^ > [ERROR] -> [Help 1] > com.twitter.scrooge.frontend.FileParseException: Exception parsing: > E:\isoftstone\workspacedeis\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift > at > com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427) > at > com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427) > at scala.Option.map(Option.scala:145) > at > com.twitter.scrooge.frontend.ThriftParser.parse(ThriftParser.scala:420) > at > com.twitter.scrooge.frontend.ThriftParser.parseFile(ThriftParser.scala:448) > at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:66) > at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:64) > at scala.collection.immutable.List.foreach(List.scala:318) > at > scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:32) > at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:45) > at com.twitter.scrooge.Compiler.run(Compiler.scala:64) > at com.twitter.ScroogeRunner.compile(ScroogeRunner.scala:45) > at > com.twitter.AbstractMavenScroogeMojo.execute(AbstractMavenScroogeMojo.java:239) > at > com.twitter.MavenScroogeCompileMojo.execute(MavenScroogeCompileMojo.java:22) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355) > a
[jira] [Commented] (DL-28) generate java code failed using scrooge
[ https://issues.apache.org/jira/browse/DL-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750285#comment-15750285 ] ASF GitHub Bot commented on DL-28: -- GitHub user xieliang opened a pull request: https://github.com/apache/incubator-distributedlog/pull/73 DL-28 : using /* */ style comment to avoid scrooge windows platform issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/xieliang/incubator-distributedlog DL-28 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit df5a66cb57e7d99e1df6e1cf29620876cd6827c6 Author: xieliang Date: 2016-12-15T03:43:46Z using /* */ style comment to avoid scrooge windows platform issue > generate java code failed using scrooge > --- > > Key: DL-28 > URL: https://issues.apache.org/jira/browse/DL-28 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-protocol >Affects Versions: 0.4.0 > Environment: Apache Maven 3.2.5 > Maven home: C:\apache-maven-3.2.5 > Java version: 1.8.0_60, vendor: Oracle Corporation > Java home: C:\Java\jdk1.8.0_60\jre > Default locale: zh_CN, platform encoding: UTF-8 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" >Reporter: weiwei >Priority: Blocker > Labels: build > Fix For: 0.4.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > [INFO] Reactor Summary: > [INFO] > [INFO] distributedlog . SUCCESS [ 0.002 > s] > [INFO] DistributedLog Protocol FAILURE [ 1.081 > s] > [INFO] DistributedLog Core Library SKIPPED > [INFO] DistributedLog Client .. SKIPPED > [INFO] DistributedLog Service . SKIPPED > [INFO] DistributedLog Benchmark ... SKIPPED > [INFO] DistributedLog Example . SKIPPED > [INFO] DistributedLog Basics .. SKIPPED > [INFO] DistributedLog Messaging Tutorial .. SKIPPED > [INFO] DistributedLog Kafka Tutorial .. SKIPPED > [INFO] DistributedLog MapReduce ... SKIPPED > [INFO] DistributedLog Tutorials ... SKIPPED > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 1.321 s > [INFO] Finished at: 2016-08-02T13:26:31+08:00 > [INFO] Final Memory: 12M/150M > [INFO] > > [ERROR] Exception parsing: > E:\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift: > [3.1] failure: string matching regex `\z' expected but `/' found > [ERROR] > [ERROR] // Response stats codes > [ERROR] > [ERROR] ^ > [ERROR] -> [Help 1] > com.twitter.scrooge.frontend.FileParseException: Exception parsing: > E:\isoftstone\workspacedeis\incubator-distributedlog\distributedlog-protocol\src\main\thrift\service.thrift > at > com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427) > at > com.twitter.scrooge.frontend.ThriftParser$$anonfun$parse$1.apply(ThriftParser.scala:427) > at scala.Option.map(Option.scala:145) > at > com.twitter.scrooge.frontend.ThriftParser.parse(ThriftParser.scala:420) > at > com.twitter.scrooge.frontend.ThriftParser.parseFile(ThriftParser.scala:448) > at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:66) > at com.twitter.scrooge.Compiler$$anonfun$run$2.apply(Compiler.scala:64) > at scala.collection.immutable.List.foreach(List.scala:318) > at > scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:32) > at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:45) > at com.twitter.scrooge.Compiler.run(Compiler.scala:64) > at com.twitter.ScroogeRunner.compile(ScroogeRunner.scala:45) > at > com.twitter.AbstractMavenScroogeMojo.execute(AbstractMavenScroogeMojo.java:239) > at > com.twitter.MavenScroogeCompileMojo.execute(MavenScroogeCompileMojo.java:22) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > at > org.apache.maven.lifecycle.internal.MojoExecuto
[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750192#comment-15750192 ] ASF GitHub Bot commented on DL-140: --- Github user xieliang commented on the issue: https://github.com/apache/incubator-distributedlog/pull/71 @sijie , in distributedlog-core pom.xml, if you add "Low" after "" config item, you will see sth like this: [INFO] BugInstance size is 120 [INFO] Error size is 0 [INFO] Total bugs: 120 Just like my result from findbugs gui view. > Fix several FindBug "Inconsistent synchronization" warnings > --- > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747138#comment-15747138 ] ASF GitHub Bot commented on DL-140: --- Github user xieliang commented on the issue: https://github.com/apache/incubator-distributedlog/pull/71 It's not the same thing. The travis ci runs with "findbugs-maven-plugin", and i ran with findbugs binary package. (From http://gleclaire.github.io/findbugs-maven-plugin/index.html , i see the core findbugs version are all 3.0.1.) Let me finger out the diff later > Fix several FindBug "Inconsistent synchronization" warnings > --- > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746993#comment-15746993 ] ASF GitHub Bot commented on DL-140: --- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/71 @xieliang I think currently we are using 3.0.3 in the pom.xml file. ` org.codehaus.mojo findbugs-maven-plugin 3.0.3 ` The travis ci runs "findbugs:check" for every pull request - "mvn --batch-mode clean package findbugs:check" is it the same command that you are running? > Fix several FindBug "Inconsistent synchronization" warnings > --- > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746952#comment-15746952 ] ASF GitHub Bot commented on DL-140: --- Github user xieliang commented on the issue: https://github.com/apache/incubator-distributedlog/pull/71 I ran the findbug (3.0.1) binary on my local devbox. Those multi-thread warings exist even after importing the findbug exclude xml file manually, what's the findbugs binary version at ci side, i guess it's obsolete... > Fix several FindBug "Inconsistent synchronization" warnings > --- > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746663#comment-15746663 ] ASF GitHub Bot commented on DL-140: --- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/71 @xieliang the change looks good. but I am interested to see how did you find this. I thought we already enable findbugs on ci jobs. I am wondering why didn't we detect the findbug warnings. > Fix several FindBug "Inconsistent synchronization" warnings > --- > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746660#comment-15746660 ] ASF GitHub Bot commented on DL-140: --- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/71 @franckcuny I passed the travis ci for both scala 2.10 and 2.11. it should be transient errors. > Fix several FindBug "Inconsistent synchronization" warnings > --- > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-135) Cleanup System.out and System.err usage
[ https://issues.apache.org/jira/browse/DL-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746651#comment-15746651 ] ASF GitHub Bot commented on DL-135: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/70 > Cleanup System.out and System.err usage > --- > > Key: DL-135 > URL: https://issues.apache.org/jira/browse/DL-135 > Project: DistributedLog > Issue Type: Task >Reporter: Sijie Guo >Assignee: Liang Xie > Labels: help-wanted > > Based on the code analysis here : > https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/ > There are 272 calls to System.out and System.err usage. Most of them might > just come from distributedlog tool. But let's still audit the code to make > sure we are using System.out and System.err correctly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-134) Add DistributedLog User MailList to pom file
[ https://issues.apache.org/jira/browse/DL-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746645#comment-15746645 ] ASF GitHub Bot commented on DL-134: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/56 > Add DistributedLog User MailList to pom file > > > Key: DL-134 > URL: https://issues.apache.org/jira/browse/DL-134 > Project: DistributedLog > Issue Type: Task >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.5.0 > > > Add distributedlog user mail list to pom file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-95) Assign host ip client id if the client id is undefined
[ https://issues.apache.org/jira/browse/DL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746640#comment-15746640 ] ASF GitHub Bot commented on DL-95: -- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/68 @franckcuny yup the change is accumulative changes. I didn't find a solution to send pull request based on other changes. The changes from DL-85 to DL-97 are accumulative. That says DL-86 includes changes in DL-85, DL-87 includes both DL-86 and DL-85. I am hoping to merge changes in the order from DL-85 to DL-97. > Assign host ip client id if the client id is undefined > -- > > Key: DL-95 > URL: https://issues.apache.org/jira/browse/DL-95 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Leigh Stewart > Fix For: 0.4.0 > > > Assign host ip client id if the client id is undefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-86) Improve handling of lock conflicts in zk session lock
[ https://issues.apache.org/jira/browse/DL-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746633#comment-15746633 ] ASF GitHub Bot commented on DL-86: -- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/58 @franckcuny I think it is a transient error. The tests passed on travis-ci but failed on apache jenkins ci. btw, for now, every pull request will be validated on both travis ci and apache jenkins. so if one passed it, it typically means it is a transient failure and should be good. we are only concerned if both of them failed. > Improve handling of lock conflicts in zk session lock > - > > Key: DL-86 > URL: https://issues.apache.org/jira/browse/DL-86 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > - lock reacquire could happen in foreground and background thread. so use a > semaphore to make sure there is only on e outstanding acquire > operation. and check if already hold lock before reacquire. > - fix handling zk sibling znode logic. as the znode is sequential znode, > the name would be different each time. so onlycomparing the client id and > session id of the znodes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-85) Publish both per-stream stats and aggregation stats
[ https://issues.apache.org/jira/browse/DL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746627#comment-15746627 ] ASF GitHub Bot commented on DL-85: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/57 > Publish both per-stream stats and aggregation stats > --- > > Key: DL-85 > URL: https://issues.apache.org/jira/browse/DL-85 > Project: DistributedLog > Issue Type: Improvement >Reporter: Sijie Guo >Assignee: Jordan Bull > Fix For: 0.5.0 > > > when publishing per stream stats, also publish aggregated stats -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-95) Assign host ip client id if the client id is undefined
[ https://issues.apache.org/jira/browse/DL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745731#comment-15745731 ] ASF GitHub Bot commented on DL-95: -- Github user franckcuny commented on the issue: https://github.com/apache/incubator-distributedlog/pull/68 @sijie this is a large change and the tests are failing. Is there anyway to reduce the scope of it ? It's hard to review. > Assign host ip client id if the client id is undefined > -- > > Key: DL-95 > URL: https://issues.apache.org/jira/browse/DL-95 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Leigh Stewart > Fix For: 0.4.0 > > > Assign host ip client id if the client id is undefined -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-140) Fix several FindBug "Inconsistent synchronization" warnings
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745729#comment-15745729 ] ASF GitHub Bot commented on DL-140: --- Github user franckcuny commented on the issue: https://github.com/apache/incubator-distributedlog/pull/71 @xieliang could you verify if the failure is due to your change ? Is the test passing on your local environment ? cc @sijie > Fix several FindBug "Inconsistent synchronization" warnings > --- > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-86) Improve handling of lock conflicts in zk session lock
[ https://issues.apache.org/jira/browse/DL-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745713#comment-15745713 ] ASF GitHub Bot commented on DL-86: -- Github user franckcuny commented on the issue: https://github.com/apache/incubator-distributedlog/pull/58 @sijie is this a transient error ? Looks like time out while doing some operation with ZK, so could be a misconfigured test too. > Improve handling of lock conflicts in zk session lock > - > > Key: DL-86 > URL: https://issues.apache.org/jira/browse/DL-86 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > - lock reacquire could happen in foreground and background thread. so use a > semaphore to make sure there is only on e outstanding acquire > operation. and check if already hold lock before reacquire. > - fix handling zk sibling znode logic. as the znode is sequential znode, > the name would be different each time. so onlycomparing the client id and > session id of the znodes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745705#comment-15745705
]
ASF GitHub Bot commented on DL-81:
--
Github user franckcuny commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/51#discussion_r92221776
--- Diff: website/community/release_guide.md ---
@@ -0,0 +1,507 @@
+---
+layout: default
+title: "DistributedLog Release Guide"
+permalink: /community/release-guide/
+---
+
+# Apache DistributedLog Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache DistributedLog
release. Creit to the
[Beam](http://distributedlog.incubator.apache.org/contribute/release-guide/)
project. We've borrow liberally from their documentation.
+
+## Introduction
+
+The Apache DistributedLog project periodically declares and publishes
releases. A release is one or more packages of the project artifact(s) that are
approved for general public distribution and use. They may come with various
degrees of caveat regarding their perceived quality and potential for change,
such as “alpha”, “beta”, “incubating”, “stable”, etc.
+
+The DistributedLog community treats releases with great importance. They
are a public face of the project and most users interact with the project only
through the releases. Releases are signed off by the entire DistributedLog
community in a public vote.
+
+Each release is executed by a *Release Manager*, who is selected among the
[DistributedLog committers]({{ site.baseurl }}/community/team). This document
describes the process that the Release Manager follows to perform a release.
Any changes to this process should be discussed and adopted on the [dev@
mailing list]({{ site.baseurl }}/community/#mailing-lists).
+
+Please remember that publishing software has legal consequences. This
guide complements the foundation-wide [Product Release
Policy](http://www.apache.org/dev/release.html) and [Release Distribution
Policy](http://www.apache.org/dev/release-distribution).
+
+## Overview
+
+![Alt text]({{ "/images/release-guide-1.png" | prepend: site.baseurl }}
"Release Process"){:width="100%"}
+
+The release process consists of several steps:
+
+1. Decide to release
+1. Prepare for the release
+1. Build a release candidate
+1. Vote on the release candidate
+1. If necessary, fix any issues and go back to step 3.
+1. Finalize the release
+1. Promote the release
+
+**
+
+## Decide to release
+
+Deciding to release and selecting a Release Manager is the first step of
the release process. This is a consensus-based decision of the entire community.
+
+Anybody can propose a release on the dev@ mailing list, giving a solid
argument and nominating a committer as the Release Manager (including
themselves). There’s no formal process, no vote requirements, and no timing
requirements. Any objections should be resolved by consensus before starting
the release.
+
+In general, the community prefers to have a rotating set of 3-5 Release
Managers. Keeping a small core set of managers allows enough people to build
expertise in this area and improve processes over time, without Release
Managers needing to re-learn the processes for each release. That said, if you
are a committer interested in serving the community in this way, please reach
out to the community on the dev@ mailing list.
+
+### Checklist to proceed to the next step
+
+1. Community agrees to release
+1. Community selects a Release Manager
+
+**
+
+## Prepare for the release
+
+Before your first release, you should perform one-time configuration
steps. This will set up your security keys for signing the release and access
to various release repositories.
+
+To prepare for each release, you should audit the project status in the
JIRA issue tracker, and do necessary bookkeeping. Finally, you should create a
release branch from which individual release candidates will be built.
+
+### One-time setup instructions
+
+ GPG Key
+
+You need to have a GPG key to sign the release artifacts. Please be aware
of the ASF-wide [release signing
guidelines](https://www.apache.org/dev/release-signing.html). If you don’t have
a GPG key associated with your Apache account, please create one according to
the guidelines.
+
+Determine your Apache GPG Key and Key ID, as follows:
+
+gpg --list-keys
+
+This will list your GPG keys. One of these should reflect your Apache
account, for example:
+
+--
+pub 2048R/845E6689 2016-02-23
+uid Nomen Nesc
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745707#comment-15745707
]
ASF GitHub Bot commented on DL-81:
--
Github user franckcuny commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/51#discussion_r92221264
--- Diff: website/community/release_guide.md ---
@@ -0,0 +1,507 @@
+---
+layout: default
+title: "DistributedLog Release Guide"
+permalink: /community/release-guide/
+---
+
+# Apache DistributedLog Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache DistributedLog
release. Creit to the
[Beam](http://distributedlog.incubator.apache.org/contribute/release-guide/)
project. We've borrow liberally from their documentation.
+
+## Introduction
+
+The Apache DistributedLog project periodically declares and publishes
releases. A release is one or more packages of the project artifact(s) that are
approved for general public distribution and use. They may come with various
degrees of caveat regarding their perceived quality and potential for change,
such as “alpha”, “beta”, “incubating”, “stable”, etc.
+
+The DistributedLog community treats releases with great importance. They
are a public face of the project and most users interact with the project only
through the releases. Releases are signed off by the entire DistributedLog
community in a public vote.
+
+Each release is executed by a *Release Manager*, who is selected among the
[DistributedLog committers]({{ site.baseurl }}/community/team). This document
describes the process that the Release Manager follows to perform a release.
Any changes to this process should be discussed and adopted on the [dev@
mailing list]({{ site.baseurl }}/community/#mailing-lists).
+
+Please remember that publishing software has legal consequences. This
guide complements the foundation-wide [Product Release
Policy](http://www.apache.org/dev/release.html) and [Release Distribution
Policy](http://www.apache.org/dev/release-distribution).
+
+## Overview
+
+![Alt text]({{ "/images/release-guide-1.png" | prepend: site.baseurl }}
"Release Process"){:width="100%"}
+
+The release process consists of several steps:
+
+1. Decide to release
+1. Prepare for the release
+1. Build a release candidate
+1. Vote on the release candidate
+1. If necessary, fix any issues and go back to step 3.
+1. Finalize the release
+1. Promote the release
+
+**
+
+## Decide to release
+
+Deciding to release and selecting a Release Manager is the first step of
the release process. This is a consensus-based decision of the entire community.
+
+Anybody can propose a release on the dev@ mailing list, giving a solid
argument and nominating a committer as the Release Manager (including
themselves). There’s no formal process, no vote requirements, and no timing
requirements. Any objections should be resolved by consensus before starting
the release.
+
+In general, the community prefers to have a rotating set of 3-5 Release
Managers. Keeping a small core set of managers allows enough people to build
expertise in this area and improve processes over time, without Release
Managers needing to re-learn the processes for each release. That said, if you
are a committer interested in serving the community in this way, please reach
out to the community on the dev@ mailing list.
+
+### Checklist to proceed to the next step
+
+1. Community agrees to release
+1. Community selects a Release Manager
+
+**
+
+## Prepare for the release
+
+Before your first release, you should perform one-time configuration
steps. This will set up your security keys for signing the release and access
to various release repositories.
+
+To prepare for each release, you should audit the project status in the
JIRA issue tracker, and do necessary bookkeeping. Finally, you should create a
release branch from which individual release candidates will be built.
+
+### One-time setup instructions
+
+ GPG Key
+
+You need to have a GPG key to sign the release artifacts. Please be aware
of the ASF-wide [release signing
guidelines](https://www.apache.org/dev/release-signing.html). If you don’t have
a GPG key associated with your Apache account, please create one according to
the guidelines.
+
+Determine your Apache GPG Key and Key ID, as follows:
+
+gpg --list-keys
+
+This will list your GPG keys. One of these should reflect your Apache
account, for example:
+
+--
+pub 2048R/845E6689 2016-02-23
+uid Nomen Nesc
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745706#comment-15745706
]
ASF GitHub Bot commented on DL-81:
--
Github user franckcuny commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/51#discussion_r92221508
--- Diff: website/community/release_guide.md ---
@@ -0,0 +1,507 @@
+---
+layout: default
+title: "DistributedLog Release Guide"
+permalink: /community/release-guide/
+---
+
+# Apache DistributedLog Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache DistributedLog
release. Creit to the
[Beam](http://distributedlog.incubator.apache.org/contribute/release-guide/)
project. We've borrow liberally from their documentation.
+
+## Introduction
+
+The Apache DistributedLog project periodically declares and publishes
releases. A release is one or more packages of the project artifact(s) that are
approved for general public distribution and use. They may come with various
degrees of caveat regarding their perceived quality and potential for change,
such as “alpha”, “beta”, “incubating”, “stable”, etc.
+
+The DistributedLog community treats releases with great importance. They
are a public face of the project and most users interact with the project only
through the releases. Releases are signed off by the entire DistributedLog
community in a public vote.
+
+Each release is executed by a *Release Manager*, who is selected among the
[DistributedLog committers]({{ site.baseurl }}/community/team). This document
describes the process that the Release Manager follows to perform a release.
Any changes to this process should be discussed and adopted on the [dev@
mailing list]({{ site.baseurl }}/community/#mailing-lists).
+
+Please remember that publishing software has legal consequences. This
guide complements the foundation-wide [Product Release
Policy](http://www.apache.org/dev/release.html) and [Release Distribution
Policy](http://www.apache.org/dev/release-distribution).
+
+## Overview
+
+![Alt text]({{ "/images/release-guide-1.png" | prepend: site.baseurl }}
"Release Process"){:width="100%"}
+
+The release process consists of several steps:
+
+1. Decide to release
+1. Prepare for the release
+1. Build a release candidate
+1. Vote on the release candidate
+1. If necessary, fix any issues and go back to step 3.
+1. Finalize the release
+1. Promote the release
+
+**
+
+## Decide to release
+
+Deciding to release and selecting a Release Manager is the first step of
the release process. This is a consensus-based decision of the entire community.
+
+Anybody can propose a release on the dev@ mailing list, giving a solid
argument and nominating a committer as the Release Manager (including
themselves). There’s no formal process, no vote requirements, and no timing
requirements. Any objections should be resolved by consensus before starting
the release.
+
+In general, the community prefers to have a rotating set of 3-5 Release
Managers. Keeping a small core set of managers allows enough people to build
expertise in this area and improve processes over time, without Release
Managers needing to re-learn the processes for each release. That said, if you
are a committer interested in serving the community in this way, please reach
out to the community on the dev@ mailing list.
+
+### Checklist to proceed to the next step
+
+1. Community agrees to release
+1. Community selects a Release Manager
+
+**
+
+## Prepare for the release
+
+Before your first release, you should perform one-time configuration
steps. This will set up your security keys for signing the release and access
to various release repositories.
+
+To prepare for each release, you should audit the project status in the
JIRA issue tracker, and do necessary bookkeeping. Finally, you should create a
release branch from which individual release candidates will be built.
+
+### One-time setup instructions
+
+ GPG Key
+
+You need to have a GPG key to sign the release artifacts. Please be aware
of the ASF-wide [release signing
guidelines](https://www.apache.org/dev/release-signing.html). If you don’t have
a GPG key associated with your Apache account, please create one according to
the guidelines.
+
+Determine your Apache GPG Key and Key ID, as follows:
+
+gpg --list-keys
+
+This will list your GPG keys. One of these should reflect your Apache
account, for example:
+
+--
+pub 2048R/845E6689 2016-02-23
+uid Nomen Nesc
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745704#comment-15745704
]
ASF GitHub Bot commented on DL-81:
--
Github user franckcuny commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/51#discussion_r9009
--- Diff: website/community/release_guide.md ---
@@ -0,0 +1,507 @@
+---
+layout: default
+title: "DistributedLog Release Guide"
+permalink: /community/release-guide/
+---
+
+# Apache DistributedLog Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache DistributedLog
release. Creit to the
[Beam](http://distributedlog.incubator.apache.org/contribute/release-guide/)
project. We've borrow liberally from their documentation.
--- End diff --
creit ? Did you mean credit ?
> Build the distributedlog release procedure
> --
>
> Key: DL-81
> URL: https://issues.apache.org/jira/browse/DL-81
> Project: DistributedLog
> Issue Type: Task
> Components: documentation
>Reporter: Sijie Guo
>Assignee: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> this is the ticket to track building the release procedure for distributedlog
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745701#comment-15745701
]
ASF GitHub Bot commented on DL-81:
--
Github user franckcuny commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/51#discussion_r92220975
--- Diff: website/community/release_guide.md ---
@@ -0,0 +1,507 @@
+---
+layout: default
+title: "DistributedLog Release Guide"
+permalink: /community/release-guide/
+---
+
+# Apache DistributedLog Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache DistributedLog
release. Creit to the
[Beam](http://distributedlog.incubator.apache.org/contribute/release-guide/)
project. We've borrow liberally from their documentation.
+
+## Introduction
+
+The Apache DistributedLog project periodically declares and publishes
releases. A release is one or more packages of the project artifact(s) that are
approved for general public distribution and use. They may come with various
degrees of caveat regarding their perceived quality and potential for change,
such as “alpha”, “beta”, “incubating”, “stable”, etc.
+
+The DistributedLog community treats releases with great importance. They
are a public face of the project and most users interact with the project only
through the releases. Releases are signed off by the entire DistributedLog
community in a public vote.
+
+Each release is executed by a *Release Manager*, who is selected among the
[DistributedLog committers]({{ site.baseurl }}/community/team). This document
describes the process that the Release Manager follows to perform a release.
Any changes to this process should be discussed and adopted on the [dev@
mailing list]({{ site.baseurl }}/community/#mailing-lists).
+
+Please remember that publishing software has legal consequences. This
guide complements the foundation-wide [Product Release
Policy](http://www.apache.org/dev/release.html) and [Release Distribution
Policy](http://www.apache.org/dev/release-distribution).
+
+## Overview
+
+![Alt text]({{ "/images/release-guide-1.png" | prepend: site.baseurl }}
"Release Process"){:width="100%"}
+
+The release process consists of several steps:
+
+1. Decide to release
+1. Prepare for the release
--- End diff --
use a bullet or increment the number ?
> Build the distributedlog release procedure
> --
>
> Key: DL-81
> URL: https://issues.apache.org/jira/browse/DL-81
> Project: DistributedLog
> Issue Type: Task
> Components: documentation
>Reporter: Sijie Guo
>Assignee: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> this is the ticket to track building the release procedure for distributedlog
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745703#comment-15745703
]
ASF GitHub Bot commented on DL-81:
--
Github user franckcuny commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/51#discussion_r92221057
--- Diff: website/community/release_guide.md ---
@@ -0,0 +1,507 @@
+---
+layout: default
+title: "DistributedLog Release Guide"
+permalink: /community/release-guide/
+---
+
+# Apache DistributedLog Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache DistributedLog
release. Creit to the
[Beam](http://distributedlog.incubator.apache.org/contribute/release-guide/)
project. We've borrow liberally from their documentation.
+
+## Introduction
+
+The Apache DistributedLog project periodically declares and publishes
releases. A release is one or more packages of the project artifact(s) that are
approved for general public distribution and use. They may come with various
degrees of caveat regarding their perceived quality and potential for change,
such as “alpha”, “beta”, “incubating”, “stable”, etc.
+
+The DistributedLog community treats releases with great importance. They
are a public face of the project and most users interact with the project only
through the releases. Releases are signed off by the entire DistributedLog
community in a public vote.
+
+Each release is executed by a *Release Manager*, who is selected among the
[DistributedLog committers]({{ site.baseurl }}/community/team). This document
describes the process that the Release Manager follows to perform a release.
Any changes to this process should be discussed and adopted on the [dev@
mailing list]({{ site.baseurl }}/community/#mailing-lists).
+
+Please remember that publishing software has legal consequences. This
guide complements the foundation-wide [Product Release
Policy](http://www.apache.org/dev/release.html) and [Release Distribution
Policy](http://www.apache.org/dev/release-distribution).
+
+## Overview
+
+![Alt text]({{ "/images/release-guide-1.png" | prepend: site.baseurl }}
"Release Process"){:width="100%"}
+
+The release process consists of several steps:
+
+1. Decide to release
+1. Prepare for the release
+1. Build a release candidate
+1. Vote on the release candidate
+1. If necessary, fix any issues and go back to step 3.
+1. Finalize the release
+1. Promote the release
+
+**
+
+## Decide to release
+
+Deciding to release and selecting a Release Manager is the first step of
the release process. This is a consensus-based decision of the entire community.
+
+Anybody can propose a release on the dev@ mailing list, giving a solid
argument and nominating a committer as the Release Manager (including
themselves). There’s no formal process, no vote requirements, and no timing
requirements. Any objections should be resolved by consensus before starting
the release.
+
+In general, the community prefers to have a rotating set of 3-5 Release
Managers. Keeping a small core set of managers allows enough people to build
expertise in this area and improve processes over time, without Release
Managers needing to re-learn the processes for each release. That said, if you
are a committer interested in serving the community in this way, please reach
out to the community on the dev@ mailing list.
+
+### Checklist to proceed to the next step
+
+1. Community agrees to release
--- End diff --
same, use a bullet or increment.
> Build the distributedlog release procedure
> --
>
> Key: DL-81
> URL: https://issues.apache.org/jira/browse/DL-81
> Project: DistributedLog
> Issue Type: Task
> Components: documentation
>Reporter: Sijie Guo
>Assignee: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> this is the ticket to track building the release procedure for distributedlog
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-97) Remove unused methods in BKLogHandler
[ https://issues.apache.org/jira/browse/DL-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745659#comment-15745659 ] ASF GitHub Bot commented on DL-97: -- Github user franckcuny commented on the issue: https://github.com/apache/incubator-distributedlog/pull/69 @sijie the build is failing with the following error: ``` Results : Failed tests: testPositionUpdatesOnlyAfterWriteCompletionWithoutFsync(com.twitter.distributedlog.TestAppendOnlyStreamWriter): expected:<33> but was:<0> Tests run: 490, Failures: 1, Errors: 0, Skipped: 9 [ERROR] There are test failures. ``` is this transient ? Or do you need to review the change. > Remove unused methods in BKLogHandler > - > > Key: DL-97 > URL: https://issues.apache.org/jira/browse/DL-97 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Leigh Stewart > Fix For: 0.4.0 > > > Remove unused methods in BKLogHandler -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-140) Fix several "Inconsistent synchronization"s from FindBug warning
[ https://issues.apache.org/jira/browse/DL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744766#comment-15744766 ] ASF GitHub Bot commented on DL-140: --- GitHub user xieliang opened a pull request: https://github.com/apache/incubator-distributedlog/pull/71 DL-140 : Fix distributedlog-core findbug inconsistent synchronization warings You can merge this pull request into a Git repository by running: $ git pull https://github.com/xieliang/incubator-distributedlog DL-140 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit febd945ffa409d861d0f783a78831b88ae56c540 Author: xieliang Date: 2016-12-13T10:11:02Z Fix distributedlog-core findbug inconsistent synchronization warings > Fix several "Inconsistent synchronization"s from FindBug warning > > > Key: DL-140 > URL: https://issues.apache.org/jira/browse/DL-140 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-core >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > > Through most of findbug warnings are false alarm or trivial issues, we need > to fix the "Multithreaded correctness" related warning if occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-135) Cleanup System.out and System.err usage
[ https://issues.apache.org/jira/browse/DL-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744645#comment-15744645 ] ASF GitHub Bot commented on DL-135: --- Github user xiliuant commented on the issue: https://github.com/apache/incubator-distributedlog/pull/70 the change looks good to me +1 > Cleanup System.out and System.err usage > --- > > Key: DL-135 > URL: https://issues.apache.org/jira/browse/DL-135 > Project: DistributedLog > Issue Type: Task >Reporter: Sijie Guo >Assignee: Liang Xie > Labels: help-wanted > > Based on the code analysis here : > https://www.kiuwan.com/blog/analyzing_distributedlog_twitter-2/ > There are 272 calls to System.out and System.err usage. Most of them might > just come from distributedlog tool. But let's still audit the code to make > sure we are using System.out and System.err correctly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-97) Remove unused methods in BKLogHandler
[ https://issues.apache.org/jira/browse/DL-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743940#comment-15743940 ] ASF GitHub Bot commented on DL-97: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/69 DL-97: Remove unused methods in BKLogHandler merge code change on remove unused methods in BKLogHandler. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-97 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 commit 800b867b705a786094b9a591e0ebc64fa934f632 Author: Dave Rusek Date: 2016-12-13T00:41:47Z Don't use stack and codec together for configuring thriftmux - Don't use stack and codec together for configuring thriftmux - Remove codec if the thriftmux is disabled commit 0a18f564ba7e4d03f4c6a0859e5478535a59befd Author: Leigh Stewart Date: 2016-12-13T00:46:11Z Be able to close the writer within a timeout period RB_ID=841340 commit f19e7564ff4a1ec1b5d6f2683db190d739df99bb Author: Leigh Stewart Date: 2016-12-13T00:49:26Z Simplify the state transition on stream * the stream is created on INITIALIZING * when the stream is started, it would start transition from INITIALIZING to INITIALIZED * it would serve stream operations when the stream is INITIALIZED * it would be turned to ERROR when encountered exceptions. * the stream would be closed when service operation timeout or encountered any exceptions. it would first be removed from acquired mapping * the stream would be removed from cached mapping depends on probation time. RB_ID=848047 commit f008f751ec0a020a670903b01c709007ada87381 Author: Sijie Guo Date: 2016-07-08T22:22:55Z Allow configuring flush interval in micros for distributedlog multi streams writer RB_ID=846974 commit 72a786e78540fb5a3f8e27f9d71d3616d06d1548 Author: Sijie Guo Date: 2016-07-11T17:10:55Z LogSegmentMetadataStore should only notify when the list of log segments is updated Currently it notifies the listeners not only when there is a change but also when session expires. it would break the readahead loop and cause readers have to wait until it is able to connect to zookeeper again. With this change, it would only notify when the list of log segments is updated. If it disconnects to zookeeper, the listener won't be notified and it would keep reading from the log segments it knows. RB_ID=842998 commit f18fe172fb4559bcabb7173d1cd0b9d27fc23c93 Author: Sijie Guo Date: 2016-07-11T17:21:44Z Make the zookeeper client used by bookke
[jira] [Commented] (DL-94) Make the zookeeper client used by bookkeeper client retry on session expires
[ https://issues.apache.org/jira/browse/DL-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743935#comment-15743935 ] ASF GitHub Bot commented on DL-94: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/67 DL-94: Make the zookeeper client used by bookkeeper client retry on session expires merge twitter's change on session expires You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-94 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 commit 800b867b705a786094b9a591e0ebc64fa934f632 Author: Dave Rusek Date: 2016-12-13T00:41:47Z Don't use stack and codec together for configuring thriftmux - Don't use stack and codec together for configuring thriftmux - Remove codec if the thriftmux is disabled commit 0a18f564ba7e4d03f4c6a0859e5478535a59befd Author: Leigh Stewart Date: 2016-12-13T00:46:11Z Be able to close the writer within a timeout period RB_ID=841340 commit f19e7564ff4a1ec1b5d6f2683db190d739df99bb Author: Leigh Stewart Date: 2016-12-13T00:49:26Z Simplify the state transition on stream * the stream is created on INITIALIZING * when the stream is started, it would start transition from INITIALIZING to INITIALIZED * it would serve stream operations when the stream is INITIALIZED * it would be turned to ERROR when encountered exceptions. * the stream would be closed when service operation timeout or encountered any exceptions. it would first be removed from acquired mapping * the stream would be removed from cached mapping depends on probation time. RB_ID=848047 commit f008f751ec0a020a670903b01c709007ada87381 Author: Sijie Guo Date: 2016-07-08T22:22:55Z Allow configuring flush interval in micros for distributedlog multi streams writer RB_ID=846974 commit 72a786e78540fb5a3f8e27f9d71d3616d06d1548 Author: Sijie Guo Date: 2016-07-11T17:10:55Z LogSegmentMetadataStore should only notify when the list of log segments is updated Currently it notifies the listeners not only when there is a change but also when session expires. it would break the readahead loop and cause readers have to wait until it is able to connect to zookeeper again. With this change, it would only notify when the list of log segments is updated. If it disconnects to zookeeper, the listener won't be notified and it would keep reading from the log segments it knows. RB_ID=842998 commit f18fe172fb4559bcabb7173d1cd0b9d27fc23c93 Author: Sijie Guo Date: 2016-07-11T17:21:44Z Make the zookeeper
[jira] [Commented] (DL-95) Assign host ip client id if the client id is undefined
[ https://issues.apache.org/jira/browse/DL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743937#comment-15743937 ] ASF GitHub Bot commented on DL-95: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/68 DL-95: Assign host ip client id if the client id is undefined merge twitter's change on client id You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-95 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 commit 800b867b705a786094b9a591e0ebc64fa934f632 Author: Dave Rusek Date: 2016-12-13T00:41:47Z Don't use stack and codec together for configuring thriftmux - Don't use stack and codec together for configuring thriftmux - Remove codec if the thriftmux is disabled commit 0a18f564ba7e4d03f4c6a0859e5478535a59befd Author: Leigh Stewart Date: 2016-12-13T00:46:11Z Be able to close the writer within a timeout period RB_ID=841340 commit f19e7564ff4a1ec1b5d6f2683db190d739df99bb Author: Leigh Stewart Date: 2016-12-13T00:49:26Z Simplify the state transition on stream * the stream is created on INITIALIZING * when the stream is started, it would start transition from INITIALIZING to INITIALIZED * it would serve stream operations when the stream is INITIALIZED * it would be turned to ERROR when encountered exceptions. * the stream would be closed when service operation timeout or encountered any exceptions. it would first be removed from acquired mapping * the stream would be removed from cached mapping depends on probation time. RB_ID=848047 commit f008f751ec0a020a670903b01c709007ada87381 Author: Sijie Guo Date: 2016-07-08T22:22:55Z Allow configuring flush interval in micros for distributedlog multi streams writer RB_ID=846974 commit 72a786e78540fb5a3f8e27f9d71d3616d06d1548 Author: Sijie Guo Date: 2016-07-11T17:10:55Z LogSegmentMetadataStore should only notify when the list of log segments is updated Currently it notifies the listeners not only when there is a change but also when session expires. it would break the readahead loop and cause readers have to wait until it is able to connect to zookeeper again. With this change, it would only notify when the list of log segments is updated. If it disconnects to zookeeper, the listener won't be notified and it would keep reading from the log segments it knows. RB_ID=842998 commit f18fe172fb4559bcabb7173d1cd0b9d27fc23c93 Author: Sijie Guo Date: 2016-07-11T17:21:44Z Make the zookeeper client used by bookkeeper cl
[jira] [Commented] (DL-92) Simplify the state transition on stream
[ https://issues.apache.org/jira/browse/DL-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743932#comment-15743932 ] ASF GitHub Bot commented on DL-92: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/65 DL-92: Simplify the state transition on stream merge twitter's change on simplifying the stream state transition You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-92 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 commit 800b867b705a786094b9a591e0ebc64fa934f632 Author: Dave Rusek Date: 2016-12-13T00:41:47Z Don't use stack and codec together for configuring thriftmux - Don't use stack and codec together for configuring thriftmux - Remove codec if the thriftmux is disabled commit 0a18f564ba7e4d03f4c6a0859e5478535a59befd Author: Leigh Stewart Date: 2016-12-13T00:46:11Z Be able to close the writer within a timeout period RB_ID=841340 commit f19e7564ff4a1ec1b5d6f2683db190d739df99bb Author: Leigh Stewart Date: 2016-12-13T00:49:26Z Simplify the state transition on stream * the stream is created on INITIALIZING * when the stream is started, it would start transition from INITIALIZING to INITIALIZED * it would serve stream operations when the stream is INITIALIZED * it would be turned to ERROR when encountered exceptions. * the stream would be closed when service operation timeout or encountered any exceptions. it would first be removed from acquired mapping * the stream would be removed from cached mapping depends on probation time. RB_ID=848047 > Simplify the state transition on stream > --- > > Key: DL-92 > URL: https://issues.apache.org/jira/browse/DL-92 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-service >Affects Versions: 0.4.0 >Reporter: Sijie Guo >Assignee: Leigh Stewart > > Simplify the state transition on stream > * the stream is created on INITIALIZING > * when the stream is started, it would start transition from INITIALIZING > to INITIALIZED > * it would serve stream operations when the stream is INITIALIZED > * it would be turned to ERROR when encountered exceptions. > * the stream would be closed when service operation timeout or > encountered any exceptions. it would first be removed from acquired mapping > * the stream would be removed from cached mapping depends on probation > time. -- This mess
[jira] [Commented] (DL-93) LogSegmentMetadataStore should only notify when the list of log segments is updated
[ https://issues.apache.org/jira/browse/DL-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743934#comment-15743934 ] ASF GitHub Bot commented on DL-93: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/66 DL-93: LogSegmentMetadataStore should only notify when the list of log segments is updated merge twitter's change on log segment metadata store. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-93 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 commit 800b867b705a786094b9a591e0ebc64fa934f632 Author: Dave Rusek Date: 2016-12-13T00:41:47Z Don't use stack and codec together for configuring thriftmux - Don't use stack and codec together for configuring thriftmux - Remove codec if the thriftmux is disabled commit 0a18f564ba7e4d03f4c6a0859e5478535a59befd Author: Leigh Stewart Date: 2016-12-13T00:46:11Z Be able to close the writer within a timeout period RB_ID=841340 commit f19e7564ff4a1ec1b5d6f2683db190d739df99bb Author: Leigh Stewart Date: 2016-12-13T00:49:26Z Simplify the state transition on stream * the stream is created on INITIALIZING * when the stream is started, it would start transition from INITIALIZING to INITIALIZED * it would serve stream operations when the stream is INITIALIZED * it would be turned to ERROR when encountered exceptions. * the stream would be closed when service operation timeout or encountered any exceptions. it would first be removed from acquired mapping * the stream would be removed from cached mapping depends on probation time. RB_ID=848047 commit f008f751ec0a020a670903b01c709007ada87381 Author: Sijie Guo Date: 2016-07-08T22:22:55Z Allow configuring flush interval in micros for distributedlog multi streams writer RB_ID=846974 commit 72a786e78540fb5a3f8e27f9d71d3616d06d1548 Author: Sijie Guo Date: 2016-07-11T17:10:55Z LogSegmentMetadataStore should only notify when the list of log segments is updated Currently it notifies the listeners not only when there is a change but also when session expires. it would break the readahead loop and cause readers have to wait until it is able to connect to zookeeper again. With this change, it would only notify when the list of log segments is updated. If it disconnects to zookeeper, the listener won't be notified and it would keep reading from the log segments it knows. RB_ID=842998 > LogSegmentMetadataStore should only notify when the list of log segments is > updated > --
[jira] [Commented] (DL-91) Be able to close writer within a timeout duration
[ https://issues.apache.org/jira/browse/DL-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743929#comment-15743929 ] ASF GitHub Bot commented on DL-91: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/64 DL-91: Be able to close writer within a timeout duration merge twitter's change on closing writer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-91 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 commit 800b867b705a786094b9a591e0ebc64fa934f632 Author: Dave Rusek Date: 2016-12-13T00:41:47Z Don't use stack and codec together for configuring thriftmux - Don't use stack and codec together for configuring thriftmux - Remove codec if the thriftmux is disabled commit 0a18f564ba7e4d03f4c6a0859e5478535a59befd Author: Leigh Stewart Date: 2016-12-13T00:46:11Z Be able to close the writer within a timeout period RB_ID=841340 > Be able to close writer within a timeout duration > - > > Key: DL-91 > URL: https://issues.apache.org/jira/browse/DL-91 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-client >Reporter: Sijie Guo >Assignee: Leigh Stewart > > If a stream is hanging on closing the writer on write proxy, it will cause > STEAM_UNAVAILABLE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-91) Be able to close writer within a timeout duration
[ https://issues.apache.org/jira/browse/DL-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743927#comment-15743927 ] ASF GitHub Bot commented on DL-91: -- Github user sijie closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/63 > Be able to close writer within a timeout duration > - > > Key: DL-91 > URL: https://issues.apache.org/jira/browse/DL-91 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-client >Reporter: Sijie Guo >Assignee: Leigh Stewart > > If a stream is hanging on closing the writer on write proxy, it will cause > STEAM_UNAVAILABLE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-91) Be able to close writer within a timeout duration
[ https://issues.apache.org/jira/browse/DL-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743924#comment-15743924 ] ASF GitHub Bot commented on DL-91: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/63 DL-91: Be able to close writer within a timeout duration merge twitter's change on closing writer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-96 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 commit 800b867b705a786094b9a591e0ebc64fa934f632 Author: Dave Rusek Date: 2016-12-13T00:41:47Z Don't use stack and codec together for configuring thriftmux - Don't use stack and codec together for configuring thriftmux - Remove codec if the thriftmux is disabled commit 0a18f564ba7e4d03f4c6a0859e5478535a59befd Author: Leigh Stewart Date: 2016-12-13T00:46:11Z Be able to close the writer within a timeout period RB_ID=841340 commit f19e7564ff4a1ec1b5d6f2683db190d739df99bb Author: Leigh Stewart Date: 2016-12-13T00:49:26Z Simplify the state transition on stream * the stream is created on INITIALIZING * when the stream is started, it would start transition from INITIALIZING to INITIALIZED * it would serve stream operations when the stream is INITIALIZED * it would be turned to ERROR when encountered exceptions. * the stream would be closed when service operation timeout or encountered any exceptions. it would first be removed from acquired mapping * the stream would be removed from cached mapping depends on probation time. RB_ID=848047 commit f008f751ec0a020a670903b01c709007ada87381 Author: Sijie Guo Date: 2016-07-08T22:22:55Z Allow configuring flush interval in micros for distributedlog multi streams writer RB_ID=846974 commit 72a786e78540fb5a3f8e27f9d71d3616d06d1548 Author: Sijie Guo Date: 2016-07-11T17:10:55Z LogSegmentMetadataStore should only notify when the list of log segments is updated Currently it notifies the listeners not only when there is a change but also when session expires. it would break the readahead loop and cause readers have to wait until it is able to connect to zookeeper again. With this change, it would only notify when the list of log segments is updated. If it disconnects to zookeeper, the listener won't be notified and it would keep reading from the log segments it knows. RB_ID=842998 commit f18fe172fb4559bcabb7173d1cd0b9d27fc23c93 Author: Sijie Guo Date: 2016-07-11T17:21:44Z Make the zookeeper client used by bookkeeper c
[jira] [Commented] (DL-89) add flag to enable thrift mux on DL monitor service
[ https://issues.apache.org/jira/browse/DL-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743920#comment-15743920 ] ASF GitHub Bot commented on DL-89: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/61 DL-89: add flag to enable thrift mux on DL monitor service merge twitter's change from David Rusek. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-89 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 > add flag to enable thrift mux on DL monitor service > --- > > Key: DL-89 > URL: https://issues.apache.org/jira/browse/DL-89 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-service >Reporter: Sijie Guo >Assignee: David Rusek > Fix For: 0.4.0 > > > provide the ability to enable thriftmux on monitor service -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-90) Don't use stack and codec together for configuring thriftmux
[ https://issues.apache.org/jira/browse/DL-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743921#comment-15743921 ] ASF GitHub Bot commented on DL-90: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/62 DL-90: Don't use stack and codec together for configuring thriftmux merge Twitter's change on thriftmux You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-90 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 commit d3a97bc0dde0c25516840725599ac46fa03601ab Author: Dave Rusek Date: 2016-06-06T23:50:25Z dl: add flag to enable thrift mux on DL Client RB_ID=839555 commit 800b867b705a786094b9a591e0ebc64fa934f632 Author: Dave Rusek Date: 2016-12-13T00:41:47Z Don't use stack and codec together for configuring thriftmux - Don't use stack and codec together for configuring thriftmux - Remove codec if the thriftmux is disabled > Don't use stack and codec together for configuring thriftmux > > > Key: DL-90 > URL: https://issues.apache.org/jira/browse/DL-90 > Project: DistributedLog > Issue Type: Bug > Components: distributedlog-client, distributedlog-service >Affects Versions: 0.4.0 >Reporter: Sijie Guo >Assignee: David Rusek > > - Don't use stack and codec together for configuring thriftmux > - Remove codec if the thriftmux is disabled -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-88) remove watches when unregister children watches
[ https://issues.apache.org/jira/browse/DL-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743918#comment-15743918 ] ASF GitHub Bot commented on DL-88: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/60 DL-88: remove watches when unregister children watches merge twitter's change from Sijie Guo You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-88 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. commit b571d3b4adcc140acca881979782474c27459d34 Author: Sijie Guo Date: 2016-05-24T04:01:57Z DL: remove watches when unregister children watches RB_ID=833858 commit 98dc9ab2df8af7af26ca68dbe93be3d420cda417 Author: Sijie Guo Date: 2016-05-27T00:06:31Z Remove watcher only when it registered watcher (reduce the annoying logging from zookeeper client about "Failed to find watcher!" RB_ID=837073 > remove watches when unregister children watches > --- > > Key: DL-88 > URL: https://issues.apache.org/jira/browse/DL-88 > Project: DistributedLog > Issue Type: New Feature > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > use the new zk removeWatches api to remove watchers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-87) Introduce periodic keepalive control record in writer
[ https://issues.apache.org/jira/browse/DL-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743914#comment-15743914 ] ASF GitHub Bot commented on DL-87: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/59 DL-87: Introduce periodic keepalive control record in writer merge twitter's change from Leigh Stewart You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-87 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 commit 517c77c164cb989ae9829cbd80bf2e492eb8e364 Author: Leigh Stewart Date: 2016-12-13T00:33:33Z Introduce periodic keepalive control record in writer * so the writer will periodically write 'keepalive' control record to make sure the stream is alive. so if the write proxy is disconnected from bookies, the control record will fail to write hence write proxy gets a chance to drop the ownership. > Introduce periodic keepalive control record in writer > - > > Key: DL-87 > URL: https://issues.apache.org/jira/browse/DL-87 > Project: DistributedLog > Issue Type: New Feature >Reporter: Sijie Guo >Assignee: Leigh Stewart > Fix For: 0.4.0 > > > the writer will periodically write 'keepalive' control record to make sure > the stream is alive. so if the write proxy is disconnected from bookies, the > control record will fail to write hence write proxy gets a chance to drop the > ownership. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-86) Improve handling of lock conflicts in zk session lock
[ https://issues.apache.org/jira/browse/DL-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743912#comment-15743912 ] ASF GitHub Bot commented on DL-86: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/58 DL-86: Improve handling of lock conflicts in zk session lock merge twitter's change from Sijie Guo. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-86 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 commit 7b46a9ac6bb5d520366069c244332347ef019e8e Author: Sijie Guo Date: 2016-05-23T23:49:19Z Improve handling of lock conflicts in zk session lock - lock reacquire could happen in foreground and background thread. so use a semaphore to make sure there is only on e outstanding acquire operation. and check if already hold lock before reacquire. - fix handling zk sibling znode logic. as the znode is sequential znode, the name would be different each time. so only comparing the client id and session id of the znodes RB_ID=833945 > Improve handling of lock conflicts in zk session lock > - > > Key: DL-86 > URL: https://issues.apache.org/jira/browse/DL-86 > Project: DistributedLog > Issue Type: Improvement > Components: distributedlog-core >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > - lock reacquire could happen in foreground and background thread. so use a > semaphore to make sure there is only on e outstanding acquire > operation. and check if already hold lock before reacquire. > - fix handling zk sibling znode logic. as the znode is sequential znode, > the name would be different each time. so onlycomparing the client id and > session id of the znodes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-85) Publish both per-stream stats and aggregation stats
[ https://issues.apache.org/jira/browse/DL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743909#comment-15743909 ] ASF GitHub Bot commented on DL-85: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/57 DL-85: Publish both per-stream stats and aggregation stats merge twittter's changes from Jordan Bull. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog merge/DL-85 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit 904b8986b46fc908cfd1a0ee05b35dce77d12f5c Author: Jordan Bull Date: 2016-05-13T18:27:19Z when publishing per partition stats, also publish per stream stats RB_ID=820062 commit 00919605f1bfa3f3e0c8514dc63552df4eeb3cc2 Author: Jordan Bull Date: 2016-05-18T17:18:34Z use zero padded partition strings in stats RB_ID=833803 > Publish both per-stream stats and aggregation stats > --- > > Key: DL-85 > URL: https://issues.apache.org/jira/browse/DL-85 > Project: DistributedLog > Issue Type: Improvement >Reporter: Sijie Guo >Assignee: Jordan Bull > Fix For: 0.4.0 > > > when publishing per stream stats, also publish aggregated stats -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-134) Add DistributedLog User MailList to pom file
[ https://issues.apache.org/jira/browse/DL-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743897#comment-15743897 ] ASF GitHub Bot commented on DL-134: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/56#discussion_r92087267 --- Diff: pom.xml --- @@ -52,6 +52,13 @@ + DistributedLog User + user-subscr...@distributedlog.incubator.apache.org + user-unsubscr...@distributedlog.incubator.apache.org + u...@distributedlog.incubator.apache.org + http://www.mail-archive.com/user%distributedlog.incubator.apache.org --- End diff -- I don't think we need to encode the @ in the xml. I updated the pom file to use 'user@distributedlog' now. > Add DistributedLog User MailList to pom file > > > Key: DL-134 > URL: https://issues.apache.org/jira/browse/DL-134 > Project: DistributedLog > Issue Type: Task >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > Add distributedlog user mail list to pom file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-127) Fix coverall report
[ https://issues.apache.org/jira/browse/DL-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743533#comment-15743533 ] ASF GitHub Bot commented on DL-127: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/53 > Fix coverall report > --- > > Key: DL-127 > URL: https://issues.apache.org/jira/browse/DL-127 > Project: DistributedLog > Issue Type: Bug > Components: builds >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > Make coverall reports work -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-127) Fix coverall report
[ https://issues.apache.org/jira/browse/DL-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742985#comment-15742985 ] ASF GitHub Bot commented on DL-127: --- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/53 @franckcuny @leighst can any of you review this one? the coverall plugin was added in a wrong section which cause the coverall report can't be generated correctly. I'd like to merge this so the master branch can generate the right coverall report. > Fix coverall report > --- > > Key: DL-127 > URL: https://issues.apache.org/jira/browse/DL-127 > Project: DistributedLog > Issue Type: Bug > Components: builds >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > Make coverall reports work -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742976#comment-15742976 ] ASF GitHub Bot commented on DL-129: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026632 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- add 'bk-shade' to avoid importing shaded bookkeeper dependencies? > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742975#comment-15742975 ] ASF GitHub Bot commented on DL-129: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026383 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- +1 for avoiding start import > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742979#comment-15742979 ] ASF GitHub Bot commented on DL-129: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92026310 --- Diff: distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml --- @@ -0,0 +1,443 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --- End diff -- nice. sorting the imports looks really good to me. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[ https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742977#comment-15742977 ] ASF GitHub Bot commented on DL-129: --- Github user sijie commented on a diff in the pull request: https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025594 --- Diff: distributedlog-build-tools/pom.xml --- @@ -0,0 +1,30 @@ + --- End diff -- I like the idea to organize the checkstyle files into a separated module so that we don't need to have configuration on each module. I think we should do the similar thing for findbugs settings. Can you move the findbug settings to builds-tool module? (It can be a separate jira and pull request). Also it might be clear to move the eclipse format settings and the merge-pr script to builds-tool module too. > Enable check style for distributedlog-protocol module > - > > Key: DL-129 > URL: https://issues.apache.org/jira/browse/DL-129 > Project: DistributedLog > Issue Type: Sub-task > Components: distributedlog-protocol >Reporter: Xi Liu >Assignee: Xi Liu > Fix For: 0.4.0 > > > Enable check style plugin for distributedlog-protocol module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-129) Enable check style for distributedlog-protocol module
[
https://issues.apache.org/jira/browse/DL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742978#comment-15742978
]
ASF GitHub Bot commented on DL-129:
---
Github user sijie commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/54#discussion_r92025930
--- Diff:
distributedlog-build-tools/src/main/resources/distributedlog/checkstyle.xml ---
@@ -0,0 +1,443 @@
+
+
+http://www.puppycrawl.com/dtds/configuration_1_3.dtd";>
+
+
+
+
+
+
+
+
+
+
+
+
--- End diff --
it might be good to make sure there is a jira associated with TODO item?
E.g.
"TODO: {@link jira_link}"?
> Enable check style for distributedlog-protocol module
> -
>
> Key: DL-129
> URL: https://issues.apache.org/jira/browse/DL-129
> Project: DistributedLog
> Issue Type: Sub-task
> Components: distributedlog-protocol
>Reporter: Xi Liu
>Assignee: Xi Liu
> Fix For: 0.4.0
>
>
> Enable check style plugin for distributedlog-protocol module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742942#comment-15742942
]
ASF GitHub Bot commented on DL-81:
--
Github user sijie commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/51#discussion_r92024690
--- Diff: website/community/release_guide.md ---
@@ -0,0 +1,507 @@
+---
+layout: default
+title: "DistributedLog Release Guide"
+permalink: /community/release-guide/
+---
+
+# Apache DistributedLog Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache DistributedLog
release. Creit to the
[Beam](http://distributedlog.incubator.apache.org/contribute/release-guide/)
project. We've borrow liberally from their documentation.
--- End diff --
Good catch! Will fix it.
> Build the distributedlog release procedure
> --
>
> Key: DL-81
> URL: https://issues.apache.org/jira/browse/DL-81
> Project: DistributedLog
> Issue Type: Task
> Components: documentation
>Reporter: Sijie Guo
>Assignee: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> this is the ticket to track building the release procedure for distributedlog
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[
https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15740776#comment-15740776
]
ASF GitHub Bot commented on DL-81:
--
Github user xieliang commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/51#discussion_r91875966
--- Diff: website/community/release_guide.md ---
@@ -0,0 +1,507 @@
+---
+layout: default
+title: "DistributedLog Release Guide"
+permalink: /community/release-guide/
+---
+
+# Apache DistributedLog Release Guide
+
+* TOC
+{:toc}
+
+This page documents the procedure to make an Apache DistributedLog
release. Creit to the
[Beam](http://distributedlog.incubator.apache.org/contribute/release-guide/)
project. We've borrow liberally from their documentation.
--- End diff --
seems replaced the beam link with DL's ... :)
> Build the distributedlog release procedure
> --
>
> Key: DL-81
> URL: https://issues.apache.org/jira/browse/DL-81
> Project: DistributedLog
> Issue Type: Task
> Components: documentation
>Reporter: Sijie Guo
>Assignee: Sijie Guo
>Priority: Blocker
> Fix For: 0.4.0
>
>
> this is the ticket to track building the release procedure for distributedlog
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (DL-127) Fix coverall report
[ https://issues.apache.org/jira/browse/DL-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738817#comment-15738817 ] ASF GitHub Bot commented on DL-127: --- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/53 DL-127: Fix coverall report You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog sijie/remove_reporting Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 commit 63fcd1dd937e0a1a47f1055ed6aa984637b386d5 Author: Sijie Guo Date: 2016-12-10T10:51:27Z remove reporting commit b46a667293448512a6303ced2be1a7276963c537 Author: Sijie Guo Date: 2016-12-11T01:23:24Z Merge branch 'master' into sijie/remove_reporting > Fix coverall report > --- > > Key: DL-127 > URL: https://issues.apache.org/jira/browse/DL-127 > Project: DistributedLog > Issue Type: Bug > Components: builds >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > Make coverall reports work -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-126) Fix the url of distributedlog blog post
[ https://issues.apache.org/jira/browse/DL-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738804#comment-15738804 ] ASF GitHub Bot commented on DL-126: --- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/52 DL-126: Fix the url of distributedlog blog post fix the url for the blog post and but still keep the wrong url and make it redirect to the right url. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog sijie/fix_blog_post_url Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit 40c276793373d1f3c42d0bde06b989e745b86049 Author: Sijie Guo Date: 2016-12-11T01:12:47Z Fix the wrong url for the blog post > Fix the url of distributedlog blog post > --- > > Key: DL-126 > URL: https://issues.apache.org/jira/browse/DL-126 > Project: DistributedLog > Issue Type: Bug > Components: website >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > The URL states 2015. It should be 2016. > http://distributedlog.incubator.apache.org/technical-review/2015/09/19/kafka-vs-distributedlog -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-79) Add Eclipse-based Apache Formatter to DL Wiki
[ https://issues.apache.org/jira/browse/DL-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15737697#comment-15737697 ] ASF GitHub Bot commented on DL-79: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/50 > Add Eclipse-based Apache Formatter to DL Wiki > - > > Key: DL-79 > URL: https://issues.apache.org/jira/browse/DL-79 > Project: DistributedLog > Issue Type: Wish > Components: documentation >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > Fix For: 0.5.0 > > Attachments: DL_formatter.xml > > > From > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65867477, we > saw several text suggestions, it would be nice if we have a importable ide > formatter file like HDFS/HBase/... projects, here is a ref jira: > https://issues.apache.org/jira/browse/HBASE-3678 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[ https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15737691#comment-15737691 ] ASF GitHub Bot commented on DL-81: -- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/51 We will use this guide for the first release. Will make modifications when go through it and will not merge until the first release is made. /cc @franckcuny @leighst @mgodave > Build the distributedlog release procedure > -- > > Key: DL-81 > URL: https://issues.apache.org/jira/browse/DL-81 > Project: DistributedLog > Issue Type: Task > Components: documentation >Reporter: Sijie Guo >Assignee: Sijie Guo >Priority: Blocker > Fix For: 0.4.0 > > > this is the ticket to track building the release procedure for distributedlog -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-81) Build the distributedlog release procedure
[ https://issues.apache.org/jira/browse/DL-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15737688#comment-15737688 ] ASF GitHub Bot commented on DL-81: -- GitHub user sijie opened a pull request: https://github.com/apache/incubator-distributedlog/pull/51 (WIP) DL-81: Build the distributedlog release procedure Borrow from http://beam.incubator.apache.org/contribute/release-guide/ You can merge this pull request into a Git repository by running: $ git pull https://github.com/sijie/incubator-distributedlog sijie/release_guid Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-distributedlog/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 8873d3e621bd9d56867764b413750131ba8bc15a Author: Sijie Guo Date: 2016-12-10T11:03:08Z (WIP) DL-81: Build the distributedlog release procedure > Build the distributedlog release procedure > -- > > Key: DL-81 > URL: https://issues.apache.org/jira/browse/DL-81 > Project: DistributedLog > Issue Type: Task > Components: documentation >Reporter: Sijie Guo >Assignee: Sijie Guo >Priority: Blocker > Fix For: 0.4.0 > > > this is the ticket to track building the release procedure for distributedlog -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-79) Add Eclipse-based Apache Formatter to DL Wiki
[ https://issues.apache.org/jira/browse/DL-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730924#comment-15730924 ] ASF GitHub Bot commented on DL-79: -- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/50 LGTM thanks @xieliang > Add Eclipse-based Apache Formatter to DL Wiki > - > > Key: DL-79 > URL: https://issues.apache.org/jira/browse/DL-79 > Project: DistributedLog > Issue Type: Wish > Components: documentation >Affects Versions: 0.4.0 >Reporter: Liang Xie >Assignee: Liang Xie > Attachments: DL_formatter.xml > > > From > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65867477, we > saw several text suggestions, it would be nice if we have a importable ide > formatter file like HDFS/HBase/... projects, here is a ref jira: > https://issues.apache.org/jira/browse/HBASE-3678 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-49) Support building project with scala 2.10 and 2.11
[ https://issues.apache.org/jira/browse/DL-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717563#comment-15717563 ] ASF GitHub Bot commented on DL-49: -- Github user asfgit closed the pull request at: https://github.com/apache/incubator-distributedlog/pull/22 > Support building project with scala 2.10 and 2.11 > - > > Key: DL-49 > URL: https://issues.apache.org/jira/browse/DL-49 > Project: DistributedLog > Issue Type: Bug >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.5.0 > > > support build the project with either scala 2.10 and scala 2.11 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-49) Support building project with scala 2.10 and 2.11
[ https://issues.apache.org/jira/browse/DL-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717392#comment-15717392 ] ASF GitHub Bot commented on DL-49: -- Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/22 merged latest master and wait for travis ci build to complete > Support building project with scala 2.10 and 2.11 > - > > Key: DL-49 > URL: https://issues.apache.org/jira/browse/DL-49 > Project: DistributedLog > Issue Type: Bug >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > support build the project with either scala 2.10 and scala 2.11 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DL-4) Repackage the source under apache namespace
[ https://issues.apache.org/jira/browse/DL-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717305#comment-15717305 ] ASF GitHub Bot commented on DL-4: - Github user sijie commented on the issue: https://github.com/apache/incubator-distributedlog/pull/41 @leighst @khurrumnasimm I would like to put this as last change to merge for the first apache release. since we might have quite a few changes to merge based on current package name. @khurrumnasimm do you have any script for repacking this? > Repackage the source under apache namespace > --- > > Key: DL-4 > URL: https://issues.apache.org/jira/browse/DL-4 > Project: DistributedLog > Issue Type: Task >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 0.4.0 > > > Per http://incubator.apache.org/guides/mentor.html#initial-clean-up, it is > recommended but not mandated. > Create a ticket for tracking the discussion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
