Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-05 Thread Carsten Ziegeler
The vote passed with the binding +1 votes and one non binding +1 vote

Thanks
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-03 Thread Jamie G.
+1 (non-binding)

I think that's a reasonable assumption regarding src vs binary users.

On Sat, Oct 3, 2015 at 5:28 AM, Carsten Ziegeler  wrote:
> Am 03.10.15 um 07:57 schrieb Pierre De Rop:
>> Indeed ! wow ! we only have the problem when building with java8; and not
>> with java7; that is odd.
>>
>> +1
>>
>> However, according to the apache release process, I think that binary
>> artifacts are only produced as convenience for users , and source artifacts
>> are more important than binaries; So, I think that when sending the
>> announce your should then mention the fact that the source release must be
>> only built using java7 and not java8.
>>
> Makes sense, yes, I'll do that - though I guess 99% of our users use the
> binary :)
>
> Regards
> Carsten
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org


Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-03 Thread Carsten Ziegeler
Am 03.10.15 um 07:57 schrieb Pierre De Rop:
> Indeed ! wow ! we only have the problem when building with java8; and not
> with java7; that is odd.
> 
> +1
> 
> However, according to the apache release process, I think that binary
> artifacts are only produced as convenience for users , and source artifacts
> are more important than binaries; So, I think that when sending the
> announce your should then mention the fact that the source release must be
> only built using java7 and not java8.
> 
Makes sense, yes, I'll do that - though I guess 99% of our users use the
binary :)

Regards
Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-02 Thread Pierre De Rop
Indeed ! wow ! we only have the problem when building with java8; and not
with java7; that is odd.

+1

However, according to the apache release process, I think that binary
artifacts are only produced as convenience for users , and source artifacts
are more important than binaries; So, I think that when sending the
announce your should then mention the fact that the source release must be
only built using java7 and not java8.

cheers
/Pierre






On Fri, Oct 2, 2015 at 5:42 PM, Carsten Ziegeler 
wrote:

> Am 02.10.15 um 17:38 schrieb Carsten Ziegeler:
>
> >
> > Interestingly, it seems to have to do with your build environment,
> > whether the import ends up in the manifest or not. If I build on my
> > machine, java 7, it's not there.
> >
> And with java 8 it is there, so it really depends on the java version
> you build with :(
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>


Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-02 Thread Carsten Ziegeler
Am 02.10.15 um 17:38 schrieb Carsten Ziegeler:

> 
> Interestingly, it seems to have to do with your build environment,
> whether the import ends up in the manifest or not. If I build on my
> machine, java 7, it's not there.
> 
And with java 8 it is there, so it really depends on the java version
you build with :(

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-02 Thread Carsten Ziegeler
Am 02.10.15 um 17:27 schrieb Pierre De Rop:
> Hello Carsten,
> 
> There is something that I don't understand regarding the FELIX-5060
>  issue:
> 
> Indeed, the org.osgi.service.component package is not imported anymore from
> the binary artifact (in
> /tmp/felix-staging/1097/org/apache/felix/org.apache.felix.webconsole/4.2.14/org.apache.felix.webconsole-4.2.14.jar).
> So, it's Ok for the binary artifact.
> 
> However, after rebuilding the binary from the sources, the package is again
> imported, and it is because the BundlesServlet class is importing the
> org.osgi.service.component.ComponentConstants).
> 
> So, shouldn't the BundlesServlet be modified in order to not depend anymore
> on the ComponentConstants from the DS API ?
> 
Thanks Pierre for finding this. Yes, we should remove it - I'll take
care of it.
I don't think we have to redo the 4.2.14 as the binary is fine. WDYT?

Interestingly, it seems to have to do with your build environment,
whether the import ends up in the manifest or not. If I build on my
machine, java 7, it's not there.

Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-02 Thread Pierre De Rop
Hello Carsten,

There is something that I don't understand regarding the FELIX-5060
 issue:

Indeed, the org.osgi.service.component package is not imported anymore from
the binary artifact (in
/tmp/felix-staging/1097/org/apache/felix/org.apache.felix.webconsole/4.2.14/org.apache.felix.webconsole-4.2.14.jar).
So, it's Ok for the binary artifact.

However, after rebuilding the binary from the sources, the package is again
imported, and it is because the BundlesServlet class is importing the
org.osgi.service.component.ComponentConstants).

So, shouldn't the BundlesServlet be modified in order to not depend anymore
on the ComponentConstants from the DS API ?

thanks;


BR
/pierre



On Fri, Oct 2, 2015 at 4:37 PM, David Bosschaert  wrote:

> +1
>
> David
>
> On 2 October 2015 at 16:28, Carsten Ziegeler  wrote:
> > I would like to call a vote for a new web console release:
> > We fixed two issues:
> > https://issues.apache.org/jira/browse/FELIX/fixforversion/12333546
> >
> > Staging repositories:
> > https://repository.apache.org/content/repositories/orgapachefelix-1097/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 10697 /tmp/felix-staging
> >
> > Please vote to approve this release:
> >
> > [ ] +1 Approve the release
> > [ ] -1 Veto the release (please provide specific comments)
> >
> > Regards
> > Carsten
> > --
> > Carsten Ziegeler
> > Adobe Research Switzerland
> > cziege...@apache.org
>


Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-02 Thread David Bosschaert
+1

David

On 2 October 2015 at 16:28, Carsten Ziegeler  wrote:
> I would like to call a vote for a new web console release:
> We fixed two issues:
> https://issues.apache.org/jira/browse/FELIX/fixforversion/12333546
>
> Staging repositories:
> https://repository.apache.org/content/repositories/orgapachefelix-1097/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 10697 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org


Re: [VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-02 Thread Carsten Ziegeler
+1


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[VOTE] Release Apache Felix WebConsole 4.2.14

2015-10-02 Thread Carsten Ziegeler
I would like to call a vote for a new web console release:
We fixed two issues:
https://issues.apache.org/jira/browse/FELIX/fixforversion/12333546

Staging repositories:
https://repository.apache.org/content/repositories/orgapachefelix-1097/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 10697 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org