Re: [FlexJS] Container and Layout Progress
Things should build now. Charts will not work yet, but MDL example (at least one) now runs for me. ‹peter On 3/24/17, 2:58 AM, "Christofer Dutz" wrote: >Hi Guys, > >Well I am expecting to be able to build develop Š if there are changes >that break things, these belong in a feature branch until they are sorted >out and merged to develop as soon as things are finished. Now please fix >the things that are broken in develop this time, but make sure to use >feature-branches in the future Š would that be ok? > >I currently don¹t need this to build as I am full with other things, I¹m >just keeping an eye on the build itself. > >Chris > > >Am 23.03.17, 18:12 schrieb "piotrz" : > >But it was expected. I can help with MDL if you will need. Just let >me know. > >If fixes will be today, there is no point to revert anything. > >Piotr > > > >- >Apache Flex PMC >piotrzarzyck...@gmail.com >-- >View this message in context: >https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle >x-development.247.n4.nabble.com%2FFlexJS-Container-and-Layout-Progress >-tp60658p60701.html&data=02%7C01%7C%7Cec8aa6f03a6d4c49fa0608d472832f81%7Cf >a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636259355160234851&sdata=vK9jS2s >SWjR4zHpvXqPnmWpvJgU%2FWOTB5A1o5S3QNSY%3D&reserved=0 >Sent from the Apache Flex Development mailing list archive at >Nabble.com. > >
Re: [FlexJS] Container and Layout Progress
Hi Guys, Well I am expecting to be able to build develop … if there are changes that break things, these belong in a feature branch until they are sorted out and merged to develop as soon as things are finished. Now please fix the things that are broken in develop this time, but make sure to use feature-branches in the future … would that be ok? I currently don’t need this to build as I am full with other things, I’m just keeping an eye on the build itself. Chris Am 23.03.17, 18:12 schrieb "piotrz" : But it was expected. I can help with MDL if you will need. Just let me know. If fixes will be today, there is no point to revert anything. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60701.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
I've committed and pushed changes to MDL that should make it compile. I don't think it will work - I'll be doing that next but I wanted to get the project to compile. Basically, all of the List-like MDL classes now extends Group rather than ContainerBase, which I should delete. Then I needed to make the classes implement the updates to IItemRendererParent. The DataGroup isn't used any longer so those classes have to act as ItemRendererParents now. Probably a better way is to use a proxy and consolidate the code; I used this for Panel. But I will get MDL to work without major structural changes since it JS-side only which makes it easier now. —peter On 3/23/17, 2:01 PM, "Peter Ent" wrote: >Yes, Chris does have a good point and from now on* I will definitely use >feature branches. I thought I could squeeze this through. > >I checked in changes to Chart that should make it compile. I doubt it will >run, but that is on the list. I will look into MDL now. That will take >longer. > >I am leary about doing the rollback at this point. You should be able to >remove MDL from the build temporarily. If you are relying on it, I will >try to be as quick as possible and test against the MDL example before >pushing my changes. > >* I will use feature branches once I get MDL working. > >Apologies, >‹peter > >On 3/23/17, 1:31 PM, "Harbs" wrote: > >>Sure. Including me. >> >>But Chris does have a point that we should be using feature branches more >>than we are. >> >>The tone of my question might have not come across correctly. I meant to >>ask how difficult it would be to move all changes to a feature branch and >>push the feature branch. If it¹s too difficult, we can just continue to >>fix the develop branch for now. >> >>> On Mar 23, 2017, at 7:19 PM, Josh Tynjala >>>wrote: >>> >>> Peter warned the list that his changes would break some things >>>temporarily, >>> and he asked if he should proceed. Everyone who responded said that it >>>was >>> okay. >>> >>> - Josh >>> >>> On Thu, Mar 23, 2017 at 10:11 AM, Harbs wrote: >>> Very good question. Peter, is there any chance to roll back containers and layouts and move all the changes to a feature branch until things are stable? > On Mar 23, 2017, at 7:58 AM, Christofer Dutz > wrote: > > Why don't you guys use feature branches? >> >
Re: [FlexJS] Container and Layout Progress
I should have committed a change to the build to exclude charts. Hmm. Peter > On Mar 23, 2017, at 12:57 PM, Christofer Dutz > wrote: > > Well I guess things are broken now ( > > I just updated and ran a new build and Charts is exploding at the moment … > > Chris > > > > Am 23.03.17, 17:02 schrieb "Peter Ent" : > >Hi, > >I've committed the changes!! The build should skip, MDL, Charts, and Basic >projects. I will get MDL and Charts running next. But before that, I will >have an email out with a breakdown of the changes I've made. Look for that >in the next couple of hours. > >Good luck! Please let me know what breaks. I will tell you that the >biggest difference is the UIBase no longer sets position style so any >elements you have that require positioning via x,y, will need to use a >Group or Container that has the BasicLayout. > >Regards, >Peter > >>On 3/22/17, 5:02 PM, "Peter Ent" wrote: >> >> Update: I'm 99% ready to commit. I will do this tomorrow morning, my time. >> I've spent today fixing some last issues in HTML package, while cosmetic, >> just didn't make things look too good. There are a couple more but I'll do >> them later. >> >> I did a local merge of the latest FlexJS code and my changes and rebuilt >> flex-asjs. The Basic and Charts packages I expected to have issues. I'm >> not sure if I should even bother with Basic, just let me know. I have >> commented Charts from the build.xml so it will not cause the main build to >> fail. >> >> The other project is MDL. I will also comment that from the build and will >> work on that after I make the commit and push. The issue is that I changed >> a couple of interfaces in Core and replaced one interface with another. I >> just have to sync them up. Hopefully it will not take more than a day. >> >> If you prefer I do MDL before doing the commit, please let me know in the >> next 12-14 hours. >> >> Thanks, >> Peter >> >>> On 3/22/17, 10:56 AM, "Harbs" wrote: >>> >>> Yes. Commit. >>> >>> Right now we need to use an earlier version because the current status is >>> broken. >>> On Mar 22, 2017, at 4:37 PM, OK wrote: In case if something is broken for somebody maybe one option is to just check out a previous revision by using the particular commit hash? Olaf -- View this message in context: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f l ex-development.247.n4.nabble.com%2FFlexJS-Container-and-Layout-Progr e ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f % 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hS A %2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0 Sent from the Apache Flex Development mailing list archive at Nabble.com. >>> >> > > >
Re: [FlexJS] Container and Layout Progress
Yes, Chris does have a good point and from now on* I will definitely use feature branches. I thought I could squeeze this through. I checked in changes to Chart that should make it compile. I doubt it will run, but that is on the list. I will look into MDL now. That will take longer. I am leary about doing the rollback at this point. You should be able to remove MDL from the build temporarily. If you are relying on it, I will try to be as quick as possible and test against the MDL example before pushing my changes. * I will use feature branches once I get MDL working. Apologies, ‹peter On 3/23/17, 1:31 PM, "Harbs" wrote: >Sure. Including me. > >But Chris does have a point that we should be using feature branches more >than we are. > >The tone of my question might have not come across correctly. I meant to >ask how difficult it would be to move all changes to a feature branch and >push the feature branch. If it¹s too difficult, we can just continue to >fix the develop branch for now. > >> On Mar 23, 2017, at 7:19 PM, Josh Tynjala wrote: >> >> Peter warned the list that his changes would break some things >>temporarily, >> and he asked if he should proceed. Everyone who responded said that it >>was >> okay. >> >> - Josh >> >> On Thu, Mar 23, 2017 at 10:11 AM, Harbs wrote: >> >>> Very good question. >>> >>> Peter, is there any chance to roll back containers and layouts and move >>> all the changes to a feature branch until things are stable? >>> On Mar 23, 2017, at 7:58 AM, Christofer Dutz >>> wrote: Why don't you guys use feature branches? >>> >>> >
Re: [FlexJS] Container and Layout Progress
I guess I should have used a feature branch. I'm not sure how long Charts will take. I wrote most of that code and it got pretty gnarly using List as a basis. It probably is better to use a feature branch. Let me see if I understand the rollback process and can get that going. Definitely a lesson learned on that. ‹peter On 3/23/17, 1:19 PM, "Josh Tynjala" wrote: >Peter warned the list that his changes would break some things >temporarily, >and he asked if he should proceed. Everyone who responded said that it was >okay. > >- Josh > >On Thu, Mar 23, 2017 at 10:11 AM, Harbs wrote: > >> Very good question. >> >> Peter, is there any chance to roll back containers and layouts and move >> all the changes to a feature branch until things are stable? >> >> > On Mar 23, 2017, at 7:58 AM, Christofer Dutz >> >> wrote: >> > >> > Why don't you guys use feature branches? >> >>
Re: [FlexJS] Container and Layout Progress
Sure. Including me. But Chris does have a point that we should be using feature branches more than we are. The tone of my question might have not come across correctly. I meant to ask how difficult it would be to move all changes to a feature branch and push the feature branch. If it’s too difficult, we can just continue to fix the develop branch for now. > On Mar 23, 2017, at 7:19 PM, Josh Tynjala wrote: > > Peter warned the list that his changes would break some things temporarily, > and he asked if he should proceed. Everyone who responded said that it was > okay. > > - Josh > > On Thu, Mar 23, 2017 at 10:11 AM, Harbs wrote: > >> Very good question. >> >> Peter, is there any chance to roll back containers and layouts and move >> all the changes to a feature branch until things are stable? >> >>> On Mar 23, 2017, at 7:58 AM, Christofer Dutz >> wrote: >>> >>> Why don't you guys use feature branches? >> >>
Re: [FlexJS] Container and Layout Progress
But it was expected. I can help with MDL if you will need. Just let me know. If fixes will be today, there is no point to revert anything. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60701.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Peter warned the list that his changes would break some things temporarily, and he asked if he should proceed. Everyone who responded said that it was okay. - Josh On Thu, Mar 23, 2017 at 10:11 AM, Harbs wrote: > Very good question. > > Peter, is there any chance to roll back containers and layouts and move > all the changes to a feature branch until things are stable? > > > On Mar 23, 2017, at 7:58 AM, Christofer Dutz > wrote: > > > > Why don't you guys use feature branches? > >
Re: [FlexJS] Container and Layout Progress
Very good question. Peter, is there any chance to roll back containers and layouts and move all the changes to a feature branch until things are stable? > On Mar 23, 2017, at 7:58 AM, Christofer Dutz > wrote: > > Why don't you guys use feature branches?
Re: [FlexJS] Container and Layout Progress
Well I guess things are broken now ( I just updated and ran a new build and Charts is exploding at the moment … Chris Am 23.03.17, 17:02 schrieb "Peter Ent" : Hi, I've committed the changes!! The build should skip, MDL, Charts, and Basic projects. I will get MDL and Charts running next. But before that, I will have an email out with a breakdown of the changes I've made. Look for that in the next couple of hours. Good luck! Please let me know what breaks. I will tell you that the biggest difference is the UIBase no longer sets position style so any elements you have that require positioning via x,y, will need to use a Group or Container that has the BasicLayout. Regards, Peter On 3/22/17, 5:02 PM, "Peter Ent" wrote: >Update: I'm 99% ready to commit. I will do this tomorrow morning, my time. >I've spent today fixing some last issues in HTML package, while cosmetic, >just didn't make things look too good. There are a couple more but I'll do >them later. > >I did a local merge of the latest FlexJS code and my changes and rebuilt >flex-asjs. The Basic and Charts packages I expected to have issues. I'm >not sure if I should even bother with Basic, just let me know. I have >commented Charts from the build.xml so it will not cause the main build to >fail. > >The other project is MDL. I will also comment that from the build and will >work on that after I make the commit and push. The issue is that I changed >a couple of interfaces in Core and replaced one interface with another. I >just have to sync them up. Hopefully it will not take more than a day. > >If you prefer I do MDL before doing the commit, please let me know in the >next 12-14 hours. > >Thanks, >Peter > >On 3/22/17, 10:56 AM, "Harbs" wrote: > >>Yes. Commit. >> >>Right now we need to use an earlier version because the current status is >>broken. >> >>> On Mar 22, 2017, at 4:37 PM, OK wrote: >>> >>> In case if something is broken for somebody maybe one option is to just >>>check >>> out a previous revision by using the particular commit hash? >>> >>> Olaf >>> >>> >>> >>> -- >>> View this message in context: >>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f >>>l >>>ex-development.247.n4.nabble.com%2FFlexJS-Container-and-Layout-Progr >>>e >>>ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f >>>% >>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hS >>>A >>>%2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0 >>> Sent from the Apache Flex Development mailing list archive at >>>Nabble.com. >> >
Re: [FlexJS] Container and Layout Progress
Hi, I've committed the changes!! The build should skip, MDL, Charts, and Basic projects. I will get MDL and Charts running next. But before that, I will have an email out with a breakdown of the changes I've made. Look for that in the next couple of hours. Good luck! Please let me know what breaks. I will tell you that the biggest difference is the UIBase no longer sets position style so any elements you have that require positioning via x,y, will need to use a Group or Container that has the BasicLayout. Regards, Peter On 3/22/17, 5:02 PM, "Peter Ent" wrote: >Update: I'm 99% ready to commit. I will do this tomorrow morning, my time. >I've spent today fixing some last issues in HTML package, while cosmetic, >just didn't make things look too good. There are a couple more but I'll do >them later. > >I did a local merge of the latest FlexJS code and my changes and rebuilt >flex-asjs. The Basic and Charts packages I expected to have issues. I'm >not sure if I should even bother with Basic, just let me know. I have >commented Charts from the build.xml so it will not cause the main build to >fail. > >The other project is MDL. I will also comment that from the build and will >work on that after I make the commit and push. The issue is that I changed >a couple of interfaces in Core and replaced one interface with another. I >just have to sync them up. Hopefully it will not take more than a day. > >If you prefer I do MDL before doing the commit, please let me know in the >next 12-14 hours. > >Thanks, >Peter > >On 3/22/17, 10:56 AM, "Harbs" wrote: > >>Yes. Commit. >> >>Right now we need to use an earlier version because the current status is >>broken. >> >>> On Mar 22, 2017, at 4:37 PM, OK wrote: >>> >>> In case if something is broken for somebody maybe one option is to just >>>check >>> out a previous revision by using the particular commit hash? >>> >>> Olaf >>> >>> >>> >>> -- >>> View this message in context: >>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-f >>>l >>>ex-development.247.n4.nabble.com%2FFlexJS-Container-and-Layout-Progr >>>e >>>ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f >>>% >>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hS >>>A >>>%2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0 >>> Sent from the Apache Flex Development mailing list archive at >>>Nabble.com. >> >
AW: [FlexJS] Container and Layout Progress
Hi,
Why don't you guys use feature branches? I've made it so simple to use them :-(
If you create a branch on all three repos and babe it "feature/{something}" you
even get automatic Jenkins builds for it.
Chris
Von meinem Samsung Galaxy Smartphone gesendet.
Ursprüngliche Nachricht
Von: Peter Ent
Datum: 22.03.17 22:02 (GMT+01:00)
An: dev@flex.apache.org
Betreff: Re: [FlexJS] Container and Layout Progress
Update: I'm 99% ready to commit. I will do this tomorrow morning, my time.
I've spent today fixing some last issues in HTML package, while cosmetic,
just didn't make things look too good. There are a couple more but I'll do
them later.
I did a local merge of the latest FlexJS code and my changes and rebuilt
flex-asjs. The Basic and Charts packages I expected to have issues. I'm
not sure if I should even bother with Basic, just let me know. I have
commented Charts from the build.xml so it will not cause the main build to
fail.
The other project is MDL. I will also comment that from the build and will
work on that after I make the commit and push. The issue is that I changed
a couple of interfaces in Core and replaced one interface with another. I
just have to sync them up. Hopefully it will not take more than a day.
If you prefer I do MDL before doing the commit, please let me know in the
next 12-14 hours.
Thanks,
Peter
On 3/22/17, 10:56 AM, "Harbs" wrote:
>Yes. Commit.
>
>Right now we need to use an earlier version because the current status is
>broken.
>
>> On Mar 22, 2017, at 4:37 PM, OK wrote:
>>
>> In case if something is broken for somebody maybe one option is to just
>>check
>> out a previous revision by using the particular commit hash?
>>
>> Olaf
>>
>>
>>
>> --
>> View this message in context:
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fl
>>ex-development.247.n4.nabble.com%2FFlexJS-Container-and-Layout-Progre
>>ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f%
>>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hSA
>>%2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0
>> Sent from the Apache Flex Development mailing list archive at
>>Nabble.com.
>
Re: [FlexJS] Container and Layout Progress
Peter, I think you should commit and try to fix at first MDL - If you have any problems let me know I will help you. As for the content of Basic - I think Alex know what changes will have place in Basic due to "dual" branch. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60686.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Update: I'm 99% ready to commit. I will do this tomorrow morning, my time. I've spent today fixing some last issues in HTML package, while cosmetic, just didn't make things look too good. There are a couple more but I'll do them later. I did a local merge of the latest FlexJS code and my changes and rebuilt flex-asjs. The Basic and Charts packages I expected to have issues. I'm not sure if I should even bother with Basic, just let me know. I have commented Charts from the build.xml so it will not cause the main build to fail. The other project is MDL. I will also comment that from the build and will work on that after I make the commit and push. The issue is that I changed a couple of interfaces in Core and replaced one interface with another. I just have to sync them up. Hopefully it will not take more than a day. If you prefer I do MDL before doing the commit, please let me know in the next 12-14 hours. Thanks, Peter On 3/22/17, 10:56 AM, "Harbs" wrote: >Yes. Commit. > >Right now we need to use an earlier version because the current status is >broken. > >> On Mar 22, 2017, at 4:37 PM, OK wrote: >> >> In case if something is broken for somebody maybe one option is to just >>check >> out a previous revision by using the particular commit hash? >> >> Olaf >> >> >> >> -- >> View this message in context: >>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fl >>ex-development.247.n4.nabble.com%2FFlexJS-Container-and-Layout-Progre >>ss-tp60658p60673.html&data=02%7C01%7C%7C82a3a0f402a943fbc3fa08d47133951f% >>7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257913736732760&sdata=hSA >>%2FIskqdzlbteHnTLr9pZwSE5Kk%2Fer9cb%2FUTJeMrZ8%3D&reserved=0 >> Sent from the Apache Flex Development mailing list archive at >>Nabble.com. >
Re: [FlexJS] Container and Layout Progress
Yes. Commit. Right now we need to use an earlier version because the current status is broken. > On Mar 22, 2017, at 4:37 PM, OK wrote: > > In case if something is broken for somebody maybe one option is to just check > out a previous revision by using the particular commit hash? > > Olaf > > > > -- > View this message in context: > http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60673.html > Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
In case if something is broken for somebody maybe one option is to just check out a previous revision by using the particular commit hash? Olaf -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60673.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Hi Peter, +1 for commit, than fix Charts. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60672.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Hi, One more thing: When I make this commit, I'm pretty sure Charts will be broken until I address it. I can hold off the commit and address Charts first, but I would prefer to commit Core and HTML and then fix Charts and anything else. Would that strategy (commit first, fix Charts etc after) impact you? Should I try to get more projects working first before doing the commit? ‹peter On 3/21/17, 6:00 PM, "piotrz" wrote: >Hi Peter, > >Thank you for a hard work. > >I'm concerning about one thing. Alex mentioned that he will merge soon >dual >branch to develop - It will be tons of conflicts - Maybe it would be good >to >look also into that problem. > >Piotr > > > >- >Apache Flex PMC >piotrzarzyck...@gmail.com >-- >View this message in context: >https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle >x-development.247.n4.nabble.com%2FFlexJS-Container-and-Layout-Progress >-tp60658p60659.html&data=02%7C01%7C%7C0c2dad00daa048aec35808d470a6ce38%7Cf >a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636257309108498545&sdata=L%2Br39 >imWqdtudyvD1HZYHTaBT61Byhqbfa%2BOHknNLR4%3D&reserved=0 >Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container and Layout Progress
Hi Peter, Thank you for a hard work. I'm concerning about one thing. Alex mentioned that he will merge soon dual branch to develop - It will be tons of conflicts - Maybe it would be good to look also into that problem. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-and-Layout-Progress-tp60658p60659.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
[FlexJS] Container and Layout Progress
Hi, I'm am making progress toward simplifying the JS output generated from the components. I should be making a commit either tomorrow or the next day. There will be some things not working 100% correctly, mostly because they need to be tuned to use the new layouts or are making assumptions about positioning which have changed. I've made changes to Group (which as my most recent commit), Container, List, Panel, etc. because they depend on some base work. I've also changed some of the SWF-side algorithms for layout and greatly simplified the HTML/JS versions of those layouts. I've tested some of the examples and have fixed components that needed tuning. For example, the DateChooser is now a Group with three main parts and it uses VerticalFlexLayout to size and position those parts. The button header and days-of-week list use HorizontalFlexLayout. Panel is now a Group and it, too, uses VerticalFlexLayout to position the title bar and Container content area. So it has been a bit of time using those components to expose some short-coming in the layout code. I also had to go back and re-think how all of these parts fit together and behave on the Flash and HTML platforms. I want to produce a before-and-after snapshot of some HTML so show you the differences and I will produce that tomorrow. Then I have to merge my changes into the develop branch. I have only touched Core and HTML framework projects, but some of the other projects (like Charts) depend on these and I want to assess them before going further. Regards, Peter
Re: [FlexJS] Container work status
Hi,
I've fixed a number of layout issues. I'm still putting things together
and testing, but this problem should be addressed in my next commit.
‹peter
On 3/20/17, 3:26 AM, "yishayw" wrote:
>I think some of your changes in BasicLayout have broken some layout
>behavior
>on the JS side. In this [1] app the blue container ("myFlex") doesn't
>stretch to screen size. After debugging this behavior for quite a while I
>came to the conclusion that BasicLayout no longer calls
>child.dispatchEvent("sizeChanged") on the JS side, so
>OneFlexibleChildVerticalLayout.layout is never called.
>
>Can you have a look? Thanks.
>
>[1]
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apa
>che.org%2FPWfp&data=02%7C01%7C%7C746f5bb3e6d546e018bd08d46f6388c4%7Cfa7b1b
>5a7b34438794aed2c178decee1%7C0%7C0%7C636255920673439873&sdata=Km7OxLtrp4uv
>rWA89U%2B1XkUsUuo0qRQDHtPLvIeBtUQ%3D&reserved=0
>
>
>
>
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.247.n4.nabble.com%2FFlexJS-Container-work-status-tp60417
>p60607.html&data=02%7C01%7C%7C746f5bb3e6d546e018bd08d46f6388c4%7Cfa7b1b5a7
>b34438794aed2c178decee1%7C0%7C0%7C636255920673449882&sdata=LO8h7nztdGjBBzh
>St7GSWyGYdBtlWglk3UA39bWp04A%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container work status
I think some of your changes in BasicLayout have broken some layout behavior
on the JS side. In this [1] app the blue container ("myFlex") doesn't
stretch to screen size. After debugging this behavior for quite a while I
came to the conclusion that BasicLayout no longer calls
child.dispatchEvent("sizeChanged") on the JS side, so
OneFlexibleChildVerticalLayout.layout is never called.
Can you have a look? Thanks.
[1] https://paste.apache.org/PWfp
--
View this message in context:
http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Container-work-status-tp60417p60607.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container work status
Peter, can I test this in FlexJs nightly build? On 16-Mar-2017 5:38 PM, "Peter Ent [via Apache Flex Development]" < ml-node+s247n60509...@n4.nabble.com> wrote: Thanks for letting me know. I will try to be quick. ‹peter On 3/16/17, 4:11 AM, "Justin Mclean" <[hidden email] <http:///user/SendEmail.jtp?type=node&node=60509&i=0>> wrote: >Hi, > >The current changes have broken the layout in our application (not >unexpected). When you feel it at a stable state just say so and we set if >we can fix it up and report back any issues. > >Thanks, >Justin -- If you reply to this email, your message will be added to the discussion below: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-work- status-tp60417p60509.html To start a new topic under Apache Flex Development, email ml-node+s247n1...@n4.nabble.com To unsubscribe from Apache Flex Development, click here <http://apache-flex-development.247.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=1&code=cHJhc2hha3VtYXJAZ21haWwuY29tfDF8LTU0MTcyMzE2NA==> . NAML <http://apache-flex-development.247.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-work-status-tp60417p60563.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] Container work status
Thanks for letting me know. I will try to be quick. ‹peter On 3/16/17, 4:11 AM, "Justin Mclean" wrote: >Hi, > >The current changes have broken the layout in our application (not >unexpected). When you feel it at a stable state just say so and we set if >we can fix it up and report back any issues. > >Thanks, >Justin
Re: [FlexJS] Container work status
Hi, The current changes have broken the layout in our application (not unexpected). When you feel it at a stable state just say so and we set if we can fix it up and report back any issues. Thanks, Justin
Re: [FlexJS] Container work status
Hi Peter, Thanks for reporting progress! I'm looking forward to your changes! :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Container-work-status-tp60417p60452.html Sent from the Apache Flex Development mailing list archive at Nabble.com.
[FlexJS] Container work status
Hi, Several days ago I wrote about making changes to FlexJS to produce cleaner and more useful HTML. I'm in the middle of doing that and it will take several more days, at least. When I'm done there will be some fundamental changes. These center around Container and by extension, List. And many components rely on these two pieces. Plus I have removed setting position style to "relative" in all of the classes that were doing so. In the course of this work I've fixed a few layout bugs, too. What you will see is that Container and Group are just on HTML while Group is a single object on SWF and Container is a nested structure in order to provide scrolling on SWF. The List component and its subclasses will behave like Container in that the HTML side will just be a with stuff (item renderers) in it while the SWF version will be an outer box with an inner box that contains the item renders and which scrolls. You will be able to have greater control over styling on the HTML side. Doing this was like pulling on a thread in a sweater and while it unravels I'm weaving it back together just slightly differently. Stay tuned. if you have any concerns or questions, please let me know. Regards, Peter Ent Adobe Systems/Apache Flex Project.
Re: [FlexJS] Container
Hi Peter, 2017-02-27 23:13 GMT+01:00 Peter Ent : > > QUESTION: In your Flex apps, do you need to place chrome elements besides > using a Panel? > As you and Peter think, is rare. This should be implemented in an extended or different component. -- Carlos Rovira http://about.me/carlosrovira
Re: [FlexJS] Container
Hi, > QUESTION: In your Flex apps, do you need to place chrome elements besides > using a Panel? A few times but reasonably rare. Think the last time was a little “x" that showed up when mouse was in the corner. > I'm getting hung up with the nesting of the containing elements and I think > most of the time it isn't necessary, especially on the JS side. Yep I seeing a few too many on the JS size, it get worse as you currently need to use more containers that you need to get around padding issues. Thanks, Justin
[FlexJS] Container
Hi, I've been wrestling with Container all day. I was working on the Flex layouts, but then went down the rabbit hole of Containers while trying to get the layouts to look right. The issue really isn't the HTML/JS side. That's pretty easy really (in concept). A FlexJS Container's element is a that gets its display style set to flex and then a couple of other properties. The problem comes from the SWF-side which creates several structures: The Container itself, its inner content area, and a viewport. All of this is to support padding, chrome pieces, and scrolling. The Container's content area appears on the HTML side, too, because of the potential chrome elements. Most times you want to use a Container you aren't going to need chrome elements, so I'd like to do away with that for Container. Maybe make a ChromeContainer later to support Panel or make Panel be a special-case Container that has chrome. QUESTION: In your Flex apps, do you need to place chrome elements besides using a Panel? Scrolling, to me, is a different issue, even though scrollbars could be considered chrome elements. What I'd like to do here is create a ScrollableContainer that will add in scrollbars on the SWF side and just set the overlay style appropriately on the HTML/JS side (again, the JS side is simple). I'm getting hung up with the nesting of the containing elements and I think most of the time it isn't necessary, especially on the JS side. Grouping elements together is a fundamental thing in UI frameworks and I'm just not feeling that this is being handling correctly. Thanks, Peter
Re: [FalconJX][FlexJS] Container added to FlexJSOverlay
I'm going to tackle Panel. Peter Ent Flex SDK Team Adobe Systems, Inc. On 5/10/13 12:52 AM, "Alex Harui" wrote: >Hi, > >I added a Container class and simple Horizontal and Vertical layouts to >the FlexJSOverlay. The StockQuote example has been updated to show how >to use them. Volunteers welcome to provide alternative layouts, and >Container variants like Panel. > >Thanks, >-- >Alex Harui >Flex SDK Team >Adobe Systems, Inc. >http://blogs.adobe.com/aharui
[FalconJX][FlexJS] Container added to FlexJSOverlay
Hi, I added a Container class and simple Horizontal and Vertical layouts to the FlexJSOverlay. The StockQuote example has been updated to show how to use them. Volunteers welcome to provide alternative layouts, and Container variants like Panel. Thanks, -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
