Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
HI, Whatever the way to go, I'm not sure checkin empty.properties which are generated is the one. This are not auto generated but are required to compile the SDK for different locales - you need to do this in develop for testing or may actually want to compile the SDK for a locale other than en_US so I don't think these need to be in the release branch only. Also having a different set of files in release to develop is going to make merging difficult for starters. Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
This are not auto generated They're copied from bundles/en_US/empty.properties to each locale at each build are required to compile the SDK for different locales - you need to do this in develop for testing or may actually want to compile the SDK for a locale other than en_US so I don't think these need to be in the release branch only are required to compile the SDK for different locales - you need to do this in develop for testing or may actually want to compile the SDK for a locale other than en_US so I don't think these need to be in the release branch only What I don't understand Justin, it's why they should go in Git so ? From what I understand, there's no needs. Thanks, -Fred -Message d'origine- From: Justin Mclean Sent: Monday, March 25, 2013 10:09 PM To: dev@flex.apache.org Subject: Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works HI, Whatever the way to go, I'm not sure checkin empty.properties which are generated is the one. This are not auto generated but are required to compile the SDK for different locales - you need to do this in develop for testing or may actually want to compile the SDK for a locale other than en_US so I don't think these need to be in the release branch only. Also having a different set of files in release to develop is going to make merging difficult for starters. Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
HI, They're copied from bundles/en_US/empty.properties to each locale at each build Only for the flash-integration target and this may or may not be the correct thing to do. It may of been a hack just to get it to work. At a future point locales may contain other translations. Also looks like the clean target may need a little work as well as it excluding all english locales. When creating a new locale via copylocale for any of the non en_US supported locales it the files need to exist in that locale and not copied from the en_US locale. eg copylocale en_AU en_NZ needs to work as this would be less work than copylocale en_US en_NZ. For this to work the files need to exist and be in GIt. Thanks, Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
On 3/25/13 2:48 PM, Justin Mclean jus...@classsoftware.com wrote: HI, They're copied from bundles/en_US/empty.properties to each locale at each build Only for the flash-integration target and this may or may not be the correct thing to do. It may of been a hack just to get it to work. At a future point locales may contain other translations. Also looks like the clean target may need a little work as well as it excluding all english locales. When creating a new locale via copylocale for any of the non en_US supported locales it the files need to exist in that locale and not copied from the en_US locale. eg copylocale en_AU en_NZ needs to work as this would be less work than copylocale en_US en_NZ. For this to work the files need to exist and be in GIt. Could it be time to reconsider and make copylocale more tolerant of missing files? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
eg copylocale en_AU en_NZ needs to work as this would be less work than copylocale en_US en_NZ. For this to work the files need to exist and be in GIt Yes, but only the user use copylocale, not the build, right ? If so, when the user get the binaries, those files have been already generated and included inside or I'm wrong ? -Fred -Message d'origine- From: Justin Mclean Sent: Monday, March 25, 2013 10:48 PM To: dev@flex.apache.org Subject: Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works HI, They're copied from bundles/en_US/empty.properties to each locale at each build Only for the flash-integration target and this may or may not be the correct thing to do. It may of been a hack just to get it to work. At a future point locales may contain other translations. Also looks like the clean target may need a little work as well as it excluding all english locales. When creating a new locale via copylocale for any of the non en_US supported locales it the files need to exist in that locale and not copied from the en_US locale. eg copylocale en_AU en_NZ needs to work as this would be less work than copylocale en_US en_NZ. For this to work the files need to exist and be in GIt. Thanks, Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
Hi, Could it be time to reconsider and make copylocale more tolerant of missing files? As I said this was an easier fix than changing the Java code inside copylcoale if you want to provide an alternative patch go ahead. Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
Hi, Yes, but only the user use copylocale, not the build, right ? Well technically the build isn't broken (you can use it as a SDK and set different locales) but you may have trouble making a new locale form this build. I think it reasonable to assume that copylocale would work locales other than en_US. If so, when the user get the binaries, those files have been already generated and included inside or I'm wrong ? Nope some of the required files were missing which is why I added them. copylocale any non en_US locale new_locale would fail. Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
Then, at this point why those files are not permanently in their corresponding locale directory rather than copied each time by the ant script ? it would allow them to stay in Git -Fred -Message d'origine- From: Justin Mclean Sent: Monday, March 25, 2013 11:09 PM To: dev@flex.apache.org Subject: Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works Hi, Yes, but only the user use copylocale, not the build, right ? Well technically the build isn't broken (you can use it as a SDK and set different locales) but you may have trouble making a new locale form this build. I think it reasonable to assume that copylocale would work locales other than en_US. If so, when the user get the binaries, those files have been already generated and included inside or I'm wrong ? Nope some of the required files were missing which is why I added them. copylocale any non en_US locale new_locale would fail. Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
On 3/25/13 3:04 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, Could it be time to reconsider and make copylocale more tolerant of missing files? As I said this was an easier fix than changing the Java code inside copylcoale if you want to provide an alternative patch go ahead. Yes, the change you made was simpler, but now you have to spend time dealing with the Git ramifications. Justin -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
Just another point, I'm trying to build a release and the textLayout asdoc
target source-path point on ${source.dir}/src, it turns into an error,
shouldn't it be ${tlf.branch}/src ?
As reminder:
!-- Call asdoc to generate dita xml files --
asdoc output=${FLEX_HOME}/tempDoc lenient=true
failonerror=true keep-xml=true skip-xsl=true fork=true
compiler.source-path path-element=${source.dir}/src/
compiler.show-actionscript-warningsfalse/compiler.show-actionscript-warnings
doc-classes class=flashx.textLayout.CoreClasses/
doc-classes class=flashx.textLayout.EditClasses/
doc-classes class=flashx.textLayout.ConversionClasses/
doc-namespaces uri=library://ns.adobe.com/flashx/textLayout/
namespace uri=library://ns.adobe.com/flashx/textLayout
manifest=${source.dir}/manifest.xml/
jvmarg line=${asdoc.jvm.args}/
static-link-runtime-shared-libraries/
define name=CONFIG::debug value=${dbg}/
define name=CONFIG::release value=${rel}/
/asdoc
Thanks,
-Fred
-Message d'origine-
From: Alex Harui
Sent: Tuesday, March 26, 2013 1:04 AM
To: dev@flex.apache.org
Subject: Re: [1/3] Added misisng empty locales files for all supported
locales so that copylocale works
On 3/25/13 3:04 PM, Justin Mclean jus...@classsoftware.com wrote:
Hi,
Could it be time to reconsider and make copylocale more tolerant of
missing
files?
As I said this was an easier fix than changing the Java code inside
copylcoale
if you want to provide an alternative patch go ahead.
Yes, the change you made was simpler, but now you have to spend time dealing
with the Git ramifications.
Justin
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
What would be the problem to do the opposite, check them in and not re-generate them ? Thanks, -Fred -Message d'origine- From: Justin Mclean Sent: Tuesday, March 26, 2013 1:35 AM To: dev@flex.apache.org Subject: Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works Hi, Yes, the change you made was simpler, but now you have to spend time dealing with the Git ramifications. Which is what exactly? That you have files that show up as changed in git status - easy don't check them in. We had exactly the same issue with SVN. Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
Hi, What would be the problem to do the opposite, check them in and not re-generate them ? Currently the build is broken (themes are not compiling for some odd reason) so I'm unable to test. Justin
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
On 3/25/13 5:28 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote:
Just another point, I'm trying to build a release and the textLayout asdoc
target source-path point on ${source.dir}/src, it turns into an error,
shouldn't it be ${tlf.branch}/src ?
Ah yes, I never did finish the release target. I just got main and
checkintests to run. If you can fix it, great, if not, I will try to get to
it later in the week.
As reminder:
!-- Call asdoc to generate dita xml files --
asdoc output=${FLEX_HOME}/tempDoc lenient=true
failonerror=true keep-xml=true skip-xsl=true fork=true
compiler.source-path path-element=${source.dir}/src/
compiler.show-actionscript-warningsfalse/compiler.show-actionscript-warning
s
doc-classes class=flashx.textLayout.CoreClasses/
doc-classes class=flashx.textLayout.EditClasses/
doc-classes class=flashx.textLayout.ConversionClasses/
doc-namespaces uri=library://ns.adobe.com/flashx/textLayout/
namespace uri=library://ns.adobe.com/flashx/textLayout
manifest=${source.dir}/manifest.xml/
jvmarg line=${asdoc.jvm.args}/
static-link-runtime-shared-libraries/
define name=CONFIG::debug value=${dbg}/
define name=CONFIG::release value=${rel}/
/asdoc
Thanks,
-Fred
-Message d'origine-
From: Alex Harui
Sent: Tuesday, March 26, 2013 1:04 AM
To: dev@flex.apache.org
Subject: Re: [1/3] Added misisng empty locales files for all supported
locales so that copylocale works
On 3/25/13 3:04 PM, Justin Mclean jus...@classsoftware.com wrote:
Hi,
Could it be time to reconsider and make copylocale more tolerant of
missing
files?
As I said this was an easier fix than changing the Java code inside
copylcoale
if you want to provide an alternative patch go ahead.
Yes, the change you made was simpler, but now you have to spend time dealing
with the Git ramifications.
Justin
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [1/3] Added misisng empty locales files for all supported locales so that copylocale works
Hi, What would be the problem to do the opposite, check them in and not re-generate them ? Modified the build script to do this - however unable to 100% test as build release is currently broken. Justin
