[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100170#comment-14100170 ] Hudson commented on GORA-354: - FAILURE: Integrated in gora-trunk #1181 (See [https://builds.apache.org/job/gora-trunk/1181/]) GORA-354 (rmarroquin: rev f840b5dda8856d09aa2e919e1d96ac7d0f26c233) * gora-solr/src/test/conf/gora.properties * gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java * gora-core/src/test/conf/gora.properties * gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java * gora-core/src/test/java/org/apache/gora/store/TestDataStoreFactory.java > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch, > GORA-354.rmm.170814.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100156#comment-14100156 ] Renato Javier Marroquín Mogrovejo commented on GORA-354: Committed in f840b5d > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch, > GORA-354.rmm.170814.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098934#comment-14098934 ] Lewis John McGibbney commented on GORA-354: --- Are you able to resolve this issue [~renato2099]? Thanks if this is possible. Great job folks. > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch, > GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080767#comment-14080767 ] Renato Javier Marroquín Mogrovejo commented on GORA-354: Sorry [~tpalsulich] for taking too long to come back to this. 1) I think all the properties' names should be lower case and users should be advised to do so. Besides that. inside Gora we always check for lowercase properties' names anyway (or at least we should. Maybe I will open another JIRA to fix those that are not). You are right the cost of an extra is negligible in this case, but it's a cost that we shouldn't even "pay" as Gora doesn't use non lowercase properties names. Class names (properties' values) capitalization should be respected as this is used to do reflection in some places. 3) Block comments should be indented at the same level as the surrounding code. Thanks Tyler! > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch, > GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080764#comment-14080764 ] Lewis John McGibbney commented on GORA-354: --- OK I have my copy patched with this locally. Does anyone have an issue with [~tpalsulich]'s patch which prevents us from committing the trivial change? Essentially everything is encapsulated here and the to lowercase also called second only as a last resort. [~renato2099]? wdyt Thanks folks > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch, > GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062046#comment-14062046 ] Tyler Palsulich commented on GORA-354: -- Hi [~renato2099], Thanks for the comments! 1) IMHO, we should try to use the user's settings first. It doesn't seem natural to silently make the property lowercase, even if we notify the user of the mistake after. How much does the extra if cost? 2) Thanks! Can always use more tests. :) 3) Would you prefer the line before? Or, just take the comment out. > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch, > GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062037#comment-14062037 ] Renato Javier Marroquín Mogrovejo commented on GORA-354: Hi guys, Sorry to take so long to get to this. My comments are: 1) properties.getProperty(key.toLowerCase()); IMHO this should be called only once with the lowerCase, and if this is wrong then then user should be notified that he is doing something wrong (which he is). So maybe doing the conversion on the getProperty method? wdty [~lewismc]? 2) I like the unit tests ;) great work [~tpalsulich]! 3) I'd rather have only standard comments, not in this format: String result = properties.getProperty(key);// Try to get the property with the specified case. 4) Yeah about the testFailureIgnore, let's look at that in the other opened JIRA. > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch, > GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062033#comment-14062033 ] Lewis John McGibbney commented on GORA-354: --- Comments [~renato2099], I see this patch embraces user driven properties first, then attempts to find the lowercase one. Is this what you had in mind? > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.palsulich.071514.full.patch, > GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062004#comment-14062004 ] Lewis John McGibbney commented on GORA-354: --- Looks good to me folks. The only concern I have is with the non-related removal of Maven config from parent pom.xml. Any other comments? > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, > GORA-354.palsulich.071414.full.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058833#comment-14058833 ] Lewis John McGibbney commented on GORA-354: --- [~renato2099] where do you propose we do the check(s)? > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058559#comment-14058559 ] Renato Javier Marroquín Mogrovejo commented on GORA-354: Hey guys, I think Tyler's suggestion to move this into the getProperty is right, but I don't think we add this double check on the property as the property's names should be in lowercase and we should enforce that users do that (as we use the properties this way inside Gora). I mean it's fine double checking, but it's an extra IF for nothing, that we would have to do every time we request for a property, even if this is not initialization phase. That is just my 2c. > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Tyler Palsulich >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058356#comment-14058356 ] Lewis John McGibbney commented on GORA-354: --- scope. I'll look into this Tyler but I am assignin to your for Karma :) > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057572#comment-14057572 ] Tyler Palsulich commented on GORA-354: -- Hi Lewis, One patch is the unit test and the other is an attempt to fix it. So yes, both could be applied. But as of now, you should apply/review the unit test to make sure that is the problem we're trying to solve. The unit test fails with or without the attempted fix. I'm happy to help! :) > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057182#comment-14057182 ] Lewis John McGibbney commented on GORA-354: --- Hi [~tpalsulich]... I don't quite get this... both patches need to be applied now? Is that correct? Thank you SO much for the patch and effprt. This may seem trivial but it is V important for new users. > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch, GORA-354.unit-test.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056675#comment-14056675 ] Tyler Palsulich commented on GORA-354: -- Ah. Just read again. Do you want a PR instead of a patch? > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 0.5 > > Attachments: GORA-354.palsulich.070914.patch > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056643#comment-14056643 ] Lewis John McGibbney commented on GORA-354: --- Can you submit a PR [~tpalsulich]? I will merge and commit. Thanks for commenting. > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 0.5 > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[
https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056550#comment-14056550
]
Tyler Palsulich commented on GORA-354:
--
I think a better solution than altering {{findProperty()}} is to update
{{getProperty()}} as follows. This way, we attempt to respect the user's
capitalization, and only fall back to lowercase if with case failed. If we go
this route, we can clean up the logic in {{findProperty()}}.
{code}
private static String getProperty(Properties properties, String key, String
defaultValue) {
if (properties == null) {
return defaultValue;
}
String result = properties.getProperty(key);
if (result == null) {
result = properties.getProperty(key.toLowerCase());
}
return result;
}
{code}
> Clarify lowercasing of DataStoreFactory#findProperty
>
>
> Key: GORA-354
> URL: https://issues.apache.org/jira/browse/GORA-354
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-core
>Affects Versions: 0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Critical
> Fix For: 0.5
>
>
> Right now it appears that the reading of key's and value's from
> DataStoreFactory#findProperty is a process which does not lowercase keys or
> values.
> This can result in undesired behavhiour meaning that configuration properties
> are not used properly @Runtime.
> The fix should be a lowercasing of all properties so that they can be stored
> within and read from the call to System properties.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
[ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054138#comment-14054138 ] Lewis John McGibbney commented on GORA-354: --- http://www.mail-archive.com/dev%40gora.apache.org/msg04821.html > Clarify lowercasing of DataStoreFactory#findProperty > > > Key: GORA-354 > URL: https://issues.apache.org/jira/browse/GORA-354 > Project: Apache Gora > Issue Type: Improvement > Components: gora-core >Affects Versions: 0.5 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Critical > Fix For: 0.5 > > > Right now it appears that the reading of key's and value's from > DataStoreFactory#findProperty is a process which does not lowercase keys or > values. > This can result in undesired behavhiour meaning that configuration properties > are not used properly @Runtime. > The fix should be a lowercasing of all properties so that they can be stored > within and read from the call to System properties. -- This message was sent by Atlassian JIRA (v6.2#6252)
