Re: is IGNITE-3142 actual now

[Вадим Опольский]

OK, thank you, Denis!

2017-06-06 21:04 GMT+03:00 Denis Magda <dma...@apache.org>:

> Vadim,
>
> Please try to run the reproducer attached. If the error pops up then the
> bug needs to be fixed.
>
> —
> Denis
>
> > On Jun 6, 2017, at 4:36 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
> >
> > Hello guys!
> >
> > I want to resolve issue https://issues.apache.org/
> jira/browse/IGNITE-3142 <https://issues.apache.org/jira/browse/IGNITE-3142
> >
> >
> > Is it actual now?
> >
> > Vadim Opolski
>
>

is IGNITE-3142 actual now

[Вадим Опольский]

Hello guys!

I want to resolve issue https://issues.apache.org/jira/browse/IGNITE-3142

Is it actual now?

Vadim Opolski

Fwd: place for printing info about partition distribution (IGNITE-4756)

[Вадим Опольский]

Guys, lets suggest the format for this log.

Yakov's version is "print only nodes that differ on +/-10% from average
partitions count we can print problem message looks like:

[cacheName=NAME, nodes=[nodeId=<ID, totalPartitionsCount=,
percentageOfTotalPartsCount=, parts=[, ...,]]

Where the first element of parts array is a count of primary partitions,
the second is count of backup0 partitions etc.
 The default value of the property IGNITE_PART_DISTRIBUTION_WARN_THRESHOLD
must disable distribution calculation because it takes  *
 *  operations per node. "

Do you agree ?


-- Forwarded message --
From: Вадим Опольский <vaopols...@gmail.com>
Date: 2017-06-04 13:42 GMT+03:00
Subject: Fwd: place for printing info about partition distribution
(IGNITE-4756)
To: Denis Magda <dma...@apache.org>, tled...@gridgain.com, Yakov Zhdanov <
yzhda...@gridgain.com>


Hello guys!

I cant start resolve issue 4756 (https://issues.apache.org/
jira/browse/IGNITE-4756) because don't understand place for pinting info
about partition.

Yakov, Taras do you have any idea about it ?

Vadim Opolski



-- Forwarded message --
From: Вадим Опольский <vaopols...@gmail.com>
Date: 2017-05-31 18:24 GMT+03:00
Subject: place for printing info about partition distribution
To: dev@ignite.apache.org, Denis Magda <dma...@apache.org>,
tled...@gridgain.com, Yakov Zhdanov <yzhda...@gridgain.com>


Hello guys!

I want to discuss and suggest some format and place for pinting info about
partition distribution to log from issue https://issues.apache.org/jira
/browse/IGNITE-4756

What do you think about it ?

Issue is about RendezvousAffinityFunction and FairAffinityFunction classes.

Vadim

place for printing info about partition distribution

[Вадим Опольский]

Hello guys!

I want to discuss and suggest some format and place for pinting info about
partition distribution to log from issue
https://issues.apache.org/jira/browse/IGNITE-4756

What do you think about it ?

Issue is about RendezvousAffinityFunction and FairAffinityFunction classes.

Vadim

IGNITE-4756

[Вадим Опольский]

Hello guys!

I want to resolve isuue - https://issues.apache.org/jira/browse/IGNITE-4756

But cant find information about where to create log message in correct
format. Help please.

Vadim Opolski

Re: [jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS

[Вадим Опольский]

Hello , Prachi!

I reviewed reference. Removing occurrence it was the right action, Thank
you!

Vadim Opolski



2017-05-23 2:19 GMT+03:00 Prachi Garg (JIRA) :

>
> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.
> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
> l=16020380#comment-16020380 ]
>
> Prachi Garg commented on IGNITE-4052:
> -
>
> [~ntikhonov] I have merged the changes and also made some edits. Within
> the Json code block, the following was mentioned twice.
> "MESOS_USER" : "userA",
>  "MESOS_ROLE" :  "role1"
>
> I have removed one occurrence. Please review and confirm that it was the
> right action.
>
> > Add ability to set up users for MESOS
> > -
> >
> > Key: IGNITE-4052
> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
> > Project: Ignite
> >  Issue Type: Improvement
> >  Components: general
> >Affects Versions: 1.7
> >Reporter: Nikolay Tikhonov
> >Assignee: Prachi Garg
> >Priority: Trivial
> >
> > In current implementation Ignite Mesos Framework connects to MESOS
> cluster via current user. Need to add ability to configure this parameters
> via system env properties. Also need to add properties for mesos role.
> > See org/apache/ignite/mesos/IgniteFramework.java:537
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

Fwd: [jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS

[Вадим Опольский]

Hello Prachi!

Have you seen the edits  in readme.io for Mesos Deployment page:
https://dash.readme.io/project/apacheignite/v2.0/suggested

Vadim Opolski



-- Forwarded message --
From: Denis Magda (JIRA) 
Date: 2017-05-15 23:02 GMT+03:00
Subject: [jira] [Commented] (IGNITE-4052) Add ability to set up users for
MESOS
To: vaopols...@gmail.com



[ https://issues.apache.org/jira/browse/IGNITE-4052?page=
com.atlassian.jira.plugin.system.issuetabpanels:comment-
tabpanel=16011240#comment-16011240 ]

Denis Magda commented on IGNITE-4052:
-

[~pgarg], please review and apply the edits suggested by Vadim in readme.io
for Mesos Deployment page:
https://dash.readme.io/project/apacheignite/v2.0/suggested

> Add ability to set up users for MESOS
> -
>
> Key: IGNITE-4052
> URL: https://issues.apache.org/jira/browse/IGNITE-4052
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Affects Versions: 1.7
>Reporter: Nikolay Tikhonov
>Assignee: Prachi Garg
>Priority: Trivial
>
> In current implementation Ignite Mesos Framework connects to MESOS
cluster via current user. Need to add ability to configure this parameters
via system env properties. Also need to add properties for mesos role.
> See org/apache/ignite/mesos/IgniteFramework.java:537



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: IGNITE-4447 ready for review

[Вадим Опольский]

Hi guys!

Semyon, test suite Ignite Cache 5 with Cache150ClientsTest failed. Run it
twice. But local it succesfully executed. What do you think about it ?

http://ci.ignite.apache.org/viewLog.html?buildId=616787=buildResultsDiv=IgniteTests_IgniteCache5

Vadim

2017-05-17 11:34 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:

> Hi Semyon!
>
> I had problem with starting TC test yesterday. Just have queued it -
> http://ci.ignite.apache.org/project.html?projectId=IgniteTests_
> IgniteTests=pull%2F1952%2Fmerge
>
> Vadim
>
> 2017-05-16 14:10 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:
>
>> Hi Vadim,
>>
>> Did you check test pass on TeamCity in this suite, could you please
>> provide
>> link for related TeamCity run?
>>
>> Thanks
>>
>> On Tue, May 16, 2017 at 1:35 PM, Вадим Опольский <vaopols...@gmail.com>
>> wrote:
>>
>> > Hi guys!
>> >
>> > IgniteCache150ClientsTest.java was removed from
>> > IgniteClientTestSuite.java to IgniteCacheTestSuite.java. Single test
>> suite
>> > was deleted.
>> >
>> > Review please this fix - https://github.com/apache/ignite/pull/1952
>> >
>> > Vadim Opolskii
>> >
>> >
>> >
>> > 2017-05-15 11:38 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:
>> >
>> > > Hi guys!
>> > >
>> > > Vladimir, is issue https://issues.apache.org/jira/browse/IGNITE-4447
>> > > actual now?
>> > >
>> > > Which tests do u mean? Detail please.
>> > >
>> > > Vadim
>> > >
>> >
>>
>
>

IGNITE - 3469

[Вадим Опольский]

Hi guys!

Is issue https://issues.apache.org/jira/browse/IGNITE-3469 actual now ?

What else needs to be done ?

Vadim

Re: IGNITE-4447 ready for review

[Вадим Опольский]

Hi Semyon!

I had problem with starting TC test yesterday. Just have queued it -
http://ci.ignite.apache.org/project.html?projectId=IgniteTests_IgniteTests=pull%2F1952%2Fmerge

Vadim

2017-05-16 14:10 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Hi Vadim,
>
> Did you check test pass on TeamCity in this suite, could you please provide
> link for related TeamCity run?
>
> Thanks
>
> On Tue, May 16, 2017 at 1:35 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
> > Hi guys!
> >
> > IgniteCache150ClientsTest.java was removed from
> > IgniteClientTestSuite.java to IgniteCacheTestSuite.java. Single test
> suite
> > was deleted.
> >
> > Review please this fix - https://github.com/apache/ignite/pull/1952
> >
> > Vadim Opolskii
> >
> >
> >
> > 2017-05-15 11:38 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:
> >
> > > Hi guys!
> > >
> > > Vladimir, is issue https://issues.apache.org/jira/browse/IGNITE-4447
> > > actual now?
> > >
> > > Which tests do u mean? Detail please.
> > >
> > > Vadim
> > >
> >
>

Re: [jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS

[Вадим Опольский]

Hello Prachi!

I reassigned issue https://issues.apache.org/jira/browse/IGNITE-4052 to you
to approve changes of page -
https://apacheignite.readme.io/docs/mesos-deployment#section-ignite-mesos-framework

Vadim

2017-05-11 11:54 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:

> Hello guys!
>
> I want to update https://apacheignite.readme.io/docs/mesos-deployment
> with new text according with https://cwiki.apache.org/
> confluence/display/IGNITE/Documentation
> But have a problem with authentication, registered login
> vaopols...@gmail.com.
> Help me, please.
>
> New text:
>
> 3.Copy the following application definition (in JSON format) and save to
> marathon.json file. Update any parameters which would like to change.
>
>
>
> *A role name must be a valid directory name, so it cannot:  • Be an empty
> string  • Be . or ..  • Start with -  • Contain any slash, backspace, or
> whitespace character*
>  If doesn't set restriction on cluster then the framework will try to
> occupy all resources in Mesos cluster. See Configuration section below.
>
> JSON
> {
>   "id": "ignition",
>   "instances": 1,
>   "cpus": 2,
>   "mem": 2048,
>   "ports": [0],
>   "uris": [
> "http://host/ignite-mesos--jar-with-dependencies.jar"
>   ],
>   "env": {
> "IGNITE_NODE_COUNT": "4",
> "MESOS_MASTER_URL": "zk://localhost:2181/mesos",
> "IGNITE_RUN_CPU_PER_NODE": "2",
> "IGNITE_MEMORY_PER_NODE": "2048",
> "IGNITE_VERSION": "1.0.5",
>
>
> *"MESOS_USER" : "userA","MESOS_ROLE" :  "role1"*  },
>   "cmd": "java -jar ignite-mesos--
> jar-with-dependencies.jar"
> }
>
> Vadim
>
>
> 2017-04-27 19:29 GMT+03:00 Nikolay Tikhonov (JIRA) <j...@apache.org>:
>
>>
>> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.
>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>> l=15986959#comment-15986959 ]
>>
>> Nikolay Tikhonov commented on IGNITE-4052:
>> --
>>
>> [~javaller],
>> Thank you for your contribution. I've fixed some minors issue and pushed
>> your changes into {{ignite-4052}} branch. Please look at the changes.
>>
>> >I dont work with Mesos and think that anyone who has experience should
>> make it. OK?
>> I think that it good time to try it. ;) It looks strange when developer
>> don't run own code. [2] Also would be great to update docs [1]. Use for it
>> {{suggest edits}} button.
>>
>> 1. https://apacheignite.readme.io/docs/mesos-deployment
>> 2. http://mesos.apache.org/gettingstarted/
>>
>> > Add ability to set up users for MESOS
>> > -
>> >
>> > Key: IGNITE-4052
>> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
>> > Project: Ignite
>> >  Issue Type: Improvement
>> >  Components: general
>> >Affects Versions: 1.7
>> >Reporter: Nikolay Tikhonov
>> >Assignee: Vadim Opolski
>> >Priority: Trivial
>> >
>> > In current implementation Ignite Mesos Framework connects to MESOS
>> cluster via current user. Need to add ability to configure this parameters
>> via system env properties. Also need to add properties for mesos role.
>> > See org/apache/ignite/mesos/IgniteFramework.java:537
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.15#6346)
>>
>
>

IGNITE-4447

[Вадим Опольский]

Hi guys!

Vladimir, is issue https://issues.apache.org/jira/browse/IGNITE-4447 actual
now?

Which tests do u mean? Detail please.

Vadim

Re: [jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS

[Вадим Опольский]

Hello guys!

I want to update https://apacheignite.readme.io/docs/mesos-deployment with
new text according with
https://cwiki.apache.org/confluence/display/IGNITE/Documentation
But have a problem with authentication, registered login
vaopols...@gmail.com.
Help me, please.

New text:

3.Copy the following application definition (in JSON format) and save to
marathon.json file. Update any parameters which would like to change.



*A role name must be a valid directory name, so it cannot:  • Be an empty
string  • Be . or ..  • Start with -  • Contain any slash, backspace, or
whitespace character*
 If doesn't set restriction on cluster then the framework will try to
occupy all resources in Mesos cluster. See Configuration section below.

JSON
{
  "id": "ignition",
  "instances": 1,
  "cpus": 2,
  "mem": 2048,
  "ports": [0],
  "uris": [
"http://host/ignite-mesos--jar-with-dependencies.jar"
  ],
  "env": {
"IGNITE_NODE_COUNT": "4",
"MESOS_MASTER_URL": "zk://localhost:2181/mesos",
"IGNITE_RUN_CPU_PER_NODE": "2",
"IGNITE_MEMORY_PER_NODE": "2048",
"IGNITE_VERSION": "1.0.5",


*"MESOS_USER" : "userA","MESOS_ROLE" :  "role1"*  },
  "cmd": "java -jar ignite-mesos--jar-with-dependencies.jar"
}

Vadim


2017-04-27 19:29 GMT+03:00 Nikolay Tikhonov (JIRA) :

>
> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=15986959#comment-15986959 ]
>
> Nikolay Tikhonov commented on IGNITE-4052:
> --
>
> [~javaller],
> Thank you for your contribution. I've fixed some minors issue and pushed
> your changes into {{ignite-4052}} branch. Please look at the changes.
>
> >I dont work with Mesos and think that anyone who has experience should
> make it. OK?
> I think that it good time to try it. ;) It looks strange when developer
> don't run own code. [2] Also would be great to update docs [1]. Use for it
> {{suggest edits}} button.
>
> 1. https://apacheignite.readme.io/docs/mesos-deployment
> 2. http://mesos.apache.org/gettingstarted/
>
> > Add ability to set up users for MESOS
> > -
> >
> > Key: IGNITE-4052
> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
> > Project: Ignite
> >  Issue Type: Improvement
> >  Components: general
> >Affects Versions: 1.7
> >Reporter: Nikolay Tikhonov
> >Assignee: Vadim Opolski
> >Priority: Trivial
> >
> > In current implementation Ignite Mesos Framework connects to MESOS
> cluster via current user. Need to add ability to configure this parameters
> via system env properties. Also need to add properties for mesos role.
> > See org/apache/ignite/mesos/IgniteFramework.java:537
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

Scala issue

[Вадим Опольский]

Hi guys!

I want to resolve ticket with Scala. Recommend me please such a issue.
Maybe with Spark.

Vadim Opolski

Re: IGNITE-1084 is ready for review

[Вадим Опольский]

Hello guys!

Semen, Sergey is issue
https://issues.apache.org/jira/browse/IGNITE-1084 resolved
?

Vadim Opolski

2017-04-19 14:06 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Vadim,
>
> I found that real cause of IGNITE-1084 is IGNITE-4760, so suggested test
> fix in pull/1828 is not correct. I added new comments in IGNITE-4760,
> please take a look.
>
> Thanks,
> Semyon
>
> On Wed, Apr 19, 2017 at 12:17 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hello guys!
>>
>> The issue IGNITE-1084 https://issues.apache.org/jira/browse/IGNITE-1794 fixed
>> originally by Milap Wadhwa.
>>
>> I reassigned it on myself because she didn't make improvements from Anton
>> Vinogradov's comments. Also I just finished another issue with hibernate's
>> test.
>>
>> Review it please - https://github.com/apache/ignite/pull/1828
>>
>> Vadim Opolski
>>
>
>

Re: [jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS

[Вадим Опольский]

Hi guys!

Nikolay, the next improvements are maden (
https://github.com/apache/ignite/pull/1783):

   - changed code according with code style (extra space, if else blocks,
   javadoc)
   - written two tests one which will testing new parametes and other which
   will testing role validation
   - used PowerMock framework to getRole getUser testing
   - ridden #setEnv method

I did not test this parameters on real mesos cluster.

Nikolay, I dont work with Mesos and think that anyone who has experience
should make it. OK?

Vadim Opolski

2017-04-19 17:01 GMT+03:00 Nikolay Tikhonov (JIRA) :

>
> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=15974725#comment-15974725 ]
>
> Nikolay Tikhonov commented on IGNITE-4052:
> --
>
> [~javaller]
> I've looked at changes and have minor comments:
> * code style (extra space, if esle blocks, javadoc and etc.
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute);
> * let's split #testIgniteFramework() test: one which will testing new
> parametes and other which will testing role validation;
> * let's to use PowerMock in test (distributed under apache 2.0 licence
> which acceptable for our product) and rid #setEnv method;
>
> And again, did you test this parameters on real mesos cluster?
>
> Thank you for your contribution.
>
> > Add ability to set up users for MESOS
> > -
> >
> > Key: IGNITE-4052
> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
> > Project: Ignite
> >  Issue Type: Improvement
> >  Components: general
> >Affects Versions: 1.7
> >Reporter: Nikolay Tikhonov
> >Assignee: Vadim Opolski
> >Priority: Trivial
> >
> > In current implementation Ignite Mesos Framework connects to MESOS
> cluster via current user. Need to add ability to configure this parameters
> via system env properties. Also need to add properties for mesos role.
> > See org/apache/ignite/mesos/IgniteFramework.java:537
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

IGNITE-1084 and IGNITE-4760 are ready for review

[Вадим Опольский]

Hi Semyon!

I added AccessType parameter in 'threadLocalForCache'.
Merged HibernateL2CacheNonStrictReadWriteSelfTest and
HibernateL2CacheReadWriteSelfTest to HibernateL2CacheStrategySelfTest.
Merged fix for issue IGNITE-4760 and issue IGNITE-1084 and checked that
HibernateL2CacheSelfTest#testNaturalIdCache() did not fail after fix IGNITE-
4760.

Review please again.

https://github.com/apache/ignite/pull/1841

Vadim Opolski




2017-04-19 14:06 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Vadim,
>
> I found that real cause of IGNITE-1084 is IGNITE-4760, so suggested test
> fix in pull/1828 is not correct. I added new comments in IGNITE-4760,
> please take a look.
>
> Thanks,
> Semyon
>
> On Wed, Apr 19, 2017 at 12:17 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hello guys!
>>
>> The issue IGNITE-1084 https://issues.apache.org/jira/browse/IGNITE-1794 fixed
>> originally by Milap Wadhwa.
>>
>> I reassigned it on myself because she didn't make improvements from Anton
>> Vinogradov's comments. Also I just finished another issue with hibernate's
>> test.
>>
>> Review it please - https://github.com/apache/ignite/pull/1828
>>
>> Vadim Opolski
>>
>
>

IGNITE-1084 is ready for review

[Вадим Опольский]

Hello guys!

The issue IGNITE-1084 https://issues.apache.org/jira/browse/IGNITE-1794 fixed
originally by Milap Wadhwa.

I reassigned it on myself because she didn't make improvements from Anton
Vinogradov's comments. Also I just finished another issue with hibernate's
test.

Review it please - https://github.com/apache/ignite/pull/1828

Vadim Opolski

Fwd: IGNITE - 4760 ready for review

[Вадим Опольский]

Hi guys!

Semyon, have you viewed https://github.com/apache/ignite/pull/1768

Is it true for issue https://issues.apache.org/jira/browse/IGNITE-4760 ?

What can I improve ?

Vadim Opolski

-- Forwarded message --
From: Вадим Опольский <vaopols...@gmail.com>
Date: 2017-04-15 10:45 GMT+03:00
Subject: Re: IGNITE - 4760 ready for review
To: Semyon Boikov <sboi...@gridgain.com>
Cc: dev@ignite.apache.org, Valentin Kulichenko <
valentin.kuliche...@gmail.com>


Hi Semyon!

I added tests for ReadWrite and NonStrictReadWrite strategy.

Also I couldn't find how to get information about access type for created
region and added overload method threadLocalForCache() without param for
ReadWrite Strategy case in createAccessStrategy. Is it right ?

https://github.com/apache/ignite/pull/1768

Vadim

2017-04-13 15:05 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Hi Vadim,
>
> I added comments in JIRA. I'll apply the same fix for hibernate5 when fix
> is finalized.
>
> Thanks!
>
> On Thu, Apr 13, 2017 at 12:10 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi, guys!
>>
>> Semyon, have you had a time to review IGNITE-4760
>> https://github.com/apache/ignite/pull/1768 ?
>>
>> Is this fix actual for hibernate5 module?
>>
>> Vadim Opolski
>>
>> 2017-04-11 13:40 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:
>>
>>> Thanks Vadim, I'll try to do review today.
>>>
>>> Semyon
>>>
>>> On Mon, Apr 10, 2017 at 8:15 PM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>>> Hello guys!
>>>>
>>>> Semyon, review please again. Test check corresponding IgniteCaches
>>>> contain expected number of entries. Test fails for
>>>> HibernateNonStrictAccessStrategy.
>>>> And per-cache thread local in method threadLocalForCache fix this issue.
>>>>
>>>> https://github.com/apache/ignite/pull/1768/files
>>>>
>>>> Vadim Opolski
>>>>
>>>>
>>>> 2017-04-07 14:15 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:
>>>>
>>>>> Hi Vadim,
>>>>>
>>>>> Test does not look correct to me. I think test need check that
>>>>> corresponding IgniteCaches contain expected number of entries like
>>>>> 'testCacheUsage' does.
>>>>>
>>>>> Thanks
>>>>>
>>>>> On Wed, Apr 5, 2017 at 3:26 PM, Вадим Опольский <vaopols...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Hello everybody!
>>>>>>
>>>>>> Added test. Test fails after session.update(e2forUpdate). This update
>>>>>> must put into ENTITY2_NAME region, but it puts into ENTITY1_NAME and
>>>>>> ENTITY2_NAME regions.
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/pull/1
>>>>>>
>>>>>> Is it true?
>>>>>>
>>>>>> I have no idea how to change the method threadLocalForCache to
>>>>>> support NONSTRICT_READ_WRITE strategy. I tried to change it in accordance
>>>>>> with Cameroon Braid report.
>>>>>>
>>>>>> Vadim Opolski
>>>>>>
>>>>>>
>>>>>> -- Forwarded message --
>>>>>> From: Вадим Опольский <vaopols...@gmail.com>
>>>>>> Date: 2017-04-03 17:39 GMT+03:00
>>>>>> Subject: Re: IGNITE - 4760 : working in hibernate module
>>>>>> To: dev@ignite.apache.org
>>>>>> Cc: Valentin Kulichenko <valentin.kuliche...@gmail.com>, Semyon
>>>>>> Boikov <sboi...@gridgain.com>
>>>>>>
>>>>>>
>>>>>> Hello everyone!
>>>>>>
>>>>>> I added some change to method threadLocalForCache  and added test
>>>>>> testEntityCacheNonStrictFails.
>>>>>>
>>>>>> How to reproduce situation when updates can be recorded to another
>>>>>> region?
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>>>>>> 07ed73872d62b2969a7411/modules/hibernate/src/main/java/org/a
>>>>>> pache/ignite/cache/hibernate/HibernateRegionFactory.java
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>>>>>> 07ed73872d62b2969a7411/modules/hib

Re: IGNITE-4052 ready for review

[Вадим Опольский]

Hi Nikolay!

The comments was added.

Vadim

2017-04-17 15:32 GMT+03:00 Nikolai Tikhonov <ntikho...@apache.org>:

> Vadim,
>
> Thank you for your contribution. I'll look at changes. Can you please post
> the list improvements to jira ticket?
>
> On Mon, Apr 17, 2017 at 3:23 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi, Nikolay!
>>
>> I've made the following improvements ( https://github.com/apache/igni
>> te/pull/1783 ):
>>
>> 1) Moved framework builder related code to separate method, so it make
>> code cleaner and framework testable.
>>
>> 2) Call framework builder method from test to test role and user.
>>
>> 3) Added validating mesos role according with mesos role documentation
>> http://mesos.apache.org/documentation/latest/roles/
>>
>> 4) Still using setEnv method because in IgniteFramework we cannot
>> override static method and make mock static methods (except powermock, but
>> it would require 3 extra dependencies in the module).
>>
>> P.S. setEnv method designed to worked both on Linux and Windows, and it
>> does not left variable in system environment  after testing.
>>
>> Vadim Opolski
>>
>>
>> 2017-04-14 12:07 GMT+03:00 Nikolay Tikhonov (JIRA) <j...@apache.org>:
>>
>>>
>>> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.a
>>> tlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&
>>> focusedCommentId=15968814#comment-15968814 ]
>>>
>>> Nikolay Tikhonov commented on IGNITE-4052:
>>> --
>>>
>>> [~javaller]
>>> It meens that lets remove #setEnv mathod and will create mock in test
>>> which will override {{getUser}} and {{getRole}} methods. Also how do you
>>> think might be need to add validation for role? Which valid set of values
>>> for this property?
>>>
>>> > Add ability to set up users for MESOS
>>> > -
>>> >
>>> > Key: IGNITE-4052
>>> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
>>> > Project: Ignite
>>> >  Issue Type: Improvement
>>> >  Components: general
>>> >Affects Versions: 1.7
>>> >Reporter: Nikolay Tikhonov
>>> >Assignee: Vadim Opolski
>>> >Priority: Trivial
>>> >
>>> > In current implementation Ignite Mesos Framework connects to MESOS
>>> cluster via current user. Need to add ability to configure this parameters
>>> via system env properties. Also need to add properties for mesos role.
>>> > See org/apache/ignite/mesos/IgniteFramework.java:537
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.15#6346)
>>>
>>
>>
>

IGNITE-4052 ready for review

[Вадим Опольский]

Hi, Nikolay!

I've made the following improvements (
https://github.com/apache/ignite/pull/1783 ):

1) Moved framework builder related code to separate method, so it make code
cleaner and framework testable.

2) Call framework builder method from test to test role and user.

3) Added validating mesos role according with mesos role documentation
http://mesos.apache.org/documentation/latest/roles/

4) Still using setEnv method because in IgniteFramework we cannot override
static method and make mock static methods (except powermock, but it would
require 3 extra dependencies in the module).

P.S. setEnv method designed to worked both on Linux and Windows, and it
does not left variable in system environment  after testing.

Vadim Opolski


2017-04-14 12:07 GMT+03:00 Nikolay Tikhonov (JIRA) :

>
> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=15968814#comment-15968814 ]
>
> Nikolay Tikhonov commented on IGNITE-4052:
> --
>
> [~javaller]
> It meens that lets remove #setEnv mathod and will create mock in test
> which will override {{getUser}} and {{getRole}} methods. Also how do you
> think might be need to add validation for role? Which valid set of values
> for this property?
>
> > Add ability to set up users for MESOS
> > -
> >
> > Key: IGNITE-4052
> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
> > Project: Ignite
> >  Issue Type: Improvement
> >  Components: general
> >Affects Versions: 1.7
> >Reporter: Nikolay Tikhonov
> >Assignee: Vadim Opolski
> >Priority: Trivial
> >
> > In current implementation Ignite Mesos Framework connects to MESOS
> cluster via current user. Need to add ability to configure this parameters
> via system env properties. Also need to add properties for mesos role.
> > See org/apache/ignite/mesos/IgniteFramework.java:537
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

Re: IGNITE - 4760 ready for review

[Вадим Опольский]

Hi Semyon!

I added tests for ReadWrite and NonStrictReadWrite strategy.

Also I couldn't find how to get information about access type for created
region and added overload method threadLocalForCache() without param for
ReadWrite Strategy case in createAccessStrategy. Is it right ?

https://github.com/apache/ignite/pull/1768

Vadim

2017-04-13 15:05 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Hi Vadim,
>
> I added comments in JIRA. I'll apply the same fix for hibernate5 when fix
> is finalized.
>
> Thanks!
>
> On Thu, Apr 13, 2017 at 12:10 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi, guys!
>>
>> Semyon, have you had a time to review IGNITE-4760
>> https://github.com/apache/ignite/pull/1768 ?
>>
>> Is this fix actual for hibernate5 module?
>>
>> Vadim Opolski
>>
>> 2017-04-11 13:40 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:
>>
>>> Thanks Vadim, I'll try to do review today.
>>>
>>> Semyon
>>>
>>> On Mon, Apr 10, 2017 at 8:15 PM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>>> Hello guys!
>>>>
>>>> Semyon, review please again. Test check corresponding IgniteCaches
>>>> contain expected number of entries. Test fails for
>>>> HibernateNonStrictAccessStrategy.
>>>> And per-cache thread local in method threadLocalForCache fix this issue.
>>>>
>>>> https://github.com/apache/ignite/pull/1768/files
>>>>
>>>> Vadim Opolski
>>>>
>>>>
>>>> 2017-04-07 14:15 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:
>>>>
>>>>> Hi Vadim,
>>>>>
>>>>> Test does not look correct to me. I think test need check that
>>>>> corresponding IgniteCaches contain expected number of entries like
>>>>> 'testCacheUsage' does.
>>>>>
>>>>> Thanks
>>>>>
>>>>> On Wed, Apr 5, 2017 at 3:26 PM, Вадим Опольский <vaopols...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Hello everybody!
>>>>>>
>>>>>> Added test. Test fails after session.update(e2forUpdate). This update
>>>>>> must put into ENTITY2_NAME region, but it puts into ENTITY1_NAME and
>>>>>> ENTITY2_NAME regions.
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/pull/1
>>>>>>
>>>>>> Is it true?
>>>>>>
>>>>>> I have no idea how to change the method threadLocalForCache to
>>>>>> support NONSTRICT_READ_WRITE strategy. I tried to change it in accordance
>>>>>> with Cameroon Braid report.
>>>>>>
>>>>>> Vadim Opolski
>>>>>>
>>>>>>
>>>>>> -- Forwarded message --
>>>>>> From: Вадим Опольский <vaopols...@gmail.com>
>>>>>> Date: 2017-04-03 17:39 GMT+03:00
>>>>>> Subject: Re: IGNITE - 4760 : working in hibernate module
>>>>>> To: dev@ignite.apache.org
>>>>>> Cc: Valentin Kulichenko <valentin.kuliche...@gmail.com>, Semyon
>>>>>> Boikov <sboi...@gridgain.com>
>>>>>>
>>>>>>
>>>>>> Hello everyone!
>>>>>>
>>>>>> I added some change to method threadLocalForCache  and added test
>>>>>> testEntityCacheNonStrictFails.
>>>>>>
>>>>>> How to reproduce situation when updates can be recorded to another
>>>>>> region?
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>>>>>> 07ed73872d62b2969a7411/modules/hibernate/src/main/java/org/a
>>>>>> pache/ignite/cache/hibernate/HibernateRegionFactory.java
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>>>>>> 07ed73872d62b2969a7411/modules/hibernate/src/test/java/org/a
>>>>>> pache/ignite/cache/hibernate/HibernateL2CacheConfigurationSe
>>>>>> lfTest.java
>>>>>>
>>>>>> PullRequest
>>>>>> https://github.com/vadopolski/ignite/pull/4/files
>>>>>>
>>>>>> Vadim
>>>>>>
>>>>>>
>>>>>>
>>>>>> 2017-03-27 18:20 GMT+03:00 Denis Magda <dma...@apache

Re: [jira] [Updated] (IGNITE-4052) Add ability to set up users for MESOS

[Вадим Опольский]

Hello guys!

Nikolai, I improved method getRole and getUser,

Review please again:

https://github.com/apache/ignite/pull/1783

but what do mean about override ?

Something like this:

public class IgniteFrameworkUnderTest extends IgniteFramework{

...
@Override
public String getUser(){
...
}

@Override
public String getRole(){
...
}

}

Vadim Opolski


2017-04-13 16:39 GMT+03:00 Nikolai Tikhonov (JIRA) <j...@apache.org>:

>
>  [ https://issues.apache.org/jira/browse/IGNITE-4052?page=
> com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Nikolai Tikhonov updated IGNITE-4052:
> -
>
> Vadim,
>
> I've left comment in the ticket.
>
> On Wed, Apr 12, 2017 at 3:00 PM, Вадим Опольский <vaopols...@gmail.com>
>
>
>
> > Add ability to set up users for MESOS
> > -
> >
> > Key: IGNITE-4052
> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
> > Project: Ignite
> >  Issue Type: Improvement
> >  Components: general
> >Affects Versions: 1.7
> >Reporter: Nikolay Tikhonov
> >Assignee: Vadim Opolski
> >Priority: Trivial
> >
> > In current implementation Ignite Mesos Framework connects to MESOS
> cluster via current user. Need to add ability to configure this parameters
> via system env properties. Also need to add properties for mesos role.
> > See org/apache/ignite/mesos/IgniteFramework.java:537
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

Re: IGNITE - 4760 ready for review

[Вадим Опольский]

Semyon, thanks for comments.

- I will change access type for created region.
- USE_STRUCTURED_CACHE property needs to store data in cache in a more
readable format. Without it I cant cast data from cache to String and
HashMap.
- I will add the same test for READ_WRITE access strategy.
- I will check code style rules.

Vadim


2017-04-13 15:05 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Hi Vadim,
>
> I added comments in JIRA. I'll apply the same fix for hibernate5 when fix
> is finalized.
>
> Thanks!
>
> On Thu, Apr 13, 2017 at 12:10 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi, guys!
>>
>> Semyon, have you had a time to review IGNITE-4760
>> https://github.com/apache/ignite/pull/1768 ?
>>
>> Is this fix actual for hibernate5 module?
>>
>> Vadim Opolski
>>
>> 2017-04-11 13:40 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:
>>
>>> Thanks Vadim, I'll try to do review today.
>>>
>>> Semyon
>>>
>>> On Mon, Apr 10, 2017 at 8:15 PM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>>> Hello guys!
>>>>
>>>> Semyon, review please again. Test check corresponding IgniteCaches
>>>> contain expected number of entries. Test fails for
>>>> HibernateNonStrictAccessStrategy.
>>>> And per-cache thread local in method threadLocalForCache fix this issue.
>>>>
>>>> https://github.com/apache/ignite/pull/1768/files
>>>>
>>>> Vadim Opolski
>>>>
>>>>
>>>> 2017-04-07 14:15 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:
>>>>
>>>>> Hi Vadim,
>>>>>
>>>>> Test does not look correct to me. I think test need check that
>>>>> corresponding IgniteCaches contain expected number of entries like
>>>>> 'testCacheUsage' does.
>>>>>
>>>>> Thanks
>>>>>
>>>>> On Wed, Apr 5, 2017 at 3:26 PM, Вадим Опольский <vaopols...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Hello everybody!
>>>>>>
>>>>>> Added test. Test fails after session.update(e2forUpdate). This update
>>>>>> must put into ENTITY2_NAME region, but it puts into ENTITY1_NAME and
>>>>>> ENTITY2_NAME regions.
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/pull/1
>>>>>>
>>>>>> Is it true?
>>>>>>
>>>>>> I have no idea how to change the method threadLocalForCache to
>>>>>> support NONSTRICT_READ_WRITE strategy. I tried to change it in accordance
>>>>>> with Cameroon Braid report.
>>>>>>
>>>>>> Vadim Opolski
>>>>>>
>>>>>>
>>>>>> -- Forwarded message --
>>>>>> From: Вадим Опольский <vaopols...@gmail.com>
>>>>>> Date: 2017-04-03 17:39 GMT+03:00
>>>>>> Subject: Re: IGNITE - 4760 : working in hibernate module
>>>>>> To: dev@ignite.apache.org
>>>>>> Cc: Valentin Kulichenko <valentin.kuliche...@gmail.com>, Semyon
>>>>>> Boikov <sboi...@gridgain.com>
>>>>>>
>>>>>>
>>>>>> Hello everyone!
>>>>>>
>>>>>> I added some change to method threadLocalForCache  and added test
>>>>>> testEntityCacheNonStrictFails.
>>>>>>
>>>>>> How to reproduce situation when updates can be recorded to another
>>>>>> region?
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>>>>>> 07ed73872d62b2969a7411/modules/hibernate/src/main/java/org/a
>>>>>> pache/ignite/cache/hibernate/HibernateRegionFactory.java
>>>>>>
>>>>>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>>>>>> 07ed73872d62b2969a7411/modules/hibernate/src/test/java/org/a
>>>>>> pache/ignite/cache/hibernate/HibernateL2CacheConfigurationSe
>>>>>> lfTest.java
>>>>>>
>>>>>> PullRequest
>>>>>> https://github.com/vadopolski/ignite/pull/4/files
>>>>>>
>>>>>> Vadim
>>>>>>
>>>>>>
>>>>>>
>>>>>> 2017-03-27 18:20 GMT+03:00 Denis Magda <dma...@apache.org>:
>>

Re: IGNITE - 4760 ready for review

[Вадим Опольский]

Hi, guys!

Semyon, have you had a time to review IGNITE-4760
https://github.com/apache/ignite/pull/1768 ?

Is this fix actual for hibernate5 module?

Vadim Opolski

2017-04-11 13:40 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Thanks Vadim, I'll try to do review today.
>
> Semyon
>
> On Mon, Apr 10, 2017 at 8:15 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hello guys!
>>
>> Semyon, review please again. Test check corresponding IgniteCaches
>> contain expected number of entries. Test fails for
>> HibernateNonStrictAccessStrategy.
>> And per-cache thread local in method threadLocalForCache fix this issue.
>>
>> https://github.com/apache/ignite/pull/1768/files
>>
>> Vadim Opolski
>>
>>
>> 2017-04-07 14:15 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:
>>
>>> Hi Vadim,
>>>
>>> Test does not look correct to me. I think test need check that
>>> corresponding IgniteCaches contain expected number of entries like
>>> 'testCacheUsage' does.
>>>
>>> Thanks
>>>
>>> On Wed, Apr 5, 2017 at 3:26 PM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>>> Hello everybody!
>>>>
>>>> Added test. Test fails after session.update(e2forUpdate). This update
>>>> must put into ENTITY2_NAME region, but it puts into ENTITY1_NAME and
>>>> ENTITY2_NAME regions.
>>>>
>>>> https://github.com/vadopolski/ignite/pull/1
>>>>
>>>> Is it true?
>>>>
>>>> I have no idea how to change the method threadLocalForCache to support
>>>> NONSTRICT_READ_WRITE strategy. I tried to change it in accordance with
>>>> Cameroon Braid report.
>>>>
>>>> Vadim Opolski
>>>>
>>>>
>>>> -- Forwarded message --
>>>> From: Вадим Опольский <vaopols...@gmail.com>
>>>> Date: 2017-04-03 17:39 GMT+03:00
>>>> Subject: Re: IGNITE - 4760 : working in hibernate module
>>>> To: dev@ignite.apache.org
>>>> Cc: Valentin Kulichenko <valentin.kuliche...@gmail.com>, Semyon Boikov
>>>> <sboi...@gridgain.com>
>>>>
>>>>
>>>> Hello everyone!
>>>>
>>>> I added some change to method threadLocalForCache  and added test
>>>> testEntityCacheNonStrictFails.
>>>>
>>>> How to reproduce situation when updates can be recorded to another
>>>> region?
>>>>
>>>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>>>> 07ed73872d62b2969a7411/modules/hibernate/src/main/java/org/a
>>>> pache/ignite/cache/hibernate/HibernateRegionFactory.java
>>>>
>>>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>>>> 07ed73872d62b2969a7411/modules/hibernate/src/test/java/org/a
>>>> pache/ignite/cache/hibernate/HibernateL2CacheConfigurationSelfTest.java
>>>>
>>>> PullRequest
>>>> https://github.com/vadopolski/ignite/pull/4/files
>>>>
>>>> Vadim
>>>>
>>>>
>>>>
>>>> 2017-03-27 18:20 GMT+03:00 Denis Magda <dma...@apache.org>:
>>>>
>>>>> Vadim,
>>>>>
>>>>> What IDE do you use? My recommendation would be to set up everything
>>>>> let’s say under IntellijIDEA or Eclipse and after that trying to compile
>>>>> from a terminal.
>>>>>
>>>>> This is how you can easily prepare the dev env in IntellijIDEA:
>>>>> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup <
>>>>> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup>
>>>>>
>>>>> —
>>>>> Denis
>>>>>
>>>>> > On Mar 27, 2017, at 7:14 AM, Вадим Опольский <vaopols...@gmail.com>
>>>>> wrote:
>>>>> >
>>>>> > Valentin, OK.
>>>>> >
>>>>> > To enabled it in my environment I done next:
>>>>> > - built project with command - mvn clean package -DskipTests
>>>>> -Prelease,lgpl
>>>>> > - added folder hibernate to modules in project structure
>>>>> > - added library to dependencies (without it import doesn't working)
>>>>> >
>>>>> > After that I have a lot of error, for instance:
>>>>> > - Class 'AccessStrategy' must either be

Re: [jira] [Commented] (IGNITE-4052) Add ability to set up users for MESOS

[Вадим Опольский]

Hello guys!

Nikolay, I looked at cassandra mesos integration, but cant find how to test
ability to configure mesos and user via system env properties. I will
continue to search in another projects which use Mesos.

Review please pull request - https://github.com/vadopolski/ignite/pull/2.
It contains new test and method for setting system environments.

Can you close issue https://issues.apache.org/jira/browse/IGNITE-4052 and
open new, about testing Mesos Integration.

Vadim Opolski

2017-04-03 12:13 GMT+03:00 Nikolay Tikhonov (JIRA) :

>
> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.
> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
> l=15953167#comment-15953167 ]
>
> Nikolay Tikhonov commented on IGNITE-4052:
> --
>
> [~javaller],
> For example you can look at cassandra mesos integration
> https://github.com/mesosphere/dcos-cassandra-service/blob/5d
> 6d15e646f1df2fa10fa98d91993d3a6b4719c4/cassandra-commons/src
> /main/java/com/mesosphere/dcos/cassandra/common/config/ServiceConfig.java.
> List of application which use Mesos not secret and can be found on official
> mesos site http://mesos.apache.org/documentation/latest/frameworks. ;)
>
> I'm really don't understand how the libs can help you. Could you clarify
> it?
>
> > Add ability to set up users for MESOS
> > -
> >
> > Key: IGNITE-4052
> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
> > Project: Ignite
> >  Issue Type: Improvement
> >  Components: general
> >Affects Versions: 1.7
> >Reporter: Nikolay Tikhonov
> >Assignee: Vadim Opolski
> >Priority: Trivial
> >
> > In current implementation Ignite Mesos Framework connects to MESOS
> cluster via current user. Need to add ability to configure this parameters
> via system env properties. Also need to add properties for mesos role.
> > See org/apache/ignite/mesos/IgniteFramework.java:537
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

Re: IGNITE-1794 is ready for review

[Вадим Опольский]

Denis, yes, I mean issue  https://issues.apache.org/jira/browse/IGNITE-1794

Yes I added some fixes in addition to previous changes. This fixes repeat
the Semyon's fixes.

Vadim

2017-04-11 19:55 GMT+03:00 Denis Magda <dma...@apache.org>:

> Vadim,
>
> Do you mean this task?
> > https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794>
> As I see Semen has already promised to review it and merge into the master
> by the end of the week.
>
> Did you add anything else in addition to previous changes?
>
> —
> Denis
>
> > On Apr 11, 2017, at 9:51 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
> >
> > Hello guys!
> >
> > I added folder hibernate5 as module to project settings and discovered
> some errors. Fixed errors in pull request - https://github.com/vopolski/
> ignite/pull/1/files <https://github.com/vopolski/ignite/pull/1/files>
> > But some tests from hibernate5 is failed. I'll fix them.
> >
> > How much time do I have?
> >
> > Vadim Opolski
> >
> > 2017-04-06 13:04 GMT+03:00 Вадим Опольский <vaopols...@gmail.com
> <mailto:vaopols...@gmail.com>>:
> > Dear sirs!
> >
> > Sorry for incorrect subject.
> >
> > https://github.com/apache/ignite/pull/1643 <https://github.com/apache/
> ignite/pull/1643>
> >
> > -- Forwarded message --
> > From: Вадим Опольский <vaopols...@gmail.com <mailto:vaopols...@gmail.com
> >>
> > Date: 2017-03-24 15:48 GMT+03:00
> > Subject: ready for review IGNITE-933
> > To: dev@ignite.apache.org <mailto:dev@ignite.apache.org>, Denis Magda <
> dma...@apache.org <mailto:dma...@apache.org>>, Valentin Kulichenko <
> valentin.kuliche...@gmail.com <mailto:valentin.kuliche...@gmail.com>>
> >
> >
> > Hello everyone!
> >
> > Denis, Valentin, what should I do to close issue
> https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794> ?
> >
> > The tests in Team City executed successfully.
> >
> > Valentin, I renamed IgniteHibernateTestSuite ->
> IgniteHibernate5TestSuite. Can you create TeamCity Configuration ?
> >
> >
> >
> > Vadim Opolski
> >
> > 2017-03-21 11:30 GMT+03:00 Вадим Опольский <vaopols...@gmail.com
> <mailto:vaopols...@gmail.com>>:
> > Hello everybody.
> >
> > The issue  https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794> fixed originally by
> Mykola Pereyma.
> > I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794> on myself, because we
> haven’t got a note from him for a while.
> >
> > Denis, I merged pull request https://github.com/apache/ignite/pull/1146
> <https://github.com/apache/ignite/pull/1146> with my fork.
> > Then I changed hibernate version to 5.2.7 and deleted ByteArrayType.java
> as per CI comments.
> > The tests from list below executed succesfully.
> >
> > Prepared new pull request - https://github.com/apache/ignite/pull/1643 <
> https://github.com/apache/ignite/pull/1643>
> >
> > What's the next step ?
> >
> > Tests:
> > HibernateL2CacheConfigurationSelfTest.java
> > HibernateL2CacheSelfTest.java
> > HibernateL2CacheTransactionalSelfTest.java
> > HibernateL2CacheTransactionalUseSyncSelfTest.java
> > CacheHibernateBlobStoreNodeRestartTest.java
> > CacheHibernateBlobStoreSelfTest.java
> > CacheHibernateStoreFactorySelfTest.java
> > CacheHibernateStoreSessionListenerSelfTest.java
> >
> >
> > Vadim Opolski
> >
> >
> > 2017-02-25 2:38 GMT+03:00 Denis Magda <dma...@apache.org  dma...@apache.org>>:
> > > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
> interesting for me. How I can assignee it to me? It is assigning with
> Mykola Pereyma now.
> > >
> > > https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794> <
> https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794>>
> >
> > Just re-assign it on yourself ;) Hope that Mykola is fine with this
> because we haven’t got a note from him for a while.
> >
> > —
> > Denis
> >
> > > On Feb 24, 2017, at 12:24 PM, Вадим Опольский <vaopols...@gmail.com
> <mailto:vaopols...@gmail.com>> wrote:
> > >
> > > Hi Denis,
> 

Re: IGNITE-1794 is ready for review

[Вадим Опольский]

Hi Semyon!

I've seen all fixes abut hibernate5 in ignite-3477-master. Will you finish
this issue?

Vadim Opolski

2017-04-11 19:54 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Hi Vadim,
>
> I already fixed all issues with hibernate5 tests and merged in
> ignite-3477-master, it will be merged in master soon.
>
> Thanks
>
> On Tue, Apr 11, 2017 at 7:51 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
> > Hello guys!
> >
> > I added folder hibernate5 as module to project settings and discovered
> some
> > errors. Fixed errors in pull request -
> > https://github.com/vopolski/ignite/pull/1/files
> > But some tests from hibernate5 is failed. I'll fix them.
> >
> > How much time do I have?
> >
> > Vadim Opolski
> >
> > 2017-04-06 13:04 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:
> >
> > > Dear sirs!
> > >
> > > Sorry for incorrect subject.
> > >
> > > https://github.com/apache/ignite/pull/1643
> > >
> > > -- Forwarded message --
> > > From: Вадим Опольский <vaopols...@gmail.com>
> > > Date: 2017-03-24 15:48 GMT+03:00
> > > Subject: ready for review IGNITE-933
> > > To: dev@ignite.apache.org, Denis Magda <dma...@apache.org>, Valentin
> > > Kulichenko <valentin.kuliche...@gmail.com>
> > >
> > >
> > > Hello everyone!
> > >
> > > Denis, Valentin, what should I do to close issue
> > > https://issues.apache.org/jira/browse/IGNITE-1794 ?
> > >
> > > The tests in Team City executed successfully.
> > >
> > > Valentin, I renamed IgniteHibernateTestSuite ->
> > IgniteHibernate5TestSuite.
> > > Can you create TeamCity Configuration ?
> > >
> > >
> > >
> > > Vadim Opolski
> > >
> > > 2017-03-21 11:30 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:
> > >
> > >> Hello everybody.
> > >>
> > >> The issue  https://issues.apache.org/jira/browse/IGNITE-1794 fixed
> > >> originally by Mykola Pereyma.
> > >> I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794
> > on
> > >> myself, because we haven’t got a note from him for a while.
> > >>
> > >> Denis, I merged pull request https://github.com/apache/
> ignite/pull/1146
> > with
> > >> my fork.
> > >> Then I changed hibernate version to 5.2.7 and deleted
> ByteArrayType.java
> > >> as per CI comments.
> > >> The tests from list below executed succesfully.
> > >>
> > >> Prepared new pull request - https://github.com/apache/
> ignite/pull/1643
> > >>
> > >> What's the next step ?
> > >>
> > >> Tests:
> > >> HibernateL2CacheConfigurationSelfTest.java
> > >> HibernateL2CacheSelfTest.java
> > >> HibernateL2CacheTransactionalSelfTest.java
> > >> HibernateL2CacheTransactionalUseSyncSelfTest.java
> > >> CacheHibernateBlobStoreNodeRestartTest.java
> > >> CacheHibernateBlobStoreSelfTest.java
> > >> CacheHibernateStoreFactorySelfTest.java
> > >> CacheHibernateStoreSessionListenerSelfTest.java
> > >>
> > >>
> > >> Vadim Opolski
> > >>
> > >>
> > >> 2017-02-25 2:38 GMT+03:00 Denis Magda <dma...@apache.org>:
> > >>
> > >>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974
> > is
> > >>> interesting for me. How I can assignee it to me? It is assigning with
> > >>> Mykola Pereyma now.
> > >>> >
> > >>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
> > >>> https://issues.apache.org/jira/browse/IGNITE-1794>
> > >>>
> > >>> Just re-assign it on yourself ;) Hope that Mykola is fine with this
> > >>> because we haven’t got a note from him for a while.
> > >>>
> > >>> —
> > >>> Denis
> > >>>
> > >>> > On Feb 24, 2017, at 12:24 PM, Вадим Опольский <
> vaopols...@gmail.com>
> > >>> wrote:
> > >>> >
> > >>> > Hi Denis,
> > >>> >
> > >>> > OK, I spotted the problem in the code and I will be try to resolve
> > it.
> > >>> >
> > >>> > https://issues.apache.org/jira/browse/IGNITE-933 <
> > >>> https://issues.ap

Re: IGNITE-1794 is ready for review

[Вадим Опольский]

Hello guys!

I added folder hibernate5 as module to project settings and discovered some
errors. Fixed errors in pull request -
https://github.com/vopolski/ignite/pull/1/files
But some tests from hibernate5 is failed. I'll fix them.

How much time do I have?

Vadim Opolski

2017-04-06 13:04 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:

> Dear sirs!
>
> Sorry for incorrect subject.
>
> https://github.com/apache/ignite/pull/1643
>
> -- Forwarded message ------
> From: Вадим Опольский <vaopols...@gmail.com>
> Date: 2017-03-24 15:48 GMT+03:00
> Subject: ready for review IGNITE-933
> To: dev@ignite.apache.org, Denis Magda <dma...@apache.org>, Valentin
> Kulichenko <valentin.kuliche...@gmail.com>
>
>
> Hello everyone!
>
> Denis, Valentin, what should I do to close issue
> https://issues.apache.org/jira/browse/IGNITE-1794 ?
>
> The tests in Team City executed successfully.
>
> Valentin, I renamed IgniteHibernateTestSuite -> IgniteHibernate5TestSuite.
> Can you create TeamCity Configuration ?
>
>
>
> Vadim Opolski
>
> 2017-03-21 11:30 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:
>
>> Hello everybody.
>>
>> The issue  https://issues.apache.org/jira/browse/IGNITE-1794 fixed
>> originally by Mykola Pereyma.
>> I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794 on
>> myself, because we haven’t got a note from him for a while.
>>
>> Denis, I merged pull request https://github.com/apache/ignite/pull/1146 with
>> my fork.
>> Then I changed hibernate version to 5.2.7 and deleted ByteArrayType.java
>> as per CI comments.
>> The tests from list below executed succesfully.
>>
>> Prepared new pull request - https://github.com/apache/ignite/pull/1643
>>
>> What's the next step ?
>>
>> Tests:
>> HibernateL2CacheConfigurationSelfTest.java
>> HibernateL2CacheSelfTest.java
>> HibernateL2CacheTransactionalSelfTest.java
>> HibernateL2CacheTransactionalUseSyncSelfTest.java
>> CacheHibernateBlobStoreNodeRestartTest.java
>> CacheHibernateBlobStoreSelfTest.java
>> CacheHibernateStoreFactorySelfTest.java
>> CacheHibernateStoreSessionListenerSelfTest.java
>>
>>
>> Vadim Opolski
>>
>>
>> 2017-02-25 2:38 GMT+03:00 Denis Magda <dma...@apache.org>:
>>
>>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
>>> interesting for me. How I can assignee it to me? It is assigning with
>>> Mykola Pereyma now.
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>>> https://issues.apache.org/jira/browse/IGNITE-1794>
>>>
>>> Just re-assign it on yourself ;) Hope that Mykola is fine with this
>>> because we haven’t got a note from him for a while.
>>>
>>> —
>>> Denis
>>>
>>> > On Feb 24, 2017, at 12:24 PM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>> >
>>> > Hi Denis,
>>> >
>>> > OK, I spotted the problem in the code and I will be try to resolve it.
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-933 <
>>> https://issues.apache.org/jira/browse/IGNITE-933>
>>> >
>>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
>>> interesting for me. How I can assignee it to me? It is assigning with
>>> Mykola Pereyma now.
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>>> https://issues.apache.org/jira/browse/IGNITE-1794>
>>> >
>>> > Vadim Opolski
>>> >
>>> > 2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org >> dma...@apache.org>>:
>>> > Hi Vadim,
>>> >
>>> > Yes, this issue might be still relevant. I can’t guide you through
>>> but, basically, you need to reproduce the issue, spot it in the code and
>>> propose a fix.
>>> >
>>> > BTW, do you have any experience with Hibernate? If so, I would be
>>> amazing if you pick up this ticket reassigning on yourself:
>>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>>> https://issues.apache.org/jira/browse/IGNITE-1794> <
>>> https://issues.apache.org/jira/browse/IGNITE-1794 <
>>> https://issues.apache.org/jira/browse/IGNITE-1794>>
>>> >
>>> > —
>>> > Denis
>>> >
>>> > > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopols...@gmail.com
>>> <mailto:vaopols...@gmail.com>> wrote:
>>> > >
>>> > > Dear sirs !
>>> > >
>>> > > I want to resolve issue IGNITE-933
>>> > >
>>> > > https://issues.apache.org/jira/browse/IGNITE-933 <
>>> https://issues.apache.org/jira/browse/IGNITE-933>
>>> > >
>>> > > Is it actual ?
>>> > >
>>> > > In which class and method you want me to make changes ?
>>> > >
>>> > > Vadim Opolski
>>> >
>>> >
>>>
>>>
>>
>
>

IGNITE - 4760 ready for review

[Вадим Опольский]

Hello guys!

Semyon, review please again. Test check corresponding IgniteCaches contain
expected number of entries. Test fails for
HibernateNonStrictAccessStrategy.
And per-cache thread local in method threadLocalForCache fix this issue.

https://github.com/apache/ignite/pull/1768/files

Vadim Opolski


2017-04-07 14:15 GMT+03:00 Semyon Boikov <sboi...@gridgain.com>:

> Hi Vadim,
>
> Test does not look correct to me. I think test need check that
> corresponding IgniteCaches contain expected number of entries like
> 'testCacheUsage' does.
>
> Thanks
>
> On Wed, Apr 5, 2017 at 3:26 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hello everybody!
>>
>> Added test. Test fails after session.update(e2forUpdate). This update
>> must put into ENTITY2_NAME region, but it puts into ENTITY1_NAME and
>> ENTITY2_NAME regions.
>>
>> https://github.com/vadopolski/ignite/pull/1
>>
>> Is it true?
>>
>> I have no idea how to change the method threadLocalForCache to support
>> NONSTRICT_READ_WRITE strategy. I tried to change it in accordance with
>> Cameroon Braid report.
>>
>> Vadim Opolski
>>
>>
>> -- Forwarded message --
>> From: Вадим Опольский <vaopols...@gmail.com>
>> Date: 2017-04-03 17:39 GMT+03:00
>> Subject: Re: IGNITE - 4760 : working in hibernate module
>> To: dev@ignite.apache.org
>> Cc: Valentin Kulichenko <valentin.kuliche...@gmail.com>, Semyon Boikov <
>> sboi...@gridgain.com>
>>
>>
>> Hello everyone!
>>
>> I added some change to method threadLocalForCache  and added test
>> testEntityCacheNonStrictFails.
>>
>> How to reproduce situation when updates can be recorded to another region?
>>
>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>> 07ed73872d62b2969a7411/modules/hibernate/src/main/java/org/
>> apache/ignite/cache/hibernate/HibernateRegionFactory.java
>>
>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5
>> 07ed73872d62b2969a7411/modules/hibernate/src/test/java/org/
>> apache/ignite/cache/hibernate/HibernateL2CacheConfigurationSelfTest.java
>>
>> PullRequest
>> https://github.com/vadopolski/ignite/pull/4/files
>>
>> Vadim
>>
>>
>>
>> 2017-03-27 18:20 GMT+03:00 Denis Magda <dma...@apache.org>:
>>
>>> Vadim,
>>>
>>> What IDE do you use? My recommendation would be to set up everything
>>> let’s say under IntellijIDEA or Eclipse and after that trying to compile
>>> from a terminal.
>>>
>>> This is how you can easily prepare the dev env in IntellijIDEA:
>>> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup <
>>> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup>
>>>
>>> —
>>> Denis
>>>
>>> > On Mar 27, 2017, at 7:14 AM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>> >
>>> > Valentin, OK.
>>> >
>>> > To enabled it in my environment I done next:
>>> > - built project with command - mvn clean package -DskipTests
>>> -Prelease,lgpl
>>> > - added folder hibernate to modules in project structure
>>> > - added library to dependencies (without it import doesn't working)
>>> >
>>> > After that I have a lot of error, for instance:
>>> > - Class 'AccessStrategy' must either be declared abstract or implement
>>> abstract method 'remove(SharedSessionContractImplementor, Object) in
>>> 'RegionAccessStrategy'
>>> >
>>> > generateCacheKey
>>> > getCacheKeyId
>>> > getRegion
>>> > insert
>>> > afterInsert
>>> > update
>>> > afterUpdate
>>> > insert
>>> > afterInsert
>>> > update
>>> > get
>>> > putFromLoad
>>> > lockItem
>>> > unlockItem
>>> > remove
>>> >
>>> > Do anybody know the easier way to resolve this issue?
>>> >
>>> > Also tried to reimport all maven projects and cleansed repository in
>>> .m2.
>>> > Vadim Opolski
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> > 2017-03-25 2:42 GMT+03:00 Valentin Kulichenko <
>>> valentin.kuliche...@gmail.com <mailto:valentin.kuliche...@gmail.com>>:
>>> > Vadim,
>>> >
>>> > ignite-hibernate module is a part of 'lgpl' profile. Apparently it's
>>> not
>>> > enabled in your environment.
>>> >
>>> > -Val
>>> >
>>> > On Fri, Mar 24, 2017 at 4:38 PM, Вадим Опольский <vaopols...@gmail.com
>>> <mailto:vaopols...@gmail.com>>
>>> > wrote:
>>> >
>>> > > Hello everybody,
>>> > >
>>> > > I want to resolve issue №4760
>>> > > https://issues.apache.org/jira/browse/IGNITE-4760 <
>>> https://issues.apache.org/jira/browse/IGNITE-4760>
>>> > >
>>> > > To find solution I'm going to change method threadLocalForCache and
>>> to add
>>> > > Junit test.
>>> > >
>>> > > Why folder hibernate is not a module ? Can I added it ?
>>> > >
>>> > > Vadim Opolski
>>> > >
>>> >
>>>
>>>
>>
>>
>

IGNITE-1794 is ready for review

[Вадим Опольский]

Dear sirs!

Sorry for incorrect subject.

https://github.com/apache/ignite/pull/1643

-- Forwarded message --
From: Вадим Опольский <vaopols...@gmail.com>
Date: 2017-03-24 15:48 GMT+03:00
Subject: ready for review IGNITE-933
To: dev@ignite.apache.org, Denis Magda <dma...@apache.org>, Valentin
Kulichenko <valentin.kuliche...@gmail.com>


Hello everyone!

Denis, Valentin, what should I do to close issue
https://issues.apache.org/jira/browse/IGNITE-1794 ?

The tests in Team City executed successfully.

Valentin, I renamed IgniteHibernateTestSuite -> IgniteHibernate5TestSuite.
Can you create TeamCity Configuration ?



Vadim Opolski

2017-03-21 11:30 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:

> Hello everybody.
>
> The issue  https://issues.apache.org/jira/browse/IGNITE-1794 fixed
> originally by Mykola Pereyma.
> I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794 on
> myself, because we haven’t got a note from him for a while.
>
> Denis, I merged pull request https://github.com/apache/ignite/pull/1146 with
> my fork.
> Then I changed hibernate version to 5.2.7 and deleted ByteArrayType.java
> as per CI comments.
> The tests from list below executed succesfully.
>
> Prepared new pull request - https://github.com/apache/ignite/pull/1643
>
> What's the next step ?
>
> Tests:
> HibernateL2CacheConfigurationSelfTest.java
> HibernateL2CacheSelfTest.java
> HibernateL2CacheTransactionalSelfTest.java
> HibernateL2CacheTransactionalUseSyncSelfTest.java
> CacheHibernateBlobStoreNodeRestartTest.java
> CacheHibernateBlobStoreSelfTest.java
> CacheHibernateStoreFactorySelfTest.java
> CacheHibernateStoreSessionListenerSelfTest.java
>
>
> Vadim Opolski
>
>
> 2017-02-25 2:38 GMT+03:00 Denis Magda <dma...@apache.org>:
>
>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
>> interesting for me. How I can assignee it to me? It is assigning with
>> Mykola Pereyma now.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>
>>
>> Just re-assign it on yourself ;) Hope that Mykola is fine with this
>> because we haven’t got a note from him for a while.
>>
>> —
>> Denis
>>
>> > On Feb 24, 2017, at 12:24 PM, Вадим Опольский <vaopols...@gmail.com>
>> wrote:
>> >
>> > Hi Denis,
>> >
>> > OK, I spotted the problem in the code and I will be try to resolve it.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-933 <
>> https://issues.apache.org/jira/browse/IGNITE-933>
>> >
>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
>> interesting for me. How I can assignee it to me? It is assigning with
>> Mykola Pereyma now.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>
>> >
>> > Vadim Opolski
>> >
>> > 2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org > dma...@apache.org>>:
>> > Hi Vadim,
>> >
>> > Yes, this issue might be still relevant. I can’t guide you through but,
>> basically, you need to reproduce the issue, spot it in the code and propose
>> a fix.
>> >
>> > BTW, do you have any experience with Hibernate? If so, I would be
>> amazing if you pick up this ticket reassigning on yourself:
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794> <
>> https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>>
>> >
>> > —
>> > Denis
>> >
>> > > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopols...@gmail.com
>> <mailto:vaopols...@gmail.com>> wrote:
>> > >
>> > > Dear sirs !
>> > >
>> > > I want to resolve issue IGNITE-933
>> > >
>> > > https://issues.apache.org/jira/browse/IGNITE-933 <
>> https://issues.apache.org/jira/browse/IGNITE-933>
>> > >
>> > > Is it actual ?
>> > >
>> > > In which class and method you want me to make changes ?
>> > >
>> > > Vadim Opolski
>> >
>> >
>>
>>
>

Re: Apache Ignite 2.0 Release

[Вадим Опольский]

Hello community!

Denis,  issue IGNITE-1794
 - Hibernate 5 Support
has been ready for review from 24 March.

The tests in Team City executed successfully.

Vadim Opolski

2017-04-06 5:04 GMT+03:00 Denis Magda :

> *Denis Magda:*
> IGNITE-1192  - Provide
> integration with Spring Data
>
>
> Will be finished and merged by the code freeze date. I’m on a business
> trip now and don’t have extra time to complete the feature.
>
> Plus, following your template these are additional tickets:
>
> *Alexey Kuznetsov*
> IGNITE-4349  - Discontinue
> the schema-import utility
>
> *Sergey Chugunov*
> IGNITE-4536  - Update
> metrics for new offheap storage
>
> *Nikita Ivanov*
> IGNITE-4572  - Machine
> Learning: Develop distributed algebra support for dense and sparse data
> sets.
>
> *Roman Shtykh*
> IGNITE-4539  -
> RocketMQ Data Streamer
>
> *Vadim Opolski*
> IGNITE-1794  -
> Hibernate 5 Support
>
> —
> Denis
>
> On Apr 5, 2017, at 9:39 PM, Dmitriy Setrakyan 
> wrote:
>
> Guys,
>
> Please provide a status underneath every ticket listed below, so we can get
> a full picture in one email thread:
>
> *Alexey Goncharuk:*
> IGNITE-3477  - Rework
> offheap storage
> IGNITE-4337  -
> Introduce
> persistence interface to allow build reliable persistence plugins
>
> *Alexander Menshikov:*
> IGNITE-4699  -
> Introduce
> custom configurable executors.
>
> *Denis Magda:*
> IGNITE-1192  - Provide
> integration with Spring Data
>
> *Dmitriy Karachentsev:*
> IGNITE-4477  - Fix
> IgniteFuture.listen() and IgniteFuture.chain() semantics
>
> *Ilya Lantukh:*
> IGNITE-4535 
> - Add option to store
> deserialized values on-heap
>
> *Ivan Rakov:*
> IGNITE-4534  -
> Implement
> offheap eviction policies based on page memory
>
> *Sergey Kalashnikov:*
> IGNITE-3595  - Improve
> Enum fields handling in SQL.
>
> *Sergi Vladykin:*
> IGNITE-3869  - Reduce
> number of temporary objects produced by H2
>
> *Taras Ledkov:*
> IGNITE-3469  - Get rid
> of deprecated APIs and entities
>
> *Vladimir Ozerov:*
> IGNITE-4565  - Support
> CREATE INDEX DDL statements
>
> *Yakov Zdanov:*
> IGNITE-4799  - Remove
> TcpDiscoverySpi.heartbeatsFrequency parameter
>
>
> *Denis*, we still have 5 issues that are *unassigned*. Are they supposed to
> be getting into release?
>
> IGNITE-3488  - Prohibit
> null as name in all the components (cache name first of all).
> IGNITE-3596  - Hadoop
> edition can't be compiled against spark 2.0.0
> IGNITE-4794  -
> Reconsider
> CachePeekMode.ONHEAP
> IGNITE-2202  - Local
> server query result doesn't include versions in entries
> IGNITE-2398  - .NET:
> Change default mapper behavior
>
>
> D.
>
> On Wed, Apr 5, 2017 at 6:07 PM, Denis Magda  wrote:
>
> Dmitriy,
>
> You can find all the required tickets with contributors assigned here:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0#
> ApacheIgnite2.0-Requiredtickets  confluence/display/IGNITE/Apache+Ignite+2.0#ApacheIgnite2.0-
> Requiredtickets>
>
> In short, Alex G., Sergi, Vovan, Taras, Yakov, Sam, etc. (almost all the
> community) please share your readiness with the rest of the community.
>
> —
> Denis
>
> On Apr 5, 2017, at 9:03 PM, Dmitriy Setrakyan 
>
> wrote:
>
>
> Denis,
>
> I think it will be worth while to list all the tickets by status together
> with a name of the engineer assigned to it. This way most folks involved
> would provide a response sooner.
>
> What do you think?
>
> D.
>
> On Wed, Apr 5, 2017 at 1:27 PM, Denis Magda  wrote:
>
> Igniters,
>
> What’s the overall status of 2.0 release? I see that many tickets
>
> related
>
> to the page memory [1] are still in 

Re: IGNITE - 4760 : working in hibernate module

[Вадим Опольский]

Denis, review please this test. The problem was recreated in the
updating part ( //updating ).

https://github.com/vadopolski/ignite/pull/1/files
<https://github.com/vadopolski/ignite/pull/1/files>

Changes supposed by Cameron Braid in threadLocalForCache method doesn't
make the test successfully executed. Perhaps, the issue is necessary to
resolve by another way.
Do you have any idea how to fix it?

Vadim



2017-04-05 21:58 GMT+03:00 Denis Magda <dma...@apache.org>:

> > How to reproduce situation when updates can be recorded to another
> region?
>
> Don’t you just need to define multiple caches that will be mapped to
> Hibernate regions and initiate a transaction that updates several regions
> (caches) at once?
>
> —
> Denis
>
> > On Apr 3, 2017, at 10:39 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
> >
> > Hello everyone!
> >
> > I added some change to method threadLocalForCache  and added test
> > testEntityCacheNonStrictFails.
> >
> > How to reproduce situation when updates can be recorded to another
> region?
> >
> > https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac507ed73872d62
> b2969a7411/modules/hibernate/src/main/java/org/apache/
> ignite/cache/hibernate/HibernateRegionFactory.java
> >
> > https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac507ed73872d62
> b2969a7411/modules/hibernate/src/test/java/org/apache/
> ignite/cache/hibernate/HibernateL2CacheConfigurationSelfTest.java
> >
> > PullRequest
> > https://github.com/vadopolski/ignite/pull/4/files
> >
> > Vadim
> >
> >
> >
> > 2017-03-27 18:20 GMT+03:00 Denis Magda <dma...@apache.org>:
> >
> >> Vadim,
> >>
> >> What IDE do you use? My recommendation would be to set up everything
> let’s
> >> say under IntellijIDEA or Eclipse and after that trying to compile from
> a
> >> terminal.
> >>
> >> This is how you can easily prepare the dev env in IntellijIDEA:
> >> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup <
> >> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup>
> >>
> >> —
> >> Denis
> >>
> >>> On Mar 27, 2017, at 7:14 AM, Вадим Опольский <vaopols...@gmail.com>
> >> wrote:
> >>>
> >>> Valentin, OK.
> >>>
> >>> To enabled it in my environment I done next:
> >>> - built project with command - mvn clean package -DskipTests
> >> -Prelease,lgpl
> >>> - added folder hibernate to modules in project structure
> >>> - added library to dependencies (without it import doesn't working)
> >>>
> >>> After that I have a lot of error, for instance:
> >>> - Class 'AccessStrategy' must either be declared abstract or implement
> >> abstract method 'remove(SharedSessionContractImplementor, Object) in
> >> 'RegionAccessStrategy'
> >>>
> >>> generateCacheKey
> >>> getCacheKeyId
> >>> getRegion
> >>> insert
> >>> afterInsert
> >>> update
> >>> afterUpdate
> >>> insert
> >>> afterInsert
> >>> update
> >>> get
> >>> putFromLoad
> >>> lockItem
> >>> unlockItem
> >>> remove
> >>>
> >>> Do anybody know the easier way to resolve this issue?
> >>>
> >>> Also tried to reimport all maven projects and cleansed repository in
> .m2.
> >>> Vadim Opolski
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> 2017-03-25 2:42 GMT+03:00 Valentin Kulichenko <
> >> valentin.kuliche...@gmail.com <mailto:valentin.kuliche...@gmail.com>>:
> >>> Vadim,
> >>>
> >>> ignite-hibernate module is a part of 'lgpl' profile. Apparently it's
> not
> >>> enabled in your environment.
> >>>
> >>> -Val
> >>>
> >>> On Fri, Mar 24, 2017 at 4:38 PM, Вадим Опольский <vaopols...@gmail.com
> >> <mailto:vaopols...@gmail.com>>
> >>> wrote:
> >>>
> >>>> Hello everybody,
> >>>>
> >>>> I want to resolve issue №4760
> >>>> https://issues.apache.org/jira/browse/IGNITE-4760 <
> >> https://issues.apache.org/jira/browse/IGNITE-4760>
> >>>>
> >>>> To find solution I'm going to change method threadLocalForCache and to
> >> add
> >>>> Junit test.
> >>>>
> >>>> Why folder hibernate is not a module ? Can I added it ?
> >>>>
> >>>> Vadim Opolski
> >>>>
> >>>
> >>
> >>
>
>

Re: IGNITE - 4760 : working in hibernate module

[Вадим Опольский]

Hello everyone!

I added some change to method threadLocalForCache  and added test
testEntityCacheNonStrictFails.

How to reproduce situation when updates can be recorded to another region?

https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac507ed73872d62b2969a7411/modules/hibernate/src/main/java/org/apache/ignite/cache/hibernate/HibernateRegionFactory.java

https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac507ed73872d62b2969a7411/modules/hibernate/src/test/java/org/apache/ignite/cache/hibernate/HibernateL2CacheConfigurationSelfTest.java

PullRequest
https://github.com/vadopolski/ignite/pull/4/files

Vadim



2017-03-27 18:20 GMT+03:00 Denis Magda <dma...@apache.org>:

> Vadim,
>
> What IDE do you use? My recommendation would be to set up everything let’s
> say under IntellijIDEA or Eclipse and after that trying to compile from a
> terminal.
>
> This is how you can easily prepare the dev env in IntellijIDEA:
> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup <
> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup>
>
> —
> Denis
>
> > On Mar 27, 2017, at 7:14 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
> >
> > Valentin, OK.
> >
> > To enabled it in my environment I done next:
> > - built project with command - mvn clean package -DskipTests
> -Prelease,lgpl
> > - added folder hibernate to modules in project structure
> > - added library to dependencies (without it import doesn't working)
> >
> > After that I have a lot of error, for instance:
> > - Class 'AccessStrategy' must either be declared abstract or implement
> abstract method 'remove(SharedSessionContractImplementor, Object) in
> 'RegionAccessStrategy'
> >
> > generateCacheKey
> > getCacheKeyId
> > getRegion
> > insert
> > afterInsert
> > update
> > afterUpdate
> > insert
> > afterInsert
> > update
> > get
> > putFromLoad
> > lockItem
> > unlockItem
> > remove
> >
> > Do anybody know the easier way to resolve this issue?
> >
> > Also tried to reimport all maven projects and cleansed repository in .m2.
> > Vadim Opolski
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > 2017-03-25 2:42 GMT+03:00 Valentin Kulichenko <
> valentin.kuliche...@gmail.com <mailto:valentin.kuliche...@gmail.com>>:
> > Vadim,
> >
> > ignite-hibernate module is a part of 'lgpl' profile. Apparently it's not
> > enabled in your environment.
> >
> > -Val
> >
> > On Fri, Mar 24, 2017 at 4:38 PM, Вадим Опольский <vaopols...@gmail.com
> <mailto:vaopols...@gmail.com>>
> > wrote:
> >
> > > Hello everybody,
> > >
> > > I want to resolve issue №4760
> > > https://issues.apache.org/jira/browse/IGNITE-4760 <
> https://issues.apache.org/jira/browse/IGNITE-4760>
> > >
> > > To find solution I'm going to change method threadLocalForCache and to
> add
> > > Junit test.
> > >
> > > Why folder hibernate is not a module ? Can I added it ?
> > >
> > > Vadim Opolski
> > >
> >
>
>

Re: [jira] [Comment Edited] (IGNITE-4052) Add ability to set up users for MESOS

[Вадим Опольский]

Hello everybody!

Nikolay, I didn't have experience with ignite-yarn integration and didn't
have idea how fix it, but its interesting for me. Can you write name of
another java application, in which I can see how they connect to mesos.

Also, can you write how correctly to test working of Builder#setRoleBytes
and Builder#setUserBytes without library org.junit.Rule and
org.junit.contrib.java.lang.system.EnvironmentVariables.

Vadim

2017-03-31 18:07 GMT+03:00 Nikolay Tikhonov (JIRA) :

>
> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=15951002#comment-15951002 ]
>
> Nikolay Tikhonov edited comment on IGNITE-4052 at 3/31/17 3:06 PM:
> ---
>
> [~javaller]
> I'm some bit confused. Builder#setRoleBytes and Builder#setUserBytes
> methods used only test and how user can provide this parameters in
> ignite-yarn integration? Also seems that the test does test nothing. I
> don't see any invocation "production code" from {{IgniteFrameworkInfoTest}}
> test. Do you have any idea how fix it?
> I think that need to investigate this deeper and look at another mesos
> application and see how they do it.
>
>
> was (Author: ntikhonov):
> [~javaller]
> I'm some bit confused. Builder#setRoleBytes and Builder#setUserBytes
> methods used only test and how user can provide this parameters in
> ignite-yarn integration? Also seems that test does test nothing. I don't
> see any invocation "production code" from {{IgniteFrameworkInfoTest}} test.
> Do you have any idea how fix it?
> I think that need to investigate this deeper and look at another mesos
> application and see how they do it.
>
> > Add ability to set up users for MESOS
> > -
> >
> > Key: IGNITE-4052
> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
> > Project: Ignite
> >  Issue Type: Improvement
> >  Components: general
> >Affects Versions: 1.7
> >Reporter: Nikolay Tikhonov
> >Assignee: Vadim Opolski
> >Priority: Trivial
> >
> > In current implementation Ignite Mesos Framework connects to MESOS
> cluster via current user. Need to add ability to configure this parameters
> via system env properties. Also need to add properties for mesos role.
> > See org/apache/ignite/mesos/IgniteFramework.java:537
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>

IGNITE-4052 ready for review - what can I improve

[Вадим Опольский]

Hello community!

I want to add ability to connect to MESOS cluster via user name and role
from system env properties and to add JUnit test.

Review please pull request, what can I improve ? How correctly to test
methods work?

https://github.com/apache/ignite/pull/1662

Vadim Opolski


2017-03-30 16:32 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:

> Hello everyone!
>
> Nikolay, method Protos.FrameworkInfo.Builder#setRoleBytes and
> Protos.FrameworkInfo.Builder#setUserBytes were added into
> IgniteFrameworkInfoTest.
>
> Details please what do you want to me do with the methods. How
> correctly to test methods work?
>
> The code was changed with official "Coding Guidelines" and the lib was
> deleted.
>
> I didn't try to use new properties on real mesos cluster.
>
> https://github.com/apache/ignite/pull/1662
>
> Vadim Opolski
>
> *You used only Protos.FrameworkInfo.Builder#setRole method, but also
> exists Protos.FrameworkInfo.Builder#setRoleBytes. Please, pay attention on
> it. You did some code styles changes which conflict with official "Coding
> Guidelines" (see *
> *https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute*
> <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute>*).
> Also you use lib for testing with licence different from Apache Licence
> 2.0. Are you sure that for this test you need additional libs? I think this
> can be implemented without them.*
>
> *Also did you try to use new properties on real mesos cluster? Did work
> properly?*
>
> 2017-03-24 15:54 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:
>
>> Nikolay, I will add properties for mesos role and unit test next week.
>>
>> -- Forwarded message --
>> From: Вадим Опольский <vaopols...@gmail.com>
>> Date: 2017-03-22 15:53 GMT+03:00
>> Subject: Re: IGNITE-4052 ready for review
>> To: dev@ignite.apache.org
>>
>>
>> Nikolay, just changed status to "path available".
>>
>> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov <ntikho...@apache.org>:
>>
>>> Hi Вадим!
>>>
>>> Thank you for your contribution!
>>> Please change status of the ticket to "path available". I'll review your
>>> changes.
>>>
>>> Thanks,
>>> Nikolay
>>>
>>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>> > Hello everybody!
>>> >
>>> > Nikolay,
>>> >  review please https://github.com/apache/ignite/pull/1662 .
>>> >
>>> > Added ability to configure current user parameters via system env
>>> > properties - "MESOS_USER".
>>> >
>>> > Vadim Opolski
>>> >
>>> >
>>> > -- Forwarded message --
>>> > From: Вадим Опольский <vaopols...@gmail.com>
>>> > Date: 2017-03-21 14:40 GMT+03:00
>>> > Subject: Assignee IGNITE-4052
>>> > To: dev@ignite.apache.org
>>> >
>>> >
>>> > Dear sirs !
>>> >
>>> > I want to resolve issue IGNITE-4052.
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-4052
>>> >
>>> > Is it actual ?
>>> >
>>> > Vadim Opolski
>>> >
>>> >
>>>
>>
>>
>>
>

Re: IGNITE-4052 ready for review

[Вадим Опольский]

Hello everyone!

Nikolay, method Protos.FrameworkInfo.Builder#setRoleBytes and
Protos.FrameworkInfo.Builder#setUserBytes were added into
IgniteFrameworkInfoTest.

Details please what do you want to me do with the methods. How correctly to
test methods work?

The code was changed with official "Coding Guidelines" and the lib was
deleted.

I didn't try to use new properties on real mesos cluster.

https://github.com/apache/ignite/pull/1662

Vadim Opolski

*You used only Protos.FrameworkInfo.Builder#setRole method, but also exists
Protos.FrameworkInfo.Builder#setRoleBytes. Please, pay attention on it. You
did some code styles changes which conflict with official "Coding
Guidelines" (see *
*https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute*
<https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute>*).
Also you use lib for testing with licence different from Apache Licence
2.0. Are you sure that for this test you need additional libs? I think this
can be implemented without them.*

*Also did you try to use new properties on real mesos cluster? Did work
properly?*

2017-03-24 15:54 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:

> Nikolay, I will add properties for mesos role and unit test next week.
>
> ------ Forwarded message --
> From: Вадим Опольский <vaopols...@gmail.com>
> Date: 2017-03-22 15:53 GMT+03:00
> Subject: Re: IGNITE-4052 ready for review
> To: dev@ignite.apache.org
>
>
> Nikolay, just changed status to "path available".
>
> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov <ntikho...@apache.org>:
>
>> Hi Вадим!
>>
>> Thank you for your contribution!
>> Please change status of the ticket to "path available". I'll review your
>> changes.
>>
>> Thanks,
>> Nikolay
>>
>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский <vaopols...@gmail.com>
>> wrote:
>>
>> > Hello everybody!
>> >
>> > Nikolay,
>> >  review please https://github.com/apache/ignite/pull/1662 .
>> >
>> > Added ability to configure current user parameters via system env
>> > properties - "MESOS_USER".
>> >
>> > Vadim Opolski
>> >
>> >
>> > -- Forwarded message --
>> > From: Вадим Опольский <vaopols...@gmail.com>
>> > Date: 2017-03-21 14:40 GMT+03:00
>> > Subject: Assignee IGNITE-4052
>> > To: dev@ignite.apache.org
>> >
>> >
>> > Dear sirs !
>> >
>> > I want to resolve issue IGNITE-4052.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-4052
>> >
>> > Is it actual ?
>> >
>> > Vadim Opolski
>> >
>> >
>>
>
>
>

IGNITE-4052 ready for review

[Вадим Опольский]

Hello everybody!

Nikolay, the properties for mesos role and JUnit test were added.

Review please the pull request - https://github.com/apache/ignite/pull/1662

Vadim Opolski

2017-03-24 18:41 GMT+03:00 Nikolai Tikhonov <ntikho...@apache.org>:

> Great! Looking forward to the contribution.
>
> On Fri, Mar 24, 2017 at 3:54 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Nikolay, I will add properties for mesos role and unit test next week.
>>
>> -- Forwarded message --
>> From: Вадим Опольский <vaopols...@gmail.com>
>> Date: 2017-03-22 15:53 GMT+03:00
>> Subject: Re: IGNITE-4052 ready for review
>> To: dev@ignite.apache.org
>>
>>
>> Nikolay, just changed status to "path available".
>>
>> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov <ntikho...@apache.org>:
>>
>>> Hi Вадим!
>>>
>>> Thank you for your contribution!
>>> Please change status of the ticket to "path available". I'll review your
>>> changes.
>>>
>>> Thanks,
>>> Nikolay
>>>
>>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>> > Hello everybody!
>>> >
>>> > Nikolay,
>>> >  review please https://github.com/apache/ignite/pull/1662 .
>>> >
>>> > Added ability to configure current user parameters via system env
>>> > properties - "MESOS_USER".
>>> >
>>> > Vadim Opolski
>>> >
>>> >
>>> > -- Forwarded message --
>>> > From: Вадим Опольский <vaopols...@gmail.com>
>>> > Date: 2017-03-21 14:40 GMT+03:00
>>> > Subject: Assignee IGNITE-4052
>>> > To: dev@ignite.apache.org
>>> >
>>> >
>>> > Dear sirs !
>>> >
>>> > I want to resolve issue IGNITE-4052.
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-4052
>>> >
>>> > Is it actual ?
>>> >
>>> > Vadim Opolski
>>> >
>>> >
>>>
>>
>>
>>
>

Re: IGNITE - 4760 : working in hibernate module

[Вадим Опольский]

Denis, thank you for instruction.

I've successfully applied it:

1) cloned project by my fork - https://github.com/vadopolski/ignite
2) created project from existing sources
3) built it - mvn clean package -DskipTests -Prelease,lgpl
4) created module from existing sources (import module from external model)

Vadim Opolski

2017-03-27 18:20 GMT+03:00 Denis Magda <dma...@apache.org>:

> Vadim,
>
> What IDE do you use? My recommendation would be to set up everything let’s
> say under IntellijIDEA or Eclipse and after that trying to compile from a
> terminal.
>
> This is how you can easily prepare the dev env in IntellijIDEA:
> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup <
> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup>
>
> —
> Denis
>
> > On Mar 27, 2017, at 7:14 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
> >
> > Valentin, OK.
> >
> > To enabled it in my environment I done next:
> > - built project with command - mvn clean package -DskipTests
> -Prelease,lgpl
> > - added folder hibernate to modules in project structure
> > - added library to dependencies (without it import doesn't working)
> >
> > After that I have a lot of error, for instance:
> > - Class 'AccessStrategy' must either be declared abstract or implement
> abstract method 'remove(SharedSessionContractImplementor, Object) in
> 'RegionAccessStrategy'
> >
> > generateCacheKey
> > getCacheKeyId
> > getRegion
> > insert
> > afterInsert
> > update
> > afterUpdate
> > insert
> > afterInsert
> > update
> > get
> > putFromLoad
> > lockItem
> > unlockItem
> > remove
> >
> > Do anybody know the easier way to resolve this issue?
> >
> > Also tried to reimport all maven projects and cleansed repository in .m2.
> > Vadim Opolski
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > 2017-03-25 2:42 GMT+03:00 Valentin Kulichenko <
> valentin.kuliche...@gmail.com <mailto:valentin.kuliche...@gmail.com>>:
> > Vadim,
> >
> > ignite-hibernate module is a part of 'lgpl' profile. Apparently it's not
> > enabled in your environment.
> >
> > -Val
> >
> > On Fri, Mar 24, 2017 at 4:38 PM, Вадим Опольский <vaopols...@gmail.com
> <mailto:vaopols...@gmail.com>>
> > wrote:
> >
> > > Hello everybody,
> > >
> > > I want to resolve issue №4760
> > > https://issues.apache.org/jira/browse/IGNITE-4760 <
> https://issues.apache.org/jira/browse/IGNITE-4760>
> > >
> > > To find solution I'm going to change method threadLocalForCache and to
> add
> > > Junit test.
> > >
> > > Why folder hibernate is not a module ? Can I added it ?
> > >
> > > Vadim Opolski
> > >
> >
>
>

Re: IGNITE - 4760 : working in hibernate module

[Вадим Опольский]

Valentin, OK.

To enabled it in my environment I done next:
- built project with command - mvn clean package -DskipTests -Prelease,lgpl
- added folder hibernate to modules in project structure
- added library to dependencies (without it import doesn't working)

After that I have a lot of error, for instance:
- Class 'AccessStrategy' must either be declared abstract or implement
abstract method 'remove(SharedSessionContractImplementor, Object) in
'RegionAccessStrategy'

generateCacheKey
getCacheKeyId
getRegion
insert
afterInsert
update
afterUpdate
insert
afterInsert
update
get
putFromLoad
lockItem
unlockItem
remove

Do anybody know the easier way to resolve this issue?

Also tried to reimport all maven projects and cleansed repository in .m2.

Vadim Opolski

[image: Встроенное изображение 1]







2017-03-25 2:42 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Vadim,
>
> ignite-hibernate module is a part of 'lgpl' profile. Apparently it's not
> enabled in your environment.
>
> -Val
>
> On Fri, Mar 24, 2017 at 4:38 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
> > Hello everybody,
> >
> > I want to resolve issue №4760
> > https://issues.apache.org/jira/browse/IGNITE-4760
> >
> > To find solution I'm going to change method threadLocalForCache and to
> add
> > Junit test.
> >
> > Why folder hibernate is not a module ? Can I added it ?
> >
> > Vadim Opolski
> >
>

Fwd: IGNITE - 4760

[Вадим Опольский]

Hello everybody,

I want to resolve issue №4760
https://issues.apache.org/jira/browse/IGNITE-4760

To find solution I'm going to change method threadLocalForCache and to add
Junit test.

Why folder hibernate is not a module ? Can I added it ?

Vadim Opolski

Fwd: IGNITE-4052 ready for review

[Вадим Опольский]

Nikolay, I will add properties for mesos role and unit test next week.

-- Forwarded message --
From: Вадим Опольский <vaopols...@gmail.com>
Date: 2017-03-22 15:53 GMT+03:00
Subject: Re: IGNITE-4052 ready for review
To: dev@ignite.apache.org


Nikolay, just changed status to "path available".

2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov <ntikho...@apache.org>:

> Hi Вадим!
>
> Thank you for your contribution!
> Please change status of the ticket to "path available". I'll review your
> changes.
>
> Thanks,
> Nikolay
>
> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
> > Hello everybody!
> >
> > Nikolay,
> >  review please https://github.com/apache/ignite/pull/1662 .
> >
> > Added ability to configure current user parameters via system env
> > properties - "MESOS_USER".
> >
> > Vadim Opolski
> >
> >
> > -- Forwarded message --
> > From: Вадим Опольский <vaopols...@gmail.com>
> > Date: 2017-03-21 14:40 GMT+03:00
> > Subject: Assignee IGNITE-4052
> > To: dev@ignite.apache.org
> >
> >
> > Dear sirs !
> >
> > I want to resolve issue IGNITE-4052.
> >
> > https://issues.apache.org/jira/browse/IGNITE-4052
> >
> > Is it actual ?
> >
> > Vadim Opolski
> >
> >
>

ready for review IGNITE-933

[Вадим Опольский]

Hello everyone!

Denis, Valentin, what should I do to close issue
https://issues.apache.org/jira/browse/IGNITE-1794 ?

The tests in Team City executed successfully.

Valentin, I renamed IgniteHibernateTestSuite -> IgniteHibernate5TestSuite.
Can you create TeamCity Configuration ?

Vadim Opolski

2017-03-21 11:30 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:

> Hello everybody.
>
> The issue  https://issues.apache.org/jira/browse/IGNITE-1794 fixed
> originally by Mykola Pereyma.
> I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794 on
> myself, because we haven’t got a note from him for a while.
>
> Denis, I merged pull request https://github.com/apache/ignite/pull/1146 with
> my fork.
> Then I changed hibernate version to 5.2.7 and deleted ByteArrayType.java
> as per CI comments.
> The tests from list below executed succesfully.
>
> Prepared new pull request - https://github.com/apache/ignite/pull/1643
>
> What's the next step ?
>
> Tests:
> HibernateL2CacheConfigurationSelfTest.java
> HibernateL2CacheSelfTest.java
> HibernateL2CacheTransactionalSelfTest.java
> HibernateL2CacheTransactionalUseSyncSelfTest.java
> CacheHibernateBlobStoreNodeRestartTest.java
> CacheHibernateBlobStoreSelfTest.java
> CacheHibernateStoreFactorySelfTest.java
> CacheHibernateStoreSessionListenerSelfTest.java
>
>
> Vadim Opolski
>
>
> 2017-02-25 2:38 GMT+03:00 Denis Magda <dma...@apache.org>:
>
>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
>> interesting for me. How I can assignee it to me? It is assigning with
>> Mykola Pereyma now.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>
>>
>> Just re-assign it on yourself ;) Hope that Mykola is fine with this
>> because we haven’t got a note from him for a while.
>>
>> —
>> Denis
>>
>> > On Feb 24, 2017, at 12:24 PM, Вадим Опольский <vaopols...@gmail.com>
>> wrote:
>> >
>> > Hi Denis,
>> >
>> > OK, I spotted the problem in the code and I will be try to resolve it.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-933 <
>> https://issues.apache.org/jira/browse/IGNITE-933>
>> >
>> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
>> interesting for me. How I can assignee it to me? It is assigning with
>> Mykola Pereyma now.
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>
>> >
>> > Vadim Opolski
>> >
>> > 2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org > dma...@apache.org>>:
>> > Hi Vadim,
>> >
>> > Yes, this issue might be still relevant. I can’t guide you through but,
>> basically, you need to reproduce the issue, spot it in the code and propose
>> a fix.
>> >
>> > BTW, do you have any experience with Hibernate? If so, I would be
>> amazing if you pick up this ticket reassigning on yourself:
>> > https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794> <
>> https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>>
>> >
>> > —
>> > Denis
>> >
>> > > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopols...@gmail.com
>> <mailto:vaopols...@gmail.com>> wrote:
>> > >
>> > > Dear sirs !
>> > >
>> > > I want to resolve issue IGNITE-933
>> > >
>> > > https://issues.apache.org/jira/browse/IGNITE-933 <
>> https://issues.apache.org/jira/browse/IGNITE-933>
>> > >
>> > > Is it actual ?
>> > >
>> > > In which class and method you want me to make changes ?
>> > >
>> > > Vadim Opolski
>> >
>> >
>>
>>
>

Re: IGNITE-4052 ready for review

[Вадим Опольский]

Nikolay, just changed status to "path available".

2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov <ntikho...@apache.org>:

> Hi Вадим!
>
> Thank you for your contribution!
> Please change status of the ticket to "path available". I'll review your
> changes.
>
> Thanks,
> Nikolay
>
> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
> > Hello everybody!
> >
> > Nikolay,
> >  review please https://github.com/apache/ignite/pull/1662 .
> >
> > Added ability to configure current user parameters via system env
> > properties - "MESOS_USER".
> >
> > Vadim Opolski
> >
> >
> > -- Forwarded message --
> > From: Вадим Опольский <vaopols...@gmail.com>
> > Date: 2017-03-21 14:40 GMT+03:00
> > Subject: Assignee IGNITE-4052
> > To: dev@ignite.apache.org
> >
> >
> > Dear sirs !
> >
> > I want to resolve issue IGNITE-4052.
> >
> > https://issues.apache.org/jira/browse/IGNITE-4052
> >
> > Is it actual ?
> >
> > Vadim Opolski
> >
> >
>

IGNITE-4052 ready for review

[Вадим Опольский]

Hello everybody!

Nikolay,
 review please https://github.com/apache/ignite/pull/1662 .

Added ability to configure current user parameters via system env
properties - "MESOS_USER".

Vadim Opolski


-- Forwarded message ------
From: Вадим Опольский <vaopols...@gmail.com>
Date: 2017-03-21 14:40 GMT+03:00
Subject: Assignee IGNITE-4052
To: dev@ignite.apache.org


Dear sirs !

I want to resolve issue IGNITE-4052.

https://issues.apache.org/jira/browse/IGNITE-4052

Is it actual ?

Vadim Opolski

IGNITE-933 ready for review

[Вадим Опольский]

Hello everybody!

Denis, I prepared a pull-request and test executed successfully on TeamCity
with awaiting time 500 milliseconds.

Review it please - https://github.com/apache/ignite/pull/1615

Vadim Opolski

2017-03-10 23:04 GMT+03:00 Denis Magda <dma...@apache.org>:

> Vadim,
>
> Please prepare a pull-request and make sure that the test passes on
> TeamCity.
>
> —
> Denis
>
> > On Mar 10, 2017, at 9:25 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
> >
> > Hello everyone!
> >
> > Denis, I've successfully executed GridFailFastNodeFailureDetectionSelfTest
> in IDE 10 times on VMware Workstation (3 GB RAM,  Intel Core i5-2520M) in
> single core mode with 300 MILLISECONDS timeout.
> >
> > What's the next step ?
> >
> > Vadim
> >
> >
> > 2017-03-07 22:25 GMT+03:00 Denis Magda <dma...@apache.org  dma...@apache.org>>:
> > Vadim,
> >
> > The timeout should be such that the test completes successfully on
> single core machine as well as on multi-core servers. Setting timeout to 3
> - 5 seconds should work.
> >
> > —
> > Denis
> >
> >> On Mar 7, 2017, at 1:55 AM, Вадим Опольский <vaopols...@gmail.com
> <mailto:vaopols...@gmail.com>> wrote:
> >>
> >> Denis,
> >>
> >> I'm planning to adjust processing time of incoming and outgoing
> messages by JMH benchmarks.
> >>
> >> What do you think are the parameters of commodity hardware/? RAM size?
> CPU speed ? or others ?
> >>
> >> Vadim
> >>
> >> 2017-03-06 22:36 GMT+03:00 Denis Magda <dma...@apache.org  dma...@apache.org>>:
> >> Vadim,
> >>
> >> How do you plan to adjust processing time of incoming and outgoing
> messages? In general, I don’t think that you need to move the direction of
> the communication layer.
> >>
> >> I’m thinking that you just need to set some reasonable awaiting time so
> that the test passes on a commodity hardware.
> >>
> >> —
> >> Denis
> >>
> >>> On Mar 6, 2017, at 2:31 AM, Вадим Опольский <vaopols...@gmail.com
> <mailto:vaopols...@gmail.com>> wrote:
> >>>
> >>> Hi everyone!
> >>>
> >>> I executed test GridFailFastNodeFailureDetectionSelfTest.testFailFast
> fails periodically with different values of node quantity and awaiting
> time. Test fails if the awaiting time is less than 600 miliseconds.
> >>> I debugged test and understood that messaging took a lot of time in
> this case.
> >>> I want to measure (with 
> >>> GridFailFastNodeFailureDetectionSelfTest.testFailFast)
> and increase speed of receiving and sending message.
> >>>
> >>> Denis, what do you think about it ?
> >>>
> >>> Vadim Opolski
> >>>
> >>>
> >>> 2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org  dma...@apache.org>>:
> >>> Hi Vadim,
> >>>
> >>> Yes, this issue might be still relevant. I can’t guide you through
> but, basically, you need to reproduce the issue, spot it in the code and
> propose a fix.
> >>>
> >>> BTW, do you have any experience with Hibernate? If so, I would be
> amazing if you pick up this ticket reassigning on yourself:
> >>> https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794> <
> https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794>>
> >>>
> >>> —
> >>> Denis
> >>>
> >>> > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopols...@gmail.com
> <mailto:vaopols...@gmail.com>> wrote:
> >>> >
> >>> > Dear sirs !
> >>> >
> >>> > I want to resolve issue IGNITE-933
> >>> >
> >>> > https://issues.apache.org/jira/browse/IGNITE-933 <
> https://issues.apache.org/jira/browse/IGNITE-933>
> >>> >
> >>> > Is it actual ?
> >>> >
> >>> > In which class and method you want me to make changes ?
> >>> >
> >>> > Vadim Opolski
> >
> >
>
>

Re: IGNITE-13 (ready for review)

[Вадим Опольский]

Hi Valentin,

OK, thank you.

2017-03-11 20:33 GMT+03:00 Valentin Kulichenko <
valentin.kuliche...@gmail.com>:

> Hi Vadim,
>
> According to these results, I don't think it makes sense to make this
> change in the product. I closed the ticket.
>
> -Val
>
> On Fri, Mar 10, 2017 at 12:28 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi Valentin,
>>
>> I cant find out why it's better on long string, but worse on a short
>> string. May be it needs to use special tools like such as oracle solaris
>> studio performance analyzer or other.
>>
>> I've added links to the benchmark, unit test and results to the ticket
>> and switched status to patch available.
>>
>> Vadim Opolski
>>
>>
>>
>> 2017-03-09 13:57 GMT+03:00 Valentin Kulichenko <
>> valentin.kuliche...@gmail.com>:
>>
>>> Hi Vadim,
>>>
>>> Results are a bit confusing. Any idea why it's better on long string,
>>> but worse on a short string? If that's actually the case, there is no any
>>> reason to make the change and I would just close the ticket.
>>>
>>> -Val
>>>
>>> On Thu, Mar 9, 2017 at 9:20 AM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>>> Hello everyone!
>>>>
>>>> Colleagues, take a look please at the results of measuring.
>>>>
>>>> Can I close this ticket ?
>>>>
>>>> Should I add JMH benchmark and unit test to Ignite project ?
>>>>
>>>> Results of measuring
>>>> https://github.com/javaller/mybenchmark/blob/master/out.txt
>>>>
>>>> Benchmark
>>>> https://github.com/javaller/mybenchmark/blob/master/src/main
>>>> /java/org/sample/ExampleTest.java
>>>>
>>>> UTest
>>>> https://github.com/javaller/mybenchmark/blob/master/src/main
>>>> /java/org/sample/BinaryMarshallerSelfTest.java
>>>>
>>>> *results of measuring*
>>>> Benchmark
>>>> (message)  Mode  Cnt
>>>> Score   Error  Units
>>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>>> TestTestTestTestTestTestTestTestTest  avgt   50  128,036 ± 4,360  ns/op
>>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>>> TestTestTestavgt   5044,934 ± 1,463  ns/op
>>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>>> Test  avgt   5021,254 ± 0,776  ns/op
>>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>>> TestTestTestTestTestTestTestTestTest avgt   5083,262 ± 2,264  ns/op
>>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>>> TestTestTest   avgt   5058,975 ± 1,559  ns/op
>>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>>> Test avgt   5048,506 ± 1,116  ns/op
>>>>
>>>>
>>>> Vadim
>>>>
>>>> 2017-03-06 19:42 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:
>>>>
>>>>> Hello, everybody!
>>>>>
>>>>> Valentin, I've corrected benchmark and received the results:
>>>>>
>>>>> Benchmark
>>>>> (message)  Mode  Cnt
>>>>> Score   Error  Units
>>>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>>>> TestTestTestTestTestTestTestTestTest  avgt   50  128,036 ± 4,360
>>>>> ns/op
>>>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>>>> TestTestTestavgt   5044,934 ± 1,463  ns/op
>>>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>>>> Test  avgt   5021,254 ± 0,776  ns/op
>>>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>>>> TestTestTestTestTestTestTestTestTest avgt   5083,262 ± 2,264
>>>>> ns/op
>>>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>>>> TestTestTest   avgt   5058,975 ± 1,559  ns/op
>>>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>>>> Test avgt   5048,506 ± 1,116  ns/op
>>>>>
>>>>> https://github.com/javaller/MyBenchmark/blob/master/out_06_03_17_2.txt
>>>>>
>>>>> Whats the next step ?
>>>>>
>>>>>  Do I have to add benchmark to Ignite proje

Re: assigning IGNITE-933

[Вадим Опольский]

Hello everyone!

Denis, I've successfully executed GridFailFastNodeFailureDetectionSelfTest
in IDE 10 times on VMware Workstation (3 GB RAM,  Intel Core i5-2520M) in
single core mode with 300 MILLISECONDS timeout.

What's the next step ?

Vadim


2017-03-07 22:25 GMT+03:00 Denis Magda <dma...@apache.org>:

> Vadim,
>
> The timeout should be such that the test completes successfully on single
> core machine as well as on multi-core servers. Setting timeout to 3 - 5
> seconds should work.
>
> —
> Denis
>
> On Mar 7, 2017, at 1:55 AM, Вадим Опольский <vaopols...@gmail.com> wrote:
>
> Denis,
>
> I'm planning to adjust processing time of incoming and outgoing messages
> by JMH benchmarks.
>
> What do you think are the parameters of commodity hardware/? RAM size? CPU
> speed ? or others ?
>
> Vadim
>
> 2017-03-06 22:36 GMT+03:00 Denis Magda <dma...@apache.org>:
>
>> Vadim,
>>
>> How do you plan to adjust processing time of incoming and outgoing
>> messages? In general, I don’t think that you need to move the direction of
>> the communication layer.
>>
>> I’m thinking that you just need to set some reasonable awaiting time so
>> that the test passes on a commodity hardware.
>>
>> —
>> Denis
>>
>> On Mar 6, 2017, at 2:31 AM, Вадим Опольский <vaopols...@gmail.com> wrote:
>>
>> Hi everyone!
>>
>> I executed test GridFailFastNodeFailureDetectionSelfTest.testFailFast
>> fails periodically with different values of node quantity and awaiting
>> time. Test fails if the awaiting time is less than 600 miliseconds.
>> I debugged test and understood that messaging took a lot of time in this
>> case.
>> I want to measure (with GridFailFastNodeFailureDetecti
>> onSelfTest.testFailFast) and increase speed of receiving and sending
>> message.
>>
>> Denis, what do you think about it ?
>>
>> Vadim Opolski
>>
>>
>> 2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org>:
>>
>>> Hi Vadim,
>>>
>>> Yes, this issue might be still relevant. I can’t guide you through but,
>>> basically, you need to reproduce the issue, spot it in the code and propose
>>> a fix.
>>>
>>> BTW, do you have any experience with Hibernate? If so, I would be
>>> amazing if you pick up this ticket reassigning on yourself:
>>> https://issues.apache.org/jira/browse/IGNITE-1794 <https://
>>> issues.apache.org/jira/browse/IGNITE-1794>
>>>
>>> —
>>> Denis
>>>
>>> > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>> >
>>> > Dear sirs !
>>> >
>>> > I want to resolve issue IGNITE-933
>>> >
>>> > https://issues.apache.org/jira/browse/IGNITE-933
>>> >
>>> > Is it actual ?
>>> >
>>> > In which class and method you want me to make changes ?
>>> >
>>> > Vadim Opolski
>>
>>
>

Re: IGNITE-13 (ready for review)

[Вадим Опольский]

Hi Valentin,

I cant find out why it's better on long string, but worse on a short
string. May be it needs to use special tools like such as oracle solaris
studio performance analyzer or other.

I've added links to the benchmark, unit test and results to the ticket and
switched status to patch available.

Vadim Opolski



2017-03-09 13:57 GMT+03:00 Valentin Kulichenko <
valentin.kuliche...@gmail.com>:

> Hi Vadim,
>
> Results are a bit confusing. Any idea why it's better on long string, but
> worse on a short string? If that's actually the case, there is no any
> reason to make the change and I would just close the ticket.
>
> -Val
>
> On Thu, Mar 9, 2017 at 9:20 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hello everyone!
>>
>> Colleagues, take a look please at the results of measuring.
>>
>> Can I close this ticket ?
>>
>> Should I add JMH benchmark and unit test to Ignite project ?
>>
>> Results of measuring
>> https://github.com/javaller/mybenchmark/blob/master/out.txt
>>
>> Benchmark
>> https://github.com/javaller/mybenchmark/blob/master/src/main
>> /java/org/sample/ExampleTest.java
>>
>> UTest
>> https://github.com/javaller/mybenchmark/blob/master/src/main
>> /java/org/sample/BinaryMarshallerSelfTest.java
>>
>> *results of measuring*
>> Benchmark
>> (message)  Mode  Cnt
>> Score   Error  Units
>> LatchBenchmark.binaryHeapOutputStreamDirect
>> TestTestTestTestTestTestTestTestTest  avgt   50  128,036 ± 4,360  ns/op
>> LatchBenchmark.binaryHeapOutputStreamDirect
>> TestTestTestavgt   5044,934 ± 1,463  ns/op
>> LatchBenchmark.binaryHeapOutputStreamDirect
>> Test  avgt   5021,254 ± 0,776  ns/op
>> LatchBenchmark.binaryHeapOutputStreamInDirect
>> TestTestTestTestTestTestTestTestTest avgt   5083,262 ± 2,264  ns/op
>> LatchBenchmark.binaryHeapOutputStreamInDirect
>> TestTestTest   avgt   5058,975 ± 1,559  ns/op
>> LatchBenchmark.binaryHeapOutputStreamInDirect
>> Test avgt   5048,506 ± 1,116  ns/op
>>
>>
>> Vadim
>>
>> 2017-03-06 19:42 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:
>>
>>> Hello, everybody!
>>>
>>> Valentin, I've corrected benchmark and received the results:
>>>
>>> Benchmark
>>> (message)  Mode  Cnt
>>> Score   Error  Units
>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>> TestTestTestTestTestTestTestTestTest  avgt   50  128,036 ± 4,360  ns/op
>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>> TestTestTestavgt   5044,934 ± 1,463  ns/op
>>> LatchBenchmark.binaryHeapOutputStreamDirect
>>> Test  avgt   5021,254 ± 0,776  ns/op
>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>> TestTestTestTestTestTestTestTestTest avgt   5083,262 ± 2,264  ns/op
>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>> TestTestTest   avgt   5058,975 ± 1,559  ns/op
>>> LatchBenchmark.binaryHeapOutputStreamInDirect
>>> Test avgt   5048,506 ± 1,116  ns/op
>>>
>>> https://github.com/javaller/MyBenchmark/blob/master/out_06_03_17_2.txt
>>>
>>> Whats the next step ?
>>>
>>>  Do I have to add benchmark to Ignite project ?
>>>
>>> Vadim Opolskiy
>>>
>>> 2017-03-03 21:11 GMT+03:00 Valentin Kulichenko <
>>> valentin.kuliche...@gmail.com>:
>>>
>>>> Hi Vadim,
>>>>
>>>> What do you mean by "copied benchmarks"? What changed singe previous
>>>> iteration and why results are so different?
>>>>
>>>> As for duplicated loop, you don't need it. BinaryOutputStream allows to
>>>> write a value to a particular position (even before already written data).
>>>> So you can reserve 4 bytes for length, remember position, calculate length
>>>> while encoding and writing bytes, and then write length.
>>>>
>>>> -Val
>>>>
>>>> On Fri, Mar 3, 2017 at 12:45 AM, Вадим Опольский <vaopols...@gmail.com>
>>>> wrote:
>>>>
>>>>> Valentin,
>>>>>
>>>>> What do you think about duplicated cycle in strToBinaryOutputStream ?
>>>>>
>>>>> How to calculate StrLen для outBinaryHeap without this cycle ?
>>>>&

Re: IGNITE-13 (ready for review)

[Вадим Опольский]

Hello everyone!

Colleagues, take a look please at the results of measuring.

Can I close this ticket ?

Should I add JMH benchmark and unit test to Ignite project ?

Results of measuring
https://github.com/javaller/mybenchmark/blob/master/out.txt

Benchmark
https://github.com/javaller/mybenchmark/blob/master/src/main/java/org/sample/ExampleTest.java

UTest
https://github.com/javaller/mybenchmark/blob/master/src/main/java/org/sample/BinaryMarshallerSelfTest.java

*results of measuring*
Benchmark
(message)  Mode  CntScore
Error  Units
LatchBenchmark.binaryHeapOutputStreamDirect
TestTestTestTestTestTestTestTestTest  avgt   50  128,036 ± 4,360  ns/op
LatchBenchmark.binaryHeapOutputStreamDirect
TestTestTestavgt   5044,934 ± 1,463  ns/op
LatchBenchmark.binaryHeapOutputStreamDirect
Test  avgt   5021,254 ± 0,776  ns/op
LatchBenchmark.binaryHeapOutputStreamInDirect
TestTestTestTestTestTestTestTestTest avgt   5083,262 ± 2,264  ns/op
LatchBenchmark.binaryHeapOutputStreamInDirect
TestTestTest   avgt   5058,975 ± 1,559  ns/op
LatchBenchmark.binaryHeapOutputStreamInDirect
Test avgt   5048,506 ± 1,116  ns/op


Vadim

2017-03-06 19:42 GMT+03:00 Вадим Опольский <vaopols...@gmail.com>:

> Hello, everybody!
>
> Valentin, I've corrected benchmark and received the results:
>
> Benchmark
> (message)  Mode  Cnt
> Score   Error  Units
> LatchBenchmark.binaryHeapOutputStreamDirect
> TestTestTestTestTestTestTestTestTest  avgt   50  128,036 ± 4,360  ns/op
> LatchBenchmark.binaryHeapOutputStreamDirect
> TestTestTestavgt   5044,934 ± 1,463  ns/op
> LatchBenchmark.binaryHeapOutputStreamDirect
> Test  avgt   5021,254 ± 0,776  ns/op
> LatchBenchmark.binaryHeapOutputStreamInDirect
> TestTestTestTestTestTestTestTestTest avgt   5083,262 ± 2,264  ns/op
> LatchBenchmark.binaryHeapOutputStreamInDirect
> TestTestTest   avgt   5058,975 ± 1,559  ns/op
> LatchBenchmark.binaryHeapOutputStreamInDirect
> Test avgt   5048,506 ± 1,116  ns/op
>
> https://github.com/javaller/MyBenchmark/blob/master/out_06_03_17_2.txt
>
> Whats the next step ?
>
>  Do I have to add benchmark to Ignite project ?
>
> Vadim Opolskiy
>
> 2017-03-03 21:11 GMT+03:00 Valentin Kulichenko <
> valentin.kuliche...@gmail.com>:
>
>> Hi Vadim,
>>
>> What do you mean by "copied benchmarks"? What changed singe previous
>> iteration and why results are so different?
>>
>> As for duplicated loop, you don't need it. BinaryOutputStream allows to
>> write a value to a particular position (even before already written data).
>> So you can reserve 4 bytes for length, remember position, calculate length
>> while encoding and writing bytes, and then write length.
>>
>> -Val
>>
>> On Fri, Mar 3, 2017 at 12:45 AM, Вадим Опольский <vaopols...@gmail.com>
>> wrote:
>>
>>> Valentin,
>>>
>>> What do you think about duplicated cycle in strToBinaryOutputStream ?
>>>
>>> How to calculate StrLen для outBinaryHeap without this cycle ?
>>>
>>> public class BinaryUtilsNew extends BinaryUtils {
>>>
>>> public static int getStrLen(String val) {
>>> int strLen = val.length();
>>> int utfLen = 0;
>>> int c;
>>>
>>> // Determine length of resulting byte array.
>>>
>>>
>>>
>>>
>>> *for (int cnt = 0; cnt < strLen; cnt++) {c = val.charAt(cnt);   
>>>  if (c >= 0x0001 && c <= 0x007F)*utfLen++;
>>>* else if (c > 0x07FF)*
>>> utfLen += 3;
>>> else
>>> utfLen += 2;
>>> }
>>>
>>> return utfLen;
>>> }
>>>
>>> public static void strToUtf8BytesDirect(BinaryOutputStream 
>>> outBinaryHeap, String val) {
>>>
>>> int strLen = val.length();
>>> int c, cnt;
>>>
>>> int position = 0;
>>>
>>> outBinaryHeap.unsafeEnsure(1 + 4);
>>>
>>> *   outBinaryHeap.unsafeWriteByte(GridBinaryMarshaller.STRING);
>>> outBinaryHeap.unsafeWriteInt(getStrLen(val));*
>>>
>>>
>>>
>>> * for (cnt = 0; cnt < strLen; cnt++) {c = val.charAt(cnt);*
>>>* if (c >= 0x0001 && c <= 0x007F)*
>>>

Re: assigning IGNITE-933

[Вадим Опольский]

Denis,

I'm planning to adjust processing time of incoming and outgoing messages by
JMH benchmarks.

What do you think are the parameters of commodity hardware/? RAM size? CPU
speed ? or others ?

Vadim

2017-03-06 22:36 GMT+03:00 Denis Magda <dma...@apache.org>:

> Vadim,
>
> How do you plan to adjust processing time of incoming and outgoing
> messages? In general, I don’t think that you need to move the direction of
> the communication layer.
>
> I’m thinking that you just need to set some reasonable awaiting time so
> that the test passes on a commodity hardware.
>
> —
> Denis
>
> On Mar 6, 2017, at 2:31 AM, Вадим Опольский <vaopols...@gmail.com> wrote:
>
> Hi everyone!
>
> I executed test GridFailFastNodeFailureDetectionSelfTest.testFailFast
> fails periodically with different values of node quantity and awaiting
> time. Test fails if the awaiting time is less than 600 miliseconds.
> I debugged test and understood that messaging took a lot of time in this
> case.
> I want to measure (with GridFailFastNodeFailureDetecti
> onSelfTest.testFailFast) and increase speed of receiving and sending
> message.
>
> Denis, what do you think about it ?
>
> Vadim Opolski
>
>
> 2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org>:
>
>> Hi Vadim,
>>
>> Yes, this issue might be still relevant. I can’t guide you through but,
>> basically, you need to reproduce the issue, spot it in the code and propose
>> a fix.
>>
>> BTW, do you have any experience with Hibernate? If so, I would be amazing
>> if you pick up this ticket reassigning on yourself:
>> https://issues.apache.org/jira/browse/IGNITE-1794 <
>> https://issues.apache.org/jira/browse/IGNITE-1794>
>>
>> —
>> Denis
>>
>> > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopols...@gmail.com>
>> wrote:
>> >
>> > Dear sirs !
>> >
>> > I want to resolve issue IGNITE-933
>> >
>> > https://issues.apache.org/jira/browse/IGNITE-933
>> >
>> > Is it actual ?
>> >
>> > In which class and method you want me to make changes ?
>> >
>> > Vadim Opolski
>>
>>
>
>

Re: IGNITE-13

[Вадим Опольский]

Hello, everybody!

Valentin, I've corrected benchmark and received the results:

Benchmark
(message)  Mode  CntScore
Error  Units
LatchBenchmark.binaryHeapOutputStreamDirect
TestTestTestTestTestTestTestTestTest  avgt   50  128,036 ± 4,360  ns/op
LatchBenchmark.binaryHeapOutputStreamDirect
TestTestTestavgt   5044,934 ± 1,463  ns/op
LatchBenchmark.binaryHeapOutputStreamDirect
Test  avgt   5021,254 ± 0,776  ns/op
LatchBenchmark.binaryHeapOutputStreamInDirect
TestTestTestTestTestTestTestTestTest avgt   5083,262 ± 2,264  ns/op
LatchBenchmark.binaryHeapOutputStreamInDirect
TestTestTest   avgt   5058,975 ± 1,559  ns/op
LatchBenchmark.binaryHeapOutputStreamInDirect
Test avgt   5048,506 ± 1,116  ns/op

https://github.com/javaller/MyBenchmark/blob/master/out_06_03_17_2.txt

Whats the next step ?

 Do I have to add benchmark to Ignite project ?

Vadim Opolskiy

2017-03-03 21:11 GMT+03:00 Valentin Kulichenko <
valentin.kuliche...@gmail.com>:

> Hi Vadim,
>
> What do you mean by "copied benchmarks"? What changed singe previous
> iteration and why results are so different?
>
> As for duplicated loop, you don't need it. BinaryOutputStream allows to
> write a value to a particular position (even before already written data).
> So you can reserve 4 bytes for length, remember position, calculate length
> while encoding and writing bytes, and then write length.
>
> -Val
>
> On Fri, Mar 3, 2017 at 12:45 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Valentin,
>>
>> What do you think about duplicated cycle in strToBinaryOutputStream ?
>>
>> How to calculate StrLen для outBinaryHeap without this cycle ?
>>
>> public class BinaryUtilsNew extends BinaryUtils {
>>
>> public static int getStrLen(String val) {
>> int strLen = val.length();
>> int utfLen = 0;
>> int c;
>>
>> // Determine length of resulting byte array.
>>
>>
>>
>>
>> *for (int cnt = 0; cnt < strLen; cnt++) {c = val.charAt(cnt);
>> if (c >= 0x0001 && c <= 0x007F)*utfLen++;
>>* else if (c > 0x07FF)*
>> utfLen += 3;
>> else
>> utfLen += 2;
>> }
>>
>> return utfLen;
>> }
>>
>> public static void strToUtf8BytesDirect(BinaryOutputStream 
>> outBinaryHeap, String val) {
>>
>> int strLen = val.length();
>> int c, cnt;
>>
>> int position = 0;
>>
>> outBinaryHeap.unsafeEnsure(1 + 4);
>>
>> *   outBinaryHeap.unsafeWriteByte(GridBinaryMarshaller.STRING);
>> outBinaryHeap.unsafeWriteInt(getStrLen(val));*
>>
>>
>>
>> * for (cnt = 0; cnt < strLen; cnt++) {c = val.charAt(cnt);*
>>* if (c >= 0x0001 && c <= 0x007F)*
>> outBinaryHeap.writeByte((byte) c);
>>  *   else if (c > 0x07FF) {*
>> outBinaryHeap.writeByte((byte)(0xE0 | (c >> 12) & 0x0F));
>> outBinaryHeap.writeByte((byte)(0x80 | (c >> 6) & 0x3F));
>> outBinaryHeap.writeByte((byte)(0x80 | (c & 0x3F)));
>> }
>> else {
>> outBinaryHeap.writeByte((byte)(0xC0 | ((c >> 6) & 0x1F)));
>> outBinaryHeap.writeByte((byte)(0x80 | (c  & 0x3F)));
>> }
>> }
>> }
>>
>>
>> Vadim
>>
>>
>>
>> 2017-03-03 2:00 GMT+03:00 Valentin Kulichenko <
>> valentin.kuliche...@gmail.com>:
>>
>>> Vadim,
>>>
>>> Looks better now. Can you also try to modify the benchmark so that
>>> marshaller and writer are created outside of the measured method? I.e. the
>>> benchmark methods should be as simple as this:
>>>
>>> @Benchmark
>>> public void binaryHeapOutputStreamDirect() throws Exception {
>>> writer.doWriteStringDirect(message);
>>> }
>>>
>>> @Benchmark
>>> public void binaryHeapOutputStreamInDirect() throws Exception {
>>> writer.doWriteString(message);
>>> }
>>>
>>> In any case, do I understand correctly that it didn't actually make any
>>> performance difference? If so, I think we can close the ticket.
>>>
>>> Vova, can you also take a look and provide your thoughts?
>&g

Re: assigning IGNITE-933

[Вадим Опольский]

Hi everyone!

I executed test GridFailFastNodeFailureDetectionSelfTest.testFailFast fails
periodically with different values of node quantity and awaiting time. Test
fails if the awaiting time is less than 600 miliseconds.
I debugged test and understood that messaging took a lot of time in this
case.
I want to measure (with
GridFailFastNodeFailureDetectionSelfTest.testFailFast) and increase speed
of receiving and sending message.

Denis, what do you think about it ?

Vadim Opolski


2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org>:

> Hi Vadim,
>
> Yes, this issue might be still relevant. I can’t guide you through but,
> basically, you need to reproduce the issue, spot it in the code and propose
> a fix.
>
> BTW, do you have any experience with Hibernate? If so, I would be amazing
> if you pick up this ticket reassigning on yourself:
> https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794>
>
> —
> Denis
>
> > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
> >
> > Dear sirs !
> >
> > I want to resolve issue IGNITE-933
> >
> > https://issues.apache.org/jira/browse/IGNITE-933
> >
> > Is it actual ?
> >
> > In which class and method you want me to make changes ?
> >
> > Vadim Opolski
>
>

Re: IGNITE-13

[Вадим Опольский]

Valentin,

What do you think about duplicated cycle in strToBinaryOutputStream ?

How to calculate StrLen для outBinaryHeap without this cycle ?

public class BinaryUtilsNew extends BinaryUtils {

public static int getStrLen(String val) {
int strLen = val.length();
int utfLen = 0;
int c;

// Determine length of resulting byte array.




*for (int cnt = 0; cnt < strLen; cnt++) {c =
val.charAt(cnt);if (c >= 0x0001 && c <= 0x007F)*
 utfLen++;
   * else if (c > 0x07FF)*
utfLen += 3;
else
utfLen += 2;
}

return utfLen;
}

public static void strToUtf8BytesDirect(BinaryOutputStream
outBinaryHeap, String val) {

int strLen = val.length();
int c, cnt;

int position = 0;

outBinaryHeap.unsafeEnsure(1 + 4);

*   outBinaryHeap.unsafeWriteByte(GridBinaryMarshaller.STRING);
outBinaryHeap.unsafeWriteInt(getStrLen(val));*



* for (cnt = 0; cnt < strLen; cnt++) {c = val.charAt(cnt);*
   * if (c >= 0x0001 && c <= 0x007F)*
outBinaryHeap.writeByte((byte) c);
 *   else if (c > 0x07FF) {*
outBinaryHeap.writeByte((byte)(0xE0 | (c >> 12) & 0x0F));
outBinaryHeap.writeByte((byte)(0x80 | (c >> 6) & 0x3F));
outBinaryHeap.writeByte((byte)(0x80 | (c & 0x3F)));
}
else {
outBinaryHeap.writeByte((byte)(0xC0 | ((c >> 6) & 0x1F)));
outBinaryHeap.writeByte((byte)(0x80 | (c  & 0x3F)));
}
}
}


Vadim


2017-03-03 2:00 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Vadim,
>
> Looks better now. Can you also try to modify the benchmark so that
> marshaller and writer are created outside of the measured method? I.e. the
> benchmark methods should be as simple as this:
>
> @Benchmark
> public void binaryHeapOutputStreamDirect() throws Exception {
> writer.doWriteStringDirect(message);
> }
>
> @Benchmark
> public void binaryHeapOutputStreamInDirect() throws Exception {
> writer.doWriteString(message);
> }
>
> In any case, do I understand correctly that it didn't actually make any
> performance difference? If so, I think we can close the ticket.
>
> Vova, can you also take a look and provide your thoughts?
>
> -Val
>
> On Thu, Mar 2, 2017 at 1:27 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi Valentin!
>>
>> I've created:
>>
>> new method strToUtf8BytesDirect in BinaryUtilsNew
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/BinaryUtilsNew.java
>>
>> new method doWriteStringDirect in BinaryWriterExImplNew
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/BinaryWriterExImplNew.java
>>
>> benchmarks for BinaryWriterExImpl doWriteString and BinaryWriterExImplNew
>> doWriteStringDirect
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/ExampleTest.java
>>
>> This is a result of comparing:
>>
>> Benchmark
>> Mode  Cnt   Score   Error 
>> UnitsExampleTest.binaryHeapOutputStreamDirect
>> avgt   50  1128448,743 ± 13536,689  
>> ns/opExampleTest.binaryHeapOutputStreamInDirect
>> avgt   50  1127270,695 ± 17309,256  ns/op
>>
>> Vadim
>>
>> 2017-03-02 1:02 GMT+03:00 Valentin Kulichenko <
>> valentin.kuliche...@gmail.com>:
>>
>>> Hi Vadim,
>>>
>>> We're getting closer :) I would actually like to see the test for actual
>>> implementation of BinaryWriterExImpl#doWriteString method. Logic in
>>> binaryHeapOutputInDirect() confuses me a bit and I'm not sure comparison is
>>> valid.
>>>
>>> Can you please do the following:
>>>
>>> 1. Create new BinaryUtils#strToUtf8BytesDirect method, copy-paste the
>>> code from existing BinaryUtils#strToUtf8Bytes and modify it so that it
>>> takes BinaryOutputStream as an argument and writes to it directly. Do not
>>> create stream inside this method, as it's the same as creating new array.
>>> 2. Create new BinaryWriterExImpl#doWriteStringDirect, copy-paste the
>>> code from existing BinaryWriterExImpl#doWriteString and modify it so
>>> that it uses BinaryUtils#strToUtf8BytesDirect and doesn't
>>> call out.writeByteArray.
>>> 3. Create benchmark for BinaryWriterExImpl#doWriteString method. I.e.,
>>> create an instance of BinaryWriterExImpl and call doWriteString() in
>>&g

Re: IGNITE-13

[Вадим Опольский]

Hello Colleagues!

I've just copied benchmarks and gotten interest results.

https://github.com/javaller/MyBenchmark/blob/master/03_03_17_out.txt

Time increase in 5, 6 Iteration in both cases.

What do you think about it?

Vadim

2017-03-03 2:00 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Vadim,
>
> Looks better now. Can you also try to modify the benchmark so that
> marshaller and writer are created outside of the measured method? I.e. the
> benchmark methods should be as simple as this:
>
> @Benchmark
> public void binaryHeapOutputStreamDirect() throws Exception {
> writer.doWriteStringDirect(message);
> }
>
> @Benchmark
> public void binaryHeapOutputStreamInDirect() throws Exception {
> writer.doWriteString(message);
> }
>
> In any case, do I understand correctly that it didn't actually make any
> performance difference? If so, I think we can close the ticket.
>
> Vova, can you also take a look and provide your thoughts?
>
> -Val
>
> On Thu, Mar 2, 2017 at 1:27 PM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi Valentin!
>>
>> I've created:
>>
>> new method strToUtf8BytesDirect in BinaryUtilsNew
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/BinaryUtilsNew.java
>>
>> new method doWriteStringDirect in BinaryWriterExImplNew
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/BinaryWriterExImplNew.java
>>
>> benchmarks for BinaryWriterExImpl doWriteString and BinaryWriterExImplNew
>> doWriteStringDirect
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/ExampleTest.java
>>
>> This is a result of comparing:
>>
>> Benchmark
>> Mode  Cnt   Score   Error 
>> UnitsExampleTest.binaryHeapOutputStreamDirect
>> avgt   50  1128448,743 ± 13536,689  
>> ns/opExampleTest.binaryHeapOutputStreamInDirect
>> avgt   50  1127270,695 ± 17309,256  ns/op
>>
>> Vadim
>>
>> 2017-03-02 1:02 GMT+03:00 Valentin Kulichenko <
>> valentin.kuliche...@gmail.com>:
>>
>>> Hi Vadim,
>>>
>>> We're getting closer :) I would actually like to see the test for actual
>>> implementation of BinaryWriterExImpl#doWriteString method. Logic in
>>> binaryHeapOutputInDirect() confuses me a bit and I'm not sure comparison is
>>> valid.
>>>
>>> Can you please do the following:
>>>
>>> 1. Create new BinaryUtils#strToUtf8BytesDirect method, copy-paste the
>>> code from existing BinaryUtils#strToUtf8Bytes and modify it so that it
>>> takes BinaryOutputStream as an argument and writes to it directly. Do not
>>> create stream inside this method, as it's the same as creating new array.
>>> 2. Create new BinaryWriterExImpl#doWriteStringDirect, copy-paste the
>>> code from existing BinaryWriterExImpl#doWriteString and modify it so
>>> that it uses BinaryUtils#strToUtf8BytesDirect and doesn't
>>> call out.writeByteArray.
>>> 3. Create benchmark for BinaryWriterExImpl#doWriteString method. I.e.,
>>> create an instance of BinaryWriterExImpl and call doWriteString() in
>>> benchmark method.
>>> 4. Similarly, create benchmark for BinaryWriterExImpl#doWriteStri
>>> ngDirect.
>>> 5. Compare results.
>>>
>>> This will give us clear picture of how these two approaches perform.
>>> Your current results are actually promising, but I would like to confirm
>>> them.
>>>
>>> -Val
>>>
>>> On Wed, Mar 1, 2017 at 6:17 AM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>>> Hi Valentin!
>>>>
>>>> Thank you for comments.
>>>>
>>>> There is a new method which writes directly to BinaryOutputStream
>>>> instead of intermediate array.
>>>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>>>> /java/org/sample/BinaryUtilsNew.java
>>>>
>>>> There is benchmark.
>>>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>>>> /java/org/sample/MyBenchmark.java
>>>>
>>>> Unit test
>>>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>>>> /java/org/sample/BinaryOutputStreamTest.java
>>>>
>>>> Statistics
>>>> https://github.com/javaller/MyBenchmark/blob/master/out_01_03_17.txt
>>>>
>>>> Benchmark
>>>>  Mode   CntScore 

Re: IGNITE-13

[Вадим Опольский]

Hi Valentin!

I've created:

new method strToUtf8BytesDirect in BinaryUtilsNew
https://github.com/javaller/MyBenchmark/blob/master/src/
main/java/org/sample/BinaryUtilsNew.java

new method doWriteStringDirect in BinaryWriterExImplNew
https://github.com/javaller/MyBenchmark/blob/master/src/
main/java/org/sample/BinaryWriterExImplNew.java

benchmarks for BinaryWriterExImpl doWriteString and BinaryWriterExImplNew
doWriteStringDirect
https://github.com/javaller/MyBenchmark/blob/master/src/
main/java/org/sample/ExampleTest.java

This is a result of comparing:

Benchmark
Mode  Cnt   Score   Error
UnitsExampleTest.binaryHeapOutputStreamDirect  avgt   50  1128448,743 ±
13536,689  ns/opExampleTest.binaryHeapOutputStreamInDirect  avgt   50
1127270,695 ± 17309,256  ns/op

Vadim

2017-03-02 1:02 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Hi Vadim,
>
> We're getting closer :) I would actually like to see the test for actual
> implementation of BinaryWriterExImpl#doWriteString method. Logic in
> binaryHeapOutputInDirect() confuses me a bit and I'm not sure comparison is
> valid.
>
> Can you please do the following:
>
> 1. Create new BinaryUtils#strToUtf8BytesDirect method, copy-paste the
> code from existing BinaryUtils#strToUtf8Bytes and modify it so that it
> takes BinaryOutputStream as an argument and writes to it directly. Do not
> create stream inside this method, as it's the same as creating new array.
> 2. Create new BinaryWriterExImpl#doWriteStringDirect, copy-paste the code
> from existing BinaryWriterExImpl#doWriteString and modify it so that it
> uses BinaryUtils#strToUtf8BytesDirect and doesn't call out.writeByteArray.
> 3. Create benchmark for BinaryWriterExImpl#doWriteString method. I.e.,
> create an instance of BinaryWriterExImpl and call doWriteString() in
> benchmark method.
> 4. Similarly, create benchmark for BinaryWriterExImpl#doWriteStringDirect.
> 5. Compare results.
>
> This will give us clear picture of how these two approaches perform. Your
> current results are actually promising, but I would like to confirm them.
>
> -Val
>
> On Wed, Mar 1, 2017 at 6:17 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi Valentin!
>>
>> Thank you for comments.
>>
>> There is a new method which writes directly to BinaryOutputStream instead
>> of intermediate array.
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/BinaryUtilsNew.java
>>
>> There is benchmark.
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/MyBenchmark.java
>>
>> Unit test
>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>> /java/org/sample/BinaryOutputStreamTest.java
>>
>> Statistics
>> https://github.com/javaller/MyBenchmark/blob/master/out_01_03_17.txt
>>
>> Benchmark
>>  Mode   CntScoreError  Units MyBenchmark.binaryHeapOutputIn
>> Directavgt  50  111,337 ± 0,742  ns/op
>> MyBenchmark.binaryHeapOutputStreamDirect   avgt  50   23,847 ±
>> 0,303ns/op
>>
>>
>> Vadim
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> 2017-02-28 4:29 GMT+03:00 Valentin Kulichenko <
>> valentin.kuliche...@gmail.com>:
>>
>>> Hi Vadim,
>>>
>>> Looks like you accidentally removed dev list from the thread, adding it
>>> back.
>>>
>>> I think there is still misunderstanding. What I propose is to modify
>>> the BinaryUtils#strToUtf8Bytes so that it writes directly to 
>>> BinaryOutputStream
>>> instead of intermediate array. This should decrease memory consumption and
>>> can also increase performance as we will avoid 'writeByteArray' step at
>>> the end.
>>>
>>> Does it make sense to you?
>>>
>>> -Val
>>>
>>> On Mon, Feb 27, 2017 at 6:55 AM, Вадим Опольский <vaopols...@gmail.com>
>>> wrote:
>>>
>>>> Hi, Valentin!
>>>>
>>>> What do you think about using the methods of BinaryOutputStream:
>>>>
>>>> 1) writeByteArray(byte[] val)
>>>> 2) writeCharArray(char[] val)
>>>> 3) write (byte[] arr, int off, int len)
>>>>
>>>> String val = "Test";
>>>> out.writeByteArray( val.getBytes(UTF_8));
>>>>
>>>>  String val = "Test";
>>>> out.writeCharArray(str.toCharArray());
>>>>
>>>> String val = "Test"
>>>> InputStream stream = new ByteArrayInputStream(
>>>> ex

Re: IGNITE-13

[Вадим Опольский]

Hi Valentin!

Thank you for comments.

There is a new method which writes directly to BinaryOutputStream instead
of intermediate array.
https://github.com/javaller/MyBenchmark/blob/master/src/
main/java/org/sample/BinaryUtilsNew.java

There is benchmark.
https://github.com/javaller/MyBenchmark/blob/master/src/
main/java/org/sample/MyBenchmark.java

Unit test
https://github.com/javaller/MyBenchmark/blob/master/src/
main/java/org/sample/BinaryOutputStreamTest.java

Statistics
https://github.com/javaller/MyBenchmark/blob/master/out_01_03_17.txt

Benchmark
 Mode   CntScoreError  Units
MyBenchmark.binaryHeapOutputInDirectavgt  50  111,337 ±
0,742  ns/op MyBenchmark.binaryHeapOutputStreamDirect   avgt  50
23,847 ± 0,303ns/op


Vadim










2017-02-28 4:29 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Hi Vadim,
>
> Looks like you accidentally removed dev list from the thread, adding it
> back.
>
> I think there is still misunderstanding. What I propose is to modify
> the BinaryUtils#strToUtf8Bytes so that it writes directly to 
> BinaryOutputStream
> instead of intermediate array. This should decrease memory consumption and
> can also increase performance as we will avoid 'writeByteArray' step at
> the end.
>
> Does it make sense to you?
>
> -Val
>
> On Mon, Feb 27, 2017 at 6:55 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hi, Valentin!
>>
>> What do you think about using the methods of BinaryOutputStream:
>>
>> 1) writeByteArray(byte[] val)
>> 2) writeCharArray(char[] val)
>> 3) write (byte[] arr, int off, int len)
>>
>> String val = "Test";
>> out.writeByteArray( val.getBytes(UTF_8));
>>
>>  String val = "Test";
>> out.writeCharArray(str.toCharArray());
>>
>> String val = "Test"
>> InputStream stream = new ByteArrayInputStream(
>> exampleString.getBytes(StandartCharsets.UTF_8));
>> byte[] buffer = new byte[1024];
>> while ((buffer = stream.read()) != -1) {
>> out.writeByteArray(buffer);
>> }
>>
>> What else can we use ?
>>
>> Vadim
>>
>>
>> 2017-02-25 2:21 GMT+03:00 Valentin Kulichenko <
>> valentin.kuliche...@gmail.com>:
>>
>>> Hi Vadim,
>>>
>>> Which method implements the approach described in the ticket? From what
>>> I see, all writeToStringX versions are still encoding into an intermediate
>>> array and then call out.writeByteArray. What we need to test is the
>>> approach where bytes are written directly into the stream during encoding.
>>> Encoding algorithm itself should stay the same for now, otherwise we will
>>> not know how to interpret the result.
>>>
>>> It looks like there is some misunderstanding here, so please let me know
>>> anything is still unclear. I will be happy to answer your questions.
>>>
>>> -Val
>>>
>>> On Wed, Feb 22, 2017 at 7:22 PM, Valentin Kulichenko <
>>> valentin.kuliche...@gmail.com> wrote:
>>>
>>>> Hi Vadim,
>>>>
>>>> Thanks, I will review this week.
>>>>
>>>> -Val
>>>>
>>>> On Wed, Feb 22, 2017 at 2:28 AM, Вадим Опольский <vaopols...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi Valentin!
>>>>>
>>>>> https://issues.apache.org/jira/browse/IGNITE-13
>>>>>
>>>>> I created BinaryWriterExImplNew (extended of BinaryWriterExImpl) and
>>>>> added new methods with changes described in the ticket
>>>>>
>>>>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>>>>> /java/org/sample/BinaryWriterExImplNew.java
>>>>>
>>>>> I created a benchmark for BinaryWriterExImplNew
>>>>>
>>>>> https://github.com/javaller/MyBenchmark/blob/master/src/main
>>>>> /java/org/sample/ExampleTest.java
>>>>>
>>>>> I run benchmark and compared results
>>>>>
>>>>> https://github.com/javaller/MyBenchmark/blob/master/totalstat.txt
>>>>>
>>>>> # Run complete. Total time: 00:10:24
>>>>> BenchmarkMode  Cnt
>>>>> Score   Error  Units
>>>>> ExampleTest.binaryHeapOutputStream1  avgt   50  1114999,207 ±
>>>>> 16756,776  ns/op
>>>>> ExampleTest.binaryHeapOutputStream2  avgt   50  1118149,320 ±
>>>>> 17515,961  ns/op
>>>>>

Re: assigning IGNITE-933

[Вадим Опольский]

Hi Denis,

OK, I spotted the problem in the code and I will be try to resolve it.

https://issues.apache.org/jira/browse/IGNITE-933

Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is
interesting for me. How I can assignee it to me? It is assigning with
Mykola Pereyma now.

https://issues.apache.org/jira/browse/IGNITE-1794

Vadim Opolski

2017-02-24 5:55 GMT+03:00 Denis Magda <dma...@apache.org>:

> Hi Vadim,
>
> Yes, this issue might be still relevant. I can’t guide you through but,
> basically, you need to reproduce the issue, spot it in the code and propose
> a fix.
>
> BTW, do you have any experience with Hibernate? If so, I would be amazing
> if you pick up this ticket reassigning on yourself:
> https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794>
>
> —
> Denis
>
> > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
> >
> > Dear sirs !
> >
> > I want to resolve issue IGNITE-933
> >
> > https://issues.apache.org/jira/browse/IGNITE-933
> >
> > Is it actual ?
> >
> > In which class and method you want me to make changes ?
> >
> > Vadim Opolski
>
>

assigning IGNITE-933

[Вадим Опольский]

Dear sirs !

I want to resolve issue IGNITE-933

https://issues.apache.org/jira/browse/IGNITE-933

Is it actual ?

In which class and method you want me to make changes ?

Vadim Opolski

Re: IGNITE-13

[Вадим Опольский]

Hi Valentin!

https://issues.apache.org/jira/browse/IGNITE-13

I created BinaryWriterExImplNew (extended of BinaryWriterExImpl) and added
new methods with changes described in the ticket

https://github.com/javaller/MyBenchmark/blob/master/src/main/java/org/sample/BinaryWriterExImplNew.java

I created a benchmark for BinaryWriterExImplNew

https://github.com/javaller/MyBenchmark/blob/master/src/main/java/org/sample/ExampleTest.java

I run benchmark and compared results

https://github.com/javaller/MyBenchmark/blob/master/totalstat.txt

# Run complete. Total time: 00:10:24
BenchmarkMode  CntScore
Error  Units
ExampleTest.binaryHeapOutputStream1  avgt   50  1114999,207 ±
16756,776  ns/op
ExampleTest.binaryHeapOutputStream2  avgt   50  1118149,320 ±
17515,961  ns/op
ExampleTest.binaryHeapOutputStream3  avgt   50  1113678,657 ±
17652,314  ns/op
ExampleTest.binaryHeapOutputStream4  avgt   50  1112415,051 ±
18273,874  ns/op
ExampleTest.binaryHeapOutputStream5  avgt   50  366,583 ±
18282,829  ns/op
ExampleTest.binaryHeapOutputStreamACSII   avgt   50  1112079,667 ±
16659,532  ns/op
ExampleTest.binaryHeapOutputStreamUTFCustom  avgt   50  1114949,759 ±
16809,669  ns/op
ExampleTest.binaryHeapOutputStreamUTFNIOavgt   50  1121462,325 ±
19836,466  ns/op

Is it OK? Whats the next step? Do I have to move this JMH benchmark to the
Ignite project ?

Vadim Opolski








2017-02-21 1:06 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Hi Vadim,
>
> I'm not sure I understand your benchmarks and how they verify the
> optimization discussed here. Basically, here is what needs to be done:
>
> 1. Create a benchmark for BinaryWriterExImpl#doWriteString method.
> 2. Run the benchmark with current implementation.
> 3. Make the change described in the ticket.
> 4. Run the benchmark with these changes.
> 5. Compare results.
>
> Makes sense? Let me know if anything is unclear.
>
> -Val
>
> On Mon, Feb 20, 2017 at 8:51 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hello everybody!
>>
>> https://issues.apache.org/jira/browse/IGNITE-13
>>
>> Valentin, I just have finished benchmark (with JMH) -
>> https://github.com/javaller/MyBenchmark.git
>>
>> It collect data about time working of serialization.
>>
>> For instance - https://github.com/javaller/My
>> Benchmark/blob/master/out200217.txt
>>
>> To start it you have to do next:
>>
>> 1) clone it - git colne https://github.com/javaller/MyBenchmark.git
>>
>> 2) install it - mvn install
>>
>> 3) run benchmarks -  java -Xms1024m -Xmx4096m -jar target\benchmarks.jar
>>
>> Vadim Opolski
>>
>>
>>
>>
>>
>> 2017-02-15 0:52 GMT+03:00 Valentin Kulichenko <
>> valentin.kuliche...@gmail.com>:
>>
>>> Vladimir,
>>>
>>> I think we misunderstood each other. My understanding of this
>>> optimization is the following.
>>>
>>> Currently string serialization is done in two steps (see
>>> BinaryWriterExImpl#doWriteString):
>>>
>>> strArr = BinaryUtils.strToUtf8Bytes(val); // Encode string into byte
>>> array.
>>> out.writeByteArray(strArr);  // Write byte array
>>> into stream.
>>>
>>> What this ticket suggests is to write directly into stream while string
>>> is encoded, without intermediate array. This both reduces memory
>>> consumption and eliminates array copy step.
>>>
>>> I updated the ticket and added this explanation there.
>>>
>>> Vadim, can you create a micro benchmark and check if it gives any
>>> improvement?
>>>
>>> -Val
>>>
>>> On Sun, Feb 12, 2017 at 10:38 PM, Vladimir Ozerov <voze...@gridgain.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> It is hard to say whether it makes sense or not. No doubt, it could
>>>> speed up marshalling process at the cost of 2x memory required for strings.
>>>> From my previous experience with marshalling micro-optimizations, we will
>>>> hardly ever notice speedup in distributed environment.
>>>>
>>>> But, there is another sied - it could speedup our queries, because we
>>>> will not have to unmarshal string on every field access. So I would try to
>>>> make this optimization optional and then measure query performance with
>>>> classes having lots of strings. It could give us interesting results.
>>>>
>>>> On Mon, Feb 13, 2017 at 5:37 AM, Valentin Kulichenko <
>>>>

Re: IGNITE-13

[Вадим Опольский]

Hi Valentin!

I compare speed of different methods how to get byte from string and push
it to outputstream.

Third method is the fastest.

Ok, I'm creating a benchmark for BinaryWriterExImpl#doWriteString method,
and making the change described in the ticket.

https://issues.apache.org/jira/browse/IGNITE-13

Vadim

2017-02-21 1:06 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Hi Vadim,
>
> I'm not sure I understand your benchmarks and how they verify the
> optimization discussed here. Basically, here is what needs to be done:
>
> 1. Create a benchmark for BinaryWriterExImpl#doWriteString method.
> 2. Run the benchmark with current implementation.
> 3. Make the change described in the ticket.
> 4. Run the benchmark with these changes.
> 5. Compare results.
>
> Makes sense? Let me know if anything is unclear.
>
> -Val
>
> On Mon, Feb 20, 2017 at 8:51 AM, Вадим Опольский <vaopols...@gmail.com>
> wrote:
>
>> Hello everybody!
>>
>> https://issues.apache.org/jira/browse/IGNITE-13
>>
>> Valentin, I just have finished benchmark (with JMH) -
>> https://github.com/javaller/MyBenchmark.git
>>
>> It collect data about time working of serialization.
>>
>> For instance - https://github.com/javaller/My
>> Benchmark/blob/master/out200217.txt
>>
>> To start it you have to do next:
>>
>> 1) clone it - git colne https://github.com/javaller/MyBenchmark.git
>>
>> 2) install it - mvn install
>>
>> 3) run benchmarks -  java -Xms1024m -Xmx4096m -jar target\benchmarks.jar
>>
>> Vadim Opolski
>>
>>
>>
>>
>>
>> 2017-02-15 0:52 GMT+03:00 Valentin Kulichenko <
>> valentin.kuliche...@gmail.com>:
>>
>>> Vladimir,
>>>
>>> I think we misunderstood each other. My understanding of this
>>> optimization is the following.
>>>
>>> Currently string serialization is done in two steps (see
>>> BinaryWriterExImpl#doWriteString):
>>>
>>> strArr = BinaryUtils.strToUtf8Bytes(val); // Encode string into byte
>>> array.
>>> out.writeByteArray(strArr);  // Write byte array
>>> into stream.
>>>
>>> What this ticket suggests is to write directly into stream while string
>>> is encoded, without intermediate array. This both reduces memory
>>> consumption and eliminates array copy step.
>>>
>>> I updated the ticket and added this explanation there.
>>>
>>> Vadim, can you create a micro benchmark and check if it gives any
>>> improvement?
>>>
>>> -Val
>>>
>>> On Sun, Feb 12, 2017 at 10:38 PM, Vladimir Ozerov <voze...@gridgain.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> It is hard to say whether it makes sense or not. No doubt, it could
>>>> speed up marshalling process at the cost of 2x memory required for strings.
>>>> From my previous experience with marshalling micro-optimizations, we will
>>>> hardly ever notice speedup in distributed environment.
>>>>
>>>> But, there is another sied - it could speedup our queries, because we
>>>> will not have to unmarshal string on every field access. So I would try to
>>>> make this optimization optional and then measure query performance with
>>>> classes having lots of strings. It could give us interesting results.
>>>>
>>>> On Mon, Feb 13, 2017 at 5:37 AM, Valentin Kulichenko <
>>>> valentin.kuliche...@gmail.com> wrote:
>>>>
>>>>> Vladimir,
>>>>>
>>>>> Can you please take a look and provide your thoughts? Can this be
>>>>> applied to binary marshaller? From what I recall, it serializes string a
>>>>> bit differently from optimized marshaller, so I'm not sure.
>>>>>
>>>>> -Val
>>>>>
>>>>> On Fri, Feb 10, 2017 at 5:16 PM, Dmitriy Setrakyan <
>>>>> dsetrak...@apache.org> wrote:
>>>>>
>>>>>> On Thu, Feb 9, 2017 at 11:26 PM, Valentin Kulichenko <
>>>>>> valentin.kuliche...@gmail.com> wrote:
>>>>>>
>>>>>> > Hi Vadim,
>>>>>> >
>>>>>> > I don't think it makes much sense to invest into
>>>>>> OptimizedMarshaller.
>>>>>> > However, I would check if this optimization is applicable to
>>>>>> > BinaryMarshaller, and if yes, implement it.
>>>>>> >
>>>>>>
>>>>>> Val, in this case can you please update the ticket?
>>>>>>
>>>>>>
>>>>>> >
>>>>>> > -Val
>>>>>> >
>>>>>> > On Thu, Feb 9, 2017 at 11:05 PM, Вадим Опольский <
>>>>>> vaopols...@gmail.com>
>>>>>> > wrote:
>>>>>> >
>>>>>> > > Dear sirs!
>>>>>> > >
>>>>>> > > I want to resolve issue IGNITE-13 -
>>>>>> > > https://issues.apache.org/jira/browse/IGNITE-13
>>>>>> > >
>>>>>> > > Is it actual?
>>>>>> > >
>>>>>> > > Vadim Opolski
>>>>>> > >
>>>>>> >
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>

Re: IGNITE-13

[Вадим Опольский]

Hello everybody!

https://issues.apache.org/jira/browse/IGNITE-13

Valentin, I just have finished benchmark (with JMH) -
https://github.com/javaller/MyBenchmark.git

It collect data about time working of serialization.

For instance -
https://github.com/javaller/MyBenchmark/blob/master/out200217.txt

To start it you have to do next:

1) clone it - git colne https://github.com/javaller/MyBenchmark.git

2) install it - mvn install

3) run benchmarks -  java -Xms1024m -Xmx4096m -jar target\benchmarks.jar

Vadim Opolski





2017-02-15 0:52 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Vladimir,
>
> I think we misunderstood each other. My understanding of this optimization
> is the following.
>
> Currently string serialization is done in two steps (see
> BinaryWriterExImpl#doWriteString):
>
> strArr = BinaryUtils.strToUtf8Bytes(val); // Encode string into byte
> array.
> out.writeByteArray(strArr);  // Write byte array into
> stream.
>
> What this ticket suggests is to write directly into stream while string is
> encoded, without intermediate array. This both reduces memory consumption
> and eliminates array copy step.
>
> I updated the ticket and added this explanation there.
>
> Vadim, can you create a micro benchmark and check if it gives any
> improvement?
>
> -Val
>
> On Sun, Feb 12, 2017 at 10:38 PM, Vladimir Ozerov <voze...@gridgain.com>
> wrote:
>
>> Hi,
>>
>> It is hard to say whether it makes sense or not. No doubt, it could speed
>> up marshalling process at the cost of 2x memory required for strings. From
>> my previous experience with marshalling micro-optimizations, we will hardly
>> ever notice speedup in distributed environment.
>>
>> But, there is another sied - it could speedup our queries, because we
>> will not have to unmarshal string on every field access. So I would try to
>> make this optimization optional and then measure query performance with
>> classes having lots of strings. It could give us interesting results.
>>
>> On Mon, Feb 13, 2017 at 5:37 AM, Valentin Kulichenko <
>> valentin.kuliche...@gmail.com> wrote:
>>
>>> Vladimir,
>>>
>>> Can you please take a look and provide your thoughts? Can this be
>>> applied to binary marshaller? From what I recall, it serializes string a
>>> bit differently from optimized marshaller, so I'm not sure.
>>>
>>> -Val
>>>
>>> On Fri, Feb 10, 2017 at 5:16 PM, Dmitriy Setrakyan <
>>> dsetrak...@apache.org> wrote:
>>>
>>>> On Thu, Feb 9, 2017 at 11:26 PM, Valentin Kulichenko <
>>>> valentin.kuliche...@gmail.com> wrote:
>>>>
>>>> > Hi Vadim,
>>>> >
>>>> > I don't think it makes much sense to invest into OptimizedMarshaller.
>>>> > However, I would check if this optimization is applicable to
>>>> > BinaryMarshaller, and if yes, implement it.
>>>> >
>>>>
>>>> Val, in this case can you please update the ticket?
>>>>
>>>>
>>>> >
>>>> > -Val
>>>> >
>>>> > On Thu, Feb 9, 2017 at 11:05 PM, Вадим Опольский <
>>>> vaopols...@gmail.com>
>>>> > wrote:
>>>> >
>>>> > > Dear sirs!
>>>> > >
>>>> > > I want to resolve issue IGNITE-13 -
>>>> > > https://issues.apache.org/jira/browse/IGNITE-13
>>>> > >
>>>> > > Is it actual?
>>>> > >
>>>> > > Vadim Opolski
>>>> > >
>>>> >
>>>>
>>>
>>>
>>
>

Re: IGNITE-13

[Вадим Опольский]

Hello everybody!

Valentin, yes, I can  create a micro benchmark and check if it gives any
improvement.

Vadim

2017-02-15 0:52 GMT+03:00 Valentin Kulichenko <valentin.kuliche...@gmail.com
>:

> Vladimir,
>
> I think we misunderstood each other. My understanding of this optimization
> is the following.
>
> Currently string serialization is done in two steps (see
> BinaryWriterExImpl#doWriteString):
>
> strArr = BinaryUtils.strToUtf8Bytes(val); // Encode string into byte
> array.
> out.writeByteArray(strArr);  // Write byte array into
> stream.
>
> What this ticket suggests is to write directly into stream while string is
> encoded, without intermediate array. This both reduces memory consumption
> and eliminates array copy step.
>
> I updated the ticket and added this explanation there.
>
> Vadim, can you create a micro benchmark and check if it gives any
> improvement?
>
> -Val
>
> On Sun, Feb 12, 2017 at 10:38 PM, Vladimir Ozerov <voze...@gridgain.com>
> wrote:
>
>> Hi,
>>
>> It is hard to say whether it makes sense or not. No doubt, it could speed
>> up marshalling process at the cost of 2x memory required for strings. From
>> my previous experience with marshalling micro-optimizations, we will hardly
>> ever notice speedup in distributed environment.
>>
>> But, there is another sied - it could speedup our queries, because we
>> will not have to unmarshal string on every field access. So I would try to
>> make this optimization optional and then measure query performance with
>> classes having lots of strings. It could give us interesting results.
>>
>> On Mon, Feb 13, 2017 at 5:37 AM, Valentin Kulichenko <
>> valentin.kuliche...@gmail.com> wrote:
>>
>>> Vladimir,
>>>
>>> Can you please take a look and provide your thoughts? Can this be
>>> applied to binary marshaller? From what I recall, it serializes string a
>>> bit differently from optimized marshaller, so I'm not sure.
>>>
>>> -Val
>>>
>>> On Fri, Feb 10, 2017 at 5:16 PM, Dmitriy Setrakyan <
>>> dsetrak...@apache.org> wrote:
>>>
>>>> On Thu, Feb 9, 2017 at 11:26 PM, Valentin Kulichenko <
>>>> valentin.kuliche...@gmail.com> wrote:
>>>>
>>>> > Hi Vadim,
>>>> >
>>>> > I don't think it makes much sense to invest into OptimizedMarshaller.
>>>> > However, I would check if this optimization is applicable to
>>>> > BinaryMarshaller, and if yes, implement it.
>>>> >
>>>>
>>>> Val, in this case can you please update the ticket?
>>>>
>>>>
>>>> >
>>>> > -Val
>>>> >
>>>> > On Thu, Feb 9, 2017 at 11:05 PM, Вадим Опольский <
>>>> vaopols...@gmail.com>
>>>> > wrote:
>>>> >
>>>> > > Dear sirs!
>>>> > >
>>>> > > I want to resolve issue IGNITE-13 -
>>>> > > https://issues.apache.org/jira/browse/IGNITE-13
>>>> > >
>>>> > > Is it actual?
>>>> > >
>>>> > > Vadim Opolski
>>>> > >
>>>> >
>>>>
>>>
>>>
>>
>

IGNITE-13

[Вадим Опольский]

Dear sirs!

I want to resolve issue IGNITE-13 -
https://issues.apache.org/jira/browse/IGNITE-13

Is it actual?

Vadim Opolski

IGNITE-13

[Вадим Опольский]

Здравствуйте, коллеги!

Это Опольский Вадим, я недавно в проекте и хочу решить тикет (IGNITE-13).

Детализируйте пожалуйста, что конкретно нужно сделать?

Где в проекте можно посмотреть примеры уже написанных more optimal
marshaling ?

Как сейчас маршализируются строки в проекте? Где описаны существующие
маршаллеры? Где можно про это почитать в документации?


Вадим

Hello

[Вадим Опольский]

Dear sirs!

I'm Vadim Opolskij, Jira user name is javaller. I want to contribute an
ignite project, ticket number is IGNITE-3537.

Vadim Opolskij

Fwd: Ignite ( IGNITE-3537 )

[Вадим Опольский]

Dear sirs!

I'm Vadim Opolskij and I want to resolve ticket  IGNITE-3537 in first time.
 https://issues.apache.org/jira/browse/IGNITE-3537.

Write, please, what I need to do to resolve this ticket? How does data
srtructure connect with transactions.

I think that I have to write a unit tests. Tell me please in which folder I
have to put this tests and which is folder?

Vadim Opolskij

Здравствуйте, коллеги!

Меня зовут Опольский Вадим и я хочу решить тикет ( IGNITE-3537 ) из Вашего
проекта в первый раз.

Детализируйте, пожалуйста, что конкретно нужно сделать? Как data structure
связаны с транзакциями?

Если я правильно понял, нужно написать юнит тесты. Вы не могли бы уточнить
сколько их нужно написать? В какой папке их нужно писать?

Вадим Опольский