AW: [DISCUSS] Updating to a newer Thrift version?

[Christofer Dutz]

Aaaah … ok

That’s an explanation … I did try the build in my branch with 0.18.1 and it 
worked nicely.

Chris


Von: Yuan Tian 
Datum: Montag, 31. Juli 2023 um 14:45
An: dev@iotdb.apache.org 
Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
Hi Chris,

I remember that we tried to upgrade to 0.15.X before, but the performance
declined. I'm not sure about that? Anyone else remember?


Best,
---
Yuan Tian

AW: [DISCUSS] Updating to a newer Thrift version?

[Christofer Dutz]

Hi all,

well … cancel that …
it seems that Thrift 0.18.1 is compiled with newer java versions and we can no 
longer, consume the jar in the Java 8 build.

Chris

Von: Christofer Dutz 
Datum: Montag, 31. Juli 2023 um 15:50
An: dev@iotdb.apache.org 
Betreff: AW: [DISCUSS] Updating to a newer Thrift version?
Aaaah … ok

That’s an explanation … I did try the build in my branch with 0.18.1 and it 
worked nicely.

Chris


Von: Yuan Tian 
Datum: Montag, 31. Juli 2023 um 14:45
An: dev@iotdb.apache.org 
Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
Hi Chris,

I remember that we tried to upgrade to 0.15.X before, but the performance
declined. I'm not sure about that? Anyone else remember?


Best,
---
Yuan Tian

AW: [DISCUSS] Updating to a newer Thrift version?

[Christofer Dutz]

So, inspecting all versions between 0.14.1 and 0.18.1 it turns out 0.17.0 was 
the last one able to be used in Java 8 applications.
I therefore updated my branch to that version.

Chris

Von: Christofer Dutz 
Datum: Montag, 31. Juli 2023 um 15:53
An: dev@iotdb.apache.org 
Betreff: AW: [DISCUSS] Updating to a newer Thrift version?
Hi all,

well … cancel that …
it seems that Thrift 0.18.1 is compiled with newer java versions and we can no 
longer, consume the jar in the Java 8 build.

Chris

Von: Christofer Dutz 
Datum: Montag, 31. Juli 2023 um 15:50
An: dev@iotdb.apache.org 
Betreff: AW: [DISCUSS] Updating to a newer Thrift version?
Aaaah … ok

That’s an explanation … I did try the build in my branch with 0.18.1 and it 
worked nicely.

Chris


Von: Yuan Tian 
Datum: Montag, 31. Juli 2023 um 14:45
An: dev@iotdb.apache.org 
Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
Hi Chris,

I remember that we tried to upgrade to 0.15.X before, but the performance
declined. I'm not sure about that? Anyone else remember?


Best,
---
Yuan Tian

AW: [DISCUSS] Updating to a newer Thrift version?

[Christofer Dutz]

Ok .. and now I know why we’re at 0.14.1.

Turns out 0.17.0 has an issue in its MANIFEST.mf which causes our build to fail.
According to Maven-Central do all older versions till 0.14.1 have known 
vulnerabilities, so we shouldn’t choose any of those.
Turns out that 0.14.1 is the sweet spot where we support Java 8, are able to 
build and don’t inherit any CVEs.

Perhaps we should discuss dropping Java 8 support.

Chris


Von: Christofer Dutz 
Datum: Montag, 31. Juli 2023 um 16:06
An: dev@iotdb.apache.org 
Betreff: AW: [DISCUSS] Updating to a newer Thrift version?
So, inspecting all versions between 0.14.1 and 0.18.1 it turns out 0.17.0 was 
the last one able to be used in Java 8 applications.
I therefore updated my branch to that version.

Chris

Von: Christofer Dutz 
Datum: Montag, 31. Juli 2023 um 15:53
An: dev@iotdb.apache.org 
Betreff: AW: [DISCUSS] Updating to a newer Thrift version?
Hi all,

well … cancel that …
it seems that Thrift 0.18.1 is compiled with newer java versions and we can no 
longer, consume the jar in the Java 8 build.

Chris

Von: Christofer Dutz 
Datum: Montag, 31. Juli 2023 um 15:50
An: dev@iotdb.apache.org 
Betreff: AW: [DISCUSS] Updating to a newer Thrift version?
Aaaah … ok

That’s an explanation … I did try the build in my branch with 0.18.1 and it 
worked nicely.

Chris


Von: Yuan Tian 
Datum: Montag, 31. Juli 2023 um 14:45
An: dev@iotdb.apache.org 
Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
Hi Chris,

I remember that we tried to upgrade to 0.15.X before, but the performance
declined. I'm not sure about that? Anyone else remember?


Best,
---
Yuan Tian

AW: [DISCUSS] Updating to a newer Thrift version?

[Christofer Dutz]

Ok …

So, it turns out that the Thrift folks intentionally updated to Java 11 but 
took that back and the next release should be based on Java 8 again.
So hopefully that will come soon and then we could have a look about 
compatibility of the generated code. I guess if the wire-protocol didn’t change 
there should generally be no reason for it to not be compatible, and if they 
don’t release a major version, usually this compatibility should stay intact 
(if they sort of follow SemVer)

I guess the best path of action would be to do nothing right now … as an 
alternative, we could of course turn on the Java compilation when building 
thrift and to bundle the jar built by that in the assembly.
If we then replace the thrift-lib dependency with a “system” scope dependency, 
we could already do that now. But admittedly I would not be in favor of doing 
that. I would recommend for us to wait for the next official release.

Chris

Von: Christofer Dutz 
Datum: Dienstag, 1. August 2023 um 08:29
An: dev@iotdb.apache.org 
Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
I opened a ticket in their jira. Might even prepare a pr... Shouldn't be too 
difficult.

Chris

Gesendet von Outlook für Android

From: 谭新宇 <1025599...@qq.com.INVALID>
Sent: Monday, July 31, 2023 1:57:28 PM
To: dev@iotdb.apache.org 
Subject: Re: [DISCUSS] Updating to a newer Thrift version?

Hi, Chris

In the latest version of thrift, there are some improvements we'd like to make, 
For example, https://issues.apache.org/jira/browse/THRIFT-5502 will down-cycled 
 "connection reset"  warn logs.

+1 for upgrading thrift.


Thanks

Xinyu Tan

> 2023年7月31日 19:50，Christofer Dutz  写道：
>
> Hi all,
>
> While working on the cleanup of the build, I noticed we’re working with 
> Thrift in version 0.14.1 however the latest version is 0.18.1
>
> Is there a reason we’re sticking to a two-year older version than the newest?
>
> If not: with the pom-cleanup refactoring it should be a thing of minutes to 
> update this.
>
> Chris
>

Re: AW: [DISCUSS] Updating to a newer Thrift version?

[Haonan Hou]

It seems that Thrift 0.19.0 is released and supports Java 8 again. ;-)
https://github.com/apache/thrift/blob/master/CHANGES.md

Best,
Haonan

On 2023/08/04 10:01:39 Christofer Dutz wrote:
> Ok …
> 
> So, it turns out that the Thrift folks intentionally updated to Java 11 but 
> took that back and the next release should be based on Java 8 again.
> So hopefully that will come soon and then we could have a look about 
> compatibility of the generated code. I guess if the wire-protocol didn’t 
> change there should generally be no reason for it to not be compatible, and 
> if they don’t release a major version, usually this compatibility should stay 
> intact (if they sort of follow SemVer)
> 
> I guess the best path of action would be to do nothing right now … as an 
> alternative, we could of course turn on the Java compilation when building 
> thrift and to bundle the jar built by that in the assembly.
> If we then replace the thrift-lib dependency with a “system” scope 
> dependency, we could already do that now. But admittedly I would not be in 
> favor of doing that. I would recommend for us to wait for the next official 
> release.
> 
> Chris
> 
> Von: Christofer Dutz 
> Datum: Dienstag, 1. August 2023 um 08:29
> An: dev@iotdb.apache.org 
> Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
> I opened a ticket in their jira. Might even prepare a pr... Shouldn't be too 
> difficult.
> 
> Chris
> 
> Gesendet von Outlook für Android
> 
> From: 谭新宇 <1025599...@qq.com.INVALID>
> Sent: Monday, July 31, 2023 1:57:28 PM
> To: dev@iotdb.apache.org 
> Subject: Re: [DISCUSS] Updating to a newer Thrift version?
> 
> Hi, Chris
> 
> In the latest version of thrift, there are some improvements we'd like to 
> make, For example, https://issues.apache.org/jira/browse/THRIFT-5502 will 
> down-cycled  "connection reset"  warn logs.
> 
> +1 for upgrading thrift.
> 
> 
> Thanks
> 
> Xinyu Tan
> 
> > 2023年7月31日 19:50，Christofer Dutz  写道：
> >
> > Hi all,
> >
> > While working on the cleanup of the build, I noticed we’re working with 
> > Thrift in version 0.14.1 however the latest version is 0.18.1
> >
> > Is there a reason we’re sticking to a two-year older version than the 
> > newest?
> >
> > If not: with the pom-cleanup refactoring it should be a thing of minutes to 
> > update this.
> >
> > Chris
> >
> 

Re: AW: [DISCUSS] Updating to a newer Thrift version?

[Xiangdong Huang]

Hi,
one more concern, is Thrift v0.19 compatible with Thrift v0.14? (It is
better to be compatible for all IoTDB v1.x. )
---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Haonan Hou  于2023年9月18日周一 18:13写道：

> It seems that Thrift 0.19.0 is released and supports Java 8 again. ;-)
> https://github.com/apache/thrift/blob/master/CHANGES.md
>
> Best,
> Haonan
>
> On 2023/08/04 10:01:39 Christofer Dutz wrote:
> > Ok …
> >
> > So, it turns out that the Thrift folks intentionally updated to Java 11
> but took that back and the next release should be based on Java 8 again.
> > So hopefully that will come soon and then we could have a look about
> compatibility of the generated code. I guess if the wire-protocol didn’t
> change there should generally be no reason for it to not be compatible, and
> if they don’t release a major version, usually this compatibility should
> stay intact (if they sort of follow SemVer)
> >
> > I guess the best path of action would be to do nothing right now … as an
> alternative, we could of course turn on the Java compilation when building
> thrift and to bundle the jar built by that in the assembly.
> > If we then replace the thrift-lib dependency with a “system” scope
> dependency, we could already do that now. But admittedly I would not be in
> favor of doing that. I would recommend for us to wait for the next official
> release.
> >
> > Chris
> >
> > Von: Christofer Dutz 
> > Datum: Dienstag, 1. August 2023 um 08:29
> > An: dev@iotdb.apache.org 
> > Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
> > I opened a ticket in their jira. Might even prepare a pr... Shouldn't be
> too difficult.
> >
> > Chris
> >
> > Gesendet von Outlook für Android
> > 
> > From: 谭新宇 <1025599...@qq.com.INVALID>
> > Sent: Monday, July 31, 2023 1:57:28 PM
> > To: dev@iotdb.apache.org 
> > Subject: Re: [DISCUSS] Updating to a newer Thrift version?
> >
> > Hi, Chris
> >
> > In the latest version of thrift, there are some improvements we'd like
> to make, For example, https://issues.apache.org/jira/browse/THRIFT-5502
> will down-cycled  "connection reset"  warn logs.
> >
> > +1 for upgrading thrift.
> >
> >
> > Thanks
> > 
> > Xinyu Tan
> >
> > > 2023年7月31日 19:50，Christofer Dutz  写道：
> > >
> > > Hi all,
> > >
> > > While working on the cleanup of the build, I noticed we’re working
> with Thrift in version 0.14.1 however the latest version is 0.18.1
> > >
> > > Is there a reason we’re sticking to a two-year older version than the
> newest?
> > >
> > > If not: with the pom-cleanup refactoring it should be a thing of
> minutes to update this.
> > >
> > > Chris
> > >
> >
>

AW: AW: [DISCUSS] Updating to a newer Thrift version?

[Christofer Dutz]

I’m currently preparing the build-tools for 0.19.0.
As soon as that’s done, we could simply build iotdb with 0.19.0.0 and simply 
try it out?
I couldn’t find any info on the binary protocol being changed in the 
release-notes.
But I guess simply trying it out should help.

Chris

Von: Xiangdong Huang 
Datum: Dienstag, 19. September 2023 um 01:50
An: dev@iotdb.apache.org 
Betreff: Re: AW: [DISCUSS] Updating to a newer Thrift version?
Hi,
one more concern, is Thrift v0.19 compatible with Thrift v0.14? (It is
better to be compatible for all IoTDB v1.x. )
---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Haonan Hou  于2023年9月18日周一 18:13写道：

> It seems that Thrift 0.19.0 is released and supports Java 8 again. ;-)
> https://github.com/apache/thrift/blob/master/CHANGES.md
>
> Best,
> Haonan
>
> On 2023/08/04 10:01:39 Christofer Dutz wrote:
> > Ok …
> >
> > So, it turns out that the Thrift folks intentionally updated to Java 11
> but took that back and the next release should be based on Java 8 again.
> > So hopefully that will come soon and then we could have a look about
> compatibility of the generated code. I guess if the wire-protocol didn’t
> change there should generally be no reason for it to not be compatible, and
> if they don’t release a major version, usually this compatibility should
> stay intact (if they sort of follow SemVer)
> >
> > I guess the best path of action would be to do nothing right now … as an
> alternative, we could of course turn on the Java compilation when building
> thrift and to bundle the jar built by that in the assembly.
> > If we then replace the thrift-lib dependency with a “system” scope
> dependency, we could already do that now. But admittedly I would not be in
> favor of doing that. I would recommend for us to wait for the next official
> release.
> >
> > Chris
> >
> > Von: Christofer Dutz 
> > Datum: Dienstag, 1. August 2023 um 08:29
> > An: dev@iotdb.apache.org 
> > Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
> > I opened a ticket in their jira. Might even prepare a pr... Shouldn't be
> too difficult.
> >
> > Chris
> >
> > Gesendet von Outlook für Android<https://aka.ms/AAb9ysg>
> > 
> > From: 谭新宇 <1025599...@qq.com.INVALID>
> > Sent: Monday, July 31, 2023 1:57:28 PM
> > To: dev@iotdb.apache.org 
> > Subject: Re: [DISCUSS] Updating to a newer Thrift version?
> >
> > Hi, Chris
> >
> > In the latest version of thrift, there are some improvements we'd like
> to make, For example, https://issues.apache.org/jira/browse/THRIFT-5502
> will down-cycled  "connection reset"  warn logs.
> >
> > +1 for upgrading thrift.
> >
> >
> > Thanks
> > �D�D�D�D�D�D�D�D�D�D�D�D
> > Xinyu Tan
> >
> > > 2023年7月31日 19:50，Christofer Dutz  写道：
> > >
> > > Hi all,
> > >
> > > While working on the cleanup of the build, I noticed we’re working
> with Thrift in version 0.14.1 however the latest version is 0.18.1
> > >
> > > Is there a reason we’re sticking to a two-year older version than the
> newest?
> > >
> > > If not: with the pom-cleanup refactoring it should be a thing of
> minutes to update this.
> > >
> > > Chris
> > >
> >
>

AW: AW: [DISCUSS] Updating to a newer Thrift version?

[Christofer Dutz]

The repo id of the staged thirft 0.19.0 generator is here:
https://repository.apache.org/content/repositories/orgapacheiotdb-1132

So, adding that repository and switching to:
0.19.0.0

0.19.0

Should do the trick.

Chris

Von: Christofer Dutz 
Datum: Dienstag, 19. September 2023 um 08:50
An: dev@iotdb.apache.org 
Betreff: AW: AW: [DISCUSS] Updating to a newer Thrift version?
I’m currently preparing the build-tools for 0.19.0.
As soon as that’s done, we could simply build iotdb with 0.19.0.0 and simply 
try it out?
I couldn’t find any info on the binary protocol being changed in the 
release-notes.
But I guess simply trying it out should help.

Chris

Von: Xiangdong Huang 
Datum: Dienstag, 19. September 2023 um 01:50
An: dev@iotdb.apache.org 
Betreff: Re: AW: [DISCUSS] Updating to a newer Thrift version?
Hi,
one more concern, is Thrift v0.19 compatible with Thrift v0.14? (It is
better to be compatible for all IoTDB v1.x. )
---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Haonan Hou  于2023年9月18日周一 18:13写道：

> It seems that Thrift 0.19.0 is released and supports Java 8 again. ;-)
> https://github.com/apache/thrift/blob/master/CHANGES.md
>
> Best,
> Haonan
>
> On 2023/08/04 10:01:39 Christofer Dutz wrote:
> > Ok …
> >
> > So, it turns out that the Thrift folks intentionally updated to Java 11
> but took that back and the next release should be based on Java 8 again.
> > So hopefully that will come soon and then we could have a look about
> compatibility of the generated code. I guess if the wire-protocol didn’t
> change there should generally be no reason for it to not be compatible, and
> if they don’t release a major version, usually this compatibility should
> stay intact (if they sort of follow SemVer)
> >
> > I guess the best path of action would be to do nothing right now … as an
> alternative, we could of course turn on the Java compilation when building
> thrift and to bundle the jar built by that in the assembly.
> > If we then replace the thrift-lib dependency with a “system” scope
> dependency, we could already do that now. But admittedly I would not be in
> favor of doing that. I would recommend for us to wait for the next official
> release.
> >
> > Chris
> >
> > Von: Christofer Dutz 
> > Datum: Dienstag, 1. August 2023 um 08:29
> > An: dev@iotdb.apache.org 
> > Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
> > I opened a ticket in their jira. Might even prepare a pr... Shouldn't be
> too difficult.
> >
> > Chris
> >
> > Gesendet von Outlook für Android<https://aka.ms/AAb9ysg>
> > 
> > From: 谭新宇 <1025599...@qq.com.INVALID>
> > Sent: Monday, July 31, 2023 1:57:28 PM
> > To: dev@iotdb.apache.org 
> > Subject: Re: [DISCUSS] Updating to a newer Thrift version?
> >
> > Hi, Chris
> >
> > In the latest version of thrift, there are some improvements we'd like
> to make, For example, https://issues.apache.org/jira/browse/THRIFT-5502
> will down-cycled  "connection reset"  warn logs.
> >
> > +1 for upgrading thrift.
> >
> >
> > Thanks
> > �D�D�D�D�D�D�D�D�D�D�D�D
> > Xinyu Tan
> >
> > > 2023年7月31日 19:50，Christofer Dutz  写道：
> > >
> > > Hi all,
> > >
> > > While working on the cleanup of the build, I noticed we’re working
> with Thrift in version 0.14.1 however the latest version is 0.18.1
> > >
> > > Is there a reason we’re sticking to a two-year older version than the
> newest?
> > >
> > > If not: with the pom-cleanup refactoring it should be a thing of
> minutes to update this.
> > >
> > > Chris
> > >
> >
>

Re: AW: AW: [DISCUSS] Updating to a newer Thrift version?

[Haonan Hou]

Ok, just pushed a branch using the staged thrift 0.19.0 generator.
https://github.com/apache/iotdb/pull/11183

We need to do more tests on it before the upgrading, such as using the old 
client with Thrift 0.14.1 to connect the data node with 0.19.0. Using the old 
data node to connect the config node with new Thrift... 

Best,
Haonan

On 2023/09/19 08:02:57 Christofer Dutz wrote:
> The repo id of the staged thirft 0.19.0 generator is here:
> https://repository.apache.org/content/repositories/orgapacheiotdb-1132
> 
> So, adding that repository and switching to:
> 0.19.0.0
> 
> 0.19.0
> 
> Should do the trick.
> 
> Chris
> 
> Von: Christofer Dutz 
> Datum: Dienstag, 19. September 2023 um 08:50
> An: dev@iotdb.apache.org 
> Betreff: AW: AW: [DISCUSS] Updating to a newer Thrift version?
> I��m currently preparing the build-tools for 0.19.0.
> As soon as that��s done, we could simply build iotdb with 0.19.0.0 and simply 
> try it out?
> I couldn��t find any info on the binary protocol being changed in the 
> release-notes.
> But I guess simply trying it out should help.
> 
> Chris
> 
> Von: Xiangdong Huang 
> Datum: Dienstag, 19. September 2023 um 01:50
> An: dev@iotdb.apache.org 
> Betreff: Re: AW: [DISCUSS] Updating to a newer Thrift version?
> Hi,
> one more concern, is Thrift v0.19 compatible with Thrift v0.14? (It is
> better to be compatible for all IoTDB v1.x. )
> ---
> Xiangdong Huang
> School of Software, Tsinghua University
> 
>  
> �廪��ѧ ѧԺ
> 
> 
> Haonan Hou  ��2023��9��18һ 18:13д
> 
> > It seems that Thrift 0.19.0 is released and supports Java 8 again. ;-)
> > https://github.com/apache/thrift/blob/master/CHANGES.md
> >
> > Best,
> > Haonan
> >
> > On 2023/08/04 10:01:39 Christofer Dutz wrote:
> > > Ok ��
> > >
> > > So, it turns out that the Thrift folks intentionally updated to Java 11
> > but took that back and the next release should be based on Java 8 again.
> > > So hopefully that will come soon and then we could have a look about
> > compatibility of the generated code. I guess if the wire-protocol didn��t
> > change there should generally be no reason for it to not be compatible, and
> > if they don��t release a major version, usually this compatibility should
> > stay intact (if they sort of follow SemVer)
> > >
> > > I guess the best path of action would be to do nothing right now �� as an
> > alternative, we could of course turn on the Java compilation when building
> > thrift and to bundle the jar built by that in the assembly.
> > > If we then replace the thrift-lib dependency with a ��system�� scope
> > dependency, we could already do that now. But admittedly I would not be in
> > favor of doing that. I would recommend for us to wait for the next official
> > release.
> > >
> > > Chris
> > >
> > > Von: Christofer Dutz 
> > > Datum: Dienstag, 1. August 2023 um 08:29
> > > An: dev@iotdb.apache.org 
> > > Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
> > > I opened a ticket in their jira. Might even prepare a pr... Shouldn't be
> > too difficult.
> > >
> > > Chris
> > >
> > > Gesendet von Outlook f��r Android<https://aka.ms/AAb9ysg>
> > > 
> > > From: ̷ <1025599...@qq.com.INVALID>
> > > Sent: Monday, July 31, 2023 1:57:28 PM
> > > To: dev@iotdb.apache.org 
> > > Subject: Re: [DISCUSS] Updating to a newer Thrift version?
> > >
> > > Hi, Chris
> > >
> > > In the latest version of thrift, there are some improvements we'd like
> > to make, For example, https://issues.apache.org/jira/browse/THRIFT-5502
> > will down-cycled  "connection reset"  warn logs.
> > >
> > > +1 for upgrading thrift.
> > >
> > >
> > > Thanks
> > > �D�D�D�D�D�D�D�D�D�D�D�D
> > > Xinyu Tan
> > >
> > > > 2023��7��31�� 19:50��Christofer Dutz  д
> > > >
> > > > Hi all,
> > > >
> > > > While working on the cleanup of the build, I noticed we��re working
> > with Thrift in version 0.14.1 however the latest version is 0.18.1
> > > >
> > > > Is there a reason we��re sticking to a two-year older version than the
> > newest?
> > > >
> > > > If not: with the pom-cleanup refactoring it should be a thing of
> > minutes to update this.
> > > >
> > > > Chris
> > > >
> > >
> >
> 

AW: AW: AW: [DISCUSS] Updating to a newer Thrift version?

[Christofer Dutz]

Hi all,

And if all is good, we could just start a vote on the generator and switch to 
using that.

Chris


Von: Haonan Hou 
Datum: Mittwoch, 20. September 2023 um 16:10
An: dev@iotdb.apache.org 
Betreff: Re: AW: AW: [DISCUSS] Updating to a newer Thrift version?
Ok, just pushed a branch using the staged thrift 0.19.0 generator.
https://github.com/apache/iotdb/pull/11183

We need to do more tests on it before the upgrading, such as using the old 
client with Thrift 0.14.1 to connect the data node with 0.19.0. Using the old 
data node to connect the config node with new Thrift...

Best,
Haonan

On 2023/09/19 08:02:57 Christofer Dutz wrote:
> The repo id of the staged thirft 0.19.0 generator is here:
> https://repository.apache.org/content/repositories/orgapacheiotdb-1132
>
> So, adding that repository and switching to:
> 0.19.0.0
>
> 0.19.0
>
> Should do the trick.
>
> Chris
>
> Von: Christofer Dutz 
> Datum: Dienstag, 19. September 2023 um 08:50
> An: dev@iotdb.apache.org 
> Betreff: AW: AW: [DISCUSS] Updating to a newer Thrift version?
> I��m currently preparing the build-tools for 0.19.0.
> As soon as that��s done, we could simply build iotdb with 0.19.0.0 and simply 
> try it out?
> I couldn��t find any info on the binary protocol being changed in the 
> release-notes.
> But I guess simply trying it out should help.
>
> Chris
>
> Von: Xiangdong Huang 
> Datum: Dienstag, 19. September 2023 um 01:50
> An: dev@iotdb.apache.org 
> Betreff: Re: AW: [DISCUSS] Updating to a newer Thrift version?
> Hi,
> one more concern, is Thrift v0.19 compatible with Thrift v0.14? (It is
> better to be compatible for all IoTDB v1.x. )
> ---
> Xiangdong Huang
> School of Software, Tsinghua University
>
>  
> �廪��ѧ ѧԺ
>
>
> Haonan Hou  ��2023��9��18һ 18:13д
>
> > It seems that Thrift 0.19.0 is released and supports Java 8 again. ;-)
> > https://github.com/apache/thrift/blob/master/CHANGES.md
> >
> > Best,
> > Haonan
> >
> > On 2023/08/04 10:01:39 Christofer Dutz wrote:
> > > Ok ��
> > >
> > > So, it turns out that the Thrift folks intentionally updated to Java 11
> > but took that back and the next release should be based on Java 8 again.
> > > So hopefully that will come soon and then we could have a look about
> > compatibility of the generated code. I guess if the wire-protocol didn��t
> > change there should generally be no reason for it to not be compatible, and
> > if they don��t release a major version, usually this compatibility should
> > stay intact (if they sort of follow SemVer)
> > >
> > > I guess the best path of action would be to do nothing right now �� as an
> > alternative, we could of course turn on the Java compilation when building
> > thrift and to bundle the jar built by that in the assembly.
> > > If we then replace the thrift-lib dependency with a ��system�� scope
> > dependency, we could already do that now. But admittedly I would not be in
> > favor of doing that. I would recommend for us to wait for the next official
> > release.
> > >
> > > Chris
> > >
> > > Von: Christofer Dutz 
> > > Datum: Dienstag, 1. August 2023 um 08:29
> > > An: dev@iotdb.apache.org 
> > > Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
> > > I opened a ticket in their jira. Might even prepare a pr... Shouldn't be
> > too difficult.
> > >
> > > Chris
> > >
> > > Gesendet von Outlook f��r Android<https://aka.ms/AAb9ysg>
> > > 
> > > From: ̷ <1025599...@qq.com.INVALID>
> > > Sent: Monday, July 31, 2023 1:57:28 PM
> > > To: dev@iotdb.apache.org 
> > > Subject: Re: [DISCUSS] Updating to a newer Thrift version?
> > >
> > > Hi, Chris
> > >
> > > In the latest version of thrift, there are some improvements we'd like
> > to make, For example, https://issues.apache.org/jira/browse/THRIFT-5502
> > will down-cycled  "connection reset"  warn logs.
> > >
> > > +1 for upgrading thrift.
> > >
> > >
> > > Thanks
> > > �D�D�D�D�D�D�D�D�D�D�D�D
> > > Xinyu Tan
> > >
> > > > 2023��7��31�� 19:50��Christofer Dutz  д
> > > >
> > > > Hi all,
> > > >
> > > > While working on the cleanup of the build, I noticed we��re working
> > with Thrift in version 0.14.1 however the latest version is 0.18.1
> > > >
> > > > Is there a reason we��re sticking to a two-year older version than the
> > newest?
> > > >
> > > > If not: with the pom-cleanup refactoring it should be a thing of
> > minutes to update this.
> > > >
> > > > Chris
> > > >
> > >
> >
>