[jira] [Commented] (JENA-1090) Add transaction handling convenience code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369301#comment-15369301
 ] 

ASF GitHub Bot commented on JENA-1090:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/153
  
There is markdown documentation to go with this.


> Add transaction handling convenience code
> -
>
> Key: JENA-1090
> URL: https://issues.apache.org/jira/browse/JENA-1090
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: ARQ
>Reporter: Andy Seaborne
>
> The code 
> [Txn|https://github.com/afs/jena-rdfconnection/blob/master/src/main/java/rdfconnection/Txn.java]
>  provides a convenient way to write common patterns of transaction usage 
> including 
> {noformat}
>  Txn.executeWrite(conn, () ->{
>... write transaction code ...
> }) ;
> {noformat}
> which provides the pattern:
> {noformat}
> txn.begin(ReadWrite.WRITE) ;
> try {
> ... write transaction code ...
> txn.commit() ;
> }
>  finally { txn.end() ; }
> {noformat}
> {{Txn}} also checks for being in a transaction already.
> There are forms to return a value from the code inside the transaction block 
> as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] jena issue #153: JENA-1090: Txn - a java8-centric transaction API

[afs]

Github user afs commented on the issue:

https://github.com/apache/jena/pull/153
  
There is markdown documentation to go with this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JENA-1090) Add transaction handling convenience code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369300#comment-15369300
 ] 

ASF GitHub Bot commented on JENA-1090:
--

GitHub user afs opened a pull request:

https://github.com/apache/jena/pull/153

JENA-1090: Txn - a java8-centric transaction API



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afs/jena txn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #153


commit 952aebd0ac8f2d5d590811f0ac97d3c17c9bea5a
Author: Andy Seaborne 
Date:   2016-07-09T21:40:03Z

JENA-1090 : Txn - a java8-centric transaction API

commit 52ff200c2756c9844b4346ffa1bff2a09081b649
Author: Andy Seaborne 
Date:   2016-07-09T21:41:01Z

Merge branch 'master' of https://github.com/apache/jena into txn




> Add transaction handling convenience code
> -
>
> Key: JENA-1090
> URL: https://issues.apache.org/jira/browse/JENA-1090
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: ARQ
>Reporter: Andy Seaborne
>
> The code 
> [Txn|https://github.com/afs/jena-rdfconnection/blob/master/src/main/java/rdfconnection/Txn.java]
>  provides a convenient way to write common patterns of transaction usage 
> including 
> {noformat}
>  Txn.executeWrite(conn, () ->{
>... write transaction code ...
> }) ;
> {noformat}
> which provides the pattern:
> {noformat}
> txn.begin(ReadWrite.WRITE) ;
> try {
> ... write transaction code ...
> txn.commit() ;
> }
>  finally { txn.end() ; }
> {noformat}
> {{Txn}} also checks for being in a transaction already.
> There are forms to return a value from the code inside the transaction block 
> as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] jena pull request #153: JENA-1090: Txn - a java8-centric transaction API

[afs]

GitHub user afs opened a pull request:

https://github.com/apache/jena/pull/153

JENA-1090: Txn - a java8-centric transaction API



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afs/jena txn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #153


commit 952aebd0ac8f2d5d590811f0ac97d3c17c9bea5a
Author: Andy Seaborne 
Date:   2016-07-09T21:40:03Z

JENA-1090 : Txn - a java8-centric transaction API

commit 52ff200c2756c9844b4346ffa1bff2a09081b649
Author: Andy Seaborne 
Date:   2016-07-09T21:41:01Z

Merge branch 'master' of https://github.com/apache/jena into txn




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369268#comment-15369268
 ] 

ASF GitHub Bot commented on JENA-576:
-

Github user ajs6f commented on the issue:

https://github.com/apache/jena/pull/151
  
As I understand it (for what that's worth) `HttpContext` is mostly about 
the idea of a "conversation", so if you've got some kind of session going on, 
or a series of request-response cycles that compose some kind of larger 
stateful activity, `HttpContext` is where you stash that state/context. (E.g. a 
cookie store.) So I guess since we want to provide the kinds of facilities 
needed for SPARQL protocols, and authN is definitely part of that story, maybe 
we would want to provide `HttpContext` as a sidecar param?


> Upgrade Apache HTTP Client to 4.3
> -
>
> Key: JENA-576
> URL: https://issues.apache.org/jira/browse/JENA-576
> Project: Apache Jena
>  Issue Type: Dependency upgrade
>  Components: ARQ
>Affects Versions: Jena 2.11.0
>Reporter: Rob Vesse
>Assignee: Rob Vesse
>Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies 
> on Apache HTTP Client.  Currently we are using 4.2.3 while the latest stable 
> release is actually 4.3.1
> Therefore we should look at upgrading our code to use the latest version 
> which may entail some refactoring since there appears to have been some 
> breaking changes across the minor version bump which users have seen in usage 
> - e.g. 
> https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

[ajs6f]

Github user ajs6f commented on the issue:

https://github.com/apache/jena/pull/151
  
As I understand it (for what that's worth) `HttpContext` is mostly about 
the idea of a "conversation", so if you've got some kind of session going on, 
or a series of request-response cycles that compose some kind of larger 
stateful activity, `HttpContext` is where you stash that state/context. (E.g. a 
cookie store.) So I guess since we want to provide the kinds of facilities 
needed for SPARQL protocols, and authN is definitely part of that story, maybe 
we would want to provide `HttpContext` as a sidecar param?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena issue #149: Jena 1206

[afs]

Github user afs commented on the issue:

https://github.com/apache/jena/pull/149
  
+1 : Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369111#comment-15369111
 ] 

ASF GitHub Bot commented on JENA-576:
-

Github user afs commented on the issue:

https://github.com/apache/jena/pull/151
  
Another thought: Does `HttpContext` with every `HttpClient` usage make an 
sense now?  We now rely on `HttpClient` a lot more and `HttpContext` seems 
mainly for cookies. Maybe, versions of calls with `HttpClient` but without 
`HttpContext` might make sense or might not.


> Upgrade Apache HTTP Client to 4.3
> -
>
> Key: JENA-576
> URL: https://issues.apache.org/jira/browse/JENA-576
> Project: Apache Jena
>  Issue Type: Dependency upgrade
>  Components: ARQ
>Affects Versions: Jena 2.11.0
>Reporter: Rob Vesse
>Assignee: Rob Vesse
>Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies 
> on Apache HTTP Client.  Currently we are using 4.2.3 while the latest stable 
> release is actually 4.3.1
> Therefore we should look at upgrading our code to use the latest version 
> which may entail some refactoring since there appears to have been some 
> breaking changes across the minor version bump which users have seen in usage 
> - e.g. 
> https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

[afs]

Github user afs commented on the issue:

https://github.com/apache/jena/pull/151
  
Another thought: Does `HttpContext` with every `HttpClient` usage make an 
sense now?  We now rely on `HttpClient` a lot more and `HttpContext` seems 
mainly for cookies. Maybe, versions of calls with `HttpClient` but without 
`HttpContext` might make sense or might not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369109#comment-15369109
 ] 

ASF GitHub Bot commented on JENA-576:
-

Github user ajs6f commented on the issue:

https://github.com/apache/jena/pull/151
  
I'm not totally clear about the style for `CloseableHttpClient`, either. 
I'll poke around and see if I can get a better reading on that. And I'll start 
jotting up some docs.


> Upgrade Apache HTTP Client to 4.3
> -
>
> Key: JENA-576
> URL: https://issues.apache.org/jira/browse/JENA-576
> Project: Apache Jena
>  Issue Type: Dependency upgrade
>  Components: ARQ
>Affects Versions: Jena 2.11.0
>Reporter: Rob Vesse
>Assignee: Rob Vesse
>Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies 
> on Apache HTTP Client.  Currently we are using 4.2.3 while the latest stable 
> release is actually 4.3.1
> Therefore we should look at upgrading our code to use the latest version 
> which may entail some refactoring since there appears to have been some 
> breaking changes across the minor version bump which users have seen in usage 
> - e.g. 
> https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

[ajs6f]

Github user ajs6f commented on the issue:

https://github.com/apache/jena/pull/151
  
I'm not totally clear about the style for `CloseableHttpClient`, either. 
I'll poke around and see if I can get a better reading on that. And I'll start 
jotting up some docs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JENA-576) Upgrade Apache HTTP Client to 4.3

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369100#comment-15369100
 ] 

ASF GitHub Bot commented on JENA-576:
-

Github user afs commented on the issue:

https://github.com/apache/jena/pull/151
  
I haven't got my head around the new API yet - this is just a preliminary 
comment.

It is a bit of a change around authentication but I think it is the right 
thing to do.  It seems to me that the only other choice is not to migrate to 
the new API which over time will become a nuisance.

Documenting the migration (for the release notes) will be helpful - maybe 
an example for user/password in the HttpOp class javadoc. If someone can grok 
that, they can see how to migrate their own code.

One thought - it looks like the new style is to treat `CloseableHttpClient` 
as a one time use object. That means a try-resource in `HttpOp.exec`.  I'm not 
sure how widespread this is. `getDefaultHttpClient` `setDefaultHttpClient` 
should be changed to be a `HttpClientBuilder`?



> Upgrade Apache HTTP Client to 4.3
> -
>
> Key: JENA-576
> URL: https://issues.apache.org/jira/browse/JENA-576
> Project: Apache Jena
>  Issue Type: Dependency upgrade
>  Components: ARQ
>Affects Versions: Jena 2.11.0
>Reporter: Rob Vesse
>Assignee: Rob Vesse
>Priority: Minor
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies 
> on Apache HTTP Client.  Currently we are using 4.2.3 while the latest stable 
> release is actually 4.3.1
> Therefore we should look at upgrading our code to use the latest version 
> which may entail some refactoring since there appears to have been some 
> breaking changes across the minor version bump which users have seen in usage 
> - e.g. 
> https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] jena issue #151: JENA-576: Moving away from deprecated HttpCommons Client AP...

[afs]

Github user afs commented on the issue:

https://github.com/apache/jena/pull/151
  
I haven't got my head around the new API yet - this is just a preliminary 
comment.

It is a bit of a change around authentication but I think it is the right 
thing to do.  It seems to me that the only other choice is not to migrate to 
the new API which over time will become a nuisance.

Documenting the migration (for the release notes) will be helpful - maybe 
an example for user/password in the HttpOp class javadoc. If someone can grok 
that, they can see how to migrate their own code.

One thought - it looks like the new style is to treat `CloseableHttpClient` 
as a one time use object. That means a try-resource in `HttpOp.exec`.  I'm not 
sure how widespread this is. `getDefaultHttpClient` `setDefaultHttpClient` 
should be changed to be a `HttpClientBuilder`?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (JENA-1158) Provide unionDefaultGraph for all graphs.

[Andy Seaborne (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JENA-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1158.
-
   Resolution: Fixed
 Assignee: Andy Seaborne
Fix Version/s: Jena 3.1.1

> Provide unionDefaultGraph for all graphs.
> -
>
> Key: JENA-1158
> URL: https://issues.apache.org/jira/browse/JENA-1158
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: ARQ
>Affects Versions: Jena 3.0.1
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
> Fix For: Jena 3.1.1
>
>
> Provide "unionDefaultGraph" for all graphs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JENA-1158) Provide unionDefaultGraph for all graphs.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369037#comment-15369037
 ] 

ASF GitHub Bot commented on JENA-1158:
--

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/152


> Provide unionDefaultGraph for all graphs.
> -
>
> Key: JENA-1158
> URL: https://issues.apache.org/jira/browse/JENA-1158
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: ARQ
>Affects Versions: Jena 3.0.1
>Reporter: Andy Seaborne
>
> Provide "unionDefaultGraph" for all graphs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] jena pull request #152: JENA-1158: Union default graph

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JENA-1158) Provide unionDefaultGraph for all graphs.

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JENA-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369036#comment-15369036
 ] 

ASF subversion and git services commented on JENA-1158:
---

Commit 9ddfccac29b4d7dbc17c920035045846b38523cc in jena's branch 
refs/heads/master from [~andy.seaborne]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=9ddfcca ]

JENA-1158: union default graph tests and clearup.

> Provide unionDefaultGraph for all graphs.
> -
>
> Key: JENA-1158
> URL: https://issues.apache.org/jira/browse/JENA-1158
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: ARQ
>Affects Versions: Jena 3.0.1
>Reporter: Andy Seaborne
>
> Provide "unionDefaultGraph" for all graphs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)