[jira] [Commented] (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019016#comment-16019016 ] Jan Høydahl commented on SOLR-2288: --- This was committed for 4.0, please resolve as fixed. > clean up compiler warnings > -- > > Key: SOLR-2288 > URL: https://issues.apache.org/jira/browse/SOLR-2288 > Project: Solr > Issue Type: Improvement >Reporter: Hoss Man >Assignee: Hoss Man > Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch > > > there's a ton of compiler warning in the solr tree, and it's high time we > cleaned them up, or annotate them to be suppressed so we can start making a > bigger stink when/if code is added to the tree thta produces warnings (we'll > never do a good job of noticing new warnings when we have ~175 existing ones) > Using this issue to track related commits > The goal of this issue should not be to change any functionality or APIs, > just deal with each warning in the most appropriate way; > * fix generic declarations > * add SuppressWarning anotation if it's safe in context -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979188#action_12979188 ] Hoss Man commented on SOLR-2288: Reminder to self: feedback from rmuir on the mailing list to replace the static EMPTY set/map refs w/type info that i added with direct usage like this... - this(fieldName, fieldType, analyzer, EMPTY_STRING_SET); + this(fieldName, fieldType, analyzer, Collections.StringemptySet()); clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Assignee: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979022#action_12979022 ] Hoss Man commented on SOLR-2288: In the absence of any direct object to the approach taken in my initial patch (i even solicited feedback from the generics policeman multiple times on IRC over the past few weeks) I went ahead and commited to trunk... Committed revision 1056558. as mentioned before, i'm going continue on with similar easy fixes around the tree w/o bothering to post patches to jira -- we can use CTR if anyone has concerns about specific changes. eventually i'd like to try and port some of this to 3x, but that's a lower priority clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979047#action_12979047 ] Hoss Man commented on SOLR-2288: Committed revision 1056578. clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Assignee: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979063#action_12979063 ] Hoss Man commented on SOLR-2288: Committed revision 1056594. clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Assignee: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979067#action_12979067 ] Hoss Man commented on SOLR-2288: Committed revision 1056595. clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Assignee: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979081#action_12979081 ] Hoss Man commented on SOLR-2288: Committed revision 1056612. clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Assignee: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12973791#action_12973791 ] Hoss Man commented on SOLR-2288: bq. can we just use: NamedList? rather then bind it explicitly to Object? i *think* in the changes i made so far i used ? every place i could. Binding to ? is appropriate when you don't care what the typevar is, but Object is what you have to use when you know you are dealing with a collection of heterogenous objects -- which is many uses of NamedList. in the cases where the code was dealing with a NamedList of homogeneous objects, i used the specific homogeneous type (ie: NamedListNamedListString) That said: there certainly may be places where i could have used NamedList? and didn't realize it. clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972107#action_12972107 ] Hoss Man commented on SOLR-2288: Robert: as mentioned, i'm trying to keep a narrow focus on this issue: dealing with warnings that can be cleaned up w/o changing functionality... bq. The goal of this issue should not be to change any functionality or APIs, just deal with each warning ...can we please confine discusions of changing the implementation of NamedList (or any other classes) to distinct issues? like SOLR-912? clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972108#action_12972108 ] Robert Muir commented on SOLR-2288: --- bq. Robert: as mentioned, i'm trying to keep a narrow focus on this issue: dealing with warnings that can be cleaned up w/o changing functionality... Ok but i didnt change the functionality? the functionality is the same, just the implementation is different. This is the root cause of most of the compiler warnings, let's not dodge the issue. clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972114#action_12972114 ] Hoss Man commented on SOLR-2288: bq. just the implementation is different. fair enough -- i ment i was trying to avoid changes to either the APIs or the internals, just focusing on the quick wins that were easy to review at a glance and shouldn't affect the bytecode (CollectionObject instead of Collection; etc...) I don't expect that *all* compiler warnings can be dealt with using trivial patches, but that's what i was trying to focus on in this issue. changes to the internals of specific classes seem like they should be tracked in distinct issues with more visibility clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972116#action_12972116 ] Ryan McKinley commented on SOLR-2288: - For compiler warnings... without chaning the API, can we just use: NamedList? rather then bind it explicitly to Object? clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] Commented: (SOLR-2288) clean up compiler warnings
[ https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972121#action_12972121 ] Robert Muir commented on SOLR-2288: --- Separately, i just want to say the following about NamedList: All uses of this API should really be reviewed. I'm quite aware that it warns you about the fact that its slow for certain operations, but in my opinion these slow operations such as get(String, int) should be deprecated and removed. Any users that are using NamedList in this way, especially in loops, are very likely using the wrong datastructure. clean up compiler warnings -- Key: SOLR-2288 URL: https://issues.apache.org/jira/browse/SOLR-2288 Project: Solr Issue Type: Improvement Reporter: Hoss Man Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch there's a ton of compiler warning in the solr tree, and it's high time we cleaned them up, or annotate them to be suppressed so we can start making a bigger stink when/if code is added to the tree thta produces warnings (we'll never do a good job of noticing new warnings when we have ~175 existing ones) Using this issue to track related commits The goal of this issue should not be to change any functionality or APIs, just deal with each warning in the most appropriate way; * fix generic declarations * add SuppressWarning anotation if it's safe in context -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
