[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Sean Owen (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116326#comment-14116326
 ] 

Sean Owen commented on MAHOUT-1610:
---

I have seen failures like this in Spark before. I think this is something that 
was perhaps partly fixed in upcoming 1.1.0, if I remember correctly. It's a 
Spark issue AFAICT.

> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
> Fix For: 1.0
>
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Dmitriy Lyubimov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116102#comment-14116102
 ] 

Dmitriy Lyubimov commented on MAHOUT-1610:
--

it seems to be Spark (spurious) failure, unable to open broadcast variable
handle. It would be nice to understand more why it happened, either we are
doing something wrong causing something to race, or it is something bad
with this version of Spark (or even build host setup?) causing this.

It is unlikely though it is our unit test setup, as we basically just
ripped it off unit testing in Spark. We are also not running any parallel
sessions here.

I think (but not sure) i saw it happened once before after we switched to
1.0, perhaps in my local runs, but never once we were on 0.9.

Sean, or anyone else, if you have any thoughts I'd appreciate sharing.





> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
> Fix For: 1.0
>
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116100#comment-14116100
 ] 

ASF GitHub Bot commented on MAHOUT-1610:


Github user dlyubimov commented on the pull request:

https://github.com/apache/mahout/pull/46#issuecomment-53942759
  
`- dssvd - the naive-est - q=0
1 [Executor task launch worker-1] ERROR org.apache.spark.executor.Executor  
- Exception in task ID 52
java.io.FileNotFoundException: http://67.195.81.155:38091/broadcast_4
at 
sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1457)
at 
org.apache.spark.broadcast.HttpBroadcast$.read(HttpBroadcast.scala:196)
at 
org.apache.spark.broadcast.HttpBroadcast.readObject(HttpBroadcast.scala:89)
at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)`


not sure what may be causing this.


> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
> Fix For: 1.0
>
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Dmitriy Lyubimov]

it seems to be Spark (spurious) failure, unable to open broadcast variable
handle. It would be nice to understand more why it happened, either we are
doing something wrong causing something to race, or it is something bad
with this version of Spark (or even build host setup?) causing this.

It is unlikely though it is our unit test setup, as we basically just
ripped it off unit testing in Spark. We are also not running any parallel
sessions here.

I think (but not sure) i saw it happened once before after we switched to
1.0, perhaps in my local runs, but never once we were on 0.9.

Sean, or anyone else, if you have any thoughts I'd appreciate sharing.


On Thu, Aug 28, 2014 at 10:57 PM, Sean Owen (JIRA)  wrote:

>
> [
> https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114893#comment-14114893
> ]
>
> Sean Owen commented on MAHOUT-1610:
> ---
>
> I forgot to modify CHANGELOG, so fixed that in an extra commit. The
> original Hudson tests passed, so I can only assume this change to just the
> CHANGELOG file can't have broken something, and that this is a spurious
> failure.
>
> > Tests can be made more robust to pass in Java 8
> > ---
> >
> > Key: MAHOUT-1610
> > URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> > Project: Mahout
> >  Issue Type: Bug
> >  Components: Integration
> >Affects Versions: 0.9
> > Environment: Java 1.8.0_11 OS X 10.9.4
> >Reporter: Sean Owen
> >Assignee: Sean Owen
> >Priority: Minor
> >  Labels: java8, tests
> > Fix For: 1.0
> >
> >
> > Right now, several tests don't seem to pass when run with Java 8 (at
> least on Java 8). The failures are benign, and just due to tests looking
> for too-specific values or expecting things like a certain ordering of
> hashmaps.
> > The tests can easily be made to pass both Java 8 and Java 6/7 at the
> same time by either relaxing the tests in a principled way, or accepting
> either output of two equally valid ones as correct.
> > (There's also one curious compilation failure in Java 8, related to
> generics. It is fixable by changing to a more explicit declaration that
> should be equivalent. It should be entirely equivalent at compile time, and
> of course, at run time. I am not sure it's not just a javac bug, but, might
> as well work around when it's so easy.)
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)
>

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Sean Owen (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114893#comment-14114893
 ] 

Sean Owen commented on MAHOUT-1610:
---

I forgot to modify CHANGELOG, so fixed that in an extra commit. The original 
Hudson tests passed, so I can only assume this change to just the CHANGELOG 
file can't have broken something, and that this is a spurious failure.

> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
> Fix For: 1.0
>
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114885#comment-14114885
 ] 

Hudson commented on MAHOUT-1610:


FAILURE: Integrated in Mahout-Quality #2771 (See 
[https://builds.apache.org/job/Mahout-Quality/2771/])
MAHOUT-1610 addendum: add CHANGELOG note (srowen: rev 
d9e26c64d620d723c94386e1a5ef9e70588c31a3)
* CHANGELOG


> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
> Fix For: 1.0
>
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113985#comment-14113985
 ] 

Hudson commented on MAHOUT-1610:


SUCCESS: Integrated in Mahout-Quality #2766 (See 
[https://builds.apache.org/job/Mahout-Quality/2766/])
MAHOUT-1610 Update tests to pass in Java 8; closes apache/mahout#46 (srowen: 
rev 91f15ecfe5d26de36d8e9bcd6cf109b307882a32)
* 
mrlegacy/src/test/java/org/apache/mahout/classifier/df/tools/VisualizerTest.java
* math/src/test/java/org/apache/mahout/math/random/MultinomialTest.java
* mrlegacy/src/test/java/org/apache/mahout/clustering/TestClusterInterface.java
* mrlegacy/src/test/java/org/apache/mahout/common/StringUtilsTest.java
* mrlegacy/src/main/java/org/apache/mahout/clustering/ClusteringUtils.java
* integration/src/test/resources/expected-arff-schema-2.json
* integration/src/test/resources/expected-arff-dictionary-2.csv
* mrlegacy/src/test/java/org/apache/mahout/classifier/df/DecisionForestTest.java
* mrlegacy/src/test/java/org/apache/mahout/classifier/df/data/DatasetTest.java
* integration/src/test/java/org/apache/mahout/utils/vectors/arff/DriverTest.java


> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
> Fix For: 1.0
>
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Dmitriy Lyubimov]

Including PRs that may happen on private company github branches to private
code once public master is merged to them. Such is unfortunate workings of
github. So please don't.


On Thu, Aug 28, 2014 at 9:52 AM, Dmitriy Lyubimov  wrote:

>
>
>
> On Thu, Aug 28, 2014 at 9:48 AM, Ted Dunning 
> wrote:
>
>>
>> If you do the commit with the github note "closes #xx", then github does
>> the right thing.  Your commit does the merge.
>>
>
> This is a bad advice.  Please always use github repo specified. it needs
> to say "closes apache/mahout #xx" since just "closes #xx" also closess ALL
> PRs in all collaborator's branches that just happen to have the same
> ordinal number. as experienced first hand.
>
>

Re: [jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Dmitriy Lyubimov]

On Thu, Aug 28, 2014 at 9:48 AM, Ted Dunning  wrote:

>
> If you do the commit with the github note "closes #xx", then github does
> the right thing.  Your commit does the merge.
>

This is a bad advice.  Please always use github repo specified. it needs to
say "closes apache/mahout #xx" since just "closes #xx" also closess ALL PRs
in all collaborator's branches that just happen to have the same ordinal
number. as experienced first hand.

Re: [jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Ted Dunning]

On Thu, Aug 28, 2014 at 6:04 AM, ASF GitHub Bot (JIRA) 
wrote:

> Github user srowen commented on the pull request:
>
> https://github.com/apache/mahout/pull/46#issuecomment-53716190
>
> I may still have the commit bit for ASF git, but can't merge the pull
> request myself. (I also realize I'm not yet sure if there's another step?
> will asfbot merge back to ASF git if merged here?)
>

If you do the commit with the github note "closes #xx", then github does
the right thing.  Your commit does the merge.

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113938#comment-14113938
 ] 

ASF GitHub Bot commented on MAHOUT-1610:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/46


> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
> Fix For: 1.0
>
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113918#comment-14113918
 ] 

ASF GitHub Bot commented on MAHOUT-1610:


Github user dlyubimov commented on the pull request:

https://github.com/apache/mahout/pull/46#issuecomment-53748236
  
I meant the PR doc. Strictly in my opinion, since original versions  stuff
has been added that was not strictly to the point and makes read longer and
therefore harder than it needs be.


On Thu, Aug 28, 2014 at 9:14 AM, Sean Owen  wrote:

> Ah right, should have RTFM. Thanks! When you say "beyond what's needed"
> were you commenting on the PR, or on the docs? Just checking whether you
> meant you wanted to discuss the change more.
>
> —
> Reply to this email directly or view it on GitHub
> .
>


> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113913#comment-14113913
 ] 

ASF GitHub Bot commented on MAHOUT-1610:


Github user srowen commented on the pull request:

https://github.com/apache/mahout/pull/46#issuecomment-53746682
  
Ah right, should have RTFM. Thanks! When you say "beyond what's needed" 
were you commenting on the PR, or on the docs? Just checking whether you meant 
you wanted to discuss the change more. 


> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113907#comment-14113907
 ] 

ASF GitHub Bot commented on MAHOUT-1610:


Github user dlyubimov commented on the pull request:

https://github.com/apache/mahout/pull/46#issuecomment-53745490
  
> may still have the commit bit for ASF git, but can't merge the pull 
request myself
Thanks, Sean. 

Yes, you can merge. A bit exploded beyond what's needed IMO but still 
useful [1]. Also, it works best if master is first merged to the PR branch and 
conflicts, if any, resolved there, so when you `--squash` stuff to master, you 
don't have to worry about conflicts on top of everything else. Hope this helps.

[1] http://mahout.apache.org/developers/github.html




> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113724#comment-14113724
 ] 

ASF GitHub Bot commented on MAHOUT-1610:


Github user srowen commented on the pull request:

https://github.com/apache/mahout/pull/46#issuecomment-53716190
  
I may still have the commit bit for ASF git, but can't merge the pull 
request myself. (I also realize I'm not yet sure if there's another step? will 
asfbot merge back to ASF git if merged here?)

Anyone who can merge this is welcome to do so!


> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[Ted Dunning (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112304#comment-14112304
 ] 

Ted Dunning commented on MAHOUT-1610:
-

Looks good to me.

> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (MAHOUT-1610) Tests can be made more robust to pass in Java 8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112290#comment-14112290
 ] 

ASF GitHub Bot commented on MAHOUT-1610:


GitHub user srowen opened a pull request:

https://github.com/apache/mahout/pull/46

MAHOUT-1610 [TESTS] Update tests to pass in Java 8

Right now, several tests don't seem to pass when run with Java 8 (at least 
on Java 8). The failures are benign, and just due to tests looking for 
too-specific values or expecting things like a certain ordering of hashmaps.

The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
time by either relaxing the tests in a principled way, or accepting either 
output of two equally valid ones as correct.

(There's also one curious compilation failure in Java 8, related to 
generics. It is fixable by changing to a more explicit declaration that should 
be equivalent. It should be entirely equivalent at compile time, and of course, 
at run time. I am not sure it's not just a javac bug, but, might as well work 
around when it's so easy.)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srowen/mahout MAHOUT-1610

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #46


commit 4ac89f32e5b76b73d7d11d05739229de51d189f6
Author: Sean Owen 
Date:   2014-08-27T14:30:36Z

Update tests to pass in Java 8




> Tests can be made more robust to pass in Java 8
> ---
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
>  Issue Type: Bug
>  Components: Integration
>Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
>Reporter: Sean Owen
>Assignee: Sean Owen
>Priority: Minor
>  Labels: java8, tests
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)