Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/07/16 um 01:23 schrieb Christian Schulte:
> And then there is this MNG-NOT-YET-FILED-BY-ME





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/06/16 um 23:49 schrieb Christian Schulte:
> 
> I'll take a closer look at the project tomorrow. Could be it's the
> Aether bug I mentioned in that other mail which got reverted and makes
> the project build again. That would mean the project really should not
> build and error out but does not, because there is a bug in Aether.
> 
> Regards,
> 

That's the situation making me think: Ship all of this together in one
release. Cause, there also is
 waiting to be shipped
and that also has a noticable impact.
()
And then there is  also
having a noticable impact
().
And then there is this MNG-NOT-YET-FILED-BY-ME about splitting
"application" and "test" classpaths completely superceding MNG-5988. We
cannot ship things like these one after the other.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Enquiry MNG-5457 - show repository id when downloading

[Rajiv Jain]

Hi

I have recently joined to Apache and would like to contribute. I have singed 
the ICLA and this has been filled.

I would like to work on MNG-5457 but require some help, as this is my first 
ticket within Apache. Could you please help?

I have checked out the current development branch (master) from GitHub by 
forking out the Apache Maven mirror. I can see a class called 
ConsoleTransferListener.java that I believe the change needs to be applied to 
(in TransferResource). I believe the TransferResource is from the Eclipse 
source code. Will I need to make checkout the Eclipse source code and make 
changes within this class, in order to implement this functionality. However, 
the ConsoleTransferListener.java is in within src/test/java. Any ideas why this 
is located here? Am I looking in the correct part of the code?

I hope to hear positively from you soon.

Thanks.

Regards,
Rajiv


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/06/16 um 23:40 schrieb Stuart McCulloch:
> On Wednesday, 6 July 2016 at 22:17, Christian Schulte wrote:
>> Am 07/06/16 um 23:08 schrieb Stuart McCulloch:
>>> On Wednesday, 6 July 2016 at 21:53, Christian Schulte wrote:
 Am 07/06/16 um 22:21 schrieb Ralph Goers:
> This is an interesting situation. The classes that use Jackson are all 
> considered optional in Log4j, so having optional set to true is indeed 
> what is desired. However, we require those dependencies to compile and to 
> run the unit tests. With scope set to test I would expect that the 
> non-test classes that need them would fail to compile. So it sounds like 
> we have to make sure all transitive dependencies needed for testing are 
> also specified with optional set to true?
>  
> Ralph
>  
  
  
 Not sure I understand the situation correctly. If the scope is set to
 test, it's not available in any other scope than test. Could you please
 point me at the POM in question? So I can 'mvn compile' that project
 successfully and you would expect it to not compile due to some optional
 transitive dependency?
  
  
  
>>>  
>>>  
>>> Hi Christian,
>>>  
>>> Gary posted a link to the build in his original post.
>>>  
>>> Basically at the moment it has a dependencyManagement section in the 
>>> top-level pom that declares various jackson dependencies as optional, 
>>> including jackson-module-jaxb-annotations. The log4j-core sub-project 
>>> declares a direct dependency to jackson-dataformat-xml with compile scope, 
>>> marked as optional (also note that jackson-module-jaxb-annotations is a 
>>> transitive dependency of jackson-dataformat-xml).
>>>  
>>> With the fix for MNG-5227 the transitive dependency to 
>>> jackson-module-jaxb-annotations is managed as optional and is removed from 
>>> the compile and test classpath. Because the code doesn’t directly depend on 
>>> jackson-module-jaxb-annotations then it compiles ok. However, the tests 
>>> fail because both jackson-dataformat-xml and 
>>> jackson-module-jaxb-annotations are needed at test time.
>>>  
>>> Without the fix for MNG-5227 the optional flags in the dependencyManagement 
>>> section are ignored, and jackson-module-jaxb-annotations is included on the 
>>> compile and test classpath (because the optional jackson-dataformat-xml 
>>> dependency is selected and jackson-module-jaxb-annotations is now seen as a 
>>> non-optional transitive dependency of jackson-dataformat-xml).
>> Ok. That's MNG-5935.
>>  
>>  
> 
> But also related to MNG-5227 right?  Since the build fails with the old maven 
> snapshot that had the fix for MNG-5227 (and the fix for MNG-5935) but passes 
> with the more recent snapshot where MNG-5227 was reverted (but still contains 
> the fix for MNG-5935)

I'll take a closer look at the project tomorrow. Could be it's the
Aether bug I mentioned in that other mail which got reverted and makes
the project build again. That would mean the project really should not
build and error out but does not, because there is a bug in Aether.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

[Christian Schulte]

Am 07/06/16 um 23:32 schrieb Christian Schulte:
> Am 07/06/16 um 23:19 schrieb Christian Schulte:
>> Am 07/06/16 um 22:41 schrieb Stuart McCulloch:
>>> On Wednesday, 6 July 2016 at 20:46, Karl Heinz Marbaise wrote:
 Hi to all Maven users,
  
 If you like to help making the next Maven release better it would be  
 nice if you could help a little bit.
  
 Please be aware of this *** This is not an official release ***
  
 I have created downloadable packages which are available from here:
  
 Windows: https://s.apache.org/qDs1
 Linux/Mac: https://s.apache.org/Sn7X
  
 Every kind of feedback is helpful.
  
 Important hint:
  
 Based on the following issue  
 https://issues.apache.org/jira/browse/MNG-5227 the optional flag in a  
 dependencyManagement was simply ignored with previous Maven versions.  
 This Maven version starts to handle that correct. If you have problems  
 with that please report.
  
  
>>>
>>> I believe this build (git hash 227085283b6379038ec16f4cf9ad2e8869cef694) 
>>> doesn’t actually contain the fix for MNG-5227. The previous testing 
>>> snapshot built from 644ac9c40ad41bf61e3b099918af33b8eb950621 did contain 
>>> the fix for MNG-5227, but the fix was reverted to avoid breaking builds 
>>> which relied on the old behaviour.
>>>
>>> (this is just based on my reading of the commit history)  
>>
>> There is MNG-5935 which is fixed and has an impact on the optional flag
>> in dependency management. See this commit and its message.
>> 
>> and there is MNG-5227 which has an impact on the optional flag in
>> dependency management. See this commit and its message.
>> .
>> Someone on dev@ has reported that he is using the optional flag in
>> dependency management (setting it to true) and that he has noticed that
>> this starts working in 3.4-SNAPSHOT for him. I haven't asked if he
>> noticed it is not working before. What is important to know is that
>> before the fix for MNG-5935 all managed dependencies were implicitly
>> managing optional to false. Aether got updated to change the optional
>> flag from 'boolean' to 'Boolean' and Maven has not been updated to
>> reflect that. So instead of passing 'null' to Aether, it passed 'false'
>> meaning 'manage the optional flag to false' where it should have passed
>> 'null' meaning 'do not manage the optional flag in any way'.
>>
> 
> To confuse everyone even more. The first 3.4-SNAPSHOT we asked users to
> test contained an Aether bugfix. That bugfix has lead to reports about
> missing 'test' dependencies. See this commit and it's message
> 
> and the description in the bugtracker
> .
> That bugfix has been reverted in 3.4 but will re-appear as soon as we
> update Aether which contains that bugfix correctly.
> 
> Regards,
> 


Long drum-roll here.

What we were discussing on users@ was how we are going to ship bugfixes
like these to the users. Either they will notice something has not
worked before and starts working or they will not notice anything and
just complain the build is no longer working as before. And we cannot
revert things like these for eternity.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Stuart McCulloch]

On Wednesday, 6 July 2016 at 22:17, Christian Schulte wrote:
> Am 07/06/16 um 23:08 schrieb Stuart McCulloch:
> > On Wednesday, 6 July 2016 at 21:53, Christian Schulte wrote:
> > > Am 07/06/16 um 22:21 schrieb Ralph Goers:
> > > > This is an interesting situation. The classes that use Jackson are all 
> > > > considered optional in Log4j, so having optional set to true is indeed 
> > > > what is desired. However, we require those dependencies to compile and 
> > > > to run the unit tests. With scope set to test I would expect that the 
> > > > non-test classes that need them would fail to compile. So it sounds 
> > > > like we have to make sure all transitive dependencies needed for 
> > > > testing are also specified with optional set to true?
> > > >  
> > > > Ralph
> > > >  
> > >  
> > >  
> > > Not sure I understand the situation correctly. If the scope is set to
> > > test, it's not available in any other scope than test. Could you please
> > > point me at the POM in question? So I can 'mvn compile' that project
> > > successfully and you would expect it to not compile due to some optional
> > > transitive dependency?
> > >  
> > >  
> > >  
> >  
> >  
> > Hi Christian,
> >  
> > Gary posted a link to the build in his original post.
> >  
> > Basically at the moment it has a dependencyManagement section in the 
> > top-level pom that declares various jackson dependencies as optional, 
> > including jackson-module-jaxb-annotations. The log4j-core sub-project 
> > declares a direct dependency to jackson-dataformat-xml with compile scope, 
> > marked as optional (also note that jackson-module-jaxb-annotations is a 
> > transitive dependency of jackson-dataformat-xml).
> >  
> > With the fix for MNG-5227 the transitive dependency to 
> > jackson-module-jaxb-annotations is managed as optional and is removed from 
> > the compile and test classpath. Because the code doesn’t directly depend on 
> > jackson-module-jaxb-annotations then it compiles ok. However, the tests 
> > fail because both jackson-dataformat-xml and 
> > jackson-module-jaxb-annotations are needed at test time.
> >  
> > Without the fix for MNG-5227 the optional flags in the dependencyManagement 
> > section are ignored, and jackson-module-jaxb-annotations is included on the 
> > compile and test classpath (because the optional jackson-dataformat-xml 
> > dependency is selected and jackson-module-jaxb-annotations is now seen as a 
> > non-optional transitive dependency of jackson-dataformat-xml).
> Ok. That's MNG-5935.
>  
>  

But also related to MNG-5227 right?  Since the build fails with the old maven 
snapshot that had the fix for MNG-5227 (and the fix for MNG-5935) but passes 
with the more recent snapshot where MNG-5227 was reverted (but still contains 
the fix for MNG-5935)
>  
>  
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org 
> (mailto:dev-unsubscr...@maven.apache.org)
> For additional commands, e-mail: dev-h...@maven.apache.org 
> (mailto:dev-h...@maven.apache.org)
>  
>  

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

[Christian Schulte]

Am 07/06/16 um 23:19 schrieb Christian Schulte:
> Am 07/06/16 um 22:41 schrieb Stuart McCulloch:
>> On Wednesday, 6 July 2016 at 20:46, Karl Heinz Marbaise wrote:
>>> Hi to all Maven users,
>>>  
>>> If you like to help making the next Maven release better it would be  
>>> nice if you could help a little bit.
>>>  
>>> Please be aware of this *** This is not an official release ***
>>>  
>>> I have created downloadable packages which are available from here:
>>>  
>>> Windows: https://s.apache.org/qDs1
>>> Linux/Mac: https://s.apache.org/Sn7X
>>>  
>>> Every kind of feedback is helpful.
>>>  
>>> Important hint:
>>>  
>>> Based on the following issue  
>>> https://issues.apache.org/jira/browse/MNG-5227 the optional flag in a  
>>> dependencyManagement was simply ignored with previous Maven versions.  
>>> This Maven version starts to handle that correct. If you have problems  
>>> with that please report.
>>>  
>>>  
>>
>> I believe this build (git hash 227085283b6379038ec16f4cf9ad2e8869cef694) 
>> doesn’t actually contain the fix for MNG-5227. The previous testing snapshot 
>> built from 644ac9c40ad41bf61e3b099918af33b8eb950621 did contain the fix for 
>> MNG-5227, but the fix was reverted to avoid breaking builds which relied on 
>> the old behaviour.
>>
>> (this is just based on my reading of the commit history)  
> 
> There is MNG-5935 which is fixed and has an impact on the optional flag
> in dependency management. See this commit and its message.
> 
> and there is MNG-5227 which has an impact on the optional flag in
> dependency management. See this commit and its message.
> .
> Someone on dev@ has reported that he is using the optional flag in
> dependency management (setting it to true) and that he has noticed that
> this starts working in 3.4-SNAPSHOT for him. I haven't asked if he
> noticed it is not working before. What is important to know is that
> before the fix for MNG-5935 all managed dependencies were implicitly
> managing optional to false. Aether got updated to change the optional
> flag from 'boolean' to 'Boolean' and Maven has not been updated to
> reflect that. So instead of passing 'null' to Aether, it passed 'false'
> meaning 'manage the optional flag to false' where it should have passed
> 'null' meaning 'do not manage the optional flag in any way'.
> 

To confuse everyone even more. The first 3.4-SNAPSHOT we asked users to
test contained an Aether bugfix. That bugfix has lead to reports about
missing 'test' dependencies. See this commit and it's message

and the description in the bugtracker
.
That bugfix has been reverted in 3.4 but will re-appear as soon as we
update Aether which contains that bugfix correctly.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

[Christian Schulte]

Am 07/06/16 um 22:41 schrieb Stuart McCulloch:
> On Wednesday, 6 July 2016 at 20:46, Karl Heinz Marbaise wrote:
>> Hi to all Maven users,
>>  
>> If you like to help making the next Maven release better it would be  
>> nice if you could help a little bit.
>>  
>> Please be aware of this *** This is not an official release ***
>>  
>> I have created downloadable packages which are available from here:
>>  
>> Windows: https://s.apache.org/qDs1
>> Linux/Mac: https://s.apache.org/Sn7X
>>  
>> Every kind of feedback is helpful.
>>  
>> Important hint:
>>  
>> Based on the following issue  
>> https://issues.apache.org/jira/browse/MNG-5227 the optional flag in a  
>> dependencyManagement was simply ignored with previous Maven versions.  
>> This Maven version starts to handle that correct. If you have problems  
>> with that please report.
>>  
>>  
> 
> I believe this build (git hash 227085283b6379038ec16f4cf9ad2e8869cef694) 
> doesn’t actually contain the fix for MNG-5227. The previous testing snapshot 
> built from 644ac9c40ad41bf61e3b099918af33b8eb950621 did contain the fix for 
> MNG-5227, but the fix was reverted to avoid breaking builds which relied on 
> the old behaviour.
> 
> (this is just based on my reading of the commit history)  

There is MNG-5935 which is fixed and has an impact on the optional flag
in dependency management. See this commit and its message.

and there is MNG-5227 which has an impact on the optional flag in
dependency management. See this commit and its message.
.
Someone on dev@ has reported that he is using the optional flag in
dependency management (setting it to true) and that he has noticed that
this starts working in 3.4-SNAPSHOT for him. I haven't asked if he
noticed it is not working before. What is important to know is that
before the fix for MNG-5935 all managed dependencies were implicitly
managing optional to false. Aether got updated to change the optional
flag from 'boolean' to 'Boolean' and Maven has not been updated to
reflect that. So instead of passing 'null' to Aether, it passed 'false'
meaning 'manage the optional flag to false' where it should have passed
'null' meaning 'do not manage the optional flag in any way'.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/06/16 um 23:08 schrieb Stuart McCulloch:
> On Wednesday, 6 July 2016 at 21:53, Christian Schulte wrote:
>> Am 07/06/16 um 22:21 schrieb Ralph Goers:
>>> This is an interesting situation. The classes that use Jackson are all 
>>> considered optional in Log4j, so having optional set to true is indeed what 
>>> is desired. However, we require those dependencies to compile and to run 
>>> the unit tests. With scope set to test I would expect that the non-test 
>>> classes that need them would fail to compile. So it sounds like we have to 
>>> make sure all transitive dependencies needed for testing are also specified 
>>> with optional set to true?
>>>  
>>> Ralph
>>  
>> Not sure I understand the situation correctly. If the scope is set to
>> test, it's not available in any other scope than test. Could you please
>> point me at the POM in question? So I can 'mvn compile' that project
>> successfully and you would expect it to not compile due to some optional
>> transitive dependency?
>>  
>>  
> 
> Hi Christian,
> 
> Gary posted a link to the build in his original post.
> 
> Basically at the moment it has a dependencyManagement section in the 
> top-level pom that declares various jackson dependencies as optional, 
> including jackson-module-jaxb-annotations. The log4j-core sub-project 
> declares a direct dependency to jackson-dataformat-xml with compile scope, 
> marked as optional (also note that jackson-module-jaxb-annotations is a 
> transitive dependency of jackson-dataformat-xml).
> 
> With the fix for MNG-5227 the transitive dependency to 
> jackson-module-jaxb-annotations is managed as optional and is removed from 
> the compile and test classpath. Because the code doesn’t directly depend on 
> jackson-module-jaxb-annotations then it compiles ok. However, the tests fail 
> because both jackson-dataformat-xml and jackson-module-jaxb-annotations are 
> needed at test time.
> 
> Without the fix for MNG-5227 the optional flags in the dependencyManagement 
> section are ignored, and jackson-module-jaxb-annotations is included on the 
> compile and test classpath (because the optional jackson-dataformat-xml 
> dependency is selected and jackson-module-jaxb-annotations is now seen as a 
> non-optional transitive dependency of jackson-dataformat-xml).
> 

Ok. That's MNG-5935.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-shared pull request #15: [MSHARED-562] unit test AnsiMessageBuffer

[seblm]

GitHub user seblm opened a pull request:

https://github.com/apache/maven-shared/pull/15

[MSHARED-562] unit test AnsiMessageBuffer

In this test we do not use mocks at all. We simply write something with 
colors into buffer and check ANSI escapes characters are appended.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/seblm/maven-shared trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-shared/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 5103c4b76304c03a4eedf77fd97702c5d731cbe1
Author: Sébastian Le Merdy 
Date:   2016-07-06T20:51:39Z

[MSHARED-562] unit test AnsiMessageBuffer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Stuart McCulloch]

On Wednesday, 6 July 2016 at 21:53, Christian Schulte wrote:
> Am 07/06/16 um 22:21 schrieb Ralph Goers:
> > This is an interesting situation. The classes that use Jackson are all 
> > considered optional in Log4j, so having optional set to true is indeed what 
> > is desired. However, we require those dependencies to compile and to run 
> > the unit tests. With scope set to test I would expect that the non-test 
> > classes that need them would fail to compile. So it sounds like we have to 
> > make sure all transitive dependencies needed for testing are also specified 
> > with optional set to true?
> >  
> > Ralph
>  
> Not sure I understand the situation correctly. If the scope is set to
> test, it's not available in any other scope than test. Could you please
> point me at the POM in question? So I can 'mvn compile' that project
> successfully and you would expect it to not compile due to some optional
> transitive dependency?
>  
>  

Hi Christian,

Gary posted a link to the build in his original post.

Basically at the moment it has a dependencyManagement section in the top-level 
pom that declares various jackson dependencies as optional, including 
jackson-module-jaxb-annotations. The log4j-core sub-project declares a direct 
dependency to jackson-dataformat-xml with compile scope, marked as optional 
(also note that jackson-module-jaxb-annotations is a transitive dependency of 
jackson-dataformat-xml).

With the fix for MNG-5227 the transitive dependency to 
jackson-module-jaxb-annotations is managed as optional and is removed from the 
compile and test classpath. Because the code doesn’t directly depend on 
jackson-module-jaxb-annotations then it compiles ok. However, the tests fail 
because both jackson-dataformat-xml and jackson-module-jaxb-annotations are 
needed at test time.

Without the fix for MNG-5227 the optional flags in the dependencyManagement 
section are ignored, and jackson-module-jaxb-annotations is included on the 
compile and test classpath (because the optional jackson-dataformat-xml 
dependency is selected and jackson-module-jaxb-annotations is now seen as a 
non-optional transitive dependency of jackson-dataformat-xml).

HTH
>  
> Regards,
> --  
> Christian
>  
>  
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org 
> (mailto:dev-unsubscr...@maven.apache.org)
> For additional commands, e-mail: dev-h...@maven.apache.org 
> (mailto:dev-h...@maven.apache.org)
>  
>  

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Gary Gregory]

On Wed, Jul 6, 2016 at 12:47 PM, Karl Heinz Marbaise 
wrote:

> Hi Gary,
>
> done so.
>
> See announce on dev / user list...


The new version fixes the Log4j build.

Thank you,
Gary


>
>
> Kind regards
> Karl Heinz Marbaise
> On 7/6/16 9:18 PM, Gary Gregory wrote:
>
>> On Wed, Jul 6, 2016 at 11:52 AM, Karl Heinz Marbaise 
>> wrote:
>>
>> Hi Gary,
>>>
>>> On 7/6/16 8:47 PM, Gary Gregory wrote:
>>>
>>> On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch 
 wrote:

 That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)

> before MNG-5227 and other breaking changes were rolled back
>
> I just tried with a maven distribution built from latest master
> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is
> passing
>
>
> Is there a download for that?


>>> Should I create one?
>>>
>>
>>
>> If you want folks like me to test something up to date, yes ;-)
>>
>> Gary
>>
>>
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>>
>>> Gary



 On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>
> A while back, a post made available a 3.4.0 SNAPSHOT build for testing.
>
>>
>> So
>
> I'm using it here and there.
>>
>> To replicate the 3.4.0-S failure (works fine on 3.3.9):
>>
>> Download
>>
>>
>>
> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
>
>
>> (this link will be gone in a couple of days)
>>
>> Or checkout the tag with "git clone
>> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then
>>
>> "git
>
> checkout tags/log4j-2.6.2-rc1”
>>
>> Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT),
>> I
>>
>> am
>
> getting:
>>
>> Failed tests:
>> XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
>> [http://logging.apache.org/log4j/2.0/events";>], does not
>>
>> contain:
>
> [> XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
>> line3 incorrect: [], must have two-space indentation
>> XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
>> XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
>> Tests in error:
>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>> com/fasterxml/ja...
>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>> com/fasterxml/ja...
>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>> com/fasterxml/ja...
>> ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
>> NoClassDefFound
>> StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
>> NoClassDefFound
>> XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
>> com/fasterxml/jackson/module/ja...
>> XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
>> com/fasterxml/jackson...
>> XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122
>> ╗
>> NoClassDefFound
>> XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
>> NoClassDefFound
>>
>> org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.
>>
> apache.logging.log4j.core.net.server.SslXmlSocketServerTest
>
> Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
>> com/fasterxml/jackson/m...
>> Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
>>
>>
>> org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.
>>
> apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
>
> Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
>> com/fasterxml/jackson/m...
>> Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
>>
>>
>> org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.
>>
> apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
>
> Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
>> com/fasterxml/jackson/m...
>> Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
>>
>> Everything works fine with Maven 3.3.9.
>>
>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>> 2015-11-10T08:41:47-08:00)
>> Maven home: E:\Java\apache-maven-3.3.9
>> Java version: 1.8.0_91, vendor: Oracle Corporation
>> Java home: C:\Program Files\Java\jdk1.8.0_91\jre
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>>
>> Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
>> 2016-06-11T12:17:57-07:00)
>> Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
>> Java version: 1.8.0_91, vendor: Oracle Corporation
>> Java home: C:\Pro

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Mark Derricutt]

On Thu, Jul 7, 2016 at 8:21 AM, Ralph Goers 
wrote:

> With scope set to test I would expect that the non-test classes that need
> them would fail to compile.


Sadly this falls into one of my biggest pet-peeves with maven. IMHO neither
compile or test scope should ever be transitive. Sadly, such a change would
break 99% of central - the only work around to that IMHO would be a
different scope, say "build" that literally meant, this dep is solely for
building THIS project ( ideally, also a scope for annotation processors,
rather than messing with the compiler plugin ).

-- 
"Great artists are extremely selfish and arrogant things" — Steven Wilson,
Porcupine Tree

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Christian Schulte]

Am 07/06/16 um 22:21 schrieb Ralph Goers:
> This is an interesting situation. The classes that use Jackson are all 
> considered optional in Log4j, so having optional set to true is indeed what 
> is desired. However, we require those dependencies to compile and to run the 
> unit tests.  With scope set to test I would expect that the non-test classes 
> that need them would fail to compile.  So it sounds like we have to make sure 
> all transitive dependencies needed for testing are also specified with 
> optional set to true?
> 
> Ralph

Not sure I understand the situation correctly. If the scope is set to
test, it's not available in any other scope than test. Could you please
point me at the POM in question? So I can 'mvn compile' that project
successfully and you would expect it to not compile due to some optional
transitive dependency?

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

[Stuart McCulloch]

On Wednesday, 6 July 2016 at 20:46, Karl Heinz Marbaise wrote:
> Hi to all Maven users,
>  
> If you like to help making the next Maven release better it would be  
> nice if you could help a little bit.
>  
> Please be aware of this *** This is not an official release ***
>  
> I have created downloadable packages which are available from here:
>  
> Windows: https://s.apache.org/qDs1
> Linux/Mac: https://s.apache.org/Sn7X
>  
> Every kind of feedback is helpful.
>  
> Important hint:
>  
> Based on the following issue  
> https://issues.apache.org/jira/browse/MNG-5227 the optional flag in a  
> dependencyManagement was simply ignored with previous Maven versions.  
> This Maven version starts to handle that correct. If you have problems  
> with that please report.
>  
>  

I believe this build (git hash 227085283b6379038ec16f4cf9ad2e8869cef694) 
doesn’t actually contain the fix for MNG-5227. The previous testing snapshot 
built from 644ac9c40ad41bf61e3b099918af33b8eb950621 did contain the fix for 
MNG-5227, but the fix was reverted to avoid breaking builds which relied on the 
old behaviour.

(this is just based on my reading of the commit history)  
>  
> This is only a current state of development (Git hash:  
> 227085283b6379038ec16f4cf9ad2e8869cef694) to get some feedback from the  
> community...
>  
> The current list of changes can be seen in the issue tracker:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fixVersion%20%3D%203.4.0
>  
> It would be nice if those who had found issues to retest their scenarios.
>  
>  
> Kind regards
> Karl Heinz Marbaise
>  
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org 
> (mailto:dev-unsubscr...@maven.apache.org)
> For additional commands, e-mail: dev-h...@maven.apache.org 
> (mailto:dev-h...@maven.apache.org)
>  
>  

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

[Gary Gregory]

I like the idea of a deprecation warning.

Gary

On Wed, Jul 6, 2016 at 12:55 PM, Paul Benedict  wrote:

> Karl, I still believe the user who recommended that MNG-5227 be emitted as
> a warning (not error) in 3.4 was onto something correct. It's clear people
> aren't getting any lead time to know that their POM has a problem and thus
> breaks when using 3.4. Making it a warning now and switching it to an error
> in 3.5 is more friendly to the upgrade path, I believe. I still hope you
> can reconsider the issue because it's not a nice thing to fail a build for
> the sake of fixing thing within 1 point release. At least for anyone who
> tries jumping 2 point releases, the Maven developers could say "we gave you
> the chance" but there is no chance at this moment.
>
> Cheers,
> Paul
>
> On Wed, Jul 6, 2016 at 2:46 PM, Karl Heinz Marbaise 
> wrote:
>
> > Hi to all Maven users,
> >
> > If you like to help making the next Maven release better it would be nice
> > if you could help a little bit.
> >
> > Please be aware of this *** This is not an official release ***
> >
> > I have created downloadable packages which are available from here:
> >
> > Windows: https://s.apache.org/qDs1
> > Linux/Mac: https://s.apache.org/Sn7X
> >
> > Every kind of feedback is helpful.
> >
> > Important hint:
> >
> > Based on the following issue
> > https://issues.apache.org/jira/browse/MNG-5227 the optional flag in a
> > dependencyManagement was simply ignored with previous Maven versions.
> This
> > Maven version starts to handle that correct. If you have problems with
> that
> > please report.
> >
> >
> > This is only a current state of development (Git hash:
> > 227085283b6379038ec16f4cf9ad2e8869cef694) to get some feedback from the
> > community...
> >
> > The current list of changes can be seen in the issue tracker:
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fixVersion%20%3D%203.4.0
> >
> > It would be nice if those who had found issues to retest their scenarios.
> >
> >
> > Kind regards
> > Karl Heinz Marbaise
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Ralph Goers]

This is an interesting situation. The classes that use Jackson are all 
considered optional in Log4j, so having optional set to true is indeed what is 
desired. However, we require those dependencies to compile and to run the unit 
tests.  With scope set to test I would expect that the non-test classes that 
need them would fail to compile.  So it sounds like we have to make sure all 
transitive dependencies needed for testing are also specified with optional set 
to true?

Ralph


> On Jul 6, 2016, at 12:18 PM, Stuart McCulloch  wrote:
> 
> BTW, https://issues.apache.org/jira/browse/MNG-5227 was about making the 
> optional flag of a dependency manageable.
> 
> Previously any optional flags in dependencyManagement sections were ignored, 
> and it looks like the Log4j build relies on that historical behaviour. For 
> example the jackson dependencies are all currently marked as optional in the 
> top-level dependencyManagement. With previous versions of Maven these managed 
> flags were simply ignored and had no effect on the build. With the 
> 644ac9c40ad41bf61e3b099918af33b8eb950621 maven build these optional flags 
> were now being managed across any jackson dependencies in all sub-projects. 
> Since jackson-module-jaxb-annotations was not declared as a direct dependency 
> in log4j-core, but was only a transitive dependency of 
> jackson-dataformat-xml, this ended up being marked as ‘optional’ and removed 
> from the test-classpath.
> 
> Removing the ‘optional’ flags from the dependencyManagement section in the 
> top-level pom.xml cleans up the build and should work with both old and 
> future versions of Maven.  
> 
> On Wednesday, 6 July 2016 at 19:45, Stuart McCulloch wrote:
> 
>> That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621) before 
>> MNG-5227 and other breaking changes were rolled back
>> 
>> I just tried with a maven distribution built from latest master 
>> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing  
>> 
>> On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>> 
>>> A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
>>> I'm using it here and there.
>>> 
>>> To replicate the 3.4.0-S failure (works fine on 3.3.9):
>>> 
>>> Download
>>> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
>>> 
>>> (this link will be gone in a couple of days)
>>> 
>>> Or checkout the tag with "git clone
>>> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then "git
>>> checkout tags/log4j-2.6.2-rc1”
>>> 
>>> Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
>>> getting:
>>> 
>>> Failed tests:
>>> XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
>>> [http://logging.apache.org/log4j/2.0/events";>], does not contain:
>>> [>> XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
>>> line3 incorrect: [], must have two-space indentation
>>> XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
>>> XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
>>> Tests in error:
>>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>>> com/fasterxml/ja...
>>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>>> com/fasterxml/ja...
>>> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
>>> com/fasterxml/ja...
>>> ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
>>> NoClassDefFound
>>> StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
>>> NoClassDefFound
>>> XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
>>> com/fasterxml/jackson/module/ja...
>>> XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
>>> com/fasterxml/jackson...
>>> XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
>>> NoClassDefFound
>>> XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
>>> NoClassDefFound
>>> org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
>>> Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
>>> com/fasterxml/jackson/m...
>>> Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
>>> 
>>> org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
>>> Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
>>> com/fasterxml/jackson/m...
>>> Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
>>> 
>>> org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
>>> Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
>>> com/fasterxml/jackson/m...
>>> Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
>>> 
>>> Everything works fine with Maven 3.3.9.
>>> 
>>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

[Paul Benedict]

Karl, I still believe the user who recommended that MNG-5227 be emitted as
a warning (not error) in 3.4 was onto something correct. It's clear people
aren't getting any lead time to know that their POM has a problem and thus
breaks when using 3.4. Making it a warning now and switching it to an error
in 3.5 is more friendly to the upgrade path, I believe. I still hope you
can reconsider the issue because it's not a nice thing to fail a build for
the sake of fixing thing within 1 point release. At least for anyone who
tries jumping 2 point releases, the Maven developers could say "we gave you
the chance" but there is no chance at this moment.

Cheers,
Paul

On Wed, Jul 6, 2016 at 2:46 PM, Karl Heinz Marbaise 
wrote:

> Hi to all Maven users,
>
> If you like to help making the next Maven release better it would be nice
> if you could help a little bit.
>
> Please be aware of this *** This is not an official release ***
>
> I have created downloadable packages which are available from here:
>
> Windows: https://s.apache.org/qDs1
> Linux/Mac: https://s.apache.org/Sn7X
>
> Every kind of feedback is helpful.
>
> Important hint:
>
> Based on the following issue
> https://issues.apache.org/jira/browse/MNG-5227 the optional flag in a
> dependencyManagement was simply ignored with previous Maven versions. This
> Maven version starts to handle that correct. If you have problems with that
> please report.
>
>
> This is only a current state of development (Git hash:
> 227085283b6379038ec16f4cf9ad2e8869cef694) to get some feedback from the
> community...
>
> The current list of changes can be seen in the issue tracker:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fixVersion%20%3D%203.4.0
>
> It would be nice if those who had found issues to retest their scenarios.
>
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Karl Heinz Marbaise]

Hi Gary,

done so.

See announce on dev / user list...

Kind regards
Karl Heinz Marbaise
On 7/6/16 9:18 PM, Gary Gregory wrote:

On Wed, Jul 6, 2016 at 11:52 AM, Karl Heinz Marbaise 
wrote:


Hi Gary,

On 7/6/16 8:47 PM, Gary Gregory wrote:


On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch 
wrote:

That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)

before MNG-5227 and other breaking changes were rolled back

I just tried with a maven distribution built from latest master
(227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing



Is there a download for that?



Should I create one?



If you want folks like me to test something up to date, yes ;-)

Gary




Kind regards
Karl Heinz Marbaise



Gary




On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:

A while back, a post made available a 3.4.0 SNAPSHOT build for testing.



So


I'm using it here and there.

To replicate the 3.4.0-S failure (works fine on 3.3.9):

Download



https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip



(this link will be gone in a couple of days)

Or checkout the tag with "git clone
https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then


"git


checkout tags/log4j-2.6.2-rc1”

Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I


am


getting:

Failed tests:
XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
[http://logging.apache.org/log4j/2.0/events";>], does not


contain:


[], must have two-space indentation
XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
Tests in error:
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
NoClassDefFound
StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
NoClassDefFound
XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
com/fasterxml/jackson/module/ja...
XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
com/fasterxml/jackson...
XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
NoClassDefFound
XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
NoClassDefFound

org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.

apache.logging.log4j.core.net.server.SslXmlSocketServerTest


Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer


org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.

apache.logging.log4j.core.net.server.TcpXmlSocketServerTest


Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer


org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.

apache.logging.log4j.core.net.server.UdpXmlSocketServerTest


Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

Everything works fine with Maven 3.3.9.

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
2016-06-11T12:17:57-07:00)
Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

Thank you
Gary (Apache Logging PMC)

--
E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) |


ggreg...@apache.org (mailto:ggreg...@apache.org)


Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

[Karl Heinz Marbaise]

Hi to all Maven users,

If you like to help making the next Maven release better it would be 
nice if you could help a little bit.


Please be aware of this *** This is not an official release ***

I have created downloadable packages which are available from here:

Windows: https://s.apache.org/qDs1
Linux/Mac: https://s.apache.org/Sn7X

Every kind of feedback is helpful.

Important hint:

Based on the following issue 
https://issues.apache.org/jira/browse/MNG-5227 the optional flag in a 
dependencyManagement was simply ignored with previous Maven versions. 
This Maven version starts to handle that correct. If you have problems 
with that please report.



This is only a current state of development (Git hash: 
227085283b6379038ec16f4cf9ad2e8869cef694) to get some feedback from the 
community...


The current list of changes can be seen in the issue tracker:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fixVersion%20%3D%203.4.0

It would be nice if those who had found issues to retest their scenarios.


Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Stuart McCulloch]

BTW, https://issues.apache.org/jira/browse/MNG-5227 was about making the 
optional flag of a dependency manageable.

Previously any optional flags in dependencyManagement sections were ignored, 
and it looks like the Log4j build relies on that historical behaviour. For 
example the jackson dependencies are all currently marked as optional in the 
top-level dependencyManagement. With previous versions of Maven these managed 
flags were simply ignored and had no effect on the build. With the 
644ac9c40ad41bf61e3b099918af33b8eb950621 maven build these optional flags were 
now being managed across any jackson dependencies in all sub-projects. Since 
jackson-module-jaxb-annotations was not declared as a direct dependency in 
log4j-core, but was only a transitive dependency of jackson-dataformat-xml, 
this ended up being marked as ‘optional’ and removed from the test-classpath.

Removing the ‘optional’ flags from the dependencyManagement section in the 
top-level pom.xml cleans up the build and should work with both old and future 
versions of Maven.  

On Wednesday, 6 July 2016 at 19:45, Stuart McCulloch wrote:

> That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621) before 
> MNG-5227 and other breaking changes were rolled back
>  
> I just tried with a maven distribution built from latest master 
> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing  
>  
> On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>  
> > A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
> > I'm using it here and there.
> >  
> > To replicate the 3.4.0-S failure (works fine on 3.3.9):
> >  
> > Download
> > https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
> >  
> > (this link will be gone in a couple of days)
> >  
> > Or checkout the tag with "git clone
> > https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then "git
> > checkout tags/log4j-2.6.2-rc1”
> >  
> > Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
> > getting:
> >  
> > Failed tests:
> > XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
> > [http://logging.apache.org/log4j/2.0/events";>], does not contain:
> > [ > XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
> > line3 incorrect: [], must have two-space indentation
> > XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
> > XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
> > Tests in error:
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
> > NoClassDefFound
> > StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
> > NoClassDefFound
> > XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
> > com/fasterxml/jackson/module/ja...
> > XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
> > com/fasterxml/jackson...
> > XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
> > NoClassDefFound
> > XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
> > NoClassDefFound
> > org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
> > Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
> >  
> > org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
> > Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
> >  
> > org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
> > Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
> >  
> > Everything works fine with Maven 3.3.9.
> >  
> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > 2015-11-10T08:41:47-08:00)
> > Maven home: E:\Java\apache-maven-3.3.9
> > Java version: 1.8.0_91, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
> >  
> > Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
> > 2016-06-11T12:17:57-07:00)
> > Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
> > Java version: 1.8.0_91, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_9

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Gary Gregory]

On Wed, Jul 6, 2016 at 11:52 AM, Karl Heinz Marbaise 
wrote:

> Hi Gary,
>
> On 7/6/16 8:47 PM, Gary Gregory wrote:
>
>> On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch 
>> wrote:
>>
>> That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)
>>> before MNG-5227 and other breaking changes were rolled back
>>>
>>> I just tried with a maven distribution built from latest master
>>> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing
>>>
>>>
>> Is there a download for that?
>>
>
> Should I create one?


If you want folks like me to test something up to date, yes ;-)

Gary

>
>
> Kind regards
> Karl Heinz Marbaise
>
>
>> Gary
>>
>>
>>
>>> On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>>>
>>> A while back, a post made available a 3.4.0 SNAPSHOT build for testing.

>>> So
>>>
 I'm using it here and there.

 To replicate the 3.4.0-S failure (works fine on 3.3.9):

 Download


>>> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
>>>

 (this link will be gone in a couple of days)

 Or checkout the tag with "git clone
 https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then

>>> "git
>>>
 checkout tags/log4j-2.6.2-rc1”

 Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I

>>> am
>>>
 getting:

 Failed tests:
 XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
 [http://logging.apache.org/log4j/2.0/events";>], does not

>>> contain:
>>>
 [>>> XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
 line3 incorrect: [], must have two-space indentation
 XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
 XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
 Tests in error:
 MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
 com/fasterxml/ja...
 MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
 com/fasterxml/ja...
 MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
 com/fasterxml/ja...
 ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
 NoClassDefFound
 StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
 NoClassDefFound
 XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
 com/fasterxml/jackson/module/ja...
 XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
 com/fasterxml/jackson...
 XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
 NoClassDefFound
 XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
 NoClassDefFound

 org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.
>>> apache.logging.log4j.core.net.server.SslXmlSocketServerTest
>>>
 Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
 com/fasterxml/jackson/m...
 Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer


 org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.
>>> apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
>>>
 Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
 com/fasterxml/jackson/m...
 Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer


 org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.
>>> apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
>>>
 Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
 com/fasterxml/jackson/m...
 Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

 Everything works fine with Maven 3.3.9.

 Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
 2015-11-10T08:41:47-08:00)
 Maven home: E:\Java\apache-maven-3.3.9
 Java version: 1.8.0_91, vendor: Oracle Corporation
 Java home: C:\Program Files\Java\jdk1.8.0_91\jre
 Default locale: en_US, platform encoding: Cp1252
 OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

 Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
 2016-06-11T12:17:57-07:00)
 Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
 Java version: 1.8.0_91, vendor: Oracle Corporation
 Java home: C:\Program Files\Java\jdk1.8.0_91\jre
 Default locale: en_US, platform encoding: Cp1252
 OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

 Thank you
 Gary (Apache Logging PMC)

 --
 E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) |

>>> ggreg...@apache.org (mailto:ggreg...@apache.org)
>>>
 Java Persistence with Hibernate, Second Edition
 
 JUnit in Action, Second Edition 
 Spring Batch in Action 
 Blog: http://g

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Karl Heinz Marbaise]

Hi Gary,

On 7/6/16 8:47 PM, Gary Gregory wrote:

On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch  wrote:


That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)
before MNG-5227 and other breaking changes were rolled back

I just tried with a maven distribution built from latest master
(227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing



Is there a download for that?


Should I create one?

Kind regards
Karl Heinz Marbaise



Gary




On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:


A while back, a post made available a 3.4.0 SNAPSHOT build for testing.

So

I'm using it here and there.

To replicate the 3.4.0-S failure (works fine on 3.3.9):

Download


https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip


(this link will be gone in a couple of days)

Or checkout the tag with "git clone
https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then

"git

checkout tags/log4j-2.6.2-rc1”

Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I

am

getting:

Failed tests:
XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
[http://logging.apache.org/log4j/2.0/events";>], does not

contain:

[], must have two-space indentation
XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
Tests in error:
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
NoClassDefFound
StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
NoClassDefFound
XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
com/fasterxml/jackson/module/ja...
XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
com/fasterxml/jackson...
XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
NoClassDefFound
XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
NoClassDefFound


org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest

Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer



org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest

Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer



org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest

Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

Everything works fine with Maven 3.3.9.

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
2016-06-11T12:17:57-07:00)
Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

Thank you
Gary (Apache Logging PMC)

--
E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) |

ggreg...@apache.org (mailto:ggreg...@apache.org)

Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Karl Heinz Marbaise]

Hi,

thanks Stuart...that's right.

Kind regards
Karl Heinz Marbaise
On 7/6/16 8:45 PM, Stuart McCulloch wrote:

That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621) before 
MNG-5227 and other breaking changes were rolled back

I just tried with a maven distribution built from latest master 
(227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing

On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:


A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
I'm using it here and there.

To replicate the 3.4.0-S failure (works fine on 3.3.9):

Download
https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip

(this link will be gone in a couple of days)

Or checkout the tag with "git clone
https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then "git
checkout tags/log4j-2.6.2-rc1”

Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
getting:

Failed tests:
XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
[http://logging.apache.org/log4j/2.0/events";>], does not contain:
[], must have two-space indentation
XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
Tests in error:
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
NoClassDefFound
StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
NoClassDefFound
XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
com/fasterxml/jackson/module/ja...
XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
com/fasterxml/jackson...
XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
NoClassDefFound
XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
NoClassDefFound
org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer

org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer

org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

Everything works fine with Maven 3.3.9.

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
2016-06-11T12:17:57-07:00)
Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

Thank you
Gary (Apache Logging PMC)


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Gary Gregory]

On Wed, Jul 6, 2016 at 11:45 AM, Stuart McCulloch  wrote:

> That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621)
> before MNG-5227 and other breaking changes were rolled back
>
> I just tried with a maven distribution built from latest master
> (227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing
>

Is there a download for that?

Gary


>
> On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:
>
> > A while back, a post made available a 3.4.0 SNAPSHOT build for testing.
> So
> > I'm using it here and there.
> >
> > To replicate the 3.4.0-S failure (works fine on 3.3.9):
> >
> > Download
> >
> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
> >
> > (this link will be gone in a couple of days)
> >
> > Or checkout the tag with "git clone
> > https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then
> "git
> > checkout tags/log4j-2.6.2-rc1”
> >
> > Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I
> am
> > getting:
> >
> > Failed tests:
> > XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
> > [http://logging.apache.org/log4j/2.0/events";>], does not
> contain:
> > [ > XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
> > line3 incorrect: [], must have two-space indentation
> > XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
> > XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
> > Tests in error:
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> > com/fasterxml/ja...
> > ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
> > NoClassDefFound
> > StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
> > NoClassDefFound
> > XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
> > com/fasterxml/jackson/module/ja...
> > XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
> > com/fasterxml/jackson...
> > XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
> > NoClassDefFound
> > XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
> > NoClassDefFound
> >
> org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
> > Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
> >
> >
> org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
> > Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
> >
> >
> org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
> > Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> > com/fasterxml/jackson/m...
> > Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
> >
> > Everything works fine with Maven 3.3.9.
> >
> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> > 2015-11-10T08:41:47-08:00)
> > Maven home: E:\Java\apache-maven-3.3.9
> > Java version: 1.8.0_91, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
> >
> > Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
> > 2016-06-11T12:17:57-07:00)
> > Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
> > Java version: 1.8.0_91, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"
> >
> > Thank you
> > Gary (Apache Logging PMC)
> >
> > --
> > E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) |
> ggreg...@apache.org (mailto:ggreg...@apache.org)
> > Java Persistence with Hibernate, Second Edition
> > 
> > JUnit in Action, Second Edition 
> > Spring Batch in Action 
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
> >
>
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: 3.4.0 SNAPSHOT breaks Log4j build

[Stuart McCulloch]

That looks like the build (644ac9c40ad41bf61e3b099918af33b8eb950621) before 
MNG-5227 and other breaking changes were rolled back

I just tried with a maven distribution built from latest master 
(227085283b6379038ec16f4cf9ad2e8869cef694) and the Log4J build is passing  

On Wednesday, 6 July 2016 at 19:24, Gary Gregory wrote:

> A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
> I'm using it here and there.
>  
> To replicate the 3.4.0-S failure (works fine on 3.3.9):
>  
> Download
> https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip
>  
> (this link will be gone in a couple of days)
>  
> Or checkout the tag with "git clone
> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then "git
> checkout tags/log4j-2.6.2-rc1”
>  
> Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
> getting:
>  
> Failed tests:
> XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
> [http://logging.apache.org/log4j/2.0/events";>], does not contain:
> [ XmlCompleteFileAppenderTest.testChildElementsAreCorrectlyIndented:139
> line3 incorrect: [], must have two-space indentation
> XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
> XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
> Tests in error:
> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> com/fasterxml/ja...
> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> com/fasterxml/ja...
> MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
> com/fasterxml/ja...
> ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
> NoClassDefFound
> StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
> NoClassDefFound
> XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
> com/fasterxml/jackson/module/ja...
> XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
> com/fasterxml/jackson...
> XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
> NoClassDefFound
> XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
> NoClassDefFound
> org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
> Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
> com/fasterxml/jackson/m...
> Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer
>  
> org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
> Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> com/fasterxml/jackson/m...
> Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer
>  
> org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
> Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
> com/fasterxml/jackson/m...
> Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer
>  
> Everything works fine with Maven 3.3.9.
>  
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T08:41:47-08:00)
> Maven home: E:\Java\apache-maven-3.3.9
> Java version: 1.8.0_91, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>  
> Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
> 2016-06-11T12:17:57-07:00)
> Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
> Java version: 1.8.0_91, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_91\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"
>  
> Thank you
> Gary (Apache Logging PMC)
>  
> --  
> E-Mail: garydgreg...@gmail.com (mailto:garydgreg...@gmail.com) | 
> ggreg...@apache.org (mailto:ggreg...@apache.org)
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>  
>  

3.4.0 SNAPSHOT breaks Log4j build

[Gary Gregory]

A while back, a post made available a 3.4.0 SNAPSHOT build for testing. So
I'm using it here and there.

To replicate the 3.4.0-S failure (works fine on 3.3.9):

Download
https://repository.apache.org/content/repositories/orgapachelogging-1020/org/apache/logging/log4j/log4j-distribution/2.6.2/log4j-distribution-2.6.2-src.zip

(this link will be gone in a couple of days)

Or checkout the tag with "git clone
https://git-wip-us.apache.org/repos/asf/logging-log4j2.git"; and then "git
checkout tags/log4j-2.6.2-rc1”

Using the src distro with 'mvn clean package' (Maven 3.4.0-SNAPSHOT), I am
getting:

Failed tests:
  XmlCompactFileAppenderTest.testFlushAtEndOfBatch:66 line1 incorrect:
[http://logging.apache.org/log4j/2.0/events";>], does not contain:
[], must have two-space indentation
  XmlCompleteFileAppenderTest.testFlushAtEndOfBatch:74 line3
  XmlFileAppenderTest.testFlushAtEndOfBatch:64 line1
Tests in error:
  MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
  MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
  MarkerMixInXmlTest>MarkerMixInTest.setUp:45 ╗ NoClassDefFound
com/fasterxml/ja...
  ThrowableProxyTest.testIoContainerAsXml:95->testIoContainer:78 ╗
NoClassDefFound
  StackTraceElementMixInTest.testLog4jXmlObjectMapper:58->roundtrip:51 ╗
NoClassDefFound
  XmlLayoutTest.testLayout:214 ╗ NoClassDefFound
com/fasterxml/jackson/module/ja...
  XmlLayoutTest.testLayoutLoggerName:262 ╗ NoClassDefFound
com/fasterxml/jackson...
  XmlLayoutTest.testLocationOffCompactOffMdcOff:268->testAllFeatures:122 ╗
NoClassDefFound
  XmlLayoutTest.testLocationOnCompactOnMdcOn:273->testAllFeatures:122 ╗
NoClassDefFound
org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest.org.apache.logging.log4j.core.net.server.SslXmlSocketServerTest
  Run 1: SslXmlSocketServerTest.setupClass:64 ╗ NoClassDefFound
com/fasterxml/jackson/m...
  Run 2: SslXmlSocketServerTest.tearDownClass:71 NullPointer

org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.TcpXmlSocketServerTest
  Run 1: TcpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
  Run 2: TcpXmlSocketServerTest.tearDownClass:45 NullPointer

org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest.org.apache.logging.log4j.core.net.server.UdpXmlSocketServerTest
  Run 1: UdpXmlSocketServerTest.setupClass:38 ╗ NoClassDefFound
com/fasterxml/jackson/m...
  Run 2: UdpXmlSocketServerTest.tearDownClass:44 NullPointer

Everything works fine with Maven 3.3.9.

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: E:\Java\apache-maven-3.3.9
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Apache Maven 3.4.0-SNAPSHOT (644ac9c40ad41bf61e3b099918af33b8eb950621;
2016-06-11T12:17:57-07:00)
Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\..
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "Windows 7", version: "6.1", arch: "amd64", family: "Windows"

Thank you
Gary (Apache Logging PMC)

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

[ANN] Apache Maven SCM Version 1.9.5 Released

[Karl Heinz Marbaise]

The Apache Maven team is pleased to announce the release of the 
Apache Maven SCM 1.9.5.
 
https://maven.apache.org/scm/

Maven SCM supports Maven 2.x plugins (e.g. maven-release-plugin) and other
tools (e.g. Continuum) by providing them with a common API for doing SCM
operations. You can look at the list of SCMs for more information on using
Maven SCM with your favorite SCM tool.
 
You can download the appropriate sources etc. from the download page:
 
https://maven.apache.org/scm/download.cgi
 
Release Notes Maven SCM 1.9.5

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317828&version=12331366

Bugs:
 * [SCM-682] - Maven release fails when releasing from a named branch
 * [SCM-734] - SVN branching fails with svn+ssh://username@host URL
 * [SCM-772] - GitStatusConsumer does not properly handle quoted paths output 
from GitStatusCommand
 * [SCM-795] - scm output parsing is too aggressive on stderr
 * [SCM-806] - JGit impl should look for repositories in parent directories
 * [SCM-812] - Jazz SCM Alias Id's roll over to zero, not 1000 as advertised.
 * [SCM-813] - SVN fails when trying to create a branch with nested directories
 * [SCM-816] - Can't bootstrap or checkout project with child module
 * [SCM-817] - Jgit provider exposes password if it contains special characters
 * [SCM-819] - Integrity blame command fixes.
 * [SCM-820] - Correctly strip quotes in GitStatusConsumer
 * [SCM-822] - Fixed SVN branching with svn+ssh://username@host URL.
 * [SCM-825] - provide JGitInfoCommand
 * [SCM-827] - Scm tests fail on Windows because Subversion crashes on loading 
tck.dump
 * [SCM-828] - support @ in username of scm url

Improvements:

 * [SCM-775] - Add workItem and changeset associate support for scm deliver
 * [SCM-781] - Add a goal to recursively validate SCM url
 * [SCM-803] - Upgrade maven-parent to version 27
 * [SCM-808] - JGit impl should be included in standard providers
 * [SCM-809] - Make git executable name a config option
 * [SCM-811] - m2 release plugin shows SCM git password if fatal occured during 
git push
 * [SCM-830] - Upgrade maven parent to version 30
 * [SCM-831] - Using inherited site descriptor from maven-parent

Wish:

 * [SCM-749] - remove "[INFO] Working directory:" from svnexe output on Linux 

Enjoy,
 
-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1751555 - in /maven/plugins/trunk/maven-changes-plugin/src: main/java/org/apache/maven/plugin/github/GitHubDownloader.java test/java/org/apache/maven/plugin/github/GitHubDownloaderTes

[Robert Scholte]

On Tue, 05 Jul 2016 22:47:33 +0200,  wrote:


 assertEquals( githubIssue.getTitle(), issue.getTitle() );
-assertEquals( githubIssue.getBody(), issue.getSummary() );
+assertEquals( githubIssue.getTitle(), issue.getSummary() );


This looks weird to me: this can only be true in issue.getTitle() and  
issue.getSummary() are the same.

Are you sure that the problem is here and not in the report?

Robert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Why would getDependencies() not return all plugin dependencies?

[Lennart Jörelid]

Hello all,

I am a tad puzzled here. I got a strange exception from the
maven-checkstyle-plugin during its site generation yesterday. The immediate
reason in the code was rather simple to track and fix (it is done in PR
https://github.com/apache/maven-plugins/pull/88). I also created a
discussion at https://issues.apache.org/jira/browse/MCHECKSTYLE-287.

However - the root cause of this is not clear to me. It seems that the call
to getArtifactMap().get( groupId:artifactId ) returns null - for some, but
not all, artifacts.
So my question is ... why would the call to *plugin.getDependencies()* not
include some of the dependencies added to the plugin?

Log output (I changed the last part of the log statement since this was
captured, but the effect is still the same):

[DEBUG] Generating
/Users/lj/Development/Projects/Skolverket/Repos/framework/persistence/persistence-spi-jpa/target/site/checkstyle.html
[INFO] Generating "Checkstyle" report   ---
maven-checkstyle-plugin:2.18-SNAPSHOT:checkstyle*[DEBUG] Got null
CheckstylePlugin Dependency Artifact from key [se.foo:foo-codestyle].
Not including null Artifact.
[DEBUG] Got null CheckstylePlugin Dependency Artifact from key
[se.jguru.nazgul.tools.codestyle:nazgul-codestyle]. Not including null
Artifact.
[DEBUG] Got null CheckstylePlugin Dependency Artifact from key
[se.foo:foo-codestyle]. Not including null Artifact.
[DEBUG] Got null CheckstylePlugin Dependency Artifact from key
[se.jguru.nazgul.tools.codestyle:nazgul-codestyle]. Not including null
Artifact. *
[DEBUG] executeCheckstyle start headerLocation : LICENSE.txt
[DEBUG] Adding licenceArtifact
[com.puppycrawl.tools:checkstyle:6.11.2] to resourceManager.
[DEBUG] Adding licenceArtifact [org.slf4j:jcl-over-slf4j:1.5.6] to
resourceManager.
[DEBUG] Adding licenceArtifact [org.slf4j:slf4j-jdk14:1.5.6] to resourceManager.


Plugin configuration with relevant plugins:

  maven-checkstyle-plugin
  2.18-SNAPSHOT
  
... left out for now...
  
  

  com.puppycrawl.tools
  checkstyle
  6.19


  se.foo
  foo-codestyle
  1.9.3-SNAPSHOT


  se.jguru.nazgul.tools.codestyle
  nazgul-codestyle
  5.0.1


  org.slf4j
  jcl-over-slf4j
  1.7.20


  org.slf4j
  slf4j-jdk14
  1.7.20

  


Relevant part of the plugin code:

private List getCheckstylePluginDependenciesAsArtifacts(
Map plugins, String hint )
{
List artifacts = new ArrayList<>();

Plugin checkstylePlugin = plugins.get( plugin.getGroupId() + ":" +
plugin.getArtifactId() );
if ( checkstylePlugin != null )
{
for ( *Dependency dep : checkstylePlugin.getDependencies()* )
*// Why do we not get all the Dependencies here?*
{
 // @todo if we can filter on hints, it should be done here...
String depKey = dep.getGroupId() + ":" + dep.getArtifactId();
final Artifact artifact = (Artifact)
plugin.getArtifactMap().get( depKey );

if ( artifact != null )
{
artifacts.add( artifact );
}
else if ( getLog().isDebugEnabled() )
{
getLog().debug( "Got null CheckstylePlugin Dependency
Artifact from key ["
+ depKey + "]. Excluding null Artifact from
return List. " );
}
}
}
return artifacts;
}


--
+==+
| Bästa hälsningar,
| [sw. "Best regards"]
|
| Lennart Jörelid
| EAI Architect & Integrator
|
| jGuru Europe AB
| Mölnlycke - Kista
|
| Email: l...@jguru.se
| URL:   www.jguru.se
| Phone
| (skype):jgurueurope
| (intl): +46 708 507 603
| (domestic): 0708 - 507 603
+==+