Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2222
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME//changes
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2499
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2499/changes Changes: [dave] Add Groupon and LIFX to PoweredByMesos documentation. -- [...truncated 63968 lines...] I1028 08:20:16.717905 4794 hierarchical_allocator_process.hpp:329] Added framework 20141028-082016-3142697795-52878-4771- I1028 08:20:16.717926 4794 hierarchical_allocator_process.hpp:697] No resources available to allocate! I1028 08:20:16.717938 4794 hierarchical_allocator_process.hpp:659] Performed allocation for 0 slaves in 15009ns I1028 08:20:16.717949 4799 sched.cpp:407] Framework registered with 20141028-082016-3142697795-52878-4771- I1028 08:20:16.717983 4799 sched.cpp:421] Scheduler::registered took 16736ns I1028 08:20:16.735296 4785 master.cpp:1362] Received registration request for framework 'default' at scheduler-f197f471-a430-458c-b179-76e944d42c26@67.195.81.187:52878 I1028 08:20:16.735385 4785 master.cpp:1321] Authorizing framework principal 'test-principal' to receive offers for role '*' I1028 08:20:16.735765 4789 master.cpp:1413] Framework 20141028-082016-3142697795-52878-4771- (default) at scheduler-f197f471-a430-458c-b179-76e944d42c26@67.195.81.187:52878 already registered, resending acknowledgement I1028 08:20:16.735998 4791 sched.cpp:394] Ignoring framework registered message because the driver is already connected! I1028 08:20:16.745360 4798 process.cpp:3358] Handling HTTP event for process 'metrics' with path: '/metrics/snapshot' I1028 08:20:16.756767 4797 hierarchical_allocator_process.hpp:697] No resources available to allocate! I1028 08:20:16.756791 4797 hierarchical_allocator_process.hpp:659] Performed allocation for 0 slaves in 47253ns I1028 08:20:16.767102 4798 process.cpp:3358] Handling HTTP event for process 'metrics' with path: '/metrics/snapshot' I1028 08:20:16.778391 4796 master.cpp:1362] Received registration request for framework 'default' at scheduler-f197f471-a430-458c-b179-76e944d42c26@67.195.81.187:52878 I1028 08:20:16.778446 4796 master.cpp:1321] Authorizing framework principal 'test-principal' to receive offers for role '*' I1028 08:20:16.778884 4797 master.cpp:1413] Framework 20141028-082016-3142697795-52878-4771- (default) at scheduler-f197f471-a430-458c-b179-76e944d42c26@67.195.81.187:52878 already registered, resending acknowledgement I1028 08:20:16.779063 4791 sched.cpp:394] Ignoring framework registered message because the driver is already connected! I1028 08:20:16.788471 4797 process.cpp:3358] Handling HTTP event for process 'metrics' with path: '/metrics/snapshot' I1028 08:20:16.799461 4771 master.cpp:677] Master terminating I1028 08:20:16.799495 4796 sched.cpp:745] Stopping framework '20141028-082016-3142697795-52878-4771-' [ OK ] RateLimitingTest.RateLimitingEnabled (146 ms) [--] 6 tests from RateLimitingTest (3430 ms total) [--] 2 tests from CpuIsolatorTest/2, where TypeParam = mesos::internal::tests::Modulemesos::internal::slave::Isolator, (mesos::internal::tests::ModuleID)1 [ RUN ] CpuIsolatorTest/2.UserCpuUsage Using temporary directory '/tmp/CpuIsolatorTest_2_UserCpuUsage_LXv7g0' I1028 08:20:16.807584 4771 launcher.cpp:137] Forked child with pid '9391' for container 'user_cpu_usage' [ OK ] CpuIsolatorTest/2.UserCpuUsage (404 ms) [ RUN ] CpuIsolatorTest/2.SystemCpuUsage Using temporary directory '/tmp/CpuIsolatorTest_2_SystemCpuUsage_9V5jvn' I1028 08:20:17.211205 4771 launcher.cpp:137] Forked child with pid '9395' for container 'system_cpu_usage' [ OK ] CpuIsolatorTest/2.SystemCpuUsage (401 ms) [--] 2 tests from CpuIsolatorTest/2 (805 ms total) [--] 2 tests from PathsTest [ RUN ] PathsTest.CreateExecutorDirectory [ OK ] PathsTest.CreateExecutorDirectory (2 ms) [ RUN ] PathsTest.format [ OK ] PathsTest.format (2 ms) [--] 2 tests from PathsTest (4 ms total) [--] 1 test from WhitelistTest [ RUN ] WhitelistTest.WhitelistSlave Using temporary directory '/tmp/WhitelistTest_WhitelistSlave_bNbAfd' I1028 08:20:17.616255 4771 leveldb.cpp:176] Opened db in 2.934878ms I1028 08:20:17.617570 4771 leveldb.cpp:183] Compacted db in 1.218266ms I1028 08:20:17.617655 4771 leveldb.cpp:198] Created db iterator in 29777ns I1028 08:20:17.617673 4771 leveldb.cpp:204] Seeked to beginning of db in 3105ns I1028 08:20:17.617681 4771 leveldb.cpp:273] Iterated through 0 keys in the db in 325ns I1028 08:20:17.617738 4771 replica.cpp:741] Replica recovered with log positions 0 - 0 with 1 holes and 0 unlearned I1028 08:20:17.618621 4794 recover.cpp:437] Starting replica recovery I1028 08:20:17.618971 4794 recover.cpp:463] Replica is in EMPTY status I1028 08:20:17.621215 4787 master.cpp:312] Master 20141028-082017-3142697795-52878-4771 (pomona.apache.org) started on 67.195.81.187:52878 I1028 08:20:17.621269 4787 master.cpp:358
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 28, 2014, 12:43 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Fixed style issues. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs (updated) - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 28, 2014, 12:44 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Fixed style issue. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Enables selecting a module based authenticator via the new --authenticators flag for mesos master. Additionally, all have been fixed towards in master.hpp and master.cpp. Diffs (updated) - src/master/flags.hpp c931fd9 src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/module/authenticator.hpp PRE-CREATION src/tests/crammd5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
0.21.0-pre Spark latest
Folks - We have some automated tests that run the latest Mesos against the latest Spark, and we've run across a series of issues in both fine, and course grained mode that I believe stem from a series of changes in the 0.21 cycle. I'm not certain if anyone owns this integration, but we should probably ensure it's fixed before we push out 0.21. -- Cheers, Timothy St. Clair Red Hat Inc.
Re: 0.21.0-pre Spark latest
Since we've recently adopted Spark, I'll second Tim's comment. We had an issue with 0.20.1 that was possibly related to Spark[1], so it's important for us to get this stuff fixed in 0.21.0. Tim, can you elaborate on the issues you saw? Have you tested with my recent Spark patches[2][3]? [1]: https://issues.apache.org/jira/browse/MESOS-1973 [2]: https://github.com/apache/spark/pull/2401 [3]: https://github.com/apache/spark/pull/2453 On Tue, Oct 28, 2014 at 7:46 AM, Tim St Clair tstcl...@redhat.com wrote: Folks - We have some automated tests that run the latest Mesos against the latest Spark, and we've run across a series of issues in both fine, and course grained mode that I believe stem from a series of changes in the 0.21 cycle. I'm not certain if anyone owns this integration, but we should probably ensure it's fixed before we push out 0.21. -- Cheers, Timothy St. Clair Red Hat Inc.
Re: 0.21.0-pre Spark latest
inline - Original Message - From: Brenden Matthews brenden.matth...@airbedandbreakfast.com To: u...@mesos.apache.org Cc: mesos-devel dev@mesos.apache.org, RJ Nowling rnowl...@redhat.com, Erik Erlandson e...@redhat.com Sent: Tuesday, October 28, 2014 9:51:58 AM Subject: Re: 0.21.0-pre Spark latest Since we've recently adopted Spark, I'll second Tim's comment. We had an issue with 0.20.1 that was possibly related to Spark[1], so it's important for us to get this stuff fixed in 0.21.0. Tim, can you elaborate on the issues you saw? Have you tested with my recent Spark patches[2][3]? We are building against Spark 1.1.0 unpatched: - Fine grained mode appears broken. - Course grained mode appears to work via normal runs, but crashes in the REPL. http://fpaste.org/145782/14506564/ [1]: https://issues.apache.org/jira/browse/MESOS-1973 [2]: https://github.com/apache/spark/pull/2401 [3]: https://github.com/apache/spark/pull/2453 On Tue, Oct 28, 2014 at 7:46 AM, Tim St Clair tstcl...@redhat.com wrote: Folks - We have some automated tests that run the latest Mesos against the latest Spark, and we've run across a series of issues in both fine, and course grained mode that I believe stem from a series of changes in the 0.21 cycle. I'm not certain if anyone owns this integration, but we should probably ensure it's fixed before we push out 0.21. -- Cheers, Timothy St. Clair Red Hat Inc. -- Cheers, Timothy St. Clair Red Hat Inc.
Re: 0.21.0-pre Spark latest
Hi Tim, Thanks for doing the integration tests, that's something that I wanted to do but never got to yet. I have great interest ensuring spark and mesos work, and I know Brenden as well does. I have been tracking these spark mesos problems with spark jira and labeling them mesos. Can you create these bugs on jira and we can dig more on each one? Also is this integration test automated? Thanks! Tim On Oct 28, 2014, at 8:03 AM, Tim St Clair tstcl...@redhat.com wrote: inline - Original Message - From: Brenden Matthews brenden.matth...@airbedandbreakfast.com To: u...@mesos.apache.org Cc: mesos-devel dev@mesos.apache.org, RJ Nowling rnowl...@redhat.com, Erik Erlandson e...@redhat.com Sent: Tuesday, October 28, 2014 9:51:58 AM Subject: Re: 0.21.0-pre Spark latest Since we've recently adopted Spark, I'll second Tim's comment. We had an issue with 0.20.1 that was possibly related to Spark[1], so it's important for us to get this stuff fixed in 0.21.0. Tim, can you elaborate on the issues you saw? Have you tested with my recent Spark patches[2][3]? We are building against Spark 1.1.0 unpatched: - Fine grained mode appears broken. - Course grained mode appears to work via normal runs, but crashes in the REPL. http://fpaste.org/145782/14506564/ [1]: https://issues.apache.org/jira/browse/MESOS-1973 [2]: https://github.com/apache/spark/pull/2401 [3]: https://github.com/apache/spark/pull/2453 On Tue, Oct 28, 2014 at 7:46 AM, Tim St Clair tstcl...@redhat.com wrote: Folks - We have some automated tests that run the latest Mesos against the latest Spark, and we've run across a series of issues in both fine, and course grained mode that I believe stem from a series of changes in the 0.21 cycle. I'm not certain if anyone owns this integration, but we should probably ensure it's fixed before we push out 0.21. -- Cheers, Timothy St. Clair Red Hat Inc. -- Cheers, Timothy St. Clair Red Hat Inc.
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2499
@benh and @timchen: can you take a look at the failing test? On Tue, Oct 28, 2014 at 1:21 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2499/changes Changes: [dave] Add Groupon and LIFX to PoweredByMesos documentation. -- [...truncated 63968 lines...] I1028 08:20:16.717905 4794 hierarchical_allocator_process.hpp:329] Added framework 20141028-082016-3142697795-52878-4771- I1028 08:20:16.717926 4794 hierarchical_allocator_process.hpp:697] No resources available to allocate! I1028 08:20:16.717938 4794 hierarchical_allocator_process.hpp:659] Performed allocation for 0 slaves in 15009ns I1028 08:20:16.717949 4799 sched.cpp:407] Framework registered with 20141028-082016-3142697795-52878-4771- I1028 08:20:16.717983 4799 sched.cpp:421] Scheduler::registered took 16736ns I1028 08:20:16.735296 4785 master.cpp:1362] Received registration request for framework 'default' at scheduler-f197f471-a430-458c-b179-76e944d42c26@67.195.81.187:52878 I1028 08:20:16.735385 4785 master.cpp:1321] Authorizing framework principal 'test-principal' to receive offers for role '*' I1028 08:20:16.735765 4789 master.cpp:1413] Framework 20141028-082016-3142697795-52878-4771- (default) at scheduler-f197f471-a430-458c-b179-76e944d42c26@67.195.81.187:52878 already registered, resending acknowledgement I1028 08:20:16.735998 4791 sched.cpp:394] Ignoring framework registered message because the driver is already connected! I1028 08:20:16.745360 4798 process.cpp:3358] Handling HTTP event for process 'metrics' with path: '/metrics/snapshot' I1028 08:20:16.756767 4797 hierarchical_allocator_process.hpp:697] No resources available to allocate! I1028 08:20:16.756791 4797 hierarchical_allocator_process.hpp:659] Performed allocation for 0 slaves in 47253ns I1028 08:20:16.767102 4798 process.cpp:3358] Handling HTTP event for process 'metrics' with path: '/metrics/snapshot' I1028 08:20:16.778391 4796 master.cpp:1362] Received registration request for framework 'default' at scheduler-f197f471-a430-458c-b179-76e944d42c26@67.195.81.187:52878 I1028 08:20:16.778446 4796 master.cpp:1321] Authorizing framework principal 'test-principal' to receive offers for role '*' I1028 08:20:16.778884 4797 master.cpp:1413] Framework 20141028-082016-3142697795-52878-4771- (default) at scheduler-f197f471-a430-458c-b179-76e944d42c26@67.195.81.187:52878 already registered, resending acknowledgement I1028 08:20:16.779063 4791 sched.cpp:394] Ignoring framework registered message because the driver is already connected! I1028 08:20:16.788471 4797 process.cpp:3358] Handling HTTP event for process 'metrics' with path: '/metrics/snapshot' I1028 08:20:16.799461 4771 master.cpp:677] Master terminating I1028 08:20:16.799495 4796 sched.cpp:745] Stopping framework '20141028-082016-3142697795-52878-4771-' [ OK ] RateLimitingTest.RateLimitingEnabled (146 ms) [--] 6 tests from RateLimitingTest (3430 ms total) [--] 2 tests from CpuIsolatorTest/2, where TypeParam = mesos::internal::tests::Modulemesos::internal::slave::Isolator, (mesos::internal::tests::ModuleID)1 [ RUN ] CpuIsolatorTest/2.UserCpuUsage Using temporary directory '/tmp/CpuIsolatorTest_2_UserCpuUsage_LXv7g0' I1028 08:20:16.807584 4771 launcher.cpp:137] Forked child with pid '9391' for container 'user_cpu_usage' [ OK ] CpuIsolatorTest/2.UserCpuUsage (404 ms) [ RUN ] CpuIsolatorTest/2.SystemCpuUsage Using temporary directory '/tmp/CpuIsolatorTest_2_SystemCpuUsage_9V5jvn' I1028 08:20:17.211205 4771 launcher.cpp:137] Forked child with pid '9395' for container 'system_cpu_usage' [ OK ] CpuIsolatorTest/2.SystemCpuUsage (401 ms) [--] 2 tests from CpuIsolatorTest/2 (805 ms total) [--] 2 tests from PathsTest [ RUN ] PathsTest.CreateExecutorDirectory [ OK ] PathsTest.CreateExecutorDirectory (2 ms) [ RUN ] PathsTest.format [ OK ] PathsTest.format (2 ms) [--] 2 tests from PathsTest (4 ms total) [--] 1 test from WhitelistTest [ RUN ] WhitelistTest.WhitelistSlave Using temporary directory '/tmp/WhitelistTest_WhitelistSlave_bNbAfd' I1028 08:20:17.616255 4771 leveldb.cpp:176] Opened db in 2.934878ms I1028 08:20:17.617570 4771 leveldb.cpp:183] Compacted db in 1.218266ms I1028 08:20:17.617655 4771 leveldb.cpp:198] Created db iterator in 29777ns I1028 08:20:17.617673 4771 leveldb.cpp:204] Seeked to beginning of db in 3105ns I1028 08:20:17.617681 4771 leveldb.cpp:273] Iterated through 0 keys in the db in 325ns I1028 08:20:17.617738 4771 replica.cpp:741] Replica recovered with log positions 0 - 0 with 1 holes and 0 unlearned I1028 08:20:17.618621 4794 recover.cpp:437] Starting replica recovery I1028 08:20:17.618971 4794 recover.cpp:463] Replica
Re: 0.21.0-pre Spark latest
Hi RJ, I see, are you or the team on working on this problem already? If not I'd like to take a look as well. Tim On Tue, Oct 28, 2014 at 8:47 AM, RJ Nowling rnowl...@redhat.com wrote: Hi Tim, The integration test is simply to open the spark shell (Spark 1.1.0) using mesos 0.21 in coarse-grained mode. We didn't even have to run any commands. RJ - Original Message - From: Timothy Chen tnac...@gmail.com To: dev@mesos.apache.org Cc: u...@mesos.apache.org, RJ Nowling rnowl...@redhat.com, Erik Erlandson e...@redhat.com Sent: Tuesday, October 28, 2014 11:40:19 AM Subject: Re: 0.21.0-pre Spark latest Hi Tim, Thanks for doing the integration tests, that's something that I wanted to do but never got to yet. I have great interest ensuring spark and mesos work, and I know Brenden as well does. I have been tracking these spark mesos problems with spark jira and labeling them mesos. Can you create these bugs on jira and we can dig more on each one? Also is this integration test automated? Thanks! Tim On Oct 28, 2014, at 8:03 AM, Tim St Clair tstcl...@redhat.com wrote: inline - Original Message - From: Brenden Matthews brenden.matth...@airbedandbreakfast.com To: u...@mesos.apache.org Cc: mesos-devel dev@mesos.apache.org, RJ Nowling rnowl...@redhat.com, Erik Erlandson e...@redhat.com Sent: Tuesday, October 28, 2014 9:51:58 AM Subject: Re: 0.21.0-pre Spark latest Since we've recently adopted Spark, I'll second Tim's comment. We had an issue with 0.20.1 that was possibly related to Spark[1], so it's important for us to get this stuff fixed in 0.21.0. Tim, can you elaborate on the issues you saw? Have you tested with my recent Spark patches[2][3]? We are building against Spark 1.1.0 unpatched: - Fine grained mode appears broken. - Course grained mode appears to work via normal runs, but crashes in the REPL. http://fpaste.org/145782/14506564/ [1]: https://issues.apache.org/jira/browse/MESOS-1973 [2]: https://github.com/apache/spark/pull/2401 [3]: https://github.com/apache/spark/pull/2453 On Tue, Oct 28, 2014 at 7:46 AM, Tim St Clair tstcl...@redhat.com wrote: Folks - We have some automated tests that run the latest Mesos against the latest Spark, and we've run across a series of issues in both fine, and course grained mode that I believe stem from a series of changes in the 0.21 cycle. I'm not certain if anyone owns this integration, but we should probably ensure it's fixed before we push out 0.21. -- Cheers, Timothy St. Clair Red Hat Inc. -- Cheers, Timothy St. Clair Red Hat Inc.
Re: Review Request 27252: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27252/#review58817 --- Ship it! Ship It! - Timothy St. Clair On Oct. 27, 2014, 11:22 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27252/ --- (Updated Oct. 27, 2014, 11:22 p.m.) Review request for mesos and Timothy St. Clair. Bugs: mesos-1985 and mesos-898 https://issues.apache.org/jira/browse/mesos-1985 https://issues.apache.org/jira/browse/mesos-898 Repository: mesos-git Description --- Reworks buiding mesos in a debug vs. a release configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity None: '-O0 -g1' --enable-optimize == '-O2' --enable-debug == '-g' --enable-optimize --enable-debug == '-O2 -g' If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use). Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked into later to enable extra logging and the like. For release builds we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion. Diffs - 3rdparty/libprocess/configure.ac ee482fcc312199823040798ac3c279d03d92c19f Diff: https://reviews.apache.org/r/27252/diff/ Testing --- Tested all four combinations of flags, making sure they set the right CXXFLAGS. Also specified Thanks, Cody Maloney
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2221
-MD5 I1028 02:38:13.649723 11898 authenticatee.hpp:250] Attempting to authenticate with mechanism 'CRAM-MD5' I1028 02:38:13.649793 11903 master.cpp:3853] Authenticating slave(28)@ 67.195.81.187:39931 I1028 02:38:13.649809 11896 authenticator.hpp:267] Received SASL authentication start I1028 02:38:13.649863 11896 authenticator.hpp:389] Authentication requires more steps I1028 02:38:13.649957 11900 authenticatee.hpp:270] Received SASL authentication step I1028 02:38:13.649961 11898 authenticator.hpp:161] Creating new server SASL connection I1028 02:38:13.650054 11900 authenticator.hpp:295] Received SASL authentication step I1028 02:38:13.650084 11900 auxprop.cpp:81] Request to lookup properties for user: 'test-principal' realm: 'pomona.apache.org' server FQDN: ' pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I1028 02:38:13.650100 11900 auxprop.cpp:153] Looking up auxiliary property '*userPassword' I1028 02:38:13.650142 11897 authenticatee.hpp:224] Received SASL authentication mechanisms: CRAM-MD5 I1028 02:38:13.650187 11897 authenticatee.hpp:250] Attempting to authenticate with mechanism 'CRAM-MD5' I1028 02:38:13.650151 11900 auxprop.cpp:153] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I1028 02:38:13.650265 11900 auxprop.cpp:81] Request to lookup properties for user: 'test-principal' realm: 'pomona.apache.org' server FQDN: ' pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true I1028 02:38:13.650357 11900 auxprop.cpp:103] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I1028 02:38:13.650364 11900 auxprop.cpp:103] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I1028 02:38:13.650387 11900 authenticator.hpp:381] Authentication success I1028 02:38:13.650293 11897 authenticator.hpp:267] Received SASL authentication start I1028 02:38:13.650456 11897 authenticator.hpp:389] Authentication requires more steps I1028 02:38:13.650511 11898 authenticatee.hpp:310] Authentication success I1028 02:38:13.650609 11904 authenticatee.hpp:270] Received SASL authentication step I1028 02:38:13.650616 11900 master.cpp:3893] Successfully authenticated principal 'test-principal' at scheduler-fa6faf5c-dace-42f2-a5ab-d32295e6006e@67.195.81.187:39931 I1028 02:38:13.650682 11904 authenticator.hpp:295] Received SASL authentication step I1028 02:38:13.650714 11904 auxprop.cpp:81] Request to lookup properties for user: 'test-principal' realm: 'pomona.apache.org' server FQDN: ' pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I1028 02:38:13.650732 11904 auxprop.cpp:153] Looking up auxiliary property '*userPassword' I1028 02:38:13.650774 11904 auxprop.cpp:153] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I1028 02:38:13.650805 11904 auxprop.cpp:81] Request to lookup properties for user: 'test-principal' realm: 'pomona.apache.org' server FQDN: ' pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true I1028 02:38:13.650820 11904 auxprop.cpp:103] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I1028 02:38:13.650831 11904 auxprop.cpp:103] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I1028 02:38:13.650851 11904 authenticator.hpp:381] Authentication success I1028 02:38:13.650931 11894 authenticatee.hpp:310] Authentication success I1028 02:38:13.650926 11896 sched.cpp:357] Successfully authenticated with master master@67.195.81.187:39931 I1028 02:38:13.650966 11896 sched.cpp:476] Sending registration request to master@67.195.81.187:39931 I1028 02:38:13.650967 11899 master.cpp:3893] Successfully authenticated principal 'test-principal' at slave(28)@67.195.81.187:39931 I1028 02:38:13.651166 11897 slave.cpp:722] Successfully authenticated with master master@67.195.81.187:39931 I1028 02:38:13.651206 11899 master.cpp:1362] Received registration request for framework 'default' at scheduler-fa6faf5c-dace-42f2-a5ab-d32295e6006e@67.195.81.187:39931 I1028 02:38:13.651298 11899 master.cpp:1321] Authorizing framework principal 'test-principal' to receive offers for role '*' I1028 02:38:13.651316 11897 slave.cpp:1050] Will retry registration in 1.610177ms if necessary I1028 02:38:13.651870 11899 master.cpp:3032] Registering slave at slave(28)@67.195.81.187:39931 (pomona.apache.org) with id 20141028-023804-3142697795-39931-11875-S0 I1028 02:38:13.652227 11899 master.cpp:1426] Registering framework 20141028-023804-3142697795-39931-11875- (default) at scheduler-fa6faf5c-dace-42f2-a5ab-d32295e6006e@67.195.81.187:39931 I1028 02:38:13.652349 11904 registrar.cpp:445] Applied 1 operations in 87188ns; attempting to update the 'registry' I1028 02:38:13.652542 11891
Re: Review Request 27252: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27252/#review58836 --- Ship it! Ship It! - Timothy St. Clair On Oct. 27, 2014, 11:22 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27252/ --- (Updated Oct. 27, 2014, 11:22 p.m.) Review request for mesos and Timothy St. Clair. Bugs: mesos-1985 and mesos-898 https://issues.apache.org/jira/browse/mesos-1985 https://issues.apache.org/jira/browse/mesos-898 Repository: mesos-git Description --- Reworks buiding mesos in a debug vs. a release configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity None: '-O0 -g1' --enable-optimize == '-O2' --enable-debug == '-g' --enable-optimize --enable-debug == '-O2 -g' If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use). Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked into later to enable extra logging and the like. For release builds we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion. Diffs - 3rdparty/libprocess/configure.ac ee482fcc312199823040798ac3c279d03d92c19f Diff: https://reviews.apache.org/r/27252/diff/ Testing --- Tested all four combinations of flags, making sure they set the right CXXFLAGS. Also specified Thanks, Cody Maloney
Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2498
Appears to be just the slowness of the build box (its disk): I1028 02:38:46.849603 9003 coordinator.cpp:340] Coordinator attempting to write TRUNCATE action at position 4 I1028 02:38:46.849669 9009 slave.cpp:2522] Received ping from slave-observer(182)@67.195.81.187:33379 I1028 02:38:46.850030 8999 hierarchical_allocator_process.hpp:442] Added slave 20141028-023846-3142697795-33379-8981-S0 (pomona.apache.org) with cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] (and cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] available) I1028 02:38:46.850214 9004 replica.cpp:508] Replica received write request for position 4 I1028 02:38:46.850265 8999 hierarchical_allocator_process.hpp:734] Offering cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] on slave 20141028-023846-3142697795-33379-8981-S0 to framework 20141028-023846-3142697795-33379-8981- I../../src/tests/master_authorization_tests.cpp:244: Failure Failed to wait 10secs for offers ../../src/tests/master_authorization_tests.cpp:238: Failure Actual function call count doesn't match EXPECT_CALL(sched, resourceOffers(driver, _))... Expected: to be called at least once Actual: never called - unsatisfied and active` 1028 02:38:46.850360 8998 master.cpp:3086] Registered slave 20141028-023846-3142697795-33379-8981-S0 at slave(203)@67.195.81.187:33379 ( pomona.apache.org) with cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] I1028 02:38:46.850438 9009 slave.cpp:756] Registered with master master@67.195.81.187:33379; given slave ID 20141028-023846-3142697795-33379-8981-S0 I1028 02:38:46.850680 9004 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 440959ns I1028 02:38:46.850715 8999 hierarchical_allocator_process.hpp:679] Performed allocation for slave 20141028-023846-3142697795-33379-8981-S0 in 606258ns I1028 02:38:51.348700 9000 master.cpp:120] No whitelist given. Advertising offers for all slaves I1028 02:39:07.113581 9004 replica.cpp:676] Persisted action at 4 I1028 02:39:07.114874 8996 status_update_manager.cpp:178] Resuming sending status updates I1028 02:39:07.115105 9009 slave.cpp:2522] Received ping from slave-observer(182)@67.195.81.187:33379 I1028 02:39:07.115129 8999 hierarchical_allocator_process.hpp:659] Performed allocation for 1 slaves in 235330ns I1028 02:39:07.115429 8998 master.cpp:3795] Sending 1 offers to framework 20141028-023846-3142697795-33379-8981- (default) at scheduler-5f51928e-4576-41a0-ac20-b629e535af9c@67.195.81.187:33379 Master sent the offer after the 10sec deadline. -- Jiang Yan Xu y...@jxu.me @xujyan http://twitter.com/xujyan On Mon, Oct 27, 2014 at 7:41 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2498/changes Changes: [tnachen] Added support for both 1.8 and earlier versions of svn library. -- [...truncated 64049 lines...] I1028 02:40:10.677944 8999 replica.cpp:508] Replica received write request for position 5 I1028 02:40:10.678493 8999 leveldb.cpp:343] Persisting action (159 bytes) to leveldb took 518803ns I1028 02:40:10.678514 8999 replica.cpp:676] Persisted action at 5 I1028 02:40:10.678982 9010 replica.cpp:655] Replica received learned notice for position 5 I1028 02:40:10.679489 9010 leveldb.cpp:343] Persisting action (161 bytes) to leveldb took 485019ns I1028 02:40:10.679512 9010 replica.cpp:676] Persisted action at 5 I1028 02:40:10.679532 9010 replica.cpp:661] Replica learned APPEND action at position 5 I1028 02:40:10.680330 8997 registrar.cpp:490] Successfully updated the 'registry' in 0ns I1028 02:40:10.680462 9000 master.cpp:4527] Removed slave 20141028-024010-3142697795-33379-8981-S0 (pomona.apache.org) I1028 02:40:10.680486 9000 master.cpp:4545] Notifying framework 20141028-024010-3142697795-33379-8981- (default) at scheduler-a122c3c4-95ac-4eba-851c-4fb6dba2fce6@67.195.81.187:33379 of lost slave 20141028-024010-3142697795-33379-8981-S0 (pomona.apache.org) after recovering I1028 02:40:10.680572 9005 log.cpp:699] Attempting to truncate the log to 5 I1028 02:40:10.680577 8999 sched.cpp:686] Lost slave 20141028-024010-3142697795-33379-8981-S0 I1028 02:40:10.680605 8999 sched.cpp:697] Scheduler::slaveLost took 16548ns I1028 02:40:10.680644 9003 coordinator.cpp:340] Coordinator attempting to write TRUNCATE action at position 6 I1028 02:40:10.681084 8998 replica.cpp:508] Replica received write request for position 6 I1028 02:40:10.681591 8998 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 485952ns I1028 02:40:10.681612 8998 replica.cpp:676] Persisted action at 6 I1028 02:40:10.682003 9002 replica.cpp:655] Replica received learned notice for position 6 I1028 02:40:10.682461 9002 leveldb.cpp:343] Persisting action (18 bytes) to leveldb took 441310ns I1028 02:40:10.682526
Review Request 27295: os::killtree() supports case when root pid has exited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1875 https://issues.apache.org/jira/browse/MESOS-1875 Repository: mesos-git Description --- Improve os::killtree() for the case when the root pid has exited and it has been instructed to either follow process groups or sessions. It will now kill all processes (and their trees) with pgid or session matching the root pid. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e0566078 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e9f37dfd3cf54c3ca85d74716b3ee4262b065fad Diff: https://reviews.apache.org/r/27295/diff/ Testing --- Added a test where the root pid exits (and is reaped), leaving behind a reparented subtree. This test initially fails. + // -+- child exit 0 [new session and process group leader] + // -+- grandchild sleep 100 + // -+- great grandchild sleep 100 Thanks, Ian Downes
Re: Review Request 27295: os::killtree() supports case when root pid has exited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/#review58855 --- Patch looks great! Reviews applied: [27295] All tests passed. - Mesos ReviewBot On Oct. 28, 2014, 6:28 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- (Updated Oct. 28, 2014, 6:28 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1875 https://issues.apache.org/jira/browse/MESOS-1875 Repository: mesos-git Description --- Improve os::killtree() for the case when the root pid has exited and it has been instructed to either follow process groups or sessions. It will now kill all processes (and their trees) with pgid or session matching the root pid. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e0566078 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e9f37dfd3cf54c3ca85d74716b3ee4262b065fad Diff: https://reviews.apache.org/r/27295/diff/ Testing --- Added a test where the root pid exits (and is reaped), leaving behind a reparented subtree. This test initially fails. + // -+- child exit 0 [new session and process group leader] + // -+- grandchild sleep 100 + // -+- great grandchild sleep 100 Thanks, Ian Downes
Build failed in Jenkins: mesos-reviewbot #2305
See https://builds.apache.org/job/mesos-reviewbot/2305/changes Changes: [idownes] Include changes to isolation flag when creating Mesos containerizer. [idownes] Move Linux namespace functions into linux/. [idownes] Add getns() for namespaces. [idownes] Add ns::pid::destroy() to destroy a pid namespace. [idownes] Remove Linux namespace functions from stout. [idownes] Pid namespace isolator for the MesosContainerizer. [idownes] Correctly recover pid in Linux launcher. [idownes] Use pid namespace to destroy container when available. -- [...truncated 3783 lines...] Note: Randomizing tests' orders with a seed of 80710 . [==] Running 0 tests from 0 test cases. [==] 0 tests from 0 test cases ran. (0 ms total) [ PASSED ] 0 tests. YOU HAVE 3 DISABLED TESTS make[6]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[5]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' Making check in include make[5]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/include' make[5]: Nothing to be done for `check'. make[5]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess/include' make[4]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty/libprocess' make[4]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty' make[4]: Nothing to be done for `check-am'. make[4]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty' make[3]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty' make[2]: Leaving directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/3rdparty' Making check in src make[2]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/src' make check-am make[3]: Entering directory `https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/src' test ../.. = .. || \ (/bin/mkdir -p python/src/mesos cp -pf ../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py) test ../.. = .. || \ (/bin/mkdir -p python/interface/src/mesos cp -pf ../../src/python/interface/src/mesos/__init__.py python/interface/src/mesos/__init__.py) test ../.. = .. || \ (/bin/mkdir -p python/interface/src/mesos/interface cp -pf ../../src/python/interface/src/mesos/interface/__init__.py python/interface/src/mesos/interface/__init__.py) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos cp -pf ../../src/python/native/src/mesos/__init__.py python/native/src/mesos/__init__.py) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/__init__.py python/native/src/mesos/native/__init__.py) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp python/native/src/mesos/native/mesos_executor_driver_impl.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp python/native/src/mesos/native/mesos_executor_driver_impl.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/module.cpp python/native/src/mesos/native/module.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/module.hpp python/native/src/mesos/native/module.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_executor.cpp python/native/src/mesos/native/proxy_executor.cpp) test ../.. = .. || \ (/bin/mkdir -p
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2223
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2223/changes Changes: [idownes] Include changes to isolation flag when creating Mesos containerizer. [idownes] Move Linux namespace functions into linux/. [idownes] Add getns() for namespaces. [idownes] Add ns::pid::destroy() to destroy a pid namespace. [idownes] Remove Linux namespace functions from stout. [idownes] Pid namespace isolator for the MesosContainerizer. [idownes] Correctly recover pid in Linux launcher. [idownes] Use pid namespace to destroy container when available. -- [...truncated 3194 lines...] creating dist creating 'dist/protobuf-2.5.0-py2.7.egg' and adding 'build/bdist.linux-x86_64/egg' to it removing 'build/bdist.linux-x86_64/egg' (and everything under it) running bdist_egg running egg_info creating src/mesos.interface.egg-info writing requirements to src/mesos.interface.egg-info/requires.txt writing src/mesos.interface.egg-info/PKG-INFO writing namespace_packages to src/mesos.interface.egg-info/namespace_packages.txt writing top-level names to src/mesos.interface.egg-info/top_level.txt writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt writing requirements to src/mesos.interface.egg-info/requires.txt writing src/mesos.interface.egg-info/PKG-INFO writing namespace_packages to src/mesos.interface.egg-info/namespace_packages.txt writing top-level names to src/mesos.interface.egg-info/top_level.txt writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt' reading manifest file 'src/mesos.interface.egg-info/SOURCES.txt' writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt' installing library code to build/bdist.linux-x86_64/egg running install_lib running build_py creating build creating build/lib.linux-x86_64-2.7 creating build/lib.linux-x86_64-2.7/mesos copying src/mesos/__init__.py - build/lib.linux-x86_64-2.7/mesos creating build/lib.linux-x86_64-2.7/mesos/interface copying src/mesos/interface/__init__.py - build/lib.linux-x86_64-2.7/mesos/interface copying src/mesos/interface/containerizer_pb2.py - build/lib.linux-x86_64-2.7/mesos/interface copying src/mesos/interface/mesos_pb2.py - build/lib.linux-x86_64-2.7/mesos/interface creating build/bdist.linux-x86_64 creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/__init__.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/containerizer_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/mesos_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/__init__.py - build/bdist.linux-x86_64/egg/mesos byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/__init__.py to __init__.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/containerizer_pb2.py to containerizer_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/mesos_pb2.py to mesos_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc creating build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/PKG-INFO - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/SOURCES.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/dependency_links.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/namespace_packages.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/requires.txt - build/bdist.linux-x86_64/egg/EGG-INFO copying src/mesos.interface.egg-info/top_level.txt - build/bdist.linux-x86_64/egg/EGG-INFO zip_safe flag not set; analyzing archive contents... mesos.__init__: module references __path__ creating ../dist creating '../dist/mesos.interface-0.21.0-py2.7.egg' and adding 'build/bdist.linux-x86_64/egg' to it removing 'build/bdist.linux-x86_64/egg' (and everything under it) running bdist_wheel running build installing to build/bdist.linux-x86_64/wheel running install running install_lib Skipping installation of build/bdist.linux-x86_64/wheel/mesos/__init__.py (namespace package) copying mesos/interface/__init__.py - build/bdist.linux-x86_64/wheel/mesos/interface copying mesos/interface/containerizer_pb2.py - build/bdist.linux-x86_64/wheel/mesos/interface copying mesos/interface/mesos_pb2.py - build/bdist.linux-x86_64/wheel/mesos/interface running install_egg_info Copying src/mesos.interface.egg-info to build/bdist.linux-x86_64/wheel/mesos.interface-0.21.0-py2.7.egg-info Installing build/bdist.linux-x86_64/wheel/mesos.interface-0.21.0-py2.7-nspkg.pth running install_scripts creating build/bdist.linux-x86_64/wheel/mesos.interface-0.21.0.dist-info/WHEEL
Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess
We try to keep the commit messages short: *5) Follow the format of commit messages. The three important bits are (a) be clear and explicit in the commit message and (b) include the link to the review and © use 72 character columns. See support/apply-review.sh for committing someone else’s code (it will construct a commit message that you’ll still need to edit because it pulls in all of the ‘Description’ which might just be ‘See summary.’ which can be omitted). Note that we don’t always have a 50 character or less summary because that restriction tends to cause people to write poorly.* http://mesos.apache.org/documentation/latest/committers-guide/ Check out the commit log to see how this commit message is much longer than the others: * 743bb59 (HEAD, apache/master, master) Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess * 3fc81ce Correct include of linux/ns.hpp in isolator tests. * fa44b0a Use pid namespace to destroy container when available. * 823b992 Correctly recover pid in Linux launcher. * 7b196d2 Pid namespace isolator for the MesosContainerizer. * 691510a Remove Linux namespace functions from stout. * 0342113 Add ns::pid::destroy() to destroy a pid namespace. * 3650573 Add getns() for namespaces. * 57447a7 Move Linux namespace functions into linux/. * 2b8ad0b Include changes to isolation flag when creating Mesos containerizer. * 26824f8 Add Groupon and LIFX to PoweredByMesos documentation. * b2d8df7 Added support for both 1.8 and earlier versions of svn library. * 17ecc0c Added support for module-specific command-line parameters. * 1ff259e Added --isolation flag for tests. * 360e432 Add Artirix to PoweredByMesos list. * f511395 Introduce a shared filesytem isolator. * c18a50a Remove /proc and /sys remounts from port_mapping isolator. * 47fa5a1 Serialize isolator prepare and cleanup (reversed). * 8e6e36a Pass executor directory to Isolator::prepare(). * b493875 Adds Localsensor to PoweredByMesos documentation. * fc67600 Fixed line wrap in state/log.cpp. * d418c17 Added --with-apr and --with-svn to Mesos configure. * 7a1020e Added --with-apr and --with-svn to libprocess configure. * 6a778df Updated svn::diff/patch to use newer versions of functions. * fc6f59e Ensured post-reviews.py added newline between subject and body. * 33e625f Added DIFF to the replicated log state storage implementation. * 3b3d60f Added functionality to create SVN based diffs of arbitrary strings. * 61ce00f Added Java replicated log implementation of State. * 1f66bb2 Adds Wizcorp to PoweredByMesos page. * 4bbf727 Reordered functions in type_utils and added an equal comparator for Volume. * 1beacb8 Added documentation for egress rate limit control. * 6ffe580 Added a check in routing library due to a bug in libnl. * b4528ce PortMappingIsolator: Swap TX/RX in statistic collection in usage * 6a045e9 Introduced a FutureResult action. * d9381b0 Fixed a spelling mistake. * 12e0674 Mark running tasks killed during framework shutdown. On Tue, Oct 28, 2014 at 2:30 PM, tstcl...@apache.org wrote: Repository: mesos Updated Branches: refs/heads/master 3fc81ce92 - 743bb5941 Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess Reworks buiding mesos in a debug vs. a release configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity None: '-O0 -g1' --enable-optimize == '-O2' --enable-debug == '-g' --enable-optimize --enable-debug == '-O2 -g' If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use). Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked into later to enable extra logging and the like. For release builds we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion. Review: https://reviews.apache.org/r/27252 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/743bb594 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/743bb594 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/743bb594 Branch: refs/heads/master Commit: 743bb5941dd1b3549c76757d939a405ccaa0f279 Parents: 3fc81ce Author: Cody Maloney c...@mesosphere.io Authored: Tue Oct 28 15:55:40 2014 -0500 Committer: Timothy St. Clair tstcl...@redhat.com Committed: Tue Oct 28 16:30:08 2014 -0500 -- 3rdparty/libprocess/configure.ac | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-)
Build failed in Jenkins: mesos-reviewbot #2306
See https://builds.apache.org/job/mesos-reviewbot/2306/changes Changes: [idownes] Correct include of linux/ns.hpp in isolator tests. [tstclair] Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess -- [...truncated 3836 lines...] (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/module.cpp python/native/src/mesos/native/module.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/module.hpp python/native/src/mesos/native/module.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_executor.cpp python/native/src/mesos/native/proxy_executor.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_executor.hpp python/native/src/mesos/native/proxy_executor.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_scheduler.cpp python/native/src/mesos/native/proxy_scheduler.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_scheduler.hpp python/native/src/mesos/native/proxy_scheduler.hpp) running bdist_egg running egg_info writing requirements to src/mesos.interface.egg-info/requires.txt running bdist_egg running egg_info writing requirements to src/mesos.native.egg-info/requires.txt writing src/mesos.interface.egg-info/PKG-INFO writing src/mesos.native.egg-info/PKG-INFO writing namespace_packages to src/mesos.interface.egg-info/namespace_packages.txt writing namespace_packages to src/mesos.native.egg-info/namespace_packages.txt writing top-level names to src/mesos.interface.egg-info/top_level.txt writing top-level names to src/mesos.native.egg-info/top_level.txt writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt writing dependency_links to src/mesos.native.egg-info/dependency_links.txt writing requirements to src/mesos.interface.egg-info/requires.txt writing requirements to src/mesos.native.egg-info/requires.txt writing src/mesos.native.egg-info/PKG-INFO writing src/mesos.interface.egg-info/PKG-INFO writing namespace_packages to src/mesos.interface.egg-info/namespace_packages.txt writing namespace_packages to src/mesos.native.egg-info/namespace_packages.txt writing top-level names to src/mesos.interface.egg-info/top_level.txt writing top-level names to src/mesos.native.egg-info/top_level.txt writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt writing dependency_links to src/mesos.native.egg-info/dependency_links.txt reading manifest file 'src/mesos.interface.egg-info/SOURCES.txt' writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt' installing library code to build/bdist.linux-x86_64/egg reading manifest file 'src/mesos.native.egg-info/SOURCES.txt' running install_lib running build_py creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/__init__.py - build/bdist.linux-x86_64/egg/mesos/interface writing manifest file 'src/mesos.native.egg-info/SOURCES.txt' installing library code to build/bdist.linux-x86_64/egg copying build/lib.linux-x86_64-2.7/mesos/interface/containerizer_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/mesos_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/__init__.py - build/bdist.linux-x86_64/egg/mesos running install_lib running build_py byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/__init__.py to __init__.pyc running build_ext creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/native copying build/lib.linux-x86_64-2.7/mesos/native/_mesos.so - build/bdist.linux-x86_64/egg/mesos/native byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/containerizer_pb2.py to containerizer_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/mesos_pb2.py to mesos_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc creating build/bdist.linux-x86_64/egg/EGG-INFO copying
Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess
My apologies here. I had ran support/apply-review.sh and had not trim'd the commit message. -Tim - Original Message - From: Benjamin Mahler benjamin.mah...@gmail.com To: dev dev@mesos.apache.org Cc: comm...@mesos.apache.org Sent: Tuesday, October 28, 2014 4:38:49 PM Subject: Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess We try to keep the commit messages short: *5) Follow the format of commit messages. The three important bits are (a) be clear and explicit in the commit message and (b) include the link to the review and © use 72 character columns. See support/apply-review.sh for committing someone else’s code (it will construct a commit message that you’ll still need to edit because it pulls in all of the ‘Description’ which might just be ‘See summary.’ which can be omitted). Note that we don’t always have a 50 character or less summary because that restriction tends to cause people to write poorly.* http://mesos.apache.org/documentation/latest/committers-guide/ Check out the commit log to see how this commit message is much longer than the others: * 743bb59 (HEAD, apache/master, master) Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess * 3fc81ce Correct include of linux/ns.hpp in isolator tests. * fa44b0a Use pid namespace to destroy container when available. * 823b992 Correctly recover pid in Linux launcher. * 7b196d2 Pid namespace isolator for the MesosContainerizer. * 691510a Remove Linux namespace functions from stout. * 0342113 Add ns::pid::destroy() to destroy a pid namespace. * 3650573 Add getns() for namespaces. * 57447a7 Move Linux namespace functions into linux/. * 2b8ad0b Include changes to isolation flag when creating Mesos containerizer. * 26824f8 Add Groupon and LIFX to PoweredByMesos documentation. * b2d8df7 Added support for both 1.8 and earlier versions of svn library. * 17ecc0c Added support for module-specific command-line parameters. * 1ff259e Added --isolation flag for tests. * 360e432 Add Artirix to PoweredByMesos list. * f511395 Introduce a shared filesytem isolator. * c18a50a Remove /proc and /sys remounts from port_mapping isolator. * 47fa5a1 Serialize isolator prepare and cleanup (reversed). * 8e6e36a Pass executor directory to Isolator::prepare(). * b493875 Adds Localsensor to PoweredByMesos documentation. * fc67600 Fixed line wrap in state/log.cpp. * d418c17 Added --with-apr and --with-svn to Mesos configure. * 7a1020e Added --with-apr and --with-svn to libprocess configure. * 6a778df Updated svn::diff/patch to use newer versions of functions. * fc6f59e Ensured post-reviews.py added newline between subject and body. * 33e625f Added DIFF to the replicated log state storage implementation. * 3b3d60f Added functionality to create SVN based diffs of arbitrary strings. * 61ce00f Added Java replicated log implementation of State. * 1f66bb2 Adds Wizcorp to PoweredByMesos page. * 4bbf727 Reordered functions in type_utils and added an equal comparator for Volume. * 1beacb8 Added documentation for egress rate limit control. * 6ffe580 Added a check in routing library due to a bug in libnl. * b4528ce PortMappingIsolator: Swap TX/RX in statistic collection in usage * 6a045e9 Introduced a FutureResult action. * d9381b0 Fixed a spelling mistake. * 12e0674 Mark running tasks killed during framework shutdown. On Tue, Oct 28, 2014 at 2:30 PM, tstcl...@apache.org wrote: Repository: mesos Updated Branches: refs/heads/master 3fc81ce92 - 743bb5941 Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess Reworks buiding mesos in a debug vs. a release configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity None: '-O0 -g1' --enable-optimize == '-O2' --enable-debug == '-g' --enable-optimize --enable-debug == '-O2 -g' If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use). Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked into later to enable extra logging and the like. For release builds we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion. Review: https://reviews.apache.org/r/27252 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/743bb594 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/743bb594 Diff:
Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess
I'll try and keep my review board titles a little shorter in the future as well to help prevent this. Cody On Tue, Oct 28, 2014 at 3:05 PM, Tim St Clair tstcl...@redhat.com wrote: My apologies here. I had ran support/apply-review.sh and had not trim'd the commit message. -Tim - Original Message - From: Benjamin Mahler benjamin.mah...@gmail.com To: dev dev@mesos.apache.org Cc: comm...@mesos.apache.org Sent: Tuesday, October 28, 2014 4:38:49 PM Subject: Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess We try to keep the commit messages short: *5) Follow the format of commit messages. The three important bits are (a) be clear and explicit in the commit message and (b) include the link to the review and © use 72 character columns. See support/apply-review.sh for committing someone else’s code (it will construct a commit message that you’ll still need to edit because it pulls in all of the ‘Description’ which might just be ‘See summary.’ which can be omitted). Note that we don’t always have a 50 character or less summary because that restriction tends to cause people to write poorly.* http://mesos.apache.org/documentation/latest/committers-guide/ Check out the commit log to see how this commit message is much longer than the others: * 743bb59 (HEAD, apache/master, master) Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess * 3fc81ce Correct include of linux/ns.hpp in isolator tests. * fa44b0a Use pid namespace to destroy container when available. * 823b992 Correctly recover pid in Linux launcher. * 7b196d2 Pid namespace isolator for the MesosContainerizer. * 691510a Remove Linux namespace functions from stout. * 0342113 Add ns::pid::destroy() to destroy a pid namespace. * 3650573 Add getns() for namespaces. * 57447a7 Move Linux namespace functions into linux/. * 2b8ad0b Include changes to isolation flag when creating Mesos containerizer. * 26824f8 Add Groupon and LIFX to PoweredByMesos documentation. * b2d8df7 Added support for both 1.8 and earlier versions of svn library. * 17ecc0c Added support for module-specific command-line parameters. * 1ff259e Added --isolation flag for tests. * 360e432 Add Artirix to PoweredByMesos list. * f511395 Introduce a shared filesytem isolator. * c18a50a Remove /proc and /sys remounts from port_mapping isolator. * 47fa5a1 Serialize isolator prepare and cleanup (reversed). * 8e6e36a Pass executor directory to Isolator::prepare(). * b493875 Adds Localsensor to PoweredByMesos documentation. * fc67600 Fixed line wrap in state/log.cpp. * d418c17 Added --with-apr and --with-svn to Mesos configure. * 7a1020e Added --with-apr and --with-svn to libprocess configure. * 6a778df Updated svn::diff/patch to use newer versions of functions. * fc6f59e Ensured post-reviews.py added newline between subject and body. * 33e625f Added DIFF to the replicated log state storage implementation. * 3b3d60f Added functionality to create SVN based diffs of arbitrary strings. * 61ce00f Added Java replicated log implementation of State. * 1f66bb2 Adds Wizcorp to PoweredByMesos page. * 4bbf727 Reordered functions in type_utils and added an equal comparator for Volume. * 1beacb8 Added documentation for egress rate limit control. * 6ffe580 Added a check in routing library due to a bug in libnl. * b4528ce PortMappingIsolator: Swap TX/RX in statistic collection in usage * 6a045e9 Introduced a FutureResult action. * d9381b0 Fixed a spelling mistake. * 12e0674 Mark running tasks killed during framework shutdown. On Tue, Oct 28, 2014 at 2:30 PM, tstcl...@apache.org wrote: Repository: mesos Updated Branches: refs/heads/master 3fc81ce92 - 743bb5941 Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess Reworks buiding mesos in a debug vs. a release configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity None: '-O0 -g1' --enable-optimize == '-O2' --enable-debug == '-g' --enable-optimize --enable-debug == '-O2 -g' If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use). Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked into later to enable extra logging and the like. For release builds we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion. Review:
Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess
Thanks guys! On Tue, Oct 28, 2014 at 3:09 PM, Cody Maloney c...@mesosphere.io wrote: I'll try and keep my review board titles a little shorter in the future as well to help prevent this. Cody On Tue, Oct 28, 2014 at 3:05 PM, Tim St Clair tstcl...@redhat.com wrote: My apologies here. I had ran support/apply-review.sh and had not trim'd the commit message. -Tim - Original Message - From: Benjamin Mahler benjamin.mah...@gmail.com To: dev dev@mesos.apache.org Cc: comm...@mesos.apache.org Sent: Tuesday, October 28, 2014 4:38:49 PM Subject: Re: git commit: Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess We try to keep the commit messages short: *5) Follow the format of commit messages. The three important bits are (a) be clear and explicit in the commit message and (b) include the link to the review and © use 72 character columns. See support/apply-review.sh for committing someone else’s code (it will construct a commit message that you’ll still need to edit because it pulls in all of the ‘Description’ which might just be ‘See summary.’ which can be omitted). Note that we don’t always have a 50 character or less summary because that restriction tends to cause people to write poorly.* http://mesos.apache.org/documentation/latest/committers-guide/ Check out the commit log to see how this commit message is much longer than the others: * 743bb59 (HEAD, apache/master, master) Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess * 3fc81ce Correct include of linux/ns.hpp in isolator tests. * fa44b0a Use pid namespace to destroy container when available. * 823b992 Correctly recover pid in Linux launcher. * 7b196d2 Pid namespace isolator for the MesosContainerizer. * 691510a Remove Linux namespace functions from stout. * 0342113 Add ns::pid::destroy() to destroy a pid namespace. * 3650573 Add getns() for namespaces. * 57447a7 Move Linux namespace functions into linux/. * 2b8ad0b Include changes to isolation flag when creating Mesos containerizer. * 26824f8 Add Groupon and LIFX to PoweredByMesos documentation. * b2d8df7 Added support for both 1.8 and earlier versions of svn library. * 17ecc0c Added support for module-specific command-line parameters. * 1ff259e Added --isolation flag for tests. * 360e432 Add Artirix to PoweredByMesos list. * f511395 Introduce a shared filesytem isolator. * c18a50a Remove /proc and /sys remounts from port_mapping isolator. * 47fa5a1 Serialize isolator prepare and cleanup (reversed). * 8e6e36a Pass executor directory to Isolator::prepare(). * b493875 Adds Localsensor to PoweredByMesos documentation. * fc67600 Fixed line wrap in state/log.cpp. * d418c17 Added --with-apr and --with-svn to Mesos configure. * 7a1020e Added --with-apr and --with-svn to libprocess configure. * 6a778df Updated svn::diff/patch to use newer versions of functions. * fc6f59e Ensured post-reviews.py added newline between subject and body. * 33e625f Added DIFF to the replicated log state storage implementation. * 3b3d60f Added functionality to create SVN based diffs of arbitrary strings. * 61ce00f Added Java replicated log implementation of State. * 1f66bb2 Adds Wizcorp to PoweredByMesos page. * 4bbf727 Reordered functions in type_utils and added an equal comparator for Volume. * 1beacb8 Added documentation for egress rate limit control. * 6ffe580 Added a check in routing library due to a bug in libnl. * b4528ce PortMappingIsolator: Swap TX/RX in statistic collection in usage * 6a045e9 Introduced a FutureResult action. * d9381b0 Fixed a spelling mistake. * 12e0674 Mark running tasks killed during framework shutdown. On Tue, Oct 28, 2014 at 2:30 PM, tstcl...@apache.org wrote: Repository: mesos Updated Branches: refs/heads/master 3fc81ce92 - 743bb5941 Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess Reworks buiding mesos in a debug vs. a release configuration. By default, mesos is built in a developer-centric setup (No optimizations, minimal debug info), in order to maximize developer productivity None: '-O0 -g1' --enable-optimize == '-O2' --enable-debug == '-g' --enable-optimize --enable-debug == '-O2 -g' If a user / developer passes CXXFLAGS or CFLAGS manually, then they are not changed / touched at all. This is important so that Mesos is a good citizen when being built for various distributions (As well as making it so specialized one-off groupings of flags are feasible to use). Adds two defines for accessing what mode things are being built in: 'DEBUG' and 'OPTIMIZE' which can be hooked
Build failed in Jenkins: Mesos-Ubuntu-distcheck #451
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/451/changes Changes: [idownes] Correct include of linux/ns.hpp in isolator tests. [tstclair] Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess -- [...truncated 3774 lines...] g++ -DPACKAGE_NAME=\libprocess\ -DPACKAGE_TARNAME=\libprocess\ -DPACKAGE_VERSION=\0.0.1\ -DPACKAGE_STRING=\libprocess\ 0.0.1\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\libprocess\ -DVERSION=\0.0.1\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_LIBAPR_1=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/src -I3rdparty/gmock-1.6.0/gtest/include -I3rdparty/gmock-1.6.0/include -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT tests-reap_tests.o -MD -MP -MF .deps/tests-reap_tests.Tpo -c -o tests-reap_tests.o `test -f 'src/tests/reap_tests.cpp' || echo '../../../3rdparty/libprocess/'`src/tests/reap_tests.cpp mv -f .deps/tests-reap_tests.Tpo .deps/tests-reap_tests.Po g++ -DPACKAGE_NAME=\libprocess\ -DPACKAGE_TARNAME=\libprocess\ -DPACKAGE_VERSION=\0.0.1\ -DPACKAGE_STRING=\libprocess\ 0.0.1\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\libprocess\ -DVERSION=\0.0.1\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_LIBAPR_1=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/src -I3rdparty/gmock-1.6.0/gtest/include -I3rdparty/gmock-1.6.0/include -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT tests-sequence_tests.o -MD -MP -MF .deps/tests-sequence_tests.Tpo -c -o tests-sequence_tests.o `test -f 'src/tests/sequence_tests.cpp' || echo '../../../3rdparty/libprocess/'`src/tests/sequence_tests.cpp mv -f .deps/tests-sequence_tests.Tpo .deps/tests-sequence_tests.Po g++ -DPACKAGE_NAME=\libprocess\ -DPACKAGE_TARNAME=\libprocess\ -DPACKAGE_VERSION=\0.0.1\ -DPACKAGE_STRING=\libprocess\ 0.0.1\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\libprocess\ -DVERSION=\0.0.1\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_LIBAPR_1=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/src -I3rdparty/gmock-1.6.0/gtest/include -I3rdparty/gmock-1.6.0/include -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/3rdparty/stout/include -I3rdparty/boost-1.53.0 -I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 -I3rdparty/glog-0.3.3/src -I3rdparty/ry-http-parser-1c3624a -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -MT tests-shared_tests.o -MD -MP -MF .deps/tests-shared_tests.Tpo -c -o tests-shared_tests.o `test -f 'src/tests/shared_tests.cpp' || echo '../../../3rdparty/libprocess/'`src/tests/shared_tests.cpp mv -f .deps/tests-shared_tests.Tpo .deps/tests-shared_tests.Po g++ -DPACKAGE_NAME=\libprocess\ -DPACKAGE_TARNAME=\libprocess\ -DPACKAGE_VERSION=\0.0.1\ -DPACKAGE_STRING=\libprocess\ 0.0.1\ -DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\libprocess\ -DVERSION=\0.0.1\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\.libs/\ -DHAVE_LIBAPR_1=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_LIBCURL=1 -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/src -I3rdparty/gmock-1.6.0/gtest/include -I3rdparty/gmock-1.6.0/include
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2501
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2501/changes
Build failed in Jenkins: mesos-reviewbot #2307
See https://builds.apache.org/job/mesos-reviewbot/2307/ -- [...truncated 3946 lines...] (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/module.cpp python/native/src/mesos/native/module.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/module.hpp python/native/src/mesos/native/module.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_executor.cpp python/native/src/mesos/native/proxy_executor.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_executor.hpp python/native/src/mesos/native/proxy_executor.hpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_scheduler.cpp python/native/src/mesos/native/proxy_scheduler.cpp) test ../.. = .. || \ (/bin/mkdir -p python/native/src/mesos/native cp -pf ../../src/python/native/src/mesos/native/proxy_scheduler.hpp python/native/src/mesos/native/proxy_scheduler.hpp) running bdist_egg running egg_info writing requirements to src/mesos.interface.egg-info/requires.txt writing src/mesos.interface.egg-info/PKG-INFO running bdist_egg writing namespace_packages to src/mesos.interface.egg-info/namespace_packages.txt writing top-level names to src/mesos.interface.egg-info/top_level.txt writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt writing requirements to src/mesos.interface.egg-info/requires.txt running egg_info writing requirements to src/mesos.native.egg-info/requires.txt writing src/mesos.interface.egg-info/PKG-INFO writing namespace_packages to src/mesos.interface.egg-info/namespace_packages.txt writing src/mesos.native.egg-info/PKG-INFO writing top-level names to src/mesos.interface.egg-info/top_level.txt writing namespace_packages to src/mesos.native.egg-info/namespace_packages.txt writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt writing top-level names to src/mesos.native.egg-info/top_level.txt writing dependency_links to src/mesos.native.egg-info/dependency_links.txt writing requirements to src/mesos.native.egg-info/requires.txt writing src/mesos.native.egg-info/PKG-INFO writing namespace_packages to src/mesos.native.egg-info/namespace_packages.txt writing top-level names to src/mesos.native.egg-info/top_level.txt writing dependency_links to src/mesos.native.egg-info/dependency_links.txt reading manifest file 'src/mesos.native.egg-info/SOURCES.txt' writing manifest file 'src/mesos.native.egg-info/SOURCES.txt' installing library code to build/bdist.linux-x86_64/egg running install_lib running build_py running build_ext creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/native copying build/lib.linux-x86_64-2.7/mesos/native/_mesos.so - build/bdist.linux-x86_64/egg/mesos/native reading manifest file 'src/mesos.interface.egg-info/SOURCES.txt' writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt' installing library code to build/bdist.linux-x86_64/egg running install_lib running build_py creating build/bdist.linux-x86_64/egg creating build/bdist.linux-x86_64/egg/mesos creating build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/__init__.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/containerizer_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/interface/mesos_pb2.py - build/bdist.linux-x86_64/egg/mesos/interface copying build/lib.linux-x86_64-2.7/mesos/__init__.py - build/bdist.linux-x86_64/egg/mesos byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/__init__.py to __init__.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/containerizer_pb2.py to containerizer_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/mesos_pb2.py to mesos_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc creating
Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1903 https://issues.apache.org/jira/browse/MESOS-1903 Repository: mesos-git Description --- Uses the same backoff (except no initial backoff) strategy used by the slave during registration. Diffs - include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/local/constants.hpp PRE-CREATION src/local/constants.cpp PRE-CREATION src/local/flags.hpp 54e88319afc68007ff5d7c0d0179b685ef845c87 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd Diff: https://reviews.apache.org/r/27315/diff/ Testing --- make check Thanks, Vinod Kone
Jenkins build is back to normal : mesos-reviewbot #2308
See https://builds.apache.org/job/mesos-reviewbot/2308/changes
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2224
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2224/changes
Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review58915 --- The GarbageCollector is one of the earliest libprocess processes that was added. It doesn't follow the preferred 'pimpl' style where we should have both a GarbageCollectorProcess wrapped (via an Owned) in a GarbageCollector, which controls the lifetime via spawn, terminate, and wait. I'd prefer to see us fix this and then simply allocate and free an instance of GarbageCollector. Make sense? - Benjamin Hindman On Oct. 22, 2014, 6:28 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/ --- (Updated Oct. 22, 2014, 6:28 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: mesos-git Description --- Wrap the libprocess garbage collector process with a unique ptr. Reset the ptr during finalization. Diffs - 3rdparty/libprocess/src/process.cpp 85fb995 Diff: https://reviews.apache.org/r/26583/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 26898: Add hostname option to docker info
On Oct. 26, 2014, 12:23 a.m., Benjamin Hindman wrote: include/mesos/mesos.proto, lines 889-890 https://reviews.apache.org/r/26898/diff/1/?file=724989#file724989line889 Shouldn't this be a generic ContainerInfo field? hmm, didn't think about that, but I think you're right it's fairly generic. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26898/#review58539 --- On Oct. 17, 2014, 10:57 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26898/ --- (Updated Oct. 17, 2014, 10:57 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Add hostname option to docker info Diffs - include/mesos/mesos.proto 6b93e90 src/docker/docker.cpp e09b51c Diff: https://reviews.apache.org/r/26898/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 27122: Reorganized authentication implementation locations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/#review58910 --- A fly-by review, mostly about the file naming and include guards. src/Makefile.am https://reviews.apache.org/r/27122/#comment100083 Why don't we call the file cram_md5_authentication_tests.cpp? The directory name is also cram_md5. src/authentication/cram_md5/authenticatee.hpp https://reviews.apache.org/r/27122/#comment100082 %s/CRAMMD5/AUTHENTICATION_CRAM_MD5/ ? src/authentication/cram_md5/authenticatee.hpp https://reviews.apache.org/r/27122/#comment100088 s/authoriation/authorization/ ? src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/27122/#comment100090 s/CRAMMD5/AUTHENTICATION_CRAM_MD5/ ? src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/27122/#comment100091 Reverse the #include order to alphabetize. src/authentication/cram_md5/authenticator.hpp https://reviews.apache.org/r/27122/#comment100092 Same as the include guard. src/authentication/cram_md5/auxprop.hpp https://reviews.apache.org/r/27122/#comment100093 s/CRAMMD5/AUTHENTICATION/CRAM_MD5/ ? src/authentication/cram_md5/auxprop.cpp https://reviews.apache.org/r/27122/#comment100094 License blob missing. - Kapil Arya On Oct. 25, 2014, 9:21 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 25, 2014, 9:21 a.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/crammd5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Diffs - src/Makefile.am 2617f77 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 95589b8 src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp e89e5e5 src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 55e5264 src/tests/crammd5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 26578: Memory cleanup: libprocess gc finalize
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26578/#review58919 --- 3rdparty/libprocess/include/process/gc.hpp https://reviews.apache.org/r/26578/#comment100096 This, IMHO, is a misleading/confusing use of unique_ptr, and a perfect opportunity to discuss how, and when, we want to use it in the code base. The reason this case is misleading is because 'process' is in no way unique, in the sense that this pointer will be stored in lots of different structures throughout the libprocess library. What you're using unique_ptr for here is automatic memory management (although it's not so automatic because you're still calling 'reset') but that might give some people the illusion that they can use this pointer in such a way that nobody else can manipulate the object that is being pointed to because nobody else knows it. In this case it's easy to just use 'delete' where you're doing 'reset', but in other cases we should be very explicit about our use of unique_ptr and the semantics we want to convey to other readers of the code. 3rdparty/libprocess/include/process/gc.hpp https://reviews.apache.org/r/26578/#comment100097 I'm not convinced these are a good semantics. The point of the garbage collector is to reclaim memory when a process terminates, but now we've also termianted processes when the garbage collector gets terminated! Making sure all processes are garbage (i.e., terminated) should be outside the scope of the responsibilities of the GarbageCollector. - Benjamin Hindman On Oct. 15, 2014, 9:37 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26578/ --- (Updated Oct. 15, 2014, 9:37 p.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: mesos-git Description --- Implement the finalize() virtual override for Libprocess' garbage collector. This terminates all processes registered with the garbage collector when the garbage collector terminates. Diffs - 3rdparty/libprocess/include/process/gc.hpp e83c636 Diff: https://reviews.apache.org/r/26578/diff/ Testing --- make check support/mesos-style.py Thanks, Joris Van Remoortere
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/#review58909 --- We added a new module kind but didn't add any new tests. Wouldn't it be better to move the authenticator example to the patch where we add the test case or the other way around? src/authentication/authenticator.hpp https://reviews.apache.org/r/26857/#comment100079 Shouldn't this be __AUTHENTICATION_AUTHENTICATOR_HPP__ src/authentication/authenticator.hpp https://reviews.apache.org/r/26857/#comment100081 Shouldn't we also explicitly include process/pid.h (although it is being included indirectly by process/future.hpp). src/authentication/authenticator.hpp https://reviews.apache.org/r/26857/#comment100080 Same as above. src/examples/test_authenticator_module.cpp https://reviews.apache.org/r/26857/#comment100098 The file module/authenticator.hpp is not part of this patch. Shouldn't it be removed from https://reviews.apache.org/r/26859/diff/# and added here? Also, alphabetize please. src/examples/test_authenticator_module.cpp https://reviews.apache.org/r/26857/#comment100100 The indentation is odd here. - Kapil Arya On Oct. 28, 2014, 8:43 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 28, 2014, 8:43 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs - src/Makefile.am f177d87 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/manager.cpp 7a6c884 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2502
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2502/changes Changes: [tstclair] Add --enable-debug and --enable-optimize flag for controlling building debug and optimized verisons of libprocess [idownes] Include tests/setns_test_helper.hpp in Makefile. -- [...truncated 12824 lines...] I1028 23:48:22.413159 31211 hierarchical_allocator_process.hpp:734] Offering cpus(*):2; mem(*):1024; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141028-234822-3193029443-50043-31190-S0 to framework 20141028-234822-3193029443-50043-31190- I1028 23:48:22.413290 31208 replica.cpp:508] Replica received write request for position 4 I1028 23:48:22.413421 31211 hierarchical_allocator_process.hpp:679] Performed allocation for slave 20141028-234822-3193029443-50043-31190-S0 in 346658ns I1028 23:48:22.413650 31208 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 336067ns I1028 23:48:22.413668 31208 replica.cpp:676] Persisted action at 4 I1028 23:48:22.413797 31216 master.cpp:3795] Sending 1 offers to framework 20141028-234822-3193029443-50043-31190- (default) at scheduler-0aa33fc7-0d29-487c-80eb-f933681f9c95@67.195.81.190:50043 I1028 23:48:22.414077 31212 replica.cpp:655] Replica received learned notice for position 4 I1028 23:48:22.414356 31212 leveldb.cpp:343] Persisting action (18 bytes) to leveldb took 260401ns I1028 23:48:22.414403 31212 leveldb.cpp:401] Deleting ~2 keys from leveldb took 28541ns I1028 23:48:22.414417 31212 replica.cpp:676] Persisted action at 4 I1028 23:48:22.414446 31212 replica.cpp:661] Replica learned TRUNCATE action at position 4 I1028 23:48:22.414422 31207 sched.cpp:544] Scheduler::resourceOffers took 310278ns I1028 23:48:22.415086 31214 master.cpp:2321] Processing reply for offers: [ 20141028-234822-3193029443-50043-31190-O0 ] on slave 20141028-234822-3193029443-50043-31190-S0 at slave(34)@67.195.81.190:50043 (pietas.apache.org) for framework 20141028-234822-3193029443-50043-31190- (default) at scheduler-0aa33fc7-0d29-487c-80eb-f933681f9c95@67.195.81.190:50043 W1028 23:48:22.415163 31214 master.cpp:1969] Executor default for task 0 uses less CPUs (None) than the minimum required (0.01). Please update your executor, as this will be mandatory in future releases. W1028 23:48:22.415186 31214 master.cpp:1980] Executor default for task 0 uses less memory (None) than the minimum required (32MB). Please update your executor, as this will be mandatory in future releases. I1028 23:48:22.415256 31214 master.cpp:2417] Authorizing framework principal 'test-principal' to launch task 0 as user 'jenkins' I1028 23:48:22.416033 31219 master.hpp:877] Adding task 0 with resources cpus(*):1; mem(*):500 on slave 20141028-234822-3193029443-50043-31190-S0 (pietas.apache.org) I1028 23:48:22.416084 31219 master.cpp:2480] Launching task 0 of framework 20141028-234822-3193029443-50043-31190- (default) at scheduler-0aa33fc7-0d29-487c-80eb-f933681f9c95@67.195.81.190:50043 with resources cpus(*):1; mem(*):500 on slave 20141028-234822-3193029443-50043-31190-S0 at slave(34)@67.195.81.190:50043 (pietas.apache.org) I1028 23:48:22.416317 31214 slave.cpp:1081] Got assigned task 0 for framework 20141028-234822-3193029443-50043-31190- I1028 23:48:22.416679 31215 hierarchical_allocator_process.hpp:563] Recovered cpus(*):1; mem(*):524; disk(*):3.70122e+06; ports(*):[31000-32000] (total allocatable: cpus(*):1; mem(*):524; disk(*):3.70122e+06; ports(*):[31000-32000]) on slave 20141028-234822-3193029443-50043-31190-S0 from framework 20141028-234822-3193029443-50043-31190- I1028 23:48:22.416721 31215 hierarchical_allocator_process.hpp:599] Framework 20141028-234822-3193029443-50043-31190- filtered slave 20141028-234822-3193029443-50043-31190-S0 for 5secs I1028 23:48:22.416724 31214 slave.cpp:1191] Launching task 0 for framework 20141028-234822-3193029443-50043-31190- I1028 23:48:22.418534 31214 slave.cpp:3871] Launching executor default of framework 20141028-234822-3193029443-50043-31190- in work directory '/tmp/AllocatorTest_0_SlaveReregistersFirst_QPPV21/slaves/20141028-234822-3193029443-50043-31190-S0/frameworks/20141028-234822-3193029443-50043-31190-/executors/default/runs/d593f433-3c16-4678-8f76-4038fe2841c4' I1028 23:48:22.420557 31214 exec.cpp:132] Version: 0.21.0 I1028 23:48:22.420755 31213 exec.cpp:182] Executor started at: executor(22)@67.195.81.190:50043 with pid 31190 I1028 23:48:22.420903 31214 slave.cpp:1317] Queuing task '0' for executor default of framework '20141028-234822-3193029443-50043-31190- I1028 23:48:22.420997 31214 slave.cpp:555] Successfully attached file '/tmp/AllocatorTest_0_SlaveReregistersFirst_QPPV21/slaves/20141028-234822-3193029443-50043-31190-S0/frameworks/20141028-234822-3193029443-50043-31190-/executors/default/runs/d593f433-3c16-4678-8f76-4038fe2841c4' I1028 23:48:22.421058 31214 slave.cpp
Jenkins build is back to normal : Mesos-Ubuntu-distcheck #452
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/452/changes
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26859/#review58924
---
src/master/master.cpp
https://reviews.apache.org/r/26859/#comment100107
Here if the user specifies an invalid modulename but doesn't specify the
module with --modules, shouldn't we give a simple error that the authenticator
'name' was not found?
Sth along the lines of :
} else if
(modules::ModuleManager::containsAuthenticator(authenticatorModules[0])) {
... ModuleManager::create ...
} else {
ERROR(invalid module)
}
- Kapil Arya
On Oct. 28, 2014, 8:44 a.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26859/
---
(Updated Oct. 28, 2014, 8:44 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
Enables selecting a module based authenticator via the new --authenticators
flag for mesos master.
Additionally, all have been fixed towards in master.hpp and
master.cpp.
Diffs
-
src/master/flags.hpp c931fd9
src/master/master.hpp b1a2cd0
src/master/master.cpp 762d2ff
src/module/authenticator.hpp PRE-CREATION
src/tests/crammd5_authentication_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/26859/diff/
Testing
---
make check
NOTE all three CRAM-MD5 authenticator module related RRs need to get applied
before running make check.
Thanks,
Till Toenshoff
Re: Review Request 26382: Add source and reason to TaskStatus.
On Oct. 24, 2014, 6:08 p.m., Vinod Kone wrote: src/master/master.cpp, line 2301 https://reviews.apache.org/r/26382/diff/7/?file=727958#file727958line2301 why is this TASK_ERROR instead of TASK_LOST? A relaunch would likely succeed here right? Dominic Hamon wrote: I thought if the offer id is invalid it likely would be again next time. Is that not the case? no. they cannot reuse an offer in subsequent calls to launchTasks(). so the only possible way to relaunch the task would be to use a new offer. On Oct. 24, 2014, 6:08 p.m., Vinod Kone wrote: src/common/http.cpp, line 103 https://reviews.apache.org/r/26382/diff/7/?file=727941#file727941line103 what happens if this is not set? Dominic Hamon wrote: nothing - i thought it was a useful thing to export in the JSON model though. nothing, as in empty? or does it return a default source (enum 0)? if it's the latter it's a problem. you should guard this statement with status.has_source(). On Oct. 24, 2014, 6:08 p.m., Vinod Kone wrote: include/mesos/mesos.proto, line 636 https://reviews.apache.org/r/26382/diff/7/?file=727940#file727940line636 I think this will become a crutch. We should know the reasons for why a task is lost. i.e., kill this. Dominic Hamon wrote: it still might be 'unknown' in cases where the caller doesn't set the reason. is that acceptable? the caller is mesos code (master, slave) which should always know the reason. do you have an example? On Oct. 24, 2014, 6:08 p.m., Vinod Kone wrote: include/mesos/mesos.proto, lines 624-629 https://reviews.apache.org/r/26382/diff/7/?file=727940#file727940line624 Pull this one and Reason inside TaskStatus. Also kill the SOURCE_ and REASON_ prefixes. Dominic Hamon wrote: and not enum TaskState? I was following that model. i'd like to keep the prefixes as it makes it easy to be sure in the callsite that you have the right enum. Autocomplete then works nicely too. The name TaskState is fully qualified and it's easy to understand what it represents, whereas a top level Reason and Source doesn't tell us what it is referring to. Having SOURCE_ prefix inside a Source namespace (enum) seems a bit redundant. Callers already do set_*source(), so I don't think it is that ambigous. But it's upto you. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/#review58174 --- On Oct. 27, 2014, 5:18 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26382/ --- (Updated Oct. 27, 2014, 5:18 p.m.) Review request for mesos, Vinod Kone and Bill Farner. Bugs: MESOS-1830 and MESOS-343 https://issues.apache.org/jira/browse/MESOS-1830 https://issues.apache.org/jira/browse/MESOS-343 Repository: mesos-git Description --- Added source and reason, enabled TASK_ERROR, and made the changes necessary throughout the codebase. Diffs - include/mesos/mesos.proto 6b93e9000761857c4f335f2a8c8088e155078f54 src/common/protobuf_utils.hpp 212d5124b9a4cc58e61719fa7f07a61cd166e834 src/common/protobuf_utils.cpp a9b65e328c4c62bff7fbf5633dda25d742d79019 src/examples/balloon_framework.cpp b05d5679fe2915142907af0b2dc00c6cd76eb9c1 src/examples/java/TestFramework.java bc593d0abfacb00690b1492b2b82c970f4e4de6d src/examples/low_level_scheduler_libprocess.cpp 7ef5ea78ade4ed856b97009fdfe31281f0a55c17 src/examples/low_level_scheduler_pthread.cpp 6e233a10117a1c7aa669806b5b430e746e227ee5 src/examples/no_executor_framework.cpp f98a0735b9f287e7f1bf98af6c2e9a47ca6a77b2 src/examples/test_framework.cpp 187a611ebfe35cb13ee48aa5eca934cf55f34dea src/master/master.cpp 9ebdc357fe679ed5bd54e0f4b9091ab9bcc2b00f src/scaling/nested_exec.py 17e61706c75e6e849b0c40ae5232d8dc60804c55 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/slave/slave.cpp 5e7c107aa8f36aff954fa6a46c431a20c313ebc2 src/tests/common/http_tests.cpp 912653b26615c86cc0204d80f58e6046c4b91a98 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd src/tests/master_authorization_tests.cpp 652e80d0d4567b225c6ffb326725ddfde06f7fd3 src/tests/master_tests.cpp f60e3761e5a558d379c56513937d2f59e898a490 src/tests/reconciliation_tests.cpp 4ba53940951584d9baa2c7aa4e124814471206bc src/tests/resource_offers_tests.cpp fe66432b1bf75ee25feb73c4bb353e4d4e5b503f Diff: https://reviews.apache.org/r/26382/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 26861: Schedule docker containers for removal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26861/ --- (Updated Oct. 29, 2014, 12:02 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Instead of removing docker containers right after reap, schedule it to be removed later. Diffs (updated) - src/slave/constants.hpp 9030871 src/slave/constants.cpp e1da5c0 src/slave/containerizer/docker.cpp 9a29489 src/slave/flags.hpp f7a8cde Diff: https://reviews.apache.org/r/26861/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26862: Fix docker flaky tests
On Oct. 26, 2014, 1:11 a.m., Benjamin Hindman wrote: src/tests/docker_containerizer_tests.cpp, line 111 https://reviews.apache.org/r/26862/diff/5/?file=728445#file728445line111 This doesn't look like it was used by any call sites. Good catch, I'm still going to use this to check if a docker container is still running. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review58545 --- On Oct. 22, 2014, 12:46 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ --- (Updated Oct. 22, 2014, 12:46 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Docker tests are flaky, mostly around getting expected output from the docker container forwarded to stdout/stderr. This is due to Docker not always have the stdout/stderr output available for docker logs if kill/rm is called. Diffs - src/docker/docker.hpp 9656f15 src/docker/docker.cpp e09b51c src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 src/tests/docker_tests.cpp 04139af src/tests/environment.cpp 4dd78e7 Diff: https://reviews.apache.org/r/26862/diff/ Testing --- make with gtest_repeat=-1 gtest_shuffle=1 Thanks, Timothy Chen
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/#review58921 --- src/master/master.hpp https://reviews.apache.org/r/26859/#comment100101 There shouldn't be a newline added here src/master/master.cpp https://reviews.apache.org/r/26859/#comment100105 Since all this code only can load one authenticator module it would be good to check the authetnicatorModules argument only produces a list of length 1 max and warn / exit early. Currently extra arguments are silently ignored. src/master/master.cpp https://reviews.apache.org/r/26859/#comment100103 The strings::split() API makes this a lot more complicated than it should be. split of an empty string returning an empty vector I think would make more sense... But alas... I think it would make sense though to default the argument to a list of one element ['crammd5'] by default. Then you should just error if not --authenticator= is passed without listing any authenticators, rather than try to fall back. Ideally the error would list available authentication modules. src/master/master.cpp https://reviews.apache.org/r/26859/#comment100104 This assuems crammd5 can only appear first in the list of authenticator modules. src/master/master.cpp https://reviews.apache.org/r/26859/#comment100113 If authenticator should really be Owned here it would be a lot better to make it owned much earlier so that it is never unowned / a resource which could potentially be lost if / when the unexpected happens. src/master/master.cpp https://reviews.apache.org/r/26859/#comment100114 All the right angle bracket fixes are nice, but the ones in chunks of code which aren't otherwise touched make the diff harder to read. src/module/authenticator.hpp https://reviews.apache.org/r/26859/#comment100115 This needs to be added to a Makefile.am so that distcheck will pass. - Cody Maloney On Oct. 28, 2014, 12:44 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 28, 2014, 12:44 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Enables selecting a module based authenticator via the new --authenticators flag for mesos master. Additionally, all have been fixed towards in master.hpp and master.cpp. Diffs - src/master/flags.hpp c931fd9 src/master/master.hpp b1a2cd0 src/master/master.cpp 762d2ff src/module/authenticator.hpp PRE-CREATION src/tests/crammd5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26862: Fix docker flaky tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ --- (Updated Oct. 29, 2014, 12:21 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Docker tests are flaky, mostly around getting expected output from the docker container forwarded to stdout/stderr. This is due to Docker not always have the stdout/stderr output available for docker logs if kill/rm is called. Diffs (updated) - src/docker/docker.hpp 9656f15 src/docker/docker.cpp 9973782 src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 src/tests/docker_tests.cpp 04139af src/tests/environment.cpp 4dd78e7 Diff: https://reviews.apache.org/r/26862/diff/ Testing --- make with gtest_repeat=-1 gtest_shuffle=1 Thanks, Timothy Chen
Re: Review Request 26896: Add privileged option to docker info
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26896/ --- (Updated Oct. 29, 2014, 12:22 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1849 https://issues.apache.org/jira/browse/MESOS-1849 Repository: mesos-git Description --- Add privileged option to docker info Diffs (updated) - include/mesos/mesos.proto 168a7a8 src/docker/docker.cpp 9973782 Diff: https://reviews.apache.org/r/26896/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26897: Support lxc configurations in docker info
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26897/ --- (Updated Oct. 29, 2014, 12:23 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Support lxc configurations in docker info Diffs (updated) - include/mesos/mesos.proto 168a7a8 src/docker/docker.cpp 9973782 Diff: https://reviews.apache.org/r/26897/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26898: Add hostname option to docker info
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26898/ --- (Updated Oct. 29, 2014, 12:24 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Add hostname option to docker info Diffs (updated) - include/mesos/mesos.proto 168a7a8 src/docker/docker.cpp 9973782 Diff: https://reviews.apache.org/r/26898/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26517: Symlink sandbox directories in docker containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 29, 2014, 12:25 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1833 https://issues.apache.org/jira/browse/MESOS-1833 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26517 Diffs (updated) - src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 Diff: https://reviews.apache.org/r/26517/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26436: Avoid docker inspect on each usage call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/ --- (Updated Oct. 29, 2014, 12:26 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26436 Diffs (updated) - src/slave/containerizer/docker.cpp 9a29489 Diff: https://reviews.apache.org/r/26436/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 27295: os::killtree() supports case when root pid has exited.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/#review58845 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp https://reviews.apache.org/r/27295/#comment11 s/process/process 'pid'/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp https://reviews.apache.org/r/27295/#comment10 s/cgroups/groups/ :) 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp https://reviews.apache.org/r/27295/#comment100122 Don't you have to check that child is not already in queue because it might be added in #80 or #84? 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp https://reviews.apache.org/r/27295/#comment100128 #669 seems to indicate that process could be none when we are here? why not have ASSERT_SOME(process) up there instead? - Vinod Kone On Oct. 28, 2014, 6:28 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27295/ --- (Updated Oct. 28, 2014, 6:28 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1875 https://issues.apache.org/jira/browse/MESOS-1875 Repository: mesos-git Description --- Improve os::killtree() for the case when the root pid has exited and it has been instructed to either follow process groups or sessions. It will now kill all processes (and their trees) with pgid or session matching the root pid. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e0566078 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e9f37dfd3cf54c3ca85d74716b3ee4262b065fad Diff: https://reviews.apache.org/r/27295/diff/ Testing --- Added a test where the root pid exits (and is reaped), leaving behind a reparented subtree. This test initially fails. + // -+- child exit 0 [new session and process group leader] + // -+- grandchild sleep 100 + // -+- great grandchild sleep 100 Thanks, Ian Downes
Re: Review Request 26436: Avoid docker inspect on each usage call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/#review58946 --- Patch looks great! Reviews applied: [26610, 26861, 26862, 26896, 26897, 26898, 26517, 26436] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 12:26 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/ --- (Updated Oct. 29, 2014, 12:26 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26436 Diffs - src/slave/containerizer/docker.cpp 9a29489 Diff: https://reviews.apache.org/r/26436/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26517: Symlink sandbox directories in docker containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review58938 --- src/slave/containerizer/docker.hpp https://reviews.apache.org/r/26517/#comment100125 why not do this as a const char * / compile time string literal rather than runtime? I see this as a fairly common pattern in our codebase, just doesn't make a lot of sense to me. In any case, the variable is expected to be set only at construction and never changed, so it would be good to make it const. 'extern const std::string'. We may want to look at changing these variables to static functions so that there is a well defined initialization order. src/slave/containerizer/docker.cpp https://reviews.apache.org/r/26517/#comment100129 I get why this cleanup should be in the destructor, but it feels uneven that we do the cleanup in the destructor but we don't do the creation / symlink in the constructor. Destructors should roughly reverse constructors. src/slave/containerizer/docker.cpp https://reviews.apache.org/r/26517/#comment100161 Indentation should line up like: Error( - Cody Maloney On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 29, 2014, 12:25 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1833 https://issues.apache.org/jira/browse/MESOS-1833 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26517 Diffs - src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 Diff: https://reviews.apache.org/r/26517/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 27315: Updated scheduler driver to exponentially backoff during registration retries.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/#review58951 --- include/mesos/scheduler.hpp https://reviews.apache.org/r/27315/#comment100173 It would be more precise to use an Optional here rather than write the rules/semantics (if I'm reading the rest of the code correctly) into a pointer. Also means we don't have to manually clean up in the destructor. src/sched/sched.cpp https://reviews.apache.org/r/27315/#comment100167 maxBackoff is never set if duration.isNone. src/sched/sched.cpp https://reviews.apache.org/r/27315/#comment100169 It would be nice to use random here (The headers at least are around in gcc 4.4). Doing this sort of math creates significantly biased randon numbers. src/sched/sched.cpp https://reviews.apache.org/r/27315/#comment100170 nextDuration/durationNext would be a more descriptive variable name. - Cody Maloney On Oct. 28, 2014, 11:08 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27315/ --- (Updated Oct. 28, 2014, 11:08 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1903 https://issues.apache.org/jira/browse/MESOS-1903 Repository: mesos-git Description --- Uses the same backoff (except no initial backoff) strategy used by the slave during registration. Diffs - include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e src/Makefile.am 374f284e1ac839fbcd8a28171b1ff4fbe8a17bd4 src/local/constants.hpp PRE-CREATION src/local/constants.cpp PRE-CREATION src/local/flags.hpp 54e88319afc68007ff5d7c0d0179b685ef845c87 src/sched/sched.cpp 0fb8c7bda75545389f8024489b3c76ae115111f4 src/tests/fault_tolerance_tests.cpp a18a41a3e34ff112e04e693447d757403e5013bd Diff: https://reviews.apache.org/r/27315/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 26517: Symlink sandbox directories in docker containerizer
On Oct. 29, 2014, 2:17 a.m., Cody Maloney wrote: src/slave/containerizer/docker.cpp, line 266 https://reviews.apache.org/r/26517/diff/5/?file=736740#file736740line266 I get why this cleanup should be in the destructor, but it feels uneven that we do the cleanup in the destructor but we don't do the creation / symlink in the constructor. Destructors should roughly reverse constructors. Since creating symlink might get an error, we can't do this in the constructor. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review58938 --- On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 29, 2014, 12:25 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1833 https://issues.apache.org/jira/browse/MESOS-1833 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26517 Diffs - src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 Diff: https://reviews.apache.org/r/26517/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26517: Symlink sandbox directories in docker containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review58955 --- src/slave/containerizer/docker.cpp https://reviews.apache.org/r/26517/#comment100181 good catch! - Timothy Chen On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 29, 2014, 12:25 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1833 https://issues.apache.org/jira/browse/MESOS-1833 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26517 Diffs - src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 Diff: https://reviews.apache.org/r/26517/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26517: Symlink sandbox directories in docker containerizer
On Oct. 29, 2014, 2:17 a.m., Cody Maloney wrote: src/slave/containerizer/docker.hpp, line 40 https://reviews.apache.org/r/26517/diff/5/?file=736739#file736739line40 why not do this as a const char * / compile time string literal rather than runtime? I see this as a fairly common pattern in our codebase, just doesn't make a lot of sense to me. In any case, the variable is expected to be set only at construction and never changed, so it would be good to make it const. 'extern const std::string'. We may want to look at changing these variables to static functions so that there is a well defined initialization order. Yes it should be const - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review58938 --- On Oct. 29, 2014, 12:25 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 29, 2014, 12:25 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1833 https://issues.apache.org/jira/browse/MESOS-1833 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26517 Diffs - src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 Diff: https://reviews.apache.org/r/26517/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26517: Symlink sandbox directories in docker containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 29, 2014, 3 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1833 https://issues.apache.org/jira/browse/MESOS-1833 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26517 Diffs (updated) - src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 Diff: https://reviews.apache.org/r/26517/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 27175: Added support for handling 'rc' tag to Version.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27175/#review58954 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100180 These TODO comments should be updted since this adds a 4th component if nothing else 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100184 labelSplit? 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100185 version? versionChunks? versionComponents? the name split isn't very helpful. 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100188 If we go with semantic versioning: Rule 10: Precedence for two pre-release versions with the same major, minor, and patch version MUST be determined by comparing each dot separated identifier from left to right until a difference is found as follows: identifiers consisting of only digits are compared numerically and identifiers with letters or hyphens are compared lexically in ASCII sort order. Numeric identifiers always have lower precedence than non-numeric identifiers. which this doesn't follow. If we want to pull out the structure of the naming we know / do (rc) then definitely we can/should. According to SemVer we should call this pre-release in general and we would then have a helper in Version which tells you whether or not there is a pre-release. It is likely that I'll use the pre-release versions for tracking mesos testing cluster builds for continuous integration (I can forsee the version string 0.20.1-2014.10.28.3+debug) 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100189 Why not strings::lower(secondarySplit[0]) so that these cases condense? 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100190 Shouldn't tag = UNKNOWN here? 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100191 shouldn't the versionString contain the tag if one is specified? Why isn't not passing in the original version string a programmer error / assertion failure? 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100192 We really need some form of more or less equal / some level of the fields match (major + minor + patch). Most users shouldn't care about tags for checking to enable / disable features. If they are getting that specific day to day development will likely break them. I don't think this should compare tags, but I see the argument either way. 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp https://reviews.apache.org/r/27175/#comment100194 The tag comparison here is incorrect. If a tag is given at all, that should always be lower level than tag == RELEASE. I'd much rather see that logic laid out here than being implicit in the ordering of the members of the enum. Same goes for operator 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp https://reviews.apache.org/r/27175/#comment100195 Can you add a test for release rc/unknown tag? - Cody Maloney On Oct. 24, 2014, 10:55 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27175/ --- (Updated Oct. 24, 2014, 10:55 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1987 https://issues.apache.org/jira/browse/MESOS-1987 Repository: mesos-git Description --- Now it can parse strings like 1.2.3-rc4. Other tags are still discarded. Updated os::release() to use Version::parse() instead of sscanf. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5d3cbba289d8f9d57c2fd49dd6f72225bb2fb8c2 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 090fcf09dd96538a8748cf4443d150911e2c0d27 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp e8f8358f3c113b4e21e30cb5e9d6a3d229191484 Diff: https://reviews.apache.org/r/27175/diff/ Testing --- Enhanced version tests and ran make check. Thanks, Kapil Arya
Re: Review Request 20423: Moved validation visitors out of master.cpp.
On Oct. 23, 2014, 7:46 p.m., Vinod Kone wrote: Why are some definitions in .hpp and some in .cpp? Why not all in .cpp? Also, it's not clear to me how this split would help in unit testing? AFAICT, all these visitors take Master or Framework or Slave which needs bringing up a cluster. Dominic Hamon wrote: They could be all in cpp, but some are so simple that being inlineable seemed beneficial. This is a first step. The Master/Slave/Frameworks passed in could be mock/stub versions that would support lightweight testing. The change also has a benefit in reducing the amount of code in the master source file, which helps with compile time and readability. Things in cpp files can be inlined with LTO (Which is something I'd like to get functioning in Mesos tooling in in the long term). There isn't much code which includes the header, so the increase in compile time / object size from having more in the header isn't something I'm worried about in this case though, so net meh from me either way. Reducing code in master.cpp is definitely good, although most of the slowness compiling it comes from things it includes, not master.cpp itself. (Flags tends to be one of the worse offenders last time I did some investigation). - Cody --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20423/#review58071 --- On Oct. 23, 2014, 10:48 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20423/ --- (Updated Oct. 23, 2014, 10:48 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1064 https://issues.apache.org/jira/browse/MESOS-1064 Repository: mesos-git Description --- This is the first step toward being able to write independent unit tests for the validation visitors. It also uses Owned to make visitor cleanup simpler (non-existent). Diffs - 3rdparty/libprocess/include/process/timeout.hpp 0bf63e11a7a63b714aafb5386bf2d169260396ce src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 src/master/master.cpp 95589b8f25a3e496eabc0cf84319c883c1ed7aec src/master/offervisitor.hpp PRE-CREATION src/master/offervisitor.cpp PRE-CREATION src/master/taskinfovisitor.hpp PRE-CREATION src/master/taskinfovisitor.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 9f745d897119a814bd9f8e1b6a0ce5eaef60ed36 src/zookeeper/group.hpp 924613065521a72887a2721b3db89f448fa50900 Diff: https://reviews.apache.org/r/20423/diff/ Testing --- make check. ran Java test framework. Thanks, Dominic Hamon
Re: Review Request 27023: Libprocess Socket std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/ --- (Updated Oct. 29, 2014, 4:31 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes --- Add get() function which instantiates the impl if it was not already (e.g. implicit int conversion after default Socket() constructor). Add create() function which returns a new shared_ptr (RVO) to make the get() function a good candidate for inlining. Repository: mesos-git Description --- Use std::shared_ptr to do reference counting for libprocess rather than manually doing it. Diffs (updated) - 3rdparty/libprocess/include/process/socket.hpp 6683881 Diff: https://reviews.apache.org/r/27023/diff/ Testing (updated) --- make check Thanks, Joris Van Remoortere
Re: Review Request 27023: Libprocess Socket std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/ --- (Updated Oct. 29, 2014, 4:43 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes --- don't introduce rvalue impl constructor yet. alphabetize include. Repository: mesos-git Description --- Use std::shared_ptr to do reference counting for libprocess rather than manually doing it. Diffs (updated) - 3rdparty/libprocess/include/process/socket.hpp 6683881 Diff: https://reviews.apache.org/r/27023/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 27023: Libprocess Socket std::shared_ptr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/ --- (Updated Oct. 29, 2014, 5:10 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes --- fix brace on new line Repository: mesos-git Description --- Use std::shared_ptr to do reference counting for libprocess rather than manually doing it. Diffs (updated) - 3rdparty/libprocess/include/process/socket.hpp 6683881 Diff: https://reviews.apache.org/r/27023/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 27054: Libprocess Socket: introduce connect()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27054/ --- (Updated Oct. 29, 2014, 5:18 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes --- rebase on 27023 Bugs: MESOS-1330 https://issues.apache.org/jira/browse/MESOS-1330 Repository: mesos-git Description --- Introduce the connect(const Node node) call to Socket. Use it in link() and send(). Diffs (updated) - 3rdparty/libprocess/include/process/socket.hpp 6683881 3rdparty/libprocess/src/process.cpp 85fb995 Diff: https://reviews.apache.org/r/27054/diff/ Testing --- make check Thanks, Joris Van Remoortere
