Re: A problem with resource offers
Fixed in 0.19: https://issues.apache.org/jira/browse/MESOS-1400 On Thu, Nov 6, 2014 at 7:59 PM, Timothy Chen t...@mesosphere.io wrote: Hi Sharma, Can you try out the latest master and see if you can repro it? Tim Sent from my iPhone On Nov 6, 2014, at 7:41 PM, Sharma Podila spod...@netflix.com wrote: I am on 0.18 still. I think I found a bug. I wrote a simple program to repeat this and there's a new twist as well. Again, although I have fixed this for now in my framework by removing all previous leases after re-registration, this can show up when mesos starts rescinding offers in the future. Here's what I do: 1. register with mesos that has just one slave in the cluster and only one master 2. get an offer, O1 3. kill and restart mesos master 4. get new offer for the only slave, O2 5. launch a task with both offers O1 and O2 6. receive TASK_LOST 7. wait for new offer, that never comes. Here's the new twist: 8. kill my framework and restart 9. get no offers from mesos at all. Here's the relevant mesos master logs: I1106 19:31:55.734485 10423 master.cpp:770] Elected as the leading master! I1106 19:31:55.737759 10423 master.cpp:1936] Attempting to re-register slave 20141029-125131-16842879-5050-18827-1 at slave(1)@127.0.1.1:5051 (lgud-spodila2) I1106 19:31:55.737788 10423 master.cpp:2818] Adding slave 20141029-125131-16842879-5050-18827-1 at lgud-spodila2 with cpus(*):8; mem(*):39209; disk(*):219127; ports(*):[31000-32000] I1106 19:31:55.738088 10422 hierarchical_allocator_process.hpp:445] Added slave 20141029-125131-16842879-5050-18827-1 (lgud-spodila2) with cpus(*):8; mem(*):39209; disk(*):219127; ports(*):[31000-32000] (and cpus(*):8; mem(*):39209; disk(*):219127; ports(*):[31000-32000] available) I1106 19:31:56.733850 10423 master.cpp:906] Re-registering framework 20141106-193136-16842879-5050-10308- at scheduler(1)@127.0.1.1:55515 I1106 19:31:56.734544 10424 hierarchical_allocator_process.hpp:332] Added framework 20141106-193136-16842879-5050-10308- I1106 19:31:56.735044 10424 master.cpp:2285] Sending 1 offers to framework 20141106-193136-16842879-5050-10308- I1106 19:31:59.627913 10423 http.cpp:391] HTTP request for '/master/state.json' I1106 19:32:09.634088 10421 http.cpp:391] HTTP request for '/master/state.json' W1106 19:32:10.377226 10425 master.cpp:1556] Failed to validate offer : Offer 20141106-193136-16842879-5050-10308-0 is no longer valid I1106 19:32:10.378697 10425 master.cpp:1567] Sending status update TASK_LOST (UUID: afadf504-f606-47f2-82cc-5af2e532afcd) for task Job123 of framework 20141106-193136-16842879-5050-10308- for launch task attempt on invalid offers: [ 20141106-193147-16842879-5050-10406-0, 20141106-193136-16842879-5050-10308-0 ] Master thinks both offers are invalid and basically leaks it. I1106 19:32:19.640913 10422 http.cpp:391] HTTP request for '/master/state.json' I1106 19:32:22.667037 10424 master.cpp:595] Framework 20141106-193136-16842879-5050-10308- disconnected I1106 19:32:22.667280 10424 master.cpp:1079] Deactivating framework 20141106-193136-16842879-5050-10308- I1106 19:32:22.668009 10424 master.cpp:617] Giving framework 20141106-193136-16842879-5050-10308- 0ns to failover I1106 19:32:22.668124 10427 hierarchical_allocator_process.hpp:408] Deactivated framework 20141106-193136-16842879-5050-10308- I1106 19:32:22.668252 10425 master.cpp:2201] Framework failover timeout, removing framework 20141106-193136-16842879-5050-10308- I1106 19:32:22.668443 10425 master.cpp:2688] Removing framework 20141106-193136-16842879-5050-10308- I1106 19:32:22.668829 10425 hierarchical_allocator_process.hpp:363] Removed framework 20141106-193136-16842879-5050-10308- I1106 19:32:24.739157 10426 master.cpp:818] Received registration request from scheduler(1)@127.0.1.1:37122 I1106 19:32:24.739328 10426 master.cpp:836] Registering framework 20141106-193147-16842879-5050-10406- at scheduler(1)@127.0.1.1:37122 I1106 19:32:24.739753 10426 hierarchical_allocator_process.hpp:332] Added framework 20141106-193147-16842879-5050-10406- I1106 19:32:29.647886 10423 http.cpp:391] HTTP request for '/master/state.json' On Thu, Nov 6, 2014 at 6:53 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Which version of the master are you using and do you have the logs? The fact that no offers were coming back sounds like a bug! As for using O1 after a disconnection, all offers are invalid once a disconnection occurs. The scheduler driver does not automatically rescind offers upon disconnection, so I'd recommend clearing all cached offers when your scheduler gets disconnected, to avoid the unnecessary TASK_LOST updates. On Thu, Nov 6, 2014 at 6:25 PM, Sharma Podila spod...@netflix.com wrote: We had an interesting problem with resource offers today and I would like to confirm this
Re: Unable to install Mesos on Ubuntu 14.04. Error during 'make'
Hi Sweta, I'm a bit confused about what works for you and what doesn't. Are you now able to start mesos-master and mesos-slave and launch an example framework? On Thu, Nov 6, 2014 at 9:16 PM, Sweta Rani swetarani3...@gmail.com wrote: Cloning from svn repo gave following error: proxima@proxima-HP-Pavilion-m6-Notebook-PC:~/mesodoc$ rake Cloning Apache Mesos codebase Cloning into '/home/proxima/mesodoc/tmp/mesos'... remote: Counting objects: 1075, done. remote: Compressing objects: 100% (935/935), done. remote: Total 1075 (delta 221), reused 537 (delta 83) Receiving objects: 100% (1075/1075), 26.77 MiB | 171.00 KiB/s, done. Resolving deltas: 100% (221/221), done. Checking connectivity... done. Updating latest documentation from the Apache Mesos codebase Updating docs to the latest version rake aborted! Errno::ENOENT: No such file or directory - /home/proxima/mesodoc/source/documentation/latest/ running-torque-or-mpi-on-mesos.md /home/proxima/mesodoc/Rakefile:43:in `block in top (required)' Tasks: TOP = default = update_docs Neither I could get assets folder in this. How will I make changes? On Thu Nov 06 2014 at 10:55:38 PM Joris Van Remoortere jo...@mesosphere.io wrote: If you run: mesos-slave.sh --help Then you will see all the options you can pass to the slave. One of them is --port=VALUE Joris On Thu, Nov 6, 2014 at 6:39 AM, Sweta Rani swetarani3...@gmail.com wrote: How can I change port for mesos-slave from default 5051 to 5052? *Sweta Rani* On Thu, Nov 6, 2014 at 7:58 PM, Sweta Rani swetarani3...@gmail.com wrote: Alex, Done with master but unable to run slave using command ./bin/mesos-slave.sh --master=127.0.0.1:5050 Also the port 5051 is allocated with random work '-'. See this: proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@proxima:~/mesos/build$ sudo kill -9 - kill: failed to parse argument: '-' proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@:~/mesos/build$ ./bin/mesos-slave.sh --master=127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 19:51:22.737992 6367 process.cpp:1532] Failed to initialize, bind 0.0.0.0:5051: Address already in use [98] *** Check failure stack trace: *** Aborted (core dumped) *Sweta Rani* On Thu, Nov 6, 2014 at 7:07 PM, Alex Rukletsov a...@mesosphere.io wrote: Sweta, have you tried another port? On Thu, Nov 6, 2014 at 2:24 PM, Sweta Rani swetarani3...@gmail.com wrote: Joris Done with above commands, but now it gives following error: WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 18:50:48.117947 9706 process.cpp:1532] Failed to initialize, bind 127.0.0.1:5050: Address already in use [98] *** Check failure stack trace: *** I tried to solve it by http://stackoverflow.com/questions/10745878/ubuntu- error-with-apache-98address-already-in-use but it didnt work for me. *Sweta Rani* On Wed, Nov 5, 2014 at 3:50 AM, Joris Van Remoortere jo...@mesosphere.io wrote: You need to make the directory and set the permissions to the user you are running the master as. For example: sudo mkdir /var/lib/mesos sudo chown jmlvanre /var/lib/mesos [jmlvanre] run mesos master... On Tue, Nov 4, 2014 at 2:07 PM, Sweta Rani swetarani3...@gmail.com wrote: Thanks for your help. I have installed mesos but unable to start mesos master by the command ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos. The file exists as mesos-master.sh.in in the bin folder. It reports: Failed to create work directory '/var/lib/mesos': Permission denied *Sweta Rani* On Tue, Nov 4, 2014 at 2:50 PM, Adam Bordelon a...@mesosphere.io wrote: As an alternate workaround, if you don't need the Java support (you're not running a JVM framework like Spark/Hadoop/Marathon), then you could use `configure --disable-java` to skip all the maven/pom build steps. By disabling Java, you could at least check that the rest of Mesos builds and runs fine, which would still work with C++, Python, or Go frameworks, or even any Java
Re: Unable to install Mesos on Ubuntu 14.04. Error during 'make'
Yes I have done that. Now master and slave both are working. Thanks for help :) On Fri Nov 07 2014 at 3:55:29 PM Alex Rukletsov a...@mesosphere.io wrote: Hi Sweta, I'm a bit confused about what works for you and what doesn't. Are you now able to start mesos-master and mesos-slave and launch an example framework? On Thu, Nov 6, 2014 at 9:16 PM, Sweta Rani swetarani3...@gmail.com wrote: Cloning from svn repo gave following error: proxima@proxima-HP-Pavilion-m6-Notebook-PC:~/mesodoc$ rake Cloning Apache Mesos codebase Cloning into '/home/proxima/mesodoc/tmp/mesos'... remote: Counting objects: 1075, done. remote: Compressing objects: 100% (935/935), done. remote: Total 1075 (delta 221), reused 537 (delta 83) Receiving objects: 100% (1075/1075), 26.77 MiB | 171.00 KiB/s, done. Resolving deltas: 100% (221/221), done. Checking connectivity... done. Updating latest documentation from the Apache Mesos codebase Updating docs to the latest version rake aborted! Errno::ENOENT: No such file or directory - /home/proxima/mesodoc/source/documentation/latest/ running-torque-or-mpi-on-mesos.md /home/proxima/mesodoc/Rakefile:43:in `block in top (required)' Tasks: TOP = default = update_docs Neither I could get assets folder in this. How will I make changes? On Thu Nov 06 2014 at 10:55:38 PM Joris Van Remoortere jo...@mesosphere.io wrote: If you run: mesos-slave.sh --help Then you will see all the options you can pass to the slave. One of them is --port=VALUE Joris On Thu, Nov 6, 2014 at 6:39 AM, Sweta Rani swetarani3...@gmail.com wrote: How can I change port for mesos-slave from default 5051 to 5052? *Sweta Rani* On Thu, Nov 6, 2014 at 7:58 PM, Sweta Rani swetarani3...@gmail.com wrote: Alex, Done with master but unable to run slave using command ./bin/mesos-slave.sh --master=127.0.0.1:5050 Also the port 5051 is allocated with random work '-'. See this: proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@proxima:~/mesos/build$ sudo kill -9 - kill: failed to parse argument: '-' proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@:~/mesos/build$ ./bin/mesos-slave.sh --master= 127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 19:51:22.737992 6367 process.cpp:1532] Failed to initialize, bind 0.0.0.0:5051: Address already in use [98] *** Check failure stack trace: *** Aborted (core dumped) *Sweta Rani* On Thu, Nov 6, 2014 at 7:07 PM, Alex Rukletsov a...@mesosphere.io wrote: Sweta, have you tried another port? On Thu, Nov 6, 2014 at 2:24 PM, Sweta Rani swetarani3...@gmail.com wrote: Joris Done with above commands, but now it gives following error: WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 18:50:48.117947 9706 process.cpp:1532] Failed to initialize, bind 127.0.0.1:5050: Address already in use [98] *** Check failure stack trace: *** I tried to solve it by http://stackoverflow.com/questions/10745878/ubuntu- error-with-apache-98address-already-in-use but it didnt work for me. *Sweta Rani* On Wed, Nov 5, 2014 at 3:50 AM, Joris Van Remoortere jo...@mesosphere.io wrote: You need to make the directory and set the permissions to the user you are running the master as. For example: sudo mkdir /var/lib/mesos sudo chown jmlvanre /var/lib/mesos [jmlvanre] run mesos master... On Tue, Nov 4, 2014 at 2:07 PM, Sweta Rani swetarani3...@gmail.com wrote: Thanks for your help. I have installed mesos but unable to start mesos master by the command ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos. The file exists as mesos-master.sh.in in the bin folder. It reports: Failed to create work directory '/var/lib/mesos': Permission denied *Sweta Rani* On Tue, Nov 4, 2014 at 2:50 PM, Adam Bordelon a...@mesosphere.io wrote: As an alternate workaround, if you don't need the Java support (you're not running a JVM framework like Spark/Hadoop/Marathon),
Re: Unable to install Mesos on Ubuntu 14.04. Error during 'make'
But next I was trying to clone svn repo as I need to make changes in main.css so I would need help in that On Fri Nov 07 2014 at 3:57:52 PM Sweta Rani swetarani3...@gmail.com wrote: Yes I have done that. Now master and slave both are working. Thanks for help :) On Fri Nov 07 2014 at 3:55:29 PM Alex Rukletsov a...@mesosphere.io wrote: Hi Sweta, I'm a bit confused about what works for you and what doesn't. Are you now able to start mesos-master and mesos-slave and launch an example framework? On Thu, Nov 6, 2014 at 9:16 PM, Sweta Rani swetarani3...@gmail.com wrote: Cloning from svn repo gave following error: proxima@proxima-HP-Pavilion-m6-Notebook-PC:~/mesodoc$ rake Cloning Apache Mesos codebase Cloning into '/home/proxima/mesodoc/tmp/mesos'... remote: Counting objects: 1075, done. remote: Compressing objects: 100% (935/935), done. remote: Total 1075 (delta 221), reused 537 (delta 83) Receiving objects: 100% (1075/1075), 26.77 MiB | 171.00 KiB/s, done. Resolving deltas: 100% (221/221), done. Checking connectivity... done. Updating latest documentation from the Apache Mesos codebase Updating docs to the latest version rake aborted! Errno::ENOENT: No such file or directory - /home/proxima/mesodoc/source/documentation/latest/ running-torque-or-mpi-on-mesos.md /home/proxima/mesodoc/Rakefile:43:in `block in top (required)' Tasks: TOP = default = update_docs Neither I could get assets folder in this. How will I make changes? On Thu Nov 06 2014 at 10:55:38 PM Joris Van Remoortere jo...@mesosphere.io wrote: If you run: mesos-slave.sh --help Then you will see all the options you can pass to the slave. One of them is --port=VALUE Joris On Thu, Nov 6, 2014 at 6:39 AM, Sweta Rani swetarani3...@gmail.com wrote: How can I change port for mesos-slave from default 5051 to 5052? *Sweta Rani* On Thu, Nov 6, 2014 at 7:58 PM, Sweta Rani swetarani3...@gmail.com wrote: Alex, Done with master but unable to run slave using command ./bin/mesos-slave.sh --master=127.0.0.1:5050 Also the port 5051 is allocated with random work '-'. See this: proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@proxima:~/mesos/build$ sudo kill -9 - kill: failed to parse argument: '-' proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@:~/mesos/build$ ./bin/mesos-slave.sh --master= 127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 19:51:22.737992 6367 process.cpp:1532] Failed to initialize, bind 0.0.0.0:5051: Address already in use [98] *** Check failure stack trace: *** Aborted (core dumped) *Sweta Rani* On Thu, Nov 6, 2014 at 7:07 PM, Alex Rukletsov a...@mesosphere.io wrote: Sweta, have you tried another port? On Thu, Nov 6, 2014 at 2:24 PM, Sweta Rani swetarani3...@gmail.com wrote: Joris Done with above commands, but now it gives following error: WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 18:50:48.117947 9706 process.cpp:1532] Failed to initialize, bind 127.0.0.1:5050: Address already in use [98] *** Check failure stack trace: *** I tried to solve it by http://stackoverflow.com/questions/10745878/ubuntu- error-with-apache-98address-already-in-use but it didnt work for me. *Sweta Rani* On Wed, Nov 5, 2014 at 3:50 AM, Joris Van Remoortere jo...@mesosphere.io wrote: You need to make the directory and set the permissions to the user you are running the master as. For example: sudo mkdir /var/lib/mesos sudo chown jmlvanre /var/lib/mesos [jmlvanre] run mesos master... On Tue, Nov 4, 2014 at 2:07 PM, Sweta Rani swetarani3...@gmail.com wrote: Thanks for your help. I have installed mesos but unable to start mesos master by the command ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos. The file exists as mesos-master.sh.in in the bin folder. It reports: Failed to create work directory '/var/lib/mesos': Permission denied *Sweta Rani* On Tue, Nov 4, 2014 at 2:50 PM, Adam Bordelon
Re: Unable to install Mesos on Ubuntu 14.04. Error during 'make'
You're welcome! If you would like to contribute to Mesos (what is highly encouraged!) please check this guide https://mesos.apache.org/documentation/latest/mesos-developers-guide/. AFAIK, you don't need to clone any svn repos for this : ). On Fri, Nov 7, 2014 at 11:29 AM, Sweta Rani swetarani3...@gmail.com wrote: But next I was trying to clone svn repo as I need to make changes in main.css so I would need help in that On Fri Nov 07 2014 at 3:57:52 PM Sweta Rani swetarani3...@gmail.com wrote: Yes I have done that. Now master and slave both are working. Thanks for help :) On Fri Nov 07 2014 at 3:55:29 PM Alex Rukletsov a...@mesosphere.io wrote: Hi Sweta, I'm a bit confused about what works for you and what doesn't. Are you now able to start mesos-master and mesos-slave and launch an example framework? On Thu, Nov 6, 2014 at 9:16 PM, Sweta Rani swetarani3...@gmail.com wrote: Cloning from svn repo gave following error: proxima@proxima-HP-Pavilion-m6-Notebook-PC:~/mesodoc$ rake Cloning Apache Mesos codebase Cloning into '/home/proxima/mesodoc/tmp/mesos'... remote: Counting objects: 1075, done. remote: Compressing objects: 100% (935/935), done. remote: Total 1075 (delta 221), reused 537 (delta 83) Receiving objects: 100% (1075/1075), 26.77 MiB | 171.00 KiB/s, done. Resolving deltas: 100% (221/221), done. Checking connectivity... done. Updating latest documentation from the Apache Mesos codebase Updating docs to the latest version rake aborted! Errno::ENOENT: No such file or directory - /home/proxima/mesodoc/source/documentation/latest/ running-torque-or-mpi-on-mesos.md /home/proxima/mesodoc/Rakefile:43:in `block in top (required)' Tasks: TOP = default = update_docs Neither I could get assets folder in this. How will I make changes? On Thu Nov 06 2014 at 10:55:38 PM Joris Van Remoortere jo...@mesosphere.io wrote: If you run: mesos-slave.sh --help Then you will see all the options you can pass to the slave. One of them is --port=VALUE Joris On Thu, Nov 6, 2014 at 6:39 AM, Sweta Rani swetarani3...@gmail.com wrote: How can I change port for mesos-slave from default 5051 to 5052? *Sweta Rani* On Thu, Nov 6, 2014 at 7:58 PM, Sweta Rani swetarani3...@gmail.com wrote: Alex, Done with master but unable to run slave using command ./bin/mesos-slave.sh --master=127.0.0.1:5050 Also the port 5051 is allocated with random work '-'. See this: proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@proxima:~/mesos/build$ sudo kill -9 - kill: failed to parse argument: '-' proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@:~/mesos/build$ ./bin/mesos-slave.sh --master= 127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 19:51:22.737992 6367 process.cpp:1532] Failed to initialize, bind 0.0.0.0:5051: Address already in use [98] *** Check failure stack trace: *** Aborted (core dumped) *Sweta Rani* On Thu, Nov 6, 2014 at 7:07 PM, Alex Rukletsov a...@mesosphere.io wrote: Sweta, have you tried another port? On Thu, Nov 6, 2014 at 2:24 PM, Sweta Rani swetarani3...@gmail.com wrote: Joris Done with above commands, but now it gives following error: WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 18:50:48.117947 9706 process.cpp:1532] Failed to initialize, bind 127.0.0.1:5050: Address already in use [98] *** Check failure stack trace: *** I tried to solve it by http://stackoverflow.com/questions/10745878/ubuntu- error-with-apache-98address-already-in-use but it didnt work for me. *Sweta Rani* On Wed, Nov 5, 2014 at 3:50 AM, Joris Van Remoortere jo...@mesosphere.io wrote: You need to make the directory and set the permissions to the user you are running the master as. For example: sudo mkdir /var/lib/mesos sudo chown jmlvanre /var/lib/mesos [jmlvanre] run mesos master... On Tue, Nov 4, 2014 at 2:07 PM, Sweta Rani swetarani3...@gmail.com wrote:
Re: Unable to install Mesos on Ubuntu 14.04. Error during 'make'
Alex, I had followed those instruction and for that I cloned git repository but I don't have the asset folder in it where I need to make changes. So, how shall I proceed then. On Fri Nov 07 2014 at 4:07:58 PM Alex Rukletsov a...@mesosphere.io wrote: You're welcome! If you would like to contribute to Mesos (what is highly encouraged!) please check this guide https://mesos.apache.org/documentation/latest/mesos-developers-guide/. AFAIK, you don't need to clone any svn repos for this : ). On Fri, Nov 7, 2014 at 11:29 AM, Sweta Rani swetarani3...@gmail.com wrote: But next I was trying to clone svn repo as I need to make changes in main.css so I would need help in that On Fri Nov 07 2014 at 3:57:52 PM Sweta Rani swetarani3...@gmail.com wrote: Yes I have done that. Now master and slave both are working. Thanks for help :) On Fri Nov 07 2014 at 3:55:29 PM Alex Rukletsov a...@mesosphere.io wrote: Hi Sweta, I'm a bit confused about what works for you and what doesn't. Are you now able to start mesos-master and mesos-slave and launch an example framework? On Thu, Nov 6, 2014 at 9:16 PM, Sweta Rani swetarani3...@gmail.com wrote: Cloning from svn repo gave following error: proxima@proxima-HP-Pavilion-m6-Notebook-PC:~/mesodoc$ rake Cloning Apache Mesos codebase Cloning into '/home/proxima/mesodoc/tmp/mesos'... remote: Counting objects: 1075, done. remote: Compressing objects: 100% (935/935), done. remote: Total 1075 (delta 221), reused 537 (delta 83) Receiving objects: 100% (1075/1075), 26.77 MiB | 171.00 KiB/s, done. Resolving deltas: 100% (221/221), done. Checking connectivity... done. Updating latest documentation from the Apache Mesos codebase Updating docs to the latest version rake aborted! Errno::ENOENT: No such file or directory - /home/proxima/mesodoc/source/documentation/latest/ running-torque-or-mpi-on-mesos.md /home/proxima/mesodoc/Rakefile:43:in `block in top (required)' Tasks: TOP = default = update_docs Neither I could get assets folder in this. How will I make changes? On Thu Nov 06 2014 at 10:55:38 PM Joris Van Remoortere jo...@mesosphere.io wrote: If you run: mesos-slave.sh --help Then you will see all the options you can pass to the slave. One of them is --port=VALUE Joris On Thu, Nov 6, 2014 at 6:39 AM, Sweta Rani swetarani3...@gmail.com wrote: How can I change port for mesos-slave from default 5051 to 5052? *Sweta Rani* On Thu, Nov 6, 2014 at 7:58 PM, Sweta Rani swetarani3...@gmail.com wrote: Alex, Done with master but unable to run slave using command ./bin/mesos-slave.sh --master=127.0.0.1:5050 Also the port 5051 is allocated with random work '-'. See this: proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@proxima:~/mesos/build$ sudo kill -9 - kill: failed to parse argument: '-' proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@:~/mesos/build$ ./bin/mesos-slave.sh --master= 127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 19:51:22.737992 6367 process.cpp:1532] Failed to initialize, bind 0.0.0.0:5051: Address already in use [98] *** Check failure stack trace: *** Aborted (core dumped) *Sweta Rani* On Thu, Nov 6, 2014 at 7:07 PM, Alex Rukletsov a...@mesosphere.io wrote: Sweta, have you tried another port? On Thu, Nov 6, 2014 at 2:24 PM, Sweta Rani swetarani3...@gmail.com wrote: Joris Done with above commands, but now it gives following error: WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 18:50:48.117947 9706 process.cpp:1532] Failed to initialize, bind 127.0.0.1:5050: Address already in use [98] *** Check failure stack trace: *** I tried to solve it by http://stackoverflow.com/questions/10745878/ubuntu- error-with-apache-98address-already-in-use but it didnt work for me. *Sweta Rani* On Wed, Nov 5, 2014 at 3:50 AM, Joris Van Remoortere jo...@mesosphere.io wrote: You
Re: Unable to install Mesos on Ubuntu 14.04. Error during 'make'
Alex, I am referring to http://mesos.apache.org/assets/css/main.css. On Fri Nov 07 2014 at 4:11:10 PM Sweta Rani swetarani3...@gmail.com wrote: Alex, I had followed those instruction and for that I cloned git repository but I don't have the asset folder in it where I need to make changes. So, how shall I proceed then. On Fri Nov 07 2014 at 4:07:58 PM Alex Rukletsov a...@mesosphere.io wrote: You're welcome! If you would like to contribute to Mesos (what is highly encouraged!) please check this guide https://mesos.apache.org/documentation/latest/mesos-developers-guide/. AFAIK, you don't need to clone any svn repos for this : ). On Fri, Nov 7, 2014 at 11:29 AM, Sweta Rani swetarani3...@gmail.com wrote: But next I was trying to clone svn repo as I need to make changes in main.css so I would need help in that On Fri Nov 07 2014 at 3:57:52 PM Sweta Rani swetarani3...@gmail.com wrote: Yes I have done that. Now master and slave both are working. Thanks for help :) On Fri Nov 07 2014 at 3:55:29 PM Alex Rukletsov a...@mesosphere.io wrote: Hi Sweta, I'm a bit confused about what works for you and what doesn't. Are you now able to start mesos-master and mesos-slave and launch an example framework? On Thu, Nov 6, 2014 at 9:16 PM, Sweta Rani swetarani3...@gmail.com wrote: Cloning from svn repo gave following error: proxima@proxima-HP-Pavilion-m6-Notebook-PC:~/mesodoc$ rake Cloning Apache Mesos codebase Cloning into '/home/proxima/mesodoc/tmp/mesos'... remote: Counting objects: 1075, done. remote: Compressing objects: 100% (935/935), done. remote: Total 1075 (delta 221), reused 537 (delta 83) Receiving objects: 100% (1075/1075), 26.77 MiB | 171.00 KiB/s, done. Resolving deltas: 100% (221/221), done. Checking connectivity... done. Updating latest documentation from the Apache Mesos codebase Updating docs to the latest version rake aborted! Errno::ENOENT: No such file or directory - /home/proxima/mesodoc/source/documentation/latest/ running-torque-or-mpi-on-mesos.md /home/proxima/mesodoc/Rakefile:43:in `block in top (required)' Tasks: TOP = default = update_docs Neither I could get assets folder in this. How will I make changes? On Thu Nov 06 2014 at 10:55:38 PM Joris Van Remoortere jo...@mesosphere.io wrote: If you run: mesos-slave.sh --help Then you will see all the options you can pass to the slave. One of them is --port=VALUE Joris On Thu, Nov 6, 2014 at 6:39 AM, Sweta Rani swetarani3...@gmail.com wrote: How can I change port for mesos-slave from default 5051 to 5052? *Sweta Rani* On Thu, Nov 6, 2014 at 7:58 PM, Sweta Rani swetarani3...@gmail.com wrote: Alex, Done with master but unable to run slave using command ./bin/mesos-slave.sh --master=127.0.0.1:5050 Also the port 5051 is allocated with random work '-'. See this: proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@proxima:~/mesos/build$ sudo kill -9 - kill: failed to parse argument: '-' proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@:~/mesos/build$ ./bin/mesos-slave.sh --master= 127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 19:51:22.737992 6367 process.cpp:1532] Failed to initialize, bind 0.0.0.0:5051: Address already in use [98] *** Check failure stack trace: *** Aborted (core dumped) *Sweta Rani* On Thu, Nov 6, 2014 at 7:07 PM, Alex Rukletsov a...@mesosphere.io wrote: Sweta, have you tried another port? On Thu, Nov 6, 2014 at 2:24 PM, Sweta Rani swetarani3...@gmail.com wrote: Joris Done with above commands, but now it gives following error: WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 18:50:48.117947 9706 process.cpp:1532] Failed to initialize, bind 127.0.0.1:5050: Address already in use [98] *** Check failure stack trace: *** I tried to solve it by http://stackoverflow.com/questions/10745878/ubuntu- error-with-apache-98address-already-in-use but it didnt work for me.
Re: Unable to install Mesos on Ubuntu 14.04. Error during 'make'
Got it. I was wrong (thanks Till for correcting me on IRC!), you do need the SVN repo. At this point, I'll let the others chime in. Best, Alex On Fri, Nov 7, 2014 at 11:59 AM, Sweta Rani swetarani3...@gmail.com wrote: Alex, I am referring to http://mesos.apache.org/assets/css/main.css. On Fri Nov 07 2014 at 4:11:10 PM Sweta Rani swetarani3...@gmail.com wrote: Alex, I had followed those instruction and for that I cloned git repository but I don't have the asset folder in it where I need to make changes. So, how shall I proceed then. On Fri Nov 07 2014 at 4:07:58 PM Alex Rukletsov a...@mesosphere.io wrote: You're welcome! If you would like to contribute to Mesos (what is highly encouraged!) please check this guide https://mesos.apache.org/documentation/latest/mesos-developers-guide/ . AFAIK, you don't need to clone any svn repos for this : ). On Fri, Nov 7, 2014 at 11:29 AM, Sweta Rani swetarani3...@gmail.com wrote: But next I was trying to clone svn repo as I need to make changes in main.css so I would need help in that On Fri Nov 07 2014 at 3:57:52 PM Sweta Rani swetarani3...@gmail.com wrote: Yes I have done that. Now master and slave both are working. Thanks for help :) On Fri Nov 07 2014 at 3:55:29 PM Alex Rukletsov a...@mesosphere.io wrote: Hi Sweta, I'm a bit confused about what works for you and what doesn't. Are you now able to start mesos-master and mesos-slave and launch an example framework? On Thu, Nov 6, 2014 at 9:16 PM, Sweta Rani swetarani3...@gmail.com wrote: Cloning from svn repo gave following error: proxima@proxima-HP-Pavilion-m6-Notebook-PC:~/mesodoc$ rake Cloning Apache Mesos codebase Cloning into '/home/proxima/mesodoc/tmp/mesos'... remote: Counting objects: 1075, done. remote: Compressing objects: 100% (935/935), done. remote: Total 1075 (delta 221), reused 537 (delta 83) Receiving objects: 100% (1075/1075), 26.77 MiB | 171.00 KiB/s, done. Resolving deltas: 100% (221/221), done. Checking connectivity... done. Updating latest documentation from the Apache Mesos codebase Updating docs to the latest version rake aborted! Errno::ENOENT: No such file or directory - /home/proxima/mesodoc/source/documentation/latest/ running-torque-or-mpi-on-mesos.md /home/proxima/mesodoc/Rakefile:43:in `block in top (required)' Tasks: TOP = default = update_docs Neither I could get assets folder in this. How will I make changes? On Thu Nov 06 2014 at 10:55:38 PM Joris Van Remoortere jo...@mesosphere.io wrote: If you run: mesos-slave.sh --help Then you will see all the options you can pass to the slave. One of them is --port=VALUE Joris On Thu, Nov 6, 2014 at 6:39 AM, Sweta Rani swetarani3...@gmail.com wrote: How can I change port for mesos-slave from default 5051 to 5052? *Sweta Rani* On Thu, Nov 6, 2014 at 7:58 PM, Sweta Rani swetarani3...@gmail.com wrote: Alex, Done with master but unable to run slave using command ./bin/mesos-slave.sh --master=127.0.0.1:5050 Also the port 5051 is allocated with random work '-'. See this: proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@proxima:~/mesos/build$ sudo kill -9 - kill: failed to parse argument: '-' proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@:~/mesos/build$ ./bin/mesos-slave.sh --master= 127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 19:51:22.737992 6367 process.cpp:1532] Failed to initialize, bind 0.0.0.0:5051: Address already in use [98] *** Check failure stack trace: *** Aborted (core dumped) *Sweta Rani* On Thu, Nov 6, 2014 at 7:07 PM, Alex Rukletsov a...@mesosphere.io wrote: Sweta, have you tried another port? On Thu, Nov 6, 2014 at 2:24 PM, Sweta Rani swetarani3...@gmail.com wrote: Joris Done with above commands, but now it gives following error: WARNING: Logging before InitGoogleLogging() is written to STDERR F1106
Review Request 27724: Fixed invalid characters in external-containerizer.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27724/ --- Review request for mesos. Repository: mesos-git Description --- see summary. Diffs - docs/external-containerizer.md 0594bee Diff: https://reviews.apache.org/r/27724/diff/ Testing --- grep --color='auto' -P -n [\x80-\xFF] external-containerizer.md Thanks, Till Toenshoff
Re: Unable to install Mesos on Ubuntu 14.04. Error during 'make'
K. I will wait till the https://reviews.apache.org/r/27724/ is commited. Then try again. Thanks, Sweta On Fri Nov 07 2014 at 6:10:34 PM Alex Rukletsov a...@mesosphere.io wrote: Got it. I was wrong (thanks Till for correcting me on IRC!), you do need the SVN repo. At this point, I'll let the others chime in. Best, Alex On Fri, Nov 7, 2014 at 11:59 AM, Sweta Rani swetarani3...@gmail.com wrote: Alex, I am referring to http://mesos.apache.org/assets/css/main.css. On Fri Nov 07 2014 at 4:11:10 PM Sweta Rani swetarani3...@gmail.com wrote: Alex, I had followed those instruction and for that I cloned git repository but I don't have the asset folder in it where I need to make changes. So, how shall I proceed then. On Fri Nov 07 2014 at 4:07:58 PM Alex Rukletsov a...@mesosphere.io wrote: You're welcome! If you would like to contribute to Mesos (what is highly encouraged!) please check this guide https://mesos.apache.org/documentation/latest/mesos- developers-guide/ . AFAIK, you don't need to clone any svn repos for this : ). On Fri, Nov 7, 2014 at 11:29 AM, Sweta Rani swetarani3...@gmail.com wrote: But next I was trying to clone svn repo as I need to make changes in main.css so I would need help in that On Fri Nov 07 2014 at 3:57:52 PM Sweta Rani swetarani3...@gmail.com wrote: Yes I have done that. Now master and slave both are working. Thanks for help :) On Fri Nov 07 2014 at 3:55:29 PM Alex Rukletsov a...@mesosphere.io wrote: Hi Sweta, I'm a bit confused about what works for you and what doesn't. Are you now able to start mesos-master and mesos-slave and launch an example framework? On Thu, Nov 6, 2014 at 9:16 PM, Sweta Rani swetarani3...@gmail.com wrote: Cloning from svn repo gave following error: proxima@proxima-HP-Pavilion-m6-Notebook-PC:~/mesodoc$ rake Cloning Apache Mesos codebase Cloning into '/home/proxima/mesodoc/tmp/mesos'... remote: Counting objects: 1075, done. remote: Compressing objects: 100% (935/935), done. remote: Total 1075 (delta 221), reused 537 (delta 83) Receiving objects: 100% (1075/1075), 26.77 MiB | 171.00 KiB/s, done. Resolving deltas: 100% (221/221), done. Checking connectivity... done. Updating latest documentation from the Apache Mesos codebase Updating docs to the latest version rake aborted! Errno::ENOENT: No such file or directory - /home/proxima/mesodoc/source/documentation/latest/ running-torque-or-mpi-on-mesos.md /home/proxima/mesodoc/Rakefile:43:in `block in top (required)' Tasks: TOP = default = update_docs Neither I could get assets folder in this. How will I make changes? On Thu Nov 06 2014 at 10:55:38 PM Joris Van Remoortere jo...@mesosphere.io wrote: If you run: mesos-slave.sh --help Then you will see all the options you can pass to the slave. One of them is --port=VALUE Joris On Thu, Nov 6, 2014 at 6:39 AM, Sweta Rani swetarani3...@gmail.com wrote: How can I change port for mesos-slave from default 5051 to 5052? *Sweta Rani* On Thu, Nov 6, 2014 at 7:58 PM, Sweta Rani swetarani3...@gmail.com wrote: Alex, Done with master but unable to run slave using command ./bin/mesos-slave.sh --master=127.0.0.1:5050 Also the port 5051 is allocated with random work '-'. See this: proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@proxima:~/mesos/build$ sudo kill -9 - kill: failed to parse argument: '-' proxima@proxima:~/mesos/build$ netstat -ltnp | grep ':5051' (Not all processes could be identified, non-owned process info will not be shown, you would have to be root to see it all.) tcp0 0 0.0.0.0:50510.0.0.0:* LISTEN - proxima@:~/mesos/build$ ./bin/mesos-slave.sh --master= 127.0.0.1:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR F1106 19:51:22.737992 6367 process.cpp:1532] Failed to initialize, bind 0.0.0.0:5051: Address already in use [98] *** Check failure stack trace: *** Aborted (core dumped) *Sweta Rani* On Thu, Nov 6, 2014 at 7:07 PM, Alex Rukletsov a...@mesosphere.io wrote: Sweta,
Re: Review Request 27724: Fixed invalid characters in external-containerizer.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27724/#review60313 --- Patch looks great! Reviews applied: [27724] All tests passed. - Mesos ReviewBot On Nov. 7, 2014, 12:52 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27724/ --- (Updated Nov. 7, 2014, 12:52 p.m.) Review request for mesos. Repository: mesos-git Description --- see summary. Diffs - docs/external-containerizer.md 0594bee Diff: https://reviews.apache.org/r/27724/diff/ Testing --- grep --color='auto' -P -n [\x80-\xFF] external-containerizer.md Thanks, Till Toenshoff
SVN : Connection Refused
Upon running svn checkout http://svn.apache.org/repos/asf/mesos/site mesos-last-attempt, it gives following error: svn: E000111: Unable to connect to a repository at URL ' http://svn.apache.org/repos/asf/mesos/site' svn: E000111: Error running context: Connection refused I am using proxy so I tried even: export HTTP_PROXY=http://10.3.100.207:8080; But still after this it didn't work. Thanks, Sweta
Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 7, 2014, 3:49 p.m.) Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'. Changes --- I forgot to remove this != that check Bugs: MESOS-2019 https://issues.apache.org/jira/browse/MESOS-2019 Repository: mesos-git Description --- At the moment, the Node class is used to keep a mapping from a socket to the ip port pair in the process namespace. I want to propose to extend its use by replacing the ip port fields from the UPID class and process namespace with this type. Diffs (updated) - 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b Diff: https://reviews.apache.org/r/27446/diff/ Testing --- make check Thanks, Evelina Dumitrescu
Fwd: SVN : Connection Refused
Upon running svn checkout http://svn.apache.org/repos/asf/mesos/site mesos-last-attempt, it gives following error: svn: E000111: Unable to connect to a repository at URL ' http://svn.apache.org/repos/asf/mesos/site' svn: E000111: Error running context: Connection refused I am using proxy so I tried even: export HTTP_PROXY=http://10.3.100.207:8080; But still after this it didn't work. Thanks, Sweta
Re: Review Request 27447: mesos: Replaced the ip and port pairs from UPID class and process namespace with Node class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27447/#review60340 --- Ship it! will wait for comments from other reviewers before committing. - Dominic Hamon On Nov. 6, 2014, 7:23 p.m., Evelina Dumitrescu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27447/ --- (Updated Nov. 6, 2014, 7:23 p.m.) Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'. Bugs: MESOS-2019 https://issues.apache.org/jira/browse/MESOS-2019 Repository: mesos-git Description --- At the moment, the Node class is used to keep a mapping from a socket to the ip port pair in the process namespace. I want to propose to extend its use by replacing the ip port fields from the UPID class and process namespace with this type. Diffs - src/common/protobuf_utils.cpp 33ce782960e88e07b910f844fbdcae4c0f19d9a7 src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/sched/sched.cpp 8ca052635bf8772a6fa95972931b6254c6e452ef src/scheduler/scheduler.cpp c74187cfeb57a748fd57198d3badd4b8773490eb src/slave/http.cpp 965d78c3e3ea2e3c922f62aabf6fc87c5cf2ab8d src/slave/slave.cpp 81e0c4ba702d492976f9c771b8d779853c423187 src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671 src/tests/files_tests.cpp a696aa22d56b37ee70c6e64c81a849da6d436451 src/tests/gc_tests.cpp f7747e2999cbd64ab0cd0321cca0021489dc3346 src/tests/logging_tests.cpp 58e9b3399c3de28b1c5b3a8ec8fdf85b7a31c6d5 src/tests/master_contender_detector_tests.cpp 8f7fb18f0ca985364565fc4cd50f113b1461fbe7 src/tests/master_tests.cpp a6d1a4a5b7d50a88e5b101c43f62d21300cf src/tests/monitor_tests.cpp 4b950e14bd94cdfa21212268b56bebdc1200078d Diff: https://reviews.apache.org/r/27447/diff/ Testing --- make check Thanks, Evelina Dumitrescu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/#review60341 --- Ship it! so much cleaner! fix up the style nits below and i'll wait for someone else to review before committing. 3rdparty/libprocess/include/process/node.hpp https://reviews.apache.org/r/27446/#comment101709 is there an extra space before 'port'? 3rdparty/libprocess/include/process/node.hpp https://reviews.apache.org/r/27446/#comment101708 you don't need the () around 'that' 3rdparty/libprocess/include/process/node.hpp https://reviews.apache.org/r/27446/#comment101711 this should be on the previous line and spaced differently - did you run the check style script? support/mesos-style.py if you install the git precommit hook from support/ it will run on commit, which is really helpful. 3rdparty/libprocess/src/process.cpp https://reviews.apache.org/r/27446/#comment101713 space before the - Dominic Hamon On Nov. 7, 2014, 7:49 a.m., Evelina Dumitrescu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 7, 2014, 7:49 a.m.) Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'. Bugs: MESOS-2019 https://issues.apache.org/jira/browse/MESOS-2019 Repository: mesos-git Description --- At the moment, the Node class is used to keep a mapping from a socket to the ip port pair in the process namespace. I want to propose to extend its use by replacing the ip port fields from the UPID class and process namespace with this type. Diffs - 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b Diff: https://reviews.apache.org/r/27446/diff/ Testing --- make check Thanks, Evelina Dumitrescu
Re: SVN : Connection Refused
http://stackoverflow.com/questions/1491180/how-to-configure-a-http-proxy-for-svn On Fri, Nov 7, 2014 at 8:10 AM, Sweta Rani swetarani3...@gmail.com wrote: Upon running svn checkout http://svn.apache.org/repos/asf/mesos/site mesos-last-attempt, it gives following error: svn: E000111: Unable to connect to a repository at URL ' http://svn.apache.org/repos/asf/mesos/site' svn: E000111: Error running context: Connection refused I am using proxy so I tried even: export HTTP_PROXY=http://10.3.100.207:8080; But still after this it didn't work. Thanks, Sweta
Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 7, 2014, 5:34 p.m.) Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'. Changes --- Fixed coding style issues. Bugs: MESOS-2019 https://issues.apache.org/jira/browse/MESOS-2019 Repository: mesos-git Description --- At the moment, the Node class is used to keep a mapping from a socket to the ip port pair in the process namespace. I want to propose to extend its use by replacing the ip port fields from the UPID class and process namespace with this type. Diffs (updated) - 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b Diff: https://reviews.apache.org/r/27446/diff/ Testing --- make check Thanks, Evelina Dumitrescu
Re: Review Request 27555: Refactored the C++ Resources class to support persistent disk resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27555/#review60351 --- include/mesos/resources.hpp https://reviews.apache.org/r/27555/#comment101714 Could this be `contains()`? I think that might be a bit more familiar and natural for people to work with compared to `superset()`: ``` offeredResources.contains(task.resources()) // vs. offeredResources.superset(task.resources()) ``` What do you think? - Ben Mahler On Nov. 4, 2014, 10:01 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27555/ --- (Updated Nov. 4, 2014, 10:01 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1974 https://issues.apache.org/jira/browse/MESOS-1974 Repository: mesos-git Description --- The purpose of the refactor is to support persistent disk resources. Here are the main things I've done in this refactor: 1) Resource objects in Resources are stored in minimal format (validated/non-zero). That allows us to kill isAllocatable, allocatable, isZero, etc. 2) 'matches' needs to be split into two pieces: one for combining and one for removing, in order to support persitent disk resource. For example, one cannot combine two Resource object with DiskInfo (it's like two disks), however, you can do removal if they are identical. 3) Some of the interfaces are not intuitive (e.g., =, see details in the ticket). I removed them in favor of more explicit interfaces. 4) Unified all the validation code. 5) Adjusted the tests accordingly. Diffs - include/mesos/resources.hpp 0e37170 src/cli/execute.cpp ddaa20d src/common/resources.cpp e9a0c85 src/examples/low_level_scheduler_libprocess.cpp 7ef5ea7 src/examples/low_level_scheduler_pthread.cpp 6e233a1 src/examples/no_executor_framework.cpp f98a073 src/examples/test_framework.cpp 187a611 src/master/drf_sorter.cpp 5464900 src/master/hierarchical_allocator_process.hpp 31dfb2c src/master/http.cpp 3189933 src/master/master.cpp d914786 src/tests/allocator_tests.cpp 58e15aa src/tests/gc_tests.cpp f7747e2 src/tests/master_tests.cpp 2e52574 src/tests/mesos.hpp c1d64a7 src/tests/resource_offers_tests.cpp fe66432 src/tests/resources_tests.cpp 3e50889 src/tests/slave_recovery_tests.cpp 98e059f src/tests/sorter_tests.cpp 0516ab5 Diff: https://reviews.apache.org/r/27555/diff/ Testing --- make check Thanks, Jie Yu
Re: SVN : Connection Refused
Thanks Joris, The next thing troubling is that svn-checkout copies some of the files to my desktop and then ends with error: svn: E200014: Checksum mismatch for '/home/proxima/mesos-last-attempt/source/api/latest/c++/search/functions_7.js': expected: 199b2291f4ed17d12c04094ba2b0c0f4 actual: 75278aea88496b7427ba1703695c7bf0 So, I tried svn cleanup and then again executing svn-checkout but again it copies some files and again gives same error at some other file. Executing repetitively these both commands would add some more file again and again but would would need at minimum 1000s execution to completely download the repository http://svn.apache.org/repos/asf/mesos/site/ . Therefore, please help me out with this. Thanks, Sweta On Fri Nov 07 2014 at 10:58:02 PM Joris Van Remoortere jo...@mesosphere.io wrote: http://stackoverflow.com/questions/1491180/how-to- configure-a-http-proxy-for-svn On Fri, Nov 7, 2014 at 8:10 AM, Sweta Rani swetarani3...@gmail.com wrote: Upon running svn checkout http://svn.apache.org/repos/asf/mesos/site mesos-last-attempt, it gives following error: svn: E000111: Unable to connect to a repository at URL ' http://svn.apache.org/repos/asf/mesos/site' svn: E000111: Error running context: Connection refused I am using proxy so I tried even: export HTTP_PROXY=http://10.3.100.207:8080; But still after this it didn't work. Thanks, Sweta
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review60358 --- src/master/master.cpp https://reviews.apache.org/r/27685/#comment101721 These should be TASK_ERROR metrics. src/master/master.cpp https://reviews.apache.org/r/27685/#comment101722 Ditto. src/tests/master_authorization_tests.cpp https://reviews.apache.org/r/27685/#comment101723 I'm surprised this is the only test you had to fix. Don't we have tests for invalid tasks that need to be fixed? - Vinod Kone On Nov. 6, 2014, 5:29 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/ --- (Updated Nov. 6, 2014, 5:29 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1143 https://issues.apache.org/jira/browse/MESOS-1143 Repository: mesos-git Description --- see summary Diffs - include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44 Diff: https://reviews.apache.org/r/27685/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review60360 --- NM. Looks like review bot caught this. Did you forget to run 'make check' ? Also, before this lands you should send an email to dev list to solicit feedback. This is a big change. - Vinod Kone On Nov. 6, 2014, 5:29 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/ --- (Updated Nov. 6, 2014, 5:29 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1143 https://issues.apache.org/jira/browse/MESOS-1143 Repository: mesos-git Description --- see summary Diffs - include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44 Diff: https://reviews.apache.org/r/27685/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 27555: Refactored the C++ Resources class to support persistent disk resources.
On Nov. 7, 2014, 6:02 p.m., Ben Mahler wrote: include/mesos/resources.hpp, lines 144-147 https://reviews.apache.org/r/27555/diff/2/?file=749699#file749699line144 Could this be `contains()`? I think that might be a bit more familiar and natural for people to work with compared to `superset()`: ``` offeredResources.contains(task.resources()) // vs. offeredResources.superset(task.resources()) ``` What do you think? Yeah, sounds good to me! - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27555/#review60351 --- On Nov. 4, 2014, 10:01 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27555/ --- (Updated Nov. 4, 2014, 10:01 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-1974 https://issues.apache.org/jira/browse/MESOS-1974 Repository: mesos-git Description --- The purpose of the refactor is to support persistent disk resources. Here are the main things I've done in this refactor: 1) Resource objects in Resources are stored in minimal format (validated/non-zero). That allows us to kill isAllocatable, allocatable, isZero, etc. 2) 'matches' needs to be split into two pieces: one for combining and one for removing, in order to support persitent disk resource. For example, one cannot combine two Resource object with DiskInfo (it's like two disks), however, you can do removal if they are identical. 3) Some of the interfaces are not intuitive (e.g., =, see details in the ticket). I removed them in favor of more explicit interfaces. 4) Unified all the validation code. 5) Adjusted the tests accordingly. Diffs - include/mesos/resources.hpp 0e37170 src/cli/execute.cpp ddaa20d src/common/resources.cpp e9a0c85 src/examples/low_level_scheduler_libprocess.cpp 7ef5ea7 src/examples/low_level_scheduler_pthread.cpp 6e233a1 src/examples/no_executor_framework.cpp f98a073 src/examples/test_framework.cpp 187a611 src/master/drf_sorter.cpp 5464900 src/master/hierarchical_allocator_process.hpp 31dfb2c src/master/http.cpp 3189933 src/master/master.cpp d914786 src/tests/allocator_tests.cpp 58e15aa src/tests/gc_tests.cpp f7747e2 src/tests/master_tests.cpp 2e52574 src/tests/mesos.hpp c1d64a7 src/tests/resource_offers_tests.cpp fe66432 src/tests/resources_tests.cpp 3e50889 src/tests/slave_recovery_tests.cpp 98e059f src/tests/sorter_tests.cpp 0516ab5 Diff: https://reviews.apache.org/r/27555/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.
On Nov. 7, 2014, 5:12 p.m., Dominic Hamon wrote: 3rdparty/libprocess/include/process/node.hpp, line 51 https://reviews.apache.org/r/27446/diff/5/?file=754538#file754538line51 this should be on the previous line and spaced differently - did you run the check style script? support/mesos-style.py if you install the git precommit hook from support/ it will run on commit, which is really helpful. When I have commited the code, the precommit hook didn't noticed me in this case. - Evelina --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/#review60341 --- On Nov. 7, 2014, 5:34 p.m., Evelina Dumitrescu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 7, 2014, 5:34 p.m.) Review request for mesos, Dominic Hamon, Joris Van Remoortere, and switched to 'mcypark'. Bugs: MESOS-2019 https://issues.apache.org/jira/browse/MESOS-2019 Repository: mesos-git Description --- At the moment, the Node class is used to keep a mapping from a socket to the ip port pair in the process namespace. I want to propose to extend its use by replacing the ip port fields from the UPID class and process namespace with this type. Diffs - 3rdparty/libprocess/include/process/node.hpp 7a96894456683be60595a8f96f85df37947ff5b6 3rdparty/libprocess/include/process/pid.hpp 23453229c2a868a62b143416de33cf630268a64e 3rdparty/libprocess/include/process/process.hpp 81a1f7a3fece78bb7df1e86850572922c8704ea4 3rdparty/libprocess/src/http.cpp 4ef00d11de4ff4e7eb4e44aac204147799f85ac2 3rdparty/libprocess/src/pid.cpp 20ff25c0959c247687955535f02e0397653af52a 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 3rdparty/libprocess/src/tests/benchmarks.cpp 3177a8ecac6adf8b52c3160587dc3a4fe2707d26 3rdparty/libprocess/src/tests/http_tests.cpp a1c3685c88d268c7ecdc2dad22608198dc0b295d 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75 3rdparty/libprocess/src/tests/process_tests.cpp b985fb77ea05fae5c0b144ea48814acc7bb5135b Diff: https://reviews.apache.org/r/27446/diff/ Testing --- make check Thanks, Evelina Dumitrescu
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory access.
On Nov. 7, 2014, 8:31 p.m., Adam B wrote: LGTM, but we may want to warn people that the Authenticator interface is expected to change (slightly) in 0.22 Indeed - I shall add that to the interface definition right away. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27741/#review60372 --- On Nov. 7, 2014, 8:26 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27741/ --- (Updated Nov. 7, 2014, 8:26 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description --- see summary. Diffs - src/authentication/authenticator.hpp 2f95db1 src/authentication/cram_md5/authenticator.hpp 601248d src/master/master.cpp a860496 src/tests/cram_md5_authentication_tests.cpp 74ea2ad Diff: https://reviews.apache.org/r/27741/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory access.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27741/ --- (Updated Nov. 7, 2014, 8:42 p.m.) Review request for mesos, Adam B and Vinod Kone. Changes --- Added comment announcing an upcoming change. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description --- see summary. Diffs (updated) - src/authentication/authenticator.hpp 2f95db1 src/authentication/cram_md5/authenticator.hpp 601248d src/master/master.cpp a860496 src/tests/cram_md5_authentication_tests.cpp 74ea2ad Diff: https://reviews.apache.org/r/27741/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27724: Fixed invalid characters in external-containerizer.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27724/#review60378 --- Ship it! Ship It! - Kapil Arya On Nov. 7, 2014, 7:52 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27724/ --- (Updated Nov. 7, 2014, 7:52 a.m.) Review request for mesos. Repository: mesos-git Description --- see summary. Diffs - docs/external-containerizer.md 0594bee Diff: https://reviews.apache.org/r/27724/diff/ Testing --- grep --color='auto' -P -n [\x80-\xFF] external-containerizer.md Thanks, Till Toenshoff
Re: Review Request 27738: Always recover 'completed' in RunState.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27738/ --- (Updated Nov. 7, 2014, 1:24 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2052 https://issues.apache.org/jira/browse/MESOS-2052 Repository: mesos-git Description --- Always recover 'completed' in RunState. Diffs (updated) - src/slave/state.cpp 87e9eb958d1af4e6742f1eed7fe90fedb16b07a7 Diff: https://reviews.apache.org/r/27738/diff/ Testing --- Thanks, Ian Downes
Review Request 27744: Separate Metrics struct from Master class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27744/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2051 https://issues.apache.org/jira/browse/MESOS-2051 Repository: mesos-git Description --- see summary Diffs - src/Makefile.am 9ab3b9c05d435d18ed1c2966f695857fa205e9fd src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7 src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/master/metrics.hpp PRE-CREATION src/master/metrics.cpp PRE-CREATION src/tests/metrics_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/27744/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors
On Nov. 7, 2014, 11:25 a.m., Vinod Kone wrote: NM. Looks like review bot caught this. Did you forget to run 'make check' ? Also, before this lands you should send an email to dev list to solicit feedback. This is a big change. i ran make check, i had GTEST_FILTER set. sorry. - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review60360 --- On Nov. 6, 2014, 9:29 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/ --- (Updated Nov. 6, 2014, 9:29 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1143 https://issues.apache.org/jira/browse/MESOS-1143 Repository: mesos-git Description --- see summary Diffs - include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44 Diff: https://reviews.apache.org/r/27685/diff/ Testing --- make check Thanks, Dominic Hamon
Re: TaskStatus source and reason fields
An update: I have a patch ready to land for MESOS-1143 https://issues.apache.org/jira/browse/MESOS-1143. Before it lands, I'd like to solicit feedback as this changes the semantics for frameworks (for the better!). Any thoughts or reservations? On Tue, Nov 4, 2014 at 2:32 PM, Dominic Hamon dha...@twopensource.com wrote: As per MESOS-343 https://issues.apache.org/jira/browse/MESOS-343, the TaskStatus now contains source and reason fields. These are set to allow frameworks to differentiate between status updates that come from the Master, Slave, or Executor, and to get more information in a programmatic way about the update. This will be part of the 0.21.0 release. As a further enhancement, TASK_ERROR has been added (see MESOS-1143 https://issues.apache.org/jira/browse/MESOS-1143) as part of 0.21.0. It is not currently being sent, but will be in the next release (0.22.0) to allow time for frameworks to support it. The semantics of TASK_LOST vs TASK_ERROR are simple: TASK_LOST means that attempting to reschedule the task should succeed. TASK_ERROR means that any attempt to reschedule the task will fail. This allows frameworks to make better decisions. Thank you. -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.* -- Dominic Hamon | @mrdo | Twitter *There are no bad ideas; only good ideas that go horribly wrong.*
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory access.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27741/#review60389 --- Patch looks great! Reviews applied: [27741] All tests passed. - Mesos ReviewBot On Nov. 7, 2014, 8:42 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27741/ --- (Updated Nov. 7, 2014, 8:42 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description --- see summary. Diffs - src/authentication/authenticator.hpp 2f95db1 src/authentication/cram_md5/authenticator.hpp 601248d src/master/master.cpp a860496 src/tests/cram_md5_authentication_tests.cpp 74ea2ad Diff: https://reviews.apache.org/r/27741/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/ --- (Updated Nov. 7, 2014, 2:04 p.m.) Review request for mesos and Vinod Kone. Changes --- fixed some tests. Bugs: MESOS-1143 https://issues.apache.org/jira/browse/MESOS-1143 Repository: mesos-git Description --- see summary Diffs (updated) - include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7 src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44 src/tests/resource_offers_tests.cpp ee332c3a529d77af0d1760fbafad51769bf7dc2c Diff: https://reviews.apache.org/r/27685/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 27738: Always recover 'completed' in RunState.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27738/#review60408 --- Patch looks great! Reviews applied: [27738] All tests passed. - Mesos ReviewBot On Nov. 7, 2014, 9:24 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27738/ --- (Updated Nov. 7, 2014, 9:24 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2052 https://issues.apache.org/jira/browse/MESOS-2052 Repository: mesos-git Description --- Always recover 'completed' in RunState. Diffs - src/slave/state.cpp 87e9eb958d1af4e6742f1eed7fe90fedb16b07a7 Diff: https://reviews.apache.org/r/27738/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 27744: Separate Metrics struct from Master class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27744/#review60416 --- Patch looks great! Reviews applied: [27744] All tests passed. - Mesos ReviewBot On Nov. 7, 2014, 9:25 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27744/ --- (Updated Nov. 7, 2014, 9:25 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2051 https://issues.apache.org/jira/browse/MESOS-2051 Repository: mesos-git Description --- see summary Diffs - src/Makefile.am 9ab3b9c05d435d18ed1c2966f695857fa205e9fd src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7 src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/master/metrics.hpp PRE-CREATION src/master/metrics.cpp PRE-CREATION src/tests/metrics_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/27744/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Design Review: Maintenance Primitives
Now that persistent resources need to be considered, we revisited the maintenance design to ensure persistent frameworks were accounted for. In particular, in the updated design we allow operators to specify a conservative estimate of the unavailability; useful for persistent frameworks. There is no longer a split between the planned schedule and the actual draining, also useful for persistent frameworks. The updated high level design is here: https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/edit?usp=sharing On Mon, Aug 25, 2014 at 12:24 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hi all, I wanted to take a moment to thank Alexandra Sava, who completed her OPW internship this past week. We worked together in the second half of her internship to create a design document for maintenance primitives in Mesos (the original ticket is MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474, but the design document is the most up-to-date plan). Maintenance in this context consists of anything that requires the tasks running on the slave to be killed (e.g. kernel upgrades, machine decommissioning, non-recoverable mesos upgrades / configuration changes, etc). The desire is to expose maintenance events to frameworks in a generic manner, as to allow frameworks to respect their SLAs, perform better task placement, and migrate tasks if necessary. The design document is here: https://docs.google.com/document/d/1NjK7MQeJzTRdfZTQ9q1Q5p4dY985bZ7cFqDpX4_fgjM/edit?usp=sharing Please take a moment before the end of next week to go over this design. *Higher level feedback and questions can be discussed most effectively in this thread.* Let's thank Alexandra for her work! Ben
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory access.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27741/ --- (Updated Nov. 7, 2014, 11:47 p.m.) Review request for mesos, Adam B and Vinod Kone. Changes --- Addressed comments. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description --- see summary. Diffs (updated) - src/authentication/authenticator.hpp 2f95db1 src/authentication/cram_md5/authenticator.hpp 601248d src/master/master.cpp a860496 src/tests/cram_md5_authentication_tests.cpp 74ea2ad Diff: https://reviews.apache.org/r/27741/diff/ Testing --- make check Thanks, Till Toenshoff
Re: SVN : Connection Refused
There is a problem as in the Rakefile the gem versions are outdated and gem install bundle installs the latest version. Therefore, executing rake gives error regarding activated gems: /var/lib/gems/1.9.1/gems/bundler-1.7.4/lib/bundler/runtime.rb:34:in `block in setup': You have already activated listen 2.7.11, but your Gemfile requires listen 1.3.1. Prepending `bundle exec` to your command may solve this. (Gem::LoadError) Therefore, I made changes in Rakefile to use the updated version and thus it passed some steps but at end again it again stucked with error: Building website from static source /var/lib/gems/1.9.1/gems/middleman-core-3.3.6/lib/middleman-core/application.rb:16:in `require': cannot load such file -- hooks (LoadError) from /var/lib/gems/1.9.1/gems/middleman-core-3.3.6/lib/middleman-core/application.rb:16:in `top (required)' from /var/lib/gems/1.9.1/gems/middleman-core-3.3.6/lib/middleman-core.rb:16:in `require' from /var/lib/gems/1.9.1/gems/middleman-core-3.3.6/lib/middleman-core.rb:16:in `top (required)' from /var/lib/gems/1.9.1/gems/middleman-3.3.6/lib/middleman.rb:1:in `require' from /var/lib/gems/1.9.1/gems/middleman-3.3.6/lib/middleman.rb:1:in `top (required)' from /var/lib/gems/1.9.1/gems/bundler-1.7.4/lib/bundler/runtime.rb:76:in `require' from /var/lib/gems/1.9.1/gems/bundler-1.7.4/lib/bundler/runtime.rb:76:in `block (2 levels) in require' from /var/lib/gems/1.9.1/gems/bundler-1.7.4/lib/bundler/runtime.rb:72:in `each' from /var/lib/gems/1.9.1/gems/bundler-1.7.4/lib/bundler/runtime.rb:72:in `block in require' from /var/lib/gems/1.9.1/gems/bundler-1.7.4/lib/bundler/runtime.rb:61:in `each' from /var/lib/gems/1.9.1/gems/bundler-1.7.4/lib/bundler/runtime.rb:61:in `require' from /var/lib/gems/1.9.1/gems/bundler-1.7.4/lib/bundler.rb:133:in `require' from /var/lib/gems/1.9.1/gems/middleman-core-3.3.6/lib/middleman-core/load_paths.rb:37:in `setup_load_paths' from /var/lib/gems/1.9.1/gems/middleman-core-3.3.6/bin/middleman:10:in `top (required)' from /usr/local/bin/middleman:23:in `load' from /usr/local/bin/middleman:23:in `main' An error was encountered when generating the site So I am unable to build the site, so look into this and help me out Thanks Sweta
Review Request 27759: Added slave metrics for total and used resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27759/ --- Review request for mesos and Dominic Hamon. Bugs: MESOS-723 https://issues.apache.org/jira/browse/MESOS-723 Repository: mesos-git Description --- Copy pasted from master code. Diffs - src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/slave/slave.hpp 72bbec9f47285083b22dd00cf9fc55cf99f3b892 src/slave/slave.cpp 81e0c4ba702d492976f9c771b8d779853c423187 src/tests/slave_tests.cpp d2cbaf82391411bdc5d85327478d7ca8072048af Diff: https://reviews.apache.org/r/27759/diff/ Testing --- make check Thanks, Vinod Kone
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2536
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2536/changes Changes: [idownes] Document authentication prerequisites in docs/release-guide.md. -- [...truncated 64980 lines...] I1108 00:34:25.486357 30413 replica.cpp:655] Replica received learned notice for position 2 I1108 00:34:25.486925 30413 leveldb.cpp:343] Persisting action (18 bytes) to leveldb took 535526ns I1108 00:34:25.486991 30413 leveldb.cpp:401] Deleting ~1 keys from leveldb took 35909ns I1108 00:34:25.487015 30413 replica.cpp:676] Persisted action at 2 I1108 00:34:25.487037 30413 replica.cpp:661] Replica learned TRUNCATE action at position 2 I1108 00:34:25.496042 30391 containerizer.cpp:100] Using isolation: posix/cpu,posix/mem I1108 00:34:25.500035 30409 slave.cpp:169] Slave started on 221)@67.195.81.187:52486 I1108 00:34:25.500082 30409 credentials.hpp:84] Loading credential for authentication from '/tmp/AllocatorTest_0_OutOfOrderDispatch_qt7Jpt/credential' I1108 00:34:25.500229 30409 slave.cpp:276] Slave using credential for: test-principal I1108 00:34:25.500504 30409 slave.cpp:289] Slave resources: cpus(*):2; mem(*):1024; disk(*):3.70122e+06; ports(*):[31000-32000] I1108 00:34:25.500601 30409 slave.cpp:318] Slave hostname: pomona.apache.org I1108 00:34:25.597322 30409 slave.cpp:319] Slave checkpoint: false W1108 00:34:25.597342 30409 slave.cpp:321] Disabling checkpointing is deprecated and the --checkpoint flag will be removed in a future release. Please avoid using this flag I1108 00:34:25.506440 30391 sched.cpp:143] Version: 0.22.0 I1108 00:34:25.597941 30407 sched.cpp:239] New master detected at master@67.195.81.187:52486 I1108 00:34:25.597990 30407 sched.cpp:295] Authenticating with master master@67.195.81.187:52486 I1108 00:34:25.598129 30408 state.cpp:33] Recovering state from '/tmp/AllocatorTest_0_OutOfOrderDispatch_qt7Jpt/meta' I1108 00:34:25.598182 30409 authenticatee.hpp:133] Creating new client SASL connection I1108 00:34:25.598387 30417 master.cpp:3896] Authenticating scheduler-3fc275c9-0955-402b-ace5-0ce5996ba9f0@67.195.81.187:52486 I1108 00:34:25.598428 30417 master.cpp:3907] Using default CRAM-MD5 authenticator I1108 00:34:25.598450 30407 status_update_manager.cpp:197] Recovering status update manager I1108 00:34:25.598659 30405 authenticator.hpp:169] Creating new server SASL connection I1108 00:34:25.598700 30410 containerizer.cpp:281] Recovering containerizer I1108 00:34:25.598824 30415 authenticatee.hpp:224] Received SASL authentication mechanisms: CRAM-MD5 I1108 00:34:25.598856 30415 authenticatee.hpp:250] Attempting to authenticate with mechanism 'CRAM-MD5' I1108 00:34:25.598954 30412 authenticator.hpp:275] Received SASL authentication start I1108 00:34:25.599009 30412 authenticator.hpp:397] Authentication requires more steps I1108 00:34:25.599115 30418 authenticatee.hpp:270] Received SASL authentication step I1108 00:34:25.599237 30411 authenticator.hpp:303] Received SASL authentication step I1108 00:34:25.599272 30411 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'pomona.apache.org' server FQDN: 'pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I1108 00:34:25.599303 30411 auxprop.cpp:171] Looking up auxiliary property '*userPassword' I1108 00:34:25.599339 30411 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I1108 00:34:25.599364 30411 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'pomona.apache.org' server FQDN: 'pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true I1108 00:34:25.599375 30411 auxprop.cpp:121] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I1108 00:34:25.599382 30411 auxprop.cpp:121] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I1108 00:34:25.599400 30411 authenticator.hpp:389] Authentication success I1108 00:34:25.599483 30412 authenticatee.hpp:310] Authentication success I1108 00:34:25.599545 30410 master.cpp:3957] Successfully authenticated principal 'test-principal' at scheduler-3fc275c9-0955-402b-ace5-0ce5996ba9f0@67.195.81.187:52486 I1108 00:34:25.599724 30419 slave.cpp:3464] Finished recovery I1108 00:34:25.599882 30407 sched.cpp:369] Successfully authenticated with master master@67.195.81.187:52486 I1108 00:34:25.599916 30407 sched.cpp:488] Sending registration request to master@67.195.81.187:52486 I1108 00:34:25.57 30407 sched.cpp:521] Will retry registration in 388.285141ms if necessary I1108 00:34:25.600083 30406 master.cpp:1378] Received registration request for framework 'framework1' at scheduler-3fc275c9-0955-402b-ace5-0ce5996ba9f0@67.195.81.187:52486 I1108 00:34:25.600163 30406 master.cpp:1337] Authorizing framework principal
Re: Review Request 27738: Always recover 'completed' in RunState.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27738/#review60439 --- Ship it! Ship It! - Vinod Kone On Nov. 7, 2014, 9:24 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27738/ --- (Updated Nov. 7, 2014, 9:24 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2052 https://issues.apache.org/jira/browse/MESOS-2052 Repository: mesos-git Description --- Always recover 'completed' in RunState. Diffs - src/slave/state.cpp 87e9eb958d1af4e6742f1eed7fe90fedb16b07a7 Diff: https://reviews.apache.org/r/27738/diff/ Testing --- Thanks, Ian Downes
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2258
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2258/changes Changes: [idownes] Document authentication prerequisites in docs/release-guide.md. -- [...truncated 18890 lines...] I1108 00:34:22.405457 24242 status_update_manager.cpp:279] Closing status update streams for framework 20141108-003413-3125920579-41765-24224- I1108 00:34:22.405583 24241 gc.cpp:56] Scheduling '/tmp/MultipleExecutorsTest_ExecutorInfoDiffersOnDifferentSlaves_9bgtMO/slaves/20141108-003413-3125920579-41765-24224-S0/frameworks/20141108-003413-3125920579-41765-24224-' for gc 6.9530767407days in the future I1108 00:34:22.405596 24242 status_update_manager.cpp:525] Cleaning up status update stream for task 092f0aca-6532-4884-9274-6432bea560ed of framework 20141108-003413-3125920579-41765-24224- I1108 00:34:22.406733 24251 slave.cpp:2896] Executor 'default' of framework 20141108-003413-3125920579-41765-24224- exited with status 0 I1108 00:34:22.408874 24251 slave.cpp:2213] Handling status update TASK_LOST (UUID: 69d301a1-6895-4e0a-a756-d33e21d4504e) for task c555a8fa-4fee-43d3-a2b2-8841ee428b03 of framework 20141108-003413-3125920579-41765-24224- from @0.0.0.0:0 I1108 00:34:22.408947 24251 slave.cpp:4219] Terminating task c555a8fa-4fee-43d3-a2b2-8841ee428b03 I1108 00:34:22.409250 24251 slave.cpp:484] Slave terminating I1108 00:34:22.409303 24251 slave.cpp:1531] Asked to shut down framework 20141108-003413-3125920579-41765-24224- by @0.0.0.0:0 I1108 00:34:22.409323 24251 slave.cpp:1556] Shutting down framework 20141108-003413-3125920579-41765-24224- I1108 00:34:22.409364 24251 slave.cpp:3005] Cleaning up executor 'default' of framework 20141108-003413-3125920579-41765-24224- I1108 00:34:22.409600 24245 gc.cpp:56] Scheduling '/tmp/MultipleExecutorsTest_ExecutorInfoDiffersOnDifferentSlaves_zeIIzl/slaves/20141108-003413-3125920579-41765-24224-S1/frameworks/20141108-003413-3125920579-41765-24224-/executors/default/runs/e827712d-26ce-4a31-810a-81bf211cb43c' for gc 6.9526126222days in the future I1108 00:34:22.409694 24251 slave.cpp:3082] Cleaning up framework 20141108-003413-3125920579-41765-24224- I1108 00:34:22.409764 24245 gc.cpp:56] Scheduling '/tmp/MultipleExecutorsTest_ExecutorInfoDiffersOnDifferentSlaves_zeIIzl/slaves/20141108-003413-3125920579-41765-24224-S1/frameworks/20141108-003413-3125920579-41765-24224-/executors/default' for gc 6.952589days in the future I1108 00:34:22.409788 24244 status_update_manager.cpp:279] Closing status update streams for framework 20141108-003413-3125920579-41765-24224- I1108 00:34:22.409838 24244 status_update_manager.cpp:525] Cleaning up status update stream for task c555a8fa-4fee-43d3-a2b2-8841ee428b03 of framework 20141108-003413-3125920579-41765-24224- I1108 00:34:22.409924 24245 gc.cpp:56] Scheduling '/tmp/MultipleExecutorsTest_ExecutorInfoDiffersOnDifferentSlaves_zeIIzl/slaves/20141108-003413-3125920579-41765-24224-S1/frameworks/20141108-003413-3125920579-41765-24224-' for gc 6.9525718815days in the future [ OK ] MultipleExecutorsTest.ExecutorInfoDiffersOnDifferentSlaves (8861 ms) [--] 2 tests from MultipleExecutorsTest (11262 ms total) [--] 10 tests from ReconciliationTest [ RUN ] ReconciliationTest.TaskStateMismatch Using temporary directory '/tmp/ReconciliationTest_TaskStateMismatch_1PKX4d' I1108 00:34:22.417440 24224 leveldb.cpp:176] Opened db in 3.122873ms I1108 00:34:22.418473 24224 leveldb.cpp:183] Compacted db in 999477ns I1108 00:34:22.418527 24224 leveldb.cpp:198] Created db iterator in 5063ns I1108 00:34:24.455214 24224 leveldb.cpp:204] Seeked to beginning of db in 1400ns I1108 00:34:24.455238 24224 leveldb.cpp:273] Iterated through 0 keys in the db in 535ns I1108 00:34:24.455282 24224 replica.cpp:741] Replica recovered with log positions 0 - 0 with 1 holes and 0 unlearned I1108 00:34:24.455881 24238 recover.cpp:437] Starting replica recovery I1108 00:34:24.456686 24252 recover.cpp:463] Replica is in EMPTY status I1108 00:34:24.457906 24240 replica.cpp:638] Replica in EMPTY status received a broadcasted recover request I1108 00:34:24.458382 24241 recover.cpp:188] Received a recover response from a replica in EMPTY status I1108 00:34:24.458886 24240 recover.cpp:554] Updating replica status to STARTING I1108 00:34:24.459362 24248 master.cpp:318] Master 20141108-003424-3125920579-41765-24224 (penates.apache.org) started on 67.195.81.186:41765 I1108 00:34:24.459404 24248 master.cpp:364] Master only allowing authenticated frameworks to register I1108 00:34:24.459419 24248 master.cpp:369] Master only allowing authenticated slaves to register I1108 00:34:24.459444 24248 credentials.hpp:36] Loading credentials for authentication from '/tmp/ReconciliationTest_TaskStateMismatch_1PKX4d/credentials' I1108 00:34:24.459614 24238 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took
Re: Review Request 27759: Added slave metrics for total and used resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27759/#review60440 --- Ship it! Ship It! src/slave/slave.cpp https://reviews.apache.org/r/27759/#comment101839 s/adding/creating/ ? - Dominic Hamon On Nov. 7, 2014, 4:25 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27759/ --- (Updated Nov. 7, 2014, 4:25 p.m.) Review request for mesos and Dominic Hamon. Bugs: MESOS-723 https://issues.apache.org/jira/browse/MESOS-723 Repository: mesos-git Description --- Copy pasted from master code. Diffs - src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428 src/slave/slave.hpp 72bbec9f47285083b22dd00cf9fc55cf99f3b892 src/slave/slave.cpp 81e0c4ba702d492976f9c771b8d779853c423187 src/tests/slave_tests.cpp d2cbaf82391411bdc5d85327478d7ca8072048af Diff: https://reviews.apache.org/r/27759/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 27724: Fixed invalid characters in external-containerizer.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27724/#review60445 --- Ship it! Ship It! - Niklas Nielsen On Nov. 7, 2014, 4:52 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27724/ --- (Updated Nov. 7, 2014, 4:52 a.m.) Review request for mesos. Repository: mesos-git Description --- see summary. Diffs - docs/external-containerizer.md 0594bee Diff: https://reviews.apache.org/r/27724/diff/ Testing --- grep --color='auto' -P -n [\x80-\xFF] external-containerizer.md Thanks, Till Toenshoff
Review Request 27760: Revised authenticator interface to allow for two fold implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description --- The initial design and implementation of the authenticator module interface caused issues and was not optimal for heavy lifting setup of external dependencies. By introducing a two fold design, this has been decoupled from the authentication message processing. The new design also gets us back on track to the goal of makeing SASL a soft dependency of mesos. Diffs - src/authentication/authenticator.hpp 2f95db1 src/authentication/cram_md5/authenticator.hpp 601248d src/master/master.hpp 687f178 src/master/master.cpp a860496 src/tests/cram_md5_authentication_tests.cpp 74ea2ad Diff: https://reviews.apache.org/r/27760/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27741: Fixed Authenticator SASL auxiliary memory access.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27741/#review60453 --- Patch looks great! Reviews applied: [27741] All tests passed. - Mesos ReviewBot On Nov. 7, 2014, 11:47 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27741/ --- (Updated Nov. 7, 2014, 11:47 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description --- see summary. Diffs - src/authentication/authenticator.hpp 2f95db1 src/authentication/cram_md5/authenticator.hpp 601248d src/master/master.cpp a860496 src/tests/cram_md5_authentication_tests.cpp 74ea2ad Diff: https://reviews.apache.org/r/27741/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27113: Libprocess benchmark cleanup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/#review60425 --- Thanks for following up Joris!! Didn't look at the forking code since we might be able to avoid per (2): (1) Hm.. it might be easier for someone to understand how this benchmark works if we change the names of these processes to `ClientProcess` and `ServerProces`, from `PingerProcess` and `PongerProcess`, respectively. After which, let's rewrite the comments above the classes to be a bit less low-level. (2) Could we pull the client and server out into separate programs? That way, we could get two key benefits. First, we can start the server and as many clients as we like manually as well, and we can run the benchmark using http requests. That might make it a bit easier for us to collect `perf` traces of say, only the server process. Second, and less important, we might be able to leverage `Subprocess` to avoid the complicated forking logic currently in place. Let me know if I missed anything! 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101822 Let's replace all of unique_ptr here with Owned, since we're thinking of keeping the SharedT and OwnedT symmetry and using unique_ptr for low level library code. 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101843 Can we take all of these in the http::Request rather than the constructor? That way, we can run the client/server benchmark manually as well, per my top-level comment. 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101858 protected? 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101859 private? 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101842 Please defer into non-static member functions! I see two options here: (1) Create the Stopwatch within `start()` instead of as a member variable, and pass it into `finish()` via lambda::bind. That way, you could just make `finish()` a static method: ``` run(const http::Request request) { Stopwatch watch; watch.start(); // Parse arguments out of request. // NOTE: Place .then() on the next line please. return run(arguments) .then(lambda::bind(PingerProcess::finish, watch); } ``` (2) Even better, what about just having a `run()` which returns the Duration? ``` run(const http::Request request) { // Parse arguments out of request. return _run(arguments) .then(lambda::bind(PingerProcess::finish, labmda::_1)); } FutureDuration _run(size_t totalRequests, size_t maxOutstandingRequests) { ... } http::Response finish(const Duration duration) { return http::OK(stringify(duration)); } ``` 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101845 Should this be inside an `else`? 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101853 In line with my other comments above, we could place this inside `run`: ``` FutureDuration run(...) { watch.start(); while (requests maxOutstandingRequests) { send(server, ping); requests++; } return finished.future(); } void pong(const UPID from, const string body) { responses++; if (responses == totalRequests) { finished.set(watch.elapsed()); } if (requests totalRequests) { send(server, pong); requests++; } } ``` Note that we should ensure 0 maxOutstandingRequests = totalRequests when we parse it! 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101848 Ditto here, do we need the hi? For now I'd say let's kill it, and possibly introduce a custom message or a message size via a request parameter. 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101855 Let's clean up the naming so that the names can be self describing, avoiding the need for all these comments, and I think we only need four of these per my comments above? ``` size_t requests; size_t responses; const size_t totalRequests; const size_t maxOutstandingRequests; ``` 3rdparty/libprocess/src/tests/benchmarks.cpp https://reviews.apache.org/r/27113/#comment101821 Can we rely on these to be generated? What does it mean for a zero argument constructor to be marked `explicit`? 3rdparty/libprocess/src/tests/benchmarks.cpp
Review Request 27765: Fixed MesosContainerizerExecuteTest.IoRedirection test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27765/ --- Review request for mesos and Ian Downes. Bugs: MESOS-2048 https://issues.apache.org/jira/browse/MESOS-2048 Repository: mesos-git Description --- See summary. Diffs - src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983 Diff: https://reviews.apache.org/r/27765/diff/ Testing --- make check GTEST_FILTER=*IoRedirection* Thanks, Vinod Kone
Review Request 27767: Fixed typo in mesos-containerizer.md causing middleman to fail.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27767/ --- Review request for mesos. Repository: mesos-git Description --- see summary. Diffs - docs/mesos-containerizer.md e4b2c24 Diff: https://reviews.apache.org/r/27767/diff/ Testing --- middleman build --verbose Thanks, Till Toenshoff
Re: [VOTE] Release Apache Mesos 0.21.0 (rc1)
-1 MESOS-2050 should be fixed now by commit ce82e81c12d7f91b158c73465c47725331626f32 Additionally I would like to add commit 36fd0111edcb3688e05d2e3d0b5cd8c5a177d214 Fxed a documentation issue which prevented our website “rake” from running successfully. Then there is https://reviews.apache.org/r/27767/ https://reviews.apache.org/r/27767/ which we might want to commit and also cherry-pick Fixed typo in mesos-containerizer.md causing middleman to fail. On Nov 7, 2014, at 3:30 AM, Vinod Kone vinodk...@gmail.com wrote: -1 There is a SEGFAULT issue in Authenticator. https://issues.apache.org/jira/browse/MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 On Thu, Nov 6, 2014 at 3:59 PM, Niklas Nielsen nik...@mesosphere.io mailto:nik...@mesosphere.io wrote: +1 for Ubuntu 14.04.1 LTS and Mac OS X 10.9.5. Niklas On 6 November 2014 13:00, Tom Arnfeld t...@duedil.com mailto:t...@duedil.com wrote: +1 `make check` passed on Ubuntu 12.04 LTS (kernel 3.2.0-67) -- Tom Arnfeld Developer // DueDil (+44) 7525940046 tel:%28%2B44%29%207525940046 25 Christopher Street, London, EC2A 2BS On Thu, Nov 6, 2014 at 8:43 PM, Ian Downes idow...@twitter.com.invalid wrote: Apologies: I used support/tag.sh but had a local branch *and* local tag and it pushed the branch only. $ git ls-remote --tags origin-wip | grep 0.21.0 a7733493dc9e6f2447f825671d8a745602c9bf7a refs/tags/0.21.0-rc1 On Thu, Nov 6, 2014 at 8:11 AM, Tim St Clair tstcl...@redhat.com mailto:tstcl...@redhat.com wrote: $ git tag -l | grep 21 $ git branch -r origin/0.21.0-rc1 It looks like you created a branch vs. tag ...? Cheers, Tim - Original Message - From: Ian Downes ian.dow...@gmail.com mailto:ian.dow...@gmail.com To: dev@mesos.apache.org mailto:dev@mesos.apache.org, u...@mesos.apache.org mailto:u...@mesos.apache.org Sent: Wednesday, November 5, 2014 5:12:52 PM Subject: [VOTE] Release Apache Mesos 0.21.0 (rc1) Hi all, Please vote on releasing the following candidate as Apache Mesos 0.21.0. 0.21.0 includes the following: State reconciliation for frameworks Support for Mesos modules Task status now includes source and reason A shared filesystem isolator A pid namespace isolator The CHANGELOG for the release is available at: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.21.0-rc1 https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.21.0-rc1 The candidate for Mesos 0.21.0 release is available at: https://dist.apache.org/repos/dist/dev/mesos/0.21.0-rc1/mesos-0.21.0.tar.gz https://dist.apache.org/repos/dist/dev/mesos/0.21.0-rc1/mesos-0.21.0.tar.gz The tag to be voted on is 0.21.0-rc1: https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.21.0-rc1 https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.21.0-rc1 The MD5 checksum of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.21.0-rc1/mesos-0.21.0.tar.gz.md5 https://dist.apache.org/repos/dist/dev/mesos/0.21.0-rc1/mesos-0.21.0.tar.gz.md5 The signature of the tarball can be found at: https://dist.apache.org/repos/dist/dev/mesos/0.21.0-rc1/mesos-0.21.0.tar.gz.asc https://dist.apache.org/repos/dist/dev/mesos/0.21.0-rc1/mesos-0.21.0.tar.gz.asc The PGP key used to sign the release is here: https://dist.apache.org/repos/dist/release/mesos/KEYS https://dist.apache.org/repos/dist/release/mesos/KEYS The JAR is up in Maven in a staging repository here: https://repository.apache.org/content/repositories/orgapachemesos-1038 https://repository.apache.org/content/repositories/orgapachemesos-1038 Please vote on releasing this package as Apache Mesos 0.21.0! The vote is open until Sat Nov 8 15:09:48 PST 2014 and passes if a majority of at least 3 +1 PMC votes are cast. [ ] +1 Release this package as Apache Mesos 0.21.0 [ ] -1 Do not release this package because ... Thanks, Ian Downes -- Cheers, Timothy St. Clair Red Hat Inc.
Re: Review Request 27765: Fixed MesosContainerizerExecuteTest.IoRedirection test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27765/#review60457 --- Ship it! Ship It! - Till Toenshoff On Nov. 8, 2014, 1:41 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27765/ --- (Updated Nov. 8, 2014, 1:41 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-2048 https://issues.apache.org/jira/browse/MESOS-2048 Repository: mesos-git Description --- See summary. Diffs - src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983 Diff: https://reviews.apache.org/r/27765/diff/ Testing --- make check GTEST_FILTER=*IoRedirection* Thanks, Vinod Kone
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2537
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2537/changes Changes: [toenshoff] Fixed Authenticator SASL auxiliary memory access. -- [...truncated 64895 lines...] I1108 01:49:05.190856 10907 leveldb.cpp:176] Opened db in 3.221795ms I1108 01:49:05.192028 10907 leveldb.cpp:183] Compacted db in 1.139528ms I1108 01:49:05.192077 10907 leveldb.cpp:198] Created db iterator in 15020ns I1108 01:49:05.192096 10907 leveldb.cpp:204] Seeked to beginning of db in 1560ns I1108 01:49:05.192106 10907 leveldb.cpp:273] Iterated through 0 keys in the db in 155ns I1108 01:49:05.192137 10907 replica.cpp:741] Replica recovered with log positions 0 - 0 with 1 holes and 0 unlearned I1108 01:49:05.192669 10935 recover.cpp:437] Starting replica recovery I1108 01:49:05.192983 10935 recover.cpp:463] Replica is in EMPTY status I1108 01:49:05.194319 10932 replica.cpp:638] Replica in EMPTY status received a broadcasted recover request I1108 01:49:05.194753 10930 recover.cpp:188] Received a recover response from a replica in EMPTY status I1108 01:49:05.195276 10932 recover.cpp:554] Updating replica status to STARTING I1108 01:49:05.196259 10931 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 756748ns I1108 01:49:05.196290 10931 replica.cpp:320] Persisted replica status to STARTING I1108 01:49:05.196527 10931 recover.cpp:463] Replica is in STARTING status I1108 01:49:05.197047 10928 master.cpp:318] Master 20141108-014905-3125920579-55654-10907 (penates.apache.org) started on 67.195.81.186:55654 I1108 01:49:05.197100 10928 master.cpp:364] Master only allowing authenticated frameworks to register I1108 01:49:05.197119 10928 master.cpp:369] Master only allowing authenticated slaves to register I1108 01:49:05.197149 10928 credentials.hpp:36] Loading credentials for authentication from '/tmp/SchedulerTest_TaskRunning_UmTIgW/credentials' I1108 01:49:05.197427 10928 master.cpp:413] Authorization enabled I1108 01:49:05.197758 10925 replica.cpp:638] Replica in STARTING status received a broadcasted recover request I1108 01:49:05.197863 10921 master.cpp:126] No whitelist given. Advertising offers for all slaves I1108 01:49:05.198024 10924 hierarchical_allocator_process.hpp:299] Initializing hierarchical allocator process with master : master@67.195.81.186:55654 I1108 01:49:05.198231 10936 recover.cpp:188] Received a recover response from a replica in STARTING status I1108 01:49:05.198763 10927 recover.cpp:554] Updating replica status to VOTING I1108 01:49:05.199261 10925 master.cpp:1263] The newly elected leader is master@67.195.81.186:55654 with id 20141108-014905-3125920579-55654-10907 I1108 01:49:05.199288 10925 master.cpp:1276] Elected as the leading master! I1108 01:49:05.199304 10925 master.cpp:1094] Recovering from registrar I1108 01:49:05.199493 10935 registrar.cpp:313] Recovering registrar I1108 01:49:05.199636 10924 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 732162ns I1108 01:49:05.199672 10924 replica.cpp:320] Persisted replica status to VOTING I1108 01:49:05.199812 10933 recover.cpp:568] Successfully joined the Paxos group I1108 01:49:05.200072 10933 recover.cpp:452] Recover process terminated I1108 01:49:05.200537 10924 log.cpp:656] Attempting to start the writer I1108 01:49:05.202018 10936 replica.cpp:474] Replica received implicit promise request with proposal 1 I1108 01:49:05.202795 10936 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 742609ns I1108 01:49:05.202823 10936 replica.cpp:342] Persisted promised to 1 I1108 01:49:05.203902 10925 coordinator.cpp:230] Coordinator attemping to fill missing position I1108 01:49:05.205755 10923 replica.cpp:375] Replica received explicit promise request for position 0 with proposal 2 I1108 01:49:05.206552 10923 leveldb.cpp:343] Persisting action (8 bytes) to leveldb took 760351ns I1108 01:49:05.206580 10923 replica.cpp:676] Persisted action at 0 I1108 01:49:06.198236 10936 hierarchical_allocator_process.hpp:697] No resources available to allocate! I1108 01:49:07.938017 10936 hierarchical_allocator_process.hpp:659] Performed allocation for 0 slaves in 1.739783833secs I1108 01:49:07.939331 10935 replica.cpp:508] Replica received write request for position 0 I1108 01:49:07.939396 10935 leveldb.cpp:438] Reading position from leveldb took 36246ns I1108 01:49:07.940140 10935 leveldb.cpp:343] Persisting action (14 bytes) to leveldb took 703763ns I1108 01:49:07.940172 10935 replica.cpp:676] Persisted action at 0 I1108 01:49:07.940814 10936 replica.cpp:655] Replica received learned notice for position 0 I1108 01:49:07.941447 10936 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 600429ns I1108 01:49:07.941474 10936 replica.cpp:676] Persisted action at 0 I1108 01:49:07.941495 10936 replica.cpp:661] Replica learned NOP action at position 0 I1108 01:49:07.942114 10929 log.cpp:672] Writer started with
Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review60458 --- Patch looks great! Reviews applied: [27741, 27760] All tests passed. - Mesos ReviewBot On Nov. 8, 2014, 12:50 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Nov. 8, 2014, 12:50 a.m.) Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. Bugs: MESOS-2050 https://issues.apache.org/jira/browse/MESOS-2050 Repository: mesos-git Description --- The initial design and implementation of the authenticator module interface caused issues and was not optimal for heavy lifting setup of external dependencies. By introducing a two fold design, this has been decoupled from the authentication message processing. The new design also gets us back on track to the goal of makeing SASL a soft dependency of mesos. Diffs - src/authentication/authenticator.hpp 2f95db1 src/authentication/cram_md5/authenticator.hpp 601248d src/master/master.hpp 687f178 src/master/master.cpp a860496 src/tests/cram_md5_authentication_tests.cpp 74ea2ad Diff: https://reviews.apache.org/r/27760/diff/ Testing --- make check Thanks, Till Toenshoff
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2259
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2259/changes Changes: [toenshoff] Fixed Authenticator SASL auxiliary memory access. [vinodkone] Added slave metrics for total and used resources. -- [...truncated 70818 lines...] I1108 01:59:19.695884 9494 slave.cpp:2621] master@67.195.81.190:48288 exited W1108 01:59:19.695916 9494 slave.cpp:2624] Master disconnected! Waiting for a new master to be elected I1108 01:59:19.703577 9475 leveldb.cpp:176] Opened db in 2.70149ms I1108 01:59:19.706002 9475 leveldb.cpp:183] Compacted db in 2.399359ms I1108 01:59:19.833946 9475 leveldb.cpp:198] Created db iterator in 26769ns I1108 01:59:19.833993 9475 leveldb.cpp:204] Seeked to beginning of db in 24857ns I1108 01:59:19.834079 9475 leveldb.cpp:273] Iterated through 3 keys in the db in 68638ns I1108 01:59:19.834128 9475 replica.cpp:741] Replica recovered with log positions 1 - 2 with 0 holes and 0 unlearned I1108 01:59:19.834666 9497 recover.cpp:437] Starting replica recovery I1108 01:59:19.835001 9492 recover.cpp:463] Replica is in VOTING status I1108 01:59:19.835204 9492 recover.cpp:452] Recover process terminated I1108 01:59:19.837558 9502 master.cpp:318] Master 20141108-015919-3193029443-48288-9475 (pietas.apache.org) started on 67.195.81.190:48288 I1108 01:59:19.837602 9502 master.cpp:364] Master only allowing authenticated frameworks to register I1108 01:59:19.837620 9502 master.cpp:369] Master only allowing authenticated slaves to register I1108 01:59:19.837648 9502 credentials.hpp:36] Loading credentials for authentication from '/tmp/AuthenticationTest_MasterFailoverDuringSlaveAuthentication_CIuLVb/credentials' I1108 01:59:19.837868 9502 master.cpp:413] Authorization enabled I1108 01:59:19.838248 9495 master.cpp:126] No whitelist given. Advertising offers for all slaves I1108 01:59:19.838374 9504 hierarchical_allocator_process.hpp:299] Initializing hierarchical allocator process with master : master@67.195.81.190:48288 I1108 01:59:19.839350 9502 master.cpp:1263] The newly elected leader is master@67.195.81.190:48288 with id 20141108-015919-3193029443-48288-9475 I1108 01:59:19.839380 9502 master.cpp:1276] Elected as the leading master! I1108 01:59:19.839395 9502 master.cpp:1094] Recovering from registrar I1108 01:59:19.839562 9494 registrar.cpp:313] Recovering registrar I1108 01:59:19.840147 9502 log.cpp:656] Attempting to start the writer I1108 01:59:19.841352 9490 replica.cpp:474] Replica received implicit promise request with proposal 2 I1108 01:59:19.842133 9490 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 759472ns I1108 01:59:19.842152 9490 replica.cpp:342] Persisted promised to 2 I1108 01:59:19.842725 9495 coordinator.cpp:230] Coordinator attemping to fill missing position I1108 01:59:19.843021 9500 log.cpp:672] Writer started with ending position 2 I1108 01:59:19.844071 9498 leveldb.cpp:438] Reading position from leveldb took 39912ns I1108 01:59:19.844143 9498 leveldb.cpp:438] Reading position from leveldb took 31441ns I1108 01:59:19.844984 9502 registrar.cpp:346] Successfully fetched the registry (100B) in 5.36704ms I1108 01:59:19.845082 9502 registrar.cpp:445] Applied 1 operations in 21392ns; attempting to update the 'registry' I1108 01:59:19.848052 9503 log.cpp:680] Attempting to append 138 bytes to the log I1108 01:59:19.848171 9497 coordinator.cpp:340] Coordinator attempting to write APPEND action at position 3 I1108 01:59:19.848974 9504 replica.cpp:508] Replica received write request for position 3 I1108 01:59:19.849486 9504 leveldb.cpp:343] Persisting action (157 bytes) to leveldb took 484112ns I1108 01:59:19.849505 9504 replica.cpp:676] Persisted action at 3 I1108 01:59:19.849953 9498 replica.cpp:655] Replica received learned notice for position 3 I1108 01:59:19.850381 9498 leveldb.cpp:343] Persisting action (159 bytes) to leveldb took 405814ns I1108 01:59:19.850400 9498 replica.cpp:676] Persisted action at 3 I1108 01:59:19.850416 9498 replica.cpp:661] Replica learned APPEND action at position 3 I1108 01:59:19.851091 9489 registrar.cpp:490] Successfully updated the 'registry' in 5.967872ms I1108 01:59:19.851193 9489 registrar.cpp:376] Successfully recovered registrar I1108 01:59:19.851321 9499 log.cpp:699] Attempting to truncate the log to 3 I1108 01:59:19.851500 9494 master.cpp:1121] Recovered 0 slaves from the Registry (100B) ; allowing 10mins for slaves to re-register I1108 01:59:19.851538 9489 coordinator.cpp:340] Coordinator attempting to write TRUNCATE action at position 4 I1108 01:59:19.852198 9500 replica.cpp:508] Replica received write request for position 4 I1108 01:59:19.852749 9500 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 525530ns I1108 01:59:19.852772 9500 replica.cpp:676] Persisted action at 4 I1108 01:59:19.853322 9492 replica.cpp:655] Replica received learned notice for position 4 I1108
Re: Review Request 27767: Fixed typo in mesos-containerizer.md causing middleman to fail.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27767/ --- (Updated Nov. 8, 2014, 2:01 a.m.) Review request for mesos and Ian Downes. Repository: mesos-git Description --- see summary. Diffs - docs/mesos-containerizer.md e4b2c24 Diff: https://reviews.apache.org/r/27767/diff/ Testing --- middleman build --verbose Thanks, Till Toenshoff
Review Request 27769: Perform task validation after authorization is done.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27769/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos-git Description --- Perform validation while launching each task. In that way, we can simplify a few Task validators. Also, it will simply the validator for persistent disk resources. Diffs - src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7 src/master/master.cpp 0e182a6328e089bcc7e9b173e267f6d5ca357890 Diff: https://reviews.apache.org/r/27769/diff/ Testing --- make check Thanks, Jie Yu
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2538
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2538/changes Changes: [vinodkone] Added slave metrics for total and used resources. [toenshoff] Fixed invalid characters in external-containerizer.md -- [...truncated 64936 lines...] I1108 02:53:19.338738 25885 slave.cpp:1556] Shutting down framework 20141108-025319-3125920579-41701-25865- I1108 02:53:19.338789 25885 slave.cpp:3005] Cleaning up executor 'default' of framework 20141108-025319-3125920579-41701-25865- I1108 02:53:19.339010 25885 slave.cpp:3082] Cleaning up framework 20141108-025319-3125920579-41701-25865- I1108 02:53:19.339022 25886 gc.cpp:56] Scheduling '/tmp/SchedulerTest_TaskRunning_ic7Pmh/slaves/20141108-025319-3125920579-41701-25865-S0/frameworks/20141108-025319-3125920579-41701-25865-/executors/default/runs/277c214d-20f1-4603-84a7-dc0d4c8003f8' for gc 6.9607806815days in the future I1108 02:53:19.339112 25889 status_update_manager.cpp:279] Closing status update streams for framework 20141108-025319-3125920579-41701-25865- I1108 02:53:19.339190 25889 status_update_manager.cpp:525] Cleaning up status update stream for task 1 of framework 20141108-025319-3125920579-41701-25865- I1108 02:53:19.339259 25886 gc.cpp:56] Scheduling '/tmp/SchedulerTest_TaskRunning_ic7Pmh/slaves/20141108-025319-3125920579-41701-25865-S0/frameworks/20141108-025319-3125920579-41701-25865-/executors/default' for gc 6.9607682667days in the future I1108 02:53:19.339406 25886 gc.cpp:56] Scheduling '/tmp/SchedulerTest_TaskRunning_ic7Pmh/slaves/20141108-025319-3125920579-41701-25865-S0/frameworks/20141108-025319-3125920579-41701-25865-' for gc 6.9607552days in the future [ OK ] SchedulerTest.TaskRunning (95 ms) [--] 1 test from SchedulerTest (95 ms total) [--] 3 tests from GarbageCollectorTest [ RUN ] GarbageCollectorTest.Unschedule Using temporary directory '/tmp/GarbageCollectorTest_Unschedule_N4q1Wq' I1108 02:53:19.342380 25886 gc.cpp:84] Unscheduling 'bogus' from gc I1108 02:53:19.342840 25888 gc.cpp:56] Scheduling 'file1' for gc 10secs in the future I1108 02:53:19.342973 25888 gc.cpp:56] Scheduling 'file2' for gc 10secs in the future I1108 02:53:19.343062 25888 gc.cpp:56] Scheduling 'file3' for gc 10secs in the future I1108 02:53:19.343144 25888 gc.cpp:84] Unscheduling 'file2' from gc I1108 02:53:19.353092 25891 gc.cpp:84] Unscheduling 'file3' from gc I1108 02:53:19.363229 25883 gc.cpp:84] Unscheduling 'file1' from gc I1108 02:53:19.374130 25891 gc.cpp:155] Ignoring gc event at 0ns as the paths were already removed, or were unscheduled [ OK ] GarbageCollectorTest.Unschedule (72 ms) [ RUN ] GarbageCollectorTest.Schedule Using temporary directory '/tmp/GarbageCollectorTest_Schedule_4L5TIA' I1108 02:53:19.414825 25881 gc.cpp:56] Scheduling 'file1' for gc 10secs in the future I1108 02:53:19.414985 25881 gc.cpp:56] Scheduling 'file2' for gc 10secs in the future I1108 02:53:19.415099 25881 gc.cpp:56] Scheduling 'file3' for gc 15secs in the future I1108 02:53:19.455865 25884 gc.cpp:134] Deleting file1 I1108 02:53:19.455934 25884 gc.cpp:143] Deleted 'file1' I1108 02:53:19.455965 25884 gc.cpp:134] Deleting file2 I1108 02:53:19.455997 25884 gc.cpp:143] Deleted 'file2' I1108 02:53:19.486083 25888 gc.cpp:134] Deleting file3 I1108 02:53:19.486142 25888 gc.cpp:143] Deleted 'file3' [ OK ] GarbageCollectorTest.Schedule (92 ms) [ RUN ] GarbageCollectorTest.Prune Using temporary directory '/tmp/GarbageCollectorTest_Prune_3GCKJK' I1108 02:53:19.506672 25879 gc.cpp:56] Scheduling 'file1' for gc 10secs in the future I1108 02:53:19.506801 25879 gc.cpp:56] Scheduling 'file2' for gc 10secs in the future I1108 02:53:19.506908 25879 gc.cpp:56] Scheduling 'file3' for gc 15secs in the future I1108 02:53:19.506994 25879 gc.cpp:56] Scheduling 'file4' for gc 15secs in the future I1108 02:53:19.507074 25879 gc.cpp:84] Unscheduling 'file3' from gc I1108 02:53:19.527171 25883 gc.cpp:167] Pruning directories with remaining removal time 10secs I1108 02:53:19.527248 25883 gc.cpp:134] Deleting file1 I1108 02:53:19.527297 25883 gc.cpp:143] Deleted 'file1' I1108 02:53:19.527323 25883 gc.cpp:134] Deleting file2 I1108 02:53:19.527354 25883 gc.cpp:143] Deleted 'file2' I1108 02:53:19.547471 25885 gc.cpp:167] Pruning directories with remaining removal time 15secs I1108 02:53:19.547575 25885 gc.cpp:134] Deleting file4 I1108 02:53:19.547633 25885 gc.cpp:143] Deleted 'file4' [ OK ] GarbageCollectorTest.Prune (51 ms) [--] 3 tests from GarbageCollectorTest (215 ms total) [--] 4 tests from ReplicaTest [ RUN ] ReplicaTest.Restore Using temporary directory '/tmp/ReplicaTest_Restore_EONZSU' I1108 02:53:19.561199 25865 leveldb.cpp:176] Opened db in 3.022731ms I1108 02:53:19.562335 25865 leveldb.cpp:183] Compacted db in 1.101381ms I1108 02:53:19.562388 25865
Re: Review Request 27765: Fixed MesosContainerizerExecuteTest.IoRedirection test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27765/#review60462 --- Patch looks great! Reviews applied: [27765] All tests passed. - Mesos ReviewBot On Nov. 8, 2014, 1:41 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27765/ --- (Updated Nov. 8, 2014, 1:41 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-2048 https://issues.apache.org/jira/browse/MESOS-2048 Repository: mesos-git Description --- See summary. Diffs - src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983 Diff: https://reviews.apache.org/r/27765/diff/ Testing --- make check GTEST_FILTER=*IoRedirection* Thanks, Vinod Kone
Re: Review Request 27516: Rebased and re-edited patch for MESOS-1316: Abstracted out invoking 'mesos-fetcher'.
On Nov. 6, 2014, 4:44 a.m., Benjamin Hindman wrote: src/slave/containerizer/fetcher.hpp, line 64 https://reviews.apache.org/r/27516/diff/3/?file=747421#file747421line64 Mind replacing ' ' with '' everywhere in your patch please? Thanks! Bernd Mathiske wrote: So we are now only using C++ compilers that do not have this bug any more? Nice! (Only about 12000 other places in Mesos to fix then :-) Yup, pretty nice huh! Also, when I said everywhere in your patch, I just meant the code you're actually changing, not all code in each file you changed. ;-) Not a huge deal, but definitely more disruptive for the reviewer. On Nov. 6, 2014, 4:44 a.m., Benjamin Hindman wrote: src/slave/containerizer/mesos/containerizer.cpp, line 524 https://reviews.apache.org/r/27516/diff/3/?file=747423#file747423line524 Why does this need to be a Future? It looks like you're chaining this below via a 'then', which means you can just use Optionint since a 'then' only invokes this if the Future is ready. The fact that you're always doing a 'get()' on the future too implies this precondition. Bernd Mathiske wrote: If we made it a plain Optionint then that value would have to be present at the time fetcher::run() returns. This would mean we have to block in fetcher::run() to wait for the fetcher. No, since you're doing a '.then(...)' with a lambda::_1 then you know that the Future is ready and you can invoke a function with the Future unpacked. I made this change for you, no worries. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27516/#review60098 --- On Nov. 6, 2014, 2:59 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27516/ --- (Updated Nov. 6, 2014, 2:59 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1316 https://issues.apache.org/jira/browse/MESOS-1316 Repository: mesos-git Description --- Manually rebasing and re-editing https://reviews.apache.org/r/21233/, which is supposed to be replaced now by this patch. Original description: To test the mesos-fetcher (and the setting of the environment) more cleanly I did some refactoring into a 'fetcher' namespace. Also moved fetcher environment tests to fetcher test file. Added two fetcher tests. Diffs - src/Makefile.am 9ab3b9c05d435d18ed1c2966f695857fa205e9fd src/launcher/fetcher.cpp bd95928bc3191970330e839bcf41e343d5142c54 src/slave/containerizer/containerizer.hpp 8a6641269b8e010a708aa8b05bb65e2e72501625 src/slave/containerizer/containerizer.cpp 0254679508167a390fd6fed855f19794354ac081 src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b src/slave/containerizer/fetcher.hpp PRE-CREATION src/slave/containerizer/fetcher.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.hpp ab3bb6ffed28e76820020d8fc457f70d948e6657 src/slave/containerizer/mesos/containerizer.cpp 4bd266552fcd28b0dcbc323bfd6a4043bbd835a9 src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983 src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671 Diff: https://reviews.apache.org/r/27516/diff/ Testing --- make check on Mac OS 10.10 and Ubuntu 14.4. In total, 3 tests fail: ExamplesTest.NoExecutorFramework, ExamplesTest.JavaFramework , ExamplesTest.PythonFramework. It is strongly suspected that those are unrelated to this code change and just generally flaky. Thanks, Bernd Mathiske
Re: Review Request 27516: Rebased and re-edited patch for MESOS-1316: Abstracted out invoking 'mesos-fetcher'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27516/#review60463 --- Ship it! Sweet, I'm committing this now Bernd! - Benjamin Hindman On Nov. 6, 2014, 2:59 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27516/ --- (Updated Nov. 6, 2014, 2:59 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1316 https://issues.apache.org/jira/browse/MESOS-1316 Repository: mesos-git Description --- Manually rebasing and re-editing https://reviews.apache.org/r/21233/, which is supposed to be replaced now by this patch. Original description: To test the mesos-fetcher (and the setting of the environment) more cleanly I did some refactoring into a 'fetcher' namespace. Also moved fetcher environment tests to fetcher test file. Added two fetcher tests. Diffs - src/Makefile.am 9ab3b9c05d435d18ed1c2966f695857fa205e9fd src/launcher/fetcher.cpp bd95928bc3191970330e839bcf41e343d5142c54 src/slave/containerizer/containerizer.hpp 8a6641269b8e010a708aa8b05bb65e2e72501625 src/slave/containerizer/containerizer.cpp 0254679508167a390fd6fed855f19794354ac081 src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b src/slave/containerizer/fetcher.hpp PRE-CREATION src/slave/containerizer/fetcher.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.hpp ab3bb6ffed28e76820020d8fc457f70d948e6657 src/slave/containerizer/mesos/containerizer.cpp 4bd266552fcd28b0dcbc323bfd6a4043bbd835a9 src/tests/containerizer_tests.cpp 2c90d2fc18a3268c55b6dfe98699bfb36d093983 src/tests/fetcher_tests.cpp e026e875c7197cd214ef0432d7c40207553c8671 Diff: https://reviews.apache.org/r/27516/diff/ Testing --- make check on Mac OS 10.10 and Ubuntu 14.4. In total, 3 tests fail: ExamplesTest.NoExecutorFramework, ExamplesTest.JavaFramework , ExamplesTest.PythonFramework. It is strongly suspected that those are unrelated to this code change and just generally flaky. Thanks, Bernd Mathiske
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2260
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2260/changes Changes: [toenshoff] Fixed invalid characters in external-containerizer.md -- [...truncated 70585 lines...] I1108 03:28:04.612184 14715 authenticator.hpp:166] Creating new server SASL connection I1108 03:28:04.612319 14716 authenticatee.hpp:224] Received SASL authentication mechanisms: CRAM-MD5 I1108 03:28:04.612354 14716 authenticatee.hpp:250] Attempting to authenticate with mechanism 'CRAM-MD5' I1108 03:28:04.612452 14706 authenticator.hpp:272] Received SASL authentication start I1108 03:28:04.612504 14706 authenticator.hpp:394] Authentication requires more steps I1108 03:28:04.612607 14703 authenticatee.hpp:270] Received SASL authentication step I1108 03:28:04.612716 14703 authenticator.hpp:300] Received SASL authentication step I1108 03:28:04.612743 14703 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'proserpina.apache.org' server FQDN: 'proserpina.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false I1108 03:28:04.612756 14703 auxprop.cpp:171] Looking up auxiliary property '*userPassword' I1108 03:28:04.612787 14703 auxprop.cpp:171] Looking up auxiliary property '*cmusaslsecretCRAM-MD5' I1108 03:28:04.612823 14703 auxprop.cpp:99] Request to lookup properties for user: 'test-principal' realm: 'proserpina.apache.org' server FQDN: 'proserpina.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true I1108 03:28:04.612839 14703 auxprop.cpp:121] Skipping auxiliary property '*userPassword' since SASL_AUXPROP_AUTHZID == true I1108 03:28:04.612848 14703 auxprop.cpp:121] Skipping auxiliary property '*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true I1108 03:28:04.612865 14703 authenticator.hpp:386] Authentication success I1108 03:28:04.612946 14708 authenticatee.hpp:310] Authentication success I1108 03:28:04.612999 14710 master.cpp:3959] Successfully authenticated principal 'test-principal' at scheduler-7f1eab90-172c-4243-8ec9-d80a3f1f58e1@67.195.81.189:38590 I1108 03:28:04.613225 14705 sched.cpp:369] Successfully authenticated with master master@67.195.81.189:38590 I1108 03:28:04.613253 14705 sched.cpp:488] Sending registration request to master@67.195.81.189:38590 I1108 03:28:04.613308 14705 sched.cpp:521] Will retry registration in 1.290447132secs if necessary I1108 03:28:04.613411 14710 master.cpp:1383] Received registration request for framework 'default' at scheduler-7f1eab90-172c-4243-8ec9-d80a3f1f58e1@67.195.81.189:38590 I1108 03:28:04.613478 14710 master.cpp:1342] Authorizing framework principal 'test-principal' to receive offers for role '*' I1108 03:28:04.613888 14708 master.cpp:1447] Registering framework 20141108-032804-3176252227-38590-14687- (default) at scheduler-7f1eab90-172c-4243-8ec9-d80a3f1f58e1@67.195.81.189:38590 I1108 03:28:04.614245 14705 hierarchical_allocator_process.hpp:329] Added framework 20141108-032804-3176252227-38590-14687- I1108 03:28:04.614275 14705 hierarchical_allocator_process.hpp:697] No resources available to allocate! I1108 03:28:04.614294 14705 hierarchical_allocator_process.hpp:659] Performed allocation for 0 slaves in 21729ns I1108 03:28:04.614405 14713 sched.cpp:419] Framework registered with 20141108-032804-3176252227-38590-14687- I1108 03:28:04.614485 14713 sched.cpp:433] Scheduler::registered took 48041ns I1108 03:28:04.615409 14687 containerizer.cpp:100] Using isolation: posix/cpu,posix/mem I1108 03:28:04.619040 14714 slave.cpp:169] Slave started on 223)@67.195.81.189:38590 I1108 03:28:04.619107 14714 credentials.hpp:84] Loading credential for authentication from '/tmp/ReconciliationTest_SlaveInTransition_IQmHDb/credential' I1108 03:28:04.619242 14714 slave.cpp:276] Slave using credential for: test-principal I1108 03:28:04.619519 14714 slave.cpp:289] Slave resources: cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] I1108 03:28:04.665650 14714 slave.cpp:318] Slave hostname: proserpina.apache.org I1108 03:28:04.665671 14714 slave.cpp:319] Slave checkpoint: true I1108 03:28:04.666412 14705 state.cpp:33] Recovering state from '/tmp/ReconciliationTest_SlaveInTransition_IQmHDb/meta' I1108 03:28:04.667301 14707 status_update_manager.cpp:197] Recovering status update manager I1108 03:28:04.667692 14713 containerizer.cpp:281] Recovering containerizer I1108 03:28:04.668696 14713 slave.cpp:3464] Finished recovery I1108 03:28:04.669278 14704 status_update_manager.cpp:171] Pausing sending status updates I1108 03:28:04.669282 14709 slave.cpp:602] New master detected at master@67.195.81.189:38590 I1108 03:28:04.669328 14709 slave.cpp:665] Authenticating with master master@67.195.81.189:38590 I1108 03:28:04.669483 14709 slave.cpp:638] Detecting new master I1108 03:28:04.669536 14708 authenticatee.hpp:133] Creating new client SASL
Re: Review Request 27701: Added check for apr and svn headers besides libraries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27701/#review60465 --- Ship it! configure.ac https://reviews.apache.org/r/27701/#comment101867 How about specifying that the headers could not be found and that's why it failed? Same for the other one too. - Benjamin Hindman On Nov. 6, 2014, 10:02 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27701/ --- (Updated Nov. 6, 2014, 10:02 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/27701 Diffs - configure.ac 4504006b25e2b3e45fefd36c9ed3a46e6c1d8430 Diff: https://reviews.apache.org/r/27701/diff/ Testing --- ./bootstrap configure make Thanks, Timothy Chen
Re: Review Request 27704: Added check for apr and svn headers besides libraries in 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27704/#review60466 --- Ship it! I'm giving this a ship it, but ultimately this (and all checks that are really for stout) should really be added to the stout configure. In this case in particular, libprocess doesn't actually depend on libapr or libsvn, Mesos does (but it checks that itself) and stout tests do, but not libprocess. - Benjamin Hindman On Nov. 6, 2014, 10:03 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27704/ --- (Updated Nov. 6, 2014, 10:03 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Added check for apr and svn headers besides libraries in 3rdparty Diffs - 3rdparty/libprocess/configure.ac 18eb681a5779b15cc5c7b7187ba5da8b4059c530 Diff: https://reviews.apache.org/r/27704/diff/ Testing --- bootstrap configure make Thanks, Timothy Chen
Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw
On Nov. 1, 2014, 6:44 p.m., Benjamin Hindman wrote: src/slave/containerizer/docker.cpp, lines 875-876 https://reviews.apache.org/r/26736/diff/5/?file=746636#file746636line875 Can we update this comment now that we're no longer doing Docker::rm or Docker::kill? It should have been updated before as well, thanks for helping out! Ryan Thomas wrote: The issue of having to retry a failed rm still exists - so I think this TODO is still valid. The stop still has the remove boolean that will remove the container after a stop. Originally in the code we were doing a Docker::rm, then we changed it to doing a Docker::kill, now we've changed it again to doing a Docker::stop. I agree that we should try to do a Docker::rm if Docker::stop failed, the comment just makes it sound like we're retrying to do a Docker::rm when in fact we'd be doing it the first time. ;-) Make sense? - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review59483 --- On Nov. 6, 2014, 9:55 p.m., Ryan Thomas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/ --- (Updated Nov. 6, 2014, 9:55 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-1925 https://issues.apache.org/jira/browse/MESOS-1925 Repository: mesos-git Description --- Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure. Diffs - src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89 src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4 src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b src/slave/flags.hpp efbd35dd744d8c8a53c36dd5cdb8d1c50fcfec3a src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6 src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d Diff: https://reviews.apache.org/r/26736/diff/ Testing --- make check sudo bin/mesos-tests.sh --gtest_filter=DOCKER --verbose support/mesos-style.py Thanks, Ryan Thomas
Re: Review Request 26736: Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherw
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/#review60468 --- Ship it! src/docker/docker.hpp https://reviews.apache.org/r/26736/#comment101869 You should be able to just do: const Duration timeout = Seconds(0) src/docker/docker.cpp https://reviews.apache.org/r/26736/#comment101870 Please pull this const up to the previous line. - Benjamin Hindman On Nov. 6, 2014, 9:55 p.m., Ryan Thomas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26736/ --- (Updated Nov. 6, 2014, 9:55 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-1925 https://issues.apache.org/jira/browse/MESOS-1925 Repository: mesos-git Description --- Ensure docker calls stop if a docker_stop_timeout is provided Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative value will result in a Failure. Diffs - src/docker/docker.hpp 2dc692c51d6f9d45d8d7c59f8678991fd80c6e89 src/docker/docker.cpp 0c0a1bfd3c1260ebdf342d0a6e0e04d7b6a111a4 src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b src/slave/flags.hpp efbd35dd744d8c8a53c36dd5cdb8d1c50fcfec3a src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6 src/tests/docker_tests.cpp ff06a01d7f20656c05bcf5afd3bc10059dc5378d Diff: https://reviews.apache.org/r/26736/diff/ Testing --- make check sudo bin/mesos-tests.sh --gtest_filter=DOCKER --verbose support/mesos-style.py Thanks, Ryan Thomas
Re: Review Request 27767: Fixed typo in mesos-containerizer.md causing middleman to fail.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27767/#review60471 --- Patch looks great! Reviews applied: [27767] All tests passed. - Mesos ReviewBot On Nov. 8, 2014, 2:01 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27767/ --- (Updated Nov. 8, 2014, 2:01 a.m.) Review request for mesos and Ian Downes. Repository: mesos-git Description --- see summary. Diffs - docs/mesos-containerizer.md e4b2c24 Diff: https://reviews.apache.org/r/27767/diff/ Testing --- middleman build --verbose Thanks, Till Toenshoff
Re: Review Request 24776: Add destroy tests for docker containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review60470 --- Ship it! src/slave/containerizer/docker.hpp https://reviews.apache.org/r/24776/#comment101871 How come you don't need to do 'process::Owned' here? There is probably some bad include file that is including all of the 'process' namespace, but we should really be doing process::Owned in headers (just like you do process::Shared above). src/slave/containerizer/docker.hpp https://reviews.apache.org/r/24776/#comment101872 process::Owned src/slave/containerizer/docker.hpp https://reviews.apache.org/r/24776/#comment101873 process::PID (here and everywhere else please). src/slave/containerizer/docker.hpp https://reviews.apache.org/r/24776/#comment101874 For the code that you have actually changed please go ahead and s/ // (but just for the code you've changed, not for all the code in all the files you've changed). src/slave/containerizer/docker.cpp https://reviews.apache.org/r/24776/#comment101875 Please update all of the 'dispatch' calls that need to be wrapped to have consistent wrapping style in this file. Thanks! src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/24776/#comment101876 Esoteric style nit: we've only used 1 newline between things declared/defined inside of classes, but two newlines for things declared at the top level. So please kill the double newline here and throughout the review. Thank you Tim! src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/24776/#comment101877 Did you want a here? And no need to use the _ prefix here. - Benjamin Hindman On Nov. 5, 2014, 7:26 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Nov. 5, 2014, 7:26 a.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/24776 Diffs - src/slave/containerizer/docker.hpp ec6b9cd308e9a16e05f016e8aeadbe77646d1621 src/slave/containerizer/docker.cpp a6689203adbdcb0ad12583389eaeb83329e4ef6b src/tests/docker_containerizer_tests.cpp 9d4ccc57f58d61c62aab5cdc79a129e987920bf6 Diff: https://reviews.apache.org/r/24776/diff/ Testing --- make check Thanks, Timothy Chen
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2261
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2261/changes Changes: [benjamin.hindman] Abstracted out invoking 'mesos-fetcher'. -- [...truncated 70651 lines...] 2014-11-08 04:44:55,244:26166(0x2b3a5c135700):ZOO_INFO@log_env@724: Client environment:os.arch=3.13.0-36-lowlatency 2014-11-08 04:44:55,244:26166(0x2b3a5c135700):ZOO_INFO@log_env@725: Client environment:os.version=#63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 2014-11-08 04:44:55,244:26166(0x2b3a5c537700):ZOO_INFO@log_env@741: Client environment:user.home=/home/jenkins 2014-11-08 04:44:55,244:26166(0x2b3a5c537700):ZOO_INFO@log_env@753: Client environment:user.dir=/tmp/LogZooKeeperTest_WriteRead_dFYVWf 2014-11-08 04:44:55,320:26166(0x2b3a5c537700):ZOO_INFO@zookeeper_init@786: Initiating client connection, host=127.0.0.1:42847 sessionTimeout=1 watcher=0x2b3a56028b0a sessionId=0 sessionPasswd=null context=0x2b3a980cc220 flags=0 2014-11-08 04:44:55,244:26166(0x2b3a5c135700):ZOO_INFO@log_env@733: Client environment:user.name=jenkins I1108 04:44:55.244516 26184 recover.cpp:437] Starting replica recovery 2014-11-08 04:44:55,320:26166(0x2b3a5c135700):ZOO_INFO@log_env@741: Client environment:user.home=/home/jenkins 2014-11-08 04:44:55,320:26166(0x2b3a5c135700):ZOO_INFO@log_env@753: Client environment:user.dir=/tmp/LogZooKeeperTest_WriteRead_dFYVWf 2014-11-08 04:44:55,320:26166(0x2b3a5c135700):ZOO_INFO@zookeeper_init@786: Initiating client connection, host=127.0.0.1:42847 sessionTimeout=1 watcher=0x2b3a56028b0a sessionId=0 sessionPasswd=null context=0x2b3a7408e8f0 flags=0 I1108 04:44:55.247128 26166 leveldb.cpp:176] Opened db in 3.573419ms I1108 04:44:55.320708 26184 recover.cpp:463] Replica is in VOTING status 2014-11-08 04:44:55,320:26166(0x2b3e0ca04700):ZOO_INFO@check_events@1703: initiated connection to server [127.0.0.1:42847] 2014-11-08 04:44:55,320:26166(0x2b3e0de2d700):ZOO_INFO@check_events@1703: initiated connection to server [127.0.0.1:42847] I1108 04:44:55.320850 26184 recover.cpp:452] Recover process terminated 2014-11-08 04:44:55,323:26166(0x2b3e0ca04700):ZOO_INFO@check_events@1750: session establishment complete on server [127.0.0.1:42847], sessionId=0x1498db82236, negotiated timeout=1 I1108 04:44:55.323797 26166 leveldb.cpp:183] Compacted db in 3.326034ms I1108 04:44:55.323853 26166 leveldb.cpp:198] Created db iterator in 17790ns I1108 04:44:55.323887 26166 leveldb.cpp:204] Seeked to beginning of db in 19544ns I1108 04:44:55.323922 26166 leveldb.cpp:273] Iterated through 1 keys in the db in 20972ns I1108 04:44:55.323957 26166 replica.cpp:741] Replica recovered with log positions 0 - 0 with 1 holes and 0 unlearned I1108 04:44:55.323997 26182 group.cpp:313] Group process (group(53)@67.195.81.190:53738) connected to ZooKeeper I1108 04:44:55.324029 26182 group.cpp:790] Syncing group operations: queue size (joins, cancels, datas) = (0, 0, 0) I1108 04:44:55.324050 26182 group.cpp:385] Trying to create path '/log' in ZooKeeper 2014-11-08 04:44:55,324:26166(0x2b3e0de2d700):ZOO_INFO@check_events@1750: session establishment complete on server [127.0.0.1:42847], sessionId=0x1498db822360001, negotiated timeout=1 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@log_env@712: Client environment:zookeeper.version=zookeeper C client 3.4.5 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@log_env@716: Client environment:host.name=pietas.apache.org 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@log_env@723: Client environment:os.name=Linux 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@log_env@724: Client environment:os.arch=3.13.0-36-lowlatency 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@log_env@725: Client environment:os.version=#63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@log_env@733: Client environment:user.name=jenkins 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@log_env@741: Client environment:user.home=/home/jenkins 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@log_env@753: Client environment:user.dir=/tmp/LogZooKeeperTest_WriteRead_dFYVWf 2014-11-08 04:44:55,324:26166(0x2b3a5c336700):ZOO_INFO@zookeeper_init@786: Initiating client connection, host=127.0.0.1:42847 sessionTimeout=1 watcher=0x2b3a56028b0a sessionId=0 sessionPasswd=null context=0x2b3a900ae0f0 flags=0 I1108 04:44:55.324905 26184 log.cpp:238] Attempting to join replica to ZooKeeper group 2014-11-08 04:44:55,325:26166(0x2b3a5bb32700):ZOO_INFO@log_env@712: Client environment:zookeeper.version=zookeeper C client 3.4.5 2014-11-08 04:44:55,325:26166(0x2b3a5bb32700):ZOO_INFO@log_env@716: Client environment:host.name=pietas.apache.org 2014-11-08 04:44:55,325:26166(0x2b3a5bb32700):ZOO_INFO@log_env@723: Client environment:os.name=Linux 2014-11-08 04:44:55,325:26166(0x2b3a5bb32700):ZOO_INFO@log_env@724: Client
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2539
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2539/changes Changes: [benjamin.hindman] Abstracted out invoking 'mesos-fetcher'. -- [...truncated 51158 lines...] I1108 04:44:52.405315 28639 replica.cpp:676] Persisted action at 0 I1108 04:44:52.405799 28629 replica.cpp:655] Replica received learned notice for position 0 I1108 04:44:52.406230 28629 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 412560ns I1108 04:44:52.406249 28629 replica.cpp:676] Persisted action at 0 I1108 04:44:52.406262 28629 replica.cpp:661] Replica learned NOP action at position 0 I1108 04:44:52.40 28638 log.cpp:672] Writer started with ending position 0 I1108 04:44:52.407613 28634 leveldb.cpp:438] Reading position from leveldb took 22363ns I1108 04:44:52.409680 28627 registrar.cpp:346] Successfully fetched the registry (0B) in 10.11584ms I1108 04:44:52.409771 28627 registrar.cpp:445] Applied 1 operations in 15655ns; attempting to update the 'registry' I1108 04:44:52.411700 28632 log.cpp:680] Attempting to append 143 bytes to the log I1108 04:44:52.411818 28624 coordinator.cpp:340] Coordinator attempting to write APPEND action at position 1 I1108 04:44:52.412412 28638 replica.cpp:508] Replica received write request for position 1 I1108 04:44:52.412874 28638 leveldb.cpp:343] Persisting action (162 bytes) to leveldb took 438499ns I1108 04:44:52.412892 28638 replica.cpp:676] Persisted action at 1 I1108 04:44:52.413326 28626 replica.cpp:655] Replica received learned notice for position 1 I1108 04:44:52.413765 28626 leveldb.cpp:343] Persisting action (164 bytes) to leveldb took 419350ns I1108 04:44:52.413784 28626 replica.cpp:676] Persisted action at 1 I1108 04:44:52.413799 28626 replica.cpp:661] Replica learned APPEND action at position 1 I1108 04:44:52.414469 28636 registrar.cpp:490] Successfully updated the 'registry' in 4.655104ms I1108 04:44:52.414584 28636 registrar.cpp:376] Successfully recovered registrar I1108 04:44:52.414657 28627 log.cpp:699] Attempting to truncate the log to 1 I1108 04:44:52.414768 28628 coordinator.cpp:340] Coordinator attempting to write TRUNCATE action at position 2 I1108 04:44:52.414787 28632 master.cpp:1121] Recovered 0 slaves from the Registry (105B) ; allowing 10mins for slaves to re-register I1108 04:44:52.415380 28639 replica.cpp:508] Replica received write request for position 2 I1108 04:44:52.415827 28639 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 422800ns I1108 04:44:52.415845 28639 replica.cpp:676] Persisted action at 2 I1108 04:44:52.416314 28635 replica.cpp:655] Replica received learned notice for position 2 I1108 04:44:52.416710 28635 leveldb.cpp:343] Persisting action (18 bytes) to leveldb took 377788ns I1108 04:44:52.416750 28635 leveldb.cpp:401] Deleting ~1 keys from leveldb took 22716ns I1108 04:44:52.416764 28635 replica.cpp:676] Persisted action at 2 I1108 04:44:52.416779 28635 replica.cpp:661] Replica learned TRUNCATE action at position 2 I1108 04:44:52.428979 28637 slave.cpp:169] Slave started on 179)@67.195.81.189:38578 I1108 04:44:52.429020 28637 credentials.hpp:84] Loading credential for authentication from '/tmp/GarbageCollectorIntegrationTest_ExitedExecutor_zbfttx/credential' I1108 04:44:52.429195 28637 slave.cpp:276] Slave using credential for: test-principal I1108 04:44:52.429373 28637 slave.cpp:289] Slave resources: cpus(*):2; mem(*):1024; disk(*):1024; ports(*):[31000-32000] I1108 04:44:52.429440 28637 slave.cpp:318] Slave hostname: proserpina.apache.org I1108 04:44:52.429451 28637 slave.cpp:319] Slave checkpoint: false W1108 04:44:52.429457 28637 slave.cpp:321] Disabling checkpointing is deprecated and the --checkpoint flag will be removed in a future release. Please avoid using this flag I1108 04:44:52.430110 28634 state.cpp:33] Recovering state from '/tmp/GarbageCollectorIntegrationTest_ExitedExecutor_zbfttx/meta' I1108 04:44:52.430361 28626 status_update_manager.cpp:197] Recovering status update manager I1108 04:44:52.430608 28631 slave.cpp:3464] Finished recovery I1108 04:44:52.430999 28634 status_update_manager.cpp:171] Pausing sending status updates I1108 04:44:52.431013 28638 slave.cpp:602] New master detected at master@67.195.81.189:38578 I1108 04:44:52.431051 28638 slave.cpp:665] Authenticating with master master@67.195.81.189:38578 I1108 04:44:52.431187 28638 slave.cpp:638] Detecting new master I1108 04:44:52.431207 28637 authenticatee.hpp:133] Creating new client SASL connection I1108 04:44:52.431361 28633 master.cpp:3901] Authenticating slave(179)@67.195.81.189:38578 I1108 04:44:52.431391 28633 master.cpp:3912] Using default CRAM-MD5 authenticator I1108 04:44:52.431519 28635 authenticator.hpp:166] Creating new server SASL connection I1108 04:44:52.431630 28637 authenticatee.hpp:224] Received SASL authentication mechanisms: CRAM-MD5 I1108 04:44:52.431650 28637 authenticatee.hpp:250]
Re: Review Request 27769: Perform task validation after authorization is done.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27769/#review60473 --- Patch looks great! Reviews applied: [27769] All tests passed. - Mesos ReviewBot On Nov. 8, 2014, 2:13 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27769/ --- (Updated Nov. 8, 2014, 2:13 a.m.) Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos-git Description --- Perform validation while launching each task. In that way, we can simplify a few Task validators. Also, it will simply the validator for persistent disk resources. Diffs - src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7 src/master/master.cpp 0e182a6328e089bcc7e9b173e267f6d5ca357890 Diff: https://reviews.apache.org/r/27769/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 27767: Fixed typo in mesos-containerizer.md causing middleman to fail.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27767/#review60479 --- Ship it! Ship It! - Adam B On Nov. 7, 2014, 6:01 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27767/ --- (Updated Nov. 7, 2014, 6:01 p.m.) Review request for mesos and Ian Downes. Repository: mesos-git Description --- see summary. Diffs - docs/mesos-containerizer.md e4b2c24 Diff: https://reviews.apache.org/r/27767/diff/ Testing --- middleman build --verbose Thanks, Till Toenshoff
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2540
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2540/changes
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2262
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2262/changes
Re: Review Request 27670: Bug fix: Check for non-zero status code and hadoop client not found
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27670/ --- (Updated Nov. 8, 2014, 7:26 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1711 https://issues.apache.org/jira/browse/MESOS-1711 Repository: mesos-git Description --- @benh noticed that the fetcher would detect the condition where hadoop returns a success in case of a success non zero value Diffs (updated) - src/launcher/fetcher.cpp 400fadf94d35721cabaa9983b12a5d35f71f5b5b Diff: https://reviews.apache.org/r/27670/diff/ Testing --- make check sudo bin/mesos-tests.sh --verbose support/mesos-style.py Thanks, Ankur Chauhan
Re: Review Request 27670: Bug fix: Check for non-zero status code and hadoop client not found
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27670/ --- (Updated Nov. 8, 2014, 7:28 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes --- Simplify if expression Bugs: MESOS-1711 https://issues.apache.org/jira/browse/MESOS-1711 Repository: mesos-git Description --- @benh noticed that the fetcher would detect the condition where hadoop returns a success in case of a success non zero value Diffs (updated) - src/launcher/fetcher.cpp 400fadf94d35721cabaa9983b12a5d35f71f5b5b Diff: https://reviews.apache.org/r/27670/diff/ Testing --- make check sudo bin/mesos-tests.sh --verbose support/mesos-style.py Thanks, Ankur Chauhan