Re: Question on LSP client

2020-11-24 Thread Randamuna Namae
Hi Jan,

I was hoping you'd chime in.

> I think it would be good to avoid having LSP4J classes in the API

I agree, but designing such an API would be too much a task for me I think
(I'm too new to NetBeans innards).
>From the cursory look I took, I don't think I can just minimally expose
some API, because I'd need access to the LSPBinding and the
WorkspaceService.
It's probably best to give it more thought about what an extensible API for
LSP clients could look like.

> Also, I wonder why the server needs a command to start working - should
not
> be that done automatically? (Does it really require all LSP clients to be
> modified to send it a command? Seems to be against the purpose of the
> protocol.)

I can more or less answer this. Their LSP server does a bit more than just
language support by also interfacing with the BSP server [1], at the same
time, because of the limitations of what has been standardize so far in
LSP, they have several extensions that you wouldn't be able to leverage via
generic protocol.
So a text-editor integrating with Metals is expected to run some workspace
commands to guide it [2].

In some ideal world scenario for my case (the Scala LSP integration), I'd
integrate with the BSP server myself, but for now Metals (that's the name
of the Scala LSP server) takes care of that.

[1] https://github.com/scalacenter/bsp/blob/master/docs/bsp.md
[2]
https://scalameta.org/metals/docs/integrations/new-editor.html#metals-server-commands


On Tue, Nov 24, 2020 at 5:05 PM Jan Lahoda  wrote:

> FWIW, for an API, I think it would be good to avoid having LSP4J classes in
> the API. So that we can replace the library that handles the communication
> if we need/want without breaking clients.
>
> Also, I wonder why the server needs a command to start working - should not
> be that done automatically? (Does it really require all LSP clients to be
> modified to send it a command? Seems to be against the purpose of the
> protocol.)
>
> Anyway - having a way to run a (registered) command would sound great to
> me!
>
> Jan
>
>
> On Tue, Nov 24, 2020 at 2:46 PM Randamuna Namae 
> wrote:
>
> > Alright, will do.
> >
> > Thanks.
> >
> > On Tue, Nov 24, 2020 at 8:58 AM Jaroslav Tulach <
> jaroslav.tul...@gmail.com
> > >
> > wrote:
> >
> > > Dne úterý 24. listopadu 2020 1:15:19 CET, Randamuna Namae napsal(a):
> > > > Hello dear community,
> > > >
> > > > I'm working on integrating Apache NetBeans with Scala's LSP server
> and
> > > got
> > > > the basics working.
> > >
> > > That's great! Recently I needed to work with scala code (https://
> > > renaissance.dev/ benchmark) and the old Scala support in NetBeans 8.x
> is
> > > no
> > > longer very reliable.
> > >
> > > > it seems that calling a command programmatically
> > > > wont be possible after all since the LSP classes are module private.
> > > > Is there a workaround for this?
> > >
> > > Prepare a PR that opens up the API slightly and let Jan Lahoda review
> it.
> > > -jt
> > >
> > >
> > >
> > >
> >
>


Re: Question on LSP client

2020-11-24 Thread Jan Lahoda
FWIW, for an API, I think it would be good to avoid having LSP4J classes in
the API. So that we can replace the library that handles the communication
if we need/want without breaking clients.

Also, I wonder why the server needs a command to start working - should not
be that done automatically? (Does it really require all LSP clients to be
modified to send it a command? Seems to be against the purpose of the
protocol.)

Anyway - having a way to run a (registered) command would sound great to me!

Jan


On Tue, Nov 24, 2020 at 2:46 PM Randamuna Namae  wrote:

> Alright, will do.
>
> Thanks.
>
> On Tue, Nov 24, 2020 at 8:58 AM Jaroslav Tulach  >
> wrote:
>
> > Dne úterý 24. listopadu 2020 1:15:19 CET, Randamuna Namae napsal(a):
> > > Hello dear community,
> > >
> > > I'm working on integrating Apache NetBeans with Scala's LSP server and
> > got
> > > the basics working.
> >
> > That's great! Recently I needed to work with scala code (https://
> > renaissance.dev/ benchmark) and the old Scala support in NetBeans 8.x is
> > no
> > longer very reliable.
> >
> > > it seems that calling a command programmatically
> > > wont be possible after all since the LSP classes are module private.
> > > Is there a workaround for this?
> >
> > Prepare a PR that opens up the API slightly and let Jan Lahoda review it.
> > -jt
> >
> >
> >
> >
>


Re: [RESULT][VOTE] Release Apache NetBeans 12.2

2020-11-24 Thread Neil C Smith
On Tue, 24 Nov 2020 at 16:45, Neil C Smith  wrote:
> On Tue, 24 Nov 2020 at 16:24, Laszlo Kishalmi  
> wrote:
> > @Neil Do we need to sign the Windows binary or it is already signed, if
> > not would you take care of that? I do not have Windows at hand to test.
>
> Yes we do.  Let me check if I can still access the signing site -
> there were some changes related to signing access in a recent email
> that I haven't got around to looking at yet.

OK, seems to be all good!

I assume the build link in the vote thread should have been to 21 not
20?  I'll sort out, test and upload to dist for voting tomorrow
morning.

Best wishes,

Neil

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [RESULT][VOTE] Release Apache NetBeans 12.2

2020-11-24 Thread Neil C Smith
On Tue, 24 Nov 2020 at 16:24, Laszlo Kishalmi  wrote:
> @Neil Do we need to sign the Windows binary or it is already signed, if
> not would you take care of that? I do not have Windows at hand to test.

Yes we do.  Let me check if I can still access the signing site -
there were some changes related to signing access in a recent email
that I haven't got around to looking at yet.

Best wishes,

Neil

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





[RESULT][VOTE] Release Apache NetBeans 12.2

2020-11-24 Thread Laszlo Kishalmi

Dear all,

I'm closing the vote thread [VOTE] Release Apache NetBeans 12.2 (vote 
candidate 2) with the result of:


With 7 +1 binding votes, 6 +1 votes, with no 0 and -1 votes, Apache 
NetBeans 12.2 source release bundle has been accepted by the community.


The next round will be the convenience binary votes as much as possible 
in parallel this time.


@Martin Balin I would kick a __new thread__ on LS for VS Code binary 
vote now to make it clear
@Neil Do we need to sign the Windows binary or it is already signed, if 
not would you take care of that? I do not have Windows at hand to test.


+1 (binding) votes:

Jaroslav Tulachhttp://people.apache.org/phonebook.html?uid=jtulach
Svata Dedic http://people.apache.org/phonebook.html?uid=sdedic
Junichi Yamamotohttp://people.apache.org/phonebook.html?uid=junichi11
Neil C Smithhttp://people.apache.org/phonebook.html?uid=neilcsmith
Matthias Bläsinghttp://people.apache.org/phonebook.html?uid=matthiasblaesing
Eric Barboni http://people.apache.org/phonebook.html?uid=skygo
Laszlo Kishalmihttp://people.apache.org/phonebook.html?uid=lkishalmi

+1 votes:

Christian Oyarzun
Martin Balin
Ludovic HOCHET
Tomáš Procházka
Kai Uwe Pel
Boris Heithecker


-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [VOTE] Release Apache NetBeans 12.2 (vote candidate 2)

2020-11-24 Thread Laszlo Kishalmi

+1 (binding)

I'm going to close this voting and tally the results now.

On 11/23/20 12:21 PM, Matthias Bläsing wrote:

+1 (binding)

  * verified SHA512 (netbeans-12.2-bin.zip, netbeans-12.2-source.zip,
netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-source.zip)
  * verified ASC (netbeans-12.2-bin.zip, netbeans-12.2-source.zip,
netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-source.zip)
  * NOTICE files look sane (netbeans-12.2-bin.zip, netbeans-12.2-
source.zip, netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-
source.zip)
  * LICENSE files look sane (netbeans-12.2-bin.zip, netbeans-12.2-
source.zip, netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-
source.zip)
  * ran RAT check for the netbeans 12.2 source zip, which came back
clean
  * verified, that code in netbeans-12.2-source.zip matches contents of
git repository of tag 12.2-rc2 (module the issue described below)
  * verified, that netbeans-platform source is a strict subset of
netbeans
  * build netbeans 12.2 from source with JDK 8 (netbeans-12.2-
source.zip) on linux, which results in a runnable IDE

Found issue in the JSF support: the new support for bootsfaces is not
correctly registered in the cluster and not part of the release:
https://issues.apache.org/jira/browse/NETBEANS-5054 . I don't consider
this a blocker.

Thank you!

Matthias

Am Samstag, den 21.11.2020, 00:06 -0800 schrieb Laszlo Kishalmi:

Dear community,

This is our second voting candidate for the 12.2 release of Apache
NetBeans. It is built off the same commit as 12.2-rc3. Please note
all requirements below for validating sources and convenience
binaries
before voting.

Apache NetBeans 12.2 constitutes all clusters in the Apache NetBeans
Git repository, which together provide the NetBeans Platform (i.e.,
the
underlying application framework), as well as all the modules that
provide the Java SE, Java EE, PHP, JavaScript and Groovy features of
Apache NetBeans.

Build artifacts are available here :
https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/12.2/vc2

They were built by the Jenkins pipeline and moved to their place :
https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/netbeans/job/release122/20/

We are primarily voting on :
https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2/netbeans-12.2-source.zip

SHA512 :
84e7584689e0993ee60e9af8ccad2ba247bad8562ab742bf24d19ab56f29ac131943a
b54fcf850588e04a00bdd9fea40909e1b91f47c8f545f89cae29144af8e

KEYS file :
https://downloads.apache.org/netbeans/KEYS

--

Associated to the primary source item you will have (generated with
pipeline mentioned above)
* under
https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2
binaries associated to the source
netbeans-12.2-bin.zip
as well as update content under nbms folder

* under
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/12.2/vc2
you will find platform cluster build
netbeans-platform-12.2-bin.zip
netbeans-platform-12.2-source.zip




-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Question on LSP client

2020-11-24 Thread Randamuna Namae
Alright, will do.

Thanks.

On Tue, Nov 24, 2020 at 8:58 AM Jaroslav Tulach 
wrote:

> Dne úterý 24. listopadu 2020 1:15:19 CET, Randamuna Namae napsal(a):
> > Hello dear community,
> >
> > I'm working on integrating Apache NetBeans with Scala's LSP server and
> got
> > the basics working.
>
> That's great! Recently I needed to work with scala code (https://
> renaissance.dev/ benchmark) and the old Scala support in NetBeans 8.x is
> no
> longer very reliable.
>
> > it seems that calling a command programmatically
> > wont be possible after all since the LSP classes are module private.
> > Is there a workaround for this?
>
> Prepare a PR that opens up the API slightly and let Jan Lahoda review it.
> -jt
>
>
>
>


Re: [VOTE] Release Apache NetBeans 12.2 (vote candidate 2)

2020-11-24 Thread Christian Oyarzun
+1 (binding)

* SHA512 of source zip checked
* built from the sources
* created, built, ran Java Maven application.

macOS 10.15.7
built and tested with 1.8.0_265; OpenJDK 64-Bit Server VM 25.265-b01
tested with  11.0.9.1; OpenJDK 64-Bit Server VM 11.0.9.1+12-LTS




On Tue, Nov 24, 2020 at 6:00 AM Boris Heithecker 
wrote:

> +1
> Behaves as expected.
>
> On Tue, 24 Nov 2020 at 11:49, Eric Barboni  wrote:
>
> > +1 (binding)
> >
> > -Message d'origine-
> > De : Matthias Bläsing 
> > Envoyé : lundi 23 novembre 2020 21:22
> > À : dev@netbeans.apache.org
> > Objet : Re: [VOTE] Release Apache NetBeans 12.2 (vote candidate 2)
> >
> > +1 (binding)
> >
> >  * verified SHA512 (netbeans-12.2-bin.zip, netbeans-12.2-source.zip,
> >netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-source.zip)
> >  * verified ASC (netbeans-12.2-bin.zip, netbeans-12.2-source.zip,
> >netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-source.zip)
> >  * NOTICE files look sane (netbeans-12.2-bin.zip, netbeans-12.2-
> >source.zip, netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-
> >source.zip)
> >  * LICENSE files look sane (netbeans-12.2-bin.zip, netbeans-12.2-
> >source.zip, netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-
> >source.zip)
> >  * ran RAT check for the netbeans 12.2 source zip, which came back
> >clean
> >  * verified, that code in netbeans-12.2-source.zip matches contents of
> >git repository of tag 12.2-rc2 (module the issue described below)
> >  * verified, that netbeans-platform source is a strict subset of
> >netbeans
> >  * build netbeans 12.2 from source with JDK 8 (netbeans-12.2-
> >source.zip) on linux, which results in a runnable IDE
> >
> > Found issue in the JSF support: the new support for bootsfaces is not
> > correctly registered in the cluster and not part of the release:
> > https://issues.apache.org/jira/browse/NETBEANS-5054 . I don't consider
> > this a blocker.
> >
> > Thank you!
> >
> > Matthias
> >
> > Am Samstag, den 21.11.2020, 00:06 -0800 schrieb Laszlo Kishalmi:
> > > Dear community,
> > >
> > > This is our second voting candidate for the 12.2 release of Apache
> > > NetBeans. It is built off the same commit as 12.2-rc3. Please note all
> > > requirements below for validating sources and convenience binaries
> > > before voting.
> > >
> > > Apache NetBeans 12.2 constitutes all clusters in the Apache NetBeans
> > > Git repository, which together provide the NetBeans Platform (i.e.,
> > > the underlying application framework), as well as all the modules that
> > > provide the Java SE, Java EE, PHP, JavaScript and Groovy features of
> > > Apache NetBeans.
> > >
> > > Build artifacts are available here :
> > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2
> > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/12.2
> > > /vc2
> > >
> > > They were built by the Jenkins pipeline and moved to their place :
> > > https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/netbean
> > > s/job/release122/20/
> > >
> > > We are primarily voting on :
> > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2/netb
> > > eans-12.2-source.zip
> > >
> > > SHA512 :
> > > 84e7584689e0993ee60e9af8ccad2ba247bad8562ab742bf24d19ab56f29ac131943a
> > > b54fcf850588e04a00bdd9fea40909e1b91f47c8f545f89cae29144af8e
> > >
> > > KEYS file :
> > > https://downloads.apache.org/netbeans/KEYS
> > >
> > > --
> > >
> > > Associated to the primary source item you will have (generated with
> > > pipeline mentioned above)
> > > * under
> > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2
> > > binaries associated to the source
> > > netbeans-12.2-bin.zip
> > > as well as update content under nbms folder
> > >
> > > * under
> > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/12.2
> > > /vc2
> > > you will find platform cluster build
> > > netbeans-platform-12.2-bin.zip
> > > netbeans-platform-12.2-source.zip
> > >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> > For additional commands, e-mail: dev-h...@netbeans.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> > For additional commands, e-mail: dev-h...@netbeans.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> >
> >
> >
>
> --
> Boris Heithecker
>
>
> Dr. Boris Heithecker
> Lüneburger Str. 30
> 28870 Ottersberg
> Festnetz: +49 4205 315834
> Mobil: +49 170 6137015
>


Re: Question on LSP client

2020-11-24 Thread Jaroslav Tulach
Dne úterý 24. listopadu 2020 1:15:19 CET, Randamuna Namae napsal(a):
> Hello dear community,
> 
> I'm working on integrating Apache NetBeans with Scala's LSP server and got
> the basics working.

That's great! Recently I needed to work with scala code (https://
renaissance.dev/ benchmark) and the old Scala support in NetBeans 8.x is no 
longer very reliable.

> it seems that calling a command programmatically
> wont be possible after all since the LSP classes are module private.
> Is there a workaround for this?

Prepare a PR that opens up the API slightly and let Jan Lahoda review it.
-jt




-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [VOTE] Release Apache NetBeans 12.2 (vote candidate 2)

2020-11-24 Thread Boris Heithecker
+1
Behaves as expected.

On Tue, 24 Nov 2020 at 11:49, Eric Barboni  wrote:

> +1 (binding)
>
> -Message d'origine-
> De : Matthias Bläsing 
> Envoyé : lundi 23 novembre 2020 21:22
> À : dev@netbeans.apache.org
> Objet : Re: [VOTE] Release Apache NetBeans 12.2 (vote candidate 2)
>
> +1 (binding)
>
>  * verified SHA512 (netbeans-12.2-bin.zip, netbeans-12.2-source.zip,
>netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-source.zip)
>  * verified ASC (netbeans-12.2-bin.zip, netbeans-12.2-source.zip,
>netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-source.zip)
>  * NOTICE files look sane (netbeans-12.2-bin.zip, netbeans-12.2-
>source.zip, netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-
>source.zip)
>  * LICENSE files look sane (netbeans-12.2-bin.zip, netbeans-12.2-
>source.zip, netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-
>source.zip)
>  * ran RAT check for the netbeans 12.2 source zip, which came back
>clean
>  * verified, that code in netbeans-12.2-source.zip matches contents of
>git repository of tag 12.2-rc2 (module the issue described below)
>  * verified, that netbeans-platform source is a strict subset of
>netbeans
>  * build netbeans 12.2 from source with JDK 8 (netbeans-12.2-
>source.zip) on linux, which results in a runnable IDE
>
> Found issue in the JSF support: the new support for bootsfaces is not
> correctly registered in the cluster and not part of the release:
> https://issues.apache.org/jira/browse/NETBEANS-5054 . I don't consider
> this a blocker.
>
> Thank you!
>
> Matthias
>
> Am Samstag, den 21.11.2020, 00:06 -0800 schrieb Laszlo Kishalmi:
> > Dear community,
> >
> > This is our second voting candidate for the 12.2 release of Apache
> > NetBeans. It is built off the same commit as 12.2-rc3. Please note all
> > requirements below for validating sources and convenience binaries
> > before voting.
> >
> > Apache NetBeans 12.2 constitutes all clusters in the Apache NetBeans
> > Git repository, which together provide the NetBeans Platform (i.e.,
> > the underlying application framework), as well as all the modules that
> > provide the Java SE, Java EE, PHP, JavaScript and Groovy features of
> > Apache NetBeans.
> >
> > Build artifacts are available here :
> > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2
> > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/12.2
> > /vc2
> >
> > They were built by the Jenkins pipeline and moved to their place :
> > https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/netbean
> > s/job/release122/20/
> >
> > We are primarily voting on :
> > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2/netb
> > eans-12.2-source.zip
> >
> > SHA512 :
> > 84e7584689e0993ee60e9af8ccad2ba247bad8562ab742bf24d19ab56f29ac131943a
> > b54fcf850588e04a00bdd9fea40909e1b91f47c8f545f89cae29144af8e
> >
> > KEYS file :
> > https://downloads.apache.org/netbeans/KEYS
> >
> > --
> >
> > Associated to the primary source item you will have (generated with
> > pipeline mentioned above)
> > * under
> > https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2
> > binaries associated to the source
> > netbeans-12.2-bin.zip
> > as well as update content under nbms folder
> >
> > * under
> > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/12.2
> > /vc2
> > you will find platform cluster build
> > netbeans-platform-12.2-bin.zip
> > netbeans-platform-12.2-source.zip
> >
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>

-- 
Boris Heithecker


Dr. Boris Heithecker
Lüneburger Str. 30
28870 Ottersberg
Festnetz: +49 4205 315834
Mobil: +49 170 6137015


RE: [VOTE] Release Apache NetBeans 12.2 (vote candidate 2)

2020-11-24 Thread Eric Barboni
+1 (binding)

-Message d'origine-
De : Matthias Bläsing  
Envoyé : lundi 23 novembre 2020 21:22
À : dev@netbeans.apache.org
Objet : Re: [VOTE] Release Apache NetBeans 12.2 (vote candidate 2)

+1 (binding)

 * verified SHA512 (netbeans-12.2-bin.zip, netbeans-12.2-source.zip,
   netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-source.zip)
 * verified ASC (netbeans-12.2-bin.zip, netbeans-12.2-source.zip,
   netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-source.zip)
 * NOTICE files look sane (netbeans-12.2-bin.zip, netbeans-12.2-
   source.zip, netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-
   source.zip)
 * LICENSE files look sane (netbeans-12.2-bin.zip, netbeans-12.2-
   source.zip, netbeans-platform-12.2-bin.zip, netbeans-platform-12.2-
   source.zip)
 * ran RAT check for the netbeans 12.2 source zip, which came back   
   clean
 * verified, that code in netbeans-12.2-source.zip matches contents of
   git repository of tag 12.2-rc2 (module the issue described below)
 * verified, that netbeans-platform source is a strict subset of
   netbeans
 * build netbeans 12.2 from source with JDK 8 (netbeans-12.2-
   source.zip) on linux, which results in a runnable IDE

Found issue in the JSF support: the new support for bootsfaces is not correctly 
registered in the cluster and not part of the release:
https://issues.apache.org/jira/browse/NETBEANS-5054 . I don't consider this a 
blocker.

Thank you!

Matthias

Am Samstag, den 21.11.2020, 00:06 -0800 schrieb Laszlo Kishalmi:
> Dear community,
> 
> This is our second voting candidate for the 12.2 release of Apache 
> NetBeans. It is built off the same commit as 12.2-rc3. Please note all 
> requirements below for validating sources and convenience binaries 
> before voting.
> 
> Apache NetBeans 12.2 constitutes all clusters in the Apache NetBeans 
> Git repository, which together provide the NetBeans Platform (i.e., 
> the underlying application framework), as well as all the modules that 
> provide the Java SE, Java EE, PHP, JavaScript and Groovy features of 
> Apache NetBeans.
> 
> Build artifacts are available here :
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/12.2
> /vc2
> 
> They were built by the Jenkins pipeline and moved to their place :
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-TLP/job/netbean
> s/job/release122/20/
> 
> We are primarily voting on :
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2/netb
> eans-12.2-source.zip
> 
> SHA512 :
> 84e7584689e0993ee60e9af8ccad2ba247bad8562ab742bf24d19ab56f29ac131943a
> b54fcf850588e04a00bdd9fea40909e1b91f47c8f545f89cae29144af8e
> 
> KEYS file :
> https://downloads.apache.org/netbeans/KEYS
> 
> --
> 
> Associated to the primary source item you will have (generated with 
> pipeline mentioned above)
> * under
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans/12.2/vc2
> binaries associated to the source
> netbeans-12.2-bin.zip
> as well as update content under nbms folder
> 
> * under
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-platform/12.2
> /vc2
> you will find platform cluster build
> netbeans-platform-12.2-bin.zip
> netbeans-platform-12.2-source.zip
> 



-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Voting in parallel was: Release Apache NetBeans Language Server VSCode extension for 12.2

2020-11-24 Thread Neil C Smith
On Tue, 24 Nov 2020 at 09:22, Jan Lahoda  wrote:
> 24. listopadu 2020 8:53:19 SEČ, John Mc  napsal:
> >My main concern here and the reason for my -1 is that there seems to be
> >a
> >push for a convince binary without knowing if the main vote passes. If
> >it
> >doesn't then it's a waste of time and effort.
>
> I don't see that huge problem in running votes in parallel. The obvious 
> advantages are that there is less time wasted waiting for votes, and that if 
> a problem is found during a convenience binary vote, it can advise the main 
> vote.

+1 See also multiple discussions we already had on this during 11.2,
prior to which we hadn't really voted on binaries at all.  eg.
https://lists.apache.org/thread.html/52cb91e35bb268e32c353cafef917f9e8bf304e420e3ff08ababe707%40%3Cdev.netbeans.apache.org%3E
 The intention then was always to have parallel voting wherever
possible, the discussion was more about whether to have one thread or
multiple.

The only reason we didn't have parallel votes for installers for 12.1
was delay caused by macOS issues (again!) which John sorted, and
problems I had with accessing ASF signing via new computer for the
Windows installer.  Those sort of things happen, but are not a good
reason in my opinion to make it a "NetBeans project habit", hence my
first reply! :-)

> >Im also struggling with why this new sub project seems to be pushing
> >forward and not liasing with the NetBeans RM for this release. Why are
> >they
> >pushing a separate timetable?  Surely the creation of a timetable for
>
> Not sure if there is a separate timetable - the source release will be done 
> first, and then the other/secondary convenience binaries, including this one. 
> So it seems like a single timetable?

+1, although agree with John that it sounds like this might have been
better coordinated with Laszlo as RM.

Best wishes,

Neil

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: Voting in parallel was: Release Apache NetBeans Language Server VSCode extension for 12.2

2020-11-24 Thread Jan Lahoda
Hi,

My personal opinion only:


24. listopadu 2020 8:53:19 SEČ, John Mc  napsal:
>Hi Laszlo,
>
>It will probably be at the weekend when I can do the Mac installer. But
>yeah I've no problem doing it.
>
>My main concern here and the reason for my -1 is that there seems to be
>a
>push for a convince binary without knowing if the main vote passes. If
>it
>doesn't then it's a waste of time and effort.

I don't see that huge problem in running votes in parallel. The obvious 
advantages are that there is less time wasted waiting for votes, and that if a 
problem is found during a convenience binary vote, it can advise the main vote.

>
>Im also struggling with why this new sub project seems to be pushing
>forward and not liasing with the NetBeans RM for this release. Why are
>they
>pushing a separate timetable?  Surely the creation of a timetable for

Not sure if there is a separate timetable - the source release will be done 
first, and then the other/secondary convenience binaries, including this one. 
So it seems like a single timetable?

Jan

>it's
>release should come from the NetBeans RM? Granted someone in the
>community
>might do the last few steps but ultimately it's a NetBeans release...
>
>
>Regards
>
>John
>
>On Mon 23 Nov 2020, 21:49 Laszlo Kishalmi, 
>wrote:
>
>> Well, I plan to close the VOTING round for 12.2 source Tomorrow
>morning
>> PST (That would be Tomorrow late afternoon in Europe). After that is
>out
>> I'd start a round for the Window and Linux binaries, also I'd ask
>John
>> to prepare the Mac binary. That would be the right time to start the
>VS
>> Code binary round, probably by then it won't be necessary to refer as
>> rc3 or voting candidate 2, as NetBeans 12.2 shall be considered as
>> released.
>>
>> Once the parallel votes have been collected, assuming that we could
>> prepare the website, the announcements can go out on the weekend.
>>
>>
>> On 11/23/20 1:01 PM, Jaroslav Tulach wrote:
>> >> Well, it would have been nicer to wait the close of the 12.2 vote.
>I
>> >> know it seems to be a matter of formality by now, but still..
>> > The best time to object was on Thursday when I described the plan
>to
>> vote in
>> > parallel:
>> >
>> > https://lists.apache.org/thread.html/
>> > r2c456e2ae9cde981e2027c9ac65ec9e624405d7b052a13e4256f2f6f%40%
>> 3Cdev.netbeans.apache.org%3E
>> >
>> > I wrote:
>> >> Given another slip, we probably run our vote in parallel to speed
>> things up.
>> >> We are short on time -  GraalVM 20.3 was released yesterday and it
>is
>> >> missing its tooling. Every delay counts.
>> > It is my understanding that finishing source vote and only then
>starting
>> vote
>> > on complementary binaries is not Apache policy, just a NetBeans
>project
>> habit.
>> >
>> > John Mc wrote:
>> >> Votes on convenience binaries should surely wait to see if the
>parent
>> >> project vote passes imo
>> > We are certainly not going to finish the VSNetBeans vote sooner
>than
>> parent one
>> > is over. As Martin wrote:
>> >
>> >>> I would like to release this convenience binary on VSCode
>Marketplace
>> >>> as soon as NetBeans 12.2 VC2 completes as well as this voting
>> completes.
>> > Of course, few more `-1` like the one by John...
>> >
>> > John Mc wrote:
>> >> -1
>> > ...and the VSNetBeans vote is over before the parent vote finishes.
>> > -jt
>> >
>> >
>> >
>> >
>> >
>-
>> > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
>> > For additional commands, e-mail: dev-h...@netbeans.apache.org
>> >
>> > For further information about the NetBeans mailing lists, visit:
>> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>> >
>> >
>> >
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
>> For additional commands, e-mail: dev-h...@netbeans.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>

-- 
Odesláno aplikací K-9 Mail ze systému Android. Omluvte prosím moji stručnost.

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [VOTE] Release Apache NetBeans Language Server VSCode extension for 12.2

2020-11-24 Thread Martin Balin
Waiting for parent project voting passes was and is the intention and 
prerequisite for this voting and for closing it.

Martin

On 23. 11. 20 21:01, John Mc wrote:

-1

Votes on convenience binaries should surely wait to see if the parent 
project vote passes imo.


Regards

John

On Mon 23 Nov 2020, 18:58 Laszlo Kishalmi, > wrote:


Well, it would have been nicer to wait the close of the 12.2 vote. I
know it seems to be a matter of formality by now, but still..

Also it would have been really nice to start a new [VOTE] thread
instead
of messing with the original 12.2 one.

On 11/23/20 8:52 AM, Martin Balin wrote:
> Dear community,
>
> I want to start voting on Apache NetBeans Language Server VSCode
> extension convenience binary for 12.2 release of Apache
NetBeans. It
> is built off the main Apache NetBeans 12.2 voting candidate 2,
sent by
> Laszlo Kishalmi.
>
> Build description is here
>

https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/BUILD.md#building



>
>
> Build artifacts of NetBeans VSCode extension are available here:
>
https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.2.0/



>
>
> The primary convenience binary is:
>

https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.2.0/apache-netbeans-java-12.2.0-vc2.vsix



>
> SHA512:
>

297be45741aecf32d19e32c61214a8e56ca034a6594ddfd76e77761bac83a9af7747263e61f403753c18abb7918494600247e258061e8be4a5d526eedd25efeb

>
>
> I would like to release this convenience binary on VSCode
Marketplace
> as soon as NetBeans 12.2 VC2 completes as well as this voting
completes.
>
> Thank you,
> Martin Balin

-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org

For additional commands, e-mail: dev-h...@netbeans.apache.org


For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists








-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists





Re: [VOTE] Release Apache NetBeans Language Server VSCode extension for 12.2

2020-11-24 Thread Martin Balin

Hi,
I'm sorry, still learning how to release complimentary binaries for 
NetBeans.

Next time I'll do it better.

Martin

On 23. 11. 20 19:58, Laszlo Kishalmi wrote:
Well, it would have been nicer to wait the close of the 12.2 vote. I 
know it seems to be a matter of formality by now, but still..


Also it would have been really nice to start a new [VOTE] thread 
instead of messing with the original 12.2 one.


On 11/23/20 8:52 AM, Martin Balin wrote:

Dear community,

I want to start voting on Apache NetBeans Language Server VSCode 
extension convenience binary for 12.2 release of Apache NetBeans. It 
is built off the main Apache NetBeans 12.2 voting candidate 2, sent 
by Laszlo Kishalmi.


Build description is here
https://urldefense.com/v3/__https://github.com/apache/netbeans/blob/master/java/java.lsp.server/vscode/BUILD.md*building__;Iw!!GqivPVa7Brio!IyM2ewNljBQybq_mdJa_anNW_IoLk6HdvMaq0CFsYHIsXASeZ-0_vLbnSm3q3fVzUA$ 



Build artifacts of NetBeans VSCode extension are available here:
https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.2.0/__;!!GqivPVa7Brio!IyM2ewNljBQybq_mdJa_anNW_IoLk6HdvMaq0CFsYHIsXASeZ-0_vLbnSm041psFcw$ 



The primary convenience binary is:
https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.2.0/apache-netbeans-java-12.2.0-vc2.vsix__;!!GqivPVa7Brio!IyM2ewNljBQybq_mdJa_anNW_IoLk6HdvMaq0CFsYHIsXASeZ-0_vLbnSm2hY7dOTQ$ 


SHA512:
297be45741aecf32d19e32c61214a8e56ca034a6594ddfd76e77761bac83a9af7747263e61f403753c18abb7918494600247e258061e8be4a5d526eedd25efeb 



I would like to release this convenience binary on VSCode Marketplace 
as soon as NetBeans 12.2 VC2 completes as well as this voting completes.


Thank you,
Martin Balin



-
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists