[GitHub] incubator-netbeans pull request #26: [NETBEANS-54] Module Review api.debugge...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/26


---

[GitHub] incubator-netbeans pull request #27: [NETBEANS-54] Module Review api.xml.ui

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/27


---

[GitHub] incubator-netbeans pull request #28: [NETBEANS-54] Module Review bugtracking

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/28


---

[GitHub] incubator-netbeans pull request #39: [NETBEANS-54] Module Review bugzilla

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/39


---

[GitHub] incubator-netbeans pull request #40: [NETBEANS-54] Module Review c.googlecod...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/40


---

[GitHub] incubator-netbeans pull request #41: [NETBEANS-54] Module Review c.google.gu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/41


---

Podling Report Reminder - October 2017

[johndament]

Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 18 October 2017, 10:30 am PDT.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, October 04).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.
*   How does the podling rate their own maturity.

This should be appended to the Incubator Wiki page at:

https://wiki.apache.org/incubator/October2017

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC

[GitHub] incubator-netbeans pull request #48: [NETBEANS-54] Module Review c.jcraft.jz...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/48


---

[GitHub] incubator-netbeans pull request #54: added initial .travis.yml

[krichter722]

GitHub user krichter722 opened a pull request:

https://github.com/apache/incubator-netbeans/pull/54

added initial .travis.yml

A basic `.travis.yml` to test the build instructions specified in 
`README.md`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krichter722/incubator-netbeans travis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit 9b79bd443b61482d3e9988a89272d14741af8a12
Author: Karl-Philipp Richter 
Date:   2017-10-03T22:42:28Z

added initial .travis.yml




---

Re: Editing permissions for making changes to the Wiki.

[Geertjan Wielenga]

Done!

And welcome!

Gj

On Tue, Oct 3, 2017 at 1:05 PM, Borxa Varela Bouzas 
wrote:

> Hi,
>
> Would someone please add my confluence id " borxa " to the list of
> people allowed to make changes to the list of modules to review at
> [1]?
>
> Thanks,
> Borxa
>
> [1] https://cwiki.apache.org/confluence/display/NETBEANS/
> List+of+Modules+to+Review  confluence/display/NETBEANS/List+of+Modules+to+Review>

[GitHub] incubator-netbeans pull request #53: [NETBEANS-54] Module Review editor.code...

[vieiro]

GitHub user vieiro opened a pull request:

https://github.com/apache/incubator-netbeans/pull/53

[NETBEANS-54] Module Review editor.codetemplates

  * No external libraries.
  * A nbproject/*sig that will be handled centrally.
  * Some text xml files wihout license header.
  * Test org.netbeans.lib.editor.codetemplates.CodeTemplatesTest FAILED...
... but ant -Dtest-unit-sys-prop.ignore.random.failures=true test did 
not fail.
  * Did you know that NetBeans DeveloperX2 was released in the spring of 
1998?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vieiro/incubator-netbeans 
netbeans-54-module-review-editor.codetemplates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #53


commit da1da87d7f2bf5a7183a4f5d703cab1311c46040
Author: Antonio Vieiro 
Date:   2017-10-03T20:48:49Z

[NETBEANS-54] Module Review editor.codetemplates

  * No external libraries.
  * A nbproject/*sig that will be handled centrally.
  * Some text xml files wihout license header.
  * Test org.netbeans.lib.editor.codetemplates.CodeTemplatesTest FAILED...
... but ant -Dtest-unit-sys-prop.ignore.random.failures=true test did 
not fail.
  * Did you know that NetBeans DeveloperX2 was released in the spring of 
1998?




---

Editing permissions for making changes to the Wiki.

[Borxa Varela Bouzas]

Hi,

Would someone please add my confluence id " borxa " to the list of
people allowed to make changes to the list of modules to review at
[1]?

Thanks,
Borxa

[1] 
https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review 

[GitHub] incubator-netbeans pull request #52: First batch of xml modules for review

[matthiasblaesing]

GitHub user matthiasblaesing opened a pull request:

https://github.com/apache/incubator-netbeans/pull/52

First batch of xml modules for review

Please see the individual commits for the details.

The biggest changeset comes from xml.text, as there many unittest files 
were adjusted to contain a header and in turn the unittests were modified
accordingly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matthiasblaesing/incubator-netbeans 
xml1-review

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #52


commit fc3b05a7427294c4ee165d5463e583f04057b9ee
Author: Matthias Bläsing 
Date:   2017-10-03T16:18:44Z

[NETBEANS-54] Module review xml.text.obsolete90

- no external library
- checked Rat report; added license header to testfiles and ensured 
  tests still run cleanly, removed unused file, that only differs from
  neighbouring file by license
- skimmed through the module, did not notice additional problems

commit 6e2e69edb6b6d0543938d99c00f62ccbe3948434
Author: Matthias Bläsing 
Date:   2017-10-03T16:41:58Z

[NETBEANS-54] Module review xml.core

- no external library
- checked Rat report; added license header to testfiles
- skimmed through the module, did not notice additional problems

commit 74d7170729987212710f0572abe4372decfa0db9
Author: Matthias Bläsing 
Date:   2017-10-03T17:07:59Z

[NETBEANS-54] Module review xml.retriever

- no external library
- checked Rat report; added license header to testfiles
- skimmed through the module, did not notice additional problems

commit 2eb40408a380977d58650fdd2bf70e0170a7e1ca
Author: Matthias Bläsing 
Date:   2017-10-03T17:17:53Z

[NETBEANS-54] Module review xml.multiview

- no external library
- checked Rat report; added license header to testfiles, manually 
  updated unconverted license headers
- skimmed through the module, did not notice additional problems

commit d320afd4cc151f250b6b424476832dfa9d06ddd7
Author: Matthias Bläsing 
Date:   2017-10-03T17:57:06Z

[NETBEANS-54] Module review xsl

- no external library
- checked Rat report; added testfiles to exclude list for rat
- skimmed through the module, did not notice additional problems

commit 2fe14876dca137fc2653d2eeacbd78895288fb2e
Author: Matthias Bläsing 
Date:   2017-10-03T19:17:52Z

[NETBEANS-54] Module review xml.text

- no external library
- checked Rat report; added license to many test files and adjusted
  tests to match these; exclude GUI visible sample data and sepcial
  test data
- skimmed through the module, did not notice additional problems




---

[GitHub] incubator-netbeans issue #49: [NETBEANS-54] Add license header to binaries-l...

[jlahoda]

Github user jlahoda commented on the issue:

https://github.com/apache/incubator-netbeans/pull/49
  
To me personally, looks OK.


---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

[junichi11]

Github user junichi11 commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
 Thank you for it :) I'll push changes tomorrow.


---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
These look good to me.

Before doing the final push you might do:



---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

[junichi11]

Github user junichi11 commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
@emilianbold Yes. Are the following steps OK if I push my changes myself?
```
$ cd incubator-netbeans

$ git remote add upstream-apache 
https://git-wip-us.apache.org/repos/asf/incubator-netbeans

$ git checkout master 
$ git pull upstream-apache master
$ git push origin master

$ git checkout module-review-branch
$ git rebase master module-review-branch
$ git push -f origin module-review-branch

$ git checkout master
$ git merge module-review-branch
$ git push upstream-apache master
```



---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
@junichi11 will you commit this yourself?


---

[GitHub] incubator-netbeans issue #41: [NETBEANS-54] Module Review c.google.guava

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/41
  
Feel free to commit.


---

[GitHub] incubator-netbeans pull request #44: Testcases related fixes

[emilianbold]

Github user emilianbold commented on a diff in the pull request:

https://github.com/apache/incubator-netbeans/pull/44#discussion_r142446465
  
--- Diff: 
autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/UpdateProviderFactoryCreateTest.java
 ---
@@ -50,7 +50,7 @@ protected void tearDown () throws  Exception {
 public void testCreate () throws Exception {
 String name = "new-one";
 String displayName = "Newone";
-URL url = UpdateUnitFactoryTest.class.getResource 
("data/catalog.xml");
+URL url = CatalogCacheTest.class.getResource ("data/catalog.xml");
--- End diff --

Why not use `UpdateProviderFactoryCreateTest.class` here? Or even 
`getClass().getResource()` ?


---

[GitHub] incubator-netbeans pull request #13: [NETBEANS-54] Module Review openide.mod...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/13


---

[GitHub] incubator-netbeans pull request #32: [NETBEANS-54] Module Review server

[borxa]

Github user borxa closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/32


---

Re: Grep CDDL (was Re: PR #46)

[Antonio Vieiro]

Aha! I now understand :-)

I’ll doublecheck that the files excluded don’t have any original license 
headers.

Thanks,
Antonio


> El 3 oct 2017, a las 15:36, Jan Lahoda  escribió:
> 
> Sorry, I probably should have been more precise.
> 
> All I meant was a check that the files excluded from Rat don't have the
> original license header (as due to the excludes, Rat would no longer report
> them). I tried to check, and it seems that none of the excluded files has
> the headers, so this should be OK.
> 
> Thanks,
> Jan
> 
> 
> On Tue, Oct 3, 2017 at 1:34 PM, Antonio  wrote:
> 
>> 
>> 
>> On 03/10/17 12:59, Antonio wrote:
>> 
>>> 
>>> I'll investigate the grep operation on CDDL and will post here with my
>>> findings.
>>> 
>>> 
>> It seems ant-rat is not able to do this.
>> 
>> Anyway one can quickly find CDDL files with
>>grep -R CDDL --exclude-dir build
>> 
>> Or adding
>> 
>>
>>
>>
>>
>>
>> 
>> to nbbuild/build.xml and then running ant grep-cddl
>> 
>> This is Linux specific (and should run in OS/X as well).
>> 
>> Want another PR with this?
>> 
>> Cheers,
>> Antonio
>> 

[GitHub] incubator-netbeans pull request #51: [NETBEANS-54] Module review docker.edit...

[matthiasblaesing]

GitHub user matthiasblaesing opened a pull request:

https://github.com/apache/incubator-netbeans/pull/51

[NETBEANS-54] Module review docker.editor

- no external library

- checked Rat report; manually updated license header in Dockerfile

- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matthiasblaesing/incubator-netbeans 
docker.editor-review

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit 2988ec3b199a0bb91917f2f4fd1018c5231bed8f
Author: Matthias Bläsing 
Date:   2017-10-03T15:15:50Z

[NETBEANS-54] Module review docker.editor

- no external library

- checked Rat report; manually updated license header in Dockerfile

- skimmed through the module, did not notice additional problems




---

[GitHub] incubator-netbeans pull request #10: [NETBEANS-54] Module Review openide.fil...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/10


---

[GitHub] incubator-netbeans pull request #25: NETBEANS-73: Autodetect id_rsa and id_d...

[lkishalmi]

Github user lkishalmi closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/25


---

[GitHub] incubator-netbeans pull request #50: [NETBEANS-54] Module review diff

[matthiasblaesing]

GitHub user matthiasblaesing opened a pull request:

https://github.com/apache/incubator-netbeans/pull/50

[NETBEANS-54] Module review diff

- no external library

- checked Rat report; ignored l10n.list (see central problems) and
  added ingore entries for rat report.

- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matthiasblaesing/incubator-netbeans 
diff-review

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #50


commit 3961ee1ba18ca30a7d7a0c6d640ad0b15b7e7162
Author: Matthias Bläsing 
Date:   2017-10-03T15:03:51Z

[NETBEANS-54] Module review diff

- no external library

- checked Rat report; ignored l10n.list (see central problems) and
  added ingore entries for rat report.

- skimmed through the module, did not notice additional problems




---

[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...

[lkishalmi]

Github user lkishalmi commented on the issue:

https://github.com/apache/incubator-netbeans/pull/25
  
Thank you!


---

[GitHub] incubator-netbeans issue #14: [NETBEANS-54] Module Review o.n.swing.tabcontr...

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/14
  
Merged.


---

[GitHub] incubator-netbeans pull request #14: [NETBEANS-54] Module Review o.n.swing.t...

[emilianbold]

Github user emilianbold closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/14


---

[GitHub] incubator-netbeans issue #17: [NETBEANS-54] Module Review openide.text

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/17
  
Committed.


---

Re: iCLA needed for Module Reviews?

[Matthias Bläsing]

Hi,

Am Dienstag, den 03.10.2017, 16:47 +0200 schrieb Christian Lenz:
> Because I asked for help in the slack chan to Review the modules, I
> get a question:
> 
> „is there any contribution agreement to sign?“
> 
> In General yes, but is this iCLA needed for module Review too?

the work itself needs to be done and is valuable, but I don't see this
reaching the level of creativity, that is needed for IP protection.

So I merged at least one or two commits already, just because they were
small enough.

Greetings

Matthias

AW: iCLA needed for Module Reviews?

[Christian Lenz]

Of Course it is always good, but if it is not needed for the module Review for 
the users to bring it on, it will be ok. 

Gesendet von Mail für Windows 10

Von: Emilian Bold
Gesendet: Dienstag, 3. Oktober 2017 16:50
An: NetBeans Dev@
Betreff: Re: iCLA needed for Module Reviews?

PS: Note how the iCLA may be digitally signed with PGP. No need to FAX
stuff.


--emi

On Tue, Oct 3, 2017 at 5:49 PM, Emilian Bold  wrote:

> I would say no. Any review will be double-checked by somebody else too and
> committed by a committer.
>
> --emi
>
> On Tue, Oct 3, 2017 at 5:47 PM, Christian Lenz 
> wrote:
>
>> Because I asked for help in the slack chan to Review the modules, I get a
>> question:
>>
>> „is there any contribution agreement to sign?“
>>
>> In General yes, but is this iCLA needed for module Review too?
>>
>>
>> Regards
>>
>> Chris
>>
>
>

Re: iCLA needed for Module Reviews?

[Matthias Bläsing]

Hi,

Am Dienstag, den 03.10.2017, 17:50 +0300 schrieb Emilian Bold:
> PS: Note how the iCLA may be digitally signed with PGP. No need to
> FAX
> stuff.

it does not even need to be signed by PGP. I printed the sheet, filled
it, scanned it and emailed it to apache. Very painless!

Greetings

Matthias

Re: iCLA needed for Module Reviews?

[Emilian Bold]

PS: Note how the iCLA may be digitally signed with PGP. No need to FAX
stuff.


--emi

On Tue, Oct 3, 2017 at 5:49 PM, Emilian Bold  wrote:

> I would say no. Any review will be double-checked by somebody else too and
> committed by a committer.
>
> --emi
>
> On Tue, Oct 3, 2017 at 5:47 PM, Christian Lenz 
> wrote:
>
>> Because I asked for help in the slack chan to Review the modules, I get a
>> question:
>>
>> „is there any contribution agreement to sign?“
>>
>> In General yes, but is this iCLA needed for module Review too?
>>
>>
>> Regards
>>
>> Chris
>>
>
>

Re: iCLA needed for Module Reviews?

[Emilian Bold]

I would say no. Any review will be double-checked by somebody else too and
committed by a committer.

--emi

On Tue, Oct 3, 2017 at 5:47 PM, Christian Lenz 
wrote:

> Because I asked for help in the slack chan to Review the modules, I get a
> question:
>
> „is there any contribution agreement to sign?“
>
> In General yes, but is this iCLA needed for module Review too?
>
>
> Regards
>
> Chris
>

Re: iCLA needed for Module Reviews?

[Geertjan Wielenga]

I think it's always good to get your iCLA sorted out, it's not hard,
regardless of whether you need it for this specific task.

https://www.apache.org/licenses/icla.pdf

Gj

On Tue, Oct 3, 2017 at 7:47 AM, Christian Lenz 
wrote:

> Because I asked for help in the slack chan to Review the modules, I get a
> question:
>
> „is there any contribution agreement to sign?“
>
> In General yes, but is this iCLA needed for module Review too?
>
>
> Regards
>
> Chris
>

[GitHub] incubator-netbeans pull request #18: [NETBEANS-54] Module Review settings

[emilianbold]

Github user emilianbold closed the pull request at:

https://github.com/apache/incubator-netbeans/pull/18


---

[GitHub] incubator-netbeans issue #18: [NETBEANS-54] Module Review settings

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/18
  
Committed.


---

iCLA needed for Module Reviews?

[Christian Lenz]

Because I asked for help in the slack chan to Review the modules, I get a 
question:

„is there any contribution agreement to sign?“

In General yes, but is this iCLA needed for module Review too?


Regards

Chris

[GitHub] incubator-netbeans issue #46: Updating the rat exclusion list

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/46
  
One additional thing I'd add is:
- `*/nbproject/private/**` (the files are per user and should not be 
distributed)

I would also not match with `**/nbproject` but `*/nbproject`. This way you 
wont accidentally match wrong files.


---

[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/25
  
Please close this PR.


---

[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...

[emilianbold]

Github user emilianbold commented on the issue:

https://github.com/apache/incubator-netbeans/pull/25
  
Committed: 
https://github.com/apache/incubator-netbeans/commit/ff5f3c4e175cf15c1b4b0caebfb5047be4196a44


---

Re: Grep CDDL (was Re: PR #46)

[Jan Lahoda]

Sorry, I probably should have been more precise.

All I meant was a check that the files excluded from Rat don't have the
original license header (as due to the excludes, Rat would no longer report
them). I tried to check, and it seems that none of the excluded files has
the headers, so this should be OK.

Thanks,
 Jan


On Tue, Oct 3, 2017 at 1:34 PM, Antonio  wrote:

>
>
> On 03/10/17 12:59, Antonio wrote:
>
>>
>> I'll investigate the grep operation on CDDL and will post here with my
>> findings.
>>
>>
> It seems ant-rat is not able to do this.
>
> Anyway one can quickly find CDDL files with
> grep -R CDDL --exclude-dir build
>
> Or adding
>
> 
> 
> 
> 
> 
>
> to nbbuild/build.xml and then running ant grep-cddl
>
> This is Linux specific (and should run in OS/X as well).
>
> Want another PR with this?
>
> Cheers,
> Antonio
>

Re: OK, so what did I mess up?

[Emilian Bold]

Yes, the repository is in a sane state. It's just those 3 duplicate commits 
that are annoying...

Funny thing is this time I tried not to do a rebase but do a plain merge. I 
will stick to fast forward.

--emi

Pe 3 oct. 2017, la 16:10, Matthias Bläsing  a scris:

> Hi Emilian,
> 
> Am Dienstag, den 03.10.2017, 15:27 +0300 schrieb Emilian Bold:
>> I looked with
>> 
>>> 
>>> $ git diff --stat --cached apache/master
>>>  git/src/org/netbeans/modules/git/ui/repository/remote/RemoteReposi
>>> tory.java
 13 ++---
>>> 
>>>  1 file changed, 10 insertions(+), 3 deletions(-)
>> 
>> so I was only supposed to push one change.
>> 
>> But $ git push apache master
>> 
>>> Counting objects: 18, done.
>>> Delta compression using up to 8 threads.
>>> Compressing objects: 100% (13/13), done.
>>> Writing objects: 100% (18/18), 2.09 KiB | 0 bytes/s, done.
>>> Total 18 (delta 10), reused 1 (delta 1)
>>> remote: incubator-netbeans git commit: Merge branch 'master' of
>>> https://github.com/apache/incubator-netbeans
>>> remote: incubator-netbeans git commit: Made Git keyfile auto
>>> detection
>>> when key auth is selected.
>>> remote: incubator-netbeans git commit: [NETBEANS-54] Module Review
>>> server
>>> remote: incubator-netbeans git commit: [NETBEANS-54] Module Review
>>> defaults
>>> remote: incubator-netbeans git commit: [NETBEANS-54] Module Review
>>> db.mysql
>>> To https://git-wip-us.apache.org/repos/asf/incubator-netbeans.git
>>>9a152a7..bd9aece  master -> master
>> 
>> 
>> So now I see those annoying "committed with emilianbold 4 days ago"
>> commits.
>> 
>> What went wrong?
>> 
>> It was a fresh clone (git checkout -b master2 apache/master) too...
>> 
>> Sigh...
>> 
> 
> This looks like some rebases happened. This was a straight merge I did
> from the PR into master (without rebasing):
> 
> https://github.com/apache/incubator-netbeans/commit/cb443c2efbbd41df528c4166f0b0a629d899cec5
> 
> and this I did by pulling the PR from borxa rebasing+squashing it
> together:
> 
> https://github.com/apache/incubator-netbeans/commit/9a152a75f50f53219b3b2669b6ab9e69a9beb1d7
> 
> So could it be, that you did some rebasing and that went wrong?
> 
> On the positive side the repository looks to be still in a sane state.
> 
> Greetings
> 
> Matthias

[GitHub] incubator-netbeans issue #12: properties for by module report

[ebarboni]

Github user ebarboni commented on the issue:

https://github.com/apache/incubator-netbeans/pull/12
  
closing this PR. Do not want to add false positive to the rat report


---

Re: OK, so what did I mess up?

[Matthias Bläsing]

Hi Emilian,

Am Dienstag, den 03.10.2017, 15:27 +0300 schrieb Emilian Bold:
> I looked with
> 
> > 
> > $ git diff --stat --cached apache/master
> >  git/src/org/netbeans/modules/git/ui/repository/remote/RemoteReposi
> > tory.java
> > > 13 ++---
> > 
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> so I was only supposed to push one change.
> 
> But $ git push apache master
> 
> > Counting objects: 18, done.
> > Delta compression using up to 8 threads.
> > Compressing objects: 100% (13/13), done.
> > Writing objects: 100% (18/18), 2.09 KiB | 0 bytes/s, done.
> > Total 18 (delta 10), reused 1 (delta 1)
> > remote: incubator-netbeans git commit: Merge branch 'master' of
> > https://github.com/apache/incubator-netbeans
> > remote: incubator-netbeans git commit: Made Git keyfile auto
> > detection
> > when key auth is selected.
> > remote: incubator-netbeans git commit: [NETBEANS-54] Module Review
> > server
> > remote: incubator-netbeans git commit: [NETBEANS-54] Module Review
> > defaults
> > remote: incubator-netbeans git commit: [NETBEANS-54] Module Review
> > db.mysql
> > To https://git-wip-us.apache.org/repos/asf/incubator-netbeans.git
> >    9a152a7..bd9aece  master -> master
> 
> 
> So now I see those annoying "committed with emilianbold 4 days ago"
> commits.
> 
> What went wrong?
> 
> It was a fresh clone (git checkout -b master2 apache/master) too...
> 
> Sigh...
> 

This looks like some rebases happened. This was a straight merge I did
from the PR into master (without rebasing):

https://github.com/apache/incubator-netbeans/commit/cb443c2efbbd41df528c4166f0b0a629d899cec5

and this I did by pulling the PR from borxa rebasing+squashing it
together:

https://github.com/apache/incubator-netbeans/commit/9a152a75f50f53219b3b2669b6ab9e69a9beb1d7

So could it be, that you did some rebasing and that went wrong?

On the positive side the repository looks to be still in a sane state.

Greetings

Matthias

[GitHub] incubator-netbeans issue #43: [NETBEANS-54] Module Review editor.bookmarks

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/43
  
Looks good.


---

[GitHub] incubator-netbeans issue #45: [NETBEANS-54] Module Review masterfs.ui

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/45
  
Looks good.


---

[GitHub] incubator-netbeans issue #48: [NETBEANS-54] Module Review c.jcraft.jzlib

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/48
  
Looks good.


---

[GitHub] incubator-netbeans issue #47: [NETBEANS-54] Module Review c.jcraft.jsch

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/47
  
Looks good.


---

OK, so what did I mess up?

[Emilian Bold]

I looked with

>
> $ git diff --stat --cached apache/master
>  git/src/org/netbeans/modules/git/ui/repository/remote/RemoteRepository.java
> | 13 ++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

so I was only supposed to push one change.

But $ git push apache master

> Counting objects: 18, done.
> Delta compression using up to 8 threads.
> Compressing objects: 100% (13/13), done.
> Writing objects: 100% (18/18), 2.09 KiB | 0 bytes/s, done.
> Total 18 (delta 10), reused 1 (delta 1)
> remote: incubator-netbeans git commit: Merge branch 'master' of
> https://github.com/apache/incubator-netbeans
> remote: incubator-netbeans git commit: Made Git keyfile auto detection
> when key auth is selected.
> remote: incubator-netbeans git commit: [NETBEANS-54] Module Review server
> remote: incubator-netbeans git commit: [NETBEANS-54] Module Review defaults
> remote: incubator-netbeans git commit: [NETBEANS-54] Module Review db.mysql
> To https://git-wip-us.apache.org/repos/asf/incubator-netbeans.git
>9a152a7..bd9aece  master -> master


So now I see those annoying "committed with emilianbold 4 days ago" commits.

What went wrong?

It was a fresh clone (git checkout -b master2 apache/master) too...

Sigh...

--emi

[GitHub] incubator-netbeans issue #46: Updating the rat exclusion list

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/46
  
Looks good - the files that would match also look clean (either ALv2 or no 
license header):

```
matthias@athena:~/src/incubator-netbeans$ find . \( -name build-impl.xml -o 
-name jfx-impl.xml -o -name genfiles.properties  \) -print0 | xargs -0 grep -i 
CDDL
matthias@athena:~/src/incubator-netbeans$ find . \( -name build-impl.xml -o 
-name jfx-impl.xml -o -name genfiles.properties  \) -print0 | xargs -0 grep -i 
LICENSE 
./java.examples/anagrams/nbproject/genfiles.properties:# Licensed to the 
Apache Software Foundation (ASF) under one
./java.examples/anagrams/nbproject/genfiles.properties:# or more 
contributor license agreements.  See the NOTICE file
./java.examples/anagrams/nbproject/genfiles.properties:# regarding 
copyright ownership.  The ASF licenses this file
./java.examples/anagrams/nbproject/genfiles.properties:# to you under the 
Apache License, Version 2.0 (the
./java.examples/anagrams/nbproject/genfiles.properties:# "License"); you 
may not use this file except in compliance
./java.examples/anagrams/nbproject/genfiles.properties:# with the License.  
You may obtain a copy of the License at
./java.examples/anagrams/nbproject/genfiles.properties:#   
http://www.apache.org/licenses/LICENSE-2.0
./java.examples/anagrams/nbproject/genfiles.properties:# software 
distributed under the License is distributed on an
./java.examples/anagrams/nbproject/genfiles.properties:# KIND, either 
express or implied.  See the License for the
./java.examples/anagrams/nbproject/genfiles.properties:# under the License.
./nbi/engine/nbproject/genfiles.properties:# Licensed to the Apache 
Software Foundation (ASF) under one
./nbi/engine/nbproject/genfiles.properties:# or more contributor license 
agreements.  See the NOTICE file
./nbi/engine/nbproject/genfiles.properties:# regarding copyright ownership. 
 The ASF licenses this file
./nbi/engine/nbproject/genfiles.properties:# to you under the Apache 
License, Version 2.0 (the
./nbi/engine/nbproject/genfiles.properties:# "License"); you may not use 
this file except in compliance
./nbi/engine/nbproject/genfiles.properties:# with the License.  You may 
obtain a copy of the License at
./nbi/engine/nbproject/genfiles.properties:#   
http://www.apache.org/licenses/LICENSE-2.0
./nbi/engine/nbproject/genfiles.properties:# software distributed under the 
License is distributed on an
./nbi/engine/nbproject/genfiles.properties:# KIND, either express or 
implied.  See the License for the
./nbi/engine/nbproject/genfiles.properties:# under the License.

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
Licensed to the Apache Software Foundation (ASF) under one

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
or more contributor license agreements.  See the NOTICE file

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
regarding copyright ownership.  The ASF licenses this file

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
to you under the Apache License, Version 2.0 (the

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
"License"); you may not use this file except in compliance

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
with the License.  You may obtain a copy of the License at

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
  http://www.apache.org/licenses/LICENSE-2.0

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
software distributed under the License is distributed on an

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
KIND, either express or implied.  See the License for the

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/jfx-impl.xml:
under the License.

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml:
Licensed to the Apache Software Foundation (ASF) under one

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml:
or more contributor license agreements.  See the NOTICE file

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml:
regarding copyright ownership.  The ASF licenses this file

./debugger.jpda.ui/test/qa-functional/data/debugTestProject/nbproject/build-impl.xml:
to you under the Apache License, Version 2.0 (the

[GitHub] incubator-netbeans issue #32: [NETBEANS-54] Module Review server

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/32
  
Thank you - I merged the changes into master with 2 positive reviews. I 
suggest, that you include the full name into the author field, user names look 
strange.

The merge can be found here: 
https://github.com/apache/incubator-netbeans/commit/9a152a75f50f53219b3b2669b6ab9e69a9beb1d7

Please close this PR yourself.


---

Re: Grep CDDL (was Re: PR #46)

[Matthias Bläsing]

Hey,

Am Dienstag, den 03.10.2017, 13:34 +0200 schrieb Antonio:
> 
> On 03/10/17 12:59, Antonio wrote:
> > 
> > I'll investigate the grep operation on CDDL and will post here with
> > my 
> > findings.
> > 
> 
> It seems ant-rat is not able to do this.
> 
> Anyway one can quickly find CDDL files with
>   grep -R CDDL --exclude-dir build
> 
> Or adding
> 
>  
>  
>  
>  
>  
> 
> to nbbuild/build.xml and then running ant grep-cddl
> 
> This is Linux specific (and should run in OS/X as well).
> 
> Want another PR with this?

I would not add greps for CDDL to the build scripts. Before adding the
excludes I suggest to cleanup the files that would be ignored and make
sure these are clean. Reintroductions via PRs need to be prevented by
the authors/committers.

Greetings

Matthias

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/31
  
Oh - and no reason for apologies! The work is appreciated.


---

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/31
  
The problem is that you added the license headers, that conflicted with the 
central change the @jlahoda kindly did (fixing a great many files). Now your 
changeset removes these headers again. On github you can see in the "Files 
changed" section what would happen if your PR is merged and in this case the 
correct headers are removed for form files.

So:
- please rebase your changes onto master
- please revert your changes to the form files
- please also revert the change to genfiles.properties (See: 
https://github.com/apache/incubator-netbeans/pull/46/commits/40a715ad91e47696a8018c48c7ad091b9c4341ec)
 as that is a generated file

The rest looks good. The whitespace changes in build.xml are the removal of 
trailing spaces, which I think is ok.


---

Grep CDDL (was Re: PR #46)

[Antonio]

On 03/10/17 12:59, Antonio wrote:


I'll investigate the grep operation on CDDL and will post here with my 
findings.




It seems ant-rat is not able to do this.

Anyway one can quickly find CDDL files with
grep -R CDDL --exclude-dir build

Or adding







to nbbuild/build.xml and then running ant grep-cddl

This is Linux specific (and should run in OS/X as well).

Want another PR with this?

Cheers,
Antonio

[GitHub] incubator-netbeans pull request #49: [NETBEANS-54] Add license header to bin...

[matthiasblaesing]

GitHub user matthiasblaesing opened a pull request:

https://github.com/apache/incubator-netbeans/pull/49

[NETBEANS-54] Add license header to binaries-list

Add Apache License header to binaries-list.

Excluded from this commit are:

- db.sql.visualeditor
- libs.felix
- libs.jna
- libs.jna.platform

For these PRs are open, that already add a license header.

Apart from the license adding/adaption, there are a few whitespace changes, 
where the file did not contain a final newline.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matthiasblaesing/incubator-netbeans 
binaries-list

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit f44b0c89e18eb7c4b9d19a924e0fd1344763c3c8
Author: Matthias Bläsing 
Date:   2017-10-03T11:13:11Z

[NETBEANS-54] Add license header to binaries-list

Add Apache License header to binaries-list.

Excluded from this commit are:

- db.sql.visualeditor
- libs.felix
- libs.jna
- libs.jna.platform

For these PRs are open, that already add a license header.




---

[GitHub] incubator-netbeans pull request #47: [NETBEANS-54] Module Review c.jcraft.js...

[junichi11]

GitHub user junichi11 opened a pull request:

https://github.com/apache/incubator-netbeans/pull/47

[NETBEANS-54] Module Review c.jcraft.jsch

- external library jsch-0.1.54.jar: BSD-jsch-variant. Maven coordinates 
added.
- checked Rat report: everything has been relicensed to Apache, included in 
'central problems' list above, or excluded via Rat
- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/junichi11/incubator-netbeans 
module-review-c.jcraft.jsch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #47


commit 2b8ce27c354e86ecec967b9d368b5f49b9d97d5f
Author: Junichi Yamamoto 
Date:   2017-10-03T09:40:47Z

[NETBEANS-54] Module Review c.jcraft.jsch

- external library jsch-0.1.54.jar: BSD-jsch-variant. Maven coordinates 
added.
- checked Rat report: everything has been relicensed to Apache, included in 
'central problems' list above, or excluded via Rat
- skimmed through the module, did not notice additional problems




---

[GitHub] incubator-netbeans pull request #48: [NETBEANS-54] Module Review c.jcraft.jz...

[junichi11]

GitHub user junichi11 opened a pull request:

https://github.com/apache/incubator-netbeans/pull/48

[NETBEANS-54] Module Review c.jcraft.jzlib

- external library jzlib-1.0.7.jar: BSD-jzlib-variant. Maven coordinates 
added.
- checked Rat report: everything has been relicensed to Apache, included in 
'central problems' list above, or excluded via Rat
- skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/junichi11/incubator-netbeans 
module-review-c.jcraft.jzlib

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #48


commit 8245e69e073caeebf61099fd6c98f16232565386
Author: Junichi Yamamoto 
Date:   2017-10-03T11:03:06Z

[NETBEANS-54] Module Review c.jcraft.jzlib

- external library jzlib-1.0.7.jar: BSD-jzlib-variant. Maven coordinates 
added.
- checked Rat report: everything has been relicensed to Apache, included in 
'central problems' list above, or excluded via Rat
- skimmed through the module, did not notice additional problems




---

PR #46 (was Re: Want a PR? (was Re: nbproject/*-impl.xml and genfiles.properties))

[Antonio]

On 03/10/17 12:18, Jan Lahoda wrote:

On Tue, Oct 3, 2017 at 11:51 AM, Antonio  wrote:

I've added '**/nbproject/*-impl.xml' and '**/nbproject/genfiles.properties'
to the rat exclusion list. (Note: **/nbproject/, so that affects qa-test
projects as well, and not */nbproject that only affects the module).



I personally would probably be more strict and and exclude specifically
**/nbproject/build-impl.xml and **/nbproject/jfx-impl.xml. Would it be
possible to grep the excluded files for word "CDDL", to be sure there's no
forgotten license header in them? Using ** seems OK to me.



See PR #46 https://github.com/apache/incubator-netbeans/pull/46
with the new patterns for exclusion.

I'll investigate the grep operation on CDDL and will post here with my 
findings.


Cheers,
Antonio

[GitHub] incubator-netbeans pull request #46: Updating the rat exclusion list

[vieiro]

GitHub user vieiro opened a pull request:

https://github.com/apache/incubator-netbeans/pull/46

Updating the rat exclusion list

Now excluding the following automatically generated files from the rat 
report:
- **/nbproject/build-impl.xml
- **/nbproject/jfx-impl.xml
- **/nbproject/genfiles.properties

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vieiro/incubator-netbeans 
netbeans-54-module-review-nbbuild

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #46


commit 40a715ad91e47696a8018c48c7ad091b9c4341ec
Author: Antonio Vieiro 
Date:   2017-10-03T10:45:10Z

Updating the rat exclusion list
Now excluding the following automatically generated files from the rat 
report:
- **/nbproject/build-impl.xml
- **/nbproject/jfx-impl.xml
- **/nbproject/genfiles.properties




---

[GitHub] incubator-netbeans pull request #45: [NETBEANS-54] Module Review masterfs.ui

[rtaneja1]

GitHub user rtaneja1 opened a pull request:

https://github.com/apache/incubator-netbeans/pull/45

[NETBEANS-54] Module Review masterfs.ui

Added Apache license header in bundle.properties

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rtaneja1/incubator-netbeans license-fixes-0310

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #45


commit 6db1eac14042c5305781ca66d0d86ba55a38e6a2
Author: Reema Taneja 
Date:   2017-10-03T10:46:19Z

[NETBEANS-54] Module Review masterfs.ui




---

Re: Want a PR? (was Re: nbproject/*-impl.xml and genfiles.properties)

[Jan Lahoda]

On Tue, Oct 3, 2017 at 11:51 AM, Antonio  wrote:

> On 03/10/17 11:09, Jaroslav Tulach wrote:
>
>> Hello Antonio,
>> thanks for your help.
>>
>
> My pleasure.
>
> I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and
>>> nbproject/genfiles.properties.
>>>
>>> These are automatically generated in the IDE so,
>>>
>>> - Should I remove them from git?
>>>
>>
>> No, add them to the rat tool exclude list.
>>
>
> Done.
>
> I've added '**/nbproject/*-impl.xml' and '**/nbproject/genfiles.properties'
> to the rat exclusion list. (Note: **/nbproject/, so that affects qa-test
> projects as well, and not */nbproject that only affects the module).
>

I personally would probably be more strict and and exclude specifically
**/nbproject/build-impl.xml and **/nbproject/jfx-impl.xml. Would it be
possible to grep the excluded files for word "CDDL", to be sure there's no
forgotten license header in them? Using ** seems OK to me.


>
> Shall I submit a pull request with these?
>

Yes please. Thanks for your help,
Jan


>
>
>> Problems to be solved centrally
>>>  build.xml, build-impl.xml, project.properties, genfiles.properties,
>>>
>>
>> I would suggest to add licenses to build.xml and project.properties - e.g.
>> those that aren't generated.
>>
>
> Of course.
>

[GitHub] incubator-netbeans issue #41: [NETBEANS-54] Module Review c.google.guava

[matthiasblaesing]

Github user matthiasblaesing commented on the issue:

https://github.com/apache/incubator-netbeans/pull/41
  
For me this looks good - thanks for taking care!


---

Re: nbproject/*-impl.xml and genfiles.properties

[Antonio]

Problems to be solved centrally

build.xml, build-impl.xml, project.properties, genfiles.properties,

D'oh! Sorry

On 03/10/17 08:57, Antonio wrote:

Hi all,

I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and 
nbproject/genfiles.properties.


These are automatically generated in the IDE so,

- I'm not adding license headers to these.
- Should I remove them from git?

Thanks,
Antonio

[GitHub] incubator-netbeans pull request #42: [NETBEANS-54] Module Review editor

[vieiro]

GitHub user vieiro opened a pull request:

https://github.com/apache/incubator-netbeans/pull/42

[NETBEANS-54] Module Review editor

- No external libraries.
- Checked Rat report: added license to project files. Did NOT add license 
to editor/demosrc/README nor to the rest of test files.
- Unit tests org.netbeans.editor.PlainDocumentCompatibilityRandomTest and 
org.netbeans.modules.editor.NbEditorToolBarTest fail (but they were also 
failing before this PR).
- QA Tests should be run.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vieiro/incubator-netbeans 
netbeans-54-module-review-editor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-netbeans/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #42


commit 6f7d84fb96fc8e64bf0a0efcca09feeabd6d92d8
Author: Antonio Vieiro 
Date:   2017-10-03T07:14:10Z

[NETBEANS-54] Module Review editor

- No external libraries.
- Checked Rat report: added license to project files. Did NOT add license 
to editor/demosrc/README nor to the rest of test files.
- Unit tests org.netbeans.editor.PlainDocumentCompatibilityRandomTest and 
org.netbeans.modules.editor.NbEditorToolBarTest fail (but they were also 
failing before this PR).
- QA Tests should be run.




---

nbproject/*-impl.xml and genfiles.properties

[Antonio]

Hi all,

I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and 
nbproject/genfiles.properties.


These are automatically generated in the IDE so,

- I'm not adding license headers to these.
- Should I remove them from git?

Thanks,
Antonio