Re: Compiling OFBiz without warning
Hi Jacques,
I have removed some redundant cast warming but if you set all the warning on
eclipse to warning where they are ignore you will get many others.
So we have to decide if we would like to remove all the warning or simply the
ones intercepted by the build.
In your patch was missing this one:
Index: macros.xml
===
--- macros.xml (revision 1081059)
+++ macros.xml (working copy)
@@ -73,9 +73,7 @@
presetdef name=javac16
default-javac compiler=javac1.6 target=1.6 source=1.6
encoding=UTF-8 sourcepathref=src-path includeantruntime=false
- !--
- compilerarg value=-Xlint:unchecked/
- --
+ compilerarg value=-Xlint/
/default-javac
/presetdef
I could say that I could fix some of them when I will get the time but I did
not know when :-)
Thanks
Marco
Il giorno 13/mar/2011, alle ore 01.38, Jacques Le Roux ha scritto:
Sorry wrong patch (no webui component by default, I test it from OFBIZ-3877)
Here is the right patch
Index: applications/order/build.xml
===
--- applications/order/build.xml (revision 1081022)
+++ applications/order/build.xml (working copy)
@@ -59,6 +59,7 @@
javac16
!-- exclude the payment processor packages; comment if you have
libs --
exclude name=org/ofbiz/order/thirdparty/taxware/**/
+ compilerarg value=-Xlint/
/javac16
/target
Index: common.xml
===
--- common.xml (revision 1081022)
+++ common.xml (working copy)
@@ -90,7 +90,9 @@
!-- == --
target name=classes depends=prepare
-javac16/
+javac16
+compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/base/build.xml
===
--- framework/base/build.xml (revision 1081022)
+++ framework/base/build.xml (working copy)
@@ -87,7 +87,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/bi/build.xml
===
--- framework/bi/build.xml (revision 1081022)
+++ framework/bi/build.xml (working copy)
@@ -46,6 +46,8 @@
!-- == --
target name=classes depends=prepare
-javac16 classpathref=local.class.path/
+javac16 classpathref=local.class.path
+compilerarg value=-Xlint/
+/javac16
/target
/project
Index: framework/sql/build.xml
===
--- framework/sql/build.xml (revision 1081022)
+++ framework/sql/build.xml (working copy)
@@ -61,7 +61,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/start/build.xml
===
--- framework/start/build.xml (revision 1081022)
+++ framework/start/build.xml (working copy)
@@ -34,7 +34,10 @@
target name=classes depends=prepare
!-- compile start --
-javac16 destdir=${build.dir}/classes srcdir=${src.dir}/
+javac16 destdir=${build.dir}/classes srcdir=${src.dir}
+compilerarg value=-Xlint/
+/javac16
+
/target
target name=jar depends=classes
Index: specialpurpose/shark/build.xml
===
--- specialpurpose/shark/build.xml (revision 1081022)
+++ specialpurpose/shark/build.xml (working copy)
@@ -55,6 +55,7 @@
target name=classes depends=prepare
javac16
src path=${src.dir}/
+compilerarg value=-Xlint/
/javac16
/target
BTW there are some interseting things, like wrong libs names:
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\commons-io-1.3.1.jar: no such file
or directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\commons-logging-1.0.4.jar: no such
file or directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\fop-hyph.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\serializer-2.7.0.jar: no such file
or directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\servlet-2.2.jar: no such file or
directory
[javac16] warning: [path] bad path element
Call for Participation for ApacheCon Now Open
https://blogs.apache.org/conferences/entry/call_for_participation_apachecon_north Jacopo
Re: Compiling OFBiz without warning
From: Jacques Le Roux jacques.le.r...@les7arts.com
BTW there are some interseting things, like wrong libs names:
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\commons-io-1.3.1.jar: no such file or
directory
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\commons-logging-1.0.4.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\fop-hyph.jar: no such file or
directory
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\serializer-2.7.0.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\servlet-2.2.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\xalan-2.7.0.jar: no such file or
directory
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\xercesImpl-2.7.1.jar: no such file or
directory
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\xml-apis-1.3.04.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\activation.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\xml-apis.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\xercesImpl.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\serializer.jar: no such file or
directory
Jacques
Eventually this is very mysterious to me. For instance
* commons-io-1.3.1.jar exists but in lib/commons and I don't find anything referring to it
* commons-logging-1.0.4.jar does not exist but I don't find anything referring
to it
* serializer-2.7.0.jar does not exist but I don't find anything referring to
it. And serializer-2.9.1.jar exists
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
Hi Marco,
I have tried the following patch locally and I get a lot of warnings.
Index: applications/order/build.xml
===
--- applications/order/build.xml (revision 1081008)
+++ applications/order/build.xml (working copy)
@@ -59,6 +59,7 @@
javac16
!-- exclude the payment processor packages; comment if you have libs
--
exclude name=org/ofbiz/order/thirdparty/taxware/**/
+ compilerarg value=-Xlint/
/javac16
/target
Index: common.xml
===
--- common.xml (revision 1081008)
+++ common.xml (working copy)
@@ -90,7 +90,9 @@
!-- == --
target name=classes depends=prepare
-javac16/
+javac16
+compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/base/build.xml
===
--- framework/base/build.xml (revision 1081008)
+++ framework/base/build.xml (working copy)
@@ -87,7 +87,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/bi/build.xml
===
--- framework/bi/build.xml (revision 1081008)
+++ framework/bi/build.xml (working copy)
@@ -46,6 +46,8 @@
!-- == --
target name=classes depends=prepare
-javac16 classpathref=local.class.path/
+javac16 classpathref=local.class.path
+compilerarg value=-Xlint/
+/javac16
/target
/project
Index: framework/sql/build.xml
===
--- framework/sql/build.xml (revision 1081008)
+++ framework/sql/build.xml (working copy)
@@ -61,7 +61,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/start/build.xml
===
--- framework/start/build.xml (revision 1081008)
+++ framework/start/build.xml (working copy)
@@ -34,7 +34,10 @@
target name=classes depends=prepare
!-- compile start --
-javac16 destdir=${build.dir}/classes srcdir=${src.dir}/
+javac16 destdir=${build.dir}/classes srcdir=${src.dir}
+compilerarg value=-Xlint/
+/javac16
+
/target
target name=jar depends=classes
Index: specialpurpose/build.xml
===
---
Re: Compiling OFBiz without warning
Yes, it's strange also to me, it's necessary to dig it something more. Anyone having some suggestion on it ? Thanks Marco Il giorno 13/mar/2011, alle ore 11.17, Jacques Le Roux ha scritto: From: Jacques Le Roux jacques.le.r...@les7arts.com BTW there are some interseting things, like wrong libs names: [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\commons-io-1.3.1.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\commons-logging-1.0.4.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\fop-hyph.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\serializer-2.7.0.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\servlet-2.2.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\xalan-2.7.0.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\xercesImpl-2.7.1.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\xml-apis-1.3.04.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\activation.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\xml-apis.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\xercesImpl.jar: no such file or directory [javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\serializer.jar: no such file or directory Jacques Eventually this is very mysterious to me. For instance * commons-io-1.3.1.jar exists but in lib/commons and I don't find anything referring to it * commons-logging-1.0.4.jar does not exist but I don't find anything referring to it * serializer-2.7.0.jar does not exist but I don't find anything referring to it. And serializer-2.9.1.jar exists Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com Hi Marco, I have tried the following patch locally and I get a lot of warnings. Index: applications/order/build.xml === --- applications/order/build.xml (revision 1081008) +++ applications/order/build.xml (working copy) @@ -59,6 +59,7 @@ javac16 !-- exclude the payment processor packages; comment if you have libs -- exclude name=org/ofbiz/order/thirdparty/taxware/**/ + compilerarg value=-Xlint/ /javac16 /target Index: common.xml === --- common.xml (revision 1081008) +++ common.xml (working copy) @@ -90,7 +90,9 @@ !-- == -- target name=classes depends=prepare -javac16/ +javac16 +compilerarg value=-Xlint/ +/javac16 /target target name=jar depends=classes Index: framework/base/build.xml === --- framework/base/build.xml (revision 1081008) +++ framework/base/build.xml (working copy) @@ -87,7 +87,9 @@ /target target name=classes depends=prepare,gen-src -javac16/ +javac16 + compilerarg value=-Xlint/ +/javac16 /target target name=jar depends=classes Index: framework/bi/build.xml === --- framework/bi/build.xml (revision 1081008) +++ framework/bi/build.xml (working copy) @@ -46,6 +46,8 @@ !-- == -- target name=classes depends=prepare -javac16 classpathref=local.class.path/ +javac16 classpathref=local.class.path +compilerarg value=-Xlint/ +/javac16 /target /project Index: framework/sql/build.xml === --- framework/sql/build.xml (revision 1081008) +++ framework/sql/build.xml (working copy) @@ -61,7 +61,9 @@ /target target name=classes depends=prepare,gen-src -javac16/ +javac16 + compilerarg value=-Xlint/ +/javac16 /target target name=jar depends=classes Index: framework/start/build.xml === --- framework/start/build.xml (revision 1081008) +++ framework/start/build.xml (working copy) @@ -34,7 +34,10 @@ target name=classes depends=prepare !-- compile start -- -javac16
Re: Compiling OFBiz without warning
Hi Marco,
My idea is to use compilerarg value=-Xlint/ (thanks for the miss), so I'd say I don't care about Eclipse, if some want to fix
them, perfect, else simply forget about those warnings
I will wait to commit that we remove most, if not all, of the warning messages
in order to not
Jacques
From: risali...@gmail.com
Hi Jacques,
I have removed some redundant cast warming but if you set all the warning on eclipse to warning where they are ignore you will get
many others.
So we have to decide if we would like to remove all the warning or simply the
ones intercepted by the build.
In your patch was missing this one:
Index: macros.xml
===
--- macros.xml (revision 1081059)
+++ macros.xml (working copy)
@@ -73,9 +73,7 @@
presetdef name=javac16
default-javac compiler=javac1.6 target=1.6 source=1.6 encoding=UTF-8 sourcepathref=src-path
includeantruntime=false
- !--
- compilerarg value=-Xlint:unchecked/
- --
+ compilerarg value=-Xlint/
/default-javac
/presetdef
I could say that I could fix some of them when I will get the time but I did
not know when :-)
Thanks
Marco
Il giorno 13/mar/2011, alle ore 01.38, Jacques Le Roux ha scritto:
Sorry wrong patch (no webui component by default, I test it from OFBIZ-3877)
Here is the right patch
Index: applications/order/build.xml
===
--- applications/order/build.xml (revision 1081022)
+++ applications/order/build.xml (working copy)
@@ -59,6 +59,7 @@
javac16
!-- exclude the payment processor packages; comment if you have libs
--
exclude name=org/ofbiz/order/thirdparty/taxware/**/
+ compilerarg value=-Xlint/
/javac16
/target
Index: common.xml
===
--- common.xml (revision 1081022)
+++ common.xml (working copy)
@@ -90,7 +90,9 @@
!-- == --
target name=classes depends=prepare
-javac16/
+javac16
+compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/base/build.xml
===
--- framework/base/build.xml (revision 1081022)
+++ framework/base/build.xml (working copy)
@@ -87,7 +87,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/bi/build.xml
===
--- framework/bi/build.xml (revision 1081022)
+++ framework/bi/build.xml (working copy)
@@ -46,6 +46,8 @@
!-- == --
target name=classes depends=prepare
-javac16 classpathref=local.class.path/
+javac16 classpathref=local.class.path
+compilerarg value=-Xlint/
+/javac16
/target
/project
Index: framework/sql/build.xml
===
--- framework/sql/build.xml (revision 1081022)
+++ framework/sql/build.xml (working copy)
@@ -61,7 +61,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/start/build.xml
===
--- framework/start/build.xml (revision 1081022)
+++ framework/start/build.xml (working copy)
@@ -34,7 +34,10 @@
target name=classes depends=prepare
!-- compile start --
-javac16 destdir=${build.dir}/classes srcdir=${src.dir}/
+javac16 destdir=${build.dir}/classes srcdir=${src.dir}
+compilerarg value=-Xlint/
+/javac16
+
/target
target name=jar depends=classes
Index: specialpurpose/shark/build.xml
===
--- specialpurpose/shark/build.xml (revision 1081022)
+++ specialpurpose/shark/build.xml (working copy)
@@ -55,6 +55,7 @@
target name=classes depends=prepare
javac16
src path=${src.dir}/
+compilerarg value=-Xlint/
/javac16
/target
BTW there are some interseting things, like wrong libs names:
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\commons-io-1.3.1.jar: no such file or
directory
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\commons-logging-1.0.4.jar: no such file or
directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\fop-hyph.jar: no such file or
directory
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\serializer-2.7.0.jar: no such file or
Re: Compiling OFBiz without warning
+1
Thanks
Marco
Il giorno 13/mar/2011, alle ore 11.31, Jacques Le Roux ha scritto:
Hi Marco,
My idea is to use compilerarg value=-Xlint/ (thanks for the miss), so
I'd say I don't care about Eclipse, if some want to fix them, perfect, else
simply forget about those warnings
I will wait to commit that we remove most, if not all, of the warning
messages in order to not
Jacques
From: risali...@gmail.com
Hi Jacques,
I have removed some redundant cast warming but if you set all the warning on
eclipse to warning where they are ignore you will get many others.
So we have to decide if we would like to remove all the warning or simply
the ones intercepted by the build.
In your patch was missing this one:
Index: macros.xml
===
--- macros.xml (revision 1081059)
+++ macros.xml (working copy)
@@ -73,9 +73,7 @@
presetdef name=javac16
default-javac compiler=javac1.6 target=1.6 source=1.6
encoding=UTF-8 sourcepathref=src-path includeantruntime=false
- !--
- compilerarg value=-Xlint:unchecked/
- --
+ compilerarg value=-Xlint/
/default-javac
/presetdef
I could say that I could fix some of them when I will get the time but I did
not know when :-)
Thanks
Marco
Il giorno 13/mar/2011, alle ore 01.38, Jacques Le Roux ha scritto:
Sorry wrong patch (no webui component by default, I test it from
OFBIZ-3877)
Here is the right patch
Index: applications/order/build.xml
===
--- applications/order/build.xml (revision 1081022)
+++ applications/order/build.xml (working copy)
@@ -59,6 +59,7 @@
javac16
!-- exclude the payment processor packages; comment if you have
libs --
exclude name=org/ofbiz/order/thirdparty/taxware/**/
+ compilerarg value=-Xlint/
/javac16
/target
Index: common.xml
===
--- common.xml (revision 1081022)
+++ common.xml (working copy)
@@ -90,7 +90,9 @@
!-- ==
--
target name=classes depends=prepare
-javac16/
+javac16
+compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/base/build.xml
===
--- framework/base/build.xml (revision 1081022)
+++ framework/base/build.xml (working copy)
@@ -87,7 +87,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/bi/build.xml
===
--- framework/bi/build.xml (revision 1081022)
+++ framework/bi/build.xml (working copy)
@@ -46,6 +46,8 @@
!-- ==
--
target name=classes depends=prepare
-javac16 classpathref=local.class.path/
+javac16 classpathref=local.class.path
+compilerarg value=-Xlint/
+/javac16
/target
/project
Index: framework/sql/build.xml
===
--- framework/sql/build.xml (revision 1081022)
+++ framework/sql/build.xml (working copy)
@@ -61,7 +61,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/start/build.xml
===
--- framework/start/build.xml (revision 1081022)
+++ framework/start/build.xml (working copy)
@@ -34,7 +34,10 @@
target name=classes depends=prepare
!-- compile start --
-javac16 destdir=${build.dir}/classes srcdir=${src.dir}/
+javac16 destdir=${build.dir}/classes srcdir=${src.dir}
+compilerarg value=-Xlint/
+/javac16
+
/target
target name=jar depends=classes
Index: specialpurpose/shark/build.xml
===
--- specialpurpose/shark/build.xml (revision 1081022)
+++ specialpurpose/shark/build.xml (working copy)
@@ -55,6 +55,7 @@
target name=classes depends=prepare
javac16
src path=${src.dir}/
+compilerarg value=-Xlint/
/javac16
/target
BTW there are some interseting things, like wrong libs names:
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\commons-io-1.3.1.jar: no such
file or directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\commons-logging-1.0.4.jar: no
such file or directory
[javac16] warning: [path] bad path
[jira] Created: (OFBIZ-4213) Add compilerarg value=-Xlint/ to all build targets
Add compilerarg value=-Xlint/ to all build targets -- Key: OFBIZ-4213 URL: https://issues.apache.org/jira/browse/OFBIZ-4213 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial THe idea is to use compilerarg value=-Xlint/ and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them I will wait to commit that we remove most, if not all, of the warning messages in order to not fill the compile log -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-4213) Add compilerarg value=-Xlint/ to all build targets
[ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4213: --- Description: THe idea is to use compilerarg value=-Xlint/ and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them was: THe idea is to use compilerarg value=-Xlint/ and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them I will wait to commit that we remove most, if not all, of the warning messages in order to not fill the compile log Add compilerarg value=-Xlint/ to all build targets -- Key: OFBIZ-4213 URL: https://issues.apache.org/jira/browse/OFBIZ-4213 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial THe idea is to use compilerarg value=-Xlint/ and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-4213) Add compilerarg value=-Xlint/ to all build targets
[ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4213: --- Attachment: OFBIZ-4213_Add compilerarg value=-Xlint.patch Add compilerarg value=-Xlint/ to all build targets -- Key: OFBIZ-4213 URL: https://issues.apache.org/jira/browse/OFBIZ-4213 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch THe idea is to use compilerarg value=-Xlint/ and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-2761) Add inventory items used for the task
[ https://issues.apache.org/jira/browse/OFBIZ-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006177#comment-13006177 ] Jacques Le Roux commented on OFBIZ-2761: Hi Aswath, Did you get a chance to look at it, should we keep this open? Thanks Add inventory items used for the task - Key: OFBIZ-2761 URL: https://issues.apache.org/jira/browse/OFBIZ-2761 Project: OFBiz Issue Type: Sub-task Reporter: Aswath Satrasala Assignee: Jacques Le Roux Attachments: taskinventory.patch, taskinventory.patch During the course of executing a project, some inventory can be used to execute the project. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4213) Add compilerarg value=-Xlint/ to all build targets
[ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006191#comment-13006191 ] Jacques Le Roux commented on OFBIZ-4213: Thanks to Marco's continued hard work, at r1081104 it's already pretty clean. We just have now to understand why we get the [javac16] warning: [path] bad path element file_name: no such file or directory This is very mysterious to me. For instance * commons-io-1.3.1.jar exists but in lib/commons and I don't find anything referring to it * commons-logging-1.0.4.jar does not exist but I don't find anything referring to it * serializer-2.7.0.jar does not exist but I don't find anything referring to it. And serializer-2.9.1.jar exists Add compilerarg value=-Xlint/ to all build targets -- Key: OFBIZ-4213 URL: https://issues.apache.org/jira/browse/OFBIZ-4213 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch THe idea is to use compilerarg value=-Xlint/ and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4014) i18n from DateTime display fields
[
https://issues.apache.org/jira/browse/OFBIZ-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006193#comment-13006193
]
Jacques Le Roux commented on OFBIZ-4014:
Hi Sascha,
I did not test yet, but why did you remove the line?
set field=localeFileNameComplete type=String value=${groovy:
localeFileNameComplete.replace('_', '-')}/ !-- those files are build this
way OOTB (ie a - not a _ between language and country --
i18n from DateTime display fields
--
Key: OFBIZ-4014
URL: https://issues.apache.org/jira/browse/OFBIZ-4014
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
Fix For: SVN trunk
Attachments: OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch,
OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch, OFBIZ-4014_dateJs.zip,
OFBIZ-4014_i18nTimepicker.patch,
OFBIZ-4014_i18nTimepicker_And_DateTimeField.patch
Hi everybody,
i did a little improvement in the display form fields from type date and
date-time.
In the past the timestamps where read from the DB and the string was simply
cut, that didn't match with (i.e.) German date pattern. I changed this
substring stuff and used the locale and timezone with the dateFormatter to
create a i18n date string.
This patch works for: display type=date / and display type=date-time /
Hope that helps.
Have a nice day
Sascha
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4213) Add compilerarg value=-Xlint/ to all build targets
[
https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006203#comment-13006203
]
Marco Risaliti commented on OFBIZ-4213:
---
Hi Jacques,
I have seen that it's due to the element Class-path inside the manifest.mf fo
the jars.
For example inside barcode4j-fop-ext-complete-2.0.jar there is the manifest.jar
with the element Class-path set to ${manifest-classpath}.
So we could avoid it without insert those jar specified in the manifest.mf but
I having no more times to dig it.
Thanks
Marco
Add compilerarg value=-Xlint/ to all build targets
--
Key: OFBIZ-4213
URL: https://issues.apache.org/jira/browse/OFBIZ-4213
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Trivial
Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch
THe idea is to use compilerarg value=-Xlint/ and to not care about
Eclipse, if some want to fix warning messages there, perfect, else we will
simply forget about them
I will wait to commit that we remove most, if not all, of the warning
messages in order to not clutter the compile log with them
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-4213) Add compilerarg value=-Xlint/ to all build targets
[ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4213: --- Attachment: OFBIZ-4213_Add compilerarg value=-Xlint.patch Actually we need to use compilerarg value=-Xlint/ only in the macros.xml file Add compilerarg value=-Xlint/ to all build targets -- Key: OFBIZ-4213 URL: https://issues.apache.org/jira/browse/OFBIZ-4213 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch, OFBIZ-4213_Add compilerarg value=-Xlint.patch THe idea is to use compilerarg value=-Xlint/ and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-4213) Add compilerarg value=-Xlint/ to all build targets
[ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4213. -- Resolution: Fixed Fix Version/s: SVN trunk ok -Xlint:-path was the solution, committed at r1081138 No one using javac16 will escape from warnings now :) I mean even in hot-deploy (if they follow best practices and use create-component) Add compilerarg value=-Xlint/ to all build targets -- Key: OFBIZ-4213 URL: https://issues.apache.org/jira/browse/OFBIZ-4213 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch, OFBIZ-4213_Add compilerarg value=-Xlint.patch THe idea is to use compilerarg value=-Xlint/ and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-4014) i18n from DateTime display fields
[ https://issues.apache.org/jira/browse/OFBIZ-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006219#comment-13006219 ] Jacques Le Roux commented on OFBIZ-4014: Sascha, Could you update your patch please, I can't apply it patching file framework/example/widget/example/FormWidgetExampleForms.xml patching file framework/common/widget/CommonScreens.xml patch: malformed patch at line 32: Index: framework/widget/templates/htmlFormMacroLibrary.ftl i18n from DateTime display fields -- Key: OFBIZ-4014 URL: https://issues.apache.org/jira/browse/OFBIZ-4014 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Sascha Rodekamp Fix For: SVN trunk Attachments: OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch, OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch, OFBIZ-4014_dateJs.zip, OFBIZ-4014_i18nTimepicker.patch, OFBIZ-4014_i18nTimepicker_And_DateTimeField.patch Hi everybody, i did a little improvement in the display form fields from type date and date-time. In the past the timestamps where read from the DB and the string was simply cut, that didn't match with (i.e.) German date pattern. I changed this substring stuff and used the locale and timezone with the dateFormatter to create a i18n date string. This patch works for: display type=date / and display type=date-time / Hope that helps. Have a nice day Sascha -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1063625 - /ofbiz/trunk/applications/product/webapp/catalog/category/CategoryTree.ftl
Hi Hans,
Is there an issue to do this?
Thanks
Jacques
Scott Gray wrote:
Hi Hans
Would you please consider moving the inline css out to the relevant theme
stylesheets?
Many thanks
Scott
HotWax Media
http://www.hotwaxmedia.com
On 26/01/2011, at 8:53 PM, hans...@apache.org wrote:
Author: hansbak
Date: Wed Jan 26 07:53:07 2011
New Revision: 1063625
URL: http://svn.apache.org/viewvc?rev=1063625view=rev
Log:
In the catalog/category tree use differentl logo's for catalog and category and
show names and id's. request from jacques
Modified:
ofbiz/trunk/applications/product/webapp/catalog/category/CategoryTree.ftl
Modified:
ofbiz/trunk/applications/product/webapp/catalog/category/CategoryTree.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/category/CategoryTree.ftl?rev=1063625r1=1063624r2=1063625view=diff
==
[snip]
@@ -122,3 +130,15 @@ var rawdata = [
/script
div id=tree/div
+style type=text/css
+.jstree-default a
+{
+white-space:normal !important;
+height: auto;
+}
+.jstree-default .jstree-leaf ins
+{
+background-position:-36px 0;
+vertical-align: top;
+}
+/style
smime.p7s
Description: S/MIME cryptographic signature
Re: Cleanup Ant if task
I have not looked into details, this has been committed by Adam
http://markmail.org/message/wnioayvhpqoo6p6u
Could you please enlighten us Adam?
Thanks
Jacques
René Scheibe wrote:
Some time ago the Ant if task implementation was replaced by another
one using a Javascript version.
I was wondering why this is named If-ant.py and not If-ant.js?
The scriptdef of this if task in macros.xml could also be cleaned.
scriptdef name=if language=javascript
classpathref=rhino.class.path loaderref=rhino.class.path.loader
src=./If-ant.py
element name=condition
classname=org.apache.tools.ant.taskdefs.condition.And/
element name=commands
classname=org.apache.tools.ant.taskdefs.Sequential/
element name=else
classname=org.apache.tools.ant.taskdefs.Sequential/
/scriptdef
The referenced loaderref rhino.class.path.loader is defined nowhere.
The referenced rhino.class.path references a Rhino jar file
(${ofbiz.home.dir}/extension/rhino/lib/js-1.7.R1.jar) which is not
existing. There is no extension folder at all in trunk.
If the classpathref and loaderref is removed, the if task is still
working as they are optional. So it looks like a Javascript engine is
included somewhere else.
If also have found framework/base/ant-scripts/if-script.groovy and it
looks like this is not used either.
I would anyway suggest to use ant-contrib which also includes an if task.
See: http://ant-contrib.sourceforge.net/tasks/tasks/if.html
Regards
René Scheibe
Revision 894330
From the Rev 894330 commit log: [OFBIZ-3274] - Using decorator sections to control the left-bar The leftbar content is now defined using the left-column ApplicationDecorator section instead of setting the variables leftbarScreenName, leftbarScreenLocation and MainColumnStyle. The logic that checks if the left-column section has content, and thus if a left column must be rendered, has been moved from the GlobalDecorator to the ApplicationDecorator. Why was the logic moved to the ApplicationDecorator? Because of that change, applications developed in a framework-only deployment do not render correctly because the necessary containers are missing. From my perspective, that change was not necessary - the logic should have stayed in the GlobalDecorator. -Adrian
[jira] Updated: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image
[
https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric de Maulde updated OFBIZ-4212:
--
Attachment: ScaleImage.patch
Here is a new patch to scale main image product content and additional image
product content, works with both image filename format (catalog.properties) to
upload an image.
Old image file system :
image.filename.format=${location}/${type}/${id}
image.filename.additionalviewsize.format=${location}/${id}/${viewtype}/${sizetype}
New image file system
image.filename.format=${location}/${id}/${type}
image.filename.additionalviewsize.format=${location}/${id}/${viewtype}/${sizetype}
I always have an error when I upgrade an additional image.
Right url is now only into the DataResource entity !!!
Old image file name format causes an error scaling updated an original image
Key: OFBIZ-4212
URL: https://issues.apache.org/jira/browse/OFBIZ-4212
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: SVN trunk
Environment: trunk 1080218
Reporter: Eric de Maulde
Priority: Minor
Fix For: SVN trunk
Attachments: ScaleImage.patch, ScaleImage.patch
Original Estimate: 0h
Remaining Estimate: 0h
To scale image into Product Content with the old catalog.properties
configuration, FilenameToUse is wrong with the new issue about Image
Management https://issues.apache.org/jira/browse/OFBIZ-4194
image.filename.format=${location}/${type}/${id}
image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Compiling OFBiz without warning
https://issues.apache.org/jira/browse/OFBIZ-4213
From: risali...@gmail.com
+1
Thanks
Marco
Il giorno 13/mar/2011, alle ore 11.31, Jacques Le Roux ha scritto:
Hi Marco,
My idea is to use compilerarg value=-Xlint/ (thanks for the miss), so I'd say I don't care about Eclipse, if some want to
fix them, perfect, else simply forget about those warnings
I will wait to commit that we remove most, if not all, of the warning messages
in order to not
Jacques
From: risali...@gmail.com
Hi Jacques,
I have removed some redundant cast warming but if you set all the warning on eclipse to warning where they are ignore you will
get many others.
So we have to decide if we would like to remove all the warning or simply the
ones intercepted by the build.
In your patch was missing this one:
Index: macros.xml
===
--- macros.xml (revision 1081059)
+++ macros.xml (working copy)
@@ -73,9 +73,7 @@
presetdef name=javac16
default-javac compiler=javac1.6 target=1.6 source=1.6 encoding=UTF-8 sourcepathref=src-path
includeantruntime=false
- !--
- compilerarg value=-Xlint:unchecked/
- --
+ compilerarg value=-Xlint/
/default-javac
/presetdef
I could say that I could fix some of them when I will get the time but I did
not know when :-)
Thanks
Marco
Il giorno 13/mar/2011, alle ore 01.38, Jacques Le Roux ha scritto:
Sorry wrong patch (no webui component by default, I test it from OFBIZ-3877)
Here is the right patch
Index: applications/order/build.xml
===
--- applications/order/build.xml (revision 1081022)
+++ applications/order/build.xml (working copy)
@@ -59,6 +59,7 @@
javac16
!-- exclude the payment processor packages; comment if you have libs
--
exclude name=org/ofbiz/order/thirdparty/taxware/**/
+ compilerarg value=-Xlint/
/javac16
/target
Index: common.xml
===
--- common.xml (revision 1081022)
+++ common.xml (working copy)
@@ -90,7 +90,9 @@
!-- == --
target name=classes depends=prepare
-javac16/
+javac16
+compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/base/build.xml
===
--- framework/base/build.xml (revision 1081022)
+++ framework/base/build.xml (working copy)
@@ -87,7 +87,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/bi/build.xml
===
--- framework/bi/build.xml (revision 1081022)
+++ framework/bi/build.xml (working copy)
@@ -46,6 +46,8 @@
!-- == --
target name=classes depends=prepare
-javac16 classpathref=local.class.path/
+javac16 classpathref=local.class.path
+compilerarg value=-Xlint/
+/javac16
/target
/project
Index: framework/sql/build.xml
===
--- framework/sql/build.xml (revision 1081022)
+++ framework/sql/build.xml (working copy)
@@ -61,7 +61,9 @@
/target
target name=classes depends=prepare,gen-src
-javac16/
+javac16
+ compilerarg value=-Xlint/
+/javac16
/target
target name=jar depends=classes
Index: framework/start/build.xml
===
--- framework/start/build.xml (revision 1081022)
+++ framework/start/build.xml (working copy)
@@ -34,7 +34,10 @@
target name=classes depends=prepare
!-- compile start --
-javac16 destdir=${build.dir}/classes srcdir=${src.dir}/
+javac16 destdir=${build.dir}/classes srcdir=${src.dir}
+compilerarg value=-Xlint/
+/javac16
+
/target
target name=jar depends=classes
Index: specialpurpose/shark/build.xml
===
--- specialpurpose/shark/build.xml (revision 1081022)
+++ specialpurpose/shark/build.xml (working copy)
@@ -55,6 +55,7 @@
target name=classes depends=prepare
javac16
src path=${src.dir}/
+compilerarg value=-Xlint/
/javac16
/target
BTW there are some interseting things, like wrong libs names:
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\commons-io-1.3.1.jar: no such file or
directory
[javac16] warning: [path] bad path element D:\workspace\ofbizDev\framework\base\lib\commons-logging-1.0.4.jar: no such file
or directory
[javac16] warning: [path] bad path element
D:\workspace\ofbizDev\framework\base\lib\fop-hyph.jar: no such file or
Differences between old image product content and new image management
Hi, I've notice several missed features from the new image magenement. I haven't seen : _ original image saving (where a functionality able to automatically resize all images if the webmaster decide by eg. to modify the large size) _ non-automatic resizing into configured small/medium/large/detail dimensions from an upload (it's an easy system to display efficient image for an e-commerce web site, to optimize image weight) I think small/medium/large/detail are more flexible than 100 X 75 / 150 X 112 / ... because if a webmaster want to modify a dimension, he has to modify too the dimension name with the new system ??? _ where can I go to the image content (by eg. to write an attribute ...) _ the link between product and image (I have to write each time the product id) _ the session between tabs doesn't work ??? _ ... So until the image magement works well, I advice to implement the following patch : https://issues.apache.org/jira/browse/OFBIZ-4212 Thanks Eric de Maulde
[jira] Resolved: (OFBIZ-4102) Remove most of the java compilation warning (generics markup, unused code/import)
[ https://issues.apache.org/jira/browse/OFBIZ-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti resolved OFBIZ-4102. --- Resolution: Fixed Thanks to Jacques has completed this work with issue OFBIZ-4213. So now this issue can be closed. Feel free to remove the others warning no so important. Marco Remove most of the java compilation warning (generics markup, unused code/import) - Key: OFBIZ-4102 URL: https://issues.apache.org/jira/browse/OFBIZ-4102 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Actually there are more than 5700 java compilation warning due to generics markup, unused code/import, deprecated methos, ... I will start to change some of that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-4102) Remove most of the java compilation warning (generics markup, unused code/import)
[ https://issues.apache.org/jira/browse/OFBIZ-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti closed OFBIZ-4102. - Remove most of the java compilation warning (generics markup, unused code/import) - Key: OFBIZ-4102 URL: https://issues.apache.org/jira/browse/OFBIZ-4102 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Actually there are more than 5700 java compilation warning due to generics markup, unused code/import, deprecated methos, ... I will start to change some of that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Revision 894330
Hi Adrian, when I did this change I supposed that left-column where only something related to applications. The global decorator only had visibility of a pre-body and a body section. The main purpose of the change was to get rid of the several variables and use the decorator feature. But I agree with you, at least I cannot remember of a particular reason for not having the logic in the GlobalDecorator. -Bruno 2011/3/13 Adrian Crum adrian.c...@sandglass-software.com From the Rev 894330 commit log: [OFBIZ-3274] - Using decorator sections to control the left-bar The leftbar content is now defined using the left-column ApplicationDecorator section instead of setting the variables leftbarScreenName, leftbarScreenLocation and MainColumnStyle. The logic that checks if the left-column section has content, and thus if a left column must be rendered, has been moved from the GlobalDecorator to the ApplicationDecorator. Why was the logic moved to the ApplicationDecorator? Because of that change, applications developed in a framework-only deployment do not render correctly because the necessary containers are missing. From my perspective, that change was not necessary - the logic should have stayed in the GlobalDecorator. -Adrian
Re: Revision 894330
Ideally, the multi-column layout would be handled by the applications needing it - not by the decorator. But it has been that way for too long to change it now. A framework-only deployment can have applications too - the Example and Web Tools components are examples. Would you be willing to move the logic to the GlobalDecorator, or should I do that myself? -Adrian On 3/13/2011 12:05 PM, Bruno Busco wrote: Hi Adrian, when I did this change I supposed that left-column where only something related to applications. The global decorator only had visibility of a pre-body and a body section. The main purpose of the change was to get rid of the several variables and use the decorator feature. But I agree with you, at least I cannot remember of a particular reason for not having the logic in the GlobalDecorator. -Bruno 2011/3/13 Adrian Crumadrian.c...@sandglass-software.com From the Rev 894330 commit log: [OFBIZ-3274] - Using decorator sections to control the left-bar The leftbar content is now defined using the left-column ApplicationDecorator section instead of setting the variables leftbarScreenName, leftbarScreenLocation and MainColumnStyle. The logic that checks if the left-column section has content, and thus if a left column must be rendered, has been moved from the GlobalDecorator to the ApplicationDecorator. Why was the logic moved to the ApplicationDecorator? Because of that change, applications developed in a framework-only deployment do not render correctly because the necessary containers are missing. From my perspective, that change was not necessary - the logic should have stayed in the GlobalDecorator. -Adrian
