[jira] [Closed] (OFBIZ-4228) Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form widget is not working) fixed
[ https://issues.apache.org/jira/browse/OFBIZ-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4228. -- Resolution: Fixed Fix Version/s: Release Branch 10.04 Assignee: Jacques Le Roux Thanks Leon, I thought about the xsd, but bypassed your search, well spotted! Your patch is in trunk at r1084855, I have applied it also to R10.04 at r1084856. Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form widget is not working) fixed Key: OFBIZ-4228 URL: https://issues.apache.org/jira/browse/OFBIZ-4228 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Leon Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: ordermgrLookupScreensParm0.patch In https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a bug in fieldlookup.js which caused Lookup target-parameter in form widget is not working。 Now the form widget framework behaves same as widget-form.xsd specifies: using parameters.parmI (where I is the position number in the target-parameter list) in the related lookup screen. The position number in the list begins from 1. That implictes parm0 is invalid. So I search the whole project to look up whether there's parm0 left out. That's what this patch for. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml
[ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010594#comment-13010594 ] Saroj Khamlue commented on OFBIZ-4217: -- I got the error when I chose Original and tried to upload image in product content page. Exception: org.ofbiz.widget.screen.ScreenRenderException Message: Error rendering screen [component://product/widget/catalog/ProductScreens.xml#EditProductContent]: java.lang.IllegalArgumentException: [GenericEntity.set] imgHeight is not a field of Product, must be one of: productId, productTypeId... Scaling image for every size type from ImageProperties.xml -- Key: OFBIZ-4217 URL: https://issues.apache.org/jira/browse/OFBIZ-4217 Project: OFBiz Issue Type: Improvement Components: framework, product, specialpurpose/ecommerce Affects Versions: SVN trunk Environment: trunk 1084574 Reporter: Eric de Maulde Priority: Trivial Fix For: SVN trunk Attachments: ImageProperties.xml, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch With the new image management, there are more predefined image size types to scale an uplaoding image. The webmaster needs flexibility because each web site are different. So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Run-tests can't be used on a server w/out Internet connection
I have nothing against (as it can be easily bypasssed) it but it's worth to be noted that run-tests depends now on download-cobertura, which itself depends on an internet connection. Hence run-tests can't be used on a server w/out Internet connection Jacques
[jira] [Closed] (OFBIZ-4220) Current implementation of UtilCache has a memory leak if maxInMemory is set
[ https://issues.apache.org/jira/browse/OFBIZ-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-4220. - Current implementation of UtilCache has a memory leak if maxInMemory is set --- Key: OFBIZ-4220 URL: https://issues.apache.org/jira/browse/OFBIZ-4220 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: ALL Reporter: Philippe Mouawad Assignee: Erwan de FERRIERES Priority: Critical Labels: CACHE, LEAK, MEMORY Fix For: SVN trunk Attachments: TestMemoryLeak.java, leak.png, patch-4220.patch If maxInMemory is set on caches, then current implementation will leak if many puts are done in cache. We made some load testing and current implementation ends very rapidly in an OutOfMemory. Philippe Mouawad http://www.ubik-ingenierie.com -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4217) Scaling image for every size type from ImageProperties.xml
[ https://issues.apache.org/jira/browse/OFBIZ-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric de Maulde updated OFBIZ-4217: -- Attachment: ScalingImageForEverySizeType.patch Sorry. The previous patch tries to save image dimensions but product entity doesn't contain fields. This patch doesn't try to save image dimensions. Scaling image for every size type from ImageProperties.xml -- Key: OFBIZ-4217 URL: https://issues.apache.org/jira/browse/OFBIZ-4217 Project: OFBiz Issue Type: Improvement Components: framework, product, specialpurpose/ecommerce Affects Versions: SVN trunk Environment: trunk 1084574 Reporter: Eric de Maulde Priority: Trivial Fix For: SVN trunk Attachments: ImageProperties.xml, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch, ScalingImageForEverySizeType.patch With the new image management, there are more predefined image size types to scale an uplaoding image. The webmaster needs flexibility because each web site are different. So, I believe the webmaster needs to customize image size type to automatically scale images to optimized dimensions, according to his constraints. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Run-tests can't be used on a server w/out Internet connection
Hi Jacques: I discovered this last week during a training class I was giving...Unfortunately, I was not hooked up to the Internet so I was not able to demonstrate. IMHO, this should be reverted back to the expected behavior, or alternatively, an option provided to bypass and still run non-network based tests. Regards, Ruth On 3/24/11 2:49 AM, Jacques Le Roux wrote: I have nothing against (as it can be easily bypasssed) it but it's worth to be noted that run-tests depends now on download-cobertura, which itself depends on an internet connection. Hence run-tests can't be used on a server w/out Internet connection Jacques
Re: Run-tests can't be used on a server w/out Internet connection
Le 24/03/2011 12:52, Ruth Hoffman a écrit : Hi Jacques: I discovered this last week during a training class I was giving...Unfortunately, I was not hooked up to the Internet so I was not able to demonstrate. IMHO, this should be reverted back to the expected behavior, or alternatively, an option provided to bypass and still run non-network based tests. Regards, Ruth On 3/24/11 2:49 AM, Jacques Le Roux wrote: I have nothing against (as it can be easily bypasssed) it but it's worth to be noted that run-tests depends now on download-cobertura, which itself depends on an internet connection. Hence run-tests can't be used on a server w/out Internet connection Jacques Hi Ruth, it's really easy to bypass, just remove the download-cobertura call. target name=run-tests depends=download-cobertura, build I have been added this as there was an error in the logs when lauching tests and the lib wasn't found. a solution I see is creating a new ant target, like run-tests-no-internet, or whatever you want which is *not* using cobertura nor test coverage. This has been added in OFBiz in last december (https://fisheye6.atlassian.com/changelog/ofbiz?cs=1050915). I've just added a better description for the ant target. So, waiting for your patch ! Cheers, -- Erwan de FERRIERES www.nereide.biz
[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010663#comment-13010663 ] Jacques Le Roux commented on OFBIZ-4225: Hi Deepak, Thinking more about it I have changed my mine. I will rather revert and use 0 as origin because some custom applications are certainly using it. I noticed you changed also for viewName in R10.04. So it was another mixed problem isn'it? Lookup target-parameter in form widget is not working. -- Key: OFBIZ-4225 URL: https://issues.apache.org/jira/browse/OFBIZ-4225 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Deepak Dixit Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch There is a target-parameter for lookup, Currently its not working. We can test it over at https://localhost:8443/ordermgr/control/request page. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Run-tests can't be used on a server w/out Internet connection
Hi Erwan: Thanks for the info. The addition of Cobertura in-and-of-itself was a big surprise. But then, I guess I only have myself to blame since I don't monitor the mailing lists or the Wiki that closely, and I never saw it coming :-) Sorry to say, the patch will have to wait since I'm not working with 10.x on a regular basis. This was just a one-off request to take a quick peak at some general OFBiz features and I just happen to have a 10.x version up and running at the time. Thanks again. Regards, Ruth On 3/24/11 8:16 AM, Erwan de FERRIERES wrote: Le 24/03/2011 12:52, Ruth Hoffman a écrit : Hi Jacques: I discovered this last week during a training class I was giving...Unfortunately, I was not hooked up to the Internet so I was not able to demonstrate. IMHO, this should be reverted back to the expected behavior, or alternatively, an option provided to bypass and still run non-network based tests. Regards, Ruth On 3/24/11 2:49 AM, Jacques Le Roux wrote: I have nothing against (as it can be easily bypasssed) it but it's worth to be noted that run-tests depends now on download-cobertura, which itself depends on an internet connection. Hence run-tests can't be used on a server w/out Internet connection Jacques Hi Ruth, it's really easy to bypass, just remove the download-cobertura call. target name=run-tests depends=download-cobertura, build I have been added this as there was an error in the logs when lauching tests and the lib wasn't found. a solution I see is creating a new ant target, like run-tests-no-internet, or whatever you want which is *not* using cobertura nor test coverage. This has been added in OFBiz in last december (https://fisheye6.atlassian.com/changelog/ofbiz?cs=1050915). I've just added a better description for the ant target. So, waiting for your patch ! Cheers,
[jira] [Created] (OFBIZ-4229) Exception if a description for an item on main.ftl in accounting is null
Exception if a description for an item on main.ftl in accounting is null Key: OFBIZ-4229 URL: https://issues.apache.org/jira/browse/OFBIZ-4229 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Reporter: Mirko Vogelsmeier Priority: Minor Fix For: Release 4.0 Hi, i recently came across an issue: In the main.ftl of the accounting-module there are a lot of items listed (like paymentMethodTypes, paymentTypes, ...). If one of these items does not have a description defined, an Exception is thrown. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4229) Exception if a description for an item on main.ftl in accounting is null
[ https://issues.apache.org/jira/browse/OFBIZ-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mirko Vogelsmeier updated OFBIZ-4229: - Attachment: JIRA-4229-Fallback-Accounting-main.ftl.patch As a fallback to the description i did add the Id. Like if paymentMethodType.description doesnt exists, it gets the paymentMethodType.paymentMethodTypeId. Greetings, Mirko Exception if a description for an item on main.ftl in accounting is null Key: OFBIZ-4229 URL: https://issues.apache.org/jira/browse/OFBIZ-4229 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Reporter: Mirko Vogelsmeier Priority: Minor Fix For: Release 4.0 Attachments: JIRA-4229-Fallback-Accounting-main.ftl.patch Hi, i recently came across an issue: In the main.ftl of the accounting-module there are a lot of items listed (like paymentMethodTypes, paymentTypes, ...). If one of these items does not have a description defined, an Exception is thrown. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-4230) Invoice items should be sorted
Invoice items should be sorted -- Key: OFBIZ-4230 URL: https://issues.apache.org/jira/browse/OFBIZ-4230 Project: OFBiz Issue Type: Improvement Affects Versions: SVN trunk Reporter: Rene Scheibe Priority: Trivial When creating an invoice via the service createInvoiceForOrderAllItems the order items are currently just fetched from the database without any sorting. This can result in a different sorting of invoice items vs. order items. Or when creating a new invoice due to a changed order the sorting between invoices can be different. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4230) Invoice items should be sorted
[ https://issues.apache.org/jira/browse/OFBIZ-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rene Scheibe updated OFBIZ-4230: Attachment: OFBIZ-4230_sort-invoice-items.patch Added patch that sorts invoice items (in case they are derived from OrderItems) by orderItemSeqId. Invoice items should be sorted -- Key: OFBIZ-4230 URL: https://issues.apache.org/jira/browse/OFBIZ-4230 Project: OFBiz Issue Type: Improvement Affects Versions: SVN trunk Reporter: Rene Scheibe Priority: Trivial Attachments: OFBIZ-4230_sort-invoice-items.patch When creating an invoice via the service createInvoiceForOrderAllItems the order items are currently just fetched from the database without any sorting. This can result in a different sorting of invoice items vs. order items. Or when creating a new invoice due to a changed order the sorting between invoices can be different. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [GSoC] code/test separation
Maybe totally unrelated, but could this help http://code.google.com/a/apache-extras.org/hosting/ ? Jacques From: Erwan de FERRIERES erwan.de-ferrie...@nereide.fr Le 17/03/2011 18:26, Ganath Rathnayaka a écrit : Hi all, Thanks for the links. I will keep in touch with the project. Thanks Ganath P.S. I installed subversion and ant, download the trunk and build it successfully. Hi Ganath, nice start ! Waiting then for your application. Cheers, -- Erwan de FERRIERES www.nereide.biz
Re: svn commit: r1084855 - /ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
Thinking more about it, I have changed my mine. I will rather revert and use 0 as origin because some custom applications are
certainly using it... Waiting Deepkak answer on a (it seems) mixed issue at https://issues.apache.org/jira/browse/OFBIZ-4225 before
going on
Jacques
Author: jleroux
Date: Thu Mar 24 06:36:58 2011
New Revision: 1084855
URL: http://svn.apache.org/viewvc?rev=1084855view=rev
Log:
A patch from Leon Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form widget is not working) fixed
https://issues.apache.org/jira/browse/OFBIZ-4228 - OFBIZ-4228
n https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a bug in fieldlookup.js which caused Lookup
target-parameter in form widget is not working。
Now the form widget framework behaves same as widget-form.xsd specifies: using parameters.parmI (where I is the position number in
the target-parameter list) in the related lookup screen. The position number in the list begins from 1. That implictes parm0
is invalid.
So I searched the whole project to look up whether there's parm0 left out.
That's what this patch for.
Modified:
ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
Modified: ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml?rev=1084855r1=1084854r2=1084855view=diff
==
--- ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml (original)
+++ ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml Thu Mar 24
06:36:58 2011
@@ -137,7 +137,7 @@ under the License.
actions
property-map resource=OrderUiLabels map-name=uiLabelMap
global=true/
set field=title
value=${uiLabelMap.PageTitleLookupCustomerRequestItem}/
-set field=custRequestId from-field=parameters.custRequestId
default-value=${parameters.parm0}/
+set field=custRequestId from-field=parameters.custRequestId
default-value=${parameters.parm1}/
set field=queryString from-field=result.queryString/
set field=viewIndex from-field=parameters.VIEW_INDEX
type=Integer/
set field=viewSize from-field=parameters.VIEW_SIZE type=Integer
default-value=20/
@@ -190,7 +190,7 @@ under the License.
actions
property-map resource=OrderUiLabels map-name=uiLabelMap
global=true/
set field=title
value=${uiLabelMap.PageTitleLookupQuoteItem}/
-set field=quoteId from-field=parameters.quoteId
default-value=${parameters.parm0}/
+set field=quoteId from-field=parameters.quoteId
default-value=${parameters.parm1}/
set field=queryString from-field=result.queryString/
set field=viewIndex from-field=parameters.VIEW_INDEX
type=Integer/
set field=viewSize from-field=parameters.VIEW_SIZE type=Integer
default-value=20/
Go To Market of an EDI application as separate module to an Open Source ERP System: Reminder
Dear, A few weeks ago, I have sent out this mail with the request to complete my survey about an Open Source EDI solution as extra module for an Open Source ERP System. Although some of the addressees completed my survey online (see link in mail hereunder), I am still looking for some extra input. Would you please be so kind to help me? Thanks a lot in advance! Regards, Erik PS: For those who already completed my survey, many thanks! From: Erik De Kuyffer Sent: Wednesday, March 09, 2011 5:00 PM To: Erik De Kuyffer Subject: Go To Market of an EDI application as separate module to an Open Source ERP System Dear Madam, dear Sir, As a student in Applied IT Management at the Hogeschool Gent, I conduct an investigation about a Go To Market of an EDI (Electronic Data Interchange) application as separate module to an Open Source ERP System. Both the electronic exchange of messages, like orders, dispatching advices and invoices (EDI), as the development and use of Open Source ERP systems have evolved significantly the last few years. The goal of my final paper will be to find out whether these two systems can cooperate in order to optimize the exchange of data between companies financially, commercially en technically. I would like to use your expertise to get a better view on the existing market of EDI tools and open source ERP systems, as well as the demand on the market for both tools, used separately or integrated May I therefore ask you to complete the online survey on http://www.thesistools.com/web/?id=178221 to the best of your abilities? It will take you about 5 minutes. I would like to stress that your answers will be treated with discretion and that you will get the possibility to study the results of this survey whenever you like Your help will be greatly appreciated. Thanks a lot in advance! Erik De Kuyffer edek...@gmail.com
Serialized inventory and the ShoppingCart
I may be missing something but it looks like you cannot shop an order for a piece of serialized inventory as part of your shopping cart process. Am I wrong about that? If you have a user walk up with, say, a hard drive or something else with a serial number on it how do you represent that in the cart? Obviously the order doesn't exist yet, but I know that no one else can reserve that inventory (for real) since the user is holding it in their hand. Any thoughts on this one? -- Ean Schuessler, CTO e...@brainfood.com 214-720-0700 x 315 Brainfood, Inc. http://www.brainfood.com
Re: svn commit: r1085137 - /ofbiz/trunk/applications/product/widget/catalog/PriceForms.xml
Well done Erwan, still an effort to have also the right fields ;o)
Jacques
Author: erwan
Date: Thu Mar 24 20:56:22 2011
New Revision: 1085137
URL: http://svn.apache.org/viewvc?rev=1085137view=rev
Log:
Now using the entity-option for drop-downs in the price rules forms. We can
display the entitylabels
Modified:
ofbiz/trunk/applications/product/widget/catalog/PriceForms.xml
Modified: ofbiz/trunk/applications/product/widget/catalog/PriceForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/PriceForms.xml?rev=1085137r1=1085136r2=1085137view=diff
==
--- ofbiz/trunk/applications/product/widget/catalog/PriceForms.xml (original)
+++ ofbiz/trunk/applications/product/widget/catalog/PriceForms.xml Thu Mar 24
20:56:22 2011
@@ -80,12 +80,16 @@
field name=productPriceCondSeqIdhidden//field!-- Users don't need this information there, the screen is already
sufficiently complex! --
field name=inputParamEnumId title=${uiLabelMap.ProductInput}
drop-down allow-empty=false current=selected
-list-options list-name=inputParamEnums key-name=enumId
description=${description}/
+entity-options entity-name=Enumeration description=${description}
key-field-name=enumId
+entity-constraint name=enumTypeId operator=equals
value=PROD_PRICE_IN_PARAM/
+/entity-options
/drop-down
/field
field name=operatorEnumId title=${uiLabelMap.ProductOperator}
drop-down allow-empty=false current=selected
-list-options list-name=condOperEnums key-name=enumId
description=${description}/
+entity-options entity-name=Enumeration description=${description}
key-field-name=enumId
+entity-constraint name=enumTypeId operator=equals
value=PROD_PRICE_COND/
+/entity-options
/drop-down
/field
field use-when=quot;PRIP_QUANTITYquot;.equals(inputParamEnumId) ||
quot;PRIP_LIST_PRICEquot;.equals(inputParamEnumId)
@@ -113,12 +117,16 @@
field name=newdisplay
default-value=${uiLabelMap.ProductPriceRulesNewCond}//field
field name=inputParamEnumId title=${uiLabelMap.ProductInput}
drop-down allow-empty=false
-list-options list-name=inputParamEnums key-name=enumId
description=${description}/
+entity-options entity-name=Enumeration description=${description}
key-field-name=enumId
+entity-constraint name=enumTypeId operator=equals
value=PROD_PRICE_IN_PARAM/
+/entity-options
/drop-down
/field
field name=operatorEnumId title=${uiLabelMap.ProductOperator}
drop-down allow-empty=false
-list-options list-name=condOperEnums key-name=enumId
description=${description}/
+entity-options entity-name=Enumeration description=${description}
key-field-name=enumId
+entity-constraint name=enumTypeId operator=equals
value=PROD_PRICE_COND/
+/entity-options
/drop-down
/field
field name=condValueInput title=${uiLabelMap.ProductValue}text
size=10//field
@@ -153,7 +161,7 @@
field name=newdisplay
default-value=${uiLabelMap.ProductPriceRulesNewAction}//field
field name=productPriceActionTypeId
title=${uiLabelMap.ProductActionType}
drop-down allow-empty=false
-list-options list-name=productPriceActionTypes key-name=productPriceActionTypeId
description=${description}/
+entity-options entity-name=ProductPriceActionType description=${description}
key-field-name=productPriceActionTypeId/
/drop-down
/field
field name=amount title=${uiLabelMap.ProductValue}text//field
Re: Run-tests can't be used on a server w/out Internet connection
I'm still not in favor of cobertura being downloaded automatically due to it's license, even less so if the build actually requires it to be downloaded. Personally, I won't be voting +1 on any releases until it's removed or someone verifies with legal that it's okay. Regards Scott HotWax Media http://www.hotwaxmedia.com On 24/03/2011, at 7:49 PM, Jacques Le Roux wrote: I have nothing against (as it can be easily bypasssed) it but it's worth to be noted that run-tests depends now on download-cobertura, which itself depends on an internet connection. Hence run-tests can't be used on a server w/out Internet connection Jacques smime.p7s Description: S/MIME cryptographic signature
Re: [GSoC] code/test separation
I am sorry Jacques, I didn't get you. Am I start from the wrong end? Ganath
[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011091#comment-13011091 ] Deepak Dixit commented on OFBIZ-4225: - Thanks Jacques for looking into this, But IMP its not working without this fix, because it can't it can't passed the correct value form the lookup/ lookup constructor. I'll cross ones again. And I did not change the view name, I only change the if condition; For 10.04 Earlier it checks for args.lenght 7 for adding target-parameter to parameters. If we check for args.lenght then its 6 and if we add target-parameter then its length is 7 so 7 th is the first target value for lookup. For Trunk: The indexing is wrong for paam, as i test it for https://localhost:8443/ordermgr/control/request , In EditRequest then it get the partyId form parameters.parm1 so I corrected the indexing. IMO it is a bug so we have to fix it and the patch will fix the problem. Please let me know it the fix is wrong and there is some improvement needed in patch. Lookup target-parameter in form widget is not working. -- Key: OFBIZ-4225 URL: https://issues.apache.org/jira/browse/OFBIZ-4225 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Deepak Dixit Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch There is a target-parameter for lookup, Currently its not working. We can test it over at https://localhost:8443/ordermgr/control/request page. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OFBIZ-4225) Lookup target-parameter in form widget is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011091#comment-13011091 ] Deepak Dixit edited comment on OFBIZ-4225 at 3/25/11 4:16 AM: -- Thanks Jacques for looking into this, But IMO its not working without this fix, because it can't it can't passed the correct value form the lookup/ lookup constructor. I'll cross ones again. And I did not change the view name, I only change the if condition; For 10.04 Earlier it checks for args.lenght 7 for adding target-parameter to parameters. If we check for args.lenght then its 6 and if we add target-parameter then its length is 7 so 7 th is the first target value for lookup. For Trunk: The indexing is wrong for paam, as i test it for https://localhost:8443/ordermgr/control/request , In EditRequest then it get the partyId form parameters.parm1 so I corrected the indexing. IMO it is a bug so we have to fix it and the patch will fix the problem. Please let me know it the fix is wrong and there is some improvement needed in patch. was (Author: deepakdixit): Thanks Jacques for looking into this, But IMP its not working without this fix, because it can't it can't passed the correct value form the lookup/ lookup constructor. I'll cross ones again. And I did not change the view name, I only change the if condition; For 10.04 Earlier it checks for args.lenght 7 for adding target-parameter to parameters. If we check for args.lenght then its 6 and if we add target-parameter then its length is 7 so 7 th is the first target value for lookup. For Trunk: The indexing is wrong for paam, as i test it for https://localhost:8443/ordermgr/control/request , In EditRequest then it get the partyId form parameters.parm1 so I corrected the indexing. IMO it is a bug so we have to fix it and the patch will fix the problem. Please let me know it the fix is wrong and there is some improvement needed in patch. Lookup target-parameter in form widget is not working. -- Key: OFBIZ-4225 URL: https://issues.apache.org/jira/browse/OFBIZ-4225 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Deepak Dixit Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch There is a target-parameter for lookup, Currently its not working. We can test it over at https://localhost:8443/ordermgr/control/request page. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4225) Lookup target-parameter in form widget is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011094#comment-13011094 ] Deepak Dixit commented on OFBIZ-4225: - For trunk its correct Jacques, We can start indexing with 0 and then its works fine. Sorry for the confusion. If we using index 0 then we have to fix the LookupPreferredContactMech screen to get parameter with parameters.parm0 instead of parameters.parm1. Lookup target-parameter in form widget is not working. -- Key: OFBIZ-4225 URL: https://issues.apache.org/jira/browse/OFBIZ-4225 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Deepak Dixit Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch There is a target-parameter for lookup, Currently its not working. We can test it over at https://localhost:8443/ordermgr/control/request page. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (OFBIZ-4225) Lookup target-parameter in form widget is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reopened OFBIZ-4225: - Lookup target-parameter in form widget is not working. -- Key: OFBIZ-4225 URL: https://issues.apache.org/jira/browse/OFBIZ-4225 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Deepak Dixit Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch There is a target-parameter for lookup, Currently its not working. We can test it over at https://localhost:8443/ordermgr/control/request page. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OFBIZ-4225) Lookup target-parameter in form widget is not working.
[ https://issues.apache.org/jira/browse/OFBIZ-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit resolved OFBIZ-4225. - Resolution: Fixed Now its working fine, Thanks Jaques and Leon. Lookup target-parameter in form widget is not working. -- Key: OFBIZ-4225 URL: https://issues.apache.org/jira/browse/OFBIZ-4225 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 10.04, SVN trunk Reporter: Deepak Dixit Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: OFBIZ-4225_FOR_BRANCH10.04.patch, OFBIZ-4225_FOR_TRUNK.patch There is a target-parameter for lookup, Currently its not working. We can test it over at https://localhost:8443/ordermgr/control/request page. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4228) Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form widget is not working) fixed
[ https://issues.apache.org/jira/browse/OFBIZ-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011098#comment-13011098 ] Deepak Dixit commented on OFBIZ-4228: - Thanks Leon I missed it, my apologies. Minor related patch after OFBIZ-4225 issue (Lookup target-parameter in form widget is not working) fixed Key: OFBIZ-4228 URL: https://issues.apache.org/jira/browse/OFBIZ-4228 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Leon Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 10.04, SVN trunk Attachments: ordermgrLookupScreensParm0.patch In https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a bug in fieldlookup.js which caused Lookup target-parameter in form widget is not working。 Now the form widget framework behaves same as widget-form.xsd specifies: using parameters.parmI (where I is the position number in the target-parameter list) in the related lookup screen. The position number in the list begins from 1. That implictes parm0 is invalid. So I search the whole project to look up whether there's parm0 left out. That's what this patch for. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1084855 - /ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
Thanks Jaques,
Both ways are fine, We can use either 0 or 1 index.
I have an idea to improve target-parameter functionality and I am working on
it, will open a ticket shortly for the same.
Thanks Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype :- deepakdixit
On Mar 24, 2011, at 6:57 PM, Jacques Le Roux wrote:
Thinking more about it, I have changed my mine. I will rather revert and use
0 as origin because some custom applications are certainly using it...
Waiting Deepkak answer on a (it seems) mixed issue at
https://issues.apache.org/jira/browse/OFBIZ-4225 before going on
Jacques
Author: jleroux
Date: Thu Mar 24 06:36:58 2011
New Revision: 1084855
URL: http://svn.apache.org/viewvc?rev=1084855view=rev
Log:
A patch from Leon Minor related patch after OFBIZ-4225 issue (Lookup
target-parameter in form widget is not working) fixed
https://issues.apache.org/jira/browse/OFBIZ-4228 - OFBIZ-4228
n https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a bug
in fieldlookup.js which caused Lookup target-parameter in form widget is
not working。
Now the form widget framework behaves same as widget-form.xsd specifies:
using parameters.parmI (where I is the position number in the
target-parameter list) in the related lookup screen. The position number
in the list begins from 1. That implictes parm0 is invalid.
So I searched the whole project to look up whether there's parm0 left out.
That's what this patch for.
Modified:
ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
Modified: ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml?rev=1084855r1=1084854r2=1084855view=diff
==
--- ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
(original)
+++ ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml Thu Mar
24 06:36:58 2011
@@ -137,7 +137,7 @@ under the License.
actions
property-map resource=OrderUiLabels map-name=uiLabelMap
global=true/
set field=title
value=${uiLabelMap.PageTitleLookupCustomerRequestItem}/
-set field=custRequestId
from-field=parameters.custRequestId default-value=${parameters.parm0}/
+set field=custRequestId
from-field=parameters.custRequestId default-value=${parameters.parm1}/
set field=queryString from-field=result.queryString/
set field=viewIndex from-field=parameters.VIEW_INDEX
type=Integer/
set field=viewSize from-field=parameters.VIEW_SIZE
type=Integer default-value=20/
@@ -190,7 +190,7 @@ under the License.
actions
property-map resource=OrderUiLabels map-name=uiLabelMap
global=true/
set field=title
value=${uiLabelMap.PageTitleLookupQuoteItem}/
-set field=quoteId from-field=parameters.quoteId
default-value=${parameters.parm0}/
+set field=quoteId from-field=parameters.quoteId
default-value=${parameters.parm1}/
set field=queryString from-field=result.queryString/
set field=viewIndex from-field=parameters.VIEW_INDEX
type=Integer/
set field=viewSize from-field=parameters.VIEW_SIZE
type=Integer default-value=20/
Re: Run-tests can't be used on a server w/out Internet connection
If we do have two tasks, how about run-tests which would revert to the older style without cobertura and would not depend on an Internet connection, and run-tests-with-coverage which would use cobertura and would have the dependency? Better to say what tasks do and what they are, rather than name a task based on a dependency or the lack of one. What do people think? Cheers Paul Foxworthy Erwan de FERRIERES wrote: Le 24/03/2011 12:52, Ruth Hoffman a écrit : gt; Hi Jacques: gt; I discovered this last week during a training class I was gt; giving...Unfortunately, I was not hooked up to the Internet so I was not gt; able to demonstrate. IMHO, this should be reverted back to the expected gt; behavior, or alternatively, an option provided to bypass and still run gt; non-network based tests. gt; gt; Regards, gt; Ruth gt; gt; gt; On 3/24/11 2:49 AM, Jacques Le Roux wrote: gt;gt; I have nothing against (as it can be easily bypasssed) it but it's gt;gt; worth to be noted that run-tests depends now on download-cobertura, gt;gt; which itself depends on an internet connection. Hence run-tests can't gt;gt; be used on a server w/out Internet connection gt;gt; gt;gt; Jacques gt;gt; gt;gt; gt; Hi Ruth, it's really easy to bypass, just remove the download-cobertura call. lt;target name=quot;run-testsquot; depends=quot;download-cobertura, buildquot; I have been added this as there was an error in the logs when lauching tests and the lib wasn't found. a solution I see is creating a new ant target, like run-tests-no-internet, or whatever you want which is *not* using cobertura nor test coverage. This has been added in OFBiz in last december (https://fisheye6.atlassian.com/changelog/ofbiz?cs=1050915). I've just added a better description for the ant target. So, waiting for your patch ! Cheers, -- Erwan de FERRIERES www.nereide.biz -- View this message in context: http://ofbiz.135035.n4.nabble.com/Run-tests-can-t-be-used-on-a-server-w-out-Internet-connection-tp3401867p3404519.html Sent from the OFBiz - Dev mailing list archive at Nabble.com.
