Filtering VCS history (was: Next step to migrate OFBiz from Subversion (SVN) to Git)

[Mathieu Lirzin]

Hello Swapnil and others,

Swapnil M Mane  writes:

> All the essential details are incorporated in this document [1] to help us
> in migrating from SVN to Git.
> Please have a look and let us know your kind thoughts.
>
> [1] https://cwiki.apache.org/confluence/x/Xg-HBg

Regarding the Git migration I would like to know people's opinion
regarding a possible history clean-up which would allow contributors to
have a smaller repository size on their development machine and quicker
initial setup which is nice for newcomers.

To be more precise the framework repository is currently 806 MiB before
compilation which takes around 15 min to download from the Github mirror
on my machine from DSL connection at a 780 KiB/s rate.

My guess is that the repository heavy weight is mainly due to dependency
JARs that were previously committed in the Version Control System (VCS)
before the Gradle migration.  This guess is based on the known fact that
Git doesn't play well with non-text based files and that JARs are binary
Zip files.

As a consequence I would suggest that while actually migrating to Git as
our main VCS we cut the history after the Gradle migration [1] for the
new reference repository and keep previous history in an archive
repository (for historians).

I currently don't know the technical details on how we should precisely
do such thing and what would be the repository size after clean up, but
I am sure the process is well documented somewhere.  Additionally a
similar cleanup could be done for the plugin repository.

What do people think?

[1] https://svn.apache.org/repos/asf/ofbiz/trunk@1752033

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Re: svn commit: r1864215 - in /ofbiz/ofbiz-framework/trunk/applications/party: servicedef/services_upgrade.xml src/main/java/org/apache/ofbiz/party/party/UpgradeServices.java

[Mathieu Lirzin]

Hello Pawan,

pa...@apache.org writes:

> Author: pawan
> Date: Fri Aug  2 10:36:33 2019
> New Revision: 1864215
>
> URL: http://svn.apache.org/viewvc?rev=1864215=rev
> Log:
> [Implemented]: Provide a service for moving data for marital status field 
> (from boolean to enum)
> [OFBIZ-10977]
> Migrate Person's marital status from indicator to enumeration
> Since revision 1858261(27 April 2019) field oldMaritalStatus of Person has 
> been deprecated.
> This service can be used to upgrade existing data of oldMaritalStatus field 
> to the new maritalStatusEnumId
> field of Person Entity.
> [Thanks]: Suraj Khurana for your contribution and Jacques Le Roux for the 
> review.

I don't know if this is intentional or just a misinterpretation but this commit
message doesn't follow the OFBiz commit guidelines [1].

It should have been something like:

--8<---cut here---start->8---
Implemented: Provide a service for moving data for marital status field
(OFBIZ-10977)

Migrate Person's marital status from indicator to enumeration Since revision
1858261(27 April 2019) field oldMaritalStatus of Person has been deprecated.
This service can be used to upgrade existing data of oldMaritalStatus field to
the new maritalStatusEnumId field of Person Entity.

Thanks: Suraj Khurana for your contribution and Jacques Le Roux for the review.
--8<---cut here---end--->8---

Please follow those guidelines next time.

Thanks.

[1] 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Re: [FYI] Old demo crashed, restarted

[Jacques Le Roux]

I had to restart it again today. Right after it started (note he hour: we start the demos at 3 o'clock and old is the last one, so 03:13 is about its 
start) we got this error


2019-08-03 03:13:08,731 |main |GenericDelegator  |E| Failure in storeAll operation: org.ofbiz.entity.GenericDataSourceException: Unable to 
esablish a connection with the database. (Unable to acquire a new connection from the pool). Rolling back transaction.

org.ofbiz.entity.GenericDataSourceException: Unable to esablish a connection 
with the database. (Unable to acquire a new connection from the pool)

I have no idea why. It's working correctly locally, and once the demo is restarted, weird. Maybe a VM config but I doubt, because why now and not some 
days ago? AFAIK the config did not change since.


OK let's see tomorrow  morning...

Jacques

Le 02/08/2019 à 13:55, Jacques Le Roux a écrit :

Hi,

Not sure what happened

Jacques

Re: OFBiz and Camel integration updated

[Girish Vasmatkar]

Thanks Bilgin for taking care of pull request. If everyone is okay with the
changes, I will go ahead and create a ticket for the same to add it as an
ofbiz plugin. Let me know of any issues or concerns anyone may have.

While writing a few test cases for the various camel components (and I am
using CamelTestSupport), it turned out OFBiz test container does not pick
them up because it is still based on inheritance (extending TestCase) and
not on annotation (any class with @Test annotated methods). I will probably
elaborate further in a separate thread, but I feel we need to add support
for considering such classes as part of test suite as well. We are using
JUnit 4 but it is hardly being used except for being available on the
classpath. Using JUnit 4 classes will make sure both mechanisms will be
supported.

Best,
Girish

On Fri, Jul 19, 2019 at 10:12 AM Girish Vasmatkar <
girish.vasmat...@hotwaxsystems.com> wrote:

> Hi Bilgin
>
> I have created a pull request
>  for *ofbiz-camel* component
> with the following additions and fixes. Please review and let me know what
> you think. Post review if you feel it is worth incorporating, we can add it
> as an ofbiz plugin.
> Here's the summary -
>
> 1. Auto discovery of RouteBuilders. Considering possibility of a developer
> wanting to create more than one route, I though of scanning available
> RouteBuilder instances in the classpath and then registering them with
> camel context. I think it should be no issue having one RouteBuilder
> configuring single route, instead of all the routes configured by a single
> RouteBuilder.
> 2. Developer can configure property to specify the package where all
> RouteBuilders are packaged and at container initialization, system would
> try to register all available RouteBuilders.
> 3. Additionally, I have also added a custom annotation (CamelRoute) that a
> class can be annotated with. I have not thought about it's implementation
> for now but this may be added in the future. Since, the same can be
> achieved by discovering RouteBuilders, this may not be needed.
> 4. As a future enhancement, I feel the need to introduce XML DSL to
> configure the routes. I am willing to share the design on this if you feel
> it would be worth a feature.
>
> Please let me know if you have any questions related to the pull request.
>
> Best,
> Girish
>
>
> On Wed, Jun 19, 2019 at 12:14 AM Rishi Solanki 
> wrote:
>
>> Dear Taher,
>> Thanks for your reply, I will soon start discussion on dev list. I just go
>> thru the code developed and basics of Apache Camel, seems it would be very
>> helpful to interact OFBiz with outer world. Work is really appreciated,
>> thanks to Bilgin for doing that.
>>
>> Best Regards,
>> --
>> *Rishi Solanki* | Sr Manager, Enterprise Software Development
>> HotWax Systems 
>> Linkedin: *Rishi Solanki*
>> 
>> Direct: +91-9893287847
>>
>>
>> On Mon, Jun 17, 2019 at 6:09 PM Taher Alkhateeb <
>> slidingfilame...@gmail.com>
>> wrote:
>>
>> > Hopefully the code still works. If yes, I think it would be a good
>> > plugin to add.
>> >
>> > Either way, I think this discussion should perhaps move to the
>> > development mailing list.
>> >
>> > On Mon, Jun 17, 2019 at 1:04 PM Rishi Solanki 
>> > wrote:
>> > >
>> > > Dear Bilgin/Taher,
>> > > I tried to look into the plugins and Jira could not found anything
>> > related.
>> > > Although some discussion is there but I see plugin is not added into
>> > OFBiz
>> > > till now. Can you please share any reference if I missed something?
>> > >
>> > > I see the code in the Bilgin's repo and seems we can take it as ground
>> > and
>> > > test then commit it. If Bilgin allows then extend ofbiz-camel
>> component
>> > to
>> > > next level if possible. And it too late to reply on this thread but I
>> > also
>> > > feel that the plugin should be part of OFBiz repo.
>> > >
>> > > Please suggest if all agree then I can go ahead to create Jira, test,
>> > > enhance and proceed.
>> > >
>> > > Best Regards,
>> > > --
>> > > Rishi Solanki
>> > > Sr Manager, Enterprise Software Development
>> > > *HotWax Systems*
>> > > *Enterprise open source experts*
>> > > cell: +91-98932-87847
>> > > http://www.hotwaxsystems.com
>> > >
>> > > On Thu, Mar 22, 2018 at 4:00 PM Taher Alkhateeb <
>> > slidingfilame...@gmail.com>
>> > > wrote:
>> > >
>> > > > 1- create a JIRA
>> > > > 2- provide a patch or reference to your github repo and get some
>> > feedback
>> > > > 3- commit in $OFBIZ_HOME/plugins/
>> > > >
>> > > > Given that you're the expert in this domain, I doubt you'll get any
>> > > > feedback on the design. However there are a few things which might
>> > > > need changing, for example:
>> > > > - Putting apache 2 license header in files
>> > > > - deleting the data directory given it is empty
>> > > > - moving the documentation to src/docs/asciidoc
>> > > > - removing some