Re: Welcome to Deepak Nigam as new committer!

2019-06-12 Thread Divesh Dutta
Welcome, aboard Deepak.

Thanks
--
Divesh Dutta

On Thu, Jun 13, 2019 at 11:25 AM Deepak Dixit  wrote:

> Welcome, Abroad Deepak Nigam!!
>
> Thanks & Regards
> --
> Deepak Dixit
> ofbiz.apache.org
>
>
> On Thu, Jun 13, 2019 at 11:20 AM Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > The OFBiz PMC has invited Deepak to become a new committer and we are
> > pleased  to announce that he has accepted.
> >
> > Deepak  is part of the community since January 2016 and has proved to be
> > committed since.
> >
> > He notably made a great work for OFBIZ-10518 "Inventory (Supply)
> > Allocation Planning "
> >
> > He not only worked in Jira,  but also answered accurately on MLs where he
> > supported our users.
> >
> > Please join me in welcoming and congratulating Deepak.
> >
> > Jacques
> >
> >
>


Re: Welcome to Pawan Verma as new committer!

2019-06-12 Thread Divesh Dutta
Welcome aboard Pawan.

Thanks
--
Divesh Dutta




On Thu, Jun 13, 2019 at 11:20 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> The OFBiz PMC has invited Pawan to become a new committer and we are
> pleased  to announce that he has accepted.
>
> Pawan is part of the community for 2 years and has being quite active and
> proficient, notably these last times with several smart propositions.
>
> He also helps a lot of Jiras and answers properly on MLs.
>
> Please join me in welcoming and congratulating Pawan.
>
> Jacques
>
>


Re: Welcome to Mathieu Lirzin as new committer!

2019-03-04 Thread Divesh Dutta
Congratulations Mathieu. Welcome aboard.

Thanks
--
Divesh Dutta


On Tue, 26 Feb 2019 at 1:48 AM, Mathieu Lirzin 
wrote:

> Hello,
>
> Taher Alkhateeb  writes:
>
> > The OFBiz PMC has invited Mathieu Lirzin to become a new committer and
> > we are happy to announce that he has accepted this role.
>
> Thanks everybody for the congratulations and welcoming me as a committer
> in this project.
>
> --
> Mathieu Lirzin
> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>


Re: New ASF Member from OFBiz Community

2018-05-07 Thread Divesh Dutta
Congratulations Deepak.


Thanks
--
Divesh Dutta


On Wed, May 2, 2018 at 9:08 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> Hi Everyone,
>
> today the ASF has published the list of newly nominated members and "our"
> Deepak Dixit is one of them:
>
> https://blogs.apache.org/foundation/entry/the-apache-
> software-foundation-welcomes2
> <https://www.google.com/url?q=https://blogs.apache.org/
> foundation/entry/the-apache-software-foundation-welcomes2&
> sa=D&source=hangouts&ust=1525357595561000&usg=
> AFQjCNHXDpgnyJ1wgnbZ06kEPTsbXs9MDQ>
>
> Congratulations Deepak!
>
> Jacopo
>


Re: Welcome Rishi Solanki as a New Committer!

2017-08-09 Thread Divesh Dutta
Congratulations Rishi


Thanks
--
Divesh Dutta

On Wed, Aug 9, 2017 at 3:25 PM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Congratulations Rishi!
>
> Best regards,
> Pranay Pandey
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Wed, Aug 9, 2017 at 2:26 PM, Sharan Foga  wrote:
>
> > The OFBiz PMC has invited Rishi Solanki to become a new committer and are
> > happy to announce that he has accepted.
> >
> > Some of the key factors considered for inviting him were as follows:
> >
> > - He has been involved with the OFBiz project for quite a while which
> > shows dedication and commitment
> > - He has a lot of good knowledge that he is happy to share which shows he
> > is a good team player
> > - His work is consistent, has good code quality and he has provided a
> > range of patches
> > - He is friendly, respectful and keen to help out others in the community
> >
> > Please join me in welcoming and congratulating Rishi!
> >
> > Thanks
> > Sharan
> >
>


Re: Welcome Akash Jain as a New Committer!

2017-08-09 Thread Divesh Dutta
Congratulations Akash.

Thanks
--
Divesh Dutta

On Wed, Aug 9, 2017 at 2:28 PM, Sharan Foga  wrote:

> The OFBiz PMC has invited Akash Jain to become a new committer and are
> happy to announce that he has accepted.
>
> Some of the key factors considered for inviting him were as follows:
>
> - He has been involved with the OFBiz project for quite a while which
> shows his dedication and commitment
> - He has a lot of good knowledge (both functional and technical) that he
> is happy to share which shows he is a good team player
> - He is very active, positive and respectful to others in the community
> - He has contributed patches and shows a willingness to learn which is
> really important as the project continues to go through changes
>
> Please join me in welcoming and congratulating Akash.
>
> Thanks
> Sharan
>


Re: New ASF Members from OFBiz Community

2017-04-04 Thread Divesh Dutta
Many congratulations to Michael, Taher, Anil, Ashish and Bilgin Ibryam for
joining the ASF community.

Thanks
--
Divesh Dutta

On Wed, Apr 5, 2017 at 9:48 AM, Sanjay Yadav  wrote:

> Many congratulations to Michael, Taher, Anil, Ashish and Bilgin Ibryam. :)
>
> Best Regards,
>
>  Sanjay Yadav
>  Manager, Enterprise Quality Assurance
>  HotWax Systems
>  http://www.hotwaxsystems.com/
>
> On Wed, Apr 5, 2017 at 12:32 AM, Sharan Foga  wrote:
>
> > Hi Everyone
> >
> > Wow – we have even more good news! Another three people from our
> community
> > have been invited to become members of the Apache Software Foundation.
> They
> > are Anil Patel, Ashish Vijaywargiya and Bilgin Ibryam
> >
> > Many congratulations Anil, Ashish and Bilgin !!!
> >
> > Thanks
> > Sharan
> >
> > On 2017-04-03 11:06 (+0200), "Sharan Foga" wrote:
> > > Hi Everyone
> > >
> > > Please join me in congratulating Michael Brohl and Taher Alkhateeb as
> > being invited to become members of the Apache Software Foundation.
> > >
> > > Congratulations Michael and Taher!
> > >
> > > Thanks
> > > Sharan
> > >
> > >
> >
>


Re: Welcome James Yong as a new committer

2017-03-14 Thread Divesh Dutta
Congratulations James.


Thanks
--
Divesh Dutta

On Tue, Mar 14, 2017 at 2:26 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> The OFBiz PMC has invited James Yong to become a new committer and we are
> happy to announce that he has accepted.
>
> James has been involved in OFBiz for years providing patches, reporting
> bugs, discussing issues and also providing help and advice to others on the
> mailing lists.
> James has a nice positive attitude and is constructive and community
> oriented and has been active on both the development and user mailing lists
> responding to some quite technical functional questions.
>
> Please join me in welcoming and congratulating James.
>
> Thanks
>
> Jacopo
>


Re: Welcome Swapnil Shah as a New Committer!

2017-02-16 Thread Divesh Dutta
Welcome aboard Swapnil. Looking forward to work with you.


Thanks
--
Divesh Dutta

On Tue, Feb 14, 2017 at 4:30 PM, Sharan Foga  wrote:

> The OFBiz PMC has invited Swapnil Shah to become a new committer and are
> happy to announce that he has accepted.
>
> Swapnil has been involved in OFBiz for a few years and has been active on
> both the development and user mailing lists responding to some quite
> technical functional questions.
>
> Some of the key factors considered for inviting him were as follows:
>
> - He has very good functional knowledge about OFBiz and this is a valuable
> skill that is useful to developers and users
> - He is polite, positive, friendly and collaborative when dealing the
> community discussions on the mailings lists or Jira
> - He has raised Jiras, performed testing on patches and new other
> functionality
> - The PMC would like to see a wide range of people from the community
> (developers and non-developers) recognised for their contributions to the
> project.
>
> Please join me in welcoming and congratulating Swapnil.
>
> Thanks
> Sharan
>


Re: [DISCUSSION] Improving the OFBiz User Interface

2016-12-08 Thread Divesh Dutta
Sounds good Julien. Order process was just an example. I agree with you to
start with other common components.


Thanks
--
Divesh Dutta



On Thu, Dec 8, 2016 at 1:25 PM, Julien NICOLAS 
wrote:

> Hi Divesh,
>
> As a first step, because we have a lot of work before starting UX part, I
> want to use POC to show how the screen structure (for find, entity details
> sheet, etc.) is important.
>
> Nicolas start to create the common-theme and I start to make it blank. The
> theme without theme (with minimal UI) ;)
>
> In that way, we will able to show how will work this structure screens.
> I'll to provide example to explain better my tough (I'll work on it this
> week-end).
>
> Because the order process contain a lot of specific process that will be
> only used by the order process, I think that first components to be migrate
> will probably simple components. It will be faster and easier than the
> order process to show a new modern and UX user interface :)
>
> What do you think ?
>
> Julien.
>
>
>
>
> On 08/12/2016 08:19, Divesh Dutta wrote:
>
>> Very good initiative. I see lots of discussions of technology part. So I
>> will not add on that part. I would like to give some inputs on our
>> approach
>> to make UI/UX of OFBiz better.
>>
>> As Jacopo also suggested to take small step at a time, I would say we
>> start
>> with one use story at a time and then improve UI and UX of that story. For
>> example: "CSR creates a sales order". We overhaul UI and UX of sales order
>> creation work flow and Order over view page. Once this is done, it will be
>> good POC for others to learn how to do UI overhaul. And then others can
>> participate by picking up other user stories . We can also prioritise user
>> stories and components.
>>
>> Besides this , before writing code, we can finalise UI and UX of one
>> workflow by drawing some thing or preparing wireframes. Once we have
>> wireframes finalised, we can start writing code.
>>
>> This will be lot of work to change UI and UX of whole OFBiz and starting
>> one user story at at time is good idea according to me. Having
>> technologies
>> defined is important thing, however defining UX for particular workflow
>> (on
>> paper or via wireframes) is also important.
>>
>> Thanks
>> --
>> Divesh Dutta.
>>
>>
>


Re: [DISCUSSION] Improving the OFBiz User Interface

2016-12-07 Thread Divesh Dutta
Very good initiative. I see lots of discussions of technology part. So I
will not add on that part. I would like to give some inputs on our approach
to make UI/UX of OFBiz better.

As Jacopo also suggested to take small step at a time, I would say we start
with one use story at a time and then improve UI and UX of that story. For
example: "CSR creates a sales order". We overhaul UI and UX of sales order
creation work flow and Order over view page. Once this is done, it will be
good POC for others to learn how to do UI overhaul. And then others can
participate by picking up other user stories . We can also prioritise user
stories and components.

Besides this , before writing code, we can finalise UI and UX of one
workflow by drawing some thing or preparing wireframes. Once we have
wireframes finalised, we can start writing code.

This will be lot of work to change UI and UX of whole OFBiz and starting
one user story at at time is good idea according to me. Having technologies
defined is important thing, however defining UX for particular workflow (on
paper or via wireframes) is also important.

Thanks
--
Divesh Dutta.


Re: [DISCUSSION] Organising OFBiz Events or Meetups

2016-12-07 Thread Divesh Dutta
Hi Sharan,

Thanks for starting this thread. I really liked the idea of doing OFBiz
meet ups or events. Events can be specific to any topic. Few ways we can
organise these events are:

1)  Invite people from business community and help them to understand how
they can use Apache OFBiz for free to run their businesses.

2) Invite developers from student community or freelancers who want to make
their career in ERP development. Experts can train them on how to do
development in OFBiz. In similar meet up of developers, experts can share
some success stories.


India does have many peoples involved in OFBiz project. Definitely, there
is an opportunity to have some events in India.

So idea seems good. We can also share some common resources in our
community, which we can use in these events. For example a good PPT
presentation of Apache OFBiz and how it can help businesses to grow.


Thanks
--
Divesh Dutta.



On Fri, Dec 2, 2016 at 7:16 PM, Sharan Foga  wrote:

> Hi Everyone
>
> Another topic that came up from the discussions in Seville was to look at
> the possibility of organising and running some OFBiz meetups or events.
>
> Meeting up at Apachecon is a great way to strengthen relationships and
> also collaborate. Could we make use of meetups (real and virtual) to bring
> the community together?
>
> Many other ASF projects have meetups but OFBiz doesn't - we tend to meetup
> at Apachecon and that's it. Could we look at organising some meetups,
> hackathons, training etc?  We have a lot of work so the meetups could be a
> way for a group of people to work together on a specific topic. It could
> also be used to do some outreach (recruit new members) as well as providing
> some valuable information / training etc for existing community members.
>
> We have a strong community in Europe – would a separate OFBiz event /
> meetup in Europe work? (or should we continue to use Apachecon?). What
> about the US?
> By the way -  I understand that there is now a focus on getting projects
> to run their 'summits' as part of Apachecon, so this could be something we
> could look at?
>
> I've also heard that there is a large OFBiz community in India -  so could
> this be an option?
>
> Anyway I'd like to find out if there is any interest so please let me have
> your feedback and comments.
>
> Thanks
> Sharan
>


Re: [DISCUSSION] Defining an OFBiz Project Strategy

2016-12-07 Thread Divesh Dutta
Hi all,



This is really a good thread and I see lots of good discussions. I liked
inputs given by Taher to increase the adaptability of OFBiz.  Recently I
met few end users who are looking for Open Source ERP options, however they
are not choosing Apache OFBiz. When I asked Why ? I got few answers which
are inline with Taher's proposals. So my inputs on each of the items based
on User's feedbacks.

Branding:

Many users  start by searching on google. When they search "Open Source
ERP" , they see OFBiz no  where in 1st page of Google. I found it at 3rd
page. Users see Openbravo, Odoo and other options. So definitely branding
is an important thing. We need to improve SEO ranking of OFBiz . Success
stories on various social media platforms etc. This will definitely help
users to adapt OFBiz.


UI redesign:

I also agree with this point. I met many people who are using Odoo or
ERPNext  or Open Bravo. When I asked them why not OFBiz? They say that when
thy tried demo version of OFBiz, they did not like the UI. They said its
very old UI and they could not understand where to start with. And they
concluded that there must be no community work going on and OFBiz project
is now dead. These users I am talking about are not subscribed in dev
mailing list or even on user mailing list. So they don't know what work is
going on. So definitely UI is important thing to consider to increase the
adaptability of project.

Documentation:

No doubt organised documentation always help in adoption of any project.


Fully Restful:

At the same time I like the idea by Scott that we should also work in
making OFBiz fully Restful. Documenting APIs for service will help
developers to adopt the project. I agree that  it will not directly help
end users to adopt the project. However if we document APIs in a good way
and make them completely restful and work towards making OFBiz as Platform
as a Service, it might also attract developers to make their own web or
mobile apps on top of OFBiz. Which might create the buzz and eventually
increase adoption in user community.



Thanks
--
Divesh Dutta.




On Sun, Dec 4, 2016 at 12:25 AM, Taher Alkhateeb  wrote:

> Well said Michael. I fully agree and I make room for others to pitch in :)
>
> On Sat, Dec 3, 2016 at 9:40 PM, Michael Brohl 
> wrote:
>
> > Hi Taher,
> >
> > I have the impression that we are not too far away from each other, we
> > only have to share the resources for the different fields of action in a
> > reasonable way.
> >
> > That makes me confident to be on a good way.
> >
> > It's extremely important to have a good amount of different opinions and
> > experiences thrown in the ring to get a picture for the overall strategy
> so
> > I like to encourage the community members, active or staying in the
> > background to speak up and let us hear their point of view to the further
> > development of OFBiz.
> >
> > Every voice is appreciated.
> >
> > Best regards,
> >
> > Michael
> >
> >
> > Am 03.12.16 um 06:55 schrieb Taher Alkhateeb:
> >
> > Hi Scott,
> >>
> >> Thank you for sharing your thoughts, it's always good to see things
> from a
> >> new perspective.
> >>
> >> If you look at my earlier post, you'll notice that we both agree that
> the
> >> points of strength in OFBiz are the domain model and business logic. It
> is
> >> also an excellent idea to incorporate RESTful calls into the framework
> and
> >> to refactor the services. All excellent suggestions.
> >>
> >> I think where we might differ a bit though is in the assumption that the
> >> UI
> >> is not that important. It would probably get the top priority position
> for
> >> me for the following reasons:
> >>
> >> - There are competing ERP systems out there that are gaining big market
> >> shares because of the appeal of a refined user interface.
> >> - The user interface gets more "end-users" to the community instead of
> >> only
> >> developers and consultants which greatly widens the community and
> >> eco-system. This is the main driver for big adoption in my opinion and I
> >> know people who adopted systems because of this very reason.
> >> - Once these non-technical end-users download the system and like it,
> they
> >> shortly start contacting vendors for customization support. I live in a
> >> very small country and yet one ERP system has two representative
> companies
> >> just because of the appeal of the user interface they have and people
> >> really like their software even though it might be inferior in other
> ways.
> >> - 

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.01

2016-11-22 Thread Divesh Dutta
+1.

Thanks
--
Divesh Dutta.


On Tue, Nov 22, 2016 at 12:21 AM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> This is the vote thread to issue the first release from the branch
> "release16.11".
>
> The name of the new release will be "Apache OFBiz 16.11.01".
>
> The release files can be downloaded from here:
>
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
>
> * apache-ofbiz-16.11.01.zip: the actual release file
>
> * KEYS: file with keys
>
> * apache-ofbiz-16.11.01.zip.asc: the detached signature file
>
> * apache-ofbiz-16.11.01.zip.md5, apache-ofbiz-16.11.01.zip.sha: hashes
>
> Vote:
>
> [ +1] release as Apache OFBiz 16.11.01
>
> [ -1] do not release
>
> This vote will be open for 5 days.
>
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>
> You can download and test the zip file and its signature and hashes (for
> instructions on testing the signature see
> http://www.apache.org/info/verification.html).
>
> Kind Regards,
>
> Jacopo
>


Re: OFBiz Premier League – Reviewers Choice Award

2016-11-11 Thread Divesh Dutta
Pierre,

Instead of taunting, you should understand the bigger cause for what Sharan
is doing it. Overall OPL effort and involving others community members in
it is for bigger cause and sake of OFBiz and its community.


Thanks
--
Divesh Dutta.

On Thu, Nov 10, 2016 at 2:50 PM, Pierre Smits 
wrote:

> Hi Sharan,
>
> Congratulations regarding your new assignment as HotWax spokesperson to the
> OFBiz project.
>
> Best regards
>
> Pierre Smits
>
> ORRTIZ.COM <http://www.orrtiz.com>
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>
> On Wed, Nov 9, 2016 at 11:39 PM, Sharan Foga 
> wrote:
>
> > Hi Everyone
> >
> > (I'm posting this on both user and dev lists).
> >
> > The Hotwax Systems teams desperately need your help! Why? Because their
> > OFBiz Premier League (OPL) competition ended this month. Details can be
> > found at http://opl.ofbiz.us/)
> >
> > Six teams were competing for points to improve OFBiz by contributing
> > ideas, code, documentation, developments and bug fixes. On 5th November
> > 2016 - the 6 month time period ended and now feedback from all the OFBiz
> > Community is needed to choose the team that will receive the 'Reviewers
> > Choice Award'. (Note: The Reviewers are the OFBiz Community :-) )
> >
> > The 6 teams were :
> >
> >  *
> >
> >Team-1 - MV Controller
> >
> >  *
> >
> >Team-2 - OFBiz Fanatics
> >
> >  *
> >
> >Team-3 - OFgrammers
> >
> >  *
> >
> >Team-4 - OS Biz Contributor
> >
> >  *
> >
> >Team-5 - OS Code Breakers
> >
> >  *
> >
> >Team-6 - SO Architects
> >
> > Each team has prepared a report with details of the contributions made
> > over the last 6 months. These reports can be found at the following link:
> >
> > https://drive.google.com/drive/folders/0BxupAk96lggNTm0zT3A2alNRY1k
> >
> > Please take a look at the reports and then assign your rating score for
> > each team. (I've taken a quick preview of the reports already and it's
> > going to be a tough decision!). All the scores will be totalled and the
> > winning team will be the one with the most points. The scores and winner
> > will be announced on the OFBiz mailing lists.
> >
> > *IMPORTANT NOTE*: All the Hotwax team members who are involved with any
> of
> > the OPL teams _*will not*_ participate in the rating or scoring of any of
> > the teams.
> >
> >
> > _*Rate The Teams*_
> >
> > To rate the teams I've setup a short survey (see link) with the name of
> > each team and a sliding scale that you can rate them and their work from
> 1
> > (Poor) to 10 (Excellent).
> >
> > https://www.surveymonkey.com/r/RXW7KVC
> >
> > Anyone from the OFBiz Community can participate in the rating the OPL
> > teams. The survey will be open for the next 7 days and will close on
> 17^th
> > November 2016. The scores will be totalled and hopefully we'll find out
> > which team has won the award.
> >
> > Good luck to all the teams and thanks for all the OFBiz contributions
> that
> > have been made.
> >
> > Thanks
> > Sharan
> >
> >
> >
>


Re: Michael Brohl joins OFBiz PMC

2016-09-06 Thread Divesh Dutta
Congratulations Michael !

Thanks
--
Divesh Dutta.

On Fri, Sep 2, 2016 at 4:06 PM, Sharan Foga  wrote:

> Hi Everyone
>
> Please join me in welcoming Michael Brohl as our newest member of the
> OFBiz PMC.
>
> Congratulations Michael and welcome! :-)
>
> Thanks
> Sharan
>


Re: Feedback on Committer Mentoring and HipChat

2016-08-22 Thread Divesh Dutta
Hi Sharan,

Thanks for starting this thread. In general, I think that setting up
HipChat environment is a good step and it helps to communicate with other
committers and collaborate on common tasks. So in my opinion we can make it
available on permanent basis.

About using it for whole community on community days can be good idea.
However using it in all other days may not be good idea for whole
community. So yes, as you mentioned that discussions and decisions will
still be done on mailing lists. Once we have  some thing concrete to work
upon after discussions on mailing lists and we have volunteers who will be
working together on common task, then they might use HipChat for
collaboration.

+1 for using HipChat on upcoming community day.


Thanks
--
Divesh Dutta.




On Mon, Aug 22, 2016 at 2:12 PM, Sharan Foga  wrote:

> Hi All
>
> A few weeks ago, in response to the results of the Committer Survey, I
> setup a trial Hipchat environment to help with Committer Mentoring.  (See
> links to the previous discussion threads below:)
>
> https://lists.apache.org/thread.html/8b8738c3adcb1b7aafd7c90f9b1cbb
> 54500578d8cd392c3b18d635b9@%3Cdev.ofbiz.apache.org%3E
>
> https://lists.apache.org/thread.html/5b64aad3bbaca967cf432adfd62ce6
> 8901c95218a8aa59d706aed6bc@%3Cdev.ofbiz.apache.org%3E
>
> I really liked the HipChat environment and think that it's a great
> collaborative tool that also helps build community spirit. So now I'd like
> to get some feedback :-)
>
> First of all I'd like to hear from the committers and mentors who
> participated to find out what they thought of the HipChat environment, what
> their general comments are and whether they would like it to be made
> available on a permanent basis.
>
> Secondly I'd like to get some general feedback from everyone to find out
> if the whole community would also be interested in participating in HipChat
> environment (e.g. for collaborating on Jiras, or during our Community
> Days). Other ASF projects have HipChat spaces setup and publish a link that
> anyone can use to join and we could do the same.
>
> The mailing list would still be used for discussions and decisions but if
> people are working together on a particular task then this could be a good
> way to speed up the process.  I'm thinking particularly about things like
> the re-factoring and our Jira backlog where bringing together the reporter
> and the developer could make things move a lot more quickly!)
>
> We have another Community Day coming up in a few weeks on 17th September
> so it could be a good chance to see how it could work in action. What do
> people think?
>
> Thanks
> Sharan
>


Re: Entity and Service definition

2016-07-19 Thread Divesh Dutta
Very good initiative.

Thanks
--
Divesh Dutta .

On Sun, Jul 17, 2016 at 6:00 PM, Rishi Solanki 
wrote:

> Starter effort on this under - OFBIZ-7828. Community review / feedback /
> suggestion / concerns are welcome.
>
> Thanks!
>
> Rishi Solanki
> Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
>
> On Thu, Jul 14, 2016 at 9:58 AM, Rishi Solanki 
> wrote:
>
> > Thank you everyone for your approval and suggestion. We would try to
> > follow most, and log Jira accordingly. Soon will start on this.
> >
> > Nicolas, thanks for pointing expire action on entity-auto.
> >
> > Jacques, Pierre, thanks for suggestion on managing Jira tickets, and you
> > guys anyways helped us in our last effort in managing Jira tickets and
> > review. Thanks for that.
> >
> > Plan is something like this, we would pick the easy entities first where
> > we found minimum changes. After delivering few we will be able to
> establish
> > practice internally, on what items we should take care before fixing an
> > entity/service. We would like to go slow initially, and as soon as we
> start
> > on it delivery process will more clear.
> >
> >
> > Thanks again for your help, and looking forward for same in the big
> effort
> > planned.
> >
> >
> >
> > Rishi Solanki
> > Manager, Enterprise Software Development
> > HotWax Systems Pvt. Ltd.
> > Direct: +91-9893287847
> > http://www.hotwaxsystems.com
> >
> > On Wed, Jul 13, 2016 at 2:36 PM, Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Le 13/07/2016 à 09:39, Pierre Smits a écrit :
> >>
> >>> At this moment in time, I can't fathom how much effort is involved in
> >>> this
> >>> factoring, but I suggest to break it down as much as possible into
> >>> separate
> >>> JIRA issues. For instance, the rework on the removal of the
> >>> OrderHeaderNoteView
> >>> and OrderItemAndShipGroupAssoc from the OrderHeader entity can be a
> >>> separate issue. Please be aware, that this might have a big impact in
> >>> various functions/services/etc.
> >>>
> >>> Best regards,
> >>>
> >>> Pierre Smits
> >>>
> >> That's a good advice Pierre, from what I have seen these last months
> from
> >> the HW effort, I'm confident they are totally aware of what to do :)
> >>
> >> Jacques
> >>
> >>
> >
>


Re: [DISCUSSION] Proposed Task List for Moving Forward with Gradle and the Trunk

2016-07-13 Thread Divesh Dutta
I agree with all the proposals. Also I like the idea of making all the
special purpose components to plugins which will be deactivated by default
and you can active them.

Thanks
--
Divesh Dutta.

On Wed, Jul 13, 2016 at 12:55 PM, Sharan Foga  wrote:

> Hi All
>
> Thanks Taher for your feedback. As I havent had many responses to this
> post and we need to move forward as quickly as possible I'm going to change
> each of these proposals to lazy consensus. This means if you are against
> any of them then please speak up.
>
> If I haven't had any more responses by this time tomorrow – we'll plan to
> go ahead with each of them.
>
> Thanks
> Sharan
>
> On 2016-07-11 20:01 (+0200), Taher Alkhateeb 
> wrote:
> > Hi Sharan and everyone.
> >
> > I propose in complement and summarizing your points the following:
> >
> > 1- deactivate by default all specialpurpose components. Possibly with a
> > convenience task called activateAllPlugins
> > 2- redesign the directory structure to separate main classes from test
> > classes
> > 3- rename the specialpurpose folder to plugins
> >
> > The migration of remote libs is already on its way.
> >
> > Taher Alkhateeb
> > On Jul 11, 2016 7:38 PM, "Sharan-F"  wrote:
> >
> > Hi Everyone
> >
> > Another update on the task list for moving forward with Gradle and the
> > Trunk. We would also like to get community feedback and comments on each
> of
> > the following 3 proposals:
> >
> > Task 1 “Replace all the current jars in OFBiz with appropriate remote
> > libraries from a download repository
> >
> --
> > The work to replace the jars is ongoing and we have already removed 169
> of
> > them. These libraries will now be automatically downloaded by Gradle.
> Work
> > will continue to remove the remaining files. As we are working through,
> we
> > are finding library migration issues with some of the specialpurpose
> > components so would like *to propose to deactivate all specialpurpose
> > components by default.*
> >
> >
> > Task 4. “ Move all java source files to\u2002$component/src/main/java and
> > introduce all unit tests in\u2002\u2002$component/src/test/java”
> >
> -
> > Another area we need to progress is the re-design and changing of the
> > directory structure so that we can separate the Java files between main
> and
> > test. This will help us simplify the implementation of a testing
> framework.
> > *The proposal for the directory structure is as follows:
> >
> >componentname/src/main/java
> >componentname/src/test/java*
> >
> >
> > Task 10. “Propose the renaming specialpurpose to plugins or such an
> > appropriate name for clarity”
> >
> -
> > We would like * to propose changing the name of the specialpurpose
> folder to
> > 'plugins'*
> >
> > These are the 3 areas we would like to progress so please feel free to
> > respond with your feedback and comments.
> >
> > Thanks
> > Sharan
> >
> >
> >
> >
> > --
> > View this message in context:
> >
> http://ofbiz.135035.n4.nabble.com/DISCUSSION-Proposed-Task-List-for-Moving-Forward-with-Gradle-and-the-Trunk-tp4687808p4688257.html
> > Sent from the OFBiz - Dev mailing list archive at Nabble.com.
> >
>


[jira] [Assigned] (OFBIZ-7653) OFBIZ-7649: Display From date with default now() on all screens under Manufacturing Application

2016-07-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7653:
---

Assignee: Divesh Dutta  (was: Swapnil Shah)

> OFBIZ-7649: Display From date with default now() on all screens under 
> Manufacturing Application
> ---
>
> Key: OFBIZ-7653
> URL: https://issues.apache.org/jira/browse/OFBIZ-7653
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7653.patch
>
>
> To begin with we can start fixing it under 
> # https://ofbiz-vm.apache.org:18443/manufacturing/control/CreateProductionRun
> # "Edit Routing Task Association" on 
> https://ofbiz-vm.apache.org:18443/manufacturing/control/EditRoutingTaskAssoc?workEffortId=DEFAULT_ROUTING
> # "Edit Routing-Product Link" over 
> https://ofbiz-vm.apache.org:18443/manufacturing/control/EditRoutingProductLink?workEffortId=DEFAULT_ROUTING
> # "Add Routing Task Costs" over 
> https://ofbiz-vm.apache.org:18443/manufacturing/control/EditRoutingTaskCosts?workEffortId=DEFAULT_TASK
> # "Edit Routing Task Product" over 
> https://ofbiz-vm.apache.org:18443/manufacturing/control/ListRoutingTaskProducts?workEffortId=DEFAULT_TASK
> # https://ofbiz-vm.apache.org:18443/manufacturing/control/EditProductBom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7651) OFBIZ-7649: Display From date with default now() on all screens under Party Application

2016-07-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7651:
---

Assignee: Divesh Dutta

> OFBIZ-7649: Display From date with default now() on all screens under Party 
> Application
> ---
>
> Key: OFBIZ-7651
> URL: https://issues.apache.org/jira/browse/OFBIZ-7651
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7651.patch
>
>
> To begin with let's start fixing it under
> # "Add Party Content" form on 
> https://ofbiz-vm.apache.org:18443/partymgr/control/EditPartyContents?partyId=DemoCustCompany
> # "Edit Product Store Roles" from on 
> https://ofbiz-vm.apache.org:18443/partymgr/control/ViewProductStoreRoles?partyId=DemoCustCompany



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7650) OFBIZ-7649: Display From date with default now() on all screens under Catalog Application

2016-07-05 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7650:
---

Assignee: Divesh Dutta  (was: Ankush Upadhyay)

> OFBIZ-7649: Display From date with default now() on all screens under Catalog 
> Application
> -
>
> Key: OFBIZ-7650
> URL: https://issues.apache.org/jira/browse/OFBIZ-7650
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7650.patch
>
>
> To begin with can start fixing it under :
> # "Add Product Price" form on 
> https://ofbiz-vm.apache.org:18443/catalog/control/EditProductPrices?productId=SV-1000
> # "Add Product Category" form on 
> https://ofbiz-vm.apache.org:18443/catalog/control/EditProductCategories?productId=SV-1000
> # "Add Product Cost Component Calc" form on 
> https://ofbiz-vm.apache.org:18443/catalog/control/EditProductCosts?productId=SV-1000
> # "Add Content to Product" form on 
> https://ofbiz-vm.apache.org:18443/catalog/control/EditProductContent?productId=GZ-1000
> Let's keep on adding other screens where it could be fixed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7512) 'Issue Component' option after partial issuance against required component quantity is not accounting for already issued quantity

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361685#comment-15361685
 ] 

Divesh Dutta commented on OFBIZ-7512:
-

Thanks [~anuj.jain] . Your patch is committed in revision number 1751367 in 
trunk. I will back port the fixes on release branches soon. 

> 'Issue Component' option after partial issuance against required component 
> quantity is not accounting for already issued quantity
> -
>
> Key: OFBIZ-7512
> URL: https://issues.apache.org/jira/browse/OFBIZ-7512
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Release Branch 14.12, 14.12.01, Release Branch 15.12, 
> 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7173.png, OFBIZ-7512.patch
>
>
> Once we issue the required component partially (i.e. by producing partial 
> quantity while task is still is still running or in case full ATP against 
> required quantity is not available for issuance) then "Issue Component" is 
> not honoring the already made issuance and hence issuing the whole required 
> quantity once again. (please refer to attached screenshot)
> !https://issues.apache.org/jira/secure/attachment/12811801/OFBIZ-7173.png|width=800px!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-6576.
-
Resolution: Fixed

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From 

[jira] [Closed] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-6576.
---

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>   Price: 11.9

[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-6576:

Fix Version/s: 15.12.01
   14.12.01

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361674#comment-15361674
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Thanks [~ankush.upadhyay] for your patch and thanks [~paul_foxworthy] for 
reporting this issue . Its committed in revision number 1751362 in trunk. 

release 14.12 - 1751363

release 15.12 - 1751364 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
&g

[jira] [Resolved] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-7518.
-
Resolution: Fixed

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Ankush Upadhyay
>    Assignee: Divesh Dutta
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7518:

Fix Version/s: 15.12.01
   14.12.01

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Ankush Upadhyay
>    Assignee: Divesh Dutta
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7518:

Affects Version/s: (was: Upcoming Branch)
   15.12.01
   14.12.01

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Ankush Upadhyay
>    Assignee: Divesh Dutta
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7518.
---

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Ankush Upadhyay
>    Assignee: Divesh Dutta
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361654#comment-15361654
 ] 

Divesh Dutta commented on OFBIZ-7518:
-

Thanks [~ankush.upadhyay] for your patch and thanks [~soledad] for your 
suggestion. Its committed in revision number 1751357 in trunk. 

release 14.12 - 1751359

release 15.12 - 1751360.  

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7553) On order list page, the 'All' checkbox for status field does not work properly

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7553:

Fix Version/s: Upcoming Branch

> On order list page, the 'All' checkbox for status field does not work properly
> --
>
> Key: OFBIZ-7553
> URL: https://issues.apache.org/jira/browse/OFBIZ-7553
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7553.patch, Screenshot.png
>
>
> Steps to generate:
> 1) Go to order list page.
> 2) For status field, check the 'All' checkbox. This will check all the other 
> status checkboxes.
> 3) Now uncheck any one or more checkbox other than 'All'.
> - Expected: This should uncheck the 'All' checkbox also.
> - Actual: 'All' checkbox remains checked.
> Please see the screenshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7553) On order list page, the 'All' checkbox for status field does not work properly

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7553.
---

> On order list page, the 'All' checkbox for status field does not work properly
> --
>
> Key: OFBIZ-7553
> URL: https://issues.apache.org/jira/browse/OFBIZ-7553
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7553.patch, Screenshot.png
>
>
> Steps to generate:
> 1) Go to order list page.
> 2) For status field, check the 'All' checkbox. This will check all the other 
> status checkboxes.
> 3) Now uncheck any one or more checkbox other than 'All'.
> - Expected: This should uncheck the 'All' checkbox also.
> - Actual: 'All' checkbox remains checked.
> Please see the screenshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7553) On order list page, the 'All' checkbox for status field does not work properly

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361639#comment-15361639
 ] 

Divesh Dutta commented on OFBIZ-7553:
-

Thanks [~Mohammad K] for your patch. Its committed in trunk in revision number 
1751356. 

> On order list page, the 'All' checkbox for status field does not work properly
> --
>
> Key: OFBIZ-7553
> URL: https://issues.apache.org/jira/browse/OFBIZ-7553
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7553.patch, Screenshot.png
>
>
> Steps to generate:
> 1) Go to order list page.
> 2) For status field, check the 'All' checkbox. This will check all the other 
> status checkboxes.
> 3) Now uncheck any one or more checkbox other than 'All'.
> - Expected: This should uncheck the 'All' checkbox also.
> - Actual: 'All' checkbox remains checked.
> Please see the screenshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7553) On order list page, the 'All' checkbox for status field does not work properly

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7553:
---

Assignee: Divesh Dutta  (was: Mohammad Kathawala)

> On order list page, the 'All' checkbox for status field does not work properly
> --
>
> Key: OFBIZ-7553
> URL: https://issues.apache.org/jira/browse/OFBIZ-7553
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7553.patch, Screenshot.png
>
>
> Steps to generate:
> 1) Go to order list page.
> 2) For status field, check the 'All' checkbox. This will check all the other 
> status checkboxes.
> 3) Now uncheck any one or more checkbox other than 'All'.
> - Expected: This should uncheck the 'All' checkbox also.
> - Actual: 'All' checkbox remains checked.
> Please see the screenshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361625#comment-15361625
 ] 

Divesh Dutta commented on OFBIZ-6899:
-

Added new table "Check" under task OFBIZ-7682 . [~Jagpreet Kaur] you may 
continue your work on this ticket now. 

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>    Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7682.
---

> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7682.patch
>
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-7682.
-
Resolution: Fixed

> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7682.patch
>
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361621#comment-15361621
 ] 

Divesh Dutta commented on OFBIZ-7682:
-

 I have added Check table in revision number 1751355 in trunk. Thanks 
[~Jagpreet Kaur] for your patch . Thanks [~pfm.smits] ,  [~jacques.le.roux] and 
[~swash78] for the discussion 

> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7682.patch
>
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7682:
---

Assignee: Divesh Dutta  (was: Jacques Le Roux)

> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7682.patch
>
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7669) SpecialPurpose/ebaystore: Correct all the checkboxes and radio buttons in all the ebaystore FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361613#comment-15361613
 ] 

Divesh Dutta commented on OFBIZ-7669:
-

Thanks [~Mohammad K] for your patch. Its committed in revision number 1751350 
in trunk .

> SpecialPurpose/ebaystore: Correct all the checkboxes and radio buttons in all 
> the ebaystore FTLs.
> -
>
> Key: OFBIZ-7669
> URL: https://issues.apache.org/jira/browse/OFBIZ-7669
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7669.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7669) SpecialPurpose/ebaystore: Correct all the checkboxes and radio buttons in all the ebaystore FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7669.
---

> SpecialPurpose/ebaystore: Correct all the checkboxes and radio buttons in all 
> the ebaystore FTLs.
> -
>
> Key: OFBIZ-7669
> URL: https://issues.apache.org/jira/browse/OFBIZ-7669
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7669.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7668) SpecialPurpose/ebay: Correct all the checkboxes and radio buttons in all the ebay FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361611#comment-15361611
 ] 

Divesh Dutta commented on OFBIZ-7668:
-

Thanks [~Jagpreet Kaur] for your patch. Its in trunk in revision number : 
1751349

> SpecialPurpose/ebay: Correct all the checkboxes and radio buttons in all the 
> ebay FTLs.
> ---
>
> Key: OFBIZ-7668
> URL: https://issues.apache.org/jira/browse/OFBIZ-7668
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7668.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7668) SpecialPurpose/ebay: Correct all the checkboxes and radio buttons in all the ebay FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7668.
---

> SpecialPurpose/ebay: Correct all the checkboxes and radio buttons in all the 
> ebay FTLs.
> ---
>
> Key: OFBIZ-7668
> URL: https://issues.apache.org/jira/browse/OFBIZ-7668
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7668.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7667) Framework/Webtools: Correct all the checkboxes and radio buttons in all the webtools FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7667.
---

> Framework/Webtools: Correct all the checkboxes and radio buttons in all the 
> webtools FTLs.
> --
>
> Key: OFBIZ-7667
> URL: https://issues.apache.org/jira/browse/OFBIZ-7667
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7667.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7667) Framework/Webtools: Correct all the checkboxes and radio buttons in all the webtools FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361607#comment-15361607
 ] 

Divesh Dutta commented on OFBIZ-7667:
-

Thanks [~upadhyay.ratnesh] for your patch. Its in trunk in revision number 
1751348. 

> Framework/Webtools: Correct all the checkboxes and radio buttons in all the 
> webtools FTLs.
> --
>
> Key: OFBIZ-7667
> URL: https://issues.apache.org/jira/browse/OFBIZ-7667
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7667.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7585) Humanares: Correct all the checkboxes and radio buttons in all the humanares FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7585.
---

> Humanares: Correct all the checkboxes and radio buttons in all the humanares 
> FTLs.
> --
>
> Key: OFBIZ-7585
> URL: https://issues.apache.org/jira/browse/OFBIZ-7585
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7585.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7585) Humanares: Correct all the checkboxes and radio buttons in all the humanares FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361603#comment-15361603
 ] 

Divesh Dutta commented on OFBIZ-7585:
-

Thanks [~Mohammad K] for your patch. Its in trunk in revision number 1751347. 

> Humanares: Correct all the checkboxes and radio buttons in all the humanares 
> FTLs.
> --
>
> Key: OFBIZ-7585
> URL: https://issues.apache.org/jira/browse/OFBIZ-7585
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7585.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7584) Workeffort: Correct all the checkboxes and radio buttons in all the workeffort FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361600#comment-15361600
 ] 

Divesh Dutta commented on OFBIZ-7584:
-

Thanks [~Mohammad K] for your patch. Its in revision number 1751346 in trunk. 

> Workeffort: Correct all the checkboxes and radio buttons in all the 
> workeffort FTLs.
> 
>
> Key: OFBIZ-7584
> URL: https://issues.apache.org/jira/browse/OFBIZ-7584
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7584.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7584) Workeffort: Correct all the checkboxes and radio buttons in all the workeffort FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7584.
---

> Workeffort: Correct all the checkboxes and radio buttons in all the 
> workeffort FTLs.
> 
>
> Key: OFBIZ-7584
> URL: https://issues.apache.org/jira/browse/OFBIZ-7584
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7584.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7583) Facility: Correct all the checkboxes and radio buttons in all the facility FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361599#comment-15361599
 ] 

Divesh Dutta commented on OFBIZ-7583:
-

Thanks [~Mohammad K] for your patch . Its in revision number 1751345 in trunk. 

> Facility: Correct all the checkboxes and radio buttons in all the facility 
> FTLs.
> 
>
> Key: OFBIZ-7583
> URL: https://issues.apache.org/jira/browse/OFBIZ-7583
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7583.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7583) Facility: Correct all the checkboxes and radio buttons in all the facility FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7583.
---

> Facility: Correct all the checkboxes and radio buttons in all the facility 
> FTLs.
> 
>
> Key: OFBIZ-7583
> URL: https://issues.apache.org/jira/browse/OFBIZ-7583
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Mohammad Kathawala
>    Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7583.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7583) Facility: Correct all the checkboxes and radio buttons in all the facility FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7583:
---

Assignee: Divesh Dutta  (was: Mohammad Kathawala)

> Facility: Correct all the checkboxes and radio buttons in all the facility 
> FTLs.
> 
>
> Key: OFBIZ-7583
> URL: https://issues.apache.org/jira/browse/OFBIZ-7583
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Mohammad Kathawala
>    Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7583.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7582) Catalog: Correct all the checkboxes and radio buttons in all the catalog FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7582.
---

> Catalog: Correct all the checkboxes and radio buttons in all the catalog FTLs.
> --
>
> Key: OFBIZ-7582
> URL: https://issues.apache.org/jira/browse/OFBIZ-7582
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7582.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7582) Catalog: Correct all the checkboxes and radio buttons in all the catalog FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361597#comment-15361597
 ] 

Divesh Dutta commented on OFBIZ-7582:
-

Thanks [~Mohammad K] for your patch. Its in trunk in revision number 1751344. 

> Catalog: Correct all the checkboxes and radio buttons in all the catalog FTLs.
> --
>
> Key: OFBIZ-7582
> URL: https://issues.apache.org/jira/browse/OFBIZ-7582
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7582.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7582) Catalog: Correct all the checkboxes and radio buttons in all the catalog FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7582:
---

Assignee: Divesh Dutta  (was: Mohammad Kathawala)

> Catalog: Correct all the checkboxes and radio buttons in all the catalog FTLs.
> --
>
> Key: OFBIZ-7582
> URL: https://issues.apache.org/jira/browse/OFBIZ-7582
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7582.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7580) Order: Correct all the checkboxes and radio buttons in all the order FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7580:
---

Assignee: Divesh Dutta  (was: Mohammad Kathawala)

> Order: Correct all the checkboxes and radio buttons in all the order FTLs.
> --
>
> Key: OFBIZ-7580
> URL: https://issues.apache.org/jira/browse/OFBIZ-7580
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7580.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7580) Order: Correct all the checkboxes and radio buttons in all the order FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7580.
---

> Order: Correct all the checkboxes and radio buttons in all the order FTLs.
> --
>
> Key: OFBIZ-7580
> URL: https://issues.apache.org/jira/browse/OFBIZ-7580
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7580.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7580) Order: Correct all the checkboxes and radio buttons in all the order FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361589#comment-15361589
 ] 

Divesh Dutta commented on OFBIZ-7580:
-

Thanks [~Mohammad K] for your patch . Its committed in revision number 1751342 
in trunk. 

> Order: Correct all the checkboxes and radio buttons in all the order FTLs.
> --
>
> Key: OFBIZ-7580
> URL: https://issues.apache.org/jira/browse/OFBIZ-7580
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7580.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7578) Content: Correct all the checkboxes and radio buttons in all the content FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7578:
---

Assignee: Divesh Dutta  (was: Mohammad Kathawala)

> Content: Correct all the checkboxes and radio buttons in all the content FTLs.
> --
>
> Key: OFBIZ-7578
> URL: https://issues.apache.org/jira/browse/OFBIZ-7578
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7578.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7578) Content: Correct all the checkboxes and radio buttons in all the content FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7578.
---

> Content: Correct all the checkboxes and radio buttons in all the content FTLs.
> --
>
> Key: OFBIZ-7578
> URL: https://issues.apache.org/jira/browse/OFBIZ-7578
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7578.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7578) Content: Correct all the checkboxes and radio buttons in all the content FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361583#comment-15361583
 ] 

Divesh Dutta commented on OFBIZ-7578:
-

[~Mohammad K] your patch is committed in revision number 1751341 in trunk. 
Thanks for your contribution. 

> Content: Correct all the checkboxes and radio buttons in all the content FTLs.
> --
>
> Key: OFBIZ-7578
> URL: https://issues.apache.org/jira/browse/OFBIZ-7578
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
> Attachments: OFBIZ-7578.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7577) Accounting: Correct all the checkboxes and radio buttons in all the accounting FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7577.
---

> Accounting: Correct all the checkboxes and radio buttons in all the 
> accounting FTLs.
> 
>
> Key: OFBIZ-7577
> URL: https://issues.apache.org/jira/browse/OFBIZ-7577
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Mohammad Kathawala
>    Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7577.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7577) Accounting: Correct all the checkboxes and radio buttons in all the accounting FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361575#comment-15361575
 ] 

Divesh Dutta commented on OFBIZ-7577:
-

[~devanshu.vyas] your patch is committed in revision number 1751338 in trunk. 

> Accounting: Correct all the checkboxes and radio buttons in all the 
> accounting FTLs.
> 
>
> Key: OFBIZ-7577
> URL: https://issues.apache.org/jira/browse/OFBIZ-7577
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7577.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7577) Accounting: Correct all the checkboxes and radio buttons in all the accounting FTLs.

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7577:
---

Assignee: Divesh Dutta  (was: Mohammad Kathawala)

> Accounting: Correct all the checkboxes and radio buttons in all the 
> accounting FTLs.
> 
>
> Key: OFBIZ-7577
> URL: https://issues.apache.org/jira/browse/OFBIZ-7577
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Mohammad Kathawala
>    Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7577.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7522) Hide user inputs for Location/Lot# for fully issued components against production run task

2016-07-04 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7522:

Assignee: Swapnil Shah  (was: Divesh Dutta)

> Hide user inputs for Location/Lot# for fully issued components against 
> production run task
> --
>
> Key: OFBIZ-7522
> URL: https://issues.apache.org/jira/browse/OFBIZ-7522
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>Priority: Minor
> Attachments: OFBIZ-7522.patch, PR_1.png
>
>
> Once any component item gets fully issued then also we allow user to enter 
> the location/lot# etc. under 'Materials Required By The Running Task' panel, 
> like we do for un-issued or partially issued components. 
> We can possible hide user selection and text entry against such fully issued 
> items and show it only if remaining to be issued qty > 0
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7522) Hide user inputs for Location/Lot# for fully issued components against production run task

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361558#comment-15361558
 ] 

Divesh Dutta commented on OFBIZ-7522:
-

Assigning [~swash78] for verification and closure. 

> Hide user inputs for Location/Lot# for fully issued components against 
> production run task
> --
>
> Key: OFBIZ-7522
> URL: https://issues.apache.org/jira/browse/OFBIZ-7522
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil Shah
>Priority: Minor
> Attachments: OFBIZ-7522.patch, PR_1.png
>
>
> Once any component item gets fully issued then also we allow user to enter 
> the location/lot# etc. under 'Materials Required By The Running Task' panel, 
> like we do for un-issued or partially issued components. 
> We can possible hide user selection and text entry against such fully issued 
> items and show it only if remaining to be issued qty > 0
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7522) Hide user inputs for Location/Lot# for fully issued components against production run task

2016-07-04 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361554#comment-15361554
 ] 

Divesh Dutta commented on OFBIZ-7522:
-

Thanks [~anuj.jain] for your patch, its in trunk in revision number 1751334. 
Thanks [~swash78] for your suggestion and [~pfm.smits] for your views on it. 

> Hide user inputs for Location/Lot# for fully issued components against 
> production run task
> --
>
> Key: OFBIZ-7522
> URL: https://issues.apache.org/jira/browse/OFBIZ-7522
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7522.patch, PR_1.png
>
>
> Once any component item gets fully issued then also we allow user to enter 
> the location/lot# etc. under 'Materials Required By The Running Task' panel, 
> like we do for un-issued or partially issued components. 
> We can possible hide user selection and text entry against such fully issued 
> items and show it only if remaining to be issued qty > 0
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5130) getProductCost causes stack overflow if product has mutual variants

2016-07-03 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360847#comment-15360847
 ] 

Divesh Dutta commented on OFBIZ-5130:
-

[~dagrawal] please give your inputs on real world use case of mutual variants . 
If we do not get your inputs in next few days then I will discard this ticket. 

> getProductCost causes stack overflow if product has mutual variants
> ---
>
> Key: OFBIZ-5130
> URL: https://issues.apache.org/jira/browse/OFBIZ-5130
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Deepak Agarwal
>Assignee: Divesh Dutta
>  Labels: crash
> Attachments: OFBiz-5130.patch
>
>
> Cost of product A = 0
> Cost of product B = 0
> B is variant of A and A is variant of B.
> Now getProductCost causes a never ending recursive loop. This causes jvm to 
> exit (prior to Jdk1.6_34, atleast in my knowledge) without any crash dump.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7484) The UI of payment section distorts when there is a billing account present for a customer while placing a sales order

2016-07-01 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta closed OFBIZ-7484.
---

> The UI of payment section distorts when there is a billing account present 
> for a customer while placing a sales order
> -
>
> Key: OFBIZ-7484
> URL: https://issues.apache.org/jira/browse/OFBIZ-7484
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Mohammad Kathawala
>    Assignee: Divesh Dutta
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7484.patch, ScreenShot2.png, Screenshot1.png
>
>
> Steps to generate:
> 1) Go to order entry process and select a customer having a billing account
> 2) Add items and continue to payment screen through Finalize Order or Quick 
> Finalize Order
> 3) Due to the select box of billing account, the UI distorts
> Please see the attached screenshots for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (OFBIZ-7484) The UI of payment section distorts when there is a billing account present for a customer while placing a sales order

2016-07-01 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta resolved OFBIZ-7484.
-
Resolution: Fixed

> The UI of payment section distorts when there is a billing account present 
> for a customer while placing a sales order
> -
>
> Key: OFBIZ-7484
> URL: https://issues.apache.org/jira/browse/OFBIZ-7484
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Mohammad Kathawala
>    Assignee: Divesh Dutta
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7484.patch, ScreenShot2.png, Screenshot1.png
>
>
> Steps to generate:
> 1) Go to order entry process and select a customer having a billing account
> 2) Add items and continue to payment screen through Finalize Order or Quick 
> Finalize Order
> 3) Due to the select box of billing account, the UI distorts
> Please see the attached screenshots for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7484) The UI of payment section distorts when there is a billing account present for a customer while placing a sales order

2016-07-01 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7484:

Fix Version/s: (was: Trunk)
   Upcoming Branch

> The UI of payment section distorts when there is a billing account present 
> for a customer while placing a sales order
> -
>
> Key: OFBIZ-7484
> URL: https://issues.apache.org/jira/browse/OFBIZ-7484
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Mohammad Kathawala
>    Assignee: Divesh Dutta
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7484.patch, ScreenShot2.png, Screenshot1.png
>
>
> Steps to generate:
> 1) Go to order entry process and select a customer having a billing account
> 2) Add items and continue to payment screen through Finalize Order or Quick 
> Finalize Order
> 3) Due to the select box of billing account, the UI distorts
> Please see the attached screenshots for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7484) The UI of payment section distorts when there is a billing account present for a customer while placing a sales order

2016-07-01 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358662#comment-15358662
 ] 

Divesh Dutta commented on OFBIZ-7484:
-

Patch is committed in revision number 1750888 in trunk. Thanks [~Mohammad K] 
for suggesting this improvement and giving patch for it. 

> The UI of payment section distorts when there is a billing account present 
> for a customer while placing a sales order
> -
>
> Key: OFBIZ-7484
> URL: https://issues.apache.org/jira/browse/OFBIZ-7484
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Mohammad Kathawala
>Assignee: Divesh Dutta
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7484.patch, ScreenShot2.png, Screenshot1.png
>
>
> Steps to generate:
> 1) Go to order entry process and select a customer having a billing account
> 2) Add items and continue to payment screen through Finalize Order or Quick 
> Finalize Order
> 3) Due to the select box of billing account, the UI distorts
> Please see the attached screenshots for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment

2016-06-29 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355129#comment-15355129
 ] 

Divesh Dutta commented on OFBIZ-6899:
-

I see no harm in creating new table, and agree that it would be more clean. So 
let's create new table for Check. [~swash78]  as Jacques mentioned,  can you 
please create a new ticket for this? 

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7518) Unable to create Product Store Roles from Party manager

2016-06-27 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7518:
---

Assignee: Divesh Dutta  (was: Ankush Upadhyay)

> Unable to create Product Store Roles from Party manager
> ---
>
> Key: OFBIZ-7518
> URL: https://issues.apache.org/jira/browse/OFBIZ-7518
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>    Assignee: Divesh Dutta
> Attachments: OFBIZ-7518.patch, ProductStoreRoleError.png
>
>
> System throws error while adding new product store role.
> Steps to reproduce:
> 1. Login to party manager and go to Company party profile page.
> 2. Navigate to Product Store Roles tab.
> 3. Try to create new product store role for any product store and any 
> roleTypeId.
> 4. System should show violation of foreign key constraint error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Track user for status change

2016-06-24 Thread Divesh Dutta
Yea I think it makes sense.

Thanks
--
Divesh Dutta.

On Fri, Jun 24, 2016 at 6:56 PM, Nameet Jain 
wrote:

> Hello everyone,
>
> Currently in OFBiz, 'changedByUserLoginId' field is missing from status
> entities (like: ShipmentStatus). Using this field we can maintain the
> history for each status change made by user.
>
> I will recommend here to add 'changedByUserLoginId' field to track the
> userlogin detail. Here is the list of entities with missing such type of
> field.
>
> 1. BudgetStatus
> 2. ContactListCommStatus
> 3. CustRequestStatus
> 4. ExampleStatus
> 5. FinAccountStatus
> 6. InventoryItemStatus
> 7. InvoiceStatus
> 8. PartyStatus
> 9. RequirementStatus
> 10. ShipmentStatus
>
> Please let me know your thoughts. If it looks good I will open a ticket for
> the same.
>
> Thanks
>
> --
> Regards,
> Nameet Jain
>


[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-24 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348054#comment-15348054
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

[~Peter Arnold] we can create a separate ticket for this problem . 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 1

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-24 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348052#comment-15348052
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Dear [~Peter Arnold] , 

You are right in terms of business definitions of VAT_TAX and SALES_TAX. 

My comment was may be confusing, sorry for that. When I say that they are 
different I say in terms of how system will handle them in terms of Sales. In 
terms of sales, revenue is generated on product sales and sales tax is recorded 
as liability that needs to be remitted off. Same is the case with Vat tax. It 
should be recorded as liability. So I mean for system, both are liability and 
should be posted on general ledger accounts of liability nature. Currently 
VAT_TAX amounts are not recorded as liability when invoices are generated in 
OFBIZ. Here is the JIRA ticket for it: 
https://issues.apache.org/jira/browse/OFBIZ-7012

In OFBiz, there is only one place where if else is written for SALES_TAX and 
VAT_TAX and that ie for recording order adjustment and deciding type of 
orderAdjustment when sales order is recorded. So if Product's price have vat 
tax included in it, adjustment is recorded with type VAT_TAX else its recorded 
as SALES_TAX. That is it. So when invoice is generated for sales order, you 
want to record tax as liability in general ledgers. So it does not matter for 
system if its VAT_TAX or SALES_TAX . System should simply post tax as liability 
in case of sales. That is why I was saying that we can remove the if and else 
statements because its only at one place. However after thinking more, I agree 
that may be we should not remove the if and else because some countries collect 
both taxes, and for reporting point of view it will be helpful to track them 
separately. 

In case of PO, sales tax is currently not calculated in OFBiz . User can 
manually add sales tax as order adjustment if user want to match total of PO 
near the invoice which supplier will send. When VAT is added in product' price 
and you place PO for those products, order total already have VAT included in 
it. And the total amount is just accounts payable for user. They don't want to 
separate out VAT amount here. 

So as [~paul_foxworthy] was saying that difference is only in case of purchases 
because VAT applies to purchases as well, and your tax liability is reduced by 
the tax you have paid on purchases. So here I was saying that in case of PO, 
you can also add Sales tax manually in PO. And in that case, both the taxes are 
reducing the liability.  So this is not the actual difference between them IMO. 

And you have already explained their actual difference in terms of business in 
very descriptive way . I hope my points are making sense. Issue in this ticket 
is already resolved. We were just discussing this additional thing for 
knowledge purpose :) . 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>    Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Cata

[jira] [Issue Comment Deleted] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-24 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-6576:

Comment: was deleted

(was: Dear [~Peter Arnold] , 

You are right in terms of business definitions of VAT_TAX and SALES_TAX. 

My comment was may be confusing, sorry for that. When I say that they are 
different I say in terms of how system will handle them in terms of Sales. In 
terms of sales, revenue is generated on product sales and sales tax is recorded 
as liability that needs to be remitted off. Same is the case with Vat tax. It 
should be recorded as liability. So I mean for system, both are liability and 
should be posted on general ledger accounts of liability nature. Currently 
VAT_TAX amounts are not recorded as liability when invoices are generated in 
OFBIZ. Here is the JIRA ticket for it: 
https://issues.apache.org/jira/browse/OFBIZ-7012

In OFBiz, there is only one place where if else is written for SALES_TAX and 
VAT_TAX and that ie for recording order adjustment and deciding type of 
orderAdjustment when sales order is recorded. So if Product's price have vat 
tax included in it, adjustment is recorded with type VAT_TAX else its recorded 
as SALES_TAX. That is it. So when invoice is generated for sales order, you 
want to record tax as liability in general ledgers. So it does not matter for 
system if its VAT_TAX or SALES_TAX . System should simply post tax as liability 
in case of sales. That is why I was saying that we can remove the if and else 
statements because its only at one place. However after thinking more, I agree 
that may be we should not remove the if and else because some countries collect 
both taxes, and for reporting point of view it will be helpful to track them 
separately. 

In case of PO, sales tax is currently not calculated in OFBiz . User can 
manually add sales tax as order adjustment if user want to match total of PO 
near the invoice which supplier will send. When VAT is added in product' price 
and you place PO for those products, order total already have VAT included in 
it. And the total amount is just accounts payable for user. They don't want to 
separate out VAT amount here. 

So as [~paul_foxworthy] was saying that difference is only in case of purchases 
because VAT applies to purchases as well, and your tax liability is reduced by 
the tax you have paid on purchases. So here I was saying that in case of PO, 
you can also add Sales tax manually in PO. And in that case, both the taxes are 
reducing the liability.  So this is not the actual difference between them IMO. 

And you have already explained their actual difference in terms of business in 
very descriptive way . I hope my points are making sense. Issue in this ticket 
is already resolved. We were just discussing this additional thing for 
knowledge purpose :) . )

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>    Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
>  

[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-24 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348053#comment-15348053
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Dear [~Peter Arnold] , 

You are right in terms of business definitions of VAT_TAX and SALES_TAX. 

My comment was may be confusing, sorry for that. When I say that they are 
different I say in terms of how system will handle them in terms of Sales. In 
terms of sales, revenue is generated on product sales and sales tax is recorded 
as liability that needs to be remitted off. Same is the case with Vat tax. It 
should be recorded as liability. So I mean for system, both are liability and 
should be posted on general ledger accounts of liability nature. Currently 
VAT_TAX amounts are not recorded as liability when invoices are generated in 
OFBIZ. Here is the JIRA ticket for it: 
https://issues.apache.org/jira/browse/OFBIZ-7012

In OFBiz, there is only one place where if else is written for SALES_TAX and 
VAT_TAX and that ie for recording order adjustment and deciding type of 
orderAdjustment when sales order is recorded. So if Product's price have vat 
tax included in it, adjustment is recorded with type VAT_TAX else its recorded 
as SALES_TAX. That is it. So when invoice is generated for sales order, you 
want to record tax as liability in general ledgers. So it does not matter for 
system if its VAT_TAX or SALES_TAX . System should simply post tax as liability 
in case of sales. That is why I was saying that we can remove the if and else 
statements because its only at one place. However after thinking more, I agree 
that may be we should not remove the if and else because some countries collect 
both taxes, and for reporting point of view it will be helpful to track them 
separately. 

In case of PO, sales tax is currently not calculated in OFBiz . User can 
manually add sales tax as order adjustment if user want to match total of PO 
near the invoice which supplier will send. When VAT is added in product' price 
and you place PO for those products, order total already have VAT included in 
it. And the total amount is just accounts payable for user. They don't want to 
separate out VAT amount here. 

So as [~paul_foxworthy] was saying that difference is only in case of purchases 
because VAT applies to purchases as well, and your tax liability is reduced by 
the tax you have paid on purchases. So here I was saying that in case of PO, 
you can also add Sales tax manually in PO. And in that case, both the taxes are 
reducing the liability.  So this is not the actual difference between them IMO. 

And you have already explained their actual difference in terms of business in 
very descriptive way . I hope my points are making sense. Issue in this ticket 
is already resolved. We were just discussing this additional thing for 
knowledge purpose :) . 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>    Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Cata

Re: Javascript clean up and improvements

2016-06-24 Thread Divesh Dutta
+1 Amardeep.


Thanks
--
Divesh Dutta.

On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1. Increases the code maintenance effort.
> 2. Impact page performance.
> 3. Present not good examples to new contributors which leads to C/P to
> various areas of js code.
>
> Here are things we should do for cleanup and improvements in js code.
>
> 1. Remove unused javascript code and files if any.
> 2. Use best practices for javascript coding to improve performance (I have
> listed some of it below).
> 3. Move utility js functions to one js file.
> 4. Remove deprecated code and use latest. For ex: We are still using
> "language='javascript'" attribute at script tag which is deprecated a years
> ago.
> 5. js should be loaded at bottom of the page, currently its in Header. Its
> a tedious task now to move it into footer because we have lot of js code
> inline in ftls.
> 6. js should not be written inline, it should be enough generic to be in
> minimum number of files and have generic code for doing the common set of
> operations over DOM.
> 7. Currently our macros of rendering pages has inline scripts, they can be
> moved to one macrorenderer.js with generic code as we can use classes, ids
> and data-attributes for doing any operation over html DOM.
> 8. After all cleanup work, we can think of build tool (like grunt) for
> various javascript build tasks (minification, concatenation of files) if
> needed. Its just a thought.
>
> I know its a huge effort and need to be done carefully. So before doing any
> major changes, I would like to start work with first 4 points.
>
> Here is the list of some best practices to start with:
>
> 1. Use [] Instead of New Array()
> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> 3. Reduce global variables
> 4. Use explicit blocks
> 5. Start blocks on the same line
> 6. Always, Always Use Semicolons - Having said that, this is a very bad
> practice that can potentially lead to much bigger, and harder to find,
> issues.
> 7. Optimize loops. Avoid calculating the length of array in for loop
> iteration.
> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
> any object.
> 9. Try to use meaningful comments.
> 10. Many more.
>
> Here are some links of best practices information-
>
> https://www.w3.org/wiki/JavaScript_best_practices
> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> https://developer.yahoo.com/performance/rules.html
>
> If everyone agrees, I would like to start on this work.
>
> Please let me know your thoughts on it.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
>


[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id

2016-06-24 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347996#comment-15347996
 ] 

Divesh Dutta commented on OFBIZ-7576:
-

Thanks [~jacques.le.roux] for committing this patch . If you get time, feel 
free to pick other tickets which are assigned to me and  patches are available 
for them :)

> auto-completer does not work to search Contact Party Id
> ---
>
> Key: OFBIZ-7576
> URL: https://issues.apache.org/jira/browse/OFBIZ-7576
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ankush Upadhyay
>Assignee: Jacques Le Roux
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7576.patch, OFBIZ-7576_proposition.patch
>
>
> Steps to reproduce:
> 1. Login to party manager.
> 2. Search Company party and navigate to profile.
> 3. Click on create new link of List Related Contacts screenlet.
> 4. Search any contact party using auto-completer.
> Expected behavior: auto-completer should work and return results like lookup 
> does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7558) Any update made for 'Qty to produce' in a newly created production run not saved

2016-06-23 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7558:
---

Assignee: Divesh Dutta  (was: Swapnil Shah)

> Any update made for 'Qty to produce' in a newly created production run not 
> saved 
> -
>
> Key: OFBIZ-7558
> URL: https://issues.apache.org/jira/browse/OFBIZ-7558
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Critical
> Attachments: OFBIZ-7558.patch, PR1.png, PR2.png, PR3.png
>
>
> Whenever quantity to produce is revised for any production run (in created 
> status) the material requirement at WEGS (per BoM) gets readjusted 
> accordingly but the same is not saved correctly (under 
> WorkEffort.quantityToProduce)
> Now when production run is confirmed, the quantity to produce is original 
> quantity but all material requirements at WEGS level are projected and 
> readjusted.
> Expected Behavior:
> Any changes made to Quantity to Produce for production run should be saved 
> correctly
> Please refer to attached screenshot
> !https://issues.apache.org/jira/secure/attachment/12812780/PR1.png|width=800px!
> !https://issues.apache.org/jira/secure/attachment/12812779/PR2.png|width=800px!
> !https://issues.apache.org/jira/secure/attachment/12812778/PR3.png|width=800px!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7522) Hide user inputs for Location/Lot# for fully issued components against production run task

2016-06-23 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7522:
---

Assignee: Divesh Dutta  (was: Swapnil Shah)

> Hide user inputs for Location/Lot# for fully issued components against 
> production run task
> --
>
> Key: OFBIZ-7522
> URL: https://issues.apache.org/jira/browse/OFBIZ-7522
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
>Priority: Minor
> Attachments: OFBIZ-7522.patch, PR_1.png
>
>
> Once any component item gets fully issued then also we allow user to enter 
> the location/lot# etc. under 'Materials Required By The Running Task' panel, 
> like we do for un-issued or partially issued components. 
> We can possible hide user selection and text entry against such fully issued 
> items and show it only if remaining to be issued qty > 0
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7512) 'Issue Component' option after partial issuance against required component quantity is not accounting for already issued quantity

2016-06-23 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7512:
---

Assignee: Divesh Dutta  (was: Swapnil Shah)

> 'Issue Component' option after partial issuance against required component 
> quantity is not accounting for already issued quantity
> -
>
> Key: OFBIZ-7512
> URL: https://issues.apache.org/jira/browse/OFBIZ-7512
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Release Branch 14.12, 14.12.01, Release Branch 15.12, 
> 15.12.01
>Reporter: Swapnil Shah
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7173.png, OFBIZ-7512.patch
>
>
> Once we issue the required component partially (i.e. by producing partial 
> quantity while task is still is still running or in case full ATP against 
> required quantity is not available for issuance) then "Issue Component" is 
> not honoring the already made issuance and hence issuing the whole required 
> quantity once again. (please refer to attached screenshot)
> !https://issues.apache.org/jira/secure/attachment/12811801/OFBIZ-7173.png|width=800px!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment

2016-06-22 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345910#comment-15345910
 ] 

Divesh Dutta commented on OFBIZ-6899:
-

Pierre , all details you are giving from business point of view makes sense. In 
context of this task, what we want to conclude is that is it making sense to 
introduce new table for check. And you are not answering that question's answer 
:) .

What I said above and what Swapnil again said here :  " if there is indeed any 
real time need of electronically transferring Check details to different 
financial institutions like Bank etc., (similar to what we mostly do for Credit 
Card/EFT), then we could add Check as new entity to store all relevant details 
as discussed above. Although, we haven't came across any real requirement 
around that from our clients so far who are dealing inbound/outbound payments 
through checks." . So our discussion is around whether to add new table or not ?

It will be great if you help us to conclude that. I think that we don't need to 
add new table for Check . Also as Swapnil mentioned we have not seen any such 
requirements so far , where clients who deals with outgoing and incoming 
payments with Check,  send check details electronically to financial 
institutions like Bank . So its not making sense to add new table for Check. 

But if you have some use case where it will make sense to add new table, we can 
definitely do that. I hope your next reply will help us to conclude this 
discussion. 

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>    Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment

2016-06-22 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344631#comment-15344631
 ] 

Divesh Dutta commented on OFBIZ-6899:
-

I know they are used in outgoing documents.  My point was in case of Check they 
are more of notes or reference because Check is paper based transaction and we 
just need bank name and account for reference. When we do payments out and in 
using electronic payment method where transactions are actually happening in 
system,  it makes more sense to have a separate table for it. But I am open to 
add new table for Check as I proposed above. It seems Jacques is agreeing with 
this proposal. What do you think on it ?

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7539) Catch GenericEntityException or GenericServiceException instead of Exception in Java classes

2016-06-22 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7539:

Description: 
There are many places in Java code when services are called or entity 
operations are performed, but GenericEntityException and 
GenericServiceException are not handled and instead higher level Exception is 
handled. Its best practice to handle detailed level exceptions. 

This is parent ticket, i will create child tickets for each component. 

  was:
There are many places in Java code when services are called or entity 
operations are performed, but GenericEntityException and GenericEntityException 
are not handled and instead higher level Exception is handled. Its best 
practice to handle detailed level exceptions. 

This is parent ticket, i will create child tickets for each component. 


> Catch GenericEntityException or GenericServiceException instead of Exception 
> in Java classes
> 
>
> Key: OFBIZ-7539
> URL: https://issues.apache.org/jira/browse/OFBIZ-7539
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>    Reporter: Divesh Dutta
>Assignee: Divesh Dutta
>
> There are many places in Java code when services are called or entity 
> operations are performed, but GenericEntityException and 
> GenericServiceException are not handled and instead higher level Exception is 
> handled. Its best practice to handle detailed level exceptions. 
> This is parent ticket, i will create child tickets for each component. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7539) Catch GenericEntityException or GenericServiceException instead of Exception in Java classes

2016-06-22 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-7539:

Summary: Catch GenericEntityException or GenericServiceException instead of 
Exception in Java classes  (was: Catch GenericEntityException or 
GenericServiceException instead of Exception class in Java files)

> Catch GenericEntityException or GenericServiceException instead of Exception 
> in Java classes
> 
>
> Key: OFBIZ-7539
> URL: https://issues.apache.org/jira/browse/OFBIZ-7539
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>    Reporter: Divesh Dutta
>
> There are many places in Java code when services are called or entity 
> operations are performed, but GenericEntityException and 
> GenericEntityException are not handled and instead higher level Exception is 
> handled. Its best practice to handle detailed level exceptions. 
> This is parent ticket, i will create child tickets for each component. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7539) Catch GenericEntityException or GenericServiceException instead of Exception in Java classes

2016-06-22 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7539:
---

Assignee: Divesh Dutta

> Catch GenericEntityException or GenericServiceException instead of Exception 
> in Java classes
> 
>
> Key: OFBIZ-7539
> URL: https://issues.apache.org/jira/browse/OFBIZ-7539
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>    Reporter: Divesh Dutta
>Assignee: Divesh Dutta
>
> There are many places in Java code when services are called or entity 
> operations are performed, but GenericEntityException and 
> GenericEntityException are not handled and instead higher level Exception is 
> handled. Its best practice to handle detailed level exceptions. 
> This is parent ticket, i will create child tickets for each component. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7539) Catch GenericEntityException or GenericServiceException instead of Exception class in Java files

2016-06-22 Thread Divesh Dutta (JIRA)
Divesh Dutta created OFBIZ-7539:
---

 Summary: Catch GenericEntityException or GenericServiceException 
instead of Exception class in Java files
 Key: OFBIZ-7539
 URL: https://issues.apache.org/jira/browse/OFBIZ-7539
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Upcoming Branch
Reporter: Divesh Dutta


There are many places in Java code when services are called or entity 
operations are performed, but GenericEntityException and GenericEntityException 
are not handled and instead higher level Exception is handled. Its best 
practice to handle detailed level exceptions. 

This is parent ticket, i will create child tickets for each component. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment

2016-06-22 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344222#comment-15344222
 ] 

Divesh Dutta commented on OFBIZ-6899:
-

Jacques actually I think Bank name and Account # is just kind of note , so we 
we were trying to use existing field of PaymentMethod table i.e description and 
we were trying to avoid need of creation of new table. But you and other 
community member thinks that it makes sense to add new table with name Check 
similar to CreditCard, EftAccount etc. , we can do that . Let us know what do 
you think ?

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Divesh Dutta
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-7511) Add proper form validation across the application

2016-06-22 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343992#comment-15343992
 ] 

Divesh Dutta edited comment on OFBIZ-7511 at 6/22/16 12:16 PM:
---

[~jacques.le.roux]  this discussion has been concluded. There was confusion in 
actual problem area. Actually the problem area is:

When you use auto-field-service in form say for eg: 

{code}



 
{code}

Then exampleFeatureId is mandatory field in this form because exampleFeatureId 
is mandatory attribute of service. Now if you create same form then where you 
want to use tool tip in exampleFeatureId , 

{code}


 

 
{code}

In this case, you have overridden the exampleFeatureId field, but during 
overriding required property is lost. And to solve this problem, Deepak is 
recommending that when you override the field , then by default required 
property should be inherited from auto-fields service, so that developer does 
not have to explicitly define required-field=true . And we agreed on this 
proposal of Deepak . 

So we agreed on solution which maximally automates. Hope this helps to 
understand the problem area and solution concluded. 


was (Author: diveshdut):
[~jacques.le.roux]  this discussion has been concluded. There was confusion in 
actual problem area. Actually the problem area is:

When you use auto-field-service in form say for eg: 

{code}



 
{code}

Then exampleFeatureId is mandatory field in this form because exampleFeatureId 
is mandatory attribute of service. Now if you create same form then where you 
want to use tool tip in exampleFeatureId , 

{code}




 
{code}

In this case, you have overridden the exampleFeatureId field, but during 
overriding required property is lost. And to solve this problem, Deepak is 
recommending that when you override the field , then by default required 
property should be inherited from auto-fields service, so that developer does 
not have to explicitly define required-field=true . And we agreed on this 
proposal of Deepak . 

So we agreed on solution which maximally automates. Hope this helps to 
understand the problem area and solution concluded. 

> Add proper form validation  across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the 
> application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7537) Complete the documentation in the XSD files

2016-06-22 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344129#comment-15344129
 ] 

Divesh Dutta commented on OFBIZ-7537:
-

Thanks Jacques for the details. I will create child tickets for each xsd file 
and get this work done.

> Complete the documentation in the XSD files
> ---
>
> Key: OFBIZ-7537
> URL: https://issues.apache.org/jira/browse/OFBIZ-7537
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Divesh Dutta
>
> We have already some documentation in the XSD files, but we could clearly do 
> better, and that's an important point to achieve a higher adoption by new 
> comers. And you know what? We need them ;)
> Thanks to Paul Piper for a reminder on the subject :)
> When I speak about documentation I speak about the blocks you can find in 
> XSDs elements and attributes like in widget-form.xsd:
> {code}
> 
> 
> This is just like display but looks up a 
> description using the Entity Engine; note that if also-hidden is true then it 
> uses the key as the value, not the shown description.
> 
> [...]
> {code}
> {code}
> 
> 
> Specifies the size of the field (as a 
> number of characters), when the text to display exceed the given size it is 
> truncated and add the complete text as a hint
> 
> 
> {code}
> BTW I personnaly prefer this formatting when the lines are long
> {code}
> 
> 
> 
> This is just like display but looks up a description using 
> the Entity Engine; note that if also-hidden is true then it uses the key as 
> the value, not the shown description.
> 
> 
> [...]
> 
> 
> 
> Specifies the size of the field (as a number of 
> characters), when the text to display exceed the given size it is truncated 
> and add the complete text as a hint
>  
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7537) Complete the documentation in the XSD files

2016-06-22 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta reassigned OFBIZ-7537:
---

Assignee: Divesh Dutta

> Complete the documentation in the XSD files
> ---
>
> Key: OFBIZ-7537
> URL: https://issues.apache.org/jira/browse/OFBIZ-7537
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>    Assignee: Divesh Dutta
>
> We have already some documentation in the XSD files, but we could clearly do 
> better, and that's an important point to achieve a better adoption by new 
> comers. And you know what? We need them ;)
> Thanks to Paul Piper for a reminder on the subject :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7511) Add proper form validation across the application

2016-06-22 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343992#comment-15343992
 ] 

Divesh Dutta commented on OFBIZ-7511:
-

[~jacques.le.roux]  this discussion has been concluded. There was confusion in 
actual problem area. Actually the problem area is:

When you use auto-field-service in form say for eg: 

{code}



 
{code}

Then exampleFeatureId is mandatory field in this form because exampleFeatureId 
is mandatory attribute of service. Now if you create same form then where you 
want to use tool tip in exampleFeatureId , 

{code}




 
{code}

In this case, you have overridden the exampleFeatureId field, but during 
overriding required property is lost. And to solve this problem, Deepak is 
recommending that when you override the field , then by default required 
property should be inherited from auto-fields service, so that developer does 
not have to explicitly define required-field=true . And we agreed on this 
proposal of Deepak . 

So we agreed on solution which maximally automates. Hope this helps to 
understand the problem area and solution concluded. 

> Add proper form validation  across the application
> --
>
> Key: OFBIZ-7511
> URL: https://issues.apache.org/jira/browse/OFBIZ-7511
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>
> This is the place holder task for adding proper form validation across the 
> application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-6576:

Priority: Major  (was: Minor)

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> Create
> # Under Catalog Manager / Products / Prices set 2 new product prices for the 
> created virtual 
> product "T-Shirt":
>  Default Price
>  From Date: Now
>   Price: 11.9
>  Tax Percentage: 19
>  Tax in price: Y
> Create
>  List Price
>  From Date: Now
>  

[jira] [Commented] (OFBIZ-7536) Clean up commented out code

2016-06-22 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343947#comment-15343947
 ] 

Divesh Dutta commented on OFBIZ-7536:
-

+1 for this effort. 

> Clean up commented out code
> ---
>
> Key: OFBIZ-7536
> URL: https://issues.apache.org/jira/browse/OFBIZ-7536
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Harsh Vijaywargiya
>Assignee: Harsh Vijaywargiya
> Fix For: Upcoming Branch
>
>
> In our Re-Factor To-Do List one of the item is to clean up the commented out 
> code. 
> This is the parent ticket and I will further create sub tasks under it so 
> that we do not push large change in one commit.
> This includes Java, Xml, Groovy and FTL files. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product

2016-06-22 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343939#comment-15343939
 ] 

Divesh Dutta commented on OFBIZ-6576:
-

Thanks Ankush for the improvement. One more minor thing, we are already 
discussing in community about directly checking null or not null for 
GenericValue instead of using isNotEmpty method of GenericValue . So in this 
patch, please change it accordingly and then we should be good, 

> Pricing error in Variant Products when setup with VAT-Tax and price set on 
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Assignee: Divesh Dutta
>Priority: Minor
>  Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6576.patch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- 
> variant- products and the price is defined only on the virtual product and 
> with "Tax in Price" set to "Y", its variants should inherit the set price 
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product 
> is added to the shopping cart. Currently sales-tax is added to the product 
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its 
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the 
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all 
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following 
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200 
> (Widgets)
>  Product Category ID: 200
>   From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
>  Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
>  Feature Type: Color
>  Description: Red
> Update
> Create New Feature
>  Feature Type: Color
>  Description: Blue
> Update
> # Create 2 variant products under the virtual product "T-Shirt"
> Under Catalog Manager / Products
> Find T-Shirt Product
> Once T-Shirt Product is selected:
> Press Features Tab
> Under Add product features from Category or Group
>  Choose T-Shirt Colors Category
>  Feature Application Type: Selectable
> Add
> Screen with Blue and Red T-Shirt Colors appears.
> Set for both colors From Date: Now
> Sequence:1 for blue
> Sequence:2 for red
> Set a tick on each feature in order to select the feature for adding it.
> Apply
> # Under Catalog Manager / Products with "T-Shirt" virtual product selected 
> press the Variants 
> tab
> The Quick add Variants screen appears.
> Define Product IDs for Blue and Red features.
> Blue: T-Shirt Blue
> Red: T-Shirt Red
> Set tick on both features in order to select for variant product creation.
> 

  1   2   3   4   5   6   7   8   >