Re: Temporary change for filling the "Fix Versions/s" field in Jira

2016-07-18 Thread Deepak Dixit
Thanks Jacques for update.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Jul 18, 2016 at 9:46 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Committer, Devs, All,
>
> You might have noticed I Temporary changed our policy about filling the
> "Fix Versions/s" field in Jira
>
> Please read
> https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=7766050&selectedPageVersions=46&selectedPageVersions=45
>
> Thanks
>
> Jacques
>
>


Re: [VOTE] Create the "security" mailing list for the OFBiz project

2016-07-24 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Jul 25, 2016 at 10:08 AM, Scott Gray 
wrote:

> Do we actually need a separate mailing list, or should it just forward to
> private@?
>
> Regards
> Scott
>
> On 25 July 2016 at 15:58, Ashish Vijaywargiya <
> ashish.vijaywarg...@hotwaxsystems.com> wrote:
>
> > +1
> >
> > --
> > Kind Regards
> > Ashish Vijaywargiya
> > HotWax Systems - est. 1997
> >
> >
> > On Sun, Jul 24, 2016 at 6:02 PM, Jacopo Cappellato <
> > jacopo.cappell...@hotwaxsystems.com> wrote:
> >
> > > Rationale: every ASF project needs a private list to discuss product
> > > vulnerabilities; for OFBiz the "private" list has been used for this
> > > purpose until now; however an ad-hoc list may be useful because it
> could
> > > provide a more focused space to discuss the security issues and could
> > > provide more flexibility to invite in the private list persons willing
> to
> > > help that are trusted by the PMC.
> > >
> > > Please vote,
> > >
> > > +1
> > >
> > > to create a "security" list (i.e. secur...@ofbiz.apache.org) and move
> > all
> > > the security related discussions and notifications currently happening
> on
> > > the private list to this new list: according to the ASF policies [*]
> the
> > > list will be a private list used by the persons willing to help to
> > resolve
> > > security issues; the list of subscribers will be approved by the OFBiz
> > PMC.
> > >
> > > Otherwise vote -1 to continue to use the "private" mailing list for
> > > vulnerability handling.
> > >
> > > [*] http://www.apache.org/security/
> > >
> >
>


Re: [VOTE] Create a "notifications" mailing list

2016-07-24 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Jul 25, 2016 at 9:31 AM, Ashish Vijaywargiya <
ashish.vijaywarg...@hotwaxsystems.com> wrote:

> +1
>
> --
> Kind Regards
> Ashish Vijaywargiya
> HotWax Systems - est. 1997
>
>
> On Sun, Jul 24, 2016 at 6:29 PM, Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com> wrote:
>
> > Rationale: Jira notifications are currently sent to the "dev" list,
> causing
> > a lot of traffic and sometimes distracting from actual conversations; the
> > creation of a "notification" email (similar to the "commits" mailing
> list)
> > will solve this problem; in the future we may vote to use the
> > "notification" list to host traffic coming from buildbot etc... thus the
> > proposal for naming it "notifications" rather than just "issues"; however
> > this vote is only about traffic from Jira (we will discuss if we want to
> > extend the usage of this list in the future).
> >
> > Please vote,
> >
> > +1
> >
> > to create a "notifications" mailing list (i.e.
> > notificati...@ofbiz.apache.org) and redirect to it all the traffic
> coming
> > from Jira notifications.
> >
> > Otherwise vote -1 to continue to use the "dev" list for Jira
> notifications.
> >
>


Re: Please subscribe to the new "notifications" mailing list

2016-08-16 Thread Deepak Dixit
Thanks Jacopo for update.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Tue, Aug 16, 2016 at 1:27 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> Hi all,
>
> very soon all the Jira traffic email notifications currently forwarded to
> the dev list will be redirected to the newly created
> notificati...@ofbiz.apache.org mailing list.
>
> Please subscribe to this new list if you are interested in getting the
> notification traffic, by sending an empty email to:
>
> notifications-subscr...@ofbiz.apache.org
>
> and then by replying to the automatic confirmation message you will
> receive.
>
> Thanks,
>
> Jacopo
>


Re: Feedback on Committer Mentoring and HipChat

2016-08-23 Thread Deepak Dixit
Hi Sharan,

I like HipChat,, it allow us to communicate with each other, it helps in
debugging.


Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Tue, Aug 23, 2016 at 2:46 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> If I had to choose I'd pickup Skype, not because it's M$ (heck), but
> because it's the one with the easier previous lines edition (when this
> feature exist). I also use PidGin with XMMP (Jabber), no previous lines
> edition.
>
> I read recently that the infra team, which uses HipChat a lot for valuable
> reasons, was questioned about that by the board, because HipChat is
> delivered by Atlassian (only the free, minor version) and history is a
> concern.
>
> Jacques
>
> PS: I don't put, "Hi", "Regards" and such things in my email when a
> conversation has begun, because I kinda use them as the same as instant
> messaging. Just with a small delay which allows me to easily follow
> discussion, without having to look 3 pages above and search in them :/
> Threads for the win!
>
>
>
> Le 23/08/2016 à 10:21, Julien NICOLAS a écrit :
>
>> Hi Sharan,
>>
>> When you start Hipchat, you opened an OFBiz room and I was loving it.
>> Push Hipchat in the startup app even it's not a Libre Software and always
>> aware on what's happen on this OFBiz community window. I was the feeling to
>> be closer to the OFBiz community.
>>
>> Then, people decided that that window is not good and go back on email
>> "boring" system. In this community context, it's more difficult to use
>> email for informal discussion.
>>
>> So for me, HipChat is one more app for instant messaging. I'm not sure
>> that is better than Skype or other proprietary software. Why not to decide
>> to use jabber server that is more in free software way ?
>>
>> Since the OFBiz room was closed, Hipchat is no more in my startup app.
>> You have to send me an email to ask me to open Hipchat.
>>
>> In summary, Hipchat or Skype as you wish, I don't mind.
>>
>> Julien.
>>
>> On 22/08/2016 10:42, Sharan Foga wrote:
>>
>>> Hi All
>>>
>>> A few weeks ago, in response to the results of the Committer Survey, I
>>> setup a trial Hipchat environment to help with Committer Mentoring.  (See
>>> links to the previous discussion threads below:)
>>>
>>> https://lists.apache.org/thread.html/8b8738c3adcb1b7aafd7c90
>>> f9b1cbb54500578d8cd392c3b18d635b9@%3Cdev.ofbiz.apache.org%3E
>>>
>>> https://lists.apache.org/thread.html/5b64aad3bbaca967cf432ad
>>> fd62ce68901c95218a8aa59d706aed6bc@%3Cdev.ofbiz.apache.org%3E
>>>
>>> I really liked the HipChat environment and think that it's a great
>>> collaborative tool that also helps build community spirit. So now I'd like
>>> to get some feedback :-)
>>>
>>> First of all I'd like to hear from the committers and mentors who
>>> participated to find out what they thought of the HipChat environment, what
>>> their general comments are and whether they would like it to be made
>>> available on a permanent basis.
>>>
>>> Secondly I'd like to get some general feedback from everyone to find out
>>> if the whole community would also be interested in participating in HipChat
>>> environment (e.g. for collaborating on Jiras, or during our Community
>>> Days). Other ASF projects have HipChat spaces setup and publish a link that
>>> anyone can use to join and we could do the same.
>>>
>>> The mailing list would still be used for discussions and decisions but
>>> if people are working together on a particular task then this could be a
>>> good way to speed up the process.  I'm thinking particularly about things
>>> like the re-factoring and our Jira backlog where bringing together the
>>> reporter and the developer could make things move a lot more quickly!)
>>>
>>> We have another Community Day coming up in a few weeks on 17th September
>>> so it could be a good chance to see how it could work in action. What do
>>> people think?
>>>
>>> Thanks
>>> Sharan
>>>
>>>
>>
>>
>


Re: Michael Brohl joins OFBiz PMC

2016-09-02 Thread Deepak Dixit
Congratulations Michael ...!

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Fri, Sep 2, 2016 at 4:14 PM, Taher Alkhateeb 
wrote:

> Michael is an added value to OFBiz. Congratulations
>
> On Sep 2, 2016 1:37 PM, "Pierre Smits"  wrote:
>
> > Congratulations Michael!
> >
> > Best regards,
> >
> > Pierre Smits
> >
> > ORRTIZ.COM <http://www.orrtiz.com>
> > OFBiz based solutions & services
> >
> > OFBiz Extensions Marketplace
> > http://oem.ofbizci.net/oci-2/
> >
> > On Fri, Sep 2, 2016 at 12:36 PM, Sharan Foga 
> > wrote:
> >
> > > Hi Everyone
> > >
> > > Please join me in welcoming Michael Brohl as our newest member of the
> > > OFBiz PMC.
> > >
> > > Congratulations Michael and welcome! :-)
> > >
> > > Thanks
> > > Sharan
> > >
> >
>


Re: svn commit: r1759067 - in /ofbiz/trunk/applications/workeffort: config/WorkEffortUiLabels.xml src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalConverter.java

2016-09-03 Thread Deepak Dixit
Thanks Pierre for review,

For workEffort we don't have error UiLabel file and I thought its not good
idea to create new UiLabel file for an single UiLabel :)

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Sat, Sep 3, 2016 at 4:01 PM, Pierre Smits  wrote:

> Hi Deepak,
>
> Should labels for error messages not go into a ErrorUiLabels.xml file
> instead of the UILabels.xml file for field labels?
>
> Best regards,
>
> Pierre Smits
>
> ORRTIZ.COM <http://www.orrtiz.com>
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>
> On Sat, Sep 3, 2016 at 12:19 PM,  wrote:
>
> > Author: deepak
> > Date: Sat Sep  3 10:19:36 2016
> > New Revision: 1759067
> >
> > URL: http://svn.apache.org/viewvc?rev=1759067&view=rev
> > Log:
> > (OFBIZ-7999) Applied patch from jira issue
> > =
> > Add UI labels for success / error messages in workeffort component
> > =
> > Thanks Tanmay for your contribution.
> >
> > Modified:
> > ofbiz/trunk/applications/workeffort/config/WorkEffortUiLabels.xml
> > ofbiz/trunk/applications/workeffort/src/main/java/org/
> > apache/ofbiz/workeffort/workeffort/ICalConverter.java
> >
> > Modified: ofbiz/trunk/applications/workeffort/config/
> > WorkEffortUiLabels.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> > workeffort/config/WorkEffortUiLabels.xml?rev=
> > 1759067&r1=1759066&r2=1759067&view=diff
> > 
> > ==
> > --- ofbiz/trunk/applications/workeffort/config/WorkEffortUiLabels.xml
> > (original)
> > +++ ofbiz/trunk/applications/workeffort/config/WorkEffortUiLabels.xml
> Sat
> > Sep  3 10:19:36 2016
> > @@ -2633,6 +2633,12 @@
> >  错误:ä½ æ²¡æœ‰æµ è§ˆè¿™ä¸ªäº‹ä»¶çš„æ ƒé™
> > ã€‚è¿™ä¸ªäº‹ä»¶å¿…é¡»å±žäºŽä½ æˆ–è€…ä½ å¿…é¡»æ˜¯ä¸€ä¸ªç®¡ç †å‘˜
> >  錯誤:ä½ æ²’æœ‰æª¢è¦–é€™å€‹äº‹ä»¶çš„æ¬
> Šé™
> > .é€™å€‹äº‹ä»¶å¿…é ˆå±¬æ–¼ä½ æˆ–è€…ä½ å¿…é ˆæ˜¯ä¸€å€‹ç®¡ç †è€…
> >  
> > +
> > +Error while creating service Map for
> service
> > : ${serviceName}
> > +
> > +
> > +Error while invoking service :
> > ${serviceName}
> > +
> >  
> >  Est.Budget
> >  Presupuesto estimado
> >
> > Modified: ofbiz/trunk/applications/workeffort/src/main/java/org/
> > apache/ofbiz/workeffort/workeffort/ICalConverter.java
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> > workeffort/src/main/java/org/apache/ofbiz/workeffort/
> > workeffort/ICalConverter.java?rev=1759067&r1=1759066&r2=
> 1759067&view=diff
> > 
> > ==
> > --- ofbiz/trunk/applications/workeffort/src/main/java/org/
> > apache/ofbiz/workeffort/workeffort/ICalConverter.java (original)
> > +++ ofbiz/trunk/applications/workeffort/src/main/java/org/
> > apache/ofbiz/workeffort/workeffort/ICalConverter.java Sat Sep  3
> 10:19:36
> > 2016
> > @@ -463,6 +463,7 @@ public class ICalConverter {
> >
> >  protected static Map invokeService(String
> > serviceName, Map serviceMap, Map Object>
> > context) {
> >  LocalDispatcher dispatcher = (LocalDispatcher)
> > context.get("dispatcher");
> > +Locale locale = (Locale) context.get("locale");
> >  Map localMap = new HashMap();
> >  try {
> >  ModelService modelService = null;
> > @@ -477,7 +478,7 @@ public class ICalConverter {
> >  }
> >  }
> >  } catch (Exception e) {
> > -String errMsg = "Error while creating service Map for
> service
> > " + serviceName + ": ";
> > +String errMsg = UtilProperties.getMessage("
> WorkEffortUiLabels",
> > "WorkeffortErrorWhileCreatingServiceMapForService",
> > UtilMisc.toMap("serviceName", serviceName), locale);
> >  Debug.logError(e, errMsg, module);
> >  return ServiceUtil.returnError(errMsg + e);
> >  }
> > @@ -488,7 +489,7 @@ public class ICalConverter {
> >  try {
> >  return dispatcher.runSync(serviceName, localMap);
> >  } catch (GenericServiceException e) {
> > -String errMsg = "Error while invoking service " +
> serviceName
> > + ": ";
> > +String errMsg = UtilProperties.getMessage("
> WorkEffortUiLabels",
> > "WorkeffortErrorWhileInvokingService", UtilMisc.toMap("serviceName",
> > serviceName), locale);
> >  Debug.logError(e, errMsg, module);
> >  return ServiceUtil.returnError(errMsg + e);
> >  }
> >
> >
> >
>


Re: [VOTE] Put the bizzness time theme in Attic

2016-09-30 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Sep 26, 2016 at 5:23 AM, Paul Foxworthy  wrote:

> +1
>


Re: [VOTE] Put the Flatgrey theme in Attic

2016-09-30 Thread Deepak Dixit
-1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Sep 26, 2016 at 5:23 AM, Paul Foxworthy  wrote:

> -1
>


Re: [VOTE] Put the Dropping Crumbs theme in Attic

2016-09-30 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Sep 26, 2016 at 5:23 AM, Paul Foxworthy  wrote:

> +1
>


Re: Unable import ofbiz references into hot/deploy java code

2016-10-23 Thread Deepak Dixit
Hi Victor,

As Taher mentioned we refactored java package. It will be applicable only
for trunk, In 15.12 brach you need to use old package hierarchy and on
trunk you need to use new package hierarchy.


Could you please share your build.xml?

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Sat, Oct 22, 2016 at 11:39 PM, Teams Corner <
victor007.hernan...@gmail.com> wrote:

> Hi OFBiz Devs,
>
> I'll appreciate your advice to fix a compile issue I'm facing about since
> a week, when trying to compile the attached ofbiz demo Java service from a
> custom hot-deploy component (trunk-rev1759478 / version 15) I got a
> "package org.ofbiz... does not exists" errors.
>
> I tried to fix with no success creating the attached build.gradle into
> hot-deploy directory and adding some  entries into
> ofbiz-component.xml.
>
> Thanks a lot in advance,
> Regards
> Victor
>


Re: Creating a new release branch in preparation for the new release

2016-10-27 Thread Deepak Dixit
I am planning to commit test cases (OFBIZ-1463), so it would be good if we
wait till next week.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Thu, Oct 27, 2016 at 9:32 PM, Pierre Smits 
wrote:

> It is - in my opinion - the best theme to use for images.
>
>
> Pierre Smits
>
> ORRTIZ.COM <http://www.orrtiz.com>
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>
> On Thu, Oct 27, 2016 at 5:48 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > That's most welcome Nicolas, and reminds me about the themes. I'll reopen
> > https://issues.apache.org/jira/browse/OFBIZ-8293 and put in Attic
> >
> > 1. bizzness time
> > 2. Dropping Crumbs
> >
> > For BlueLight, I'll wait Sharan's opinion, I know she likes it
> >
> > Jacques
> >
> >
> > Le 27/10/2016 à 14:32, Julien NICOLAS a écrit :
> >
> >> hello,
> >>
> >> I want to improve less file for Rainbowstone and add a new feature in
> the
> >> main menu (both already approved by our customers), I'll schedule to do
> it
> >> for this week-end, if you can wait until monday, I'll really happy ^^
> >>
> >> Thanks!
> >>
> >> Julien.
> >>
> >>
> >> On 27/10/2016 14:20, Jacopo Cappellato wrote:
> >>
> >>> Thank you Jacques, I agree that delaying of 1-2 weeks would not be a
> big
> >>> deal.
> >>> If anyone is planning to contribute improvements in the next 1-2 weeks
> >>> then
> >>> please speak up and we could definitely wait for them.
> >>>
> >>> Jacopo
> >>>
> >>> On Thu, Oct 27, 2016 at 1:40 PM, Jacques Le Roux <
> >>> jacques.le.r...@les7arts.com> wrote:
> >>>
> >>> Hi Jacopo, All.
> >>>>
> >>>> Are there no major improvements that we would wish to have before
> >>>> cutting
> >>>> the branch?
> >>>>
> >>>> I personally don't remember any. But with the 6 last months turmoil we
> >>>> increased from around 0 issues created vs resolved to 1840 created and
> >>>> 1447
> >>>> resolved.
> >>>> So we have now a differential of around 400 issues pending for
> >>>> resolution.
> >>>> https://issues.apache.org/jira/secure/Dashboard.jspa?selectP
> >>>> ageId=12310800
> >>>> I know that most of them are minor subtasks, and it's hard to follow
> the
> >>>> flow.
> >>>>
> >>>> Anyway if you wait for an improvement it's the moment to raise a hand
> >>>>
> >>>> Thanks
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >>>>
> >>>> Le 24/10/2016 à 10:40, Jacopo Cappellato a écrit :
> >>>>
> >>>> Ok, it is probably time to proceed with this plan:
> >>>>> 1) create a new release branch named "release16.10"
> >>>>> 2) the target goal could be that of issuing a release out of it
> >>>>> sometime
> >>>>> in
> >>>>> the next month ("Apache OFBiz 16.10.01")
> >>>>>
> >>>>> Jacopo
> >>>>>
> >>>>> On Wed, Sep 7, 2016 at 1:26 PM, Taher Alkhateeb <
> >>>>> slidingfilame...@gmail.com>
> >>>>> wrote:
> >>>>>
> >>>>> +1
> >>>>>
> >>>>>> On Wed, Sep 7, 2016 at 2:07 PM, Sharan Foga 
> >>>>>> wrote:
> >>>>>>
> >>>>>> That's great news !  +1
> >>>>>>
> >>>>>>> Thanks
> >>>>>>> Sharan
> >>>>>>>
> >>>>>>>
> >>>>>>> On 07/09/16 12:06, Jacopo Cappellato wrote:
> >>>>>>>
> >>>>>>> Hi all,
> >>>>>>>
> >>>>>>>> I think it is the right time to create a new release branch out of
> >>>>>>>> the
> >>>>>>>> trunk.
> >>>>>>>>
> >>>>>>>> According to our naming conventions the release will be named
> >>>>>>>> "release16.09".
> >>>>>>>>
> >>>>>>>> Any objections or concerns? If not, I will create the branch later
> >>>>>>>> today/tomorrow.
> >>>>>>>>
> >>>>>>>> After that we will start, in a separate thread, the discussion
> about
> >>>>>>>> the
> >>>>>>>> preparation of our first release out of this branch.
> >>>>>>>>
> >>>>>>>> Thanks,
> >>>>>>>>
> >>>>>>>> Jacopo
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>
> >>
> >
>


Re: svn commit: r1767974 - /ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests .xml

2016-11-04 Thread Deepak Dixit
Let me check Jacques.

Thanks for review.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Fri, Nov 4, 2016 at 4:22 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak,
>
> The testUpdateFinAccountRole test fails because the data are wrong the
> FinAccountRole entity PKs are
>
> finAccountId (String)
> fromDate (java.sql.Timestamp)
> partyId (String)
> roleTypeId (String)
>
> When the data are
>
> 
>  finAccountName="Deposit Account" finAccountCode="1001" currencyUomId="USD"
> organizationPartyId="DEMO_COMPANY" fromDate="2016-11-03 00:00:00"
> actualBalance="2000.00" availableBalance="1500.00"/>
>  roleTypeId="SUPPLIER" fromDate="2016-11-03 00:00:00"/>
>
> At least organizationPartyId is wrong, should be partyId
>
> Thanks
>
> Jacques
>
>
> Le 03/11/2016 à 22:03, dee...@apache.org a écrit :
>
>> Author: deepak
>> Date: Thu Nov  3 21:03:13 2016
>> New Revision: 1767974
>>
>> URL: http://svn.apache.org/viewvc?rev=1767974&view=rev
>> Log:
>> Improved: Added missing file for accounting fin service test cases.
>>
>> Added:
>>  
>> ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml
>>  (with props)
>>
>> Added: ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>> inAccountTests.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accoun
>> ting/minilang/test/AutoAcctgFinAccountTests.xml?rev=1767974&view=auto
>> 
>> ==
>> --- 
>> ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml
>> (added)
>> +++ 
>> ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml
>> Thu Nov  3 21:03:13 2016
>> @@ -0,0 +1,182 @@
>> +
>> +
>> +
>> +http://www.w3.org/2001/XMLSchema-instance";
>> +xmlns="http://ofbiz.apache.org/Simple-Method";
>> xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
>> http://ofbiz.apache.org/dtds/simple-methods.xsd";>
>> +> short-description="Test case for service deleteFinAccountRole"
>> login-required="false">
>> +
>> +
>> +
>> +> type="Timestamp"/>
>> +
>> +
>> +
>> +
>> +> in-map-name="serviceCtx"/>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> short-description="Test case for service updateFinAccountRole"
>> login-required="false">
>> +
>> +
>> +
>> +
>> +> type="Timestamp"/>
>> +
>> +
>> +
>> +
>> +
>> +> in-map-name="serviceCtx"/>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> short-description="Test case for service createFinAccountRole"
>> login-required="false">
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> in-map-name="serviceCtx"/>
>> +
>> +
>> +
>> +> value="INTERNAL_ORGANIZATIO"/>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> short-description="Test case for service createFinAccountTrans"
>> login-required="false">
>> +
>> +> value="ADJUSTMENT"/>
>> +
>> +
>> +
>> +
>> +> in-map-name="serviceCtx"/>
>> +> entity-name="FinAccountTrans">
>> +
>> +
>> +> list="finAccountTransList"/>
>> +
>> +
>> +> field="finAccountTrans.finAccountTransTypeId&q

Re: svn commit: r1767974 - /ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests .xml

2016-11-05 Thread Deepak Dixit
Thanks Jacques and Deepak Nigam, this has been fixed at r#1768167.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Sat, Nov 5, 2016 at 2:38 PM, Deepak Nigam  wrote:

> I think this issue should be fixed after correcting the sequence of test
> cases in the file AutoAcctgFinAccountTests.xml.
>
> Thanks & Regards
> --
> Deepak Nigam
> Sr. Enterprise Software Engineer
> Hotwax Systems
> www.hotwaxsystems.com
>
> On Fri, Nov 4, 2016 at 4:43 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Ha no sorry, it's another error but not related to organizationPartyId
> >
> > The FinAccountRole data are OK
> >
> > The error is here https://ci.apache.org/projects/ofbiz/logs/trunk/html/
> >
> > Jacques
> >
> >
> >
> > Le 04/11/2016 à 11:56, Deepak Dixit a écrit :
> >
> >> Let me check Jacques.
> >>
> >> Thanks for review.
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> www.hotwaxsystems.com
> >>
> >> On Fri, Nov 4, 2016 at 4:22 PM, Jacques Le Roux <
> >> jacques.le.r...@les7arts.com> wrote:
> >>
> >> Hi Deepak,
> >>>
> >>> The testUpdateFinAccountRole test fails because the data are wrong the
> >>> FinAccountRole entity PKs are
> >>>
> >>> finAccountId (String)
> >>> fromDate (java.sql.Timestamp)
> >>> partyId (String)
> >>> roleTypeId (String)
> >>>
> >>> When the data are
> >>>
> >>>  
> >>>   >>> finAccountName="Deposit Account" finAccountCode="1001"
> >>> currencyUomId="USD"
> >>> organizationPartyId="DEMO_COMPANY" fromDate="2016-11-03 00:00:00"
> >>> actualBalance="2000.00" availableBalance="1500.00"/>
> >>>   >>> roleTypeId="SUPPLIER" fromDate="2016-11-03 00:00:00"/>
> >>>
> >>> At least organizationPartyId is wrong, should be partyId
> >>>
> >>> Thanks
> >>>
> >>> Jacques
> >>>
> >>>
> >>> Le 03/11/2016 à 22:03, dee...@apache.org a écrit :
> >>>
> >>> Author: deepak
> >>>> Date: Thu Nov  3 21:03:13 2016
> >>>> New Revision: 1767974
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=1767974&view=rev
> >>>> Log:
> >>>> Improved: Added missing file for accounting fin service test cases.
> >>>>
> >>>> Added:
> >>>>   ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
> >>>> inAccountTests.xml
> >>>>   (with props)
> >>>>
> >>>> Added: ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
> >>>> inAccountTests.xml
> >>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accoun
> >>>> ting/minilang/test/AutoAcctgFinAccountTests.xml?rev=1767974&view=auto
> >>>> 
> >>>> ==
> >>>> --- ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
> >>>> inAccountTests.xml
> >>>> (added)
> >>>> +++ ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
> >>>> inAccountTests.xml
> >>>> Thu Nov  3 21:03:13 2016
> >>>> @@ -0,0 +1,182 @@
> >>>> +
> >>>> +
> >>>> +
> >>>> +http://www.w3.org/2001/XMLSchema-instance
> "
> >>>> +xmlns="http://ofbiz.apache.org/Simple-Method";
> >>>> xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
> >>>> http://ofbiz.apache.org/dtds/simple-methods.xsd";>
> >>>> + >>>> short-description="Test case for service deleteFinAccountRole"
> >>>> login-required="false">
> >>>> +
> >>>> +
> >>>> +
> >>>> + >>>> type="Timestamp"/>
> >>>> +
> >>>> +
> >>>> +
> >>>> +
> >>>> + >>>> in-map-name="serviceCtx"/&g

Re: svn commit: r1767974 - /ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests .xml

2016-11-07 Thread Deepak Dixit
Let me check Jacques.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Nov 7, 2016 at 8:02 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak, All,
>
> This commit puts in 86 failures, tests were successful just before. I
> guess most of them have been fixed since but according to BuildBot we have
> still 32 failures and one errors
>
> https://ci.apache.org/builders/ofbiz-trunk
>
> https://ci.apache.org/projects/ofbiz/logs/trunk/html/
>
> Not sure some are still related with r1767974, but anyway we need to fix
> all of them before going ahead.
> Else it will become more and more uneasy to track from which commit/s
> these errors come, hence harder to fix them
>
> So I suggest to fix them before continuing to commit
>
> Thanks
>
> Jacques
>
>
> Le 03/11/2016 à 22:03, dee...@apache.org a écrit :
>
>> Author: deepak
>> Date: Thu Nov  3 21:03:13 2016
>> New Revision: 1767974
>>
>> URL: http://svn.apache.org/viewvc?rev=1767974&view=rev
>> Log:
>> Improved: Added missing file for accounting fin service test cases.
>>
>> Added:
>>  
>> ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml
>>  (with props)
>>
>> Added: ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>> inAccountTests.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accoun
>> ting/minilang/test/AutoAcctgFinAccountTests.xml?rev=1767974&view=auto
>> 
>> ==
>> --- 
>> ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml
>> (added)
>> +++ 
>> ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml
>> Thu Nov  3 21:03:13 2016
>> @@ -0,0 +1,182 @@
>> +
>> +
>> +
>> +http://www.w3.org/2001/XMLSchema-instance";
>> +xmlns="http://ofbiz.apache.org/Simple-Method";
>> xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
>> http://ofbiz.apache.org/dtds/simple-methods.xsd";>
>> +> short-description="Test case for service deleteFinAccountRole"
>> login-required="false">
>> +
>> +
>> +
>> +> type="Timestamp"/>
>> +
>> +
>> +
>> +
>> +> in-map-name="serviceCtx"/>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> short-description="Test case for service updateFinAccountRole"
>> login-required="false">
>> +
>> +
>> +
>> +
>> +> type="Timestamp"/>
>> +
>> +
>> +
>> +
>> +
>> +> in-map-name="serviceCtx"/>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> short-description="Test case for service createFinAccountRole"
>> login-required="false">
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> in-map-name="serviceCtx"/>
>> +
>> +
>> +
>> +> value="INTERNAL_ORGANIZATIO"/>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +> short-description="Test case for service createFinAccountTrans"
>> login-required="false">
>> +
>> +> value="ADJUSTMENT"/>
>> +
>> +
>> +
>> +
>> +> in-map-name="serviceCtx"/>
>> +> entity-name="FinAccountTrans">
>> +
>> +
>> +> list="finAccountTransList"/>
>> +
>> +
>> +> field="finAccountTrans.finAccountTransTypeId">
>> +
>> +
>> +
>> +> short-description="

Re: svn commit: r1767974 - /ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests .xml

2016-11-14 Thread Deepak Dixit
Hi Jacques,

I fixed party test case at r#1769645, and accounting test cases at r#1769650.
There is an bug in EntityAutoEngine that was causing the failure. Open
ticket for the same https://issues.apache.org/jira/browse/OFBIZ-9117.
To fix test cases I simply converted createInvoiceContactMech form
entity-auto to simple method. Now all test cases passes successfully.



Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Thu, Nov 10, 2016 at 5:21 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Deepak,
>
> You are not the only one concerned, I guess ;).
>
> I did not check, does someone know if the last 11 failures an sole error
> are due to new tests or regressions?
>
> Thanks
>
> Jacques
>
>
>
> Le 07/11/2016 à 16:08, Deepak Dixit a écrit :
>
>> Let me check Jacques.
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> www.hotwaxsystems.com
>>
>> On Mon, Nov 7, 2016 at 8:02 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> Hi Deepak, All,
>>>
>>> This commit puts in 86 failures, tests were successful just before. I
>>> guess most of them have been fixed since but according to BuildBot we
>>> have
>>> still 32 failures and one errors
>>>
>>> https://ci.apache.org/builders/ofbiz-trunk
>>>
>>> https://ci.apache.org/projects/ofbiz/logs/trunk/html/
>>>
>>> Not sure some are still related with r1767974, but anyway we need to fix
>>> all of them before going ahead.
>>> Else it will become more and more uneasy to track from which commit/s
>>> these errors come, hence harder to fix them
>>>
>>> So I suggest to fix them before continuing to commit
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 03/11/2016 à 22:03, dee...@apache.org a écrit :
>>>
>>> Author: deepak
>>>> Date: Thu Nov  3 21:03:13 2016
>>>> New Revision: 1767974
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1767974&view=rev
>>>> Log:
>>>> Improved: Added missing file for accounting fin service test cases.
>>>>
>>>> Added:
>>>>   ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>>>> inAccountTests.xml
>>>>   (with props)
>>>>
>>>> Added: ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>>>> inAccountTests.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accoun
>>>> ting/minilang/test/AutoAcctgFinAccountTests.xml?rev=1767974&view=auto
>>>> 
>>>> ==
>>>> --- ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>>>> inAccountTests.xml
>>>> (added)
>>>> +++ ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgF
>>>> inAccountTests.xml
>>>> Thu Nov  3 21:03:13 2016
>>>> @@ -0,0 +1,182 @@
>>>> +
>>>> +
>>>> +
>>>> +http://www.w3.org/2001/XMLSchema-instance";
>>>> +xmlns="http://ofbiz.apache.org/Simple-Method";
>>>> xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
>>>> http://ofbiz.apache.org/dtds/simple-methods.xsd";>
>>>> +>>> short-description="Test case for service deleteFinAccountRole"
>>>> login-required="false">
>>>> +
>>>> +
>>>> +
>>>> +>>> type="Timestamp"/>
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> in-map-name="serviceCtx"/>
>>>> +>>> entity-name="FinAccountRole">
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> list="finAccountRoles"/>
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> short-description="Test case for service updateFinAccountRole"
>>>> login-required="false">
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> type="Timestamp"/

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.01

2016-11-23 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Wed, Nov 23, 2016 at 6:50 PM, Anahita Goljahani <
anahita.goljah...@gmail.com> wrote:

> +1
>
> Kind regards
>
> Anahita
>
> 2016-11-21 19:51 GMT+01:00 Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com>:
>
> > This is the vote thread to issue the first release from the branch
> > "release16.11".
> >
> > The name of the new release will be "Apache OFBiz 16.11.01".
> >
> > The release files can be downloaded from here:
> >
> > https://dist.apache.org/repos/dist/dev/ofbiz/
> >
> > and are:
> >
> > * apache-ofbiz-16.11.01.zip: the actual release file
> >
> > * KEYS: file with keys
> >
> > * apache-ofbiz-16.11.01.zip.asc: the detached signature file
> >
> > * apache-ofbiz-16.11.01.zip.md5, apache-ofbiz-16.11.01.zip.sha: hashes
> >
> > Vote:
> >
> > [ +1] release as Apache OFBiz 16.11.01
> >
> > [ -1] do not release
> >
> > This vote will be open for 5 days.
> >
> > For more details about this process please read
> > http://www.apache.org/foundation/voting.html
> >
> > You can download and test the zip file and its signature and hashes (for
> > instructions on testing the signature see
> > http://www.apache.org/info/verification.html).
> >
> > Kind Regards,
> >
> > Jacopo
> >
>


Re: buildbot failure in on ofbiz-trunk

2016-11-29 Thread Deepak Dixit
I think its an false report, as  testIntegration return success on local
box.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Tue, Nov 29, 2016 at 11:47 PM,  wrote:

> The Buildbot has detected a new failure on builder ofbiz-trunk while
> building . Full details are available at:
> https://ci.apache.org/builders/ofbiz-trunk/builds/1765
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit'
> triggered this build
> Build Source Stamp: [branch ofbiz/trunk] 1771935
> Blamelist: deepak
>
> BUILD FAILED: failed shell_1
>
> Sincerely,
>  -The Buildbot
>
>
>
>


Re: Empty folders

2014-03-24 Thread Deepak Dixit
HI Jacques,

We have also an empty folder tmp in runtime. This is used for content upload 
purpose. And if we deployed ofbiz using git then content upload process does 
now working and its return error.

Thanks & Regards
-- 
Deepak Dixit

On Mar 24, 2014, at 1:37 PM, Pierre Smits wrote:

> I would say that there is no need to keep these given that they don't hold
> content. If empty folders do serve a purpose (e.g. the hot-deploy folder
> and lib folders in components), it should hold a readme doc explaining the
> purpose.
> 
> Regards,
> 
> Pierre Smits
> 
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com



smime.p7s
Description: S/MIME cryptographic signature


Re: Help required to assign components to Jira tickets

2014-04-22 Thread Deepak Dixit
Hi Jacopo,

I am also not able to edit the task meta deta. Is this related to jira user 
group permission?

Thanks & Regards
-- 
Deepak Dixit


On Apr 22, 2014, at 9:35 PM, Jacopo Cappellato wrote:

> it may be related to Jira user rights; are you logged in?
> 
> Jacopo
> 
> On Apr 22, 2014, at 5:45 PM, Taher Alkhateeb  
> wrote:
> 
>> Hi Jacopo, 
>> 
>> I would like to help, but it seems I cannot edit the meta-data on any of the 
>> listed tickets in your search. Is this a request of committers or are you 
>> asking the community for help? 
>> 
>> Best, 
>> 
>> Taher Alkhateeb 
>> 
>> - Original Message -
>> 
>> From: "Jacques Le Roux"  
>> To: dev@ofbiz.apache.org 
>> Sent: Tuesday, April 22, 2014 6:03:54 PM 
>> Subject: Re: Help required to assign components to Jira tickets 
>> 
>> Hi Jacopo, 
>> 
>> I sure can help. 
>> 
>> Thanks for your continued effort on Jira issues, much appreciated! 
>> 
>> Jacques 
>> 
>> Le 22/04/2014 13:49, Jacopo Cappellato a écrit : 
>>> Hi all, 
>>> 
>>> there are currently 71 Jira tickets that are open without a component 
>>> specified: 
>>> 
>>> https://issues.apache.org/jira/browse/OFBIZ-2475?jql=project%20%3D%20OFBIZ%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20is%20EMPTY%20ORDER%20BY%20priority%20DESC
>>>  
>>> 
>>> I have categorized a few of them but we definitely need some help to assign 
>>> one or more components to each of them. Volunteers? 
>>> 
>>> Thanks, 
>>> 
>>> Jacopo 
>>> 
>>> 
>>> 
>>> 
>>> 
>> 
>> -- 
>> 
> 



Re: Help required to assign components to Jira tickets

2014-04-23 Thread Deepak Dixit
Thanks Jacopo for the update.


Thanks & Regards
-- 
Deepak Dixit

On Apr 23, 2014, at 1:14 PM, Jacopo Cappellato wrote:

> Ok,
> 
> so it seems that only committers have the rights to edit a ticket that is not 
> assigned to them. Let's see if the committer group can edit all the issues, 
> if not we will explore the possibility to grant some Jira rights to other 
> contributors.
> 
> Jacopo
> 
> 
> On Apr 23, 2014, at 9:26 AM, Christian Geisert 
>  wrote:
> 
>> Am 23.04.2014 06:45, schrieb Deepak Dixit:
>>> Hi Jacopo,
>>> 
>>> I am also not able to edit the task meta deta. Is this related to jira user 
>>> group permission?
>>> 
>>> Thanks & Regards
>>> 
>> 
>> I just tried it. Log in, click on Edit, then select component and click
>> on Update works for me.
>> 
>> Christian
>> 
> 



Re: The official demos are back

2014-06-22 Thread Deepak Dixit

Thanks Jacques..

Thanks & Regards
—
Deepak Dixit

On Jun 22, 2014, at 8:29 PM, Jacques Le Roux  
wrote:

> Hi,
> 
> I'm happy to announce that eventually all the demos are back. The main page 
> is updated to reflect that: http://ofbiz.apache.org/
> 
> You can also get to the trunk demo using
> http://demo-trunk-ofbiz.apache.org/ecommerce/control/main
> http://demo-trunk-ofbiz.apache.org/catalog/control/main?USERNAME=flexadmin&PASSWORD=ofbiz&JavaScriptEnabled=Y
> 
> Two things which are worth to be noted have changed.
> 1) The sub domains are no longer demo-*.ofbiz.apache.org but 
> demo-*-ofbiz.apache.org
> 2) Internally OFBiz no longer uses HTTPS in these demos. The security is done 
> by the infra team which is proxying all calls. The official ASF certificate 
> is used for all demos.
> 
> Enjoy
> 
> Jacques



smime.p7s
Description: S/MIME cryptographic signature


Re: Welcome Sharan Foga as new committer

2014-07-24 Thread Deepak Dixit
Congratulations Sharan..!!


Thanks & Regards
—
Deepak Dixit

On Jul 24, 2014, at 12:48 PM, Jacopo Cappellato 
 wrote:

> This is just to inform you all that the OFBiz PMC has invited Sharan to 
> become a new committer and she has accepted the invitation: welcome aboard 
> Sharan!
> 
> Thank you
> 
> Jacopo



smime.p7s
Description: S/MIME cryptographic signature


Re: Proposal: merging framework/images into framework/resources

2014-09-18 Thread Deepak Dixit
Hi Folks,

Any update on this?

IMO moving static resources from images to resources is good. 
We can do logical grouping as well to make it easily readable ie. we can move 
all the js files and library under resources/js and same applies to css and 
images (related to js and css file) as well.


Thanks & Regards
—
Deepak Dixit


On Jul 18, 2012, at 5:23 PM, Jacques Le Roux  
wrote:

> From: "Jacopo Cappellato" 
>> On Jul 16, 2012, at 11:50 AM, Adrian Crum wrote:
>> 
>>>> The next steps for the future will be to move out of the framework the 
>>>> folders in the "images" application that are specific to
>>>> applications (somewhere under runtime seems a good approach).
>>> 
>>> Some of the application-specific content could be used by other 
>>> applications, so it should stay in the resources component.
>>> Anything that is truly application-specific should be kept in the 
>>> application. The application-specific content can be added to
>>> the application's URL path. If that causes problems with other applications 
>>> trying to access it (I'm thinking of the product
>>> content), then we might need to re-engineer some things to accommodate 
>>> that. Putting content in the runtime folder sounds odd to
>>> me.
>> 
>> The goal that I would like to achieve in the long term is the following: the 
>> framework/applications folders, once deployed should
>> be read only and should not contain files that are generated at runtime
> 
> +1, it has allways disturbed me (not too much though)
> 
>> ; at the moment the images folder is an exception because, for example, when 
>> you upload an image the image is stored under
>> framework/images/webapp/images (by default); for this I think that runtime 
>> would be a better fit.
> 
> Why not a JackRabbit content repo? I think, in the long term, it would give 
> us more power on content. This could be a second phase though, since 
> JackRabbit could relies on runtime folder/s.
> 
>> On the other hand I agree that static resources could be hosted in the 
>> respective component.
> 
> I agree too, easier to retrieve, but those have to be really static 
> resources. In my opininon, any not static content resources should be handled 
> by JackRabbit embedeed inside of OFBiz. I did not work on it yet, may be 
> using it beside/outside could be done. But, since Sascha has already done a 
> part of the work, I think this (JackRabbit embedded) should be really 
> envisioned by the team and discussed before coding only our own (of course 
> the idea is to delegate as much a possible).
> 
> Jacques
> 
>> 
>> But I am not planning to work on this sometime soon... we have time to think.
>> 
>> Jacopo



smime.p7s
Description: S/MIME cryptographic signature


Re: Proposal: merging framework/images into framework/resources

2014-09-19 Thread Deepak Dixit
Here is the task id for the same OFBIZ-5776

Thanks & Regards
—
Deepak Dixit

On Sep 18, 2014, at 5:23 PM, Deepak Dixit  wrote:

> Hi Folks,
> 
> Any update on this?
> 
> IMO moving static resources from images to resources is good. 
> We can do logical grouping as well to make it easily readable ie. we can move 
> all the js files and library under resources/js and same applies to css and 
> images (related to js and css file) as well.
> 
> 
> Thanks & Regards
> —
> Deepak Dixit
> 
> 
> On Jul 18, 2012, at 5:23 PM, Jacques Le Roux  
> wrote:
> 
>> From: "Jacopo Cappellato" 
>>> On Jul 16, 2012, at 11:50 AM, Adrian Crum wrote:
>>> 
>>>>> The next steps for the future will be to move out of the framework the 
>>>>> folders in the "images" application that are specific to
>>>>> applications (somewhere under runtime seems a good approach).
>>>> 
>>>> Some of the application-specific content could be used by other 
>>>> applications, so it should stay in the resources component.
>>>> Anything that is truly application-specific should be kept in the 
>>>> application. The application-specific content can be added to
>>>> the application's URL path. If that causes problems with other 
>>>> applications trying to access it (I'm thinking of the product
>>>> content), then we might need to re-engineer some things to accommodate 
>>>> that. Putting content in the runtime folder sounds odd to
>>>> me.
>>> 
>>> The goal that I would like to achieve in the long term is the following: 
>>> the framework/applications folders, once deployed should
>>> be read only and should not contain files that are generated at runtime
>> 
>> +1, it has allways disturbed me (not too much though)
>> 
>>> ; at the moment the images folder is an exception because, for example, 
>>> when you upload an image the image is stored under
>>> framework/images/webapp/images (by default); for this I think that runtime 
>>> would be a better fit.
>> 
>> Why not a JackRabbit content repo? I think, in the long term, it would give 
>> us more power on content. This could be a second phase though, since 
>> JackRabbit could relies on runtime folder/s.
>> 
>>> On the other hand I agree that static resources could be hosted in the 
>>> respective component.
>> 
>> I agree too, easier to retrieve, but those have to be really static 
>> resources. In my opininon, any not static content resources should be 
>> handled by JackRabbit embedeed inside of OFBiz. I did not work on it yet, 
>> may be using it beside/outside could be done. But, since Sascha has already 
>> done a part of the work, I think this (JackRabbit embedded) should be really 
>> envisioned by the team and discussed before coding only our own (of course 
>> the idea is to delegate as much a possible).
>> 
>> Jacques
>> 
>>> 
>>> But I am not planning to work on this sometime soon... we have time to 
>>> think.
>>> 
>>> Jacopo
> 



smime.p7s
Description: S/MIME cryptographic signature


Re: svn commit: r1626385 - /ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml

2014-09-20 Thread Deepak Dixit
Thanks Adrian for review. New patch has been uploaded using clone-value tag to 
clone the immutable generic value.

Thanks & Regards
—
Deepak Dixit

On Sep 20, 2014, at 12:13 PM, Adrian Crum  
wrote:

> This doesn't fix the problem, it only hides it. If client code wants to 
> modify an immutable GenericValue, then it needs to copy it.
> 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
> 
> On 9/20/2014 7:16 AM, ash...@apache.org wrote:
>> Author: ashish
>> Date: Sat Sep 20 06:16:29 2014
>> New Revision: 1626385
>> 
>> URL: http://svn.apache.org/r1626385
>> Log:
>> Applied patch from jira issue - OFBIZ-5739 - 
>> copyContentAndElectronicTextandAssoc service broken.
>> Thanks Deepak Dixit for the contribution.
>> 
>> Modified:
>> 
>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>> 
>> Modified: 
>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml?rev=1626385&r1=1626384&r2=1626385&view=diff
>> ==
>> --- 
>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>  (original)
>> +++ 
>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>  Sat Sep 20 06:16:29 2014
>> @@ -159,10 +159,7 @@
>>  
>> 
>>  > short-description="copy a content, electronic text and assocs and set status 
>> in progress">
>> -> to-map="getC"/>
>> -
>> -
>> -
>> +
>>  
>>  > map="content" to-map="getEt"/>
>>  > in-map-name="getEt">
>> 
>> 



smime.p7s
Description: S/MIME cryptographic signature


Re: Welcome Sharan Foga as new PMC member

2014-09-22 Thread Deepak Dixit
Congratulations Sharan!

Thanks & Regards
—
Deepak Dixit


On Sep 22, 2014, at 3:04 PM, Adrian Crum  
wrote:

> Congrats Sharan!
> 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
> 
> On 9/22/2014 10:29 AM, Jacopo Cappellato wrote:
>> Please welcome Shara Foga in the OFBiz PMC.
>> 
>> Congratulation Sharan! I am very happy to have you onboard and I am sure all 
>> the other PMC members feel the same.
>> 
>> Jacopo
>> 



smime.p7s
Description: S/MIME cryptographic signature


Re: Welcome Nicolas Malin as new committer!

2014-09-26 Thread Deepak Dixit
Congrats Nicolas..


Thanks & Regards
—
Deepak Dixit

On Sep 26, 2014, at 10:25 PM, Jacopo Cappellato 
 wrote:

> The OFBiz PMC has invited Nicolas to become a new committer and he has 
> accepted the new role: Nicolas is a skilled developer and he knows the OFBiz 
> codebase quite well; but most of all Nicolas
> is committed to the project and has always showed a positive and 
> collaborative attitude. Please welcome him onboard!
> 
> Thank you
> 
> Jacopo



smime.p7s
Description: S/MIME cryptographic signature


Re: Wiki Coding conventions

2014-09-29 Thread Deepak Dixit
+1

Thanks & Regards
—
Deepak Dixit

On Sep 29, 2014, at 5:43 PM, Pranay Pandey  
wrote:

> 
> Hi Nicolas,
> 
> Its a good idea to complete those TODOs, If you are not sure about any 
> specific item you are planning to add, it can be discussed over mailing list 
> for sure.
> 
> Pranay Pandey
> HotWax Media
> http://www.hotwaxmedia.com
> ApacheCon US 2014 Silver Sponsor
> http://na.apachecon.com/sponsor/our-sponsors
> 
> 
> On Sep 29, 2014, at 5:33 PM, Nicolas Malin  wrote:
> 
>> In the wiki, we have some coding conventions here 
>> https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions with 
>> a "few" TODO.
>> 
>> I propose to complete some TODO directly on the wiki or you prefer exchange 
>> before on the mailing list ?
>> 
>> Nicolas
>> 
>> -- 
>> 
>> Nicolas Malin - Consultant - 06 17 66 40 06 -- http://nereide.fr
>> 
> 



smime.p7s
Description: S/MIME cryptographic signature


Re: Housekeeping of the OFBiz svn tree: removing some old/unused experimental branches

2014-09-30 Thread Deepak Dixit
We can remove jquery branch for sure, as we merged moved to jquery library 
completely.


Thanks & Regards
—
Deepak Dixit

On Sep 30, 2014, at 1:32 PM, Jacopo Cappellato 
 wrote:

> New list after Adrian's feedback:
> 
>   • 2015ScreenWidgetRedesign/
>   • 20111205EmailHandling/
>   • 20120209RemoveBsh/
>   • 20120329_portletWidget/
>   • 2013_RemoveJavolution/
>   • addbirt/
>   • executioncontext20090716/
>   • executioncontext20090812/
>   • frontendNewTheme2013-05-10/
>   • htmlfive_20110529/
>   • improved-entityengine-features-20120528/
>   • jackrabbit20100709/
>   • jquery/
>   • multitenant20100310/
>   • webhelp-2012-12-07/
> 
> Jacopo
> 
> On Sep 30, 2014, at 9:59 AM, Adrian Crum  
> wrote:
> 
>> executioncontext20091231
>> 
>> is a working copy of the security redesign:
>> 
>> https://cwiki.apache.org/confluence/display/OFBTECH/OFBiz+Security+Redesign
>> 
>> I still hope there will be some interest in it some day.
>> 
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>> 
>> On 9/30/2014 8:31 AM, Jacopo Cappellato wrote:
>>> What do you think about removing some old and no more active experimental 
>>> branches? Please let me know what are the ones we should keep.
>>> 
>>> Here is the current list of experimental branches (*):
>>> 
>>> • 2015ScreenWidgetRedesign/
>>> • 20111205EmailHandling/
>>> • 20120209RemoveBsh/
>>> • 20120329_portletWidget/
>>> • 2013_RemoveJavolution/
>>> • OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23/
>>> • addbirt/
>>> • executioncontext20090716/
>>> • executioncontext20090812/
>>> • executioncontext20091231/
>>> • frontendNewTheme2013-05-10/
>>> • htmlfive_20110529/
>>> • improved-entityengine-features-20120528/
>>> • jackrabbit20100709/
>>> • jackrabbit20120501/
>>> • jquery/
>>> • multitenant20100310/
>>> • webhelp-2012-12-07/
>>> 
>>> Regards,
>>> 
>>> Jacopo
>>> 
>>> 
>>> (*) https://svn.apache.org/repos/asf/ofbiz/branches/
>>> 
> 



smime.p7s
Description: S/MIME cryptographic signature


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

2014-09-30 Thread Deepak Dixit
-1 

ecommerce is broken on release13.07 branch, "ReferenceError: jQuery is not 
defined” error occurred on js console. It might be due to query library update, 
Need to fix the js path for ecommerce component.


Thanks & Regards
—
Deepak Dixit

On Sep 30, 2014, at 1:16 PM, Jacopo Cappellato 
 wrote:

> This is the vote thread to publish the first release from the "release13.07" 
> branch.
> For a description of release naming and strategy see 
> http://ofbiz.apache.org/download.html
> 
> The release files can be downloaded from here:
> 
> https://dist.apache.org/repos/dist/dev/ofbiz/
> 
> and are:
> 
> * apache-ofbiz-13.07.01.zip
> * KEYS: text file with keys
> * apache-ofbiz-13.07.01.zip.asc: the detached signature file
> * apache-ofbiz-13.07.01.zip.md5, apache-ofbiz-13.07.01.zip.sha: checksum 
> hashes
> 
> Please download and test the zip file (*) and its signature and checksums 
> (for instructions see http://www.apache.org/info/verification.html).
> 
> Vote:
> 
> [ +1] release as Apache OFBiz 13.07.01
> [ -1] do not release
> 
> This vote will be open for about 5 days.
> For more details about this process please read 
> http://www.apache.org/foundation/voting.html
> 
> Kind Regards,
> 
> Jacopo
> 
> (*) run at least:
> ant load-demo run-tests
> and verify that all tests are successful
> 



smime.p7s
Description: S/MIME cryptographic signature


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01

2014-09-30 Thread Deepak Dixit
Open ticket for the issue and attached patch for the fix.
Here is the link for ticket https://issues.apache.org/jira/browse/OFBIZ-5789

Thanks & Regards
—
Deepak Dixit


On Sep 30, 2014, at 1:57 PM, Jacopo Cappellato 
 wrote:

> ouch... thanks for catching this Deepak!
> 
> Let's cancel this vote for now.
> 
> Jacopo
> 
> On Sep 30, 2014, at 10:23 AM, Deepak Dixit  
> wrote:
> 
>> -1 
>> 
>> ecommerce is broken on release13.07 branch, "ReferenceError: jQuery is not 
>> defined” error occurred on js console. It might be due to query library 
>> update, Need to fix the js path for ecommerce component.
>> 
>> 
>> Thanks & Regards
>> —
>> Deepak Dixit
>> 
>> On Sep 30, 2014, at 1:16 PM, Jacopo Cappellato 
>>  wrote:
>> 
>>> This is the vote thread to publish the first release from the 
>>> "release13.07" branch.
>>> For a description of release naming and strategy see 
>>> http://ofbiz.apache.org/download.html
>>> 
>>> The release files can be downloaded from here:
>>> 
>>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>> 
>>> and are:
>>> 
>>> * apache-ofbiz-13.07.01.zip
>>> * KEYS: text file with keys
>>> * apache-ofbiz-13.07.01.zip.asc: the detached signature file
>>> * apache-ofbiz-13.07.01.zip.md5, apache-ofbiz-13.07.01.zip.sha: checksum 
>>> hashes
>>> 
>>> Please download and test the zip file (*) and its signature and checksums 
>>> (for instructions see http://www.apache.org/info/verification.html).
>>> 
>>> Vote:
>>> 
>>> [ +1] release as Apache OFBiz 13.07.01
>>> [ -1] do not release
>>> 
>>> This vote will be open for about 5 days.
>>> For more details about this process please read 
>>> http://www.apache.org/foundation/voting.html
>>> 
>>> Kind Regards,
>>> 
>>> Jacopo
>>> 
>>> (*) run at least:
>>> ant load-demo run-tests
>>> and verify that all tests are successful
>>> 
>> 
> 



smime.p7s
Description: S/MIME cryptographic signature


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01 (2nd)

2014-10-01 Thread Deepak Dixit
+1

Thanks & Regards
—
Deepak Dixit

On Oct 1, 2014, at 12:11 PM, Jacopo Cappellato  
wrote:

> This is the (second, after the first was cancelled) vote thread to publish 
> the first release from the "release13.07" branch.
> For a description of release naming and strategy see 
> http://ofbiz.apache.org/download.html
> 
> The release files can be downloaded from here:
> 
> https://dist.apache.org/repos/dist/dev/ofbiz/
> 
> and are:
> 
> * apache-ofbiz-13.07.01.zip
> * KEYS: text file with keys
> * apache-ofbiz-13.07.01.zip.asc: the detached signature file
> * apache-ofbiz-13.07.01.zip.md5, apache-ofbiz-13.07.01.zip.sha: checksum 
> hashes
> 
> Please download and test the zip file (*) and its signature and checksums 
> (for instructions see http://www.apache.org/info/verification.html).
> 
> Vote:
> 
> [ +1] release as Apache OFBiz 13.07.01
> [ -1] do not release
> 
> This vote will be open for about 5 days.
> For more details about this process please read 
> http://www.apache.org/foundation/voting.html
> 
> Kind Regards,
> 
> Jacopo
> 
> (*) run at least:
> ant load-demo run-tests
> and verify that all tests are successful



smime.p7s
Description: S/MIME cryptographic signature


Unnecessary code in ofbiz-component.xml of accounting component

2009-10-11 Thread Deepak Dixit


I was just looking through accounting component and found that three 
claspath entries are unnecessary exists there i.e location="lib/cybersource/*"/>


.

I think this is mistakenly left there. Due to this a warning comes at 
the time of starting server i.e. 
"${ofbiz_home}/applications/accounting/lib/cybersource' does not exist " 
and "${ofbiz_home}/applications/accounting/lib/worldpay' does not exist".


Solution for this either can be remove these entries or add folders with 
the respective names for future use.


Regards
-
Deepak Dixit


Re: svn commit: r826266 - in /ofbiz/trunk/applications: humanres/data/ humanres/webapp/humanres/WEB-INF/ humanres/widget/ party/webapp/partymgr/WEB-INF/ party/widget/partymgr/

2009-10-19 Thread Deepak Dixit

Hello Jacques,

Due to this commit data not loaded .Following error occured:
Key (user_login_id)=(DemoEmployee) is not present in table "user_login".))

Thanks
-----
Deepak Dixit

comment inline:

jler...@apache.org wrote:

Author: jleroux
Date: Sat Oct 17 15:05:32 2009
New Revision: 826266

URL: http://svn.apache.org/viewvc?rev=826266&view=rev
Log:
merged by hand from Simranjeet Singh's HR_Training_improvements.patch in " 
Enhancements in Trainings under HR module" 
(https://issues.apache.org/jira/browse/OFBIZ-2531) - OFBIZ-2531
Please see this issue for more, it's enough complicated as is...
In one word this patch was waiting comments for near a month and 
https://issues.apache.org/jira/browse/OFBIZ-3046 decided me to act!

Modified:
ofbiz/trunk/applications/humanres/data/HumanResDemoData.xml
ofbiz/trunk/applications/humanres/webapp/humanres/WEB-INF/controller.xml
ofbiz/trunk/applications/humanres/widget/CommonScreens.xml
ofbiz/trunk/applications/humanres/widget/EmployeeScreens.xml
ofbiz/trunk/applications/humanres/widget/Menus.xml
ofbiz/trunk/applications/humanres/widget/PersonTrainingScreens.xml
ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml
ofbiz/trunk/applications/party/widget/partymgr/CommonScreens.xml

Modified: ofbiz/trunk/applications/humanres/data/HumanResDemoData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResDemoData.xml?rev=826266&r1=826265&r2=826266&view=diff
==
--- ofbiz/trunk/applications/humanres/data/HumanResDemoData.xml (original)
+++ ofbiz/trunk/applications/humanres/data/HumanResDemoData.xml Sat Oct 17 
15:05:32 2009
@@ -34,6 +34,10 @@
 
 
 

+
+
+
  

This entry generates error, I think this is mistakenly added.

+
 



Re: Fwd: svn commit: r829392 - in /ofbiz/trunk/applications/accounting/widget: ap/CommonScreens.xml ar/CommonScreens.xml

2009-10-26 Thread Deepak Dixit
Just for information, these changes are done because when this decorator 
is called, the location of decorator is given mainDecoratorLocation and 
in AP/AR mainDecoratorLocation is their CommonScreens.xml file.


The same problem occurs with 
CommonOrganizationAccountingReportsDecorator and CommonAdminChecksDecorator.


Thanks and Regards
--
Deepak Dixit


Anil Patel wrote:
Note to myself, There is something not so good in this commit, will 
review and come back to it soon.


Thanks and Regards
Anil Patel
HotWax Media Inc
http://www.hotwaxmedia.com
http://us.apachecon.com/c/acus2009/sponsors/sponsors

Begin forwarded message:


From: jler...@apache.org
Date: October 24, 2009 11:49:24 AM EDT
To: comm...@ofbiz.apache.org
Subject: svn commit: r829392 - in 
/ofbiz/trunk/applications/accounting/widget: ap/CommonScreens.xml 
ar/CommonScreens.xml

Reply-To: dev@ofbiz.apache.org

Author: jleroux
Date: Sat Oct 24 15:49:23 2009
New Revision: 829392

URL: http://svn.apache.org/viewvc?rev=829392&view=rev
Log:
A patch from Deepak Dixit "Could not find screen with name 
[CommonPartyDecorator]." 
(https://issues.apache.org/jira/browse/OFBIZ-3080) - OFBIZ-3080

Steps to generate error:
1) Go to AP/AR.
2) Select Invoice.
3) Search Invoices.
4) Select an Invoice.
5) Click on Acctg Trans Id

Modified:
   ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml
   ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml

Modified: 
ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff 

== 

--- ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml 
(original)
+++ ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml 
Sat Oct 24 15:49:23 2009

@@ -344,4 +344,27 @@



+
+
+
+
+from-field="parameters.organizationPartyId" global="true"/>

+
+
+location="${parameters.mainDecoratorLocation}">

+
+
+
+field="organizationPartyId"/>

+
+
+location="component://accounting/widget/AccountingMenus.xml"/>
+name="body"/>

+
+
+
+
+
+
+

\ No newline at end of file

Modified: 
ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml?rev=829392&r1=829391&r2=829392&view=diff 

== 

--- ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml 
(original)
+++ ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml 
Sat Oct 24 15:49:23 2009

@@ -178,5 +178,28 @@



+
+
+
+
+from-field="parameters.organizationPartyId" global="true"/>

+
+
+location="${parameters.mainDecoratorLocation}">

+
+
+
+field="organizationPartyId"/>

+
+
+location="component://accounting/widget/AccountingMenus.xml"/>
+name="body"/>

+
+
+
+
+
+
+


\ No newline at end of file









Re: svn commit: r831920 - in /ofbiz/trunk/applications/accounting: webapp/accounting/WEB-INF/ webapp/ap/WEB-INF/ webapp/ar/WEB-INF/ widget/ widget/ap/ widget/ar/

2009-11-02 Thread Deepak Dixit
Same problem occurs with CommonOrganizationAccountingReportsDecorator 
and CommonAdminChecksDecorator.


Thanks & Regards
-----
Deepak Dixit

apa...@apache.org wrote:

Author: apatel
Date: Mon Nov  2 15:32:39 2009
New Revision: 831920

URL: http://svn.apache.org/viewvc?rev=831920&view=rev
Log:
Removed duplicate definition of CommonPartyDecorator. Added 
partyDecoratorLocation parameter to ar/ap web.xml file so they can find 
CommonPartyDecorator.
This issues was discussed on list after r829392 commit in response to patch on 
OFBIZ-3080.
 


Modified:
ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/web.xml
ofbiz/trunk/applications/accounting/webapp/ap/WEB-INF/web.xml
ofbiz/trunk/applications/accounting/webapp/ar/WEB-INF/web.xml
ofbiz/trunk/applications/accounting/widget/CommonScreens.xml
ofbiz/trunk/applications/accounting/widget/GlScreens.xml
ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
ofbiz/trunk/applications/accounting/widget/ap/CommonScreens.xml
ofbiz/trunk/applications/accounting/widget/ar/CommonScreens.xml

Modified: ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/web.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/web.xml?rev=831920&r1=831919&r2=831920&view=diff
==
--- ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/web.xml 
(original)
+++ ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/web.xml Mon 
Nov  2 15:32:39 2009
@@ -49,6 +49,11 @@
 
component://accounting/widget/CommonScreens.xml
 The location of the main-decorator screen to use for this 
webapp; referred to as a context variable in screen def XML files.
 
+
+partyDecoratorLocation
+
component://accounting/widget/CommonScreens.xml
+The location of the CommonPartyDecorator screen to use for this 
webapp; referred to as a context variable in screen def XML files.
+
 
 

 ContextFilter

Modified: ofbiz/trunk/applications/accounting/webapp/ap/WEB-INF/web.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/ap/WEB-INF/web.xml?rev=831920&r1=831919&r2=831920&view=diff
==
--- ofbiz/trunk/applications/accounting/webapp/ap/WEB-INF/web.xml (original)
+++ ofbiz/trunk/applications/accounting/webapp/ap/WEB-INF/web.xml Mon Nov  2 
15:32:39 2009
@@ -45,6 +45,11 @@
 
component://accounting/widget/ap/CommonScreens.xml
 The location of the main-decorator screen to use for this 
webapp; referred to as a context variable in screen def XML files.
 
+
+partyDecoratorLocation
+
component://accounting/widget/CommonScreens.xml
+The location of the CommonPartyDecorator screen to use for this 
webapp; referred to as a context variable in screen def XML files.
+
 
 

 ContextFilter

Modified: ofbiz/trunk/applications/accounting/webapp/ar/WEB-INF/web.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/ar/WEB-INF/web.xml?rev=831920&r1=831919&r2=831920&view=diff
==
--- ofbiz/trunk/applications/accounting/webapp/ar/WEB-INF/web.xml (original)
+++ ofbiz/trunk/applications/accounting/webapp/ar/WEB-INF/web.xml Mon Nov  2 
15:32:39 2009
@@ -49,6 +49,11 @@
 
component://accounting/widget/ar/CommonScreens.xml
 The location of the main-decorator screen to use for this 
webapp; referred to as a context variable in screen def XML files.
 
+
+partyDecoratorLocation
+
component://accounting/widget/CommonScreens.xml
+The location of the CommonPartyDecorator screen to use for this 
webapp; referred to as a context variable in screen def XML files.
+
 
 

 ContextFilter

Modified: ofbiz/trunk/applications/accounting/widget/CommonScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/CommonScreens.xml?rev=831920&r1=831919&r2=831920&view=diff
==
--- ofbiz/trunk/applications/accounting/widget/CommonScreens.xml (original)
+++ ofbiz/trunk/applications/accounting/widget/CommonScreens.xml Mon Nov  2 
15:32:39 2009
@@ -138,7 +138,7 @@
 
 
 
-
+
 
 
 
@@ -161,7 +161,7 @@
 
 
 
-
+
 
 
 

Modified: ofbiz/trunk/applications/accounting/widget/GlScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widge

Re: svn commit: r832294 - in /ofbiz/trunk: applications/marketing/config/ applications/marketing/webapp/sfa/WEB-INF/ applications/marketing/widget/sfa/ applications/marketing/widget/sfa/forms/ applica

2009-11-02 Thread Deepak Dixit

I am facing this problem with java 6.

Wickersheimer Jeremy wrote:
This is a Java 5 issue which does not support @Override on interface methods whereas Java 
6 does.


  



Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548



Re: Getting error while running server

2009-11-05 Thread Deepak Dixit

This is due to commit no 833294.

==
--- ofbiz/trunk/framework/base/config/ofbiz-containers.xml (original)
+++ ofbiz/trunk/framework/base/config/ofbiz-containers.xml Fri Nov  6 03:55:56 
2009
@@ -256,6 +256,14 @@



+
+

+
+
+
+
+
+



Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548





Brajesh Patel wrote:

Hello All,
Not able to run server due to following:

org.ofbiz.base.start.StartupException: Cannot locate container class 
(org.ofbiz.birt.container.BirtContainer)
   at 
org.ofbiz.base.container.ContainerLoader.loadContainer(ContainerLoader.java:164) 

   at 
org.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:65)

   at org.ofbiz.base.start.Start.initStartLoaders(Start.java:258)
   at org.ofbiz.base.start.Start.init(Start.java:96)
   at org.ofbiz.base.start.Start.main(Start.java:409)
java.lang.ClassNotFoundException: org.ofbiz.birt.container.BirtContainer
   at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
   at 
org.ofbiz.base.util.CachedClassLoader.loadClass(CachedClassLoader.java:186) 

   at 
org.ofbiz.base.util.CachedClassLoader.loadClass(CachedClassLoader.java:160) 

   at 
org.ofbiz.base.container.ContainerLoader.loadContainer(ContainerLoader.java:162) 

   at 
org.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:65)

   at org.ofbiz.base.start.Start.initStartLoaders(Start.java:258)
   at org.ofbiz.base.start.Start.init(Start.java:96)
   at org.ofbiz.base.start.Start.main(Start.java:409)
java.lang.ClassNotFoundException: org.ofbiz.birt.container.BirtContainer
   at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(URLClassLoader.java:188)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
   at 
org.ofbiz.base.util.CachedClassLoader.loadClass(CachedClassLoader.java:186) 

   at 
org.ofbiz.base.util.CachedClassLoader.loadClass(CachedClassLoader.java:160) 

   at 
org.ofbiz.base.container.ContainerLoader.loadContainer(ContainerLoader.java:162) 

   at 
org.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:65)

   at org.ofbiz.base.start.Start.initStartLoaders(Start.java:258)
   at org.ofbiz.base.start.Start.init(Start.java:96)
   at org.ofbiz.base.start.Start.main(Start.java:409)

Thanks
Brajesh Patel


Re: svn commit: r833294 - in /ofbiz: branches/addbirt/framework/ branches/addbirt/framework/birt/lib/ branches/addbirt/framework/birt/src/org/ofbiz/birt/report/context/ branches/addbirt/framework/birt

2009-11-05 Thread Deepak Dixit

Hello Hans,

comment inline:

Modified: ofbiz/trunk/framework/base/config/ofbiz-containers.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/config/ofbiz-containers.xml?rev=833294&r1=833293&r2=833294&view=diff
==
--- ofbiz/trunk/framework/base/config/ofbiz-containers.xml (original)
+++ ofbiz/trunk/framework/base/config/ofbiz-containers.xml Fri Nov  6 03:55:56 
2009
@@ -256,6 +256,14 @@
 
 
 
+
+

+
+
+
+
+
+
 
 

 

  

Due to above changes we are not able to run server.Following error occured :

org.ofbiz.base.start.StartupException: Cannot locate container class 
(org.ofbiz.birt.container.BirtContainer)
  at 
org.ofbiz.base.container.ContainerLoader.loadContainer(ContainerLoader.java:164) 

  at 
org.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:65)

  at org.ofbiz.base.start.Start.initStartLoaders(Start.java:258)
  at org.ofbiz.base.start.Start.init(Start.java:96)
  at org.ofbiz.base.start.Start.main(Start.java:409)
java.lang.ClassNotFoundException: org.ofbiz.birt.container.BirtContainer




Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548



Re: svn commit: r833294 - in /ofbiz: branches/addbirt/framework/ branches/addbirt/framework/birt/lib/ branches/addbirt/framework/birt/src/org/ofbiz/birt/report/context/ branches/addbirt/framework/birt

2009-11-05 Thread Deepak Dixit

Thanks Scott  :-)

Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548


Scott Gray wrote:
I've reverted the portion of the commit that affected the trunk in 
r833303


Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 6/11/2009, at 6:14 PM, Deepak Dixit wrote:


Hello Hans,

comment inline:

Modified: ofbiz/trunk/framework/base/config/ofbiz-containers.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/config/ofbiz-containers.xml?rev=833294&r1=833293&r2=833294&view=diff 

== 


--- ofbiz/trunk/framework/base/config/ofbiz-containers.xml (original)
+++ ofbiz/trunk/framework/base/config/ofbiz-containers.xml Fri Nov  
6 03:55:56 2009

@@ -256,6 +256,14 @@



++
+class="org.ofbiz.birt.container.BirtContainer">

+
+
+
+value="org.ofbiz"/>

+
 
class="org.ofbiz.base.container.BeanShellContainer">



Due to above changes we are not able to run server.Following error 
occured :


org.ofbiz.base.start.StartupException: Cannot locate container class 
(org.ofbiz.birt.container.BirtContainer)
 at 
org.ofbiz.base.container.ContainerLoader.loadContainer(ContainerLoader.java:164) 

 at 
org.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:65)

 at org.ofbiz.base.start.Start.initStartLoaders(Start.java:258)
 at org.ofbiz.base.start.Start.init(Start.java:96)
 at org.ofbiz.base.start.Start.main(Start.java:409)
java.lang.ClassNotFoundException: org.ofbiz.birt.container.BirtContainer




Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548








Error while creating new customer

2009-11-23 Thread Deepak Dixit

I am getting following error while creating new customer.

Error in Service [partyRolePermissionCheck]: You must be logged in to 
complete the [Party role permission logic] process.


It is working fine for r883228 but not for r883229.

Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548



Re: Error while creating new customer

2009-11-27 Thread Deepak Dixit

This issue fixed in rev no.884262.


Thanks & Regards

--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548


Deepak Dixit wrote:

I am getting following error while creating new customer.

Error in Service [partyRolePermissionCheck]: You must be logged in to 
complete the [Party role permission logic] process.


It is working fine for r883228 but not for r883229.

Thanks & Regards


Re: how to display 3 products in a row instead of 1

2010-07-06 Thread Deepak Dixit

Hi hdv,

You can do this with the help of css.You can change the "productsummary" 
class  in ecommain.css  (line no 781) as follows or you can write your 
own css.


.productsummary {
border-bottom:1px solid #99;
float:left;
height:135px;
padding:5px 8px 5px 6px;
position:relative;
width:30%;
}



Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype   :- deepakdixit


hdv wrote:

hi
I am new to ofbiz.when I am trying to search any keyword in keywordsearch
box,the result shows one product in a row.But I want 3 products in a row.
So can anybody help me out in this case.what changes should i do in this
case?
  





Re: how to display 3 products in a row instead of 1

2010-07-06 Thread Deepak Dixit

And please ask these types of questions on user mailing list.

Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype   :- deepakdixit


hdv wrote:

hi
I am new to ofbiz.when I am trying to search any keyword in keywordsearch
box,the result shows one product in a row.But I want 3 products in a row.
So can anybody help me out in this case.what changes should i do in this
case?
  





Re: svn commit: r985298 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-10-26 Thread Deepak Dixit

Hello Adam,

I am using Ofbiz10.0.4 branch, and I am facing same problem, it seems 
like a bug in Ofbiz10.04 branch.

So we can fix this  for Ofbiz10.04 branch as well.

Thanks & Regards
--
Deepak Dixit



doo...@apache.org wrote:

Author: doogie
Date: Fri Aug 13 17:42:51 2010
New Revision: 985298

URL: http://svn.apache.org/viewvc?rev=985298&view=rev
Log:
Different entity groups can point to the same helper.  However, since
the entities defined in the group are what is passed to the helper for
checking, it makes no sense to have protection against a helper from
being checked multiple times.

Ideally, the proper fix would be to find all groups by helper, combine
all the entities together, then pass them to the helper in one shot.
However, with the new tenant system, this grouping needs to be done by
target database uri(and other parameters), not by helper name.  This
might get done later.

Before this commit, any ofbiz installation that put multiple entity
groups into the same helper would only have the entities from the first
group get created.

Modified:
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

Modified: 
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java?rev=985298&r1=985297&r2=985298&view=diff
==
--- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java 
(original)
+++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java Fri 
Aug 13 17:42:51 2010
@@ -247,7 +247,6 @@ public class GenericDelegator implements
 }
 
 // initialize helpers by group

-TreeSet helpersDone = new TreeSet();
 Set groupNames = 
getModelGroupReader().getGroupNames(delegatorBaseName);
 for (String groupName: groupNames) {
 GenericHelperInfo helperInfo = this.getGroupHelperInfo(groupName);
@@ -256,12 +255,6 @@ public class GenericDelegator implements
 if (Debug.infoOn()) Debug.logInfo("Delegator \"" + delegatorFullName + "\" 
initializing helper \"" +
 helperBaseName + "\" for entity group \"" + groupName + 
"\".", module);
 if (UtilValidate.isNotEmpty(helperInfo.getHelperFullName())) {
-// make sure each helper is only loaded once
-if (helpersDone.contains(helperInfo.getHelperFullName())) {
-if (Debug.infoOn()) Debug.logInfo("Helper \"" + 
helperInfo.getHelperFullName() + "\" already initialized, not re-initializing.", module);
-continue;
-}
-helpersDone.add(helperInfo.getHelperFullName());
 // pre-load field type defs, the return value is ignored
 ModelFieldTypeReader.getModelFieldTypeReader(helperBaseName);
 // get the helper and if configured, do the datasource check


  





Re: svn commit: r985298 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-10-29 Thread Deepak Dixit


Thanks Ashish.


Thanks & Regards
--
Deepak Dixit



Ashish Vijaywargiya wrote:

Thanks Deepak for reporting the bug. If Adam will not get a chance to commit
it in ReleaseBranch 10.04 then I will commit it tomorrow.

--
Ashish

On Wed, Oct 27, 2010 at 11:44 AM, Deepak Dixit   

wrote:



  

Hello Adam,

I am using Ofbiz10.0.4 branch, and I am facing same problem, it seems like
a bug in Ofbiz10.04 branch.
So we can fix this  for Ofbiz10.04 branch as well.

Thanks & Regards
--
Deepak Dixit




doo...@apache.org wrote:



Author: doogie
Date: Fri Aug 13 17:42:51 2010
New Revision: 985298

URL: http://svn.apache.org/viewvc?rev=985298&view=rev
Log:
Different entity groups can point to the same helper.  However, since
the entities defined in the group are what is passed to the helper for
checking, it makes no sense to have protection against a helper from
being checked multiple times.

Ideally, the proper fix would be to find all groups by helper, combine
all the entities together, then pass them to the helper in one shot.
However, with the new tenant system, this grouping needs to be done by
target database uri(and other parameters), not by helper name.  This
might get done later.

Before this commit, any ofbiz installation that put multiple entity
groups into the same helper would only have the entities from the first
group get created.

Modified:
   ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

Modified:
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java?rev=985298&r1=985297&r2=985298&view=diff

==
---
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
(original)
+++
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java Fri
Aug 13 17:42:51 2010
@@ -247,7 +247,6 @@ public class GenericDelegator implements
}
 // initialize helpers by group
-TreeSet helpersDone = new TreeSet();
Set groupNames =
getModelGroupReader().getGroupNames(delegatorBaseName);
for (String groupName: groupNames) {
GenericHelperInfo helperInfo =
this.getGroupHelperInfo(groupName);
@@ -256,12 +255,6 @@ public class GenericDelegator implements
if (Debug.infoOn()) Debug.logInfo("Delegator \"" +
delegatorFullName + "\" initializing helper \"" +
helperBaseName + "\" for entity group \"" + groupName
+ "\".", module);
if (UtilValidate.isNotEmpty(helperInfo.getHelperFullName())) {
-// make sure each helper is only loaded once
-if (helpersDone.contains(helperInfo.getHelperFullName()))
{
-if (Debug.infoOn()) Debug.logInfo("Helper \"" +
helperInfo.getHelperFullName() + "\" already initialized, not
re-initializing.", module);
-continue;
-}
-helpersDone.add(helperInfo.getHelperFullName());
// pre-load field type defs, the return value is ignored

ModelFieldTypeReader.getModelFieldTypeReader(helperBaseName);
// get the helper and if configured, do the datasource
check




  





  





Re: [jira] Closed: (OFBIZ-4006) jQuery Test and Bug fixing

2010-12-01 Thread Deepak Dixit


jQuery provide lot of pluginns and good thing is that all of these 
pluginns are cross browser compatible.


So  +1 for  merge jQuery with trunk and then create release branch with 
jQuery.


Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype Id :- deepakdixit



Jacques Le Roux wrote:

Other opinions?

Jacques

From: "Bruno Busco" 

I would prefer to have the release branch before the merge with jQuery.

-Bruno


2010/11/27 Jacopo Cappellato 

We may want to create a new release branch (before or after the 
merge with

jQuery?) and officially release 10.04.

Jacopo

On Nov 27, 2010, at 10:57 AM, Jacques Le Roux wrote:

> Yes, there is no hurry to merge jQuery, and a branch before could 
be a

good idea indeed.
> This could be an answer for removing or not all Prototype/Dojo 
from the

trunk.
> With this branch people could rely on it for Prototype/Dojo. Those
interested by the trunk are already leaving on the leading-edge and 
should

not worry too much.
>
> On the other hand maybe some would prefer to have jQuery in the next
release? And also should we wait 11.xx? 11.01 would be okay for me...
>
> BTW for those interested  please be sure to check this thread (Bilgin
noticed that I mixed 2 subjects in it: jQuery docs and demo and 
removing

Prototype/Dojo from the trunk or not)
> http://markmail.org/message/mpdywy4ymkjddrpr
>
> Jacques
>
> From: "Bruno Busco" 
>> What about creating a new release branch before merging the jquery ?
>>
>> -Bruno
>>
>> 2010/11/26 Jacques Le Roux 
>>
>>> Hi Rohit,
>>>
>>> Hopefully before new year, but we will need more testing, could you
help?
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>> From: "rohit" 
>>>
>>>
>>>> hi,
>>>>
>>>> when can we expect the jQuery branch to be merged with the 
truck, it

that
>>>> expected at all...
>>>>
>>>> thanks
>>>>
>>>> rohit
>>>>
>>>> --
>>>> View this message in context:
>>>>
http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-4006-jQuery-Test-and-Bug-fixing-tp3016706p3060540.html 


>>>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>>>>
>>>>
>>>
>>>
>
>











Re: [jira] Closed: (OFBIZ-4006) jQuery Test and Bug fixing

2010-12-01 Thread Deepak Dixit


yes exactly, and jQuery 1.4.2 is stable and we can use it without issue.
In future we can update it to 1.4.3 or 1.4.4 or any stable release.

Thanks & Regards
--
Deepak Dixit




Jacques Le Roux wrote:
I agree, we already use the jQuery branch in a custom project without 
issues so far.
The only problem we crossed is related to jQuery 1.4.3 and 1.4.4 and 
we had to revert to 1.4.2.
The problem was related to the use of jQuery.live() and was 
reproductible with OFBiz OOTB. I have still to report it to jQuery 
team, not easy

http://docs.jquery.com/How_to_Report_Bugs
http://bugs.jquery.com/search?ticket=on&q=live+1.4.3&page=2&noquickjump=1
http://bugs.jquery.com/ticket/7340
http://jsfiddle.net/

There are options:
* to put a tag in the trunk before merging, but it's static and does 
not help much. You have still to handle the "future" of the tag :/
* to create a branch before mergin, but I don't like it much; it looks 
like a Prototype/Dojo fork


So yes I'd also vote to merge it in the trunk and not worry too much, 
we should be able to quickly handle issues, if any...


Jacques

From: "Divesh Dutta" 
I think, if issues come then we can attack them. In this way we will 
have release branch with Jquery.


Thanks
--
Divesh Dutta.

On Dec 1, 2010, at 6:38 PM, Bruno Busco wrote:


I vote for doing a release branch first and then merge jQuery.

This will let people to have a branch with the actual trunk in case the
jQuery causes any issues to them.

Thank you,
Bruno

2010/12/1 Deepak Dixit 



jQuery provide lot of pluginns and good thing is that all of these 
pluginns

are cross browser compatible.

So  +1 for  merge jQuery with trunk and then create release branch 
with

jQuery.

Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype Id :- deepakdixit




Jacques Le Roux wrote:


Other opinions?

Jacques

From: "Bruno Busco" 

I would prefer to have the release branch before the merge with 
jQuery.


-Bruno


2010/11/27 Jacopo Cappellato 

We may want to create a new release branch (before or after the 
merge

with
jQuery?) and officially release 10.04.

Jacopo

On Nov 27, 2010, at 10:57 AM, Jacques Le Roux wrote:

Yes, there is no hurry to merge jQuery, and a branch before 
could be a

good idea indeed.
This could be an answer for removing or not all Prototype/Dojo 
from

the
trunk.

With this branch people could rely on it for Prototype/Dojo. Those

interested by the trunk are already leaving on the leading-edge and
should
not worry too much.


On the other hand maybe some would prefer to have jQuery in the 
next
release? And also should we wait 11.xx? 11.01 would be okay for 
me...


BTW for those interested  please be sure to check this thread 
(Bilgin
noticed that I mixed 2 subjects in it: jQuery docs and demo and 
removing

Prototype/Dojo from the trunk or not)

http://markmail.org/message/mpdywy4ymkjddrpr

Jacques

From: "Bruno Busco" 
What about creating a new release branch before merging the 
jquery ?


-Bruno

2010/11/26 Jacques Le Roux 


Hi Rohit,

Hopefully before new year, but we will need more testing, 
could you

help?


Thanks

Jacques

From: "rohit" 



hi,

when can we expect the jQuery branch to be merged with the 
truck,

it
that

expected at all...

thanks

rohit

--
View this message in context:



http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-4006-jQuery-Test-and-Bug-fixing-tp3016706p3060540.html 


Sent from the OFBiz - Dev mailing list archive at Nabble.com.
































Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Deepak Dixit

+1

Thanks & Regards
--
Deepak Dixit



Jacopo Cappellato wrote:

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

  





Re: New Flat Grey default?

2011-01-18 Thread Deepak Dixit

On Wednesday 19 January 2011 03:53 AM, Jacques Le Roux wrote:

From: "Adrian Crum" 

On 1/18/2011 12:56 PM, Jacques Le Roux wrote:

From: "Adrian Crum" 

On 1/18/2011 10:08 AM, Jacques Le Roux wrote:

From: "Adam Heath" 

On 01/18/2011 11:46 AM, Adrian Crum wrote:

There are more benefits than that. Flat Grey does not require
JavaScript, and it is sight-impaired accessible. It would be the 
most

accommodating point of entry for a new user.


Huh? You mean all those href="javascript:submitForm()" stuff has 
been

removed?


No, and that's the real issue... I think it will remains, except 
if we

find another way to avoid XSS from FTL files. I don't feel it will
change...


I don't understand how changing a form's submit button to a link that
calls a submit function protects us from XSS attacks.

-Adrian


Just have a look at one of the patches at
https://issues.apache.org/jira/browse/OFBIZ-2330 and you should get it

it was not forms that were changed but plain URL (get method)

The idea is before we had something like
href='<@ofbizUrl>request?param1=${param1Value}¶m2=${param2Value}&>${uiLabelMap} 



So we had parameters in an URL (ie a GET type method) and this could be
exploited when the request was a Create Update or Delete type service
(no pb for Read), ie to get an access to the DB.

We have now.



${uiLabelMap...}

As it's a POST request type method with hidden parameters included in a
javascript call parameters it's not possible to use XSS Injection (you
can't hack the URL from outside to inject a script in it). Just try it
if you want to be sure...

This is explained clearly at
http://www.testingsecurity.com/how-to-test/injection-vulnerabilities/XSS-Injection 


section "How to test for XSS Injection vulnerabilities"

One thing I'm not quire sure though is why we use javascript calls
instead of simple submit buttons (almost your question ;o).


That was EXACTLY my question.


Right, but most of the changes which introduced those js calls were 
not done on forms but plain URLs. That's why I explained it

all... For instance CopyAgreement.ftl has not been changed...
But yes, I think we could replace them by simple submit buttons. I can 
see not reasons why we should not.


BTW I have just tried with
deletePartyContactMechPurpose_${partyContactMechPurpose.contactMechPurposeTypeId} 
in
specialpurpose/ecommerce/webapp/ecommerce/customer/editcontactmech.ftl 
and it works well. I replaced


by
name="deletePartyContactMechPurpose_${partyContactMechPurpose.contactMechPurposeTypeId}" 
class='button' value=" ${uiLabelMap.CommonDelete} "/>




IMO we can change submit a form. There is a input button of type submit that are used for 
form submit.
At initial level these all form that contain href="javascript:document." for  form submit are only string and after security update these query string convert into form 
but for form submission they changed href="javascript:document." instead of using input button of type submit.


We should refactor these type of unnecessary javascript call.


Thanks & Regards
--
Deepak Dixit



any differences, any security error messages...

Maybe I miss something (XSS reinforced security?). But, like you, I 
can't see what! (I specifically chosen a dynamic input name)


Jacques


-Adrian








Re: svn commit: r1084855 - /ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml

2011-03-24 Thread Deepak Dixit
Thanks Jaques, 

Both ways are fine, We can use either 0 or 1 index.
I have an idea  to improve target-parameter functionality and I am working on 
it, will open a ticket shortly for the same.


Thanks & Regards
-- 
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype  :- deepakdixit

On Mar 24, 2011, at 6:57 PM, Jacques Le Roux wrote:

> Thinking more about it, I have changed my mine. I will rather revert and use 
> 0 as origin because some custom applications are certainly using it... 
> Waiting Deepkak answer on a (it seems) mixed issue at 
> https://issues.apache.org/jira/browse/OFBIZ-4225 before going on
> 
> Jacques
> 
>> Author: jleroux
>> Date: Thu Mar 24 06:36:58 2011
>> New Revision: 1084855
>> 
>> URL: http://svn.apache.org/viewvc?rev=1084855&view=rev
>> Log:
>> A patch from Leon "Minor related patch after OFBIZ-4225 issue (Lookup 
>> target-parameter in form widget is not working) fixed" 
>> https://issues.apache.org/jira/browse/OFBIZ-4228 - OFBIZ-4228
>> 
>> n https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a bug 
>> in fieldlookup.js which caused "Lookup target-parameter in form widget is 
>> not working"。
>> 
>> Now the form widget framework behaves same as widget-form.xsd specifies: 
>> using parameters.parmI (where I is the position number in the 
>> "target-parameter" list) in the related lookup screen. The position number 
>> in the list begins from 1. That implictes "parm0" is invalid.
>> 
>> So I searched the whole project to look up whether there's "parm0" left out. 
>> That's what this patch for.
>> 
>> Modified:
>>   ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
>> 
>> Modified: ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml?rev=1084855&r1=1084854&r2=1084855&view=diff
>> ==
>> --- ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml 
>> (original)
>> +++ ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml Thu Mar 
>> 24 06:36:58 2011
>> @@ -137,7 +137,7 @@ under the License.
>>
>>> global="true"/>
>>> value="${uiLabelMap.PageTitleLookupCustomerRequestItem}"/>
>> -> from-field="parameters.custRequestId" default-value="${parameters.parm0}"/>
>> +> from-field="parameters.custRequestId" default-value="${parameters.parm1}"/>
>>
>>> type="Integer"/>
>>> type="Integer" default-value="20"/>
>> @@ -190,7 +190,7 @@ under the License.
>>
>>> global="true"/>
>>> value="${uiLabelMap.PageTitleLookupQuoteItem}"/>
>> -> default-value="${parameters.parm0}"/>
>> +> default-value="${parameters.parm1}"/>
>>
>>> type="Integer"/>
>>> type="Integer" default-value="20"/>
>> 
> 
> 



Re: svn commit: r1084855 - /ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml

2011-03-25 Thread Deepak Dixit
Hello Jacques,

I have reopened https://issues.apache.org/jira/browse/OFBIZ-4225 and attach 
improved patch, now parm indexing start with 0 instead of 1. 
I have tested it for editRequest functionality and its working fine. 


Thanks & Regards
-- 
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype  :- deepakdixit

On Mar 25, 2011, at 1:49 PM, Jacques Le Roux wrote:

> Hi Deepak,
> 
> From your comments, I'm not sure if I should wait you or do it myself (not a 
> big deal)?
> 
> Jacques
> 
> Deepak Dixit wrote:
>> Thanks Jaques,
>> 
>> Both ways are fine, We can use either 0 or 1 index.
>> I have an idea  to improve target-parameter functionality and I am working 
>> on it, will open a ticket shortly for the same.
>> 
>> 
>> Thanks & Regards
>> 
>>> Thinking more about it, I have changed my mine. I will rather revert and 
>>> use 0 as origin because some custom applications are
>>> certainly using it... Waiting Deepkak answer on a (it seems) mixed issue at 
>>> https://issues.apache.org/jira/browse/OFBIZ-4225
>>> before going on
>>> 
>>> Jacques
>>> 
>>>> Author: jleroux
>>>> Date: Thu Mar 24 06:36:58 2011
>>>> New Revision: 1084855
>>>> 
>>>> URL: http://svn.apache.org/viewvc?rev=1084855&view=rev
>>>> Log:
>>>> A patch from Leon "Minor related patch after OFBIZ-4225 issue (Lookup 
>>>> target-parameter in form widget is not working) fixed"
>>>> https://issues.apache.org/jira/browse/OFBIZ-4228 - OFBIZ-4228
>>>> 
>>>> n https://issues.apache.org/jira/browse/OFBIZ-4225, Deepak Dixit fixed a 
>>>> bug in fieldlookup.js which caused "Lookup
>>>> target-parameter in form widget is not working"。
>>>> 
>>>> Now the form widget framework behaves same as widget-form.xsd specifies: 
>>>> using parameters.parmI (where I is the position number
>>>> in the "target-parameter" list) in the related lookup screen. The position 
>>>> number in the list begins from 1. That implictes
>>>> "parm0" is invalid.
>>>> 
>>>> So I searched the whole project to look up whether there's "parm0" left 
>>>> out. That's what this patch for.
>>>> 
>>>> Modified:
>>>>  ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
>>>> 
>>>> Modified: ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml?rev=1084855&r1=1084854&r2=1084855&view=diff
>>>> ==
>>>>  ---
>>>> ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml 
>>>> (original) +++
>>>> ofbiz/trunk/applications/order/widget/ordermgr/LookupScreens.xml Thu Mar 
>>>> 24 06:36:58 2011 @@ -137,7 +137,7 @@ under the License.
>>>>   
>>>>   >>> global="true"/>
>>>>   >>> value="${uiLabelMap.PageTitleLookupCustomerRequestItem}"/>
>>>> ->>> from-field="parameters.custRequestId" default-value="${parameters.parm0}"/>
>>>> +>>> from-field="parameters.custRequestId" default-value="${parameters.parm1}"/>
>>>>   
>>>>   >>> type="Integer"/>
>>>>   >>> type="Integer" default-value="20"/>
>>>> @@ -190,7 +190,7 @@ under the License.
>>>>   
>>>>   >>> global="true"/>
>>>>   >>> value="${uiLabelMap.PageTitleLookupQuoteItem}"/>
>>>> ->>> default-value="${parameters.parm0}"/>
>>>> +>>> default-value="${parameters.parm1}"/>
>>>>   
>>>>   >>> type="Integer"/>
>>>>   >>> type="Integer" default-value="20"/> 
> 
> 



Re: Plan for OFBiz stable Release_11.04?

2011-04-13 Thread Deepak Dixit
+1

Thanks & Regards
-- 
Deepak Dixit


On Apr 12, 2011, at 4:22 PM, Ashish Vijaywargiya wrote:

> Its mid of April month so I thought to start a thread in which we all can
> discuss about the stable release 11.04 of OFBiz trunk like we did last year.
> Thoughts?
> 
> Thanks!
> --
> Ashish



Re: Plan for OFBiz stable Release_11.04?

2011-05-02 Thread Deepak Dixit
Thanks Jacopo!


Thanks & Regards
-- 
Deepak Dixit


On May 2, 2011, at 10:21 PM, Jacopo Cappellato wrote:

> I have created the new branch:
> 
> http://svn.apache.org/repos/asf/ofbiz/branches/release11.04/
> 
> and updated the information here:
> 
> https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Source+Repository+and+Access
> 
> Kind regards,
> 
> Jacopo
> 
> On Apr 25, 2011, at 9:40 AM, Ashish Vijaywargiya wrote:
> 
>> Thanks Jacopo!
>> 
>> --
>> Ashish
>> 
>> On Mon, Apr 25, 2011 at 12:38 PM, Jacopo Cappellato <
>> jacopo.cappell...@hotwaxmedia.com> wrote:
>> 
>>> Ok, I am going to create the branch by the end of April.
>>> 
>>> Kind regards,
>>> 
>>> Jacopo
>>> 
>>> On Apr 13, 2011, at 11:01 AM, Sam Hamilton wrote:
>>> 
>>>> +1
>>>> 
>>>> 
>>>> On 12 Apr 2011, at 18:52, Ashish Vijaywargiya wrote:
>>>> 
>>>>> Its mid of April month so I thought to start a thread in which we all
>>> can
>>>>> discuss about the stable release 11.04 of OFBiz trunk like we did last
>>> year.
>>>>> Thoughts?
>>>>> 
>>>>> Thanks!
>>>>> --
>>>>> Ashish
>>>> 
>>> 
>>> 
> 



Re: svn commit: r1158120 - in /ofbiz/trunk/applications: content/script/org/ofbiz/content/content/ContentServices.xml content/servicedef/services_content.xml party/script/org/ofbiz/party/communication

2011-08-17 Thread Deepak Dixit
Hello Hans,

inline:

On Aug 16, 2011, at 11:51 AM, hans...@apache.org wrote:

> Author: hansbak
> Date: Tue Aug 16 06:21:04 2011
> New Revision: 1158120
> 
> URL: http://svn.apache.org/viewvc?rev=1158120&view=rev
> Log:
> extended the commevent delete service to delete also seo friendly url's 
> connected to the attached content of a comm event
> 
> Modified:
>
> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>ofbiz/trunk/applications/content/servicedef/services_content.xml
>
> ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml
> 
> Modified: 
> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml?rev=1158120&r1=1158119&r2=1158120&view=diff
> ==
> --- 
> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>  (original)
> +++ 
> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>  Tue Aug 16 06:21:04 2011
> @@ -69,6 +69,29 @@
> 
> 
> 
> + short-description="Remove a Content Record, related resource(s) and assocs.">
> +
> +
> + value-field="content"/>

map is not a valid attribute for entity-one tag. Its giving error on console, 
Here is the error message:

  [java] 2011-08-18 11:04:08,214 (main) [UtilXml.java:1060:ERROR] 
XmlFileLoader: File 
file:/sandbox/ofbiz/applications/content/script/org/ofbiz/content/content/ContentServices.xml
 process error. Line: 75. Error message: cvc-complex-type.3.2.2: Attribute 
'map' is not allowed to appear in element 'entity-one'.


Thanks & Regards
-- 
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype  :- deepakdixit


> +
> + relation-name="ContentKeyword"/>
> + relation-name="FromContentAssoc"/>
> + relation-name="ToContentAssoc"/>
> +
> + to-value-field="dataResource"/>
> +
> + relation-name="ImageDataResource" to-value-field="imageDataResource"/>
> +
> +
> +
> + relation-name="ElectronicText" to-value-field="electronicText"/>
> +
> +
> +
> + relation-name="DataResourceRole"/>
> +
> +
> +
> 
> 
> 
> 
> Modified: ofbiz/trunk/applications/content/servicedef/services_content.xml
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/servicedef/services_content.xml?rev=1158120&r1=1158119&r2=1158120&view=diff
> ==
> --- ofbiz/trunk/applications/content/servicedef/services_content.xml 
> (original)
> +++ ofbiz/trunk/applications/content/servicedef/services_content.xml Tue Aug 
> 16 06:21:04 2011
> @@ -151,6 +151,17 @@
>  type="List"/>
> 
> 
> + engine="simple"
> +
> location="component://content/script/org/ofbiz/content/content/ContentServices.xml"
>  invoke="removeContentAndRelated" auth="true">
> +Remove Content
> + main-action="DELETE"/>
> +
> + type="List"/>
> + type="String"/>
> + type="org.ofbiz.entity.GenericValue"/>
> + type="List"/>
> +
> +
> 
>  transaction-timeout="7200"
> 
> Modified: 
> ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml?rev=1158120&r1=1158119&r2=1158120&view=diff
> ==
> --- 
> ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml
>  (original)
> +++ 
> ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml
>  Tue Aug 16 06:21:04 2011
> @@ -358,6 +358,18 @@ under the License.
> 
>  relation-name="ContentRole"/>
>

Re: svn commit: r1158120 - in /ofbiz/trunk/applications: content/script/org/ofbiz/content/content/ContentServices.xml content/servicedef/services_content.xml party/script/org/ofbiz/party/communication

2011-08-18 Thread Deepak Dixit
Thanks Hans. 

Thanks & Regards
-- 
Deepak Dixit


On Aug 18, 2011, at 12:40 PM, Hans Bakker wrote:

> Thanks for the comment, fixed in Revision: 1159064
> 
> Regards,
> hans
> 
> On Thu, 2011-08-18 at 11:40 +0530, Deepak Dixit wrote:
>> Hello Hans,
>> 
>> inline:
>> 
>> On Aug 16, 2011, at 11:51 AM, hans...@apache.org wrote:
>> 
>>> Author: hansbak
>>> Date: Tue Aug 16 06:21:04 2011
>>> New Revision: 1158120
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1158120&view=rev
>>> Log:
>>> extended the commevent delete service to delete also seo friendly url's 
>>> connected to the attached content of a comm event
>>> 
>>> Modified:
>>>   
>>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>>   ofbiz/trunk/applications/content/servicedef/services_content.xml
>>>   
>>> ofbiz/trunk/applications/party/script/org/ofbiz/party/communication/CommunicationEventServices.xml
>>> 
>>> Modified: 
>>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>> URL: 
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml?rev=1158120&r1=1158119&r2=1158120&view=diff
>>> ==
>>> --- 
>>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>>  (original)
>>> +++ 
>>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>>  Tue Aug 16 06:21:04 2011
>>> @@ -69,6 +69,29 @@
>>> 
>>>
>>>
>>> +>> short-description="Remove a Content Record, related resource(s) and 
>>> assocs.">
>>> +
>>> +
>>> +>> value-field="content"/>
>> 
>> map is not a valid attribute for entity-one tag. Its giving error on 
>> console, Here is the error message:
>> 
>>  [java] 2011-08-18 11:04:08,214 (main) [UtilXml.java:1060:ERROR] 
>> XmlFileLoader: File 
>> file:/sandbox/ofbiz/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>  process error. Line: 75. Error message: cvc-complex-type.3.2.2: Attribute 
>> 'map' is not allowed to appear in element 'entity-one'.
>> 
>> 
>> Thanks & Regards
>> -- 
>> Deepak Dixit
>> HotWax Media Pvt. Ltd.
>> www.hotwaxmedia.com
>> Contact :- +91-98267-54548
>> Skype  :- deepakdixit
>> 
>> 
>>> +
>>> +>> relation-name="ContentKeyword"/>
>>> +>> relation-name="FromContentAssoc"/>
>>> +>> relation-name="ToContentAssoc"/>
>>> +
>>> +>> relation-name="DataResource" to-value-field="dataResource"/>
>>> +
>>> +>> relation-name="ImageDataResource" to-value-field="imageDataResource"/>
>>> +
>>> +
>>> +
>>> +>> relation-name="ElectronicText" to-value-field="electronicText"/>
>>> +
>>> +
>>> +
>>> +>> relation-name="DataResourceRole"/>
>>> +
>>> +
>>> +
>>> 
>>>
>>>>> short-description="Create a ContntAssoc Record">
>>> 
>>> Modified: ofbiz/trunk/applications/content/servicedef/services_content.xml
>>> URL: 
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/servicedef/services_content.xml?rev=1158120&r1=1158119&r2=1158120&view=diff
>>> ==
>>> --- ofbiz/trunk/applications/content/servicedef/services_content.xml 
>>> (original)
>>> +++ ofbiz/trunk/applications/content/servicedef/services_content.xml Tue 
>>> Aug 16 06:21:04 2011
>>> @@ -151,6 +151,17 @@
>>>>> type="List"/>
>>>
>>> 
>>> +>> engine="simple"
>>> +
>>> location="component://content/script/org/ofbiz/content/content/ContentServices.xml"
>>>  invoke="

Re: svn commit: r1167015 - in /ofbiz/trunk: applications/accounting/entitydef/ applications/order/config/ applications/order/data/ applications/order/entitydef/ applications/order/script/org/ofbiz/ord

2011-09-22 Thread Deepak Dixit
Hi Hans,

inline:

On Sep 9, 2011, at 12:10 PM, hans...@apache.org wrote:

> Author: hansbak
> Date: Fri Sep  9 06:40:28 2011
> New Revision: 1167015
> 
> URL: http://svn.apache.org/viewvc?rev=1167015&view=rev
> Log:
> New product type: Fixed Asset Usage For Rental of an asset which is shipped 
> from and returned to inventory. Including Junit test and demo data. More 
> explanation will follow in a blog on the 'what is new page'
> 
> Modified:
>ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
>ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>ofbiz/trunk/applications/order/data/OrderTypeData.xml
>ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml
>
> ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml
>
> ofbiz/trunk/applications/order/script/org/ofbiz/order/test/ShoppingCartTests.xml
>ofbiz/trunk/applications/order/servicedef/secas.xml
>ofbiz/trunk/applications/order/servicedef/services.xml
>ofbiz/trunk/applications/order/servicedef/services_return.xml
>ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
>
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java
>ofbiz/trunk/applications/order/testdef/ShoppingCartTests.xml
>
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/compareproducts.ftl
>
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productdetail.ftl
>
> ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl
>ofbiz/trunk/applications/order/webapp/ordermgr/return/returnItemInc.ftl
>ofbiz/trunk/applications/product/data/ProductTypeData.xml
>ofbiz/trunk/applications/product/widget/catalog/CatalogMenus.xml
>ofbiz/trunk/framework/images/webapp/images/ecommain.css
>ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml
>
> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy
>ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/cart/showcart.ftl
>
> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/catalog/productdetail.ftl
>
> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/shoppinglist/editShoppingList.ftl
>ofbiz/trunk/specialpurpose/ecommerce/widget/CommonScreens.xml
> 
> Modified: ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml?rev=1167015&r1=1167014&r2=1167015&view=diff
> ==
> --- ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml (original)
> +++ ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml Fri Sep  9 
> 06:40:28 2011
> @@ -4069,4 +4069,12 @@ under the License.
> 
> 
> 
> +
> +
> +
> +
> + rel-entity-name="InventoryItem">
> + rel-field-name="inventoryItemId"/>

In this commit fixedAssetId has beed added in InventoryItem entity, due to this 
changes some of view entity throwing out field alias in view entity.
Here is the list of those view entity that need to fix:
- InventoryItemAndDetail
- ItemIssuanceAndInventoryItem
- ItemIssuanceInventoryItemAndProduct
- ProductInventoryItemAndItemIssuance

Can you please have a look at it?


Thanks & Regards
-- 
Deepak Dixit


> +
> +
> 



Re: svn commit: r1167015 - in /ofbiz/trunk: applications/accounting/entitydef/ applications/order/config/ applications/order/data/ applications/order/entitydef/ applications/order/script/org/ofbiz/ord

2011-09-22 Thread Deepak Dixit
Thanks Hans :) 

Thanks & Regards
-- 
Deepak Dixit


On Sep 22, 2011, at 6:37 PM, Hans Bakker wrote:

> Thank you for the tip, we will have a look at it
> 
> Regards,
> Hans
> 
> On Thu, 2011-09-22 at 18:18 +0530, Deepak Dixit wrote:
>> Hi Hans,
>> 
>> inline:
>> 
>> On Sep 9, 2011, at 12:10 PM, hans...@apache.org wrote:
>> 
>>> Author: hansbak
>>> Date: Fri Sep  9 06:40:28 2011
>>> New Revision: 1167015
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1167015&view=rev
>>> Log:
>>> New product type: Fixed Asset Usage For Rental of an asset which is shipped 
>>> from and returned to inventory. Including Junit test and demo data. More 
>>> explanation will follow in a blog on the 'what is new page'
>>> 
>>> Modified:
>>>   ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
>>>   ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>>>   ofbiz/trunk/applications/order/data/OrderTypeData.xml
>>>   ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml
>>>   
>>> ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml
>>>   
>>> ofbiz/trunk/applications/order/script/org/ofbiz/order/test/ShoppingCartTests.xml
>>>   ofbiz/trunk/applications/order/servicedef/secas.xml
>>>   ofbiz/trunk/applications/order/servicedef/services.xml
>>>   ofbiz/trunk/applications/order/servicedef/services_return.xml
>>>   
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
>>>   
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
>>>   
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java
>>>   ofbiz/trunk/applications/order/testdef/ShoppingCartTests.xml
>>>   
>>> ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/compareproducts.ftl
>>>   
>>> ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productdetail.ftl
>>>   
>>> ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl
>>>   ofbiz/trunk/applications/order/webapp/ordermgr/return/returnItemInc.ftl
>>>   ofbiz/trunk/applications/product/data/ProductTypeData.xml
>>>   ofbiz/trunk/applications/product/widget/catalog/CatalogMenus.xml
>>>   ofbiz/trunk/framework/images/webapp/images/ecommain.css
>>>   ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml
>>>   
>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy
>>>   ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/cart/showcart.ftl
>>>   
>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/catalog/productdetail.ftl
>>>   
>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/shoppinglist/editShoppingList.ftl
>>>   ofbiz/trunk/specialpurpose/ecommerce/widget/CommonScreens.xml
>>> 
>>> Modified: ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
>>> URL: 
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml?rev=1167015&r1=1167014&r2=1167015&view=diff
>>> ==
>>> --- ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml (original)
>>> +++ ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml Fri Sep  
>>> 9 06:40:28 2011
>>> @@ -4069,4 +4069,12 @@ under the License.
>>>
>>>
>>>
>>> +
>>> +
>>> +
>>> +
>>> +>> rel-entity-name="InventoryItem">
>>> +>> rel-field-name="inventoryItemId"/>
>> 
>> In this commit fixedAssetId has beed added in InventoryItem entity, due to 
>> this changes some of view entity throwing out field alias in view entity.
>> Here is the list of those view entity that need to fix:
>> - InventoryItemAndDetail
>> - ItemIssuanceAndInventoryItem
>> - ItemIssuanceInventoryItemAndProduct
>> - ProductInventoryItemAndItemIssuance
>> 
>> Can you please have a look at it?
>> 
>> 
>> Thanks & Regards
> 
> -- 
> Ofbiz on twitter: http://twitter.com/apache_ofbiz
> Alternative ofbiz website: http://www.ofbiz.info
> http://www.antwebsystems.com : Quality services for competitive rates.
> 



Re: Proposal to "close" the 4.0 and 09.04 release branches

2012-02-23 Thread Deepak Dixit
+1


Thanks & Regards
-- 
Deepak Dixit

On Feb 23, 2012, at 3:13 PM, Sascha Rodekamp wrote:

> +1
> 
> Good idea. That will simplify a few things!
> 
> Regards
> 
> Am 23.02.2012 um 09:35 schrieb Jacopo Cappellato 
> :
> 
>> Hi devs,
>> 
>> I would like to propose to officially close the two oldest branches:
>> 
>> release4.0
>> release09.04
>> 
>> When the branches will be closed:
>> * we will no more backport fixes to them (no commits in general will be done)
>> * if a user will submit a patch for the branch in Jira we will resolve as 
>> "won't fix": the patch will still be there for interested parties
>> * no new release will be created in the future from the two branches
>> * the OFBiz download page will explain that the branches are old and no more 
>> supported
>> * (optional) we could "close" the Jira versions for them and resolve as 
>> "won't fix" outstanding issues if only related to these branches
>> 
>> The result would be that, if the current vote for the release "Apache OFBiz 
>> 09.04.02" will pass then the 09.04.02 will be the last (and third) release 
>> of this branch.
>> Of course we could still return on this decision if something new will 
>> happen... but I doubt because the number of commits lately has been very low.
>> 
>> The main goal is to help the community  to have a clearer roadmap for the 
>> future and to help to focus on more defined targets: older branches are not 
>> supported, but the community will always try to backport fixes to the last 
>> two/three branches: the currently active branches are 11.04, 10.04 and the 
>> upcoming 12.04.
>> Following the same rule ("no more than three active release branches at a 
>> time") we could plan to "close" the 10.04 branch around (sometime before) 
>> April 2013 (when the new release branch 13.04 will be created).
>> 
>> This is a small and natural step in the direction of having some sort of 
>> roadmap for the project.
>> This, together with the discussion going on in thread "Proposal about a time 
>> based release plan" should be enough to define and create a nice and clean 
>> release roadmap.
>> 
>> We could start an official vote thread if there is interest in this, or, 
>> less formally, we could more simply use this thread to discuss pros and cons 
>> and find an agreement.
>> 
>> What do you think?
>> 
>> Jacopo
>> 



Google Checkout is not working.

2010-02-24 Thread Deepak Dixit

Hi All,

Goolgle checkout is broken, It gives following error :

"org.ofbiz.webapp.event.EventHandlerException: Problems getting the 
service model (Cannot locate service by name (sendGoogleCheckoutRequest))"



Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548



Re: Google Checkout is not working.

2010-02-24 Thread Deepak Dixit

typo:

Google checkout is broken, It gives following error :

"org.ofbiz.webapp.event.EventHandlerException: Problems getting the 
service model (Cannot locate service by name (sendGoogleCheckoutRequest))"



Deepak Dixit wrote:

Hi All,

Goolgle checkout is broken, It gives following error :

"org.ofbiz.webapp.event.EventHandlerException: Problems getting the 
service model (Cannot locate service by name 
(sendGoogleCheckoutRequest))"



Thanks & Regards



Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
Website :- www.hotwaxmedia.com
Contact :- +91-98267-54548



Re: Dojo tree 1.4

2010-06-08 Thread Deepak Dixit

Good idea Sascha,

Yes jQuery is much better then Dojo and much faster then Prototype.


Thanks & Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.



Sascha Rodekamp wrote:

Hey guys,

i started the work to update the Dojo libary to the current version 1.4.
And i have to say that it didn't satisfy me to work on every Dojo based
JaveScript for a little version update. It will coast a lot of time to test
and update all the JavaScript Code. And what we have at the end a new heavy
Dojo libary which brings a lot of widget but it's hard to extend :-)

So i have another (maybe better idea). Why we didn't set Dojo and Prototype
as depricated
and starting to use jQuerry. In my optinion jQuerry is a better invest in
the future. There are a lot of Widget/ Plugin's too and it's much lighter
than Dojo.

Instead of spending my time with updating all the Dojo stuff, i could spend
my time to migrate all Prototype / Dojo based Code to jQuerry.

What do you think?

Cheers
Sascha

2010/6/5 Anil Patel 

  

Looks like good plan. Overtime people might choose to replace prototype
framework with similar thing from Dojo.

Thanks and Regards
Anil Patel
HotWax Media Inc
Find us on the web at www.hotwaxmedia.com or Google Keyword "ofbiz"

On Jun 5, 2010, at 1:13 PM, Jacques Le Roux wrote:



So far I have mostly used Dojo for its tree in a CMS tool, and some
  

Prototype functions notably for layered lookups.


I still see them as complementary (Dojo coming more complete but heavier,
  

Prototype being mostly an API).


I does do think it's necessary to make a choice.

Jacques

From: "Adrian Crum" 
  

>From what I recall, the two libraries were included in the project with


the idea that the most popular one would get used. At the


time, Dojo was a very heavy library and the first attempts to use it
  

resulted in very slow page loads. I used Prototype in some


initial Ajax work - mainly because it was pretty easy to use. Today, I
  

have no preference for either one.


-Adrian

--- On Sat, 6/5/10, Anil Patel  wrote:



From: Anil Patel 
Subject: Re: Dojo tree 1.4
To: dev@ofbiz.apache.org
Cc: "Anil Patel" 
Date: Saturday, June 5, 2010, 7:00 AM
I started using Dojo in Ofbiz long
back and in six months because of issues faced we switched
to using prototype. At that time there were few others in
comunity who liked prototype better. But I really don't
remember the reasons.

Since then new checkout process was added that uses
prototype for all javascript needs. But did not remove Dojo
because i did not want to upset anybody in community.

Thanks and Regards
Anil Patel
HotWax Media Inc
Find us on the web at www.hotwaxmedia.com or Google Keyword
"ofbiz"

On Jun 5, 2010, at 9:47 AM, Jacques Le Roux wrote:

  

I have created a branch
http://svn.apache.org/repos/asf/ofbiz/branches/dojo1.4
Nothing else for now

Jacques

From: "Sascha Rodekamp" 


Hi Jacques ...
jep it's a lot of work but not impossible :)
A brunch is a good idea to start working on this
  

project. I think the reason
  

for Antil was, that he isn't use to Dojo. But that
  

shouldn't be a problem
  

the syntax isn't complicated.
And by the way, if this will work the new Dojo
  

will bring us a big benefit
  

(in my opinion).
Cheers
Sascha
2010/6/5 Jacques Le Roux 
  

Sascha,

We should rather use the dev ML for this


thread.
  

Maybe it's the reason why Anil was reluctant


to use Dojo?
  

Jacques


Jacques Le Roux wrote:



Sascha Rodekamp wrote:

  

Hey,

so i started upgrading to dojo 1.4.
The good point is ... Dojo 1.4 has


many really cool new Features which
  

can
help us to improve the UI.
The Bad thing is, some parts of the


syntax had changed. That effects many
  

parts in OFBiz (OnePageCheckout,


Trees, all Dojo features Scripts :-)).
  

Arg, I did not thought it will be so much
  

trouble :/
  

So that's a lot of work and i can't do it
  

on my own ... who volunteer to
  

help me ;) ??



I could help

First Step is to collect all depending
  

issues and than to fix them step
  

by
step.



So if we do that we need a branch I
  

guess...
  

Jacques

Have a nice day
  

Sascha



-- >> http://www.lynx.de

  
  




  




  





Re: SXSW panel talk

2009-09-03 Thread Deepak Dixit

Done!

Regards
-
Deepak Dixit

Ean Schuessler wrote:

Hi Everyone.

I'm trying to get an OFBiz panel on the schedule for SXSW (South by
Southwest) Interactive. This is a great conference for social networking
(blogs, twitter, etc. et al) and there are lots of startups that go
there. I'm hoping to spread the word that when it comes to their
financials and other business processes, Free Software isn't just for
application servers.

If any of you (preferrably ALL of you! ;-) could take a few minutes to
sign-up and "thumbs up" my talk, I think we can get OFBiz introduced to
a whole new segment of brainy and media savvy users. Please, please help
and thank you in advance.

http://panelpicker.sxsw.com/ideas/view/3944

Additionally, if anyone is going to be in Austin for SXSW, we should set
up some kind of meet up. I'm sure that we could get some of the SXSW IT
staff to attend as well.

Thanks so much.

  




Re: [jira] Updated: (OFBIZ-2932) checkoutpayment XHTML validation & default payment

2009-09-13 Thread Deepak Dixit

Hello Eric,

This file need some more markup clean up. like
1) The "name"attribute  exists in form element and the name|| attribute 
of form elements is formally deprecated, and will be removed in a 
subsequent version of XHTML .Use id attribute instead of name.
2) Event attribute is in lower camel case, but according to XHTML all 
attribute need to be in lower case.

3) script tag is not in the correct formate.


Thanks & Regards
-
Deepak Dixit


Eric DE MAULDE (JIRA) wrote:

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric DE MAULDE updated OFBIZ-2932:
--

Attachment: 
OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch

This patch modifies
_ checked into checked="checked"
_ add " />" at the end of input tag
_ add a checked default payment : it's the first, EXT_OFFLINE


  

checkoutpayment XHTML validation & default payment
--

Key: OFBIZ-2932
URL: https://issues.apache.org/jira/browse/OFBIZ-2932
Project: OFBiz
 Issue Type: Bug
 Components: specialpurpose/ecommerce
   Affects Versions: SVN trunk
Environment: trunk 814152
   Reporter: Eric DE MAULDE
Fix For: SVN trunk

Attachments: 
OFBIZ-2932_checkoutpayment_XHTML_validation_&_default_payment.patch


checkoutpayment.ftl doesn't validate XHTML test
More, checkoutpayment hasn't a checked default payment.



  




Re: svn commit: r814287 - in /ofbiz/trunk/applications: commonext/documents/ marketing/documents/ party/config/ party/data/ party/data/helpdata/ party/documents/ party/entitydef/ party/script/org/ofbi

2009-09-13 Thread Deepak Dixit

Hello Hans,

This commit generate error for loading data.In this you have add the 
statusId in PartyHelpData.xml but statusId's  define 
(ContentTypeData.xml) in  content component, and content component is 
loaded after party component so statusId generate error.


Thanks & Regards
-----
Deepak Dixit


hans...@apache.org wrote:

Author: hansbak
Date: Sun Sep 13 08:50:54 2009
New Revision: 814287

URL: http://svn.apache.org/viewvc?rev=814287&view=rev
Log:
added the 'main-roletype' to the party list screen, also added a helpscreen to 
explain it...

Added:
ofbiz/trunk/applications/party/data/helpdata/
ofbiz/trunk/applications/party/data/helpdata/HELP_PARTY.xml   (with props)
ofbiz/trunk/applications/party/data/helpdata/HELP_PARTY_findparty.xml   
(with props)
ofbiz/trunk/applications/party/documents/
ofbiz/trunk/applications/party/documents/Party.xml   (with props)
Modified:
ofbiz/trunk/applications/commonext/documents/ApacheOfbizUser.xml
ofbiz/trunk/applications/marketing/documents/Marketing.xml
ofbiz/trunk/applications/party/config/PartyEntityLabels.xml
ofbiz/trunk/applications/party/config/PartyUiLabels.xml
ofbiz/trunk/applications/party/data/PartyHelpData.xml
ofbiz/trunk/applications/party/data/PartyTypeData.xml
ofbiz/trunk/applications/party/entitydef/entitymodel.xml

ofbiz/trunk/applications/party/script/org/ofbiz/party/party/PartyServices.xml
ofbiz/trunk/applications/party/servicedef/services.xml
ofbiz/trunk/applications/party/webapp/partymgr/party/findparty.ftl

Modified: ofbiz/trunk/applications/commonext/documents/ApacheOfbizUser.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/commonext/documents/ApacheOfbizUser.xml?rev=814287&r1=814286&r2=814287&view=diff
==
--- ofbiz/trunk/applications/commonext/documents/ApacheOfbizUser.xml (original)
+++ ofbiz/trunk/applications/commonext/documents/ApacheOfbizUser.xml Sun Sep 13 
08:50:54 2009
@@ -67,6 +67,7 @@
 
 
 
+
 
 
 

Modified: ofbiz/trunk/applications/marketing/documents/Marketing.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/documents/Marketing.xml?rev=814287&r1=814286&r2=814287&view=diff
==
--- ofbiz/trunk/applications/marketing/documents/Marketing.xml (original)
+++ ofbiz/trunk/applications/marketing/documents/Marketing.xml Sun Sep 13 
08:50:54 2009
@@ -35,7 +35,7 @@
 
 It is very much based on the party component as its source.
 Records from the party component are selected with only one basic 
reason: a possible sale in the future.
-That also means that records in the party manager should be 
complete, esspecially the role is pretty important.
+That also means that records in the party manager should be 
complete, especially the role is pretty important.
 Not All roles, but at least 'lead' 'contact' and 'Account' should be defined 
 
 


Modified: ofbiz/trunk/applications/party/config/PartyEntityLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/config/PartyEntityLabels.xml?rev=814287&r1=814286&r2=814287&view=diff
==
--- ofbiz/trunk/applications/party/config/PartyEntityLabels.xml (original)
+++ ofbiz/trunk/applications/party/config/PartyEntityLabels.xml Sun Sep 13 
08:50:54 2009
@@ -974,7 +974,7 @@
 Informations transporteur
 
 
-Account
+Account Owned by
 Cuenta
 Compte
 खाता
@@ -1102,7 +1102,7 @@
 主机服务器访问者
 
 
-Lead owner
+Lead owned by
 Encargado de lead
 Propriétaire principal
 मुख्य स्वामी

Modified: ofbiz/trunk/applications/party/config/PartyUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/config/PartyUiLabels.xml?rev=814287&r1=814286&r2=814287&view=diff
==
--- ofbiz/trunk/applications/party/config/PartyUiLabels.xml (original)
+++ ofbiz/trunk/applications/party/config/PartyUiLabels.xml Sun Sep 13 08:50:54 
2009
@@ -6053,6 +6053,9 @@
 นามสกุลเดิมก่อนแต่งงาน
 母亲婚前姓
 
+
+Main Role
+
 
 Akteur Manager Anwendung
 Party Manager Application

Modified: ofbiz/trunk/applications/party/data/PartyHelpData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/data/PartyHelpData.xml?rev=814287&r1=814286&r2=814287&view=diff
==

Re: svn commit: r819277 - in /ofbiz/trunk/framework: base/src/org/ofbiz/base/util/cache/UtilCache.java common/data/CommonTypeData.xml common/data/GeoData_CN.xml

2009-09-29 Thread Deepak Dixit

Hi Jacques,

I was looking at the data file and found that GeoData_CN.xml file is not 
getting loaded at the time of ant run-install. The reason behind this is 
there is no entry for this file in ofbiz-component.xml.

Is this intended ?

--
Thanks and Regards
Deepak Dixit


jler...@apache.org wrote:

Author: jleroux
Date: Sun Sep 27 09:10:03 2009
New Revision: 819277

URL: http://svn.apache.org/viewvc?rev=819277&view=rev
Log:
Fix wrong file in r819274 (Chinese Geo data)

Added:
ofbiz/trunk/framework/common/data/GeoData_CN.xml
Modified:
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/cache/UtilCache.java
ofbiz/trunk/framework/common/data/CommonTypeData.xml

Modified: 
ofbiz/trunk/framework/base/src/org/ofbiz/base/util/cache/UtilCache.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/cache/UtilCache.java?rev=819277&r1=819276&r2=819277&view=diff
==
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/cache/UtilCache.java 
(original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/cache/UtilCache.java Sun 
Sep 27 09:10:03 2009
@@ -19,7 +19,6 @@
 package org.ofbiz.base.util.cache;
 
 import java.io.Serializable;

-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
@@ -116,9 +115,7 @@
 
 setPropertiesParams(cacheName);
 
-synchronized (utilCacheTable) {

-utilCacheTable.put(name, this);
-}
+utilCacheTable.put(name, this);
 }
 
 public UtilCache(String cacheName, int maxSize, long expireTime, boolean useSoftReference) {

@@ -146,9 +143,8 @@
 String name = "specified" + this.getNextDefaultIndex("specified");
 
 setPropertiesParams(name);

-synchronized (utilCacheTable) {
-utilCacheTable.put(name, this);
-}
+
+utilCacheTable.put(name, this);
 }
 
 /** This constructor takes a name for the cache, puts itself in the utilCacheTable.

@@ -161,9 +157,8 @@
 
 setPropertiesParams("default");

 setPropertiesParams(cacheName);
-synchronized (utilCacheTable) {
-utilCacheTable.put(name, this);
-}
+
+utilCacheTable.put(name, this);
 }
 
 /** This constructor takes a name for the cache, puts itself in the utilCacheTable.

@@ -175,9 +170,8 @@
 
 setPropertiesParams("default");

 setPropertiesParams(cacheName);
-synchronized (utilCacheTable) {
-utilCacheTable.put(name, this);
-}
+
+utilCacheTable.put(name, this);
 }
 
 /** Default constructor, all members stay at default values as defined in cache.properties, or the defaults in this file if cache.properties is not found, or there are no 'default' entries in it. */

@@ -185,9 +179,7 @@
 setPropertiesParams("default");
 
 name = "default" + this.getNextDefaultIndex("default");

-synchronized (utilCacheTable) {
-utilCacheTable.put(name, this);
-}
+utilCacheTable.put(name, this);
 }
 
 protected String getNextDefaultIndex(String cacheName) {

@@ -406,24 +398,10 @@
 
 /** Removes all elements from this cache */

 public static void clearAllCaches() {
-// We make a copy since clear may take time
-List> list = getUtilCacheTableValuesImage();
-for (UtilCache cache : list) {
-cache.clear();
-}
-list.clear();
-}
-
-/**
- * Return an image of the values at a time
- * @return {...@link List}
- */
-private static List getUtilCacheTableValuesImage() {
-List list = new ArrayList(utilCacheTable.size());
-synchronized (utilCacheTable) {
-list.addAll(utilCacheTable.values());
+for (Map.Entry> entry: 
utilCacheTable.entrySet()) {
+UtilCache utilCache = entry.getValue();
+utilCache.clear();
 }
-return list;
 }
 
 /** Getter for the name of the UtilCache instance.

@@ -654,12 +632,10 @@
 
 /** Clears all expired cache entries from all caches */

 public static void clearExpiredFromAllCaches() {
-// We make a copy since clear may take time
-List> list = getUtilCacheTableValuesImage();
-for (UtilCache utilCache : list) {
+for (Map.Entry> entry: 
utilCacheTable.entrySet()) {
+UtilCache utilCache = entry.getValue();
 utilCache.clearExpired();
 }
-list.clear();
 }
 
 /** Checks for a non-expired key in a specific cache */

@@ -674,20 +650,13 @@
 
 public static void clearCachesThatStartWith(String startsWith) {

 synchronized (utilCacheTable) {
-List> cachesToClear = FastList.newInstance();
-synchronized (utilCacheTable) {
- 

Re: In preparation for the 13.04 branch

2013-03-22 Thread Deepak Dixit
+1

One thing will need to move convertProductPriceCurrency property from 
ecommerce.properies file, may be place it in catalog.properties or in some 
other property file.
As this is used for automatic product price currency conversion (r1125215).

Thanks & Regards
-- 
Deepak Dixit

On Mar 23, 2013, at 2:40 AM, Jacques Le Roux wrote:

> Agreed
> 
> Jacques
> 
> From: "Adrian Crum" 
>> That seems pretty harmless. Anyone wanting to use specialpurpose can 
>> just add it to their local copy.
>> 
>> -Adrian
>> 
>> On 3/22/2013 4:19 PM, Jacopo Cappellato wrote:
>>> Hi all,
>>> 
>>> the next month is the month of the creation of our annual branch release: 
>>> release13.04.
>>> In preparation for this, I would like to propose to exclude from the 
>>> upcoming new branch the specialpurpose folder and some of the themes 
>>> components: this is inline with what we have discussed recently for the 
>>> trunk (and there seemed to be a good consensus/interest about this), i.e. 
>>> separating the specialpurpose folders into an optional module that is not 
>>> built and deployed by default: for the trunk this requires some work to 
>>> make the build scripts more flexible, but for the branch it is much simpler 
>>> (we can simply remove the folders from the branch).
>>> This will help a lot to avoid the risk to receive vulnerability reports for 
>>> the future releases, that require a good amount of work for us; in fact 
>>> there are a lot of external jars in specialpurpose and if we deliver them 
>>> in our releases we should also take care of making sure that, if the 
>>> external projects issue new releases with fixes for vulnerabilities then we 
>>> should also issue a new release as well: maintaining this is time consuming 
>>> and also reviewing all the code to make sure it meets good standard of 
>>> quality and it is clear from license issues when a release is issued is 
>>> becoming an overwhelming effort. If we deliver in releases a smaller 
>>> codebase, everything will be easier and more manageable.
>>> Of course we can still decide to issue a release of "specialpurpose" 
>>> components separately.
>>> 
>>> WDYT?
>>> 
>>> Jacopo
>> 



Re: [VOTE] [RELEASE] Apache OFBiz 12.04.01

2013-03-27 Thread Deepak Dixit
+1

Thanks & Regards
-- 
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype  :- deepakdixit

On Mar 26, 2013, at 10:02 PM, Jacopo Cappellato wrote:

> This is the vote thread to approve the first release for the 12.04 branch. 
> This new release, "Apache OFBiz 12.04.01" (major release number: "12.04"; 
> minor release number: "01") is the first release of the 12.04 series and 
> contains all the features of the trunk up to April 2012 and since then has 
> been stabilized with bug fixes. It will become the OFBiz current "stable" 
> release and users of the 11.04 series will be encouraged to migrate to this 
> release.
> 
> The candidate release files can be downloaded from here:
> 
> https://dist.apache.org/repos/dist/dev/ofbiz/
> 
> (committers only) or from here:
> 
> http://people.apache.org/~jacopoc/dist/
> 
> (everyone else)
> 
> and are:
> 
> * apache-ofbiz-12.04.01.zip: the release package, based on the 12.04 branch 
> at revision 1461136 (latest as of now)
> * KEYS: text file with keys
> * apache-ofbiz-12.04.01.zip.asc: the detached signature file
> * apache-ofbiz-12.04.01.zip.md5, apache-ofbiz-12.04.01.zip.sha: hashes
> 
> Please download the zip file and check its signatures (for instructions on 
> testing the signatures see http://www.apache.org/info/verification.html), 
> then test the release.
> 
> Vote:
> 
> [ +1] release as Apache OFBiz 12.04.01
> [ -1] do not release
> 
> This vote will be closed in Monday, 1st of April.
> For more details about this process please read 
> http://www.apache.org/foundation/voting.html
> 
> The following text is quoted from the above url:
> "Votes on whether a package is ready to be released use majority approval -- 
> i.e. at least three PMC members must vote affirmatively for release, and 
> there must be more positive than negative votes. Releases may not be vetoed. 
> Generally the community will cancel the release vote if anyone identifies 
> serious problems, but in most cases the ultimate decision, lies with the 
> individual serving as release manager."
> 
> Jacopo Cappellato
> 



Re: Query regarding the code download(SVN) and new developer on contribution in development

2013-06-11 Thread Deepak Dixit
Please post your query on user mailing list.

You  can checkout ofbiz trunk from below svn url:
https://svn.apache.org/repos/asf/ofbiz/trunk/

for more detail please visit: http://ofbiz.apache.org/source-repositories.html

Thanks & Regards
-- 
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype  :- deepakdixit

On Jun 11, 2013, at 1:42 PM, rajesh jain wrote:

> Hi All,
> 
> I am new here and want to contribute in development of this wonderful
> product OFBIZ. I want to download the  source code and want to build it
> locally so that i could start contributing.I have SVN client installed on
> my PC.But when i try to download it i am getting the below error.
> 
> *Checkout from http://svn.apache.org/repos/asf/ofbiz/site ofbiz-website,
> revision HEAD, Fully recursive, Externals included*
> URL 'http://svn.apache.org/repos/asf/ofbiz/site%20ofbiz-website' doesn't
> exist
> 
> It holds true for all the links mentioned.
> 
> Do I need additional permissions for it.
> 
> To start contributing in to it.Do I need to do something extra.
> 
> Please suggest.
> 
> Regards,
> Rajesh Jain



smime.p7s
Description: S/MIME cryptographic signature


Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Deepak Dixit
Hi Adrian,

These controller request has "event", and if an request event attribute is not 
null then WidgetWorker.determineAutoLinkType() return hidden-form as link type 
and its create an empty form for the same. 
WidgetWorker method convert hyper links to hidden for for service type of event 
as we allow only post parameter for service.

Thanks & Regards
-- 
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype  :- deepakdixit

On Jul 5, 2013, at 4:32 PM, Adrian Crum wrote:

> This doesn't make sense. Why are those two menu items exceptions to the rule?
> 
> -Adrian
> 
> On 7/5/2013 7:57 AM, jler...@apache.org wrote:
>> Author: jleroux
>> Date: Fri Jul  5 06:57:03 2013
>> New Revision: 1499918
>> 
>> URL: http://svn.apache.org/r1499918
>> Log:
>> A patch from Deepak Dixit for "Application Menu items should be link not 
>> hidden form." https://issues.apache.org/jira/browse/OFBIZ-4913
>> 
>> Application menu item should be link not hidden form. As if its hidden form 
>> then you can not open it in new tab.
>> Default menu item link type auto, and its create an hidden for for link if 
>> controller request call an event, but in menu item this should be link.
>> 
>> Modified:
>> ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml
>> ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml
>> 
>> Modified: ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml?rev=1499918&r1=1499917&r2=1499918&view=diff
>> ==
>> --- ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml (original)
>> +++ ofbiz/trunk/applications/marketing/widget/sfa/SfaMenus.xml Fri Jul  5 
>> 06:57:03 2013
>> @@ -28,7 +28,7 @@ under the License.
>>  > target="FindSalesForecast"/>
>>  > title="${uiLabelMap.SfaOpportunities}">> target="FindSalesOpportunity"/>
>>  > title="${uiLabelMap.CommonPreferences}" align-style="opposed">
>> -
>> +
>>  > from-field="parameters.parentPortalPageId"/>
>>  
>>  
>> 
>> Modified: ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml?rev=1499918&r1=1499917&r2=1499918&view=diff
>> ==
>> --- ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml (original)
>> +++ ofbiz/trunk/applications/order/widget/ordermgr/OrderMenus.xml Fri Jul  5 
>> 06:57:03 2013
>> @@ -60,7 +60,7 @@ under the License.
>>  > action="_PURCHASE_CREATE"/>
>>  
>>  
>> -
>> +
>>  
>>
>> 
>> 
> 



smime.p7s
Description: S/MIME cryptographic signature


Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Deepak Dixit
I found these reported request :)

All the request with event attribute will be render in same way and create 
hidden form.

Thanks & Regards
-- 
Deepak Dixit


On Jul 5, 2013, at 5:04 PM, Adrian Crum wrote:

> That doesn't answer my question. Why are only two requests being changed? 
> What makes those two requests the exception to all other requests that 
> include an event?
> 
> -Adrian
> 
> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>> Hi Adrian,
>> 
>> These controller request has "event", and if an request event attribute is 
>> not null then WidgetWorker.determineAutoLinkType() return hidden-form as 
>> link type and its create an empty form for the same.
>> WidgetWorker method convert hyper links to hidden for for service type of 
>> event as we allow only post parameter for service.
>> 
>> Thanks & Regards
> 



smime.p7s
Description: S/MIME cryptographic signature


Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-06 Thread Deepak Dixit
I checked all the possible menu items.

Thanks & Regards
-- 
Deepak Dixit

On Jul 5, 2013, at 7:33 PM, Jacques Le Roux wrote:

> Yes I wondered about that also, but, from his assertion, thought Deepak 
> checked all others
> 
> Deepak?
> 
> Jacques
> 
> From: "Adrian Crum" 
>> That doesn't answer my question. Why are only two requests being 
>> changed? What makes those two requests the exception to all other 
>> requests that include an event?
>> 
>> -Adrian
>> 
>> On 7/5/2013 12:19 PM, Deepak Dixit wrote:
>>> Hi Adrian,
>>> 
>>> These controller request has "event", and if an request event attribute is 
>>> not null then WidgetWorker.determineAutoLinkType() return hidden-form as 
>>> link type and its create an empty form for the same.
>>> WidgetWorker method convert hyper links to hidden for for service type of 
>>> event as we allow only post parameter for service.
>>> 
>>> Thanks & Regards
>> 



smime.p7s
Description: S/MIME cryptographic signature


Re: [VOTE] [RELEASE] Apache OFBiz 12.04.02

2013-07-14 Thread Deepak Dixit
+1

Thanks & Regards
-- 
Deepak Dixit

On Jul 13, 2013, at 6:43 PM, Jacopo Cappellato wrote:

> This is the vote thread to release a new (bug fix) release for the 12.04 
> branch. This new release, "Apache OFBiz 12.04.02" (major release number: 
> "12.04"; minor release number: "02"), will supersede the release "Apache 
> OFBiz 12.04.01".
> 
> The release files can be downloaded from here:
> 
> https://dist.apache.org/repos/dist/dev/ofbiz/
> 
> (committers only) or from here:
> 
> http://people.apache.org/~jacopoc/dist/
> 
> (everyone else)
> 
> and are:
> 
> * apache-ofbiz-12.04.02.zip: the release package, based on the 12.04 branch 
> (latest revision as of now)
> * KEYS: text file with keys
> * apache-ofbiz-12.04.02.zip.asc: the detached signature file
> * apache-ofbiz-12.04.02.zip.md5, apache-ofbiz-12.04.02.zip.sha: hashes
> 
> Please download and test the zip file and its signatures (for instructions on 
> testing the signatures see http://www.apache.org/info/verification.html).
> 
> Vote:
> 
> [ +1] release as Apache OFBiz 12.04.02
> [ -1] do not release
> 
> This vote will be closed in Thursday, 18th of July.
> For more details about this process please read 
> http://www.apache.org/foundation/voting.html
> 
> The following text is quoted from the above url:
> "Votes on whether a package is ready to be released use majority approval -- 
> i.e. at least three PMC members must vote affirmatively for release, and 
> there must be more positive than negative votes. Releases may not be vetoed. 
> Generally the community will cancel the release vote if anyone identifies 
> serious problems, but in most cases the ultimate decision, lies with the 
> individual serving as release manager."
> 
> Kind Regards,
> 
> Jacopo



smime.p7s
Description: S/MIME cryptographic signature


Re: [VOTE] [RELEASE] Apache OFBiz 10.04.06

2013-07-14 Thread Deepak Dixit
+1

Thanks & Regards
-- 
Deepak Dixit

On Jul 13, 2013, at 6:40 PM, Jacopo Cappellato wrote:

> This is the vote thread to release a new (bug fix) release for the 10.04 
> branch. This new release, "Apache OFBiz 10.04.06" (major release number: 
> "10.04"; minor release number: "06"), will supersede the release "Apache 
> OFBiz 10.04.05".
> 
> The release files can be downloaded from here:
> 
> https://dist.apache.org/repos/dist/dev/ofbiz/
> 
> (committers only) or from here:
> 
> http://people.apache.org/~jacopoc/dist/
> 
> (everyone else)
> 
> and are:
> 
> * apache-ofbiz-10.04.06.zip: the release package, based on the 10.04 branch 
> (latest revision as of now)
> * KEYS: text file with keys
> * apache-ofbiz-10.04.06.zip.asc: the detached signature file
> * apache-ofbiz-10.04.06.zip.md5, apache-ofbiz-10.04.06.zip.sha: hashes
> 
> Please download and test the zip file and its signatures (for instructions on 
> testing the signatures see http://www.apache.org/info/verification.html).
> 
> Vote:
> 
> [ +1] release as Apache OFBiz 10.04.06
> [ -1] do not release
> 
> This vote will be closed in Thursday, 18th of July.
> For more details about this process please read 
> http://www.apache.org/foundation/voting.html
> 
> The following text is quoted from the above url:
> "Votes on whether a package is ready to be released use majority approval -- 
> i.e. at least three PMC members must vote affirmatively for release, and 
> there must be more positive than negative votes. Releases may not be vetoed. 
> Generally the community will cancel the release vote if anyone identifies 
> serious problems, but in most cases the ultimate decision, lies with the 
> individual serving as release manager."
> 
> Kind Regards,
> 
> Jacopo



smime.p7s
Description: S/MIME cryptographic signature


Re: [VOTE] [RELEASE] Apache OFBiz 11.04.03

2013-07-14 Thread Deepak Dixit
+1

Thanks & Regards
-- 
Deepak Dixit

On Jul 13, 2013, at 6:43 PM, Jacopo Cappellato wrote:

> This is the vote thread to release a new (bug fix) release for the 11.04 
> branch. This new release, "Apache OFBiz 11.04.03" (major release number: 
> "11.04"; minor release number: "03"), will supersede the release "Apache 
> OFBiz 11.04.02".
> 
> The release files can be downloaded from here:
> 
> https://dist.apache.org/repos/dist/dev/ofbiz/
> 
> (committers only) or from here:
> 
> http://people.apache.org/~jacopoc/dist/
> 
> (everyone else)
> 
> and are:
> 
> * apache-ofbiz-11.04.03.zip: the release package, based on the 11.04 branch 
> (latest revision as of now)
> * KEYS: text file with keys
> * apache-ofbiz-11.04.03.zip.asc: the detached signature file
> * apache-ofbiz-11.04.03.zip.md5, apache-ofbiz-11.04.03.zip.sha: hashes
> 
> Please download and test the zip file and its signatures (for instructions on 
> testing the signatures see http://www.apache.org/info/verification.html).
> 
> Vote:
> 
> [ +1] release as Apache OFBiz 11.04.03
> [ -1] do not release
> 
> This vote will be closed in Thursday, 18th of July.
> For more details about this process please read 
> http://www.apache.org/foundation/voting.html
> 
> The following text is quoted from the above url:
> "Votes on whether a package is ready to be released use majority approval -- 
> i.e. at least three PMC members must vote affirmatively for release, and 
> there must be more positive than negative votes. Releases may not be vetoed. 
> Generally the community will cancel the release vote if anyone identifies 
> serious problems, but in most cases the ultimate decision, lies with the 
> individual serving as release manager."
> 
> Kind Regards,
> 
> Jacopo



smime.p7s
Description: S/MIME cryptographic signature


Re: Freemarker 2.3.20 is released

2013-08-14 Thread Deepak Dixit
+1 


Thanks & Regards
-- 
Deepak Dixit

On Aug 14, 2013, at 3:20 PM, Jacopo Cappellato wrote:

> If there are no objections I would like to upgrade the trunk with the latest 
> official 2.3.20 release; then after some time, if we will not face any issues 
> related to the overloaded methods in templates I will backport the jar to the 
> 13.07 branch: in this way we will distribute the official Freemarker jars, 
> and it will be easy to stay updated with the new bug fix releases from the 
> Freemarker community.
> 
> Jacopo
> 
> 
> On Jul 7, 2013, at 8:40 AM, Jacopo Cappellato 
>  wrote:
> 
>> Current situation: in OFBiz we are currently using/distributing a patched 
>> version of Freemarker 2.3.19; the patch version addresses the bugs reported 
>> below.
>> 
>> News: the new version of Freemarker (2.3.20) has been finally released and 
>> it is available for download:
>> 
>> http://freemarker.org/docs/versions_2_3_20.html
>> 
>> Good News: the deadlock issue that was affecting OFBiz (under special 
>> conditions) that we have reported and helped to fix, has been resolved:
>> 
>> http://sourceforge.net/p/freemarker/bugs/361/
>> 
>> Bad News: the "Wrong overloaded method" issue, for which Adam Heat submitted 
>> a patch to the Freemarker community and patched the 2.3.19 release we are 
>> using, was not resolved in this release:
>> 
>> http://sourceforge.net/p/freemarker/bugs/363/
>> 
>> Adam, could you please check this comment from Daniel and possibly follow up 
>> with him?
>> 
>> http://sourceforge.net/p/freemarker/bugs/363/?limit=10&page=1#bb98
>> 
>> "I'm looking into the overloaded method related parts (I don't mean the 
>> patch) and... there are other issues as well. Certainly I will have to *try* 
>> redesign/rewrite this stuff pretty much (it's tricky because of FM object 
>> wrapping), and of course, I will have to add switch where you can chose 
>> between old and the new implementation, globally or per template. Now this 
>> 100% won't be finished in two days, so I guess 2.3.20 will be release 
>> without this, but then I continue working on this, and release 2.3.21 when 
>> this and some other smaller things are done..."
>> 
>> Thanks,
>> 
>> Jacopo
>> 
> 



smime.p7s
Description: S/MIME cryptographic signature


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.02 - third attempt

2015-05-14 Thread Deepak Dixit
+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Fri, May 15, 2015 at 6:50 AM, Darrell Donati 
wrote:

> +1
>
> - Darrell
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/VOTE-RELEASE-Apache-OFBiz-13-07-02-third-attempt-tp4668261p4668308.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>


Re: Unable to take update or checkout

2015-06-06 Thread Deepak Dixit
SVN service restored but some DNS related issue still persists.


Thanks & Regards
—
Deepak Dixit


> On Jun 6, 2015, at 4:01 PM, Pierre Smits  wrote:
> 
> SVN services are restored, according to a message in the infra ml.
> 
> Best regards,
> 
> Pierre Smits
> 
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
> 
> On Sat, Jun 6, 2015 at 11:48 AM, Pierre Smits 
> wrote:
> 
>> Thanks for the update, Ashish.
>> 
>> Best regards,
>> 
>> Pierre Smits
>> 
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>> 
>> On Sat, Jun 6, 2015 at 11:47 AM, Ashish Vijaywargiya <
>> ashish.vijaywarg...@hotwaxsystems.com> wrote:
>> 
>>> Hello,
>>> 
>>> I am getting following error when taking update of any of the OFBiz code
>>> base(trunk or release branches):
>>> 
>>> ashish@ashish:~/ofbiz-dev/ofbiz-14.12$ svn update
>>> Updating '.':
>>> svn: E175011: Repository moved permanently to 'https://svn.apache.org';
>>> please relocate
>>> svn: E175009: Additional errors:
>>> svn: E175009: XML parsing failed: (301 Moved Permanently)
>>> 
>>> It seems that ASF team is working on this issue and it will be rectified
>>> soon. Please refer below link:
>>> 
>>> http://status.apache.org/
>>> 
>>> --
>>> Kind Regards
>>> Ashish Vijaywargiya
>>> HotWax Systems - est. 1997
>>> 
>> 
>> 



Re: svn commit: r1686635 - in /ofbiz/trunk/applications/order: servicedef/ src/org/ofbiz/order/order/ webapp/ordermgr/WEB-INF/ webapp/ordermgr/WEB-INF/actions/order/ webapp/ordermgr/order/

2015-06-20 Thread Deepak Dixit
Please do not use javolution classes.

Thanks & Regards
--
Deepak Dixit

On Saturday, June 20, 2015,  wrote:

> Author: diveshdutta
> Date: Sat Jun 20 14:58:45 2015
> New Revision: 1686635
>
> URL: http://svn.apache.org/r1686635
> Log:
> [OFBIZ-5347] 1) Fixed issue: Shipping costs not recalculated after
> changing sales order shipment method. For this introduced new service as
> per the design in this task. 2) This service will loads the cart save new
> shipping method in cart, re-do all the calculations for tax and promotion,
> and saves the cart again in order. 3) Also adding new SECA rule which will
> trigger resetGrandTotal service on new service updateShipGroupShipInfo.
>
> Modified:
> ofbiz/trunk/applications/order/servicedef/secas.xml
> ofbiz/trunk/applications/order/servicedef/services.xml
>
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
>
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
>
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/OrderView.groovy
> ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/controller.xml
>
> ofbiz/trunk/applications/order/webapp/ordermgr/order/ordershippinginfo.ftl
>
> Modified: ofbiz/trunk/applications/order/servicedef/secas.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/secas.xml?rev=1686635&r1=1686634&r2=1686635&view=diff
>
> ==
> --- ofbiz/trunk/applications/order/servicedef/secas.xml (original)
> +++ ofbiz/trunk/applications/order/servicedef/secas.xml Sat Jun 20
> 14:58:45 2015
> @@ -451,4 +451,7 @@ under the License.
>   value="SALES_ORDER"/>
>  
>  
> +
> +
> +
>  
>
> Modified: ofbiz/trunk/applications/order/servicedef/services.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services.xml?rev=1686635&r1=1686634&r2=1686635&view=diff
>
> ==
> --- ofbiz/trunk/applications/order/servicedef/services.xml (original)
> +++ ofbiz/trunk/applications/order/servicedef/services.xml Sat Jun 20
> 14:58:45 2015
> @@ -1187,4 +1187,12 @@ under the License.
>  
>  
>
> + location="org.ofbiz.order.order.OrderServices"
> invoke="updateShipGroupShipInfo" auth="true">
> +Update Shipping Information on Order
> View
> +  optional="false"/>
> +  optional="true"/>
> +  optional="true"/>
> +  optional="true"/>
> +  optional="true"/>
> +
>  
>
> Modified:
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java?rev=1686635&r1=1686634&r2=1686635&view=diff
>
> ==
> ---
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
> (original)
> +++
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
> Sat Jun 20 14:58:45 2015
> @@ -33,6 +33,8 @@ import java.util.Locale;
>  import java.util.Map;
>  import java.util.Set;
>
> +import javolution.util.FastList;
> +
>  import org.ofbiz.base.util.Debug;
>  import org.ofbiz.base.util.UtilDateTime;
>  import org.ofbiz.base.util.UtilFormatOut;
> @@ -3012,4 +3014,17 @@ public class OrderReadHelper {
>  }
>  }
>
> +public List getShippableSizes(String shipGrouSeqId) {
> +List shippableSizes = FastList.newInstance();
> +
> +List validItems = getValidOrderItems(shipGrouSeqId);
> +if (validItems != null) {
> +Iterator i = validItems.iterator();
> +while (i.hasNext()) {
> +GenericValue item = i.next();
> +shippableSizes.add(this.getItemSize(item));
> +}
> +}
> +return shippableSizes;
> +}
>  }
>
> Modified:
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1686635&r1=1686634&r2=1686635&view=diff
>
> ==
> ---
> ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
> (original)
> +++
> 

Re: Should we revert 1530237?

2015-08-21 Thread Deepak Dixit
+1

Thanks & Regards
-- 
Deepak Dixit

On Friday, August 21, 2015, Jacques Le Roux 
wrote:

> I made it, but agree consistency is better +1
>
> Jacques
>
> Le 21/08/2015 15:28, Arun Patidar a écrit :
>
>> +1.
>>
>> Thanks & Regards
>> ---
>> Arun Patidar
>> Manager,Enterprise Software Development
>> HotWax Systems
>> www.hotwaxsystems.com
>>
>> On Friday 21 August 2015 06:03 PM, Taher Alkhateeb wrote:
>>
>>> Hi Jacopo,
>>>
>>> +1 It makes perfect sense to have consistent database "rules" across the
>>> different databases to reduce fragmentation and workarounds.
>>>
>>> Taher Alkhateeb
>>>
>>> - Original Message -
>>>
>>> From: "Michael Brohl" 
>>> To: dev@ofbiz.apache.org
>>> Sent: Friday, 21 August, 2015 3:26:24 PM
>>> Subject: Re: Should we revert 1530237?
>>>
>>> Hi Jacopo,
>>>
>>> I agree that the field length should be equal on every database to avoid
>>> migration problems if you change the database.
>>> So +1.
>>>
>>> Regards,
>>>
>>> Michael Brohl
>>> ecomify GmbH
>>> www.ecomify.de
>>>
>>> Am 21.08.15 um 12:34 schrieb Jacopo Cappellato:
>>>
>>>> Hi all,
>>>>
>>>> in rev. 1530237 the sql type for Postgres for "comments" and
>>>> "description" fields was changed from VARCHAR(255) to TEXT:
>>>>
>>>> https://fisheye6.atlassian.com/changelog/ofbiz/?cs=1530237
>>>>
>>>> The original contribution and discussion can be found here:
>>>>
>>>> https://issues.apache.org/jira/browse/OFBIZ-1920
>>>>
>>>> However I don't think it was a good idea and I suggest to change the
>>>> types back to VARCHAR(255) because the new TEXT type allows strings of any
>>>> length; all other types definitions (MySQL, Derby etc...) are using
>>>> VARCHAR(255) thus limiting the length of "comments" and "description"
>>>> fields to 255 characters and now Postgres is the only one that is 
>>>> different.
>>>>
>>>> In my opinion we should set postgres to VARCHAR(255) too until we will
>>>> decide to change the size for all the dbs.
>>>>
>>>> Any objections?
>>>>
>>>> Kind regards,
>>>>
>>>> Jacopo
>>>>
>>>
>>>
>>>
>>>
>>
>>

-- 
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com


Re: svn commit: r1686655 - in /ofbiz/trunk: framework/common/widget/ themes/bizznesstime/data/ themes/bizznesstime/includes/ themes/bluelight/data/ themes/bluelight/includes/ themes/droppingcrumbs/dat

2015-08-24 Thread Deepak Dixit
Hi Adrian,

This is nice enhancement, But I think we should have to keep the 
layoutSettings.javaScripts part in header.ftl file to support the component 
specific js. 
As we removed following code from header.ftl file so component specific js is 
not loading and related functionality is broken in partymgr, webs, content etc.

> 
> -  <#if layoutSettings.javaScripts?has_content>
> -<#assign javaScriptsSet = 
> Static["org.ofbiz.base.util.UtilMisc"].toSet(layoutSettings.javaScripts)/>
> -<#list layoutSettings.javaScripts as javaScript>
> -<#if javaScriptsSet.contains(javaScript)>
> -<#assign nothing = javaScriptsSet.remove(javaScript)/>
> - src="<@ofbizContentUrl>${StringUtil.wrapString(javaScript)}</@ofbizContentUrl>"
>  type="text/javascript">
> -
> -
> -


We have around 93 occurrence of layoutSettings.javaScripts in system.
What should be the best solution?

- Add data for all the js? But it will load specific component related js to 
accords the site unnecessarily.
- Add the layoutSettings.javaScripts code just after the 
layoutSettings.VT_HDR_JAVASCRIPT inclusion. It will allow to include the 
component specific js in header. 


Thanks & Regards
—
Deepak Dixit


> On Jun 20, 2015, at 10:32 PM, adri...@apache.org wrote:
> 
> Author: adrianc
> Date: Sat Jun 20 17:02:22 2015
> New Revision: 1686655
> 
> URL: http://svn.apache.org/r1686655
> Log:
> Move theme-specific js & css references from CommonDecorator(s) to themes - 
> https://issues.apache.org/jira/browse/OFBIZ-6362.
> 
> Modified:
>ofbiz/trunk/framework/common/widget/CommonScreens.xml
>ofbiz/trunk/themes/bizznesstime/data/BizznessTimeThemeData.xml
>ofbiz/trunk/themes/bizznesstime/includes/header.ftl
>ofbiz/trunk/themes/bluelight/data/BlueLightThemeData.xml
>ofbiz/trunk/themes/bluelight/includes/header.ftl
>ofbiz/trunk/themes/droppingcrumbs/data/DroppingCrumbsThemeData.xml
>ofbiz/trunk/themes/droppingcrumbs/includes/header.ftl
>ofbiz/trunk/themes/flatgrey/data/FlatGreyThemeData.xml
>ofbiz/trunk/themes/flatgrey/includes/header.ftl
>ofbiz/trunk/themes/tomahawk/data/TomahawkThemeData.xml
>ofbiz/trunk/themes/tomahawk/includes/header.ftl
> 
> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=1686655&r1=1686654&r2=1686655&view=diff
> ==
> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Sat Jun 20 17:02:22 
> 2015
> @@ -137,41 +137,19 @@ under the License.
> 
> 
> 
> -
> -
> -
> - value="${groovy:parameters?.userLogin?.lastLocale}" 
> default-value="${groovy:locale.toString()}" />
> -  global="true" />
> -  global="true" />
> -  global="true" />
> -  global="true" />
> - value="/images/jquery/plugins/asmselect/jquery.asmselect-1.0.4a-beta.js" 
> global="true" />
> - value="/images/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon.min-1.4.3.js"
>  global="true" />
> - value="/images/jquery/plugins/jquery.maskedinput-1.3.1.min.js" global="true" 
> />
> - value="/images/jquery/ui/js/jquery-ui-1.10.3.min.js" global="true" />
> - value="/images/jquery/plugins/jeditable/jquery.jeditable.js" global="true" />
> - value="/images/jquery/plugins/validate/jquery.validate.min.js" global="true" 
> />
> - value="/images/jquery/plugins/fjTimer/jquerytimer-min.js" global="true" />
> - value="/images/jquery/jquery-migrate-1.2.1.js" global="true"/>
> - value="/images/jquery/jquery-1.11.0.min.js" global="true" />
> -
> - value="/images/jquery/plugins/asmselect/jquery.asmselect-1.0.4a-beta.css" 
> global="true" />
> -
> - value="/images/OpenLayers-2.13.1.js" global="true" />
> - value="/images/selectall.js" global="true" />
> - 

Re: svn commit: r1686655 - in /ofbiz/trunk: framework/common/widget/ themes/bizznesstime/data/ themes/bizznesstime/includes/ themes/bluelight/data/ themes/bluelight/includes/ themes/droppingcrumbs/dat

2015-08-24 Thread Deepak Dixit
Thanks Pierre. I'll add the missing code.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Aug 24, 2015 at 10:54 PM, Pierre Smits 
wrote:

> Yes, we should maintain the ability to define component specific js and css
> settings. Adding the missing piece in the header .ftl files of the themes
> ensures functionality and backward compatibility (somewhat).
>
> Best regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>


Re: svn commit: r1686655 - in /ofbiz/trunk: framework/common/widget/ themes/bizznesstime/data/ themes/bizznesstime/includes/ themes/bluelight/data/ themes/bluelight/includes/ themes/droppingcrumbs/dat

2015-08-24 Thread Deepak Dixit
Fixed at r#1697574


Thanks & Regards
—
Deepak Dixit


> On Aug 25, 2015, at 10:21 AM, Deepak Dixit  
> wrote:
> 
> Thanks Pierre. I'll add the missing code.
> 
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com <http://www.hotwaxsystems.com/>
> 
> On Mon, Aug 24, 2015 at 10:54 PM, Pierre Smits  <mailto:pierre.sm...@gmail.com>> wrote:
> Yes, we should maintain the ability to define component specific js and css
> settings. Adding the missing piece in the header .ftl files of the themes
> ensures functionality and backward compatibility (somewhat).
> 
> Best regards,
> 
> Pierre Smits
> 
> *ORRTIZ.COM <http://orrtiz.com/> <http://www.orrtiz.com 
> <http://www.orrtiz.com/>>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com <http://www.orrtiz.com/>
> 



Security enhancement

2015-09-24 Thread Deepak Dixit
Hi Dev, 

I would like to propose some security enhancement at web-app level. 
IMO we have to enhance sessionId and cookie tracking. As per current 
implementation:
- The cookie containing the session identifier is not secure
- The session identifier is transmitted in the query string of the URL

We can add following configuration in web.xml to fix the above issue:



true
true

COOKIE


To use cookie-config and tracking-mode we need to update the servlet 
specification to 3.0 
https://tomcat.apache.org/whichversion.html


Thanks & Regards
—
Deepak Dixit




Re: Security enhancement

2015-09-26 Thread Deepak Dixit
Thanks Pierre and Jacques.
I opened ticket for the same: https://issues.apache.org/jira/browse/OFBIZ-6655

Thanks & Regards
—
Deepak Dixit

> On Sep 24, 2015, at 5:35 PM, Jacques Le Roux  
> wrote:
> 
> That's quite a good news, thanks Deepak and Pierre!
> 
> Jacques
> 
> Le 24/09/2015 11:44, Pierre Smits a écrit :
>> Servlet spec 3.0 is implemented in Tomcat versions 7.x. In trunk (and
>> release branch 14.x) we use Tomcat 7.0.64.
>> 
>> So this can be applied in future release branches as well as in r14.x
>> 
>> Best regards,
>> 
>> Pierre Smits
>> 
>> *OFBiz Extensions Marketplace*
>> http://oem.ofbizci.net
>> 
>> On Thu, Sep 24, 2015 at 11:27 AM, Deepak Dixit <
>> deepak.di...@hotwaxsystems.com> wrote:
>> 
>>> Hi Dev,
>>> 
>>> I would like to propose some security enhancement at web-app level.
>>> IMO we have to enhance sessionId and cookie tracking. As per current
>>> implementation:
>>> - The cookie containing the session identifier is not secure
>>> - The session identifier is transmitted in the query string of the URL
>>> 
>>> We can add following configuration in web.xml to fix the above issue:
>>> 
>>> 
>>> 
>>> true
>>> true
>>> 
>>> COOKIE
>>> 
>>> 
>>> To use cookie-config and tracking-mode we need to update the servlet
>>> specification to 3.0
>>> https://tomcat.apache.org/whichversion.html
>>> 
>>> 
>>> Thanks & Regards
>>> —
>>> Deepak Dixit
>>> 
>>> 
>>> 



Re: svn commit: r1705331 [1/2] - in /ofbiz/branches/release14.12: ./ applications/accounting/webapp/accounting/reports/ applications/content/src/org/ofbiz/content/content/ applications/order/src/org/o

2015-09-26 Thread Deepak Dixit
Hi Jacques, 

ecommerce is broken, I think you missed some groovy file where description, 
name is used directly. like  

categoryDescription = categoryContentWrapper.DESCRIPTION;

I am getting following error while accession ecommerce on updated local box:
{code}
[java] Caused by: java.lang.IllegalArgumentException: Error running script at 
location 
[component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/Category.groovy]:
 groovy.lang.MissingPropertyException: No such property: DESCRIPTION for class: 
org.ofbiz.product.category.CategoryContentWrapper

{code}


Thanks & Regards
—
Deepak Dixit

> On Sep 25, 2015, at 10:14 PM, Jacques Le Roux  
> wrote:
> 
> I did not backport to older releases because of too much conflicts, anyway 
> it's a low vulnerability
> 
> Jacqued
> 
> 
> Le 25/09/2015 18:34, jler...@apache.org a écrit :
>> Author: jleroux
>> Date: Fri Sep 25 16:34:34 2015
>> New Revision: 1705331
>> 
>> URL: http://svn.apache.org/viewvc?rev=1705331&view=rev
>> Log:
>> "Applied fix from trunk for revision: 1705329  " (conflicts handled by hand)
>> 
>> r1705329 | jleroux | 2015-09-25 18:27:12 +0200 (ven. 25 sept. 2015) | 20 
>> lignes
>> 
>> I found a possible XSS attack through 
>> ProductContentWrapper.java.getProductContentAsText() which is notably used 
>> in several FTL files. This exists also in others *ContentWrapper.java.
>> Note that in supported releases it's hard to exploit, it's a Stored XSS 
>> https://www.owasp.org/index.php/Types_of_Cross-Site_Scripting which means 
>> you need 1st to somehow inject exploiting code in the DB.
>> 
>> This fixes it by changing the ContentWrapper interface
>> from
>> public interface ContentWrapper {
>> public StringUtil.StringWrapper get(String contentTypeId);
>> }
>> to
>> public interface ContentWrapper {
>> public StringUtil.StringWrapper get(String contentTypeId, String 
>> encoderType) {
>> }
>> 
>> And changing the Category, Party, Product, ProductPromo and WorkEffort 
>> ContentWrapperS accordingly. This means to use 2 types of encoderTypes: 
>> "html" and "url".
>> The "html"  encoderType will be used for all ProductContentTypes but those 
>> who contain URL in their ContentTypeIdS (actually end with, "_URL") which 
>> will use "url" encoderType.
>> It concerns not only the get() method but also methods like 
>> getPartyContentAsText(), getProductContentAsText(), etc.
>> 
>> It seems a big change but it's straightforward. It's normally complete.
>> 
>> There are some (unrelated) tabs replaced by spaces here and there, and few 
>> trailing spaces removed but nothing big
>> 
>> 
>> 
>> Modified:
>> ofbiz/branches/release14.12/   (props changed)
>> 
>> ofbiz/branches/release14.12/applications/accounting/webapp/accounting/reports/SalesInvoiceByProductCategorySummary.ftl
>> 
>> ofbiz/branches/release14.12/applications/content/src/org/ofbiz/content/content/ContentWrapper.java
>> 
>> ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/order/OrderReturnServices.java
>> 
>> ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java
>> 
>> ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/InlineProductDetail.groovy
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ProductDetail.groovy
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/entry/SplitShip.ftl
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/entry/cart/showcartitems.ftl
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/entry/catalog/breadcrumbs.ftl
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/entry/catalog/compareproducts.ftl
>> 
>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/entry/catalog/compareprodu

Re: svn commit: r1705331 [1/2] - in /ofbiz/branches/release14.12: ./ applications/accounting/webapp/accounting/reports/ applications/content/src/org/ofbiz/content/content/ applications/order/src/org/o

2015-09-26 Thread Deepak Dixit
Hi Jacques,

Can we add the get method with default encoding to maintain the backward 
compatibility?


Thanks & Regards
—
Deepak Dixit



> On Sep 26, 2015, at 2:54 PM, Deepak Dixit  
> wrote:
> 
> Hi Jacques, 
> 
> ecommerce is broken, I think you missed some groovy file where description, 
> name is used directly. like  
> 
> categoryDescription = categoryContentWrapper.DESCRIPTION;
> 
> I am getting following error while accession ecommerce on updated local box:
> {code}
> [java] Caused by: java.lang.IllegalArgumentException: Error running script at 
> location 
> [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/Category.groovy]:
>  groovy.lang.MissingPropertyException: No such property: DESCRIPTION for 
> class: org.ofbiz.product.category.CategoryContentWrapper
> 
> {code}
> 
> 
> Thanks & Regards
> —
> Deepak Dixit
> 
>> On Sep 25, 2015, at 10:14 PM, Jacques Le Roux  
>> wrote:
>> 
>> I did not backport to older releases because of too much conflicts, anyway 
>> it's a low vulnerability
>> 
>> Jacqued
>> 
>> 
>> Le 25/09/2015 18:34, jler...@apache.org a écrit :
>>> Author: jleroux
>>> Date: Fri Sep 25 16:34:34 2015
>>> New Revision: 1705331
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1705331&view=rev
>>> Log:
>>> "Applied fix from trunk for revision: 1705329  " (conflicts handled by hand)
>>> 
>>> r1705329 | jleroux | 2015-09-25 18:27:12 +0200 (ven. 25 sept. 2015) | 20 
>>> lignes
>>> 
>>> I found a possible XSS attack through 
>>> ProductContentWrapper.java.getProductContentAsText() which is notably used 
>>> in several FTL files. This exists also in others *ContentWrapper.java.
>>> Note that in supported releases it's hard to exploit, it's a Stored XSS 
>>> https://www.owasp.org/index.php/Types_of_Cross-Site_Scripting which means 
>>> you need 1st to somehow inject exploiting code in the DB.
>>> 
>>> This fixes it by changing the ContentWrapper interface
>>> from
>>>public interface ContentWrapper {
>>>public StringUtil.StringWrapper get(String contentTypeId);
>>>}
>>> to
>>>public interface ContentWrapper {
>>>public StringUtil.StringWrapper get(String contentTypeId, String 
>>> encoderType) {
>>>}
>>> 
>>> And changing the Category, Party, Product, ProductPromo and WorkEffort 
>>> ContentWrapperS accordingly. This means to use 2 types of encoderTypes: 
>>> "html" and "url".
>>> The "html"  encoderType will be used for all ProductContentTypes but those 
>>> who contain URL in their ContentTypeIdS (actually end with, "_URL") which 
>>> will use "url" encoderType.
>>> It concerns not only the get() method but also methods like 
>>> getPartyContentAsText(), getProductContentAsText(), etc.
>>> 
>>> It seems a big change but it's straightforward. It's normally complete.
>>> 
>>> There are some (unrelated) tabs replaced by spaces here and there, and few 
>>> trailing spaces removed but nothing big
>>> 
>>> 
>>> 
>>> Modified:
>>>ofbiz/branches/release14.12/   (props changed)
>>>
>>> ofbiz/branches/release14.12/applications/accounting/webapp/accounting/reports/SalesInvoiceByProductCategorySummary.ftl
>>>
>>> ofbiz/branches/release14.12/applications/content/src/org/ofbiz/content/content/ContentWrapper.java
>>>
>>> ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/order/OrderReturnServices.java
>>>
>>> ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartItem.java
>>>
>>> ofbiz/branches/release14.12/applications/order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java
>>>
>>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/InlineProductDetail.groovy
>>>
>>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ProductDetail.groovy
>>>
>>> ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy
>>>
>>> ofbiz/branches/release14.12/applications/order/webapp/ord

Re: Welcome to our new committers Gil Portenseigne and Wei Zhang!

2015-10-06 Thread Deepak Dixit
Many Congrats Guys….


Thanks & Regards
—
Deepak Dixit


> On Oct 6, 2015, at 3:03 PM, Jacopo Cappellato 
>  wrote:
> 
> On behalf of the PMC, welcome onboard guys and keep up the good work!
> 
> Jacopo



svn commit: r1707857 - in /ofbiz/trunk: applications/product/src/org/ofbiz/product/config/ specialpurpose/ecommerce/webapp/ecommerce/catalog/

2015-10-12 Thread Deepak Dixit
Hi Jacques,

I think we fixed all these ContentWrapper* code in trunk code base,  but it
will affect lot of custom code as well.
So IMO  we have to maintain backward compatibility as well.

Can we add an get method that will use the default encoding as html?

As we generally used ContentWrapper to render the Content (generally
html/text) so we can add get method with default encoding as html e.g.

{code}
public String get(String contentTypeId) {
 return get (contentTypeId, "html")
}
{code}

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Sat, Oct 10, 2015 at 4:08 PM, > wrote:

> Author: jleroux
> Date: Sat Oct 10 10:38:49 2015
> New Revision: 1707857
>
> URL: http://svn.apache.org/viewvc?rev=1707857&view=rev
> Log:
> Fixes "ecommerce screen exception"
> https://issues.apache.org/jira/browse/OFBIZ-6665 reported by Wai
>
> I missed this hidden ProductConfigItemContentWrapper class while working
> on r1705329 and sequels. I checked there are no other *ContentWrapper
> classes left now.
>
> Modified:
>
> ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java
>
> ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
>
> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/catalog/configproductdetail.ftl
>
> Modified:
> ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java?rev=1707857&r1=1707856&r2=1707857&view=diff
>
> ==
> ---
> ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java
> (original)
> +++
> ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java
> Sat Oct 10 10:38:49 2015
> @@ -22,7 +22,6 @@ import java.io.IOException;
>  import java.io.StringWriter;
>  import java.io.Writer;
>  import java.util.HashMap;
> -import java.util.List;
>  import java.util.Locale;
>  import java.util.Map;
>
> @@ -30,9 +29,13 @@ import javax.servlet.http.HttpServletReq
>
>  import org.ofbiz.base.util.Debug;
>  import org.ofbiz.base.util.GeneralException;
> +import org.ofbiz.base.util.StringUtil;
> +import org.ofbiz.base.util.StringUtil.StringWrapper;
> +import org.ofbiz.base.util.UtilCodec;
>  import org.ofbiz.base.util.UtilHttp;
>  import org.ofbiz.base.util.UtilValidate;
>  import org.ofbiz.content.content.ContentWorker;
> +import org.ofbiz.content.content.ContentWrapper;
>  import org.ofbiz.entity.Delegator;
>  import org.ofbiz.entity.DelegatorFactory;
>  import org.ofbiz.entity.GenericValue;
> @@ -46,7 +49,7 @@ import org.ofbiz.service.ServiceContaine
>   * Product Config Item Content Worker: gets product content to display
>   */
>  @SuppressWarnings("serial")
> -public class ProductConfigItemContentWrapper implements
> java.io.Serializable {
> +public class ProductConfigItemContentWrapper implements ContentWrapper {
>
>  public static final String module =
> ProductConfigItemContentWrapper.class.getName();
>
> @@ -83,8 +86,8 @@ public class ProductConfigItemContentWra
>  this.mimeTypeId = "text/html";
>  }
>
> -public String get(String confItemContentTypeId) {
> -return getProductConfigItemContentAsText(productConfigItem,
> confItemContentTypeId, locale, mimeTypeId, getDelegator(), getDispatcher());
> +public StringWrapper get(String confItemContentTypeId, String
> encoderType) {
> +return
> StringUtil.makeStringWrapper(getProductConfigItemContentAsText(productConfigItem,
> confItemContentTypeId, locale, mimeTypeId, getDelegator(), getDispatcher(),
> encoderType));
>  }
>
>  public Delegator getDelegator() {
> @@ -101,32 +104,36 @@ public class ProductConfigItemContentWra
>  return dispatcher;
>  }
>
> -public static String getProductConfigItemContentAsText(GenericValue
> productConfigItem, String confItemContentTypeId, HttpServletRequest
> request) {
> +public static String getProductConfigItemContentAsText(GenericValue
> productConfigItem, String confItemContentTypeId, HttpServletRequest
> request, String encoderType) {
>  LocalDispatcher dispatcher = (LocalDispatcher)
> request.getAttribute("dispatcher");
> -return getProductConfigItemContentAsText(productConfigItem,
> confItemContentTypeId, UtilHttp.getLocale(request), "text/html",
> productConfigItem.getDelegator(), dispatcher);
> +return getPro

Re: svn commit: r1708275 - in /ofbiz/branches/release14.12: ./ applications/content/config/ applications/content/src/org/ofbiz/content/content/ framework/base/lib/ specialpurpose/cmssite/data/

2015-10-13 Thread Deepak Dixit
Hi Jacques,

I am getting following exception on 14.12:

{code}
 java.lang.NoClassDefFoundError: Could not initialize class
org.owasp.html.Sanitizers
[java] at
org.ofbiz.content.content.ContentWorker.renderContentAsText(ContentWorker.java:354)
~[ofbiz-content.jar:?]
[java] at
org.ofbiz.content.content.ContentMapFacade.renderThis(ContentMapFacade.java:343)
~[ofbiz-content.jar:?]
[java] at
org.ofbiz.content.content.ContentMapFacade.toString(ContentMapFacade.java:355)
~[ofbiz-content.jar:?]
[java] at
freemarker.ext.beans.StringModel.getAsString(StringModel.java:61)
~[freemarker-2.3.22.jar:2.3.22]
[java] at freemarker.core.EvalUtil.modelToString(EvalUtil.java:55)
~[freemarker-2.3.22.jar:2.3.22]
[java] at
freemarker.core.EvalUtil.coerceModelToString(EvalUtil.java:340)
~[freemarker-2.3.22.jar:2.3.22]

{code}

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Tue, Oct 13, 2015 at 6:15 AM,  wrote:

> Author: jleroux
> Date: Tue Oct 13 00:45:31 2015
> New Revision: 1708275
>
> URL: http://svn.apache.org/viewvc?rev=1708275&view=rev
> Log:
> "Applied fix from trunk for revision: 1708274  " (handled conflicts on
> .classpath by hand)
> 
> r1708274 | jleroux | 2015-10-13 02:40:47 +0200 (mar. 13 oct. 2015) | 1
> ligne
>
> Fix for ContentWorker at OFBIZ-6669. For that I have added
> owasp-java-html-sanitizer-r239.jar and put a "content.sanitize=true"
> property in content.properties with some explanations. The reason I put
> this property is because the sanitizer does some (safe) changes which might
> be unwanted in a context where you are "sure" no one can inject/exploit
> your DB, see the JIra issue for details. Note that this does not affect the
> *ContentWrapper.java classes where we use OWASP encoding and not sanitizer.
> The reason we need the sanitizer here is because we are no only handling
> content but also HTML code...
> 
>
>
> Added:
>
> ofbiz/branches/release14.12/framework/base/lib/owasp-java-html-sanitizer-r239.jar
>   - copied unchanged from r1708274,
> ofbiz/trunk/framework/base/lib/owasp-java-html-sanitizer-r239.jar
> Modified:
> ofbiz/branches/release14.12/   (props changed)
> ofbiz/branches/release14.12/.classpath
> ofbiz/branches/release14.12/LICENSE
>
> ofbiz/branches/release14.12/applications/content/config/content.properties
>
> ofbiz/branches/release14.12/applications/content/src/org/ofbiz/content/content/ContentWorker.java
>
> ofbiz/branches/release14.12/specialpurpose/cmssite/data/CmsSiteDemoData.xml
>
> Propchange: ofbiz/branches/release14.12/
>
> --
> --- svn:mergeinfo (original)
> +++ svn:mergeinfo Tue Oct 13 00:45:31 2015
> @@ -8,4 +8,4 @@
>  /ofbiz/branches/json-integration-refactoring:1634077-1635900
>  /ofbiz/branches/multitenant20100310:921280-927264
>  /ofbiz/branches/release13.07:1547657
>
> -/ofbiz/trunk:1649072,1649083-1649084,1649086,1649090,1649096,1649230,1649238-1649239,1649248,1649272,1649275,1649280-1649281,1649283,1649285-1649286,1649291,1649329,1649331,1649384,1649393,1649666,1649742,1650240,1650348,1650357,1650583,1650642,1650678,1650821,1650882,1650887,1650938,1651593,1652312,1652361,1652638,1652641,1652672,1652688,1652706,1652725,1652731,1652739,1652852,1653248,1653296,1653456,1653597,1653614,1654175,1654273,1654509,1654670,1654672-1654673,1654683-1654684,1654824,1655046,1655668,1655979,1656014,1656185,1656198,1656445,1656983,1657323,1657506-1657507,1657514,1657714,1657790,1657848,1658364,1658662,1658882,1659224,1659965,1660031,1660053,1660389,1660444,1660579,1661303,1661328,1661760,1661778,1661853,1661862,1661873,1661940,1661951,1661977,1662119-1662120,1662361,1662500,1662812,1662919,1663202,1663912,1663979,1664602,1664604,1664696,1665154,1665162,1665535,1666404,1666511,133,1666836,1666939,1666949,1666958,1667055,1667253,1667483,1667492,1667774,1668207,
>
>  
> 1668214,1668236,1668246,1668258,1668263,1668265,1668270,1668277,1668314,1668657,1669317,1669588,1672427,1672430,1672846,1672853,1672856,1672862,1672873,1673764,1674447,1674464,1674491,1674496,1674908,1676674,1677123,1677597,1677769-160,1678294,1678882,1678911,1679689,1679697,1679709,1679720,1679728,1679732,1679957,1680155,1680288,1680304,1680671,1680675,1680733,1680840,1680881,1682272,1682295,1682415,1682633,1683998,1684094,1686360,1686536,1686545,1686566,1686569,1686574,1686583,1686635,1686651,1686970,1687427,1688772,1690086,1690581,1692357,1692458,1692600,1692604,1693393

Re: svn commit: r1708275 - in /ofbiz/branches/release14.12: ./ applications/content/config/ applications/content/src/org/ofbiz/content/content/ framework/base/lib/ specialpurpose/cmssite/data/

2015-10-13 Thread Deepak Dixit
Thanks Jacques.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Tue, Oct 13, 2015 at 10:58 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> It's fixed at revision: 1708471
>
> Jacques
>
>
> Le 13/10/2015 17:36, Jacques Le Roux a écrit :
>
>> Hi Deepak
>>
>> Indeed something is not working in R14.12, I don't see any missing
>> dependencies (it compiles w/o issues), I'll have a look, thanks!
>>
>>
>> Jacques
>>
>> Le 13/10/2015 13:50, Deepak Dixit a écrit :
>>
>>> Hi Jacques,
>>>
>>> I am getting following exception on 14.12:
>>>
>>> {code}
>>>   java.lang.NoClassDefFoundError: Could not initialize class
>>> org.owasp.html.Sanitizers
>>>  [java] at
>>>
>>> org.ofbiz.content.content.ContentWorker.renderContentAsText(ContentWorker.java:354)
>>> ~[ofbiz-content.jar:?]
>>>  [java] at
>>>
>>> org.ofbiz.content.content.ContentMapFacade.renderThis(ContentMapFacade.java:343)
>>> ~[ofbiz-content.jar:?]
>>>  [java] at
>>>
>>> org.ofbiz.content.content.ContentMapFacade.toString(ContentMapFacade.java:355)
>>> ~[ofbiz-content.jar:?]
>>>  [java] at
>>> freemarker.ext.beans.StringModel.getAsString(StringModel.java:61)
>>> ~[freemarker-2.3.22.jar:2.3.22]
>>>  [java] at freemarker.core.EvalUtil.modelToString(EvalUtil.java:55)
>>> ~[freemarker-2.3.22.jar:2.3.22]
>>>  [java] at
>>> freemarker.core.EvalUtil.coerceModelToString(EvalUtil.java:340)
>>> ~[freemarker-2.3.22.jar:2.3.22]
>>>
>>> {code}
>>>
>>> Thanks & Regards
>>> --
>>> Deepak Dixit
>>> www.hotwaxsystems.com
>>>
>>> On Tue, Oct 13, 2015 at 6:15 AM,  wrote:
>>>
>>> Author: jleroux
>>>> Date: Tue Oct 13 00:45:31 2015
>>>> New Revision: 1708275
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1708275&view=rev
>>>> Log:
>>>> "Applied fix from trunk for revision: 1708274  " (handled conflicts on
>>>> .classpath by hand)
>>>> 
>>>> r1708274 | jleroux | 2015-10-13 02:40:47 +0200 (mar. 13 oct. 2015) | 1
>>>> ligne
>>>>
>>>> Fix for ContentWorker at OFBIZ-6669. For that I have added
>>>> owasp-java-html-sanitizer-r239.jar and put a "content.sanitize=true"
>>>> property in content.properties with some explanations. The reason I put
>>>> this property is because the sanitizer does some (safe) changes which
>>>> might
>>>> be unwanted in a context where you are "sure" no one can inject/exploit
>>>> your DB, see the JIra issue for details. Note that this does not affect
>>>> the
>>>> *ContentWrapper.java classes where we use OWASP encoding and not
>>>> sanitizer.
>>>> The reason we need the sanitizer here is because we are no only handling
>>>> content but also HTML code...
>>>> 
>>>>
>>>>
>>>> Added:
>>>>
>>>>
>>>> ofbiz/branches/release14.12/framework/base/lib/owasp-java-html-sanitizer-r239.jar
>>>>- copied unchanged from r1708274,
>>>> ofbiz/trunk/framework/base/lib/owasp-java-html-sanitizer-r239.jar
>>>> Modified:
>>>>  ofbiz/branches/release14.12/   (props changed)
>>>>  ofbiz/branches/release14.12/.classpath
>>>>  ofbiz/branches/release14.12/LICENSE
>>>>
>>>>
>>>> ofbiz/branches/release14.12/applications/content/config/content.properties
>>>>
>>>>
>>>> ofbiz/branches/release14.12/applications/content/src/org/ofbiz/content/content/ContentWorker.java
>>>>
>>>>
>>>> ofbiz/branches/release14.12/specialpurpose/cmssite/data/CmsSiteDemoData.xml
>>>>
>>>> Propchange: ofbiz/branches/release14.12/
>>>>
>>>>
>>>> --
>>>> --- svn:mergeinfo (original)
>>>> +++ svn:mergeinfo Tue Oct 13 00:45:31 2015
>>>> @@ -8,4 +8,4 @@
>>>>   /ofbiz/branches/json-integration-re

Re: svn commit: r1710178 - in /ofbiz/trunk: applications/accounting/entitydef/entitymodel.xml specialpurpose/assetmaint/entitydef/entitymodel.xml

2015-10-25 Thread Deepak Dixit
Thanks Pierre, but this is used in FixedAssetServices.xml, and its an view
entity so I think there is no harm to put it in org.ofbiz.accounting.fixedasset
package.

+1 Jacques.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Sat, Oct 24, 2015 at 7:02 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> This also reminds me Jacopo's ideas about having the all the data model in
> a component apart on which all other components would depend...
>
> Jacques
>
>
> Le 24/10/2015 14:52, Jacques Le Roux a écrit :
>
>> Also
>> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies#comment-61325557
>>
>> Jacques
>>
>> Le 24/10/2015 09:47, Pierre Smits a écrit :
>>
>>> Deepak,
>>>
>>> This is a bad addition as it doesn't belong in accounting. Please keep it
>>> in the asset management component.
>>>
>>> Best regards,
>>>
>>> Pierre
>>>
>>> Pierre Smits
>>>
>>> *OFBiz Extensions Marketplace*
>>> http://oem.ofbizci.net/oci-2/
>>>
>>> On Fri, Oct 23, 2015 at 1:35 PM,  wrote:
>>>
>>> Author: deepak
>>>> Date: Fri Oct 23 11:35:34 2015
>>>> New Revision: 1710178
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1710178&view=rev
>>>> Log:
>>>> (OFBIZ-6687) Moved FixedAssetMaintWorkEffort view entity from
>>>> specialpurpose/assetmaint to accounting.
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
>>>> ofbiz/trunk/specialpurpose/assetmaint/entitydef/entitymodel.xml
>>>>
>>>> Modified: ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
>>>> URL:
>>>>
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml?rev=1710178&r1=1710177&r2=1710178&view=diff
>>>>
>>>>
>>>> ==
>>>> --- ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml
>>>> (original)
>>>> +++ ofbiz/trunk/applications/accounting/entitydef/entitymodel.xml Fri
>>>> Oct
>>>> 23 11:35:34 2015
>>>> @@ -1134,6 +1134,23 @@ under the License.
>>>>   
>>>>   
>>>> 
>>>> +>>> package-name="org.ofbiz.accounting.fixedasset"
>>>> +title="FixedAssetMaint and WorkEffort View Entity">
>>>> +
>>>> +>>> entity-name="FixedAssetMaint"/>
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +
>>>> +>>> rel-field-name="workEffortId"/>
>>>> +
>>>> +
>>>>
>>>> 
>>>> 
>>>>
>>>> Modified:
>>>> ofbiz/trunk/specialpurpose/assetmaint/entitydef/entitymodel.xml
>>>> URL:
>>>>
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/assetmaint/entitydef/entitymodel.xml?rev=1710178&r1=1710177&r2=1710178&view=diff
>>>>
>>>>
>>>> ==
>>>> --- ofbiz/trunk/specialpurpose/assetmaint/entitydef/entitymodel.xml
>>>> (original)
>>>> +++ ofbiz/trunk/specialpurpose/assetmaint/entitydef/entitymodel.xml Fri
>>>> Oct 23 11:35:34 2015
>>>> @@ -38,23 +38,6 @@
>>>>   
>>>>   
>>>>   
>>>> ->>> package-name="org.ofbiz.specialpurpose.assetmaint"
>>>> -title="FixedAssetMaint and WorkEffort View Entity">
>>>> -
>>>> ->>> entity-name="FixedAssetMaint"/>
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> -
>>>> ->>> rel-field-name="workEffortId"/>
>>>> -
>>>> -
>>>>   >>> entity-name="FixedAssetMaintWorkEffortAndPartyAssignment"
>>>>   package-name="org.ofbiz.specialpurpose.assetmaint"
>>>>   title="View of FixedAssetMaint and WorkEffort and
>>>> WorkEffortPartyAssignment">
>>>>
>>>>
>>>>
>>>>
>>


Re: svn commit: r1710527 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/renderer/ src/org/ofbiz/widget/renderer/macro/ templates/

2015-10-26 Thread Deepak Dixit
Hi Jacques,

Build fails due to this commit.

{code}

FoFormRenderer is not abstract and does not override abstract method
renderFormatHeaderClose(Appendable,Map,ModelForm) in
FormStringRenderer

  [javac18] public class FoFormRenderer extends HtmlWidgetRenderer
implements FormStringRenderer

{code}

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Mon, Oct 26, 2015 at 1:45 PM,  wrote:

> Author: jleroux
> Date: Mon Oct 26 08:15:45 2015
> New Revision: 1710527
>
> URL: http://svn.apache.org/viewvc?rev=1710527&view=rev
> Log:
> A patch from Christian Carlow for "FOP rendered list form widgets do not
> work for fields with postition > 0"
> https://issues.apache.org/jira/browse/OFBIZ-6354
>
> It doesn't work because of the way the renderFormatHeaderRowOpen is called
> causes the FOP renderer to create more than one .
>
> This patch adds renderFormatHeaderOpen and renderFormatHeaderClose to
> separately generate  for FOP and  for html.
>
> Modified:
>
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormRenderer.java
>
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormStringRenderer.java
>
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> ofbiz/trunk/framework/widget/templates/foFormMacroLibrary.ftl
> ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
>
> Modified:
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormRenderer.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormRenderer.java?rev=1710527&r1=1710526&r2=1710527&view=diff
>
> ==
> ---
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormRenderer.java
> (original)
> +++
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormRenderer.java
> Mon Oct 26 08:15:45 2015
> @@ -394,6 +394,7 @@ public class FormRenderer {
>  // ===
>  // Rendering
>  // ===
> +formStringRenderer.renderFormatHeaderOpen(writer, context,
> modelForm);
>  for (Map> listsMap :
> fieldRowsByPosition) {
>  List innerDisplayHyperlinkFieldsBegin =
> listsMap.get("displayBefore");
>  List innerFormFields =
> listsMap.get("inputFields");
> @@ -492,6 +493,7 @@ public class FormRenderer {
>  formStringRenderer.renderFormatHeaderRowClose(writer,
> context, modelForm);
>  }
>  }
> +formStringRenderer.renderFormatHeaderClose(writer, context,
> modelForm);
>
>  return maxNumOfColumns;
>  }
>
> Modified:
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormStringRenderer.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormStringRenderer.java?rev=1710527&r1=1710526&r2=1710527&view=diff
>
> ==
> ---
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormStringRenderer.java
> (original)
> +++
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/FormStringRenderer.java
> Mon Oct 26 08:15:45 2015
> @@ -59,6 +59,8 @@ public interface FormStringRenderer {
>
>  public void renderFormatHeaderRowOpen(Appendable writer, Map Object> context, ModelForm modelForm) throws IOException;
>  public void renderFormatHeaderRowClose(Appendable writer, Map Object> context, ModelForm modelForm) throws IOException;
> +public void renderFormatHeaderOpen(Appendable writer, Map Object> context, ModelForm modelForm) throws IOException;
> +public void renderFormatHeaderClose(Appendable writer, Map Object> context, ModelForm modelForm) throws IOException;
>  public void renderFormatHeaderRowCellOpen(Appendable writer,
> Map context, ModelForm modelForm, ModelFormField
> modelFormField, int positionSpan) throws IOException;
>  public void renderFormatHeaderRowCellClose(Appendable writer,
> Map context, ModelForm modelForm, ModelFormField
> modelFormField) throws IOException;
>
>
> Modified:
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java?rev=1710527&r1=1710526&r2=1710527&view=diff
>
> ==
> ---
> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> (original)
> 

Re: svn commit: r1715506 - in /ofbiz/trunk/specialpurpose/ecommerce/webapp: ecomclone/WEB-INF/web.xml ecommerce/WEB-INF/web.xml ecomseo/WEB-INF/web.xml

2015-11-23 Thread Deepak Dixit
Thanks Jacques and Pierre for reporting the issue, I;ll dig around this and
try to find out actual cause.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Tue, Nov 24, 2015 at 11:41 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> I reverted r1715506 at revision: 1716036. The issues I crossed:
>
> Get to localhost:8080/ecommerce/control/main
> Add a product, instead of stating on the main page you get to the cart
> page despite having the "Always View Cart After Adding An Item. " not
> checked. Then eg:
>
> Scenario 1
> Use the Recalculate option at top => You get "Your Shopping Cart Empty"
>
> Scenario 2
> Use the  Continue Shopping option at top => your cart is empty
>
> Scenario 3
> Use the checkout link on top
> Login with DemoCustomer
> Use the Quick Checkout option
> Use the main link on top => your cart is empty
>
> Jacques
> PS: the OFBIZ-VM is down, so no demos are accessible yet, I have asked
> infra to restart the VM...
>
>
> Le 23/11/2015 23:17, Jacques Le Roux a écrit :
>
>> I have also an issue with DemoCustomer, not sure it's the same than
>> Pierre's, but it fails
>>
>> Jacques
>>
>> Le 23/11/2015 20:52, Pierre Smits a écrit :
>>
>>> This commit breaks how the ecommerce component works. When I create a new
>>> user, and subsequently add a product to the cart, the shop returns to an
>>> unknow (anonymous) user and the cart doesn't show the products added.
>>>
>>>
>>> Best regards,
>>>
>>>
>>>
>>> Pierre Smits
>>>
>>> *OFBiz Extensions Marketplace*
>>> http://oem.ofbizci.net/oci-2/
>>>
>>> On Sat, Nov 21, 2015 at 1:42 PM,  wrote:
>>>
>>> Author: deepak
>>>> Date: Sat Nov 21 12:42:30 2015
>>>> New Revision: 1715506
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1715506&view=rev
>>>> Log:
>>>> (OFBIZ-6655) Applied patch from jira issue.
>>>> 
>>>> - Added session cookies config for ecommerce,ecomseo and ecomclone
>>>> web.xml.
>>>> - Used web-app 3.0 version for web-app
>>>> - Re-arrange description and display-name attribute as per the web-app
>>>> structure.
>>>>
>>>> Thanks Rahul for your contribution.
>>>>
>>>> Modified:
>>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecomclone/WEB-INF/web.xml
>>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/web.xml
>>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecomseo/WEB-INF/web.xml
>>>>
>>>> Modified:
>>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecomclone/WEB-INF/web.xml
>>>> URL:
>>>>
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecomclone/WEB-INF/web.xml?rev=1715506&r1=1715505&r2=1715506&view=diff
>>>>
>>>>
>>>> ==
>>>> ---
>>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecomclone/WEB-INF/web.xml
>>>> (original)
>>>> +++
>>>> ofbiz/trunk/specialpurpose/ecommerce/webapp/ecomclone/WEB-INF/web.xml
>>>> Sat Nov 21 12:42:30 2015
>>>> @@ -1,5 +1,4 @@
>>>>   
>>>> ->>> Application
>>>> 2.3//EN" "http://java.sun.com/dtd/web-app_2_3.dtd";>
>>>>
>>>>   
>>>>
>>>> -
>>>> +>>> + xmlns="http://java.sun.com/xml/ns/javaee";
>>>> + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>>>> + xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
>>>> +
>>>> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
>>>>   Apache OFBiz - demostore
>>>>   Cloned Demo Store for the Apache OFBiz
>>>> Project
>>>>
>>>>   
>>>> +A unique ID used to look up the WebSite
>>>> entity
>>>>   webSiteId
>>>>   WebStoreClone
>>>> -A unique ID used to look up the WebSite
>>>> entity
>>>>   
>>>>   
>>>> +A unique name used to identify/recognize the local
>>>> dispatcher for the Service Engine
>>>> localDispatcherName
>>>>

Re: Creating the 15.12 release branch

2015-12-29 Thread Deepak Dixit
+1 Jacopo,

IMO It would be good to have 15.12 branch (time based release
<https://wiki.ubuntu.com/TimeBasedReleases>).

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Tue, Dec 29, 2015 at 10:49 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> Should we create a 15.12 branch before the end of the year?
> I don't have a strong opinion but it may be nice to create since:
> 1) the 12.04 is approaching the end of life and we usually keep 3 live
> branches
> 2) several changes have been introduced since the last (14.12) branch
> 3) it is nice to avoid skipping a year
>
> What do you think?
>
> Jacopo
>


Re: Creating the 15.12 release branch

2015-12-30 Thread Deepak Dixit
I think ecommerce broken due to r1719939, I reverted it and tested it
locally and its working fine.
I am testing it more and if its working properly then I'll revert r1719939.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Wed, Dec 30, 2015 at 4:54 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> That's not blocking, once freezed we patch releases branches
>
> Jacques
>
>
> Le 30/12/2015 06:28, Vyom Jain a écrit :
>
>> Hi Jacopo,
>>
>> I've been doing random tests, the major issue that has been noticed &
>> reported is OFBIZ-6781 [https://issues.apache.org/jira/browse/OFBIZ-6781
>> <https://issues.apache.org/jira/browse/OFBIZ-5565>].
>>
>> Also, I think I did face some issues (after fresh checkout and no local
>> changes) when adding products to cart in the ecommerce application.
>>
>> --
>> Vyom
>>
>> On 29 December 2015 at 22:49, Jacopo Cappellato <
>> jacopo.cappell...@hotwaxsystems.com> wrote:
>>
>> Should we create a 15.12 branch before the end of the year?
>>> I don't have a strong opinion but it may be nice to create since:
>>> 1) the 12.04 is approaching the end of life and we usually keep 3 live
>>> branches
>>> 2) several changes have been introduced since the last (14.12) branch
>>> 3) it is nice to avoid skipping a year
>>>
>>> What do you think?
>>>
>>> Jacopo
>>>
>>>


Re: Creating the 15.12 release branch

2015-12-30 Thread Deepak Dixit
Hi Vyom,

I reverted the suspected commit (r1719762) at r#1722379. I tested it
locally and ecommerce working fine after reverting it.

Could you please test it with ant clean-all?


Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Wed, Dec 30, 2015 at 10:58 AM, Vyom Jain  wrote:

> Hi Jacopo,
>
> I've been doing random tests, the major issue that has been noticed &
> reported is OFBIZ-6781 [https://issues.apache.org/jira/browse/OFBIZ-6781
> <https://issues.apache.org/jira/browse/OFBIZ-5565>].
>
> Also, I think I did face some issues (after fresh checkout and no local
> changes) when adding products to cart in the ecommerce application.
>
> --
> Vyom
>
> On 29 December 2015 at 22:49, Jacopo Cappellato <
> jacopo.cappell...@hotwaxsystems.com> wrote:
>
> > Should we create a 15.12 branch before the end of the year?
> > I don't have a strong opinion but it may be nice to create since:
> > 1) the 12.04 is approaching the end of life and we usually keep 3 live
> > branches
> > 2) several changes have been introduced since the last (14.12) branch
> > 3) it is nice to avoid skipping a year
> >
> > What do you think?
> >
> > Jacopo
> >
>


demo trunk is broken

2014-11-20 Thread Deepak Dixit
Demo trunk is not accessible. Its throwing error
"java.lang.IllegalArgumentException:
Template location is empty (Template location is empty)" . I think data
load failed on demo trunk instance.


Thanks & Regards
--
Deepak Dixit
www.hotwaxmedia.com


Re: demo trunk is broken

2014-11-21 Thread Deepak Dixit
Thanks Jacques..

Thanks & Regards
--
Deepak Dixit
www.hotwaxmedia.com

On Thu, Nov 20, 2014 at 6:02 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks for report Deepak,
>
> It's fixed now, see r1640727
>
> Damn I hate when Buildbot is not reporting.
>
> Jacques
>
> Le 20/11/2014 12:28, Deepak Dixit a écrit :
>
>  Demo trunk is not accessible. Its throwing error
>> "java.lang.IllegalArgumentException:
>> Template location is empty (Template location is empty)" . I think data
>> load failed on demo trunk instance.
>>
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> www.hotwaxmedia.com
>>
>>


<    1   2   3   4   5   6   7   8   9   10   >